SemaChecking.cpp revision e3fbbe9a486c4c8709726d8c79af33140eb02e53
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 1659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 17199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 18384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 19c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 2055fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/EvaluatedExprVisitor.h" 21be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h" 222324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 237ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 24f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Analysis/Analyses/FormatString.h" 273f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose#include "clang/Basic/CharInfo.h" 2855fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetBuiltins.h" 2955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetInfo.h" 3059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 3155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h" 3255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Lookup.h" 3355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/ScopeInfo.h" 3455fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Sema.h" 35f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 3755fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "llvm/ADT/SmallString.h" 38cb5620c9b213f4bd323912159fdddda35e258a14Dmitri Gribenko#include "llvm/Support/ConvertUTF.h" 393bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 40a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 42781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4608f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie PP.getLangOpts(), PP.getTargetInfo()); 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 508e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 70e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer 71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal. 72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (checkArgCount(S, TheCall, 2)) 74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // First argument should be an integer. 77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *ValArg = TheCall->getArg(0); 78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge QualType Ty = ValArg->getType(); 79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (!Ty->isIntegerType()) { 80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << ValArg->getSourceRange(); 82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge } 84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // Second argument should be a constant string. 86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 8877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 89e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << StrArg->getSourceRange(); 9177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 93e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge TheCall->setType(Ty); 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 985154dce6388e3aaa445467030df7a45ed1211abeRichard Smith/// Check that the argument to __builtin_addressof is a glvalue, and set the 995154dce6388e3aaa445467030df7a45ed1211abeRichard Smith/// result type to the corresponding pointer type. 1005154dce6388e3aaa445467030df7a45ed1211abeRichard Smithstatic bool SemaBuiltinAddressof(Sema &S, CallExpr *TheCall) { 1015154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (checkArgCount(S, TheCall, 1)) 1025154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return true; 1035154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 1045154dce6388e3aaa445467030df7a45ed1211abeRichard Smith ExprResult Arg(S.Owned(TheCall->getArg(0))); 1055154dce6388e3aaa445467030df7a45ed1211abeRichard Smith QualType ResultType = S.CheckAddressOfOperand(Arg, TheCall->getLocStart()); 1065154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (ResultType.isNull()) 1075154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return true; 1085154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 1095154dce6388e3aaa445467030df7a45ed1211abeRichard Smith TheCall->setArg(0, Arg.take()); 1105154dce6388e3aaa445467030df7a45ed1211abeRichard Smith TheCall->setType(ResultType); 1115154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return false; 1125154dce6388e3aaa445467030df7a45ed1211abeRichard Smith} 1135154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 11460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 115d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 11660d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1172def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 121946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 122946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 123946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 124946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 125946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 126946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 127946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 128946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 129946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 130946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 131946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 132946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 133946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 134946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 135946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 136d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 13730ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 138925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 140690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1410eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 142d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 14349ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 14430ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 147d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1481b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1491b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1501b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1511b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1521b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1531b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 156d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 157e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 158e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 159e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 160e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1619ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1629ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1639ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1649ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1659ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1663b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1679ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1689ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 169d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1710eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1720eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1734493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1740eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1750eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 176d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 177d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1780eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1790eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 180d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 181d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 182d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 183d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 184d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1898e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 19075c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1918e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1928e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 19375c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 2005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 2065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 2125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 2185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 2245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 2305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 257a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 263a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 269a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 270a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 271a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 273a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 274a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 275a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 276a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 277a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 27823aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 279a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 280a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 281a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 282a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 283a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 2843fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaBuiltinAtomicOverloaded(TheCallResult); 285ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS) 286ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 287ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Builtin::BI##ID: \ 2883fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 289ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def" 29077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 291e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (SemaBuiltinAnnotation(*this, TheCall)) 29277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 29377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 2945154dce6388e3aaa445467030df7a45ed1211abeRichard Smith case Builtin::BI__builtin_addressof: 2955154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (SemaBuiltinAddressof(*this, TheCall)) 2965154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return ExprError(); 2975154dce6388e3aaa445467030df7a45ed1211abeRichard Smith break; 29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 30126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 30226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 303bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 30526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 30626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 30726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 30826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 309fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips: 310fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mipsel: 311fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64: 312fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64el: 313fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 314fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return ExprError(); 315fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan break; 31626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 31726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 31826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 31926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 32026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 3213fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 32226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 32326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 32461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 32561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 326da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 327da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 328da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 329da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 330da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 331da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 332da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 333da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 334da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 335da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 336da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 337da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 338da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 339da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 340da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 341da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 342da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 343da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 344da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 34561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3467530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 34761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 34861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3516f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3526f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3556f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3566f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3576f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3586f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3596f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3606f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3626f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3636f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3646f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3656f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3666f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3676f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3686f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3696f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3717530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3736f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 37409df2b066221d869f17f4b5762405f111a65f983Tim Northoverbool Sema::CheckARMBuiltinExclusiveCall(unsigned BuiltinID, CallExpr *TheCall) { 37509df2b066221d869f17f4b5762405f111a65f983Tim Northover assert((BuiltinID == ARM::BI__builtin_arm_ldrex || 37609df2b066221d869f17f4b5762405f111a65f983Tim Northover BuiltinID == ARM::BI__builtin_arm_strex) && 37709df2b066221d869f17f4b5762405f111a65f983Tim Northover "unexpected ARM builtin"); 37809df2b066221d869f17f4b5762405f111a65f983Tim Northover bool IsLdrex = BuiltinID == ARM::BI__builtin_arm_ldrex; 37909df2b066221d869f17f4b5762405f111a65f983Tim Northover 38009df2b066221d869f17f4b5762405f111a65f983Tim Northover DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 38109df2b066221d869f17f4b5762405f111a65f983Tim Northover 38209df2b066221d869f17f4b5762405f111a65f983Tim Northover // Ensure that we have the proper number of arguments. 38309df2b066221d869f17f4b5762405f111a65f983Tim Northover if (checkArgCount(*this, TheCall, IsLdrex ? 1 : 2)) 38409df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 38509df2b066221d869f17f4b5762405f111a65f983Tim Northover 38609df2b066221d869f17f4b5762405f111a65f983Tim Northover // Inspect the pointer argument of the atomic builtin. This should always be 38709df2b066221d869f17f4b5762405f111a65f983Tim Northover // a pointer type, whose element is an integral scalar or pointer type. 38809df2b066221d869f17f4b5762405f111a65f983Tim Northover // Because it is a pointer type, we don't have to worry about any implicit 38909df2b066221d869f17f4b5762405f111a65f983Tim Northover // casts here. 39009df2b066221d869f17f4b5762405f111a65f983Tim Northover Expr *PointerArg = TheCall->getArg(IsLdrex ? 0 : 1); 39109df2b066221d869f17f4b5762405f111a65f983Tim Northover ExprResult PointerArgRes = DefaultFunctionArrayLvalueConversion(PointerArg); 39209df2b066221d869f17f4b5762405f111a65f983Tim Northover if (PointerArgRes.isInvalid()) 39309df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 39409df2b066221d869f17f4b5762405f111a65f983Tim Northover PointerArg = PointerArgRes.take(); 39509df2b066221d869f17f4b5762405f111a65f983Tim Northover 39609df2b066221d869f17f4b5762405f111a65f983Tim Northover const PointerType *pointerType = PointerArg->getType()->getAs<PointerType>(); 39709df2b066221d869f17f4b5762405f111a65f983Tim Northover if (!pointerType) { 39809df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 39909df2b066221d869f17f4b5762405f111a65f983Tim Northover << PointerArg->getType() << PointerArg->getSourceRange(); 40009df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 40109df2b066221d869f17f4b5762405f111a65f983Tim Northover } 40209df2b066221d869f17f4b5762405f111a65f983Tim Northover 40309df2b066221d869f17f4b5762405f111a65f983Tim Northover // ldrex takes a "const volatile T*" and strex takes a "volatile T*". Our next 40409df2b066221d869f17f4b5762405f111a65f983Tim Northover // task is to insert the appropriate casts into the AST. First work out just 40509df2b066221d869f17f4b5762405f111a65f983Tim Northover // what the appropriate type is. 40609df2b066221d869f17f4b5762405f111a65f983Tim Northover QualType ValType = pointerType->getPointeeType(); 40709df2b066221d869f17f4b5762405f111a65f983Tim Northover QualType AddrType = ValType.getUnqualifiedType().withVolatile(); 40809df2b066221d869f17f4b5762405f111a65f983Tim Northover if (IsLdrex) 40909df2b066221d869f17f4b5762405f111a65f983Tim Northover AddrType.addConst(); 41009df2b066221d869f17f4b5762405f111a65f983Tim Northover 41109df2b066221d869f17f4b5762405f111a65f983Tim Northover // Issue a warning if the cast is dodgy. 41209df2b066221d869f17f4b5762405f111a65f983Tim Northover CastKind CastNeeded = CK_NoOp; 41309df2b066221d869f17f4b5762405f111a65f983Tim Northover if (!AddrType.isAtLeastAsQualifiedAs(ValType)) { 41409df2b066221d869f17f4b5762405f111a65f983Tim Northover CastNeeded = CK_BitCast; 41509df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::ext_typecheck_convert_discards_qualifiers) 41609df2b066221d869f17f4b5762405f111a65f983Tim Northover << PointerArg->getType() 41709df2b066221d869f17f4b5762405f111a65f983Tim Northover << Context.getPointerType(AddrType) 41809df2b066221d869f17f4b5762405f111a65f983Tim Northover << AA_Passing << PointerArg->getSourceRange(); 41909df2b066221d869f17f4b5762405f111a65f983Tim Northover } 42009df2b066221d869f17f4b5762405f111a65f983Tim Northover 42109df2b066221d869f17f4b5762405f111a65f983Tim Northover // Finally, do the cast and replace the argument with the corrected version. 42209df2b066221d869f17f4b5762405f111a65f983Tim Northover AddrType = Context.getPointerType(AddrType); 42309df2b066221d869f17f4b5762405f111a65f983Tim Northover PointerArgRes = ImpCastExprToType(PointerArg, AddrType, CastNeeded); 42409df2b066221d869f17f4b5762405f111a65f983Tim Northover if (PointerArgRes.isInvalid()) 42509df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 42609df2b066221d869f17f4b5762405f111a65f983Tim Northover PointerArg = PointerArgRes.take(); 42709df2b066221d869f17f4b5762405f111a65f983Tim Northover 42809df2b066221d869f17f4b5762405f111a65f983Tim Northover TheCall->setArg(IsLdrex ? 0 : 1, PointerArg); 42909df2b066221d869f17f4b5762405f111a65f983Tim Northover 43009df2b066221d869f17f4b5762405f111a65f983Tim Northover // In general, we allow ints, floats and pointers to be loaded and stored. 43109df2b066221d869f17f4b5762405f111a65f983Tim Northover if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 43209df2b066221d869f17f4b5762405f111a65f983Tim Northover !ValType->isBlockPointerType() && !ValType->isFloatingType()) { 43309df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intfltptr) 43409df2b066221d869f17f4b5762405f111a65f983Tim Northover << PointerArg->getType() << PointerArg->getSourceRange(); 43509df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 43609df2b066221d869f17f4b5762405f111a65f983Tim Northover } 43709df2b066221d869f17f4b5762405f111a65f983Tim Northover 43809df2b066221d869f17f4b5762405f111a65f983Tim Northover // But ARM doesn't have instructions to deal with 128-bit versions. 43909df2b066221d869f17f4b5762405f111a65f983Tim Northover if (Context.getTypeSize(ValType) > 64) { 44009df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::err_atomic_exclusive_builtin_pointer_size) 44109df2b066221d869f17f4b5762405f111a65f983Tim Northover << PointerArg->getType() << PointerArg->getSourceRange(); 44209df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 44309df2b066221d869f17f4b5762405f111a65f983Tim Northover } 44409df2b066221d869f17f4b5762405f111a65f983Tim Northover 44509df2b066221d869f17f4b5762405f111a65f983Tim Northover switch (ValType.getObjCLifetime()) { 44609df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_None: 44709df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_ExplicitNone: 44809df2b066221d869f17f4b5762405f111a65f983Tim Northover // okay 44909df2b066221d869f17f4b5762405f111a65f983Tim Northover break; 45009df2b066221d869f17f4b5762405f111a65f983Tim Northover 45109df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_Weak: 45209df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_Strong: 45309df2b066221d869f17f4b5762405f111a65f983Tim Northover case Qualifiers::OCL_Autoreleasing: 45409df2b066221d869f17f4b5762405f111a65f983Tim Northover Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 45509df2b066221d869f17f4b5762405f111a65f983Tim Northover << ValType << PointerArg->getSourceRange(); 45609df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 45709df2b066221d869f17f4b5762405f111a65f983Tim Northover } 45809df2b066221d869f17f4b5762405f111a65f983Tim Northover 45909df2b066221d869f17f4b5762405f111a65f983Tim Northover 46009df2b066221d869f17f4b5762405f111a65f983Tim Northover if (IsLdrex) { 46109df2b066221d869f17f4b5762405f111a65f983Tim Northover TheCall->setType(ValType); 46209df2b066221d869f17f4b5762405f111a65f983Tim Northover return false; 46309df2b066221d869f17f4b5762405f111a65f983Tim Northover } 46409df2b066221d869f17f4b5762405f111a65f983Tim Northover 46509df2b066221d869f17f4b5762405f111a65f983Tim Northover // Initialize the argument to be stored. 46609df2b066221d869f17f4b5762405f111a65f983Tim Northover ExprResult ValArg = TheCall->getArg(0); 46709df2b066221d869f17f4b5762405f111a65f983Tim Northover InitializedEntity Entity = InitializedEntity::InitializeParameter( 46809df2b066221d869f17f4b5762405f111a65f983Tim Northover Context, ValType, /*consume*/ false); 46909df2b066221d869f17f4b5762405f111a65f983Tim Northover ValArg = PerformCopyInitialization(Entity, SourceLocation(), ValArg); 47009df2b066221d869f17f4b5762405f111a65f983Tim Northover if (ValArg.isInvalid()) 47109df2b066221d869f17f4b5762405f111a65f983Tim Northover return true; 47209df2b066221d869f17f4b5762405f111a65f983Tim Northover 47309df2b066221d869f17f4b5762405f111a65f983Tim Northover TheCall->setArg(0, ValArg.get()); 47409df2b066221d869f17f4b5762405f111a65f983Tim Northover return false; 47509df2b066221d869f17f4b5762405f111a65f983Tim Northover} 47609df2b066221d869f17f4b5762405f111a65f983Tim Northover 47726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 4781c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 4791c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 48009df2b066221d869f17f4b5762405f111a65f983Tim Northover if (BuiltinID == ARM::BI__builtin_arm_ldrex || 48109df2b066221d869f17f4b5762405f111a65f983Tim Northover BuiltinID == ARM::BI__builtin_arm_strex) { 48209df2b066221d869f17f4b5762405f111a65f983Tim Northover return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall); 48309df2b066221d869f17f4b5762405f111a65f983Tim Northover } 48409df2b066221d869f17f4b5762405f111a65f983Tim Northover 485f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith uint64_t mask = 0; 48661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 4874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 4886f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 4891c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 490a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 491a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 492a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 4931c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 4941c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 4950d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 4960d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 4976f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 4980d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 4996f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 5000d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 5010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 502da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 503f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith if ((TV > 63) || (mask & (1ULL << TV)) == 0) 5040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 5056f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 5066f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 5076f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 5084648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 5096f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 5104648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 5114648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 5124648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 5134648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 5144648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 5154648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 5164648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 5174648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 5184648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 5194648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 5204648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 5214648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 5224648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 5234648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 5244648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 5254648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 5260d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 5271c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 5280d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 5290d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 53061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 5310d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 5320d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 533bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 534bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 53599c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 53699c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 537a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 538a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 539a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 5400d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 5410d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 542592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 543592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 544592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(i)->isValueDependent()) 545592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 546592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 54761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 5480d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 5490d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 5500d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 55161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 5520d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 55361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 5540d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 555476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 5560d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 55799c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 55826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 559d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 560d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 561fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 562fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned i = 0, l = 0, u = 0; 563fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan switch (BuiltinID) { 564fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan default: return false; 565fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 566fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 567be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 568be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 569be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 570be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 571be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 572fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan }; 573fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 574fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // We can't check the value of a dependent argument. 575fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (TheCall->getArg(i)->isTypeDependent() || 576fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan TheCall->getArg(i)->isValueDependent()) 577fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 578fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 579fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Check that the immediate argument is actually a constant. 580fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan llvm::APSInt Result; 581fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (SemaBuiltinConstantArg(TheCall, i, Result)) 582fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return true; 583fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 584fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Range check against the upper/lower values for this instruction. 585fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned Val = Result.getZExtValue(); 586fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (Val < l || Val > u) 587fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 588fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan << l << u << TheCall->getArg(i)->getSourceRange(); 589fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 590fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 591fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan} 592fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 593831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 594831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg. 595831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has 596831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated. 597831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 598831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo *FSI) { 599831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->HasVAListArg = Format->getFirstArg() == 0; 600831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FormatIdx = Format->getFormatIdx() - 1; 601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 602de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 603831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The way the format attribute works in GCC, the implicit this argument 604831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // of member functions is counted. However, it doesn't appear in our own 605831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // lists, so decrement format_idx in that case. 606831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (IsCXXMember) { 607831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if(FSI->FormatIdx == 0) 608831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 609831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FormatIdx; 610831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (FSI->FirstDataArg != 0) 611831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FirstDataArg; 612831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 613831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 614831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 6151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 616831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg 617831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters. 6181c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::checkCall(NamedDecl *FDecl, 6191c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 620831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs, 621831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction, 622831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc, 623831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceRange Range, 624831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType) { 62566360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose if (CurContext->isDependentContext()) 62666360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose return; 627de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 628c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 629831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool HandledFormatString = false; 6300538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (FDecl) 6310538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<FormatAttr> 6320538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu I = FDecl->specific_attr_begin<FormatAttr>(), 6330538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I) 6340538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, 6350538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu Range)) 6360538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu HandledFormatString = true; 637831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 638831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Refuse POD arguments that weren't caught by the format string 639831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // checks above. 640831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!HandledFormatString && CallType != VariadicDoesNotApply) 6411c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko for (unsigned ArgIdx = NumProtoArgs; ArgIdx < Args.size(); ++ArgIdx) { 6420234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek // Args[ArgIdx] can be null in malformed code. 6431c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (const Expr *Arg = Args[ArgIdx]) 6440234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek variadicArgumentPODCheck(Arg, CallType); 6450234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek } 6461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6470538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (FDecl) { 6480538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<NonNullAttr> 6490538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu I = FDecl->specific_attr_begin<NonNullAttr>(), 6500538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I) 6510538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu CheckNonNullArguments(*I, Args.data(), Loc); 6520538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 6530538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu // Type safety checking. 6540538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<ArgumentWithTypeTagAttr> 6550538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(), 6560538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); 6570538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu i != e; ++i) { 6580538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu CheckArgumentWithTypeTag(*i, Args.data()); 6590538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu } 6600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 661831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 662831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 663831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety 664831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system. 6651c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::CheckConstructorCall(FunctionDecl *FDecl, 6661c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 667831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto, 668831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc) { 669831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 670831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 6711c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, Args, Proto->getNumArgs(), 672831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/true, Loc, SourceRange(), CallType); 673831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 674831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 675831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness 676831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system. 677831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 678831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 6792edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) && 6802edcde8747a000113b434a5c88b4648beed4197bEli Friedman isa<CXXMethodDecl>(FDecl); 6812edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) || 6822edcde8747a000113b434a5c88b4648beed4197bEli Friedman IsMemberOperatorCall; 683831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 684831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()); 685831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 6862edcde8747a000113b434a5c88b4648beed4197bEli Friedman Expr** Args = TheCall->getArgs(); 6872edcde8747a000113b434a5c88b4648beed4197bEli Friedman unsigned NumArgs = TheCall->getNumArgs(); 688df75b0c74b277c6b46af2f9e90e13160fbc14d6fEli Friedman if (IsMemberOperatorCall) { 6892edcde8747a000113b434a5c88b4648beed4197bEli Friedman // If this is a call to a member operator, hide the first argument 6902edcde8747a000113b434a5c88b4648beed4197bEli Friedman // from checkCall. 6912edcde8747a000113b434a5c88b4648beed4197bEli Friedman // FIXME: Our choice of AST representation here is less than ideal. 6922edcde8747a000113b434a5c88b4648beed4197bEli Friedman ++Args; 6932edcde8747a000113b434a5c88b4648beed4197bEli Friedman --NumArgs; 6942edcde8747a000113b434a5c88b4648beed4197bEli Friedman } 6951c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, llvm::makeArrayRef<const Expr *>(Args, NumArgs), 6961c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko NumProtoArgs, 697831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IsMemberFunction, TheCall->getRParenLoc(), 698831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 699831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 700831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IdentifierInfo *FnInfo = FDecl->getIdentifier(); 701831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // None of the checks below are needed for functions that don't have 702831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // simple names (e.g., C++ conversion functions). 703831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!FnInfo) 704831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 7050eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 7060a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 7070a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 708d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 709bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 710d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 7110a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 712bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 713c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 714c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 715d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 7160a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 7177ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 718d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 71971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 72071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 72129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 722287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko ArrayRef<const Expr *> Args) { 723831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 724831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 72529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 726287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko checkCall(Method, Args, Method->param_size(), 727831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/false, 728831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith lbrac, Method->getSourceRange(), CallType); 72929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 73029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 73129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 73229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 733f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieubool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall, 734f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu const FunctionProtoType *Proto) { 735725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 736725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 737d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 7381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 739725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 740f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType()) 741d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 7421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 743f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu VariadicCallType CallType; 744a4993778f65212f01168c857cf3043e99ba85c9fRichard Trieu if (!Proto || !Proto->isVariadic()) { 745f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicDoesNotApply; 746f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } else if (Ty->isBlockPointerType()) { 747f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicBlock; 748f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } else { // Ty->isFunctionPointerType() 749f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicFunction; 750f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } 751831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 752d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 7531c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(NDecl, 7541c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 7551c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko TheCall->getNumArgs()), 756831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NumProtoArgs, /*IsMemberFunction=*/false, 757831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getRParenLoc(), 758831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 759831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 760d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 761725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 762725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 7630538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu/// Checks function calls when a FunctionDecl or a NamedDecl is not available, 7640538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu/// such as function pointers returned from functions. 7650538f0e9200df56974b5a71bc276dbce456e9781Richard Trieubool Sema::CheckOtherCall(CallExpr *TheCall, const FunctionProtoType *Proto) { 7660538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu VariadicCallType CallType = getVariadicCallType(/*FDecl=*/0, Proto, 7670538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getCallee()); 7680538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 7690538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 7700538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu checkCall(/*FDecl=*/0, 7710538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 7720538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getNumArgs()), 7730538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu NumProtoArgs, /*IsMemberFunction=*/false, 7740538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getRParenLoc(), 7750538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getCallee()->getSourceRange(), CallType); 7760538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 7770538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu return false; 7780538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu} 7790538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 780ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 781ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AtomicOp Op) { 782276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 783276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 784276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 785ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // All these operations take one of the following forms: 786ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith enum { 787ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_init(A *, C) 788ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Init, 789ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_load(A *, int) 790ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Load, 791ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_load(A *, CP, int) 792ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Copy, 793ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_add(A *, M, int) 794ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Arithmetic, 795ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __atomic_exchange_n(A *, CP, int) 796ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Xchg, 797ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_exchange(A *, C *, CP, int) 798ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUXchg, 799ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 800ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith C11CmpXchg, 801ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 802ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUCmpXchg 803ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } Form = Init; 804ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 805ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 806ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // where: 807ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C is an appropriate type, 808ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 809ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 810ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 811ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the int parameters are for orderings. 812ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 813ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(AtomicExpr::AO__c11_atomic_init == 0 && 814ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 815ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith && "need to update code for modified C11 atomics"); 816ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 817ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsN = Op == AtomicExpr::AO__atomic_load_n || 819ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_store_n || 820ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_exchange_n || 821ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_compare_exchange_n; 822ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsAddSub = false; 823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Op) { 825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_init: 826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Init; 827ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 828ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 829ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_load: 830ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load_n: 831ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Load; 832ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 833ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 834ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_store: 835ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load: 836ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store: 837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store_n: 838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Copy; 839ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 840ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 841ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_add: 842ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_sub: 843ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_add: 844ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_sub: 845ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_add_fetch: 846ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_sub_fetch: 847ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith IsAddSub = true; 848ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Fall through. 849ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_and: 850ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_or: 851ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_xor: 852ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_and: 853ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_or: 854ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_xor: 85551b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_fetch_nand: 856ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_and_fetch: 857ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_or_fetch: 858ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_xor_fetch: 85951b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_nand_fetch: 860ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Arithmetic; 861ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 862ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 863ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_exchange: 864ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange_n: 865ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Xchg; 866ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 867ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 868ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange: 869ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUXchg; 870ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 871ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 872ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 873ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 874ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = C11CmpXchg; 875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 876ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 877ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange: 878ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange_n: 879ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUCmpXchg; 880ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 881276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 882276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Check we have the right number of arguments. 884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (TheCall->getNumArgs() < NumArgs[Form]) { 885276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 887276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 888276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 889ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (TheCall->getNumArgs() > NumArgs[Form]) { 890ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 891276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 892ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 893276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 894276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 895276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 896276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 897ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Inspect the first argument of the atomic operation. 898dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 899276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 900276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 901276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 902ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 903276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 904276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 905276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 906276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 907ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For a __c11 builtin, this should be a pointer to an _Atomic type. 908ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType AtomTy = pointerType->getPointeeType(); // 'A' 909ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ValType = AtomTy; // 'C' 910ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsC11) { 911ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!AtomTy->isAtomicType()) { 912ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 913ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 914ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 915ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 916bc57b108b2253e26b83768dba196c28564952f18Richard Smith if (AtomTy.isConstQualified()) { 917bc57b108b2253e26b83768dba196c28564952f18Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic) 918bc57b108b2253e26b83768dba196c28564952f18Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 919bc57b108b2253e26b83768dba196c28564952f18Richard Smith return ExprError(); 920bc57b108b2253e26b83768dba196c28564952f18Richard Smith } 921ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ValType = AtomTy->getAs<AtomicType>()->getValueType(); 922276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 923276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 924ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For an arithmetic operation, the implied arithmetic must be well-formed. 925ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Arithmetic) { 926ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 927ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 928ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 929ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 930ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 931ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 932ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsAddSub && !ValType->isIntegerType()) { 933ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 934ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 935ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 936ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 937ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 938ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For __atomic_*_n operations, the value type must be a scalar integral or 939ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 940276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 941ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 942276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 943276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 944276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 945ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) { 946ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For GNU atomics, require a trivially-copyable type. This is not part of 947ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the GNU atomics specification, but we enforce it for sanity. 948ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 949276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 950276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 951276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 952276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 953ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: For any builtin other than a load, the ValType must not be 954ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // const-qualified. 955ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 956276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 957276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 958276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 959276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 960276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 961276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 962276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 963276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 964276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 965ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: Can this happen? By this point, ValType should be known 966ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // to be trivially copyable. 967276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 968276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 969276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 970276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 971276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 972276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 973ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Copy || Form == GNUXchg || Form == Init) 974276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 975ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == C11CmpXchg || Form == GNUCmpXchg) 976276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 977276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 978ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The type of a parameter passed 'by value'. In the GNU atomics, such 979ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // arguments are actually passed as pointers. 980ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ByValType = ValType; // 'CP' 981ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !IsN) 982ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ByValType = Ptr->getType(); 983ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 984276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 985276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 986276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 987ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith for (unsigned i = 1; i != NumArgs[Form]; ++i) { 988276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 989ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (i < NumVals[Form] + 1) { 990ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (i) { 991ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 1: 992ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The second argument is the non-atomic operand. For arithmetic, this 993ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // is always passed by value, and for a compare_exchange it is always 994ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // passed by address. For the rest, GNU uses by-address and C11 uses 995ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // by-value. 996ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(Form != Load); 997ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 998ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ValType; 999ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Copy || Form == Xchg) 1000ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 1001ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Arithmetic) 1002ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerDiffType(); 1003ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else 1004ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerType(ValType.getUnqualifiedType()); 1005ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1006ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 2: 1007ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The third argument to compare_exchange / GNU exchange is a 1008ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // (pointer to a) desired value. 1009ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 1010ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1011ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 3: 1012ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The fourth argument to GNU compare_exchange is a 'weak' flag. 1013ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.BoolTy; 1014ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1015ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 1016276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 1017276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 1018276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 1019276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1020ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 1021276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 1022276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 1023ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ExprResult Arg = TheCall->getArg(i); 1024276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1025276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 1026276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 1027276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 1028276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1029276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1030ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Permute the arguments into a 'consistent' order. 1031dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 1032dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 1033ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Form) { 1034ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Init: 1035ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal1() has a special case for this atomic. 10367a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 1037ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1038ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Load: 1039ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Order 1040ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1041ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Copy: 1042ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Arithmetic: 1043ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Xchg: 1044dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 1045dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 1046ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1047ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUXchg: 1048ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal2() has a special case for this atomic. 1049ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Order 1050ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 1051ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 1052ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1053ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case C11CmpXchg: 1054dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 1055dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 1056dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 10572ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall SubExprs.push_back(TheCall->getArg(2)); // Val2 1058ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1059ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUCmpXchg: 1060ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(4)); // Order 1061ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 1062ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(5)); // OrderFail 1063ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 1064ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Weak 1065ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 1066276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 1067538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian 1068538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian AtomicExpr *AE = new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 1069538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian SubExprs, ResultType, Op, 1070538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian TheCall->getRParenLoc()); 1071538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian 1072538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian if ((Op == AtomicExpr::AO__c11_atomic_load || 1073538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian (Op == AtomicExpr::AO__c11_atomic_store)) && 1074538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian Context.AtomicUsesUnsupportedLibcall(AE)) 1075538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian Diag(AE->getLocStart(), diag::err_atomic_load_store_uses_lib) << 1076538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian ((Op == AtomicExpr::AO__c11_atomic_load) ? 0 : 1); 1077dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 1078538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian return Owned(AE); 1079276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 1080276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 1081276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 10825f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 10835f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 10845f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 10855f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 10865f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 10875f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 10885f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 10895f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 10905f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 10915f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 10925f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 10935f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 10945f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 10955f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 10965f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 10975f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 10985f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 10995f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 11005f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 11015f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 11025f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 11035f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 11045f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 11055f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 11065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 11075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 11085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 11095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 11105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 11115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 11125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 11135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 111460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 111560d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 1116d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 11175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 11185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 11195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 11205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 1121d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 1122d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1123d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 1124d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1125d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1126d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 11271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 11295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 11305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 11315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 1132d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 11335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 11348c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 11358c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 11368c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 11378c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 11388c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 11398c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 1140f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 1141f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 1142d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 1143d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1144d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1145d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 11461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1147f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 1148dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 1149d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 1150d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 1151d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1152d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1153d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 11545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1155f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 1156f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 1157f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 1158f85e193739c953358c865005855253af4f68a497John McCall // okay 1159f85e193739c953358c865005855253af4f68a497John McCall break; 1160f85e193739c953358c865005855253af4f68a497John McCall 1161f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 1162f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 1163f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 1164b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1165f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 1166f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 1167f85e193739c953358c865005855253af4f68a497John McCall } 1168f85e193739c953358c865005855253af4f68a497John McCall 1169b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 1170b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 1171b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 11728d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 11738d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 11748d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 11758d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 11765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 11775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 11785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 11795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 11805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 11815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 11821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 11845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 11855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 11865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 11875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 11885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 11891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 11915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 11925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 11935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 11945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 11951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 11975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 11985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 119923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 120023aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 12015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 12021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 12031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 12055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 1206199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 12075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 12085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 12095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 12105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 12115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 12125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 1213d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 1214d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1215d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 12165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 12171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 12195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 12205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 12215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 12227814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 12235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 12245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 1225b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 1226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 1227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 1228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 1229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 1230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 1231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 1233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 1236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 1237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 1238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 1239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 1240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 1242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 1245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 1246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 1247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 1248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 1249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 1251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 1254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 1255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 1256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 1257a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 1258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 1260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 1263a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 1264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 1265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 1266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 1267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 1269a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1270a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1271a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 1272a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 1273a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 1274a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 1275a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 1276a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1277a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 1278a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1279a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1280a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 1281a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 1282a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 1283a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 1284a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 1285a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 1286a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 1287a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1288a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1289a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 1290a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 1291a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 1292a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 1293a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 1294a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 1295a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 1296a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1297a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1298a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 1299a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 1300a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 1301a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 1302a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 1303a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 1304a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 1305a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1306a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1307a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 1308a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 1309a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 1310a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 1311a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 1312a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 1313a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 1314a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 13151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1317a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 1318a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 1319a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 1320a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 1321a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 13227eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 13235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 13245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1325a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 13265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1327a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 1328a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 1329a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 1330a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 1331a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 13327eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 13335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 13348d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 13355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1336a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1337a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 1338a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 1339a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 1340a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 1341a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 1342a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 1343a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 1344a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1345a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 13465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 1347a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 1348a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 1349a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 1350a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 1351a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 13527eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 13535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 13548d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 13555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1356a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1357a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 1358a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 1359a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 1360a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 1361a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 1362a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 1363a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 1364a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 13655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 13661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 13685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 1369d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 1370d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1371d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 1372d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1373d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1374d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 13751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1376e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 1377e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 1378e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1379e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 13802ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara FunctionDecl *NewBuiltinDecl; 13812ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinID == BuiltinID) 13822ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = FDecl; 13832ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara else { 13842ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara // Perform builtin lookup to avoid redeclaring it. 13852ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara DeclarationName DN(&Context.Idents.get(NewBuiltinName)); 13862ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName); 13872ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true); 13882ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara assert(Res.getFoundDecl()); 13892ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl()); 13902ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinDecl == 0) 13912ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara return ExprError(); 13922ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara } 1393d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1394f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 1395f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 1396f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 13975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 1398429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 13991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 14015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 1402b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 1403b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1404b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 1405b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1406429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 1407d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 14081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 14105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 14115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 14125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 14135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 14141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 1415b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 14165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 14171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1418bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 1419bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 1420bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 1421bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 1422bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 1423bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 1424e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 1425bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 1426f4b88a45902af1802a1cb42ba48b1c474474f228John McCall /*enclosing*/ false, 1427bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 1428a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman Context.BuiltinFnTy, 1429bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 14301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 1432a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman // FIXME: This loses syntactic information. 1433a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 1434a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 1435a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman CK_BuiltinFnToFnPtr); 1436429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 14371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1438db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1439db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1440db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 14418d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1442d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 14433fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 14445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 14455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1446690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 144771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1448fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1449fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1450690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 145156f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 145271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 145371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 14545cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1455fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1456fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 14579cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 145871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 14591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14607da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 14615f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 14627da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 14635f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 146431ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky const UTF8 *FromPtr = (const UTF8 *)String.data(); 14657da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 14667da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 14677da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 14687da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 14697da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 14707da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 14717da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 14727da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 14737da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 14747da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 14759cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 147659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 147759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1478c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1479c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1480925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1481925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1482925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 14832c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1484fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1485ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1486ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 14871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1488fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 148930ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 149030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 149156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 149256f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1493d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1494d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1495d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 149656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 149756f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 14985f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 14995f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 15005f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 15015f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1502c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 15039ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1504c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1505cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1506c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 15079498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 15089498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 15099498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 151053d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 15111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1512c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 151330ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 151430ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 151530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 15161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 151730ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 151830ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 151930ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1520e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 15211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1522b07d448a625d7399d871079d55491c6b10316e6fNico Weber // These are valid if SecondArgIsLastNamedArgument is false after the next 1523b07d448a625d7399d871079d55491c6b10316e6fNico Weber // block. 1524b07d448a625d7399d871079d55491c6b10316e6fNico Weber QualType Type; 1525b07d448a625d7399d871079d55491c6b10316e6fNico Weber SourceLocation ParamLoc; 1526b07d448a625d7399d871079d55491c6b10316e6fNico Weber 152788cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 152888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 152930ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 153030ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 153188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1532cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1533cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1534cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1535371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 153630ce344307f8a8b00054021307015571f83c7364Chris Lattner else 153753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 153830ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 1539b07d448a625d7399d871079d55491c6b10316e6fNico Weber 1540b07d448a625d7399d871079d55491c6b10316e6fNico Weber Type = PV->getType(); 1541b07d448a625d7399d871079d55491c6b10316e6fNico Weber ParamLoc = PV->getLocation(); 154230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 154330ce344307f8a8b00054021307015571f83c7364Chris Lattner } 15441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 154530ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 15461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 154730ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 1548b07d448a625d7399d871079d55491c6b10316e6fNico Weber else if (Type->isReferenceType()) { 1549b07d448a625d7399d871079d55491c6b10316e6fNico Weber Diag(Arg->getLocStart(), 1550b07d448a625d7399d871079d55491c6b10316e6fNico Weber diag::warn_va_start_of_reference_type_is_undefined); 1551b07d448a625d7399d871079d55491c6b10316e6fNico Weber Diag(ParamLoc, diag::note_parameter_type) << Type; 1552b07d448a625d7399d871079d55491c6b10316e6fNico Weber } 1553b07d448a625d7399d871079d55491c6b10316e6fNico Weber 155430ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 15556cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 155630ce344307f8a8b00054021307015571f83c7364Chris Lattner 15571b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 15581b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1559925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1560925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 15612c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1562d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1563925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 15641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1565fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1566ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1567fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1568fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 15691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1570429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1571429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1572cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 15731b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 15741b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1575925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1576429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1577429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1578403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1579403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1580403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1581403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1582429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1583429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 15841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1585429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1586cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1587cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 15881b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 15891b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 1590860a319e62b0e256817a458396d191aa91c0787aEli Friedman if (Res.isNull() || !Res->isRealFloatingType()) 1591429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1592fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1593429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1594429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 15951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 15961b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 15971b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 15981b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1599e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1600e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 16013b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 16023b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 16033b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 16043b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 16059ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1606d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 16073b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 16083b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 16099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1610ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 16113b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 16129ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 16139ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 16143b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 16151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 16169ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 16179ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 16189ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 161981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 16209ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 16211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 16229ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 16239ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 16241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 162581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 162681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 162781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 162881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 162981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 163081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 163181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 163281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 163381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 163481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 163581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 16369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 16379ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 16389ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1639d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1640d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 164160d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 164237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 16430eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1644d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 164537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1646d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1647d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 164837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 164937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 165037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 165137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 165237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 165337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 1654e3fbbe9a486c4c8709726d8c79af33140eb02e53Craig Topper 1655cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1656cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 165737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 165837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 1659e3fbbe9a486c4c8709726d8c79af33140eb02e53Craig Topper 166037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1661cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 16621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1663cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1664cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1665cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1666e3fbbe9a486c4c8709726d8c79af33140eb02e53Craig Topper 166737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 166837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 166937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 167037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 167137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 167237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 167337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 16744cb3d909cb4af5efc073fd4122d4998c466a220eSylvestre Ledru if (!RHSType->hasIntegerRepresentation() || 167537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 167637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 167737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 167837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 1679e3fbbe9a486c4c8709726d8c79af33140eb02e53Craig Topper } else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1680cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 16811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1682cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1683cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 168437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 168537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1686788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1687e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1688cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1689d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1690d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1691d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1692cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1693cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1694cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1695cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 169637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 169737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 169837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 169937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 170037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 17010eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1702d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 17030eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1704fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 17050eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1706d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1707d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 17085f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1709d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1710d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1711d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1712d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1713d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1714d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 17153b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType, 17168189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 17178189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1718d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 171930ce344307f8a8b00054021307015571f83c7364Chris Lattner 17204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 17214493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 17224493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 17234493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1724fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 17254493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1726fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1727ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1728ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1729ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1730ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 17314493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 17324493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 17334493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1734fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 17354493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1736592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1737592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1738592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (Arg->isTypeDependent() || Arg->isValueDependent()) 1739592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor continue; 1740592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 17419aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1742691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1743691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 17441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 17454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 17464493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 17474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1748fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 17499aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1750fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 175121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 17524493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 17539aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1754fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 175521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 17564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 17574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 17584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1759fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 17604493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 17614493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1762691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1763691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1764691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1765691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1766691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1767691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1768691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1769691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1770691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1771691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1772691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1773691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 17745e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1775691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 177621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 177721fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 177821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1779d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1780d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1781d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1782fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1783d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1784691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1785592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1786592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1787592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(1)->isTypeDependent() || 1788592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(1)->isValueDependent()) 1789592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 1790592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1791691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1792691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1793691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1794d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1795691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1796d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1797fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1798fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1799d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1800d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1801d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1802d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1803d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1804586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1805d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1806d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1807d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1808691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1809cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1810691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1811691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1812691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1813691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1814691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1815d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1816d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1817d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1818d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1819d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1820d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1821831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string. 1822831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a 1823831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning. 1824831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString. 1825831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType 18261c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri GribenkoSema::checkFormatStringExpr(const Expr *E, ArrayRef<const Expr *> Args, 18271c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool HasVAListArg, 1828831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned format_idx, unsigned firstDataArg, 1829ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose FormatStringType Type, VariadicCallType CallType, 1830ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall) { 18314fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1832cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1833831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1834d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 183534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1836f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1837a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1838a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1839a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1840a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1841a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1842831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1843a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1844d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 184556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1846d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 1847831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The expression is a literal if both sub-expressions were, and it was 1848831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // completely checked only if both sub-expressions were checked. 1849831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const AbstractConditionalOperator *C = 1850831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith cast<AbstractConditionalOperator>(E); 1851831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Left = 18521c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getTrueExpr(), Args, 1853831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1854ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1855831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Left == SLCT_NotALiteral) 1856831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1857831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Right = 18581c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getFalseExpr(), Args, 1859831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1860ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1861831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Left < Right ? Left : Right; 1862d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1863d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1864d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 18654fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 18664fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1867d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1868d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 186956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 187056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 187156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 187256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 187356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 1874831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 187556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1876b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1877b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1878b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1879b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1880831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1881b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1882082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1883082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 18841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1885082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1886082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1887082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1888082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1889082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1890082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1891082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1892082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1893ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 18941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1895082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1896e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1897e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1898e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1899e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1900082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 19011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1902082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 1903e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const Expr *Init = VD->getAnyInitializer()) { 1904e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay // Look through initializers like const char c[] = { "foo" } 1905e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 1906e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (InitList->isStringLiteralInit()) 1907e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay Init = InitList->getInit(0)->IgnoreParenImpCasts(); 1908e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 19091c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Init, Args, 1910831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1911ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1912831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*inFunctionCall*/false); 1913e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 1914082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 19151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1916d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1917d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1918d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1919d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1920d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1921d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1922d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1923d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1924d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1925d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1926d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1927d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1928d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1929d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1930f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (HasVAListArg) { 1931f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 1932f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 1933f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas int PVIndex = PV->getFunctionScopeIndex() + 1; 1934f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 1935f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas i = ND->specific_attr_begin<FormatAttr>(), 1936f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 1937f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas FormatAttr *PVFormat = *i; 1938f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // adjust for implicit parameter 1939f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 1940f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (MD->isInstance()) 1941f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas ++PVIndex; 1942f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We also check if the formats are compatible. 1943f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We can't pass a 'scanf' string to a 'printf' function. 1944f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (PVIndex == PVFormat->getFormatIdx() && 1945f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas Type == GetFormatStringType(PVFormat)) 1946831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1947f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1948f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1949f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1950f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1951082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 19521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1953831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1954082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1955d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 195652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 195752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 19588f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 195952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 196052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 196152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 196252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 196352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 196452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 196552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 196652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 19671c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 1968831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1969ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 197050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 197150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned BuiltinID = FD->getBuiltinID(); 197250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 197350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 197450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose const Expr *Arg = CE->getArg(0); 19751c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 1976831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1977ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1978ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall); 197950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } 19808f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 19818f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 19821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1983831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 19848f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1985082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1986082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1987082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 19881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1989082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1990d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1991d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1992082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 19931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1994d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 19951c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko CheckFormatString(StrE, E, Args, HasVAListArg, format_idx, 1996ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, inFunctionCall, CallType); 1997831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1998d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 19991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2000831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 2001d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 20021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2003082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 2004831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 2005d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 2006d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 2007d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 2008e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 20091eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 2010909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 2011909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 2012cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 2013cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 2014e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 2015909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 20163edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 20173edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // As a special case, transparent unions initialized with zero are 20183edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // considered null for the purposes of the nonnull attribute. 20193edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const RecordType *UT = ArgExpr->getType()->getAsUnionType()) { 20203edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (UT->getDecl()->hasAttr<TransparentUnionAttr>()) 20213edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const CompoundLiteralExpr *CLE = 20223edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<CompoundLiteralExpr>(ArgExpr)) 20233edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const InitListExpr *ILE = 20243edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<InitListExpr>(CLE->getInitializer())) 20253edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky ArgExpr = ILE->getInit(0); 20263edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky } 20273edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 20283edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky bool Result; 20293edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (ArgExpr->EvaluateAsBooleanCondition(Result, Context) && !Result) 2030909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 2031e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 2032e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 2033d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 203434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 203534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 203634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 203734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 203834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 203934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 204034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 204134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 204234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 204334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 204434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 2045ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar 2046826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 2047831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked. 20481c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(const FormatAttr *Format, 20491c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 20501c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool IsCXXMember, 2051ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 205229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 2053831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo FSI; 2054831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 20551c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx, 2056831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI.FirstDataArg, GetFormatStringType(Format), 2057ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose CallType, Loc, Range); 2058831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 205929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 20604a2614e94672c47395abcde60518776fbebec589Sebastian Redl 20611c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args, 206234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 206334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 2064ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 206534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 2066826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 20671c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (format_idx >= Args.size()) { 206829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 2069831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 207071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 20711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 207229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 20731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 207459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 20751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 207671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 207771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 207871895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 207971895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 208071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 20817ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 20821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 20837ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 20841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 20857ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 2086831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType CT = 20871c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(OrigFormatExpr, Args, HasVAListArg, 2088ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose format_idx, firstDataArg, Type, CallType); 2089831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (CT != SLCT_NotALiteral) 2090831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Literal format string found, check done! 2091831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CT == SLCT_CheckedLiteral; 20921cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 20932837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 20942837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 20952837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 2096831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 20972837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 2098ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 2099ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 2100ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 2101ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 2102dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas if (Type == FST_NSString && 2103dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart())) 2104831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2105ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 2106655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 2107655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 21082243e78a6580ead4d17b76c924cd4b630b50d6aeEli Friedman if (Args.size() == firstDataArg) 210929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 2110826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 2111655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 2112655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 211329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 2114826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 2115655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 2116831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2117d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 2118d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 2119e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 2120826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 2121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 2122e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 2123e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 2124e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 21256ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 2126e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 2127e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 21280d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 21291c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args; 21300d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 21317f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 2132efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 2133efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 213455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 2135ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType; 21364e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 2137826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 21386ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 213950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 21401c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2141ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2142ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType callType) 2143e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 214450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), 214550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose Beg(beg), HasVAListArg(hasVAListArg), 21461c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args(Args), FormatIdx(formatIdx), 214755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 2148ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall(inFunctionCall), CallType(callType) { 21497f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 21507f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 21517f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 21524e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 215307d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 21544e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2155826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 2156826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 215776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2158bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose void HandleInvalidLengthModifier( 2159bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2160bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 21618be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID); 2162bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 216376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardLengthModifier( 21648be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 216576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 216676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 216776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecifier( 216876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 216976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 217076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2171f85626453123f9691bcef13cff963f556e209c27Hans Wennborg virtual void HandlePosition(const char *startPos, unsigned posLen); 2172f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2173efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 2174efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 2175826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 2176efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2177efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 2178efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2179e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 21804e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 218155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 218255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 218355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 218455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 218555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 218655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 21875543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 218855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2189826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 2190c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 2191c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2192c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2193c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 219455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 219555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 219655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 219755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 2198c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2199f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 2200826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 2201826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2202e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 22034e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 22040d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 2205666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2206666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 2207666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2208666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 2209666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 221055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 221155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 221255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 221355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 22145543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 221555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 221655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 221755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 2218e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 2219e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2220e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2221826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 2222e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 2223e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2224e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2225826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 2226826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 222745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 222845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 222945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 223045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 2231a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 223245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 223345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 2234f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 2235f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 2236826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 22374e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 2238e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2239e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2240826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 2241826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 224255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 224355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 224455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 224555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2246808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 2247808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 2248bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier( 2249bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2250bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 22518be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID) { 2252bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose using namespace analyze_format_string; 2253bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2254bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 2255bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 2256bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2257bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose // See if we know how to fix this length modifier. 2258dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 2259bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (FixedLM) { 22608be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2261bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2262bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2263bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2264bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2265bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 2266bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixedLM->toString() 2267bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 2268bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2269bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } else { 22708be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose FixItHint Hint; 22718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (DiagID == diag::warn_format_nonsensical_length) 22728be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint = FixItHint::CreateRemoval(LMRange); 22738be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 22748be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2275bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2276bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2277bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen), 22788be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint); 2279bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } 2280bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose} 2281bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 228276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier( 22838be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 228476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 22858be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose using namespace analyze_format_string; 22868be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 22878be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 22888be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 22898be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 22908be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose // See if we know how to fix this length modifier. 2291dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 22928be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (FixedLM) { 22938be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 22948be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 22958be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 22968be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 22978be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 22988be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 22998be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 23008be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixedLM->toString() 23018be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 23028be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 23038be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } else { 23048be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 23058be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 23068be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 23078be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 23088be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 23098be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } 231076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 231176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 231276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier( 231376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 231476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 2315670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose using namespace analyze_format_string; 2316670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2317670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose // See if we know how to fix this conversion specifier. 2318dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier(); 2319670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose if (FixedCS) { 2320670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2321670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2322670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2323670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2324670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2325670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2326670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength()); 2327670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier) 2328670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixedCS->toString() 2329670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixItHint::CreateReplacement(CSRange, FixedCS->toString()); 2330670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } else { 2331670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2332670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2333670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2334670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2335670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2336670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } 233776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 233876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2339f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos, 2340f85626453123f9691bcef13cff963f556e209c27Hans Wennborg unsigned posLen) { 2341f85626453123f9691bcef13cff963f556e209c27Hans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 2342f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getLocationOfByte(startPos), 2343f85626453123f9691bcef13cff963f556e209c27Hans Wennborg /*IsStringLocation*/true, 2344f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getSpecifierRange(startPos, posLen)); 2345f85626453123f9691bcef13cff963f556e209c27Hans Wennborg} 2346f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2347efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 2348826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 2349826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 235055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 235155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 235255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 235355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2354efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2355efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2356826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 2357efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 235855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 235955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 236055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 236155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2362efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2363efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2364826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 236550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 23660c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 236755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 236855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 236955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 237055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 23710c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 2372826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2373826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 237448716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building 237548716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions. 2376826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 237729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 2378826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 23794e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2380826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 2381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 2382826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 2383826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 2384826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 2385826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 2386826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 2387826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 2388826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 238948716663e421472cbd590af160a372bc490205e8Jordan Rose if (const Expr *E = getDataArg((unsigned) notCoveredArg)) { 239048716663e421472cbd590af160a372bc490205e8Jordan Rose SourceLocation Loc = E->getLocStart(); 239148716663e421472cbd590af160a372bc490205e8Jordan Rose if (!S.getSourceManager().isInSystemMacro(Loc)) { 239248716663e421472cbd590af160a372bc490205e8Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 239348716663e421472cbd590af160a372bc490205e8Jordan Rose Loc, /*IsStringLocation*/false, 239448716663e421472cbd590af160a372bc490205e8Jordan Rose getFormatStringRange()); 239548716663e421472cbd590af160a372bc490205e8Jordan Rose } 2396c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson } 2397826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2398826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2399826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2400826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2401c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 2402c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 2403c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 2404c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2405c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2406c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 2407c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 2408c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2409c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 2410c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 2411c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 2412c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 2413c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 2414c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2415c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 2416c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 2417c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 2418c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 2419c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 2420c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 2421c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 2422c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2423c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 242455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 242555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 242655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 242755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 2428c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2429c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 2430c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2431c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 243255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 243355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 243455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 243555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 243655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 243755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 243855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 243955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 244055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2441666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 2442666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 2443666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 2444666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2445666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2446666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2447666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 244855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 244955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 245055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 245155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 245255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 245355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 245455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2455666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 2456666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 2457666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 2458666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 2459666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 246055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 246155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 246255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 246355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 246455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2465ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 246629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 246755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 246855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 246955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 247055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 247155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 247255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 247370517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function 247455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 247555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 247655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 247755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 247855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 247955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 248055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 248155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 248255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 248355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 248455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 248555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 248655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 248755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 248855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 248955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 249055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 249155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 249255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 249355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 249455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 249555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 249670517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string. 249755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 249855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 249955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 250055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 250155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 250255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 250355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2504ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 2505ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (InFunctionCall) { 2506ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 2507ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << StringRange; 2508ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2509ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2510ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << *I; 2511ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2512ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 251355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 251455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 2515ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2516ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &Note = 2517ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 2518ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose diag::note_format_string_defined); 2519ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2520ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << StringRange; 2521ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2522ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2523ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << *I; 2524ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 252555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 252655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 252755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2528826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 2529826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2530826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2531826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 253250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose bool ObjCContext; 2533826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2534826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2535826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 253650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, bool isObjC, 2537826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 25381c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2539ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2540ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2541826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 25421c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko numDataArgs, beg, hasVAListArg, Args, 2543ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose formatIdx, inFunctionCall, CallType), ObjCContext(isObjC) 2544ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2545ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose 2546826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2547826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 2548826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2549826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2550826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2551826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2552826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2553826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2554826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2557831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2558831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E); 2559831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2560826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2561826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2562826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2563826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 2564826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 2565826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2566826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2567826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2568826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2569826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2570826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 2571826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2572826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2573f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg bool checkForCStrMembers(const analyze_printf::ArgType &AT, 2574831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E, const CharSourceRange &CSR); 2575831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2576826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2577826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2578826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2579826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2580826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2581826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2582826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 25836ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 2584c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2585826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2586c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2587c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2588c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2589c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 259026ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 259126ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 2592826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 2593826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 2594826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 2595826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 25960d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 25970d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 25980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 25997f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 26007f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 260155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 260255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 260355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 260455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 260555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 26060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 26070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 26080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26104e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 26110d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 261231f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 261331f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 261431f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 26157f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 26167f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 261748716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 261848716663e421472cbd590af160a372bc490205e8Jordan Rose return false; 261948716663e421472cbd590af160a372bc490205e8Jordan Rose 26200d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 26214e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2622f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 2623f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg assert(AT.isValid()); 26244e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2625f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg if (!AT.matchesType(S.Context, T)) { 262655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2627f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << k << AT.getRepresentativeTypeName(S.Context) 262855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 262955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 263055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 263155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 26320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 26330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 26340d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26350d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26360d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26370d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26380d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 26390d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 26400d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2641e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 2642826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2643e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 2644e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 2645e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2646e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 26476ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 26486ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 2649e4ee9663168dfb2b4122c768091e30217328c9faTom Care 265055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 265155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 265255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 265355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 265455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 265555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 265655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 265755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 265855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 265955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 266055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 266155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2662e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2663e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2664826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2665e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2666e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2667e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2668e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 26696ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 26706ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 267155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 267255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 267355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 267455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 267555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 267655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 267755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2678e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2679e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2680e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2681826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2682e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2683e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2684e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2685e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2686e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 268755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 268855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 268955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 269055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 269155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 269255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 269355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2694e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2695e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2696831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing 2697831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named 2698831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()"). 2699831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind> 2700831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1> 2701831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 2702831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const RecordType *RT = Ty->getAs<RecordType>(); 2703831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith llvm::SmallPtrSet<MemberKind*, 1> Results; 2704831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2705831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RT) 2706831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2707831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 2708831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RD) 2709831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2710831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2711831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(), 2712831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Sema::LookupMemberName); 2713831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2714831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // We just need to include all members of the right kind turned up by the 2715831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // filter, at this point. 2716831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (S.LookupQualifiedName(R, RT->getDecl())) 2717831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 2718831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NamedDecl *decl = (*I)->getUnderlyingDecl(); 2719831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 2720831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Results.insert(FK); 2721831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2722831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2723831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2724831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2725831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a 2726f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid. 2727831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found. 2728831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers( 2729f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT, const Expr *E, 2730831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CharSourceRange &CSR) { 2731831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 2732831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2733831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MethodSet Results = 2734831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 2735831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2736831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 2737831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MI != ME; ++MI) { 2738831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXMethodDecl *Method = *MI; 2739831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Method->getNumParams() == 0 && 2740f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg AT.matchesType(S.Context, Method->getResultType())) { 2741831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // FIXME: Suggest parens if the expression needs them. 2742831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation EndLoc = 2743831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()); 2744831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.Diag(E->getLocStart(), diag::note_printf_c_str) 2745831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << "c_str()" 2746831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 2747831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 2748831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2749831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2750831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2751831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2752831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2753831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2754e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2755826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 27565c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2757e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2758e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2759e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 27606ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2761efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 27626ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2763e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2764baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2765baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2766baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2767baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2768baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2769baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 277055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 277155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2772baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2773baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2774efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2775efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 27760d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 27770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2778efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2779efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 27800d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 27810d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 27824e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2783efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2784efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 27850d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 27860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 27870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2788f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2789f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2790f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 27910e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2792f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 27934e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 27947f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 27957f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2796e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2797e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2798e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2799e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2800e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2801e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 28027f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 28037f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 28047f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 280550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!ObjCContext && CS.isObjCArg()) { 2806826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2807826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 28087f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 28094e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2810e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2811e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 281245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2813e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2814e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2815e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2816e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2817e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2818e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2819e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2820e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2821e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2822e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 282365197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 282465197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2825e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2826e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2827e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2828e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 282945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 283045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2831e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2832e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2833e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2834e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2835e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2836e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 283745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 283845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 283945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2840e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2841e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2842e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2843e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2844e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2845bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 28468be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 28478be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 2848bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 28498be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 2850bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 28518be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 28528be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 2853e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2854bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 2855bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 2856bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2857da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2858da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2859da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 28604e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2861666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2862da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 28634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 286448716663e421472cbd590af160a372bc490205e8Jordan Rose const Expr *Arg = getDataArg(argIndex); 286548716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 286648716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 286748716663e421472cbd590af160a372bc490205e8Jordan Rose 286848716663e421472cbd590af160a372bc490205e8Jordan Rose return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 2869831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2870831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2871ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) { 2872ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // FIXME: We should have a general way to reason about operator 2873ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // precedence and whether parens are actually needed here. 2874ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Take care of a few common cases where they aren't. 2875ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Expr *Inside = E->IgnoreImpCasts(); 2876ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 2877ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 2878ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2879ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose switch (Inside->getStmtClass()) { 2880ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ArraySubscriptExprClass: 2881ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::CallExprClass: 288217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CharacterLiteralClass: 288317ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CXXBoolLiteralExprClass: 2884ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::DeclRefExprClass: 288517ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::FloatingLiteralClass: 288617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::IntegerLiteralClass: 2887ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::MemberExprClass: 288817ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCArrayLiteralClass: 288917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoolLiteralExprClass: 289017ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoxedExprClass: 289117ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCDictionaryLiteralClass: 289217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCEncodeExprClass: 2893ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCIvarRefExprClass: 2894ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCMessageExprClass: 2895ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCPropertyRefExprClass: 289617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCStringLiteralClass: 289717ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCSubscriptRefExprClass: 2898ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ParenExprClass: 289917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::StringLiteralClass: 2900ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::UnaryOperatorClass: 2901ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return false; 2902ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose default: 2903ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return true; 2904ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2905ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose} 2906ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2907831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool 2908831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2909831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2910831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2911831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E) { 2912831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_format_string; 2913831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_printf; 291496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 291596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 2916f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = FS.getArgType(S.Context, 2917f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg ObjCContext); 2918614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (!AT.isValid()) 2919614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2920ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2921448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType ExprTy = E->getType(); 292202be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) { 292302be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek ExprTy = TET->getUnderlyingExpr()->getType(); 292402be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek } 292502be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek 2926448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 2927614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2928614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2929614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Look through argument promotions for our error message's reported type. 2930614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // This includes the integral and floating promotions, but excludes array 2931614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // and function pointer decay; seeing that an argument intended to be a 2932614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // string has type 'char [6]' is probably more confusing than 'char *'. 2933614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 2934614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getCastKind() == CK_IntegralCast || 2935614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getCastKind() == CK_FloatingCast) { 2936614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E = ICE->getSubExpr(); 2937448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = E->getType(); 2938614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2939614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Check if we didn't match because of an implicit cast from a 'char' 2940614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // or 'short' to an 'int'. This is done because printf is a varargs 2941614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // function. 2942614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getType() == S.Context.IntTy || 2943614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getType() == S.Context.UnsignedIntTy) { 2944614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // All further checking is done on the subexpression. 2945448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 2946614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 29474d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 2948ee0259d308e72141982a85b40863e760a8447edfJordan Rose } 2949448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) { 2950448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Special case for 'a', which has type 'int' in C. 2951448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Note, however, that we do /not/ want to treat multibyte constants like 2952448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // 'MooV' as characters! This form is deprecated but still exists. 2953448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy == S.Context.IntTy) 2954448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue())) 2955448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = S.Context.CharTy; 2956614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } 2957614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 29582cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // %C in an Objective-C context prints a unichar, not a wchar_t. 29592cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // If the argument is an integer of some kind, believe the %C and suggest 29602cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // a cast instead of changing the conversion specifier. 2961448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType IntendedTy = ExprTy; 29622cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ObjCContext && 29632cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) { 29642cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ExprTy->isIntegralOrUnscopedEnumerationType() && 29652cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose !ExprTy->isCharType()) { 29662cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // 'unichar' is defined as a typedef of unsigned short, but we should 29672cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // prefer using the typedef if it is visible. 29682cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.UnsignedShortTy; 29692cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 29702cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(), 29712cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose Sema::LookupOrdinaryName); 29722cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (S.LookupName(Result, S.getCurScope())) { 29732cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose NamedDecl *ND = Result.getFoundDecl(); 29742cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND)) 29752cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TD->getUnderlyingType() == IntendedTy) 29762cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.getTypedefType(TD); 29772cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 29782cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 29792cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 29802cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 29812cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // Special-case some of Darwin's platform-independence types by suggesting 29822cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // casts to primitive types that are known to be large enough. 29832cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose bool ShouldNotPrintDirectly = false; 2984ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 29856edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek // Use a 'while' to peel off layers of typedefs. 29866edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek QualType TyTy = IntendedTy; 29876edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) { 2988ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 29892cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose QualType CastTy = llvm::StringSwitch<QualType>(Name) 2990ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSInteger", S.Context.LongTy) 2991ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSUInteger", S.Context.UnsignedLongTy) 2992ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("SInt32", S.Context.IntTy) 2993ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("UInt32", S.Context.UnsignedIntTy) 29942cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose .Default(QualType()); 29952cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 29962cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (!CastTy.isNull()) { 29972cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose ShouldNotPrintDirectly = true; 29982cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = CastTy; 29996edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek break; 30002cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 30016edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek TyTy = UserTy->desugar(); 3002ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 3003ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 3004ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3005614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // We may be able to offer a FixItHint if it is a supported type. 3006614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose PrintfSpecifier fixedFS = FS; 3007ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(), 3008614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.Context, ObjCContext); 300996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3010614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (success) { 3011614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Get the fix string from the fixed format specifier 3012614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SmallString<16> buf; 3013614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose llvm::raw_svector_ostream os(buf); 3014614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose fixedFS.toString(os); 3015614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 3016ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 3017ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 30182cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (IntendedTy == ExprTy) { 30192cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the specifier is wrong and should be changed to match 30202cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the argument. 30212cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 30222cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 30232cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << IntendedTy 30242cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 30252cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), 30262cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose /*IsStringLocation*/false, 30272cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, 30282cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FixItHint::CreateReplacement(SpecRange, os.str())); 30292cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 30302cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 3031ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // The canonical type for formatting this value is different from the 3032ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // actual type of the expression. (This occurs, for example, with Darwin's 3033ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 3034ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // should be printed as 'long' for 64-bit compatibility.) 3035ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Rather than emitting a normal format/argument mismatch, we want to 3036ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // add a cast to the recommended type (and correct the format string 3037ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // if necessary). 3038ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallString<16> CastBuf; 3039ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose llvm::raw_svector_ostream CastFix(CastBuf); 3040ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 3041ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 3042ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << ")"; 3043ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3044ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallVector<FixItHint,4> Hints; 3045ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (!AT.matchesType(S.Context, IntendedTy)) 3046ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 3047ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3048ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 3049ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If there's already a cast present, just replace it. 3050ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 3051ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 3052ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3053ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else if (!requiresParensToAddCast(E)) { 3054ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If the expression has high enough precedence, 3055ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // just write the C-style cast. 3056ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 3057ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 3058ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 3059ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Otherwise, add parens around the expression as well as the cast. 3060ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 3061ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 3062ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 3063ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 3064ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd()); 3065ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(After, ")")); 3066ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 3067ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 30682cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ShouldNotPrintDirectly) { 30692cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // The expression has a type that should not be printed directly. 30702cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // We extract the name from the typedef because we don't want to show 30712cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the underlying type in the diagnostic. 30722cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose StringRef Name = cast<TypedefType>(ExprTy)->getDecl()->getName(); 30732cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 30742cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 30752cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << Name << IntendedTy 30762cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 30772cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation=*/false, 30782cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 30792cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 30802cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the expression could be printed using a different 30812cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // specifier, but we've decided that the specifier is probably correct 30822cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // and we should cast instead. Just use the normal warning message. 30832cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 30842cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 30852cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 30862cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 30872cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation*/false, 30882cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 30892cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 3090ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 3091614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else { 3092614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 3093614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SpecifierLen); 3094614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Since the warning for passing non-POD types to variadic functions 3095614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // was deferred until now, we emit a warning for non-POD 3096614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // arguments here. 3097448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (S.isValidVarArgType(ExprTy) == Sema::VAK_Invalid) { 3098614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose unsigned DiagKind; 3099448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy->isObjCObjectType()) 3100614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format; 3101614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose else 3102614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::warn_non_pod_vararg_with_format_string; 310396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3104614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose EmitFormatDiagnostic( 3105614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.PDiag(DiagKind) 310680ad52f327b532bded5c5b0ee38779d841c6cd35Richard Smith << S.getLangOpts().CPlusPlus11 3107448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << ExprTy 3108614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CallType 3109614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << AT.getRepresentativeTypeName(S.Context) 3110614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 3111614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getSourceRange(), 3112614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 311396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3114614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose checkForCStrMembers(AT, E, CSR); 3115614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else 311655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 311755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 3118448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 3119614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 3120831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << E->getSourceRange(), 3121614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 312296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 312396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3124e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 3125e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 3126e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3127826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 3128826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3129826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 3130826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 3131826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 3132826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 3133826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 313450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 31351c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 3136ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 3137ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 3138826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 313950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, 31401c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args, formatIdx, inFunctionCall, CallType) 3141ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 3142826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3143826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 3144826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3145826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 3146c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3147c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 3148c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3149c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 3150c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 3151b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 3152b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 3153826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 3154826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 3155826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3156b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 3157b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 315855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 315955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 316055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 3161b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 3162b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 3163c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 3164c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3165c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 3166c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 3167c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 31686ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 3169c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 3170c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3171c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 3172c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 3173c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 3174c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 3175c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 3176c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3177826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 3178826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3179826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3180826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 3181826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3182826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 3183826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 3184826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 31856ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 3186826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3187baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 3188baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 3189baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 3190baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 3191baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 3192baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 3193baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3194baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 319555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 319655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 3197baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 3198baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3199826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3200826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3201826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 3202826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 3203826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 3204826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 3205826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 3206826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 320755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 320855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 320955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 321055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 32117f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 32127f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 3213826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3214826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 3215826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 3216826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 3217826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3218826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3219826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3220826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 3221826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 3222826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 3223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 3224826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 3225826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 3226826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 3227826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3228826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 32291e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 3230bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 32318be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 32328be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 3233bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 32348be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 3235bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 32368be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 32378be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 323876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 3239bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 3240bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 3241bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 3242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 3243826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 3244826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3245826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3246666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 3247826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 3248826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 32496fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 32506fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 325148716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Ex) 325248716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 325348716663e421472cbd590af160a372bc490205e8Jordan Rose 325458e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 325558e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) { 32566fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 32574e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 3258be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context); 32596fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 32606fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 32616fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 3262f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 32636fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 32646fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 32656fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 32666fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 32676fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 326858e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 32696fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 3270abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3271abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 32726fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 32736fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 32746fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 32756fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 32766fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 3277220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 3278220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 327958e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 3280220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 3281abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3282abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 3283220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 32846fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 32856fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 32866fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 3287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 328807d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 3289e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 32910e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 32921c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 329329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 329434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 3295ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall, VariadicCallType CallType) { 3296826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3297e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 3298df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith if (!FExpr->isAscii() && !FExpr->isUTF8()) { 329955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 330029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 330155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 330255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3303e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3304e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3306e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 33075f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 33082f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 33092f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 33101c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko const unsigned numDataArgs = Args.size() - firstDataArg; 3311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3312e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 33134cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 331455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 331529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 331655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 331755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3318e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3319e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3320826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 332134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 3322826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 332350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, (Type == FST_NSString), 33241c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3325ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3326826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3327d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 3328275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3329275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3330826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 333134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 333250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs, 33331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3334ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3335826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3336d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 3337275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3338275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3339826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 334034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 3341ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 3342ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 33437ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 33447ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 33452a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 33462a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 33472a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 33482a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 33492a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 33502a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 33512a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 33522a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 33532a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 33542a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 33552a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 3356a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 3357000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 3358000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 3359e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 3360000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3361000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 3362000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 3363e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 3364000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 3365000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 3366000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3367a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 3368000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 3369000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 3370000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3371000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 3372000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 3373000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3374000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 3375e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 3376e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 33777ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 33787ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 3379929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 3380cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 3381cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 33827ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 33837ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 3384cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 33850a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 3386cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 33870a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 33880a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 33891d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 3390707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 33910a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 3392cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 33931d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 33941d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 33950a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 33960a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 33970a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 3398cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 3399000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3400000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 3401000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 3402000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 3403000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 3404000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 340506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 340606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 3407e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 340806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 340906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 341006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 341106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 3412f85e193739c953358c865005855253af4f68a497John McCall 3413000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 3414000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 3415000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 341606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 341706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 3418000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 3419000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 3420000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 3421000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 3422000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 3423000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 3424000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 3425000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 3426000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 3427000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 3428000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 3429000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 3430000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 3431000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 3432cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 3433cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 3434000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 34356fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks StringRef ReadableName = FnName->getName(); 34366fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 3437000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 343890c78328e70cb376754edf87708505a84c044271Anna Zaks if (UnaryOp->getOpcode() == UO_AddrOf) 3439000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 34407adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian if (!PointeeTy->isIncompleteType() && 34417adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian (Context.getTypeSize(PointeeTy) == Context.getCharWidth())) 3442000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 3443000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 34446fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 34456fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // If the function is defined as a builtin macro, do not show macro 34466fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // expansion. 34476fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceLocation SL = SizeOfArg->getExprLoc(); 34486fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange DSR = Dest->getSourceRange(); 34496fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange SSR = SizeOfArg->getSourceRange(); 34506fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceManager &SM = PP.getSourceManager(); 34516fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 34526fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks if (SM.isMacroArgExpansion(SL)) { 34536fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 34546fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SL = SM.getSpellingLoc(SL); 34556fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 34566fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(DSR.getEnd())); 34576fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 34586fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(SSR.getEnd())); 34596fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks } 34606fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 346190c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 3462000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 34636fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << ReadableName 346490c78328e70cb376754edf87708505a84c044271Anna Zaks << PointeeTy 346590c78328e70cb376754edf87708505a84c044271Anna Zaks << DestTy 34666fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << DSR 346790c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 346890c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 346990c78328e70cb376754edf87708505a84c044271Anna Zaks PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 347090c78328e70cb376754edf87708505a84c044271Anna Zaks << ActionIdx 347190c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 347290c78328e70cb376754edf87708505a84c044271Anna Zaks 3473000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3474000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3475000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3476000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3477000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 3478000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 3479000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 3480000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 3481000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 3482000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 3483000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 3484000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 3485000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 3486000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 3487000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 3488000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3489000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3490e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 3491e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 349206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 34930a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 34940a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 34950a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 34960a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 34970a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 34980a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 34990a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 35000a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 35010a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 35020a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 35030a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 35040a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 35050a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 35060a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 35075c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 35085c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 35095c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 35100a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 3511d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 35120a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 35135c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 35140a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 35150a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 35165c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 35175c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 35185c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 35195c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 35205c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 3521f85e193739c953358c865005855253af4f68a497John McCall else 352206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 3523f85e193739c953358c865005855253af4f68a497John McCall 3524f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 3525f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 3526929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 352706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 352806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 352906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 35307ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 35317ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 35327ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 3533bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 3534bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 3535bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 3536bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 3537bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 3538bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3539bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 3540bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 3541bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 3542bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3543bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3544bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 3545bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 3546bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3547bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 3548bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 3549bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 3550bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 3551bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 3552bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3553bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3554bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3555bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 3556bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3557bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 35580f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 35590f38acee92014cb15af980808f87144e5564031dAnna Zaks ASTContext &Context) { 35600f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only handle constant-sized or VLAs, but not flexible members. 35610f38acee92014cb15af980808f87144e5564031dAnna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 35620f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only issue the FIXIT for arrays of size > 1. 35630f38acee92014cb15af980808f87144e5564031dAnna Zaks if (CAT->getSize().getSExtValue() <= 1) 35640f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 35650f38acee92014cb15af980808f87144e5564031dAnna Zaks } else if (!Ty->isVariableArrayType()) { 35660f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 35670f38acee92014cb15af980808f87144e5564031dAnna Zaks } 35680f38acee92014cb15af980808f87144e5564031dAnna Zaks return true; 35690f38acee92014cb15af980808f87144e5564031dAnna Zaks} 35700f38acee92014cb15af980808f87144e5564031dAnna Zaks 3571bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 3572bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 3573bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 3574bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 3575bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3576bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 3577bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 3578bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3579bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3580bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 3581bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 3582bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 3583bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3584bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 3585bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 3586bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 3587bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 3588bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 3589bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 3590180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 3591bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 3592bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 3593bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3594bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3595bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3596bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 3597bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3598bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3599bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 3600bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 3601bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 3602bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 3603bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 3604bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 3605bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3606bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3607bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 3608bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 3609bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 3610bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3611bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3612bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 3613bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 3614bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 3615bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3616bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 3617bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 3618bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 3619bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 3620bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 36210f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 36228f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 36238f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 3624f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 36258f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 36268f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 3627d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 36288f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 36298f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 36308f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 36318f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 36328f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 3633bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3634bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3635c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 3636c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 3637c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 3638c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 3639c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 3640c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 3641c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3642c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3643c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 3644c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 3645c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 3646c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 3647c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3648c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 3649c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3650c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3651c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3652c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3653c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 3654c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 3655c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 3656c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 3657c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 3658c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 3659c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 3660c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3661c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 3662c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 3663c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 3664c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3665c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 3666c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 3667c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 3668c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 3669c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 3670c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 3671c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3672c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 3673c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 3674c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3675c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 3676c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 3677c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 3678c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 3679c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 3680c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 3681c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 3682c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3683c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 3684c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 3685c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3686c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3687c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3688c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3689c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 3690c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3691c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3692afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 3693afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 3694afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 3695afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 3696afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 3697afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 3698afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 3699afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 3700afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 3701afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 3702afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 3703afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 37040f38acee92014cb15af980808f87144e5564031dAnna Zaks // Check if the destination is an array (rather than a pointer to an array). 37050f38acee92014cb15af980808f87144e5564031dAnna Zaks QualType DstTy = DstArg->getType(); 37060f38acee92014cb15af980808f87144e5564031dAnna Zaks bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 37070f38acee92014cb15af980808f87144e5564031dAnna Zaks Context); 37080f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isKnownSizeArray) { 37090f38acee92014cb15af980808f87144e5564031dAnna Zaks if (PatternType == 1) 37100f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_wrong_size) << SR; 37110f38acee92014cb15af980808f87144e5564031dAnna Zaks else 37120f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 37130f38acee92014cb15af980808f87144e5564031dAnna Zaks return; 37140f38acee92014cb15af980808f87144e5564031dAnna Zaks } 37150f38acee92014cb15af980808f87144e5564031dAnna Zaks 3716c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 3717afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 3718c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 3719afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 3720c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3721f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 3722c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 3723c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 3724d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3725c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 3726c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 3727d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3728c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 3729c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3730afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 3731afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 3732c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3733c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 373406de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 373506de276fff91264437fa75111ed76de43097e089Ted Kremenek 3736e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3737e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 3738e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars, 3739e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 374006de276fff91264437fa75111ed76de43097e089Ted Kremenek 374106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 374206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 374306de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 374406de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 374506de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 37461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 374726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 37485f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 37494e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 375026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 375126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 3752f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 37534e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 3754e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0); 3755ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 3756e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0); 375726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 375826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 375926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 376026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 376126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 376226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 376326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 376426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 376526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 376626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 376726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 376826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 376926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 377026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 377126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 377226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 377326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 377426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 377526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 377626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 377726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 377826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 377926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 378026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 378126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 378226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 378326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 378426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 378526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 378626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 378726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 378826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 378926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 379026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 379126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 379226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 379326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 379426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 379526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 379626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 379726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 379826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 379926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 380026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 380106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 380206de276fff91264437fa75111ed76de43097e089Ted Kremenek} 380306de276fff91264437fa75111ed76de43097e089Ted Kremenek 380406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 380506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 380626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 380726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 380806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 380926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 381026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 381126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 381226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 381326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 381426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 381526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 381606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 3817e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 3818e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 381926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 382026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 382106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 382206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 382306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 382406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 382506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 382606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 382706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 382806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 382906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 3830e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3831e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 383226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 383326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 383426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 383506de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 38360f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 3837dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 3838a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 3839fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 38401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3841f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 3842f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 384306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 384406de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 384506de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 384606de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 384726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 384826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 384926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 385026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 385126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 385226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 385326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 385426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 385526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 385626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3857e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(V->getInit(), refVars, ParentDecl); 385826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 385926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 386026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 386126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 386206de276fff91264437fa75111ed76de43097e089Ted Kremenek 3863fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 3864fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 3865fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 3866fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 38671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 38682de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 3869e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars, ParentDecl); 3870fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 3871fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 3872fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 38731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3874fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 3875fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 3876fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 3877fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 38782de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 38791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 38802de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 3881fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 38821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3883fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 38843907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3885fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 3886fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 3887fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 38881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3889fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 3890e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(Base, refVars, ParentDecl); 3891fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 389261f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 3893fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 3894fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 3895fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 3896fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 38971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3898fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 38999ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 39009ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 39019ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 3902e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl)) 39039ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 39049ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 39059ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 39069ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 39079ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 39089ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 390906de276fff91264437fa75111ed76de43097e089Ted Kremenek 3910e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars, ParentDecl); 3911fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 391226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 391326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 3914469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 391526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 391626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 391726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 391826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 391926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 39201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 392180ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3922e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 3923e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis ParentDecl); 392480ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 392554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 392654b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 392749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 39286eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 3929f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 39308b9414e868853fc052251455674bf7512261e14aEli Friedman case Stmt::ObjCBridgedCastExprClass: 39311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 39321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 393349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 393449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 39358b9414e868853fc052251455674bf7512261e14aEli Friedman Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 39368b9414e868853fc052251455674bf7512261e14aEli Friedman switch (cast<CastExpr>(E)->getCastKind()) { 39378b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BitCast: 39388b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_LValueToRValue: 39398b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_NoOp: 39408b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BaseToDerived: 39418b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_DerivedToBase: 39428b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_UncheckedDerivedToBase: 39438b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_Dynamic: 39448b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_CPointerToObjCPointerCast: 39458b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BlockPointerToObjCPointerCast: 39468b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_AnyPointerToBlockPointerCast: 3947e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(SubExpr, refVars, ParentDecl); 39488b9414e868853fc052251455674bf7512261e14aEli Friedman 39498b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_ArrayToPointerDecay: 3950e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(SubExpr, refVars, ParentDecl); 39518b9414e868853fc052251455674bf7512261e14aEli Friedman 39528b9414e868853fc052251455674bf7512261e14aEli Friedman default: 39538b9414e868853fc052251455674bf7512261e14aEli Friedman return 0; 39548b9414e868853fc052251455674bf7512261e14aEli Friedman } 3955fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 39561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 395703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 395803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 395903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3960e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 396103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 396203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 396303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 396403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 3965fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 3966fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 3967fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 396806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 396906de276fff91264437fa75111ed76de43097e089Ted Kremenek} 39701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 397106de276fff91264437fa75111ed76de43097e089Ted Kremenek 397206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 397306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 3974e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3975e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 397668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 3977e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 3978e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 3979e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 39801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 398106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 398206de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 398306de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 3984f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 3985f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 398606de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 398768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 398868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 39895baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 399068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 399168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 399268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 399368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 399468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 399568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 399680ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3997e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl); 399880ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 3999a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 400026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 400126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 400226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 400306de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 40041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4005e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 4006e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis // Check if it refers to itself, e.g. "int& i = i;". 4007e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (V == ParentDecl) 4008e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return DR; 4009e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis 401026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 401126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 401226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 401326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 401426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 401526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 401626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 401726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 401826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 4019e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(V->getInit(), refVars, V); 402026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 402126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 4022e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis } 40231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 402406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 402506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 40261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 402706de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 402806de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 402906de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 403006de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 403106de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 40321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 40332de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 4034e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 403506de276fff91264437fa75111ed76de43097e089Ted Kremenek 403606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 403706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 40381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 403906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 404006de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 404106de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 404206de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 4043e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl); 404406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 40451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 404606de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 404706de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 404826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 404906de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 405006de276fff91264437fa75111ed76de43097e089Ted Kremenek 40513907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 40523907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 4053e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl)) 40543907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 40553907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 4056e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(C->getRHS(), refVars, ParentDecl); 405706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 40581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 405906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 406083f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 406106de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 40621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 406306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 4064a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 4065a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 4066a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 4067a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 4068a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 4069a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 407006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 4071a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 4072e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(M->getBase(), refVars, ParentDecl); 407306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 40741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 407503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 407603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 407703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 4078e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 407903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 408003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 408103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 408203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 408306de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 408426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 408526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 408626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 408726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 408826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 408926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 409006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 409106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 409268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 409306de276fff91264437fa75111ed76de43097e089Ted Kremenek} 4094588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 4095588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 4096588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 4097588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 4098588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 4099588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 4100dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 4101dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 4102dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 4103588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 4104588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 4105588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 4106588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 4107588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 4108588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 4109980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 41101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 41111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 41121b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 41131b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 41141b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 41151b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 41161b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 4117980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 4118980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLL->isExact()) 4119980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 4120980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie } else 4121980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 4122980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLR->isExact()) 4123980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 41241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4125588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 4126980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 4127980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CL->isBuiltinCall()) 4128980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 41291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4130980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 4131980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CR->isBuiltinCall()) 4132980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 41331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4134588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 4135980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie Diag(Loc, diag::warn_floatingpoint_eq) 4136980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie << LHS->getSourceRange() << RHS->getSourceRange(); 4137588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 4138ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4139f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 4140f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 4141ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4142f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 4143ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4144f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 4145f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 4146f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 4147f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 4148f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 4149ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4150f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 4151f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 415251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4153f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 4154f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 4155f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 415651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 4158f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 4159f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 4160f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 416151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41621844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 41631844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 41641844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 41651844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 416651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 416751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41681844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 41691844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 4170f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 417151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4172f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 4173f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 4174f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 4175f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 4176323ed74658bc8375278eabf074b4777458376540John McCall 4177f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer // For enum types, use the known bit width of the enumerators. 4178323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 4179f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer EnumDecl *Enum = ET->getDecl(); 4180f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer if (!Enum->isCompleteDefinition()) 4181f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(C.getIntWidth(QualType(T, 0)), false); 4182091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4183f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer unsigned NumPositive = Enum->getNumPositiveBits(); 4184f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer unsigned NumNegative = Enum->getNumNegativeBits(); 4185323ed74658bc8375278eabf074b4777458376540John McCall 4186f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer if (NumNegative == 0) 4187f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(NumPositive, true/*NonNegative*/); 4188f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer else 4189f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(std::max(NumPositive + 1, NumNegative), 4190f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer false/*NonNegative*/); 4191323ed74658bc8375278eabf074b4777458376540John McCall } 419251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4193f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 4194f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 419551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4196f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 419751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 419851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 42001844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 42011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 42021844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 42031844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 42041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 42051844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 42061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 42071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 42081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 42091844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 42101844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 42111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 421269ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 42131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 42141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 42151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 42161844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 42171844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 42181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 42191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 42201844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 4221c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 4222f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 422360fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 422460fad45739b764886f707bd204eae9ecce6db1f2John McCall } 422560fad45739b764886f707bd204eae9ecce6db1f2John McCall 42261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 4227c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 422860fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 422960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 423051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4231f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 423251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 42330692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 42340692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4235f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 4236f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 423751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4238f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 42399f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 424051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4241f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 4242f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 4243f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 424451313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 424551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 42460692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 42470692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4248f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 4249f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 425051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4251f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 42520acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 42530acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 42540acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 42550acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 42560acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 4257f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 425851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 425951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4260f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 4261f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 4262f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 4263f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 4264f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4265f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4266f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 4267f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 42680acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 42690acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 42700acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 427165639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 42725e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 427351313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 427451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 427509bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedmanstatic QualType GetExprType(Expr *E) { 427609bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman QualType Ty = E->getType(); 427709bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman if (const AtomicType *AtomicRHS = Ty->getAs<AtomicType>()) 427809bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman Ty = AtomicRHS->getValueType(); 427909bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return Ty; 428009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman} 428109bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman 4282f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 4283f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 4284f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4285f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 42860692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 428751313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 428851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4289f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 4290f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 429151f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 429209bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return GetValueRange(C, result.Val, GetExprType(E), MaxWidth); 429351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4294f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 4295f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 4296f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 4297f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 4298b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 4299f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 430051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 430109bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman IntRange OutputTypeRange = IntRange::forValueOfType(C, GetExprType(CE)); 430251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 43032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 430460fad45739b764886f707bd204eae9ecce6db1f2John McCall 4305f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 430660fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 4307f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 430851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4309f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 4310f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 4311f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 431251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4313f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 4314f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 4315f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 431651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4317f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 4318f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 4319f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 4320f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 4321f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4322f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4323f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 4324f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 4325f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 4326f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 4327f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 4328f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 4329f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 4330f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4331f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 4332f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 4333f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 4334f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 433551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 433651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 433751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 433851313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 433951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4340f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 43412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 43422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 43432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 43442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 43452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 43462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 43472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 43482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 4349f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 435051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4351862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 4352862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 43532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 43542de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 43552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 43562de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 43572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 4358862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 4359862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 4360862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 436109bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 4362c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 4363862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 4364862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 4365862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 4366862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 4367862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4368862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 436951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 43702de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 43712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 437209bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 437351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 437460fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 43752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 43762de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 437760fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 437860fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 437960fad45739b764886f707bd204eae9ecce6db1f2John McCall 438051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 43812de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 43823aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 43833aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 43843aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 43853aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 43863aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 438709bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman IntRange R = IntRange::forValueOfType(C, GetExprType(E)); 43883aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 43893aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 43903aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 43913aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 43923aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 43932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 439409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 439551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 439660fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 43972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 43982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 439960fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 440060fad45739b764886f707bd204eae9ecce6db1f2John McCall 440160fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 440260fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 440360fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 440460fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 440560fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 440660fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 440760fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 440860fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 440960fad45739b764886f707bd204eae9ecce6db1f2John McCall else 441060fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 441160fad45739b764886f707bd204eae9ecce6db1f2John McCall } 441260fad45739b764886f707bd204eae9ecce6db1f2John McCall 441360fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 441460fad45739b764886f707bd204eae9ecce6db1f2John McCall } 441560fad45739b764886f707bd204eae9ecce6db1f2John McCall 441660fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 44172de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 4418f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4419f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 442060fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 44212de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 442251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 442309bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 442400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 442500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 442600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 442700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 442800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 442900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 443009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman unsigned opWidth = C.getIntWidth(GetExprType(E)); 443100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 443200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 443300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 443400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 443500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 443600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 443700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 443800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 443900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 444000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 444100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 444200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 444300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 444400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 444500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 444600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 444700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 444800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 444900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 445000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 445100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 445200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 445309bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman unsigned opWidth = C.getIntWidth(GetExprType(E)); 445400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 445500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 445600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 445700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 445800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 445900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 446000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 44614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 446200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 446300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 446400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 446500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 446600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 4467f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 446851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4469f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 447000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 447100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 4472f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4473f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 4474f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 447551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 447651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 447751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 447851313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 447951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 44802de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 4481f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 448251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 448351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 44842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 44852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 448609bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 448751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 448851313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 4489f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 449051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 449151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 449251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4493993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *BitField = E->getSourceBitField()) 4494a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 44955e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 4496f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 449709bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 4498f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4499f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 45000692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 450109bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return GetExprRange(C, E, C.getIntWidth(GetExprType(E))); 4502323ed74658bc8375278eabf074b4777458376540John McCall} 4503323ed74658bc8375278eabf074b4777458376540John McCall 4504f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4505f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4506f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 45070692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 45080692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 45090692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4510f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 4511f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4512f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 4513f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 4514f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 4515f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4516f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 451751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 451851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4519f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4520f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4521f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 4522f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4523f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 45240692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 45250692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 45260692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4527f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 4528f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 4529f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4530f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 4531f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 4532f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 4533f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 4534f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 4535f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4536f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4537f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 4538f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 4539f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 4540f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4541f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 45420692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 4543323ed74658bc8375278eabf074b4777458376540John McCall 4544e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 4545e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 4546e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 4547e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 4548e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 4549e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4550e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4551e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 4552e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 4553e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4554e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4555323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 4556323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 4557323ed74658bc8375278eabf074b4777458376540John McCall} 4558323ed74658bc8375278eabf074b4777458376540John McCall 4559372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 4560372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 4561372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 456263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 456363b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 4564372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 456563b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 4566372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 4567372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 4568372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 4569372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 4570372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 45710692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 45722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 457314af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 457414af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 457514af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 45762de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 4577323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4578372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 4579323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 45802de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 4581323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4582372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 4583323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 45842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 4585323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4586372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 4587323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 45882de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 4589323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4590372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 4591323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4592323ed74658bc8375278eabf074b4777458376540John McCall } 4593323ed74658bc8375278eabf074b4777458376540John McCall} 4594323ed74658bc8375278eabf074b4777458376540John McCall 459515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanianstatic void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, 4596a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian Expr *Constant, Expr *Other, 459715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt Value, 4598a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian bool RhsConstant) { 4599526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // 0 values are handled later by CheckTrivialUnsignedComparison(). 4600526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value == 0) 4601526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4602526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 460315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian BinaryOperatorKind op = E->getOpcode(); 4604a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType OtherT = Other->getType(); 4605a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType ConstantT = Constant->getType(); 4606526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu QualType CommonT = E->getLHS()->getType(); 4607a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT)) 460815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian return; 4609a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) 461015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian && "comparison with non-integer type"); 4611526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4612526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool ConstantSigned = ConstantT->isSignedIntegerType(); 4613526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool CommonSigned = CommonT->isSignedIntegerType(); 4614526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4615526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool EqualityOnly = false; 4616526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4617526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // TODO: Investigate using GetExprRange() to get tighter bounds on 4618526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // on the bit ranges. 461915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); 4620526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu unsigned OtherWidth = OtherRange.Width; 4621526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4622526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (CommonSigned) { 4623526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The common type is signed, therefore no signed to unsigned conversion. 4624d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (!OtherRange.NonNegative) { 4625526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4626526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4627526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getMinSignedBits()) 4628526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4629526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4630526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits() + 1) 4631526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4632526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4633526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !OtherSigned 4634526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4635526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Negative values are out of range. 4636526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4637526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits()) 4638526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4639526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4640526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4641526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4642526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4643526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4644526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !CommonSigned 4645d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (OtherRange.NonNegative) { 4646526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4647526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4648d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman } else if (!OtherRange.NonNegative && !ConstantSigned) { 4649526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is representable in OtherT. 4650526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth > Value.getActiveBits()) 4651526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4652526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is equivalent to a negative value 4653526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // cast to CommonT. 4654526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (S.Context.getIntWidth(ConstantT) == S.Context.getIntWidth(CommonT) && 46555d1cf4f292cb060b1973eb197607fc6d5716bd12Richard Trieu Value.isNegative() && Value.getMinSignedBits() <= OtherWidth) 4656526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4657526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The constant value rests between values that OtherT can represent after 4658526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // conversion. Relational comparison still works, but equality 4659526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // comparisons will be tautological. 4660526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu EqualityOnly = true; 4661526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // OtherSigned && ConstantSigned 4662526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu assert(0 && "Two signed types converted to unsigned types."); 4663526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4664526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4665526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4666526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool PositiveConstant = !ConstantSigned || Value.isNonNegative(); 4667526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 466815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsTrue = true; 4669526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (op == BO_EQ || op == BO_NE) { 4670526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = op == BO_NE; 4671526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (EqualityOnly) { 4672526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4673526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (RhsConstant) { 467415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_GT || op == BO_GE) 4675526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 467615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_LT || op == BO_LE 4677526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 4678a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else { 467915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_LT || op == BO_LE) 4680526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 468115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_GT || op == BO_GE 4682526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 468315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian } 46847adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 46857adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // If this is a comparison to an enum constant, include that 46867adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // constant in the diagnostic. 46877adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek const EnumConstantDecl *ED = 0; 46887adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant)) 46897adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek ED = dyn_cast<EnumConstantDecl>(DR->getDecl()); 46907adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 46917adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek SmallString<64> PrettySourceValue; 46927adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek llvm::raw_svector_ostream OS(PrettySourceValue); 46937adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (ED) 46949de50947ba381561a5236b3c878c83e4bb8c1088Ted Kremenek OS << '\'' << *ED << "' (" << Value << ")"; 46957adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek else 46967adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek OS << Value; 46977adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 4698a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian S.Diag(E->getOperatorLoc(), diag::warn_out_of_range_compare) 46997adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek << OS.str() << OtherT << IsTrue 4700526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 470115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian} 470215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4703323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 4704323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 47050692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 4706b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4707b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4708323ed74658bc8375278eabf074b4777458376540John McCall} 4709f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4710ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 4711ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 4712dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 47130692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 4714323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 4715323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 4716323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 4717323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 4718ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian if (E->isValueDependent()) 4719ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian return AnalyzeImpConvsInComparison(S, E); 4720323ed74658bc8375278eabf074b4777458376540John McCall 472115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 472215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 472315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 472415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsComparisonConstant = false; 472515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4726a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian // Check whether an integer constant comparison results in a value 472715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian // of 'true' or 'false'. 472815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (T->isIntegralType(S.Context)) { 472915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt RHSValue; 473015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsRHSIntegralLiteral = 473115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian RHS->isIntegerConstantExpr(RHSValue, S.Context); 473215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt LHSValue; 473315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsLHSIntegralLiteral = 473415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian LHS->isIntegerConstantExpr(LHSValue, S.Context); 473515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral) 473615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true); 473715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral) 473815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false); 473915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else 474015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsComparisonConstant = 474115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian (IsRHSIntegralLiteral && IsLHSIntegralLiteral); 4742a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else if (!T->hasUnsignedIntegerRepresentation()) 4743a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian IsComparisonConstant = E->isIntegerConstantExpr(S.Context); 474415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4745323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 4746323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 4747323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 47483e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 47493e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 47503e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 475115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant) 4752323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 475315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4754323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 4755323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 4756323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 4757dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 4758dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 4759323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 4760dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 4761dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 4762dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 4763dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 4764dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 4765ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 4766323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 4767323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 4768ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 4769ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4770323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 4771323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 4772f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4773323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 4774323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 4775dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 4776dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 4777ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4778323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 4779323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 4780323ed74658bc8375278eabf074b4777458376540John McCall // or false. 4781323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 4782323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 4783ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4784ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 4785ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 4786ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 4787ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 4788323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 4789323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 4790323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 4791323ed74658bc8375278eabf074b4777458376540John McCall 4792323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 4793323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 4794323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 4795ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4796323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 4797323ed74658bc8375278eabf074b4777458376540John McCall return; 4798323ed74658bc8375278eabf074b4777458376540John McCall } 4799323ed74658bc8375278eabf074b4777458376540John McCall 48006d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 48016d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.PDiag(diag::warn_mixed_sign_comparison) 48026d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getType() << RHS->getType() 48036d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getSourceRange() << RHS->getSourceRange()); 4804ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 4805ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 480615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 480715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 480815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 48090692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 48100692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 481115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 481215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 481315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 481415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 481591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 481691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 481791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 481891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 481946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 482046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 482146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 482246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 482346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 482446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 482546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 482615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 482715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 482880d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 482980d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 483015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 483115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 483215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 4833a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 483415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 483515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 483615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 483715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 48383a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 48399f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 48403a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 484115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 48423a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 48433a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 4844e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 484515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 484615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 48473a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 484834ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 484934ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 48503a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 48513a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 485215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 485315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 485415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 485515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 485615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 485715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 485815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 485915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 486015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 486115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4862beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 4863beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 48640692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 4865beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 4866beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4867beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4868beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 4869beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 4870993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) { 4871dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 487215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 487315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 487415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 487515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 4876beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4877beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4878beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4879beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4880beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 4881beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 488251313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 48830692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 4884c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4885c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4886c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 4887c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 4888c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 4889c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 4890c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 4891c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 4892c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 48935a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 48945a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 48955a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 48965a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4897e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 48980692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 4899c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4900c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4901c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 4902e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 4903e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 49049ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 49059ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 4906f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 4907f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 49089ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 4909f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 49109ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 49113e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 49123e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 49133e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 4914f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 49159ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 4916f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 4917f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4918be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie SmallString<16> PrettySourceValue; 4919be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie Value.toString(PrettySourceValue); 4920de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie SmallString<16> PrettyTargetValue; 4921be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (T->isSpecificBuiltinType(BuiltinType::Bool)) 4922be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie PrettyTargetValue = IntegerValue == 0 ? "false" : "true"; 4923be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie else 4924de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie IntegerValue.toString(PrettyTargetValue); 4925be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 49269ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 4927be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << FL->getType() << T.getUnqualifiedType() << PrettySourceValue 4928be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext); 4929f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 4930f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4931091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 4932091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 4933091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4934091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 4935091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 49369f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 4937091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 4938091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 4939091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 494088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 494188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!isa<ImplicitCastExpr>(Ex)) 494288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 494388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 494488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = Ex->IgnoreParenImpCasts(); 494588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 494688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Source = 494788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 494888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isDependentType()) 494988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 495088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 495188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const BuiltinType *FloatCandidateBT = 495288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg dyn_cast<BuiltinType>(ToBool ? Source : Target); 495388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *BoolCandidateType = ToBool ? Target : Source; 495488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 495588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 495688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 495788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 495888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 495988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 496088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg SourceLocation CC) { 496188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = TheCall->getNumArgs(); 496288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg for (unsigned i = 0; i < NumArgs; ++i) { 496388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *CurrA = TheCall->getArg(i); 496488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 496588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg continue; 496688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 496788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg bool IsSwapped = ((i > 0) && 496888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 496988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsSwapped |= ((i < (NumArgs - 1)) && 497088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 497188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (IsSwapped) { 497288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion. 497388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 497488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CurrA->getType(), CC, 497588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 497688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 497788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 497888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 497988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 4980323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 4981dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov SourceLocation CC, bool *ICContext = 0) { 4982323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 498351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4984323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 4985323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 4986323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 4987323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 498851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4989108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 4990108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 4991108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 4992108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 4993108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 4994ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 4995b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 4996b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4997f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 4998f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 4999f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 5000f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 5001f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 5002f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 5003f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 5004f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 5005e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 5006e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 5007e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 5008e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 5009e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 5010e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 5011e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 5012e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 5013e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 5014e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 5015e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 5016e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 5017e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 501826b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 501926b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 502026b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 50212def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 50222def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 50232def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 50242def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 5025c8fa525b5b81eeb7a62294dd3218ca2a6ccf0a6aDavid Blaikie S.tryExprAsCall(*E, ReturnType, NonTemplateOverloads); 50262def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 50272def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 50282def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 50292def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 50302def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 503126b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 503226b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 5033e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 5034e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 5035f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 503651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 503751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 503851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 5039ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 5040d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5041ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5042b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 5043ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 5044b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 5045b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 5046b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 5047b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 5048b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 504951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 505051313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 505151313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 505251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 505351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 505451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 505551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 5056ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 5057d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5058ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5059ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5060b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 5061ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 506251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 506351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 506451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 506551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 506651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 506751313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 506851313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 506951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 507051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 507151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 507251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 507351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 507451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 507551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 507651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 507751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 507851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 507951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 508051313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 508151f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 508251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 508351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 5084323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 5085323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 508651313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 508751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 508851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5089d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5090ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5091ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5092b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 509351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 509451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 509551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 509651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5097ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 5098be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (TargetBT && TargetBT->isInteger()) { 5099d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5100ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5101ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5102a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 5103634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 5104634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 5105634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 5106634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 5107634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 5108f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 5109f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 5110a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 5111a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 5112a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 5113a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 511451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 511588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // If the target is bool, warn if expr is a function or method call. 511688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isSpecificBuiltinType(BuiltinType::Bool) && 511788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg isa<CallExpr>(E)) { 511888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check last argument of function call to see if it is an 511988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // implicit cast from a type matching the type the result 512088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // is being cast to. 512188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CallExpr *CEx = cast<CallExpr>(E); 512288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = CEx->getNumArgs(); 512388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (NumArgs > 0) { 512488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *LastA = CEx->getArg(NumArgs - 1); 512588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = LastA->IgnoreParenImpCasts(); 512688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *InnerType = 512788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 512888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) { 512988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion 513088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, E, T, CC, 513188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 513288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 513388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 513488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 513551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 513651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 513751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 51381838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 5139b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie == Expr::NPCK_GNUNull) && !Target->isAnyPointerType() 5140e81b43bc306d361fcf4d411aeb14b43f8464bf4aDavid Blaikie && !Target->isBlockPointerType() && !Target->isMemberPointerType() 5141896c7dd62801c0aacf14b05183c3c471c1fe9f7aDavid Blaikie && Target->isScalarType() && !Target->isNullPtrType()) { 5142b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie SourceLocation Loc = E->getSourceRange().getBegin(); 5143b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie if (Loc.isMacroID()) 5144b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 51459fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie if (!Loc.isMacroID() || CC.isMacroID()) 51469fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 51479fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << T << clang::SourceRange(CC) 51489fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T)); 51491838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 51501838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 5151b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie if (!Source->isIntegerType() || !Target->isIntegerType()) 5152b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie return; 5153b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie 5154be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // TODO: remove this early return once the false positives for constant->bool 5155be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // in templates, macros, etc, are reduced or removed. 5156be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 5157be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie return; 5158be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 5159323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 51601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 516151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5162dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (SourceRange.Width > TargetRange.Width) { 516325ffbef84450f0c666957a2d00cdf928c61b44d7Sam Panzer // If the source is a constant, use a default-on diagnostic. 5164dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // TODO: this should happen for bitfield stores, too. 5165dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov llvm::APSInt Value(32); 5166dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (E->isIntegerConstantExpr(Value, S.Context)) { 5167dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5168dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5169dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 5170091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 5171091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 5172dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 51735e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 51745e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 51755e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 51765e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 51775e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 5178091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 5179091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 5180091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 5181dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // People want to build with -Wshorten-64-to-32 and not -Wconversion. 5182dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5183dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5184dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 518537050841d7b852497b85d5275d9ea92c07ddf059David Blaikie if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 5186c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 5187c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 5188b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 5189323ed74658bc8375278eabf074b4777458376540John McCall } 5190323ed74658bc8375278eabf074b4777458376540John McCall 5191323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 5192323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 5193323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 5194ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5195d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5196ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5197ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5198323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 5199323ed74658bc8375278eabf074b4777458376540John McCall 5200323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 5201323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 5202323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 5203323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 5204323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 5205323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 5206323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 5207323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 5208323ed74658bc8375278eabf074b4777458376540John McCall } 5209323ed74658bc8375278eabf074b4777458376540John McCall 5210b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 521151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 521251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5213284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 52145a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 52155a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 52165a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 52174e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!S.getLangOpts().CPlusPlus) { 52185a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 52195a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 52205a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 52215a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 52225a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 52235a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 52245a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 52255a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 5226284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 5227284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 522883972f128e9218c051692bf96361327a701aeb79John McCall if (SourceEnum->getDecl()->hasNameForLinkage() && 522983972f128e9218c051692bf96361327a701aeb79John McCall TargetEnum->getDecl()->hasNameForLinkage() && 5230ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 5231d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5232ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5233ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 52345a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 5235284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 5236ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 5237284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 523851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 523951313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 524051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 52419fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 52429fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T); 5243323ed74658bc8375278eabf074b4777458376540John McCall 5244323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 5245b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 5246323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 5247323ed74658bc8375278eabf074b4777458376540John McCall 5248323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 52499fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 5250323ed74658bc8375278eabf074b4777458376540John McCall 5251b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 5252323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5253b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 5254323ed74658bc8375278eabf074b4777458376540John McCall return; 5255323ed74658bc8375278eabf074b4777458376540John McCall} 5256323ed74658bc8375278eabf074b4777458376540John McCall 52579fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 52589fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T) { 5259b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 5260323ed74658bc8375278eabf074b4777458376540John McCall 5261323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 5262b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 5263b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 5264323ed74658bc8375278eabf074b4777458376540John McCall 5265323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 5266323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 5267323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 5268323ed74658bc8375278eabf074b4777458376540John McCall 5269323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 52700827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 52710827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 5272323ed74658bc8375278eabf074b4777458376540John McCall return; 5273323ed74658bc8375278eabf074b4777458376540John McCall 5274323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 5275323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 52765254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 52775254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 52785254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 52795254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 52805254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 52815254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 52825254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 5283b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 5284323ed74658bc8375278eabf074b4777458376540John McCall} 5285323ed74658bc8375278eabf074b4777458376540John McCall 5286323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 5287323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 5288323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 5289b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 5290323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 5291323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 5292323ed74658bc8375278eabf074b4777458376540John McCall 5293f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 5294f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 5295f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 5296323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 5297323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 5298323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 5299323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 53009fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie CheckConditionalOperator(S, CO, CC, T); 5301323ed74658bc8375278eabf074b4777458376540John McCall return; 5302323ed74658bc8375278eabf074b4777458376540John McCall } 5303323ed74658bc8375278eabf074b4777458376540John McCall 530488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check implicit argument conversions for function calls. 530588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (CallExpr *Call = dyn_cast<CallExpr>(E)) 530688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CheckImplicitArgumentConversions(S, Call, CC); 530788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 5308323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 5309323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 5310323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 5311323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5312b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 5313323ed74658bc8375278eabf074b4777458376540John McCall 5314323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 53156f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 53166f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian if (PseudoObjectExpr * POE = dyn_cast<PseudoObjectExpr>(E)) { 5317a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian if (POE->getResultExpr()) 5318a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian E = POE->getResultExpr(); 53196f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian } 53206f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 5321a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) 5322a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC); 5323a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian 5324323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 5325323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 5326323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 5327b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 5328323ed74658bc8375278eabf074b4777458376540John McCall } 5329323ed74658bc8375278eabf074b4777458376540John McCall 5330beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 5331beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 5332beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 5333beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 5334beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 5335dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // And with simple assignments. 5336dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (BO->getOpcode() == BO_Assign) 5337beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 5338beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 5339323ed74658bc8375278eabf074b4777458376540John McCall 5340323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 5341323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 5342323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 5343323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 5344323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 5345323ed74658bc8375278eabf074b4777458376540John McCall 5346323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 5347f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 5348323ed74658bc8375278eabf074b4777458376540John McCall 5349323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 5350b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 5351f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 5352f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 5353f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 535454042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 5355503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 5356503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 5357503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 5358f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 5359f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 5360f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 5361f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 5362f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 5363f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 5364323ed74658bc8375278eabf074b4777458376540John McCall} 5365323ed74658bc8375278eabf074b4777458376540John McCall 5366323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 5367323ed74658bc8375278eabf074b4777458376540John McCall 5368323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 5369323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 5370323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 5371b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 5372b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 5373b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 5374b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 5375b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 5376323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 537771f55f771794674a410171dbf3cb5dbedf95d033David Blaikie if (isUnevaluatedContext()) 5378323ed74658bc8375278eabf074b4777458376540John McCall return; 5379323ed74658bc8375278eabf074b4777458376540John McCall 5380323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 5381323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 5382323ed74658bc8375278eabf074b4777458376540John McCall return; 5383323ed74658bc8375278eabf074b4777458376540John McCall 5384d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 5385d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 5386d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 5387d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 5388d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5389b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 5390b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 5391323ed74658bc8375278eabf074b4777458376540John McCall} 5392323ed74658bc8375278eabf074b4777458376540John McCall 5393ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// Diagnose when expression is an integer constant expression and its evaluation 5394ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// results in integer overflow 5395ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckForIntOverflow (Expr *E) { 53961fd8d46d222fab7f17b91846e2c50bef640a60a0Fariborz Jahanian if (isa<BinaryOperator>(E->IgnoreParens())) { 5397ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian llvm::SmallVector<PartialDiagnosticAt, 4> Diags; 5398ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian E->EvaluateForOverflow(Context, &Diags); 5399ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian } 5400ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian} 5401ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian 54026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithnamespace { 54036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// \brief Visitor for expressions which looks for unsequenced operations on the 54046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// same object. 54056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithclass SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> { 54060c0b3909d11de7440d77556089516918b9c04cefRichard Smith typedef EvaluatedExprVisitor<SequenceChecker> Base; 54070c0b3909d11de7440d77556089516918b9c04cefRichard Smith 54086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A tree of sequenced regions within an expression. Two regions are 54096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced if one is an ancestor or a descendent of the other. When we 54106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// finish processing an expression with sequencing, such as a comma 54116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression, we fold its tree nodes into its parent, since they are 54126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced with respect to nodes we will visit later. 54136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class SequenceTree { 54146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Value { 54156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {} 54166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Parent : 31; 54176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Merged : 1; 54186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 54196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<Value, 8> Values; 54206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 54226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A region within an expression which may be sequenced with respect 54236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// to some other region. 54246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class Seq { 54256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Seq(unsigned N) : Index(N) {} 54266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Index; 54276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith friend class SequenceTree; 54286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 54296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq() : Index(0) {} 54306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 54316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree() { Values.push_back(Value(0)); } 54336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq root() const { return Seq(0); } 54346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Create a new sequence of operations, which is an unsequenced 54366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// subset of \p Parent. This sequence of operations is sequenced with 54376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// respect to other children of \p Parent. 54386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq allocate(Seq Parent) { 54396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values.push_back(Value(Parent.Index)); 54406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Seq(Values.size() - 1); 54416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Merge a sequence of operations into its parent. 54446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void merge(Seq S) { 54456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values[S.Index].Merged = true; 54466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Determine whether two operations are unsequenced. This operation 54496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// is asymmetric: \p Cur should be the more recent sequence, and \p Old 54506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// should have been merged into its parent as appropriate. 54516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool isUnsequenced(Seq Cur, Seq Old) { 54526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned C = representative(Cur.Index); 54536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Target = representative(Old.Index); 54546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith while (C >= Target) { 54556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (C == Target) 54566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return true; 54576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith C = Values[C].Parent; 54586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return false; 54606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith private: 54636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Pick a representative for a sequence. 54646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned representative(unsigned K) { 54656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Values[K].Merged) 54666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Perform path compression as we go. 54676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Values[K].Parent = representative(Values[K].Parent); 54686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return K; 54696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 54716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// An object for which we can track unsequenced uses. 54736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef NamedDecl *Object; 54746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Different flavors of object usage which we track. We only track the 54766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// least-sequenced usage of each kind. 54776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith enum UsageKind { 54786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A read of an object. Multiple unsequenced reads are OK. 54796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Use, 54806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is sequenced before the value 5481418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith /// computation of the expression, such as ++n in C++. 54826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsValue, 54836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is not sequenced before the value 54846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// computation of the expression, such as n++. 54856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsSideEffect, 54866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Count = UK_ModAsSideEffect + 1 54886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 54896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Usage { 54916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage() : Use(0), Seq() {} 54926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Use; 54936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Seq; 54946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 54956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct UsageInfo { 54976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo() : Diagnosed(false) {} 54986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage Uses[UK_Count]; 54996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Have we issued a diagnostic for this variable already? 55006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Diagnosed; 55016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 55026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap; 55036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Sema &SemaRef; 55056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Sequenced regions within the expression. 55066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree Tree; 55076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Declaration modifications and references which we have seen. 55086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfoMap UsageMap; 55096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// The region we are currently within. 55106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Region; 55116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Filled in with declarations which were modified as a side-effect 55126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// (that is, post-increment operations). 55136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect; 55141a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// Expressions to check later. We defer checking these to reduce 55151a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// stack usage. 55161a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList; 55176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// RAII object wrapping the visitation of a sequenced subexpression of an 55196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression. At the end of this process, the side-effects of the evaluation 55206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// become sequenced with respect to the value computation of the result, so 55216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// we downgrade any UK_ModAsSideEffect within the evaluation to 55226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// UK_ModAsValue. 55236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct SequencedSubexpression { 55246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression(SequenceChecker &Self) 55256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) { 55266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = &ModAsSideEffect; 55276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ~SequencedSubexpression() { 55296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0, E = ModAsSideEffect.size(); I != E; ++I) { 55306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = Self.UsageMap[ModAsSideEffect[I].first]; 55316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Uses[UK_ModAsSideEffect] = ModAsSideEffect[I].second; 55326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.addUsage(U, ModAsSideEffect[I].first, 55336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect[I].second.Use, UK_ModAsValue); 55346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = OldModAsSideEffect; 55366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceChecker &Self; 55396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect; 55406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect; 55416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 55426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5543674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// RAII object wrapping the visitation of a subexpression which we might 5544674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// choose to evaluate as a constant. If any subexpression is evaluated and 5545674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// found to be non-constant, this allows us to suppress the evaluation of 5546674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// the outer expression. 5547674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith class EvaluationTracker { 5548674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith public: 5549674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker(SequenceChecker &Self) 5550674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith : Self(Self), Prev(Self.EvalTracker), EvalOK(true) { 5551674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Self.EvalTracker = this; 5552674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5553674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith ~EvaluationTracker() { 5554674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Self.EvalTracker = Prev; 5555674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Prev) 5556674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Prev->EvalOK &= EvalOK; 5557674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5558674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 5559674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith bool evaluate(const Expr *E, bool &Result) { 5560674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (!EvalOK || E->isValueDependent()) 5561674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith return false; 5562674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvalOK = E->EvaluateAsBooleanCondition(Result, Self.SemaRef.Context); 5563674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith return EvalOK; 5564674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5565674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 5566674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith private: 5567674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith SequenceChecker &Self; 5568674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker *Prev; 5569674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith bool EvalOK; 5570674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } *EvalTracker; 5571674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 55726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Find the object which is produced by the specified expression, 55736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// if any. 55746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object getObject(Expr *E, bool Mod) const { 55756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = E->IgnoreParenCasts(); 55766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 55776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec)) 55786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(UO->getSubExpr(), Mod); 55796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 55806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (BO->getOpcode() == BO_Comma) 55816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getRHS(), Mod); 55826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && BO->isAssignmentOp()) 55836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getLHS(), Mod); 55846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) { 55856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: Check for more interesting cases, like "x.n = ++x.n". 55866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts())) 55876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return ME->getMemberDecl(); 55886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 55896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: If this is a reference, map through to its value. 55906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return DRE->getDecl(); 55916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return 0; 55926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Note that an object was modified or used by an expression. 55956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) { 55966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage &U = UI.Uses[UK]; 55976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) { 55986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UK == UK_ModAsSideEffect && ModAsSideEffect) 55996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect->push_back(std::make_pair(O, U)); 56006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Use = Ref; 56016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Seq = Region; 56026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Check whether a modification or use conflicts with a prior usage. 56056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind, 56066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool IsModMod) { 56076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UI.Diagnosed) 56086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 56096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith const Usage &U = UI.Uses[OtherKind]; 56116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) 56126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 56136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Mod = U.Use; 56156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *ModOrUse = Ref; 56166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (OtherKind == UK_Use) 56176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith std::swap(Mod, ModOrUse); 56186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SemaRef.Diag(Mod->getExprLoc(), 56206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith IsModMod ? diag::warn_unsequenced_mod_mod 56216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : diag::warn_unsequenced_mod_use) 56226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith << O << SourceRange(ModOrUse->getExprLoc()); 56236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UI.Diagnosed = true; 56246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreUse(Object O, Expr *Use) { 56276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 56286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Uses conflict with other modifications. 56296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsValue, false); 56306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostUse(Object O, Expr *Use) { 56326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 56336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, false); 56346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK_Use); 56356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreMod(Object O, Expr *Mod) { 56386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 56396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Modifications conflict with other modifications and with uses. 56406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_ModAsValue, true); 56416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_Use, false); 56426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostMod(Object O, Expr *Use, UsageKind UK) { 56446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 56456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, true); 56466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK); 56476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithpublic: 56501a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(Sema &S, Expr *E, 56511a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList) 56520c0b3909d11de7440d77556089516918b9c04cefRichard Smith : Base(S.Context), SemaRef(S), Region(Tree.root()), 56530c0b3909d11de7440d77556089516918b9c04cefRichard Smith ModAsSideEffect(0), WorkList(WorkList), EvalTracker(0) { 56546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 56556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitStmt(Stmt *S) { 56586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Skip all statements which aren't expressions for now. 56596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitExpr(Expr *E) { 56626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // By default, just recurse to evaluated subexpressions. 56630c0b3909d11de7440d77556089516918b9c04cefRichard Smith Base::VisitStmt(E); 56646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCastExpr(CastExpr *E) { 56676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = Object(); 56686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (E->getCastKind() == CK_LValueToRValue) 56696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith O = getObject(E->getSubExpr(), false); 56706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 56726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, E); 56736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitExpr(E); 56746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 56756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, E); 56766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinComma(BinaryOperator *BO) { 56796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.comma]p1: 56806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Every value computation and side effect associated with the left 56816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // expression is sequenced before every value computation and side 56826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // effect associated with the right expression. 56836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq LHS = Tree.allocate(Region); 56846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq RHS = Tree.allocate(Region); 56856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq OldRegion = Region; 56866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 56886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression SeqLHS(*this); 56896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = LHS; 56906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 56916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = RHS; 56946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 56956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = OldRegion; 56976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that LHS and RHS are sequenced. They are both unsequenced 56996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // with respect to other stuff. 57006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(LHS); 57016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(RHS); 57026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinAssign(BinaryOperator *BO) { 57056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The modification is sequenced after the value computation of the LHS 57066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // and RHS, so check it before inspecting the operands and update the 57076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // map afterwards. 57086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(BO->getLHS(), true); 57096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 57106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(BO); 57116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, BO); 57136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.ass]p7: 57156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated 57166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // only once. 57176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // 57186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Therefore, for a compound assignment operator, O is considered used 57196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // everywhere except within the evaluation of E1 itself. 57206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 57216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, BO); 57226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 57246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 57266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, BO); 57276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 57296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5730418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C++11 [expr.ass]p1: 5731418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // the assignment is sequenced [...] before the value computation of the 5732418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // assignment expression. 5733418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C11 6.5.16/3 has no such rule. 5734418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith notePostMod(O, BO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 5735418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith : UK_ModAsSideEffect); 57366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) { 57386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitBinAssign(CAO); 57396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 57426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 57436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreIncDec(UnaryOperator *UO) { 57446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 57456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 57466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 57476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 57496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 5750418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C++11 [expr.pre.incr]p1: 5751418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // the expression ++x is equivalent to x+=1 5752418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith notePostMod(O, UO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 5753418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith : UK_ModAsSideEffect); 57546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 57576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 57586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostIncDec(UnaryOperator *UO) { 57596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 57606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 57616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 57626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 57646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 57656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostMod(O, UO, UK_ModAsSideEffect); 57666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Don't visit the RHS of '&&' or '||' if it might not be evaluated. 57696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLOr(BinaryOperator *BO) { 57706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The side-effects of the LHS of an '&&' are sequenced before the 57716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // value computation of the RHS, and hence before the value computation 57726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // of the '&&' itself, unless the LHS evaluates to zero. We treat them 57736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // as if they were unconditionally sequenced. 5774674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 57756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 57766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 57776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 57786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5781674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(BO->getLHS(), Result)) { 5782995e4a7530d705147c875b63608532c483c011a8Richard Smith if (!Result) 5783995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5784995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 5785995e4a7530d705147c875b63608532c483c011a8Richard Smith // Check for unsequenced operations in the RHS, treating it as an 5786995e4a7530d705147c875b63608532c483c011a8Richard Smith // entirely separate evaluation. 5787995e4a7530d705147c875b63608532c483c011a8Richard Smith // 5788995e4a7530d705147c875b63608532c483c011a8Richard Smith // FIXME: If there are operations in the RHS which are unsequenced 5789995e4a7530d705147c875b63608532c483c011a8Richard Smith // with respect to operations outside the RHS, and those operations 5790995e4a7530d705147c875b63608532c483c011a8Richard Smith // are unconditionally evaluated, diagnose them. 57911a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5792995e4a7530d705147c875b63608532c483c011a8Richard Smith } 57936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLAnd(BinaryOperator *BO) { 5795674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 57966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 57976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 57986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 57996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5802674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(BO->getLHS(), Result)) { 5803995e4a7530d705147c875b63608532c483c011a8Richard Smith if (Result) 5804995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5805995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 58061a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5807995e4a7530d705147c875b63608532c483c011a8Richard Smith } 58086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Only visit the condition, unless we can be sure which subexpression will 58116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // be chosen. 58126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) { 5813674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 5814418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith { 5815418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith SequencedSubexpression Sequenced(*this); 5816418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith Visit(CO->getCond()); 5817418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith } 58186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5820674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(CO->getCond(), Result)) 58216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr()); 5822995e4a7530d705147c875b63608532c483c011a8Richard Smith else { 58231a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getTrueExpr()); 58241a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getFalseExpr()); 5825995e4a7530d705147c875b63608532c483c011a8Richard Smith } 58266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58280c0b3909d11de7440d77556089516918b9c04cefRichard Smith void VisitCallExpr(CallExpr *CE) { 58290c0b3909d11de7440d77556089516918b9c04cefRichard Smith // C++11 [intro.execution]p15: 58300c0b3909d11de7440d77556089516918b9c04cefRichard Smith // When calling a function [...], every value computation and side effect 58310c0b3909d11de7440d77556089516918b9c04cefRichard Smith // associated with any argument expression, or with the postfix expression 58320c0b3909d11de7440d77556089516918b9c04cefRichard Smith // designating the called function, is sequenced before execution of every 58330c0b3909d11de7440d77556089516918b9c04cefRichard Smith // expression or statement in the body of the function [and thus before 58340c0b3909d11de7440d77556089516918b9c04cefRichard Smith // the value computation of its result]. 58350c0b3909d11de7440d77556089516918b9c04cefRichard Smith SequencedSubexpression Sequenced(*this); 58360c0b3909d11de7440d77556089516918b9c04cefRichard Smith Base::VisitCallExpr(CE); 58370c0b3909d11de7440d77556089516918b9c04cefRichard Smith 58380c0b3909d11de7440d77556089516918b9c04cefRichard Smith // FIXME: CXXNewExpr and CXXDeleteExpr implicitly call functions. 58390c0b3909d11de7440d77556089516918b9c04cefRichard Smith } 58400c0b3909d11de7440d77556089516918b9c04cefRichard Smith 58416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCXXConstructExpr(CXXConstructExpr *CCE) { 58420c0b3909d11de7440d77556089516918b9c04cefRichard Smith // This is a call, so all subexpressions are sequenced before the result. 58430c0b3909d11de7440d77556089516918b9c04cefRichard Smith SequencedSubexpression Sequenced(*this); 58440c0b3909d11de7440d77556089516918b9c04cefRichard Smith 58456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!CCE->isListInitialization()) 58466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(CCE); 58476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 58496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 58506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 58516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(), 58526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = CCE->arg_end(); 58536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith I != E; ++I) { 58546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 58556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 58566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(*I); 58576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 58606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 58616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 58626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 58636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitInitListExpr(InitListExpr *ILE) { 58666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!SemaRef.getLangOpts().CPlusPlus11) 58676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(ILE); 58686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 58706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 58716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 58726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < ILE->getNumInits(); ++I) { 58736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *E = ILE->getInit(I); 58746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!E) continue; 58756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 58766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 58776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 58786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 58816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 58826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 58836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 58846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 58856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith}; 58866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 58876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 58886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithvoid Sema::CheckUnsequencedOperations(Expr *E) { 58891a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVector<Expr*, 8> WorkList; 58901a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(E); 58911a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith while (!WorkList.empty()) { 58921a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith Expr *Item = WorkList.back(); 58931a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.pop_back(); 58941a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(*this, Item, WorkList); 58951a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith } 58966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 58976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5898ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc, 5899ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian bool IsConstexpr) { 59006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckImplicitConversions(E, CheckLoc); 59016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckUnsequencedOperations(E); 5902ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian if (!IsConstexpr && !E->isValueDependent()) 5903ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian CheckForIntOverflow(E); 59046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 59056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 590615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 590715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 590815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 590915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 591015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 591115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 5912f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 5913f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 5914f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 5915f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 5916f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 59178c0501c7370d894a735692b92fab62bbb05d86bdReid Klecknerbool Sema::CheckParmsForFunctionDef(ParmVarDecl *const *P, 59188c0501c7370d894a735692b92fab62bbb05d86bdReid Kleckner ParmVarDecl *const *PEnd, 591982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 5920f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 592182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 592282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 592382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 5924f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 5925f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 5926f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 5927f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 5928f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 5929f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 5930f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 5931d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_typecheck_decl_incomplete_type)) { 5932f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 5933f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 5934f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5935f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5936f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 5937f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 593882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 593982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 5940f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 59414e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().CPlusPlus) 5942f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 5943d17e340e2d516139931768697bf080f60920ba9dSam Weinig 5944d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 5945d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 5946d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 5947d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 5948d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 5949d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 5950d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian while (const ArrayType *AT = Context.getAsArrayType(PType)) { 5951d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 5952fc09336a5965040736f9bc63a70416003972364eStefanus Du Toit // FIXME: This diagnostic should point the '[*]' if source-location 5953d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 5954d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 5955d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian break; 5956d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 5957d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian PType= AT->getElementType(); 5958d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 59599b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner 59609b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // MSVC destroys objects passed by value in the callee. Therefore a 59619b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // function definition which takes such a parameter must be able to call the 59629b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // object's destructor. 59639b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner if (getLangOpts().CPlusPlus && 59649b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner Context.getTargetInfo().getCXXABI().isArgumentDestroyedByCallee()) { 59659b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner if (const RecordType *RT = Param->getType()->getAs<RecordType>()) 59669b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner FinalizeVarWithDestructor(Param, RT); 59679b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner } 5968f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5969f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5970f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 5971f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 5972b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5973b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 5974b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 5975b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 5976b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 5977b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 59780827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 59790827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 5980d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 5981b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5982b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5983b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 5984b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 5985b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5986b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5987b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 5988b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 5989b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 5990b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5991b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 5992b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 5993b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 5994b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 5995b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 5996b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5997b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 5998b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 5999b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 6000b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 6001b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6002b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 6003b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 6004b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 6005b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 6006b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 6007b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6008b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 6009b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 6010b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6011b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 6012b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 6013b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 6014b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 6015b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 6016b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 6017b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 6018d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 6019d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 6020d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 6021d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 6022d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 6023d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 6024d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 6025d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 6026d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6027c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 6028c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 6029c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 6030c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 6031c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 6032c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 6033c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 6034c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 6035c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 6036c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 6037c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 6038c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 6039c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 6040c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 6041d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan 6042d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 604300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek while (TInfo) { 604400e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TypeLoc TL = TInfo->getTypeLoc(); 604500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek // Look through typedefs. 604639e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) { 604739e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const TypedefNameDecl *TDL = TTL.getTypedefNameDecl(); 604800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TInfo = TDL->getTypeSourceInfo(); 604900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek continue; 605000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek } 605139e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) { 605239e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 60535e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 60545e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier return false; 60555e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier } 605600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek break; 6057d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan } 6058c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 6059c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 6060381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 6061381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 6062381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 6063381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 6064381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 6065c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 606622d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 606722d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 606822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 606922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 607022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 607122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 6072c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 6073c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 6074d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 607580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 607625b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 607792b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman IndexExpr = IndexExpr->IgnoreParenImpCasts(); 607880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 607980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 6080d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 608180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 608280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 60833406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 6084d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 60853406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 6086a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 608735001ca261f895817916b468379b696d6d45959dChandler Carruth 60883406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 608980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 6090a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 609125b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 609225b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 60938fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 6094ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 6095ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 6096ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 6097c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 6098ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 6099ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 61009e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 610125b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 610235001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 610335001ca261f895817916b468379b696d6d45959dChandler Carruth return; 6104d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6105d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 6106de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 6107d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 6108d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 6109d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 6110d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 611118f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 6112d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 6113d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 6114d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 6115d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 6116d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 6117d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 6118d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 6119d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6120d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6121d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 61223406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 612392b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman index = index.zext(size.getBitWidth()); 612425b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 612592b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman size = size.zext(index.getBitWidth()); 612625b3b849e3ad340b04442707038c86980035765bTed Kremenek 6127d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 6128d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 6129d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 6130d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 613192b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 6132ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 6133ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 6134ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 6135ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 6136ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 6137d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 61388fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 61393406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 614080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 614180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 614280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 614380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 614480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 614580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 614680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 614780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 614880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 614980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 615080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 615180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 615280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 615380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 6154d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 615580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 6156d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 6157d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6158d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6159d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 6160d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 6161d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 6162d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 61633406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 6164d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 616580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 6166d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 6167d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 6168d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6169d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6170d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6171d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 6172d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 6173a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 617435001ca261f895817916b468379b696d6d45959dChandler Carruth 6175cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 6176cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 6177cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 6178cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 6179cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 6180cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 6181cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 6182cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 6183cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 6184cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 6185cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 618635001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 6187d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 6188d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 6189d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 61903aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 61913aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 61923aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 6193d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 6194d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 6195d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 61963aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 6197d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 6198d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 619980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 6200d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 62013aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 6202d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6203d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 6204d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 6205d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 6206d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 6207d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 6208d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 6209d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 6210d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6211d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 6212d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 6213d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6214d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 6215d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 6216d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6217d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6218d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 62193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 62203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 62213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 62223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 62233aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 62243aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 62253aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 62263aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 62273aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 62283aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 62293aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 6230f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 6231a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 6232f85e193739c953358c865005855253af4f68a497John McCall 6233f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 6234f85e193739c953358c865005855253af4f68a497John McCall 6235f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6236f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 6237f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 6238f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6239f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 6240f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 6241f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 6242f85e193739c953358c865005855253af4f68a497John McCall 6243f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 6244f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 6245f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 6246f85e193739c953358c865005855253af4f68a497John McCall } 6247f85e193739c953358c865005855253af4f68a497John McCall }; 6248f85e193739c953358c865005855253af4f68a497John McCall} 6249f85e193739c953358c865005855253af4f68a497John McCall 6250f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 6251f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 6252f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 6253f3477c13eeaf11b32a41f181398fb5deffd0dd73Sylvestre Ledru // In ARC, it's captured strongly iff the variable has __strong 6254f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 6255f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 6256f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6257f85e193739c953358c865005855253af4f68a497John McCall return false; 6258f85e193739c953358c865005855253af4f68a497John McCall 6259f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 6260e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (ref) 6261e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose owner.setLocsFrom(ref); 6262f85e193739c953358c865005855253af4f68a497John McCall return true; 6263f85e193739c953358c865005855253af4f68a497John McCall} 6264f85e193739c953358c865005855253af4f68a497John McCall 62656e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 6266f85e193739c953358c865005855253af4f68a497John McCall while (true) { 6267f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 6268f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 6269f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 6270f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 6271f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 6272f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 627333e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 6274f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 6275f85e193739c953358c865005855253af4f68a497John McCall continue; 6276f85e193739c953358c865005855253af4f68a497John McCall 6277f85e193739c953358c865005855253af4f68a497John McCall default: 6278f85e193739c953358c865005855253af4f68a497John McCall return false; 6279f85e193739c953358c865005855253af4f68a497John McCall } 6280f85e193739c953358c865005855253af4f68a497John McCall } 6281f85e193739c953358c865005855253af4f68a497John McCall 6282f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 6283f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 6284f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6285f85e193739c953358c865005855253af4f68a497John McCall return false; 6286f85e193739c953358c865005855253af4f68a497John McCall 6287f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 62886e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 6289f85e193739c953358c865005855253af4f68a497John McCall return false; 6290f85e193739c953358c865005855253af4f68a497John McCall 6291f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 6292f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 6293f85e193739c953358c865005855253af4f68a497John McCall return true; 6294f85e193739c953358c865005855253af4f68a497John McCall } 6295f85e193739c953358c865005855253af4f68a497John McCall 6296f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 6297f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 6298f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 6299f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 6300f85e193739c953358c865005855253af4f68a497John McCall } 6301f85e193739c953358c865005855253af4f68a497John McCall 6302f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 6303f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 6304f85e193739c953358c865005855253af4f68a497John McCall 6305f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 6306f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 6307f85e193739c953358c865005855253af4f68a497John McCall continue; 6308f85e193739c953358c865005855253af4f68a497John McCall } 6309f85e193739c953358c865005855253af4f68a497John McCall 63104b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 63114b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 63124b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 63134b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 63144b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 63154b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 63164b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 63174b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 63184b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 63194b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 63204b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 63214b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 63224b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 63234b9c2d235fb9449e249d74f48ecfec601650de93John McCall 63244b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 63256e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 63266e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 63276e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 63286e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 63296e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 63306e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 63316e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 63326e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 63334b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 63344b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 63354b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 63364b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 63374b9c2d235fb9449e249d74f48ecfec601650de93John McCall 6338f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 6339f85e193739c953358c865005855253af4f68a497John McCall 6340f85e193739c953358c865005855253af4f68a497John McCall return false; 6341f85e193739c953358c865005855253af4f68a497John McCall } 6342f85e193739c953358c865005855253af4f68a497John McCall} 6343f85e193739c953358c865005855253af4f68a497John McCall 6344f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6345f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 6346f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 6347f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 6348f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 6349f85e193739c953358c865005855253af4f68a497John McCall 6350f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6351f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 6352f85e193739c953358c865005855253af4f68a497John McCall 6353f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 6354f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 6355f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6356f85e193739c953358c865005855253af4f68a497John McCall } 6357f85e193739c953358c865005855253af4f68a497John McCall 6358f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 6359f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 6360f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 6361f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 6362f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6363f85e193739c953358c865005855253af4f68a497John McCall } 6364f85e193739c953358c865005855253af4f68a497John McCall 6365f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 6366f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 6367f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 6368f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 6369f85e193739c953358c865005855253af4f68a497John McCall } 63707e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian 63717e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 63727e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (Capturer) return; 63737e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (OVE->getSourceExpr()) 63747e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian Visit(OVE->getSourceExpr()); 63757e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian } 6376f85e193739c953358c865005855253af4f68a497John McCall }; 6377f85e193739c953358c865005855253af4f68a497John McCall} 6378f85e193739c953358c865005855253af4f68a497John McCall 6379f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 6380f85e193739c953358c865005855253af4f68a497John McCall/// variable. 6381f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 6382f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6383f85e193739c953358c865005855253af4f68a497John McCall 6384f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 63851fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 63861fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose // Look through [^{...} copy] and Block_copy(^{...}). 63871fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) { 63881fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose Selector Cmd = ME->getSelector(); 63891fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") { 63901fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = ME->getInstanceReceiver(); 63911fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (!e) 63921fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose return 0; 63931fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = e->IgnoreParenCasts(); 63941fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 63951fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) { 63961fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (CE->getNumArgs() == 1) { 63971fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl()); 6398d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (Fn) { 6399d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek const IdentifierInfo *FnI = Fn->getIdentifier(); 6400d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (FnI && FnI->isStr("_Block_copy")) { 6401d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek e = CE->getArg(0)->IgnoreParenCasts(); 6402d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 6403d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 64041fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 64051fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 64061fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 6407f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 6408f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 6409f85e193739c953358c865005855253af4f68a497John McCall return 0; 6410f85e193739c953358c865005855253af4f68a497John McCall 6411f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 6412f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 6413f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 6414f85e193739c953358c865005855253af4f68a497John McCall} 6415f85e193739c953358c865005855253af4f68a497John McCall 6416f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 6417f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 6418f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 6419f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6420f85e193739c953358c865005855253af4f68a497John McCall 6421f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 6422f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 6423f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 6424f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 6425f85e193739c953358c865005855253af4f68a497John McCall} 6426f85e193739c953358c865005855253af4f68a497John McCall 6427f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 6428f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 6429f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 6430f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 6431f85e193739c953358c865005855253af4f68a497John McCall 64325f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 6433f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 6434968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 6435f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 6436968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 6437968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 6438968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 6439968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 6440968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 6441968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 6442f85e193739c953358c865005855253af4f68a497John McCall else 6443f85e193739c953358c865005855253af4f68a497John McCall return false; 6444f85e193739c953358c865005855253af4f68a497John McCall 6445f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 64463f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose return !isLowercase(str.front()); 6447f85e193739c953358c865005855253af4f68a497John McCall} 6448f85e193739c953358c865005855253af4f68a497John McCall 6449f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 6450f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 6451f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 6452f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 6453f85e193739c953358c865005855253af4f68a497John McCall return; 6454f85e193739c953358c865005855253af4f68a497John McCall 6455f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 6456f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 6457f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 64586e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 6459f85e193739c953358c865005855253af4f68a497John McCall return; 6460f85e193739c953358c865005855253af4f68a497John McCall } else { 6461f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 6462f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 6463f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 6464f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 6465f85e193739c953358c865005855253af4f68a497John McCall } 6466f85e193739c953358c865005855253af4f68a497John McCall 6467f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 6468f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 6469f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 6470f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 6471f85e193739c953358c865005855253af4f68a497John McCall} 6472f85e193739c953358c865005855253af4f68a497John McCall 6473f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 6474f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 6475f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 64766e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 6477f85e193739c953358c865005855253af4f68a497John McCall return; 6478f85e193739c953358c865005855253af4f68a497John McCall 6479f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 6480f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 6481f85e193739c953358c865005855253af4f68a497John McCall} 6482f85e193739c953358c865005855253af4f68a497John McCall 6483e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rosevoid Sema::checkRetainCycles(VarDecl *Var, Expr *Init) { 6484e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose RetainCycleOwner Owner; 6485e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner)) 6486e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose return; 6487e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6488e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // Because we don't have an expression for the variable, we have to set the 6489e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // location explicitly here. 6490e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Loc = Var->getLocation(); 6491e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Range = Var->getSourceRange(); 6492e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6493e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (Expr *Capturer = findCapturingExpr(*this, Init, Owner)) 6494e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose diagnoseRetainCycle(*this, Capturer, Owner); 6495e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose} 6496e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 64979d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenekstatic bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc, 64989d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek Expr *RHS, bool isProperty) { 64999d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // Check if RHS is an Objective-C object literal, which also can get 65009d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // immediately zapped in a weak reference. Note that we explicitly 65019d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // allow ObjCStringLiterals, since those are designed to never really die. 65029d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek RHS = RHS->IgnoreParenImpCasts(); 6503f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6504d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // This enum needs to match with the 'select' in 6505d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // warn_objc_arc_literal_assign (off-by-1). 6506d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS); 6507d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek if (Kind == Sema::LK_String || Kind == Sema::LK_None) 6508d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek return false; 6509f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6510f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek S.Diag(Loc, diag::warn_arc_literal_assign) 6511d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek << (unsigned) Kind 65129d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << (isProperty ? 0 : 1) 65139d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << RHS->getSourceRange(); 6514f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6515f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek return true; 65169d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek} 65179d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek 6518b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenekstatic bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc, 6519b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Qualifiers::ObjCLifetime LT, 6520b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Expr *RHS, bool isProperty) { 6521b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek // Strip off any implicit cast added to get to the one ARC-specific. 6522b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 6523b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (cast->getCastKind() == CK_ARCConsumeObject) { 6524b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek S.Diag(Loc, diag::warn_arc_retained_assign) 6525b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (LT == Qualifiers::OCL_ExplicitNone) 6526b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (isProperty ? 0 : 1) 6527b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << RHS->getSourceRange(); 6528b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6529b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6530b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek RHS = cast->getSubExpr(); 6531b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6532b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6533b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (LT == Qualifiers::OCL_Weak && 6534b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek checkUnsafeAssignLiteral(S, Loc, RHS, isProperty)) 6535b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6536b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6537b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return false; 6538b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek} 6539b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6540b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenekbool Sema::checkUnsafeAssigns(SourceLocation Loc, 6541b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek QualType LHS, Expr *RHS) { 6542b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 6543b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6544b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 6545b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6546b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6547b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false)) 6548b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return true; 6549b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6550b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6551b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek} 6552b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6553921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 6554921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 655587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 655687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 655787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 655887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 655987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 656087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 656187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 656287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 656387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 656487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 656587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 656687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 656787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 65687a2704800943fbb69207e125d28186278712af36Jordan Rose 65697a2704800943fbb69207e125d28186278712af36Jordan Rose Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 65707a2704800943fbb69207e125d28186278712af36Jordan Rose 65717a2704800943fbb69207e125d28186278712af36Jordan Rose if (LT == Qualifiers::OCL_Weak) { 65727a2704800943fbb69207e125d28186278712af36Jordan Rose DiagnosticsEngine::Level Level = 65737a2704800943fbb69207e125d28186278712af36Jordan Rose Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak, Loc); 65747a2704800943fbb69207e125d28186278712af36Jordan Rose if (Level != DiagnosticsEngine::Ignored) 65757a2704800943fbb69207e125d28186278712af36Jordan Rose getCurFunction()->markSafeWeakUse(LHS); 65767a2704800943fbb69207e125d28186278712af36Jordan Rose } 65777a2704800943fbb69207e125d28186278712af36Jordan Rose 6578921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 6579921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 65807a2704800943fbb69207e125d28186278712af36Jordan Rose 6581921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 6582921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 6583921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6584921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 658587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 6586921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 6587921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6588921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 6589921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 6590921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6591921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 6592ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = PD->getPropertyAttributes(); 6593ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 659487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 659587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 659687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 659787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 659887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 659987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 660087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 660187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 6602921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 660333e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 6604921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 6605921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 6606921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6607921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6608921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 6609921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 661087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 6611ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 6612b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true)) 6613b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return; 6614bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 6615921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6616921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 6617625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6618625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 6619625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6620625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace { 6621625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 6622625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc, 6623625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *Body) { 6624625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do not warn if the body is a macro that expands to nothing, e.g: 6625625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6626625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // #define CALL(x) 6627625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // if (condition) 6628625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CALL(0); 6629625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6630625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Body->hasLeadingEmptyMacro()) 6631625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6632625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6633625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Get line numbers of statement and body. 6634625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtLineInvalid; 6635625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 6636625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtLineInvalid); 6637625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLineInvalid) 6638625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6639625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6640625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyLineInvalid; 6641625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 6642625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyLineInvalid); 6643625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyLineInvalid) 6644625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6645625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6646625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Warn if null statement and body are on the same line. 6647625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLine != BodyLine) 6648625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6649625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6650625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return true; 6651625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6652625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace 6653625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6654625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 6655625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body, 6656625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID) { 6657625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Since this is a syntactic check, don't emit diagnostic for template 6658625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // instantiations, this just adds noise. 6659625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (CurrentInstantiationScope) 6660625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6661625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6662625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6663625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6664625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6665625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6666625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6667625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6668625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6669625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6670625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6671625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6672625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6673625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6674625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6675625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S, 6676625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *PossibleBody) { 6677625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko assert(!CurrentInstantiationScope); // Ensured by caller 6678625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6679625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc; 6680625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body; 6681625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID; 6682625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 6683625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = FS->getRParenLoc(); 6684625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = FS->getBody(); 6685625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_for_body; 6686625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 6687625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = WS->getCond()->getSourceRange().getEnd(); 6688625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = WS->getBody(); 6689625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_while_body; 6690625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else 6691625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; // Neither `for' nor `while'. 6692625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6693625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6694625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6695625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6696625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6697625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6698625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Skip expensive checks if diagnostic is disabled. 6699625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 6700625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagnosticsEngine::Ignored) 6701625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6702625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6703625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6704625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6705625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6706625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6707625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // `for(...);' and `while(...);' are popular idioms, so in order to keep 6708625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // noise level low, emit diagnostics only if for/while is followed by a 6709625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CompoundStmt, e.g.: 6710625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6711625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // { 6712625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6713625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // } 6714625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // or if for/while is followed by a statement with more indentation 6715625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // than for/while itself: 6716625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6717625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6718625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 6719625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ProbableTypo) { 6720625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyColInvalid; 6721625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 6722625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko PossibleBody->getLocStart(), 6723625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyColInvalid); 6724625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyColInvalid) 6725625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6726625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6727625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtColInvalid; 6728625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 6729625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko S->getLocStart(), 6730625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtColInvalid); 6731625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtColInvalid) 6732625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6733625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6734625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyCol > StmtCol) 6735625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko ProbableTypo = true; 6736625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6737625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6738625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (ProbableTypo) { 6739625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6740625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6741625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6742625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 67430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------// 67450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 67470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 67490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible. 67510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 67520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [dcl.enum] p8: 67530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Two enumeration types are layout-compatible if they have the same 67540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // underlying type. 67550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return ED1->isComplete() && ED2->isComplete() && 67560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 67570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible. 67600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 67610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 67620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField() != Field2->isBitField()) 67650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField()) { 67680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Make sure that the bit-fields are the same length. 67690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits1 = Field1->getBitWidthValue(C); 67700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits2 = Field2->getBitWidthValue(C); 67710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Bits1 != Bits2) 67730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 67770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible. 67800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17) 67810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C, 67820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 67830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 67840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If both records are C++ classes, check that base classes match. 67850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 67860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If one of records is a CXXRecordDecl we are in C++ mode, 67870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // thus the other one is a CXXRecordDecl, too. 67880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 67890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check number of base classes. 67900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D1CXX->getNumBases() != D2CXX->getNumBases()) 67910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the base classes. 67940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (CXXRecordDecl::base_class_const_iterator 67950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 = D1CXX->bases_begin(), 67960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BaseEnd1 = D1CXX->bases_end(), 67970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base2 = D2CXX->bases_begin(); 67980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 != BaseEnd1; 67990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ++Base1, ++Base2) { 68000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 68010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 68040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If only RD2 is a C++ class, it should have zero base classes. 68050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D2CXX->getNumBases() > 0) 68060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the fields. 68100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl::field_iterator Field2 = RD2->field_begin(), 68110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(), 68120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 = RD1->field_begin(), 68130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 68140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 68150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, *Field1, *Field2)) 68160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1 != Field1End || Field2 != Field2End) 68190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 68220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible. 68250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18) 68260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C, 68270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 68280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 68290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 68300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field2 = RD2->field_begin(), 68310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(); 68320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2 != Field2End; ++Field2) { 68330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko UnmatchedFields.insert(*Field2); 68340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field1 = RD1->field_begin(), 68370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 68380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 != Field1End; ++Field1) { 68390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8>::iterator 68400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = UnmatchedFields.begin(), 68410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = UnmatchedFields.end(); 68420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; I != E; ++I) { 68440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (isLayoutCompatible(C, *Field1, *I)) { 68450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result = UnmatchedFields.erase(*I); 68460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (void) Result; 68470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko assert(Result); 68480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko break; 68490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == E) 68520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return UnmatchedFields.empty(); 68560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 68590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion() != RD2->isUnion()) 68600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion()) 68630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleUnion(C, RD1, RD2); 68640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 68650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleStruct(C, RD1, RD2); 68660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense. 68690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 68700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (T1.isNull() || T2.isNull()) 68710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.types] p11: 68740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If two types T1 and T2 are the same type, then T1 and T2 are 68750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // layout-compatible types. 68760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (C.hasSameType(T1, T2)) 68770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 68780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T1 = T1.getCanonicalType().getUnqualifiedType(); 68800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T2 = T2.getCanonicalType().getUnqualifiedType(); 68810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC1 = T1->getTypeClass(); 68830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC2 = T2->getTypeClass(); 68840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 != TC2) 68860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 == Type::Enum) { 68890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 68900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T1)->getDecl(), 68910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T2)->getDecl()); 68920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (TC1 == Type::Record) { 68930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 68940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 68970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T1)->getDecl(), 68980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T2)->getDecl()); 68990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 69060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 69080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself. 69090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code. 69110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag. 69130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value. 69150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 69160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl **VD, uint64_t *MagicValue) { 69170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko while(true) { 69180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeExpr) 69190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 69220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko switch (TypeExpr->getStmtClass()) { 69240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::UnaryOperatorClass: { 69250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 69260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 69270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = UO->getSubExpr(); 69280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 69290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::DeclRefExprClass: { 69340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 69350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *VD = DRE->getDecl(); 69360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 69370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::IntegerLiteralClass: { 69400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 69410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::APInt MagicValueAPInt = IL->getValue(); 69420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (MagicValueAPInt.getActiveBits() <= 64) { 69430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *MagicValue = MagicValueAPInt.getZExtValue(); 69440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 69450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 69460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryConditionalOperatorClass: 69500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::ConditionalOperatorClass: { 69510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const AbstractConditionalOperator *ACO = 69520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<AbstractConditionalOperator>(TypeExpr); 69530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result; 69540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 69550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Result) 69560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getTrueExpr(); 69570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 69580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getFalseExpr(); 69590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 69600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryOperatorClass: { 69650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 69660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (BO->getOpcode() == BO_Comma) { 69670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = BO->getRHS(); 69680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 69690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko default: 69740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr. 69800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag. 69820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values. 69840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 69860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// kind. 69870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type. 69890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 69900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found. 69910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType( 69920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind, 69930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeExpr, const ASTContext &Ctx, 69940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const llvm::DenseMap<Sema::TypeTagMagicValue, 69950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData> *MagicValues, 69960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool &FoundWrongKind, 69970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData &TypeInfo) { 69980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = false; 69990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Variable declaration that has type_tag_for_datatype attribute. 70010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl *VD = NULL; 70020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue; 70040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 70060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (VD) { 70090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<TypeTagForDatatypeAttr> 70100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(), 70110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = VD->specific_attr_end<TypeTagForDatatypeAttr>(); 70120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I != E; ++I) { 70130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I->getArgumentKind() != ArgumentKind) { 70140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = true; 70150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.Type = I->getMatchingCType(); 70180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 70190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.MustBeNull = I->getMustBeNull(); 70200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 70210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!MagicValues) 70260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::DenseMap<Sema::TypeTagMagicValue, 70290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData>::const_iterator I = 70300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 70310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == MagicValues->end()) 70320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo = I->second; 70350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 70360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 70370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 70380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 70400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue, QualType Type, 70410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool LayoutCompatible, 70420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool MustBeNull) { 70430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeTagForDatatypeMagicValues) 70440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.reset( 70450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 70460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagMagicValue Magic(ArgumentKind, MagicValue); 70480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (*TypeTagForDatatypeMagicValues)[Magic] = 70490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData(Type, LayoutCompatible, MustBeNull); 70500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 70510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 70530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) { 70540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 70550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT1) 70560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 70590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT2) 70600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 70610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T1Kind = BT1->getKind(); 70630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T2Kind = BT2->getKind(); 70640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 70660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 70670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 70680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 70690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 70700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 70710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 70730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr * const *ExprArgs) { 70740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 70750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool IsPointerAttr = Attr->getIsPointer(); 70760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 70780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool FoundWrongKind; 70790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData TypeInfo; 70800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 70810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.get(), 70820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind, TypeInfo)) { 70830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (FoundWrongKind) 70840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(TypeTagExpr->getExprLoc(), 70850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_tag_for_datatype_wrong_kind) 70860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 70870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 70880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 70910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) { 70920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Skip implicit cast of pointer to `void *' (as a function argument). 70930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 70945a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko if (ICE->getType()->isVoidPointerType() && 7095b57ce4e8918656f5f4070f59d74354fcefbbb6f8Dmitri Gribenko ICE->getCastKind() == CK_BitCast) 70960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentExpr = ICE->getSubExpr(); 70970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType ArgumentType = ArgumentExpr->getType(); 70990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Passing a `void*' pointer shouldn't trigger a warning. 71010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr && ArgumentType->isVoidPointerType()) 71020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 71030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TypeInfo.MustBeNull) { 71050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type tag with matching void type requires a null pointer. 71060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!ArgumentExpr->isNullPointerConstant(Context, 71070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Expr::NPC_ValueDependentIsNotNull)) { 71080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), 71090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_safety_null_pointer_required) 71100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentKind->getName() 71110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 71120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 71130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 71140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 71150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 71160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType RequiredType = TypeInfo.Type; 71180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 71190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType = Context.getPointerType(RequiredType); 71200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool mismatch = false; 71220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeInfo.LayoutCompatible) { 71230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !Context.hasSameType(ArgumentType, RequiredType); 71240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.fundamental] p1: 71260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Plain char, signed char, and unsigned char are three distinct types. 71270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // 71280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // But we treat plain `char' as equivalent to `signed char' or `unsigned 71290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // char' depending on the current char signedness mode. 71300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 71310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 71320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType())) || 71330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 71340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = false; 71350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 71360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 71370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, 71380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentType->getPointeeType(), 71390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType()); 71400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 71410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 71420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 71430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 71440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 71450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentType << ArgumentKind->getName() 71460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeInfo.LayoutCompatible << RequiredType 71470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 71480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 71490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 7150