SemaChecking.cpp revision ec08735e1b6a51c11533311b774bf6336c0a5d63
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h" 19831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith#include "clang/Sema/Lookup.h" 20781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 21826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 2259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 23199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 24384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 25c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 26be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h" 272324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 287ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 29f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 31f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 3359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 34f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 358fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 373bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 38691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 407da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 41a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 43781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4708f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 484e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie PP.getLangOpts(), PP.getTargetInfo()); 4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 5060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer 72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal. 73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (checkArgCount(S, TheCall, 2)) 75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // First argument should be an integer. 78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *ValArg = TheCall->getArg(0); 79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge QualType Ty = ValArg->getType(); 80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (!Ty->isIntegerType()) { 81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << ValArg->getSourceRange(); 83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge } 85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // Second argument should be a constant string. 87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 88e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 8977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 91e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << StrArg->getSourceRange(); 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 95e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge TheCall->setType(Ty); 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 9960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 100d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 10160d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1022def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 121d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 12230ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 123925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 125690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 127d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 12849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 12930ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1310eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 132d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 141d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 142e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 143e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 145e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1489ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1499ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1509ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1513b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 154d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1570eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1600eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 161d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 162d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1640eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 165d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 166d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 167d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 168d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 169d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 17575c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 17875c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 2035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 2095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 2155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 26323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 2693fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaBuiltinAtomicOverloaded(TheCallResult); 270ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS) 271ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 272ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Builtin::BI##ID: \ 2733fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 274ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def" 27577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 276e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (SemaBuiltinAnnotation(*this, TheCall)) 27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 27877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 28326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 284bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 28626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 28926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 290fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips: 291fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mipsel: 292fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64: 293fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64el: 294fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 295fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return ExprError(); 296fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan break; 29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 30126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 3023fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 30326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 30661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 321da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 322da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 323da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 324da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 325da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 32661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3277530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 32961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3476f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3516f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3527530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 35526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 3561c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 3571c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 358f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith uint64_t mask = 0; 35961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 3604648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 3621c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 363a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 364a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 365a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 3661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 3671c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 3690d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 3710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 3730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3740d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 375da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 376f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith if ((TV > 63) || (mask & (1ULL << TV)) == 0) 3770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 3786f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3806f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 3814648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 3826f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 3944648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 3954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3964648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 3974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 3984648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3990d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 4001c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 4010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 4020d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 40361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 4040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 4050d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 406bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 407bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 40899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 40999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 410a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 411a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 412a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 4140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 415592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 416592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 417592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(i)->isValueDependent()) 418592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 419592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 42061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 4230d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 42461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 4250d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 42661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 4270d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 428476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 4290d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 43099c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 43126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 433d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 434fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 435fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned i = 0, l = 0, u = 0; 436fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan switch (BuiltinID) { 437fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan default: return false; 438fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 439fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 440be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 441be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 442be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 443be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 444be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 445fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan }; 446fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 447fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // We can't check the value of a dependent argument. 448fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (TheCall->getArg(i)->isTypeDependent() || 449fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan TheCall->getArg(i)->isValueDependent()) 450fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 451fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 452fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Check that the immediate argument is actually a constant. 453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan llvm::APSInt Result; 454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (SemaBuiltinConstantArg(TheCall, i, Result)) 455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return true; 456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Range check against the upper/lower values for this instruction. 458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned Val = Result.getZExtValue(); 459fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (Val < l || Val > u) 460fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 461fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan << l << u << TheCall->getArg(i)->getSourceRange(); 462fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 463fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 464fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan} 465fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg. 468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has 469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated. 470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo *FSI) { 472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->HasVAListArg = Format->getFirstArg() == 0; 473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FormatIdx = Format->getFormatIdx() - 1; 474831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 475de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The way the format attribute works in GCC, the implicit this argument 477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // of member functions is counted. However, it doesn't appear in our own 478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // lists, so decrement format_idx in that case. 479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (IsCXXMember) { 480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if(FSI->FormatIdx == 0) 481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FormatIdx; 483831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (FSI->FirstDataArg != 0) 484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FirstDataArg; 485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 487831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 4881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg 490831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters. 491831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::checkCall(NamedDecl *FDecl, Expr **Args, 492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumArgs, 493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs, 494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction, 495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc, 496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceRange Range, 497831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType) { 498de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 499de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 500de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 501de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 502c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool HandledFormatString = false; 504c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 505831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith I = FDecl->specific_attr_begin<FormatAttr>(), 506831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I) 507ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose if (CheckFormatArguments(*I, Args, NumArgs, IsMemberFunction, CallType, 508ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Loc, Range)) 509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HandledFormatString = true; 510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 511831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Refuse POD arguments that weren't caught by the format string 512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // checks above. 513831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!HandledFormatString && CallType != VariadicDoesNotApply) 514831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (unsigned ArgIdx = NumProtoArgs; ArgIdx < NumArgs; ++ArgIdx) 515831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith variadicArgumentPODCheck(Args[ArgIdx], CallType); 5161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 517c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith I = FDecl->specific_attr_begin<NonNullAttr>(), 519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I) 520831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CheckNonNullArguments(*I, Args, Loc); 5210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 5220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type safety checking. 5230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<ArgumentWithTypeTagAttr> 5240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(), 5250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); i != e; ++i) { 5260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko CheckArgumentWithTypeTag(*i, Args); 5270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety 531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system. 532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::CheckConstructorCall(FunctionDecl *FDecl, Expr **Args, 533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumArgs, 534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto, 535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc) { 536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkCall(FDecl, Args, NumArgs, Proto->getNumArgs(), 539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/true, Loc, SourceRange(), CallType); 540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness 543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system. 544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 546831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall); 547831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 548831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()); 549831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 550831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkCall(FDecl, TheCall->getArgs(), TheCall->getNumArgs(), NumProtoArgs, 551831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IsMemberFunction, TheCall->getRParenLoc(), 552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 553831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 554831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IdentifierInfo *FnInfo = FDecl->getIdentifier(); 555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // None of the checks below are needed for functions that don't have 556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // simple names (e.g., C++ conversion functions). 557831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!FnInfo) 558831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 5590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 5600a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 5610a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 562d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 563bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 564d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 5650a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 566bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 567c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 568c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 569d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 5700a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 5717ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 572d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 57371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 57471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 57529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 57629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs) { 577831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 578831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 57929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 580831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkCall(Method, Args, NumArgs, Method->param_size(), 581831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/false, 582831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith lbrac, Method->getSourceRange(), CallType); 58329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 58429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 58529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 58629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 587831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall, 588831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 589725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 590725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 591d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 5921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 593725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 594725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 595d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 5961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 597831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 598831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ; 599831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 600d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkCall(NDecl, TheCall->getArgs(), TheCall->getNumArgs(), 602831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NumProtoArgs, /*IsMemberFunction=*/false, 603831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getRParenLoc(), 604831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 605831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 606d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 607725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 608725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 609ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 610ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AtomicOp Op) { 611276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 612276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 613276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 614ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // All these operations take one of the following forms: 615ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith enum { 616ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_init(A *, C) 617ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Init, 618ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_load(A *, int) 619ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Load, 620ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_load(A *, CP, int) 621ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Copy, 622ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_add(A *, M, int) 623ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Arithmetic, 624ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __atomic_exchange_n(A *, CP, int) 625ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Xchg, 626ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_exchange(A *, C *, CP, int) 627ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUXchg, 628ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 629ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith C11CmpXchg, 630ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 631ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUCmpXchg 632ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } Form = Init; 633ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 634ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 635ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // where: 636ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C is an appropriate type, 637ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 638ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 639ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 640ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the int parameters are for orderings. 641ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 642ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(AtomicExpr::AO__c11_atomic_init == 0 && 643ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 644ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith && "need to update code for modified C11 atomics"); 645ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 646ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 647ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsN = Op == AtomicExpr::AO__atomic_load_n || 648ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_store_n || 649ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_exchange_n || 650ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_compare_exchange_n; 651ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsAddSub = false; 652ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 653ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Op) { 654ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_init: 655ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Init; 656ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 657ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 658ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_load: 659ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load_n: 660ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Load; 661ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 662ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 663ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_store: 664ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load: 665ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store: 666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store_n: 667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Copy; 668ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 669ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 670ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_add: 671ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_sub: 672ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_add: 673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_sub: 674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_add_fetch: 675ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_sub_fetch: 676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith IsAddSub = true; 677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Fall through. 678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_and: 679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_or: 680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_xor: 681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_and: 682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_or: 683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_xor: 68451b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_fetch_nand: 685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_and_fetch: 686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_or_fetch: 687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_xor_fetch: 68851b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_nand_fetch: 689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Arithmetic; 690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_exchange: 693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange_n: 694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Xchg; 695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange: 698ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUXchg; 699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 703ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = C11CmpXchg; 704ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange: 707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange_n: 708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUCmpXchg; 709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 710276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 711276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Check we have the right number of arguments. 713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (TheCall->getNumArgs() < NumArgs[Form]) { 714276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 716276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 717276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (TheCall->getNumArgs() > NumArgs[Form]) { 719ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 720276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 722276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 723276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 724276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 725276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 726ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Inspect the first argument of the atomic operation. 727dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 728276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 729276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 730276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 731ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 732276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 733276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 734276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 735276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 736ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For a __c11 builtin, this should be a pointer to an _Atomic type. 737ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType AtomTy = pointerType->getPointeeType(); // 'A' 738ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ValType = AtomTy; // 'C' 739ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsC11) { 740ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!AtomTy->isAtomicType()) { 741ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 742ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 743ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 744ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 745ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ValType = AtomTy->getAs<AtomicType>()->getValueType(); 746276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 747276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 748ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For an arithmetic operation, the implied arithmetic must be well-formed. 749ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Arithmetic) { 750ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 751ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 753ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 754ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 755ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsAddSub && !ValType->isIntegerType()) { 757ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 759ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 760ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 761ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 762ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For __atomic_*_n operations, the value type must be a scalar integral or 763ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 764276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 765ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 766276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 767276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 768276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 769ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) { 770ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For GNU atomics, require a trivially-copyable type. This is not part of 771ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the GNU atomics specification, but we enforce it for sanity. 772ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 773276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 774276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 775276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 776276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 777ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: For any builtin other than a load, the ValType must not be 778ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // const-qualified. 779ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 780276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 781276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 782276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 783276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 784276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 785276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 786276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 787276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 788276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 789ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: Can this happen? By this point, ValType should be known 790ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // to be trivially copyable. 791276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 792276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 793276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 794276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 795276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 796276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 797ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Copy || Form == GNUXchg || Form == Init) 798276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 799ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == C11CmpXchg || Form == GNUCmpXchg) 800276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 801276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 802ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The type of a parameter passed 'by value'. In the GNU atomics, such 803ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // arguments are actually passed as pointers. 804ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ByValType = ValType; // 'CP' 805ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !IsN) 806ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ByValType = Ptr->getType(); 807ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 808276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 809276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 810276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 811ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith for (unsigned i = 1; i != NumArgs[Form]; ++i) { 812276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 813ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (i < NumVals[Form] + 1) { 814ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (i) { 815ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 1: 816ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The second argument is the non-atomic operand. For arithmetic, this 817ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // is always passed by value, and for a compare_exchange it is always 818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // passed by address. For the rest, GNU uses by-address and C11 uses 819ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // by-value. 820ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(Form != Load); 821ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 822ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ValType; 823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Copy || Form == Xchg) 824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Arithmetic) 826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerDiffType(); 827ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else 828ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerType(ValType.getUnqualifiedType()); 829ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 830ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 2: 831ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The third argument to compare_exchange / GNU exchange is a 832ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // (pointer to a) desired value. 833ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 834ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 835ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 3: 836ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The fourth argument to GNU compare_exchange is a 'weak' flag. 837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.BoolTy; 838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 839ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 840276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 841276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 842276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 843276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 844ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 845276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 846276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 847ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ExprResult Arg = TheCall->getArg(i); 848276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 849276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 850276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 851276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 852276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 853276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 854ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Permute the arguments into a 'consistent' order. 855dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 856dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 857ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Form) { 858ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Init: 859ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal1() has a special case for this atomic. 8607a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 861ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 862ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Load: 863ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Order 864ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 865ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Copy: 866ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Arithmetic: 867ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Xchg: 868dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 869dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 870ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 871ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUXchg: 872ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal2() has a special case for this atomic. 873ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Order 874ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 876ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 877ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case C11CmpXchg: 878dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 879dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 880dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 8812ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall SubExprs.push_back(TheCall->getArg(2)); // Val2 882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUCmpXchg: 884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(4)); // Order 885ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(5)); // OrderFail 887ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 888ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Weak 889ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 890276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 891dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 892dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 8933b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer SubExprs, ResultType, Op, 894dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman TheCall->getRParenLoc())); 895276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 896276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 897276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 8985f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 8995f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 9005f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 9015f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 9025f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 9035f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 9045f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 9055f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 9065f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 9075f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 9085f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9095f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 9105f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 9115f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 9125f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9135f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 9145f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 9155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 9165f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 9175f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9185f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 9195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 9205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 9215f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 9235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 9245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 9255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 9265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 9275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 9285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 9295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 93060d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 93160d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 932d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 9335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 9345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 9355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 9365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 937d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 938d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 939d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 940d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 941d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 942d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 9455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 9465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 9475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 948d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 9495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 9508c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 9518c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 9528c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 9538c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 9548c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 9558c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 956f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 957f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 958d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 959d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 960d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 961d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 963f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 964dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 965d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 966d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 967d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 968d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 969d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 971f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 972f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 973f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 974f85e193739c953358c865005855253af4f68a497John McCall // okay 975f85e193739c953358c865005855253af4f68a497John McCall break; 976f85e193739c953358c865005855253af4f68a497John McCall 977f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 978f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 979f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 980b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 981f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 982f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 983f85e193739c953358c865005855253af4f68a497John McCall } 984f85e193739c953358c865005855253af4f68a497John McCall 985b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 986b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 987b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 9888d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 9898d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 9908d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 9918d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 9925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 9935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 9945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 9955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 9965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 9975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 9981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 10005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 10015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 10025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 10035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 10045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 10051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 10075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 10085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 10095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 10105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 10111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 10135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 10145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 101523aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 101623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 10175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 10181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 10191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 10215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 1022199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 10235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 10245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 10255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 10265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 10275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 10285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 1029d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 1030d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1031d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 10325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 10331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 10355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 10365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 10375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 10387814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 10395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 10405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 1041b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 1042a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 1043a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 1044a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 1045a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 1046a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 1047a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1048a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 1049a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1050a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1051a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 1052a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 1053a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 1054a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 1055a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 1056a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1057a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 1058a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1059a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1060a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 1061a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 1062a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 1063a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 1064a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 1065a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1066a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 1067a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1068a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1069a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 1070a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 1071a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 1072a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 1073a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 1074a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1075a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 1076a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1077a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1078a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 1079a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 1080a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 1081a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 1082a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 1083a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1084a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 1085a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1086a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1087a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 1088a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 1089a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 1090a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 1091a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 1092a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1093a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 1094a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1095a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1096a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 1097a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 1098a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 1099a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 1100a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 1101a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 1102a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 1103a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1104a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1105a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 1106a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 1107a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 1108a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 1109a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 1110a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 1111a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 1112a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1113a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1114a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 1115a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 1116a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 1117a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 1119a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 1120a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 1126a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 1127a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 1128a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 1130a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 11311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 1136a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 1137a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 11387eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 11395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 11405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 11425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1143a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 1144a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 1145a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 1147a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 11487eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 11495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 11508d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 11515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1152a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1153a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 1154a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 1155a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 1156a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 1157a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 1158a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 1159a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 1160a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1161a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 11625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 1163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 1167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 11687eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 11695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 11708d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 11715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 1174a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 1175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 1176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 1177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 1178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 1179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 1180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 11815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 11821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 11845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 1185d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 1186d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1187d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 1188d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1189d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1190d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 11911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1192e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 1193e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 1194e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1195e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 1196e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 11971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 1198e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 1199e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 1200d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1201f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 1202f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 1203f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 12045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 1205429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 12061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 12085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 1209b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 1210b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1211b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 1212b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1213429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 1214d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 12151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 12175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 12185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 12195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 12205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 12211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 1222b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 12235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 12241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1225bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 1226bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 1227bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 1228bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 1229bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 1230bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 1231e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 1232bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 1233f4b88a45902af1802a1cb42ba48b1c474474f228John McCall /*enclosing*/ false, 1234bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 1235a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman Context.BuiltinFnTy, 1236bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 12371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 1239a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman // FIXME: This loses syntactic information. 1240a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 1241a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 1242a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman CK_BuiltinFnToFnPtr); 1243429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 12441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1245db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1246db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1247db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 12488d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1249d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 12503fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 12515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 12525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1253690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 125471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1255fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1256fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1257690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 125856f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 125971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 126071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 12615cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1262fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1263fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 12649cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 126571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 12661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12677da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 12685f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 12697da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 12705f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 12717da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 12727da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 12737da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 12747da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 12757da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 12767da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 12777da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 12787da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 12797da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 12807da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 12817da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 12829cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 128359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 128459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1285c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1286c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1287925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1288925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1289925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 12902c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1291fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1292ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1293ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 12941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1295fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 129630ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 129730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 129856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 129956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1300d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1301d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1302d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 130356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 130456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 13055f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 13065f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 13075f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 13085f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1309c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 13109ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1311c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1312cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1313c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 13149498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 13159498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 13169498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 131753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 13181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1319c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 132030ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 132130ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 132230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 13231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 132430ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 132530ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 132630ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1327e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 13281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 132988cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 133088cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 133130ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 133230ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 133388cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1334cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1335cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1336cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1337371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 133830ce344307f8a8b00054021307015571f83c7364Chris Lattner else 133953d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 134030ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 134130ce344307f8a8b00054021307015571f83c7364Chris Lattner } 134230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 13431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 134430ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 13451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 134630ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 134730ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 13486cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 134930ce344307f8a8b00054021307015571f83c7364Chris Lattner 13501b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 13511b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1352925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1353925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 13542c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1355d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1356925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 13571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1358fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1359ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1360fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1361fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 13621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1363429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1364429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1365cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 13661b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 13671b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1368925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1369429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1370429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1371403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1372403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1373403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1374403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1375429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1376429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 13771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1378429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1379cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1380cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 13811b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 13821b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 1383860a319e62b0e256817a458396d191aa91c0787aEli Friedman if (Res.isNull() || !Res->isRealFloatingType()) 1384429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1385fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1386429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1387429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 13881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13891b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 13901b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 13911b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1392e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1393e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 13943b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 13953b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 13963b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 13973b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 13989ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1399d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 14003b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 14013b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 14029ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1403ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 14043b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 14059ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 14069ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 14073b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 14081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 14109ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 14119ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 141281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 14139ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 14141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 14159ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 14169ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 14171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 141881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 141981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 142081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 142181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 142281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 142381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 142481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 142581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 142681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 142781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 142881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 14299ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 14309ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 14319ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1432d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1433d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 143460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 143537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 14360eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1437d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 143837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1439d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1440d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 144137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 144237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 144337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 144437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 144537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 144637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 144737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1448cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1449cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 145037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 145137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 145237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 145337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1454cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 14551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1456cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1457cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1458cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 145937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 146037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 146137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 146237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 146337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 146437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 146537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 146637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 1467f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 146837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 146937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 147037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 147137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 147237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 147337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 147437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1475cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 14761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1477cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1478cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 147937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 148037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1481788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1482e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1483cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1484d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1485d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1486d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1487cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1488cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1489cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1490cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 149137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 149237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 149337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 149437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 149537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 14960eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1497d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 14980eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1499fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 15000eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1501d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1502d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 15035f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1504d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1505d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1506d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1507d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1508d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1509d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 15103b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType, 15118189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 15128189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1513d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 151430ce344307f8a8b00054021307015571f83c7364Chris Lattner 15154493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 15164493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 15174493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 15184493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1519fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 15204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1521fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1522ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1523ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1524ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1525ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 15264493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 15274493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 15284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1529fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 15304493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1531592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1532592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1533592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (Arg->isTypeDependent() || Arg->isValueDependent()) 1534592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor continue; 1535592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 15369aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1537691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1538691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 15391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 15404493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 15414493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 15424493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1543fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 15449aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1545fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 154621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 15474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 15489aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1549fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 155021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 15514493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 15524493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 15534493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1554fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 15554493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 15564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1557691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1558691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1559691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1560691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1561691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1562691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1563691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1564691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1565691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1566691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1567691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1568691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 15695e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1570691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 157121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 157221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 157321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1574d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1575d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1576d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1577fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1578d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1579691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1580592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1581592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1582592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(1)->isTypeDependent() || 1583592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(1)->isValueDependent()) 1584592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 1585592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1586691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1587691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1588691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1589d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1590691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1591d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1592fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1593fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1594d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1595d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1596d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1597d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1598d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1599586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1600d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1601d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1602d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1603691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1604cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1605691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1606691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1607691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1608691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1609691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1610d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1611d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1612d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1613d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1614d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1615d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1616831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string. 1617831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a 1618831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning. 1619831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString. 1620831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType 1621831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::checkFormatStringExpr(const Expr *E, Expr **Args, 1622831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumArgs, bool HasVAListArg, 1623831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned format_idx, unsigned firstDataArg, 1624ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose FormatStringType Type, VariadicCallType CallType, 1625ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall) { 16264fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1627cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1628831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1629d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 163034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1631f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1632a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1633a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1634a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1635a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1636a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1637831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1638a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1639d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 164056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1641d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 1642831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The expression is a literal if both sub-expressions were, and it was 1643831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // completely checked only if both sub-expressions were checked. 1644831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const AbstractConditionalOperator *C = 1645831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith cast<AbstractConditionalOperator>(E); 1646831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Left = 1647831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkFormatStringExpr(C->getTrueExpr(), Args, NumArgs, 1648831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1649ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1650831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Left == SLCT_NotALiteral) 1651831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1652831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Right = 1653831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkFormatStringExpr(C->getFalseExpr(), Args, NumArgs, 1654831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1655ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1656831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Left < Right ? Left : Right; 1657d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1658d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1659d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 16604fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 16614fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1662d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1663d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 166456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 166556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 166656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 166756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 166856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 1669831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 167056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1671b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1672b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1673b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1674b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1675831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1676b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1677082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1678082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 16791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1680082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1681082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1682082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1683082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1684082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1685082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1686082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1687082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1688ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 16891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1690082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1691e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1692e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1693e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1694e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1695082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 16961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1697082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 1698e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const Expr *Init = VD->getAnyInitializer()) { 1699e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay // Look through initializers like const char c[] = { "foo" } 1700e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 1701e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (InitList->isStringLiteralInit()) 1702e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay Init = InitList->getInit(0)->IgnoreParenImpCasts(); 1703e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 1704831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return checkFormatStringExpr(Init, Args, NumArgs, 1705831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1706ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1707831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*inFunctionCall*/false); 1708e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 1709082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1711d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1712d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1713d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1714d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1715d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1716d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1717d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1718d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1719d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1720d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1721d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1722d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1723d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1724d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1725f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (HasVAListArg) { 1726f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 1727f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 1728f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas int PVIndex = PV->getFunctionScopeIndex() + 1; 1729f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 1730f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas i = ND->specific_attr_begin<FormatAttr>(), 1731f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 1732f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas FormatAttr *PVFormat = *i; 1733f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // adjust for implicit parameter 1734f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 1735f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (MD->isInstance()) 1736f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas ++PVIndex; 1737f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We also check if the formats are compatible. 1738f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We can't pass a 'scanf' string to a 'printf' function. 1739f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (PVIndex == PVFormat->getFormatIdx() && 1740f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas Type == GetFormatStringType(PVFormat)) 1741831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1742f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1743f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1744f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1745f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1746082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1748831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1749082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1750d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 175152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 175252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 17538f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 175452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 175552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 175652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 175752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 175852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 175952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 176052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 176152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 1762831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return checkFormatStringExpr(Arg, Args, NumArgs, 1763831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1764ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 176550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 176650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned BuiltinID = FD->getBuiltinID(); 176750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 176850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 176950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose const Expr *Arg = CE->getArg(0); 1770831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return checkFormatStringExpr(Arg, Args, NumArgs, 1771831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1772ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1773ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall); 177450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } 17758f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 17768f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 17771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1778831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 17798f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1780082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1781082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1782082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 17831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1784082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1785d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1786d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1787082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 17881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1789d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 179029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx, 1791ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, inFunctionCall, CallType); 1792831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1793d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 17941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1795831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1796d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 17971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1798082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1799831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1800d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1801d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1802d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1803e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 18041eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1805909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1806909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1807cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1808cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1809e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1810909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 18114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1812ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1813909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1814e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1815e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1816d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 181734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 181834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 181934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 182034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 182134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 182234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 182334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 182434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 182534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 182634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 182734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 1828ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar 1829826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 1830831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked. 1831831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args, 183229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned NumArgs, bool IsCXXMember, 1833ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 183429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1835831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo FSI; 1836831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 1837831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CheckFormatArguments(Args, NumArgs, FSI.HasVAListArg, FSI.FormatIdx, 1838831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI.FirstDataArg, GetFormatStringType(Format), 1839ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose CallType, Loc, Range); 1840831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 184129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 18424a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1843831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs, 184434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 184534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 1846ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 184734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1848826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 184929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (format_idx >= NumArgs) { 185029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 1851831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 185271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 18531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 185429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 18551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 185659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 18571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 185871895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 185971895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 186071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 186171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 186271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 18637ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 18641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 18657ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 18661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 18677ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 1868831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType CT = 1869831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkFormatStringExpr(OrigFormatExpr, Args, NumArgs, HasVAListArg, 1870ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose format_idx, firstDataArg, Type, CallType); 1871831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (CT != SLCT_NotALiteral) 1872831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Literal format string found, check done! 1873831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CT == SLCT_CheckedLiteral; 18741cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 18752837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 18762837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 18772837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 1878831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 18792837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 1880ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 1881ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 1882ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 1883ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 1884dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas if (Type == FST_NSString && 1885dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart())) 1886831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1887ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 1888655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1889655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 189029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (NumArgs == format_idx+1) 189129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1892826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1893655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1894655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 189529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1897655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1898831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1899d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1900d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1901e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1902826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1903826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1904e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1905e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1906e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 19076ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1908e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1909e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 19100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 191129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr * const *Args; 191229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const unsigned NumArgs; 19130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 19147f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1915efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1916efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 191755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 1918ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType; 19194e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1920826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 19216ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 192250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 192329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **args, unsigned numArgs, 1924ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 1925ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType callType) 1926e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 192750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), 192850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose Beg(beg), HasVAListArg(hasVAListArg), 192929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Args(args), NumArgs(numArgs), FormatIdx(formatIdx), 193055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 1931ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall(inFunctionCall), CallType(callType) { 19327f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 19337f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 19347f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 19354e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 193607d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 19374e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1938826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 194076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 194176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardLengthModifier( 194276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::LengthModifier &LM, 194376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 194476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 194576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecifier( 194676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 194776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 194876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 194976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecification( 195076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::LengthModifier &LM, 195176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 195276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 195376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 1954f85626453123f9691bcef13cff963f556e209c27Hans Wennborg virtual void HandlePosition(const char *startPos, unsigned posLen); 1955f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 1956efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1957efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1958826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1959efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1960efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1961efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1962e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 19634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 196455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 196555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 196655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 196755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 196855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 196955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 1970ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>()); 197155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1972826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1973c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1974c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1975c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1976c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 197755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 197855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 197955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 198055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 1981c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1982f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1983826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1984826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1985e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 19864e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 19870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1988666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1989666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1990666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1991666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1992666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 199355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 199455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 199555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 199655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 1997ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>()); 199855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 199955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 200055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 2001e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 2002e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2003e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2004826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 2005e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 2006e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2007e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2008826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 2009826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 201045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 201145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 201245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 201345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 2014a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 201545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 201645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 2017f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 2018f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 2019826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 20204e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 2021e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2022e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2023826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 2024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 202555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 202655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 202755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 202855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2029808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 2030808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 203176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier( 203276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::LengthModifier &LM, 203376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 203476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << LM.toString() 2035f85626453123f9691bcef13cff963f556e209c27Hans Wennborg << 0, 203676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getLocationOfByte(LM.getStart()), 203776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg /*IsStringLocation*/true, 203876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getSpecifierRange(startSpecifier, specifierLen)); 203976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 204076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 204176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier( 204276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 204376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 204476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << CS.toString() 2045f85626453123f9691bcef13cff963f556e209c27Hans Wennborg << 1, 204676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getLocationOfByte(CS.getStart()), 204776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg /*IsStringLocation*/true, 204876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getSpecifierRange(startSpecifier, specifierLen)); 204976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 205076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 205176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecification( 205276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::LengthModifier &LM, 205376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 205476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 205576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_conversion_spec) 205676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg << LM.toString() << CS.toString(), 205776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getLocationOfByte(LM.getStart()), 205876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg /*IsStringLocation*/true, 205976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getSpecifierRange(startSpecifier, specifierLen)); 206076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 206176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2062f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos, 2063f85626453123f9691bcef13cff963f556e209c27Hans Wennborg unsigned posLen) { 2064f85626453123f9691bcef13cff963f556e209c27Hans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 2065f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getLocationOfByte(startPos), 2066f85626453123f9691bcef13cff963f556e209c27Hans Wennborg /*IsStringLocation*/true, 2067f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getSpecifierRange(startPos, posLen)); 2068f85626453123f9691bcef13cff963f556e209c27Hans Wennborg} 2069f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2070efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 2071826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 2072826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 207355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 207455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 207555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 207655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2077efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2078efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2079826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 2080efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 208155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 208255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 208355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 208455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2085efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2086efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2087826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 208850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 20890c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 209055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 209155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 209255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 209355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 20940c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 2095826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2096826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 209748716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building 209848716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions. 2099826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 210029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 2101826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 21024e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2103826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 2104826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 2105826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 2106826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 2107826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 2108826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 2109826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 2110826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 2111826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 211248716663e421472cbd590af160a372bc490205e8Jordan Rose if (const Expr *E = getDataArg((unsigned) notCoveredArg)) { 211348716663e421472cbd590af160a372bc490205e8Jordan Rose SourceLocation Loc = E->getLocStart(); 211448716663e421472cbd590af160a372bc490205e8Jordan Rose if (!S.getSourceManager().isInSystemMacro(Loc)) { 211548716663e421472cbd590af160a372bc490205e8Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 211648716663e421472cbd590af160a372bc490205e8Jordan Rose Loc, /*IsStringLocation*/false, 211748716663e421472cbd590af160a372bc490205e8Jordan Rose getFormatStringRange()); 211848716663e421472cbd590af160a372bc490205e8Jordan Rose } 2119c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson } 2120826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2122826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2123826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2124c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 2125c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 2126c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 2127c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2128c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2129c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 2130c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 2131c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2132c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 2133c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 2134c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 2135c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 2136c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 2137c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2138c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 2139c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 2140c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 2141c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 2142c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 2143c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 2144c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 2145c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2146c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 214755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 214855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 214955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 215055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 2151c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2152c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 2153c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2154c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 215555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 215655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 215755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 215855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 215955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 216055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 216155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 216255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 216355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2164666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 2165666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 2166666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 2167666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2168666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2169666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2170666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 217155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 217255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 217355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 217455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 217555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 217655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 217755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2178666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 2179666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 2180666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 2181666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 2182666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 218355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 218455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 218555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 218655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 218755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2188ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 218929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 219055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 219155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 219255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 219355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 219455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 219555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 219670517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function 219755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 219855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 219955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 220055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 220155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 220255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 220355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 220455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 220555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 220655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 220755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 220855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 220955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 221055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 221155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 221255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 221355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 221455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 221555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 221655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 221755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 221855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 221970517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string. 222055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 222155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 222255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 222355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 222455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 222555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 222655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2227ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 2228ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (InFunctionCall) { 2229ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 2230ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << StringRange; 2231ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2232ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2233ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << *I; 2234ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2235ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 223655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 223755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 2238ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2239ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &Note = 2240ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 2241ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose diag::note_format_string_defined); 2242ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2243ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << StringRange; 2244ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2245ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2246ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << *I; 2247ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 224855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 224955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 225055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2251826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 2252826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2253826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2254826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 225550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose bool ObjCContext; 2256826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2257826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2258826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 225950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, bool isObjC, 2260826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 226129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 2262ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2263ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2264826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 226550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, Args, NumArgs, 2266ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose formatIdx, inFunctionCall, CallType), ObjCContext(isObjC) 2267ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2268ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose 2269826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2270826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 2271826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2272826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2274826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2275826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2276826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2277826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2278831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2279831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2280831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2281831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E); 2282831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2283826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2284826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2285826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2286826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 2287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 2288826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2289826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2292826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2293826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 2294826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2295826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2296f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg bool checkForCStrMembers(const analyze_printf::ArgType &AT, 2297831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E, const CharSourceRange &CSR); 2298831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2299826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2300826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2301826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2302826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 23066ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 2307c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2309c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2310c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2311c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2312c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 231326ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 231426ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 2315826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 2316826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 2317826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 2318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 23190d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 23200d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 23210d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 23227f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 23237f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 232455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 232555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 232655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 232755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 232855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 23290d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 23300d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 23310d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 23320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 23334e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 23340d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 233531f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 233631f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 233731f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 23387f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 23397f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 234048716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 234148716663e421472cbd590af160a372bc490205e8Jordan Rose return false; 234248716663e421472cbd590af160a372bc490205e8Jordan Rose 23430d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 23444e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2345f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 2346f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg assert(AT.isValid()); 23474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2348f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg if (!AT.matchesType(S.Context, T)) { 234955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2350f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << k << AT.getRepresentativeTypeName(S.Context) 235155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 235255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 235355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 235455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 23550d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 23560d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 23570d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 23580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 23590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 23600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 23610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 23620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 23630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2364e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 2365826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2366e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 2367e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 2368e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2369e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 23706ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 23716ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 2372e4ee9663168dfb2b4122c768091e30217328c9faTom Care 237355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 237455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 237555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 237655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 237755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 237855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 237955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 238055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 238155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 238255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 238355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 238455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2385e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2386e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2387826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2388e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2389e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2390e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2391e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 23926ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 23936ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 239455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 239555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 239655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 239755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 239855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 239955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 240055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2401e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2402e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2403e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2404826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2405e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2406e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2407e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2408e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2409e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 241055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 241155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 241255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 241355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 241455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 241555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 241655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2417e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2418e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2419831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing 2420831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named 2421831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()"). 2422831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind> 2423831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1> 2424831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 2425831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const RecordType *RT = Ty->getAs<RecordType>(); 2426831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith llvm::SmallPtrSet<MemberKind*, 1> Results; 2427831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2428831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RT) 2429831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2430831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 2431831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RD) 2432831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2433831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2434831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(), 2435831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Sema::LookupMemberName); 2436831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2437831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // We just need to include all members of the right kind turned up by the 2438831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // filter, at this point. 2439831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (S.LookupQualifiedName(R, RT->getDecl())) 2440831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 2441831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NamedDecl *decl = (*I)->getUnderlyingDecl(); 2442831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 2443831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Results.insert(FK); 2444831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2445831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2446831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2447831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2448831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a 2449f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid. 2450831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found. 2451831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers( 2452f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT, const Expr *E, 2453831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CharSourceRange &CSR) { 2454831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 2455831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2456831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MethodSet Results = 2457831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 2458831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2459831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 2460831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MI != ME; ++MI) { 2461831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXMethodDecl *Method = *MI; 2462831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Method->getNumParams() == 0 && 2463f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg AT.matchesType(S.Context, Method->getResultType())) { 2464831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // FIXME: Suggest parens if the expression needs them. 2465831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation EndLoc = 2466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()); 2467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.Diag(E->getLocStart(), diag::note_printf_c_str) 2468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << "c_str()" 2469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 2470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 2471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2474831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2475831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2477e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2478826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 24795c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2480e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2481e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2482e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 24836ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2484efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 24856ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2486e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2487baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2488baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2489baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2490baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2491baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2492baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 249355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 249455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2495baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2496baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2497efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2498efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 24990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 25000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2501efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2502efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 25030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 25040d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25054e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2506efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2507efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 25080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 25090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2511f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2512f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2513f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 25140e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2515f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 25164e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 25177f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 25187f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2519e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2520e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2521e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2522e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2523e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2524e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 25257f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 25267f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 25277f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 252850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!ObjCContext && CS.isObjCArg()) { 2529826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2530826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 25317f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 25324e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2533e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2534e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 253545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2536e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2537e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2538e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2539e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2540e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2541e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2542e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2543e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2544e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2545e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 254665197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 254765197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2548e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2549e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2550e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2551e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 255245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 255345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2554e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2555e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2556e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2557e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2558e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2559e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 256045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 256145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 256245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2563e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2564e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2565e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2566e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2567e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2568e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 2569e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 257055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length) 257155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << LM.toString() << CS.toString(), 257255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(LM.getStart()), 257355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 257455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 257555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 257655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(LM.getStart(), 257755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu LM.getLength()))); 257876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg if (!FS.hasStandardLengthModifier()) 257976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardLengthModifier(LM, startSpecifier, specifierLen); 25804e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 258176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 258276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg if (!FS.hasStandardLengthConversionCombination()) 258376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardConversionSpecification(LM, CS, startSpecifier, 258476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg specifierLen); 2585e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2586da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2587da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2588da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 25894e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2590666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2591da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 25924e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 259348716663e421472cbd590af160a372bc490205e8Jordan Rose const Expr *Arg = getDataArg(argIndex); 259448716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 259548716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 259648716663e421472cbd590af160a372bc490205e8Jordan Rose 259748716663e421472cbd590af160a372bc490205e8Jordan Rose return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 2598831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2599831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2600ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) { 2601ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // FIXME: We should have a general way to reason about operator 2602ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // precedence and whether parens are actually needed here. 2603ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Take care of a few common cases where they aren't. 2604ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Expr *Inside = E->IgnoreImpCasts(); 2605ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 2606ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 2607ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2608ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose switch (Inside->getStmtClass()) { 2609ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ArraySubscriptExprClass: 2610ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::CallExprClass: 2611ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::DeclRefExprClass: 2612ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::MemberExprClass: 2613ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCIvarRefExprClass: 2614ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCMessageExprClass: 2615ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCPropertyRefExprClass: 2616ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ParenExprClass: 2617ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::UnaryOperatorClass: 2618ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return false; 2619ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose default: 2620ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return true; 2621ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2622ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose} 2623ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2624831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool 2625831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2626831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2627831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2628831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E) { 2629831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_format_string; 2630831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_printf; 263196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 263296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 2633f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = FS.getArgType(S.Context, 2634f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg ObjCContext); 2635614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (!AT.isValid()) 2636614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2637ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2638ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose QualType IntendedTy = E->getType(); 2639ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (AT.matchesType(S.Context, IntendedTy)) 2640614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2641614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2642614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Look through argument promotions for our error message's reported type. 2643614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // This includes the integral and floating promotions, but excludes array 2644614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // and function pointer decay; seeing that an argument intended to be a 2645614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // string has type 'char [6]' is probably more confusing than 'char *'. 2646614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 2647614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getCastKind() == CK_IntegralCast || 2648614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getCastKind() == CK_FloatingCast) { 2649614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E = ICE->getSubExpr(); 2650ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy = E->getType(); 2651614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2652614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Check if we didn't match because of an implicit cast from a 'char' 2653614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // or 'short' to an 'int'. This is done because printf is a varargs 2654614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // function. 2655614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getType() == S.Context.IntTy || 2656614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getType() == S.Context.UnsignedIntTy) { 2657614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // All further checking is done on the subexpression. 2658ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (AT.matchesType(S.Context, IntendedTy)) 2659614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 26604d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 2661ee0259d308e72141982a85b40863e760a8447edfJordan Rose } 2662614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } 2663614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2664ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 2665ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Special-case some of Darwin's platform-independence types. 2666ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const TypedefType *UserTy = IntendedTy->getAs<TypedefType>()) { 2667ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 2668ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy = llvm::StringSwitch<QualType>(Name) 2669ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSInteger", S.Context.LongTy) 2670ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSUInteger", S.Context.UnsignedLongTy) 2671ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("SInt32", S.Context.IntTy) 2672ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("UInt32", S.Context.UnsignedIntTy) 2673ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Default(IntendedTy); 2674ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2675ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2676ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2677614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // We may be able to offer a FixItHint if it is a supported type. 2678614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose PrintfSpecifier fixedFS = FS; 2679ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(), 2680614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.Context, ObjCContext); 268196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2682614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (success) { 2683614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Get the fix string from the fixed format specifier 2684614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SmallString<16> buf; 2685614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose llvm::raw_svector_ostream os(buf); 2686614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose fixedFS.toString(os); 2687614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2688ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 2689ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2690ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (IntendedTy != E->getType()) { 2691ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // The canonical type for formatting this value is different from the 2692ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // actual type of the expression. (This occurs, for example, with Darwin's 2693ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 2694ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // should be printed as 'long' for 64-bit compatibility.) 2695ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Rather than emitting a normal format/argument mismatch, we want to 2696ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // add a cast to the recommended type (and correct the format string 2697ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // if necessary). 2698ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallString<16> CastBuf; 2699ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose llvm::raw_svector_ostream CastFix(CastBuf); 2700ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2701ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 2702ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << ")"; 2703ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2704ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallVector<FixItHint,4> Hints; 2705ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (!AT.matchesType(S.Context, IntendedTy)) 2706ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 2707ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2708ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 2709ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If there's already a cast present, just replace it. 2710ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 2711ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 2712ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2713ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else if (!requiresParensToAddCast(E)) { 2714ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If the expression has high enough precedence, 2715ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // just write the C-style cast. 2716ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2717ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2718ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 2719ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Otherwise, add parens around the expression as well as the cast. 2720ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2721ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2722ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2723ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2724ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd()); 2725ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(After, ")")); 2726ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2727ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2728ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // We extract the name from the typedef because we don't want to show 2729ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // the underlying type in the diagnostic. 2730ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const TypedefType *UserTy = cast<TypedefType>(E->getType()); 2731ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 2732ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2733ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Finally, emit the diagnostic. 2734ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 2735ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose << Name << IntendedTy 2736ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose << E->getSourceRange(), 2737ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose E->getLocStart(), /*IsStringLocation=*/false, 2738ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SpecRange, Hints); 2739ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 2740ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose EmitFormatDiagnostic( 2741ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2742ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose << AT.getRepresentativeTypeName(S.Context) << IntendedTy 2743ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose << E->getSourceRange(), 2744ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose E->getLocStart(), 2745ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose /*IsStringLocation*/false, 2746ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SpecRange, 2747ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose FixItHint::CreateReplacement(SpecRange, os.str())); 2748ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2749614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else { 2750614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 2751614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SpecifierLen); 2752614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Since the warning for passing non-POD types to variadic functions 2753614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // was deferred until now, we emit a warning for non-POD 2754614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // arguments here. 2755614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (S.isValidVarArgType(E->getType()) == Sema::VAK_Invalid) { 2756614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose unsigned DiagKind; 2757614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (E->getType()->isObjCObjectType()) 2758614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format; 2759614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose else 2760614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::warn_non_pod_vararg_with_format_string; 276196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2762614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose EmitFormatDiagnostic( 2763614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.PDiag(DiagKind) 2764614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << S.getLangOpts().CPlusPlus0x 2765614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getType() 2766614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CallType 2767614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << AT.getRepresentativeTypeName(S.Context) 2768614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 2769614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getSourceRange(), 2770614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 277196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2772614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose checkForCStrMembers(AT, E, CSR); 2773614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else 277455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 277555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2776f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << AT.getRepresentativeTypeName(S.Context) << E->getType() 2777614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 2778831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << E->getSourceRange(), 2779614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 278096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 278196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2782e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 2783e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2784e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2785826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 2786826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2787826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2788826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 2789826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2790826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 2791826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 279250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 279329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 2794ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2795ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2796826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 279750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, 2798ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Args, NumArgs, formatIdx, inFunctionCall, CallType) 2799ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2800826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2801826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 2802826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2803826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2804c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2805c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 2806c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2807c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2808c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 2809b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2810b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 2811826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2812826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2813826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2814b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 2815b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 281655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 281755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 281855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 2819b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 2820b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2821c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 2822c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2823c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2824c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 2825c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 28266ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 2827c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2828c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2829c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2830c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2831c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2832c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 2833c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2834c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2835826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 2836826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2837826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2838826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 2839826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2840826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 2841826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 2842826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 28436ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 2844826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2845baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 2846baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 2847baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2848baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2849baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2850baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2851baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2852baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 285355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 285455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2855baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2856baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2857826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2858826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2859826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 2860826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 2861826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 2862826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 2863826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 2864826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 286555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 286655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 286755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 286855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 28697f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 28707f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 2871826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2872826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 2873826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 2874826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 2875826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2876826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2877826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2878826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 2879826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2880826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 2881826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 2882826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 2883826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 2884826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 2885826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2886826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 28871e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 28881e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 28891e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 2890220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas const CharSourceRange &R = getSpecifierRange(LM.getStart(), LM.getLength()); 2891220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length) 2892220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << LM.toString() << CS.toString() 2893220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << getSpecifierRange(startSpecifier, specifierLen), 2894220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getLocationOfByte(LM.getStart()), 2895220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas /*IsStringLocation*/true, R, 2896220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas FixItHint::CreateRemoval(R)); 28971e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 28981e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 289976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg if (!FS.hasStandardLengthModifier()) 290076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardLengthModifier(LM, startSpecifier, specifierLen); 29014e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 290276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 290376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg if (!FS.hasStandardLengthConversionCombination()) 290476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardConversionSpecification(LM, CS, startSpecifier, 290576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg specifierLen); 290676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2907826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 2908826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 2909826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2910826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2911666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2912826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 2913826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 29146fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 29156fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 291648716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Ex) 291748716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 291848716663e421472cbd590af160a372bc490205e8Jordan Rose 291958e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 292058e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) { 29216fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 29224e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 2923be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context); 29246fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 29256fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 29266fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 2927f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 29286fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 29296fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 29306fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 29316fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 29326fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 293358e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 29346fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 2935abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 2936abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 29376fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 29386fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 29396fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 29406fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 29416fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 2942220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 2943220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 294458e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 2945220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 2946abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 2947abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 2948220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 29496fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 29506fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 29516fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 2952826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 295307d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 2954e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2955826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 29560e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 295729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 295829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 295934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 2960ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall, VariadicCallType CallType) { 2961826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2962e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 2963df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith if (!FExpr->isAscii() && !FExpr->isUTF8()) { 296455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 296529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 296655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 296755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 2968e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2969e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2970826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2971e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 29725f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 29732f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 29742f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 297529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const unsigned numDataArgs = NumArgs - firstDataArg; 2976826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2977e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 29784cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 297955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 298029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 298155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 298255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 2983e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2984e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2985826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 298634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 2987826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 298850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, (Type == FST_NSString), 298929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Str, HasVAListArg, Args, NumArgs, format_idx, 2990ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 2991826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2992d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 29934e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts())) 2994826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 299534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 299650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs, 299729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Str, HasVAListArg, Args, NumArgs, format_idx, 2998ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 2999826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3000d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 30014e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts())) 3002826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 300334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 3004ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 3005ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 30067ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 30077ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 30082a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 30092a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 30102a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 30112a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 30122a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 30132a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 30142a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 30152a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 30162a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 30172a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 30182a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 3019a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 3020000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 3021000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 3022e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 3023000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3024000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 3025000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 3026e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 3027000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 3028000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 3029000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3030a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 3031000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 3032000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 3033000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3034000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 3035000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 3036000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3037000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 3038e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 3039e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 30407ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 30417ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 3042929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 3043cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 3044cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 30457ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 30467ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 3047cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 30480a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 3049cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 30500a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 30510a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 30521d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 3053707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 30540a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 3055cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 30561d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 30571d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 30580a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 30590a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 30600a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 3061cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 3062000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3063000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 3064000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 3065000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 3066000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 3067000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 306806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 306906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 3070e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 307106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 307206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 307306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 307406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 3075f85e193739c953358c865005855253af4f68a497John McCall 3076000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 3077000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 3078000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 307906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 308006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 3081000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 3082000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 3083000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 3084000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 3085000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 3086000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 3087000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 3088000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 3089000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 3090000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 3091000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 3092000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 3093000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 3094000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 3095cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 3096cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 3097000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 30986fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks StringRef ReadableName = FnName->getName(); 30996fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 3100000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 310190c78328e70cb376754edf87708505a84c044271Anna Zaks if (UnaryOp->getOpcode() == UO_AddrOf) 3102000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 3103000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 3104000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 3105000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 31066fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 31076fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // If the function is defined as a builtin macro, do not show macro 31086fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // expansion. 31096fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceLocation SL = SizeOfArg->getExprLoc(); 31106fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange DSR = Dest->getSourceRange(); 31116fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange SSR = SizeOfArg->getSourceRange(); 31126fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceManager &SM = PP.getSourceManager(); 31136fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 31146fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks if (SM.isMacroArgExpansion(SL)) { 31156fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 31166fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SL = SM.getSpellingLoc(SL); 31176fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 31186fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(DSR.getEnd())); 31196fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 31206fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(SSR.getEnd())); 31216fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks } 31226fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 312390c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 3124000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 31256fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << ReadableName 312690c78328e70cb376754edf87708505a84c044271Anna Zaks << PointeeTy 312790c78328e70cb376754edf87708505a84c044271Anna Zaks << DestTy 31286fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << DSR 312990c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 313090c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 313190c78328e70cb376754edf87708505a84c044271Anna Zaks PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 313290c78328e70cb376754edf87708505a84c044271Anna Zaks << ActionIdx 313390c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 313490c78328e70cb376754edf87708505a84c044271Anna Zaks 3135000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3136000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3137000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3138000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3139000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 3140000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 3141000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 3142000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 3143000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 3144000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 3145000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 3146000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 3147000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 3148000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 3149000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 3150000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3151000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3152e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 3153e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 315406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 31550a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 31560a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 31570a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 31580a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 31590a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 31600a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 31610a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 31620a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 31630a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 31640a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 31650a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 31660a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 31670a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 31680a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 31695c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 31705c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 31715c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 31720a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 3173d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 31740a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 31755c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 31760a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 31770a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 31785c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 31795c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 31805c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 31815c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 31825c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 3183f85e193739c953358c865005855253af4f68a497John McCall else 318406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 3185f85e193739c953358c865005855253af4f68a497John McCall 3186f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 3187f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 3188929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 318906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 319006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 319106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 31927ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 31937ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 31947ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 3195bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 3196bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 3197bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 3198bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 3199bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 3200bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3201bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 3202bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 3203bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 3204bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3205bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3206bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 3207bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 3208bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3209bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 3210bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 3211bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 3212bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 3213bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 3214bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3215bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3216bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3217bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 3218bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3219bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 32200f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 32210f38acee92014cb15af980808f87144e5564031dAnna Zaks ASTContext &Context) { 32220f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only handle constant-sized or VLAs, but not flexible members. 32230f38acee92014cb15af980808f87144e5564031dAnna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 32240f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only issue the FIXIT for arrays of size > 1. 32250f38acee92014cb15af980808f87144e5564031dAnna Zaks if (CAT->getSize().getSExtValue() <= 1) 32260f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 32270f38acee92014cb15af980808f87144e5564031dAnna Zaks } else if (!Ty->isVariableArrayType()) { 32280f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 32290f38acee92014cb15af980808f87144e5564031dAnna Zaks } 32300f38acee92014cb15af980808f87144e5564031dAnna Zaks return true; 32310f38acee92014cb15af980808f87144e5564031dAnna Zaks} 32320f38acee92014cb15af980808f87144e5564031dAnna Zaks 3233bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 3234bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 3235bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 3236bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 3237bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3238bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 3239bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 3240bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3241bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3242bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 3243bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 3244bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 3245bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3246bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 3247bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 3248bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 3249bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 3250bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 3251bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 3252180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 3253bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 3254bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 3255bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3256bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3257bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3258bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 3259bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3260bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3261bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 3262bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 3263bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 3264bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 3265bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 3266bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 3267bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3268bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3269bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 3270bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 3271bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 3272bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3273bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3274bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 3275bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 3276bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 3277bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3278bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 3279bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 3280bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 3281bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 3282bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 32830f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 32848f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 32858f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 3286f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 32878f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 32888f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 3289d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 32908f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 32918f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 32928f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 32938f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 32948f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 3295bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3296bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3297c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 3298c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 3299c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 3300c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 3301c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 3302c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 3303c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3304c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3305c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 3306c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 3307c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 3308c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 3309c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3310c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 3311c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3312c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3313c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3314c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3315c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 3316c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 3317c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 3318c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 3319c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 3320c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 3321c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 3322c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3323c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 3324c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 3325c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 3326c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3327c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 3328c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 3329c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 3330c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 3331c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 3332c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 3333c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3334c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 3335c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 3336c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3337c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 3338c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 3339c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 3340c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 3341c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 3342c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 3343c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 3344c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3345c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 3346c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 3347c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3348c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3349c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3350c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3351c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 3352c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3353c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3354afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 3355afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 3356afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 3357afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 3358afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 3359afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 3360afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 3361afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 3362afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 3363afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 3364afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 3365afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 33660f38acee92014cb15af980808f87144e5564031dAnna Zaks // Check if the destination is an array (rather than a pointer to an array). 33670f38acee92014cb15af980808f87144e5564031dAnna Zaks QualType DstTy = DstArg->getType(); 33680f38acee92014cb15af980808f87144e5564031dAnna Zaks bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 33690f38acee92014cb15af980808f87144e5564031dAnna Zaks Context); 33700f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isKnownSizeArray) { 33710f38acee92014cb15af980808f87144e5564031dAnna Zaks if (PatternType == 1) 33720f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_wrong_size) << SR; 33730f38acee92014cb15af980808f87144e5564031dAnna Zaks else 33740f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 33750f38acee92014cb15af980808f87144e5564031dAnna Zaks return; 33760f38acee92014cb15af980808f87144e5564031dAnna Zaks } 33770f38acee92014cb15af980808f87144e5564031dAnna Zaks 3378c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 3379afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 3380c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 3381afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 3382c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3383f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 3384c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 3385c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 3386d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3387c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 3388c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 3389d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3390c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 3391c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3392afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 3393afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 3394c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3395c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 339606de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 339706de276fff91264437fa75111ed76de43097e089Ted Kremenek 3398e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3399e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 3400e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars, 3401e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 340206de276fff91264437fa75111ed76de43097e089Ted Kremenek 340306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 340406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 340506de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 340606de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 340706de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 34081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 340926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 34105f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 34114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 341226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 341326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 3414f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 34154e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 3416e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0); 3417ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 3418e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0); 341926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 342026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 342126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 342226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 342326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 342426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 342526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 342626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 342726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 342826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 342926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 343026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 343126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 343226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 343326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 343426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 343526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 343626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 343726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 343826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 343926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 344026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 344126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 344226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 344326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 344426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 344526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 344626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 344726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 344826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 344926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 345026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 345126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 345226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 345326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 345426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 345526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 345626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 345726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 345826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 345926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 346026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 346126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 346226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 346306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 346406de276fff91264437fa75111ed76de43097e089Ted Kremenek} 346506de276fff91264437fa75111ed76de43097e089Ted Kremenek 346606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 346706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 346826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 346926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 347006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 347126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 347226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 347326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 347426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 347526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 347626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 347726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 347806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 3479e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 3480e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 348126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 348226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 348306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 348406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 348506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 348606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 348706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 348806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 348906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 349006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 349106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 3492e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3493e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 349426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 349526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 349626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 349706de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 34980f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 3499dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 3500a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 3501fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 35021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3503f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 3504f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 350506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 350606de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 350706de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 350806de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 350926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 351026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 351126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 351226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 351326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 351426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 351526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 351626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 351726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 351826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3519e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(V->getInit(), refVars, ParentDecl); 352026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 352126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 352226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 352326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 352406de276fff91264437fa75111ed76de43097e089Ted Kremenek 3525fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 3526fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 3527fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 3528fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 35291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 35302de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 3531e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars, ParentDecl); 3532fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 3533fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 3534fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 35351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3536fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 3537fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 3538fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 3539fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 35402de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 35411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 35422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 3543fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 35441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3545fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 35463907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3547fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 3548fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 3549fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 35501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3551fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 3552e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(Base, refVars, ParentDecl); 3553fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 355461f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 3555fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 3556fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 3557fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 3558fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 35591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3560fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 35619ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 35629ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 35639ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 3564e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl)) 35659ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 35669ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 35679ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 35689ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 35699ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 35709ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 357106de276fff91264437fa75111ed76de43097e089Ted Kremenek 3572e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars, ParentDecl); 3573fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 357426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 357526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 3576469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 357726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 357826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 357926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 358026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 358126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 35821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 358380ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3584e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 3585e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis ParentDecl); 358680ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 358754b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 358854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 358949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 35906eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 3591f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 35928b9414e868853fc052251455674bf7512261e14aEli Friedman case Stmt::ObjCBridgedCastExprClass: 35931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 35941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 359549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 359649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 35978b9414e868853fc052251455674bf7512261e14aEli Friedman Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 35988b9414e868853fc052251455674bf7512261e14aEli Friedman switch (cast<CastExpr>(E)->getCastKind()) { 35998b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BitCast: 36008b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_LValueToRValue: 36018b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_NoOp: 36028b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BaseToDerived: 36038b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_DerivedToBase: 36048b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_UncheckedDerivedToBase: 36058b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_Dynamic: 36068b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_CPointerToObjCPointerCast: 36078b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BlockPointerToObjCPointerCast: 36088b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_AnyPointerToBlockPointerCast: 3609e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(SubExpr, refVars, ParentDecl); 36108b9414e868853fc052251455674bf7512261e14aEli Friedman 36118b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_ArrayToPointerDecay: 3612e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(SubExpr, refVars, ParentDecl); 36138b9414e868853fc052251455674bf7512261e14aEli Friedman 36148b9414e868853fc052251455674bf7512261e14aEli Friedman default: 36158b9414e868853fc052251455674bf7512261e14aEli Friedman return 0; 36168b9414e868853fc052251455674bf7512261e14aEli Friedman } 3617fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 36181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 361903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 362003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 362103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3622e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 362303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 362403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 362503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 362603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 3627fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 3628fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 3629fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 363006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 363106de276fff91264437fa75111ed76de43097e089Ted Kremenek} 36321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 363306de276fff91264437fa75111ed76de43097e089Ted Kremenek 363406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 363506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 3636e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3637e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 363868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 3639e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 3640e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 3641e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 36421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 364306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 364406de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 364506de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 3646f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 3647f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 364806de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 364968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 365068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 36515baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 365268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 365368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 365468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 365568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 365668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 365768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 365880ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3659e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl); 366080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 3661a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 366226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 366326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 366426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 366506de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 36661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3667e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 3668e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis // Check if it refers to itself, e.g. "int& i = i;". 3669e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (V == ParentDecl) 3670e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return DR; 3671e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis 367226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 367326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 367426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 367526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 367626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 367726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 367826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 367926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 368026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3681e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(V->getInit(), refVars, V); 368226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 368326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 3684e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis } 36851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 368606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 368706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 36881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 368906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 369006de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 369106de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 369206de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 369306de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 36941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 36952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 3696e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 369706de276fff91264437fa75111ed76de43097e089Ted Kremenek 369806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 369906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 370106de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 370206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 370306de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 370406de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 3705e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl); 370606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 370806de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 370906de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 371026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 371106de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 371206de276fff91264437fa75111ed76de43097e089Ted Kremenek 37133907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 37143907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 3715e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl)) 37163907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 37173907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3718e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(C->getRHS(), refVars, ParentDecl); 371906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 372106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 372283f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 372306de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 37241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 372506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 3726a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 3727a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 3728a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3729a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 3730a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 3731a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 373206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 3733a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3734e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(M->getBase(), refVars, ParentDecl); 373506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 373703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 373803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 373903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3740e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 374103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 374203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 374303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 374403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 374506de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 374626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 374726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 374826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 374926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 375026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 375126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 375206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 375306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 375468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 375506de276fff91264437fa75111ed76de43097e089Ted Kremenek} 3756588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3757588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 3758588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3759588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 3760588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 3761588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 3762dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 3763dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 3764dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 3765588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3766588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 3767588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 3768588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 3769588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 3770588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 3771980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 37721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 37731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 37741b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 37751b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 37761b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 37771b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 37781b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 3779980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 3780980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLL->isExact()) 3781980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 3782980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie } else 3783980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 3784980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLR->isExact()) 3785980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 37861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3787588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 3788980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 3789980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CL->isBuiltinCall()) 3790980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 37911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3792980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 3793980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CR->isBuiltinCall()) 3794980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 37951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3796588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 3797980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie Diag(Loc, diag::warn_floatingpoint_eq) 3798980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie << LHS->getSourceRange() << RHS->getSourceRange(); 3799588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 3800ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3801f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 3802f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 3803ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3804f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 3805ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3806f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 3807f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 3808f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 3809f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 3810f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 3811ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3812f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 3813f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 381451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3815f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 3816f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 3817f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 381851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 3820f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 3821f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 3822f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 382351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 38251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 38261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 38271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 382851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 382951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 38311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 3832f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 383351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3834f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 3835f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 3836f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 3837f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 3838323ed74658bc8375278eabf074b4777458376540John McCall 3839091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 3840323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 3841323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 38425e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall if (!Enum->isCompleteDefinition()) 3843091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 3844091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3845323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 3846323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 3847323ed74658bc8375278eabf074b4777458376540John McCall 3848323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 3849323ed74658bc8375278eabf074b4777458376540John McCall } 385051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3851f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 3852f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 385351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3854f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 385551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 385651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 38581844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 38591844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 38601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 38611844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 38621844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 38631844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 38641844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 38651844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 38661844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 38671844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 38681844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 38691844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 387069ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 38711844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 38721844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 38731844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 38741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 38751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 38761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 38771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 38781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 3879c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 3880f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 388160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 388260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 388360fad45739b764886f707bd204eae9ecce6db1f2John McCall 38841844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 3885c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 388660fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 388760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 388851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3889f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 389051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38910692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 38920692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 3893f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 3894f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 389551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3896f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 38979f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 389851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3899f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 3900f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 3901f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 390251313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 390351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39040692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 39050692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 3906f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 3907f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 390851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3909f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 39100acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 39110acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 39120acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 39130acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 39140acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 3915f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 391651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 391751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3918f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 3919f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 3920f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 3921f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 3922f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3923f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3924f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 3925f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 39260acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 39270acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 39280acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 392965639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 39305e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 393151313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 393251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3933f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 3934f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 3935f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3936f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 39370692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 393851313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 393951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3940f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 3941f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 394251f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 39430acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 394451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3945f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 3946f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 3947f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 3948f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 3949b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 3950f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 395151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39521844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 395351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39542de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 395560fad45739b764886f707bd204eae9ecce6db1f2John McCall 3956f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 395760fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 3958f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 395951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3960f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 3961f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 3962f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 396351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3964f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 3965f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 3966f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 396751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3968f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 3969f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 3970f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 3971f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 3972f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3973f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3974f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 3975f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 3976f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 3977f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 3978f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 3979f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 3980f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 3981f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3982f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 3983f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 3984f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 3985f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 398651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 398751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 398851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 398951313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 399051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3991f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 39922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 39932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 39942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 39952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 39962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 39972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 39982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 39992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 4000f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 400151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4002862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 4003862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 40042de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 40052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 40062de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 40072de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 40082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 4009862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 4010862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 4011862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 40121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 4013c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 4014862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 4015862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 4016862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 4017862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 4018862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4019862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 402051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 40212de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 40222de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 40231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 402451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 402560fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 40262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 40272de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 402860fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 402960fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 403060fad45739b764886f707bd204eae9ecce6db1f2John McCall 403151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 40322de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 40333aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 40343aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 40353aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 40363aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 40373aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 40381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 40393aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 40403aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 40413aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 40423aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 40433aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 40442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 40451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 404651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 404760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 40482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 40492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 405060fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 405160fad45739b764886f707bd204eae9ecce6db1f2John McCall 405260fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 405360fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 405460fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 405560fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 405660fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 405760fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 405860fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 405960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 406060fad45739b764886f707bd204eae9ecce6db1f2John McCall else 406160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 406260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 406360fad45739b764886f707bd204eae9ecce6db1f2John McCall 406460fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 406560fad45739b764886f707bd204eae9ecce6db1f2John McCall } 406660fad45739b764886f707bd204eae9ecce6db1f2John McCall 406760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 40682de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 4069f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4070f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 407160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 40722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 407351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 40741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 407500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 407600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 407700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 407800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 407900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 408000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 408100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 408200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 408300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 408400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 408500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 408600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 408700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 408800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 408900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 409000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 409100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 409200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 409300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 409400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 409500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 409600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 409700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 409800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 409900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 410000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 410100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 410200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 410300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 410400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 410500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 410600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 410700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 410800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 410900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 411000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 411100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 41124e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 411300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 411400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 411500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 411600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 411700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 4118f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 411951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4120f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 412100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 412200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 4123f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4124f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 4125f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 412651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 412751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 412851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 412951313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 413051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 41312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 4132f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 413351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 413451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 41352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 41362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 41371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 413851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 413951313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 4140f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 414151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 414251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 41438ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 41448ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 41451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 41468ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 414751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4148a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (FieldDecl *BitField = E->getBitField()) 4149a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 41505e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 4151f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 41521844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 4153f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4154f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 41550692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 4156323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 4157323ed74658bc8375278eabf074b4777458376540John McCall} 4158323ed74658bc8375278eabf074b4777458376540John McCall 4159f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4160f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4161f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 41620692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 41630692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 41640692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4165f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 4166f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4167f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 4168f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 4169f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 4170f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4171f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 417251313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 417351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4174f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4175f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4176f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 4177f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4178f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 41790692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 41800692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 41810692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4182f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 4183f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 4184f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4185f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 4186f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 4187f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 4188f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 4189f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 4190f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4191f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4192f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 4193f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 4194f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 4195f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4196f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 41970692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 4198323ed74658bc8375278eabf074b4777458376540John McCall 4199e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 4200e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 4201e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 4202e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 4203e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 4204e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4205e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4206e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 4207e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 4208e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4209e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4210323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 4211323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 4212323ed74658bc8375278eabf074b4777458376540John McCall} 4213323ed74658bc8375278eabf074b4777458376540John McCall 4214372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 4215372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 4216372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 421763b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 421863b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 4219372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 422063b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 4221372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 4222372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 4223372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 4224372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 4225372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 42260692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 42272de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 422814af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 422914af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 423014af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 42312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 4232323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4233372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 4234323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 42352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 4236323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4237372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 4238323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 42392de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 4240323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4241372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 4242323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 42432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 4244323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4245372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 4246323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4247323ed74658bc8375278eabf074b4777458376540John McCall } 4248323ed74658bc8375278eabf074b4777458376540John McCall} 4249323ed74658bc8375278eabf074b4777458376540John McCall 4250323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 4251323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 42520692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 4253b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4254b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4255323ed74658bc8375278eabf074b4777458376540John McCall} 4256f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4257ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 4258ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 4259dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 42600692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 4261323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 4262323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 4263323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 4264323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 4265323ed74658bc8375278eabf074b4777458376540John McCall 4266323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 4267323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 4268323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 42693e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 42703e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 42713e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 42723e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 42733e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 4274323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 4275323ed74658bc8375278eabf074b4777458376540John McCall 4276dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 4277dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 4278323ed74658bc8375278eabf074b4777458376540John McCall 4279323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 4280323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 4281323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 4282dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 4283dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 4284323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 4285dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 4286dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 4287dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 4288dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 4289dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 4290ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 4291323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 4292323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 4293ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 4294ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4295323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 4296323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 4297f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4298323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 4299323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 4300dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 4301dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 4302ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4303323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 4304323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 4305323ed74658bc8375278eabf074b4777458376540John McCall // or false. 4306323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 4307323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 4308ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4309ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 4310ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 4311ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 4312ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 4313323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 4314323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 4315323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 4316323ed74658bc8375278eabf074b4777458376540John McCall 4317323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 4318323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 4319323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 4320ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4321323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 4322323ed74658bc8375278eabf074b4777458376540John McCall return; 4323323ed74658bc8375278eabf074b4777458376540John McCall } 4324323ed74658bc8375278eabf074b4777458376540John McCall 43256d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 43266d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.PDiag(diag::warn_mixed_sign_comparison) 43276d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getType() << RHS->getType() 43286d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getSourceRange() << RHS->getSourceRange()); 4329ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 4330ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 433115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 433215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 433315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 43340692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 43350692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 433615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 433715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 433815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 433915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 434091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 434191b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 434291b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 434391b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 434446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 434546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 434646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 434746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 434846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 434946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 435046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 435115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 435215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 435380d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 435480d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 435515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 435615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 435715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 4358a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 435915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 436015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 436115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 436215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 43633a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 43649f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 43653a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 436615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 43673a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 43683a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 4369e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 437015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 437115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 43723a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 437334ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 437434ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 43753a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 43763a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 437715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 437815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 437915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 438015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 438115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 438215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 438315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 438415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 438515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 438615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4387beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 4388beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 43890692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 4390beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 4391beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4392beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4393beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 4394beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 4395beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 439615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 439715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 439815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 439915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 440015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 4401beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4402beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4403beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4404beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4405beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 4406beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 440751313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 44080692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 4409c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4410c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4411c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 4412c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 4413c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 4414c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 4415c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 4416c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 4417c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 44185a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 44195a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 44205a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 44215a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4422e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 44230692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 4424c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4425c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4426c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 4427e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 4428e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 44299ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 44309ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 4431f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 4432f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 44339ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 4434f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 44359ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 44363e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 44373e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 44383e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 4439f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 44409ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 4441f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 4442f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4443be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie SmallString<16> PrettySourceValue; 4444be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie Value.toString(PrettySourceValue); 4445de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie SmallString<16> PrettyTargetValue; 4446be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (T->isSpecificBuiltinType(BuiltinType::Bool)) 4447be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie PrettyTargetValue = IntegerValue == 0 ? "false" : "true"; 4448be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie else 4449de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie IntegerValue.toString(PrettyTargetValue); 4450be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 44519ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 4452be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << FL->getType() << T.getUnqualifiedType() << PrettySourceValue 4453be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext); 4454f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 4455f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4456091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 4457091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 4458091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4459091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 4460091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 44619f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 4462091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 4463091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 4464091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 446588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 446688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!isa<ImplicitCastExpr>(Ex)) 446788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 446888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 446988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = Ex->IgnoreParenImpCasts(); 447088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 447188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Source = 447288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 447388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isDependentType()) 447488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 447588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 447688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const BuiltinType *FloatCandidateBT = 447788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg dyn_cast<BuiltinType>(ToBool ? Source : Target); 447888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *BoolCandidateType = ToBool ? Target : Source; 447988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 448088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 448188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 448288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 448388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 448488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 448588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg SourceLocation CC) { 448688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = TheCall->getNumArgs(); 448788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg for (unsigned i = 0; i < NumArgs; ++i) { 448888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *CurrA = TheCall->getArg(i); 448988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 449088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg continue; 449188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 449288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg bool IsSwapped = ((i > 0) && 449388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 449488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsSwapped |= ((i < (NumArgs - 1)) && 449588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 449688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (IsSwapped) { 449788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion. 449888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 449988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CurrA->getType(), CC, 450088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 450188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 450288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 450388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 450488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 4505323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 4506b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 4507323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 450851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4509323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 4510323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 4511323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 4512323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 451351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4514108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 4515108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 4516108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 4517108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 4518108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 4519ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 4520b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 4521b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4522f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 4523f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 4524f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 4525f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 4526f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 4527f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 4528f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 4529f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 4530e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 4531e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 4532e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 4533e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 4534e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 4535e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 4536e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 4537e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 4538e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 4539e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 4540e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4541e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 4542e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 454326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 454426b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 454526b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 45462def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 45472def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 45482def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 45492def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 45502def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.isExprCallable(*E, ReturnType, NonTemplateOverloads); 45512def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 45522def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 45532def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 45542def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 45552def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 455626b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 455726b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 4558e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4559e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4560f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 456151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 456251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 456351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 4564ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 4565d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4566ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4567b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 4568ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4569b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 4570b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 4571b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 4572b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 4573b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 457451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 457551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 457651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 457751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 457851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 457951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 458051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 4581ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 4582d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4583ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4584ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4585b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 4586ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 458751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 458851313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 458951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 459051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 459151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 459251313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 459351313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 459451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 459551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 459651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 459751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 459851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 459951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 460051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 460151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 460251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 460351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 460451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 460551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 460651f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 460751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 460851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 4609323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 4610323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 461151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 461251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 461351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4614d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4615ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4616ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4617b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 461851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 461951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 462051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 462151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4622ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 4623be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (TargetBT && TargetBT->isInteger()) { 4624d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4625ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4626ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4627a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 4628634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 4629634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 4630634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 4631634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 4632634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 4633f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 4634f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 4635a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 4636a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 4637a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 4638a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 463951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 464088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // If the target is bool, warn if expr is a function or method call. 464188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isSpecificBuiltinType(BuiltinType::Bool) && 464288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg isa<CallExpr>(E)) { 464388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check last argument of function call to see if it is an 464488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // implicit cast from a type matching the type the result 464588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // is being cast to. 464688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CallExpr *CEx = cast<CallExpr>(E); 464788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = CEx->getNumArgs(); 464888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (NumArgs > 0) { 464988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *LastA = CEx->getArg(NumArgs - 1); 465088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = LastA->IgnoreParenImpCasts(); 465188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *InnerType = 465288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 465388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) { 465488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion 465588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, E, T, CC, 465688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 465788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 465888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 465988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 466051313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 466151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 466251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 46631838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 4664b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie == Expr::NPCK_GNUNull) && !Target->isAnyPointerType() 466528a5f0cdfcc927a94c1bda6a225200762df22411David Blaikie && !Target->isBlockPointerType() && !Target->isMemberPointerType()) { 4666b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie SourceLocation Loc = E->getSourceRange().getBegin(); 4667b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie if (Loc.isMacroID()) 4668b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 46699fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie if (!Loc.isMacroID() || CC.isMacroID()) 46709fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 46719fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << T << clang::SourceRange(CC) 46729fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T)); 46731838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 46741838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 4675b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie if (!Source->isIntegerType() || !Target->isIntegerType()) 4676b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie return; 4677b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie 4678be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // TODO: remove this early return once the false positives for constant->bool 4679be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // in templates, macros, etc, are reduced or removed. 4680be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 4681be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie return; 4682be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 4683323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 46841844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 468551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4686f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 4687091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 4688091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 4689091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 4690091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 4691d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4692ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4693ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4694091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 4695091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 4696091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 46975e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 46985e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 46995e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 47005e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 47015e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 4702091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 4703091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 4704091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4705b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 4706d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4707ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4708ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 470937050841d7b852497b85d5275d9ea92c07ddf059David Blaikie if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 4710c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 4711c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 4712b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 4713323ed74658bc8375278eabf074b4777458376540John McCall } 4714323ed74658bc8375278eabf074b4777458376540John McCall 4715323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 4716323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 4717323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 4718ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4719d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4720ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4721ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4722323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 4723323ed74658bc8375278eabf074b4777458376540John McCall 4724323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 4725323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 4726323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 4727323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 4728323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 4729323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 4730323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 4731323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 4732323ed74658bc8375278eabf074b4777458376540John McCall } 4733323ed74658bc8375278eabf074b4777458376540John McCall 4734b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 473551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 473651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4737284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 47385a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 47395a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 47405a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 47414e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!S.getLangOpts().CPlusPlus) { 47425a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 47435a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 47445a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 47455a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 47465a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 47475a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 47485a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 47495a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4750284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 4751284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 4752284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 4753162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 4754284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 4755162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 4756ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 4757d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4758ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4759ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 47605a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 4761284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 4762ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4763284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 476451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 476551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 476651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 47679fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 47689fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T); 4769323ed74658bc8375278eabf074b4777458376540John McCall 4770323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 4771b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 4772323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 4773323ed74658bc8375278eabf074b4777458376540John McCall 4774323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 47759fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 4776323ed74658bc8375278eabf074b4777458376540John McCall 4777b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 4778323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4779b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 4780323ed74658bc8375278eabf074b4777458376540John McCall return; 4781323ed74658bc8375278eabf074b4777458376540John McCall} 4782323ed74658bc8375278eabf074b4777458376540John McCall 47839fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 47849fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T) { 4785b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 4786323ed74658bc8375278eabf074b4777458376540John McCall 4787323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 4788b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 4789b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 4790323ed74658bc8375278eabf074b4777458376540John McCall 4791323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 4792323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 4793323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 4794323ed74658bc8375278eabf074b4777458376540John McCall 4795323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 47960827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 47970827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 4798323ed74658bc8375278eabf074b4777458376540John McCall return; 4799323ed74658bc8375278eabf074b4777458376540John McCall 4800323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 4801323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 48025254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 48035254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 48045254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 48055254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 48065254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 48075254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 48085254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 4809b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 4810323ed74658bc8375278eabf074b4777458376540John McCall} 4811323ed74658bc8375278eabf074b4777458376540John McCall 4812323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 4813323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 4814323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 4815b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 4816323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 4817323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 4818323ed74658bc8375278eabf074b4777458376540John McCall 4819f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 4820f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 4821f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 4822323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 4823323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 4824323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 4825323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 48269fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie CheckConditionalOperator(S, CO, CC, T); 4827323ed74658bc8375278eabf074b4777458376540John McCall return; 4828323ed74658bc8375278eabf074b4777458376540John McCall } 4829323ed74658bc8375278eabf074b4777458376540John McCall 483088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check implicit argument conversions for function calls. 483188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (CallExpr *Call = dyn_cast<CallExpr>(E)) 483288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CheckImplicitArgumentConversions(S, Call, CC); 483388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 4834323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 4835323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 4836323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 4837323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4838b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 4839323ed74658bc8375278eabf074b4777458376540John McCall 4840323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 4841323ed74658bc8375278eabf074b4777458376540John McCall 4842323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 4843323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 4844323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 4845b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 4846323ed74658bc8375278eabf074b4777458376540John McCall } 4847323ed74658bc8375278eabf074b4777458376540John McCall 4848beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 4849beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 4850beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 4851beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 4852beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 48530fa063816818ac53a0015a5d2b0328812005b40eEli Friedman // And with simple assignments. 48540fa063816818ac53a0015a5d2b0328812005b40eEli Friedman if (BO->getOpcode() == BO_Assign) 4855beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 4856beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4857323ed74658bc8375278eabf074b4777458376540John McCall 4858323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 4859323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 4860323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 4861323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 4862323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 4863323ed74658bc8375278eabf074b4777458376540John McCall 4864323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 4865f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 4866323ed74658bc8375278eabf074b4777458376540John McCall 4867323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 4868b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 4869f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 4870f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 4871f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 487254042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 4873503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 4874503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 4875503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 4876f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 4877f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 4878f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 4879f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 4880f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 4881f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 4882323ed74658bc8375278eabf074b4777458376540John McCall} 4883323ed74658bc8375278eabf074b4777458376540John McCall 4884323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 4885323ed74658bc8375278eabf074b4777458376540John McCall 4886323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 4887323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 4888323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 4889b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 4890b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 4891b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 4892b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 4893b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 4894323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 489571f55f771794674a410171dbf3cb5dbedf95d033David Blaikie if (isUnevaluatedContext()) 4896323ed74658bc8375278eabf074b4777458376540John McCall return; 4897323ed74658bc8375278eabf074b4777458376540John McCall 4898323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 4899323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 4900323ed74658bc8375278eabf074b4777458376540John McCall return; 4901323ed74658bc8375278eabf074b4777458376540John McCall 4902d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 4903d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 4904d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 4905d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 4906d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4907b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 4908b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 4909323ed74658bc8375278eabf074b4777458376540John McCall} 4910323ed74658bc8375278eabf074b4777458376540John McCall 491115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 491215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 491315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 491415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 491515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 491615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4917f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 4918f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 4919f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 4920f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 4921f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 492282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 492382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 4924f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 492582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 492682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 492782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 4928f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 4929f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 4930f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 4931f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 4932f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 4933f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 4934f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 4935d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_typecheck_decl_incomplete_type)) { 4936f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 4937f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 4938f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 4939f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 4940f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 4941f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 494282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 494382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 4944f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 49454e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().CPlusPlus) 4946f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 4947d17e340e2d516139931768697bf080f60920ba9dSam Weinig 4948d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 4949d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 4950d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 4951d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 4952d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 4953d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 4954d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 4955d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 4956bed28ac1d1463adca3ecf24fca5c30646fa9dbb2Sylvestre Ledru // FIXME: This diagnosic should point the '[*]' if source-location 4957d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 4958d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 4959d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 4960d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 4961f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 4962f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 4963f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 4964f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 4965b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4966b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 4967b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 4968b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 4969b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 4970b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 49710827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 49720827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 4973d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 4974b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 4975b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4976b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 4977b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 4978b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 4979b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4980b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 4981b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 4982b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 4983b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4984b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 4985b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 4986b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 4987b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 4988b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 4989b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4990b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 4991b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 4992b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 4993b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 4994b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4995b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 4996b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 4997b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 4998b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 4999b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 5000b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5001b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 5002b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 5003b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5004b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 5005b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 5006b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 5007b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 5008b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 5009b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 5010b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5011d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 5012d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 5013d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 5014d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 5015d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 5016d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 5017d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 5018d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 5019d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5020c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 5021c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 5022c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 5023c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 5024c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 5025c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 5026c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 5027c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 5028c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5029c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 5030c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 5031c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5032c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 5033c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 5034d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan 5035d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 503600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek while (TInfo) { 503700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TypeLoc TL = TInfo->getTypeLoc(); 503800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek // Look through typedefs. 503900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek const TypedefTypeLoc *TTL = dyn_cast<TypedefTypeLoc>(&TL); 504000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek if (TTL) { 504100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek const TypedefNameDecl *TDL = TTL->getTypedefNameDecl(); 504200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TInfo = TDL->getTypeSourceInfo(); 504300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek continue; 504400e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek } 504500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek ConstantArrayTypeLoc CTL = cast<ConstantArrayTypeLoc>(TL); 504600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 5047d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 5048d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan return false; 504900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek break; 5050d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan } 5051c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5052c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 5053381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 5054381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 5055381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 5056381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 5057381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 5058c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 505922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 506022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 506122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 506222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 506322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 506422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 5065c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 5066c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5067d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 506880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 506925b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 507092b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman IndexExpr = IndexExpr->IgnoreParenImpCasts(); 507180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 507280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 5073d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 507480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 507580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 50763406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 5077d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 50783406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 5079a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 508035001ca261f895817916b468379b696d6d45959dChandler Carruth 50813406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 508280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 5083a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 508425b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 508525b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 50868fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 5087ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 5088ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 5089ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 5090c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 5091ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 5092ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 50939e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 509425b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 509535001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 509635001ca261f895817916b468379b696d6d45959dChandler Carruth return; 5097d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5098d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 5099de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 5100d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 5101d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 5102d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 5103d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 510418f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 5105d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 5106d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 5107d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 5108d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 5109d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 5110d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 5111d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 5112d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5113d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5114d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 51153406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 511692b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman index = index.zext(size.getBitWidth()); 511725b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 511892b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman size = size.zext(index.getBitWidth()); 511925b3b849e3ad340b04442707038c86980035765bTed Kremenek 5120d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 5121d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 5122d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 5123d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 512492b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 5125ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 5126ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 5127ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 5128ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 5129ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 5130d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 51318fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 51323406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 513380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 513480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 513580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 513680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 513780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 513880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 513980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 514080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 514180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 514280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 514380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 514480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 514580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 514680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 5147d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 514880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 5149d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 5150d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5151d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 5152d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 5153d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 5154d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 5155d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 51563406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 5157d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 515880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 5159d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 5160d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 5161d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5162d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5163d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 5164d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 5165d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 5166a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 516735001ca261f895817916b468379b696d6d45959dChandler Carruth 5168cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 5169cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 5170cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 5171cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 5172cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 5173cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 5174cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 5175cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 5176cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 5177cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 5178cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 517935001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 5180d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 5181d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 5182d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 51833aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 51843aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 51853aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 5186d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 5187d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 5188d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 51893aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 5190d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 5191d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 519280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 5193d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 51943aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 5195d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5196d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 5197d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 5198d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 5199d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 5200d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 5201d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 5202d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 5203d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5204d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 5205d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 5206d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5207d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 5208d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 5209d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5210d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5211d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 52123aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 52133aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 52143aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 52153aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 52163aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 52173aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 52183aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 52193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 52203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 52213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 52223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 5223f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 5224a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 5225f85e193739c953358c865005855253af4f68a497John McCall 5226f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 5227f85e193739c953358c865005855253af4f68a497John McCall 5228f85e193739c953358c865005855253af4f68a497John McCallnamespace { 5229f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 5230f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 5231f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 5232f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 5233f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 5234f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 5235f85e193739c953358c865005855253af4f68a497John McCall 5236f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 5237f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 5238f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 5239f85e193739c953358c865005855253af4f68a497John McCall } 5240f85e193739c953358c865005855253af4f68a497John McCall }; 5241f85e193739c953358c865005855253af4f68a497John McCall} 5242f85e193739c953358c865005855253af4f68a497John McCall 5243f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 5244f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 5245f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 5246f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 5247f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 5248f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 5249f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 5250f85e193739c953358c865005855253af4f68a497John McCall return false; 5251f85e193739c953358c865005855253af4f68a497John McCall 5252f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 5253f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 5254f85e193739c953358c865005855253af4f68a497John McCall return true; 5255f85e193739c953358c865005855253af4f68a497John McCall} 5256f85e193739c953358c865005855253af4f68a497John McCall 52576e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 5258f85e193739c953358c865005855253af4f68a497John McCall while (true) { 5259f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 5260f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 5261f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 5262f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 5263f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 5264f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 526533e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 5266f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 5267f85e193739c953358c865005855253af4f68a497John McCall continue; 5268f85e193739c953358c865005855253af4f68a497John McCall 5269f85e193739c953358c865005855253af4f68a497John McCall default: 5270f85e193739c953358c865005855253af4f68a497John McCall return false; 5271f85e193739c953358c865005855253af4f68a497John McCall } 5272f85e193739c953358c865005855253af4f68a497John McCall } 5273f85e193739c953358c865005855253af4f68a497John McCall 5274f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 5275f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 5276f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 5277f85e193739c953358c865005855253af4f68a497John McCall return false; 5278f85e193739c953358c865005855253af4f68a497John McCall 5279f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 52806e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 5281f85e193739c953358c865005855253af4f68a497John McCall return false; 5282f85e193739c953358c865005855253af4f68a497John McCall 5283f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 5284f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 5285f85e193739c953358c865005855253af4f68a497John McCall return true; 5286f85e193739c953358c865005855253af4f68a497John McCall } 5287f85e193739c953358c865005855253af4f68a497John McCall 5288f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 5289f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 5290f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 5291f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 5292f85e193739c953358c865005855253af4f68a497John McCall } 5293f85e193739c953358c865005855253af4f68a497John McCall 5294f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 5295f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 5296f85e193739c953358c865005855253af4f68a497John McCall 5297f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 5298f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 5299f85e193739c953358c865005855253af4f68a497John McCall continue; 5300f85e193739c953358c865005855253af4f68a497John McCall } 5301f85e193739c953358c865005855253af4f68a497John McCall 53024b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 53034b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 53044b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 53054b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 53064b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 53074b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 53084b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 53094b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 53104b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 53114b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 53124b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 53134b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 53144b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 53154b9c2d235fb9449e249d74f48ecfec601650de93John McCall 53164b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 53176e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 53186e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 53196e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 53206e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 53216e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 53226e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 53236e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 53246e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 53254b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 53264b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 53274b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 53284b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 53294b9c2d235fb9449e249d74f48ecfec601650de93John McCall 5330f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 5331f85e193739c953358c865005855253af4f68a497John McCall 5332f85e193739c953358c865005855253af4f68a497John McCall return false; 5333f85e193739c953358c865005855253af4f68a497John McCall } 5334f85e193739c953358c865005855253af4f68a497John McCall} 5335f85e193739c953358c865005855253af4f68a497John McCall 5336f85e193739c953358c865005855253af4f68a497John McCallnamespace { 5337f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 5338f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 5339f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 5340f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 5341f85e193739c953358c865005855253af4f68a497John McCall 5342f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 5343f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 5344f85e193739c953358c865005855253af4f68a497John McCall 5345f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 5346f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 5347f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 5348f85e193739c953358c865005855253af4f68a497John McCall } 5349f85e193739c953358c865005855253af4f68a497John McCall 5350f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 5351f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 5352f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 5353f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 5354f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 5355f85e193739c953358c865005855253af4f68a497John McCall } 5356f85e193739c953358c865005855253af4f68a497John McCall 5357f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 5358f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 5359f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 5360f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 5361f85e193739c953358c865005855253af4f68a497John McCall } 53627e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian 53637e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 53647e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (Capturer) return; 53657e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (OVE->getSourceExpr()) 53667e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian Visit(OVE->getSourceExpr()); 53677e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian } 5368f85e193739c953358c865005855253af4f68a497John McCall }; 5369f85e193739c953358c865005855253af4f68a497John McCall} 5370f85e193739c953358c865005855253af4f68a497John McCall 5371f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 5372f85e193739c953358c865005855253af4f68a497John McCall/// variable. 5373f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 5374f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 5375f85e193739c953358c865005855253af4f68a497John McCall 5376f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 5377f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 5378f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 5379f85e193739c953358c865005855253af4f68a497John McCall return 0; 5380f85e193739c953358c865005855253af4f68a497John McCall 5381f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 5382f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 5383f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 5384f85e193739c953358c865005855253af4f68a497John McCall} 5385f85e193739c953358c865005855253af4f68a497John McCall 5386f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 5387f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 5388f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 5389f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 5390f85e193739c953358c865005855253af4f68a497John McCall 5391f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 5392f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 5393f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 5394f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 5395f85e193739c953358c865005855253af4f68a497John McCall} 5396f85e193739c953358c865005855253af4f68a497John McCall 5397f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 5398f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 5399f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 5400f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 5401f85e193739c953358c865005855253af4f68a497John McCall 54025f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 5403f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 5404968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 5405f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 5406968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 5407968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 5408968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 5409968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 5410968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 5411968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 5412f85e193739c953358c865005855253af4f68a497John McCall else 5413f85e193739c953358c865005855253af4f68a497John McCall return false; 5414f85e193739c953358c865005855253af4f68a497John McCall 5415f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 5416f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 5417f85e193739c953358c865005855253af4f68a497John McCall} 5418f85e193739c953358c865005855253af4f68a497John McCall 5419f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 5420f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 5421f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 5422f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 5423f85e193739c953358c865005855253af4f68a497John McCall return; 5424f85e193739c953358c865005855253af4f68a497John McCall 5425f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 5426f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 5427f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 54286e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 5429f85e193739c953358c865005855253af4f68a497John McCall return; 5430f85e193739c953358c865005855253af4f68a497John McCall } else { 5431f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 5432f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 5433f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 5434f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 5435f85e193739c953358c865005855253af4f68a497John McCall } 5436f85e193739c953358c865005855253af4f68a497John McCall 5437f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 5438f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 5439f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 5440f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 5441f85e193739c953358c865005855253af4f68a497John McCall} 5442f85e193739c953358c865005855253af4f68a497John McCall 5443f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 5444f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 5445f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 54466e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 5447f85e193739c953358c865005855253af4f68a497John McCall return; 5448f85e193739c953358c865005855253af4f68a497John McCall 5449f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 5450f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 5451f85e193739c953358c865005855253af4f68a497John McCall} 5452f85e193739c953358c865005855253af4f68a497John McCall 5453921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 5454f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 5455f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 5456f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 5457921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 5458921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 5459921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 546033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 5461f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 5462bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian << (LT == Qualifiers::OCL_ExplicitNone) << 1 5463f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 5464921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 5465921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5466921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 5467921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5468921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 5469f85e193739c953358c865005855253af4f68a497John McCall} 5470f85e193739c953358c865005855253af4f68a497John McCall 5471921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 5472921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 547387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 547487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 547587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 547687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 547787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 547887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 547987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 548087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 548187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 548287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 548387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 548487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 548587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 5486921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 5487921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5488921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 5489921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 5490921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 5491921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5492921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 549387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 5494921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 5495921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5496921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 5497921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 5498921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5499921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 5500921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 550187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 550287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 550387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 550487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 550587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 550687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 550787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 550887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 550987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 5510921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 551133e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 5512921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 5513921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 5514921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5515921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5516921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 5517921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 551887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 5519bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 5520bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 5521bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian if (cast->getCastKind() == CK_ARCConsumeObject) { 5522bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_assign) 5523bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian << 0 << 0<< RHS->getSourceRange(); 5524bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian return; 5525bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 5526bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian RHS = cast->getSubExpr(); 5527bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 5528bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 5529921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5530921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 5531625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5532625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 5533625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5534625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace { 5535625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 5536625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc, 5537625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *Body) { 5538625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do not warn if the body is a macro that expands to nothing, e.g: 5539625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 5540625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // #define CALL(x) 5541625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // if (condition) 5542625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CALL(0); 5543625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 5544625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Body->hasLeadingEmptyMacro()) 5545625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5546625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5547625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Get line numbers of statement and body. 5548625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtLineInvalid; 5549625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 5550625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtLineInvalid); 5551625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLineInvalid) 5552625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5553625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5554625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyLineInvalid; 5555625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 5556625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyLineInvalid); 5557625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyLineInvalid) 5558625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5559625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5560625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Warn if null statement and body are on the same line. 5561625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLine != BodyLine) 5562625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5563625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5564625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return true; 5565625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 5566625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace 5567625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5568625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 5569625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body, 5570625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID) { 5571625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Since this is a syntactic check, don't emit diagnostic for template 5572625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // instantiations, this just adds noise. 5573625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (CurrentInstantiationScope) 5574625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5575625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5576625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 5577625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 5578625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 5579625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5580625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5581625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 5582625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 5583625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5584625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5585625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 5586625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 5587625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 5588625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5589625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S, 5590625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *PossibleBody) { 5591625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko assert(!CurrentInstantiationScope); // Ensured by caller 5592625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5593625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc; 5594625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body; 5595625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID; 5596625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 5597625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = FS->getRParenLoc(); 5598625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = FS->getBody(); 5599625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_for_body; 5600625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 5601625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = WS->getCond()->getSourceRange().getEnd(); 5602625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = WS->getBody(); 5603625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_while_body; 5604625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else 5605625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; // Neither `for' nor `while'. 5606625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5607625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 5608625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 5609625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 5610625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5611625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5612625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Skip expensive checks if diagnostic is disabled. 5613625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 5614625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagnosticsEngine::Ignored) 5615625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5616625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5617625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 5618625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 5619625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5620625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5621625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // `for(...);' and `while(...);' are popular idioms, so in order to keep 5622625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // noise level low, emit diagnostics only if for/while is followed by a 5623625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CompoundStmt, e.g.: 5624625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 5625625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // { 5626625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 5627625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // } 5628625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // or if for/while is followed by a statement with more indentation 5629625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // than for/while itself: 5630625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 5631625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 5632625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 5633625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ProbableTypo) { 5634625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyColInvalid; 5635625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 5636625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko PossibleBody->getLocStart(), 5637625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyColInvalid); 5638625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyColInvalid) 5639625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5640625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5641625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtColInvalid; 5642625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 5643625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko S->getLocStart(), 5644625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtColInvalid); 5645625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtColInvalid) 5646625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5647625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5648625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyCol > StmtCol) 5649625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko ProbableTypo = true; 5650625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 5651625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5652625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (ProbableTypo) { 5653625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 5654625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 5655625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 5656625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 56570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------// 56590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 56610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 56630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible. 56650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 56660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [dcl.enum] p8: 56670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Two enumeration types are layout-compatible if they have the same 56680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // underlying type. 56690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return ED1->isComplete() && ED2->isComplete() && 56700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 56710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 56720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible. 56740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 56750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 56760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 56770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField() != Field2->isBitField()) 56790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 56800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField()) { 56820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Make sure that the bit-fields are the same length. 56830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits1 = Field1->getBitWidthValue(C); 56840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits2 = Field2->getBitWidthValue(C); 56850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Bits1 != Bits2) 56870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 56880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 56890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 56910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 56920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 56930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible. 56940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17) 56950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C, 56960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 56970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 56980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If both records are C++ classes, check that base classes match. 56990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 57000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If one of records is a CXXRecordDecl we are in C++ mode, 57010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // thus the other one is a CXXRecordDecl, too. 57020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 57030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check number of base classes. 57040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D1CXX->getNumBases() != D2CXX->getNumBases()) 57050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 57060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the base classes. 57080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (CXXRecordDecl::base_class_const_iterator 57090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 = D1CXX->bases_begin(), 57100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BaseEnd1 = D1CXX->bases_end(), 57110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base2 = D2CXX->bases_begin(); 57120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 != BaseEnd1; 57130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ++Base1, ++Base2) { 57140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 57150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 57160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 57170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 57180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If only RD2 is a C++ class, it should have zero base classes. 57190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D2CXX->getNumBases() > 0) 57200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 57210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 57220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the fields. 57240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl::field_iterator Field2 = RD2->field_begin(), 57250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(), 57260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 = RD1->field_begin(), 57270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 57280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 57290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, *Field1, *Field2)) 57300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 57310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 57320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1 != Field1End || Field2 != Field2End) 57330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 57340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 57360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 57370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible. 57390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18) 57400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C, 57410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 57420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 57430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 57440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field2 = RD2->field_begin(), 57450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(); 57460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2 != Field2End; ++Field2) { 57470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko UnmatchedFields.insert(*Field2); 57480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 57490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field1 = RD1->field_begin(), 57510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 57520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 != Field1End; ++Field1) { 57530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8>::iterator 57540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = UnmatchedFields.begin(), 57550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = UnmatchedFields.end(); 57560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; I != E; ++I) { 57580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (isLayoutCompatible(C, *Field1, *I)) { 57590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result = UnmatchedFields.erase(*I); 57600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (void) Result; 57610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko assert(Result); 57620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko break; 57630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 57640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 57650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == E) 57660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 57670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 57680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return UnmatchedFields.empty(); 57700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 57710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 57730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion() != RD2->isUnion()) 57740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 57750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion()) 57770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleUnion(C, RD1, RD2); 57780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 57790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleStruct(C, RD1, RD2); 57800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 57810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense. 57830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 57840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (T1.isNull() || T2.isNull()) 57850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 57860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.types] p11: 57880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If two types T1 and T2 are the same type, then T1 and T2 are 57890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // layout-compatible types. 57900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (C.hasSameType(T1, T2)) 57910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 57920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T1 = T1.getCanonicalType().getUnqualifiedType(); 57940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T2 = T2.getCanonicalType().getUnqualifiedType(); 57950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC1 = T1->getTypeClass(); 57970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC2 = T2->getTypeClass(); 57980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 57990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 != TC2) 58000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 == Type::Enum) { 58030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 58040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T1)->getDecl(), 58050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T2)->getDecl()); 58060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (TC1 == Type::Record) { 58070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 58080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 58110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T1)->getDecl(), 58120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T2)->getDecl()); 58130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 58170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 58180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 58200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 58220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself. 58230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 58240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code. 58250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 58260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag. 58270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 58280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value. 58290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 58300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl **VD, uint64_t *MagicValue) { 58310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko while(true) { 58320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeExpr) 58330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 58360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko switch (TypeExpr->getStmtClass()) { 58380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::UnaryOperatorClass: { 58390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 58400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 58410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = UO->getSubExpr(); 58420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 58430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::DeclRefExprClass: { 58480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 58490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *VD = DRE->getDecl(); 58500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 58510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::IntegerLiteralClass: { 58540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 58550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::APInt MagicValueAPInt = IL->getValue(); 58560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (MagicValueAPInt.getActiveBits() <= 64) { 58570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *MagicValue = MagicValueAPInt.getZExtValue(); 58580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 58590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 58600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryConditionalOperatorClass: 58640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::ConditionalOperatorClass: { 58650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const AbstractConditionalOperator *ACO = 58660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<AbstractConditionalOperator>(TypeExpr); 58670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result; 58680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 58690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Result) 58700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getTrueExpr(); 58710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 58720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getFalseExpr(); 58730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 58740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryOperatorClass: { 58790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 58800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (BO->getOpcode() == BO_Comma) { 58810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = BO->getRHS(); 58820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 58830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko default: 58880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 58920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr. 58940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 58950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag. 58960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 58970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values. 58980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 58990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 59000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// kind. 59010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 59020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type. 59030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 59040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found. 59050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType( 59060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind, 59070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeExpr, const ASTContext &Ctx, 59080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const llvm::DenseMap<Sema::TypeTagMagicValue, 59090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData> *MagicValues, 59100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool &FoundWrongKind, 59110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData &TypeInfo) { 59120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = false; 59130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Variable declaration that has type_tag_for_datatype attribute. 59150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl *VD = NULL; 59160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue; 59180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 59200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (VD) { 59230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<TypeTagForDatatypeAttr> 59240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(), 59250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = VD->specific_attr_end<TypeTagForDatatypeAttr>(); 59260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I != E; ++I) { 59270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I->getArgumentKind() != ArgumentKind) { 59280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = true; 59290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.Type = I->getMatchingCType(); 59320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 59330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.MustBeNull = I->getMustBeNull(); 59340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 59350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!MagicValues) 59400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::DenseMap<Sema::TypeTagMagicValue, 59430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData>::const_iterator I = 59440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 59450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == MagicValues->end()) 59460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo = I->second; 59490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 59500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 59510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 59520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 59540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue, QualType Type, 59550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool LayoutCompatible, 59560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool MustBeNull) { 59570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeTagForDatatypeMagicValues) 59580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.reset( 59590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 59600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagMagicValue Magic(ArgumentKind, MagicValue); 59620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (*TypeTagForDatatypeMagicValues)[Magic] = 59630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData(Type, LayoutCompatible, MustBeNull); 59640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 59650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 59670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) { 59680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 59690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT1) 59700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 59730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT2) 59740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T1Kind = BT1->getKind(); 59770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T2Kind = BT2->getKind(); 59780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 59800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 59810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 59820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 59830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 59840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 59850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 59870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr * const *ExprArgs) { 59880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 59890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool IsPointerAttr = Attr->getIsPointer(); 59900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 59920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool FoundWrongKind; 59930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData TypeInfo; 59940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 59950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.get(), 59960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind, TypeInfo)) { 59970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (FoundWrongKind) 59980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(TypeTagExpr->getExprLoc(), 59990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_tag_for_datatype_wrong_kind) 60000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 60010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 60020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 60050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) { 60060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Skip implicit cast of pointer to `void *' (as a function argument). 60070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 60080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ICE->getType()->isVoidPointerType()) 60090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentExpr = ICE->getSubExpr(); 60100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType ArgumentType = ArgumentExpr->getType(); 60120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Passing a `void*' pointer shouldn't trigger a warning. 60140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr && ArgumentType->isVoidPointerType()) 60150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 60160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TypeInfo.MustBeNull) { 60180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type tag with matching void type requires a null pointer. 60190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!ArgumentExpr->isNullPointerConstant(Context, 60200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Expr::NPC_ValueDependentIsNotNull)) { 60210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), 60220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_safety_null_pointer_required) 60230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentKind->getName() 60240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 60250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 60260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 60280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType RequiredType = TypeInfo.Type; 60310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 60320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType = Context.getPointerType(RequiredType); 60330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool mismatch = false; 60350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeInfo.LayoutCompatible) { 60360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !Context.hasSameType(ArgumentType, RequiredType); 60370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.fundamental] p1: 60390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Plain char, signed char, and unsigned char are three distinct types. 60400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // 60410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // But we treat plain `char' as equivalent to `signed char' or `unsigned 60420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // char' depending on the current char signedness mode. 60430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 60440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 60450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType())) || 60460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 60470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = false; 60480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 60490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 60500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, 60510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentType->getPointeeType(), 60520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType()); 60530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 60540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 60550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 60570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 60580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentType << ArgumentKind->getName() 60590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeInfo.LayoutCompatible << RequiredType 60600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 60610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 60620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 60630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 6064