SemaChecking.cpp revision f6a1648197562e0b133440d612d9af297d0a86cc
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 15e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 162d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 17781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 18826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 1959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 20199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 21384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 22c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 232324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 247ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 26f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 27f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 313bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 32691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 347da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 35a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 37781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 3859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 3960800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4108f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4208f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4408f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 464403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 474403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 484403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 534a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 544a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 554a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 594403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 604403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 61efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 62efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 634403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 644403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 654403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 6860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 6960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 70d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 7160d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 722def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 73946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 74946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 75946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 76946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 77946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 78946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 79946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 80946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 81946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 82946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 83946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 84946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 85946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 86946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 87946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 88946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 89946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 90946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 91d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 9230ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 93925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 941b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 95690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 960eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 97d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 9849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 9930ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1000eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1010eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 102d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1031b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1041b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1051b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1061b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1071b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1081b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1090eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1100eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 111d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 112e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 113e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 114e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 115e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1169ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1179ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1189ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1199ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1209ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1213b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1229ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1239ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 124d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1250eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1270eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1290eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 131d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 132d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1330eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1340eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 135d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 136d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 137d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 138d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 139d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 14075c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 14175c29a012793292ff4578015a9113bf086156d7fChris Lattner if (TheCall->getNumArgs() == 0) 14275c29a012793292ff4578015a9113bf086156d7fChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 14375c29a012793292ff4578015a9113bf086156d7fChris Lattner << 0 /*function call*/ << 1 << 0 << TheCall->getSourceRange(); 14475c29a012793292ff4578015a9113bf086156d7fChris Lattner if (TheCall->getNumArgs() > 1) 14575c29a012793292ff4578015a9113bf086156d7fChris Lattner return Diag(TheCall->getArg(1)->getLocStart(), 14675c29a012793292ff4578015a9113bf086156d7fChris Lattner diag::err_typecheck_call_too_many_args) 14775c29a012793292ff4578015a9113bf086156d7fChris Lattner << 0 /*function call*/ << 1 << TheCall->getNumArgs() 14875c29a012793292ff4578015a9113bf086156d7fChris Lattner << TheCall->getArg(1)->getSourceRange(); 14975c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 1515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 1525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 1535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 1545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 1555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 1565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 1575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 1585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 1595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 1605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 1635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 164d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 16526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 16626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 16726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 16826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 16926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 17026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman switch (Context.Target.getTriple().getArch()) { 17126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 17226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 17326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 17426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 17526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 17626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 17726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 17826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 17926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 18026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 18126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 18226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 18326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 18461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 18561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 18661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 18761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 18861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 18961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 190d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 19161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 192d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 19361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 194d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 19561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 196d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 19761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 19861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 199d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 20061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 20161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift polynomial types!"); 202d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (8 << (int)quad) - 1; 20361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 20461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift polynomial types!"); 205d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 20661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 20761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 208d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 20961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 21061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 21161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 21261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 21326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2141c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2151c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2160d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 21761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2181c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 219a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 220a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 221a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2221c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2231c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2240d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2250d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2260d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2270d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2280d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2290d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2300d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 23161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 23261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2330d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2340d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2350d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2361c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2370d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2380d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 23961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 2400d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 2410d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 242bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 243bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 24499c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 24599c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 246a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 247a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 248a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 2490d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 2500d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 25161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 2520d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 2530d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2540d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 25561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 2560d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 25761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 2580d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 259476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 2600d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 26199c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 26226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 263d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 264d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 265d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 266d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 267d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 268d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 269d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 270de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 271d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 272d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 273d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 274d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 2751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 276de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 277de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 278de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 279de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 280c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 281c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 282c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 283c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 284c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 285c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 286826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 2883d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 289826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 292826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 2933c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 29459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 2951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 296c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 297c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 298c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 299cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt CheckNonNullArguments(*i, TheCall); 300c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 3010eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 302d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 30371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 30471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 305d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 306725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 30740b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 308725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 309d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 311725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 312725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 313d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 315725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 316725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 317d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 319826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 320826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 321d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 323d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 324826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 325826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 326d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 327d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 328725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 329725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 3305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 3315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 3325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 3335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 3345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 3355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 3365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 3375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 33860d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 33960d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 340d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 3415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 3425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 3435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 3445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 345d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 346d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 347d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 348d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 349d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 350d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 3535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 3545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 3555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 356d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 3575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 358d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (!FirstArg->getType()->isPointerType()) { 359d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 360d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 361d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 362d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 364d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth QualType ValType = 365d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth FirstArg->getType()->getAs<PointerType>()->getPointeeType(); 366dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 367d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 368d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 369d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 370d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 371d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 3738d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 3748d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 3758d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 3768d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 3775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 3785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 3795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 3805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 3815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 3825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 3831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 3855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 3865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 3875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 3885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 3895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 3901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 3925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 3935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 3945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 3955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 3961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 3985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 3995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 4005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_release) 4015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 4021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 4031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 4055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 406199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 4075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 4085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 4095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 4105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 4115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 4125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 413d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 414d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 415d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 4165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 4195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 4205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 4215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 4227814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 4235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 4245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 4255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: assert(0 && "Unknown overloaded atomic builtin!"); 4265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 4275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 4285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 4295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 4305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 4311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4327eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 4337eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 4347eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 4357eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 4367eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 4371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 4397eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 4405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 4415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 4437eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 4445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 4458d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 4465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4477eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 4485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 4497eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 4505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 4518d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 4525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 4565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 457d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 458d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 459d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 460d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 461d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 462d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 464e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 465e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 466e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 467e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 468e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 4691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 470e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 471e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 472d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 473f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 474f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 475f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 4765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 4775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *Arg = TheCall->getArg(i+1); 4781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 4805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 4815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) { 4825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 4835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 4845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setArg(i+1, Arg); 4855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 4885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 489daa8e4e888758d55a7a759dd4a91b83921cef222John McCall CastKind Kind = CK_Invalid; 490f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ExprValueKind VK = VK_RValue; 491f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall CXXCastPath BasePath; 492f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, VK, BasePath)) 493d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 4941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 4965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 4975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 4985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 4995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 5001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 501f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ImpCastExprToType(Arg, ValType, Kind, VK, &BasePath); 5025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setArg(i+1, Arg); 5035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Switch the DeclRefExpr to refer to the new decl. 5065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setDecl(NewBuiltinDecl); 5075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setType(NewBuiltinDecl->getType()); 5081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 5105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 5115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *PromotedCall = DRE; 5125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner UsualUnaryConversions(PromotedCall); 5135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setCallee(PromotedCall); 5141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 515db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 516db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 517db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 5188d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 519d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 520d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 5215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 5225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 5235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 524690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 52571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 526fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 527fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 528690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 52956f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 53071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 53171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 53271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson if (!Literal || Literal->isWide()) { 533fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 534fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 5359cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 53671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 5371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5382f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer size_t NulPos = Literal->getString().find('\0'); 5392f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer if (NulPos != llvm::StringRef::npos) { 5402f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer Diag(getLocationOfStringLiteralByte(Literal, NulPos), 5412f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer diag::warn_cfstring_literal_contains_nul_character) 5422f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer << Arg->getSourceRange(); 543f015b034159d40e7033309e50036804eb1971787Daniel Dunbar } 5447da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 5457da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::StringRef String = Literal->getString(); 5467da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 5477da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::SmallVector<UTF16, 128> ToBuf(NumBytes); 5487da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 5497da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 5507da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 5517da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 5527da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 5537da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 5547da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 5557da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 5567da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 5577da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 5587da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 5599cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 56059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 56159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 562c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 563c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 564925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 565925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 566925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 5672c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 568fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 569ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 570ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 5711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 572fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 57330ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 57430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 57556f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 57656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 577d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 578d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 579d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 58056f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 58156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 582c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 5839ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 584c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 585cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 586c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 5879498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 5889498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 5899498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 59053d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 5911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 592c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 59330ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 59430ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 59530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 5961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 59730ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 59830ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 59930ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 600e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 6011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 60288cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 60388cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 60430ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 60530ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 60688cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 607cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 608cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 609cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 610371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 61130ce344307f8a8b00054021307015571f83c7364Chris Lattner else 61253d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 61330ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 61430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 61530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 61730ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 6181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 61930ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 62030ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 6216cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 62230ce344307f8a8b00054021307015571f83c7364Chris Lattner 6231b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 6241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 625925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 626925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 6272c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 628d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 629925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 6301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 631fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 632ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 633fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 634fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 6351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 636925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *OrigArg0 = TheCall->getArg(0); 637925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *OrigArg1 = TheCall->getArg(1); 638cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 6401b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 641925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 642403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 643403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 644403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 645403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 646403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar TheCall->setArg(0, OrigArg0); 647403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar TheCall->setArg(1, OrigArg1); 6481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 649cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent()) 650cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 651cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6521b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 6531b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 6541b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 6551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg0->getLocStart(), 656fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 657d162584991885ab004a02573a73ce06422b921fcChris Lattner << OrigArg0->getType() << OrigArg1->getType() 658fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd()); 6591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6601b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 6611b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 6621b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 663e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 664e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 6653b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 6663b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 6673b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 6683b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 6699ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 670d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 6713b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 6723b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 6739ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 674ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 6753b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 6769ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 6779ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 6783b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 6791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6809ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 6819ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 6829ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 68381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 6849ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 6851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 6869ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 6879ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 6881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 68981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 69081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 69181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 69281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 69381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 69481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 69581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 69681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 69781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 69881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 69981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 70081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 7019ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7029ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 7039ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 704d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 705d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 70660d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 70737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 7080eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 709d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 71037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 711d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 712d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 71337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 71437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 71537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 71637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 71737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 71837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 71937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 720cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 721cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 72237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 72337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 72437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 72537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 726cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 7271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 728cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 729cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 730cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 73137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 73237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 73337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 73437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 73537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 73637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 73737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 73837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 739f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 74037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 74137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 74237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 74337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 74437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 74537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 74637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 747cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 7481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 749cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 750cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 75137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 75237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 753788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 754e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 755cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 756d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 757d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 758d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 759cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 760cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 761cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 762cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 76337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 76437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 76537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 76637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 76737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 7680eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 769d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 7700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 771fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 7720eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 773d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 774d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 775d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman llvm::SmallVector<Expr*, 32> exprs; 776d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 777d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 778d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 779d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 780d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 781d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 782a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 78337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 7848189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 7858189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 786d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 78730ce344307f8a8b00054021307015571f83c7364Chris Lattner 7884493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 7894493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 7904493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 7914493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 792fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 7934493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 794fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 795ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 796ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 797ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 798ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 7994493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 8004493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 8014493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 802fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 8034493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 804691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 8059aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 806691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 807691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 8081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8094493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 8104493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 8114493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 812fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 8139aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 814fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 81521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 8164493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 8179aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 818fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 81921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 8204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8214493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8224493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 823fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 8244493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 8254493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 826691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 827691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 828691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 829691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 830691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 831691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 832691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 833691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 834691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 835691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 836691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 837691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 8385e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 839691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 84021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 84121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 84221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 843d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 844d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 845d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 846fee667f35e64751baa7fefe70b4e7bab06c8cd86Eric Christopher// For compatability check 0-3, llvm only handles 0 and 2. 847d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 848691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 849691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 850691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 851691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 852691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 853d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 854691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 855d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 856fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 857fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 858d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 859d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 860d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 861d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 862d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 863586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 864d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 865d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 866d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 867691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 868cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 869691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 870691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 871691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 872691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 873691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 874d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 875d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 876d875fed28578835de89cd407e9db4be788596d7cEli Friedman 877d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 878d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 879d875fed28578835de89cd407e9db4be788596d7cEli Friedman 880d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek// Handle i > 1 ? "x" : "y", recursivelly 881082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 882082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 883826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 884826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 8854fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 886cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 887cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 888d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 889d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 890d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 891082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const ConditionalOperator *C = cast<ConditionalOperator>(E); 892826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 893826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 894826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg, 895826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 896d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 897d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 89895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 89995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 90095355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 90195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 90295355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 90395355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 90495355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 905d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 9064fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 9074fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 908d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 909d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 910d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ParenExprClass: { 9114fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ParenExpr>(E)->getSubExpr(); 9124fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 913d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 9141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 915082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 916082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 9171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 918082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 919082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 920082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 921082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 922082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 923082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 924082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 925082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 926ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 9271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 928082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 929082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 931082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 93231310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 933082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 934826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 935826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 936082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 938d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 939d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 940d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 941d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 942d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 943d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 944d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 945d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 946d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 947d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 948d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 949d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 950d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 951d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 952d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 953d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 954d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 955d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 956d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 957d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 958d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 959082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 961082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 962082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 963d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 9648f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 9658f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 9661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 9678f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 9688f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 9698f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 97040b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 9718f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 9728f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 9731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 975826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 9768f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 9778f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 9788f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 9798f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 9801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9818f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 9828f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 983082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 984082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 985082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 9861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 987082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 988d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 989d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 990082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 9911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 992d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 993826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 994826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 995d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 996d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 9971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 998d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 999d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1001082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1002082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1003d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1004d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1005d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1006e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 10071eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 10081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump const CallExpr *TheCall) { 1009cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1010cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1011e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 101212b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner const Expr *ArgExpr = TheCall->getArg(*i); 10134e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1014ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 101512b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg) 101612b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner << ArgExpr->getSourceRange(); 1017e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1018e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1019d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1020826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1021826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 102259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1023826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1025826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1027082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1028925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 10294a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 10304a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 10314a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 10324a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 10339263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 10349263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 10359263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 10369263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 10379263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 10389263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 10399263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 10409263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 10419263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 10429263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 10434a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 10444a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1045826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1046925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1047826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1048dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 104971895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 105071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 10511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1052082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 10531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 105459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 10551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 105671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 105771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 105871895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 105971895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 106071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 10617ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 10621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 10637ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 10641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 10657ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 10661cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1067826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 10681cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 10691cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1070655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1071655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1072655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 10731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1074826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1075655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1076655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 10771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1078826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1079655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1080d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1081d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1082e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1083826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1084826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1085e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1086e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1087e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 10886ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1089e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1090e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1091e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 10920d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 10930d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 10940d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 10957f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1096efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1097efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 10984e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1099826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 11006ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1101e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 11020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 11030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1104e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 11056ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 11067f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 11070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 11080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1109efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1110efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 11117f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 11127f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 11137f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 11144e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 111507d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 11164e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1117826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1118826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1119826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1120efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1121efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1122826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1123efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1124efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1125efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1126e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 11274e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1128826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1129c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1130c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1131c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1132c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1133c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1134f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1135826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1136826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1137e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 11384e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 11390d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1140666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1141666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1142666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1143666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1144666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1145e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1146e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1147e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1148826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1149e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1150e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1151e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1152826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1153826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 115445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 115545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 115645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 115745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 115845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care End = End.getFileLocWithOffset(1); 115945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 116045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1161f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1162f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1163826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 11644e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1165e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1166e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1167826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1168826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1169808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1170808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1171826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1172808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1173808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1174efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1175826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1176826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1177efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1178826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1179826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1180efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1181efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1182826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1183efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1184efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1185826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1186826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1187efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1188efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1189826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 1190826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The presence of a null character is likely an error. 1191826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(nullCharacter), 1192826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_format_string_contains_null_char) 1193826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1194826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1195826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1196826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1197826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1198826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 11994e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1200826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1201826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1202826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1203826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1204826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1205826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1206826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1207826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1208826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1209826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1210826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1211826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1212826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1213826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1214826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1215826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1216c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1217c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1218c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1219c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1220c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1221c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1222c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1223c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1224c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1225c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1226c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1227c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1228c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1229c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1230c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1231c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1232c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1233c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1234c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1235c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1236c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1237c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1238c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1239c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 1240c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << llvm::StringRef(csStart, csLen) 1241c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1242c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1243c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1244c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1245c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1246666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1247666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1248666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1249666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1250666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1251666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1252666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1253666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1254666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1255666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1256666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1257666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1258666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1259666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1260666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1261666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1262666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1263666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1264666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1265666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1266666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1267666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1268666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1269666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1270826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1271826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1272826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1274826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1275826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1276826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1277826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1278826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1279826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1280826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1281826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1282826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1283826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1284826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1285826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1286826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1288826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1289826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1292826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1293826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1294826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1295826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1296826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1297826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1298826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1299826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1300826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1301826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1302826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1312826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1313826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13146ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1315c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1316826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1317c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1318c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1319c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1320c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 132126ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 132226ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1323826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1324826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1325826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1326826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13270d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 13280d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 13290d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 13307f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 13317f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1332efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1333efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1334826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 13350d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13360d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 13370d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 13380d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13394e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13400d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 134131f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 134231f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 134331f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 13447f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 13457f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 13460d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 13474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 13494e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 13504e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13514e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1352efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1353efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1354efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 13554e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1356826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1357d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 13580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 13600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 13610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 13650d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 13660d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1367e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1368826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1369e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1370e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1371e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1372e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 13736ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 13746ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1375e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1376e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1377e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1378e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1379e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1380e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1382826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1383e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1384e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1385e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1386e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1387e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1388e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1389e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1390e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1391826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1392e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1393e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1394e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1395e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1396826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1397e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1398e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1399e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1400e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 14016ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14026ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1403e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1404e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1405e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1406826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1407826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1408e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1409e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1410e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1411826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1412e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1413e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1414e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1415e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1416e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1417e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1418e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1419e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1420826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1421826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1422e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1423e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1424e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1425e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1426826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 14275c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1428e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1429e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1430e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 14316ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1432efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 14336ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1434e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1435baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1436baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1437baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1438baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1439baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1440baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1441baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1442baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1443baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1444baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1445baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1446baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1447efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1448efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 14490d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 14500d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1451efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1452efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 14530d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14540d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14554e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1456efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1457efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 14580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1461f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1462f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1463f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 14640e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1465f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 14664e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14677f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 14687f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1469e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1470e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1471e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1472e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1473e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1474e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 14757f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 14767f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 14777f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 14787f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1479826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1480826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 14817f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 14824e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1483e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1484e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 148545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1486e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1487e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1488e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1489e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1490e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1491e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1492e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1493e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1494e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1495e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 1496e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1497e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1498e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1499e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 150045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 150145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1502e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1503e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1504e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1505e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1506e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1507e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 150845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 150945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 151045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1511e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1512e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1513e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1514e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1515e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1516e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1517e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1518e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1519649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1520e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1521826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1522826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1523e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1524e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1525e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 152635d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1527e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1528e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1529826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1530e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1531e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1532e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 15335c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1534da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1535da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1536da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 15374e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1538666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1539da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 15404e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 154196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 154296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 154396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 154496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 154596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 154696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 154796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 154896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 154996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 15504d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 15514d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 15524d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 15534d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 155496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 15554d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 155696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 155796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 155896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 155996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer bool success = fixedFS.fixType(Ex->getType()); 156096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 156196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 156296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 156396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 156496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 156596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 156696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 15679325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 15689325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 15699325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 157096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 157196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 157296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 157396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 157496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 157596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 157696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 157796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 157896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 157996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 158096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 158196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 158296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 158396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 158496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 158596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 158696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 158796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1588e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1589e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1590e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1591826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 1592826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1593826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1594826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 1595826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1596826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1597826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1598826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1599826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1600826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1601826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1602826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1603826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1604826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1605826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1606826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1607826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1608c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1609c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 1610c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1611c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1612c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 1613b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1614b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 1615826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1616826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1617826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1618b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 1619b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 1620b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1621b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 1622b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 1623b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1624c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1625c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1626c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1627c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 1628c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 16296ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 1630c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1631c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1632c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1633c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1634c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1635c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 1636c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1637c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1638826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 1639826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1640826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1641826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 1642826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1643826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 1644826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 1645826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 16466ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 1647826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1648baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 1649baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 1650baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1651baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1652baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1653baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1654baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1655baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1656baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1657baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1658baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1659baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1660baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1661baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1662826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1663826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1664826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 1665826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 1666826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 1667826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 1668826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 1669826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 1670826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1671826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 1672826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 16737f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 16747f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 1675826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1676826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 1677826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 1678826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 1679826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1680826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1681826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1682826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 1683826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1684826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 1685826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 1686826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 1687826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 1688826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 1689826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1690826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 16911e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 16921e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 16931e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 16941e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 16951e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 16961e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 16971e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 16981e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 16991e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 17001e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 17011e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 1702826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 1703826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 1704826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1705826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1706666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1707826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 1708826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1709826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 1710826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1711826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 171207d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 1713e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1714826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 17150e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 17160e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 1717826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1718826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1719826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1720e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 1721e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (FExpr->isWide()) { 1722e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 1723826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 1724e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1725e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1726e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1727826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1728e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 17292f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer llvm::StringRef StrRef = FExpr->getString(); 17302f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 17312f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 1732826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1733e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 1734e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (StrLen == 0) { 1735826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 1736e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1737e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1738e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1739826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1740826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 1741826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1742826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1743826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1744826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1745826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1746826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 1747826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1748826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1749826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 1750826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1751826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1752826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1753826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1754826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1755826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 1756826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1757826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1758ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 1759ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 176006de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 176106de276fff91264437fa75111ed76de43097e089Ted Kremenek 176226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars); 176326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars); 176406de276fff91264437fa75111ed76de43097e089Ted Kremenek 176506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 176606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 176706de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 176806de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 176906de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 17701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 177126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 177226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis llvm::SmallVector<DeclRefExpr *, 8> refVars; 17734e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 177426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 177526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 177626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { 177726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 1778ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 177926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 178026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 178126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 178226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 178326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 178426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 178526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 178626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 178726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 178826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 178926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 179026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 179126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 179226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 179326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 179426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 179526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 179626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 179726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 179826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 179926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 180026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 180126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 180226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 180326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 180426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 180526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 180626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 180726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 180826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 180926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 181026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 181126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 181226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 181326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 181426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 181526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 181626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 181726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 181826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 181926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 182026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 182126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 182226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 182326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 182406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 182506de276fff91264437fa75111ed76de43097e089Ted Kremenek} 182606de276fff91264437fa75111ed76de43097e089Ted Kremenek 182706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 182806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 182926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 183026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 183106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 183226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 183326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 183426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 183526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 183626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 183726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 183826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 183906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 1840e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 1841e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 184226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 184326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 184406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 184506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 184606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 184706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 184806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 184906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 185006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 185106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 185206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 185326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars) { 185426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 185526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 185626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 185706de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 18580f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 1859dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 1860a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 1861fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 18621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 186306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 186406de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 186506de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 186606de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 1867fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ParenExprClass: 1868fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Ignore parentheses. 186926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ParenExpr>(E)->getSubExpr(), refVars); 187026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 187126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 187226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 187326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 187426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 187526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 187626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 187726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 187826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 187926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 188026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 188126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 188226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 188326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 188426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 188526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 188606de276fff91264437fa75111ed76de43097e089Ted Kremenek 1887fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 1888fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 1889fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 1890fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 18911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 18922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 189326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 1894fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 1895fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 1896fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 18971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1898fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 1899fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 1900fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 1901fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 19022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 19031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 19042de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 1905fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 19061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1907fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 19083907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 1909fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 1910fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 1911fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 19121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1913fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 191426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 1915fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 191661f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 1917fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 1918fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 1919fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 1920fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 19211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1922fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 19239ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 19249ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 19259ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 192626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 19279ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 19289ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 19299ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 19309ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 19319ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 19329ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 193306de276fff91264437fa75111ed76de43097e089Ted Kremenek 193426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 1935fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 193626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 193726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 193826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (cast<BlockExpr>(E)->hasBlockDeclRefExprs()) 193926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 194026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 194126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 194226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 194326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 19441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 194554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 194654b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 194749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 19486eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 194949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXFunctionalCastExprClass: { 19500835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 195154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 19521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1953dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 1954dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 1955dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 195626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 195754b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 195826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 1959fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 196054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 1961fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1963fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 1964fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 196549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 196649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 1967fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 196849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 196949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 19701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 19711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 19721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 197349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 197449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 197549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 1976dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 197726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 197806de276fff91264437fa75111ed76de43097e089Ted Kremenek else 197906de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 1980fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1982fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 1983fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 1984fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 198506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 198606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 19871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 198806de276fff91264437fa75111ed76de43097e089Ted Kremenek 198906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 199006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 199126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars) { 199268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 1993e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 1994e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 1995e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 19961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 199706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 199806de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 199906de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 200006de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 200168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 200268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 20035baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 200468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 200568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 200668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 200768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 200868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 200968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2010a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 201126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 201226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 201326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 201406de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 20151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 201606de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 201726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 201826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 201926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 202026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 202126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 202226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 202326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 202426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 202526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 202626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 202726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 202826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 20291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 203006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 203106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 203368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ParenExprClass: { 203406de276fff91264437fa75111ed76de43097e089Ted Kremenek // Ignore parentheses. 203568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = cast<ParenExpr>(E)->getSubExpr(); 203668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 203768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 20381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 203906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 204006de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 204106de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 204206de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 204306de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 20441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 20452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 204626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 204706de276fff91264437fa75111ed76de43097e089Ted Kremenek 204806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 204906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 205106de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 205206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 205306de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 205406de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 205526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 205606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 205806de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 205906de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 206026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 206106de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 206206de276fff91264437fa75111ed76de43097e089Ted Kremenek 20633907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 20643907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 206526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 20663907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 20673907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 206826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 206906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 207106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 207283f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 207306de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 20741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 207506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2076a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2077a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2078a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2079a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2080a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2081a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 208206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2083a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 208426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 208506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 208706de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 208826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 208926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 209026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 209126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 209226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 209326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 209406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 209506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 209668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 209706de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2098588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2099588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2100588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2101588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2102588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2103588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2104588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenekvoid Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { 2105588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 21061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2107f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* LeftExprSansParen = lex->IgnoreParenImpCasts(); 2108f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* RightExprSansParen = rex->IgnoreParenImpCasts(); 2109588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2110588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2111588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2112588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2113588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2114588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2115588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21181b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 21191b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 21201b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 21211b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 21221b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 21231b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 21241b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 21251b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 21261b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2127ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 21281b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 21291b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 21301b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 21311b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 21321b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 21331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2134588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 21350eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2136588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 21373c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2138588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2141588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 21423c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2143588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2145588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2146588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2147fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(loc, diag::warn_floatingpoint_eq) 2148fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << lex->getSourceRange() << rex->getSourceRange(); 2149588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2150ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2151f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2152f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2153ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2154f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2155ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2156f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2157f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2158f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2159f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2160f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2161ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2162f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2163f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 216451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2165f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2166f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2167f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 216851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21691844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2170f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2171f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2172f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 217351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 21751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 21761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 21771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 217851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 217951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21801844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 21811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2182f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 218351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2184f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2185f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2186f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2187f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2188323ed74658bc8375278eabf074b4777458376540John McCall 2189091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2190323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2191323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 2192091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Enum->isDefinition()) 2193091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2194091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2195323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2196323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2197323ed74658bc8375278eabf074b4777458376540John McCall 2198323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2199323ed74658bc8375278eabf074b4777458376540John McCall } 220051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2201f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2202f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 220351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2204f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 220551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 220651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 22081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 22091844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 22101844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 22111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 22121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 22131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 22141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 22161844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 22171844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 22181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 22191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 22201844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = ET->getDecl()->getIntegerType().getTypePtr(); 22211844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 22231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 22241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 22261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 22271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2229c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2230f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 223160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 223260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 223360fad45739b764886f707bd204eae9ecce6db1f2John McCall 22341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2235c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 223660fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 223760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 223851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2239f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 224051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2241f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2242f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2243f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 224451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2245f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 2246f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall value.trunc(MaxWidth); 224751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2248f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2249f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2250f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 225151313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 225251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22530acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2254f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2255f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2256f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 225751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2258f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 22590acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 22600acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 22610acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 22620acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 22630acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2264f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 226551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 226651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2267f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2268f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2269f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2270f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2271f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2272f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2273f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2274f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 22750acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 22760acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 22770acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2278f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 22790acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return IntRange(MaxWidth, Ty->isUnsignedIntegerType()); 228051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 228151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2282f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2283f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2284f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2285f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2286f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 228751313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 228851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2289f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2290f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2291f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 22920acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 229351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2294f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2295f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2296f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2297f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 22982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2299f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 230051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 23011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 230251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 23032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 230460fad45739b764886f707bd204eae9ecce6db1f2John McCall 2305f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 230660fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2307f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 230851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2309f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2310f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2311f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 231251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2313f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2314f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2315f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 231651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2317f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2318f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2319f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2320f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2321f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2322f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2323f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2324f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2325f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2326f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2327f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2328f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2329f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2330f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2331f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2332f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2333f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2334f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 233551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 233651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 233751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 233851313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 233951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2340f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 23412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 23422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 23432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 23442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 23452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 23462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 23472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 23482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 2349f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 235051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2351c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // The type of these compound assignments is the type of the LHS, 2352c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // so the RHS is not necessarily an integer. 23532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 23542de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 23552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 23562de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 23572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 23581844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2359c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 236051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 23612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 23622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 23631844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 236451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 236560fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 23662de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 23672de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 236860fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 236960fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 237060fad45739b764886f707bd204eae9ecce6db1f2John McCall 237151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 23722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 23733aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 23743aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 23753aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 23763aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 23773aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 23781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 23793aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 23803aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 23813aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 23823aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 23833aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 23842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 23851844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 238651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 238760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 23882de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 23892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 239060fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 239160fad45739b764886f707bd204eae9ecce6db1f2John McCall 239260fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 239360fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 239460fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 239560fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 239660fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 239760fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 239860fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 239960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 240060fad45739b764886f707bd204eae9ecce6db1f2John McCall else 240160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 240260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 240360fad45739b764886f707bd204eae9ecce6db1f2John McCall 240460fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 240560fad45739b764886f707bd204eae9ecce6db1f2John McCall } 240660fad45739b764886f707bd204eae9ecce6db1f2John McCall 240760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 24082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 2409f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2410f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 241160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 24122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 241351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 24141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 241551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // fallthrough 24164e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 241751313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2418f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 241951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2420f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2421f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Treat every other operator as if it were closed on the 2422f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // narrowest type that encompasses both operands. 2423f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2424f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 2425f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 242651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 242751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 242851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 242951313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 243051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 24312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 2432f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 243351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 243451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 24352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 24362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 24371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 243851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 243951313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2440f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 244151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 244251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 24438ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 24448ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 24451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 24468ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 244751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2448f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall FieldDecl *BitField = E->getBitField(); 2449f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (BitField) { 2450f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); 2451f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned BitWidth = BitWidthAP.getZExtValue(); 245251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2453f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType()); 2454f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2455f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 24561844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2457f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2458f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2459323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 2460323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 2461323ed74658bc8375278eabf074b4777458376540John McCall} 2462323ed74658bc8375278eabf074b4777458376540John McCall 2463f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2464f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2465f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2466f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 2467f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2468f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2469f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 2470f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2471f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 2472f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 2473f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 2474f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2475f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 247651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 247751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2478f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2479f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2480f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2481f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2482f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 2483f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 2484f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2485f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2486f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 2487f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 2488f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2489f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 2490f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 2491f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 2492f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 2493f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 2494f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2495f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2496f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 2497f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 2498f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 2499f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2500f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2501b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 2502323ed74658bc8375278eabf074b4777458376540John McCall 2503e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 2504e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 2505e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 2506e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 2507e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 2508e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2509e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2510e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 2511e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 2512e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2513e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2514323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 2515323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 2516323ed74658bc8375278eabf074b4777458376540John McCall} 2517323ed74658bc8375278eabf074b4777458376540John McCall 2518372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 2519372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 2520372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 252163b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 252263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 2523372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 252463b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 2525372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 2526372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2527372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 2528372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 2529372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2530323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 25312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 25322de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 2533323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2534372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 2535323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 2537323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2538372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 2539323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25402de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 2541323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2542372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 2543323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 2545323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2546372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 2547323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2548323ed74658bc8375278eabf074b4777458376540John McCall } 2549323ed74658bc8375278eabf074b4777458376540John McCall} 2550323ed74658bc8375278eabf074b4777458376540John McCall 2551323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 2552323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 2553323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 2554b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2555b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2556323ed74658bc8375278eabf074b4777458376540John McCall} 2557f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2558ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 2559ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 2560ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param lex the left-hand expression 2561ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param rex the right-hand expression 2562ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param OpLoc the location of the joining operator 2563d1b47bf17fde73fac67d8664bd65273742c00ecdJohn McCall/// \param BinOpc binary opcode or 0 2564323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 2565323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 2566323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 2567323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 2568323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 2569323ed74658bc8375278eabf074b4777458376540John McCall 2570323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 2571323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 2572323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 2573f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!T->hasUnsignedIntegerRepresentation()) 2574323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2575323ed74658bc8375278eabf074b4777458376540John McCall 2576323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getLHS()->IgnoreParenImpCasts(); 2577323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getRHS()->IgnoreParenImpCasts(); 2578323ed74658bc8375278eabf074b4777458376540John McCall 2579323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 2580323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 2581323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 2582f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (lex->getType()->hasSignedIntegerRepresentation()) { 2583f60946222721d9ba3c059563935c17b84703187aDouglas Gregor assert(!rex->getType()->hasSignedIntegerRepresentation() && 2584323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 2585323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = lex; 2586323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = rex; 2587f60946222721d9ba3c059563935c17b84703187aDouglas Gregor } else if (rex->getType()->hasSignedIntegerRepresentation()) { 2588323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = rex; 2589323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = lex; 2590ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 2591323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 2592323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2593ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 2594ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2595323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 2596323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 2597f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2598323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 2599323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 2600b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, lex, E->getOperatorLoc()); 2601b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, rex, E->getOperatorLoc()); 2602ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2603323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 2604323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 2605323ed74658bc8375278eabf074b4777458376540John McCall // or false. 2606323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 2607323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 2608ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2609ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 2610ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 2611ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 2612ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 2613323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 2614323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 2615323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 2616323ed74658bc8375278eabf074b4777458376540John McCall 2617323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 2618323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 2619323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 2620ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2621323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 2622323ed74658bc8375278eabf074b4777458376540John McCall return; 2623323ed74658bc8375278eabf074b4777458376540John McCall } 2624323ed74658bc8375278eabf074b4777458376540John McCall 2625323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 2626323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 2627323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 2628ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 2629ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 263015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 263115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 263215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 263315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 263415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 263515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 263615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 263715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 263815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 263991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 264091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 264191b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 264291b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 264315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 264415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 264515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall llvm::APSInt Width(32); 264615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr::EvalResult InitValue; 264715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (!Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) || 264891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall !OriginalInit->Evaluate(InitValue, S.Context) || 264915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall !InitValue.Val.isInt()) 265015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 265115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 265215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall const llvm::APSInt &Value = InitValue.Val.getInt(); 265315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 265415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned FieldWidth = Width.getZExtValue(); 265515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 265615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 265715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 265815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 265915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall llvm::APSInt TruncatedValue = Value; 266015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall TruncatedValue.trunc(FieldWidth); 266115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 266215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 266315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 266415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 266515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 266615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall TruncatedValue.sext(OriginalWidth); 266715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 266815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall TruncatedValue.zext(OriginalWidth); 266915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 267015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 267115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 267215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 267315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 267415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 267515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 267615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 267715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 267815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 267915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 268015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 268115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 268215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 2683beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 2684beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 2685beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 2686beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 2687beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2688beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2689beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 2690beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 2691beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 269215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 269315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 269415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 269515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 269615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 2697beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2698beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2699beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2700beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2701beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 2702beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 270351313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 2704b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 2705b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall unsigned diag) { 2706b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall S.Diag(E->getExprLoc(), diag) 2707b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall << E->getType() << T << E->getSourceRange() << SourceRange(CContext); 270851313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 270951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2710091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 2711091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 2712091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2713091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 2714091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 2715091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.trunc(Range.Width); 2716091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 2717091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 2718091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2719323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 2720b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 2721323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 272251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2723323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 2724323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 2725323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 2726323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 272751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2728b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // If the conversion context location is invalid or instantiated 2729b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // from a system macro, don't complain. 2730b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall if (CC.isInvalid() || 2731b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall (CC.isMacroID() && S.Context.getSourceManager().isInSystemHeader( 2732b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall S.Context.getSourceManager().getSpellingLoc(CC)))) 2733b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 2734b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 273551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Never diagnose implicit casts to bool. 273651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 273751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 273851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 273951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 274051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 274151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (!isa<VectorType>(Target)) 2742b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 274351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 274451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 274551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 274651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 274751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 274851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 274951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 275051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (!isa<ComplexType>(Target)) 2751b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 275251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 275351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 275451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 275551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 275651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 275751313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 275851313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 275951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 276051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 276151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 276251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 276351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 276451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 276551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 276651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 276751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 276851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 276951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 277051313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 2771323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 277251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 277351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 2774323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 2775323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 277651313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 277751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 277851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2779b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 278051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 278151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 278251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 278351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 278451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the target is integral, always warn. 278551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if ((TargetBT && TargetBT->isInteger())) 278651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // TODO: don't warn for integer values? 2787b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 278851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 278951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 279051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 279151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2792f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 279351313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 279451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2795323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 27961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 279751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2798f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 2799091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 2800091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 2801091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 2802091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 2803091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 2804091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 2805091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2806091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) 2807091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << PrettySourceValue << PrettyTargetValue 2808091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); 2809091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 2810091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 2811091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 281251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // People want to build with -Wshorten-64-to-32 and not -Wconversion 281351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // and by god we'll let them. 2814f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 2815b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 2816b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 2817323ed74658bc8375278eabf074b4777458376540John McCall } 2818323ed74658bc8375278eabf074b4777458376540John McCall 2819323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 2820323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 2821323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 2822323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 2823323ed74658bc8375278eabf074b4777458376540John McCall 2824323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 2825323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 2826323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 2827323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 2828323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 2829323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 2830323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 2831323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 2832323ed74658bc8375278eabf074b4777458376540John McCall } 2833323ed74658bc8375278eabf074b4777458376540John McCall 2834b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 283551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 283651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 283751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 283851313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 283951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2840323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 2841323ed74658bc8375278eabf074b4777458376540John McCall 2842323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 2843b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 2844323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 2845323ed74658bc8375278eabf074b4777458376540John McCall 2846323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 2847323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 2848323ed74658bc8375278eabf074b4777458376540John McCall 2849b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 2850323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 2851b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 2852323ed74658bc8375278eabf074b4777458376540John McCall return; 2853323ed74658bc8375278eabf074b4777458376540John McCall} 2854323ed74658bc8375278eabf074b4777458376540John McCall 2855323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 2856b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 2857b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 2858b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 2859323ed74658bc8375278eabf074b4777458376540John McCall 2860323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 2861b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 2862b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 2863323ed74658bc8375278eabf074b4777458376540John McCall 2864323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 2865323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 2866323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 2867323ed74658bc8375278eabf074b4777458376540John McCall 2868323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 2869323ed74658bc8375278eabf074b4777458376540John McCall if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional)) 2870323ed74658bc8375278eabf074b4777458376540John McCall return; 2871323ed74658bc8375278eabf074b4777458376540John McCall 2872323ed74658bc8375278eabf074b4777458376540John McCall // ...and -Wsign-compare isn't... 2873323ed74658bc8375278eabf074b4777458376540John McCall if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional)) 2874323ed74658bc8375278eabf074b4777458376540John McCall return; 2875323ed74658bc8375278eabf074b4777458376540John McCall 2876323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 2877323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 2878323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) { 2879323ed74658bc8375278eabf074b4777458376540John McCall Suspicious = false; 2880323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 2881b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 2882323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 2883323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 2884b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 2885323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 2886323ed74658bc8375278eabf074b4777458376540John McCall return; 2887323ed74658bc8375278eabf074b4777458376540John McCall } 2888323ed74658bc8375278eabf074b4777458376540John McCall 2889323ed74658bc8375278eabf074b4777458376540John McCall // If so, emit a diagnostic under -Wsign-compare. 2890323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts(); 2891323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts(); 2892323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional) 2893323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 2894323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 2895323ed74658bc8375278eabf074b4777458376540John McCall} 2896323ed74658bc8375278eabf074b4777458376540John McCall 2897323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 2898323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 2899323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 2900b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 2901323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 2902323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 2903323ed74658bc8375278eabf074b4777458376540John McCall 2904323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 2905323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 2906323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 2907323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 2908323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 2909323ed74658bc8375278eabf074b4777458376540John McCall return; 2910323ed74658bc8375278eabf074b4777458376540John McCall } 2911323ed74658bc8375278eabf074b4777458376540John McCall 2912323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 2913323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 2914323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 2915323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 2916b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 2917323ed74658bc8375278eabf074b4777458376540John McCall 2918323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 2919323ed74658bc8375278eabf074b4777458376540John McCall 2920323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 2921323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 2922323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 2923b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 2924323ed74658bc8375278eabf074b4777458376540John McCall } 2925323ed74658bc8375278eabf074b4777458376540John McCall 2926beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 2927beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 2928beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 2929beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 2930beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2931beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 2932beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 2933beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 2934beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2935323ed74658bc8375278eabf074b4777458376540John McCall 2936323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 2937323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 2938323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 2939323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 2940323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 2941323ed74658bc8375278eabf074b4777458376540John McCall 2942323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 2943323ed74658bc8375278eabf074b4777458376540John McCall if (isa<SizeOfAlignOfExpr>(E)) return; 2944323ed74658bc8375278eabf074b4777458376540John McCall 2945323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 2946b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 2947323ed74658bc8375278eabf074b4777458376540John McCall for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end(); 2948323ed74658bc8375278eabf074b4777458376540John McCall I != IE; ++I) 2949b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, cast<Expr>(*I), CC); 2950323ed74658bc8375278eabf074b4777458376540John McCall} 2951323ed74658bc8375278eabf074b4777458376540John McCall 2952323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 2953323ed74658bc8375278eabf074b4777458376540John McCall 2954323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 2955323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 2956323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 2957b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 2958b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 2959b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 2960b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 2961b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 2962323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 2963323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 2964323ed74658bc8375278eabf074b4777458376540John McCall return; 2965323ed74658bc8375278eabf074b4777458376540John McCall 2966323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 2967323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 2968323ed74658bc8375278eabf074b4777458376540John McCall return; 2969323ed74658bc8375278eabf074b4777458376540John McCall 2970b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 2971b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 2972323ed74658bc8375278eabf074b4777458376540John McCall} 2973323ed74658bc8375278eabf074b4777458376540John McCall 297415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 297515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 297615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 297715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 297815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 297915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 2980f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 2981f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 2982f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 2983f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 2984f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 298582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 298682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 2987f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 298882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 298982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 299082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 2991f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 2992f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 2993f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 2994f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 2995f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 2996f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 2997f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 2998f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 2999f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 3000f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 3001f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3002f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3003f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 3004f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 300582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 300682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 3007f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 3008f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 3009f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 3010d17e340e2d516139931768697bf080f60920ba9dSam Weinig 3011d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 3012d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 3013d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 3014d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 3015d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 3016d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 3017d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 3018d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 3019d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 3020d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 3021d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 3022d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3023d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3024f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3025f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3026f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 3027f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 3028b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3029b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 3030b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 3031b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 3032b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 3033b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 3034b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align) 3035b7f4ffe073fa419613946461a2583ba2fcb72280John McCall == Diagnostic::Ignored) 3036b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3037b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3038b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 3039b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 3040b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3041b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3042b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 3043b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 3044b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3045b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3046b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3047b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3048b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3049b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3050b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3051b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3052b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3053b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3054b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3055b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3056b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3057b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3058b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3059b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3060b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3061b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3062b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3063b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3064b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3065b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3066b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3067b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3068b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3069b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3070b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3071b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3072b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3073