| ae13ec986e188d66eaad3c69bb916ea18c142fef |
|
03-Sep-2014 |
Andre Eisenbach <eisenbach@google.com> |
Avoid race condition in SBC encoder initialization
In the A2DP media task, btif_a2dp_encoder_update() relies on the fact
that btif_a2dp_encoder_init() is called beforehand. Otherwise division
by zero errors will occur.
Since _init() called after the audio stream is opened, and _update() is
called in resonse the the audio stream being opened, a race condition
could ensue where _update() was called before open.
This patch changes the A2DP stream start sequence to ensure the SBC
encoder is initialized before the updated parameters are calculated.
Bug: 17339248
Change-Id: I6ed36a7fff0e4aa672a8866727030681eb4b3dfc
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 6397cfb5b415d2622f81a27c646a441b108ee13f |
|
02-Jul-2014 |
Mike Lockwood <lockwood@google.com> |
Fix problem with A2DP initialization due to merge error
btif_av_init() would fail when called a second time due to
erroneous nulling of btif_av_cb.sm_handle
Bug: 16014877
Change-Id: I7e6b213759e93372ac8ecaadc2b81452572f3f7d
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| afa6e1abbedaad8fe854b0f43999b8aeb801af91 |
|
28-Jun-2014 |
Matthew Xie <mattx@google.com> |
resolved conflicts for merge of e8c3d75b to master
Change-Id: I78ef69c4d54a36243620ae14296d3507e3339567
|
| d6151e9811a35ac965bfb96ad77c427d9a4f1325 |
|
22-Jun-2014 |
Matthew Xie <mattx@google.com> |
switch a2dp sync and source to the correct uuids
bug 15687722
Change-Id: I09e5fdc7bf7c1bb0ff3c87dc43b228e3761cfa36
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| e8c3d75b75493911ebf0f99c83676359657178f7 |
|
04-May-2014 |
Sharvil Nanavati <sharvil@google.com> |
Logging cleanup: BTIF and APPL.
Change-Id: I5b1214642bbb4b9aecc0fd2c899a6ec2c9793286
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 4ad470e33021be4246ae539e1bcb7a346dbb4405 |
|
03-Jun-2014 |
Mike Lockwood <lockwood@google.com> |
Move AVRCP controller support to separate HAL interface
Change-Id: Ib7dcd7b90f85cf3b25148e2929d8921c6db37aa2
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 3e8a242fcbeebea2857fa964ca48624d8433333e |
|
23-May-2014 |
Mike Lockwood <lockwood@google.com> |
More work on A2DP Sink:
Output audio data through A2DP audio HAL rather than playing directly
to native AudioTrack API.
Add separate HAL interface for A2DP sink
Change-Id: I6c6cb6088c350e104b4a7354f328b29c7178e295
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| f7dd9f5779680da37dc89e5df2b26d436487818c |
|
24-Oct-2013 |
Hemant Gupta <hemantg@codeaurora.org> |
Add A2DP Sink Support
Change-Id: I9affefdd2d00597545e49c593ef3bddb110d4c9c
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 3a1ca50d0def4078a0db82bcdeecfe408ca4af64 |
|
03-Jun-2014 |
Mike Lockwood <lockwood@google.com> |
Move AVRCP controller support to separate HAL interface
Change-Id: Ib7dcd7b90f85cf3b25148e2929d8921c6db37aa2
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 309243751678f395e6f7323e45433e5476dc17ef |
|
23-May-2014 |
Mike Lockwood <lockwood@google.com> |
More work on A2DP Sink:
Output audio data through A2DP audio HAL rather than playing directly
to native AudioTrack API.
Add separate HAL interface for A2DP sink
Change-Id: I6c6cb6088c350e104b4a7354f328b29c7178e295
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| cc35559160745c60b42ae182002a59337d844d09 |
|
24-Oct-2013 |
Hemant Gupta <hemantg@codeaurora.org> |
Add A2DP Sink Support
Change-Id: I9affefdd2d00597545e49c593ef3bddb110d4c9c
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 44c6f8d6c7cb3929a5b49e5d0ef8c471798f552f |
|
07-Feb-2014 |
Hemant Gupta <hemantg@codeaurora.org> |
[2/4] Add Support for AVRCP Controller Feature
- Provide support for AVRCP Controller CAT 1 and CAT 2
Passthrough commands.
Change-Id: Ia3ca08c1139d9a98b86919b51d7480e0245c35f3
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 54db2c249efa91082c5a167a924a527ec73ff38d |
|
13-Apr-2014 |
Sharvil Nanavati <sharvil@google.com> |
Remove executable bit on source files.
Change-Id: Id456478aea626f57fed3479346e8fb4dbd0fafa6
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| d2ccbbb73c7851d2fa28dc212d2fffc0ad4e5d50 |
|
13-Apr-2014 |
Sharvil Nanavati <sharvil@google.com> |
Remove executable bit on source files.
Change-Id: Id456478aea626f57fed3479346e8fb4dbd0fafa6
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 85c1751ac78a4b9ae9f2250130000755081905fb |
|
11-Feb-2014 |
Mike J. Chen <mjchen@google.com> |
am 3d4f5c71: am b83a8234: Merge changes Ifc373f95,I95eb887a,I1e6be2ab,Ia6ea939a,I147d0138, ... into klp-modular-dev
* commit '3d4f5c715204c3c5eeb21e351aff73072000f61e': (24 commits)
Make all warnings fatal compilation errors
Major warnings cleanup
Add macro UNUSED() to bt_utils.h
Fix unused parameter warning in static function
Add "static" to a static function
Fix a number of unused parameter warnings in static functions
Fix bug with wrong parameter passed to logu
Default send_ind_evt should be FALSE
Fix warning "implicit declaration of function 'GAP_BleReadPeerPrefConnParams'"
Fix unused parameter warnings in static functions by changing prototype
Fix some unused parameter warnings in static functions
Fix warnings about implicit declaration of bdcmp and bdcpy
Fix warning "comparison is always true due to limited range of data type"
Fix warning "suggest braces around empty body in an 'if' statement"
Fix warning "comparison is always true due to limited range of data type"
Add a function prototype for btm_ble_test_command_complete
Change argument to return ptr rather than assign to unused local
Fix warning "comparison is always true due to limited range of data type"
Fix warnings about implicit declarations
Fix warning "implicit declaration of function 'bdcmp'"
...
|
| 5cd8bff2dd0337cb52bf48f312e3d2d55a8882fb |
|
01-Feb-2014 |
Mike J. Chen <mjchen@google.com> |
Major warnings cleanup
Mostly fixing unused parameter warnings.
A few other warnings also fixed like possible use of
unitialized variables (no real issue found, just compiler couldn't
follow the path), signed vs unsigned warning.
Also fixed some typos, indent issues, removal of dead code, etc.
Change-Id: I95eb887aefc4d559d7921f71a0af5f3bfb01ac01
Signed-off-by: Mike J. Chen <mjchen@google.com>
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 4128e36cd8430dfbed16d364e6ab5265e1642db5 |
|
08-Jan-2014 |
Zhihai Xu <zhihaixu@google.com> |
increase the bluetooth task priority when start a2dp.
change the BT task priority based on audio play state.
increase the BT task priority to ANDROID_PRIORITY_URGENT_AUDIO
,when start ad2p audio playing.
to better prevent CPU premption by other process/task(UI).
restore the BT task priority when stop a2dp audio playing.
bug:12082841
Change-Id: I34e8344cffea87f68987149c820cd3e84a4196d1
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 379743beded881127703334e1dda2cd327ec651d |
|
29-Sep-2013 |
Zhihai Xu <zhihaixu@google.com> |
Failure to start playback on A2DP sink after connection
This is what happen:
after Headset is connected, we call start_audio_datapath which will send AVDTP_Start command to Headset,
Headset reject it with bad state. Bluedroid stack will ack failure to start_audio_datapath.
The next time we write audio data to bluetooth, we will call start_audio_datapath again to send AVDTP_Start command to Headset
Headset reject it with bad state again. Bluedroid stack will ack failure to start_audio_datapath.
When the third time we call start_audio_datapath, right at that time we receive AVDTP_Start command from Headset.
Handle AVDTP_Start command and Handle start_audio_datapath are in two different threads.
Handle AVDTP_Start command is in btu_task thread.
Handle start_audio_datapath() is in btif_task thread.
We have race condition in this case
Because when btif_task processed BTIF_AV_START_STREAM_REQ_EVT(triggered by start_audio_datapath),
it don't know we receive AVDTP_Start command which is processed in btu_task.
btif_task will send a message BTA_AV_API_START_EVT to btu_task, which will be handled by bta_av_do_start.
AVDTP_start command from headset is handled by bta_av_start_ok.
bta_av_start_ok will send BTA_AV_START_EVT with suspending true to btif_task and send AVDTP_Suspend command
to headset to suspend the AVDTP for reconfiguration purpose.
in bta_av_do_start, we will check whether the AVDTP is already started, we will know the AVDTP is already start at this time because
bta_av_do_start is also running in btu_task. We will send BTA_AV_START_EVT with success to btif_task.
In the btif_task, BTA_AV_START_EVT will be processed by btif_av_state_opened_handler:
For the first BTA_AV_START_EVT with suspending true sent by bta_av_start_ok, it will ignore it:
if ((p_av->start.status == BTA_SUCCESS) && (p_av->start.suspending == TRUE))
return TRUE;
For the second BTA_AV_START_EVT with success sent by bta_av_do_start , it will ack success to start_audio_datapath, and change to
BTIF_AV_STATE_STARTED/BTAV_AUDIO_STATE_STARTED, after receive success ack from bluedroid stack, we will start send Audio data to bluetooth.
At last we received AVDTP_Suspend response accept from Headset, we will send BTA_AV_SUSPEND_EVT to btif_task, which will be
handled by btif_av_state_started_handler. It will call btif_a2dp_on_suspended and call audio_state_cb with new audio state
BTAV_AUDIO_STATE_STOPPED.
so The state between bluedroid stack and audio data path is out of sync.
The fix is to send failure message if we know we suspend AVDTP in bta_av_do_start,
also make sure we won't miss acknowledgement for pending start if we exit opened state,
to avoid audio data path dead lock.
bug:10953908
Change-Id: I1704839977324b7c4e234eb843cddf3719e10d2c
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| b8ceaa484a09be14263d5f10d022a272f9602378 |
|
05-Apr-2013 |
Mattias Agren <magren@broadcom.com> |
Set default a2dp sbc encoding quality to high
* Increased bitpool to high quality setting (53). * Added rate quality
reduction to medium quality for basic rate connections * Enhanced
a2dp frame calculation ratio to smooth out frame distrubution * Removed
iop scaling patch.
Bug 8252054
Change-Id: I20725d0decfe5f820e1c03407889b6272e830aca
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 247c68fe6eee3660cbdcf4509195fe735ae25573 |
|
01-Aug-2013 |
Satya Calloji <satyac@broadcom.com> |
Add support for AbsoluteVolume
Add support for AbsoluteVolume in BTIF
bug 9595622
Change-Id: I11b707f6ab50d31bd11e879b0ebe5ad5bac54ad9
Conflicts:
btif/src/btif_rc.c
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 77d1cb6ff904b48ee85c09a06c5e05dd0ed049b9 |
|
22-May-2013 |
Kausik Sinnaswamy <kausik@broadcom.com> |
Fix for AV lockup on local and remote start collision
Bug: 7002859
Change-Id: I6170be864b44011b98e08d7e2599021a3eec70a3
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 5fd74f06caab4324d0ba69df86ad5170c072ec64 |
|
05-Apr-2013 |
Mattias Agren <magren@broadcom.com> |
Stability fixes for a2dp hal control path
Ensure av statemachine is preventing a2dp hal to restart the stream
when not ready. This prevents ending up in a scenario where a2dp hal
locks up. Code cleanup.
bug 7002859
Change-Id: I3f3eeaab4ca185733b8b0042ed2cfa701f76a203
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 9adddf4965e9ddb01e339b934c343fcbd842a977 |
|
06-Mar-2013 |
Ravi Nagarajan <nravi@broadcom.com> |
Initial version of Stack for AVRCP 1.3
BTIF and stack changes for supporting AVRCP 1.3
Change-Id: Id02eb7b6a385683cedc41c62b6f829f5d7620bd4
/external/bluetooth/bluedroid/btif/src/btif_av.c
|
| 5738f83aeb59361a0a2eda2460113f6dc9194271 |
|
13-Dec-2012 |
The Android Open Source Project <initial-contribution@android.com> |
Snapshot cdeccf6fdd8c2d494ea2867cb37a025bf8879baf
Change-Id: Ia2de32ccb97a9641462c72363b0a8c4288f4f36d
/external/bluetooth/bluedroid/btif/src/btif_av.c
|