History log of /external/harfbuzz_ng/src/hb-object-private.hh
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
7babfe5a7904c26060c5b8441ca1bf23e1444f35 03-Dec-2012 Behdad Esfahbod <behdad@behdad.org> Move object mutext into the user-data array

We are not using it for anything lse it seems.
/external/harfbuzz_ng/src/hb-object-private.hh
a1900114770952778563dd6f3bc79334b0ca8df5 03-Dec-2012 Behdad Esfahbod <behdad@behdad.org> Remove unused functions
/external/harfbuzz_ng/src/hb-object-private.hh
2cf301968cb8c1150cead0ab909457cdd3ee2d01 09-Jun-2012 Behdad Esfahbod <behdad@behdad.org> Add hb_object_lock/unlock()
/external/harfbuzz_ng/src/hb-object-private.hh
bd300df9adf955c1e69b3783c1c061876940fb8b 09-Jun-2012 Behdad Esfahbod <behdad@behdad.org> Minor
/external/harfbuzz_ng/src/hb-object-private.hh
6220e5fc0dad728e67a92e838d3ac275d032f2c7 06-Jun-2012 Behdad Esfahbod <behdad@behdad.org> Add ASSERT_POD for most objects
/external/harfbuzz_ng/src/hb-object-private.hh
cdafe3a7d8483ac586e2c16487e2a09164e0f65c 05-Jun-2012 Behdad Esfahbod <behdad@behdad.org> Add gcc intrinsics implementations for atomic and mutex
/external/harfbuzz_ng/src/hb-object-private.hh
0e253e97af71e2a7ead153589f61fd579a247502 05-Jun-2012 Behdad Esfahbod <behdad@behdad.org> Add a mutex to object header

Removes one more static-initialization. A few more to go.
/external/harfbuzz_ng/src/hb-object-private.hh
bf93b636c4963cbc32d5fba7ace1053db6719192 05-Jun-2012 Behdad Esfahbod <behdad@behdad.org> Remove constructor from hb_prealloced_array_t

This was causing all object types to be non-POD and have static
initializers. We don't need that!

Now, most nil objects just moved from .bss to .data. Fixing for that
coming soon.
/external/harfbuzz_ng/src/hb-object-private.hh
3b8fd9c48f4bde368bf2d465c148b9743a9216ee 03-Jun-2012 Behdad Esfahbod <behdad@behdad.org> Remove const from ref_count.ref_count

According to Tom Hacohen this was breaking build with some compilers.

In file included from hb-buffer-private.hh:35:0,
from hb-ot-map-private.hh:32,
from hb-ot-shape-private.hh:32,
from hb-ot-shape.cc:29:
hb-object-private.hh: In constructor '_hb_object_header_t::_hb_object_header_t()':
hb-object-private.hh:97:8: error: uninitialized const member in 'struct hb_reference_count_t'
hb-object-private.hh:51:25: note: 'hb_reference_count_t::ref_count' should be initialized
In file included from hb-ot-shape.cc:33:0:
hb-set-private.hh: In constructor '_hb_set_t::_hb_set_t()':
hb-set-private.hh:37:8: note: synthesized method '_hb_object_header_t::_hb_object_header_t()' first required here
hb-ot-shape.cc: In function 'void hb_ot_shape_glyphs_closure(hb_font_t*, hb_buffer_t*, const hb_feature_t*, unsigned int, hb_set_t*)':
hb-ot-shape.cc:521:12: note: synthesized method '_hb_set_t::_hb_set_t()' first required here
/external/harfbuzz_ng/src/hb-object-private.hh
70600dbf626808a30fb0fd8b7ae860e64d9ffe87 03-Jun-2012 Behdad Esfahbod <behdad@behdad.org> Minor
/external/harfbuzz_ng/src/hb-object-private.hh
0558d55bac7fb9279aac859b465e7c0e3ad97492 28-May-2012 Behdad Esfahbod <behdad@behdad.org> Remove hb_atomic_int_set/get()

We never use them in fact...

I'm just adjusting these as I better understand the requirements of
the code and the guarantees of each operation.
/external/harfbuzz_ng/src/hb-object-private.hh
ec3ba4b96fc4f262db1ff9f906628c32f26c9b7d 18-May-2012 Behdad Esfahbod <behdad@behdad.org> Move atomic ops into their own header
/external/harfbuzz_ng/src/hb-object-private.hh
7bd2b04fea5649d77d796d58b7f4918fe0378ee5 11-May-2012 Behdad Esfahbod <behdad@behdad.org> Minor
/external/harfbuzz_ng/src/hb-object-private.hh
cf26510dbbd8d38486e6ba423800db6427ade332 11-May-2012 Behdad Esfahbod <behdad@behdad.org> Some more...

Done. I promise.
/external/harfbuzz_ng/src/hb-object-private.hh
bc71ad4973842f25216b48842a46d6c9cbce6aa3 02-Mar-2012 Behdad Esfahbod <behdad@behdad.org> Fix atomic-int op on Apple

The OSAtomicAdd32Barrier operator returns the new value, we want the
old value.
/external/harfbuzz_ng/src/hb-object-private.hh
a1970d9afc15b2c6b7513b923019bb223bd95154 24-Feb-2012 Behdad Esfahbod <behdad@behdad.org> Add support for atomic int and mutex on Apple systems

So, apparently there's no atomic int 'get' method on Apple. You have to
add(0) to get. And that's not const-friendly. So switch inert-object
checking to a non-atomic get. This, however, is safe, and a negligible
performance boost too.
/external/harfbuzz_ng/src/hb-object-private.hh
8004429102d7d3a8c42e1cbfe231835de4d3d782 24-Feb-2012 Behdad Esfahbod <behdad@behdad.org> Remove unused hb_atomic_int_set()

Apparently it can't be implemented on OS X. We weren't using it anyway.
/external/harfbuzz_ng/src/hb-object-private.hh
bd7ff1dec5b92ee59fa060e793f88499adcd8c11 23-Feb-2012 Behdad Esfahbod <behdad@behdad.org> Allow disabling multi-threaded support

By defining HB_NO_MT.

Also, only warn once per missing MT feature support.

Mozilla Bug 666661 - gfx/harfbuzz/src/hb-prive.h - compiler warnings on mac
/external/harfbuzz_ng/src/hb-object-private.hh
af92135424b994062648f4fb7e26af0bd970a4b1 21-Oct-2011 Behdad Esfahbod <behdad@behdad.org> Minor
/external/harfbuzz_ng/src/hb-object-private.hh
89d89646e8163b6c0874b9a3c14d4da974ea8219 17-Oct-2011 Behdad Esfahbod <behdad@behdad.org> Fix intrin.h b0rkage with older MSVC

Reported by Jonathan Kew.
/external/harfbuzz_ng/src/hb-object-private.hh
d5476a30a10da5e54783c8dbf04340225a9a00d7 16-Sep-2011 Behdad Esfahbod <behdad@behdad.org> Minor
/external/harfbuzz_ng/src/hb-object-private.hh
33ccc77902660ed4b49184e5ec99f4fd0ef63175 09-Aug-2011 Behdad Esfahbod <behdad@behdad.org> [API] Make set_user_data() functions take a replace parameter

We need this to set data on objects safely without worrying that some
other thread unsets it by setting it at the same time.
/external/harfbuzz_ng/src/hb-object-private.hh
c605bbbb6d4b2a98b1f40ca818760088d991f7d1 05-Aug-2011 Behdad Esfahbod <behdad@behdad.org> Remove C++ guards from source files

Where causing issues for people with MSVC.
/external/harfbuzz_ng/src/hb-object-private.hh
cc06c243d8be3ebb1190281653d2dba504c16c0f 26-Jul-2011 Behdad Esfahbod <behdad@behdad.org> Streamline debugging infrastructure even more
/external/harfbuzz_ng/src/hb-object-private.hh
43ff203d8ea3e1b09e316e3aae1a4e5ec15bfdd2 25-Jul-2011 Behdad Esfahbod <behdad@behdad.org> Use variadic macros for debugging

Looks *so* much nicer!
/external/harfbuzz_ng/src/hb-object-private.hh
decd4e3e16424dc311e9fb5b663170414a11556a 25-Jul-2011 Behdad Esfahbod <behdad@behdad.org> Add sugar syntax for debug messages

Buffer debugging coming soon.
/external/harfbuzz_ng/src/hb-object-private.hh
31f18abecb149f8888a72510f2660328dd6de16d 15-Jun-2011 Behdad Esfahbod <behdad@behdad.org> Minor compiler warning fixes
/external/harfbuzz_ng/src/hb-object-private.hh
b9452bfc1696457e156e79037c863903da5454fc 14-Jun-2011 Behdad Esfahbod <behdad@behdad.org> Fix compiler warnings with -pedantic
/external/harfbuzz_ng/src/hb-object-private.hh
df077fadd7828b609bdfe4dbcad52ef2448525c7 12-May-2011 Behdad Esfahbod <behdad@behdad.org> [object] Make object inert during destruction

Such that user_data and other finalizers cannot resurrect object
/external/harfbuzz_ng/src/hb-object-private.hh
45bfa99034512e886d75b1d45a5a649647f4711f 11-May-2011 Behdad Esfahbod <behdad@behdad.org> Fix set implementation to be truly threadsafe even with destroy() callbacks

The test/object test is passing again, instead of deadlocking.
/external/harfbuzz_ng/src/hb-object-private.hh
46df6828513d56cd60467e36cbe45aa06648f488 05-May-2011 Behdad Esfahbod <behdad@behdad.org> Make user_data access threadsafe

For now, by taking a global user_data mutex.
/external/harfbuzz_ng/src/hb-object-private.hh
218e67b9eefa26e2e4fe43f99a84d082b185b1b0 05-May-2011 Behdad Esfahbod <behdad@behdad.org> Shrink code
/external/harfbuzz_ng/src/hb-object-private.hh
b45f32ee4e599c515ce93e44315283d236b073bb 05-May-2011 Behdad Esfahbod <behdad@behdad.org> Use hb_array_t for hb_language_t mapping
/external/harfbuzz_ng/src/hb-object-private.hh
21d2c92fdf7307c7117f8948021f0dd7d5a5d2a3 05-May-2011 Behdad Esfahbod <behdad@behdad.org> Move code around
/external/harfbuzz_ng/src/hb-object-private.hh
811482bd650fb5652a9835471ae8ecf0fb185611 05-May-2011 Behdad Esfahbod <behdad@behdad.org> Replace hb_map_t with hb_set_t which is more intuitive and flexible
/external/harfbuzz_ng/src/hb-object-private.hh
478a42536ff7ab777a7774fbfdb9c5e51334a14e 05-May-2011 Behdad Esfahbod <behdad@behdad.org> Make array/map implementation more generic
/external/harfbuzz_ng/src/hb-object-private.hh
56eb5ad6f94c32189ad219438db9a18683ca6846 05-May-2011 Behdad Esfahbod <behdad@behdad.org> Move code around

Mutex (and Windows.h by extension) are fairly isolated now.
/external/harfbuzz_ng/src/hb-object-private.hh
2000179487b49e0d504ec127450dc6fcb5568cec 03-May-2011 Behdad Esfahbod <behdad@behdad.org> Move Win32 thread-safety stuff to hb-object-private.h

The Win32 definitions for LONG, ULONG, etc conflicts with
hb-open-type.h. Avoid that by making sure hb-object-private.h
and hb-open-type.h are not included in the same compilation unit.
/external/harfbuzz_ng/src/hb-object-private.hh
1cd5969f253528b1fc05a06c7a9f222baa29f68d 03-May-2011 Behdad Esfahbod <behdad@behdad.org> [object] Fix bug in get_user_data() implementation
/external/harfbuzz_ng/src/hb-object-private.hh
852e08ec8fbfbce1d50e571d0bb0b52ef4d4cc58 28-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Move code around
/external/harfbuzz_ng/src/hb-object-private.hh
29c67d3f70b081766a6c01353980f457f38aeb12 28-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Add initial implementation of user_data to objects
/external/harfbuzz_ng/src/hb-object-private.hh
47e71d9661946a4ffb96026bf1d697d788414ab5 27-Apr-2011 Behdad Esfahbod <behdad@behdad.org> [object] Remove unnecessary use of macros
/external/harfbuzz_ng/src/hb-object-private.hh
ae008b90cfc2028e878100f78b21d70f923a6044 27-Apr-2011 Behdad Esfahbod <behdad@behdad.org> [object] Add tracing support back in
/external/harfbuzz_ng/src/hb-object-private.hh
40a9b8154f929947f4693bf90c64301afa407c3f 27-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Add TODO item
/external/harfbuzz_ng/src/hb-object-private.hh
ec6f9c2fd03a49d1e91cbaefa5bdbbfb35dff92e 22-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Further simplify object handling
/external/harfbuzz_ng/src/hb-object-private.hh
fca368c4682624346a0aaee690e1ad6ed4c0b337 22-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Add hb_object_header_t which is the common part of all objects

Makes way for adding arbitrary user_data support.
/external/harfbuzz_ng/src/hb-object-private.hh
a9f24c802956d57180d71b83e96a0fb81197df4a 21-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Move hb_reference_count_t to hb-private.h
/external/harfbuzz_ng/src/hb-object-private.hh
2409d5f8d7dd8b535ce5ea29e933f7db27d33793 21-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Update Copyright headers
/external/harfbuzz_ng/src/hb-object-private.hh
24229eb13268a422efffbcb28a094b726824c7f0 21-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Remove obsolete comment

Talking to Ryan Lortie, he thinks my comment doesn't make sense.

So I'm making the getter const. Note that g_atomic_int_get()
casts that away itself, so we don't need to worry about that
(which kinda makes me uncomfortable actually).
/external/harfbuzz_ng/src/hb-object-private.hh
3e8bdbf9414291da5cf61213d5f4275c1ae23ae5 21-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Cleanup hb_refrence_count_t
/external/harfbuzz_ng/src/hb-object-private.hh
d18431b4cd8c1b14523733cd60a62b862f5b471f 21-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Move hb_reference_count_t from macros to inline methods
/external/harfbuzz_ng/src/hb-object-private.hh
c57d454accff66e5f2c58006e8fb40bc020b6182 21-Apr-2011 Behdad Esfahbod <behdad@behdad.org> Rename all private sources and headers to C++ files

So we can liberally use the simple features of C++ that parts of the
codebase is already using.
/external/harfbuzz_ng/src/hb-object-private.hh