| f01a6c3663970ccd6e1882e76a887e0fda467b77 |
|
18-Jun-2014 |
scroggo <scroggo@google.com> |
In Android framework, make tools depend on jsoncpp
Always build the tools with JSON, but either build our own
or use the system's.
Rename skia_build_json_writer to skia_use_system_jsoncpp,
since we now always build with JSON.
Remove SK_BUILD_JSON_WRITER, which was only there so
we could build without JSON it in the framework.
BUG=skia:2448
R=djsollen@google.com, reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/303913002
/external/skia/gm/gm_expectations.cpp
|
| bfefc7c95fc0e8ebd5000c68f6d16e1a3ea0e71e |
|
13-Jun-2014 |
reed <reed@chromium.org> |
hide Config in SkImageDecoder -- use SkColorType instead
patch from issue 334613003
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/334793002
/external/skia/gm/gm_expectations.cpp
|
| 25c1066e4d23cf7cb1795c78987f4fde08282b46 |
|
16-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Generate gm/Android.mk, minus JSON.
When running gyp_to_android.py, generate the makefile for gm.
For now, remove json functionality and do not depend on json. This
allows us to build and run until solving skbug.com/2448.
gm/gm_expectations.cpp:
gm/gm_expectations.h:
gm/gmmain.cpp:
Remove all json functionality when SK_BUILD_JSON_WRITER is not defined.
This flag is not defined when SK_BUILD_FOR_ANDROID is defined.
gyp/gm.gyp:
Depend on skia and cutils.
platform_tools/android/bin/gyp_to_android.py:
Generate gm/Android.mk.
platform_tools/android/gyp_gen/makefile_writer.py:
Build gm/Android.mk when building external/skia.
Depends on https://codereview.chromium.org/282053002/
BUG=skia:2447
BUG=skia:2448
R=epoger@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/281303003
git-svn-id: http://skia.googlecode.com/svn/trunk@14767 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 90c0fbd34947b6b644e90c5b2253752035f65b64 |
|
09-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
reland "extract some common code from PictureRenderer"
re-lands https://codereview.chromium.org/273703006/
NOTRY=True
R=bungeman@google.com, djsollen@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/278633002
git-svn-id: http://skia.googlecode.com/svn/trunk@14662 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| de3ad9e2209e4c0a682246cf732c8bf3bc0f0286 |
|
08-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert of extract some common code from PictureRenderer (https://codereview.chromium.org/273703006/)
Reason for revert:
breaking the android debug builds. It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue.
Original issue's description:
> extract some common code from PictureRenderer
>
> Committed: http://code.google.com/p/skia/source/detail?r=14638
R=borenet@google.com, epoger@google.com
TBR=borenet@google.com, epoger@google.com
NOTREECHECKS=true
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/274463004
git-svn-id: http://skia.googlecode.com/svn/trunk@14649 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| ee18f2a3c92f3df3998cc93ffc438a9453281c6b |
|
08-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
extract some common code from PictureRenderer
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/273703006
git-svn-id: http://skia.googlecode.com/svn/trunk@14638 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 2b3a204bf68c9e41e62e0f2db5dfe263ea811424 |
|
27-Feb-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
replace gm_fprintf() calls with SkDebugf()
BUG=skia:1221
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/181933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13613 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| ab1c13864df34aecfd4840ea7d1e4f8730b44f4e |
|
05-Dec-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix compilation with SK_ENABLE_INST_COUNT=1
Add INHERITED declarations to class declarations that prevent
compilation with the flag.
Remove SK_DEFINE_INST_COUNT from all class implementations. Instead,
use function-local static variables in the reference count helper
classes to create the global instances to store the needed info. The
accessor functions are defined inline in the helper classes, so
definitions are not needed. The initialization point of the variables
should be as well defined as previously.
Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT
instead. This avoids possible future compilation errors further.
For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member
function to all classes that use SK_DECLARE_INST_COUNT and
SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes
contain public INHERITED typedef. This member function seems to be
compiled away. This shouĺd ensure that part of the compilation errors
are caught earlier.
Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses.
R=robertphillips@google.com, richardlin@chromium.org, bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/98703002
git-svn-id: http://skia.googlecode.com/svn/trunk@12501 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 5187c4313cd6b1dea82c43fa5af466576e4025f1 |
|
22-Oct-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
More work to integrate skimage with rebaseline tools.
tools/skimage_main.cpp:
Add the ability to write the results to checksum based filenames,
much like GM uses. This will allow using the skpdiff server to
rebaseline images.
Write the keys in the JSON file as <original image>_<pref config>.png,
so it matches gm_json.IMAGE_FILENAME_PATTERN. Also replace '_' with
'-' in the original file name, to avoid confusing the pattern matcher.
The '_' to '-' replacement also happens on the output filename.
Read the keys in a similar manner.
In make_outname, no longer remove a suffix. This fixes a bug where
subset decoding writes multiple subsets to the same file.
tools/rebaseline.py:
Since the filenames written to json files now match
gm_json.IMAGE_FILENAME_PATTERN, enable the option to match based
on configs/tests when rebaselining skimage.
test json files:
Update to match the new format of output.
gm/gm_expectations:
Add a constructor that takes a BitmapAndDigest as input.
tools/tests/skimage_self_test.py:
Test that reading the expectations file just created by skimage with
the same file actually compares to the original file (rather than just
succeeding because expectations were missing).
Change the expectations files to match the new format.
Will require a buildbot change to use the new flag: https://codereview.chromium.org/27389002/
BUG=1466
R=epoger@google.com
Review URL: https://codereview.chromium.org/26297004
git-svn-id: http://skia.googlecode.com/svn/trunk@11902 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 1d5bbb26cfe1c1d195c9525b42ff1bb7a49196b8 |
|
14-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Spin off incidental changes from DM CL (22839016).
BUG=
R=epoger@google.com, bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/27023004
git-svn-id: http://skia.googlecode.com/svn/trunk@11752 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| aadb4d9a53d406b4bf40089a10ef94302d21b6bb |
|
09-Oct-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
flush after every print in windows
R=djsollen@google.com, reed@google.com, epoger@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/26680004
git-svn-id: http://skia.googlecode.com/svn/trunk@11670 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| ef284a84f503adfd08ee52b5aee142c548698ea4 |
|
12-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
The two leaks are:
missing unrefs in megalooper GM
missing reset capability in oval renderer
This CL also expands the instance counting system to some recently adding classes (e.g., SkFontStyleSet)
R=bsalomon@google.com, jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/18461007
git-svn-id: http://skia.googlecode.com/svn/trunk@10030 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| a783f2bee894e09a9350a93d83b25ebe03ecca87 |
|
08-Jul-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
rebaseline.py: if expectations dir contains JSON format results, update those instead of image files
Part of Step 3 in https://goto.google.com/ChecksumTransitionDetail
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/18348018
git-svn-id: http://skia.googlecode.com/svn/trunk@9910 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 6f7f14d061b045a58a888ee5450b4596797dc453 |
|
19-Jun-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reland r9682, using new SkString::appendU64()
Review URL: https://codereview.chromium.org/17157005
git-svn-id: http://skia.googlecode.com/svn/trunk@9687 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 628de5f1f496d96b6f58d3139319be0f42e41269 |
|
19-Jun-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverting r9682, which broke on some compilers
git-svn-id: http://skia.googlecode.com/svn/trunk@9684 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 6324ac5d811e2554f78d61f0dfd918c678c395ba |
|
19-Jun-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
GM: add --writeChecksumBasedFilenames option
as needed for Step 2 of https://goto.google.com/ChecksumTransitionDetail :
make GenerateGMs upload actual images to Google Storage instead of skia-autogen
R=scroggo@google.com
Review URL: https://codereview.chromium.org/17365002
git-svn-id: http://skia.googlecode.com/svn/trunk@9682 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| ccd7afb6fb2df9774e57fb4d7f62f9504cabf03e |
|
28-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reland 'Add path utils, plus a test for it.'
Build SkPathJoin and SkBasename on windows also.
Previous CL did not build on Windows because the two functions were
accidentally placed inside an ifdef that did not include windows.
Move the functions to the top of the file, and add a comment by the
endif for clarity.
Previously reviewed at https://codereview.chromium.org/15747004/
Review URL: https://codereview.chromium.org/15740024
git-svn-id: http://skia.googlecode.com/svn/trunk@9295 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 9d33154b1362d89454297c21663b2403f1a75de5 |
|
28-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Split GM json schema out of display_json_results.py, for sharing with other tools
R=rmistry@google.com
Review URL: https://codereview.chromium.org/16155002
git-svn-id: http://skia.googlecode.com/svn/trunk@9290 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| dbbcaa8983c866187cdca6944717a72461bc8037 |
|
24-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "Add path utils, plus a test for it."
This reverts commit d172374b46cae0bd5d7c024b9848f5bdafcc6a16.
This CL broke on Windows.
Review URL: https://codereview.chromium.org/15986004
git-svn-id: http://skia.googlecode.com/svn/trunk@9278 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 1bee03704408fad8df334f6193267774bb21231b |
|
24-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add path utils, plus a test for it.
SkOSFile:
Added class SkOSPath with functions for
modifying strings representing path names.
OSPathTest.cpp:
Test of the new utilities.
factory.cpp:
Use SkPathJoin.
gmmain and gm_expectations:
Use SkOSPath::SkPathJoin instead of a local version.
skimage_main.cpp:
Use the new location of SkPathJoin and SkBasename.
R=epoger@google.com
Review URL: https://codereview.chromium.org/15747004
git-svn-id: http://skia.googlecode.com/svn/trunk@9277 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| d4993ff3605102036f83d5834d9a022d780e5488 |
|
24-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
GM: create GmResultDigest that encapsulates digest type ("bitmap-64bitMD5") and value (12345)
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15883004
git-svn-id: http://skia.googlecode.com/svn/trunk@9271 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| a55e48d6ef67daa90d17731b49d45b0ac94dcc34 |
|
21-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Improve tool that analyzes gm JSON summary
BUG=https://code.google.com/p/skia/issues/detail?id=1300
R=borenet@google.com
Review URL: https://codereview.chromium.org/15298010
git-svn-id: http://skia.googlecode.com/svn/trunk@9217 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 659c8c06cdc6c825004515240f81a8dafb2b4b0f |
|
21-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
GM: make behavior of make_filename() more late-binding
This will be needed to add the option of writing out files with
checksum-based filenames.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15415003
git-svn-id: http://skia.googlecode.com/svn/trunk@9215 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 26515baa9088db6076ede090d88904774713f855 |
|
14-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add gm/confirm_no_failures_in_json.py
The CompareGMs step will use this (instead of running skdiff over the image
files) to decide whether to go red or green.
R=rmistry@google.com
Review URL: https://codereview.chromium.org/15100003
git-svn-id: http://skia.googlecode.com/svn/trunk@9127 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| ce057fec926f8ec1d60ed4722d1e51a0086e7976 |
|
14-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
GM: include filename extension (.png) of each output file in JSON summary
Doing this so that, once we *do* start writing PDF checksums into the JSON
summary, we'll be able to distinguish those from the PNG checksums.
Otherwise, we could have naming collisions.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/14890017
git-svn-id: http://skia.googlecode.com/svn/trunk@9119 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 6843bdb7061364c100990e7e0feb3757fca08bb0 |
|
08-May-2013 |
scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Write/compare against expectations in skimage tool.
skimage:
Add two new modes: one to write expectations to a json file, and
another to compare results against expectations.
Use SkPATH_SEPARATOR instead of '/'.
gm_expectations:
Split into a static library so it can be used by skimage.
Make functions non static and move function definitions into source
file.
Capitalize static member functions to follow the coding style
guidelines.
BUG=https://code.google.com/p/skia/issues/detail?id=1241
R=epoger@google.com
Review URL: https://codereview.chromium.org/14670021
git-svn-id: http://skia.googlecode.com/svn/trunk@9069 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 0a117be3919becebcaa0338040af2c5ec03f6752 |
|
08-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp
R=rmistry@google.com
Review URL: https://codereview.chromium.org/15060008/
git-svn-id: http://skia.googlecode.com/svn/trunk@9064 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| e8d08a0fc294f2df7fc1ea074bcad52fc57c91b4 |
|
08-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Roll out r9059 to unbreak bots
git-svn-id: http://skia.googlecode.com/svn/trunk@9060 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| aaf7343e16c4bf9f9c6f07968689669fe6ba71d7 |
|
08-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove third-party cityhash, unused since r8992
R=djsollen@google.com
Review URL: https://codereview.chromium.org/15027013
git-svn-id: http://skia.googlecode.com/svn/trunk@9059 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 366a770159611031f4cda6d471043b7045f84072 |
|
07-May-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
GM: now that we use MD5 instead of CityHash, the JSON should say so
(this should have been part of https://code.google.com/p/skia/source/detail?r=8992 )
R=bungeman@google.com
Review URL: https://codereview.chromium.org/14758003
git-svn-id: http://skia.googlecode.com/svn/trunk@9038 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|
| 76c913db20de7ae1baa49ae66e943bf7f40781cc |
|
26-Apr-2013 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
GM: specify that currently used checksums are CityHashes of SkBitmaps
(distinct from other hash algorithms we may switch to, or hashes of
files such as PDFs that cannot be read into an SkBitmap)
Review URL: https://codereview.chromium.org/14284018
git-svn-id: http://skia.googlecode.com/svn/trunk@8877 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/gm/gm_expectations.cpp
|