| 887f3979f0c717e69a8b7d169169bc27eb46d3b5 |
|
17-Jun-2014 |
mtklein <mtklein@chromium.org> |
Add EXPERIMENTAL_beginRecording() for SkRecord-based recording.
The interesting stuff is in SkPictureRecorder.{h,cpp}. The rest is mostly moving SkRecord from its own directories into core to avoid circular dependencies in GYP.
After plumbing SkRecord all the way through in Picture, I'll delete its old entry point include/record/SkRecording.h. For now it and record.gypi need to stay where they are to keep Chrome building.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/331573004
/external/skia/src/core/SkPictureRecorder.cpp
|
| 0bdbea75ff1a6f3c313c18cab0139728967cb93e |
|
11-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove picture pre-allocation from SkPictureRecorder
This CL improves the separation of the SkPicture and SkPictureRecord classes. It delays creation of the SkPicture (in SkPictureRecorder) until recording is actually completed. To accomplish this the SkRecord-derived classes now get SkPathHeap and SkPictureContentInfo members that are absorbed by the SkPicture when it is constructed.
As an ancillary change, this CL also moves the SkPictureContentInfo object from SkPicture to SkPicturePlayback. This is intended to centralize all the data in the SkPicturePlayback object.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/324293004
/external/skia/src/core/SkPictureRecorder.cpp
|
| 9058d602d0303c4d601bea260929367a8be37f04 |
|
10-Jun-2014 |
robertphillips <robertphillips@google.com> |
Fix error revealed by Android unit test
The issue is/was that the original Picture/PictureRecorder that is being partially replayed is not guaranteed to issue any more commands before attempting to modify the existing data. Such modification is prohibited if there is a extant copy-on-write snapshot. Rather then further complicate the SkWriter32::snapshot capability for a dis-preferred use case, this CL simply copies the operation data.
R=scroggo@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/316063005
/external/skia/src/core/SkPictureRecorder.cpp
|
| 6de27127c4d50ef90b5435aefaeef47fa84b819d |
|
10-Jun-2014 |
robertphillips <robertphillips@google.com> |
Remove unused 'deepCopy' parameter
This is split out of https://codereview.chromium.org/316063005/ for clarity. Keeping in mind that SkPicture::FakeEndRecording is now only called from SkPictureRecorder, its deepCopy parameter is no longer necessary. This is b.c., given the new Picture recording semantics (where SkPictures can no longer be actively recording), cloning for thread safety only happens when an SkPicturePlayback has already been allocated (i.e., it happens in the SkPicturePlayback copy constructor.
R=scroggo@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/324093003
/external/skia/src/core/SkPictureRecorder.cpp
|
| e2f2b984443e870319e107374f7d786f243a20ae |
|
08-Jun-2014 |
robertphillips <robertphillips@google.com> |
No longer limit SkPictureRecorder::partialReplay to Android
Toggling this for local testing is a bit of a chore.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/316173004
/external/skia/src/core/SkPictureRecorder.cpp
|
| 643b8bd6617e333f7a970a57ad9166f3d6675d1a |
|
08-Jun-2014 |
robertphillips <robertphillips@google.com> |
First pass at splitting out SkPictureRecord from SkPicture
This patch begins the process of splitting apart SkPicture, SkPicturePlayback and SkPictureRecord.
This is still a bit messy. In a follow up CL I hope to delay the creation of SkPictureRecorder's SkPicture until endRecording time.
R=reed@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/318763004
/external/skia/src/core/SkPictureRecorder.cpp
|
| 2246e325b8710389d8f718843356e410f683dd25 |
|
29-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Make SkPictureRecorder::partialReplay const
This will make it easier to integrate this into Android's use case.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/307693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14957 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureRecorder.cpp
|
| 5889e309961b865fbb2c4ed7f704c315c005a63c |
|
28-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Include SkTypes to fix Android frameworks build
Since Android's defines are included in SkUserConfig (rather than
being defined in the build file), we need to include something that
includes SkUserConfig (transitively; meaning just about anything)
before we can use any build macros. Include SkTypes, "the correct
way to get access to the config system" so that
SK_BUILD_FOR_ANDROID is defined before querying it.
R=robertphillips@google.com, djsollen@google.com, mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/294393011
git-svn-id: http://skia.googlecode.com/svn/trunk@14914 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureRecorder.cpp
|
| 6d3eaeabddd03b1bf440345f1f3f9aa5b6dd0717 |
|
28-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add replay entry point to SkPictureRecorder for Android
This CL adds an Android-only entry point to address the Java Picture(Picture) and serialize use cases. Note that (in its current form) it doesn't preserve the old API's handling of unbalanced saves/saveLayers (this CL always balances them).
R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/252873005
git-svn-id: http://skia.googlecode.com/svn/trunk@14911 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureRecorder.cpp
|
| 770963f23f4fc313db0fa3bac18b1b8aafb55f17 |
|
18-Apr-2014 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Staging for cleanup of SkPicture-related headers
https://codereview.chromium.org/243173002
git-svn-id: http://skia.googlecode.com/svn/trunk@14258 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkPictureRecorder.cpp
|