| bf6a6d45043393f8cd9c942d7f03b789fe2c94b3 |
|
31-Jan-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix leaks in SkConf
These leaks were small and would only happen with non-default
runtime configuration things set, but they were still leaks
and they should be squished.
Valgrind reported leaks pre-patch, and all the rtconf leaks are gone after patch.
BUG=skia:1722
R=reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/136963004
git-svn-id: http://skia.googlecode.com/svn/trunk@13269 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 2d1adf2322b026ec746dbdd931ca6aac7bb5d4cb |
|
10-Jan-2014 |
halcanary@google.com <halcanary@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reduce verbosity of SkGraphics::Init in default case.
SkGraphics::Init() now checks to see if there are any non-default
runtime configuration options before announcing that it is about
to print out the non-default runtime configuration options.
This makes the executables in tools/ less verbose.
Add SkRTConfRegistry::countNonDefault() function.
BUG=
R=mtklein@google.com, reed@google.com
Review URL: https://codereview.chromium.org/133583003
git-svn-id: http://skia.googlecode.com/svn/trunk@13017 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 1f0121af495e5a70ecff2521729b7749c81a20b2 |
|
06-Nov-2013 |
halcanary@google.com <halcanary@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
New SkRTConf macro SK_CONF_TRY_SET: no complaint on missing configuration
SK_CONF_TRY_SET() is like SK_CONF_SET(), but doesn't complain if
confname can't be found. This is useful if the SK_CONF_DECLARE is
inside a source file whose linkage is dependent on the system.
Internally to the SkRTConf system, SkRTConfRegistry::set() was given
an additional parameter controling wanrings.
A new RuntimeConfig unit test was introduced. It should run silently.
In the future, it should be expanded to cover all of the SkRTConf
functionality.
(For example, the images.jpeg.suppressDecoderWarnings variable is
defined and used only in SkImageDecoder_libjpeg.cpp, but on MacOS, we
use Core Graphics via SkImageDecoder_CG.cpp - SkImageDecoder_libjpeg
is never linked in. The same is true of the Windows Imaging Component
on Windows.)
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/54503007
git-svn-id: http://skia.googlecode.com/svn/trunk@12155 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 7a2269ea7352f0580422f193081b6d7028651138 |
|
06-Nov-2013 |
halcanary@google.com <halcanary@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix a bug which caused crash in SkRTConfig whith string values in environment variables
A minor change to SkRTConfRegistry::parse() fixes this
BUG=skia:1717
R=scroggo@google.com
Review URL: https://codereview.chromium.org/26373008
git-svn-id: http://skia.googlecode.com/svn/trunk@12152 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| c1bf2de83549406de305e174af2b88630fdc3098 |
|
14-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix crash when querying a runtime config that is defined in environment
Fix crash when querying a runtime config in case when there's no
skia.conf file and the config variable is still defined in the
environment.
Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test.
Previous version of the patch failed Windows build due to setenv usage.
On Windows, use _putenv_s instead.
BUG=skia:1494
R=bsalomon@google.com, humper@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/23174002
git-svn-id: http://skia.googlecode.com/svn/trunk@10715 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 1c0ade7fc67a45f0c3068303aefaba846e2ffa05 |
|
11-Aug-2013 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Reverted r10654 (Fix crash when querying a runtime config that is defined in environment) due to compilation failure on Chromium win_layout bot
git-svn-id: http://skia.googlecode.com/svn/trunk@10669 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| a1007def7ed27c9bc71b6d6b8c097848f3731568 |
|
09-Aug-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix crash when querying a runtime config that is defined in environment
Fix crash when querying a runtime config in case when there's no
skia.conf file and the config variable is still defined in the
environment.
Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test.
BUG=skia:1494
R=bsalomon@google.com, humper@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/22650007
git-svn-id: http://skia.googlecode.com/svn/trunk@10654 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 91673aafdf227675da15a8b7fabd38dbabdefbb7 |
|
24-Jul-2013 |
humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
search registered rtconf variables backwards and break when we find the
first match. Patch from mozilla
BUG=
R=mtklein@google.com
Review URL: https://codereview.chromium.org/20136003
git-svn-id: http://skia.googlecode.com/svn/trunk@10337 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 2b71c439afaf2912f6eba211d0631ef07beaec1b |
|
20-May-2013 |
humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix boolean check for unknown rtconf variables in files.
BUG=
Review URL: https://codereview.chromium.org/15300019
git-svn-id: http://skia.googlecode.com/svn/trunk@9198 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 8563d3089cd18464db181c16ad90271de16ba524 |
|
04-Mar-2013 |
sugoi@google.com <sugoi@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed doParse functions
For some reason, "success" wasn't set in a bunch of template specializations, causing it to be invalid when used later on.
Review URL: https://codereview.appspot.com/7370052
git-svn-id: http://skia.googlecode.com/svn/trunk@7969 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 7fc0e0a75a99ac5ea2e5d03ab3a00cacabacfa09 |
|
15-Jan-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7173 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 810ae48f82f82d6e7fc4cf78d7a5a69e3cf9f2ed |
|
14-Jan-2013 |
humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
move template specializations to inline functions in the header to make windows happy again
BUG=
Review URL: https://codereview.appspot.com/7099053
git-svn-id: http://skia.googlecode.com/svn/trunk@7164 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 18a48c3c1c1aa183a1b1ab033be34329685199f6 |
|
14-Jan-2013 |
humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
replace getline with fgets for portability
BUG=
Review URL: https://codereview.appspot.com/7085058
git-svn-id: http://skia.googlecode.com/svn/trunk@7163 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 6d29eda49129893d8f5e385bfbe8473af154b82b |
|
14-Jan-2013 |
humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove dynamic_cast because rtti is disabled on some platforms (but not all??)
BUG=
Review URL: https://codereview.appspot.com/7102056
git-svn-id: http://skia.googlecode.com/svn/trunk@7161 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|
| 7af56bee17764a0c118c8856a035bb3d27766969 |
|
14-Jan-2013 |
humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Runtime configuration system for skia. This will allow developers to control settings at launch time without relying on compile-time flags or recompilation. It can be used to turn features on and off, as well as to control numeric quantities to 'tune' algorithms. Once I make sure it's working across all platforms I'll send out a quick tutorial on its use.
Review URL: https://codereview.appspot.com/7098051
git-svn-id: http://skia.googlecode.com/svn/trunk@7158 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/utils/SkRTConf.cpp
|