15821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Copyright (c) 2012 The Chromium Authors. All rights reserved. 25821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Use of this source code is governed by a BSD-style license that can be 35821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// found in the LICENSE file. 45821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 55821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/bind.h" 65821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/bind_helpers.h" 72a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "base/files/file_path.h" 85821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/memory/singleton.h" 99ab5563a3196760eb381d102cbb2bc0f7abc6a50Ben Murdoch#include "base/message_loop/message_loop.h" 10868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)#include "base/strings/utf_string_conversions.h" 115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/profiles/profile.h" 125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/ui/browser.h" 132a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "chrome/browser/ui/tabs/tab_strip_model.h" 145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/ui/webui/chrome_web_contents_handler.h" 155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/common/url_constants.h" 165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/test/base/in_process_browser_test.h" 175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/test/base/ui_test_utils.h" 185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "content/public/browser/browser_context.h" 195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "content/public/browser/render_widget_host_view.h" 205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "content/public/browser/web_contents.h" 215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "testing/gmock/include/gmock/gmock.h" 225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "testing/gtest/include/gtest/gtest.h" 235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "ui/views/controls/webview/web_dialog_view.h" 245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "ui/views/widget/widget.h" 252a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "ui/web_dialogs/test/test_web_dialog_delegate.h" 265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using content::BrowserContext; 285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using content::WebContents; 295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using testing::Eq; 305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using ui::WebDialogDelegate; 315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace { 335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Initial size of WebDialog for SizeWindow test case. 355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)const int kInitialWidth = 40; 365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)const int kInitialHeight = 40; 375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)class TestWebDialogView : public views::WebDialogView { 395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) public: 405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) TestWebDialogView(content::BrowserContext* context, 415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) WebDialogDelegate* delegate) 425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) : views::WebDialogView(context, delegate, new ChromeWebContentsHandler), 435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) should_quit_on_size_change_(false) { 445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) delegate->GetDialogSize(&last_size_); 455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) void set_should_quit_on_size_change(bool should_quit) { 485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) should_quit_on_size_change_ = should_quit; 495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) private: 525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // TODO(xiyuan): Update this when WidgetDelegate has bounds change hook. 535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) virtual void SaveWindowPlacement(const gfx::Rect& bounds, 545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ui::WindowShowState show_state) OVERRIDE { 555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (should_quit_on_size_change_ && last_size_ != bounds.size()) { 565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Schedule message loop quit because we could be called while 575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the bounds change call is on the stack and not in the nested message 585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // loop. 59b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) base::MessageLoop::current()->PostTask( 60b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) FROM_HERE, 61b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) base::Bind(&base::MessageLoop::Quit, 62b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) base::Unretained(base::MessageLoop::current()))); 635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) last_size_ = bounds.size(); 665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) virtual void OnDialogClosed(const std::string& json_retval) OVERRIDE { 695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) should_quit_on_size_change_ = false; // No quit when we are closing. 705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) views::WebDialogView::OnDialogClosed(json_retval); 715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Whether we should quit message loop when size change is detected. 745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) bool should_quit_on_size_change_; 755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) gfx::Size last_size_; 765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DISALLOW_COPY_AND_ASSIGN(TestWebDialogView); 785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}; 795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} // namespace 815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)class WebDialogBrowserTest : public InProcessBrowserTest { 835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) public: 845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) WebDialogBrowserTest() {} 855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}; 865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 8703b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles)// Windows has some issues resizing windows. An off by one problem, and a 8803b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles)// minimum size that seems too big. See http://crbug.com/52602. 8903b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles)#if defined(OS_WIN) 9003b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles)#define MAYBE_SizeWindow DISABLED_SizeWindow 9103b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles)#else 9203b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles)#define MAYBE_SizeWindow SizeWindow 9303b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles)#endif 9403b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles)IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) { 9503b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) ui::test::TestWebDialogDelegate delegate( 9603b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) (GURL(chrome::kChromeUIChromeURLsURL))); 9703b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) delegate.set_size(kInitialWidth, kInitialHeight); 985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) TestWebDialogView* view = 10003b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) new TestWebDialogView(browser()->profile(), &delegate); 1012a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) WebContents* web_contents = 1022a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) browser()->tab_strip_model()->GetActiveWebContents(); 1035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_TRUE(web_contents != NULL); 10403b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) views::Widget::CreateWindowWithParent(view, web_contents->GetNativeView()); 1055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->GetWidget()->Show(); 1065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // TestWebDialogView should quit current message loop on size change. 1085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->set_should_quit_on_size_change(true); 1095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) gfx::Rect bounds = view->GetWidget()->GetClientAreaBoundsInScreen(); 1115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) gfx::Rect set_bounds = bounds; 1135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) gfx::Rect actual_bounds, rwhv_bounds; 1145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Bigger than the default in both dimensions. 1165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) set_bounds.set_width(400); 1175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) set_bounds.set_height(300); 1185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->MoveContents(web_contents, set_bounds); 1205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) content::RunMessageLoop(); // TestWebDialogView will quit. 1215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen(); 1225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(set_bounds, actual_bounds); 1235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) rwhv_bounds = 1255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->web_contents()->GetRenderWidgetHostView()->GetViewBounds(); 1265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_LT(0, rwhv_bounds.width()); 1275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_LT(0, rwhv_bounds.height()); 1285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_GE(set_bounds.width(), rwhv_bounds.width()); 1295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_GE(set_bounds.height(), rwhv_bounds.height()); 1305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Larger in one dimension and smaller in the other. 1325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) set_bounds.set_width(550); 1335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) set_bounds.set_height(250); 1345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->MoveContents(web_contents, set_bounds); 1365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) content::RunMessageLoop(); // TestWebDialogView will quit. 1375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen(); 1385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(set_bounds, actual_bounds); 1395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) rwhv_bounds = 1415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->web_contents()->GetRenderWidgetHostView()->GetViewBounds(); 1425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_LT(0, rwhv_bounds.width()); 1435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_LT(0, rwhv_bounds.height()); 1445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_GE(set_bounds.width(), rwhv_bounds.width()); 1455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_GE(set_bounds.height(), rwhv_bounds.height()); 1465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Get very small. 14803b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) const gfx::Size min_size = view->GetWidget()->GetMinimumSize(); 14903b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) EXPECT_LT(0, min_size.width()); 15003b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) EXPECT_LT(0, min_size.height()); 15103b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) 1525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) set_bounds.set_size(min_size); 1535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->MoveContents(web_contents, set_bounds); 1555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) content::RunMessageLoop(); // TestWebDialogView will quit. 1565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen(); 1575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(set_bounds, actual_bounds); 1585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) rwhv_bounds = 1605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->web_contents()->GetRenderWidgetHostView()->GetViewBounds(); 1615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_LT(0, rwhv_bounds.width()); 1625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_LT(0, rwhv_bounds.height()); 1635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_GE(set_bounds.width(), rwhv_bounds.width()); 1645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_GE(set_bounds.height(), rwhv_bounds.height()); 1655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 16603b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) // Check to make sure we can't get to 0x0. First expand beyond the minimum 16703b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) // size that was set above so that TestWebDialogView has a change to pick up. 16803b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) set_bounds.set_height(250); 16903b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) view->MoveContents(web_contents, set_bounds); 17003b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) content::RunMessageLoop(); // TestWebDialogView will quit. 17103b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen(); 17203b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) EXPECT_EQ(set_bounds, actual_bounds); 17303b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) 17403b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) // Now verify that attempts to re-size to 0x0 enforces the minimum size. 1755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) set_bounds.set_width(0); 1765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) set_bounds.set_height(0); 1775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) view->MoveContents(web_contents, set_bounds); 1795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) content::RunMessageLoop(); // TestWebDialogView will quit. 1805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen(); 18103b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) EXPECT_EQ(min_size, actual_bounds.size()); 18203b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) 18303b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) // And that the render view is also non-zero. 18403b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) rwhv_bounds = 18503b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) view->web_contents()->GetRenderWidgetHostView()->GetViewBounds(); 18603b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) EXPECT_LT(0, rwhv_bounds.width()); 18703b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) EXPECT_LT(0, rwhv_bounds.height()); 18803b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) 18903b57e008b61dfcb1fbad3aea950ae0e001748b0Torne (Richard Coles) view->GetWidget()->CloseNow(); 1905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 191