web_dialog_view_browsertest.cc revision 5821806d5e7f356e8fa4b058a389a808ea183019
15821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Copyright (c) 2012 The Chromium Authors. All rights reserved.
25821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Use of this source code is governed by a BSD-style license that can be
35821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// found in the LICENSE file.
45821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
55821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/bind.h"
65821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/bind_helpers.h"
75821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/file_path.h"
85821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/memory/singleton.h"
95821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/message_loop.h"
105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/utf_string_conversions.h"
115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/profiles/profile.h"
125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/ui/browser.h"
135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/ui/browser_tabstrip.h"
145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/ui/webui/chrome_web_contents_handler.h"
155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/ui/webui/test_web_dialog_delegate.h"
165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/common/url_constants.h"
175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/test/base/in_process_browser_test.h"
185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/test/base/ui_test_utils.h"
195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "content/public/browser/browser_context.h"
205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "content/public/browser/render_widget_host_view.h"
215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "content/public/browser/web_contents.h"
225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "content/public/browser/web_contents_view.h"
235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "testing/gmock/include/gmock/gmock.h"
245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "testing/gtest/include/gtest/gtest.h"
255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "ui/views/controls/webview/web_dialog_view.h"
265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "ui/views/widget/widget.h"
275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using content::BrowserContext;
295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using content::WebContents;
305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using testing::Eq;
315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using ui::WebDialogDelegate;
325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace {
345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Initial size of WebDialog for SizeWindow test case.
365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)const int kInitialWidth = 40;
375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)const int kInitialHeight = 40;
385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)class TestWebDialogView : public views::WebDialogView {
405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) public:
415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  TestWebDialogView(content::BrowserContext* context,
425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)                    WebDialogDelegate* delegate)
435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      : views::WebDialogView(context, delegate, new ChromeWebContentsHandler),
445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)        should_quit_on_size_change_(false) {
455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    delegate->GetDialogSize(&last_size_);
465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  void set_should_quit_on_size_change(bool should_quit) {
495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    should_quit_on_size_change_ = should_quit;
505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) private:
535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // TODO(xiyuan): Update this when WidgetDelegate has bounds change hook.
545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  virtual void SaveWindowPlacement(const gfx::Rect& bounds,
555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)                                   ui::WindowShowState show_state) OVERRIDE {
565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    if (should_quit_on_size_change_ && last_size_ != bounds.size()) {
575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      // Schedule message loop quit because we could be called while
585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      // the bounds change call is on the stack and not in the nested message
595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      // loop.
605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)          &MessageLoop::Quit, base::Unretained(MessageLoop::current())));
625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    }
635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    last_size_ = bounds.size();
655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  virtual void OnDialogClosed(const std::string& json_retval) OVERRIDE {
685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    should_quit_on_size_change_ = false;  // No quit when we are closing.
695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    views::WebDialogView::OnDialogClosed(json_retval);
705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // Whether we should quit message loop when size change is detected.
735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  bool should_quit_on_size_change_;
745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  gfx::Size last_size_;
755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  DISALLOW_COPY_AND_ASSIGN(TestWebDialogView);
775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)};
785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}  // namespace
805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)class WebDialogBrowserTest : public InProcessBrowserTest {
825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) public:
835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  WebDialogBrowserTest() {}
845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)};
855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#define MAYBE_SizeWindow SizeWindow
885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#else
895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// http://code.google.com/p/chromium/issues/detail?id=52602
905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Windows has some issues resizing windows- an off by one problem,
915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// and a minimum size that seems too big.  This file isn't included in
925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Mac builds yet. On Chrome OS, this test doesn't apply since ChromeOS
935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// doesn't allow resizing of windows.
945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#define MAYBE_SizeWindow DISABLED_SizeWindow
955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#endif
965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) {
985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  test::TestWebDialogDelegate* delegate =
995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      new test::TestWebDialogDelegate(
1005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)          GURL(chrome::kChromeUIChromeURLsURL));
1015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  delegate->set_size(kInitialWidth, kInitialHeight);
1025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  TestWebDialogView* view =
1045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      new TestWebDialogView(browser()->profile(), delegate);
1055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  WebContents* web_contents = chrome::GetActiveWebContents(browser());
1065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  ASSERT_TRUE(web_contents != NULL);
1075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  views::Widget::CreateWindowWithParent(
1085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      view, web_contents->GetView()->GetTopLevelNativeWindow());
1095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  view->GetWidget()->Show();
1105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // TestWebDialogView should quit current message loop on size change.
1125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  view->set_should_quit_on_size_change(true);
1135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  gfx::Rect bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
1155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  gfx::Rect set_bounds = bounds;
1175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  gfx::Rect actual_bounds, rwhv_bounds;
1185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // Bigger than the default in both dimensions.
1205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  set_bounds.set_width(400);
1215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  set_bounds.set_height(300);
1225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  view->MoveContents(web_contents, set_bounds);
1245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  content::RunMessageLoop();  // TestWebDialogView will quit.
1255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
1265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_EQ(set_bounds, actual_bounds);
1275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  rwhv_bounds =
1295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      view->web_contents()->GetRenderWidgetHostView()->GetViewBounds();
1305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_LT(0, rwhv_bounds.width());
1315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_LT(0, rwhv_bounds.height());
1325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_GE(set_bounds.width(), rwhv_bounds.width());
1335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_GE(set_bounds.height(), rwhv_bounds.height());
1345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // Larger in one dimension and smaller in the other.
1365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  set_bounds.set_width(550);
1375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  set_bounds.set_height(250);
1385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  view->MoveContents(web_contents, set_bounds);
1405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  content::RunMessageLoop();  // TestWebDialogView will quit.
1415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
1425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_EQ(set_bounds, actual_bounds);
1435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  rwhv_bounds =
1455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      view->web_contents()->GetRenderWidgetHostView()->GetViewBounds();
1465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_LT(0, rwhv_bounds.width());
1475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_LT(0, rwhv_bounds.height());
1485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_GE(set_bounds.width(), rwhv_bounds.width());
1495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_GE(set_bounds.height(), rwhv_bounds.height());
1505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // Get very small.
1525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  gfx::Size min_size = view->GetWidget()->GetMinimumSize();
1535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  set_bounds.set_size(min_size);
1545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  view->MoveContents(web_contents, set_bounds);
1565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  content::RunMessageLoop();  // TestWebDialogView will quit.
1575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
1585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_EQ(set_bounds, actual_bounds);
1595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  rwhv_bounds =
1615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      view->web_contents()->GetRenderWidgetHostView()->GetViewBounds();
1625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_LT(0, rwhv_bounds.width());
1635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_LT(0, rwhv_bounds.height());
1645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_GE(set_bounds.width(), rwhv_bounds.width());
1655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_GE(set_bounds.height(), rwhv_bounds.height());
1665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // Check to make sure we can't get to 0x0
1685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  set_bounds.set_width(0);
1695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  set_bounds.set_height(0);
1705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  view->MoveContents(web_contents, set_bounds);
1725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  content::RunMessageLoop();  // TestWebDialogView will quit.
1735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
1745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_LT(0, actual_bounds.width());
1755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  EXPECT_LT(0, actual_bounds.height());
1765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
177