shill_property_handler.cc revision f2477e01787aa58f445919b809d89e252beef54f
15821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Copyright (c) 2012 The Chromium Authors. All rights reserved.
25821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Use of this source code is governed by a BSD-style license that can be
35821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// found in the LICENSE file.
45821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
55821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chromeos/network/shill_property_handler.h"
65821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
75821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/bind.h"
82a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "base/format_macros.h"
95821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/stl_util.h"
10868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)#include "base/strings/string_util.h"
11868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)#include "base/strings/stringprintf.h"
125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/values.h"
135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chromeos/dbus/dbus_thread_manager.h"
145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chromeos/dbus/shill_device_client.h"
155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chromeos/dbus/shill_ipconfig_client.h"
165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chromeos/dbus/shill_manager_client.h"
17eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch#include "chromeos/dbus/shill_profile_client.h"
185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chromeos/dbus/shill_service_client.h"
192a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "chromeos/network/network_event_log.h"
20c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)#include "chromeos/network/network_state.h"
215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "dbus/object_path.h"
225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "third_party/cros_system_api/dbus/service_constants.h"
235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace {
255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
262a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)// Limit the number of services or devices we observe. Since they are listed in
272a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)// priority order, it should be reasonable to ignore services past this.
282a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)const size_t kMaxObserved = 100;
295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)const base::ListValue* GetListValue(const std::string& key,
315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)                                    const base::Value& value) {
325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  const base::ListValue* vlist = NULL;
335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  if (!value.GetAsList(&vlist)) {
345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    LOG(ERROR) << "Error parsing key as list: " << key;
355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    return NULL;
365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  return vlist;
385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}  // namespace
415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace chromeos {
435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace internal {
445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
452a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)// Class to manage Shill service property changed observers. Observers are
462a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)// added on construction and removed on destruction. Runs the handler when
472a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)// OnPropertyChanged is called.
482a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)class ShillPropertyObserver : public ShillPropertyChangedObserver {
492a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) public:
502a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  typedef base::Callback<void(ManagedState::ManagedType type,
512a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)                              const std::string& service,
522a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)                              const std::string& name,
532a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)                              const base::Value& value)> Handler;
542a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
552a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  ShillPropertyObserver(ManagedState::ManagedType type,
562a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)                        const std::string& path,
572a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)                        const Handler& handler)
582a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      : type_(type),
592a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        path_(path),
602a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        handler_(handler) {
612a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    if (type_ == ManagedState::MANAGED_TYPE_NETWORK) {
622a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      DBusThreadManager::Get()->GetShillServiceClient()->
632a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)          AddPropertyChangedObserver(dbus::ObjectPath(path_), this);
642a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    } else if (type_ == ManagedState::MANAGED_TYPE_DEVICE) {
652a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      DBusThreadManager::Get()->GetShillDeviceClient()->
662a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)          AddPropertyChangedObserver(dbus::ObjectPath(path_), this);
672a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    } else {
682a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      NOTREACHED();
692a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    }
702a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
712a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
722a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  virtual ~ShillPropertyObserver() {
732a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    if (type_ == ManagedState::MANAGED_TYPE_NETWORK) {
742a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      DBusThreadManager::Get()->GetShillServiceClient()->
752a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)          RemovePropertyChangedObserver(dbus::ObjectPath(path_), this);
762a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    } else if (type_ == ManagedState::MANAGED_TYPE_DEVICE) {
772a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      DBusThreadManager::Get()->GetShillDeviceClient()->
782a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)          RemovePropertyChangedObserver(dbus::ObjectPath(path_), this);
792a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    } else {
802a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      NOTREACHED();
812a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    }
822a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
832a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
842a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  // ShillPropertyChangedObserver overrides.
852a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  virtual void OnPropertyChanged(const std::string& key,
862a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)                                 const base::Value& value) OVERRIDE {
872a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    handler_.Run(type_, path_, key, value);
882a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
892a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
902a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) private:
912a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  ManagedState::ManagedType type_;
922a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  std::string path_;
932a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  Handler handler_;
942a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
952a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  DISALLOW_COPY_AND_ASSIGN(ShillPropertyObserver);
962a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)};
972a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
982a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)//------------------------------------------------------------------------------
992a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)// ShillPropertyHandler
1002a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
1015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)ShillPropertyHandler::ShillPropertyHandler(Listener* listener)
1025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    : listener_(listener),
103c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)      shill_manager_(DBusThreadManager::Get()->GetShillManagerClient()) {
1045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
1055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)ShillPropertyHandler::~ShillPropertyHandler() {
1075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // Delete network service observers.
1085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  STLDeleteContainerPairSecondPointers(
1095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      observed_networks_.begin(), observed_networks_.end());
1102a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  STLDeleteContainerPairSecondPointers(
1112a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      observed_devices_.begin(), observed_devices_.end());
1125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  CHECK(shill_manager_ == DBusThreadManager::Get()->GetShillManagerClient());
1135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  shill_manager_->RemovePropertyChangedObserver(this);
1145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
1155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
1165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::Init() {
117eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  UpdateManagerProperties();
118eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  shill_manager_->AddPropertyChangedObserver(this);
119eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch}
120eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch
121eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdochvoid ShillPropertyHandler::UpdateManagerProperties() {
122eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  NET_LOG_EVENT("UpdateManagerProperties", "");
1235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  shill_manager_->GetProperties(
1245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      base::Bind(&ShillPropertyHandler::ManagerPropertiesCallback,
125c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)                 AsWeakPtr()));
1265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
1275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
128c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)bool ShillPropertyHandler::IsTechnologyAvailable(
1292a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const std::string& technology) const {
1302a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  return available_technologies_.count(technology) != 0;
1312a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)}
1322a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
133c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)bool ShillPropertyHandler::IsTechnologyEnabled(
1342a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const std::string& technology) const {
1352a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  return enabled_technologies_.count(technology) != 0;
1362a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)}
1372a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
138c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)bool ShillPropertyHandler::IsTechnologyEnabling(
139c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    const std::string& technology) const {
140c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)  return enabling_technologies_.count(technology) != 0;
141c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)}
142c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)
143c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)bool ShillPropertyHandler::IsTechnologyUninitialized(
1442a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const std::string& technology) const {
1452a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  return uninitialized_technologies_.count(technology) != 0;
1462a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)}
1472a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
1485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::SetTechnologyEnabled(
1495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const std::string& technology,
1502a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    bool enabled,
1512a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const network_handler::ErrorCallback& error_callback) {
1525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  if (enabled) {
153c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    enabling_technologies_.insert(technology);
1542a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    shill_manager_->EnableTechnology(
1552a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        technology,
1562a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        base::Bind(&base::DoNothing),
157c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)        base::Bind(&ShillPropertyHandler::EnableTechnologyFailed,
158c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)                   AsWeakPtr(), technology, error_callback));
1595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  } else {
160eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    // Immediately clear locally from enabled and enabling lists.
161c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    enabled_technologies_.erase(technology);
162c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    enabling_technologies_.erase(technology);
1632a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    shill_manager_->DisableTechnology(
1642a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        technology,
1652a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        base::Bind(&base::DoNothing),
1662a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        base::Bind(&network_handler::ShillErrorCallbackFunction,
1677dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch                   "SetTechnologyEnabled Failed",
16890dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)                   technology, error_callback));
1695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
1705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
1715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
172868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)void ShillPropertyHandler::SetCheckPortalList(
173868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)    const std::string& check_portal_list) {
174868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)  base::StringValue value(check_portal_list);
175868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)  shill_manager_->SetProperty(
17668043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)      shill::kCheckPortalListProperty,
177868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)      value,
178868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)      base::Bind(&base::DoNothing),
179868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)      base::Bind(&network_handler::ShillErrorCallbackFunction,
1807dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch                 "SetCheckPortalList Failed",
181868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)                 "", network_handler::ErrorCallback()));
182868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)}
183868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)
1845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::RequestScan() const {
1852a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  shill_manager_->RequestScan(
1862a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      "",
1872a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      base::Bind(&base::DoNothing),
1882a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      base::Bind(&network_handler::ShillErrorCallbackFunction,
1897dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch                 "RequestScan Failed",
19090dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)                 "", network_handler::ErrorCallback()));
1915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
1925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
193c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)void ShillPropertyHandler::ConnectToBestServices() const {
19490dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)  NET_LOG_EVENT("ConnectToBestServices", "");
195c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)  shill_manager_->ConnectToBestServices(
196c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)      base::Bind(&base::DoNothing),
197c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)      base::Bind(&network_handler::ShillErrorCallbackFunction,
1987dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch                 "ConnectToBestServices Failed",
19990dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)                 "", network_handler::ErrorCallback()));
200c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)}
201c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)
2025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::RequestProperties(ManagedState::ManagedType type,
2035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)                                             const std::string& path) {
204eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  VLOG(2) << "Request Properties: " << type << " : " << path;
2052a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  if (pending_updates_[type].find(path) != pending_updates_[type].end())
2062a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    return;  // Update already requested.
2072a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
2082a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  pending_updates_[type].insert(path);
209eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  if (type == ManagedState::MANAGED_TYPE_NETWORK ||
210eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      type == ManagedState::MANAGED_TYPE_FAVORITE) {
2115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    DBusThreadManager::Get()->GetShillServiceClient()->GetProperties(
2125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)        dbus::ObjectPath(path),
2135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)        base::Bind(&ShillPropertyHandler::GetPropertiesCallback,
214c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)                   AsWeakPtr(), type, path));
2155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  } else if (type == ManagedState::MANAGED_TYPE_DEVICE) {
2165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    DBusThreadManager::Get()->GetShillDeviceClient()->GetProperties(
2175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)        dbus::ObjectPath(path),
2185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)        base::Bind(&ShillPropertyHandler::GetPropertiesCallback,
219c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)                   AsWeakPtr(), type, path));
2205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  } else {
2215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    NOTREACHED();
2225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
2235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
2245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
2255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::OnPropertyChanged(const std::string& key,
2265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)                                             const base::Value& value) {
227d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)  ManagerPropertyChanged(key, value);
228eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  CheckPendingStateListUpdates(key);
2295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
2305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
2315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)//------------------------------------------------------------------------------
2325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Private methods
2335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
2345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::ManagerPropertiesCallback(
2355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    DBusMethodCallStatus call_status,
2365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const base::DictionaryValue& properties) {
2375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  if (call_status != DBUS_METHOD_CALL_SUCCESS) {
23890dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)    NET_LOG_ERROR("ManagerPropertiesCallback",
23990dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)                  base::StringPrintf("Failed: %d", call_status));
2405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    return;
2415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
24290dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)  NET_LOG_EVENT("ManagerPropertiesCallback", "Success");
243eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  const base::Value* update_service_value = NULL;
244eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  const base::Value* update_service_complete_value = NULL;
2455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  for (base::DictionaryValue::Iterator iter(properties);
246c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)       !iter.IsAtEnd(); iter.Advance()) {
2475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    // Defer updating Services until all other properties have been updated.
24868043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)    if (iter.key() == shill::kServicesProperty)
249eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      update_service_value = &iter.value();
250eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    else if (iter.key() == shill::kServiceCompleteListProperty)
251eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      update_service_complete_value = &iter.value();
2525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    else
253d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)      ManagerPropertyChanged(iter.key(), iter.value());
2545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
255eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  // Update Services which can safely assume other properties have been set.
256d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)  if (update_service_value)
25768043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)    ManagerPropertyChanged(shill::kServicesProperty, *update_service_value);
258eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  // Update ServiceCompleteList which skips entries that have already been
259eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  // requested for Services.
260eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  if (update_service_complete_value) {
261d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)    ManagerPropertyChanged(shill::kServiceCompleteListProperty,
262d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)                           *update_service_complete_value);
2635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
264eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch
265eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  CheckPendingStateListUpdates("");
266eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch}
267eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch
268eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdochvoid ShillPropertyHandler::CheckPendingStateListUpdates(
269eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    const std::string& key) {
270eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  // Once there are no pending updates, signal the state list changed callbacks.
27168043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  if ((key.empty() || key == shill::kServicesProperty) &&
272eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      pending_updates_[ManagedState::MANAGED_TYPE_NETWORK].size() == 0) {
2732a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    listener_->ManagedStateListChanged(ManagedState::MANAGED_TYPE_NETWORK);
274eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  }
275eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  // Both Network update requests and Favorite update requests will affect
276eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  // the list of favorites, so wait for both to complete.
277eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  if ((key.empty() || key == shill::kServiceCompleteListProperty) &&
278eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      pending_updates_[ManagedState::MANAGED_TYPE_NETWORK].size() == 0 &&
279eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      pending_updates_[ManagedState::MANAGED_TYPE_FAVORITE].size() == 0) {
280eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    listener_->ManagedStateListChanged(ManagedState::MANAGED_TYPE_FAVORITE);
281eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  }
28268043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  if ((key.empty() || key == shill::kDevicesProperty) &&
283eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      pending_updates_[ManagedState::MANAGED_TYPE_DEVICE].size() == 0) {
2842a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    listener_->ManagedStateListChanged(ManagedState::MANAGED_TYPE_DEVICE);
285eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  }
2865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
2875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
288d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)void ShillPropertyHandler::ManagerPropertyChanged(const std::string& key,
2895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)                                                  const base::Value& value) {
29068043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  if (key == shill::kServicesProperty) {
2915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const base::ListValue* vlist = GetListValue(key, value);
2925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    if (vlist) {
293a93a17c8d99d686bd4a1511e5504e5e6cc9fcadfTorne (Richard Coles)      listener_->UpdateManagedList(ManagedState::MANAGED_TYPE_NETWORK, *vlist);
294eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      UpdateProperties(ManagedState::MANAGED_TYPE_NETWORK, *vlist);
295a93a17c8d99d686bd4a1511e5504e5e6cc9fcadfTorne (Richard Coles)      // UpdateObserved used to use kServiceWatchListProperty for TYPE_NETWORK,
296a93a17c8d99d686bd4a1511e5504e5e6cc9fcadfTorne (Richard Coles)      // however that prevents us from receiving Strength updates from inactive
297a93a17c8d99d686bd4a1511e5504e5e6cc9fcadfTorne (Richard Coles)      // networks. The overhead for observing all services is not unreasonable
298a93a17c8d99d686bd4a1511e5504e5e6cc9fcadfTorne (Richard Coles)      // (and we limit the max number of observed services to kMaxObserved).
2992a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      UpdateObserved(ManagedState::MANAGED_TYPE_NETWORK, *vlist);
3005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    }
301eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  } else if (key == shill::kServiceCompleteListProperty) {
3025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const ListValue* vlist = GetListValue(key, value);
3032a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    if (vlist) {
304eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      listener_->UpdateManagedList(ManagedState::MANAGED_TYPE_FAVORITE, *vlist);
305eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      UpdateProperties(ManagedState::MANAGED_TYPE_FAVORITE, *vlist);
306eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    }
30768043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  } else if (key == shill::kDevicesProperty) {
308eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    const base::ListValue* vlist = GetListValue(key, value);
309eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    if (vlist) {
3102a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      listener_->UpdateManagedList(ManagedState::MANAGED_TYPE_DEVICE, *vlist);
311eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      UpdateProperties(ManagedState::MANAGED_TYPE_DEVICE, *vlist);
3122a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      UpdateObserved(ManagedState::MANAGED_TYPE_DEVICE, *vlist);
3132a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    }
31468043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  } else if (key == shill::kAvailableTechnologiesProperty) {
3155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const base::ListValue* vlist = GetListValue(key, value);
316d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)    if (vlist)
3172a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      UpdateAvailableTechnologies(*vlist);
31868043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  } else if (key == shill::kEnabledTechnologiesProperty) {
3195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const base::ListValue* vlist = GetListValue(key, value);
320d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)    if (vlist)
3212a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      UpdateEnabledTechnologies(*vlist);
3222a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  } else if (key == shill::kUninitializedTechnologiesProperty) {
3232a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const base::ListValue* vlist = GetListValue(key, value);
324d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)    if (vlist)
3252a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      UpdateUninitializedTechnologies(*vlist);
32668043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  } else if (key == shill::kProfilesProperty) {
327c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    listener_->ProfileListChanged();
32868043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  } else if (key == shill::kCheckPortalListProperty) {
329868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)    std::string check_portal_list;
330d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)    if (value.GetAsString(&check_portal_list))
331868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)      listener_->CheckPortalListChanged(check_portal_list);
332eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  } else {
333eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    VLOG(2) << "Ignored Manager Property: " << key;
3345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
3355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
3365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
337eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdochvoid ShillPropertyHandler::UpdateProperties(ManagedState::ManagedType type,
338eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch                                            const base::ListValue& entries) {
339eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  std::set<std::string>& requested_updates = requested_updates_[type];
340eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  std::set<std::string>& requested_service_updates =
341eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      requested_updates_[ManagedState::MANAGED_TYPE_NETWORK];  // For favorites
342eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  std::set<std::string> new_requested_updates;
343eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  VLOG(2) << "Update Properties: " << type << " Entries: " << entries.GetSize();
344eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  for (base::ListValue::const_iterator iter = entries.begin();
345eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch       iter != entries.end(); ++iter) {
346eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    std::string path;
347eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    (*iter)->GetAsString(&path);
348eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    if (path.empty())
349eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      continue;
350eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    if (type == ManagedState::MANAGED_TYPE_FAVORITE &&
351eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch        requested_service_updates.count(path) > 0)
352eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      continue;  // Update already requested
353f2477e01787aa58f445919b809d89e252beef54fTorne (Richard Coles)
354f2477e01787aa58f445919b809d89e252beef54fTorne (Richard Coles)    // We add a special case for devices here to work around an issue in shill
355f2477e01787aa58f445919b809d89e252beef54fTorne (Richard Coles)    // that prevents it from sending property changed signals for cellular
356f2477e01787aa58f445919b809d89e252beef54fTorne (Richard Coles)    // devices (see crbug.com/321854).
357f2477e01787aa58f445919b809d89e252beef54fTorne (Richard Coles)    if (type == ManagedState::MANAGED_TYPE_DEVICE ||
358f2477e01787aa58f445919b809d89e252beef54fTorne (Richard Coles)        requested_updates.find(path) == requested_updates.end())
359eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      RequestProperties(type, path);
360eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    new_requested_updates.insert(path);
361eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  }
362eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  requested_updates.swap(new_requested_updates);
363eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch}
364eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch
3652a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)void ShillPropertyHandler::UpdateObserved(ManagedState::ManagedType type,
3662a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)                                          const base::ListValue& entries) {
367eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  DCHECK(type == ManagedState::MANAGED_TYPE_NETWORK ||
368eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch         type == ManagedState::MANAGED_TYPE_DEVICE);
3692a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  ShillPropertyObserverMap& observer_map =
3702a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      (type == ManagedState::MANAGED_TYPE_NETWORK)
3712a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      ? observed_networks_ : observed_devices_;
3722a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  ShillPropertyObserverMap new_observed;
3735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  for (base::ListValue::const_iterator iter1 = entries.begin();
3745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)       iter1 != entries.end(); ++iter1) {
3755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    std::string path;
3765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    (*iter1)->GetAsString(&path);
3775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    if (path.empty())
3785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      continue;
3792a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    ShillPropertyObserverMap::iterator iter2 = observer_map.find(path);
3802a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    if (iter2 != observer_map.end()) {
3812a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      new_observed[path] = iter2->second;
3825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    } else {
3832a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      // Create an observer for future updates.
3842a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      new_observed[path] = new ShillPropertyObserver(
3852a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)          type, path, base::Bind(
386c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)              &ShillPropertyHandler::PropertyChangedCallback, AsWeakPtr()));
3875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    }
3882a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    observer_map.erase(path);
3895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    // Limit the number of observed services.
3902a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    if (new_observed.size() >= kMaxObserved)
3915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)      break;
3925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
3932a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  // Delete network service observers still in observer_map.
3942a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  for (ShillPropertyObserverMap::iterator iter =  observer_map.begin();
3952a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)       iter != observer_map.end(); ++iter) {
3962a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    delete iter->second;
3972a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
3982a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  observer_map.swap(new_observed);
3992a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)}
4002a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
4012a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)void ShillPropertyHandler::UpdateAvailableTechnologies(
4022a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const base::ListValue& technologies) {
4032a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  available_technologies_.clear();
40490dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)  NET_LOG_EVENT("AvailableTechnologiesChanged",
405a36e5920737c6adbddd3e43b760e5de8431db6e0Torne (Richard Coles)                base::StringPrintf("Size: %" PRIuS, technologies.GetSize()));
4062a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  for (base::ListValue::const_iterator iter = technologies.begin();
4072a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)       iter != technologies.end(); ++iter) {
4082a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    std::string technology;
4092a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    (*iter)->GetAsString(&technology);
4102a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    DCHECK(!technology.empty());
4112a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    available_technologies_.insert(technology);
4122a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
413d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)  listener_->TechnologyListChanged();
4142a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)}
4152a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
4162a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)void ShillPropertyHandler::UpdateEnabledTechnologies(
4172a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const base::ListValue& technologies) {
4182a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  enabled_technologies_.clear();
41990dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)  NET_LOG_EVENT("EnabledTechnologiesChanged",
420a36e5920737c6adbddd3e43b760e5de8431db6e0Torne (Richard Coles)                base::StringPrintf("Size: %" PRIuS, technologies.GetSize()));
4212a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  for (base::ListValue::const_iterator iter = technologies.begin();
4222a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)       iter != technologies.end(); ++iter) {
4232a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    std::string technology;
4242a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    (*iter)->GetAsString(&technology);
4252a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    DCHECK(!technology.empty());
4262a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    enabled_technologies_.insert(technology);
427c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    enabling_technologies_.erase(technology);
4282a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
429d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)  listener_->TechnologyListChanged();
4302a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)}
4312a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
4322a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)void ShillPropertyHandler::UpdateUninitializedTechnologies(
4332a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const base::ListValue& technologies) {
4342a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  uninitialized_technologies_.clear();
43590dce4d38c5ff5333bea97d859d4e484e27edf0cTorne (Richard Coles)  NET_LOG_EVENT("UninitializedTechnologiesChanged",
436a36e5920737c6adbddd3e43b760e5de8431db6e0Torne (Richard Coles)                base::StringPrintf("Size: %" PRIuS, technologies.GetSize()));
4372a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  for (base::ListValue::const_iterator iter = technologies.begin();
4382a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)       iter != technologies.end(); ++iter) {
4392a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    std::string technology;
4402a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    (*iter)->GetAsString(&technology);
4412a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    DCHECK(!technology.empty());
4422a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    uninitialized_technologies_.insert(technology);
4432a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
444d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles)  listener_->TechnologyListChanged();
4455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
4465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
447c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)void ShillPropertyHandler::EnableTechnologyFailed(
448c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    const std::string& technology,
449c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    const network_handler::ErrorCallback& error_callback,
4507dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch    const std::string& dbus_error_name,
4517dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch    const std::string& dbus_error_message) {
452c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)  enabling_technologies_.erase(technology);
453c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)  network_handler::ShillErrorCallbackFunction(
4547dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch      "EnableTechnology Failed",
4557dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch      technology, error_callback,
4567dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch      dbus_error_name, dbus_error_message);
457c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)}
458c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)
4595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::GetPropertiesCallback(
4605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    ManagedState::ManagedType type,
4615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const std::string& path,
4625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    DBusMethodCallStatus call_status,
4635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const base::DictionaryValue& properties) {
4645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  VLOG(2) << "GetPropertiesCallback: " << type << " : " << path;
4652a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  pending_updates_[type].erase(path);
4665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  if (call_status != DBUS_METHOD_CALL_SUCCESS) {
46758537e28ecd584eab876aee8be7156509866d23aTorne (Richard Coles)    // The shill service no longer exists.  This can happen when a network
46858537e28ecd584eab876aee8be7156509866d23aTorne (Richard Coles)    // has been removed.
46958537e28ecd584eab876aee8be7156509866d23aTorne (Richard Coles)    NET_LOG_DEBUG("Failed to get properties",
470eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch                  base::StringPrintf("%s: %d", path.c_str(), call_status));
4715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    return;
4725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
473eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  // Update Favorite properties for networks in the Services list.
474eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  if (type == ManagedState::MANAGED_TYPE_NETWORK) {
4752385ea399aae016c0806a4f9ef3c9cfe3d2a39dfBen Murdoch    // Only networks with a ProfilePath set are Favorites.
4762385ea399aae016c0806a4f9ef3c9cfe3d2a39dfBen Murdoch    std::string profile_path;
4772385ea399aae016c0806a4f9ef3c9cfe3d2a39dfBen Murdoch    properties.GetStringWithoutPathExpansion(
47868043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)        shill::kProfileProperty, &profile_path);
4792385ea399aae016c0806a4f9ef3c9cfe3d2a39dfBen Murdoch    if (!profile_path.empty()) {
4802385ea399aae016c0806a4f9ef3c9cfe3d2a39dfBen Murdoch      listener_->UpdateManagedStateProperties(
4812385ea399aae016c0806a4f9ef3c9cfe3d2a39dfBen Murdoch          ManagedState::MANAGED_TYPE_FAVORITE, path, properties);
4822385ea399aae016c0806a4f9ef3c9cfe3d2a39dfBen Murdoch    }
483eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  }
4844e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles)  listener_->UpdateManagedStateProperties(type, path, properties);
485eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  // Request IPConfig parameters for networks.
486eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  if (type == ManagedState::MANAGED_TYPE_NETWORK &&
487eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      properties.HasKey(shill::kIPConfigProperty)) {
4882a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    std::string ip_config_path;
4892a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    if (properties.GetString(shill::kIPConfigProperty, &ip_config_path)) {
4902a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)      DBusThreadManager::Get()->GetShillIPConfigClient()->GetProperties(
4912a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)          dbus::ObjectPath(ip_config_path),
4922a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)          base::Bind(&ShillPropertyHandler::GetIPConfigCallback,
493c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)                     AsWeakPtr(), path));
4942a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    }
4952a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
4962a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
4975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  // Notify the listener only when all updates for that type have completed.
498eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  if (pending_updates_[type].size() == 0) {
4995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    listener_->ManagedStateListChanged(type);
500eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    // Notify that Favorites have changed when notifying for Networks if there
501eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    // are no additional Favorite updates pending.
502eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    if (type == ManagedState::MANAGED_TYPE_NETWORK &&
503eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch        pending_updates_[ManagedState::MANAGED_TYPE_FAVORITE].size() == 0) {
504eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch      listener_->ManagedStateListChanged(ManagedState::MANAGED_TYPE_FAVORITE);
505eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    }
506eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch  }
5075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
5085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
5092a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)void ShillPropertyHandler::PropertyChangedCallback(
5102a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    ManagedState::ManagedType type,
5112a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const std::string& path,
5122a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const std::string& key,
5132a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const base::Value& value) {
5142a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  if (type == ManagedState::MANAGED_TYPE_NETWORK)
5152a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    NetworkServicePropertyChangedCallback(path, key, value);
5162a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  else if (type == ManagedState::MANAGED_TYPE_DEVICE)
5172a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    NetworkDevicePropertyChangedCallback(path, key, value);
5182a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  else
5192a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    NOTREACHED();
5202a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)}
5212a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
5225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::NetworkServicePropertyChangedCallback(
5235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const std::string& path,
5245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const std::string& key,
5255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const base::Value& value) {
5262a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  if (key == shill::kIPConfigProperty) {
527c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    // Request the IPConfig for the network and update network properties
5282a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    // when the request completes.
5292a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    std::string ip_config_path;
5302a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    value.GetAsString(&ip_config_path);
5312a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    DCHECK(!ip_config_path.empty());
5322a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    DBusThreadManager::Get()->GetShillIPConfigClient()->GetProperties(
5332a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        dbus::ObjectPath(ip_config_path),
5342a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)        base::Bind(&ShillPropertyHandler::GetIPConfigCallback,
535c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)                   AsWeakPtr(), path));
5362a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  } else {
5372a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    listener_->UpdateNetworkServiceProperty(path, key, value);
5382a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  }
5395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
5405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
5415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void ShillPropertyHandler::GetIPConfigCallback(
5425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const std::string& service_path,
5435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    DBusMethodCallStatus call_status,
5445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    const base::DictionaryValue& properties)  {
5455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  if (call_status != DBUS_METHOD_CALL_SUCCESS) {
546eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch    NET_LOG_ERROR("Failed to get IP Config properties",
547eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch                  base::StringPrintf("%s: %d",
548eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch                                     service_path.c_str(), call_status));
5495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)    return;
5505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)  }
55168043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  UpdateIPConfigProperty(service_path, properties, shill::kAddressProperty);
55268043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  UpdateIPConfigProperty(service_path, properties, shill::kNameServersProperty);
55368043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  UpdateIPConfigProperty(service_path, properties, shill::kPrefixlenProperty);
55468043e1e95eeb07d5cae7aca370b26518b0867d6Torne (Richard Coles)  UpdateIPConfigProperty(service_path, properties, shill::kGatewayProperty);
5553551c9c881056c480085172ff9840cab31610854Torne (Richard Coles)  UpdateIPConfigProperty(service_path, properties,
5563551c9c881056c480085172ff9840cab31610854Torne (Richard Coles)                         shill::kWebProxyAutoDiscoveryUrlProperty);
5577dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch}
5587dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch
5597dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdochvoid ShillPropertyHandler::UpdateIPConfigProperty(
5607dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch    const std::string& service_path,
5617dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch    const base::DictionaryValue& properties,
5627dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch    const char* property) {
5637dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch  const base::Value* value;
5647dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch  if (!properties.GetWithoutPathExpansion(property, &value)) {
5657dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch    LOG(ERROR) << "Failed to get IPConfig property: " << property
5667dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch               << ", for: " << service_path;
567c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)    return;
568c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)  }
569c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)  listener_->UpdateNetworkServiceProperty(
5707dbb3d5cf0c15f500944d211057644d6a2f37371Ben Murdoch      service_path, NetworkState::IPConfigProperty(property), *value);
5715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}
5725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)
5732a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)void ShillPropertyHandler::NetworkDevicePropertyChangedCallback(
5742a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const std::string& path,
5752a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const std::string& key,
5762a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)    const base::Value& value) {
5772a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)  listener_->UpdateDeviceProperty(path, key, value);
5782a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)}
5792a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)
5805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}  // namespace internal
5815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}  // namespace chromeos
582