PRESUBMIT.py revision 58537e28ecd584eab876aee8be7156509866d23a
1# Copyright (c) 2012 The Chromium Authors. All rights reserved. 2# Use of this source code is governed by a BSD-style license that can be 3# found in the LICENSE file. 4 5"""Top-level presubmit script for isolate. 6 7See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 8details on the presubmit API built into gcl. 9""" 10 11 12def CommonChecks(input_api, output_api): 13 output = [] 14 disabled_warnings = [ 15 'F0401', # Unable to import module 16 'R0401', # Cyclic import 17 'W0613', # Unused argument 18 'E1103', # subprocess.communicate() generates these :( 19 'R0201', # method could be function (doesn't reference self) 20 ] 21 black_list = [ 22 r'src[\\\/]build_tools[\\\/]tests[\\\/].*', 23 r'src[\\\/]build_tools[\\\/]sdk_tools[\\\/]third_party[\\\/].*', 24 r'src[\\\/]doc[\\\/]*', 25 ] 26 canned = input_api.canned_checks 27 output.extend(canned.RunPylint(input_api, output_api, black_list=black_list, 28 disabled_warnings=disabled_warnings)) 29 return output 30 31 32def CheckChangeOnUpload(input_api, output_api): 33 return CommonChecks(input_api, output_api) 34 35 36def CheckChangeOnCommit(input_api, output_api): 37 return CommonChecks(input_api, output_api) 38 39 40def GetPreferredTrySlaves(project, change): 41 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk'] 42