12a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)// Copyright 2012 The Chromium Authors. All rights reserved. 25821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Use of this source code is governed by a BSD-style license that can be 35821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// found in the LICENSE file. 45821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 55821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/engine/syncer_util.h" 65821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 75821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include <algorithm> 85821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include <set> 95821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include <string> 105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include <vector> 115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 12c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)#include "base/base64.h" 135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/location.h" 145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/metrics/histogram.h" 15cedac228d2dd51db4b79ea1e72c7f249408ee061Torne (Richard Coles)#include "base/rand_util.h" 16868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles)#include "base/strings/string_number_conversions.h" 175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/engine/conflict_resolver.h" 185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/engine/syncer_proto_util.h" 195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/engine/syncer_types.h" 20116680a4aac90f2aa7413d9095a592090648e557Ben Murdoch#include "sync/internal_api/public/base/attachment_id_proto.h" 215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/internal_api/public/base/model_type.h" 22c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)#include "sync/internal_api/public/base/unique_position.h" 235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/protocol/bookmark_specifics.pb.h" 245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/protocol/password_specifics.pb.h" 255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/protocol/sync.pb.h" 265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/syncable/directory.h" 275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/syncable/entry.h" 284e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles)#include "sync/syncable/model_neutral_mutable_entry.h" 295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/syncable/mutable_entry.h" 305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/syncable/syncable_changes_version.h" 314e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles)#include "sync/syncable/syncable_model_neutral_write_transaction.h" 325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/syncable/syncable_proto_util.h" 332a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "sync/syncable/syncable_read_transaction.h" 345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/syncable/syncable_util.h" 352a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "sync/syncable/syncable_write_transaction.h" 365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/util/cryptographer.h" 375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "sync/util/time.h" 385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace syncer { 405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 41c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)using syncable::BASE_SERVER_SPECIFICS; 425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::BASE_VERSION; 435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::CHANGES_VERSION; 445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::CREATE_NEW_UPDATE_ITEM; 455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::CTIME; 465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::Directory; 475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::Entry; 485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::GET_BY_HANDLE; 495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::GET_BY_ID; 505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::ID; 515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::IS_DEL; 525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::IS_DIR; 535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::IS_UNAPPLIED_UPDATE; 545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::IS_UNSYNCED; 555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::Id; 565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::META_HANDLE; 575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::MTIME; 585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::MutableEntry; 595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::NON_UNIQUE_NAME; 605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::PARENT_ID; 615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SERVER_CTIME; 625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SERVER_IS_DEL; 635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SERVER_IS_DIR; 645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SERVER_MTIME; 655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SERVER_NON_UNIQUE_NAME; 665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SERVER_PARENT_ID; 675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SERVER_SPECIFICS; 68c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)using syncable::SERVER_UNIQUE_POSITION; 695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SERVER_VERSION; 705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SPECIFICS; 715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::SYNCER; 72c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)using syncable::UNIQUE_BOOKMARK_TAG; 73c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)using syncable::UNIQUE_CLIENT_TAG; 74c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)using syncable::UNIQUE_POSITION; 75c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)using syncable::UNIQUE_SERVER_TAG; 765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)using syncable::WriteTransaction; 775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)syncable::Id FindLocalIdToUpdate( 795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::BaseTransaction* trans, 805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const sync_pb::SyncEntity& update) { 815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Expected entry points of this function: 825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // SyncEntity has NOT been applied to SERVER fields. 835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // SyncEntity has NOT been applied to LOCAL fields. 845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // DB has not yet been modified, no entries created for this update. 855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const std::string& client_id = trans->directory()->cache_guid(); 875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const syncable::Id& update_id = SyncableIdFromProto(update.id_string()); 885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (update.has_client_defined_unique_tag() && 905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) !update.client_defined_unique_tag().empty()) { 915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // When a server sends down a client tag, the following cases can occur: 925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // 1) Client has entry for tag already, ID is server style, matches 935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // 2) Client has entry for tag already, ID is server, doesn't match. 945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // 3) Client has entry for tag already, ID is local, (never matches) 955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // 4) Client has no entry for tag 965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Case 1, we don't have to do anything since the update will 985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // work just fine. Update will end up in the proper entry, via ID lookup. 995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Case 2 - Happens very rarely due to lax enforcement of client tags 1005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // on the server, if two clients commit the same tag at the same time. 1015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // When this happens, we pick the lexically-least ID and ignore all other 1025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // items. 1035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Case 3 - We need to replace the local ID with the server ID so that 1045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // this update gets targeted at the correct local entry; we expect conflict 1055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // resolution to occur. 1065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Case 4 - Perfect. Same as case 1. 1075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::Entry local_entry(trans, syncable::GET_BY_CLIENT_TAG, 1095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) update.client_defined_unique_tag()); 1105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // The SyncAPI equivalent of this function will return !good if IS_DEL. 1125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // The syncable version will return good even if IS_DEL. 1135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // TODO(chron): Unit test the case with IS_DEL and make sure. 1145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (local_entry.good()) { 115d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (local_entry.GetId().ServerKnows()) { 116d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (local_entry.GetId() != update_id) { 1175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Case 2. 1185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(WARNING) << "Duplicated client tag."; 119d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (local_entry.GetId() < update_id) { 1205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Signal an error; drop this update on the floor. Note that 1215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // we don't server delete the item, because we don't allow it to 1225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // exist locally at all. So the item will remain orphaned on 1235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the server, and we won't pay attention to it. 1245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return syncable::GetNullId(); 1255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Target this change to the existing local entry; later, 1285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // we'll change the ID of the local entry to update_id 1295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // if needed. 130d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) return local_entry.GetId(); 1315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } else { 1325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Case 3: We have a local entry with the same client tag. 1335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // We should change the ID of the local entry to the server entry. 1345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // This will result in an server ID with base version == 0, but that's 1355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // a legal state for an item with a client tag. By changing the ID, 1365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // update will now be applied to local_entry. 137d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) DCHECK(0 == local_entry.GetBaseVersion() || 138d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) CHANGES_VERSION == local_entry.GetBaseVersion()); 139d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) return local_entry.GetId(); 1405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } else if (update.has_originator_cache_guid() && 1435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) update.originator_cache_guid() == client_id) { 1445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // If a commit succeeds, but the response does not come back fast enough 1455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // then the syncer might assume that it was never committed. 1465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // The server will track the client that sent up the original commit and 1475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // return this in a get updates response. When this matches a local 1485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // uncommitted item, we must mutate our local item and version to pick up 1495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the committed version of the same item whose commit response was lost. 1505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // There is however still a race condition if the server has not 1515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // completed the commit by the time the syncer tries to get updates 1525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // again. To mitigate this, we need to have the server time out in 1535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // a reasonable span, our commit batches have to be small enough 1545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // to process within our HTTP response "assumed alive" time. 1555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // We need to check if we have an entry that didn't get its server 1575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // id updated correctly. The server sends down a client ID 1585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // and a local (negative) id. If we have a entry by that 1595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // description, we should update the ID and version to the 1605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // server side ones to avoid multiple copies of the same thing. 1615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::Id client_item_id = syncable::Id::CreateFromClientString( 1635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) update.originator_client_item_id()); 1645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DCHECK(!client_item_id.ServerKnows()); 1655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::Entry local_entry(trans, GET_BY_ID, client_item_id); 1665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // If it exists, then our local client lost a commit response. Use 1685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the local entry. 169d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (local_entry.good() && !local_entry.GetIsDel()) { 170d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) int64 old_version = local_entry.GetBaseVersion(); 1715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int64 new_version = update.version(); 1725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DCHECK_LE(old_version, 0); 1735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DCHECK_GT(new_version, 0); 1745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Otherwise setting the base version could cause a consistency failure. 1755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // An entry should never be version 0 and SYNCED. 176d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) DCHECK(local_entry.GetIsUnsynced()); 1775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Just a quick sanity check. 179d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) DCHECK(!local_entry.GetId().ServerKnows()); 1805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(1) << "Reuniting lost commit response IDs. server id: " 182d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) << update_id << " local id: " << local_entry.GetId() 1835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << " new version: " << new_version; 1845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 185d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) return local_entry.GetId(); 1865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Fallback: target an entry having the server ID, creating one if needed. 1895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return update_id; 1905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 1915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)UpdateAttemptResponse AttemptToUpdateEntry( 1935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::WriteTransaction* const trans, 1945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::MutableEntry* const entry, 1955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) Cryptographer* cryptographer) { 1965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) CHECK(entry->good()); 197d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (!entry->GetIsUnappliedUpdate()) 1985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return SUCCESS; // No work to do. 199d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) syncable::Id id = entry->GetId(); 200d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) const sync_pb::EntitySpecifics& specifics = entry->GetServerSpecifics(); 2015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Only apply updates that we can decrypt. If we can't decrypt the update, it 2035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // is likely because the passphrase has not arrived yet. Because the 2045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // passphrase may not arrive within this GetUpdates, we can't just return 2055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // conflict, else we try to perform normal conflict resolution prematurely or 2065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the syncer may get stuck. As such, we return CONFLICT_ENCRYPTION, which is 2075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // treated as an unresolvable conflict. See the description in syncer_types.h. 2085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // This prevents any unsynced changes from commiting and postpones conflict 2095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // resolution until all data can be decrypted. 2105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (specifics.has_encrypted() && 2115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) !cryptographer->CanDecrypt(specifics.encrypted())) { 2125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // We can't decrypt this node yet. 2135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(1) << "Received an undecryptable " 2145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << ModelTypeToString(entry->GetServerModelType()) 2152a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) << " update, returning conflict_encryption."; 2165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return CONFLICT_ENCRYPTION; 2175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } else if (specifics.has_password() && 218d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->GetUniqueServerTag().empty()) { 2195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Passwords use their own legacy encryption scheme. 2205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const sync_pb::PasswordSpecifics& password = specifics.password(); 2215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (!cryptographer->CanDecrypt(password.encrypted())) { 2225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(1) << "Received an undecryptable password update, returning " 2232a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) << "conflict_encryption."; 2245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return CONFLICT_ENCRYPTION; 2255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 2265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 2275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 228d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (!entry->GetServerIsDel()) { 229d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) syncable::Id new_parent = entry->GetServerParentId(); 2305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) Entry parent(trans, GET_BY_ID, new_parent); 2315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // A note on non-directory parents: 2325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // We catch most unfixable tree invariant errors at update receipt time, 2335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // however we deal with this case here because we may receive the child 2345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // first then the illegal parent. Instead of dealing with it twice in 2355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // different ways we deal with it once here to reduce the amount of code and 2365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // potential errors. 237d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (!parent.good() || parent.GetIsDel() || !parent.GetIsDir()) { 2382a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) DVLOG(1) << "Entry has bad parent, returning conflict_hierarchy."; 2395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return CONFLICT_HIERARCHY; 2405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 241d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (entry->GetParentId() != new_parent) { 242d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (!entry->GetIsDel() && !IsLegalNewParent(trans, id, new_parent)) { 2435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(1) << "Not updating item " << id 2445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << ", illegal new parent (would cause loop)."; 2455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return CONFLICT_HIERARCHY; 2465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 2475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 248d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) } else if (entry->GetIsDir()) { 249868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles) Directory::Metahandles handles; 2505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) trans->directory()->GetChildHandlesById(trans, id, &handles); 2515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (!handles.empty()) { 2525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // If we have still-existing children, then we need to deal with 2535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // them before we can process this change. 2545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(1) << "Not deleting directory; it's not empty " << *entry; 2555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return CONFLICT_HIERARCHY; 2565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 2575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 2585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 259d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (entry->GetIsUnsynced()) { 2605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(1) << "Skipping update, returning conflict for: " << id 2615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << " ; it's unsynced."; 2625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return CONFLICT_SIMPLE; 2635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 2645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (specifics.has_encrypted()) { 2665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(2) << "Received a decryptable " 2675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << ModelTypeToString(entry->GetServerModelType()) 2685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << " update, applying normally."; 2695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } else { 2705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(2) << "Received an unencrypted " 2715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << ModelTypeToString(entry->GetServerModelType()) 2725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << " update, applying normally."; 2735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 2745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) UpdateLocalDataFromServerData(trans, entry); 2765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return SUCCESS; 2785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 2795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 280c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)std::string GetUniqueBookmarkTagFromUpdate(const sync_pb::SyncEntity& update) { 281c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) if (!update.has_originator_cache_guid() || 282c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) !update.has_originator_client_item_id()) { 283cedac228d2dd51db4b79ea1e72c7f249408ee061Torne (Richard Coles) LOG(ERROR) << "Update is missing requirements for bookmark position." 284cedac228d2dd51db4b79ea1e72c7f249408ee061Torne (Richard Coles) << " This is a server bug."; 285cedac228d2dd51db4b79ea1e72c7f249408ee061Torne (Richard Coles) return UniquePosition::RandomSuffix(); 286c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 287c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 288c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) return syncable::GenerateSyncableBookmarkHash( 289c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) update.originator_cache_guid(), update.originator_client_item_id()); 290c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)} 291c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 292c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)UniquePosition GetUpdatePosition(const sync_pb::SyncEntity& update, 293c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const std::string& suffix) { 294c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) DCHECK(UniquePosition::IsValidSuffix(suffix)); 295c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) if (!(SyncerProtoUtil::ShouldMaintainPosition(update))) { 296c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) return UniquePosition::CreateInvalid(); 297c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } else if (update.has_unique_position()) { 298c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) return UniquePosition::FromProto(update.unique_position()); 299c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } else if (update.has_position_in_parent()) { 300c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) return UniquePosition::FromInt64(update.position_in_parent(), suffix); 301c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } else { 302cedac228d2dd51db4b79ea1e72c7f249408ee061Torne (Richard Coles) LOG(ERROR) << "No position information in update. This is a server bug."; 303cedac228d2dd51db4b79ea1e72c7f249408ee061Torne (Richard Coles) return UniquePosition::FromInt64(0, suffix); 304c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 305c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)} 306c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 3075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace { 308c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 3095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Helper to synthesize a new-style sync_pb::EntitySpecifics for use locally, 3105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// when the server speaks only the old sync_pb::SyncEntity_BookmarkData-based 3115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// protocol. 3125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void UpdateBookmarkSpecifics(const std::string& singleton_tag, 3135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const std::string& url, 3145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const std::string& favicon_bytes, 3154e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::ModelNeutralMutableEntry* local_entry) { 3165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // In the new-style protocol, the server no longer sends bookmark info for 3175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the "google_chrome" folder. Mimic that here. 3185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (singleton_tag == "google_chrome") 3195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return; 3205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sync_pb::EntitySpecifics pb; 3215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sync_pb::BookmarkSpecifics* bookmark = pb.mutable_bookmark(); 3225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (!url.empty()) 3235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) bookmark->set_url(url); 3245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (!favicon_bytes.empty()) 3255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) bookmark->set_favicon(favicon_bytes); 326d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) local_entry->PutServerSpecifics(pb); 3275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 3285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 3294e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles)void UpdateBookmarkPositioning( 3304e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) const sync_pb::SyncEntity& update, 3314e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::ModelNeutralMutableEntry* local_entry) { 332c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Update our unique bookmark tag. In many cases this will be identical to 333c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // the tag we already have. However, clients that have recently upgraded to 334c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // versions that support unique positions will have incorrect tags. See the 335c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // v86 migration logic in directory_backing_store.cc for more information. 336c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // 337c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Both the old and new values are unique to this element. Applying this 338c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // update will not risk the creation of conflicting unique tags. 339c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) std::string bookmark_tag = GetUniqueBookmarkTagFromUpdate(update); 340c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) if (UniquePosition::IsValidSuffix(bookmark_tag)) { 341c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) local_entry->PutUniqueBookmarkTag(bookmark_tag); 342c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 343c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 344c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Update our position. 345c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) UniquePosition update_pos = 346d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) GetUpdatePosition(update, local_entry->GetUniqueBookmarkTag()); 347c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) if (update_pos.IsValid()) { 348d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) local_entry->PutServerUniquePosition(update_pos); 349c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 350c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)} 351c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 3525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} // namespace 3535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 3545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void UpdateServerFieldsFromUpdate( 3554e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::ModelNeutralMutableEntry* target, 3565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const sync_pb::SyncEntity& update, 3575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const std::string& name) { 3585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (update.deleted()) { 359d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (target->GetServerIsDel()) { 3605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // If we already think the item is server-deleted, we're done. 3615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Skipping these cases prevents our committed deletions from coming 3625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // back and overriding subsequent undeletions. For non-deleted items, 3635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the version number check has a similar effect. 3645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return; 3655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 3665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // The server returns very lightweight replies for deletions, so we don't 3675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // clobber a bunch of fields on delete. 368d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerIsDel(true); 369d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (!target->GetUniqueClientTag().empty()) { 3705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Items identified by the client unique tag are undeletable; when 3715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // they're deleted, they go back to version 0. 372d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerVersion(0); 3735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } else { 3745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Otherwise, fake a server version by bumping the local number. 375d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerVersion( 376d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) std::max(target->GetServerVersion(), target->GetBaseVersion()) + 1); 3775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 378d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutIsUnappliedUpdate(true); 3795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return; 3805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 3815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 382d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) DCHECK_EQ(target->GetId(), SyncableIdFromProto(update.id_string())) 3835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << "ID Changing not supported here"; 384d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerParentId(SyncableIdFromProto(update.parent_id_string())); 385d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerNonUniqueName(name); 386d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerVersion(update.version()); 387d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerCtime(ProtoTimeToTime(update.ctime())); 388d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerMtime(ProtoTimeToTime(update.mtime())); 389d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerIsDir(IsFolder(update)); 3905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (update.has_server_defined_unique_tag()) { 3915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const std::string& tag = update.server_defined_unique_tag(); 392d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutUniqueServerTag(tag); 3935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 3945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (update.has_client_defined_unique_tag()) { 3955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const std::string& tag = update.client_defined_unique_tag(); 396d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutUniqueClientTag(tag); 3975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 3985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Store the datatype-specific part as a protobuf. 3995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (update.has_specifics()) { 4005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DCHECK_NE(GetModelType(update), UNSPECIFIED) 4015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << "Storing unrecognized datatype in sync database."; 402d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerSpecifics(update.specifics()); 4035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } else if (update.has_bookmarkdata()) { 4045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Legacy protocol response for bookmark data. 4055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const sync_pb::SyncEntity::BookmarkData& bookmark = update.bookmarkdata(); 4065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) UpdateBookmarkSpecifics(update.server_defined_unique_tag(), 4075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) bookmark.bookmark_url(), 4085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) bookmark.bookmark_favicon(), 4095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) target); 4105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 411116680a4aac90f2aa7413d9095a592090648e557Ben Murdoch target->PutServerAttachmentMetadata( 412116680a4aac90f2aa7413d9095a592090648e557Ben Murdoch CreateAttachmentMetadata(update.attachment_id())); 413c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) if (SyncerProtoUtil::ShouldMaintainPosition(update)) { 414c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) UpdateBookmarkPositioning(update, target); 415c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 4165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 417d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerIsDel(update.deleted()); 4185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // We only mark the entry as unapplied if its version is greater than the 4195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // local data. If we're processing the update that corresponds to one of our 4205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // commit we don't apply it as time differences may occur. 421d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (update.version() > target->GetBaseVersion()) { 422d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutIsUnappliedUpdate(true); 4235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 4245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 4255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 4265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Creates a new Entry iff no Entry exists with the given id. 4274e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles)void CreateNewEntry(syncable::ModelNeutralWriteTransaction *trans, 4285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const syncable::Id& id) { 4294e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::Entry entry(trans, GET_BY_ID, id); 4305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (!entry.good()) { 4314e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::ModelNeutralMutableEntry new_entry( 4324e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) trans, 4334e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::CREATE_NEW_UPDATE_ITEM, 4344e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) id); 4355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 4365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 4375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 4385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// This function is called on an entry when we can update the user-facing data 4395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// from the server data. 4405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void UpdateLocalDataFromServerData( 4415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::WriteTransaction* trans, 4425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::MutableEntry* entry) { 443d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) DCHECK(!entry->GetIsUnsynced()); 444d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) DCHECK(entry->GetIsUnappliedUpdate()); 4455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 4465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(2) << "Updating entry : " << *entry; 4475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Start by setting the properties that determine the model_type. 448d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutSpecifics(entry->GetServerSpecifics()); 4495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Clear the previous server specifics now that we're applying successfully. 450d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutBaseServerSpecifics(sync_pb::EntitySpecifics()); 451d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutIsDir(entry->GetServerIsDir()); 4525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // This strange dance around the IS_DEL flag avoids problems when setting 4535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the name. 4545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // TODO(chron): Is this still an issue? Unit test this codepath. 455d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (entry->GetServerIsDel()) { 456d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutIsDel(true); 4575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } else { 458d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutNonUniqueName(entry->GetServerNonUniqueName()); 459d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutParentId(entry->GetServerParentId()); 460d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutUniquePosition(entry->GetServerUniquePosition()); 461d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutIsDel(false); 4625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 4635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 464d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutCtime(entry->GetServerCtime()); 465d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutMtime(entry->GetServerMtime()); 466d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutBaseVersion(entry->GetServerVersion()); 467d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutIsDel(entry->GetServerIsDel()); 468d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry->PutIsUnappliedUpdate(false); 469116680a4aac90f2aa7413d9095a592090648e557Ben Murdoch entry->PutAttachmentMetadata(entry->GetServerAttachmentMetadata()); 4705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 4715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 4725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)VerifyCommitResult ValidateCommitEntry(syncable::Entry* entry) { 473d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) syncable::Id id = entry->GetId(); 474d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (id == entry->GetParentId()) { 4755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) CHECK(id.IsRoot()) << "Non-root item is self parenting." << *entry; 4765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // If the root becomes unsynced it can cause us problems. 4775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(ERROR) << "Root item became unsynced " << *entry; 4785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_UNSYNCABLE; 4795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 4805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (entry->IsRoot()) { 4815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(ERROR) << "Permanent item became unsynced " << *entry; 4825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_UNSYNCABLE; 4835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 484d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (entry->GetIsDel() && !entry->GetId().ServerKnows()) { 4855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Drop deleted uncommitted entries. 4865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_UNSYNCABLE; 4875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 4885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_OK; 4895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 4905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 4915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void MarkDeletedChildrenSynced( 4925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::Directory* dir, 4934e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::BaseWriteTransaction* trans, 4945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) std::set<syncable::Id>* deleted_folders) { 4955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // There's two options here. 4965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // 1. Scan deleted unsynced entries looking up their pre-delete tree for any 4975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // of the deleted folders. 4985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // 2. Take each folder and do a tree walk of all entries underneath it. 4995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // #2 has a lower big O cost, but writing code to limit the time spent inside 5005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the transaction during each step is simpler with 1. Changing this decision 5015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // may be sensible if this code shows up in profiling. 5025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (deleted_folders->empty()) 5035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return; 504868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles) Directory::Metahandles handles; 5054e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) dir->GetUnsyncedMetaHandles(trans, &handles); 5065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (handles.empty()) 5075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return; 508868fa2fe829687343ffae624259930155e16dbd8Torne (Richard Coles) Directory::Metahandles::iterator it; 5095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (it = handles.begin() ; it != handles.end() ; ++it) { 5104e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::ModelNeutralMutableEntry entry(trans, GET_BY_HANDLE, *it); 511d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (!entry.GetIsUnsynced() || !entry.GetIsDel()) 5125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) continue; 513d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) syncable::Id id = entry.GetParentId(); 5144e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) while (id != trans->root_id()) { 5155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (deleted_folders->find(id) != deleted_folders->end()) { 5165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // We've synced the deletion of this deleted entries parent. 517d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) entry.PutIsUnsynced(false); 5185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) break; 5195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5204e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) Entry parent(trans, GET_BY_ID, id); 521d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (!parent.good() || !parent.GetIsDel()) 5225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) break; 523d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) id = parent.GetParentId(); 5245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 5275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 5285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)VerifyResult VerifyNewEntry( 5295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const sync_pb::SyncEntity& update, 5305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncable::Entry* target, 5315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const bool deleted) { 5325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (target->good()) { 5335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Not a new update. 5345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_UNDECIDED; 5355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (deleted) { 5375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Deletion of an item we've never seen can be ignored. 5385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SKIP; 5395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 5415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SUCCESS; 5425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 5435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 5445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Assumes we have an existing entry; check here for updates that break 5455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// consistency rules. 5465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)VerifyResult VerifyUpdateConsistency( 5474e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::ModelNeutralWriteTransaction* trans, 5485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const sync_pb::SyncEntity& update, 5495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const bool deleted, 5505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const bool is_directory, 5514e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) ModelType model_type, 5524e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::ModelNeutralMutableEntry* target) { 5535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 5545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) CHECK(target->good()); 5555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const syncable::Id& update_id = SyncableIdFromProto(update.id_string()); 5565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 5575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // If the update is a delete, we don't really need to worry at this stage. 5585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (deleted) 5595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SUCCESS; 5605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 5615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (model_type == UNSPECIFIED) { 5625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // This update is to an item of a datatype we don't recognize. The server 5635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // shouldn't have sent it to us. Throw it on the ground. 5645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SKIP; 5655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 567d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (target->GetServerVersion() > 0) { 5685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Then we've had an update for this entry before. 569d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (is_directory != target->GetServerIsDir() || 5705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) model_type != target->GetServerModelType()) { 571d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (target->GetIsDel()) { // If we've deleted the item, we don't care. 5725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SKIP; 5735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } else { 5745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(ERROR) << "Server update doesn't agree with previous updates. "; 5755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(ERROR) << " Entry: " << *target; 5765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(ERROR) << " Update: " 5775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << SyncerProtoUtil::SyncEntityDebugString(update); 5785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_FAIL; 5795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 582d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (!deleted && (target->GetId() == update_id) && 583d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) (target->GetServerIsDel() || 584d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) (!target->GetIsUnsynced() && target->GetIsDel() && 585d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->GetBaseVersion() > 0))) { 5865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // An undelete. The latter case in the above condition is for 5875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // when the server does not give us an update following the 5885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // commit of a delete, before undeleting. 5895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Undeletion is common for items that reuse the client-unique tag. 5905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) VerifyResult result = VerifyUndelete(trans, update, target); 5915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (VERIFY_UNDECIDED != result) 5925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return result; 5935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 5945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 595d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (target->GetBaseVersion() > 0) { 5965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // We've committed this update in the past. 597d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (is_directory != target->GetIsDir() || 5985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) model_type != target->GetModelType()) { 5995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(ERROR) << "Server update doesn't agree with committed item. "; 6005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(ERROR) << " Entry: " << *target; 6015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(ERROR) << " Update: " 6025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << SyncerProtoUtil::SyncEntityDebugString(update); 6035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_FAIL; 6045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 605d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (target->GetId() == update_id) { 606d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (target->GetServerVersion() > update.version()) { 6075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(WARNING) << "We've already seen a more recent version."; 6085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(WARNING) << " Entry: " << *target; 6095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(WARNING) << " Update: " 6105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << SyncerProtoUtil::SyncEntityDebugString(update); 6115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SKIP; 6125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 6135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 6145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 6155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SUCCESS; 6165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 6175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 6185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Assumes we have an existing entry; verify an update that seems to be 6195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// expressing an 'undelete' 6204e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles)VerifyResult VerifyUndelete(syncable::ModelNeutralWriteTransaction* trans, 6215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const sync_pb::SyncEntity& update, 6224e180b6a0b4720a9b8e9e959a882386f690f08ffTorne (Richard Coles) syncable::ModelNeutralMutableEntry* target) { 6235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // TODO(nick): We hit this path for items deleted items that the server 6245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // tells us to re-create; only deleted items with positive base versions 6255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // will hit this path. However, it's not clear how such an undeletion 6265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // would actually succeed on the server; in the protocol, a base 6275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // version of 0 is required to undelete an object. This codepath 6285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // should be deprecated in favor of client-tag style undeletion 6295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // (where items go to version 0 when they're deleted), or else 6305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // removed entirely (if this type of undeletion is indeed impossible). 6315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) CHECK(target->good()); 6325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) DVLOG(1) << "Server update is attempting undelete. " << *target 6335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << "Update:" << SyncerProtoUtil::SyncEntityDebugString(update); 6345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Move the old one aside and start over. It's too tricky to get the old one 6355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // back into a state that would pass CheckTreeInvariants(). 636d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (target->GetIsDel()) { 637d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (target->GetUniqueClientTag().empty()) 638c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) LOG(WARNING) << "Doing move-aside undeletion on client-tagged item."; 639d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutId(trans->directory()->NextId()); 640d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutUniqueClientTag(std::string()); 641d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutBaseVersion(CHANGES_VERSION); 642d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) target->PutServerVersion(0); 6435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SUCCESS; 6445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 645d0247b1b59f9c528cb6df88b4f2b9afaf80d181eTorne (Richard Coles) if (update.version() < target->GetServerVersion()) { 6465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) LOG(WARNING) << "Update older than current server version for " 6475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << *target << " Update:" 6485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << SyncerProtoUtil::SyncEntityDebugString(update); 6495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_SUCCESS; // Expected in new sync protocol. 6505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 6515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return VERIFY_UNDECIDED; 6525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 6535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 6545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} // namespace syncer 655