SemaChecking.cpp revision 4f611fa1eb5b57ae66465cfeb73f14b18b4d4446
1//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3//                     The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10//  This file implements extra semantic analysis beyond what is enforced
11//  by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
15#include "Sema.h"
16#include "clang/Analysis/CFG.h"
17#include "clang/Analysis/AnalysisContext.h"
18#include "clang/Analysis/Analyses/PrintfFormatString.h"
19#include "clang/AST/ASTContext.h"
20#include "clang/AST/CharUnits.h"
21#include "clang/AST/DeclObjC.h"
22#include "clang/AST/ExprCXX.h"
23#include "clang/AST/ExprObjC.h"
24#include "clang/AST/DeclObjC.h"
25#include "clang/AST/StmtCXX.h"
26#include "clang/AST/StmtObjC.h"
27#include "clang/Lex/LiteralSupport.h"
28#include "clang/Lex/Preprocessor.h"
29#include "llvm/ADT/BitVector.h"
30#include "llvm/ADT/STLExtras.h"
31#include <limits>
32#include <queue>
33using namespace clang;
34
35/// getLocationOfStringLiteralByte - Return a source location that points to the
36/// specified byte of the specified string literal.
37///
38/// Strings are amazingly complex.  They can be formed from multiple tokens and
39/// can have escape sequences in them in addition to the usual trigraph and
40/// escaped newline business.  This routine handles this complexity.
41///
42SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
43                                                    unsigned ByteNo) const {
44  assert(!SL->isWide() && "This doesn't work for wide strings yet");
45
46  // Loop over all of the tokens in this string until we find the one that
47  // contains the byte we're looking for.
48  unsigned TokNo = 0;
49  while (1) {
50    assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
51    SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
52
53    // Get the spelling of the string so that we can get the data that makes up
54    // the string literal, not the identifier for the macro it is potentially
55    // expanded through.
56    SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
57
58    // Re-lex the token to get its length and original spelling.
59    std::pair<FileID, unsigned> LocInfo =
60      SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
61    std::pair<const char *,const char *> Buffer =
62      SourceMgr.getBufferData(LocInfo.first);
63    const char *StrData = Buffer.first+LocInfo.second;
64
65    // Create a langops struct and enable trigraphs.  This is sufficient for
66    // relexing tokens.
67    LangOptions LangOpts;
68    LangOpts.Trigraphs = true;
69
70    // Create a lexer starting at the beginning of this token.
71    Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.first, StrData,
72                   Buffer.second);
73    Token TheTok;
74    TheLexer.LexFromRawLexer(TheTok);
75
76    // Use the StringLiteralParser to compute the length of the string in bytes.
77    StringLiteralParser SLP(&TheTok, 1, PP);
78    unsigned TokNumBytes = SLP.GetStringLength();
79
80    // If the byte is in this token, return the location of the byte.
81    if (ByteNo < TokNumBytes ||
82        (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
83      unsigned Offset =
84        StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP);
85
86      // Now that we know the offset of the token in the spelling, use the
87      // preprocessor to get the offset in the original source.
88      return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
89    }
90
91    // Move to the next string token.
92    ++TokNo;
93    ByteNo -= TokNumBytes;
94  }
95}
96
97/// CheckablePrintfAttr - does a function call have a "printf" attribute
98/// and arguments that merit checking?
99bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) {
100  if (Format->getType() == "printf") return true;
101  if (Format->getType() == "printf0") {
102    // printf0 allows null "format" string; if so don't check format/args
103    unsigned format_idx = Format->getFormatIdx() - 1;
104    // Does the index refer to the implicit object argument?
105    if (isa<CXXMemberCallExpr>(TheCall)) {
106      if (format_idx == 0)
107        return false;
108      --format_idx;
109    }
110    if (format_idx < TheCall->getNumArgs()) {
111      Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts();
112      if (!Format->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNull))
113        return true;
114    }
115  }
116  return false;
117}
118
119Action::OwningExprResult
120Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
121  OwningExprResult TheCallResult(Owned(TheCall));
122
123  switch (BuiltinID) {
124  case Builtin::BI__builtin___CFStringMakeConstantString:
125    assert(TheCall->getNumArgs() == 1 &&
126           "Wrong # arguments to builtin CFStringMakeConstantString");
127    if (CheckObjCString(TheCall->getArg(0)))
128      return ExprError();
129    break;
130  case Builtin::BI__builtin_stdarg_start:
131  case Builtin::BI__builtin_va_start:
132    if (SemaBuiltinVAStart(TheCall))
133      return ExprError();
134    break;
135  case Builtin::BI__builtin_isgreater:
136  case Builtin::BI__builtin_isgreaterequal:
137  case Builtin::BI__builtin_isless:
138  case Builtin::BI__builtin_islessequal:
139  case Builtin::BI__builtin_islessgreater:
140  case Builtin::BI__builtin_isunordered:
141    if (SemaBuiltinUnorderedCompare(TheCall))
142      return ExprError();
143    break;
144  case Builtin::BI__builtin_isfinite:
145  case Builtin::BI__builtin_isinf:
146  case Builtin::BI__builtin_isinf_sign:
147  case Builtin::BI__builtin_isnan:
148  case Builtin::BI__builtin_isnormal:
149    if (SemaBuiltinUnaryFP(TheCall))
150      return ExprError();
151    break;
152  case Builtin::BI__builtin_return_address:
153  case Builtin::BI__builtin_frame_address:
154    if (SemaBuiltinStackAddress(TheCall))
155      return ExprError();
156    break;
157  case Builtin::BI__builtin_eh_return_data_regno:
158    if (SemaBuiltinEHReturnDataRegNo(TheCall))
159      return ExprError();
160    break;
161  case Builtin::BI__builtin_shufflevector:
162    return SemaBuiltinShuffleVector(TheCall);
163    // TheCall will be freed by the smart pointer here, but that's fine, since
164    // SemaBuiltinShuffleVector guts it, but then doesn't release it.
165  case Builtin::BI__builtin_prefetch:
166    if (SemaBuiltinPrefetch(TheCall))
167      return ExprError();
168    break;
169  case Builtin::BI__builtin_object_size:
170    if (SemaBuiltinObjectSize(TheCall))
171      return ExprError();
172    break;
173  case Builtin::BI__builtin_longjmp:
174    if (SemaBuiltinLongjmp(TheCall))
175      return ExprError();
176    break;
177  case Builtin::BI__sync_fetch_and_add:
178  case Builtin::BI__sync_fetch_and_sub:
179  case Builtin::BI__sync_fetch_and_or:
180  case Builtin::BI__sync_fetch_and_and:
181  case Builtin::BI__sync_fetch_and_xor:
182  case Builtin::BI__sync_fetch_and_nand:
183  case Builtin::BI__sync_add_and_fetch:
184  case Builtin::BI__sync_sub_and_fetch:
185  case Builtin::BI__sync_and_and_fetch:
186  case Builtin::BI__sync_or_and_fetch:
187  case Builtin::BI__sync_xor_and_fetch:
188  case Builtin::BI__sync_nand_and_fetch:
189  case Builtin::BI__sync_val_compare_and_swap:
190  case Builtin::BI__sync_bool_compare_and_swap:
191  case Builtin::BI__sync_lock_test_and_set:
192  case Builtin::BI__sync_lock_release:
193    if (SemaBuiltinAtomicOverloaded(TheCall))
194      return ExprError();
195    break;
196  }
197
198  return move(TheCallResult);
199}
200
201/// CheckFunctionCall - Check a direct function call for various correctness
202/// and safety properties not strictly enforced by the C type system.
203bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
204  // Get the IdentifierInfo* for the called function.
205  IdentifierInfo *FnInfo = FDecl->getIdentifier();
206
207  // None of the checks below are needed for functions that don't have
208  // simple names (e.g., C++ conversion functions).
209  if (!FnInfo)
210    return false;
211
212  // FIXME: This mechanism should be abstracted to be less fragile and
213  // more efficient. For example, just map function ids to custom
214  // handlers.
215
216  // Printf checking.
217  if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
218    if (CheckablePrintfAttr(Format, TheCall)) {
219      bool HasVAListArg = Format->getFirstArg() == 0;
220      if (!HasVAListArg) {
221        if (const FunctionProtoType *Proto
222            = FDecl->getType()->getAs<FunctionProtoType>())
223          HasVAListArg = !Proto->isVariadic();
224      }
225      CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
226                           HasVAListArg ? 0 : Format->getFirstArg() - 1);
227    }
228  }
229
230  for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull;
231       NonNull = NonNull->getNext<NonNullAttr>())
232    CheckNonNullArguments(NonNull, TheCall);
233
234  return false;
235}
236
237bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
238  // Printf checking.
239  const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
240  if (!Format)
241    return false;
242
243  const VarDecl *V = dyn_cast<VarDecl>(NDecl);
244  if (!V)
245    return false;
246
247  QualType Ty = V->getType();
248  if (!Ty->isBlockPointerType())
249    return false;
250
251  if (!CheckablePrintfAttr(Format, TheCall))
252    return false;
253
254  bool HasVAListArg = Format->getFirstArg() == 0;
255  if (!HasVAListArg) {
256    const FunctionType *FT =
257      Ty->getAs<BlockPointerType>()->getPointeeType()->getAs<FunctionType>();
258    if (const FunctionProtoType *Proto = dyn_cast<FunctionProtoType>(FT))
259      HasVAListArg = !Proto->isVariadic();
260  }
261  CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
262                       HasVAListArg ? 0 : Format->getFirstArg() - 1);
263
264  return false;
265}
266
267/// SemaBuiltinAtomicOverloaded - We have a call to a function like
268/// __sync_fetch_and_add, which is an overloaded function based on the pointer
269/// type of its first argument.  The main ActOnCallExpr routines have already
270/// promoted the types of arguments because all of these calls are prototyped as
271/// void(...).
272///
273/// This function goes through and does final semantic checking for these
274/// builtins,
275bool Sema::SemaBuiltinAtomicOverloaded(CallExpr *TheCall) {
276  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
277  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
278
279  // Ensure that we have at least one argument to do type inference from.
280  if (TheCall->getNumArgs() < 1)
281    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
282              << 0 << TheCall->getCallee()->getSourceRange();
283
284  // Inspect the first argument of the atomic builtin.  This should always be
285  // a pointer type, whose element is an integral scalar or pointer type.
286  // Because it is a pointer type, we don't have to worry about any implicit
287  // casts here.
288  Expr *FirstArg = TheCall->getArg(0);
289  if (!FirstArg->getType()->isPointerType())
290    return Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
291             << FirstArg->getType() << FirstArg->getSourceRange();
292
293  QualType ValType = FirstArg->getType()->getAs<PointerType>()->getPointeeType();
294  if (!ValType->isIntegerType() && !ValType->isPointerType() &&
295      !ValType->isBlockPointerType())
296    return Diag(DRE->getLocStart(),
297                diag::err_atomic_builtin_must_be_pointer_intptr)
298             << FirstArg->getType() << FirstArg->getSourceRange();
299
300  // We need to figure out which concrete builtin this maps onto.  For example,
301  // __sync_fetch_and_add with a 2 byte object turns into
302  // __sync_fetch_and_add_2.
303#define BUILTIN_ROW(x) \
304  { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
305    Builtin::BI##x##_8, Builtin::BI##x##_16 }
306
307  static const unsigned BuiltinIndices[][5] = {
308    BUILTIN_ROW(__sync_fetch_and_add),
309    BUILTIN_ROW(__sync_fetch_and_sub),
310    BUILTIN_ROW(__sync_fetch_and_or),
311    BUILTIN_ROW(__sync_fetch_and_and),
312    BUILTIN_ROW(__sync_fetch_and_xor),
313    BUILTIN_ROW(__sync_fetch_and_nand),
314
315    BUILTIN_ROW(__sync_add_and_fetch),
316    BUILTIN_ROW(__sync_sub_and_fetch),
317    BUILTIN_ROW(__sync_and_and_fetch),
318    BUILTIN_ROW(__sync_or_and_fetch),
319    BUILTIN_ROW(__sync_xor_and_fetch),
320    BUILTIN_ROW(__sync_nand_and_fetch),
321
322    BUILTIN_ROW(__sync_val_compare_and_swap),
323    BUILTIN_ROW(__sync_bool_compare_and_swap),
324    BUILTIN_ROW(__sync_lock_test_and_set),
325    BUILTIN_ROW(__sync_lock_release)
326  };
327#undef BUILTIN_ROW
328
329  // Determine the index of the size.
330  unsigned SizeIndex;
331  switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
332  case 1: SizeIndex = 0; break;
333  case 2: SizeIndex = 1; break;
334  case 4: SizeIndex = 2; break;
335  case 8: SizeIndex = 3; break;
336  case 16: SizeIndex = 4; break;
337  default:
338    return Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
339             << FirstArg->getType() << FirstArg->getSourceRange();
340  }
341
342  // Each of these builtins has one pointer argument, followed by some number of
343  // values (0, 1 or 2) followed by a potentially empty varags list of stuff
344  // that we ignore.  Find out which row of BuiltinIndices to read from as well
345  // as the number of fixed args.
346  unsigned BuiltinID = FDecl->getBuiltinID();
347  unsigned BuiltinIndex, NumFixed = 1;
348  switch (BuiltinID) {
349  default: assert(0 && "Unknown overloaded atomic builtin!");
350  case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
351  case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
352  case Builtin::BI__sync_fetch_and_or:  BuiltinIndex = 2; break;
353  case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
354  case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
355  case Builtin::BI__sync_fetch_and_nand:BuiltinIndex = 5; break;
356
357  case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 6; break;
358  case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 7; break;
359  case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 8; break;
360  case Builtin::BI__sync_or_and_fetch:  BuiltinIndex = 9; break;
361  case Builtin::BI__sync_xor_and_fetch: BuiltinIndex =10; break;
362  case Builtin::BI__sync_nand_and_fetch:BuiltinIndex =11; break;
363
364  case Builtin::BI__sync_val_compare_and_swap:
365    BuiltinIndex = 12;
366    NumFixed = 2;
367    break;
368  case Builtin::BI__sync_bool_compare_and_swap:
369    BuiltinIndex = 13;
370    NumFixed = 2;
371    break;
372  case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 14; break;
373  case Builtin::BI__sync_lock_release:
374    BuiltinIndex = 15;
375    NumFixed = 0;
376    break;
377  }
378
379  // Now that we know how many fixed arguments we expect, first check that we
380  // have at least that many.
381  if (TheCall->getNumArgs() < 1+NumFixed)
382    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
383            << 0 << TheCall->getCallee()->getSourceRange();
384
385
386  // Get the decl for the concrete builtin from this, we can tell what the
387  // concrete integer type we should convert to is.
388  unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
389  const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
390  IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
391  FunctionDecl *NewBuiltinDecl =
392    cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
393                                           TUScope, false, DRE->getLocStart()));
394  const FunctionProtoType *BuiltinFT =
395    NewBuiltinDecl->getType()->getAs<FunctionProtoType>();
396  ValType = BuiltinFT->getArgType(0)->getAs<PointerType>()->getPointeeType();
397
398  // If the first type needs to be converted (e.g. void** -> int*), do it now.
399  if (BuiltinFT->getArgType(0) != FirstArg->getType()) {
400    ImpCastExprToType(FirstArg, BuiltinFT->getArgType(0), CastExpr::CK_BitCast);
401    TheCall->setArg(0, FirstArg);
402  }
403
404  // Next, walk the valid ones promoting to the right type.
405  for (unsigned i = 0; i != NumFixed; ++i) {
406    Expr *Arg = TheCall->getArg(i+1);
407
408    // If the argument is an implicit cast, then there was a promotion due to
409    // "...", just remove it now.
410    if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
411      Arg = ICE->getSubExpr();
412      ICE->setSubExpr(0);
413      ICE->Destroy(Context);
414      TheCall->setArg(i+1, Arg);
415    }
416
417    // GCC does an implicit conversion to the pointer or integer ValType.  This
418    // can fail in some cases (1i -> int**), check for this error case now.
419    CastExpr::CastKind Kind = CastExpr::CK_Unknown;
420    CXXMethodDecl *ConversionDecl = 0;
421    if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind,
422                       ConversionDecl))
423      return true;
424
425    // Okay, we have something that *can* be converted to the right type.  Check
426    // to see if there is a potentially weird extension going on here.  This can
427    // happen when you do an atomic operation on something like an char* and
428    // pass in 42.  The 42 gets converted to char.  This is even more strange
429    // for things like 45.123 -> char, etc.
430    // FIXME: Do this check.
431    ImpCastExprToType(Arg, ValType, Kind, /*isLvalue=*/false);
432    TheCall->setArg(i+1, Arg);
433  }
434
435  // Switch the DeclRefExpr to refer to the new decl.
436  DRE->setDecl(NewBuiltinDecl);
437  DRE->setType(NewBuiltinDecl->getType());
438
439  // Set the callee in the CallExpr.
440  // FIXME: This leaks the original parens and implicit casts.
441  Expr *PromotedCall = DRE;
442  UsualUnaryConversions(PromotedCall);
443  TheCall->setCallee(PromotedCall);
444
445
446  // Change the result type of the call to match the result type of the decl.
447  TheCall->setType(NewBuiltinDecl->getResultType());
448  return false;
449}
450
451
452/// CheckObjCString - Checks that the argument to the builtin
453/// CFString constructor is correct
454/// FIXME: GCC currently emits the following warning:
455/// "warning: input conversion stopped due to an input byte that does not
456///           belong to the input codeset UTF-8"
457/// Note: It might also make sense to do the UTF-16 conversion here (would
458/// simplify the backend).
459bool Sema::CheckObjCString(Expr *Arg) {
460  Arg = Arg->IgnoreParenCasts();
461  StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
462
463  if (!Literal || Literal->isWide()) {
464    Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
465      << Arg->getSourceRange();
466    return true;
467  }
468
469  const char *Data = Literal->getStrData();
470  unsigned Length = Literal->getByteLength();
471
472  for (unsigned i = 0; i < Length; ++i) {
473    if (!Data[i]) {
474      Diag(getLocationOfStringLiteralByte(Literal, i),
475           diag::warn_cfstring_literal_contains_nul_character)
476        << Arg->getSourceRange();
477      break;
478    }
479  }
480
481  return false;
482}
483
484/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
485/// Emit an error and return true on failure, return false on success.
486bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
487  Expr *Fn = TheCall->getCallee();
488  if (TheCall->getNumArgs() > 2) {
489    Diag(TheCall->getArg(2)->getLocStart(),
490         diag::err_typecheck_call_too_many_args)
491      << 0 /*function call*/ << Fn->getSourceRange()
492      << SourceRange(TheCall->getArg(2)->getLocStart(),
493                     (*(TheCall->arg_end()-1))->getLocEnd());
494    return true;
495  }
496
497  if (TheCall->getNumArgs() < 2) {
498    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
499      << 0 /*function call*/;
500  }
501
502  // Determine whether the current function is variadic or not.
503  bool isVariadic;
504  if (CurBlock)
505    isVariadic = CurBlock->isVariadic;
506  else if (getCurFunctionDecl()) {
507    if (FunctionProtoType* FTP =
508            dyn_cast<FunctionProtoType>(getCurFunctionDecl()->getType()))
509      isVariadic = FTP->isVariadic();
510    else
511      isVariadic = false;
512  } else {
513    isVariadic = getCurMethodDecl()->isVariadic();
514  }
515
516  if (!isVariadic) {
517    Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
518    return true;
519  }
520
521  // Verify that the second argument to the builtin is the last argument of the
522  // current function or method.
523  bool SecondArgIsLastNamedArgument = false;
524  const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
525
526  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
527    if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
528      // FIXME: This isn't correct for methods (results in bogus warning).
529      // Get the last formal in the current function.
530      const ParmVarDecl *LastArg;
531      if (CurBlock)
532        LastArg = *(CurBlock->TheDecl->param_end()-1);
533      else if (FunctionDecl *FD = getCurFunctionDecl())
534        LastArg = *(FD->param_end()-1);
535      else
536        LastArg = *(getCurMethodDecl()->param_end()-1);
537      SecondArgIsLastNamedArgument = PV == LastArg;
538    }
539  }
540
541  if (!SecondArgIsLastNamedArgument)
542    Diag(TheCall->getArg(1)->getLocStart(),
543         diag::warn_second_parameter_of_va_start_not_last_named_argument);
544  return false;
545}
546
547/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
548/// friends.  This is declared to take (...), so we have to check everything.
549bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
550  if (TheCall->getNumArgs() < 2)
551    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
552      << 0 /*function call*/;
553  if (TheCall->getNumArgs() > 2)
554    return Diag(TheCall->getArg(2)->getLocStart(),
555                diag::err_typecheck_call_too_many_args)
556      << 0 /*function call*/
557      << SourceRange(TheCall->getArg(2)->getLocStart(),
558                     (*(TheCall->arg_end()-1))->getLocEnd());
559
560  Expr *OrigArg0 = TheCall->getArg(0);
561  Expr *OrigArg1 = TheCall->getArg(1);
562
563  // Do standard promotions between the two arguments, returning their common
564  // type.
565  QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
566
567  // Make sure any conversions are pushed back into the call; this is
568  // type safe since unordered compare builtins are declared as "_Bool
569  // foo(...)".
570  TheCall->setArg(0, OrigArg0);
571  TheCall->setArg(1, OrigArg1);
572
573  if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
574    return false;
575
576  // If the common type isn't a real floating type, then the arguments were
577  // invalid for this operation.
578  if (!Res->isRealFloatingType())
579    return Diag(OrigArg0->getLocStart(),
580                diag::err_typecheck_call_invalid_ordered_compare)
581      << OrigArg0->getType() << OrigArg1->getType()
582      << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
583
584  return false;
585}
586
587/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isnan and
588/// friends.  This is declared to take (...), so we have to check everything.
589bool Sema::SemaBuiltinUnaryFP(CallExpr *TheCall) {
590  if (TheCall->getNumArgs() < 1)
591    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
592      << 0 /*function call*/;
593  if (TheCall->getNumArgs() > 1)
594    return Diag(TheCall->getArg(1)->getLocStart(),
595                diag::err_typecheck_call_too_many_args)
596      << 0 /*function call*/
597      << SourceRange(TheCall->getArg(1)->getLocStart(),
598                     (*(TheCall->arg_end()-1))->getLocEnd());
599
600  Expr *OrigArg = TheCall->getArg(0);
601
602  if (OrigArg->isTypeDependent())
603    return false;
604
605  // This operation requires a floating-point number
606  if (!OrigArg->getType()->isRealFloatingType())
607    return Diag(OrigArg->getLocStart(),
608                diag::err_typecheck_call_invalid_unary_fp)
609      << OrigArg->getType() << OrigArg->getSourceRange();
610
611  return false;
612}
613
614bool Sema::SemaBuiltinStackAddress(CallExpr *TheCall) {
615  // The signature for these builtins is exact; the only thing we need
616  // to check is that the argument is a constant.
617  SourceLocation Loc;
618  if (!TheCall->getArg(0)->isTypeDependent() &&
619      !TheCall->getArg(0)->isValueDependent() &&
620      !TheCall->getArg(0)->isIntegerConstantExpr(Context, &Loc))
621    return Diag(Loc, diag::err_stack_const_level) << TheCall->getSourceRange();
622
623  return false;
624}
625
626/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
627// This is declared to take (...), so we have to check everything.
628Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
629  if (TheCall->getNumArgs() < 3)
630    return ExprError(Diag(TheCall->getLocEnd(),
631                          diag::err_typecheck_call_too_few_args)
632      << 0 /*function call*/ << TheCall->getSourceRange());
633
634  unsigned numElements = std::numeric_limits<unsigned>::max();
635  if (!TheCall->getArg(0)->isTypeDependent() &&
636      !TheCall->getArg(1)->isTypeDependent()) {
637    QualType FAType = TheCall->getArg(0)->getType();
638    QualType SAType = TheCall->getArg(1)->getType();
639
640    if (!FAType->isVectorType() || !SAType->isVectorType()) {
641      Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
642        << SourceRange(TheCall->getArg(0)->getLocStart(),
643                       TheCall->getArg(1)->getLocEnd());
644      return ExprError();
645    }
646
647    if (!Context.hasSameUnqualifiedType(FAType, SAType)) {
648      Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
649        << SourceRange(TheCall->getArg(0)->getLocStart(),
650                       TheCall->getArg(1)->getLocEnd());
651      return ExprError();
652    }
653
654    numElements = FAType->getAs<VectorType>()->getNumElements();
655    if (TheCall->getNumArgs() != numElements+2) {
656      if (TheCall->getNumArgs() < numElements+2)
657        return ExprError(Diag(TheCall->getLocEnd(),
658                              diag::err_typecheck_call_too_few_args)
659                 << 0 /*function call*/ << TheCall->getSourceRange());
660      return ExprError(Diag(TheCall->getLocEnd(),
661                            diag::err_typecheck_call_too_many_args)
662                 << 0 /*function call*/ << TheCall->getSourceRange());
663    }
664  }
665
666  for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
667    if (TheCall->getArg(i)->isTypeDependent() ||
668        TheCall->getArg(i)->isValueDependent())
669      continue;
670
671    llvm::APSInt Result(32);
672    if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
673      return ExprError(Diag(TheCall->getLocStart(),
674                  diag::err_shufflevector_nonconstant_argument)
675                << TheCall->getArg(i)->getSourceRange());
676
677    if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
678      return ExprError(Diag(TheCall->getLocStart(),
679                  diag::err_shufflevector_argument_too_large)
680               << TheCall->getArg(i)->getSourceRange());
681  }
682
683  llvm::SmallVector<Expr*, 32> exprs;
684
685  for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
686    exprs.push_back(TheCall->getArg(i));
687    TheCall->setArg(i, 0);
688  }
689
690  return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
691                                            exprs.size(), exprs[0]->getType(),
692                                            TheCall->getCallee()->getLocStart(),
693                                            TheCall->getRParenLoc()));
694}
695
696/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
697// This is declared to take (const void*, ...) and can take two
698// optional constant int args.
699bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
700  unsigned NumArgs = TheCall->getNumArgs();
701
702  if (NumArgs > 3)
703    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_many_args)
704             << 0 /*function call*/ << TheCall->getSourceRange();
705
706  // Argument 0 is checked for us and the remaining arguments must be
707  // constant integers.
708  for (unsigned i = 1; i != NumArgs; ++i) {
709    Expr *Arg = TheCall->getArg(i);
710    if (Arg->isTypeDependent())
711      continue;
712
713    if (!Arg->getType()->isIntegralType())
714      return Diag(TheCall->getLocStart(), diag::err_prefetch_invalid_arg_type)
715              << Arg->getSourceRange();
716
717    ImpCastExprToType(Arg, Context.IntTy, CastExpr::CK_IntegralCast);
718    TheCall->setArg(i, Arg);
719
720    if (Arg->isValueDependent())
721      continue;
722
723    llvm::APSInt Result;
724    if (!Arg->isIntegerConstantExpr(Result, Context))
725      return Diag(TheCall->getLocStart(), diag::err_prefetch_invalid_arg_ice)
726        << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
727
728    // FIXME: gcc issues a warning and rewrites these to 0. These
729    // seems especially odd for the third argument since the default
730    // is 3.
731    if (i == 1) {
732      if (Result.getLimitedValue() > 1)
733        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
734             << "0" << "1" << Arg->getSourceRange();
735    } else {
736      if (Result.getLimitedValue() > 3)
737        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
738            << "0" << "3" << Arg->getSourceRange();
739    }
740  }
741
742  return false;
743}
744
745/// SemaBuiltinEHReturnDataRegNo - Handle __builtin_eh_return_data_regno, the
746/// operand must be an integer constant.
747bool Sema::SemaBuiltinEHReturnDataRegNo(CallExpr *TheCall) {
748  llvm::APSInt Result;
749  if (!TheCall->getArg(0)->isIntegerConstantExpr(Result, Context))
750    return Diag(TheCall->getLocStart(), diag::err_expr_not_ice)
751      << TheCall->getArg(0)->getSourceRange();
752
753  return false;
754}
755
756
757/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
758/// int type). This simply type checks that type is one of the defined
759/// constants (0-3).
760// For compatability check 0-3, llvm only handles 0 and 2.
761bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
762  Expr *Arg = TheCall->getArg(1);
763  if (Arg->isTypeDependent())
764    return false;
765
766  QualType ArgType = Arg->getType();
767  const BuiltinType *BT = ArgType->getAs<BuiltinType>();
768  llvm::APSInt Result(32);
769  if (!BT || BT->getKind() != BuiltinType::Int)
770    return Diag(TheCall->getLocStart(), diag::err_object_size_invalid_argument)
771             << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
772
773  if (Arg->isValueDependent())
774    return false;
775
776  if (!Arg->isIntegerConstantExpr(Result, Context)) {
777    return Diag(TheCall->getLocStart(), diag::err_object_size_invalid_argument)
778             << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
779  }
780
781  if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
782    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
783             << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
784  }
785
786  return false;
787}
788
789/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
790/// This checks that val is a constant 1.
791bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
792  Expr *Arg = TheCall->getArg(1);
793  if (Arg->isTypeDependent() || Arg->isValueDependent())
794    return false;
795
796  llvm::APSInt Result(32);
797  if (!Arg->isIntegerConstantExpr(Result, Context) || Result != 1)
798    return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
799             << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
800
801  return false;
802}
803
804// Handle i > 1 ? "x" : "y", recursivelly
805bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
806                                  bool HasVAListArg,
807                                  unsigned format_idx, unsigned firstDataArg) {
808  if (E->isTypeDependent() || E->isValueDependent())
809    return false;
810
811  switch (E->getStmtClass()) {
812  case Stmt::ConditionalOperatorClass: {
813    const ConditionalOperator *C = cast<ConditionalOperator>(E);
814    return SemaCheckStringLiteral(C->getTrueExpr(), TheCall,
815                                  HasVAListArg, format_idx, firstDataArg)
816        && SemaCheckStringLiteral(C->getRHS(), TheCall,
817                                  HasVAListArg, format_idx, firstDataArg);
818  }
819
820  case Stmt::ImplicitCastExprClass: {
821    const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
822    return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
823                                  format_idx, firstDataArg);
824  }
825
826  case Stmt::ParenExprClass: {
827    const ParenExpr *Expr = cast<ParenExpr>(E);
828    return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
829                                  format_idx, firstDataArg);
830  }
831
832  case Stmt::DeclRefExprClass: {
833    const DeclRefExpr *DR = cast<DeclRefExpr>(E);
834
835    // As an exception, do not flag errors for variables binding to
836    // const string literals.
837    if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
838      bool isConstant = false;
839      QualType T = DR->getType();
840
841      if (const ArrayType *AT = Context.getAsArrayType(T)) {
842        isConstant = AT->getElementType().isConstant(Context);
843      } else if (const PointerType *PT = T->getAs<PointerType>()) {
844        isConstant = T.isConstant(Context) &&
845                     PT->getPointeeType().isConstant(Context);
846      }
847
848      if (isConstant) {
849        const VarDecl *Def = 0;
850        if (const Expr *Init = VD->getDefinition(Def))
851          return SemaCheckStringLiteral(Init, TheCall,
852                                        HasVAListArg, format_idx, firstDataArg);
853      }
854
855      // For vprintf* functions (i.e., HasVAListArg==true), we add a
856      // special check to see if the format string is a function parameter
857      // of the function calling the printf function.  If the function
858      // has an attribute indicating it is a printf-like function, then we
859      // should suppress warnings concerning non-literals being used in a call
860      // to a vprintf function.  For example:
861      //
862      // void
863      // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
864      //      va_list ap;
865      //      va_start(ap, fmt);
866      //      vprintf(fmt, ap);  // Do NOT emit a warning about "fmt".
867      //      ...
868      //
869      //
870      //  FIXME: We don't have full attribute support yet, so just check to see
871      //    if the argument is a DeclRefExpr that references a parameter.  We'll
872      //    add proper support for checking the attribute later.
873      if (HasVAListArg)
874        if (isa<ParmVarDecl>(VD))
875          return true;
876    }
877
878    return false;
879  }
880
881  case Stmt::CallExprClass: {
882    const CallExpr *CE = cast<CallExpr>(E);
883    if (const ImplicitCastExpr *ICE
884          = dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
885      if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
886        if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
887          if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
888            unsigned ArgIndex = FA->getFormatIdx();
889            const Expr *Arg = CE->getArg(ArgIndex - 1);
890
891            return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg,
892                                          format_idx, firstDataArg);
893          }
894        }
895      }
896    }
897
898    return false;
899  }
900  case Stmt::ObjCStringLiteralClass:
901  case Stmt::StringLiteralClass: {
902    const StringLiteral *StrE = NULL;
903
904    if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
905      StrE = ObjCFExpr->getString();
906    else
907      StrE = cast<StringLiteral>(E);
908
909    if (StrE) {
910      CheckPrintfString(StrE, E, TheCall, HasVAListArg, format_idx,
911                        firstDataArg);
912      return true;
913    }
914
915    return false;
916  }
917
918  default:
919    return false;
920  }
921}
922
923void
924Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
925                            const CallExpr *TheCall) {
926  for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end();
927       i != e; ++i) {
928    const Expr *ArgExpr = TheCall->getArg(*i);
929    if (ArgExpr->isNullPointerConstant(Context,
930                                       Expr::NPC_ValueDependentIsNotNull))
931      Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg)
932        << ArgExpr->getSourceRange();
933  }
934}
935
936/// CheckPrintfArguments - Check calls to printf (and similar functions) for
937/// correct use of format strings.
938///
939///  HasVAListArg - A predicate indicating whether the printf-like
940///    function is passed an explicit va_arg argument (e.g., vprintf)
941///
942///  format_idx - The index into Args for the format string.
943///
944/// Improper format strings to functions in the printf family can be
945/// the source of bizarre bugs and very serious security holes.  A
946/// good source of information is available in the following paper
947/// (which includes additional references):
948///
949///  FormatGuard: Automatic Protection From printf Format String
950///  Vulnerabilities, Proceedings of the 10th USENIX Security Symposium, 2001.
951///
952/// Functionality implemented:
953///
954///  We can statically check the following properties for string
955///  literal format strings for non v.*printf functions (where the
956///  arguments are passed directly):
957//
958///  (1) Are the number of format conversions equal to the number of
959///      data arguments?
960///
961///  (2) Does each format conversion correctly match the type of the
962///      corresponding data argument?  (TODO)
963///
964/// Moreover, for all printf functions we can:
965///
966///  (3) Check for a missing format string (when not caught by type checking).
967///
968///  (4) Check for no-operation flags; e.g. using "#" with format
969///      conversion 'c'  (TODO)
970///
971///  (5) Check the use of '%n', a major source of security holes.
972///
973///  (6) Check for malformed format conversions that don't specify anything.
974///
975///  (7) Check for empty format strings.  e.g: printf("");
976///
977///  (8) Check that the format string is a wide literal.
978///
979/// All of these checks can be done by parsing the format string.
980///
981/// For now, we ONLY do (1), (3), (5), (6), (7), and (8).
982void
983Sema::CheckPrintfArguments(const CallExpr *TheCall, bool HasVAListArg,
984                           unsigned format_idx, unsigned firstDataArg) {
985  const Expr *Fn = TheCall->getCallee();
986
987  // The way the format attribute works in GCC, the implicit this argument
988  // of member functions is counted. However, it doesn't appear in our own
989  // lists, so decrement format_idx in that case.
990  if (isa<CXXMemberCallExpr>(TheCall)) {
991    // Catch a format attribute mistakenly referring to the object argument.
992    if (format_idx == 0)
993      return;
994    --format_idx;
995    if(firstDataArg != 0)
996      --firstDataArg;
997  }
998
999  // CHECK: printf-like function is called with no format string.
1000  if (format_idx >= TheCall->getNumArgs()) {
1001    Diag(TheCall->getRParenLoc(), diag::warn_printf_missing_format_string)
1002      << Fn->getSourceRange();
1003    return;
1004  }
1005
1006  const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
1007
1008  // CHECK: format string is not a string literal.
1009  //
1010  // Dynamically generated format strings are difficult to
1011  // automatically vet at compile time.  Requiring that format strings
1012  // are string literals: (1) permits the checking of format strings by
1013  // the compiler and thereby (2) can practically remove the source of
1014  // many format string exploits.
1015
1016  // Format string can be either ObjC string (e.g. @"%d") or
1017  // C string (e.g. "%d")
1018  // ObjC string uses the same format specifiers as C string, so we can use
1019  // the same format string checking logic for both ObjC and C strings.
1020  if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
1021                             firstDataArg))
1022    return;  // Literal format string found, check done!
1023
1024  // If there are no arguments specified, warn with -Wformat-security, otherwise
1025  // warn only with -Wformat-nonliteral.
1026  if (TheCall->getNumArgs() == format_idx+1)
1027    Diag(TheCall->getArg(format_idx)->getLocStart(),
1028         diag::warn_printf_nonliteral_noargs)
1029      << OrigFormatExpr->getSourceRange();
1030  else
1031    Diag(TheCall->getArg(format_idx)->getLocStart(),
1032         diag::warn_printf_nonliteral)
1033           << OrigFormatExpr->getSourceRange();
1034}
1035
1036namespace {
1037class CheckPrintfHandler : public FormatStringHandler {
1038  Sema &S;
1039  const StringLiteral *FExpr;
1040  const Expr *OrigFormatExpr;
1041  unsigned NumConversions;
1042  const unsigned NumDataArgs;
1043  const bool IsObjCLiteral;
1044  const char *Beg; // Start of format string.
1045  const bool HasVAListArg;
1046  const CallExpr *TheCall;
1047  unsigned FormatIdx;
1048public:
1049  CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
1050                     const Expr *origFormatExpr,
1051                     unsigned numDataArgs, bool isObjCLiteral,
1052                     const char *beg, bool hasVAListArg,
1053                     const CallExpr *theCall, unsigned formatIdx)
1054    : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
1055      NumConversions(0), NumDataArgs(numDataArgs),
1056      IsObjCLiteral(isObjCLiteral), Beg(beg),
1057      HasVAListArg(hasVAListArg),
1058      TheCall(theCall), FormatIdx(formatIdx) {}
1059
1060  void DoneProcessing();
1061
1062  void HandleIncompleteFormatSpecifier(const char *startSpecifier,
1063                                       unsigned specifierLen);
1064
1065  void HandleInvalidConversionSpecifier(const analyze_printf::FormatSpecifier &FS,
1066                                        const char *startSpecifier,
1067                                        unsigned specifierLen);
1068
1069  void HandleNullChar(const char *nullCharacter);
1070
1071  bool HandleFormatSpecifier(const analyze_printf::FormatSpecifier &FS,
1072                             const char *startSpecifier,
1073                             unsigned specifierLen);
1074private:
1075  SourceRange getFormatStringRange();
1076  SourceRange getFormatSpecifierRange(const char *startSpecifier,
1077									  unsigned specifierLen);
1078  SourceLocation getLocationOfByte(const char *x);
1079
1080  bool HandleAmount(const analyze_printf::OptionalAmount &Amt,
1081                    unsigned MissingArgDiag, unsigned BadTypeDiag,
1082					const char *startSpecifier, unsigned specifierLen);
1083
1084  const Expr *getDataArg(unsigned i) const;
1085};
1086}
1087
1088SourceRange CheckPrintfHandler::getFormatStringRange() {
1089  return OrigFormatExpr->getSourceRange();
1090}
1091
1092SourceRange CheckPrintfHandler::
1093getFormatSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
1094  return SourceRange(getLocationOfByte(startSpecifier),
1095					 getLocationOfByte(startSpecifier+specifierLen-1));
1096}
1097
1098SourceLocation CheckPrintfHandler::getLocationOfByte(const char *x) {
1099  return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
1100}
1101
1102void CheckPrintfHandler::
1103HandleIncompleteFormatSpecifier(const char *startSpecifier,
1104                                unsigned specifierLen) {
1105  SourceLocation Loc = getLocationOfByte(startSpecifier);
1106  S.Diag(Loc, diag::warn_printf_incomplete_specifier)
1107    << getFormatSpecifierRange(startSpecifier, specifierLen);
1108}
1109
1110void CheckPrintfHandler::
1111HandleInvalidConversionSpecifier(const analyze_printf::FormatSpecifier &FS,
1112                                 const char *startSpecifier,
1113                                 unsigned specifierLen) {
1114
1115  ++NumConversions;
1116  const analyze_printf::ConversionSpecifier &CS =
1117    FS.getConversionSpecifier();
1118  SourceLocation Loc = getLocationOfByte(CS.getStart());
1119  S.Diag(Loc, diag::warn_printf_invalid_conversion)
1120      << llvm::StringRef(CS.getStart(), CS.getLength())
1121      << getFormatSpecifierRange(startSpecifier, specifierLen);
1122}
1123
1124void CheckPrintfHandler::HandleNullChar(const char *nullCharacter) {
1125  // The presence of a null character is likely an error.
1126  S.Diag(getLocationOfByte(nullCharacter),
1127         diag::warn_printf_format_string_contains_null_char)
1128    << getFormatStringRange();
1129}
1130
1131const Expr *CheckPrintfHandler::getDataArg(unsigned i) const {
1132  return TheCall->getArg(FormatIdx + i);
1133}
1134
1135bool
1136CheckPrintfHandler::HandleAmount(const analyze_printf::OptionalAmount &Amt,
1137                                 unsigned MissingArgDiag,
1138                                 unsigned BadTypeDiag,
1139								 const char *startSpecifier,
1140								 unsigned specifierLen) {
1141
1142  if (Amt.hasDataArgument()) {
1143    ++NumConversions;
1144    if (!HasVAListArg) {
1145      if (NumConversions > NumDataArgs) {
1146        S.Diag(getLocationOfByte(Amt.getStart()), MissingArgDiag)
1147          << getFormatSpecifierRange(startSpecifier, specifierLen);
1148        // Don't do any more checking.  We will just emit
1149        // spurious errors.
1150        return false;
1151      }
1152
1153      // Type check the data argument.  It should be an 'int'.
1154      const Expr *Arg = getDataArg(NumConversions);
1155      QualType T = Arg->getType();
1156      const BuiltinType *BT = T->getAs<BuiltinType>();
1157      if (!BT || BT->getKind() != BuiltinType::Int) {
1158        S.Diag(getLocationOfByte(Amt.getStart()), BadTypeDiag)
1159          << T
1160		  << getFormatSpecifierRange(startSpecifier, specifierLen)
1161		  << Arg->getSourceRange();
1162        // Don't do any more checking.  We will just emit
1163        // spurious errors.
1164        return false;
1165      }
1166    }
1167  }
1168  return true;
1169}
1170
1171bool
1172CheckPrintfHandler::HandleFormatSpecifier(const analyze_printf::FormatSpecifier &FS,
1173                                          const char *startSpecifier,
1174                                          unsigned specifierLen) {
1175
1176  using namespace analyze_printf;
1177  const ConversionSpecifier &CS = FS.getConversionSpecifier();
1178
1179  // First check if the field width, precision, and conversion specifier
1180  // have matching data arguments.
1181  if (!HandleAmount(FS.getFieldWidth(),
1182                    diag::warn_printf_asterisk_width_missing_arg,
1183                    diag::warn_printf_asterisk_width_wrong_type,
1184					startSpecifier, specifierLen)) {
1185    return false;
1186  }
1187
1188  if (!HandleAmount(FS.getPrecision(),
1189                    diag::warn_printf_asterisk_precision_missing_arg,
1190                    diag::warn_printf_asterisk_precision_wrong_type,
1191					startSpecifier, specifierLen)) {
1192    return false;
1193  }
1194
1195  // Check for using an Objective-C specific conversion specifier
1196  // in a non-ObjC literal.
1197  if (!IsObjCLiteral && CS.isObjCArg()) {
1198    HandleInvalidConversionSpecifier(FS, startSpecifier, specifierLen);
1199
1200    // Continue checking the other format specifiers.
1201    return true;
1202  }
1203
1204  if (!CS.consumesDataArgument()) {
1205    // FIXME: Technically specifying a precision or field width here
1206    // makes no sense.  Worth issuing a warning at some point.
1207	return true;
1208  }
1209
1210  ++NumConversions;
1211
1212  // Are we using '%n'?  Issue a warning about this being
1213  // a possible security issue.
1214  if (CS.getKind() == ConversionSpecifier::OutIntPtrArg) {
1215    S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back)
1216      << getFormatSpecifierRange(startSpecifier, specifierLen);
1217    // Continue checking the other format specifiers.
1218    return true;
1219  }
1220
1221
1222  // The remaining checks depend on the data arguments.
1223  if (HasVAListArg)
1224    return true;
1225
1226  if (NumConversions > NumDataArgs) {
1227    S.Diag(getLocationOfByte(CS.getStart()),
1228           diag::warn_printf_insufficient_data_args)
1229      << getFormatSpecifierRange(startSpecifier, specifierLen);
1230    // Don't do any more checking.
1231    return false;
1232  }
1233
1234  return true;
1235}
1236
1237void CheckPrintfHandler::DoneProcessing() {
1238  // Does the number of data arguments exceed the number of
1239  // format conversions in the format string?
1240  if (!HasVAListArg && NumConversions < NumDataArgs)
1241    S.Diag(getDataArg(NumConversions+1)->getLocStart(),
1242           diag::warn_printf_too_many_data_args)
1243      << getFormatStringRange();
1244}
1245
1246void Sema::CheckPrintfString(const StringLiteral *FExpr,
1247							 const Expr *OrigFormatExpr,
1248							 const CallExpr *TheCall, bool HasVAListArg,
1249							 unsigned format_idx, unsigned firstDataArg) {
1250
1251  // CHECK: is the format string a wide literal?
1252  if (FExpr->isWide()) {
1253    Diag(FExpr->getLocStart(),
1254         diag::warn_printf_format_string_is_wide_literal)
1255    << OrigFormatExpr->getSourceRange();
1256    return;
1257  }
1258
1259  // Str - The format string.  NOTE: this is NOT null-terminated!
1260  const char *Str = FExpr->getStrData();
1261
1262  // CHECK: empty format string?
1263  unsigned StrLen = FExpr->getByteLength();
1264
1265  if (StrLen == 0) {
1266    Diag(FExpr->getLocStart(), diag::warn_printf_empty_format_string)
1267    << OrigFormatExpr->getSourceRange();
1268    return;
1269  }
1270
1271  CheckPrintfHandler H(*this, FExpr, OrigFormatExpr,
1272                       TheCall->getNumArgs() - firstDataArg,
1273                       isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1274                       HasVAListArg, TheCall, format_idx);
1275
1276  if (!ParseFormatString(H, Str, Str + StrLen))
1277    H.DoneProcessing();
1278}
1279
1280//===--- CHECK: Return Address of Stack Variable --------------------------===//
1281
1282static DeclRefExpr* EvalVal(Expr *E);
1283static DeclRefExpr* EvalAddr(Expr* E);
1284
1285/// CheckReturnStackAddr - Check if a return statement returns the address
1286///   of a stack variable.
1287void
1288Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
1289                           SourceLocation ReturnLoc) {
1290
1291  // Perform checking for returned stack addresses.
1292  if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
1293    if (DeclRefExpr *DR = EvalAddr(RetValExp))
1294      Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
1295       << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
1296
1297    // Skip over implicit cast expressions when checking for block expressions.
1298    RetValExp = RetValExp->IgnoreParenCasts();
1299
1300    if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp))
1301      if (C->hasBlockDeclRefExprs())
1302        Diag(C->getLocStart(), diag::err_ret_local_block)
1303          << C->getSourceRange();
1304
1305    if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp))
1306      Diag(ALE->getLocStart(), diag::warn_ret_addr_label)
1307        << ALE->getSourceRange();
1308
1309  } else if (lhsType->isReferenceType()) {
1310    // Perform checking for stack values returned by reference.
1311    // Check for a reference to the stack
1312    if (DeclRefExpr *DR = EvalVal(RetValExp))
1313      Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
1314        << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
1315  }
1316}
1317
1318/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
1319///  check if the expression in a return statement evaluates to an address
1320///  to a location on the stack.  The recursion is used to traverse the
1321///  AST of the return expression, with recursion backtracking when we
1322///  encounter a subexpression that (1) clearly does not lead to the address
1323///  of a stack variable or (2) is something we cannot determine leads to
1324///  the address of a stack variable based on such local checking.
1325///
1326///  EvalAddr processes expressions that are pointers that are used as
1327///  references (and not L-values).  EvalVal handles all other values.
1328///  At the base case of the recursion is a check for a DeclRefExpr* in
1329///  the refers to a stack variable.
1330///
1331///  This implementation handles:
1332///
1333///   * pointer-to-pointer casts
1334///   * implicit conversions from array references to pointers
1335///   * taking the address of fields
1336///   * arbitrary interplay between "&" and "*" operators
1337///   * pointer arithmetic from an address of a stack variable
1338///   * taking the address of an array element where the array is on the stack
1339static DeclRefExpr* EvalAddr(Expr *E) {
1340  // We should only be called for evaluating pointer expressions.
1341  assert((E->getType()->isAnyPointerType() ||
1342          E->getType()->isBlockPointerType() ||
1343          E->getType()->isObjCQualifiedIdType()) &&
1344         "EvalAddr only works on pointers");
1345
1346  // Our "symbolic interpreter" is just a dispatch off the currently
1347  // viewed AST node.  We then recursively traverse the AST by calling
1348  // EvalAddr and EvalVal appropriately.
1349  switch (E->getStmtClass()) {
1350  case Stmt::ParenExprClass:
1351    // Ignore parentheses.
1352    return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
1353
1354  case Stmt::UnaryOperatorClass: {
1355    // The only unary operator that make sense to handle here
1356    // is AddrOf.  All others don't make sense as pointers.
1357    UnaryOperator *U = cast<UnaryOperator>(E);
1358
1359    if (U->getOpcode() == UnaryOperator::AddrOf)
1360      return EvalVal(U->getSubExpr());
1361    else
1362      return NULL;
1363  }
1364
1365  case Stmt::BinaryOperatorClass: {
1366    // Handle pointer arithmetic.  All other binary operators are not valid
1367    // in this context.
1368    BinaryOperator *B = cast<BinaryOperator>(E);
1369    BinaryOperator::Opcode op = B->getOpcode();
1370
1371    if (op != BinaryOperator::Add && op != BinaryOperator::Sub)
1372      return NULL;
1373
1374    Expr *Base = B->getLHS();
1375
1376    // Determine which argument is the real pointer base.  It could be
1377    // the RHS argument instead of the LHS.
1378    if (!Base->getType()->isPointerType()) Base = B->getRHS();
1379
1380    assert (Base->getType()->isPointerType());
1381    return EvalAddr(Base);
1382  }
1383
1384  // For conditional operators we need to see if either the LHS or RHS are
1385  // valid DeclRefExpr*s.  If one of them is valid, we return it.
1386  case Stmt::ConditionalOperatorClass: {
1387    ConditionalOperator *C = cast<ConditionalOperator>(E);
1388
1389    // Handle the GNU extension for missing LHS.
1390    if (Expr *lhsExpr = C->getLHS())
1391      if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
1392        return LHS;
1393
1394     return EvalAddr(C->getRHS());
1395  }
1396
1397  // For casts, we need to handle conversions from arrays to
1398  // pointer values, and pointer-to-pointer conversions.
1399  case Stmt::ImplicitCastExprClass:
1400  case Stmt::CStyleCastExprClass:
1401  case Stmt::CXXFunctionalCastExprClass: {
1402    Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
1403    QualType T = SubExpr->getType();
1404
1405    if (SubExpr->getType()->isPointerType() ||
1406        SubExpr->getType()->isBlockPointerType() ||
1407        SubExpr->getType()->isObjCQualifiedIdType())
1408      return EvalAddr(SubExpr);
1409    else if (T->isArrayType())
1410      return EvalVal(SubExpr);
1411    else
1412      return 0;
1413  }
1414
1415  // C++ casts.  For dynamic casts, static casts, and const casts, we
1416  // are always converting from a pointer-to-pointer, so we just blow
1417  // through the cast.  In the case the dynamic cast doesn't fail (and
1418  // return NULL), we take the conservative route and report cases
1419  // where we return the address of a stack variable.  For Reinterpre
1420  // FIXME: The comment about is wrong; we're not always converting
1421  // from pointer to pointer. I'm guessing that this code should also
1422  // handle references to objects.
1423  case Stmt::CXXStaticCastExprClass:
1424  case Stmt::CXXDynamicCastExprClass:
1425  case Stmt::CXXConstCastExprClass:
1426  case Stmt::CXXReinterpretCastExprClass: {
1427      Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
1428      if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
1429        return EvalAddr(S);
1430      else
1431        return NULL;
1432  }
1433
1434  // Everything else: we simply don't reason about them.
1435  default:
1436    return NULL;
1437  }
1438}
1439
1440
1441///  EvalVal - This function is complements EvalAddr in the mutual recursion.
1442///   See the comments for EvalAddr for more details.
1443static DeclRefExpr* EvalVal(Expr *E) {
1444
1445  // We should only be called for evaluating non-pointer expressions, or
1446  // expressions with a pointer type that are not used as references but instead
1447  // are l-values (e.g., DeclRefExpr with a pointer type).
1448
1449  // Our "symbolic interpreter" is just a dispatch off the currently
1450  // viewed AST node.  We then recursively traverse the AST by calling
1451  // EvalAddr and EvalVal appropriately.
1452  switch (E->getStmtClass()) {
1453  case Stmt::DeclRefExprClass: {
1454    // DeclRefExpr: the base case.  When we hit a DeclRefExpr we are looking
1455    //  at code that refers to a variable's name.  We check if it has local
1456    //  storage within the function, and if so, return the expression.
1457    DeclRefExpr *DR = cast<DeclRefExpr>(E);
1458
1459    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
1460      if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
1461
1462    return NULL;
1463  }
1464
1465  case Stmt::ParenExprClass:
1466    // Ignore parentheses.
1467    return EvalVal(cast<ParenExpr>(E)->getSubExpr());
1468
1469  case Stmt::UnaryOperatorClass: {
1470    // The only unary operator that make sense to handle here
1471    // is Deref.  All others don't resolve to a "name."  This includes
1472    // handling all sorts of rvalues passed to a unary operator.
1473    UnaryOperator *U = cast<UnaryOperator>(E);
1474
1475    if (U->getOpcode() == UnaryOperator::Deref)
1476      return EvalAddr(U->getSubExpr());
1477
1478    return NULL;
1479  }
1480
1481  case Stmt::ArraySubscriptExprClass: {
1482    // Array subscripts are potential references to data on the stack.  We
1483    // retrieve the DeclRefExpr* for the array variable if it indeed
1484    // has local storage.
1485    return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
1486  }
1487
1488  case Stmt::ConditionalOperatorClass: {
1489    // For conditional operators we need to see if either the LHS or RHS are
1490    // non-NULL DeclRefExpr's.  If one is non-NULL, we return it.
1491    ConditionalOperator *C = cast<ConditionalOperator>(E);
1492
1493    // Handle the GNU extension for missing LHS.
1494    if (Expr *lhsExpr = C->getLHS())
1495      if (DeclRefExpr *LHS = EvalVal(lhsExpr))
1496        return LHS;
1497
1498    return EvalVal(C->getRHS());
1499  }
1500
1501  // Accesses to members are potential references to data on the stack.
1502  case Stmt::MemberExprClass: {
1503    MemberExpr *M = cast<MemberExpr>(E);
1504
1505    // Check for indirect access.  We only want direct field accesses.
1506    if (!M->isArrow())
1507      return EvalVal(M->getBase());
1508    else
1509      return NULL;
1510  }
1511
1512  // Everything else: we simply don't reason about them.
1513  default:
1514    return NULL;
1515  }
1516}
1517
1518//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
1519
1520/// Check for comparisons of floating point operands using != and ==.
1521/// Issue a warning if these are no self-comparisons, as they are not likely
1522/// to do what the programmer intended.
1523void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
1524  bool EmitWarning = true;
1525
1526  Expr* LeftExprSansParen = lex->IgnoreParens();
1527  Expr* RightExprSansParen = rex->IgnoreParens();
1528
1529  // Special case: check for x == x (which is OK).
1530  // Do not emit warnings for such cases.
1531  if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
1532    if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
1533      if (DRL->getDecl() == DRR->getDecl())
1534        EmitWarning = false;
1535
1536
1537  // Special case: check for comparisons against literals that can be exactly
1538  //  represented by APFloat.  In such cases, do not emit a warning.  This
1539  //  is a heuristic: often comparison against such literals are used to
1540  //  detect if a value in a variable has not changed.  This clearly can
1541  //  lead to false negatives.
1542  if (EmitWarning) {
1543    if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
1544      if (FLL->isExact())
1545        EmitWarning = false;
1546    } else
1547      if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
1548        if (FLR->isExact())
1549          EmitWarning = false;
1550    }
1551  }
1552
1553  // Check for comparisons with builtin types.
1554  if (EmitWarning)
1555    if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
1556      if (CL->isBuiltinCall(Context))
1557        EmitWarning = false;
1558
1559  if (EmitWarning)
1560    if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
1561      if (CR->isBuiltinCall(Context))
1562        EmitWarning = false;
1563
1564  // Emit the diagnostic.
1565  if (EmitWarning)
1566    Diag(loc, diag::warn_floatingpoint_eq)
1567      << lex->getSourceRange() << rex->getSourceRange();
1568}
1569
1570//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
1571//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
1572
1573namespace {
1574
1575/// Structure recording the 'active' range of an integer-valued
1576/// expression.
1577struct IntRange {
1578  /// The number of bits active in the int.
1579  unsigned Width;
1580
1581  /// True if the int is known not to have negative values.
1582  bool NonNegative;
1583
1584  IntRange() {}
1585  IntRange(unsigned Width, bool NonNegative)
1586    : Width(Width), NonNegative(NonNegative)
1587  {}
1588
1589  // Returns the range of the bool type.
1590  static IntRange forBoolType() {
1591    return IntRange(1, true);
1592  }
1593
1594  // Returns the range of an integral type.
1595  static IntRange forType(ASTContext &C, QualType T) {
1596    return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr());
1597  }
1598
1599  // Returns the range of an integeral type based on its canonical
1600  // representation.
1601  static IntRange forCanonicalType(ASTContext &C, const Type *T) {
1602    assert(T->isCanonicalUnqualified());
1603
1604    if (const VectorType *VT = dyn_cast<VectorType>(T))
1605      T = VT->getElementType().getTypePtr();
1606    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
1607      T = CT->getElementType().getTypePtr();
1608    if (const EnumType *ET = dyn_cast<EnumType>(T))
1609      T = ET->getDecl()->getIntegerType().getTypePtr();
1610
1611    const BuiltinType *BT = cast<BuiltinType>(T);
1612    assert(BT->isInteger());
1613
1614    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
1615  }
1616
1617  // Returns the supremum of two ranges: i.e. their conservative merge.
1618  static IntRange join(const IntRange &L, const IntRange &R) {
1619    return IntRange(std::max(L.Width, R.Width),
1620                    L.NonNegative && R.NonNegative);
1621  }
1622
1623  // Returns the infinum of two ranges: i.e. their aggressive merge.
1624  static IntRange meet(const IntRange &L, const IntRange &R) {
1625    return IntRange(std::min(L.Width, R.Width),
1626                    L.NonNegative || R.NonNegative);
1627  }
1628};
1629
1630IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
1631  if (value.isSigned() && value.isNegative())
1632    return IntRange(value.getMinSignedBits(), false);
1633
1634  if (value.getBitWidth() > MaxWidth)
1635    value.trunc(MaxWidth);
1636
1637  // isNonNegative() just checks the sign bit without considering
1638  // signedness.
1639  return IntRange(value.getActiveBits(), true);
1640}
1641
1642IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
1643                       unsigned MaxWidth) {
1644  if (result.isInt())
1645    return GetValueRange(C, result.getInt(), MaxWidth);
1646
1647  if (result.isVector()) {
1648    IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
1649    for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
1650      IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
1651      R = IntRange::join(R, El);
1652    }
1653    return R;
1654  }
1655
1656  if (result.isComplexInt()) {
1657    IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
1658    IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
1659    return IntRange::join(R, I);
1660  }
1661
1662  // This can happen with lossless casts to intptr_t of "based" lvalues.
1663  // Assume it might use arbitrary bits.
1664  // FIXME: The only reason we need to pass the type in here is to get
1665  // the sign right on this one case.  It would be nice if APValue
1666  // preserved this.
1667  assert(result.isLValue());
1668  return IntRange(MaxWidth, Ty->isUnsignedIntegerType());
1669}
1670
1671/// Pseudo-evaluate the given integer expression, estimating the
1672/// range of values it might take.
1673///
1674/// \param MaxWidth - the width to which the value will be truncated
1675IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
1676  E = E->IgnoreParens();
1677
1678  // Try a full evaluation first.
1679  Expr::EvalResult result;
1680  if (E->Evaluate(result, C))
1681    return GetValueRange(C, result.Val, E->getType(), MaxWidth);
1682
1683  // I think we only want to look through implicit casts here; if the
1684  // user has an explicit widening cast, we should treat the value as
1685  // being of the new, wider type.
1686  if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
1687    if (CE->getCastKind() == CastExpr::CK_NoOp)
1688      return GetExprRange(C, CE->getSubExpr(), MaxWidth);
1689
1690    IntRange OutputTypeRange = IntRange::forType(C, CE->getType());
1691
1692    bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast);
1693    if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown)
1694      isIntegerCast = CE->getSubExpr()->getType()->isIntegerType();
1695
1696    // Assume that non-integer casts can span the full range of the type.
1697    if (!isIntegerCast)
1698      return OutputTypeRange;
1699
1700    IntRange SubRange
1701      = GetExprRange(C, CE->getSubExpr(),
1702                     std::min(MaxWidth, OutputTypeRange.Width));
1703
1704    // Bail out if the subexpr's range is as wide as the cast type.
1705    if (SubRange.Width >= OutputTypeRange.Width)
1706      return OutputTypeRange;
1707
1708    // Otherwise, we take the smaller width, and we're non-negative if
1709    // either the output type or the subexpr is.
1710    return IntRange(SubRange.Width,
1711                    SubRange.NonNegative || OutputTypeRange.NonNegative);
1712  }
1713
1714  if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
1715    // If we can fold the condition, just take that operand.
1716    bool CondResult;
1717    if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
1718      return GetExprRange(C, CondResult ? CO->getTrueExpr()
1719                                        : CO->getFalseExpr(),
1720                          MaxWidth);
1721
1722    // Otherwise, conservatively merge.
1723    IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
1724    IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
1725    return IntRange::join(L, R);
1726  }
1727
1728  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
1729    switch (BO->getOpcode()) {
1730
1731    // Boolean-valued operations are single-bit and positive.
1732    case BinaryOperator::LAnd:
1733    case BinaryOperator::LOr:
1734    case BinaryOperator::LT:
1735    case BinaryOperator::GT:
1736    case BinaryOperator::LE:
1737    case BinaryOperator::GE:
1738    case BinaryOperator::EQ:
1739    case BinaryOperator::NE:
1740      return IntRange::forBoolType();
1741
1742    // Operations with opaque sources are black-listed.
1743    case BinaryOperator::PtrMemD:
1744    case BinaryOperator::PtrMemI:
1745      return IntRange::forType(C, E->getType());
1746
1747    // Bitwise-and uses the *infinum* of the two source ranges.
1748    case BinaryOperator::And:
1749      return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
1750                            GetExprRange(C, BO->getRHS(), MaxWidth));
1751
1752    // Left shift gets black-listed based on a judgement call.
1753    case BinaryOperator::Shl:
1754      return IntRange::forType(C, E->getType());
1755
1756    // Right shift by a constant can narrow its left argument.
1757    case BinaryOperator::Shr: {
1758      IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
1759
1760      // If the shift amount is a positive constant, drop the width by
1761      // that much.
1762      llvm::APSInt shift;
1763      if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
1764          shift.isNonNegative()) {
1765        unsigned zext = shift.getZExtValue();
1766        if (zext >= L.Width)
1767          L.Width = (L.NonNegative ? 0 : 1);
1768        else
1769          L.Width -= zext;
1770      }
1771
1772      return L;
1773    }
1774
1775    // Comma acts as its right operand.
1776    case BinaryOperator::Comma:
1777      return GetExprRange(C, BO->getRHS(), MaxWidth);
1778
1779    // Black-list pointer subtractions.
1780    case BinaryOperator::Sub:
1781      if (BO->getLHS()->getType()->isPointerType())
1782        return IntRange::forType(C, E->getType());
1783      // fallthrough
1784
1785    default:
1786      break;
1787    }
1788
1789    // Treat every other operator as if it were closed on the
1790    // narrowest type that encompasses both operands.
1791    IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
1792    IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
1793    return IntRange::join(L, R);
1794  }
1795
1796  if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
1797    switch (UO->getOpcode()) {
1798    // Boolean-valued operations are white-listed.
1799    case UnaryOperator::LNot:
1800      return IntRange::forBoolType();
1801
1802    // Operations with opaque sources are black-listed.
1803    case UnaryOperator::Deref:
1804    case UnaryOperator::AddrOf: // should be impossible
1805    case UnaryOperator::OffsetOf:
1806      return IntRange::forType(C, E->getType());
1807
1808    default:
1809      return GetExprRange(C, UO->getSubExpr(), MaxWidth);
1810    }
1811  }
1812
1813  FieldDecl *BitField = E->getBitField();
1814  if (BitField) {
1815    llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C);
1816    unsigned BitWidth = BitWidthAP.getZExtValue();
1817
1818    return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType());
1819  }
1820
1821  return IntRange::forType(C, E->getType());
1822}
1823
1824/// Checks whether the given value, which currently has the given
1825/// source semantics, has the same value when coerced through the
1826/// target semantics.
1827bool IsSameFloatAfterCast(const llvm::APFloat &value,
1828                          const llvm::fltSemantics &Src,
1829                          const llvm::fltSemantics &Tgt) {
1830  llvm::APFloat truncated = value;
1831
1832  bool ignored;
1833  truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
1834  truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
1835
1836  return truncated.bitwiseIsEqual(value);
1837}
1838
1839/// Checks whether the given value, which currently has the given
1840/// source semantics, has the same value when coerced through the
1841/// target semantics.
1842///
1843/// The value might be a vector of floats (or a complex number).
1844bool IsSameFloatAfterCast(const APValue &value,
1845                          const llvm::fltSemantics &Src,
1846                          const llvm::fltSemantics &Tgt) {
1847  if (value.isFloat())
1848    return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
1849
1850  if (value.isVector()) {
1851    for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
1852      if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
1853        return false;
1854    return true;
1855  }
1856
1857  assert(value.isComplexFloat());
1858  return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
1859          IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
1860}
1861
1862} // end anonymous namespace
1863
1864/// \brief Implements -Wsign-compare.
1865///
1866/// \param lex the left-hand expression
1867/// \param rex the right-hand expression
1868/// \param OpLoc the location of the joining operator
1869/// \param Equality whether this is an "equality-like" join, which
1870///   suppresses the warning in some cases
1871void Sema::CheckSignCompare(Expr *lex, Expr *rex, SourceLocation OpLoc,
1872                            const PartialDiagnostic &PD, bool Equality) {
1873  // Don't warn if we're in an unevaluated context.
1874  if (ExprEvalContexts.back().Context == Unevaluated)
1875    return;
1876
1877  // If either expression is value-dependent, don't warn. We'll get another
1878  // chance at instantiation time.
1879  if (lex->isValueDependent() || rex->isValueDependent())
1880    return;
1881
1882  QualType lt = lex->getType(), rt = rex->getType();
1883
1884  // Only warn if both operands are integral.
1885  if (!lt->isIntegerType() || !rt->isIntegerType())
1886    return;
1887
1888  // In C, the width of a bitfield determines its type, and the
1889  // declared type only contributes the signedness.  This duplicates
1890  // the work that will later be done by UsualUnaryConversions.
1891  // Eventually, this check will be reorganized in a way that avoids
1892  // this duplication.
1893  if (!getLangOptions().CPlusPlus) {
1894    QualType tmp;
1895    tmp = Context.isPromotableBitField(lex);
1896    if (!tmp.isNull()) lt = tmp;
1897    tmp = Context.isPromotableBitField(rex);
1898    if (!tmp.isNull()) rt = tmp;
1899  }
1900
1901  // The rule is that the signed operand becomes unsigned, so isolate the
1902  // signed operand.
1903  Expr *signedOperand = lex, *unsignedOperand = rex;
1904  QualType signedType = lt, unsignedType = rt;
1905  if (lt->isSignedIntegerType()) {
1906    if (rt->isSignedIntegerType()) return;
1907  } else {
1908    if (!rt->isSignedIntegerType()) return;
1909    std::swap(signedOperand, unsignedOperand);
1910    std::swap(signedType, unsignedType);
1911  }
1912
1913  unsigned unsignedWidth = Context.getIntWidth(unsignedType);
1914  unsigned signedWidth = Context.getIntWidth(signedType);
1915
1916  // If the unsigned type is strictly smaller than the signed type,
1917  // then (1) the result type will be signed and (2) the unsigned
1918  // value will fit fully within the signed type, and thus the result
1919  // of the comparison will be exact.
1920  if (signedWidth > unsignedWidth)
1921    return;
1922
1923  // Otherwise, calculate the effective ranges.
1924  IntRange signedRange = GetExprRange(Context, signedOperand, signedWidth);
1925  IntRange unsignedRange = GetExprRange(Context, unsignedOperand, unsignedWidth);
1926
1927  // We should never be unable to prove that the unsigned operand is
1928  // non-negative.
1929  assert(unsignedRange.NonNegative && "unsigned range includes negative?");
1930
1931  // If the signed operand is non-negative, then the signed->unsigned
1932  // conversion won't change it.
1933  if (signedRange.NonNegative)
1934    return;
1935
1936  // For (in)equality comparisons, if the unsigned operand is a
1937  // constant which cannot collide with a overflowed signed operand,
1938  // then reinterpreting the signed operand as unsigned will not
1939  // change the result of the comparison.
1940  if (Equality && unsignedRange.Width < unsignedWidth)
1941    return;
1942
1943  Diag(OpLoc, PD)
1944    << lt << rt << lex->getSourceRange() << rex->getSourceRange();
1945}
1946
1947/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
1948static void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) {
1949  S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange();
1950}
1951
1952/// Implements -Wconversion.
1953void Sema::CheckImplicitConversion(Expr *E, QualType T) {
1954  // Don't diagnose in unevaluated contexts.
1955  if (ExprEvalContexts.back().Context == Sema::Unevaluated)
1956    return;
1957
1958  // Don't diagnose for value-dependent expressions.
1959  if (E->isValueDependent())
1960    return;
1961
1962  const Type *Source = Context.getCanonicalType(E->getType()).getTypePtr();
1963  const Type *Target = Context.getCanonicalType(T).getTypePtr();
1964
1965  // Never diagnose implicit casts to bool.
1966  if (Target->isSpecificBuiltinType(BuiltinType::Bool))
1967    return;
1968
1969  // Strip vector types.
1970  if (isa<VectorType>(Source)) {
1971    if (!isa<VectorType>(Target))
1972      return DiagnoseImpCast(*this, E, T, diag::warn_impcast_vector_scalar);
1973
1974    Source = cast<VectorType>(Source)->getElementType().getTypePtr();
1975    Target = cast<VectorType>(Target)->getElementType().getTypePtr();
1976  }
1977
1978  // Strip complex types.
1979  if (isa<ComplexType>(Source)) {
1980    if (!isa<ComplexType>(Target))
1981      return DiagnoseImpCast(*this, E, T, diag::warn_impcast_complex_scalar);
1982
1983    Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
1984    Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
1985  }
1986
1987  const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
1988  const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
1989
1990  // If the source is floating point...
1991  if (SourceBT && SourceBT->isFloatingPoint()) {
1992    // ...and the target is floating point...
1993    if (TargetBT && TargetBT->isFloatingPoint()) {
1994      // ...then warn if we're dropping FP rank.
1995
1996      // Builtin FP kinds are ordered by increasing FP rank.
1997      if (SourceBT->getKind() > TargetBT->getKind()) {
1998        // Don't warn about float constants that are precisely
1999        // representable in the target type.
2000        Expr::EvalResult result;
2001        if (E->Evaluate(result, Context)) {
2002          // Value might be a float, a float vector, or a float complex.
2003          if (IsSameFloatAfterCast(result.Val,
2004                     Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
2005                     Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
2006            return;
2007        }
2008
2009        DiagnoseImpCast(*this, E, T, diag::warn_impcast_float_precision);
2010      }
2011      return;
2012    }
2013
2014    // If the target is integral, always warn.
2015    if ((TargetBT && TargetBT->isInteger()))
2016      // TODO: don't warn for integer values?
2017      return DiagnoseImpCast(*this, E, T, diag::warn_impcast_float_integer);
2018
2019    return;
2020  }
2021
2022  if (!Source->isIntegerType() || !Target->isIntegerType())
2023    return;
2024
2025  IntRange SourceRange = GetExprRange(Context, E, Context.getIntWidth(E->getType()));
2026  IntRange TargetRange = IntRange::forCanonicalType(Context, Target);
2027
2028  // FIXME: also signed<->unsigned?
2029
2030  if (SourceRange.Width > TargetRange.Width) {
2031    // People want to build with -Wshorten-64-to-32 and not -Wconversion
2032    // and by god we'll let them.
2033    if (SourceRange.Width == 64 && TargetRange.Width == 32)
2034      return DiagnoseImpCast(*this, E, T, diag::warn_impcast_integer_64_32);
2035    return DiagnoseImpCast(*this, E, T, diag::warn_impcast_integer_precision);
2036  }
2037
2038  return;
2039}
2040
2041// MarkLive - Mark all the blocks reachable from e as live.  Returns the total
2042// number of blocks just marked live.
2043static unsigned MarkLive(CFGBlock *e, llvm::BitVector &live) {
2044  unsigned count = 0;
2045  std::queue<CFGBlock*> workq;
2046  // Prep work queue
2047  live.set(e->getBlockID());
2048  ++count;
2049  workq.push(e);
2050  // Solve
2051  while (!workq.empty()) {
2052    CFGBlock *item = workq.front();
2053    workq.pop();
2054    for (CFGBlock::succ_iterator I=item->succ_begin(),
2055           E=item->succ_end();
2056         I != E;
2057         ++I) {
2058      if ((*I) && !live[(*I)->getBlockID()]) {
2059        live.set((*I)->getBlockID());
2060        ++count;
2061        workq.push(*I);
2062      }
2063    }
2064  }
2065  return count;
2066}
2067
2068static SourceLocation GetUnreachableLoc(CFGBlock &b, SourceRange &R1,
2069                                        SourceRange &R2) {
2070  Stmt *S;
2071  unsigned sn = 0;
2072  R1 = R2 = SourceRange();
2073
2074  top:
2075  if (sn < b.size())
2076    S = b[sn].getStmt();
2077  else if (b.getTerminator())
2078    S = b.getTerminator();
2079  else
2080    return SourceLocation();
2081
2082  switch (S->getStmtClass()) {
2083  case Expr::BinaryOperatorClass: {
2084    BinaryOperator *BO = cast<BinaryOperator>(S);
2085    if (BO->getOpcode() == BinaryOperator::Comma) {
2086      if (sn+1 < b.size())
2087        return b[sn+1].getStmt()->getLocStart();
2088      CFGBlock *n = &b;
2089      while (1) {
2090        if (n->getTerminator())
2091          return n->getTerminator()->getLocStart();
2092        if (n->succ_size() != 1)
2093          return SourceLocation();
2094        n = n[0].succ_begin()[0];
2095        if (n->pred_size() != 1)
2096          return SourceLocation();
2097        if (!n->empty())
2098          return n[0][0].getStmt()->getLocStart();
2099      }
2100    }
2101    R1 = BO->getLHS()->getSourceRange();
2102    R2 = BO->getRHS()->getSourceRange();
2103    return BO->getOperatorLoc();
2104  }
2105  case Expr::UnaryOperatorClass: {
2106    const UnaryOperator *UO = cast<UnaryOperator>(S);
2107    R1 = UO->getSubExpr()->getSourceRange();
2108    return UO->getOperatorLoc();
2109  }
2110  case Expr::CompoundAssignOperatorClass: {
2111    const CompoundAssignOperator *CAO = cast<CompoundAssignOperator>(S);
2112    R1 = CAO->getLHS()->getSourceRange();
2113    R2 = CAO->getRHS()->getSourceRange();
2114    return CAO->getOperatorLoc();
2115  }
2116  case Expr::ConditionalOperatorClass: {
2117    const ConditionalOperator *CO = cast<ConditionalOperator>(S);
2118    return CO->getQuestionLoc();
2119  }
2120  case Expr::MemberExprClass: {
2121    const MemberExpr *ME = cast<MemberExpr>(S);
2122    R1 = ME->getSourceRange();
2123    return ME->getMemberLoc();
2124  }
2125  case Expr::ArraySubscriptExprClass: {
2126    const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(S);
2127    R1 = ASE->getLHS()->getSourceRange();
2128    R2 = ASE->getRHS()->getSourceRange();
2129    return ASE->getRBracketLoc();
2130  }
2131  case Expr::CStyleCastExprClass: {
2132    const CStyleCastExpr *CSC = cast<CStyleCastExpr>(S);
2133    R1 = CSC->getSubExpr()->getSourceRange();
2134    return CSC->getLParenLoc();
2135  }
2136  case Expr::CXXFunctionalCastExprClass: {
2137    const CXXFunctionalCastExpr *CE = cast <CXXFunctionalCastExpr>(S);
2138    R1 = CE->getSubExpr()->getSourceRange();
2139    return CE->getTypeBeginLoc();
2140  }
2141  case Expr::ImplicitCastExprClass:
2142    ++sn;
2143    goto top;
2144  case Stmt::CXXTryStmtClass: {
2145    return cast<CXXTryStmt>(S)->getHandler(0)->getCatchLoc();
2146  }
2147  default: ;
2148  }
2149  R1 = S->getSourceRange();
2150  return S->getLocStart();
2151}
2152
2153static SourceLocation MarkLiveTop(CFGBlock *e, llvm::BitVector &live,
2154                               SourceManager &SM) {
2155  std::queue<CFGBlock*> workq;
2156  // Prep work queue
2157  workq.push(e);
2158  SourceRange R1, R2;
2159  SourceLocation top = GetUnreachableLoc(*e, R1, R2);
2160  bool FromMainFile = false;
2161  bool FromSystemHeader = false;
2162  bool TopValid = false;
2163  if (top.isValid()) {
2164    FromMainFile = SM.isFromMainFile(top);
2165    FromSystemHeader = SM.isInSystemHeader(top);
2166    TopValid = true;
2167  }
2168  // Solve
2169  while (!workq.empty()) {
2170    CFGBlock *item = workq.front();
2171    workq.pop();
2172    SourceLocation c = GetUnreachableLoc(*item, R1, R2);
2173    if (c.isValid()
2174        && (!TopValid
2175            || (SM.isFromMainFile(c) && !FromMainFile)
2176            || (FromSystemHeader && !SM.isInSystemHeader(c))
2177            || SM.isBeforeInTranslationUnit(c, top))) {
2178      top = c;
2179      FromMainFile = SM.isFromMainFile(top);
2180      FromSystemHeader = SM.isInSystemHeader(top);
2181    }
2182    live.set(item->getBlockID());
2183    for (CFGBlock::succ_iterator I=item->succ_begin(),
2184           E=item->succ_end();
2185         I != E;
2186         ++I) {
2187      if ((*I) && !live[(*I)->getBlockID()]) {
2188        live.set((*I)->getBlockID());
2189        workq.push(*I);
2190      }
2191    }
2192  }
2193  return top;
2194}
2195
2196static int LineCmp(const void *p1, const void *p2) {
2197  SourceLocation *Line1 = (SourceLocation *)p1;
2198  SourceLocation *Line2 = (SourceLocation *)p2;
2199  return !(*Line1 < *Line2);
2200}
2201
2202namespace {
2203  struct ErrLoc {
2204    SourceLocation Loc;
2205    SourceRange R1;
2206    SourceRange R2;
2207    ErrLoc(SourceLocation l, SourceRange r1, SourceRange r2)
2208      : Loc(l), R1(r1), R2(r2) { }
2209  };
2210}
2211
2212/// CheckUnreachable - Check for unreachable code.
2213void Sema::CheckUnreachable(AnalysisContext &AC) {
2214  unsigned count;
2215  // We avoid checking when there are errors, as the CFG won't faithfully match
2216  // the user's code.
2217  if (getDiagnostics().hasErrorOccurred())
2218    return;
2219  if (Diags.getDiagnosticLevel(diag::warn_unreachable) == Diagnostic::Ignored)
2220    return;
2221
2222  CFG *cfg = AC.getCFG();
2223  if (cfg == 0)
2224    return;
2225
2226  llvm::BitVector live(cfg->getNumBlockIDs());
2227  // Mark all live things first.
2228  count = MarkLive(&cfg->getEntry(), live);
2229
2230  if (count == cfg->getNumBlockIDs())
2231    // If there are no dead blocks, we're done.
2232    return;
2233
2234  SourceRange R1, R2;
2235
2236  llvm::SmallVector<ErrLoc, 24> lines;
2237  bool AddEHEdges = AC.getAddEHEdges();
2238  // First, give warnings for blocks with no predecessors, as they
2239  // can't be part of a loop.
2240  for (CFG::iterator I = cfg->begin(), E = cfg->end(); I != E; ++I) {
2241    CFGBlock &b = **I;
2242    if (!live[b.getBlockID()]) {
2243      if (b.pred_begin() == b.pred_end()) {
2244        if (!AddEHEdges && b.getTerminator()
2245            && isa<CXXTryStmt>(b.getTerminator())) {
2246          // When not adding EH edges from calls, catch clauses
2247          // can otherwise seem dead.  Avoid noting them as dead.
2248          count += MarkLive(&b, live);
2249          continue;
2250        }
2251        SourceLocation c = GetUnreachableLoc(b, R1, R2);
2252        if (!c.isValid()) {
2253          // Blocks without a location can't produce a warning, so don't mark
2254          // reachable blocks from here as live.
2255          live.set(b.getBlockID());
2256          ++count;
2257          continue;
2258        }
2259        lines.push_back(ErrLoc(c, R1, R2));
2260        // Avoid excessive errors by marking everything reachable from here
2261        count += MarkLive(&b, live);
2262      }
2263    }
2264  }
2265
2266  if (count < cfg->getNumBlockIDs()) {
2267    // And then give warnings for the tops of loops.
2268    for (CFG::iterator I = cfg->begin(), E = cfg->end(); I != E; ++I) {
2269      CFGBlock &b = **I;
2270      if (!live[b.getBlockID()])
2271        // Avoid excessive errors by marking everything reachable from here
2272        lines.push_back(ErrLoc(MarkLiveTop(&b, live,
2273                                           Context.getSourceManager()),
2274                               SourceRange(), SourceRange()));
2275    }
2276  }
2277
2278  llvm::array_pod_sort(lines.begin(), lines.end(), LineCmp);
2279  for (llvm::SmallVector<ErrLoc, 24>::iterator I = lines.begin(),
2280         E = lines.end();
2281       I != E;
2282       ++I)
2283    if (I->Loc.isValid())
2284      Diag(I->Loc, diag::warn_unreachable) << I->R1 << I->R2;
2285}
2286
2287/// CheckFallThrough - Check that we don't fall off the end of a
2288/// Statement that should return a value.
2289///
2290/// \returns AlwaysFallThrough iff we always fall off the end of the statement,
2291/// MaybeFallThrough iff we might or might not fall off the end,
2292/// NeverFallThroughOrReturn iff we never fall off the end of the statement or
2293/// return.  We assume NeverFallThrough iff we never fall off the end of the
2294/// statement but we may return.  We assume that functions not marked noreturn
2295/// will return.
2296Sema::ControlFlowKind Sema::CheckFallThrough(AnalysisContext &AC) {
2297  CFG *cfg = AC.getCFG();
2298  if (cfg == 0)
2299    // FIXME: This should be NeverFallThrough
2300    return NeverFallThroughOrReturn;
2301
2302  // The CFG leaves in dead things, and we don't want the dead code paths to
2303  // confuse us, so we mark all live things first.
2304  std::queue<CFGBlock*> workq;
2305  llvm::BitVector live(cfg->getNumBlockIDs());
2306  unsigned count = MarkLive(&cfg->getEntry(), live);
2307
2308  bool AddEHEdges = AC.getAddEHEdges();
2309  if (!AddEHEdges && count != cfg->getNumBlockIDs())
2310    // When there are things remaining dead, and we didn't add EH edges
2311    // from CallExprs to the catch clauses, we have to go back and
2312    // mark them as live.
2313    for (CFG::iterator I = cfg->begin(), E = cfg->end(); I != E; ++I) {
2314      CFGBlock &b = **I;
2315      if (!live[b.getBlockID()]) {
2316        if (b.pred_begin() == b.pred_end()) {
2317          if (b.getTerminator() && isa<CXXTryStmt>(b.getTerminator()))
2318            // When not adding EH edges from calls, catch clauses
2319            // can otherwise seem dead.  Avoid noting them as dead.
2320            count += MarkLive(&b, live);
2321          continue;
2322        }
2323      }
2324    }
2325
2326  // Now we know what is live, we check the live precessors of the exit block
2327  // and look for fall through paths, being careful to ignore normal returns,
2328  // and exceptional paths.
2329  bool HasLiveReturn = false;
2330  bool HasFakeEdge = false;
2331  bool HasPlainEdge = false;
2332  bool HasAbnormalEdge = false;
2333  for (CFGBlock::pred_iterator I=cfg->getExit().pred_begin(),
2334         E = cfg->getExit().pred_end();
2335       I != E;
2336       ++I) {
2337    CFGBlock& B = **I;
2338    if (!live[B.getBlockID()])
2339      continue;
2340    if (B.size() == 0) {
2341      if (B.getTerminator() && isa<CXXTryStmt>(B.getTerminator())) {
2342        HasAbnormalEdge = true;
2343        continue;
2344      }
2345
2346      // A labeled empty statement, or the entry block...
2347      HasPlainEdge = true;
2348      continue;
2349    }
2350    Stmt *S = B[B.size()-1];
2351    if (isa<ReturnStmt>(S)) {
2352      HasLiveReturn = true;
2353      continue;
2354    }
2355    if (isa<ObjCAtThrowStmt>(S)) {
2356      HasFakeEdge = true;
2357      continue;
2358    }
2359    if (isa<CXXThrowExpr>(S)) {
2360      HasFakeEdge = true;
2361      continue;
2362    }
2363    if (const AsmStmt *AS = dyn_cast<AsmStmt>(S)) {
2364      if (AS->isMSAsm()) {
2365        HasFakeEdge = true;
2366        HasLiveReturn = true;
2367        continue;
2368      }
2369    }
2370    if (isa<CXXTryStmt>(S)) {
2371      HasAbnormalEdge = true;
2372      continue;
2373    }
2374
2375    bool NoReturnEdge = false;
2376    if (CallExpr *C = dyn_cast<CallExpr>(S)) {
2377      if (B.succ_begin()[0] != &cfg->getExit()) {
2378        HasAbnormalEdge = true;
2379        continue;
2380      }
2381      Expr *CEE = C->getCallee()->IgnoreParenCasts();
2382      if (CEE->getType().getNoReturnAttr()) {
2383        NoReturnEdge = true;
2384        HasFakeEdge = true;
2385      } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(CEE)) {
2386        ValueDecl *VD = DRE->getDecl();
2387        if (VD->hasAttr<NoReturnAttr>()) {
2388          NoReturnEdge = true;
2389          HasFakeEdge = true;
2390        }
2391      }
2392    }
2393    // FIXME: Add noreturn message sends.
2394    if (NoReturnEdge == false)
2395      HasPlainEdge = true;
2396  }
2397  if (!HasPlainEdge) {
2398    if (HasLiveReturn)
2399      return NeverFallThrough;
2400    return NeverFallThroughOrReturn;
2401  }
2402  if (HasAbnormalEdge || HasFakeEdge || HasLiveReturn)
2403    return MaybeFallThrough;
2404  // This says AlwaysFallThrough for calls to functions that are not marked
2405  // noreturn, that don't return.  If people would like this warning to be more
2406  // accurate, such functions should be marked as noreturn.
2407  return AlwaysFallThrough;
2408}
2409
2410/// CheckFallThroughForFunctionDef - Check that we don't fall off the end of a
2411/// function that should return a value.  Check that we don't fall off the end
2412/// of a noreturn function.  We assume that functions and blocks not marked
2413/// noreturn will return.
2414void Sema::CheckFallThroughForFunctionDef(Decl *D, Stmt *Body,
2415                                          AnalysisContext &AC) {
2416  // FIXME: Would be nice if we had a better way to control cascading errors,
2417  // but for now, avoid them.  The problem is that when Parse sees:
2418  //   int foo() { return a; }
2419  // The return is eaten and the Sema code sees just:
2420  //   int foo() { }
2421  // which this code would then warn about.
2422  if (getDiagnostics().hasErrorOccurred())
2423    return;
2424
2425  bool ReturnsVoid = false;
2426  bool HasNoReturn = false;
2427  if (FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
2428    // If the result type of the function is a dependent type, we don't know
2429    // whether it will be void or not, so don't
2430    if (FD->getResultType()->isDependentType())
2431      return;
2432    if (FD->getResultType()->isVoidType())
2433      ReturnsVoid = true;
2434    if (FD->hasAttr<NoReturnAttr>())
2435      HasNoReturn = true;
2436  } else if (ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
2437    if (MD->getResultType()->isVoidType())
2438      ReturnsVoid = true;
2439    if (MD->hasAttr<NoReturnAttr>())
2440      HasNoReturn = true;
2441  }
2442
2443  // Short circuit for compilation speed.
2444  if ((Diags.getDiagnosticLevel(diag::warn_maybe_falloff_nonvoid_function)
2445       == Diagnostic::Ignored || ReturnsVoid)
2446      && (Diags.getDiagnosticLevel(diag::warn_noreturn_function_has_return_expr)
2447          == Diagnostic::Ignored || !HasNoReturn)
2448      && (Diags.getDiagnosticLevel(diag::warn_suggest_noreturn_block)
2449          == Diagnostic::Ignored || !ReturnsVoid))
2450    return;
2451  // FIXME: Function try block
2452  if (CompoundStmt *Compound = dyn_cast<CompoundStmt>(Body)) {
2453    switch (CheckFallThrough(AC)) {
2454    case MaybeFallThrough:
2455      if (HasNoReturn)
2456        Diag(Compound->getRBracLoc(), diag::warn_falloff_noreturn_function);
2457      else if (!ReturnsVoid)
2458        Diag(Compound->getRBracLoc(),diag::warn_maybe_falloff_nonvoid_function);
2459      break;
2460    case AlwaysFallThrough:
2461      if (HasNoReturn)
2462        Diag(Compound->getRBracLoc(), diag::warn_falloff_noreturn_function);
2463      else if (!ReturnsVoid)
2464        Diag(Compound->getRBracLoc(), diag::warn_falloff_nonvoid_function);
2465      break;
2466    case NeverFallThroughOrReturn:
2467      if (ReturnsVoid && !HasNoReturn)
2468        Diag(Compound->getLBracLoc(), diag::warn_suggest_noreturn_function);
2469      break;
2470    case NeverFallThrough:
2471      break;
2472    }
2473  }
2474}
2475
2476/// CheckFallThroughForBlock - Check that we don't fall off the end of a block
2477/// that should return a value.  Check that we don't fall off the end of a
2478/// noreturn block.  We assume that functions and blocks not marked noreturn
2479/// will return.
2480void Sema::CheckFallThroughForBlock(QualType BlockTy, Stmt *Body,
2481                                    AnalysisContext &AC) {
2482  // FIXME: Would be nice if we had a better way to control cascading errors,
2483  // but for now, avoid them.  The problem is that when Parse sees:
2484  //   int foo() { return a; }
2485  // The return is eaten and the Sema code sees just:
2486  //   int foo() { }
2487  // which this code would then warn about.
2488  if (getDiagnostics().hasErrorOccurred())
2489    return;
2490  bool ReturnsVoid = false;
2491  bool HasNoReturn = false;
2492  if (const FunctionType *FT =BlockTy->getPointeeType()->getAs<FunctionType>()){
2493    if (FT->getResultType()->isVoidType())
2494      ReturnsVoid = true;
2495    if (FT->getNoReturnAttr())
2496      HasNoReturn = true;
2497  }
2498
2499  // Short circuit for compilation speed.
2500  if (ReturnsVoid
2501      && !HasNoReturn
2502      && (Diags.getDiagnosticLevel(diag::warn_suggest_noreturn_block)
2503          == Diagnostic::Ignored || !ReturnsVoid))
2504    return;
2505  // FIXME: Funtion try block
2506  if (CompoundStmt *Compound = dyn_cast<CompoundStmt>(Body)) {
2507    switch (CheckFallThrough(AC)) {
2508    case MaybeFallThrough:
2509      if (HasNoReturn)
2510        Diag(Compound->getRBracLoc(), diag::err_noreturn_block_has_return_expr);
2511      else if (!ReturnsVoid)
2512        Diag(Compound->getRBracLoc(), diag::err_maybe_falloff_nonvoid_block);
2513      break;
2514    case AlwaysFallThrough:
2515      if (HasNoReturn)
2516        Diag(Compound->getRBracLoc(), diag::err_noreturn_block_has_return_expr);
2517      else if (!ReturnsVoid)
2518        Diag(Compound->getRBracLoc(), diag::err_falloff_nonvoid_block);
2519      break;
2520    case NeverFallThroughOrReturn:
2521      if (ReturnsVoid)
2522        Diag(Compound->getLBracLoc(), diag::warn_suggest_noreturn_block);
2523      break;
2524    case NeverFallThrough:
2525      break;
2526    }
2527  }
2528}
2529
2530/// CheckParmsForFunctionDef - Check that the parameters of the given
2531/// function are appropriate for the definition of a function. This
2532/// takes care of any checks that cannot be performed on the
2533/// declaration itself, e.g., that the types of each of the function
2534/// parameters are complete.
2535bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) {
2536  bool HasInvalidParm = false;
2537  for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) {
2538    ParmVarDecl *Param = FD->getParamDecl(p);
2539
2540    // C99 6.7.5.3p4: the parameters in a parameter type list in a
2541    // function declarator that is part of a function definition of
2542    // that function shall not have incomplete type.
2543    //
2544    // This is also C++ [dcl.fct]p6.
2545    if (!Param->isInvalidDecl() &&
2546        RequireCompleteType(Param->getLocation(), Param->getType(),
2547                               diag::err_typecheck_decl_incomplete_type)) {
2548      Param->setInvalidDecl();
2549      HasInvalidParm = true;
2550    }
2551
2552    // C99 6.9.1p5: If the declarator includes a parameter type list, the
2553    // declaration of each parameter shall include an identifier.
2554    if (Param->getIdentifier() == 0 &&
2555        !Param->isImplicit() &&
2556        !getLangOptions().CPlusPlus)
2557      Diag(Param->getLocation(), diag::err_parameter_name_omitted);
2558  }
2559
2560  return HasInvalidParm;
2561}
2562