SemaChecking.cpp revision c09b6a59e02ae265fce51b8c11e2a045bcdaa888
1//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 2// 3// The LLVM Compiler Infrastructure 4// 5// This file is distributed under the University of Illinois Open Source 6// License. See LICENSE.TXT for details. 7// 8//===----------------------------------------------------------------------===// 9// 10// This file implements extra semantic analysis beyond what is enforced 11// by the C type system. 12// 13//===----------------------------------------------------------------------===// 14 15#include "Sema.h" 16#include "clang/Analysis/Analyses/FormatString.h" 17#include "clang/AST/ASTContext.h" 18#include "clang/AST/CharUnits.h" 19#include "clang/AST/DeclObjC.h" 20#include "clang/AST/ExprCXX.h" 21#include "clang/AST/ExprObjC.h" 22#include "clang/AST/DeclObjC.h" 23#include "clang/AST/StmtCXX.h" 24#include "clang/AST/StmtObjC.h" 25#include "clang/Lex/LiteralSupport.h" 26#include "clang/Lex/Preprocessor.h" 27#include "llvm/ADT/BitVector.h" 28#include "llvm/ADT/STLExtras.h" 29#include "llvm/ADT/StringExtras.h" 30#include "llvm/Support/raw_ostream.h" 31#include "clang/Basic/TargetBuiltins.h" 32#include "clang/Basic/TargetInfo.h" 33#include <limits> 34using namespace clang; 35 36/// getLocationOfStringLiteralByte - Return a source location that points to the 37/// specified byte of the specified string literal. 38/// 39/// Strings are amazingly complex. They can be formed from multiple tokens and 40/// can have escape sequences in them in addition to the usual trigraph and 41/// escaped newline business. This routine handles this complexity. 42/// 43SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 44 unsigned ByteNo) const { 45 assert(!SL->isWide() && "This doesn't work for wide strings yet"); 46 47 // Loop over all of the tokens in this string until we find the one that 48 // contains the byte we're looking for. 49 unsigned TokNo = 0; 50 while (1) { 51 assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!"); 52 SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo); 53 54 // Get the spelling of the string so that we can get the data that makes up 55 // the string literal, not the identifier for the macro it is potentially 56 // expanded through. 57 SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc); 58 59 // Re-lex the token to get its length and original spelling. 60 std::pair<FileID, unsigned> LocInfo = 61 SourceMgr.getDecomposedLoc(StrTokSpellingLoc); 62 bool Invalid = false; 63 llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid); 64 if (Invalid) 65 return StrTokSpellingLoc; 66 67 const char *StrData = Buffer.data()+LocInfo.second; 68 69 // Create a langops struct and enable trigraphs. This is sufficient for 70 // relexing tokens. 71 LangOptions LangOpts; 72 LangOpts.Trigraphs = true; 73 74 // Create a lexer starting at the beginning of this token. 75 Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData, 76 Buffer.end()); 77 Token TheTok; 78 TheLexer.LexFromRawLexer(TheTok); 79 80 // Use the StringLiteralParser to compute the length of the string in bytes. 81 StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false); 82 unsigned TokNumBytes = SLP.GetStringLength(); 83 84 // If the byte is in this token, return the location of the byte. 85 if (ByteNo < TokNumBytes || 86 (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) { 87 unsigned Offset = 88 StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP, 89 /*Complain=*/false); 90 91 // Now that we know the offset of the token in the spelling, use the 92 // preprocessor to get the offset in the original source. 93 return PP.AdvanceToTokenCharacter(StrTokLoc, Offset); 94 } 95 96 // Move to the next string token. 97 ++TokNo; 98 ByteNo -= TokNumBytes; 99 } 100} 101 102/// CheckablePrintfAttr - does a function call have a "printf" attribute 103/// and arguments that merit checking? 104bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 105 if (Format->getType() == "printf") return true; 106 if (Format->getType() == "printf0") { 107 // printf0 allows null "format" string; if so don't check format/args 108 unsigned format_idx = Format->getFormatIdx() - 1; 109 // Does the index refer to the implicit object argument? 110 if (isa<CXXMemberCallExpr>(TheCall)) { 111 if (format_idx == 0) 112 return false; 113 --format_idx; 114 } 115 if (format_idx < TheCall->getNumArgs()) { 116 Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 117 if (!Format->isNullPointerConstant(Context, 118 Expr::NPC_ValueDependentIsNull)) 119 return true; 120 } 121 } 122 return false; 123} 124 125Action::OwningExprResult 126Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 127 OwningExprResult TheCallResult(Owned(TheCall)); 128 129 switch (BuiltinID) { 130 case Builtin::BI__builtin___CFStringMakeConstantString: 131 assert(TheCall->getNumArgs() == 1 && 132 "Wrong # arguments to builtin CFStringMakeConstantString"); 133 if (CheckObjCString(TheCall->getArg(0))) 134 return ExprError(); 135 break; 136 case Builtin::BI__builtin_stdarg_start: 137 case Builtin::BI__builtin_va_start: 138 if (SemaBuiltinVAStart(TheCall)) 139 return ExprError(); 140 break; 141 case Builtin::BI__builtin_isgreater: 142 case Builtin::BI__builtin_isgreaterequal: 143 case Builtin::BI__builtin_isless: 144 case Builtin::BI__builtin_islessequal: 145 case Builtin::BI__builtin_islessgreater: 146 case Builtin::BI__builtin_isunordered: 147 if (SemaBuiltinUnorderedCompare(TheCall)) 148 return ExprError(); 149 break; 150 case Builtin::BI__builtin_fpclassify: 151 if (SemaBuiltinFPClassification(TheCall, 6)) 152 return ExprError(); 153 break; 154 case Builtin::BI__builtin_isfinite: 155 case Builtin::BI__builtin_isinf: 156 case Builtin::BI__builtin_isinf_sign: 157 case Builtin::BI__builtin_isnan: 158 case Builtin::BI__builtin_isnormal: 159 if (SemaBuiltinFPClassification(TheCall, 1)) 160 return ExprError(); 161 break; 162 case Builtin::BI__builtin_return_address: 163 case Builtin::BI__builtin_frame_address: { 164 llvm::APSInt Result; 165 if (SemaBuiltinConstantArg(TheCall, 0, Result)) 166 return ExprError(); 167 break; 168 } 169 case Builtin::BI__builtin_eh_return_data_regno: { 170 llvm::APSInt Result; 171 if (SemaBuiltinConstantArg(TheCall, 0, Result)) 172 return ExprError(); 173 break; 174 } 175 case Builtin::BI__builtin_shufflevector: 176 return SemaBuiltinShuffleVector(TheCall); 177 // TheCall will be freed by the smart pointer here, but that's fine, since 178 // SemaBuiltinShuffleVector guts it, but then doesn't release it. 179 case Builtin::BI__builtin_prefetch: 180 if (SemaBuiltinPrefetch(TheCall)) 181 return ExprError(); 182 break; 183 case Builtin::BI__builtin_object_size: 184 if (SemaBuiltinObjectSize(TheCall)) 185 return ExprError(); 186 break; 187 case Builtin::BI__builtin_longjmp: 188 if (SemaBuiltinLongjmp(TheCall)) 189 return ExprError(); 190 break; 191 case Builtin::BI__sync_fetch_and_add: 192 case Builtin::BI__sync_fetch_and_sub: 193 case Builtin::BI__sync_fetch_and_or: 194 case Builtin::BI__sync_fetch_and_and: 195 case Builtin::BI__sync_fetch_and_xor: 196 case Builtin::BI__sync_add_and_fetch: 197 case Builtin::BI__sync_sub_and_fetch: 198 case Builtin::BI__sync_and_and_fetch: 199 case Builtin::BI__sync_or_and_fetch: 200 case Builtin::BI__sync_xor_and_fetch: 201 case Builtin::BI__sync_val_compare_and_swap: 202 case Builtin::BI__sync_bool_compare_and_swap: 203 case Builtin::BI__sync_lock_test_and_set: 204 case Builtin::BI__sync_lock_release: 205 return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 206 } 207 208 // Since the target specific builtins for each arch overlap, only check those 209 // of the arch we are compiling for. 210 if (BuiltinID >= Builtin::FirstTSBuiltin) { 211 switch (Context.Target.getTriple().getArch()) { 212 case llvm::Triple::arm: 213 case llvm::Triple::thumb: 214 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 215 return ExprError(); 216 break; 217 case llvm::Triple::x86: 218 case llvm::Triple::x86_64: 219 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall)) 220 return ExprError(); 221 break; 222 default: 223 break; 224 } 225 } 226 227 return move(TheCallResult); 228} 229 230bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 231 switch (BuiltinID) { 232 case X86::BI__builtin_ia32_palignr128: 233 case X86::BI__builtin_ia32_palignr: { 234 llvm::APSInt Result; 235 if (SemaBuiltinConstantArg(TheCall, 2, Result)) 236 return true; 237 break; 238 } 239 } 240 return false; 241} 242 243// Get the valid immediate range for the specified NEON type code. 244static unsigned RFT(unsigned t, bool shift = false) { 245 bool quad = t & 0x10; 246 247 switch (t & 0x7) { 248 case 0: // i8 249 return shift ? 7 : (8 << (int)quad) - 1; 250 case 1: // i16 251 return shift ? 15 : (4 << (int)quad) - 1; 252 case 2: // i32 253 return shift ? 31 : (2 << (int)quad) - 1; 254 case 3: // i64 255 return shift ? 63 : (1 << (int)quad) - 1; 256 case 4: // f32 257 assert(!shift && "cannot shift float types!"); 258 return (2 << (int)quad) - 1; 259 case 5: // poly8 260 assert(!shift && "cannot shift polynomial types!"); 261 return (8 << (int)quad) - 1; 262 case 6: // poly16 263 assert(!shift && "cannot shift polynomial types!"); 264 return (4 << (int)quad) - 1; 265 case 7: // float16 266 assert(!shift && "cannot shift float types!"); 267 return (4 << (int)quad) - 1; 268 } 269 return 0; 270} 271 272bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 273 llvm::APSInt Result; 274 275 unsigned mask = 0; 276 unsigned TV = 0; 277 switch (BuiltinID) { 278#define GET_NEON_OVERLOAD_CHECK 279#include "clang/Basic/arm_neon.inc" 280#undef GET_NEON_OVERLOAD_CHECK 281 } 282 283 // For NEON intrinsics which are overloaded on vector element type, validate 284 // the immediate which specifies which variant to emit. 285 if (mask) { 286 unsigned ArgNo = TheCall->getNumArgs()-1; 287 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 288 return true; 289 290 TV = Result.getLimitedValue(32); 291 if ((TV > 31) || (mask & (1 << TV)) == 0) 292 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 293 << TheCall->getArg(ArgNo)->getSourceRange(); 294 } 295 296 // For NEON intrinsics which take an immediate value as part of the 297 // instruction, range check them here. 298 unsigned i = 0, l = 0, u = 0; 299 switch (BuiltinID) { 300 default: return false; 301#define GET_NEON_IMMEDIATE_CHECK 302#include "clang/Basic/arm_neon.inc" 303#undef GET_NEON_IMMEDIATE_CHECK 304 }; 305 306 // Check that the immediate argument is actually a constant. 307 if (SemaBuiltinConstantArg(TheCall, i, Result)) 308 return true; 309 310 // Range check against the upper/lower values for this isntruction. 311 unsigned Val = Result.getZExtValue(); 312 if (Val < l || Val > (u + l)) 313 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 314 << llvm::utostr(l) << llvm::utostr(u+l) 315 << TheCall->getArg(i)->getSourceRange(); 316 317 return false; 318} 319 320/// CheckFunctionCall - Check a direct function call for various correctness 321/// and safety properties not strictly enforced by the C type system. 322bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 323 // Get the IdentifierInfo* for the called function. 324 IdentifierInfo *FnInfo = FDecl->getIdentifier(); 325 326 // None of the checks below are needed for functions that don't have 327 // simple names (e.g., C++ conversion functions). 328 if (!FnInfo) 329 return false; 330 331 // FIXME: This mechanism should be abstracted to be less fragile and 332 // more efficient. For example, just map function ids to custom 333 // handlers. 334 335 // Printf checking. 336 if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) { 337 const bool b = Format->getType() == "scanf"; 338 if (b || CheckablePrintfAttr(Format, TheCall)) { 339 bool HasVAListArg = Format->getFirstArg() == 0; 340 CheckPrintfScanfArguments(TheCall, HasVAListArg, 341 Format->getFormatIdx() - 1, 342 HasVAListArg ? 0 : Format->getFirstArg() - 1, 343 !b); 344 } 345 } 346 347 for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull; 348 NonNull = NonNull->getNext<NonNullAttr>()) 349 CheckNonNullArguments(NonNull, TheCall); 350 351 return false; 352} 353 354bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 355 // Printf checking. 356 const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 357 if (!Format) 358 return false; 359 360 const VarDecl *V = dyn_cast<VarDecl>(NDecl); 361 if (!V) 362 return false; 363 364 QualType Ty = V->getType(); 365 if (!Ty->isBlockPointerType()) 366 return false; 367 368 const bool b = Format->getType() == "scanf"; 369 if (!b && !CheckablePrintfAttr(Format, TheCall)) 370 return false; 371 372 bool HasVAListArg = Format->getFirstArg() == 0; 373 CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 374 HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 375 376 return false; 377} 378 379/// SemaBuiltinAtomicOverloaded - We have a call to a function like 380/// __sync_fetch_and_add, which is an overloaded function based on the pointer 381/// type of its first argument. The main ActOnCallExpr routines have already 382/// promoted the types of arguments because all of these calls are prototyped as 383/// void(...). 384/// 385/// This function goes through and does final semantic checking for these 386/// builtins, 387Sema::OwningExprResult 388Sema::SemaBuiltinAtomicOverloaded(OwningExprResult TheCallResult) { 389 CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 390 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 391 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 392 393 // Ensure that we have at least one argument to do type inference from. 394 if (TheCall->getNumArgs() < 1) { 395 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 396 << 0 << 1 << TheCall->getNumArgs() 397 << TheCall->getCallee()->getSourceRange(); 398 return ExprError(); 399 } 400 401 // Inspect the first argument of the atomic builtin. This should always be 402 // a pointer type, whose element is an integral scalar or pointer type. 403 // Because it is a pointer type, we don't have to worry about any implicit 404 // casts here. 405 // FIXME: We don't allow floating point scalars as input. 406 Expr *FirstArg = TheCall->getArg(0); 407 if (!FirstArg->getType()->isPointerType()) { 408 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 409 << FirstArg->getType() << FirstArg->getSourceRange(); 410 return ExprError(); 411 } 412 413 QualType ValType = 414 FirstArg->getType()->getAs<PointerType>()->getPointeeType(); 415 if (!ValType->isIntegerType() && !ValType->isPointerType() && 416 !ValType->isBlockPointerType()) { 417 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 418 << FirstArg->getType() << FirstArg->getSourceRange(); 419 return ExprError(); 420 } 421 422 // The majority of builtins return a value, but a few have special return 423 // types, so allow them to override appropriately below. 424 QualType ResultType = ValType; 425 426 // We need to figure out which concrete builtin this maps onto. For example, 427 // __sync_fetch_and_add with a 2 byte object turns into 428 // __sync_fetch_and_add_2. 429#define BUILTIN_ROW(x) \ 430 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 431 Builtin::BI##x##_8, Builtin::BI##x##_16 } 432 433 static const unsigned BuiltinIndices[][5] = { 434 BUILTIN_ROW(__sync_fetch_and_add), 435 BUILTIN_ROW(__sync_fetch_and_sub), 436 BUILTIN_ROW(__sync_fetch_and_or), 437 BUILTIN_ROW(__sync_fetch_and_and), 438 BUILTIN_ROW(__sync_fetch_and_xor), 439 440 BUILTIN_ROW(__sync_add_and_fetch), 441 BUILTIN_ROW(__sync_sub_and_fetch), 442 BUILTIN_ROW(__sync_and_and_fetch), 443 BUILTIN_ROW(__sync_or_and_fetch), 444 BUILTIN_ROW(__sync_xor_and_fetch), 445 446 BUILTIN_ROW(__sync_val_compare_and_swap), 447 BUILTIN_ROW(__sync_bool_compare_and_swap), 448 BUILTIN_ROW(__sync_lock_test_and_set), 449 BUILTIN_ROW(__sync_lock_release) 450 }; 451#undef BUILTIN_ROW 452 453 // Determine the index of the size. 454 unsigned SizeIndex; 455 switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 456 case 1: SizeIndex = 0; break; 457 case 2: SizeIndex = 1; break; 458 case 4: SizeIndex = 2; break; 459 case 8: SizeIndex = 3; break; 460 case 16: SizeIndex = 4; break; 461 default: 462 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 463 << FirstArg->getType() << FirstArg->getSourceRange(); 464 return ExprError(); 465 } 466 467 // Each of these builtins has one pointer argument, followed by some number of 468 // values (0, 1 or 2) followed by a potentially empty varags list of stuff 469 // that we ignore. Find out which row of BuiltinIndices to read from as well 470 // as the number of fixed args. 471 unsigned BuiltinID = FDecl->getBuiltinID(); 472 unsigned BuiltinIndex, NumFixed = 1; 473 switch (BuiltinID) { 474 default: assert(0 && "Unknown overloaded atomic builtin!"); 475 case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 476 case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 477 case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 478 case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 479 case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 480 481 case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 482 case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 483 case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 484 case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 485 case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 486 487 case Builtin::BI__sync_val_compare_and_swap: 488 BuiltinIndex = 10; 489 NumFixed = 2; 490 break; 491 case Builtin::BI__sync_bool_compare_and_swap: 492 BuiltinIndex = 11; 493 NumFixed = 2; 494 ResultType = Context.BoolTy; 495 break; 496 case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 497 case Builtin::BI__sync_lock_release: 498 BuiltinIndex = 13; 499 NumFixed = 0; 500 ResultType = Context.VoidTy; 501 break; 502 } 503 504 // Now that we know how many fixed arguments we expect, first check that we 505 // have at least that many. 506 if (TheCall->getNumArgs() < 1+NumFixed) { 507 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 508 << 0 << 1+NumFixed << TheCall->getNumArgs() 509 << TheCall->getCallee()->getSourceRange(); 510 return ExprError(); 511 } 512 513 // Get the decl for the concrete builtin from this, we can tell what the 514 // concrete integer type we should convert to is. 515 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 516 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 517 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 518 FunctionDecl *NewBuiltinDecl = 519 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 520 TUScope, false, DRE->getLocStart())); 521 522 // The first argument is by definition correct, we use it's type as the type 523 // of the entire operation. Walk the remaining arguments promoting them to 524 // the deduced value type. 525 for (unsigned i = 0; i != NumFixed; ++i) { 526 Expr *Arg = TheCall->getArg(i+1); 527 528 // If the argument is an implicit cast, then there was a promotion due to 529 // "...", just remove it now. 530 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) { 531 Arg = ICE->getSubExpr(); 532 ICE->setSubExpr(0); 533 ICE->Destroy(Context); 534 TheCall->setArg(i+1, Arg); 535 } 536 537 // GCC does an implicit conversion to the pointer or integer ValType. This 538 // can fail in some cases (1i -> int**), check for this error case now. 539 CastExpr::CastKind Kind = CastExpr::CK_Unknown; 540 CXXBaseSpecifierArray BasePath; 541 if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath)) 542 return ExprError(); 543 544 // Okay, we have something that *can* be converted to the right type. Check 545 // to see if there is a potentially weird extension going on here. This can 546 // happen when you do an atomic operation on something like an char* and 547 // pass in 42. The 42 gets converted to char. This is even more strange 548 // for things like 45.123 -> char, etc. 549 // FIXME: Do this check. 550 ImpCastExprToType(Arg, ValType, Kind); 551 TheCall->setArg(i+1, Arg); 552 } 553 554 // Switch the DeclRefExpr to refer to the new decl. 555 DRE->setDecl(NewBuiltinDecl); 556 DRE->setType(NewBuiltinDecl->getType()); 557 558 // Set the callee in the CallExpr. 559 // FIXME: This leaks the original parens and implicit casts. 560 Expr *PromotedCall = DRE; 561 UsualUnaryConversions(PromotedCall); 562 TheCall->setCallee(PromotedCall); 563 564 // Change the result type of the call to match the original value type. This 565 // is arbitrary, but the codegen for these builtins ins design to handle it 566 // gracefully. 567 TheCall->setType(ResultType); 568 569 return move(TheCallResult); 570} 571 572 573/// CheckObjCString - Checks that the argument to the builtin 574/// CFString constructor is correct 575/// FIXME: GCC currently emits the following warning: 576/// "warning: input conversion stopped due to an input byte that does not 577/// belong to the input codeset UTF-8" 578/// Note: It might also make sense to do the UTF-16 conversion here (would 579/// simplify the backend). 580bool Sema::CheckObjCString(Expr *Arg) { 581 Arg = Arg->IgnoreParenCasts(); 582 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 583 584 if (!Literal || Literal->isWide()) { 585 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 586 << Arg->getSourceRange(); 587 return true; 588 } 589 590 const char *Data = Literal->getStrData(); 591 unsigned Length = Literal->getByteLength(); 592 593 for (unsigned i = 0; i < Length; ++i) { 594 if (!Data[i]) { 595 Diag(getLocationOfStringLiteralByte(Literal, i), 596 diag::warn_cfstring_literal_contains_nul_character) 597 << Arg->getSourceRange(); 598 break; 599 } 600 } 601 602 return false; 603} 604 605/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 606/// Emit an error and return true on failure, return false on success. 607bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 608 Expr *Fn = TheCall->getCallee(); 609 if (TheCall->getNumArgs() > 2) { 610 Diag(TheCall->getArg(2)->getLocStart(), 611 diag::err_typecheck_call_too_many_args) 612 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 613 << Fn->getSourceRange() 614 << SourceRange(TheCall->getArg(2)->getLocStart(), 615 (*(TheCall->arg_end()-1))->getLocEnd()); 616 return true; 617 } 618 619 if (TheCall->getNumArgs() < 2) { 620 return Diag(TheCall->getLocEnd(), 621 diag::err_typecheck_call_too_few_args_at_least) 622 << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 623 } 624 625 // Determine whether the current function is variadic or not. 626 BlockScopeInfo *CurBlock = getCurBlock(); 627 bool isVariadic; 628 if (CurBlock) 629 isVariadic = CurBlock->TheDecl->isVariadic(); 630 else if (FunctionDecl *FD = getCurFunctionDecl()) 631 isVariadic = FD->isVariadic(); 632 else 633 isVariadic = getCurMethodDecl()->isVariadic(); 634 635 if (!isVariadic) { 636 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 637 return true; 638 } 639 640 // Verify that the second argument to the builtin is the last argument of the 641 // current function or method. 642 bool SecondArgIsLastNamedArgument = false; 643 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 644 645 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 646 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 647 // FIXME: This isn't correct for methods (results in bogus warning). 648 // Get the last formal in the current function. 649 const ParmVarDecl *LastArg; 650 if (CurBlock) 651 LastArg = *(CurBlock->TheDecl->param_end()-1); 652 else if (FunctionDecl *FD = getCurFunctionDecl()) 653 LastArg = *(FD->param_end()-1); 654 else 655 LastArg = *(getCurMethodDecl()->param_end()-1); 656 SecondArgIsLastNamedArgument = PV == LastArg; 657 } 658 } 659 660 if (!SecondArgIsLastNamedArgument) 661 Diag(TheCall->getArg(1)->getLocStart(), 662 diag::warn_second_parameter_of_va_start_not_last_named_argument); 663 return false; 664} 665 666/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 667/// friends. This is declared to take (...), so we have to check everything. 668bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 669 if (TheCall->getNumArgs() < 2) 670 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 671 << 0 << 2 << TheCall->getNumArgs()/*function call*/; 672 if (TheCall->getNumArgs() > 2) 673 return Diag(TheCall->getArg(2)->getLocStart(), 674 diag::err_typecheck_call_too_many_args) 675 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 676 << SourceRange(TheCall->getArg(2)->getLocStart(), 677 (*(TheCall->arg_end()-1))->getLocEnd()); 678 679 Expr *OrigArg0 = TheCall->getArg(0); 680 Expr *OrigArg1 = TheCall->getArg(1); 681 682 // Do standard promotions between the two arguments, returning their common 683 // type. 684 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 685 686 // Make sure any conversions are pushed back into the call; this is 687 // type safe since unordered compare builtins are declared as "_Bool 688 // foo(...)". 689 TheCall->setArg(0, OrigArg0); 690 TheCall->setArg(1, OrigArg1); 691 692 if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent()) 693 return false; 694 695 // If the common type isn't a real floating type, then the arguments were 696 // invalid for this operation. 697 if (!Res->isRealFloatingType()) 698 return Diag(OrigArg0->getLocStart(), 699 diag::err_typecheck_call_invalid_ordered_compare) 700 << OrigArg0->getType() << OrigArg1->getType() 701 << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd()); 702 703 return false; 704} 705 706/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 707/// __builtin_isnan and friends. This is declared to take (...), so we have 708/// to check everything. We expect the last argument to be a floating point 709/// value. 710bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 711 if (TheCall->getNumArgs() < NumArgs) 712 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 713 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 714 if (TheCall->getNumArgs() > NumArgs) 715 return Diag(TheCall->getArg(NumArgs)->getLocStart(), 716 diag::err_typecheck_call_too_many_args) 717 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 718 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 719 (*(TheCall->arg_end()-1))->getLocEnd()); 720 721 Expr *OrigArg = TheCall->getArg(NumArgs-1); 722 723 if (OrigArg->isTypeDependent()) 724 return false; 725 726 // This operation requires a non-_Complex floating-point number. 727 if (!OrigArg->getType()->isRealFloatingType()) 728 return Diag(OrigArg->getLocStart(), 729 diag::err_typecheck_call_invalid_unary_fp) 730 << OrigArg->getType() << OrigArg->getSourceRange(); 731 732 // If this is an implicit conversion from float -> double, remove it. 733 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 734 Expr *CastArg = Cast->getSubExpr(); 735 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 736 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 737 "promotion from float to double is the only expected cast here"); 738 Cast->setSubExpr(0); 739 Cast->Destroy(Context); 740 TheCall->setArg(NumArgs-1, CastArg); 741 OrigArg = CastArg; 742 } 743 } 744 745 return false; 746} 747 748/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 749// This is declared to take (...), so we have to check everything. 750Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 751 if (TheCall->getNumArgs() < 2) 752 return ExprError(Diag(TheCall->getLocEnd(), 753 diag::err_typecheck_call_too_few_args_at_least) 754 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 755 << TheCall->getSourceRange()); 756 757 // Determine which of the following types of shufflevector we're checking: 758 // 1) unary, vector mask: (lhs, mask) 759 // 2) binary, vector mask: (lhs, rhs, mask) 760 // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 761 QualType resType = TheCall->getArg(0)->getType(); 762 unsigned numElements = 0; 763 764 if (!TheCall->getArg(0)->isTypeDependent() && 765 !TheCall->getArg(1)->isTypeDependent()) { 766 QualType LHSType = TheCall->getArg(0)->getType(); 767 QualType RHSType = TheCall->getArg(1)->getType(); 768 769 if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 770 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 771 << SourceRange(TheCall->getArg(0)->getLocStart(), 772 TheCall->getArg(1)->getLocEnd()); 773 return ExprError(); 774 } 775 776 numElements = LHSType->getAs<VectorType>()->getNumElements(); 777 unsigned numResElements = TheCall->getNumArgs() - 2; 778 779 // Check to see if we have a call with 2 vector arguments, the unary shuffle 780 // with mask. If so, verify that RHS is an integer vector type with the 781 // same number of elts as lhs. 782 if (TheCall->getNumArgs() == 2) { 783 if (!RHSType->isIntegerType() || 784 RHSType->getAs<VectorType>()->getNumElements() != numElements) 785 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 786 << SourceRange(TheCall->getArg(1)->getLocStart(), 787 TheCall->getArg(1)->getLocEnd()); 788 numResElements = numElements; 789 } 790 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 791 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 792 << SourceRange(TheCall->getArg(0)->getLocStart(), 793 TheCall->getArg(1)->getLocEnd()); 794 return ExprError(); 795 } else if (numElements != numResElements) { 796 QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 797 resType = Context.getVectorType(eltType, numResElements, 798 VectorType::NotAltiVec); 799 } 800 } 801 802 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 803 if (TheCall->getArg(i)->isTypeDependent() || 804 TheCall->getArg(i)->isValueDependent()) 805 continue; 806 807 llvm::APSInt Result(32); 808 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 809 return ExprError(Diag(TheCall->getLocStart(), 810 diag::err_shufflevector_nonconstant_argument) 811 << TheCall->getArg(i)->getSourceRange()); 812 813 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 814 return ExprError(Diag(TheCall->getLocStart(), 815 diag::err_shufflevector_argument_too_large) 816 << TheCall->getArg(i)->getSourceRange()); 817 } 818 819 llvm::SmallVector<Expr*, 32> exprs; 820 821 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 822 exprs.push_back(TheCall->getArg(i)); 823 TheCall->setArg(i, 0); 824 } 825 826 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 827 exprs.size(), resType, 828 TheCall->getCallee()->getLocStart(), 829 TheCall->getRParenLoc())); 830} 831 832/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 833// This is declared to take (const void*, ...) and can take two 834// optional constant int args. 835bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 836 unsigned NumArgs = TheCall->getNumArgs(); 837 838 if (NumArgs > 3) 839 return Diag(TheCall->getLocEnd(), 840 diag::err_typecheck_call_too_many_args_at_most) 841 << 0 /*function call*/ << 3 << NumArgs 842 << TheCall->getSourceRange(); 843 844 // Argument 0 is checked for us and the remaining arguments must be 845 // constant integers. 846 for (unsigned i = 1; i != NumArgs; ++i) { 847 Expr *Arg = TheCall->getArg(i); 848 849 llvm::APSInt Result; 850 if (SemaBuiltinConstantArg(TheCall, i, Result)) 851 return true; 852 853 // FIXME: gcc issues a warning and rewrites these to 0. These 854 // seems especially odd for the third argument since the default 855 // is 3. 856 if (i == 1) { 857 if (Result.getLimitedValue() > 1) 858 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 859 << "0" << "1" << Arg->getSourceRange(); 860 } else { 861 if (Result.getLimitedValue() > 3) 862 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 863 << "0" << "3" << Arg->getSourceRange(); 864 } 865 } 866 867 return false; 868} 869 870/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 871/// TheCall is a constant expression. 872bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 873 llvm::APSInt &Result) { 874 Expr *Arg = TheCall->getArg(ArgNum); 875 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 876 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 877 878 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 879 880 if (!Arg->isIntegerConstantExpr(Result, Context)) 881 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 882 << FDecl->getDeclName() << Arg->getSourceRange(); 883 884 return false; 885} 886 887/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 888/// int type). This simply type checks that type is one of the defined 889/// constants (0-3). 890// For compatability check 0-3, llvm only handles 0 and 2. 891bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 892 llvm::APSInt Result; 893 894 // Check constant-ness first. 895 if (SemaBuiltinConstantArg(TheCall, 1, Result)) 896 return true; 897 898 Expr *Arg = TheCall->getArg(1); 899 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 900 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 901 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 902 } 903 904 return false; 905} 906 907/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 908/// This checks that val is a constant 1. 909bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 910 Expr *Arg = TheCall->getArg(1); 911 llvm::APSInt Result; 912 913 // TODO: This is less than ideal. Overload this to take a value. 914 if (SemaBuiltinConstantArg(TheCall, 1, Result)) 915 return true; 916 917 if (Result != 1) 918 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 919 << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 920 921 return false; 922} 923 924// Handle i > 1 ? "x" : "y", recursivelly 925bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 926 bool HasVAListArg, 927 unsigned format_idx, unsigned firstDataArg, 928 bool isPrintf) { 929 930 if (E->isTypeDependent() || E->isValueDependent()) 931 return false; 932 933 switch (E->getStmtClass()) { 934 case Stmt::ConditionalOperatorClass: { 935 const ConditionalOperator *C = cast<ConditionalOperator>(E); 936 return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 937 format_idx, firstDataArg, isPrintf) 938 && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg, 939 format_idx, firstDataArg, isPrintf); 940 } 941 942 case Stmt::ImplicitCastExprClass: { 943 const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E); 944 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg, 945 format_idx, firstDataArg, isPrintf); 946 } 947 948 case Stmt::ParenExprClass: { 949 const ParenExpr *Expr = cast<ParenExpr>(E); 950 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg, 951 format_idx, firstDataArg, isPrintf); 952 } 953 954 case Stmt::DeclRefExprClass: { 955 const DeclRefExpr *DR = cast<DeclRefExpr>(E); 956 957 // As an exception, do not flag errors for variables binding to 958 // const string literals. 959 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 960 bool isConstant = false; 961 QualType T = DR->getType(); 962 963 if (const ArrayType *AT = Context.getAsArrayType(T)) { 964 isConstant = AT->getElementType().isConstant(Context); 965 } else if (const PointerType *PT = T->getAs<PointerType>()) { 966 isConstant = T.isConstant(Context) && 967 PT->getPointeeType().isConstant(Context); 968 } 969 970 if (isConstant) { 971 if (const Expr *Init = VD->getAnyInitializer()) 972 return SemaCheckStringLiteral(Init, TheCall, 973 HasVAListArg, format_idx, firstDataArg, 974 isPrintf); 975 } 976 977 // For vprintf* functions (i.e., HasVAListArg==true), we add a 978 // special check to see if the format string is a function parameter 979 // of the function calling the printf function. If the function 980 // has an attribute indicating it is a printf-like function, then we 981 // should suppress warnings concerning non-literals being used in a call 982 // to a vprintf function. For example: 983 // 984 // void 985 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 986 // va_list ap; 987 // va_start(ap, fmt); 988 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 989 // ... 990 // 991 // 992 // FIXME: We don't have full attribute support yet, so just check to see 993 // if the argument is a DeclRefExpr that references a parameter. We'll 994 // add proper support for checking the attribute later. 995 if (HasVAListArg) 996 if (isa<ParmVarDecl>(VD)) 997 return true; 998 } 999 1000 return false; 1001 } 1002 1003 case Stmt::CallExprClass: { 1004 const CallExpr *CE = cast<CallExpr>(E); 1005 if (const ImplicitCastExpr *ICE 1006 = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 1007 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 1008 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 1009 if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 1010 unsigned ArgIndex = FA->getFormatIdx(); 1011 const Expr *Arg = CE->getArg(ArgIndex - 1); 1012 1013 return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 1014 format_idx, firstDataArg, isPrintf); 1015 } 1016 } 1017 } 1018 } 1019 1020 return false; 1021 } 1022 case Stmt::ObjCStringLiteralClass: 1023 case Stmt::StringLiteralClass: { 1024 const StringLiteral *StrE = NULL; 1025 1026 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1027 StrE = ObjCFExpr->getString(); 1028 else 1029 StrE = cast<StringLiteral>(E); 1030 1031 if (StrE) { 1032 CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1033 firstDataArg, isPrintf); 1034 return true; 1035 } 1036 1037 return false; 1038 } 1039 1040 default: 1041 return false; 1042 } 1043} 1044 1045void 1046Sema::CheckNonNullArguments(const NonNullAttr *NonNull, 1047 const CallExpr *TheCall) { 1048 for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end(); 1049 i != e; ++i) { 1050 const Expr *ArgExpr = TheCall->getArg(*i); 1051 if (ArgExpr->isNullPointerConstant(Context, 1052 Expr::NPC_ValueDependentIsNotNull)) 1053 Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg) 1054 << ArgExpr->getSourceRange(); 1055 } 1056} 1057 1058/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1059/// functions) for correct use of format strings. 1060void 1061Sema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1062 unsigned format_idx, unsigned firstDataArg, 1063 bool isPrintf) { 1064 1065 const Expr *Fn = TheCall->getCallee(); 1066 1067 // The way the format attribute works in GCC, the implicit this argument 1068 // of member functions is counted. However, it doesn't appear in our own 1069 // lists, so decrement format_idx in that case. 1070 if (isa<CXXMemberCallExpr>(TheCall)) { 1071 // Catch a format attribute mistakenly referring to the object argument. 1072 if (format_idx == 0) 1073 return; 1074 --format_idx; 1075 if(firstDataArg != 0) 1076 --firstDataArg; 1077 } 1078 1079 // CHECK: printf/scanf-like function is called with no format string. 1080 if (format_idx >= TheCall->getNumArgs()) { 1081 Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1082 << Fn->getSourceRange(); 1083 return; 1084 } 1085 1086 const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 1087 1088 // CHECK: format string is not a string literal. 1089 // 1090 // Dynamically generated format strings are difficult to 1091 // automatically vet at compile time. Requiring that format strings 1092 // are string literals: (1) permits the checking of format strings by 1093 // the compiler and thereby (2) can practically remove the source of 1094 // many format string exploits. 1095 1096 // Format string can be either ObjC string (e.g. @"%d") or 1097 // C string (e.g. "%d") 1098 // ObjC string uses the same format specifiers as C string, so we can use 1099 // the same format string checking logic for both ObjC and C strings. 1100 if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1101 firstDataArg, isPrintf)) 1102 return; // Literal format string found, check done! 1103 1104 // If there are no arguments specified, warn with -Wformat-security, otherwise 1105 // warn only with -Wformat-nonliteral. 1106 if (TheCall->getNumArgs() == format_idx+1) 1107 Diag(TheCall->getArg(format_idx)->getLocStart(), 1108 diag::warn_format_nonliteral_noargs) 1109 << OrigFormatExpr->getSourceRange(); 1110 else 1111 Diag(TheCall->getArg(format_idx)->getLocStart(), 1112 diag::warn_format_nonliteral) 1113 << OrigFormatExpr->getSourceRange(); 1114} 1115 1116namespace { 1117class CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1118protected: 1119 Sema &S; 1120 const StringLiteral *FExpr; 1121 const Expr *OrigFormatExpr; 1122 const unsigned FirstDataArg; 1123 const unsigned NumDataArgs; 1124 const bool IsObjCLiteral; 1125 const char *Beg; // Start of format string. 1126 const bool HasVAListArg; 1127 const CallExpr *TheCall; 1128 unsigned FormatIdx; 1129 llvm::BitVector CoveredArgs; 1130 bool usesPositionalArgs; 1131 bool atFirstArg; 1132public: 1133 CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 1134 const Expr *origFormatExpr, unsigned firstDataArg, 1135 unsigned numDataArgs, bool isObjCLiteral, 1136 const char *beg, bool hasVAListArg, 1137 const CallExpr *theCall, unsigned formatIdx) 1138 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 1139 FirstDataArg(firstDataArg), 1140 NumDataArgs(numDataArgs), 1141 IsObjCLiteral(isObjCLiteral), Beg(beg), 1142 HasVAListArg(hasVAListArg), 1143 TheCall(theCall), FormatIdx(formatIdx), 1144 usesPositionalArgs(false), atFirstArg(true) { 1145 CoveredArgs.resize(numDataArgs); 1146 CoveredArgs.reset(); 1147 } 1148 1149 void DoneProcessing(); 1150 1151 void HandleIncompleteSpecifier(const char *startSpecifier, 1152 unsigned specifierLen); 1153 1154 virtual void HandleInvalidPosition(const char *startSpecifier, 1155 unsigned specifierLen, 1156 analyze_format_string::PositionContext p); 1157 1158 virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1159 1160 void HandleNullChar(const char *nullCharacter); 1161 1162protected: 1163 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1164 const char *startSpec, 1165 unsigned specifierLen, 1166 const char *csStart, unsigned csLen); 1167 1168 SourceRange getFormatStringRange(); 1169 CharSourceRange getSpecifierRange(const char *startSpecifier, 1170 unsigned specifierLen); 1171 SourceLocation getLocationOfByte(const char *x); 1172 1173 const Expr *getDataArg(unsigned i) const; 1174}; 1175} 1176 1177SourceRange CheckFormatHandler::getFormatStringRange() { 1178 return OrigFormatExpr->getSourceRange(); 1179} 1180 1181CharSourceRange CheckFormatHandler:: 1182getSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 1183 SourceLocation Start = getLocationOfByte(startSpecifier); 1184 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 1185 1186 // Advance the end SourceLocation by one due to half-open ranges. 1187 End = End.getFileLocWithOffset(1); 1188 1189 return CharSourceRange::getCharRange(Start, End); 1190} 1191 1192SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 1193 return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1194} 1195 1196void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1197 unsigned specifierLen){ 1198 SourceLocation Loc = getLocationOfByte(startSpecifier); 1199 S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1200 << getSpecifierRange(startSpecifier, specifierLen); 1201} 1202 1203void 1204CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1205 analyze_format_string::PositionContext p) { 1206 SourceLocation Loc = getLocationOfByte(startPos); 1207 S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1208 << (unsigned) p << getSpecifierRange(startPos, posLen); 1209} 1210 1211void CheckFormatHandler::HandleZeroPosition(const char *startPos, 1212 unsigned posLen) { 1213 SourceLocation Loc = getLocationOfByte(startPos); 1214 S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1215 << getSpecifierRange(startPos, posLen); 1216} 1217 1218void CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 1219 // The presence of a null character is likely an error. 1220 S.Diag(getLocationOfByte(nullCharacter), 1221 diag::warn_printf_format_string_contains_null_char) 1222 << getFormatStringRange(); 1223} 1224 1225const Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1226 return TheCall->getArg(FirstDataArg + i); 1227} 1228 1229void CheckFormatHandler::DoneProcessing() { 1230 // Does the number of data arguments exceed the number of 1231 // format conversions in the format string? 1232 if (!HasVAListArg) { 1233 // Find any arguments that weren't covered. 1234 CoveredArgs.flip(); 1235 signed notCoveredArg = CoveredArgs.find_first(); 1236 if (notCoveredArg >= 0) { 1237 assert((unsigned)notCoveredArg < NumDataArgs); 1238 S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1239 diag::warn_printf_data_arg_not_used) 1240 << getFormatStringRange(); 1241 } 1242 } 1243} 1244 1245bool 1246CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1247 SourceLocation Loc, 1248 const char *startSpec, 1249 unsigned specifierLen, 1250 const char *csStart, 1251 unsigned csLen) { 1252 1253 bool keepGoing = true; 1254 if (argIndex < NumDataArgs) { 1255 // Consider the argument coverered, even though the specifier doesn't 1256 // make sense. 1257 CoveredArgs.set(argIndex); 1258 } 1259 else { 1260 // If argIndex exceeds the number of data arguments we 1261 // don't issue a warning because that is just a cascade of warnings (and 1262 // they may have intended '%%' anyway). We don't want to continue processing 1263 // the format string after this point, however, as we will like just get 1264 // gibberish when trying to match arguments. 1265 keepGoing = false; 1266 } 1267 1268 S.Diag(Loc, diag::warn_format_invalid_conversion) 1269 << llvm::StringRef(csStart, csLen) 1270 << getSpecifierRange(startSpec, specifierLen); 1271 1272 return keepGoing; 1273} 1274 1275//===--- CHECK: Printf format string checking ------------------------------===// 1276 1277namespace { 1278class CheckPrintfHandler : public CheckFormatHandler { 1279public: 1280 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1281 const Expr *origFormatExpr, unsigned firstDataArg, 1282 unsigned numDataArgs, bool isObjCLiteral, 1283 const char *beg, bool hasVAListArg, 1284 const CallExpr *theCall, unsigned formatIdx) 1285 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1286 numDataArgs, isObjCLiteral, beg, hasVAListArg, 1287 theCall, formatIdx) {} 1288 1289 1290 bool HandleInvalidPrintfConversionSpecifier( 1291 const analyze_printf::PrintfSpecifier &FS, 1292 const char *startSpecifier, 1293 unsigned specifierLen); 1294 1295 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1296 const char *startSpecifier, 1297 unsigned specifierLen); 1298 1299 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1300 const char *startSpecifier, unsigned specifierLen); 1301 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1302 const analyze_printf::OptionalAmount &Amt, 1303 unsigned type, 1304 const char *startSpecifier, unsigned specifierLen); 1305 void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1306 const analyze_printf::OptionalFlag &flag, 1307 const char *startSpecifier, unsigned specifierLen); 1308 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1309 const analyze_printf::OptionalFlag &ignoredFlag, 1310 const analyze_printf::OptionalFlag &flag, 1311 const char *startSpecifier, unsigned specifierLen); 1312}; 1313} 1314 1315bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1316 const analyze_printf::PrintfSpecifier &FS, 1317 const char *startSpecifier, 1318 unsigned specifierLen) { 1319 const analyze_printf::ConversionSpecifier &CS = 1320 FS.getConversionSpecifier(); 1321 1322 return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1323 getLocationOfByte(CS.getStart()), 1324 startSpecifier, specifierLen, 1325 CS.getStart(), CS.getLength()); 1326} 1327 1328bool CheckPrintfHandler::HandleAmount( 1329 const analyze_format_string::OptionalAmount &Amt, 1330 unsigned k, const char *startSpecifier, 1331 unsigned specifierLen) { 1332 1333 if (Amt.hasDataArgument()) { 1334 if (!HasVAListArg) { 1335 unsigned argIndex = Amt.getArgIndex(); 1336 if (argIndex >= NumDataArgs) { 1337 S.Diag(getLocationOfByte(Amt.getStart()), 1338 diag::warn_printf_asterisk_missing_arg) 1339 << k << getSpecifierRange(startSpecifier, specifierLen); 1340 // Don't do any more checking. We will just emit 1341 // spurious errors. 1342 return false; 1343 } 1344 1345 // Type check the data argument. It should be an 'int'. 1346 // Although not in conformance with C99, we also allow the argument to be 1347 // an 'unsigned int' as that is a reasonably safe case. GCC also 1348 // doesn't emit a warning for that case. 1349 CoveredArgs.set(argIndex); 1350 const Expr *Arg = getDataArg(argIndex); 1351 QualType T = Arg->getType(); 1352 1353 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 1354 assert(ATR.isValid()); 1355 1356 if (!ATR.matchesType(S.Context, T)) { 1357 S.Diag(getLocationOfByte(Amt.getStart()), 1358 diag::warn_printf_asterisk_wrong_type) 1359 << k 1360 << ATR.getRepresentativeType(S.Context) << T 1361 << getSpecifierRange(startSpecifier, specifierLen) 1362 << Arg->getSourceRange(); 1363 // Don't do any more checking. We will just emit 1364 // spurious errors. 1365 return false; 1366 } 1367 } 1368 } 1369 return true; 1370} 1371 1372void CheckPrintfHandler::HandleInvalidAmount( 1373 const analyze_printf::PrintfSpecifier &FS, 1374 const analyze_printf::OptionalAmount &Amt, 1375 unsigned type, 1376 const char *startSpecifier, 1377 unsigned specifierLen) { 1378 const analyze_printf::ConversionSpecifier &CS = FS.getConversionSpecifier(); 1379 switch (Amt.getHowSpecified()) { 1380 case analyze_printf::OptionalAmount::Constant: 1381 S.Diag(getLocationOfByte(Amt.getStart()), 1382 diag::warn_printf_nonsensical_optional_amount) 1383 << type 1384 << CS.toString() 1385 << getSpecifierRange(startSpecifier, specifierLen) 1386 << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1387 Amt.getConstantLength())); 1388 break; 1389 1390 default: 1391 S.Diag(getLocationOfByte(Amt.getStart()), 1392 diag::warn_printf_nonsensical_optional_amount) 1393 << type 1394 << CS.toString() 1395 << getSpecifierRange(startSpecifier, specifierLen); 1396 break; 1397 } 1398} 1399 1400void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1401 const analyze_printf::OptionalFlag &flag, 1402 const char *startSpecifier, 1403 unsigned specifierLen) { 1404 // Warn about pointless flag with a fixit removal. 1405 const analyze_printf::ConversionSpecifier &CS = FS.getConversionSpecifier(); 1406 S.Diag(getLocationOfByte(flag.getPosition()), 1407 diag::warn_printf_nonsensical_flag) 1408 << flag.toString() << CS.toString() 1409 << getSpecifierRange(startSpecifier, specifierLen) 1410 << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1411} 1412 1413void CheckPrintfHandler::HandleIgnoredFlag( 1414 const analyze_printf::PrintfSpecifier &FS, 1415 const analyze_printf::OptionalFlag &ignoredFlag, 1416 const analyze_printf::OptionalFlag &flag, 1417 const char *startSpecifier, 1418 unsigned specifierLen) { 1419 // Warn about ignored flag with a fixit removal. 1420 S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1421 diag::warn_printf_ignored_flag) 1422 << ignoredFlag.toString() << flag.toString() 1423 << getSpecifierRange(startSpecifier, specifierLen) 1424 << FixItHint::CreateRemoval(getSpecifierRange( 1425 ignoredFlag.getPosition(), 1)); 1426} 1427 1428bool 1429CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 1430 &FS, 1431 const char *startSpecifier, 1432 unsigned specifierLen) { 1433 1434 using namespace analyze_printf; 1435 const ConversionSpecifier &CS = FS.getConversionSpecifier(); 1436 1437 if (atFirstArg) { 1438 atFirstArg = false; 1439 usesPositionalArgs = FS.usesPositionalArg(); 1440 } 1441 else if (usesPositionalArgs != FS.usesPositionalArg()) { 1442 // Cannot mix-and-match positional and non-positional arguments. 1443 S.Diag(getLocationOfByte(CS.getStart()), 1444 diag::warn_format_mix_positional_nonpositional_args) 1445 << getSpecifierRange(startSpecifier, specifierLen); 1446 return false; 1447 } 1448 1449 // First check if the field width, precision, and conversion specifier 1450 // have matching data arguments. 1451 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1452 startSpecifier, specifierLen)) { 1453 return false; 1454 } 1455 1456 if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1457 startSpecifier, specifierLen)) { 1458 return false; 1459 } 1460 1461 if (!CS.consumesDataArgument()) { 1462 // FIXME: Technically specifying a precision or field width here 1463 // makes no sense. Worth issuing a warning at some point. 1464 return true; 1465 } 1466 1467 // Consume the argument. 1468 unsigned argIndex = FS.getArgIndex(); 1469 if (argIndex < NumDataArgs) { 1470 // The check to see if the argIndex is valid will come later. 1471 // We set the bit here because we may exit early from this 1472 // function if we encounter some other error. 1473 CoveredArgs.set(argIndex); 1474 } 1475 1476 // Check for using an Objective-C specific conversion specifier 1477 // in a non-ObjC literal. 1478 if (!IsObjCLiteral && CS.isObjCArg()) { 1479 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1480 specifierLen); 1481 } 1482 1483 // Check for invalid use of field width 1484 if (!FS.hasValidFieldWidth()) { 1485 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1486 startSpecifier, specifierLen); 1487 } 1488 1489 // Check for invalid use of precision 1490 if (!FS.hasValidPrecision()) { 1491 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1492 startSpecifier, specifierLen); 1493 } 1494 1495 // Check each flag does not conflict with any other component. 1496 if (!FS.hasValidLeadingZeros()) 1497 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1498 if (!FS.hasValidPlusPrefix()) 1499 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 1500 if (!FS.hasValidSpacePrefix()) 1501 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1502 if (!FS.hasValidAlternativeForm()) 1503 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1504 if (!FS.hasValidLeftJustified()) 1505 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1506 1507 // Check that flags are not ignored by another flag 1508 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 1509 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 1510 startSpecifier, specifierLen); 1511 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1512 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1513 startSpecifier, specifierLen); 1514 1515 // Check the length modifier is valid with the given conversion specifier. 1516 const LengthModifier &LM = FS.getLengthModifier(); 1517 if (!FS.hasValidLengthModifier()) 1518 S.Diag(getLocationOfByte(LM.getStart()), 1519 diag::warn_printf_nonsensical_length) 1520 << LM.toString() << CS.toString() 1521 << getSpecifierRange(startSpecifier, specifierLen) 1522 << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1523 LM.getLength())); 1524 1525 // Are we using '%n'? 1526 if (CS.getKind() == ConversionSpecifier::OutIntPtrArg) { 1527 // Issue a warning about this being a possible security issue. 1528 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1529 << getSpecifierRange(startSpecifier, specifierLen); 1530 // Continue checking the other format specifiers. 1531 return true; 1532 } 1533 1534 // The remaining checks depend on the data arguments. 1535 if (HasVAListArg) 1536 return true; 1537 1538 if (argIndex >= NumDataArgs) { 1539 if (FS.usesPositionalArg()) { 1540 S.Diag(getLocationOfByte(CS.getStart()), 1541 diag::warn_printf_positional_arg_exceeds_data_args) 1542 << (argIndex+1) << NumDataArgs 1543 << getSpecifierRange(startSpecifier, specifierLen); 1544 } 1545 else { 1546 S.Diag(getLocationOfByte(CS.getStart()), 1547 diag::warn_printf_insufficient_data_args) 1548 << getSpecifierRange(startSpecifier, specifierLen); 1549 } 1550 1551 // Don't do any more checking. 1552 return false; 1553 } 1554 1555 // Now type check the data expression that matches the 1556 // format specifier. 1557 const Expr *Ex = getDataArg(argIndex); 1558 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 1559 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 1560 // Check if we didn't match because of an implicit cast from a 'char' 1561 // or 'short' to an 'int'. This is done because printf is a varargs 1562 // function. 1563 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 1564 if (ICE->getType() == S.Context.IntTy) 1565 if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType())) 1566 return true; 1567 1568 // We may be able to offer a FixItHint if it is a supported type. 1569 PrintfSpecifier fixedFS = FS; 1570 bool success = fixedFS.fixType(Ex->getType()); 1571 1572 if (success) { 1573 // Get the fix string from the fixed format specifier 1574 llvm::SmallString<128> buf; 1575 llvm::raw_svector_ostream os(buf); 1576 fixedFS.toString(os); 1577 1578 S.Diag(getLocationOfByte(CS.getStart()), 1579 diag::warn_printf_conversion_argument_type_mismatch) 1580 << ATR.getRepresentativeType(S.Context) << Ex->getType() 1581 << getSpecifierRange(startSpecifier, specifierLen) 1582 << Ex->getSourceRange() 1583 << FixItHint::CreateReplacement( 1584 getSpecifierRange(startSpecifier, specifierLen), 1585 os.str()); 1586 } 1587 else { 1588 S.Diag(getLocationOfByte(CS.getStart()), 1589 diag::warn_printf_conversion_argument_type_mismatch) 1590 << ATR.getRepresentativeType(S.Context) << Ex->getType() 1591 << getSpecifierRange(startSpecifier, specifierLen) 1592 << Ex->getSourceRange(); 1593 } 1594 } 1595 1596 return true; 1597} 1598 1599//===--- CHECK: Scanf format string checking ------------------------------===// 1600 1601namespace { 1602class CheckScanfHandler : public CheckFormatHandler { 1603public: 1604 CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1605 const Expr *origFormatExpr, unsigned firstDataArg, 1606 unsigned numDataArgs, bool isObjCLiteral, 1607 const char *beg, bool hasVAListArg, 1608 const CallExpr *theCall, unsigned formatIdx) 1609 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1610 numDataArgs, isObjCLiteral, beg, hasVAListArg, 1611 theCall, formatIdx) {} 1612 1613 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1614 const char *startSpecifier, 1615 unsigned specifierLen); 1616 1617 bool HandleInvalidScanfConversionSpecifier( 1618 const analyze_scanf::ScanfSpecifier &FS, 1619 const char *startSpecifier, 1620 unsigned specifierLen); 1621 1622 void HandleIncompleteScanList(const char *start, const char *end); 1623}; 1624} 1625 1626void CheckScanfHandler::HandleIncompleteScanList(const char *start, 1627 const char *end) { 1628 S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1629 << getSpecifierRange(start, end - start); 1630} 1631 1632bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1633 const analyze_scanf::ScanfSpecifier &FS, 1634 const char *startSpecifier, 1635 unsigned specifierLen) { 1636 1637 const analyze_scanf::ConversionSpecifier &CS = 1638 FS.getConversionSpecifier(); 1639 1640 return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1641 getLocationOfByte(CS.getStart()), 1642 startSpecifier, specifierLen, 1643 CS.getStart(), CS.getLength()); 1644} 1645 1646bool CheckScanfHandler::HandleScanfSpecifier( 1647 const analyze_scanf::ScanfSpecifier &FS, 1648 const char *startSpecifier, 1649 unsigned specifierLen) { 1650 1651 using namespace analyze_scanf; 1652 using namespace analyze_format_string; 1653 1654 const ConversionSpecifier &CS = FS.getConversionSpecifier(); 1655 1656 // FIXME: Handle case where '%' and '*' don't consume an argument. 1657 // This needs to be done for the printf case as well. 1658 if (atFirstArg) { 1659 atFirstArg = false; 1660 usesPositionalArgs = FS.usesPositionalArg(); 1661 } 1662 else if (usesPositionalArgs != FS.usesPositionalArg()) { 1663 // Cannot mix-and-match positional and non-positional arguments. 1664 S.Diag(getLocationOfByte(CS.getStart()), 1665 diag::warn_format_mix_positional_nonpositional_args) 1666 << getSpecifierRange(startSpecifier, specifierLen); 1667 return false; 1668 } 1669 1670 // Check if the field with is non-zero. 1671 const OptionalAmount &Amt = FS.getFieldWidth(); 1672 if (Amt.getHowSpecified() == OptionalAmount::Constant) { 1673 if (Amt.getConstantAmount() == 0) { 1674 const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 1675 Amt.getConstantLength()); 1676 S.Diag(getLocationOfByte(Amt.getStart()), 1677 diag::warn_scanf_nonzero_width) 1678 << R << FixItHint::CreateRemoval(R); 1679 } 1680 } 1681 1682 if (!FS.consumesDataArgument()) { 1683 // FIXME: Technically specifying a precision or field width here 1684 // makes no sense. Worth issuing a warning at some point. 1685 return true; 1686 } 1687 1688 // Consume the argument. 1689 unsigned argIndex = FS.getArgIndex(); 1690 if (argIndex < NumDataArgs) { 1691 // The check to see if the argIndex is valid will come later. 1692 // We set the bit here because we may exit early from this 1693 // function if we encounter some other error. 1694 CoveredArgs.set(argIndex); 1695 } 1696 1697 // FIXME: Check that the length modifier is valid with the given 1698 // conversion specifier. 1699 1700 // The remaining checks depend on the data arguments. 1701 if (HasVAListArg) 1702 return true; 1703 1704 if (argIndex >= NumDataArgs) { 1705 if (FS.usesPositionalArg()) { 1706 S.Diag(getLocationOfByte(CS.getStart()), 1707 diag::warn_printf_positional_arg_exceeds_data_args) 1708 << (argIndex+1) << NumDataArgs 1709 << getSpecifierRange(startSpecifier, specifierLen); 1710 } 1711 else { 1712 S.Diag(getLocationOfByte(CS.getStart()), 1713 diag::warn_printf_insufficient_data_args) 1714 << getSpecifierRange(startSpecifier, specifierLen); 1715 } 1716 1717 // Don't do any more checking. 1718 return false; 1719 } 1720 1721 // FIXME: Check that the argument type matches the format specifier. 1722 1723 return true; 1724} 1725 1726void Sema::CheckFormatString(const StringLiteral *FExpr, 1727 const Expr *OrigFormatExpr, 1728 const CallExpr *TheCall, bool HasVAListArg, 1729 unsigned format_idx, unsigned firstDataArg, 1730 bool isPrintf) { 1731 1732 // CHECK: is the format string a wide literal? 1733 if (FExpr->isWide()) { 1734 Diag(FExpr->getLocStart(), 1735 diag::warn_format_string_is_wide_literal) 1736 << OrigFormatExpr->getSourceRange(); 1737 return; 1738 } 1739 1740 // Str - The format string. NOTE: this is NOT null-terminated! 1741 const char *Str = FExpr->getStrData(); 1742 1743 // CHECK: empty format string? 1744 unsigned StrLen = FExpr->getByteLength(); 1745 1746 if (StrLen == 0) { 1747 Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 1748 << OrigFormatExpr->getSourceRange(); 1749 return; 1750 } 1751 1752 if (isPrintf) { 1753 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1754 TheCall->getNumArgs() - firstDataArg, 1755 isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1756 HasVAListArg, TheCall, format_idx); 1757 1758 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 1759 H.DoneProcessing(); 1760 } 1761 else { 1762 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1763 TheCall->getNumArgs() - firstDataArg, 1764 isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1765 HasVAListArg, TheCall, format_idx); 1766 1767 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 1768 H.DoneProcessing(); 1769 } 1770} 1771 1772//===--- CHECK: Return Address of Stack Variable --------------------------===// 1773 1774static DeclRefExpr* EvalVal(Expr *E); 1775static DeclRefExpr* EvalAddr(Expr* E); 1776 1777/// CheckReturnStackAddr - Check if a return statement returns the address 1778/// of a stack variable. 1779void 1780Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 1781 SourceLocation ReturnLoc) { 1782 1783 // Perform checking for returned stack addresses. 1784 if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { 1785 if (DeclRefExpr *DR = EvalAddr(RetValExp)) 1786 Diag(DR->getLocStart(), diag::warn_ret_stack_addr) 1787 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); 1788 1789 // Skip over implicit cast expressions when checking for block expressions. 1790 RetValExp = RetValExp->IgnoreParenCasts(); 1791 1792 if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp)) 1793 if (C->hasBlockDeclRefExprs()) 1794 Diag(C->getLocStart(), diag::err_ret_local_block) 1795 << C->getSourceRange(); 1796 1797 if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp)) 1798 Diag(ALE->getLocStart(), diag::warn_ret_addr_label) 1799 << ALE->getSourceRange(); 1800 1801 } else if (lhsType->isReferenceType()) { 1802 // Perform checking for stack values returned by reference. 1803 // Check for a reference to the stack 1804 if (DeclRefExpr *DR = EvalVal(RetValExp)) 1805 Diag(DR->getLocStart(), diag::warn_ret_stack_ref) 1806 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); 1807 } 1808} 1809 1810/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 1811/// check if the expression in a return statement evaluates to an address 1812/// to a location on the stack. The recursion is used to traverse the 1813/// AST of the return expression, with recursion backtracking when we 1814/// encounter a subexpression that (1) clearly does not lead to the address 1815/// of a stack variable or (2) is something we cannot determine leads to 1816/// the address of a stack variable based on such local checking. 1817/// 1818/// EvalAddr processes expressions that are pointers that are used as 1819/// references (and not L-values). EvalVal handles all other values. 1820/// At the base case of the recursion is a check for a DeclRefExpr* in 1821/// the refers to a stack variable. 1822/// 1823/// This implementation handles: 1824/// 1825/// * pointer-to-pointer casts 1826/// * implicit conversions from array references to pointers 1827/// * taking the address of fields 1828/// * arbitrary interplay between "&" and "*" operators 1829/// * pointer arithmetic from an address of a stack variable 1830/// * taking the address of an array element where the array is on the stack 1831static DeclRefExpr* EvalAddr(Expr *E) { 1832 // We should only be called for evaluating pointer expressions. 1833 assert((E->getType()->isAnyPointerType() || 1834 E->getType()->isBlockPointerType() || 1835 E->getType()->isObjCQualifiedIdType()) && 1836 "EvalAddr only works on pointers"); 1837 1838 // Our "symbolic interpreter" is just a dispatch off the currently 1839 // viewed AST node. We then recursively traverse the AST by calling 1840 // EvalAddr and EvalVal appropriately. 1841 switch (E->getStmtClass()) { 1842 case Stmt::ParenExprClass: 1843 // Ignore parentheses. 1844 return EvalAddr(cast<ParenExpr>(E)->getSubExpr()); 1845 1846 case Stmt::UnaryOperatorClass: { 1847 // The only unary operator that make sense to handle here 1848 // is AddrOf. All others don't make sense as pointers. 1849 UnaryOperator *U = cast<UnaryOperator>(E); 1850 1851 if (U->getOpcode() == UnaryOperator::AddrOf) 1852 return EvalVal(U->getSubExpr()); 1853 else 1854 return NULL; 1855 } 1856 1857 case Stmt::BinaryOperatorClass: { 1858 // Handle pointer arithmetic. All other binary operators are not valid 1859 // in this context. 1860 BinaryOperator *B = cast<BinaryOperator>(E); 1861 BinaryOperator::Opcode op = B->getOpcode(); 1862 1863 if (op != BinaryOperator::Add && op != BinaryOperator::Sub) 1864 return NULL; 1865 1866 Expr *Base = B->getLHS(); 1867 1868 // Determine which argument is the real pointer base. It could be 1869 // the RHS argument instead of the LHS. 1870 if (!Base->getType()->isPointerType()) Base = B->getRHS(); 1871 1872 assert (Base->getType()->isPointerType()); 1873 return EvalAddr(Base); 1874 } 1875 1876 // For conditional operators we need to see if either the LHS or RHS are 1877 // valid DeclRefExpr*s. If one of them is valid, we return it. 1878 case Stmt::ConditionalOperatorClass: { 1879 ConditionalOperator *C = cast<ConditionalOperator>(E); 1880 1881 // Handle the GNU extension for missing LHS. 1882 if (Expr *lhsExpr = C->getLHS()) 1883 if (DeclRefExpr* LHS = EvalAddr(lhsExpr)) 1884 return LHS; 1885 1886 return EvalAddr(C->getRHS()); 1887 } 1888 1889 // For casts, we need to handle conversions from arrays to 1890 // pointer values, and pointer-to-pointer conversions. 1891 case Stmt::ImplicitCastExprClass: 1892 case Stmt::CStyleCastExprClass: 1893 case Stmt::CXXFunctionalCastExprClass: { 1894 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 1895 QualType T = SubExpr->getType(); 1896 1897 if (SubExpr->getType()->isPointerType() || 1898 SubExpr->getType()->isBlockPointerType() || 1899 SubExpr->getType()->isObjCQualifiedIdType()) 1900 return EvalAddr(SubExpr); 1901 else if (T->isArrayType()) 1902 return EvalVal(SubExpr); 1903 else 1904 return 0; 1905 } 1906 1907 // C++ casts. For dynamic casts, static casts, and const casts, we 1908 // are always converting from a pointer-to-pointer, so we just blow 1909 // through the cast. In the case the dynamic cast doesn't fail (and 1910 // return NULL), we take the conservative route and report cases 1911 // where we return the address of a stack variable. For Reinterpre 1912 // FIXME: The comment about is wrong; we're not always converting 1913 // from pointer to pointer. I'm guessing that this code should also 1914 // handle references to objects. 1915 case Stmt::CXXStaticCastExprClass: 1916 case Stmt::CXXDynamicCastExprClass: 1917 case Stmt::CXXConstCastExprClass: 1918 case Stmt::CXXReinterpretCastExprClass: { 1919 Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 1920 if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 1921 return EvalAddr(S); 1922 else 1923 return NULL; 1924 } 1925 1926 // Everything else: we simply don't reason about them. 1927 default: 1928 return NULL; 1929 } 1930} 1931 1932 1933/// EvalVal - This function is complements EvalAddr in the mutual recursion. 1934/// See the comments for EvalAddr for more details. 1935static DeclRefExpr* EvalVal(Expr *E) { 1936 1937 // We should only be called for evaluating non-pointer expressions, or 1938 // expressions with a pointer type that are not used as references but instead 1939 // are l-values (e.g., DeclRefExpr with a pointer type). 1940 1941 // Our "symbolic interpreter" is just a dispatch off the currently 1942 // viewed AST node. We then recursively traverse the AST by calling 1943 // EvalAddr and EvalVal appropriately. 1944 switch (E->getStmtClass()) { 1945 case Stmt::DeclRefExprClass: { 1946 // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking 1947 // at code that refers to a variable's name. We check if it has local 1948 // storage within the function, and if so, return the expression. 1949 DeclRefExpr *DR = cast<DeclRefExpr>(E); 1950 1951 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 1952 if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR; 1953 1954 return NULL; 1955 } 1956 1957 case Stmt::ParenExprClass: 1958 // Ignore parentheses. 1959 return EvalVal(cast<ParenExpr>(E)->getSubExpr()); 1960 1961 case Stmt::UnaryOperatorClass: { 1962 // The only unary operator that make sense to handle here 1963 // is Deref. All others don't resolve to a "name." This includes 1964 // handling all sorts of rvalues passed to a unary operator. 1965 UnaryOperator *U = cast<UnaryOperator>(E); 1966 1967 if (U->getOpcode() == UnaryOperator::Deref) 1968 return EvalAddr(U->getSubExpr()); 1969 1970 return NULL; 1971 } 1972 1973 case Stmt::ArraySubscriptExprClass: { 1974 // Array subscripts are potential references to data on the stack. We 1975 // retrieve the DeclRefExpr* for the array variable if it indeed 1976 // has local storage. 1977 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase()); 1978 } 1979 1980 case Stmt::ConditionalOperatorClass: { 1981 // For conditional operators we need to see if either the LHS or RHS are 1982 // non-NULL DeclRefExpr's. If one is non-NULL, we return it. 1983 ConditionalOperator *C = cast<ConditionalOperator>(E); 1984 1985 // Handle the GNU extension for missing LHS. 1986 if (Expr *lhsExpr = C->getLHS()) 1987 if (DeclRefExpr *LHS = EvalVal(lhsExpr)) 1988 return LHS; 1989 1990 return EvalVal(C->getRHS()); 1991 } 1992 1993 // Accesses to members are potential references to data on the stack. 1994 case Stmt::MemberExprClass: { 1995 MemberExpr *M = cast<MemberExpr>(E); 1996 1997 // Check for indirect access. We only want direct field accesses. 1998 if (!M->isArrow()) 1999 return EvalVal(M->getBase()); 2000 else 2001 return NULL; 2002 } 2003 2004 // Everything else: we simply don't reason about them. 2005 default: 2006 return NULL; 2007 } 2008} 2009 2010//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2011 2012/// Check for comparisons of floating point operands using != and ==. 2013/// Issue a warning if these are no self-comparisons, as they are not likely 2014/// to do what the programmer intended. 2015void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { 2016 bool EmitWarning = true; 2017 2018 Expr* LeftExprSansParen = lex->IgnoreParens(); 2019 Expr* RightExprSansParen = rex->IgnoreParens(); 2020 2021 // Special case: check for x == x (which is OK). 2022 // Do not emit warnings for such cases. 2023 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2024 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2025 if (DRL->getDecl() == DRR->getDecl()) 2026 EmitWarning = false; 2027 2028 2029 // Special case: check for comparisons against literals that can be exactly 2030 // represented by APFloat. In such cases, do not emit a warning. This 2031 // is a heuristic: often comparison against such literals are used to 2032 // detect if a value in a variable has not changed. This clearly can 2033 // lead to false negatives. 2034 if (EmitWarning) { 2035 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 2036 if (FLL->isExact()) 2037 EmitWarning = false; 2038 } else 2039 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 2040 if (FLR->isExact()) 2041 EmitWarning = false; 2042 } 2043 } 2044 2045 // Check for comparisons with builtin types. 2046 if (EmitWarning) 2047 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 2048 if (CL->isBuiltinCall(Context)) 2049 EmitWarning = false; 2050 2051 if (EmitWarning) 2052 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 2053 if (CR->isBuiltinCall(Context)) 2054 EmitWarning = false; 2055 2056 // Emit the diagnostic. 2057 if (EmitWarning) 2058 Diag(loc, diag::warn_floatingpoint_eq) 2059 << lex->getSourceRange() << rex->getSourceRange(); 2060} 2061 2062//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2063//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2064 2065namespace { 2066 2067/// Structure recording the 'active' range of an integer-valued 2068/// expression. 2069struct IntRange { 2070 /// The number of bits active in the int. 2071 unsigned Width; 2072 2073 /// True if the int is known not to have negative values. 2074 bool NonNegative; 2075 2076 IntRange() {} 2077 IntRange(unsigned Width, bool NonNegative) 2078 : Width(Width), NonNegative(NonNegative) 2079 {} 2080 2081 // Returns the range of the bool type. 2082 static IntRange forBoolType() { 2083 return IntRange(1, true); 2084 } 2085 2086 // Returns the range of an integral type. 2087 static IntRange forType(ASTContext &C, QualType T) { 2088 return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr()); 2089 } 2090 2091 // Returns the range of an integeral type based on its canonical 2092 // representation. 2093 static IntRange forCanonicalType(ASTContext &C, const Type *T) { 2094 assert(T->isCanonicalUnqualified()); 2095 2096 if (const VectorType *VT = dyn_cast<VectorType>(T)) 2097 T = VT->getElementType().getTypePtr(); 2098 if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2099 T = CT->getElementType().getTypePtr(); 2100 2101 if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2102 EnumDecl *Enum = ET->getDecl(); 2103 unsigned NumPositive = Enum->getNumPositiveBits(); 2104 unsigned NumNegative = Enum->getNumNegativeBits(); 2105 2106 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2107 } 2108 2109 const BuiltinType *BT = cast<BuiltinType>(T); 2110 assert(BT->isInteger()); 2111 2112 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 2113 } 2114 2115 // Returns the supremum of two ranges: i.e. their conservative merge. 2116 static IntRange join(IntRange L, IntRange R) { 2117 return IntRange(std::max(L.Width, R.Width), 2118 L.NonNegative && R.NonNegative); 2119 } 2120 2121 // Returns the infinum of two ranges: i.e. their aggressive merge. 2122 static IntRange meet(IntRange L, IntRange R) { 2123 return IntRange(std::min(L.Width, R.Width), 2124 L.NonNegative || R.NonNegative); 2125 } 2126}; 2127 2128IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2129 if (value.isSigned() && value.isNegative()) 2130 return IntRange(value.getMinSignedBits(), false); 2131 2132 if (value.getBitWidth() > MaxWidth) 2133 value.trunc(MaxWidth); 2134 2135 // isNonNegative() just checks the sign bit without considering 2136 // signedness. 2137 return IntRange(value.getActiveBits(), true); 2138} 2139 2140IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2141 unsigned MaxWidth) { 2142 if (result.isInt()) 2143 return GetValueRange(C, result.getInt(), MaxWidth); 2144 2145 if (result.isVector()) { 2146 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 2147 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 2148 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 2149 R = IntRange::join(R, El); 2150 } 2151 return R; 2152 } 2153 2154 if (result.isComplexInt()) { 2155 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2156 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2157 return IntRange::join(R, I); 2158 } 2159 2160 // This can happen with lossless casts to intptr_t of "based" lvalues. 2161 // Assume it might use arbitrary bits. 2162 // FIXME: The only reason we need to pass the type in here is to get 2163 // the sign right on this one case. It would be nice if APValue 2164 // preserved this. 2165 assert(result.isLValue()); 2166 return IntRange(MaxWidth, Ty->isUnsignedIntegerType()); 2167} 2168 2169/// Pseudo-evaluate the given integer expression, estimating the 2170/// range of values it might take. 2171/// 2172/// \param MaxWidth - the width to which the value will be truncated 2173IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 2174 E = E->IgnoreParens(); 2175 2176 // Try a full evaluation first. 2177 Expr::EvalResult result; 2178 if (E->Evaluate(result, C)) 2179 return GetValueRange(C, result.Val, E->getType(), MaxWidth); 2180 2181 // I think we only want to look through implicit casts here; if the 2182 // user has an explicit widening cast, we should treat the value as 2183 // being of the new, wider type. 2184 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 2185 if (CE->getCastKind() == CastExpr::CK_NoOp) 2186 return GetExprRange(C, CE->getSubExpr(), MaxWidth); 2187 2188 IntRange OutputTypeRange = IntRange::forType(C, CE->getType()); 2189 2190 bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast); 2191 if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown) 2192 isIntegerCast = CE->getSubExpr()->getType()->isIntegerType(); 2193 2194 // Assume that non-integer casts can span the full range of the type. 2195 if (!isIntegerCast) 2196 return OutputTypeRange; 2197 2198 IntRange SubRange 2199 = GetExprRange(C, CE->getSubExpr(), 2200 std::min(MaxWidth, OutputTypeRange.Width)); 2201 2202 // Bail out if the subexpr's range is as wide as the cast type. 2203 if (SubRange.Width >= OutputTypeRange.Width) 2204 return OutputTypeRange; 2205 2206 // Otherwise, we take the smaller width, and we're non-negative if 2207 // either the output type or the subexpr is. 2208 return IntRange(SubRange.Width, 2209 SubRange.NonNegative || OutputTypeRange.NonNegative); 2210 } 2211 2212 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2213 // If we can fold the condition, just take that operand. 2214 bool CondResult; 2215 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2216 return GetExprRange(C, CondResult ? CO->getTrueExpr() 2217 : CO->getFalseExpr(), 2218 MaxWidth); 2219 2220 // Otherwise, conservatively merge. 2221 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2222 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2223 return IntRange::join(L, R); 2224 } 2225 2226 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 2227 switch (BO->getOpcode()) { 2228 2229 // Boolean-valued operations are single-bit and positive. 2230 case BinaryOperator::LAnd: 2231 case BinaryOperator::LOr: 2232 case BinaryOperator::LT: 2233 case BinaryOperator::GT: 2234 case BinaryOperator::LE: 2235 case BinaryOperator::GE: 2236 case BinaryOperator::EQ: 2237 case BinaryOperator::NE: 2238 return IntRange::forBoolType(); 2239 2240 // The type of these compound assignments is the type of the LHS, 2241 // so the RHS is not necessarily an integer. 2242 case BinaryOperator::MulAssign: 2243 case BinaryOperator::DivAssign: 2244 case BinaryOperator::RemAssign: 2245 case BinaryOperator::AddAssign: 2246 case BinaryOperator::SubAssign: 2247 return IntRange::forType(C, E->getType()); 2248 2249 // Operations with opaque sources are black-listed. 2250 case BinaryOperator::PtrMemD: 2251 case BinaryOperator::PtrMemI: 2252 return IntRange::forType(C, E->getType()); 2253 2254 // Bitwise-and uses the *infinum* of the two source ranges. 2255 case BinaryOperator::And: 2256 case BinaryOperator::AndAssign: 2257 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 2258 GetExprRange(C, BO->getRHS(), MaxWidth)); 2259 2260 // Left shift gets black-listed based on a judgement call. 2261 case BinaryOperator::Shl: 2262 // ...except that we want to treat '1 << (blah)' as logically 2263 // positive. It's an important idiom. 2264 if (IntegerLiteral *I 2265 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 2266 if (I->getValue() == 1) { 2267 IntRange R = IntRange::forType(C, E->getType()); 2268 return IntRange(R.Width, /*NonNegative*/ true); 2269 } 2270 } 2271 // fallthrough 2272 2273 case BinaryOperator::ShlAssign: 2274 return IntRange::forType(C, E->getType()); 2275 2276 // Right shift by a constant can narrow its left argument. 2277 case BinaryOperator::Shr: 2278 case BinaryOperator::ShrAssign: { 2279 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2280 2281 // If the shift amount is a positive constant, drop the width by 2282 // that much. 2283 llvm::APSInt shift; 2284 if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 2285 shift.isNonNegative()) { 2286 unsigned zext = shift.getZExtValue(); 2287 if (zext >= L.Width) 2288 L.Width = (L.NonNegative ? 0 : 1); 2289 else 2290 L.Width -= zext; 2291 } 2292 2293 return L; 2294 } 2295 2296 // Comma acts as its right operand. 2297 case BinaryOperator::Comma: 2298 return GetExprRange(C, BO->getRHS(), MaxWidth); 2299 2300 // Black-list pointer subtractions. 2301 case BinaryOperator::Sub: 2302 if (BO->getLHS()->getType()->isPointerType()) 2303 return IntRange::forType(C, E->getType()); 2304 // fallthrough 2305 2306 default: 2307 break; 2308 } 2309 2310 // Treat every other operator as if it were closed on the 2311 // narrowest type that encompasses both operands. 2312 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2313 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 2314 return IntRange::join(L, R); 2315 } 2316 2317 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 2318 switch (UO->getOpcode()) { 2319 // Boolean-valued operations are white-listed. 2320 case UnaryOperator::LNot: 2321 return IntRange::forBoolType(); 2322 2323 // Operations with opaque sources are black-listed. 2324 case UnaryOperator::Deref: 2325 case UnaryOperator::AddrOf: // should be impossible 2326 case UnaryOperator::OffsetOf: 2327 return IntRange::forType(C, E->getType()); 2328 2329 default: 2330 return GetExprRange(C, UO->getSubExpr(), MaxWidth); 2331 } 2332 } 2333 2334 if (dyn_cast<OffsetOfExpr>(E)) { 2335 IntRange::forType(C, E->getType()); 2336 } 2337 2338 FieldDecl *BitField = E->getBitField(); 2339 if (BitField) { 2340 llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); 2341 unsigned BitWidth = BitWidthAP.getZExtValue(); 2342 2343 return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType()); 2344 } 2345 2346 return IntRange::forType(C, E->getType()); 2347} 2348 2349IntRange GetExprRange(ASTContext &C, Expr *E) { 2350 return GetExprRange(C, E, C.getIntWidth(E->getType())); 2351} 2352 2353/// Checks whether the given value, which currently has the given 2354/// source semantics, has the same value when coerced through the 2355/// target semantics. 2356bool IsSameFloatAfterCast(const llvm::APFloat &value, 2357 const llvm::fltSemantics &Src, 2358 const llvm::fltSemantics &Tgt) { 2359 llvm::APFloat truncated = value; 2360 2361 bool ignored; 2362 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 2363 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 2364 2365 return truncated.bitwiseIsEqual(value); 2366} 2367 2368/// Checks whether the given value, which currently has the given 2369/// source semantics, has the same value when coerced through the 2370/// target semantics. 2371/// 2372/// The value might be a vector of floats (or a complex number). 2373bool IsSameFloatAfterCast(const APValue &value, 2374 const llvm::fltSemantics &Src, 2375 const llvm::fltSemantics &Tgt) { 2376 if (value.isFloat()) 2377 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 2378 2379 if (value.isVector()) { 2380 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 2381 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 2382 return false; 2383 return true; 2384 } 2385 2386 assert(value.isComplexFloat()); 2387 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 2388 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 2389} 2390 2391void AnalyzeImplicitConversions(Sema &S, Expr *E); 2392 2393bool IsZero(Sema &S, Expr *E) { 2394 llvm::APSInt Value; 2395 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 2396} 2397 2398void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 2399 BinaryOperator::Opcode op = E->getOpcode(); 2400 if (op == BinaryOperator::LT && IsZero(S, E->getRHS())) { 2401 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2402 << "< 0" << "false" 2403 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2404 } else if (op == BinaryOperator::GE && IsZero(S, E->getRHS())) { 2405 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2406 << ">= 0" << "true" 2407 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2408 } else if (op == BinaryOperator::GT && IsZero(S, E->getLHS())) { 2409 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2410 << "0 >" << "false" 2411 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2412 } else if (op == BinaryOperator::LE && IsZero(S, E->getLHS())) { 2413 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2414 << "0 <=" << "true" 2415 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2416 } 2417} 2418 2419/// Analyze the operands of the given comparison. Implements the 2420/// fallback case from AnalyzeComparison. 2421void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 2422 AnalyzeImplicitConversions(S, E->getLHS()); 2423 AnalyzeImplicitConversions(S, E->getRHS()); 2424} 2425 2426/// \brief Implements -Wsign-compare. 2427/// 2428/// \param lex the left-hand expression 2429/// \param rex the right-hand expression 2430/// \param OpLoc the location of the joining operator 2431/// \param BinOpc binary opcode or 0 2432void AnalyzeComparison(Sema &S, BinaryOperator *E) { 2433 // The type the comparison is being performed in. 2434 QualType T = E->getLHS()->getType(); 2435 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 2436 && "comparison with mismatched types"); 2437 2438 // We don't do anything special if this isn't an unsigned integral 2439 // comparison: we're only interested in integral comparisons, and 2440 // signed comparisons only happen in cases we don't care to warn about. 2441 if (!T->isUnsignedIntegerType()) 2442 return AnalyzeImpConvsInComparison(S, E); 2443 2444 Expr *lex = E->getLHS()->IgnoreParenImpCasts(); 2445 Expr *rex = E->getRHS()->IgnoreParenImpCasts(); 2446 2447 // Check to see if one of the (unmodified) operands is of different 2448 // signedness. 2449 Expr *signedOperand, *unsignedOperand; 2450 if (lex->getType()->isSignedIntegerType()) { 2451 assert(!rex->getType()->isSignedIntegerType() && 2452 "unsigned comparison between two signed integer expressions?"); 2453 signedOperand = lex; 2454 unsignedOperand = rex; 2455 } else if (rex->getType()->isSignedIntegerType()) { 2456 signedOperand = rex; 2457 unsignedOperand = lex; 2458 } else { 2459 CheckTrivialUnsignedComparison(S, E); 2460 return AnalyzeImpConvsInComparison(S, E); 2461 } 2462 2463 // Otherwise, calculate the effective range of the signed operand. 2464 IntRange signedRange = GetExprRange(S.Context, signedOperand); 2465 2466 // Go ahead and analyze implicit conversions in the operands. Note 2467 // that we skip the implicit conversions on both sides. 2468 AnalyzeImplicitConversions(S, lex); 2469 AnalyzeImplicitConversions(S, rex); 2470 2471 // If the signed range is non-negative, -Wsign-compare won't fire, 2472 // but we should still check for comparisons which are always true 2473 // or false. 2474 if (signedRange.NonNegative) 2475 return CheckTrivialUnsignedComparison(S, E); 2476 2477 // For (in)equality comparisons, if the unsigned operand is a 2478 // constant which cannot collide with a overflowed signed operand, 2479 // then reinterpreting the signed operand as unsigned will not 2480 // change the result of the comparison. 2481 if (E->isEqualityOp()) { 2482 unsigned comparisonWidth = S.Context.getIntWidth(T); 2483 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 2484 2485 // We should never be unable to prove that the unsigned operand is 2486 // non-negative. 2487 assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 2488 2489 if (unsignedRange.Width < comparisonWidth) 2490 return; 2491 } 2492 2493 S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 2494 << lex->getType() << rex->getType() 2495 << lex->getSourceRange() << rex->getSourceRange(); 2496} 2497 2498/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 2499void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) { 2500 S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange(); 2501} 2502 2503void CheckImplicitConversion(Sema &S, Expr *E, QualType T, 2504 bool *ICContext = 0) { 2505 if (E->isTypeDependent() || E->isValueDependent()) return; 2506 2507 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 2508 const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 2509 if (Source == Target) return; 2510 if (Target->isDependentType()) return; 2511 2512 // Never diagnose implicit casts to bool. 2513 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 2514 return; 2515 2516 // Strip vector types. 2517 if (isa<VectorType>(Source)) { 2518 if (!isa<VectorType>(Target)) 2519 return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar); 2520 2521 Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 2522 Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 2523 } 2524 2525 // Strip complex types. 2526 if (isa<ComplexType>(Source)) { 2527 if (!isa<ComplexType>(Target)) 2528 return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar); 2529 2530 Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 2531 Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 2532 } 2533 2534 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 2535 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 2536 2537 // If the source is floating point... 2538 if (SourceBT && SourceBT->isFloatingPoint()) { 2539 // ...and the target is floating point... 2540 if (TargetBT && TargetBT->isFloatingPoint()) { 2541 // ...then warn if we're dropping FP rank. 2542 2543 // Builtin FP kinds are ordered by increasing FP rank. 2544 if (SourceBT->getKind() > TargetBT->getKind()) { 2545 // Don't warn about float constants that are precisely 2546 // representable in the target type. 2547 Expr::EvalResult result; 2548 if (E->Evaluate(result, S.Context)) { 2549 // Value might be a float, a float vector, or a float complex. 2550 if (IsSameFloatAfterCast(result.Val, 2551 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 2552 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 2553 return; 2554 } 2555 2556 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision); 2557 } 2558 return; 2559 } 2560 2561 // If the target is integral, always warn. 2562 if ((TargetBT && TargetBT->isInteger())) 2563 // TODO: don't warn for integer values? 2564 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer); 2565 2566 return; 2567 } 2568 2569 if (!Source->isIntegerType() || !Target->isIntegerType()) 2570 return; 2571 2572 IntRange SourceRange = GetExprRange(S.Context, E); 2573 IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target); 2574 2575 if (SourceRange.Width > TargetRange.Width) { 2576 // People want to build with -Wshorten-64-to-32 and not -Wconversion 2577 // and by god we'll let them. 2578 if (SourceRange.Width == 64 && TargetRange.Width == 32) 2579 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32); 2580 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision); 2581 } 2582 2583 if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 2584 (!TargetRange.NonNegative && SourceRange.NonNegative && 2585 SourceRange.Width == TargetRange.Width)) { 2586 unsigned DiagID = diag::warn_impcast_integer_sign; 2587 2588 // Traditionally, gcc has warned about this under -Wsign-compare. 2589 // We also want to warn about it in -Wconversion. 2590 // So if -Wconversion is off, use a completely identical diagnostic 2591 // in the sign-compare group. 2592 // The conditional-checking code will 2593 if (ICContext) { 2594 DiagID = diag::warn_impcast_integer_sign_conditional; 2595 *ICContext = true; 2596 } 2597 2598 return DiagnoseImpCast(S, E, T, DiagID); 2599 } 2600 2601 return; 2602} 2603 2604void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 2605 2606void CheckConditionalOperand(Sema &S, Expr *E, QualType T, 2607 bool &ICContext) { 2608 E = E->IgnoreParenImpCasts(); 2609 2610 if (isa<ConditionalOperator>(E)) 2611 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 2612 2613 AnalyzeImplicitConversions(S, E); 2614 if (E->getType() != T) 2615 return CheckImplicitConversion(S, E, T, &ICContext); 2616 return; 2617} 2618 2619void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 2620 AnalyzeImplicitConversions(S, E->getCond()); 2621 2622 bool Suspicious = false; 2623 CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious); 2624 CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious); 2625 2626 // If -Wconversion would have warned about either of the candidates 2627 // for a signedness conversion to the context type... 2628 if (!Suspicious) return; 2629 2630 // ...but it's currently ignored... 2631 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional)) 2632 return; 2633 2634 // ...and -Wsign-compare isn't... 2635 if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional)) 2636 return; 2637 2638 // ...then check whether it would have warned about either of the 2639 // candidates for a signedness conversion to the condition type. 2640 if (E->getType() != T) { 2641 Suspicious = false; 2642 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 2643 E->getType(), &Suspicious); 2644 if (!Suspicious) 2645 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 2646 E->getType(), &Suspicious); 2647 if (!Suspicious) 2648 return; 2649 } 2650 2651 // If so, emit a diagnostic under -Wsign-compare. 2652 Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts(); 2653 Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts(); 2654 S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional) 2655 << lex->getType() << rex->getType() 2656 << lex->getSourceRange() << rex->getSourceRange(); 2657} 2658 2659/// AnalyzeImplicitConversions - Find and report any interesting 2660/// implicit conversions in the given expression. There are a couple 2661/// of competing diagnostics here, -Wconversion and -Wsign-compare. 2662void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) { 2663 QualType T = OrigE->getType(); 2664 Expr *E = OrigE->IgnoreParenImpCasts(); 2665 2666 // For conditional operators, we analyze the arguments as if they 2667 // were being fed directly into the output. 2668 if (isa<ConditionalOperator>(E)) { 2669 ConditionalOperator *CO = cast<ConditionalOperator>(E); 2670 CheckConditionalOperator(S, CO, T); 2671 return; 2672 } 2673 2674 // Go ahead and check any implicit conversions we might have skipped. 2675 // The non-canonical typecheck is just an optimization; 2676 // CheckImplicitConversion will filter out dead implicit conversions. 2677 if (E->getType() != T) 2678 CheckImplicitConversion(S, E, T); 2679 2680 // Now continue drilling into this expression. 2681 2682 // Skip past explicit casts. 2683 if (isa<ExplicitCastExpr>(E)) { 2684 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 2685 return AnalyzeImplicitConversions(S, E); 2686 } 2687 2688 // Do a somewhat different check with comparison operators. 2689 if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp()) 2690 return AnalyzeComparison(S, cast<BinaryOperator>(E)); 2691 2692 // These break the otherwise-useful invariant below. Fortunately, 2693 // we don't really need to recurse into them, because any internal 2694 // expressions should have been analyzed already when they were 2695 // built into statements. 2696 if (isa<StmtExpr>(E)) return; 2697 2698 // Don't descend into unevaluated contexts. 2699 if (isa<SizeOfAlignOfExpr>(E)) return; 2700 2701 // Now just recurse over the expression's children. 2702 for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end(); 2703 I != IE; ++I) 2704 AnalyzeImplicitConversions(S, cast<Expr>(*I)); 2705} 2706 2707} // end anonymous namespace 2708 2709/// Diagnoses "dangerous" implicit conversions within the given 2710/// expression (which is a full expression). Implements -Wconversion 2711/// and -Wsign-compare. 2712void Sema::CheckImplicitConversions(Expr *E) { 2713 // Don't diagnose in unevaluated contexts. 2714 if (ExprEvalContexts.back().Context == Sema::Unevaluated) 2715 return; 2716 2717 // Don't diagnose for value- or type-dependent expressions. 2718 if (E->isTypeDependent() || E->isValueDependent()) 2719 return; 2720 2721 AnalyzeImplicitConversions(*this, E); 2722} 2723 2724/// CheckParmsForFunctionDef - Check that the parameters of the given 2725/// function are appropriate for the definition of a function. This 2726/// takes care of any checks that cannot be performed on the 2727/// declaration itself, e.g., that the types of each of the function 2728/// parameters are complete. 2729bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) { 2730 bool HasInvalidParm = false; 2731 for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) { 2732 ParmVarDecl *Param = FD->getParamDecl(p); 2733 2734 // C99 6.7.5.3p4: the parameters in a parameter type list in a 2735 // function declarator that is part of a function definition of 2736 // that function shall not have incomplete type. 2737 // 2738 // This is also C++ [dcl.fct]p6. 2739 if (!Param->isInvalidDecl() && 2740 RequireCompleteType(Param->getLocation(), Param->getType(), 2741 diag::err_typecheck_decl_incomplete_type)) { 2742 Param->setInvalidDecl(); 2743 HasInvalidParm = true; 2744 } 2745 2746 // C99 6.9.1p5: If the declarator includes a parameter type list, the 2747 // declaration of each parameter shall include an identifier. 2748 if (Param->getIdentifier() == 0 && 2749 !Param->isImplicit() && 2750 !getLangOptions().CPlusPlus) 2751 Diag(Param->getLocation(), diag::err_parameter_name_omitted); 2752 2753 // C99 6.7.5.3p12: 2754 // If the function declarator is not part of a definition of that 2755 // function, parameters may have incomplete type and may use the [*] 2756 // notation in their sequences of declarator specifiers to specify 2757 // variable length array types. 2758 QualType PType = Param->getOriginalType(); 2759 if (const ArrayType *AT = Context.getAsArrayType(PType)) { 2760 if (AT->getSizeModifier() == ArrayType::Star) { 2761 // FIXME: This diagnosic should point the the '[*]' if source-location 2762 // information is added for it. 2763 Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 2764 } 2765 } 2766 } 2767 2768 return HasInvalidParm; 2769} 2770