SemaObjCProperty.cpp revision 13bf6336ab395eb6af487ab96d32229460907769
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian#include "clang/AST/ExprCXX.h" 2050df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28265941bc308d65cc270d5c4de5806f37ce405606John McCall/// getImpliedARCOwnership - Given a set of property attributes and a 29265941bc308d65cc270d5c4de5806f37ce405606John McCall/// type, infer an expected lifetime. The type's ownership qualification 30265941bc308d65cc270d5c4de5806f37ce405606John McCall/// is not considered. 31265941bc308d65cc270d5c4de5806f37ce405606John McCall/// 32265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Returns OCL_None if the attributes as stated do not imply an ownership. 33265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Never returns OCL_Autoreleasing. 34265941bc308d65cc270d5c4de5806f37ce405606John McCallstatic Qualifiers::ObjCLifetime getImpliedARCOwnership( 35265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attrs, 36265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType type) { 37265941bc308d65cc270d5c4de5806f37ce405606John McCall // retain, strong, copy, weak, and unsafe_unretained are only legal 38265941bc308d65cc270d5c4de5806f37ce405606John McCall // on properties of retainable pointer type. 39265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & (ObjCPropertyDecl::OBJC_PR_retain | 40265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_strong | 41265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 42265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Strong; 43265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_weak) { 44265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Weak; 45265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_unsafe_unretained) { 46265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 47265941bc308d65cc270d5c4de5806f37ce405606John McCall } 48265941bc308d65cc270d5c4de5806f37ce405606John McCall 49265941bc308d65cc270d5c4de5806f37ce405606John McCall // assign can appear on other types, so we have to check the 50265941bc308d65cc270d5c4de5806f37ce405606John McCall // property type. 51265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & ObjCPropertyDecl::OBJC_PR_assign && 52265941bc308d65cc270d5c4de5806f37ce405606John McCall type->isObjCRetainableType()) { 53265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 54265941bc308d65cc270d5c4de5806f37ce405606John McCall } 55265941bc308d65cc270d5c4de5806f37ce405606John McCall 56265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_None; 57265941bc308d65cc270d5c4de5806f37ce405606John McCall} 58265941bc308d65cc270d5c4de5806f37ce405606John McCall 59f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 60f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 61f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 62f85e193739c953358c865005855253af4f68a497John McCall 63f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 64f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 65f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 66f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 67f85e193739c953358c865005855253af4f68a497John McCall 68f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 69f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 70f85e193739c953358c865005855253af4f68a497John McCall 71265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime expectedLifetime 72265941bc308d65cc270d5c4de5806f37ce405606John McCall = getImpliedARCOwnership(propertyKind, property->getType()); 73265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!expectedLifetime) { 74f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 75265941bc308d65cc270d5c4de5806f37ce405606John McCall // attribute. That's okay, but restore reasonable invariants by 76265941bc308d65cc270d5c4de5806f37ce405606John McCall // setting the property attribute according to the lifetime 77265941bc308d65cc270d5c4de5806f37ce405606John McCall // qualifier. 78265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attr; 79265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == Qualifiers::OCL_Strong) { 80265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_strong; 81265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak) { 82265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_weak; 83265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 84265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(propertyLifetime == Qualifiers::OCL_ExplicitNone); 85265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 86265941bc308d65cc270d5c4de5806f37ce405606John McCall } 87265941bc308d65cc270d5c4de5806f37ce405606John McCall property->setPropertyAttributes(attr); 88f85e193739c953358c865005855253af4f68a497John McCall return; 89f85e193739c953358c865005855253af4f68a497John McCall } 90f85e193739c953358c865005855253af4f68a497John McCall 91f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 92f85e193739c953358c865005855253af4f68a497John McCall 93f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 94f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 95b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 96f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 97265941bc308d65cc270d5c4de5806f37ce405606John McCall << expectedLifetime 98f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 99f85e193739c953358c865005855253af4f68a497John McCall} 100f85e193739c953358c865005855253af4f68a497John McCall 101d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 102d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 103d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 104d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 105d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 106d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 1074a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 1084a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 10928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 110f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 111f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 112e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if ((getLangOptions().getGC() != LangOptions::NonGC && 113f85e193739c953358c865005855253af4f68a497John McCall T.isObjCGCWeak()) || 114f85e193739c953358c865005855253af4f68a497John McCall (getLangOptions().ObjCAutoRefCount && 115f85e193739c953358c865005855253af4f68a497John McCall T.getObjCLifetime() == Qualifiers::OCL_Weak)) 116f85e193739c953358c865005855253af4f68a497John McCall Attributes |= ObjCDeclSpec::DQ_PR_weak; 117f85e193739c953358c865005855253af4f68a497John McCall 11828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 11928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 12028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 12128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 12228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 12328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 12428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 12528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 126f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 127f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 128f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 129f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 13014086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 131e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 132a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 133e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 13428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 135ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 136a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian Decl *Res = HandlePropertyInClassExtension(S, AtLoc, 137ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 138ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 139ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 140ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 141ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 142f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 143ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 144f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 145f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 146f85e193739c953358c865005855253af4f68a497John McCall } 147ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 148ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 149ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 150f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 151f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 152f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 153f85e193739c953358c865005855253af4f68a497John McCall Attributes, TSI, MethodImplKind); 1544a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1554a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1564a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 157842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 158842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 159f85e193739c953358c865005855253af4f68a497John McCall 160f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 161f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 162f85e193739c953358c865005855253af4f68a497John McCall 163842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 164e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 165e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 166d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 167a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 169e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 170e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 171e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 172e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 173e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 17483a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 175e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 17658a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 177e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 178a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 179e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 1802a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 1812a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 1822a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 1832a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 1842a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 1852a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 1862a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 1872a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 1882a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 1892a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 1902a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 1912a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 1922a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 1932a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1942a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1952a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 196e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 197e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 19888f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 199e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 200e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 201e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 20222f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 20322f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 20422f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 20522f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 20688f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 20788f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 20888f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 20991ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 210e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 211e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 212e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 213e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 214e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 215e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 216e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 217d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 218e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 219e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 220e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 221e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 222e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 223e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 224e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 225e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 226e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 227e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 228e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 229e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 23023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek Attributes, T, MethodImplKind, DC); 231e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 232e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 233e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 234e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 235a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek ProcessPropertyDecl(PDecl, CCPrimary, /* redeclaredProperty = */ 0, 236a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 237d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PDecl; 238e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 239a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian if (PIDecl->getType().getCanonicalType() 240a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian != PDecl->getType().getCanonicalType()) { 241a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian Diag(AtLoc, 24268af536046461b514b59aedac016b52784ece3f7Fariborz Jahanian diag::warn_type_mismatch_continuation_class) << PDecl->getType(); 243a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian Diag(PIDecl->getLocation(), diag::note_property_declare); 244a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian } 245a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian 246e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 247e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 24880aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 249e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 250e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 251e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 252f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 253e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 254e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 255e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 256e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 257e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 258e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 259e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 2609944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 2619944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 2629944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 263e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 264e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 265e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 266e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 267e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 268e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 269e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 270e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 271a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 272a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 2737939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 2747939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 275d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 276e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 277e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 278e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 279a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 2804a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 2814a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 282d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 28328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 284e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 285e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 286e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 287f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 288f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 289e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 290e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 291e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 292e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 293788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 294788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 295788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 296788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 297788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 298788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 299788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 300788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 301788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 302788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 303e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 304e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 305e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 306e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 307e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 3088254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 309d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 310e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 311e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 312e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 313e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 314e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 315e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 316e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 317e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 318e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 319e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 320e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 32183a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 32223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 32323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 324e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 32583a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 32628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 32728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 32828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 329e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::NonGC && 33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 331c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 332c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 333c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 334c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 335c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 336c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 337c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 338c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 33928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 340c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 34128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 34228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 343e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 34428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 34528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 34683a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 347e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 3489f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 3499f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 35028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 351894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 35228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 35328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 35423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 35528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 35623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 35723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 35823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 35928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 36028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 36128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 36228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 36328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 36428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 36528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 36728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 36828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 37128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 3720a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 3730a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 3740a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 3750a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 3760a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 3770a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_getter) 3780a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 3790a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_setter) 3800a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 3810a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_assign) 3820a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 3830a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_retain) 3840a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 3850a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_strong) 3860a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 3870a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_weak) 3880a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 3890a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_copy) 3900a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 3910a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 3920a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 3930a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 3940a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 3950a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 3960a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 3970a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 3980a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 3990a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten); 4000a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 40128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 40228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 40328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 40428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 40528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 40628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 40728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 40928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 41028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 41128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 41328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 41428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 41528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 416f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 417f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 418f85e193739c953358c865005855253af4f68a497John McCall 419f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) 420f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 421f85e193739c953358c865005855253af4f68a497John McCall 42228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 42328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 42428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 425f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 426f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 427f85e193739c953358c865005855253af4f68a497John McCall 42828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 42928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 43028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 431265941bc308d65cc270d5c4de5806f37ce405606John McCall // In the semantic attributes, one of nonatomic or atomic is always set. 43228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 43328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 434265941bc308d65cc270d5c4de5806f37ce405606John McCall else 43545937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 43628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 437f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 438f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 439f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 440f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 441f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 442f85e193739c953358c865005855253af4f68a497John McCall 44328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 44528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 44628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 44728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 448e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 44928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 45028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 451f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 452f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 453f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 454f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 455f85e193739c953358c865005855253af4f68a497John McCall 456f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 457f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 458f85e193739c953358c865005855253af4f68a497John McCall 459265941bc308d65cc270d5c4de5806f37ce405606John McCall // The lifetime implied by the property's attributes. 460265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime propertyLifetime = 461265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(property->getPropertyAttributes(), 462265941bc308d65cc270d5c4de5806f37ce405606John McCall property->getType()); 463f85e193739c953358c865005855253af4f68a497John McCall 464265941bc308d65cc270d5c4de5806f37ce405606John McCall // We're fine if they match. 465265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == ivarLifetime) return; 466f85e193739c953358c865005855253af4f68a497John McCall 467265941bc308d65cc270d5c4de5806f37ce405606John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 468265941bc308d65cc270d5c4de5806f37ce405606John McCall if (ivarLifetime == Qualifiers::OCL_None || 469265941bc308d65cc270d5c4de5806f37ce405606John McCall ivarLifetime == Qualifiers::OCL_Autoreleasing) 470265941bc308d65cc270d5c4de5806f37ce405606John McCall return; 471265941bc308d65cc270d5c4de5806f37ce405606John McCall 472265941bc308d65cc270d5c4de5806f37ce405606John McCall switch (propertyLifetime) { 473265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Strong: 474265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_strong_property_ownership) 475265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 476265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 477265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivarLifetime; 478265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 479265941bc308d65cc270d5c4de5806f37ce405606John McCall 480265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Weak: 481265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::error_weak_property) 482265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 483265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName(); 484265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 485265941bc308d65cc270d5c4de5806f37ce405606John McCall 486265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_ExplicitNone: 487265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_assign_property_ownership) 488265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 489265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 490265941bc308d65cc270d5c4de5806f37ce405606John McCall << ((property->getPropertyAttributesAsWritten() 491265941bc308d65cc270d5c4de5806f37ce405606John McCall & ObjCPropertyDecl::OBJC_PR_assign) != 0); 492265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 493265941bc308d65cc270d5c4de5806f37ce405606John McCall 494265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Autoreleasing: 495265941bc308d65cc270d5c4de5806f37ce405606John McCall llvm_unreachable("properties cannot be autoreleasing"); 496265941bc308d65cc270d5c4de5806f37ce405606John McCall 497265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_None: 498265941bc308d65cc270d5c4de5806f37ce405606John McCall // Any other property should be ignored. 499f85e193739c953358c865005855253af4f68a497John McCall return; 500f85e193739c953358c865005855253af4f68a497John McCall } 501f85e193739c953358c865005855253af4f68a497John McCall 502f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 503f85e193739c953358c865005855253af4f68a497John McCall} 504f85e193739c953358c865005855253af4f68a497John McCall 50528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 50628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 50728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 50828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 50928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 510d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 511d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 512d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 513d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 514d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 515a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 516a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 517e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 51884e0ccff7a6e51d7b81fd58686b493a4880dd44dFariborz Jahanian dyn_cast<ObjCContainerDecl>(CurContext); 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 52128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 522d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 52328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 52428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 52528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 52628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 52728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 52828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 52928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 53028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 53828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 54028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 541d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 54228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 543dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 54445937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 54545937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 546dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 547dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 548dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 549dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 550dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 551dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 552dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 55328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 55428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 55628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 55728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 558d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 55928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 56328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 564d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 56528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 56728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 56828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 569d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 57128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 57228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 57328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 57428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 57528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 57628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 577d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 57828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 58028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 58128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 58228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 583d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 58628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 587d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 59028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 59128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 59228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 59328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 59428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 595f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind kind 596f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 597265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropType = property->getType(); 598265941bc308d65cc270d5c4de5806f37ce405606John McCall 599265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropertyIvarType = PropType.getNonReferenceType(); 600265941bc308d65cc270d5c4de5806f37ce405606John McCall 601265941bc308d65cc270d5c4de5806f37ce405606John McCall // Add GC __weak to the ivar type if the property is weak. 602265941bc308d65cc270d5c4de5806f37ce405606John McCall if ((kind & ObjCPropertyDecl::OBJC_PR_weak) && 603e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC) { 604265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(!getLangOptions().ObjCAutoRefCount); 605265941bc308d65cc270d5c4de5806f37ce405606John McCall if (PropertyIvarType.isObjCGCStrong()) { 606265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(PropertyLoc, diag::err_gc_weak_property_strong_type); 607265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(property->getLocation(), diag::note_property_declare); 608265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 609265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType = 610265941bc308d65cc270d5c4de5806f37ce405606John McCall Context.getObjCGCQualType(PropertyIvarType, Qualifiers::Weak); 611edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 612edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 613265941bc308d65cc270d5c4de5806f37ce405606John McCall 61428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 61528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 61628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 61728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 618265941bc308d65cc270d5c4de5806f37ce405606John McCall // In ARC, give the ivar a lifetime qualifier based on the 619f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 620f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 621265941bc308d65cc270d5c4de5806f37ce405606John McCall !PropertyIvarType.getObjCLifetime() && 622265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType->isObjCRetainableType()) { 623f85e193739c953358c865005855253af4f68a497John McCall 624265941bc308d65cc270d5c4de5806f37ce405606John McCall // It's an error if we have to do this and the user didn't 625265941bc308d65cc270d5c4de5806f37ce405606John McCall // explicitly write an ownership attribute on the property. 626473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 627265941bc308d65cc270d5c4de5806f37ce405606John McCall !(kind & ObjCPropertyDecl::OBJC_PR_strong)) { 628473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(PropertyLoc, 629473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 630473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 631265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 632265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime lifetime = 633265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(kind, PropertyIvarType); 634265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(lifetime && "no lifetime for property?"); 635473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis 636265941bc308d65cc270d5c4de5806f37ce405606John McCall if (lifetime == Qualifiers::OCL_Weak && 637265941bc308d65cc270d5c4de5806f37ce405606John McCall !getLangOptions().ObjCRuntimeHasWeak) { 638f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::err_arc_weak_no_runtime); 639f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 640f85e193739c953358c865005855253af4f68a497John McCall } 641265941bc308d65cc270d5c4de5806f37ce405606John McCall 642f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 643265941bc308d65cc270d5c4de5806f37ce405606John McCall qs.addObjCLifetime(lifetime); 644f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 645f85e193739c953358c865005855253af4f68a497John McCall } 646f85e193739c953358c865005855253af4f68a497John McCall } 647f85e193739c953358c865005855253af4f68a497John McCall 648f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 649f85e193739c953358c865005855253af4f68a497John McCall !getLangOptions().ObjCAutoRefCount && 650e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() == LangOptions::NonGC) { 651f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::error_synthesize_weak_non_arc_or_gc); 652f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 653f85e193739c953358c865005855253af4f68a497John McCall } 654f85e193739c953358c865005855253af4f68a497John McCall 655ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 656ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara PropertyLoc, PropertyLoc, PropertyIvar, 65714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 6587504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 659ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 66029fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 66128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 66228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 66328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 66428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 66528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 66628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 66728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 66828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 66928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 67028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 67128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 67228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 67328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 6744087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 67528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 67628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 67728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 67828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 67928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 680265941bc308d65cc270d5c4de5806f37ce405606John McCall if (Context.getCanonicalType(PropertyIvarType) != IvarType) { 68162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 68214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 683f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 68462ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 68562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 68614086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 68762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 688b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 689b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor SourceLocation Loc = PropertyIvarLoc; 690b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor if (Loc.isInvalid()) 691b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor Loc = PropertyLoc; 69214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian compat = (CheckAssignmentConstraints(Loc, PropertyIvarType, IvarType) 693daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 694b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 69562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 69628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 697f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 698f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 699f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 70028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 70128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 70228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 70328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 70428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 70528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 70628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 70714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 70828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 70928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 71028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 71128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 712f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 713f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 714f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 71528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 71628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 71728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 718f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 719e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC)) { 72028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 72128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 722edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 72328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 72428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 725f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 72628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 72728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 728e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC) { 72928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 73028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 73128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 73228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 73328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 734f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 735f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 73628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 73728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 73828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 739f85e193739c953358c865005855253af4f68a497John McCall 74028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 74128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 74228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 74328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 74428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 74528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 74628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 747a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 74817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 74917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 7500313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize && 7510313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 75217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 75317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 75417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 75517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 75617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 757f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 758f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 75917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 76017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 76117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 76260d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 76317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 7643c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 7653c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 7663c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 76717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 76817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 76917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 77017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 77117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 7724765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 77317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 77417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 77517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 776831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 777831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 778831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 779831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 780831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 781831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 78217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 78317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 78417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 7850313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize 7860313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian && Ivar->getType()->isRecordType()) { 78717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 78817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 78917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 790f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 791f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 79217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 79317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 79417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 79517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 79617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 79714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType T = Param->getType(); 79814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (T->isReferenceType()) 79961750f2bed7f5c0e440318841e3be385920b22f3Fariborz Jahanian T = T->getAs<ReferenceType>()->getPointeeType(); 80014086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian Expr *rhs = new (Context) DeclRefExpr(Param, T, 801f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 802fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 8032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 80457e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (property->getPropertyAttributes() & 80557e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_atomic) { 80657e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Expr *callExpr = Res.takeAs<Expr>(); 80757e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (const CXXOperatorCallExpr *CXXCE = 80813bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian dyn_cast_or_null<CXXOperatorCallExpr>(callExpr)) 80913bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian if (const FunctionDecl *FuncDecl = CXXCE->getDirectCallee()) 81057e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (!FuncDecl->isTrivial()) 81157e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Diag(PropertyLoc, 81257e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian diag::warn_atomic_property_nontrivial_assign_op) 81357e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian << property->getType(); 81457e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian } 81517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 81617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 81717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 81817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 81928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 82028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 82128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 82228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 82328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 82428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 82528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 82628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 82728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 82828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 82928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 83028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 83128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 83228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 833d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 83428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 83528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 836e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian if (getLangOptions().ObjCDefaultSynthProperties && 837e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian getLangOptions().ObjCNonFragileABI2) { 838ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 839ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 840cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 841411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 842ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 843ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 844ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 845ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 846ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 847ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 848ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 849cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 850cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 851cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian IC->getClassInterface() == ClassDeclared) { 852ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 853ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 854ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 855ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 856ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 85728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 85828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 85928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 86028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 86128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 86228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 86328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 86428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 86528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 86628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 86728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 86828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 86928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 87028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 871d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 87228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 87328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 87428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 87528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 876d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 87728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 87828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 87928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 88028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 88128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 88228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 8839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 8849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 8859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 8869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 8879d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 8889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 8899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 8909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 8919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 8929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 8939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 8949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 8959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 8969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 8979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 8989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 8999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 902f85e193739c953358c865005855253af4f68a497John McCall else { 903f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 904f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 905f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 906f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 907f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 908f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 909f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 910f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 911f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 912f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 913f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 914f85e193739c953358c865005855253af4f68a497John McCall } 9159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 9179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 9189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 9209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 9219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 9239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 9249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 9269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 9289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 9299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 9309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 9319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 932c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 9338beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 9348beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 9358beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 9368beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 9378beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 9388beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 9398beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian IncompatibleObjC) 9408beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 9418beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 9469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 9479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 9489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 9499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->getResultType() != property->getType()) { 9509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 9511c23e91ef66688d20868b6bab3b5589a119eb603John McCall if (property->getType()->isObjCObjectPointerType()) 952b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor result = CheckAssignmentConstraints(Loc, GetterMethod->getResultType(), 9531c23e91ef66688d20868b6bab3b5589a119eb603John McCall property->getType()); 9549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 9559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 9569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 9579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 9589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 9669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 967fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 9699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 9769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 9779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 9849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 9899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 9909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 9919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 9929d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 9939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 9949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 9999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 10009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 10019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 10029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 10049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 10052d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 10069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 10099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 10109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 10159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 10169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 10179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 10189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 10229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 1032d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 1033d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 10349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 10479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 1050d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 106153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 106253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 106353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 106953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 107053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 107153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1072d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 10849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 10859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 10869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 10879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 10889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 10909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 10919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 10959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 10969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 10979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 10989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 11019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 11059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 11069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 11199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 11259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 11279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 11289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 11299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 11309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 11339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 11349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1135cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 1136cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 11379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 11389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 11399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 11409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 114453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 114553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 114653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1147cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 11509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 11519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 11529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 11539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 115753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 11589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1159cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 11639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 11649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 1165cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1166cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1167cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1168a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian if (!PropertyFromSuper || 1169a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian PropertyFromSuper->getIdentifier() != Prop->getIdentifier()) { 1170cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1171cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1172cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1173cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 11749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 11769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 11779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1178cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1182509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 1183509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 1184509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 1185509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 1186509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1187509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1188509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1189509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 1190509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1191509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1192509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 119353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 119453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 119553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1196509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1197509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1198509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1199509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1200509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 1201509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1202509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1203509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1204509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 1205509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1206509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 1207509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1208509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1209509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1210509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1211509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1212509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1213509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1214509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1215509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1216509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1217509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1218509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 1219509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1220509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1221509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1222509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1223509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 12249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 12259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 12269d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 12279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 12289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 12299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 12309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 12319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 12329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 123753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 123853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 123953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 12409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 12469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 12479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 12489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 12499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 12549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 12559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 12569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 12629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1264d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekstatic IdentifierInfo * getDefaultSynthIvarName(ObjCPropertyDecl *Prop, 1265d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ASTContext &Ctx) { 1266d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek llvm::SmallString<128> ivarName; 1267d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek { 1268d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek llvm::raw_svector_ostream os(ivarName); 1269d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek os << '_' << Prop->getIdentifier()->getName(); 1270d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek } 1271d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek return &Ctx.Idents.get(ivarName.str()); 1272d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek} 1273d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek 1274509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 1275509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 1276d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekvoid Sema::DefaultSynthesizeProperties(Scope *S, ObjCImplDecl* IMPDecl, 1277d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ObjCInterfaceDecl *IDecl) { 1278509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1279509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1280509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 1281509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1282509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1283509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1284509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1285509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1286509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1287509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1288509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1289509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1290509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1291509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1292509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1293509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1294509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1295509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1296509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1297d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1298d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1299d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 130095f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 130195f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 130295f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 130395f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 130495f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 130595f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1306d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian 13072a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 13082a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 13092a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 13102a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 13112a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 13122a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1313a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian true, 1314d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek /* property = */ Prop->getIdentifier(), 1315d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek /* ivar = */ getDefaultSynthIvarName(Prop, Context), 1316a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation()); 13172a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1318509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 13199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13208697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 13218697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!LangOpts.ObjCDefaultSynthProperties || !LangOpts.ObjCNonFragileABI2) 13228697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 13238697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 13248697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 13258697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 13268697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 13278697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 13288697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 13298697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 133017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 13319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 13329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 1333cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1334cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1335cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1336cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 13379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1338cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 13399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 13409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 13439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 13449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 13459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 13469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 13479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 13509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 13539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1354327126ee3d2faad9314b2633974eefc672f73b79Fariborz Jahanian PropImplMap.count(Prop) || Prop->hasAttr<UnavailableAttr>()) 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 1357b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1362b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1363b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 13649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1367b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 13689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1372b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1373b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 13749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13799d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 13809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 13819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 1382e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::NonGC) 13839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 13859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 13869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 13879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 138894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 138994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 139094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 139194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 1393265941bc308d65cc270d5c4de5806f37ce405606John McCall unsigned AttributesAsWritten = Property->getPropertyAttributesAsWritten(); 139494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1395265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic) && 1396265941bc308d65cc270d5c4de5806f37ce405606John McCall !(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 139794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 139894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 139994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 140094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 140194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 140294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1403293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 140494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 140594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 140694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 140794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 140894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1409293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 141094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 141194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 141294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 141394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 14149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 14159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 14169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 14179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 14189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 14199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 14209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 14219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 142294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 142394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 142494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 142594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 142694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 14279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 14289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 14299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 14309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 14319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 14327d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << Property->getIdentifier() << (GetterMethod != 0) 14337d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << (SetterMethod != 0); 14347d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian Diag(MethodLoc, diag::note_atomic_property_fixup_suggest); 14359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 14369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1441f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 1442e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() == LangOptions::GCOnly) 1443f85e193739c953358c865005855253af4f68a497John McCall return; 1444f85e193739c953358c865005855253af4f68a497John McCall 1445f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1446f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1447f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyImplDecl *PID = *i; 1448f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1449f85e193739c953358c865005855253af4f68a497John McCall continue; 1450f85e193739c953358c865005855253af4f68a497John McCall 1451f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1452831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1453831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1454f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1455f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1456f85e193739c953358c865005855253af4f68a497John McCall continue; 1457f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1458f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1459f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 1460f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 1461f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1462f85e193739c953358c865005855253af4f68a497John McCall else 1463f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::warn_ownin_getter_rule); 1464f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1465f85e193739c953358c865005855253af4f68a497John McCall } 1466f85e193739c953358c865005855253af4f68a497John McCall } 1467f85e193739c953358c865005855253af4f68a497John McCall } 1468f85e193739c953358c865005855253af4f68a497John McCall} 1469f85e193739c953358c865005855253af4f68a497John McCall 14705de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 14715de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 14725de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 14735de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 14745de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 14750a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 14760a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 14770a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 14780a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 14790a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 14800a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 14810a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 14820a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 14835de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 14845de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 14859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 14869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 14879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 14889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 14899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 14909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 14918254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 14928254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 14938254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 14948254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 14959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 14969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 14989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 14999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 15009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 15019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 15039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 15049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 15059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 15069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 15079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 15089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 15099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 15102aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian !Context.hasSameUnqualifiedType( 15112aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian (*SetterMethod->param_begin())->getType(), property->getType())) { 15129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 15139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 15149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 15159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 15169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 15179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 15219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 15229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 15239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 15249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 15259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 15269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 15279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 15289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 15299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1530a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1531a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1532a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1533a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1534a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1535a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 153675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 153775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isVariadic=*/false, /*isSynthesized=*/true, 153875cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 15399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 15429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 15439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 15445de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15455de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 15465de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 154723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 154823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1549a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 155023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1551831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1552831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1553831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 15549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 15559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 15569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 15579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 15589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 15599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 15619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 15629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 15639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 15649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 15659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 15669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 15678254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 15688254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 15698254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 15708254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15718254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 1572491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ObjCMethodDecl::Create(Context, Loc, Loc, 15738254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 157475cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 157575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isSynthesized=*/true, 157675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 157775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 15789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15808254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 15818254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 15828254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 15849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1585ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1586ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 15879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1588f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 15899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1590d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1591d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 15929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 1593491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis SetterMethod->setMethodParams(Context, Argument, 1594491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ArrayRef<SourceLocation>()); 15955de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15965de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 15975de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 159923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 160023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 16018254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 160223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 16039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 16049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 16059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 16069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 16079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 16089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 16109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 16119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 16139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 16149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 16159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 16179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 16189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 16199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 16209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 16229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 16239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 16249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 16259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 16269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1627d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 16289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 16299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 16309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1631f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 16325fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 16335fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 16345fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1635842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 16369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 16389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 163928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 164028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 1641f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 164228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 1643f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 1644f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 164528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 164628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 164728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 164828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 1649f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 1650f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 165128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 165228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 16539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 165428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 165528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 165628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 165728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 165828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 166028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 1661f85e193739c953358c865005855253af4f68a497John McCall if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1662f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 1663f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 1664842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 166528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 1666f85e193739c953358c865005855253af4f68a497John McCall << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 1667f85e193739c953358c865005855253af4f68a497John McCall Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 1668f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1669f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 167028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 167228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 167328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 167428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 167528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 167628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 167728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 167828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 167928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 168028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 168128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 168228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 168328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1684f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1685f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1686f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 1687f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1688f85e193739c953358c865005855253af4f68a497John McCall } 1689f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1690f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1691f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1692f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 1693f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1694f85e193739c953358c865005855253af4f68a497John McCall } 1695f85e193739c953358c865005855253af4f68a497John McCall } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 1696f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1697f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1698f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 1699f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 1700f85e193739c953358c865005855253af4f68a497John McCall } 1701f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1702f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1703f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 1704f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1705f85e193739c953358c865005855253af4f68a497John McCall } 1706f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1707f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1708f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 1709f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1710f85e193739c953358c865005855253af4f68a497John McCall } 1711f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1712f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1713f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1714f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 1715f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1716f85e193739c953358c865005855253af4f68a497John McCall } 171728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 171828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 171928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 172028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 172128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 172228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1723f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1724f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1725f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 1726f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1727f85e193739c953358c865005855253af4f68a497John McCall } 1728f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 1729f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1730f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 1731f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1732f85e193739c953358c865005855253af4f68a497John McCall } 1733f85e193739c953358c865005855253af4f68a497John McCall } 1734f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 1735f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1736f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1737f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 1738528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1739f85e193739c953358c865005855253af4f68a497John McCall } 1740f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 1741f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1742f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1743f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 1744f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 174528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 174728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 174828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 174928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 1750f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 1751f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 1752f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 175328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 175428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 1755bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().ObjCAutoRefCount) 1756bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 1757bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // not specified 1758bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 1759bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian else { 1760bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 1761e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::GCOnly) 1762bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 17630a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 1764bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 1765e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() == LangOptions::NonGC) 1766bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 1767bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 17689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 176928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 177028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 177128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 177228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 177328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 177528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 17762b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 1777e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor && getLangOptions().getGC() == LangOptions::GCOnly 177828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 177928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 1780528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian else if (getLangOptions().ObjCAutoRefCount && 1781528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_retain) && 1782528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1783528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 1784528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian PropertyTy->isBlockPointerType()) 1785528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Diag(Loc, diag::warn_objc_property_retain_of_block); 17869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1787