SemaObjCProperty.cpp revision 16573fa9705b546b7597c273b25b85d6321e2b33
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek#include "Sema.h" 169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 2328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted KremenekSema::DeclPtrTy Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FieldDeclarator &FD, 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec &ODS, 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Selector GetterSel, 2728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Selector SetterSel, 2828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DeclPtrTy ClassCategory, 2928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool *isOverridingProperty, 3028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 3128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 3228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 3328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 3428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 3528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 3628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 3728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 3828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 3928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 4028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_copy))); 41e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 4228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType T = GetTypeForDeclarator(FD.D, S); 4328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isReferenceType()) { 4428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_reference_property); 4528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 4628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 47e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 48e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *ClassDecl = 49e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek cast<ObjCContainerDecl>(ClassCategory.getAs<Decl>()); 50e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 5128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 52e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (CDecl->IsClassExtension()) 53e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return HandlePropertyInClassExtension(S, CDecl, AtLoc, 54e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, 55e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek isAssign, isReadWrite, 56e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Attributes, 57e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek isOverridingProperty, T, 58e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek MethodImplKind); 59e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 60842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian DeclPtrTy Res = DeclPtrTy::make(CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 61e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek GetterSel, SetterSel, 62e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek isAssign, isReadWrite, 63e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Attributes, T, MethodImplKind)); 64842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 65842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 66842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 67e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 68e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 69e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekSema::DeclPtrTy 70e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekSema::HandlePropertyInClassExtension(Scope *S, ObjCCategoryDecl *CDecl, 71e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 72e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 73e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 74e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 75e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 76e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 77e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek QualType T, 78e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 79e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 80e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 81e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 82e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 83894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek 849f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 859f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 86e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::err_duplicate_property); 87894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 88e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return DeclPtrTy(); 89e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 90e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 91e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 92e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 93e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 94e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 95e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 9622f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 9722f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 9822f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 9922f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 10022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian 101e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 102e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 103e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 104e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 105e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 106e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 107e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 108e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 109e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return DeclPtrTy(); 110e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 111e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 112e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 113e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 114e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 115e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 116e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 117e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 118e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 119e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 120e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 121e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 122e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Attributes, T, MethodImplKind); 123e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 124e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 125e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 126e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 127e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProcessPropertyDecl(PDecl, CCPrimary); 128e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return DeclPtrTy::make(PDecl); 129e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 130e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 131e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 132e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 133e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 134e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned PIkind = PIDecl->getPropertyAttributes(); 135e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 136e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 137e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 138e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 139e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 140e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 141e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 143e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 144e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 1459944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 1469944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 1479944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 148e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 149e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 150e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 151e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 152e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 153e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 154e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 155e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 156e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 157e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclPtrTy ProtocolPtrTy = 158e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 159e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 160e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 161e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclPtrTy::make(CCPrimary), isOverridingProperty, 162e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek MethodImplKind); 163e9686572f17968048a5e097254f85c202ea44aecTed Kremenek PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy.getAs<Decl>()); 16428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 165e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 166e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 167e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 169e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 170e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 171e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 172e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::err_use_continuation_class) 173e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 174e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 175e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 176e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 177e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 178e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary); 179e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return DeclPtrTy(); 180e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 183e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 184e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 185e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 186e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 187e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 188e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 189e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 190e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 191e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek QualType T, 192e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind){ 193e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 194e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 19528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 19628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 19728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 19828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC && 19928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 20028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isObjCObjectPointerType()) { 20128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType InterfaceTy = T->getPointeeType(); 20228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCInterfaceType *OIT = 20328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek InterfaceTy->getAs<ObjCInterfaceType>()) { 20428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *IDecl = OIT->getDecl(); 20528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IDecl) 20628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCProtocolDecl* PNSCopying = 207c83c6874e3bf1432d3df5e8d3530f8561ff5441fDouglas Gregor LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 20828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 209e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 21028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isObjCInterfaceType()) 21328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 21428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 215e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 21628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 21728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 218e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 219e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 2209f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 2219f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 22228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 223894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 22428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 22528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 22628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else 22728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 22828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 22928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 23028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 23128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 23228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 23328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 23428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 23528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 23628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 23728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 23828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 23928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 24028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 24228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 24328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 24528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 24628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 24828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 24928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 25128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 25228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 25428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 25528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 25728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 25828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 26028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 26128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 26328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 26428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 26628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 26728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 26828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 26928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 270e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 27128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 27228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 27528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 27628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 27728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 27828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted KremenekSema::DeclPtrTy Sema::ActOnPropertyImplDecl(SourceLocation AtLoc, 27928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek SourceLocation PropertyLoc, 28028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool Synthesize, 28128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DeclPtrTy ClassCatImpDecl, 28228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IdentifierInfo *PropertyId, 28328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IdentifierInfo *PropertyIvar) { 284e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 285e9686572f17968048a5e097254f85c202ea44aecTed Kremenek cast_or_null<ObjCContainerDecl>(ClassCatImpDecl.getAs<Decl>()); 28628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 28728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 28828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 28928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 29028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 29128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 29228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 29328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 29428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 29528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 29628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 29728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 29828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 29928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 30028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 30128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 30228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 30328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 30428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 30528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 30628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 30728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 30828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 30928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 31028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 31128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 31228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 31328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 31428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 31528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 31628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 31728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 31828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 31928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 32028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 32128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 32228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 32428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 32528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 32628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 32728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 32928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 33228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 33328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 33428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 33528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 33628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 33728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 33828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 33928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 34028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 34128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 34228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 34328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 34428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 34528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 34628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 34728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 34828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 34928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 35028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 35128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 35228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType PropType = Context.getCanonicalType(property->getType()); 35328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 35428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 35528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 35628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 35729fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, PropertyLoc, 35828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar, PropType, /*Dinfo=*/0, 3592846b2b47029c877357438d16c73911c1510be6cFariborz Jahanian ObjCIvarDecl::Protected, 36028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Expr *)0); 36129fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 36228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 36328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 36428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 36528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 36728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 36828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 37128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 37228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 37328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 37428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 37528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Ivar << Ivar->getNameAsCString(); 37628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 37728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 37828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 37928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 38028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 38128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (PropType != IvarType) { 38228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (CheckAssignmentConstraints(PropType, IvarType) != Compatible) { 38328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 384f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 385f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 386f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 38728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 38828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 38928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 39028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 39128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 39228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 39328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 39428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType lhsType =Context.getCanonicalType(PropType).getUnqualifiedType(); 39528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 39628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 39728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 39828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 399f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 400f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 401f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 40228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 40328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 40428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 40528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 40628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 40728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 40928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 41028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 41128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 41328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 41428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 41528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 41628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 41728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 41828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 41928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 42028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 42128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 42228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 42328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 42428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 42528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 42628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 42728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 42828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 42928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar); 43028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 43128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 43228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 43328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 43428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 43528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 43628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 43728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 43828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 43928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 44028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 44128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 44228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 44328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 44528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 44628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 44728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 44828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 44928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 45028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 45128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 45228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 45328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 45428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 45528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 45628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 45728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 45828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 45928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 46028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 46128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 46228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 46328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 46428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 46528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 46628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy::make(PIDecl); 46728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 46828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 46928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 47028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 47128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 47228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 4739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 4749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 4759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 4769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 4779d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 4789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 4799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 4809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 4819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 4829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 4839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 4849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 4859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 4869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 4879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 4889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 4899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 4909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 4919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 4929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain) 4939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_retain)) 4949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 4959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "retain" << inheritedName; 4969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 4979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 4989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 4999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 5019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 5029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 5049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 5059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 5079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 5099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 5109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 5119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 5129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Context.typesAreCompatible(LHSType, RHSType)) { 5149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Incorporate this test with typesAreCompatible. 5159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType()) 5169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Context.ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false)) 5179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 5189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 5199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getType() << SuperProperty->getType() << inheritedName; 5209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 5219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 5229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 5249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 5259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 5269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 5279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->getResultType() != property->getType()) { 5289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 5299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (property->getType()->isObjCObjectPointerType()) 5309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek result = CheckAssignmentConstraints(GetterMethod->getResultType(), 5319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType()); 5329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 5339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 5349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 5359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 5369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 5379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 5389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 5399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 5409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 5419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 5429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 5449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 5459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// diagnostics in a variety of inconsistant situations. 5469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 5479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 5489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 5499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 5509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 5519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 5529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 5539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 5549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 5559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 5569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 5579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 5589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 5599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 5609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 5619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 5629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 5639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 5649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 5659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 5679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 5689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 5699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 5709d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 5719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 5729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 5739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 5749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 5759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 5769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 5779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 5789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 5799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 5809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 5819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 5829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 5832d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 5849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 5859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 5869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 5879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 5889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 5899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 5909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 5919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 5929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 5939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 5949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 5959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 5969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 5979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 5989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 5999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 6009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 6019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 6029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 6039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 6079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 6089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 6099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 6109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CompareProperties(Decl *CDecl, 6119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DeclPtrTy ClassOrProtocol) { 6129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Decl *ClassDecl = ClassOrProtocol.getAs<Decl>(); 6139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 6149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 6169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 6179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 6189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 6199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 6209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 6219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 6229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 6239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 6249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 6269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 6279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 6289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 6299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CompareProperties(CatDecl, DeclPtrTy::make(*P)); 6309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 6319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 6329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 6339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 6349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 6359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 6379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 6409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator P = MDecl->protocol_begin(), 6419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 6429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 6439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 6449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 6469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 6479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator P = IDecl->protocol_begin(), 6489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); P != E; ++P) 6499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CompareProperties(IDecl, DeclPtrTy::make(*P)); 6509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 6519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 6529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 6539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 6549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 6559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 6599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 6609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 6619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 6629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 6639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 6649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 6659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 6679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 6689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 6699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 6729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 6739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 6749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 6759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 6769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 6779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 6789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 6799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 6819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 6829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 6839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 6879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 6889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 6899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 6909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 6919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 6929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 6949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 6959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 6969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 7009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 7019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 7029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 7049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 7059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 7069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 7079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 7109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 7119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 7129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 7139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 7149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 7159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 7169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 7179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 7189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 7209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 7219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); PI != E; ++PI) 7229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CollectImmediateProperties((*PI), PropMap); 7239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 7259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 7269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 7279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 7289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 7299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 7309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 7329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = CATDecl->protocol_begin(), 7339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 7349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CollectImmediateProperties((*PI), PropMap); 7359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 7379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 7389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 7399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 7409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 7419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PropEntry) 7429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropEntry = Prop; 7439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 7459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 7469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 7479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CollectImmediateProperties((*PI), PropMap); 7489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 7529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 7539d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 7549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 7559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 7569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 7579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 7589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 7599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 7609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 7619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 7629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 7649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 7659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); PI != E; ++PI) { 7669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 7679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 7689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 7699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 7729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 7739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 7749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 7759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 7769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 7779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 7789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 7809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 7819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 7829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 7839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 7849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 7859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 7889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::DiagnoseUnimplementedProperties(ObjCImplDecl* IMPDecl, 7929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 7939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 7949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 7959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CollectImmediateProperties(CDecl, PropMap); 7969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 7979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 7989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 8009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 8019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 8029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 8039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 8049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 8069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 8079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 8089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 8099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 8109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 8119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.count(Prop)) 8129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 8139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (LangOpts.ObjCNonFragileABI2) { 8149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ActOnPropertyImplDecl(IMPDecl->getLocation(), 8159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation(), 8169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek true, DeclPtrTy::make(IMPDecl), 8179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getIdentifier(), 8189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getIdentifier()); 8199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 8209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 8229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 8239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 8249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 8259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 8269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 8279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 8289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 8299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 8329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 8339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 8349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 8359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 8369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 8379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 8389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 8399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 8429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 8449d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 8459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 8469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 8479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC) 8489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 8499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 8509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 8519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 8529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 8539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 8549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 8559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 8569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 8579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 8589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 8599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 8609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 8619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 8629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod = 8639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IMPDecl->getInstanceMethod(Property->getGetterName()); 8649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *SetterMethod = 8659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IMPDecl->getInstanceMethod(Property->getSetterName()); 8669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 8679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 8689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 8699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 8709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 8719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getIdentifier(); 8729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 8739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 8779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 8799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 8809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 8819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 8829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 8839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 8849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CD) { 8859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 8869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 8889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 8899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 8909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 8919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 8939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 8949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 8959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 8969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 8979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 8989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 8999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ((*SetterMethod->param_begin())->getType() != property->getType())) { 9019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 9029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 9039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 9049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 9059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 9069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 9109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 9119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 9129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 9139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 9149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 9159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 9169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 9179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 9189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 9199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 9209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), property->getGetterName(), 9219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType(), 0, CD, true, false, true, 9229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 9239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 9249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 9259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 9269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 9279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 9289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 9299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 9309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 9319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 9329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 9349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 9359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 9369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 9379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 9389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 9399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 9409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 9419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), 9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getSetterName(), 9439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy, 0, CD, true, false, true, 9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 9469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 9479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 9489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 9499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 9509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 9519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), 9529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 9539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType(), 9549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 9559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek VarDecl::None, 95616573fa9705b546b7597c273b25b85d6321e2b33Douglas Gregor VarDecl::None, 9579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 9584ecb25fa94897b2c03510292acace710e5262ba5Fariborz Jahanian SetterMethod->setMethodParams(Context, &Argument, 1, 1); 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 9619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 9649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 9659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 9679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 9699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 9769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 9779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 984842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanianvoid Sema::CheckObjCPropertyAttributes(DeclPtrTy PropertyPtrTy, 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 988842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian Decl *PDecl = PropertyPtrTy.getAs<Decl>(); 9895fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek if (!PDecl) 9905fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 9915fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 9925fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 993842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 9949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 99728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 99828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 99928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 100028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_retain))) { 100128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 100228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 100328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 100428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 100528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 100628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 100828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 100928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 101028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 101128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 101228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 101428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 101528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) && 101628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !PropertyTy->isObjCObjectPointerType() && 101728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !PropertyTy->isBlockPointerType() && 1018842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !Context.isObjCNSObjectType(PropertyTy) && 1019842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 102028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 102128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << (Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain"); 102228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain); 102328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 102528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 102628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 102728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 102828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 102928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 103028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 103128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 103228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 103328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 103428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 103528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 103628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 103728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 103828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 103928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 104028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 104128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 104228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 104328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 104528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 104628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 104728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 104828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_retain)) && 104928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 105028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 105128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Skip this warning in gc-only mode. 105228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::GCOnly) 105328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 105528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If non-gc code warn that this is likely inappropriate. 105628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() == LangOptions::NonGC) 105728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_default_assign_on_object); 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 105928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 106028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 106128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 106228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 106328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 106528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 106628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && getLangOptions().getGCMode() == LangOptions::GCOnly 106728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 106828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1070