SemaObjCProperty.cpp revision 5bf5c2ec54ede5352293e5739e9b44bea2f6b01b
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian#include "clang/AST/ExprCXX.h" 20c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis#include "clang/AST/ASTMutationListener.h" 21edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian#include "clang/Lex/Lexer.h" 22edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian#include "clang/Basic/SourceManager.h" 2350df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 248fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 25fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian#include "clang/Lex/Preprocessor.h" 269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 3128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33265941bc308d65cc270d5c4de5806f37ce405606John McCall/// getImpliedARCOwnership - Given a set of property attributes and a 34265941bc308d65cc270d5c4de5806f37ce405606John McCall/// type, infer an expected lifetime. The type's ownership qualification 35265941bc308d65cc270d5c4de5806f37ce405606John McCall/// is not considered. 36265941bc308d65cc270d5c4de5806f37ce405606John McCall/// 37265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Returns OCL_None if the attributes as stated do not imply an ownership. 38265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Never returns OCL_Autoreleasing. 39265941bc308d65cc270d5c4de5806f37ce405606John McCallstatic Qualifiers::ObjCLifetime getImpliedARCOwnership( 40265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attrs, 41265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType type) { 42265941bc308d65cc270d5c4de5806f37ce405606John McCall // retain, strong, copy, weak, and unsafe_unretained are only legal 43265941bc308d65cc270d5c4de5806f37ce405606John McCall // on properties of retainable pointer type. 44265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & (ObjCPropertyDecl::OBJC_PR_retain | 45265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_strong | 46265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 47d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return Qualifiers::OCL_Strong; 48265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_weak) { 49265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Weak; 50265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_unsafe_unretained) { 51265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 52265941bc308d65cc270d5c4de5806f37ce405606John McCall } 53265941bc308d65cc270d5c4de5806f37ce405606John McCall 54265941bc308d65cc270d5c4de5806f37ce405606John McCall // assign can appear on other types, so we have to check the 55265941bc308d65cc270d5c4de5806f37ce405606John McCall // property type. 56265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & ObjCPropertyDecl::OBJC_PR_assign && 57265941bc308d65cc270d5c4de5806f37ce405606John McCall type->isObjCRetainableType()) { 58265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 59265941bc308d65cc270d5c4de5806f37ce405606John McCall } 60265941bc308d65cc270d5c4de5806f37ce405606John McCall 61265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_None; 62265941bc308d65cc270d5c4de5806f37ce405606John McCall} 63265941bc308d65cc270d5c4de5806f37ce405606John McCall 64f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 65f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 66f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 67f85e193739c953358c865005855253af4f68a497John McCall 68f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 69f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 70f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 71f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 72f85e193739c953358c865005855253af4f68a497John McCall 73f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 74f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 75f85e193739c953358c865005855253af4f68a497John McCall 76265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime expectedLifetime 77265941bc308d65cc270d5c4de5806f37ce405606John McCall = getImpliedARCOwnership(propertyKind, property->getType()); 78265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!expectedLifetime) { 79f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 80265941bc308d65cc270d5c4de5806f37ce405606John McCall // attribute. That's okay, but restore reasonable invariants by 81265941bc308d65cc270d5c4de5806f37ce405606John McCall // setting the property attribute according to the lifetime 82265941bc308d65cc270d5c4de5806f37ce405606John McCall // qualifier. 83265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attr; 84265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == Qualifiers::OCL_Strong) { 85265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_strong; 86265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak) { 87265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_weak; 88265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 89265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(propertyLifetime == Qualifiers::OCL_ExplicitNone); 90265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 91265941bc308d65cc270d5c4de5806f37ce405606John McCall } 92265941bc308d65cc270d5c4de5806f37ce405606John McCall property->setPropertyAttributes(attr); 93f85e193739c953358c865005855253af4f68a497John McCall return; 94f85e193739c953358c865005855253af4f68a497John McCall } 95f85e193739c953358c865005855253af4f68a497John McCall 96f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 97f85e193739c953358c865005855253af4f68a497John McCall 98f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 99f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 100b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 101f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 102265941bc308d65cc270d5c4de5806f37ce405606John McCall << expectedLifetime 103f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 104f85e193739c953358c865005855253af4f68a497John McCall} 105f85e193739c953358c865005855253af4f68a497John McCall 106dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanianstatic unsigned deduceWeakPropertyFromType(Sema &S, QualType T) { 107dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if ((S.getLangOpts().getGC() != LangOptions::NonGC && 108dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.isObjCGCWeak()) || 109dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (S.getLangOpts().ObjCAutoRefCount && 110dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.getObjCLifetime() == Qualifiers::OCL_Weak)) 111dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return ObjCDeclSpec::DQ_PR_weak; 112dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return 0; 113dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 114dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 115d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 11677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 117d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 118d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 119d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 120d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 121d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 1224a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 1234a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 12428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 125f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 126f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 127dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian Attributes |= deduceWeakPropertyFromType(*this, T); 128dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 12928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 13028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 13128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 13228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 13328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 13428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 13528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 13628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 137f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 138f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 139f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 140f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 14114086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 143a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 14428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 145ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 14677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Decl *Res = HandlePropertyInClassExtension(S, AtLoc, LParenLoc, 147ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 148ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 149ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 150dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 151ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 152ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 153f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 154cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes, false); 1554e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 156f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 157f85e193739c953358c865005855253af4f68a497John McCall } 158abd56c816e9164b17bb3e7154a511b0c9896ffdbDmitri Gribenko ActOnDocumentableDecl(Res); 159ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 160ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 161ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 16277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, LParenLoc, FD, 163f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 164f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 165dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis Attributes, 166dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 167dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis TSI, MethodImplKind); 1684a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1694a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1704a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 171842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 172cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes, 173cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (isa<ObjCInterfaceDecl>(ClassDecl) || 174cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian isa<ObjCProtocolDecl>(ClassDecl))); 175f85e193739c953358c865005855253af4f68a497John McCall 1764e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 177f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 178f85e193739c953358c865005855253af4f68a497John McCall 179abd56c816e9164b17bb3e7154a511b0c9896ffdbDmitri Gribenko ActOnDocumentableDecl(Res); 180842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 183b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidisstatic ObjCPropertyDecl::PropertyAttributeKind 184b98ffded10453d80369951f33f3892f35d747c95Argyrios KyrtzidismakePropertyAttributesAsWritten(unsigned Attributes) { 185b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 186b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 187b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 188b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 189b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 190b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_getter) 191b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 192b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_setter) 193b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 194b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_assign) 195b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 196b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_retain) 197b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 198b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_strong) 199b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 200b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_weak) 201b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 202b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_copy) 203b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 204b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 205b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 206b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 207b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 208b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 209b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 210b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 211b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis return (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten; 212b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis} 213b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 2145bf0e3522fac400cf7bf49a775554f0fc942b336Fariborz Jahanianstatic bool LocPropertyAttribute( ASTContext &Context, const char *attrName, 215edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation LParenLoc, SourceLocation &Loc) { 216edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (LParenLoc.isMacroID()) 217edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 218edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 219edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceManager &SM = Context.getSourceManager(); 220edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian std::pair<FileID, unsigned> locInfo = SM.getDecomposedLoc(LParenLoc); 221edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Try to load the file buffer. 222edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian bool invalidTemp = false; 223edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef file = SM.getBufferData(locInfo.first, &invalidTemp); 224edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (invalidTemp) 225edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 226edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian const char *tokenBegin = file.data() + locInfo.second; 227edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 228edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Lex from the start of the given location. 229edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Lexer lexer(SM.getLocForStartOfFile(locInfo.first), 230edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Context.getLangOpts(), 231edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian file.begin(), tokenBegin, file.end()); 232edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Token Tok; 233edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian do { 234edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian lexer.LexFromRawLexer(Tok); 235edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (Tok.is(tok::raw_identifier) && 236edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef(Tok.getRawIdentifierData(), Tok.getLength()) == attrName) { 237edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Loc = Tok.getLocation(); 238edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return true; 239edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 240edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } while (Tok.isNot(tok::r_paren)); 241edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 242edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 2432b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian} 2442b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 245d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanianstatic unsigned getOwnershipRule(unsigned attr) { 246dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return attr & (ObjCPropertyDecl::OBJC_PR_assign | 247dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_retain | 248dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_copy | 249dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_weak | 250dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_strong | 251dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 252dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 253dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 254d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 255a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 25677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation AtLoc, 25777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 25877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FieldDeclarator &FD, 259e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 260e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 261e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 262e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 263dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 264e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 26583a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 266e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 26758a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 268e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 269a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 270e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 2712a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 2722a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 2732a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 2742a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 2752a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 2762a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 2772a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 2782a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 2792a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 2802a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 2812a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 2822a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 2832a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 2842a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2852a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2862a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 287e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 288e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 28988f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 290e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 291e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 29277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, T); 293b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 294dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 29522f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 29622f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 29722f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 29822f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 29988f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 30088f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 30188f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 30291ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 303e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 304e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 305e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 306e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 307e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 308e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 309e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 310d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 311e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 312e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 313e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 314e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 315e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 316e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 317e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 318e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 319e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 320d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ObjCPropertyDecl *PrimaryPDecl = 32177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian CreatePropertyDecl(S, CCPrimary, AtLoc, LParenLoc, 322e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 323dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis Attributes,AttributesAsWritten, T, MethodImplKind, DC); 324e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 325e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 326e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 327e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 328d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ProcessPropertyDecl(PrimaryPDecl, CCPrimary, /* redeclaredProperty = */ 0, 329a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 330d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PrimaryPDecl->getGetterMethodDecl()); 331d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PrimaryPDecl->getSetterMethodDecl()); 332c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 333d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PrimaryPDecl, /*OrigProp=*/0, CDecl); 334d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis return PrimaryPDecl; 335e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 336e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!Context.hasSameType(PIDecl->getType(), PDecl->getType())) { 337e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian bool IncompatibleObjC = false; 338e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian QualType ConvertedType; 339ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Relax the strict type matching for property type in continuation class. 340ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Allow property object type of continuation class to be different as long 341ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // as it narrows the object type in its primary class property. Note that 342ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // this conversion is safe only because the wider type is for a 'readonly' 343ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // property in primary class and 'narrowed' type for a 'readwrite' property 344ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // in continuation class. 345e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!isa<ObjCObjectPointerType>(PIDecl->getType()) || 346e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian !isa<ObjCObjectPointerType>(PDecl->getType()) || 347e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian (!isObjCPointerConversion(PDecl->getType(), PIDecl->getType(), 348e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian ConvertedType, IncompatibleObjC)) 349e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian || IncompatibleObjC) { 350e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(AtLoc, 351e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian diag::err_type_mismatch_continuation_class) << PDecl->getType(); 352e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(PIDecl->getLocation(), diag::note_property_declare); 3536defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return 0; 354e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian } 355a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian } 356a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian 357e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 358e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 35980aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 360e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 361dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian PIkind |= deduceWeakPropertyFromType(*this, PIDecl->getType()); 362d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanian unsigned ClassExtensionMemoryModel = getOwnershipRule(Attributes); 363d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanian unsigned PrimaryClassMemoryModel = getOwnershipRule(PIkind); 364dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if (PrimaryClassMemoryModel && ClassExtensionMemoryModel && 365dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (PrimaryClassMemoryModel != ClassExtensionMemoryModel)) { 366e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 367e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 368e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 3699944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 3709944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 3719944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 372e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 373e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 374e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 375e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 376e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 377e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 378e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 379e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 380a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 381a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 3827939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 3837939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 384d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 38577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian ActOnProperty(S, AtLoc, LParenLoc, FD, ProtocolPropertyODS, 386e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 387e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 388a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 3894a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 3904a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 391d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 39228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 393e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 394e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 395e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 396f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 397f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 398e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 399e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 400e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 401e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 402788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 403788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 404788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 405788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 406788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 407788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 408788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 409788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 410788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 411788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 412e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 413e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 4146defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return 0; 415e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 416e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 417e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 4188254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 419d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PIDecl->getGetterMethodDecl()); 420d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PIDecl->getSetterMethodDecl()); 421c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 422c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PDecl, PIDecl, CDecl); 4236defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return PDecl; 424e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 425e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 426e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 427e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 428e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 42977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 430e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 431e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 432e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 433e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 434e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 435e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 436dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 43783a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 43823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 43923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 440e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 44183a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 44228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 44328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 4454e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC && 44628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 447c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 448c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 449c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 450c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 451c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 452c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 453c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 454c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 45528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 456c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 45728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 45828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 459e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 46028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 46128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 46277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, TInfo); 463e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 4649f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 4659f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 46628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 467894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 46828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 46928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 47023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 47128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 47223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 47323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 47423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 47528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 47628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 47728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 47828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 47928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 48028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 48128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 48228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 48328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 48428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 48528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 48628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 4870a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 488dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 4890a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 49028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 49128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 49228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 49328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 49428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 49528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 49628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 49728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 49828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 49928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 50028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 50128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 50228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 50328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 50428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 505f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 506f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 507f85e193739c953358c865005855253af4f68a497John McCall 508f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) 509f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 510f85e193739c953358c865005855253af4f68a497John McCall 51128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 51228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 51328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 514f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 515f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 516f85e193739c953358c865005855253af4f68a497John McCall 51728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 51828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 520265941bc308d65cc270d5c4de5806f37ce405606John McCall // In the semantic attributes, one of nonatomic or atomic is always set. 52128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 52228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 523265941bc308d65cc270d5c4de5806f37ce405606John McCall else 52445937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 52528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 526f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 527f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 528f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 529f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 530f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 531f85e193739c953358c865005855253af4f68a497John McCall 53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 537e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 53828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 540f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 541f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 542f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 543f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 544f85e193739c953358c865005855253af4f68a497John McCall 545f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 546f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 547f85e193739c953358c865005855253af4f68a497John McCall 548265941bc308d65cc270d5c4de5806f37ce405606John McCall // The lifetime implied by the property's attributes. 549265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime propertyLifetime = 550265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(property->getPropertyAttributes(), 551265941bc308d65cc270d5c4de5806f37ce405606John McCall property->getType()); 552f85e193739c953358c865005855253af4f68a497John McCall 553265941bc308d65cc270d5c4de5806f37ce405606John McCall // We're fine if they match. 554265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == ivarLifetime) return; 555f85e193739c953358c865005855253af4f68a497John McCall 556265941bc308d65cc270d5c4de5806f37ce405606John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 557265941bc308d65cc270d5c4de5806f37ce405606John McCall if (ivarLifetime == Qualifiers::OCL_None || 558265941bc308d65cc270d5c4de5806f37ce405606John McCall ivarLifetime == Qualifiers::OCL_Autoreleasing) 559265941bc308d65cc270d5c4de5806f37ce405606John McCall return; 560265941bc308d65cc270d5c4de5806f37ce405606John McCall 561d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // If the ivar is private, and it's implicitly __unsafe_unretained 562d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // becaues of its type, then pretend it was actually implicitly 563d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // __strong. This is only sound because we're processing the 564d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // property implementation before parsing any method bodies. 565d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (ivarLifetime == Qualifiers::OCL_ExplicitNone && 566d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall propertyLifetime == Qualifiers::OCL_Strong && 567d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->getAccessControl() == ObjCIvarDecl::Private) { 568d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall SplitQualType split = ivarType.split(); 569d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (split.Quals.hasObjCLifetime()) { 570d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall assert(ivarType->isObjCARCImplicitlyUnretainedType()); 571d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall split.Quals.setObjCLifetime(Qualifiers::OCL_Strong); 572d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivarType = S.Context.getQualifiedType(split); 573d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->setType(ivarType); 574d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return; 575d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 576d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 577d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall 578265941bc308d65cc270d5c4de5806f37ce405606John McCall switch (propertyLifetime) { 579265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Strong: 580265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_strong_property_ownership) 581265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 582265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 583265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivarLifetime; 584265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 585265941bc308d65cc270d5c4de5806f37ce405606John McCall 586265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Weak: 587265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::error_weak_property) 588265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 589265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName(); 590265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 591265941bc308d65cc270d5c4de5806f37ce405606John McCall 592265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_ExplicitNone: 593265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_assign_property_ownership) 594265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 595265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 596265941bc308d65cc270d5c4de5806f37ce405606John McCall << ((property->getPropertyAttributesAsWritten() 597265941bc308d65cc270d5c4de5806f37ce405606John McCall & ObjCPropertyDecl::OBJC_PR_assign) != 0); 598265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 599265941bc308d65cc270d5c4de5806f37ce405606John McCall 600265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Autoreleasing: 601265941bc308d65cc270d5c4de5806f37ce405606John McCall llvm_unreachable("properties cannot be autoreleasing"); 602265941bc308d65cc270d5c4de5806f37ce405606John McCall 603265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_None: 604265941bc308d65cc270d5c4de5806f37ce405606John McCall // Any other property should be ignored. 605f85e193739c953358c865005855253af4f68a497John McCall return; 606f85e193739c953358c865005855253af4f68a497John McCall } 607f85e193739c953358c865005855253af4f68a497John McCall 608f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 609f85e193739c953358c865005855253af4f68a497John McCall} 610f85e193739c953358c865005855253af4f68a497John McCall 611015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// setImpliedPropertyAttributeForReadOnlyProperty - 612015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// This routine evaludates life-time attributes for a 'readonly' 613015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// property with no known lifetime of its own, using backing 614015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// 'ivar's attribute, if any. If no backing 'ivar', property's 615015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// life-time is assumed 'strong'. 616015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanianstatic void setImpliedPropertyAttributeForReadOnlyProperty( 617015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl *property, ObjCIvarDecl *ivar) { 618015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime propertyLifetime = 619015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian getImpliedARCOwnership(property->getPropertyAttributes(), 620015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->getType()); 621015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (propertyLifetime != Qualifiers::OCL_None) 622015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 623015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 624015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (!ivar) { 625015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // if no backing ivar, make property 'strong'. 626015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 627015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 628015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 629015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // property assumes owenership of backing ivar. 630015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian QualType ivarType = ivar->getType(); 631015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 632015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (ivarLifetime == Qualifiers::OCL_Strong) 633015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 634015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian else if (ivarLifetime == Qualifiers::OCL_Weak) 635015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 636015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 637015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian} 63828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 639cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// DiagnoseClassAndClassExtPropertyMismatch - diagnose inconsistant property 640cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// attribute declared in primary class and attributes overridden in any of its 641cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// class extensions. 642cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanianstatic void 643cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz JahanianDiagnoseClassAndClassExtPropertyMismatch(Sema &S, ObjCInterfaceDecl *ClassDecl, 644cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *property) { 645cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned Attributes = property->getPropertyAttributesAsWritten(); 646cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian bool warn = (Attributes & ObjCDeclSpec::DQ_PR_readonly); 647cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian for (const ObjCCategoryDecl *CDecl = ClassDecl->getFirstClassExtension(); 648cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian CDecl; CDecl = CDecl->getNextClassExtension()) { 649cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *ClassExtProperty = 0; 650cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = CDecl->prop_begin(), 651cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian E = CDecl->prop_end(); P != E; ++P) { 652cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if ((*P)->getIdentifier() == property->getIdentifier()) { 653cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ClassExtProperty = *P; 654cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 655cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 656cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 657cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (ClassExtProperty) { 658c78ff27813288b30ee566477705353ae660fd577Fariborz Jahanian warn = false; 659cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned classExtPropertyAttr = 660cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ClassExtProperty->getPropertyAttributesAsWritten(); 661cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // We are issuing the warning that we postponed because class extensions 662cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // can override readonly->readwrite and 'setter' attributes originally 663cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // placed on class's property declaration now make sense in the overridden 664cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // property. 665cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) { 666cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (!classExtPropertyAttr || 667a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (classExtPropertyAttr & 668a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (ObjCDeclSpec::DQ_PR_readwrite| 669a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_assign | 670a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 671a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 672a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 673a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_strong))) 674cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian continue; 675cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian warn = true; 676cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 677cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 678cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 679cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 680cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (warn) { 681cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned setterAttrs = (ObjCDeclSpec::DQ_PR_assign | 682cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 683cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 684cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 685cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong); 686cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (Attributes & setterAttrs) { 687cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian const char * which = 688cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 689cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "assign" : 690cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 691cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "unsafe_unretained" : 692cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 693cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "copy" : 694cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_retain) ? 695cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "retain" : "strong"; 696cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 697cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian S.Diag(property->getLocation(), 698cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian diag::warn_objc_property_attr_mutually_exclusive) 699cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << which; 700cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 701cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 702cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 703cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 704cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian} 705cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 70628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 70728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 708699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// as \@synthesize or \@dynamic. 70928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 710d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 711d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 712d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 713d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 714d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 715a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 716a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 717e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 71884e0ccff7a6e51d7b81fd58686b493a4880dd44dFariborz Jahanian dyn_cast<ObjCContainerDecl>(CurContext); 71928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 72028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 72128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 722d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 72328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 724f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis if (PropertyIvarLoc.isInvalid()) 725f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc = PropertyLoc; 726e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman SourceLocation PropertyDiagLoc = PropertyLoc; 727e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (PropertyDiagLoc.isInvalid()) 728e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PropertyDiagLoc = ClassImpDecl->getLocStart(); 72928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 73028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 73128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 73228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 73328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 73428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 73528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 73628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 73728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 73828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 73928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 74028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 74128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 74228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 74328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 74428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 74528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 746d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 74728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 748dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 74945937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 75045937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 751dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 752dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 753dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 754dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 755dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 756dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 757dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 75828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 75928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 76028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 76128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 76228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 763d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 76428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 76528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 7662b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 7672b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian if (Synthesize&& 7682b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian (PIkind & ObjCPropertyDecl::OBJC_PR_readonly) && 7692b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian property->hasAttr<IBOutletAttr>() && 7702b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian !AtLoc.isValid()) { 7712b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_readonly_iboutlet_property); 7722b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 773edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation readonlyLoc; 7745bf0e3522fac400cf7bf49a775554f0fc942b336Fariborz Jahanian if (LocPropertyAttribute(Context, "readonly", 775edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian property->getLParenLoc(), readonlyLoc)) { 776edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation endLoc = 777edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian readonlyLoc.getLocWithOffset(strlen("readonly")-1); 778edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceRange ReadonlySourceRange(readonlyLoc, endLoc); 779edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Diag(property->getLocation(), 780edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian diag::note_auto_readonly_iboutlet_fixup_suggest) << 781edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian FixItHint::CreateReplacement(ReadonlySourceRange, "readwrite"); 782edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 7832b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian } 784cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 785cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian DiagnoseClassAndClassExtPropertyMismatch(*this, IDecl, property); 7862b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 78728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 78828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 78928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 790d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 79128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 79228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 79328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 79428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 795d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 79628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 79728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 79828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 79928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 80028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 80128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 80228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 803d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 80428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 80528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 80628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 80728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 80828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 809d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 81028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 81128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 81228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 813d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 81428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 81528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 816e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman bool CompleteTypeErr = false; 817744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian bool compat = true; 81828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 81928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 82028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 82128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 82228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 823015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // Check that this is a previously declared 'ivar' in 'IDecl' interface 824015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared; 825015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 826265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropType = property->getType(); 827265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropertyIvarType = PropType.getNonReferenceType(); 828e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 829e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (RequireCompleteType(PropertyDiagLoc, PropertyIvarType, 830d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_incomplete_synthesized_property, 831d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor property->getDeclName())) { 832e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(property->getLocation(), diag::note_property_declare); 833e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman CompleteTypeErr = true; 834e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman } 835e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 8364e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 837015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian (property->getPropertyAttributesAsWritten() & 8383efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_readonly) && 8393efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian PropertyIvarType->isObjCRetainableType()) { 840015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian setImpliedPropertyAttributeForReadOnlyProperty(property, Ivar); 841015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 842015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 843015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl::PropertyAttributeKind kind 844015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian = property->getPropertyAttributes(); 845265941bc308d65cc270d5c4de5806f37ce405606John McCall 846265941bc308d65cc270d5c4de5806f37ce405606John McCall // Add GC __weak to the ivar type if the property is weak. 847265941bc308d65cc270d5c4de5806f37ce405606John McCall if ((kind & ObjCPropertyDecl::OBJC_PR_weak) && 8484e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 8494e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie assert(!getLangOpts().ObjCAutoRefCount); 850265941bc308d65cc270d5c4de5806f37ce405606John McCall if (PropertyIvarType.isObjCGCStrong()) { 851e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_gc_weak_property_strong_type); 852265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(property->getLocation(), diag::note_property_declare); 853265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 854265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType = 855265941bc308d65cc270d5c4de5806f37ce405606John McCall Context.getObjCGCQualType(PropertyIvarType, Qualifiers::Weak); 856edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 857edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 858e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (AtLoc.isInvalid()) { 859e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // Check when default synthesizing a property that there is 860e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // an ivar matching property name and issue warning; since this 861e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // is the most common case of not using an ivar used for backing 862e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // property in non-default synthesis case. 863e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 864e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCIvarDecl *originalIvar = 865e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian IDecl->lookupInstanceVariable(property->getIdentifier(), 866e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ClassDeclared); 867e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (originalIvar) { 868e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(PropertyDiagLoc, 869e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian diag::warn_autosynthesis_property_ivar_match) 8702578532c7323efdd68ec42a31b7bdf72e5218867Fariborz Jahanian << PropertyId << (Ivar == 0) << PropertyIvar 87120e7d992140cc6bc94f2e65f3638346527150756Fariborz Jahanian << originalIvar->getIdentifier(); 872e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 873e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(originalIvar->getLocation(), diag::note_ivar_decl); 874dd3284b17829adfd542ecf4a7b4423dce1d7502bFariborz Jahanian } 875e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian } 876e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian 877e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (!Ivar) { 878265941bc308d65cc270d5c4de5806f37ce405606John McCall // In ARC, give the ivar a lifetime qualifier based on the 879f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 8804e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 881265941bc308d65cc270d5c4de5806f37ce405606John McCall !PropertyIvarType.getObjCLifetime() && 882265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType->isObjCRetainableType()) { 883f85e193739c953358c865005855253af4f68a497John McCall 884265941bc308d65cc270d5c4de5806f37ce405606John McCall // It's an error if we have to do this and the user didn't 885265941bc308d65cc270d5c4de5806f37ce405606John McCall // explicitly write an ownership attribute on the property. 886473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 887265941bc308d65cc270d5c4de5806f37ce405606John McCall !(kind & ObjCPropertyDecl::OBJC_PR_strong)) { 888e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, 889473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 890473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 891265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 892265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime lifetime = 893265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(kind, PropertyIvarType); 894265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(lifetime && "no lifetime for property?"); 8956dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (lifetime == Qualifiers::OCL_Weak) { 8966dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian bool err = false; 8976dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (const ObjCObjectPointerType *ObjT = 898a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith PropertyIvarType->getAs<ObjCObjectPointerType>()) { 899a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith const ObjCInterfaceDecl *ObjI = ObjT->getInterfaceDecl(); 900a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith if (ObjI && ObjI->isArcWeakrefUnavailable()) { 901e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_arc_weak_unavailable_property); 9026dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 9036dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian err = true; 9046dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 905a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith } 9060a7dd788dbef975f35f273c7ab913f480f7edd60John McCall if (!err && !getLangOpts().ObjCARCWeak) { 907e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_arc_weak_no_runtime); 9086dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 9096dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 910f85e193739c953358c865005855253af4f68a497John McCall } 9116dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian 912f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 913265941bc308d65cc270d5c4de5806f37ce405606John McCall qs.addObjCLifetime(lifetime); 914f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 915f85e193739c953358c865005855253af4f68a497John McCall } 916f85e193739c953358c865005855253af4f68a497John McCall } 917f85e193739c953358c865005855253af4f68a497John McCall 918f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 9194e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().ObjCAutoRefCount && 9204e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() == LangOptions::NonGC) { 921e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_synthesize_weak_non_arc_or_gc); 922f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 923f85e193739c953358c865005855253af4f68a497John McCall } 924f85e193739c953358c865005855253af4f68a497John McCall 925ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 926f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc,PropertyIvarLoc, PropertyIvar, 92714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 9287504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 929ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 930e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (CompleteTypeErr) 931e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->setInvalidDecl(); 93229fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 9331b7f9cbed1b96b58a6e5f7808ebc9345a76a0936Richard Smith IDecl->makeDeclVisibleInContext(Ivar); 93428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 935260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (getLangOpts().ObjCRuntime.isFragile()) 936e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_missing_property_ivar_decl) 937e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman << PropertyId; 93828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 93928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 940260611a32535c851237926bfcf78869b13c07d5bJohn McCall } else if (getLangOpts().ObjCRuntime.isNonFragile() && 94160ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor !declaresSameEntity(ClassDeclared, IDecl)) { 942e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_ivar_in_superclass_use) 94328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 94428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 94528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 9464087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 94728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 94828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 9495bf5c2ec54ede5352293e5739e9b44bea2f6b01bAnna Zaks property->setPropertyIvarDecl(Ivar); 9505bf5c2ec54ede5352293e5739e9b44bea2f6b01bAnna Zaks 95128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 95228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 95328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 954744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (!Context.hasSameType(PropertyIvarType, IvarType)) { 95514086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 956f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 957b3cd3c0c8a234803dcb9b9c0dfe10106674141cdRichard Smith compat = 95862ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 95914086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 96062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 961b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 962f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis compat = (CheckAssignmentConstraints(PropertyIvarLoc, PropertyIvarType, 963f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis IvarType) 964daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 965b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 96662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 967e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_ivar_type) 968f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 969f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 970f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 97128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 97228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 97328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 974744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian else { 975744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // FIXME! Rules for properties are somewhat different that those 976744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // for assignments. Use a new routine to consolidate all cases; 977744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // specifically for property redeclarations as well as for ivars. 978744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 979744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 980744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (lhsType != rhsType && 981744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian lhsType->isArithmeticType()) { 982744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(PropertyDiagLoc, diag::error_property_ivar_type) 983744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << property->getDeclName() << PropType 984744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << Ivar->getDeclName() << IvarType; 985744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 986744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // Fall thru - see previous comment 987744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian } 98828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 98928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 990f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 9914e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC)) { 992e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_weak_property) 99328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 994edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 99528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 99628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 997f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 99828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 99928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 10004e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 1001e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_strong_property) 100228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 100328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 100428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 100528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 10064e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1007f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 100828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 100928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 1010e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_dynamic_property_ivar_decl); 1011f85e193739c953358c865005855253af4f68a497John McCall 101228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 101328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 101428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 101528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 101628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 101728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 101828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 1019a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 1020e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 1021744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (CompleteTypeErr || !compat) 1022e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PIDecl->setInvalidDecl(); 1023e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 102417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 102517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 1026e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 10270313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 102817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 102917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 103017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 103117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 103217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1033f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 1034f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 103517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 103617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 103717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 103860d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 103917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 10403c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 10413c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 10423c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 104317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 104417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 104517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 104617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 104717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 10484765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 104917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 105017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 105117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 1052831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 1053831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 1054831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 1055831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 1056831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 1057831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 105817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 105917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 106017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 1061e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 1062e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->getType()->isRecordType()) { 106317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 106417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 106517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1066f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 1067f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 106817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 106917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 107017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 107117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 107217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 10733c3b7f90a863af43fa63043d396553ecf205351cJohn McCall QualType T = Param->getType().getNonReferenceType(); 1074f4b88a45902af1802a1cb42ba48b1c474474f228John McCall Expr *rhs = new (Context) DeclRefExpr(Param, false, T, 1075f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 1076fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 10772de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 107857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (property->getPropertyAttributes() & 107957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_atomic) { 108057e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Expr *callExpr = Res.takeAs<Expr>(); 108157e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (const CXXOperatorCallExpr *CXXCE = 108213bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian dyn_cast_or_null<CXXOperatorCallExpr>(callExpr)) 108313bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian if (const FunctionDecl *FuncDecl = CXXCE->getDirectCallee()) 108457e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (!FuncDecl->isTrivial()) 108520abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian if (property->getType()->isReferenceType()) { 108620abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian Diag(PropertyLoc, 108720abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::err_atomic_property_nontrivial_assign_op) 108857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian << property->getType(); 108920abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian Diag(FuncDecl->getLocStart(), 109020abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::note_callee_decl) << FuncDecl; 109120abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian } 109257e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian } 109317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 109417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 109517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 109617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 109728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 109828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 109928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 110028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 110128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 110228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 110328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 110428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 110528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 110628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 110728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 110828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 110928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 111028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1111d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 111228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 111328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 11144e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCDefaultSynthProperties && 1115260611a32535c851237926bfcf78869b13c07d5bJohn McCall getLangOpts().ObjCRuntime.isNonFragile() && 111671207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek !IDecl->isObjCRequiresPropertyDefs()) { 1117ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 1118ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 1119cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 1120411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 1121ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 1122ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 1123ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1124ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 1125ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 1126ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1127ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1128cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 1129cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 113060ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor declaresSameEntity(IC->getClassInterface(), ClassDeclared)) { 1131ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 1132ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 1133ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 1134ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1135ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 113628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 113728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 113828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 113928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 1140e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_duplicate_ivar_use) 114128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 114228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 114328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 114428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 114528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 114628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 114728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 1148e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_implemented) << PropertyId; 114928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1150d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 115128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 115228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 115328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 115428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 1155d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 115628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 115728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 115828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 115928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 116028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 116128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 11639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 11649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 11659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 11669d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 11679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 11689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 11699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 11709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 11719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 11729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 11739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 11749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 11759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 11769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 11779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 11789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 11799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 11809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 11811b46d8d78be713c546fb9680eaeea8f793bee5bfFariborz Jahanian else if (!(SAttr & ObjCPropertyDecl::OBJC_PR_readonly)){ 1182f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 1183f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 1184f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1185f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 1186f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 1187f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1188f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 1189f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 1190f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 1191f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 1192f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 1193f85e193739c953358c865005855253af4f68a497John McCall } 11949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 11969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 11979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 11989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 11999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 12009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 12019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 12029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 12039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 12049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 12059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 12079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 12089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 12099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 12109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1211c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 12128beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 12138beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 12148beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 12158beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 12168beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 12178beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 121813546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian IncompatibleObjC) { 12198beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 12208beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 122113546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 122213546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian } 12239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 12279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 12289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 12299abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!GetterMethod) 12309abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return false; 12319abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType GetterType = GetterMethod->getResultType().getNonReferenceType(); 12329abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType PropertyIvarType = property->getType().getNonReferenceType(); 12339abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian bool compat = Context.hasSameType(PropertyIvarType, GetterType); 12349abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 12359abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) && 12369abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian isa<ObjCObjectPointerType>(GetterType)) 12379abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = 12389abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Context.canAssignObjCInterfaces( 1239490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian GetterType->getAs<ObjCObjectPointerType>(), 1240490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>()); 1241490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian else if (CheckAssignmentConstraints(Loc, GetterType, PropertyIvarType) 12429abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian != Compatible) { 12439abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::error_property_accessor_type) 12449abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() << PropertyIvarType 12459abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector() << GetterType; 12469abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 12479abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 12489abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } else { 12499abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = true; 12509abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 12519abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType rhsType =Context.getCanonicalType(GetterType).getUnqualifiedType(); 12529abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (lhsType != rhsType && lhsType->isArithmeticType()) 12539abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = false; 12549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12569abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 12579abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 12589abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::warn_accessor_property_type_mismatch) 12599abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() 12609abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector(); 12619abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 12629abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 12639abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } 12649abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 12659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 12669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 12699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 1270fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 12719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 12729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 12739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 12749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 12759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 12769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 12779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 12789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 1279581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *SuperPDecl = *S; 12809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 12819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 12829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 1283581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *PDecl = *I; 12849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 12859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 12869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 12879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 12929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 12939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 12949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 12959d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 12969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 12979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 12989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 12999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 13009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 13019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 13029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 13039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 13049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1305581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Pr = *P; 13069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 13079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 13082d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 1309262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie if (CP->getIdentifier() == Pr->getIdentifier()) 13109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 13119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 13129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 1313581deb3da481053c4993c7600f97acf7768caac5David Blaikie DiagnosePropertyMismatch(*CP, Pr, PDecl->getIdentifier()); 13149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 13189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1319581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Pr = *P; 13209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 13219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 13229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 1323262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie if (CP->getIdentifier() == Pr->getIdentifier()) 13249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 13259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 13269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 1327581deb3da481053c4993c7600f97acf7768caac5David Blaikie DiagnosePropertyMismatch(*CP, Pr, PDecl->getIdentifier()); 13289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 13329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 13339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 13349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 1335d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 1336d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 13379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 13389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 13409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 13419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 13429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 13439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 13449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 13459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 13469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 13479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 13489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 13509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 1353d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 13549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 136453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 136553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 136653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 13679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 13689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 13699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 13719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 137253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 137353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 137453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1375d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 13769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 13779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 13789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 13799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 13809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 13819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 13859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 13869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 13879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 13889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 13899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 13909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 13919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 13939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 13949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 13959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 13969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 13989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 13999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 14009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 14019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 14029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 14039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 14049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 14059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 14079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 14089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 14099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 14139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 14149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 14159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 14169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 14179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 14189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 14209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 14219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 14229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 14269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 14279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 14289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 14309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 14319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 14329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 14339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 14369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 14379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1438cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 1439cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 14409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 14419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 14429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 1443581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 14449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 14459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 144753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 144853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 144953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1450cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 14539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 14549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 14559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 1456581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 14579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 14589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 146053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 14619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1462cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 14659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 14669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1467581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1468cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1469cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1470cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1471a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian if (!PropertyFromSuper || 1472a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian PropertyFromSuper->getIdentifier() != Prop->getIdentifier()) { 1473cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1474cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1475cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1476cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 14779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 14799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 14809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1481cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1485509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 1486509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 1487509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 1488509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 1489509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1490509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1491509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1492509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 1493581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1494509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1495509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 149653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 149753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 149853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1499509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1500509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1501509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1502509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1503509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 1504581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1505d48bcb2f4dedf8e7b654cb017968b3d7b6663a57Benjamin Kramer // Insert into PropMap if not there already. 1506d48bcb2f4dedf8e7b654cb017968b3d7b6663a57Benjamin Kramer PropMap.insert(std::make_pair(Prop->getIdentifier(), Prop)); 1507509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1508509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 1509509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1510509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 1511509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1512509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1513509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1514509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1515509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1516509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1517509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1518509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1519509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1520509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1521509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1522509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 1523509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1524509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1525509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1526509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1527509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 15289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 15299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 15309d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 15319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 15329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 15339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 15349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 15359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 1536581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 15379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 15389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 15399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 154153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 154253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 154353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 15449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 15459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 15469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 15479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 15509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 15519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 15529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1553581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 15549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 15559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 15569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 15589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 15599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 15609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 15619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 15629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 15639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 1565fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian else if (const ObjCCategoryDecl *CatDecl = 1566fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian dyn_cast<ObjCCategoryDecl>(CDecl)) { 1567fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = CatDecl->prop_begin(), 1568fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian E = CatDecl->prop_end(); P != E; ++P) { 1569fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian ObjCPropertyDecl *Prop = *P; 1570fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian if (Prop->getIdentifier() == II) 1571fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian return Prop; 1572fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian } 1573fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian } 1574fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian return 0; 1575fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian} 1576fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian 1577fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian/// PropertyIfSetterOrGetter - Looks up the property if named declaration 1578fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian/// is a setter or getter method backing a property. 1579fd09088880f758c874edc8d3d22fa922baec0483Fariborz JahanianObjCPropertyDecl *Sema::PropertyIfSetterOrGetter(NamedDecl *D) { 1580fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian if (const ObjCMethodDecl *Method = dyn_cast<ObjCMethodDecl>(D)) { 1581fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian Selector Sel = Method->getSelector(); 1582fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian IdentifierInfo *Id = 0; 1583fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian if (Sel.getNumArgs() == 0) 1584fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian Id = Sel.getIdentifierInfoForSlot(0); 1585fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian else if (Sel.getNumArgs() == 1) { 1586fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian StringRef str = Sel.getNameForSlot(0); 1587fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian if (str.startswith("set")) { 1588fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian str = str.substr(3); 1589fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian char front = str.front(); 1590fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian front = islower(front) ? toupper(front) : tolower(front); 1591fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian SmallString<100> PropertyName = str; 1592fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian PropertyName[0] = front; 1593fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian Id = &PP.getIdentifierTable().get(PropertyName); 1594fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian } 1595fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian } 1596fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian if (Id) { 1597fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian if (isa<ObjCInterfaceDecl>(Method->getDeclContext())) { 1598fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian const ObjCInterfaceDecl *IDecl = Method->getClassInterface(); 1599fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian while (IDecl) { 1600fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian ObjCPropertyDecl *PDecl = 1601fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian LookupPropertyDecl(cast<ObjCContainerDecl>(IDecl), Id); 1602fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian if (PDecl) 1603fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian return PDecl; 1604fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 1605fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian Category; Category = Category->getNextClassCategory()) 1606fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian if ((PDecl = 1607fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian LookupPropertyDecl(cast<ObjCContainerDecl>(Category), Id))) 1608fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian return PDecl; 1609fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian IDecl = IDecl->getSuperClass(); 1610fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian } 1611fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian } else if (ObjCPropertyDecl *PDecl = 1612fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian LookupPropertyDecl( 1613fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian cast<ObjCContainerDecl>(Method->getDeclContext()), Id)) 1614fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian return PDecl; 1615fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian } 1616fd09088880f758c874edc8d3d22fa922baec0483Fariborz Jahanian } 16179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 16189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 16199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1620d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekstatic IdentifierInfo * getDefaultSynthIvarName(ObjCPropertyDecl *Prop, 1621d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ASTContext &Ctx) { 1622f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> ivarName; 1623d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek { 1624d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek llvm::raw_svector_ostream os(ivarName); 1625d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek os << '_' << Prop->getIdentifier()->getName(); 1626d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek } 1627d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek return &Ctx.Idents.get(ivarName.str()); 1628d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek} 1629d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek 1630699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// \brief Default synthesizes all properties which must be synthesized 1631699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// in class's \@implementation. 1632d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekvoid Sema::DefaultSynthesizeProperties(Scope *S, ObjCImplDecl* IMPDecl, 1633d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ObjCInterfaceDecl *IDecl) { 1634509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1635509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1636509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 1637509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1638509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1639509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1640509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1641509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1642509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1643509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1644509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1645509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1646509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1647509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1648509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1649509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1650509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1651509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1652509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1653d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1654d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1655d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 165695f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 165795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 165895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 165995f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 166095f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 166195f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1662f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian if (isa<ObjCProtocolDecl>(Prop->getDeclContext())) { 1663f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian // We won't auto-synthesize properties declared in protocols. 1664f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(IMPDecl->getLocation(), 1665f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian diag::warn_auto_synthesizing_protocol_property); 1666f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(Prop->getLocation(), diag::note_property_declare); 1667f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian continue; 1668f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian } 16692a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 16702a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 16712a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 16722a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 16732a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 1674975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ObjCPropertyImplDecl *PIDecl = dyn_cast_or_null<ObjCPropertyImplDecl>( 1675975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1676975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian true, 1677975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian /* property = */ Prop->getIdentifier(), 1678975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian /* ivar = */ getDefaultSynthIvarName(Prop, Context), 1679390fff8e8b480fa146ffc14cbc63a1c2f9e2d206Argyrios Kyrtzidis Prop->getLocation())); 1680975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian if (PIDecl) { 1681975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian Diag(Prop->getLocation(), diag::warn_missing_explicit_synthesis); 16825ea66619a3108e2985e952b9a60a84316d464b25Fariborz Jahanian Diag(IMPDecl->getLocation(), diag::note_while_in_implementation); 1683975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian } 16842a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1685509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 16869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16878697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 1688260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (!LangOpts.ObjCDefaultSynthProperties || LangOpts.ObjCRuntime.isFragile()) 16898697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 16908697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 16918697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 16928697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 16938697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 169471207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (!IDecl->isObjCRequiresPropertyDefs()) 1695eb4f2c56c298071d58b441ccf801b039be93788aFariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 16968697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 16978697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 169817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 16999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 1700811bfcd823d51db6a06b3fd5a5943ff910b79d68Benjamin Kramer const SelectorSet &InsMap) { 1701cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1702cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1703cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1704cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 17059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1706cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 17079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 17089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 17099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 17119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 17129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 17139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 1714262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie PropImplMap.insert(I->getPropertyDecl()); 17159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 17179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 17189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 17199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 17209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 17219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1722327126ee3d2faad9314b2633974eefc672f73b79Fariborz Jahanian PropImplMap.count(Prop) || Prop->hasAttr<UnavailableAttr>()) 17239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 17249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 1725b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 17269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 17279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 17289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 17299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1730b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1731b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1732260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1733da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 173471207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1735da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 1736da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian 17379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1740b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 17419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 17429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 17439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 17449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1745b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1746b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1747260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1748da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 174971207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1750da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 17519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 17549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 17569d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 17579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 17589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 17594e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC) 17609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 17619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 17629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 17639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 1764581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Property = *I; 176594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 176694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 176794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 176894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 17699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 1770265941bc308d65cc270d5c4de5806f37ce405606John McCall unsigned AttributesAsWritten = Property->getPropertyAttributesAsWritten(); 177194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1772265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic) && 1773265941bc308d65cc270d5c4de5806f37ce405606John McCall !(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 177494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 177594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 177694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 177794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 177894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 177994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1780293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 178194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 178294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 178394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 178494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 178594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1786293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 178794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 178894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 178994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 179094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 17919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 17929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 17939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 17949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 17959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 17969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 17979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 17989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 179994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 180094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 180194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 180294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 180394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 18049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 18059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 18069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 18079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 18089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 18097d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << Property->getIdentifier() << (GetterMethod != 0) 18107d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << (SetterMethod != 0); 181177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // fixit stuff. 181277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (!AttributesAsWritten) { 181377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (Property->getLParenLoc().isValid()) { 181477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 181577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), 181677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getLParenLoc()); 181777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 181877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic"); 181977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 182077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else { 182177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian //@property id etc. 182277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = 182377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getTypeSourceInfo()->getTypeLoc().getBeginLoc(); 182477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian endLoc = endLoc.getLocWithOffset(-1); 182577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 182677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 182777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic) "); 182877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 182977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 183077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic)) { 183177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 183277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = Property->getLParenLoc(); 183377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 183477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 183577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic, "); 183677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 183777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else 183877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(MethodLoc, diag::note_atomic_property_fixup_suggest); 18399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 18409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 18449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1845f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 18464e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::GCOnly) 1847f85e193739c953358c865005855253af4f68a497John McCall return; 1848f85e193739c953358c865005855253af4f68a497John McCall 1849f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1850f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1851581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyImplDecl *PID = *i; 1852f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1853f85e193739c953358c865005855253af4f68a497John McCall continue; 1854f85e193739c953358c865005855253af4f68a497John McCall 1855f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1856831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1857831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1858f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1859f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1860f85e193739c953358c865005855253af4f68a497John McCall continue; 1861f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1862f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1863f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 18644e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1865f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1866f85e193739c953358c865005855253af4f68a497John McCall else 1867920c9c1155c118ac40e5209d4b757b9f54186339Ted Kremenek Diag(PID->getLocation(), diag::warn_owning_getter_rule); 1868f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1869f85e193739c953358c865005855253af4f68a497John McCall } 1870f85e193739c953358c865005855253af4f68a497John McCall } 1871f85e193739c953358c865005855253af4f68a497John McCall } 1872f85e193739c953358c865005855253af4f68a497John McCall} 1873f85e193739c953358c865005855253af4f68a497John McCall 18745de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 18755de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 18765de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 18775de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 18785de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 18790a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 18800a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 18810a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 18820a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 18830a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 18840a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 18850a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 18860a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 18875de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 18885de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 18899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 18909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 18919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 18929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 18939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 18949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 18958254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 18968254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 18978254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 18988254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 18999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 19009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 19029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 19039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 19049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 19059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 19079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 19089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 19099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 19109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 19119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 19129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 19139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 19142aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian !Context.hasSameUnqualifiedType( 1915bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian (*SetterMethod->param_begin())->getType().getNonReferenceType(), 1916bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian property->getType().getNonReferenceType())) { 19179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 19189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 19199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 19209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 19219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 19229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 19239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 19249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 19269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 19279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 19289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 19299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 19309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 19319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 19329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 19339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 19349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1935a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1936a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1937a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1938a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1939a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1940a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 194175cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 194275cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isVariadic=*/false, /*isSynthesized=*/true, 194375cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 19449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 19459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 19469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 19479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 19489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 19495de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 19505de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 19515de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 195223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 195323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1954a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 195523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1956831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1957831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1958831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 19599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 19609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 19619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 19629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 19639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 19649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 19669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 19679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 19689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 19699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 19709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 19719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 19728254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 19738254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 19748254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 19758254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 19768254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 1977491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ObjCMethodDecl::Create(Context, Loc, Loc, 19788254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 197975cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 198075cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isSynthesized=*/true, 198175cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 198275cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 19839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 19849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 19858254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 19868254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 19878254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 19889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 19899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1990ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1991ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 19929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1993f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 19949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1995d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1996d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 19979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 1998491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis SetterMethod->setMethodParams(Context, Argument, 1999491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ArrayRef<SourceLocation>()); 20005de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 20015de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 20025de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 20039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 200423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 200523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 20068254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 200723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 20089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 20099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 20109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 20119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 20129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 20139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 20149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 20159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 20169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 20189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 20199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 20209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 20229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 20239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 20249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 20259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 20279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 20289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 20299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 2030e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis 2031e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(CD); 2032e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (!CurrentClass) { 2033e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(CD)) 2034e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Cat->getClassInterface(); 2035e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(CD)) 2036e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Impl->getClassInterface(); 2037e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis } 2038e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (GetterMethod) 2039e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(GetterMethod, CurrentClass, Sema::RTC_Unknown); 2040e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (SetterMethod) 2041e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(SetterMethod, CurrentClass, Sema::RTC_Unknown); 20429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 20439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2044d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 20459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 2046cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned &Attributes, 2047cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian bool propertyInPrimaryClass) { 20489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 2049f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 20505fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 20515fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 20525fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 2053842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 20549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 20554e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2056015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2057015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian PropertyTy->isObjCRetainableType()) { 2058015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // 'readonly' property with no obvious lifetime. 2059015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // its life time will be determined by its backing ivar. 2060015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian unsigned rel = (ObjCDeclSpec::DQ_PR_unsafe_unretained | 2061015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 2062015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 2063015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong | 2064015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_weak | 2065015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_assign); 2066015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if ((Attributes & rel) == 0) 2067015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 2068015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 2069015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 2070cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (propertyInPrimaryClass) { 2071cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // we postpone most property diagnosis until class's implementation 2072cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // because, its readonly attribute may be overridden in its class 2073cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // extensions making other attributes, which make no sense, to make sense. 2074cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2075cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_readwrite)) 2076cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2077cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << "readwrite"; 2078cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 20799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 2080cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian else if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2081cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 208228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 2083f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 208428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 2085f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 2086f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 208728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 208828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 208928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 209028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 2091f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 2092f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 209328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 209428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 20959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 209628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 209728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 209828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 209928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 210028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 210228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 2103f85e193739c953358c865005855253af4f68a497John McCall if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2104f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 2105f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 2106842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 210728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 2108f85e193739c953358c865005855253af4f68a497John McCall << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 2109f85e193739c953358c865005855253af4f68a497John McCall Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 2110f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2111f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 2112977ea7864a50eee39f6bef8a5a79154ac9ba4b3eJohn McCall PropertyDecl->setInvalidDecl(); 211328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 211528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 211628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 211728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 211828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 211928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 212028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 212128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 212228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 212328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 212428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 212528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 212628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2127f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2128f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2129f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 2130f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2131f85e193739c953358c865005855253af4f68a497John McCall } 21324e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2133f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2134f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2135f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 2136f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2137f85e193739c953358c865005855253af4f68a497John McCall } 2138f85e193739c953358c865005855253af4f68a497John McCall } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 2139f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2140f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2141f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 2142f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 2143f85e193739c953358c865005855253af4f68a497John McCall } 2144f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 2145f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2146f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 2147f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2148f85e193739c953358c865005855253af4f68a497John McCall } 2149f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2150f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2151f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 2152f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2153f85e193739c953358c865005855253af4f68a497John McCall } 21544e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2155f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2156f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2157f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 2158f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2159f85e193739c953358c865005855253af4f68a497John McCall } 216028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 216128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 216228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 216328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 216428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 216528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2166f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2167f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2168f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 2169f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2170f85e193739c953358c865005855253af4f68a497John McCall } 2171f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 2172f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2173f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 2174f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2175f85e193739c953358c865005855253af4f68a497John McCall } 2176f85e193739c953358c865005855253af4f68a497John McCall } 2177f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2178f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2179f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2180f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 2181528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2182f85e193739c953358c865005855253af4f68a497John McCall } 2183f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 2184f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2185f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2186f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 2187f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 218828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 21909d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_atomic) && 21919d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)) { 21929d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 21939d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian << "atomic" << "nonatomic"; 21949d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_atomic; 21959d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian } 21969d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian 219728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 219828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 219928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 2200f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 2201f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 2202f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 220328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 22044e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 2205bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 2206f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian // not specified; including when property is 'readonly'. 2207bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 2208f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian else if (!(Attributes & ObjCDeclSpec::DQ_PR_readonly)) { 22099f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian bool isAnyClassTy = 22109f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian (PropertyTy->isObjCClassType() || 22119f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian PropertyTy->isObjCQualifiedClassType()); 22129f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // In non-gc, non-arc mode, 'Class' is treated as a 'void *' no need to 22139f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // issue any warning. 22144e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (isAnyClassTy && getLangOpts().getGC() == LangOptions::NonGC) 22159f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian ; 2216f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian else if (propertyInPrimaryClass) { 2217f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian // Don't issue warning on property with no life time in class 2218f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian // extension as it is inherited from property in primary class. 2219bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 22204e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::GCOnly) 2221bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 22220a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 2223bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 22244e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::NonGC) 2225bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 22269f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian } 2227bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 22289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 222928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 223028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 223128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 223228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 223328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 22349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 223528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 22362b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 22374e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie && getLangOpts().getGC() == LangOptions::GCOnly 223828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 223928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 22407c16d58f8546365d1f56468e9ae1ecfa182afca0Fariborz Jahanian else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2241528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2242528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 2243528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian PropertyTy->isBlockPointerType()) 2244528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Diag(Loc, diag::warn_objc_property_retain_of_block); 224548a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 224648a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 224748a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_setter)) 224848a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian Diag(Loc, diag::warn_objc_readonly_property_has_setter); 224948a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 22509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 2251