SemaObjCProperty.cpp revision 7cd088e519d7e6caa4c4c12db52e0e4ae35d25c2
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 27d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 28d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 29d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 30d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 31d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassCategory, 32d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 33d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall tok::ObjCKeywordKind MethodImplKind) { 3428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 3528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 3628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 3728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 3828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 3928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 4028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 4128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 4228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 4328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_copy))); 44e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 45bf1a028246d884a540aeafa38e89be59a269b072John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 46bf1a028246d884a540aeafa38e89be59a269b072John McCall QualType T = TSI->getType(); 4728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isReferenceType()) { 4828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_reference_property); 49d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 5028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 51e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 52e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *ClassDecl = 53d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall cast<ObjCContainerDecl>(ClassCategory); 54e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 5528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 56ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 57d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *Res = HandlePropertyInClassExtension(S, CDecl, AtLoc, 58ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 59ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 60ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 61ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 62ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 63ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (Res) 64ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 65ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 66ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 67ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 68d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 69d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall GetterSel, SetterSel, 70d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall isAssign, isReadWrite, 71d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Attributes, TSI, MethodImplKind); 72842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 73842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 74842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 75e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 76e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 77d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 78e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekSema::HandlePropertyInClassExtension(Scope *S, ObjCCategoryDecl *CDecl, 79e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 80e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 81e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 82e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 83e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 84e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 8583a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 86e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 87e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 88e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 89e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 90e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 91894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek 929f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 939f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 94e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::err_duplicate_property); 95894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 96d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 97e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 98e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 99e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 100e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 101e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 102e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 103e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 10422f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 10522f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 10622f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 10722f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 10822f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian 109e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 110e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 111e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 112e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 113e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 114e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 115e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 116e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 117d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 118e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 119e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 120e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 121e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 122e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 123e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 124e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 125e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 126e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 127e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 128e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 129e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 13023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek Attributes, T, MethodImplKind, DC); 13180aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // Mark written attribute as having no attribute because 13280aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // this is not a user-written property declaration in primary 13380aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // class. 13480aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian PDecl->setPropertyAttributesAsWritten(ObjCPropertyDecl::OBJC_PR_noattr); 135e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 136e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 137e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 138e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 139e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProcessPropertyDecl(PDecl, CCPrimary); 140d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PDecl; 141e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 143e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 144e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 145e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 14680aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 147e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 148e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 149e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 150e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 151e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 152e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 153e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 154e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 155e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 156e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 1579944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 1589944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 1599944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 160e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 161e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 162e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 163e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 164e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 165e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 166e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 167e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 169d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 170e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 171e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 172e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 173d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CCPrimary, isOverridingProperty, 174e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek MethodImplKind); 175d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 17628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 177e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 178e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 179e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 180e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 183e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 184e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::err_use_continuation_class) 185e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 186e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 187e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 188e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 189e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 190e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary); 191d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 192e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 193e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 194e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 195e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 196e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 197e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 198e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 199e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 200e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 201e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 202e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 20383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 20423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 20523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 206e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 20783a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 20828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 20928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 21028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 21128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC && 21228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 213c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 214c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 215c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 216c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 217c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 218c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 219c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 220c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 22128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 222c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 22328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 22428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 225e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 22628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 22728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 22883a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 229e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 2309f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 2319f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 23228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 233894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 23428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 23528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 23623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 23728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 23823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 23923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 24023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 24128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 24328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 24428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 24528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 24628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 24828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 25028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 25128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 25228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 25328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 25528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 25628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 25828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 25928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 26128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 26228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 26428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 26528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 26728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 26828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 27028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 27128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 27328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 27428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 27628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 27728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27880aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian PDecl->setPropertyAttributesAsWritten(PDecl->getPropertyAttributes()); 27980aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian 28028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 28128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 28228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 28328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 28428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 285e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 28628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 28728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 29028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 29128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 29228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 293d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 294d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 295d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 296d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 297d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassCatImpDecl, 298d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 299d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyIvar) { 300e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 301d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall cast_or_null<ObjCContainerDecl>(ClassCatImpDecl); 30228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 30328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 30428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 305d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 30628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 30728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 30828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 30928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 31028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 31128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 31228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 31328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 31428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 31528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 31628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 31728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 31828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 31928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 32028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 32128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 32228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 32328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 324d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 32528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 32728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 32828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 32928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 331d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 33228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 33328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 33428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 33528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 33628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 337d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 33828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 33928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 34028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 34128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 342d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 34328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 34428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 34528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 34628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 34728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 34828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 34928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 350d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 35128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 35228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 35328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 35428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 35528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 356d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 35728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 35828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 35928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 360d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 36128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 36228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 36328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 36428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 36528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 36728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 36828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType PropType = Context.getCanonicalType(property->getType()); 36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 37128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 37228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 37329fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, PropertyLoc, 37428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar, PropType, /*Dinfo=*/0, 3752846b2b47029c877357438d16c73911c1510be6cFariborz Jahanian ObjCIvarDecl::Protected, 376ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 37729fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 37828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 37928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 38028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 38128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 38228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 38328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 38428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 38528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 38628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 38728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 38828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 38928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 39028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 3914087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 39228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 39328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 39428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 39528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 39628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 39728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (PropType != IvarType) { 39862ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 39962ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (isa<ObjCObjectPointerType>(PropType) 40062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian && isa<ObjCObjectPointerType>(IvarType)) 40162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 40262ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 40362ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian PropType->getAs<ObjCObjectPointerType>(), 40462ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 40562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian else 40662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = (CheckAssignmentConstraints(PropType, IvarType) == Compatible); 40762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 409f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 410f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 411f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 41328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 41428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 41528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 41628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 41728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 41828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 41928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType lhsType =Context.getCanonicalType(PropType).getUnqualifiedType(); 42028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 42128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 42228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 42328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 424f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 425f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 426f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 42728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 42828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 42928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 43028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 43128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 43228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 43328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 43428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 43528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 43628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 43728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 43828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 43928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 44028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 44128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 44228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 44328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 44528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 44628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 44728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 44828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 44928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 45028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 45128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 45228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 45328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 45428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar); 45517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 45617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 45717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize) { 45817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 45917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 46017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 46117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 46217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 46317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) DeclRefExpr(SelfDecl,SelfDecl->getType(), 46417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation()); 46517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 46617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 46717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 46860d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 46917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 4703c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 4713c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 4723c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 47317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 47417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 47517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 47617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 47717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 47817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ResExpr = MaybeCreateCXXExprWithTemporaries(ResExpr); 47917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 48017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 48117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 48217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 48317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 48417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 48517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize) { 48617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 48717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 48817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 48917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) DeclRefExpr(SelfDecl,SelfDecl->getType(), 49017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation()); 49117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 49217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 49317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 49417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 49517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 49617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *rhs = new (Context) DeclRefExpr(Param,Param->getType(), 49717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation()); 49860d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = BuildBinOp(S, SourceLocation(), 49960d7b3a319d84d688752be3870615ac0f111fb16John McCall BinaryOperator::Assign, lhs, rhs); 50017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 50117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 50217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 50317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 50428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 50528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 50628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 50728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 50828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 50928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 51028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 51128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 51228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 51328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 51428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 51528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 51628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 51728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 518d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 521ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (getLangOptions().ObjCNonFragileABI2) { 522ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 523ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 524ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // but it requires a dirreferently named ivar. 525ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCInterfaceDecl *ClassDeclared; 526ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 527ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 528ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 529ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 530ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 531ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 532ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 533ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (Ivar && Ivar->getSynthesize()) { 534ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 535ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 536ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 537ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 538ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 54028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 54128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 54228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 54328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 54428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 54528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 54628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 54728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 54828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 54928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 55028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 55128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 55228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 553d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 55428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 55628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 55728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 558d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 55928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 56328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 56428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 5659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 5669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 5679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 5689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 5699d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 5709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 5719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 5729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 5739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 5749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 5759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 5769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 5779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 5789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 5799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 5809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 5819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 5829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 5849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain) 5859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_retain)) 5869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "retain" << inheritedName; 5889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 5909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 5919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 5939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 5949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 5969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 5979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 5999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 6019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 6029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 6039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 6049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Context.typesAreCompatible(LHSType, RHSType)) { 6069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Incorporate this test with typesAreCompatible. 6079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType()) 6089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Context.ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false)) 6099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 6109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 6119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getType() << SuperProperty->getType() << inheritedName; 6129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 6169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 6179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 6189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 6199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->getResultType() != property->getType()) { 6209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 6219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (property->getType()->isObjCObjectPointerType()) 6229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek result = CheckAssignmentConstraints(GetterMethod->getResultType(), 6239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType()); 6249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 6259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 6269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 6279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 6289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 6299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 6309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 6369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 6379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// diagnostics in a variety of inconsistant situations. 6389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 6399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 6409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 6419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 6429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 6439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 6449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 6459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 6469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 6479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 6489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 6499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 6509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 6519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 6529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 6539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 6549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 6599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 6609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 6619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 6629d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 6639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 6649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 6659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 6669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 6679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 6689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 6699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 6709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 6719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 6729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 6739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 6749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 6752d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 6769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 6779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 6789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 6799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 6809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 6819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 6839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 6859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 6869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 6879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 6889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 6899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 6909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 6919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 6929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 6939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 6949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 6959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 6999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 7009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 7019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 702d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 703d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 7049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 7059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 7079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 7089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 7099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 7109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 7119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 7129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 7139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 7149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 7159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 7179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 7189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 7199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 720d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 7219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 7229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 7239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 7249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 7259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 7269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 7289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 7319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator P = MDecl->protocol_begin(), 7329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 7339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 7349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 7359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 7379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 7389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator P = IDecl->protocol_begin(), 7399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); P != E; ++P) 740d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 7419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 7429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 7439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 7449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 7459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 7469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 7509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 7519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 7529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 7539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 7549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 7559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 7569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 7589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 7599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 7609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 7639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 7649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 7659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 7669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 7679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 7689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 7699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 7709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 7729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 7739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 7749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 7789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 7799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 7809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 7819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 7829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 7839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 7859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 7869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 7879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 7919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 7929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 7939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 7959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 7969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 7979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 7989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 8019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 8029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 803cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 804cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 8059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 8069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 8079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 8089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 8099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 8109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 8129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 8139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); PI != E; ++PI) 814cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 8159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 8179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 8189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 8199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 8209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 8219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 8229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 8249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = CATDecl->protocol_begin(), 8259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 826cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 8279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 8299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 8309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 8319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 832cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 833cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 834cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 835cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropertyFromSuper || PropertyFromSuper != Prop) { 836cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 837cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 838cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 839cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 8409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 8429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 8439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 844cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 8459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 8479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 848509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 849509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 850509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 851509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 852509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 853509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 854509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 855509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 856509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 857509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 858509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 859509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 860509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->protocol_end(); PI != E; ++PI) 861509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 862509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 863509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 864509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 865509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 866509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 867509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 868509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 869509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 870509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 871509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 872509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 873509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 874509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 875509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 876509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 877509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 878509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 879509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 880509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 881509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 882509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 883509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 884509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 885509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 886509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 887509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 888509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 8899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 8909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 8919d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 8929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 8939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 8949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 8959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 8969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 8979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 8989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 8999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 9029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 9039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); PI != E; ++PI) { 9049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 9059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 9069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 9109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 9119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 9129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 9139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 9149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 9159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 9189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 9199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 9209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 9219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 9229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 9269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 928509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 929509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 930509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties (Scope *S, ObjCImplDecl* IMPDecl, 931509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCInterfaceDecl *IDecl) { 932509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 933509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 934509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 935509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 936509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 937509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 938509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 939509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 940509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 941509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 942509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 943509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 944509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 945509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 946509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 947509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 948509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 949509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 950509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 951d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 952d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 953d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 954d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian 955509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ActOnPropertyImplDecl(S, IMPDecl->getLocation(), IMPDecl->getLocation(), 956d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall true, IMPDecl, 957509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getIdentifier(), Prop->getIdentifier()); 958509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 959509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 96117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 964cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 965cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 966cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 967cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 969cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 9769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 9779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 9849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.count(Prop)) 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 9889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 9899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 9909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 9919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 9929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 9939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 9949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 9999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 10009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 10019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 10029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 10049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 10059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 10109d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC) 10149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 10169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 10179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 10189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 10229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod = 10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IMPDecl->getInstanceMethod(Property->getGetterName()); 10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *SetterMethod = 10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IMPDecl->getInstanceMethod(Property->getSetterName()); 10329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 10349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getIdentifier(); 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 10459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 10469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 10479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 10509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CD) { 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 10559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 10569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 10629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ((*SetterMethod->param_begin())->getType() != property->getType())) { 10679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 10709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 10719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 10799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 10809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 10849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 10859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 10869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), property->getGetterName(), 10873fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian property->getType(), 0, CD, true, false, true, 10883fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian false, 10899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 10909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 10919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 109423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 109523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 109623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (DeclContext *lexicalDC = property->getLexicalDeclContext()) 109723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 109823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek 10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 11019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 11039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 11069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 11079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 11089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 11099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), 11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getSetterName(), 11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy, 0, CD, true, false, true, 11163fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian false, 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 11199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 11209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 11219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), 11259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 11269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType(), 11279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 11289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek VarDecl::None, 112916573fa9705b546b7597c273b25b85d6321e2b33Douglas Gregor VarDecl::None, 11309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 11314ecb25fa94897b2c03510292acace710e5262ba5Fariborz Jahanian SetterMethod->setMethodParams(Context, &Argument, 1, 1); 11329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 113323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 113423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 113523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (DeclContext *lexicalDC = property->getLexicalDeclContext()) 113623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 11379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 11389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 11399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 11409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 11419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 11429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 11449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 11459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 11469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 11479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 11489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 11499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 11509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 11519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 11529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 11539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 11549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 11559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 11569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 11579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 11589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 11599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1161d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 11639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 11649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 11655fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek if (!PDecl) 11665fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 11675fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 11685fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1169842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 11709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 11729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 117328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 117428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 117528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 117628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_retain))) { 117728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 117828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 117928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 118028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 118128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 118228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 11839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 118428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 118528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 118628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 118728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 118828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 11899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 119028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 119128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) && 119228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !PropertyTy->isObjCObjectPointerType() && 119328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !PropertyTy->isBlockPointerType() && 1194842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !Context.isObjCNSObjectType(PropertyTy) && 1195842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 119628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 119728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << (Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain"); 119828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain); 119928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 12009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 120128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 120228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 120328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 120428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 120528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 120628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 120728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 120828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 120928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 121028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 121128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 121228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 121328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 121428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 121528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 121628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 121728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 121828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 121928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 12209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 122128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 122228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 122328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 122428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_retain)) && 122528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 122628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 122728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Skip this warning in gc-only mode. 122828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::GCOnly) 122928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 12309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 123128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If non-gc code warn that this is likely inappropriate. 123228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() == LangOptions::NonGC) 123328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_default_assign_on_object); 12349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 123528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 123628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 123728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 123828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 123928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 12409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 124128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 124228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && getLangOptions().getGCMode() == LangOptions::GCOnly 124328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 124428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 12459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1246