SemaObjCProperty.cpp revision 937ec1d9575ec455bc2d4e1f159f64980b476196
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 1655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/ASTMutationListener.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian#include "clang/AST/ExprCXX.h" 1955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/ExprObjC.h" 20edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian#include "clang/Basic/SourceManager.h" 2155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Lex/Lexer.h" 2255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Lex/Preprocessor.h" 2355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h" 2450df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 258fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 3128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33265941bc308d65cc270d5c4de5806f37ce405606John McCall/// getImpliedARCOwnership - Given a set of property attributes and a 34265941bc308d65cc270d5c4de5806f37ce405606John McCall/// type, infer an expected lifetime. The type's ownership qualification 35265941bc308d65cc270d5c4de5806f37ce405606John McCall/// is not considered. 36265941bc308d65cc270d5c4de5806f37ce405606John McCall/// 37265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Returns OCL_None if the attributes as stated do not imply an ownership. 38265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Never returns OCL_Autoreleasing. 39265941bc308d65cc270d5c4de5806f37ce405606John McCallstatic Qualifiers::ObjCLifetime getImpliedARCOwnership( 40265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attrs, 41265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType type) { 42265941bc308d65cc270d5c4de5806f37ce405606John McCall // retain, strong, copy, weak, and unsafe_unretained are only legal 43265941bc308d65cc270d5c4de5806f37ce405606John McCall // on properties of retainable pointer type. 44265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & (ObjCPropertyDecl::OBJC_PR_retain | 45265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_strong | 46265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 47d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return Qualifiers::OCL_Strong; 48265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_weak) { 49265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Weak; 50265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_unsafe_unretained) { 51265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 52265941bc308d65cc270d5c4de5806f37ce405606John McCall } 53265941bc308d65cc270d5c4de5806f37ce405606John McCall 54265941bc308d65cc270d5c4de5806f37ce405606John McCall // assign can appear on other types, so we have to check the 55265941bc308d65cc270d5c4de5806f37ce405606John McCall // property type. 56265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & ObjCPropertyDecl::OBJC_PR_assign && 57265941bc308d65cc270d5c4de5806f37ce405606John McCall type->isObjCRetainableType()) { 58265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 59265941bc308d65cc270d5c4de5806f37ce405606John McCall } 60265941bc308d65cc270d5c4de5806f37ce405606John McCall 61265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_None; 62265941bc308d65cc270d5c4de5806f37ce405606John McCall} 63265941bc308d65cc270d5c4de5806f37ce405606John McCall 64f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 65f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 66f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 67f85e193739c953358c865005855253af4f68a497John McCall 68f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 69f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 70f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 71f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 72f85e193739c953358c865005855253af4f68a497John McCall 73f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 74f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 75f85e193739c953358c865005855253af4f68a497John McCall 76265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime expectedLifetime 77265941bc308d65cc270d5c4de5806f37ce405606John McCall = getImpliedARCOwnership(propertyKind, property->getType()); 78265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!expectedLifetime) { 79f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 80265941bc308d65cc270d5c4de5806f37ce405606John McCall // attribute. That's okay, but restore reasonable invariants by 81265941bc308d65cc270d5c4de5806f37ce405606John McCall // setting the property attribute according to the lifetime 82265941bc308d65cc270d5c4de5806f37ce405606John McCall // qualifier. 83265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attr; 84265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == Qualifiers::OCL_Strong) { 85265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_strong; 86265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak) { 87265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_weak; 88265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 89265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(propertyLifetime == Qualifiers::OCL_ExplicitNone); 90265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 91265941bc308d65cc270d5c4de5806f37ce405606John McCall } 92265941bc308d65cc270d5c4de5806f37ce405606John McCall property->setPropertyAttributes(attr); 93f85e193739c953358c865005855253af4f68a497John McCall return; 94f85e193739c953358c865005855253af4f68a497John McCall } 95f85e193739c953358c865005855253af4f68a497John McCall 96f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 97f85e193739c953358c865005855253af4f68a497John McCall 98f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 99f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 100b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 101f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 102265941bc308d65cc270d5c4de5806f37ce405606John McCall << expectedLifetime 103f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 104f85e193739c953358c865005855253af4f68a497John McCall} 105f85e193739c953358c865005855253af4f68a497John McCall 106dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanianstatic unsigned deduceWeakPropertyFromType(Sema &S, QualType T) { 107dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if ((S.getLangOpts().getGC() != LangOptions::NonGC && 108dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.isObjCGCWeak()) || 109dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (S.getLangOpts().ObjCAutoRefCount && 110dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.getObjCLifetime() == Qualifiers::OCL_Weak)) 111dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return ObjCDeclSpec::DQ_PR_weak; 112dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return 0; 113dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 114dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 115b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor/// \brief Check this Objective-C property against a property declared in the 116b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor/// given protocol. 117b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregorstatic void 118b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas GregorCheckPropertyAgainstProtocol(Sema &S, ObjCPropertyDecl *Prop, 119b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor ObjCProtocolDecl *Proto, 120b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor llvm::SmallPtrSet<ObjCProtocolDecl *, 16> &Known) { 121b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Have we seen this protocol before? 122b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor if (!Known.insert(Proto)) 123b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor return; 124b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor 125b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Look for a property with the same name. 126b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor DeclContext::lookup_result R = Proto->lookup(Prop->getDeclName()); 127b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (unsigned I = 0, N = R.size(); I != N; ++I) { 128b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor if (ObjCPropertyDecl *ProtoProp = dyn_cast<ObjCPropertyDecl>(R[I])) { 129b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor S.DiagnosePropertyMismatch(Prop, ProtoProp, Proto->getIdentifier()); 130b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor return; 131b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 132b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 133b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor 134b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Check this property against any protocols we inherit. 135b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCProtocolDecl::protocol_iterator P = Proto->protocol_begin(), 136b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = Proto->protocol_end(); 137b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 138b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(S, Prop, *P, Known); 139b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 140b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor} 141b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor 142d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 14377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 144d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 145d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 146d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 147d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 148d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 1494a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 1504a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 151ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = ODS.getPropertyAttributes(); 152f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 153f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 154ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes |= deduceWeakPropertyFromType(*this, T); 155dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 156ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 15728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 158ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 15928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 16028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 161ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 16228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 163ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 164ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 165ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 166ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 167ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 16814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 169aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor // Proceed with constructing the ObjCPropertyDecls. 170a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 171aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor ObjCPropertyDecl *Res = 0; 172aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 173ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 174aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor Res = HandlePropertyInClassExtension(S, AtLoc, LParenLoc, 175ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 176ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 177ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes, 178dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 179ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 180ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 181aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (!Res) 182aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor return 0; 183ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 184aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor } 185aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor 186aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (!Res) { 187aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor Res = CreatePropertyDecl(S, ClassDecl, AtLoc, LParenLoc, FD, 188aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor GetterSel, SetterSel, isAssign, isReadWrite, 189aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor Attributes, ODS.getPropertyAttributes(), 190aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor TSI, MethodImplKind); 191aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (lexicalDC) 192aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor Res->setLexicalDeclContext(lexicalDC); 193aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor } 1944a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 195842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 196ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling CheckObjCPropertyAttributes(Res, AtLoc, Attributes, 197cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (isa<ObjCInterfaceDecl>(ClassDecl) || 198cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian isa<ObjCProtocolDecl>(ClassDecl))); 199f85e193739c953358c865005855253af4f68a497John McCall 2004e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 201f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 202f85e193739c953358c865005855253af4f68a497John McCall 203b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor llvm::SmallPtrSet<ObjCProtocolDecl *, 16> KnownProtos; 204aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (ObjCInterfaceDecl *IFace = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 205b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // For a class, compare the property against a property in our superclass. 206b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor bool FoundInSuper = false; 207aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (ObjCInterfaceDecl *Super = IFace->getSuperClass()) { 208aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor DeclContext::lookup_result R = Super->lookup(Res->getDeclName()); 209b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (unsigned I = 0, N = R.size(); I != N; ++I) { 210b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor if (ObjCPropertyDecl *SuperProp = dyn_cast<ObjCPropertyDecl>(R[I])) { 211aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor DiagnosePropertyMismatch(Res, SuperProp, Super->getIdentifier()); 212b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor FoundInSuper = true; 213b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor break; 214b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 215b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 216b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 217b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor 218b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor if (FoundInSuper) { 219b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Also compare the property against a property in our protocols. 220b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCInterfaceDecl::protocol_iterator P = IFace->protocol_begin(), 221b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = IFace->protocol_end(); 222b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 223b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(*this, Res, *P, KnownProtos); 224b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 225b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } else { 226b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Slower path: look in all protocols we referenced. 227b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCInterfaceDecl::all_protocol_iterator 228b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P = IFace->all_referenced_protocol_begin(), 229b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = IFace->all_referenced_protocol_end(); 230b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 231b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(*this, Res, *P, KnownProtos); 232b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 233b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 234b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } else if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 235b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCCategoryDecl::protocol_iterator P = Cat->protocol_begin(), 236b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = Cat->protocol_end(); 237b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 238b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(*this, Res, *P, KnownProtos); 239b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 240b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } else { 241b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor ObjCProtocolDecl *Proto = cast<ObjCProtocolDecl>(ClassDecl); 242b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCProtocolDecl::protocol_iterator P = Proto->protocol_begin(), 243b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = Proto->protocol_end(); 244b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 245b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(*this, Res, *P, KnownProtos); 246aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor } 247aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor } 248aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor 249abd56c816e9164b17bb3e7154a511b0c9896ffdbDmitri Gribenko ActOnDocumentableDecl(Res); 250842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 251e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 252e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 253b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidisstatic ObjCPropertyDecl::PropertyAttributeKind 254ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill WendlingmakePropertyAttributesAsWritten(unsigned Attributes) { 255b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 256ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 257b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 258ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 259b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 260ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_getter) 261b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 262ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_setter) 263b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 264ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_assign) 265b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 266ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 267b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 268ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 269b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 270ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) 271b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 272ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 273b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 274ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 275b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 276ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 277b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 278ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 279b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 280b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 281b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis return (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten; 282b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis} 283b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 2845bf0e3522fac400cf7bf49a775554f0fc942b336Fariborz Jahanianstatic bool LocPropertyAttribute( ASTContext &Context, const char *attrName, 285edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation LParenLoc, SourceLocation &Loc) { 286edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (LParenLoc.isMacroID()) 287edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 288edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 289edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceManager &SM = Context.getSourceManager(); 290edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian std::pair<FileID, unsigned> locInfo = SM.getDecomposedLoc(LParenLoc); 291edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Try to load the file buffer. 292edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian bool invalidTemp = false; 293edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef file = SM.getBufferData(locInfo.first, &invalidTemp); 294edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (invalidTemp) 295edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 296edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian const char *tokenBegin = file.data() + locInfo.second; 297edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 298edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Lex from the start of the given location. 299edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Lexer lexer(SM.getLocForStartOfFile(locInfo.first), 300edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Context.getLangOpts(), 301edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian file.begin(), tokenBegin, file.end()); 302edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Token Tok; 303edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian do { 304edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian lexer.LexFromRawLexer(Tok); 305edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (Tok.is(tok::raw_identifier) && 306edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef(Tok.getRawIdentifierData(), Tok.getLength()) == attrName) { 307edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Loc = Tok.getLocation(); 308edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return true; 309edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 310edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } while (Tok.isNot(tok::r_paren)); 311edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 312edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 3132b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian} 3142b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 315d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanianstatic unsigned getOwnershipRule(unsigned attr) { 316dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return attr & (ObjCPropertyDecl::OBJC_PR_assign | 317dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_retain | 318dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_copy | 319dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_weak | 320dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_strong | 321dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 322dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 323dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 324aabd094cf694039fe823987e133af7ac25cb9711Douglas GregorObjCPropertyDecl * 325a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 32677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation AtLoc, 32777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 32877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FieldDeclarator &FD, 329e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 330e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 331e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 332ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const unsigned Attributes, 333dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 334e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 33583a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 336e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 33758a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 338e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 339a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 340e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 3412a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 3422a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 343d329724745b49f894b768d47275b7c2713106e89Douglas Gregor if (CCPrimary) { 3442a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 3452a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 346d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCInterfaceDecl::known_extensions_iterator 347d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext = CCPrimary->known_extensions_begin(), 348d329724745b49f894b768d47275b7c2713106e89Douglas Gregor ExtEnd = CCPrimary->known_extensions_end(); 349d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext != ExtEnd; ++Ext) { 350d329724745b49f894b768d47275b7c2713106e89Douglas Gregor if (ObjCPropertyDecl *prevDecl 351d329724745b49f894b768d47275b7c2713106e89Douglas Gregor = ObjCPropertyDecl::findPropertyDecl(*Ext, PropertyId)) { 3522a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 3532a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 3542a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 3552a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 3562a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 357d329724745b49f894b768d47275b7c2713106e89Douglas Gregor } 358d329724745b49f894b768d47275b7c2713106e89Douglas Gregor 359e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 360e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 36188f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 362e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 363e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 36477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, T); 365b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 366dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 367ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 36822f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 369ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 37022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 371b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 372b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 373b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 374b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 37588f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 37688f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 37788f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 37891ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 379e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 380e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 381e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 382e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 383e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 384e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 385e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 386d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 387e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 388e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 389e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 390e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 391e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 392e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 393e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 394e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 395e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 396d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ObjCPropertyDecl *PrimaryPDecl = 39777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian CreatePropertyDecl(S, CCPrimary, AtLoc, LParenLoc, 398e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 399ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes,AttributesAsWritten, T, MethodImplKind, DC); 400e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 401e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 402e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 403e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 404d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ProcessPropertyDecl(PrimaryPDecl, CCPrimary, /* redeclaredProperty = */ 0, 405a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 406d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PrimaryPDecl->getGetterMethodDecl()); 407d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PrimaryPDecl->getSetterMethodDecl()); 408c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 409d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PrimaryPDecl, /*OrigProp=*/0, CDecl); 410d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis return PrimaryPDecl; 411e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 412e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!Context.hasSameType(PIDecl->getType(), PDecl->getType())) { 413e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian bool IncompatibleObjC = false; 414e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian QualType ConvertedType; 415ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Relax the strict type matching for property type in continuation class. 416ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Allow property object type of continuation class to be different as long 417ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // as it narrows the object type in its primary class property. Note that 418ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // this conversion is safe only because the wider type is for a 'readonly' 419ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // property in primary class and 'narrowed' type for a 'readwrite' property 420ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // in continuation class. 421e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!isa<ObjCObjectPointerType>(PIDecl->getType()) || 422e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian !isa<ObjCObjectPointerType>(PDecl->getType()) || 423e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian (!isObjCPointerConversion(PDecl->getType(), PIDecl->getType(), 424e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian ConvertedType, IncompatibleObjC)) 425e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian || IncompatibleObjC) { 426e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(AtLoc, 427e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian diag::err_type_mismatch_continuation_class) << PDecl->getType(); 428e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(PIDecl->getLocation(), diag::note_property_declare); 4296defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return 0; 430e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian } 431a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian } 432a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian 433e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 434e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 43580aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 436e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 437dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian PIkind |= deduceWeakPropertyFromType(*this, PIDecl->getType()); 438ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned ClassExtensionMemoryModel = getOwnershipRule(Attributes); 439d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanian unsigned PrimaryClassMemoryModel = getOwnershipRule(PIkind); 440dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if (PrimaryClassMemoryModel && ClassExtensionMemoryModel && 441dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (PrimaryClassMemoryModel != ClassExtensionMemoryModel)) { 442e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 443e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 444e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 4459944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 4469944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 4479944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 448e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 449e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 450e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 451e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 452e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 453e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 454e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 455e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 456a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 457a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 4587939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 4597939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 460d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 46177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian ActOnProperty(S, AtLoc, LParenLoc, FD, ProtocolPropertyODS, 462e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 463e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 464a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 4654a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 4664a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 467d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 46828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 469e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 470ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 471e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 472ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 473f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 474ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 475e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 476e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 477e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 478788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 479788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 480788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 481788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 482788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 483ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 484788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 485788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 486788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 487788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 488e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 489e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 4906defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return 0; 491e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 492e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 493e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 4948254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 495d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PIDecl->getGetterMethodDecl()); 496d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PIDecl->getSetterMethodDecl()); 497c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 498c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PDecl, PIDecl, CDecl); 4996defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return PDecl; 500e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 501e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 502e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 503e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 504e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 50577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 506e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 507e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 508e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 509e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 510e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 511ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const unsigned Attributes, 512dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 51383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 51423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 51523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 516e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 51783a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 51828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 5214e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC && 522ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 523c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 524c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 525c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 526c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 527c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 528c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 529c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 530c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 53227d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman 53327d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman if (T->isObjCObjectType()) { 53427d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman SourceLocation StarLoc = TInfo->getTypeLoc().getLocEnd(); 53527d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman StarLoc = PP.getLocForEndOfToken(StarLoc); 53627d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object) 53727d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman << FixItHint::CreateInsertion(StarLoc, "*"); 53827d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman T = Context.getObjCObjectPointerType(T); 53927d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman SourceLocation TLoc = TInfo->getTypeLoc().getLocStart(); 54027d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman TInfo = Context.getTrivialTypeSourceInfo(T, TLoc); 54127d4644f4fad002b9e1be87c4e07f0f0c8240e1dEli Friedman } 54228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 543e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 54428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 54528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 54677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, TInfo); 547e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 5489f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 5499f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 55028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 551894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 55228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 55328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 55423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 55623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 55723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 55823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 55928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 56328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 56528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 56628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 56728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 56828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 56928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 5710a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 572dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 5730a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 574ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 57528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 57628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 577ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_getter) 57828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 580ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_setter) 58128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 58228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 58328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 58428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 58528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 586ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 58728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 58828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 589ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 590f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 591f85e193739c953358c865005855253af4f68a497John McCall 592ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) 593f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 594f85e193739c953358c865005855253af4f68a497John McCall 595ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 59628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 59728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 598ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 599f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 600f85e193739c953358c865005855253af4f68a497John McCall 60128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 60228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 60328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 604265941bc308d65cc270d5c4de5806f37ce405606John McCall // In the semantic attributes, one of nonatomic or atomic is always set. 605ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 60628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 607265941bc308d65cc270d5c4de5806f37ce405606John McCall else 60845937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 60928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 610f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 611ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 612f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 613f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 614f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 615f85e193739c953358c865005855253af4f68a497John McCall 61628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 61728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 61828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 61928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 62028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 621e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 62228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 62328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 624f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 625f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 626f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 627f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 628f85e193739c953358c865005855253af4f68a497John McCall 629f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 630f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 631f85e193739c953358c865005855253af4f68a497John McCall 632265941bc308d65cc270d5c4de5806f37ce405606John McCall // The lifetime implied by the property's attributes. 633265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime propertyLifetime = 634265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(property->getPropertyAttributes(), 635265941bc308d65cc270d5c4de5806f37ce405606John McCall property->getType()); 636f85e193739c953358c865005855253af4f68a497John McCall 637265941bc308d65cc270d5c4de5806f37ce405606John McCall // We're fine if they match. 638265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == ivarLifetime) return; 639f85e193739c953358c865005855253af4f68a497John McCall 640265941bc308d65cc270d5c4de5806f37ce405606John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 641265941bc308d65cc270d5c4de5806f37ce405606John McCall if (ivarLifetime == Qualifiers::OCL_None || 642265941bc308d65cc270d5c4de5806f37ce405606John McCall ivarLifetime == Qualifiers::OCL_Autoreleasing) 643265941bc308d65cc270d5c4de5806f37ce405606John McCall return; 644265941bc308d65cc270d5c4de5806f37ce405606John McCall 645d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // If the ivar is private, and it's implicitly __unsafe_unretained 646d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // becaues of its type, then pretend it was actually implicitly 647d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // __strong. This is only sound because we're processing the 648d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // property implementation before parsing any method bodies. 649d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (ivarLifetime == Qualifiers::OCL_ExplicitNone && 650d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall propertyLifetime == Qualifiers::OCL_Strong && 651d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->getAccessControl() == ObjCIvarDecl::Private) { 652d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall SplitQualType split = ivarType.split(); 653d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (split.Quals.hasObjCLifetime()) { 654d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall assert(ivarType->isObjCARCImplicitlyUnretainedType()); 655d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall split.Quals.setObjCLifetime(Qualifiers::OCL_Strong); 656d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivarType = S.Context.getQualifiedType(split); 657d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->setType(ivarType); 658d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return; 659d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 660d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 661d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall 662265941bc308d65cc270d5c4de5806f37ce405606John McCall switch (propertyLifetime) { 663265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Strong: 664135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::err_arc_strong_property_ownership) 665265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 666265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 667265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivarLifetime; 668265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 669265941bc308d65cc270d5c4de5806f37ce405606John McCall 670265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Weak: 671135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::error_weak_property) 672265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 673265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName(); 674265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 675265941bc308d65cc270d5c4de5806f37ce405606John McCall 676265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_ExplicitNone: 677135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::err_arc_assign_property_ownership) 678265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 679265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 680265941bc308d65cc270d5c4de5806f37ce405606John McCall << ((property->getPropertyAttributesAsWritten() 681265941bc308d65cc270d5c4de5806f37ce405606John McCall & ObjCPropertyDecl::OBJC_PR_assign) != 0); 682265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 683265941bc308d65cc270d5c4de5806f37ce405606John McCall 684265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Autoreleasing: 685265941bc308d65cc270d5c4de5806f37ce405606John McCall llvm_unreachable("properties cannot be autoreleasing"); 686265941bc308d65cc270d5c4de5806f37ce405606John McCall 687265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_None: 688265941bc308d65cc270d5c4de5806f37ce405606John McCall // Any other property should be ignored. 689f85e193739c953358c865005855253af4f68a497John McCall return; 690f85e193739c953358c865005855253af4f68a497John McCall } 691f85e193739c953358c865005855253af4f68a497John McCall 692f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 693135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis if (propertyImplLoc.isValid()) 694135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(propertyImplLoc, diag::note_property_synthesize); 695f85e193739c953358c865005855253af4f68a497John McCall} 696f85e193739c953358c865005855253af4f68a497John McCall 697015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// setImpliedPropertyAttributeForReadOnlyProperty - 698015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// This routine evaludates life-time attributes for a 'readonly' 699015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// property with no known lifetime of its own, using backing 700015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// 'ivar's attribute, if any. If no backing 'ivar', property's 701015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// life-time is assumed 'strong'. 702015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanianstatic void setImpliedPropertyAttributeForReadOnlyProperty( 703015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl *property, ObjCIvarDecl *ivar) { 704015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime propertyLifetime = 705015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian getImpliedARCOwnership(property->getPropertyAttributes(), 706015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->getType()); 707015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (propertyLifetime != Qualifiers::OCL_None) 708015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 709015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 710015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (!ivar) { 711015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // if no backing ivar, make property 'strong'. 712015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 713015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 714015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 715015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // property assumes owenership of backing ivar. 716015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian QualType ivarType = ivar->getType(); 717015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 718015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (ivarLifetime == Qualifiers::OCL_Strong) 719015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 720015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian else if (ivarLifetime == Qualifiers::OCL_Weak) 721015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 722015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 723015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian} 72428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 7258dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian/// DiagnosePropertyMismatchDeclInProtocols - diagnose properties declared 7268dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian/// in inherited protocols with mismatched types. Since any of them can 7278dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian/// be candidate for synthesis. 728b1a4d37c0549501fe12907bc6ffa81bc5d04b98aBenjamin Kramerstatic void 729b1a4d37c0549501fe12907bc6ffa81bc5d04b98aBenjamin KramerDiagnosePropertyMismatchDeclInProtocols(Sema &S, SourceLocation AtLoc, 730b1a4d37c0549501fe12907bc6ffa81bc5d04b98aBenjamin Kramer ObjCInterfaceDecl *ClassDecl, 7318dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian ObjCPropertyDecl *Property) { 7328dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian ObjCInterfaceDecl::ProtocolPropertyMap PropMap; 7338dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian for (ObjCInterfaceDecl::all_protocol_iterator 7348dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian PI = ClassDecl->all_referenced_protocol_begin(), 7358dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian E = ClassDecl->all_referenced_protocol_end(); PI != E; ++PI) { 7368dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (const ObjCProtocolDecl *PDecl = (*PI)->getDefinition()) 7378dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian PDecl->collectInheritedProtocolProperties(Property, PropMap); 7388dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian } 7398dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (ObjCInterfaceDecl *SDecl = ClassDecl->getSuperClass()) 7408dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian while (SDecl) { 7418dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian for (ObjCInterfaceDecl::all_protocol_iterator 7428dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian PI = SDecl->all_referenced_protocol_begin(), 7438dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian E = SDecl->all_referenced_protocol_end(); PI != E; ++PI) { 7448dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (const ObjCProtocolDecl *PDecl = (*PI)->getDefinition()) 7458dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian PDecl->collectInheritedProtocolProperties(Property, PropMap); 7468dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian } 7478dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian SDecl = SDecl->getSuperClass(); 7488dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian } 7498dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian 7508dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (PropMap.empty()) 7518dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian return; 7528dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian 7538dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian QualType RHSType = S.Context.getCanonicalType(Property->getType()); 7548dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian bool FirsTime = true; 7558dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian for (ObjCInterfaceDecl::ProtocolPropertyMap::iterator 7568dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian I = PropMap.begin(), E = PropMap.end(); I != E; I++) { 7578dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian ObjCPropertyDecl *Prop = I->second; 7588dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian QualType LHSType = S.Context.getCanonicalType(Prop->getType()); 7598dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (!S.Context.propertyTypesAreCompatible(LHSType, RHSType)) { 7608dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian bool IncompatibleObjC = false; 7618dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian QualType ConvertedType; 7628dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (!S.isObjCPointerConversion(RHSType, LHSType, ConvertedType, IncompatibleObjC) 7638dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian || IncompatibleObjC) { 7648dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (FirsTime) { 7658dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian S.Diag(Property->getLocation(), diag::warn_protocol_property_mismatch) 7668dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian << Property->getType(); 7678dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian FirsTime = false; 7688dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian } 7698dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian S.Diag(Prop->getLocation(), diag::note_protocol_property_declare) 7708dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian << Prop->getType(); 7718dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian } 7728dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian } 7738dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian } 7748dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (!FirsTime && AtLoc.isValid()) 7758dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian S.Diag(AtLoc, diag::note_property_synthesize); 7768dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian} 7778dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian 778cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// DiagnoseClassAndClassExtPropertyMismatch - diagnose inconsistant property 779cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// attribute declared in primary class and attributes overridden in any of its 780cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// class extensions. 781cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanianstatic void 782cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz JahanianDiagnoseClassAndClassExtPropertyMismatch(Sema &S, ObjCInterfaceDecl *ClassDecl, 783cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *property) { 784ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = property->getPropertyAttributesAsWritten(); 785ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool warn = (Attributes & ObjCDeclSpec::DQ_PR_readonly); 786d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCInterfaceDecl::known_extensions_iterator 787d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext = ClassDecl->known_extensions_begin(), 788d329724745b49f894b768d47275b7c2713106e89Douglas Gregor ExtEnd = ClassDecl->known_extensions_end(); 789d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext != ExtEnd; ++Ext) { 790cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *ClassExtProperty = 0; 7910dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor DeclContext::lookup_result R = Ext->lookup(property->getDeclName()); 7920dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor for (unsigned I = 0, N = R.size(); I != N; ++I) { 7930dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor ClassExtProperty = dyn_cast<ObjCPropertyDecl>(R[0]); 7940dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor if (ClassExtProperty) 795cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 796cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 7970dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor 798cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (ClassExtProperty) { 799c78ff27813288b30ee566477705353ae660fd577Fariborz Jahanian warn = false; 800cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned classExtPropertyAttr = 801cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ClassExtProperty->getPropertyAttributesAsWritten(); 802cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // We are issuing the warning that we postponed because class extensions 803cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // can override readonly->readwrite and 'setter' attributes originally 804cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // placed on class's property declaration now make sense in the overridden 805cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // property. 806ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) { 807cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (!classExtPropertyAttr || 808a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (classExtPropertyAttr & 809a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (ObjCDeclSpec::DQ_PR_readwrite| 810a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_assign | 811a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 812a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 813a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 814a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_strong))) 815cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian continue; 816cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian warn = true; 817cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 818cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 819cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 820cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 821cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (warn) { 822cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned setterAttrs = (ObjCDeclSpec::DQ_PR_assign | 823cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 824cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 825cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 826cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong); 827ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & setterAttrs) { 828cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian const char * which = 829ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 830cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "assign" : 831ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 832cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "unsafe_unretained" : 833ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 834cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "copy" : 835ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_retain) ? 836cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "retain" : "strong"; 837cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 838cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian S.Diag(property->getLocation(), 839cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian diag::warn_objc_property_attr_mutually_exclusive) 840cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << which; 841cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 842cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 843cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 844cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 845cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian} 846cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 84728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 84828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 849699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// as \@synthesize or \@dynamic. 85028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 851d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 852d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 853d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 854d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 855d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 856a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 857a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 858e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 85984e0ccff7a6e51d7b81fd58686b493a4880dd44dFariborz Jahanian dyn_cast<ObjCContainerDecl>(CurContext); 86028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 86128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 86228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 863d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 86428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 865f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis if (PropertyIvarLoc.isInvalid()) 866f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc = PropertyLoc; 867e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman SourceLocation PropertyDiagLoc = PropertyLoc; 868e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (PropertyDiagLoc.isInvalid()) 869e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PropertyDiagLoc = ClassImpDecl->getLocStart(); 87028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 87128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 87228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 87328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 87428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 87528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 87628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 87728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 87828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 87928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 88028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 88128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 88228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 88328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 88428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 88528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 88628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 887d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 88828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 889dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 89045937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 89145937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 892dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 893dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 894dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 895dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 896dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 897dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 898dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 89928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 90028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 90128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 90228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 90328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 904d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 90528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 90628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 9072b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian if (Synthesize&& 9082b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian (PIkind & ObjCPropertyDecl::OBJC_PR_readonly) && 9092b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian property->hasAttr<IBOutletAttr>() && 9102b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian !AtLoc.isValid()) { 911125643455953069b925b30d2e4ae5674063984edFariborz Jahanian bool ReadWriteProperty = false; 912125643455953069b925b30d2e4ae5674063984edFariborz Jahanian // Search into the class extensions and see if 'readonly property is 913125643455953069b925b30d2e4ae5674063984edFariborz Jahanian // redeclared 'readwrite', then no warning is to be issued. 914125643455953069b925b30d2e4ae5674063984edFariborz Jahanian for (ObjCInterfaceDecl::known_extensions_iterator 915125643455953069b925b30d2e4ae5674063984edFariborz Jahanian Ext = IDecl->known_extensions_begin(), 916125643455953069b925b30d2e4ae5674063984edFariborz Jahanian ExtEnd = IDecl->known_extensions_end(); Ext != ExtEnd; ++Ext) { 917125643455953069b925b30d2e4ae5674063984edFariborz Jahanian DeclContext::lookup_result R = Ext->lookup(property->getDeclName()); 918125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (!R.empty()) 919125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (ObjCPropertyDecl *ExtProp = dyn_cast<ObjCPropertyDecl>(R[0])) { 920125643455953069b925b30d2e4ae5674063984edFariborz Jahanian PIkind = ExtProp->getPropertyAttributesAsWritten(); 921125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) { 922125643455953069b925b30d2e4ae5674063984edFariborz Jahanian ReadWriteProperty = true; 923125643455953069b925b30d2e4ae5674063984edFariborz Jahanian break; 924125643455953069b925b30d2e4ae5674063984edFariborz Jahanian } 925125643455953069b925b30d2e4ae5674063984edFariborz Jahanian } 926125643455953069b925b30d2e4ae5674063984edFariborz Jahanian } 927125643455953069b925b30d2e4ae5674063984edFariborz Jahanian 928125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (!ReadWriteProperty) { 929a4475a6b8277f24ed15d7b67d9dab77444c77cb1Ted Kremenek Diag(property->getLocation(), diag::warn_auto_readonly_iboutlet_property) 930a4475a6b8277f24ed15d7b67d9dab77444c77cb1Ted Kremenek << property->getName(); 931125643455953069b925b30d2e4ae5674063984edFariborz Jahanian SourceLocation readonlyLoc; 932125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (LocPropertyAttribute(Context, "readonly", 933125643455953069b925b30d2e4ae5674063984edFariborz Jahanian property->getLParenLoc(), readonlyLoc)) { 934125643455953069b925b30d2e4ae5674063984edFariborz Jahanian SourceLocation endLoc = 935125643455953069b925b30d2e4ae5674063984edFariborz Jahanian readonlyLoc.getLocWithOffset(strlen("readonly")-1); 936125643455953069b925b30d2e4ae5674063984edFariborz Jahanian SourceRange ReadonlySourceRange(readonlyLoc, endLoc); 937125643455953069b925b30d2e4ae5674063984edFariborz Jahanian Diag(property->getLocation(), 938125643455953069b925b30d2e4ae5674063984edFariborz Jahanian diag::note_auto_readonly_iboutlet_fixup_suggest) << 939125643455953069b925b30d2e4ae5674063984edFariborz Jahanian FixItHint::CreateReplacement(ReadonlySourceRange, "readwrite"); 940125643455953069b925b30d2e4ae5674063984edFariborz Jahanian } 941edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 9422b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian } 9438dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian if (Synthesize && isa<ObjCProtocolDecl>(property->getDeclContext())) 9448dbda516d343706bae904f800c6d64e145d58a8cFariborz Jahanian DiagnosePropertyMismatchDeclInProtocols(*this, AtLoc, IDecl, property); 945cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 946cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian DiagnoseClassAndClassExtPropertyMismatch(*this, IDecl, property); 9472b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 94828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 94928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 95028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 951d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 95228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 95328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 95428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 95528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 956d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 95728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 95828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 95928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 96028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 96128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 96228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 96328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 964d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 96528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 96628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 96728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 96828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 96928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 970d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 97128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 97228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 97328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 974d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 97528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 97628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 977e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman bool CompleteTypeErr = false; 978744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian bool compat = true; 97928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 98028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 98128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 98228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 98328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 984015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // Check that this is a previously declared 'ivar' in 'IDecl' interface 985015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared; 986015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 987265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropType = property->getType(); 988265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropertyIvarType = PropType.getNonReferenceType(); 989e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 990e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (RequireCompleteType(PropertyDiagLoc, PropertyIvarType, 991d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_incomplete_synthesized_property, 992d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor property->getDeclName())) { 993e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(property->getLocation(), diag::note_property_declare); 994e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman CompleteTypeErr = true; 995e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman } 996e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 9974e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 998015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian (property->getPropertyAttributesAsWritten() & 9993efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_readonly) && 10003efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian PropertyIvarType->isObjCRetainableType()) { 1001015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian setImpliedPropertyAttributeForReadOnlyProperty(property, Ivar); 1002015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 1003015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 1004015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl::PropertyAttributeKind kind 1005015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian = property->getPropertyAttributes(); 1006265941bc308d65cc270d5c4de5806f37ce405606John McCall 1007265941bc308d65cc270d5c4de5806f37ce405606John McCall // Add GC __weak to the ivar type if the property is weak. 1008265941bc308d65cc270d5c4de5806f37ce405606John McCall if ((kind & ObjCPropertyDecl::OBJC_PR_weak) && 10094e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 10104e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie assert(!getLangOpts().ObjCAutoRefCount); 1011265941bc308d65cc270d5c4de5806f37ce405606John McCall if (PropertyIvarType.isObjCGCStrong()) { 1012e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_gc_weak_property_strong_type); 1013265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(property->getLocation(), diag::note_property_declare); 1014265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 1015265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType = 1016265941bc308d65cc270d5c4de5806f37ce405606John McCall Context.getObjCGCQualType(PropertyIvarType, Qualifiers::Weak); 1017edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 1018edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 1019e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (AtLoc.isInvalid()) { 1020e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // Check when default synthesizing a property that there is 1021e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // an ivar matching property name and issue warning; since this 1022e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // is the most common case of not using an ivar used for backing 1023e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // property in non-default synthesis case. 1024e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 1025e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCIvarDecl *originalIvar = 1026e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian IDecl->lookupInstanceVariable(property->getIdentifier(), 1027e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ClassDeclared); 1028e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (originalIvar) { 1029e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(PropertyDiagLoc, 1030e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian diag::warn_autosynthesis_property_ivar_match) 10312578532c7323efdd68ec42a31b7bdf72e5218867Fariborz Jahanian << PropertyId << (Ivar == 0) << PropertyIvar 103220e7d992140cc6bc94f2e65f3638346527150756Fariborz Jahanian << originalIvar->getIdentifier(); 1033e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 1034e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(originalIvar->getLocation(), diag::note_ivar_decl); 1035dd3284b17829adfd542ecf4a7b4423dce1d7502bFariborz Jahanian } 1036e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian } 1037e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian 1038e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (!Ivar) { 1039265941bc308d65cc270d5c4de5806f37ce405606John McCall // In ARC, give the ivar a lifetime qualifier based on the 1040f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 10414e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 1042265941bc308d65cc270d5c4de5806f37ce405606John McCall !PropertyIvarType.getObjCLifetime() && 1043265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType->isObjCRetainableType()) { 1044f85e193739c953358c865005855253af4f68a497John McCall 1045265941bc308d65cc270d5c4de5806f37ce405606John McCall // It's an error if we have to do this and the user didn't 1046265941bc308d65cc270d5c4de5806f37ce405606John McCall // explicitly write an ownership attribute on the property. 1047473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 1048265941bc308d65cc270d5c4de5806f37ce405606John McCall !(kind & ObjCPropertyDecl::OBJC_PR_strong)) { 1049e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, 1050473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 1051473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 1052265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 1053265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime lifetime = 1054265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(kind, PropertyIvarType); 1055265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(lifetime && "no lifetime for property?"); 10566dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (lifetime == Qualifiers::OCL_Weak) { 10576dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian bool err = false; 10586dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (const ObjCObjectPointerType *ObjT = 1059a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith PropertyIvarType->getAs<ObjCObjectPointerType>()) { 1060a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith const ObjCInterfaceDecl *ObjI = ObjT->getInterfaceDecl(); 1061a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith if (ObjI && ObjI->isArcWeakrefUnavailable()) { 106280abce3d1597edaf427f65ce15d8433f3f13315dFariborz Jahanian Diag(property->getLocation(), 106380abce3d1597edaf427f65ce15d8433f3f13315dFariborz Jahanian diag::err_arc_weak_unavailable_property) << PropertyIvarType; 106480abce3d1597edaf427f65ce15d8433f3f13315dFariborz Jahanian Diag(ClassImpDecl->getLocation(), diag::note_implemented_by_class) 106580abce3d1597edaf427f65ce15d8433f3f13315dFariborz Jahanian << ClassImpDecl->getName(); 10666dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian err = true; 10676dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 1068a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith } 10690a7dd788dbef975f35f273c7ab913f480f7edd60John McCall if (!err && !getLangOpts().ObjCARCWeak) { 1070e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_arc_weak_no_runtime); 10716dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 10726dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 1073f85e193739c953358c865005855253af4f68a497John McCall } 10746dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian 1075f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 1076265941bc308d65cc270d5c4de5806f37ce405606John McCall qs.addObjCLifetime(lifetime); 1077f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 1078f85e193739c953358c865005855253af4f68a497John McCall } 1079f85e193739c953358c865005855253af4f68a497John McCall } 1080f85e193739c953358c865005855253af4f68a497John McCall 1081f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 10824e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().ObjCAutoRefCount && 10834e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() == LangOptions::NonGC) { 1084e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_synthesize_weak_non_arc_or_gc); 1085f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 1086f85e193739c953358c865005855253af4f68a497John McCall } 1087f85e193739c953358c865005855253af4f68a497John McCall 1088ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 1089f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc,PropertyIvarLoc, PropertyIvar, 109014086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 10917504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 1092ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 10938540b6e778545008fd521b002929b89ce10506ceFariborz Jahanian if (RequireNonAbstractType(PropertyIvarLoc, 10948540b6e778545008fd521b002929b89ce10506ceFariborz Jahanian PropertyIvarType, 10958540b6e778545008fd521b002929b89ce10506ceFariborz Jahanian diag::err_abstract_type_in_decl, 10968540b6e778545008fd521b002929b89ce10506ceFariborz Jahanian AbstractSynthesizedIvarType)) { 10978540b6e778545008fd521b002929b89ce10506ceFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 1098e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->setInvalidDecl(); 10998540b6e778545008fd521b002929b89ce10506ceFariborz Jahanian } else if (CompleteTypeErr) 11008540b6e778545008fd521b002929b89ce10506ceFariborz Jahanian Ivar->setInvalidDecl(); 110129fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 11021b7f9cbed1b96b58a6e5f7808ebc9345a76a0936Richard Smith IDecl->makeDeclVisibleInContext(Ivar); 110328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 1104260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (getLangOpts().ObjCRuntime.isFragile()) 1105e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_missing_property_ivar_decl) 1106e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman << PropertyId; 110728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 110828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 1109260611a32535c851237926bfcf78869b13c07d5bJohn McCall } else if (getLangOpts().ObjCRuntime.isNonFragile() && 111060ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor !declaresSameEntity(ClassDeclared, IDecl)) { 1111e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_ivar_in_superclass_use) 111228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 111328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 111428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 11154087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 111628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 111728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 11185bf5c2ec54ede5352293e5739e9b44bea2f6b01bAnna Zaks property->setPropertyIvarDecl(Ivar); 11195bf5c2ec54ede5352293e5739e9b44bea2f6b01bAnna Zaks 112028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 112128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 112228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 1123744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (!Context.hasSameType(PropertyIvarType, IvarType)) { 112414086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 1125f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 1126b3cd3c0c8a234803dcb9b9c0dfe10106674141cdRichard Smith compat = 112762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 112814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 112962ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 1130b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 1131f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis compat = (CheckAssignmentConstraints(PropertyIvarLoc, PropertyIvarType, 1132f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis IvarType) 1133daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 1134b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 113562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 1136e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_ivar_type) 1137f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 1138f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 1139f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 114028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 114128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 114228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1143744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian else { 1144744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // FIXME! Rules for properties are somewhat different that those 1145744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // for assignments. Use a new routine to consolidate all cases; 1146744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // specifically for property redeclarations as well as for ivars. 1147744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 1148744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 1149744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (lhsType != rhsType && 1150744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian lhsType->isArithmeticType()) { 1151744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(PropertyDiagLoc, diag::error_property_ivar_type) 1152744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << property->getDeclName() << PropType 1153744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << Ivar->getDeclName() << IvarType; 1154744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 1155744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // Fall thru - see previous comment 1156744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian } 115728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 115828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 1159f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 11604e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC)) { 1161e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_weak_property) 116228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 1163edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 116428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 116528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1166f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 116728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 116828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 11694e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 1170e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_strong_property) 117128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 117228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 117328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 117428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 11754e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1176f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 117728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 117828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 1179e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_dynamic_property_ivar_decl); 1180f85e193739c953358c865005855253af4f68a497John McCall 118128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 118228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 118328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 118428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 118528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 118628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 118728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 1188a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 1189e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 1190744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (CompleteTypeErr || !compat) 1191e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PIDecl->setInvalidDecl(); 1192e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 119317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 119417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 1195e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 11960313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 119717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 119817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 119917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 12009a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman SynthesizedFunctionScope Scope(*this, getterMethod); 120117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 120217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1203f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 12049a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_RValue, PropertyDiagLoc); 12059a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(SelfExpr); 120617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 12079a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), PropertyDiagLoc, 12080c70181854a95fca0e0d56dfa1203eb2216052eaFariborz Jahanian Ivar->getLocation(), 120917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 121060d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 121117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 12129a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman PropertyDiagLoc, 12133c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 12143c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 12159a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman PropertyDiagLoc, 121617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 121717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 121817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 121917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 12204765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 122117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 122217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 122317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 1224831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 1225831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 1226831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 1227831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 1228831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 1229831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 1230b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian if (getLangOpts().ObjCAutoRefCount && Synthesize) 1231b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian switch (getterMethod->getMethodFamily()) { 1232b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian case OMF_retain: 1233b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian case OMF_retainCount: 1234b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian case OMF_release: 1235b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian case OMF_autorelease: 1236b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian Diag(getterMethod->getLocation(), diag::err_arc_illegal_method_def) 1237b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian << 1 << getterMethod->getSelector(); 1238b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian break; 1239b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian default: 1240b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian break; 1241b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian } 124217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 124317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 124417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 1245e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 1246e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->getType()->isRecordType()) { 124717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 12489a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman SynthesizedFunctionScope Scope(*this, setterMethod); 124917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 125017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1251f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 12529a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_RValue, PropertyDiagLoc); 12539a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(SelfExpr); 125417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 12559a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), PropertyDiagLoc, 12560c70181854a95fca0e0d56dfa1203eb2216052eaFariborz Jahanian Ivar->getLocation(), 125717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 125817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 125917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 12603c3b7f90a863af43fa63043d396553ecf205351cJohn McCall QualType T = Param->getType().getNonReferenceType(); 12619a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman DeclRefExpr *rhs = new (Context) DeclRefExpr(Param, false, T, 12629a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_LValue, PropertyDiagLoc); 12639a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(rhs); 12649a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman ExprResult Res = BuildBinOp(S, PropertyDiagLoc, 12652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 126657e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (property->getPropertyAttributes() & 126757e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_atomic) { 126857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Expr *callExpr = Res.takeAs<Expr>(); 126957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (const CXXOperatorCallExpr *CXXCE = 127013bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian dyn_cast_or_null<CXXOperatorCallExpr>(callExpr)) 127113bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian if (const FunctionDecl *FuncDecl = CXXCE->getDirectCallee()) 127257e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (!FuncDecl->isTrivial()) 127320abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian if (property->getType()->isReferenceType()) { 12749a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman Diag(PropertyDiagLoc, 127520abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::err_atomic_property_nontrivial_assign_op) 127657e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian << property->getType(); 127720abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian Diag(FuncDecl->getLocStart(), 127820abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::note_callee_decl) << FuncDecl; 127920abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian } 128057e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian } 128117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 128217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 128317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 128417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 128528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 128628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 128728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 128828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 128928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 129028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 129128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 129228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 129328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 129428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 129528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 129628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 129728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 129828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1299d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 130028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 130128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 13024e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCDefaultSynthProperties && 1303260611a32535c851237926bfcf78869b13c07d5bJohn McCall getLangOpts().ObjCRuntime.isNonFragile() && 130471207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek !IDecl->isObjCRequiresPropertyDefs()) { 1305ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 1306ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 1307cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 1308411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 1309ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 1310ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 1311ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1312ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 1313ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 1314ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1315ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1316cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 1317cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 131860ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor declaresSameEntity(IC->getClassInterface(), ClassDeclared)) { 1319ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 1320ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 1321ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 1322ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1323ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 132428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 132528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 132628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 132728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 1328e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_duplicate_ivar_use) 132928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 133028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 133128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 133228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 133328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 133428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 133528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 1336e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_implemented) << PropertyId; 133728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1338d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 133928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 134028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 134128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 134228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 1343d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 134428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 134528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 134628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 134728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 134828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 134928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 13509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 13539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13549d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 13609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 13619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 13629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 13639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 13649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 13659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 13669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 13679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 13689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 13691b46d8d78be713c546fb9680eaeea8f793bee5bfFariborz Jahanian else if (!(SAttr & ObjCPropertyDecl::OBJC_PR_readonly)){ 1370f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 1371f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 1372f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1373f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 1374f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 1375f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1376f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 1377f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 1378f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 1379f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 1380f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 1381f85e193739c953358c865005855253af4f68a497John McCall } 13829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 1384b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 13859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 13869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 1387b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 1388b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian } 1389b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian if (Property->getSetterName() != SuperProperty->getSetterName()) { 13909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 13919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 1392b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 1393b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian } 1394b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian if (Property->getGetterName() != SuperProperty->getGetterName()) { 13959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 13969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 1397b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 1398b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian } 13999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 14019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 14029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 14039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 14049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1405c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 14068beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 14078beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 14088beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 14098beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 14108beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 14118beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 141213546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian IncompatibleObjC) { 14138beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 14148beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 141513546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 141613546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian } 14179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 14219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 14229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 14239abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!GetterMethod) 14249abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return false; 14259abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType GetterType = GetterMethod->getResultType().getNonReferenceType(); 14269abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType PropertyIvarType = property->getType().getNonReferenceType(); 14279abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian bool compat = Context.hasSameType(PropertyIvarType, GetterType); 14289abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 14299abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) && 14309abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian isa<ObjCObjectPointerType>(GetterType)) 14319abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = 14329abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Context.canAssignObjCInterfaces( 1433490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian GetterType->getAs<ObjCObjectPointerType>(), 1434490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>()); 1435490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian else if (CheckAssignmentConstraints(Loc, GetterType, PropertyIvarType) 14369abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian != Compatible) { 14379abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::error_property_accessor_type) 14389abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() << PropertyIvarType 14399abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector() << GetterType; 14409abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 14419abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 14429abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } else { 14439abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = true; 14449abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 14459abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType rhsType =Context.getCanonicalType(GetterType).getUnqualifiedType(); 14469abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (lhsType != rhsType && lhsType->isArithmeticType()) 14479abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = false; 14489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14509abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 14519abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 14529abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::warn_accessor_property_type_mismatch) 14539abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() 14549abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector(); 14559abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 14569abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 14579abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } 14589abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 14599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 14630dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor/// the class and its conforming protocols; but not those in its super class. 14649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1465e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCContainerDecl::PropertyMap &PropMap, 1466e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCContainerDecl::PropertyMap &SuperPropMap) { 14679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 14689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 14699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 1470581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 14719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 14729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 147453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 147553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 147653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1477cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 14809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 14819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 14829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 1483581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 14849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 14859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 148753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 14889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1489cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 14929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 14939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1494581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1495cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1496cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1497cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1498a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian if (!PropertyFromSuper || 1499a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian PropertyFromSuper->getIdentifier() != Prop->getIdentifier()) { 1500cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1501cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1502cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1503cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 15049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 15069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 15079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1508cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 15099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 15119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1512509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1513509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1514509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1515509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1516e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCInterfaceDecl::PropertyMap &PropMap) { 1517509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1518cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian ObjCInterfaceDecl::PropertyDeclOrder PO; 1519509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1520cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian SDecl->collectPropertiesToImplement(PropMap, PO); 1521509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1522509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1523509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1524509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1525509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 152626202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian/// IvarBacksCurrentMethodAccessor - This routine returns 'true' if 'IV' is 152726202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian/// an ivar synthesized for 'Method' and 'Method' is a property accessor 152826202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian/// declared in class 'IFace'. 152926202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanianbool 153026202291b161f8598c0c342cba12c6552e44d44cFariborz JahanianSema::IvarBacksCurrentMethodAccessor(ObjCInterfaceDecl *IFace, 153126202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian ObjCMethodDecl *Method, ObjCIvarDecl *IV) { 153226202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian if (!IV->getSynthesize()) 153326202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian return false; 153426202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian ObjCMethodDecl *IMD = IFace->lookupMethod(Method->getSelector(), 153526202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian Method->isInstanceMethod()); 153626202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian if (!IMD || !IMD->isPropertyAccessor()) 153726202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian return false; 153826202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian 153926202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian // look up a property declaration whose one of its accessors is implemented 154026202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian // by this method. 154126202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IFace->prop_begin(), 154226202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian E = IFace->prop_end(); P != E; ++P) { 154326202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian ObjCPropertyDecl *property = *P; 154426202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian if ((property->getGetterName() == IMD->getSelector() || 154526202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian property->getSetterName() == IMD->getSelector()) && 154626202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian (property->getPropertyIvarDecl() == IV)) 154726202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian return true; 154826202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian } 154926202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian return false; 155026202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian} 155126202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian 155226202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian 1553699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// \brief Default synthesizes all properties which must be synthesized 1554699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// in class's \@implementation. 1555d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekvoid Sema::DefaultSynthesizeProperties(Scope *S, ObjCImplDecl* IMPDecl, 1556d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ObjCInterfaceDecl *IDecl) { 1557509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1558b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCInterfaceDecl::PropertyMap PropMap; 1559cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian ObjCInterfaceDecl::PropertyDeclOrder PropertyOrder; 1560cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian IDecl->collectPropertiesToImplement(PropMap, PropertyOrder); 1561509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1562509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1563b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCInterfaceDecl::PropertyMap SuperPropMap; 1564509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1565509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1566cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian for (unsigned i = 0, e = PropertyOrder.size(); i != e; i++) { 1567cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian ObjCPropertyDecl *Prop = PropertyOrder[i]; 15686071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian // Is there a matching property synthesize/dynamic? 15696071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian if (Prop->isInvalidDecl() || 15706071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional) 15716071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian continue; 15726071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian // Property may have been synthesized by user. 15736071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 15746071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian continue; 15756071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 15766071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 15776071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian continue; 15786071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 15796071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian continue; 15806071af93f9b3c5a361c2f11566003d729418be3dFariborz Jahanian } 1581509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 15826114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) { 15836114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian ObjCPropertyDecl *PropInSuperClass = SuperPropMap[Prop->getIdentifier()]; 15846114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian if ((Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readwrite) && 15856114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian (PropInSuperClass->getPropertyAttributes() & 15861d0d2fe76496ee2f8da9f56cb7f7eb24c4ffba05Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_readonly) && 15875bdaef55d486f20346fe16f3d41324694d3ff0d5Fariborz Jahanian !IMPDecl->getInstanceMethod(Prop->getSetterName()) && 15885bdaef55d486f20346fe16f3d41324694d3ff0d5Fariborz Jahanian !IDecl->HasUserDeclaredSetterMethod(Prop)) { 15896114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian Diag(Prop->getLocation(), diag::warn_no_autosynthesis_property) 15906114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian << Prop->getIdentifier()->getName(); 15916114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian Diag(PropInSuperClass->getLocation(), diag::note_property_declare); 15926114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian } 1593509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 15946114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian } 1595a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian if (ObjCPropertyImplDecl *PID = 1596a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) { 1597a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian if (PID->getPropertyDecl() != Prop) { 1598a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian Diag(Prop->getLocation(), diag::warn_no_autosynthesis_shared_ivar_property) 1599a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian << Prop->getIdentifier()->getName(); 1600a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian if (!PID->getLocation().isInvalid()) 1601a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian Diag(PID->getLocation(), diag::note_property_synthesize); 1602a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian } 1603a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian continue; 1604a6ba40c1e573aee7882baa804e596e243b9c4e2aFariborz Jahanian } 1605f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian if (isa<ObjCProtocolDecl>(Prop->getDeclContext())) { 1606f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian // We won't auto-synthesize properties declared in protocols. 1607f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(IMPDecl->getLocation(), 1608f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian diag::warn_auto_synthesizing_protocol_property); 1609f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(Prop->getLocation(), diag::note_property_declare); 1610f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian continue; 1611f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian } 16122a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 16132a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 16142a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 16152a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 16162a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 1617975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ObjCPropertyImplDecl *PIDecl = dyn_cast_or_null<ObjCPropertyImplDecl>( 1618975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1619975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian true, 1620975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian /* property = */ Prop->getIdentifier(), 1621ad0ce53c8219456938405b84c5d13341a47e3d94Anna Zaks /* ivar = */ Prop->getDefaultSynthIvarName(Context), 1622390fff8e8b480fa146ffc14cbc63a1c2f9e2d206Argyrios Kyrtzidis Prop->getLocation())); 1623975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian if (PIDecl) { 1624975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian Diag(Prop->getLocation(), diag::warn_missing_explicit_synthesis); 16255ea66619a3108e2985e952b9a60a84316d464b25Fariborz Jahanian Diag(IMPDecl->getLocation(), diag::note_while_in_implementation); 1626975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian } 16272a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1628509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 16299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16308697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 1631260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (!LangOpts.ObjCDefaultSynthProperties || LangOpts.ObjCRuntime.isFragile()) 16328697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 16338697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 16348697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 16358697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 16368697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 163771207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (!IDecl->isObjCRequiresPropertyDefs()) 1638eb4f2c56c298071d58b441ccf801b039be93788aFariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 16398697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 16408697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 164117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 1642c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian ObjCContainerDecl *CDecl) { 1643277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian ObjCContainerDecl::PropertyMap NoNeedToImplPropMap; 1644277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian ObjCInterfaceDecl *IDecl; 1645277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // Gather properties which need not be implemented in this class 1646277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // or category. 1647277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (!(IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl))) 1648277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) { 1649277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // For categories, no need to implement properties declared in 1650277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // its primary class (and its super classes) if property is 1651277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // declared in one of those containers. 1652cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian if ((IDecl = C->getClassInterface())) { 1653cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian ObjCInterfaceDecl::PropertyDeclOrder PO; 1654cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian IDecl->collectPropertiesToImplement(NoNeedToImplPropMap, PO); 1655cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian } 1656277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian } 1657277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (IDecl) 1658277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, NoNeedToImplPropMap); 1659cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 1660b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCContainerDecl::PropertyMap PropMap; 1661277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, NoNeedToImplPropMap); 16629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 16639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 16649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 16669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 16679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 16689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 1669262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie PropImplMap.insert(I->getPropertyDecl()); 16709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1671c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian SelectorSet InsMap; 1672c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // Collect property accessors implemented in current implementation. 1673c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian for (ObjCImplementationDecl::instmeth_iterator 1674c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian I = IMPDecl->instmeth_begin(), E = IMPDecl->instmeth_end(); I!=E; ++I) 1675c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian InsMap.insert((*I)->getSelector()); 1676c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian 1677c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl); 1678c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian ObjCInterfaceDecl *PrimaryClass = 0; 1679c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if (C && !C->IsClassExtension()) 1680c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if ((PrimaryClass = C->getClassInterface())) 1681c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // Report unimplemented properties in the category as well. 1682c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if (ObjCImplDecl *IMP = PrimaryClass->getImplementation()) { 1683c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // When reporting on missing setter/getters, do not report when 1684c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // setter/getter is implemented in category's primary class 1685c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // implementation. 1686c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian for (ObjCImplementationDecl::instmeth_iterator 1687c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian I = IMP->instmeth_begin(), E = IMP->instmeth_end(); I!=E; ++I) 1688c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian InsMap.insert((*I)->getSelector()); 1689c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian } 1690c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian 1691b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks for (ObjCContainerDecl::PropertyMap::iterator 16929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 16939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 16949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 16959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 16969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 16977cdc45751cb5b200ad5fff0de28c5d1a64b6fce3Douglas Gregor PropImplMap.count(Prop) || 16987cdc45751cb5b200ad5fff0de28c5d1a64b6fce3Douglas Gregor Prop->getAvailability() == AR_Unavailable) 16999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 1700c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // When reporting on missing property getter implementation in 1701c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // categories, do not report when they are declared in primary class, 1702c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // class's protocol, or one of it super classes. This is because, 1703c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // the class is going to implement them. 1704c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if (!InsMap.count(Prop->getGetterName()) && 1705c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian (PrimaryClass == 0 || 1706f3f0f357f8d6b4511b6d605cc8a39ae3787fef6dFariborz Jahanian !PrimaryClass->lookupPropertyAccessor(Prop->getGetterName(), C))) { 1707b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 17089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 17099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 17109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 17119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1712b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1713b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1714260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1715da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 171671207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1717da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 1718da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian 17199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 1720c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // When reporting on missing property setter implementation in 1721c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // categories, do not report when they are declared in primary class, 1722c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // class's protocol, or one of it super classes. This is because, 1723c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // the class is going to implement them. 1724c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName()) && 1725c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian (PrimaryClass == 0 || 1726f3f0f357f8d6b4511b6d605cc8a39ae3787fef6dFariborz Jahanian !PrimaryClass->lookupPropertyAccessor(Prop->getSetterName(), C))) { 1727b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 17289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 17299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 17309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 17319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1732b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1733b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1734260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1735da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 173671207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1737da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 17389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 17419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 17439d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 17449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 17459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 17464e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC) 17479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 17489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 17499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 17509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 1751581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Property = *I; 175294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 175394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 175494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 175594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1756ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = Property->getPropertyAttributes(); 1757265941bc308d65cc270d5c4de5806f37ce405606John McCall unsigned AttributesAsWritten = Property->getPropertyAttributesAsWritten(); 175894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1759265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic) && 1760265941bc308d65cc270d5c4de5806f37ce405606John McCall !(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 176194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 176294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 176394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 176494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 176594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 176694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1767293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 176894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 176994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 177094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 177194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 177294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1773293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 177494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 177594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 177694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 177794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 17789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 1779ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 1780ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 17819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 17829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 17839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 17849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 17859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 178694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 178794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 178894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 178994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 179094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 17919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 17929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 17939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 17949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 17959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 17967d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << Property->getIdentifier() << (GetterMethod != 0) 17977d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << (SetterMethod != 0); 179877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // fixit stuff. 179977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (!AttributesAsWritten) { 180077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (Property->getLParenLoc().isValid()) { 180177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 180277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), 180377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getLParenLoc()); 180477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 180577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic"); 180677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 180777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else { 180877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian //@property id etc. 180977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = 181077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getTypeSourceInfo()->getTypeLoc().getBeginLoc(); 181177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian endLoc = endLoc.getLocWithOffset(-1); 181277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 181377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 181477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic) "); 181577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 181677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 181777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic)) { 181877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 181977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = Property->getLParenLoc(); 182077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 182177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 182277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic, "); 182377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 182477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else 182577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(MethodLoc, diag::note_atomic_property_fixup_suggest); 18269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 18279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 18319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1832f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 18334e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::GCOnly) 1834f85e193739c953358c865005855253af4f68a497John McCall return; 1835f85e193739c953358c865005855253af4f68a497John McCall 1836f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1837f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1838581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyImplDecl *PID = *i; 1839f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1840f85e193739c953358c865005855253af4f68a497John McCall continue; 1841f85e193739c953358c865005855253af4f68a497John McCall 1842f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1843831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1844831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1845f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1846f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1847f85e193739c953358c865005855253af4f68a497John McCall continue; 1848f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1849f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1850f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 18514e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1852f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1853f85e193739c953358c865005855253af4f68a497John McCall else 1854920c9c1155c118ac40e5209d4b757b9f54186339Ted Kremenek Diag(PID->getLocation(), diag::warn_owning_getter_rule); 1855f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1856f85e193739c953358c865005855253af4f68a497John McCall } 1857f85e193739c953358c865005855253af4f68a497John McCall } 1858f85e193739c953358c865005855253af4f68a497John McCall } 1859f85e193739c953358c865005855253af4f68a497John McCall} 1860f85e193739c953358c865005855253af4f68a497John McCall 18615de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 18625de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 18635de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 18645de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 18655de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 18660a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 18670a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 18680a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 18690a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 18700a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 18710a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 18720a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 18730a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 18745de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 18755de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 18769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 18779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 18789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 18799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 18809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 18819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 18828254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 18838254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 18848254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 18858254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 18869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 18879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 18889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 18899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 18909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 18919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 18929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 18939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 18949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 18959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 18969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 18979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 18989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 18999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 19009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 19012aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian !Context.hasSameUnqualifiedType( 1902bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian (*SetterMethod->param_begin())->getType().getNonReferenceType(), 1903bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian property->getType().getNonReferenceType())) { 19049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 19059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 19069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 19079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 19089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 19099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 19109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 19119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 19139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 19149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 19159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 19169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 19179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 19189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 19199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 19209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 19219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1922a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1923a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1924a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1925a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1926a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1927a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 192875cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 19291e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose /*isVariadic=*/false, /*isPropertyAccessor=*/true, 193075cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 19319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 19329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 19339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 19349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 19359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 19365de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 19375de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 19385de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 193923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 194023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1941a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 194223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1943831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1944831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1945831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 1946937ec1d9575ec455bc2d4e1f159f64980b476196Fariborz Jahanian 1947937ec1d9575ec455bc2d4e1f159f64980b476196Fariborz Jahanian if (property->hasAttr<ObjCReturnsInnerPointerAttr>()) 1948937ec1d9575ec455bc2d4e1f159f64980b476196Fariborz Jahanian GetterMethod->addAttr( 1949937ec1d9575ec455bc2d4e1f159f64980b476196Fariborz Jahanian ::new (Context) ObjCReturnsInnerPointerAttr(Loc, Context)); 1950b846381fc3099b2340ba8c74d16178203a60d9a0John McCall 1951b846381fc3099b2340ba8c74d16178203a60d9a0John McCall if (getLangOpts().ObjCAutoRefCount) 1952b846381fc3099b2340ba8c74d16178203a60d9a0John McCall CheckARCMethodDecl(GetterMethod); 19539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 19549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 19559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 19561e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose GetterMethod->setPropertyAccessor(true); 19579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 19589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 19609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 19619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 19629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 19639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 19649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 19659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 19668254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 19678254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 19688254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 19698254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 19708254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 1971491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ObjCMethodDecl::Create(Context, Loc, Loc, 19728254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 197375cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 19741e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose /*isPropertyAccessor=*/true, 197575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 197675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 19779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 19789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 19798254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 19808254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 19818254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 19829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 19839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1984ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1985ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 19869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1987f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 19889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1989d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 19909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 19915543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko SetterMethod->setMethodParams(Context, Argument, None); 19925de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 19935de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 19945de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 19959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 199623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 199723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 19988254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 199923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 2000b846381fc3099b2340ba8c74d16178203a60d9a0John McCall 2001b846381fc3099b2340ba8c74d16178203a60d9a0John McCall // It's possible for the user to have set a very odd custom 2002b846381fc3099b2340ba8c74d16178203a60d9a0John McCall // setter selector that causes it to have a method family. 2003b846381fc3099b2340ba8c74d16178203a60d9a0John McCall if (getLangOpts().ObjCAutoRefCount) 2004b846381fc3099b2340ba8c74d16178203a60d9a0John McCall CheckARCMethodDecl(SetterMethod); 20059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 20069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 20079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 20081e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose SetterMethod->setPropertyAccessor(true); 20099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 20109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 20119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 20129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 20139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 20159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 20169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 20179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 20199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 20209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 20219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 20229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 20249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 20259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 20269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 2027e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis 2028e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(CD); 2029e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (!CurrentClass) { 2030e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(CD)) 2031e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Cat->getClassInterface(); 2032e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(CD)) 2033e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Impl->getClassInterface(); 2034e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis } 2035e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (GetterMethod) 2036e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(GetterMethod, CurrentClass, Sema::RTC_Unknown); 2037e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (SetterMethod) 2038e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(SetterMethod, CurrentClass, Sema::RTC_Unknown); 20399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 20409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2041d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 20429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 2043ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned &Attributes, 2044cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian bool propertyInPrimaryClass) { 20459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 2046f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 20475fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 20485fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 20495fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 2050842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 20519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 20524e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2053ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2054015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian PropertyTy->isObjCRetainableType()) { 2055015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // 'readonly' property with no obvious lifetime. 2056015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // its life time will be determined by its backing ivar. 2057015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian unsigned rel = (ObjCDeclSpec::DQ_PR_unsafe_unretained | 2058015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 2059015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 2060015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong | 2061015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_weak | 2062015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_assign); 2063ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & rel) == 0) 2064015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 2065015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 2066015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 2067cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (propertyInPrimaryClass) { 2068cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // we postpone most property diagnosis until class's implementation 2069cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // because, its readonly attribute may be overridden in its class 2070cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // extensions making other attributes, which make no sense, to make sense. 2071ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2072ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readwrite)) 2073cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2074cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << "readwrite"; 2075cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 20769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 2077ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2078ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 207928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 2080f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 208128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 2082f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 2083f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 2084ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 208528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 2086ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 208728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 2088ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 2089f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 2090ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 209128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 20929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2093ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 209428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 209528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 209628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 209728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 20989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 209928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 2100ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2101f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 2102f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 2103842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 210428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 2105ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 2106ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 2107ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2108f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 2109977ea7864a50eee39f6bef8a5a79154ac9ba4b3eJohn McCall PropertyDecl->setInvalidDecl(); 211028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 211228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 2113ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 2114ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 211528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 211628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 2117ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 211828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2119ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 212028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 212128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 2122ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 212328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2124ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2125f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2126f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 2127ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2128f85e193739c953358c865005855253af4f68a497John McCall } 21294e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2130ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2131f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2132f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 2133ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2134f85e193739c953358c865005855253af4f68a497John McCall } 2135548fba96250b6624a96459780e30fd459eed1528Fariborz Jahanian if (PropertyDecl->getAttr<IBOutletCollectionAttr>()) 2136548fba96250b6624a96459780e30fd459eed1528Fariborz Jahanian Diag(Loc, diag::warn_iboutletcollection_property_assign); 2137ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 2138ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2139f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2140f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 2141ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 2142f85e193739c953358c865005855253af4f68a497John McCall } 2143ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 2144f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2145f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 2146ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2147f85e193739c953358c865005855253af4f68a497John McCall } 2148ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2149f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2150f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 2151ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2152f85e193739c953358c865005855253af4f68a497John McCall } 21534e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2154ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2155f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2156f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 2157ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2158f85e193739c953358c865005855253af4f68a497John McCall } 2159ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2160ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 216128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 216228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 2163ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 216428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2165ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2166f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2167f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 2168ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2169f85e193739c953358c865005855253af4f68a497John McCall } 2170ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 2171f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2172f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 2173ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2174f85e193739c953358c865005855253af4f68a497John McCall } 2175f85e193739c953358c865005855253af4f68a497John McCall } 2176ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2177ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2178f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2179f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 2180ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2181f85e193739c953358c865005855253af4f68a497John McCall } 2182ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 2183ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2184f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2185f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 2186ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 218728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2189ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_atomic) && 2190ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)) { 21919d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 21929d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian << "atomic" << "nonatomic"; 2193ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_atomic; 21949d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian } 21959d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian 219628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 219728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 2198ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 2199f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 2200f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 2201f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 220228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 22034e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 2204bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 2205f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian // not specified; including when property is 'readonly'. 2206bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 2207ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if (!(Attributes & ObjCDeclSpec::DQ_PR_readonly)) { 22089f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian bool isAnyClassTy = 22099f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian (PropertyTy->isObjCClassType() || 22109f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian PropertyTy->isObjCQualifiedClassType()); 22119f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // In non-gc, non-arc mode, 'Class' is treated as a 'void *' no need to 22129f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // issue any warning. 22134e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (isAnyClassTy && getLangOpts().getGC() == LangOptions::NonGC) 22149f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian ; 2215f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian else if (propertyInPrimaryClass) { 2216f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian // Don't issue warning on property with no life time in class 2217f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian // extension as it is inherited from property in primary class. 2218bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 22194e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::GCOnly) 2220bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 22210a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 2222bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 22234e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::NonGC) 2224bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 22259f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian } 2226bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 22279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 222828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 222928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 223028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 223128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 223228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 22339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2234ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 2235ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 22364e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie && getLangOpts().getGC() == LangOptions::GCOnly 223728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 223828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 2239ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2240ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2241ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 2242528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian PropertyTy->isBlockPointerType()) 2243528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Diag(Loc, diag::warn_objc_property_retain_of_block); 224448a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 2245ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2246ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_setter)) 224748a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian Diag(Loc, diag::warn_objc_readonly_property_has_setter); 224848a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 22499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 2250