SemaObjCProperty.cpp revision 94659e4bdb87534f591ae185812548c42d6efacb
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1950df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 28d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 29d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 30d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 31d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 32d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassCategory, 33d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 344a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 354a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 3628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 3728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 3828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 3928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 4028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 4128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 4228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 4328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 4428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 4528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_copy))); 46e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 47bf1a028246d884a540aeafa38e89be59a269b072John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 48bf1a028246d884a540aeafa38e89be59a269b072John McCall QualType T = TSI->getType(); 4928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isReferenceType()) { 5028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_reference_property); 51d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 5228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 53e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 54e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *ClassDecl = 55d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall cast<ObjCContainerDecl>(ClassCategory); 56e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 5728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 58ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 59d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *Res = HandlePropertyInClassExtension(S, CDecl, AtLoc, 60ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 61ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 62ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 63ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 64ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 65ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (Res) 66ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 67ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 68ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 69ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 70d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 71d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall GetterSel, SetterSel, 72d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall isAssign, isReadWrite, 73d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Attributes, TSI, MethodImplKind); 744a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 754a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 764a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 77842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 78842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 79842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 80e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 81e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 82d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 83e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekSema::HandlePropertyInClassExtension(Scope *S, ObjCCategoryDecl *CDecl, 84e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 85e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 86e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 87e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 88e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 89e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 9083a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 91e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 92e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 93e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 94e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 95e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 962a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 972a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 982a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 992a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 1002a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 1012a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 1022a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 1032a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 1042a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 1052a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 1062a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 1072a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 1082a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 1092a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1102a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1112a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 112e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 113e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 11488f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 115e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 116e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 117e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 11822f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 11922f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 12022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 12122f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 12288f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 12388f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 12488f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 125e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 126e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 127e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 128e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 129e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 130e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 131e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 132d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 133e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 134e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 135e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 136e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 137e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 138e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 139e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 140e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 141e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 143e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 144e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 14523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek Attributes, T, MethodImplKind, DC); 14680aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // Mark written attribute as having no attribute because 14780aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // this is not a user-written property declaration in primary 14880aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // class. 14980aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian PDecl->setPropertyAttributesAsWritten(ObjCPropertyDecl::OBJC_PR_noattr); 150e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 151e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 152e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 153e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 154a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek ProcessPropertyDecl(PDecl, CCPrimary, /* redeclaredProperty = */ 0, 155a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 156d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PDecl; 157e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 158e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 159e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 160e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 16180aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 162e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 163e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 164e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 165e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 166e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 167e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 169e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 170e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 171e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 1729944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 1739944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 1749944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 175e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 176e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 177e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 178e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 179e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 180e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 183e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 184d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 185e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 186e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 187e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 188d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CCPrimary, isOverridingProperty, 1894a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 1904a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 191d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 19228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 193e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 194e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 195e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 196e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 197e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 198e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 199e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 200788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 201788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 202788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 203788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 204788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 205788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 206788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 207788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 208788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 209788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 210e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 211e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 212e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 213e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 214e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 2158254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 216d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 217e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 218e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 219e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 220e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 221e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 222e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 223e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 224e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 225e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 226e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 227e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 22883a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 22923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 23023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 231e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 23283a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 23328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 23428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 23528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 23628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC && 23728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 238c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 239c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 240c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 241c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 242c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 243c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 244c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 245c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 24628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 247c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 24828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 24928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 250e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 25128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 25228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 25383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 254e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 2559f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 2569f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 25728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 258894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 25928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 26028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 26123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 26228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 26323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 26423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 26523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 26628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 26828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 26928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 27028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 27128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 27328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 27528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 27628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 27728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 27828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 28028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 28128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 28328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 28428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 28628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 28728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 28928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 29028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 29128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 29228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 29328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 29428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 29528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 29628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 29728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 29828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 29928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 30028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 30128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 302dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 303dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 30428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 30580aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian PDecl->setPropertyAttributesAsWritten(PDecl->getPropertyAttributes()); 30680aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian 30728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 30828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 30928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 31028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 31128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 312e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 31328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 31428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 31528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 31628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 31728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 31828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 31928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 320d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 321d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 322d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 323d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 324d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassCatImpDecl, 325d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 326a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 327a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 328e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 329d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall cast_or_null<ObjCContainerDecl>(ClassCatImpDecl); 33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 33128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 33228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 333d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 33428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 33528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 33628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 33728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 33828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 33928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 34028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 34128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 34228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 34328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 34428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 34528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 34628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 34728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 34828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 34928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 35028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 35128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 352d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 35328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 354dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 355dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 356dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 357dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 358dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 359dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 360dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 361dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 362dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 363dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 36428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 36528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 36728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 36828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 369d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 37128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 37228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 37328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 37428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 375d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 37628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 37728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 37828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 37928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 380d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 38128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 38228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 38328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 38428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 38528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 38628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 38728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 388d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 38928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 39028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 39128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 39228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 39328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 394d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 39528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 39628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 39728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 398d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 39928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 40028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 40128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 40228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 40328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 40428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 40528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 40628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType PropType = Context.getCanonicalType(property->getType()); 40728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 40928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 41028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 41129fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, PropertyLoc, 41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar, PropType, /*Dinfo=*/0, 4137504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 414ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 41529fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 41628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 41728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 41828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 41928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 42028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 42128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 42228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 42328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 42428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 42528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 42628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 42728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 42828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 4294087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 43028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 43128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 43228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 43328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 43428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 43528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (PropType != IvarType) { 43662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 43762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (isa<ObjCObjectPointerType>(PropType) 43862ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian && isa<ObjCObjectPointerType>(IvarType)) 43962ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 44062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 44162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian PropType->getAs<ObjCObjectPointerType>(), 44262ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 443b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 444b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor SourceLocation Loc = PropertyIvarLoc; 445b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor if (Loc.isInvalid()) 446b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor Loc = PropertyLoc; 447b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor compat = (CheckAssignmentConstraints(Loc, PropType, IvarType) 448daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 449b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 45062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 45128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 452f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 453f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 454f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 45528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 45628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 45728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 45828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 45928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 46028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 46128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 46228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType lhsType =Context.getCanonicalType(PropType).getUnqualifiedType(); 46328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 46428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 46528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 46628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 467f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 468f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 469f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 47028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 47128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 47228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 47328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 47428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 47528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 47628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 47728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 47828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 47928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 48028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 48128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 48228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 48328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 48428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 48528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 48628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 48728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 48828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 48928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 49028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 49128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 49228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 49328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 49428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 49528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 49628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 497a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 49817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 49917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 5000313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize && 5010313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 50217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 50317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 50417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 50517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 50617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 507f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 508f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 50917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 51017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 51117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 51260d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 51317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 5143c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 5153c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 5163c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 51717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 51817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 51917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 52017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 52117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 5224765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 52317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 52417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 52517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 52617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 52717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 52817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 5290313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize 5300313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian && Ivar->getType()->isRecordType()) { 53117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 53217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 53317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 534f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 535f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 53617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 53717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 53817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 53917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 54017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 541f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall Expr *rhs = new (Context) DeclRefExpr(Param, Param->getType(), 542f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 543fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 5442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 54517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 54617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 54717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 54817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 54928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 55028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 55128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 55228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 55328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 55428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 55628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 55728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 55828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 55928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 563d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 56428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 566e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian if (getLangOptions().ObjCDefaultSynthProperties && 567e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian getLangOptions().ObjCNonFragileABI2) { 568ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 569ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 570cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 571411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 572ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 573ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 574ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 575ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 576ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 577ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 578ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 579cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 580cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 581cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian IC->getClassInterface() == ClassDeclared) { 582ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 583ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 584ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 585ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 586ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 58728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 58828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 58928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 59028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 59128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 59228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 59328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 59428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 59528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 59628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 59728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 59828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 59928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 60028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 601d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 60228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 60328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 60428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 60528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 606d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 60728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 60828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 60928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 61028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 61128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 61228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 6139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 6149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 6159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 6169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 6179d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 6189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 6199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 6209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 6219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 6229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 6239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 6249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 6259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 6269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 6279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 6289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 6299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 6309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 6319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 6329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain) 6339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_retain)) 6349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 6359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "retain" << inheritedName; 6369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 6389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 6399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 6409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 6419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 6429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 6439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 6449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 6459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 6469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 6479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 6499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 6509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 6519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 6529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Context.typesAreCompatible(LHSType, RHSType)) { 6549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Incorporate this test with typesAreCompatible. 6559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType()) 6569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Context.ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false)) 6579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 6589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 6599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getType() << SuperProperty->getType() << inheritedName; 6609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 6649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 6659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 6669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 6679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->getResultType() != property->getType()) { 6689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 6691c23e91ef66688d20868b6bab3b5589a119eb603John McCall if (property->getType()->isObjCObjectPointerType()) 670b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor result = CheckAssignmentConstraints(Loc, GetterMethod->getResultType(), 6711c23e91ef66688d20868b6bab3b5589a119eb603John McCall property->getType()); 6729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 6739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 6749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 6759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 6769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 6779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 6789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 6849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 6859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// diagnostics in a variety of inconsistant situations. 6869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 6879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 6889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 6899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 6909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 6919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 6929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 6939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 6949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 6959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 6969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 6979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 6989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 6999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 7009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 7019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 7029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 7079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 7089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 7099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 7109d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 7119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 7129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 7139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 7149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 7159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 7169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 7179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 7189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 7199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 7209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 7219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 7229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 7232d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 7249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 7259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 7269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 7279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 7289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 7299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 7319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 7339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 7349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 7359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 7369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 7379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 7389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 7399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 7409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 7419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 7429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 7439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 7479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 7489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 7499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 750d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 751d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 7529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 7539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 7559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 7569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 7579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 7589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 7599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 7609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 7619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 7629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 7639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 7659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 7669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 7679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 768d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 7699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 7709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 7719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 7729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 7739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 7749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 7769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 77953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 78053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 78153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 7829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 7839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 7849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 7869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 78753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 78853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 78953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 790d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 7919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 7929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 7939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 7949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 7959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 7969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 8009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 8019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 8029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 8039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 8049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 8059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 8069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 8079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 8089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 8099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 8109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 8119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 8139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 8149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 8159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 8169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 8179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 8189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 8199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 8209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 8219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 8229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 8239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 8249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 8259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 8289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 8299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 8309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 8319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 8329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 8339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 8349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 8359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 8369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 8379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 8389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 8419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 8429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 8439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 8449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 8459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 8469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 8479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 8489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 8499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 8519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 8529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 853cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 854cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 8559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 8569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 8579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 8589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 8599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 8609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 86253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 86353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 86453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 865cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 8669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 8689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 8699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 8709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 8719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 8729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 8739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 87553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 8769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 877cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 8789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 8809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 8819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 8829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 883cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 884cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 885cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 886cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropertyFromSuper || PropertyFromSuper != Prop) { 887cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 888cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 889cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 890cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 8919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 8939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 8949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 895cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 8969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 8989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 899509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 900509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 901509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 902509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 903509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 904509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 905509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 906509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 907509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 908509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 909509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 91053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 91153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 91253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 913509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 914509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 915509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 916509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 917509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 918509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 919509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 920509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 921509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 922509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 923509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 924509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 925509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 926509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 927509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 928509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 929509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 930509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 931509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 932509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 933509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 934509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 935509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 936509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 937509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 938509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 939509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 940509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 9419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 9439d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 9469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 9479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 9489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 9499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 9509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 9519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 95453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 95553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 95653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 9579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 9589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 9649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 9659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 9669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 9679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 981509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 982509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 983509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties (Scope *S, ObjCImplDecl* IMPDecl, 984509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCInterfaceDecl *IDecl) { 985509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 986509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 987509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 988509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 989509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 990509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 991509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 992509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 993509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 994509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 995509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 996509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 997509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 998509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 999509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1000509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1001509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1002509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1003509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1004d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1005d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1006d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 100795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 100895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 100995f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 101095f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 101195f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 101295f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1013d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian 10142a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 10152a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 10162a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 10172a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 10182a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 10192a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 10202a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek true,IMPDecl, 1021a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Prop->getIdentifier(), Prop->getIdentifier(), 1022a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation()); 10232a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1024509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 102617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 1029cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1030cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1031cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1032cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1034cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 10459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 10469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 10479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 10509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.count(Prop)) 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 10559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 10569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 10679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 10709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 10759d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC) 10799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 108494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 108594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 108694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 108794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 10889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 108994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis unsigned AttributesAsWrittern = Property->getPropertyAttributesAsWritten(); 109094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 109194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!(AttributesAsWrittern & ObjCPropertyDecl::OBJC_PR_atomic) && 109294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis !(AttributesAsWrittern & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 109394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 109494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 109594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 109694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 109794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 109894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 109994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis << Property->getIdentifier(); 110094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 110194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 110294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 110394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 110494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 110594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis << Property->getIdentifier(); 110694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 110794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 110894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 110994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 11169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 111894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 111994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 112094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 112194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 112294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 11259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 11269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 11279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 11289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getIdentifier(); 11299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 11309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11355de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 11365de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 11375de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 11385de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 11395de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 11405de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall if (DeprecatedAttr *A = Property->getAttr<DeprecatedAttr>()) 11415de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall PropertyMethod->addAttr(A->clone(S.Context)); 11425de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall if (UnavailableAttr *A = Property->getAttr<UnavailableAttr>()) 11435de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall PropertyMethod->addAttr(A->clone(S.Context)); 11445de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 11455de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 11469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 11479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 11489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 11499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 11509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 11519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 11528254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 11538254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 11548254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 11558254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 11569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 11579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 11599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 11609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 11619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 11649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 11659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 11669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 11679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 11689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 11699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 11709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 11719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ((*SetterMethod->param_begin())->getType() != property->getType())) { 11729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 11739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 11749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 11759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 11769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 11779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 11819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 11829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 11839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 11849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 11859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 11869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 11879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 11889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 11899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1190a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1191a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1192a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1193a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1194a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1195a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 11963fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian property->getType(), 0, CD, true, false, true, 11973fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian false, 11989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 11999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 12009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 12019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 12029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 12035de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 12045de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 12055de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 120623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 120723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1208a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 120923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 12109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 12119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 12129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 12139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 12149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 12159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 12179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 12189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 12199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 12209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 12219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 12229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 12238254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 12248254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 12258254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 12268254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 12278254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 12288254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Create(Context, Loc, Loc, 12298254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 12308254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek CD, true, false, true, false, 12319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 12329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 12338254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 12348254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 12358254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 12369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 12379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 12388254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, Loc, 12399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 12409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType(), 12419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1242d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1243d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 12449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 12454ecb25fa94897b2c03510292acace710e5262ba5Fariborz Jahanian SetterMethod->setMethodParams(Context, &Argument, 1, 1); 12465de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 12475de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 12485de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 12499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 125023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 125123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 12528254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 125323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 12549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 12559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 12569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 12579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 12589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 12599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 12619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 12629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 12639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 12649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 12659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 12669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 12679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 12689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 12699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 12709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 12719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 12729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 12739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 12749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 12759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 12769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1278d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 12799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 12809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 12819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 12825fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek if (!PDecl) 12835fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 12845fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 12855fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1286842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 12879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 12899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 129028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 129128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 129228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 129328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_retain))) { 129428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 129528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 129628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 129728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 129828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 129928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 13009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 130128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 130228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 130328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 130428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 130528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 13069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 130728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 130828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) && 130928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !PropertyTy->isObjCObjectPointerType() && 131028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !PropertyTy->isBlockPointerType() && 1311842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !Context.isObjCNSObjectType(PropertyTy) && 1312842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 131328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 131428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << (Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain"); 131528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain); 131628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 13179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 131828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 131928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 132028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 132128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 132228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 132328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 132428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 132528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 132628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 132728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 132828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 132928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 133028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 133128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 133228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 133328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 133428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 133528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 133628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 13379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 133828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 133928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 134028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 134128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_retain)) && 134228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 134328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 134428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Skip this warning in gc-only mode. 134528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::GCOnly) 134628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 13479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 134828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If non-gc code warn that this is likely inappropriate. 134928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() == LangOptions::NonGC) 135028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_default_assign_on_object); 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 135228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 135328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 135428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 135528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 135628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 135828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 13592b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 136028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && getLangOptions().getGCMode() == LangOptions::GCOnly 136128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 136228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 13639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1364