SemaObjCProperty.cpp revision a28948f34817476d02412fa204cae038e228c827
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1950df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 28f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 29f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 30f85e193739c953358c865005855253af4f68a497John McCall 31f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 32f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 33f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 34f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 35f85e193739c953358c865005855253af4f68a497John McCall 36f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 37f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 38f85e193739c953358c865005855253af4f68a497John McCall 39f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime expectedLifetime; 40f85e193739c953358c865005855253af4f68a497John McCall unsigned selector; 41f85e193739c953358c865005855253af4f68a497John McCall 42f85e193739c953358c865005855253af4f68a497John McCall // Strong properties should have either strong or no lifetime. 43f85e193739c953358c865005855253af4f68a497John McCall if (propertyKind & (ObjCPropertyDecl::OBJC_PR_retain | 44f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 45f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 46f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_Strong; 47f85e193739c953358c865005855253af4f68a497John McCall selector = 0; 48f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyKind & ObjCPropertyDecl::OBJC_PR_weak) { 49f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_Weak; 50f85e193739c953358c865005855253af4f68a497John McCall selector = 1; 51f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyKind & (ObjCPropertyDecl::OBJC_PR_assign | 52f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_unsafe_unretained) && 53f85e193739c953358c865005855253af4f68a497John McCall property->getType()->isObjCRetainableType()) { 54f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_ExplicitNone; 55f85e193739c953358c865005855253af4f68a497John McCall selector = 2; 56f85e193739c953358c865005855253af4f68a497John McCall } else { 57f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 58f85e193739c953358c865005855253af4f68a497John McCall // attribute. That's okay. 59f85e193739c953358c865005855253af4f68a497John McCall return; 60f85e193739c953358c865005855253af4f68a497John McCall } 61f85e193739c953358c865005855253af4f68a497John McCall 62f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 63f85e193739c953358c865005855253af4f68a497John McCall 64f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 65f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 66b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 67f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 68f85e193739c953358c865005855253af4f68a497John McCall << selector 69f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 70f85e193739c953358c865005855253af4f68a497John McCall} 71f85e193739c953358c865005855253af4f68a497John McCall 72d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 73d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 74d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 75d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 76d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 77d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 784a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 794a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 8028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 81f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 82f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 83f85e193739c953358c865005855253af4f68a497John McCall if ((getLangOptions().getGCMode() != LangOptions::NonGC && 84f85e193739c953358c865005855253af4f68a497John McCall T.isObjCGCWeak()) || 85f85e193739c953358c865005855253af4f68a497John McCall (getLangOptions().ObjCAutoRefCount && 86f85e193739c953358c865005855253af4f68a497John McCall T.getObjCLifetime() == Qualifiers::OCL_Weak)) 87f85e193739c953358c865005855253af4f68a497John McCall Attributes |= ObjCDeclSpec::DQ_PR_weak; 88f85e193739c953358c865005855253af4f68a497John McCall 8928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 9028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 9128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 9228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 9328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 9428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 9528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 9628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 97f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 98f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 99f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 100f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 10114086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 102e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 103a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 104e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 10528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 106ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 107a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian Decl *Res = HandlePropertyInClassExtension(S, AtLoc, 108ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 109ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 110ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 111ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 112ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 113f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 114ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 115f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 116f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 117f85e193739c953358c865005855253af4f68a497John McCall } 118ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 119ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 120ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 121f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 122f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 123f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 124f85e193739c953358c865005855253af4f68a497John McCall Attributes, TSI, MethodImplKind); 1254a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1264a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1274a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 128842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 129842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 130f85e193739c953358c865005855253af4f68a497John McCall 131f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 132f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 133f85e193739c953358c865005855253af4f68a497John McCall 134842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 135e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 136e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 137d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 138a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 139e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 140e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 141e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 143e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 144e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 14583a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 146e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 147a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(CurContext); 148e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 149a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 150e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 1512a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 1522a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 1532a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 1542a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 1552a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 1562a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 1572a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 1582a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 1592a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 1602a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 1612a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 1622a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 1632a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 1642a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1652a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1662a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 167e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 16988f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 170e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 171e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 172e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 17322f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 17422f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 17522f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 17622f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 17788f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 17888f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 17988f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 18091ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 183e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 184e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 185e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 186e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 187e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 188d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 189e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 190e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 191e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 192e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 193e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 194e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 195e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 196e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 197e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 198e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 199e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 200e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 20123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek Attributes, T, MethodImplKind, DC); 202e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 203e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 204e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 205e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 206a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek ProcessPropertyDecl(PDecl, CCPrimary, /* redeclaredProperty = */ 0, 207a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 208d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PDecl; 209e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 210e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 211e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 212e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 21380aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 214e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 215e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 216e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 217f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 218e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 219e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 220e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 221e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 222e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 223e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 224e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 2259944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 2269944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 2279944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 228e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 229e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 230e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 231e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 232e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 233e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 234e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 235e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 236a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 237a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 238a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ActOnObjCContainerFinishDefinition(CDecl); 239a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ActOnObjCContainerStartDefinition(CCPrimary); 240d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 241e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 242e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 243e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 244a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 2454a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 2464a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 247a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // restore class extension context. 248a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ActOnObjCContainerFinishDefinition(CCPrimary); 249a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ActOnObjCContainerStartDefinition(CDecl); 250d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 25128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 252e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 253e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 254e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 255f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 256f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 257e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 258e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 259e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 260e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 261788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 262788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 263788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 264788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 265788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 266788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 267788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 268788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 269788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 270788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 271e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 272e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 273e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 274e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 275e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 2768254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 277d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 278e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 279e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 280e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 281e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 282e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 283e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 284e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 285e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 286e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 287e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 288e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 28983a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 29023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 29123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 292e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 29383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 29428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 29528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 29628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 29728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC && 29828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 299c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 300c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 301c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 302c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 303c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 304c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 305c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 306c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 30728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 308c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 30928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 31028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 311e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 31228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 31328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 31483a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 315e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 3169f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 3179f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 31828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 319894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 32028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 32128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 32328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 32423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 32523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 32623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 32728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 32828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 32928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 33128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 33228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 33428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 33628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 33728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 33828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 33928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 3400a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 3410a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 3420a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 3430a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 3440a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 3450a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_getter) 3460a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 3470a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_setter) 3480a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 3490a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_assign) 3500a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 3510a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_retain) 3520a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 3530a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_strong) 3540a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 3550a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_weak) 3560a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 3570a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_copy) 3580a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 3590a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 3600a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 3610a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 3620a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 3630a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 3640a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 3650a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 3660a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 3670a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten); 3680a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 37128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 37228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 37328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 37428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 37528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 37628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 37728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 37828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 37928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 38028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 38128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 38228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 38328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 384f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 385f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 386f85e193739c953358c865005855253af4f68a497John McCall 387f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) 388f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 389f85e193739c953358c865005855253af4f68a497John McCall 39028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 39128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 39228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 393f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 394f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 395f85e193739c953358c865005855253af4f68a497John McCall 39628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 39728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 39828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 39928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 40028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 40145937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian else if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 40245937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 40328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 404f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 405f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 406f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 407f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 408f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 409f85e193739c953358c865005855253af4f68a497John McCall 41028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 41128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 41328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 41428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 415e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 41628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 41728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 418f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 419f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 420f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 421f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 422f85e193739c953358c865005855253af4f68a497John McCall 423f85e193739c953358c865005855253af4f68a497John McCall QualType propertyType = property->getType(); 424f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime = propertyType.getObjCLifetime(); 425f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 426f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 427f85e193739c953358c865005855253af4f68a497John McCall 428f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 429f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 430f85e193739c953358c865005855253af4f68a497John McCall 431f85e193739c953358c865005855253af4f68a497John McCall // Case 1: strong properties. 432f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_Strong || 433f85e193739c953358c865005855253af4f68a497John McCall (propertyKind & (ObjCPropertyDecl::OBJC_PR_retain | 434f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 435f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy))) { 436f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 437f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 438f85e193739c953358c865005855253af4f68a497John McCall // Okay. 439f85e193739c953358c865005855253af4f68a497John McCall return; 440f85e193739c953358c865005855253af4f68a497John McCall 441f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 442f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 443f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 444f85e193739c953358c865005855253af4f68a497John McCall return; 445f85e193739c953358c865005855253af4f68a497John McCall 446f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 447f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 448b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis S.Diag(propertyImplLoc, diag::err_arc_strong_property_ownership) 449f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 450f85e193739c953358c865005855253af4f68a497John McCall << ivar->getDeclName() 451f85e193739c953358c865005855253af4f68a497John McCall << ivarLifetime; 452f85e193739c953358c865005855253af4f68a497John McCall break; 453f85e193739c953358c865005855253af4f68a497John McCall } 454f85e193739c953358c865005855253af4f68a497John McCall 455f85e193739c953358c865005855253af4f68a497John McCall // Case 2: weak properties. 456f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak || 457f85e193739c953358c865005855253af4f68a497John McCall (propertyKind & ObjCPropertyDecl::OBJC_PR_weak)) { 458f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 459f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 460f85e193739c953358c865005855253af4f68a497John McCall // Okay. 461f85e193739c953358c865005855253af4f68a497John McCall return; 462f85e193739c953358c865005855253af4f68a497John McCall 463f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 464f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 465f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 466f85e193739c953358c865005855253af4f68a497John McCall return; 467f85e193739c953358c865005855253af4f68a497John McCall 468f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 469f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 470f85e193739c953358c865005855253af4f68a497John McCall S.Diag(propertyImplLoc, diag::error_weak_property) 471f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 472f85e193739c953358c865005855253af4f68a497John McCall << ivar->getDeclName(); 473f85e193739c953358c865005855253af4f68a497John McCall break; 474f85e193739c953358c865005855253af4f68a497John McCall } 475f85e193739c953358c865005855253af4f68a497John McCall 476f85e193739c953358c865005855253af4f68a497John McCall // Case 3: assign properties. 477f85e193739c953358c865005855253af4f68a497John McCall } else if ((propertyKind & ObjCPropertyDecl::OBJC_PR_assign) && 478f85e193739c953358c865005855253af4f68a497John McCall propertyType->isObjCRetainableType()) { 479f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 480f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 481f85e193739c953358c865005855253af4f68a497John McCall // Okay. 482f85e193739c953358c865005855253af4f68a497John McCall return; 483f85e193739c953358c865005855253af4f68a497John McCall 484f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 485f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 486f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 487f85e193739c953358c865005855253af4f68a497John McCall return; 488f85e193739c953358c865005855253af4f68a497John McCall 489f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 490f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 491b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis S.Diag(propertyImplLoc, diag::err_arc_assign_property_ownership) 492f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 493f85e193739c953358c865005855253af4f68a497John McCall << ivar->getDeclName(); 494f85e193739c953358c865005855253af4f68a497John McCall break; 495f85e193739c953358c865005855253af4f68a497John McCall } 496f85e193739c953358c865005855253af4f68a497John McCall 497f85e193739c953358c865005855253af4f68a497John McCall // Any other property should be ignored. 498f85e193739c953358c865005855253af4f68a497John McCall } else { 499f85e193739c953358c865005855253af4f68a497John McCall return; 500f85e193739c953358c865005855253af4f68a497John McCall } 501f85e193739c953358c865005855253af4f68a497John McCall 502f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 503f85e193739c953358c865005855253af4f68a497John McCall} 504f85e193739c953358c865005855253af4f68a497John McCall 50528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 50628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 50728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 50828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 50928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 510d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 511d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 512d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 513d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 514d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 515a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 516a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 517e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 518a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian cast_or_null<ObjCContainerDecl>(CurContext); 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 52128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 522d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 52328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 52428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 52528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 52628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 52728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 52828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 52928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 53028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 53828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 54028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 541d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 54228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 543dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 54445937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 54545937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 546dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 547dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 548dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 549dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 550dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 551dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 552dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 55328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 55428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 55628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 55728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 558d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 55928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 56328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 564d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 56528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 56728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 56828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 569d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 57128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 57228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 57328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 57428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 57528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 57628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 577d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 57828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 58028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 58128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 58228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 583d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 58628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 587d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 59028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 59128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 59228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 59328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 59428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 595f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind kind 596f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 59728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType PropType = Context.getCanonicalType(property->getType()); 59814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType PropertyIvarType = PropType; 59914086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (PropType->isReferenceType()) 60014086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType = cast<ReferenceType>(PropType)->getPointeeType(); 60128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 60228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 60328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 60428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 605f85e193739c953358c865005855253af4f68a497John McCall // In ARC, give the ivar a lifetime qualifier based on its 606f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 607f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 608f85e193739c953358c865005855253af4f68a497John McCall !PropertyIvarType.getObjCLifetime()) { 609f85e193739c953358c865005855253af4f68a497John McCall 610473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 611bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian property->getType()->isObjCRetainableType() && 612bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian !(kind & ObjCPropertyDecl::OBJC_PR_strong) ) { 613473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(PropertyLoc, 614473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 615473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 616473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis } 617473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis 618f85e193739c953358c865005855253af4f68a497John McCall // retain/copy have retaining lifetime. 619f85e193739c953358c865005855253af4f68a497John McCall if (kind & (ObjCPropertyDecl::OBJC_PR_retain | 620f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 621f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 622f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 623f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_Strong); 624f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 625f85e193739c953358c865005855253af4f68a497John McCall } 626f85e193739c953358c865005855253af4f68a497John McCall else if (kind & ObjCPropertyDecl::OBJC_PR_weak) { 6279f084a3166b684573ba49df28fc5792bc37d92e1John McCall if (!getLangOptions().ObjCRuntimeHasWeak) { 628f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::err_arc_weak_no_runtime); 629f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 630f85e193739c953358c865005855253af4f68a497John McCall } 631f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 632f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_Weak); 633f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 634f85e193739c953358c865005855253af4f68a497John McCall } 635f85e193739c953358c865005855253af4f68a497John McCall else if (kind & ObjCPropertyDecl::OBJC_PR_assign && 636f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType->isObjCRetainableType()) { 637f85e193739c953358c865005855253af4f68a497John McCall // assume that an 'assign' property synthesizes __unsafe_unretained 638f85e193739c953358c865005855253af4f68a497John McCall // ivar 639f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 640f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_ExplicitNone); 641f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 642f85e193739c953358c865005855253af4f68a497John McCall } 643f85e193739c953358c865005855253af4f68a497John McCall } 644f85e193739c953358c865005855253af4f68a497John McCall 645f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 646f85e193739c953358c865005855253af4f68a497John McCall !getLangOptions().ObjCAutoRefCount && 647f85e193739c953358c865005855253af4f68a497John McCall getLangOptions().getGCMode() == LangOptions::NonGC) { 648f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::error_synthesize_weak_non_arc_or_gc); 649f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 650f85e193739c953358c865005855253af4f68a497John McCall } 651f85e193739c953358c865005855253af4f68a497John McCall 652ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 653ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara PropertyLoc, PropertyLoc, PropertyIvar, 65414086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 6557504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 656ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 65729fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 65828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 65928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 66028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 66128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 66228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 66328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 66428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 66528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 66628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 66728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 66828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 66928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 67028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 6714087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 67228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 67328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 67428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 67528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 67628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 67714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (PropertyIvarType != IvarType) { 67862ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 67914086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 680f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 68162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 68262ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 68314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 68462ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 685b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 686b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor SourceLocation Loc = PropertyIvarLoc; 687b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor if (Loc.isInvalid()) 688b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor Loc = PropertyLoc; 68914086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian compat = (CheckAssignmentConstraints(Loc, PropertyIvarType, IvarType) 690daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 691b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 69262ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 69328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 694f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 695f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 696f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 69728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 69828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 69928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 70028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 70128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 70228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 70328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 70414086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 70528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 70628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 70728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 70828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 709f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 710f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 711f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 71228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 71328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 71428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 715f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 716f85e193739c953358c865005855253af4f68a497John McCall getLangOptions().getGCMode() != LangOptions::NonGC)) { 71728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 71828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 71928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 72028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 721f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 72228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 72328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 72428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 72528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 72628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 72728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 72828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 72928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 730f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 731f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 73228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 73328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 73428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 735f85e193739c953358c865005855253af4f68a497John McCall 73628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 73728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 73828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 73928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 74028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 74128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 74228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 743a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 74417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 74517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 7460313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize && 7470313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 74817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 74917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 75017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 75117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 75217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 753f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 754f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 75517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 75617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 75717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 75860d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 75917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 7603c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 7613c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 7623c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 76317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 76417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 76517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 76617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 76717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 7684765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 76917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 77017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 77117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 772831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 773831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 774831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 775831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 776831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 777831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 77817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 77917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 78017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 7810313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize 7820313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian && Ivar->getType()->isRecordType()) { 78317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 78417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 78517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 786f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 787f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 78817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 78917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 79017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 79117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 79217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 79314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType T = Param->getType(); 79414086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (T->isReferenceType()) 79561750f2bed7f5c0e440318841e3be385920b22f3Fariborz Jahanian T = T->getAs<ReferenceType>()->getPointeeType(); 79614086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian Expr *rhs = new (Context) DeclRefExpr(Param, T, 797f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 798fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 7992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 80017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 80117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 80217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 80317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 80428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 80528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 80628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 80728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 80828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 80928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 81028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 81128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 81228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 81328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 81428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 81528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 81628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 81728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 818d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 81928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 82028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 821e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian if (getLangOptions().ObjCDefaultSynthProperties && 822e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian getLangOptions().ObjCNonFragileABI2) { 823ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 824ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 825cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 826411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 827ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 828ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 829ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 830ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 831ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 832ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 833ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 834cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 835cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 836cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian IC->getClassInterface() == ClassDeclared) { 837ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 838ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 839ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 840ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 841ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 84228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 84328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 84428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 84528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 84628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 84728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 84828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 84928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 85028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 85128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 85228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 85328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 85428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 85528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 856d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 85728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 85828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 85928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 86028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 861d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 86228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 86328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 86428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 86528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 86628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 86728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 8689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 8699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 8709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 8719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 8729d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 8739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 8749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 8759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 8769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 8779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 8789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 8799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 8809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 8819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 8829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 8839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 8849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 8859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 8869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 887f85e193739c953358c865005855253af4f68a497John McCall else { 888f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 889f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 890f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 891f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 892f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 893f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 894f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 895f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 896f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 897f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 898f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 899f85e193739c953358c865005855253af4f68a497John McCall } 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 9029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 9039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 9059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 9069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 9089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 9099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 9119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 9139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 9149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 9159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 9169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 917c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 9188beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 9198beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 9208beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 9218beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 9228beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 9238beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 9248beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian IncompatibleObjC) 9258beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 9268beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 9279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 9319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 9329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 9339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 9349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->getResultType() != property->getType()) { 9359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 9361c23e91ef66688d20868b6bab3b5589a119eb603John McCall if (property->getType()->isObjCObjectPointerType()) 937b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor result = CheckAssignmentConstraints(Loc, GetterMethod->getResultType(), 9381c23e91ef66688d20868b6bab3b5589a119eb603John McCall property->getType()); 9399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 9409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 9419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 9439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 9489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 9519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 952fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 9539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 9549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 9559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 9569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 9579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 9619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 9649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 9659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 9669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 9679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 9699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 9769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 9779d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 9849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 9889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 9899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 9902d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 9919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 9929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 9939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 9949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 10009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 10019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 10029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 10049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 10059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 10069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 10099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 10109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 10149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 10159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 10169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 1017d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 1018d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 10229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 10329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 10349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 1035d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 104653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 104753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 104853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 10509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 105453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 105553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 105653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1057d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 10679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 10709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 10719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 10759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 10809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 10849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 10859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 10869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 10879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 10899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 10909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 10919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 10959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 10969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 10979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 10989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 11039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 11089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 11099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 11199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1120cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 1121cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 11259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 112953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 113053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 113153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1132cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 11359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 11369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 11379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 11389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 114253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 11439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1144cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 11479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 11489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 11499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 1150cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1151cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1152cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1153cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropertyFromSuper || PropertyFromSuper != Prop) { 1154cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1155cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1156cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1157cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 11589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 11609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 11619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1162cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1166509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 1167509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 1168509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 1169509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 1170509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1171509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1172509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1173509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 1174509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1175509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1176509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 117753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 117853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 117953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1180509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1181509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1182509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1183509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1184509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 1185509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1186509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1187509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1188509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 1189509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1190509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 1191509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1192509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1193509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1194509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1195509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1196509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1197509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1198509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1199509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1200509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1201509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1202509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 1203509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1204509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1205509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1206509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1207509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 12089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 12099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 12109d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 12119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 12129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 12139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 12149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 12159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 12169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 122153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 122253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 122353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 12249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 12309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 12319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 12329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 12339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 12389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 12399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 12409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 12469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1248509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 1249509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 1250509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties (Scope *S, ObjCImplDecl* IMPDecl, 1251509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCInterfaceDecl *IDecl) { 1252509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1253509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1254509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 1255509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1256509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1257509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1258509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1259509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1260509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1261509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1262509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1263509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1264509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1265509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1266509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1267509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1268509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1269509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1270509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1271d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1272d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1273d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 127495f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 127595f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 127695f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 127795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 127895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 127995f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1280d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian 12812a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 12822a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 12832a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 12842a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 12852a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 12862a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1287a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian true, 1288a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Prop->getIdentifier(), Prop->getIdentifier(), 1289a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation()); 12902a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1291509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 12929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 129317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 12949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 12959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 1296cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1297cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1298cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1299cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 13009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1301cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 13029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 13039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 13069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 13079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 13089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 13099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 13109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 13129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 13139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 13149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 13159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 13169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1317327126ee3d2faad9314b2633974eefc672f73b79Fariborz Jahanian PropImplMap.count(Prop) || Prop->hasAttr<UnavailableAttr>()) 13189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 13199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 13209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 13219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 13259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 13269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 13279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 13309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 13319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 13359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 13369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 13379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13429d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 13439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 13449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 13459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC) 13469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 13489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 13509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 135194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 135294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 135394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 135494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 135694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis unsigned AttributesAsWrittern = Property->getPropertyAttributesAsWritten(); 135794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 135845937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if (!(AttributesAsWrittern & ObjCPropertyDecl::OBJC_PR_atomic) && 135945937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian !(AttributesAsWrittern & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 136094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 136194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 136294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 136394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 136494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 136594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1366293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 136794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 136894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 136994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 137094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 137194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1372293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 137394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 137494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 137594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 137694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 13779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 13789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 13799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 13809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 13819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 13829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 13839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 13849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 138594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 138694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 138794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 138894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 138994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 13909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 13919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 13939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 13949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 13959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getIdentifier(); 13969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 13979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1402f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 1403f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().getGCMode() == LangOptions::GCOnly) 1404f85e193739c953358c865005855253af4f68a497John McCall return; 1405f85e193739c953358c865005855253af4f68a497John McCall 1406f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1407f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1408f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyImplDecl *PID = *i; 1409f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1410f85e193739c953358c865005855253af4f68a497John McCall continue; 1411f85e193739c953358c865005855253af4f68a497John McCall 1412f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1413831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1414831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1415f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1416f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1417f85e193739c953358c865005855253af4f68a497John McCall continue; 1418f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1419f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1420f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 1421f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 1422f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1423f85e193739c953358c865005855253af4f68a497John McCall else 1424f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::warn_ownin_getter_rule); 1425f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1426f85e193739c953358c865005855253af4f68a497John McCall } 1427f85e193739c953358c865005855253af4f68a497John McCall } 1428f85e193739c953358c865005855253af4f68a497John McCall } 1429f85e193739c953358c865005855253af4f68a497John McCall} 1430f85e193739c953358c865005855253af4f68a497John McCall 14315de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 14325de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 14335de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 14345de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 14355de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 14360a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 14370a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 14380a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 14390a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 14400a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 14410a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 14420a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 14430a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 14445de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 14455de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 14469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 14479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 14489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 14499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 14509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 14519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 14528254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 14538254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 14548254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 14558254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 14569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 14579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 14599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 14609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 14619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 14629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 14649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 14659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 14669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 14679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 14689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 14699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 14709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 14719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ((*SetterMethod->param_begin())->getType() != property->getType())) { 14729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 14739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 14749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 14759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 14769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 14779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 14819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 14829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 14839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 14849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 14859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 14869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 14879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 14889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 14899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1490a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1491a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1492a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1493a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1494a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1495a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 149675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 149775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isVariadic=*/false, /*isSynthesized=*/true, 149875cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 14999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 15029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 15039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 15045de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15055de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 15065de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 150723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 150823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1509a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 151023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1511831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1512831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1513831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 15149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 15159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 15169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 15179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 15189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 15199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 15219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 15229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 15239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 15249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 15259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 15269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 15278254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 15288254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 15298254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 15308254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15318254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 15328254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Create(Context, Loc, Loc, 15338254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 153475cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 153575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isSynthesized=*/true, 153675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 153775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 15389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15408254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 15418254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 15428254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 15449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1545ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1546ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 15479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1548f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 15499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1550d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1551d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 15529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 15534ecb25fa94897b2c03510292acace710e5262ba5Fariborz Jahanian SetterMethod->setMethodParams(Context, &Argument, 1, 1); 15545de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15555de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 15565de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 155823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 155923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 15608254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 156123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 15629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 15639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 15649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 15659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 15669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 15679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 15699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 15709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 15729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 15739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 15749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 15769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 15779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 15789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 15799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 15819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 15829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 15839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 15849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 15859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1586d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 15879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 15889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 15899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1590f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 15915fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 15925fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 15935fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1594842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 15959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 15979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 159828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 159928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 1600f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 160128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 1602f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 1603f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 160428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 160528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 160628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 160728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 1608f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 1609f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 161028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 161128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 16129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 161328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 161428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 161528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 161628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 161728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 161928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 1620f85e193739c953358c865005855253af4f68a497John McCall if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1621f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 1622f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 1623842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 162428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 1625f85e193739c953358c865005855253af4f68a497John McCall << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 1626f85e193739c953358c865005855253af4f68a497John McCall Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 1627f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1628f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 162928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 163128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 163228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 163328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 163428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 163528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 163628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 163728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 163828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 163928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 164028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 164128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 164228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1643f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1644f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1645f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 1646f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1647f85e193739c953358c865005855253af4f68a497John McCall } 1648f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1649f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1650f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1651f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 1652f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1653f85e193739c953358c865005855253af4f68a497John McCall } 1654f85e193739c953358c865005855253af4f68a497John McCall } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 1655f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1656f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1657f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 1658f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 1659f85e193739c953358c865005855253af4f68a497John McCall } 1660f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1661f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1662f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 1663f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1664f85e193739c953358c865005855253af4f68a497John McCall } 1665f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1666f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1667f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 1668f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1669f85e193739c953358c865005855253af4f68a497John McCall } 1670f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1671f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1672f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1673f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 1674f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1675f85e193739c953358c865005855253af4f68a497John McCall } 167628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 167728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 167828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 167928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 168028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 168128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1682f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1683f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1684f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 1685f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1686f85e193739c953358c865005855253af4f68a497John McCall } 1687f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 1688f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1689f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 1690f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1691f85e193739c953358c865005855253af4f68a497John McCall } 1692f85e193739c953358c865005855253af4f68a497John McCall } 1693f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 1694f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1695f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1696f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 1697f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1698f85e193739c953358c865005855253af4f68a497John McCall } 1699f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 1700f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1701f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1702f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 1703f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 170428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 170628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 170728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 170828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 1709f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 1710f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 1711f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 171228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 171328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 1714bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().ObjCAutoRefCount) 1715bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 1716bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // not specified 1717bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 1718bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian else { 1719bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 1720bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().getGCMode() != LangOptions::GCOnly) 1721bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 17220a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 1723bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 1724bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().getGCMode() == LangOptions::NonGC) 1725bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 1726bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 17279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 172828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 172928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 173028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 173128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 173228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 173428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 17352b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 173628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && getLangOptions().getGCMode() == LangOptions::GCOnly 173728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 173828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 17399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1740