SemaObjCProperty.cpp revision b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 1655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/ASTMutationListener.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian#include "clang/AST/ExprCXX.h" 1955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/ExprObjC.h" 20edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian#include "clang/Basic/SourceManager.h" 2155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Lex/Lexer.h" 2255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Lex/Preprocessor.h" 2355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h" 2450df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 258fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 3128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33265941bc308d65cc270d5c4de5806f37ce405606John McCall/// getImpliedARCOwnership - Given a set of property attributes and a 34265941bc308d65cc270d5c4de5806f37ce405606John McCall/// type, infer an expected lifetime. The type's ownership qualification 35265941bc308d65cc270d5c4de5806f37ce405606John McCall/// is not considered. 36265941bc308d65cc270d5c4de5806f37ce405606John McCall/// 37265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Returns OCL_None if the attributes as stated do not imply an ownership. 38265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Never returns OCL_Autoreleasing. 39265941bc308d65cc270d5c4de5806f37ce405606John McCallstatic Qualifiers::ObjCLifetime getImpliedARCOwnership( 40265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attrs, 41265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType type) { 42265941bc308d65cc270d5c4de5806f37ce405606John McCall // retain, strong, copy, weak, and unsafe_unretained are only legal 43265941bc308d65cc270d5c4de5806f37ce405606John McCall // on properties of retainable pointer type. 44265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & (ObjCPropertyDecl::OBJC_PR_retain | 45265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_strong | 46265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 47d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return Qualifiers::OCL_Strong; 48265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_weak) { 49265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Weak; 50265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_unsafe_unretained) { 51265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 52265941bc308d65cc270d5c4de5806f37ce405606John McCall } 53265941bc308d65cc270d5c4de5806f37ce405606John McCall 54265941bc308d65cc270d5c4de5806f37ce405606John McCall // assign can appear on other types, so we have to check the 55265941bc308d65cc270d5c4de5806f37ce405606John McCall // property type. 56265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & ObjCPropertyDecl::OBJC_PR_assign && 57265941bc308d65cc270d5c4de5806f37ce405606John McCall type->isObjCRetainableType()) { 58265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 59265941bc308d65cc270d5c4de5806f37ce405606John McCall } 60265941bc308d65cc270d5c4de5806f37ce405606John McCall 61265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_None; 62265941bc308d65cc270d5c4de5806f37ce405606John McCall} 63265941bc308d65cc270d5c4de5806f37ce405606John McCall 64f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 65f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 66f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 67f85e193739c953358c865005855253af4f68a497John McCall 68f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 69f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 70f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 71f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 72f85e193739c953358c865005855253af4f68a497John McCall 73f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 74f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 75f85e193739c953358c865005855253af4f68a497John McCall 76265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime expectedLifetime 77265941bc308d65cc270d5c4de5806f37ce405606John McCall = getImpliedARCOwnership(propertyKind, property->getType()); 78265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!expectedLifetime) { 79f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 80265941bc308d65cc270d5c4de5806f37ce405606John McCall // attribute. That's okay, but restore reasonable invariants by 81265941bc308d65cc270d5c4de5806f37ce405606John McCall // setting the property attribute according to the lifetime 82265941bc308d65cc270d5c4de5806f37ce405606John McCall // qualifier. 83265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attr; 84265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == Qualifiers::OCL_Strong) { 85265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_strong; 86265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak) { 87265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_weak; 88265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 89265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(propertyLifetime == Qualifiers::OCL_ExplicitNone); 90265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 91265941bc308d65cc270d5c4de5806f37ce405606John McCall } 92265941bc308d65cc270d5c4de5806f37ce405606John McCall property->setPropertyAttributes(attr); 93f85e193739c953358c865005855253af4f68a497John McCall return; 94f85e193739c953358c865005855253af4f68a497John McCall } 95f85e193739c953358c865005855253af4f68a497John McCall 96f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 97f85e193739c953358c865005855253af4f68a497John McCall 98f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 99f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 100b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 101f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 102265941bc308d65cc270d5c4de5806f37ce405606John McCall << expectedLifetime 103f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 104f85e193739c953358c865005855253af4f68a497John McCall} 105f85e193739c953358c865005855253af4f68a497John McCall 106dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanianstatic unsigned deduceWeakPropertyFromType(Sema &S, QualType T) { 107dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if ((S.getLangOpts().getGC() != LangOptions::NonGC && 108dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.isObjCGCWeak()) || 109dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (S.getLangOpts().ObjCAutoRefCount && 110dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.getObjCLifetime() == Qualifiers::OCL_Weak)) 111dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return ObjCDeclSpec::DQ_PR_weak; 112dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return 0; 113dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 114dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 115b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor/// \brief Check this Objective-C property against a property declared in the 116b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor/// given protocol. 117b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregorstatic void 118b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas GregorCheckPropertyAgainstProtocol(Sema &S, ObjCPropertyDecl *Prop, 119b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor ObjCProtocolDecl *Proto, 120b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor llvm::SmallPtrSet<ObjCProtocolDecl *, 16> &Known) { 121b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Have we seen this protocol before? 122b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor if (!Known.insert(Proto)) 123b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor return; 124b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor 125b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Look for a property with the same name. 126b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor DeclContext::lookup_result R = Proto->lookup(Prop->getDeclName()); 127b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (unsigned I = 0, N = R.size(); I != N; ++I) { 128b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor if (ObjCPropertyDecl *ProtoProp = dyn_cast<ObjCPropertyDecl>(R[I])) { 129b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor S.DiagnosePropertyMismatch(Prop, ProtoProp, Proto->getIdentifier()); 130b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor return; 131b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 132b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 133b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor 134b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Check this property against any protocols we inherit. 135b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCProtocolDecl::protocol_iterator P = Proto->protocol_begin(), 136b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = Proto->protocol_end(); 137b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 138b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(S, Prop, *P, Known); 139b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 140b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor} 141b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor 142d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 14377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 144d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 145d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 146d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 147d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 148d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 1494a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 1504a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 151ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = ODS.getPropertyAttributes(); 152f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 153f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 154ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes |= deduceWeakPropertyFromType(*this, T); 155dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 156ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 15728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 158ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 15928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 16028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 161ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 16228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 163ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 164ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 165ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 166ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 167ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 16814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 169aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor // Proceed with constructing the ObjCPropertyDecls. 170a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 171aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor ObjCPropertyDecl *Res = 0; 172aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 173ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 174aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor Res = HandlePropertyInClassExtension(S, AtLoc, LParenLoc, 175ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 176ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 177ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes, 178dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 179ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 180ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 181aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (!Res) 182aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor return 0; 183ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 184aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor } 185aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor 186aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (!Res) { 187aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor Res = CreatePropertyDecl(S, ClassDecl, AtLoc, LParenLoc, FD, 188aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor GetterSel, SetterSel, isAssign, isReadWrite, 189aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor Attributes, ODS.getPropertyAttributes(), 190aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor TSI, MethodImplKind); 191aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (lexicalDC) 192aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor Res->setLexicalDeclContext(lexicalDC); 193aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor } 1944a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 195842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 196ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling CheckObjCPropertyAttributes(Res, AtLoc, Attributes, 197cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (isa<ObjCInterfaceDecl>(ClassDecl) || 198cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian isa<ObjCProtocolDecl>(ClassDecl))); 199f85e193739c953358c865005855253af4f68a497John McCall 2004e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 201f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 202f85e193739c953358c865005855253af4f68a497John McCall 203b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor llvm::SmallPtrSet<ObjCProtocolDecl *, 16> KnownProtos; 204aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (ObjCInterfaceDecl *IFace = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 205b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // For a class, compare the property against a property in our superclass. 206b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor bool FoundInSuper = false; 207aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor if (ObjCInterfaceDecl *Super = IFace->getSuperClass()) { 208aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor DeclContext::lookup_result R = Super->lookup(Res->getDeclName()); 209b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (unsigned I = 0, N = R.size(); I != N; ++I) { 210b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor if (ObjCPropertyDecl *SuperProp = dyn_cast<ObjCPropertyDecl>(R[I])) { 211aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor DiagnosePropertyMismatch(Res, SuperProp, Super->getIdentifier()); 212b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor FoundInSuper = true; 213b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor break; 214b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 215b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 216b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 217b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor 218b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor if (FoundInSuper) { 219b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Also compare the property against a property in our protocols. 220b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCInterfaceDecl::protocol_iterator P = IFace->protocol_begin(), 221b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = IFace->protocol_end(); 222b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 223b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(*this, Res, *P, KnownProtos); 224b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 225b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } else { 226b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor // Slower path: look in all protocols we referenced. 227b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCInterfaceDecl::all_protocol_iterator 228b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P = IFace->all_referenced_protocol_begin(), 229b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = IFace->all_referenced_protocol_end(); 230b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 231b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(*this, Res, *P, KnownProtos); 232b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 233b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 234b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } else if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 235b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCCategoryDecl::protocol_iterator P = Cat->protocol_begin(), 236b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = Cat->protocol_end(); 237b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 238b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(*this, Res, *P, KnownProtos); 239b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } 240b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor } else { 241b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor ObjCProtocolDecl *Proto = cast<ObjCProtocolDecl>(ClassDecl); 242b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor for (ObjCProtocolDecl::protocol_iterator P = Proto->protocol_begin(), 243b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor PEnd = Proto->protocol_end(); 244b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor P != PEnd; ++P) { 245b892d7010f9c2c61e2f3a2686546cbfbffbedef3Douglas Gregor CheckPropertyAgainstProtocol(*this, Res, *P, KnownProtos); 246aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor } 247aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor } 248aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor 249abd56c816e9164b17bb3e7154a511b0c9896ffdbDmitri Gribenko ActOnDocumentableDecl(Res); 250842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 251e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 252e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 253b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidisstatic ObjCPropertyDecl::PropertyAttributeKind 254ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill WendlingmakePropertyAttributesAsWritten(unsigned Attributes) { 255b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 256ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 257b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 258ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 259b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 260ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_getter) 261b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 262ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_setter) 263b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 264ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_assign) 265b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 266ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 267b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 268ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 269b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 270ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) 271b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 272ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 273b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 274ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 275b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 276ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 277b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 278ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 279b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 280b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 281b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis return (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten; 282b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis} 283b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 2845bf0e3522fac400cf7bf49a775554f0fc942b336Fariborz Jahanianstatic bool LocPropertyAttribute( ASTContext &Context, const char *attrName, 285edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation LParenLoc, SourceLocation &Loc) { 286edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (LParenLoc.isMacroID()) 287edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 288edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 289edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceManager &SM = Context.getSourceManager(); 290edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian std::pair<FileID, unsigned> locInfo = SM.getDecomposedLoc(LParenLoc); 291edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Try to load the file buffer. 292edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian bool invalidTemp = false; 293edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef file = SM.getBufferData(locInfo.first, &invalidTemp); 294edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (invalidTemp) 295edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 296edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian const char *tokenBegin = file.data() + locInfo.second; 297edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 298edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Lex from the start of the given location. 299edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Lexer lexer(SM.getLocForStartOfFile(locInfo.first), 300edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Context.getLangOpts(), 301edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian file.begin(), tokenBegin, file.end()); 302edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Token Tok; 303edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian do { 304edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian lexer.LexFromRawLexer(Tok); 305edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (Tok.is(tok::raw_identifier) && 306edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef(Tok.getRawIdentifierData(), Tok.getLength()) == attrName) { 307edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Loc = Tok.getLocation(); 308edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return true; 309edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 310edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } while (Tok.isNot(tok::r_paren)); 311edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 312edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 3132b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian} 3142b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 315d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanianstatic unsigned getOwnershipRule(unsigned attr) { 316dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return attr & (ObjCPropertyDecl::OBJC_PR_assign | 317dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_retain | 318dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_copy | 319dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_weak | 320dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_strong | 321dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 322dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 323dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 324aabd094cf694039fe823987e133af7ac25cb9711Douglas GregorObjCPropertyDecl * 325a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 32677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation AtLoc, 32777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 32877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FieldDeclarator &FD, 329e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 330e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 331e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 332ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const unsigned Attributes, 333dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 334e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 33583a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 336e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 33758a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 338e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 339a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 340e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 3412a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 3422a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 343d329724745b49f894b768d47275b7c2713106e89Douglas Gregor if (CCPrimary) { 3442a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 3452a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 346d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCInterfaceDecl::known_extensions_iterator 347d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext = CCPrimary->known_extensions_begin(), 348d329724745b49f894b768d47275b7c2713106e89Douglas Gregor ExtEnd = CCPrimary->known_extensions_end(); 349d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext != ExtEnd; ++Ext) { 350d329724745b49f894b768d47275b7c2713106e89Douglas Gregor if (ObjCPropertyDecl *prevDecl 351d329724745b49f894b768d47275b7c2713106e89Douglas Gregor = ObjCPropertyDecl::findPropertyDecl(*Ext, PropertyId)) { 3522a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 3532a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 3542a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 3552a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 3562a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 357d329724745b49f894b768d47275b7c2713106e89Douglas Gregor } 358d329724745b49f894b768d47275b7c2713106e89Douglas Gregor 359e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 360e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 36188f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 362e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 363e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 36477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, T); 365b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 366dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 367ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 36822f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 369ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 37022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 371b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 372b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 373b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 374b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 37588f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 37688f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 37788f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 37891ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 379e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 380e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 381e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 382e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 383e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 384e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 385e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 386d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 387e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 388e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 389e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 390e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 391e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 392e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 393e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 394e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 395e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 396d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ObjCPropertyDecl *PrimaryPDecl = 39777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian CreatePropertyDecl(S, CCPrimary, AtLoc, LParenLoc, 398e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 399ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes,AttributesAsWritten, T, MethodImplKind, DC); 400e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 401e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 402e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 403e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 404d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ProcessPropertyDecl(PrimaryPDecl, CCPrimary, /* redeclaredProperty = */ 0, 405a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 406d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PrimaryPDecl->getGetterMethodDecl()); 407d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PrimaryPDecl->getSetterMethodDecl()); 408c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 409d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PrimaryPDecl, /*OrigProp=*/0, CDecl); 410d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis return PrimaryPDecl; 411e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 412e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!Context.hasSameType(PIDecl->getType(), PDecl->getType())) { 413e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian bool IncompatibleObjC = false; 414e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian QualType ConvertedType; 415ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Relax the strict type matching for property type in continuation class. 416ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Allow property object type of continuation class to be different as long 417ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // as it narrows the object type in its primary class property. Note that 418ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // this conversion is safe only because the wider type is for a 'readonly' 419ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // property in primary class and 'narrowed' type for a 'readwrite' property 420ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // in continuation class. 421e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!isa<ObjCObjectPointerType>(PIDecl->getType()) || 422e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian !isa<ObjCObjectPointerType>(PDecl->getType()) || 423e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian (!isObjCPointerConversion(PDecl->getType(), PIDecl->getType(), 424e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian ConvertedType, IncompatibleObjC)) 425e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian || IncompatibleObjC) { 426e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(AtLoc, 427e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian diag::err_type_mismatch_continuation_class) << PDecl->getType(); 428e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(PIDecl->getLocation(), diag::note_property_declare); 4296defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return 0; 430e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian } 431a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian } 432a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian 433e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 434e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 43580aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 436e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 437dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian PIkind |= deduceWeakPropertyFromType(*this, PIDecl->getType()); 438ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned ClassExtensionMemoryModel = getOwnershipRule(Attributes); 439d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanian unsigned PrimaryClassMemoryModel = getOwnershipRule(PIkind); 440dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if (PrimaryClassMemoryModel && ClassExtensionMemoryModel && 441dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (PrimaryClassMemoryModel != ClassExtensionMemoryModel)) { 442e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 443e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 444e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 4459944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 4469944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 4479944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 448e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 449e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 450e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 451e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 452e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 453e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 454e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 455e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 456a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 457a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 4587939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 4597939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 460d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 46177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian ActOnProperty(S, AtLoc, LParenLoc, FD, ProtocolPropertyODS, 462e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 463e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 464a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 4654a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 4664a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 467d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 46828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 469e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 470ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 471e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 472ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 473f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 474ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 475e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 476e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 477e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 478788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 479788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 480788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 481788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 482788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 483ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 484788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 485788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 486788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 487788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 488e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 489e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 4906defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return 0; 491e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 492e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 493e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 4948254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 495d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PIDecl->getGetterMethodDecl()); 496d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PIDecl->getSetterMethodDecl()); 497c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 498c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PDecl, PIDecl, CDecl); 4996defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return PDecl; 500e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 501e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 502e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 503e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 504e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 50577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 506e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 507e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 508e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 509e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 510e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 511ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const unsigned Attributes, 512dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 51383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 51423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 51523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 516e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 51783a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 51828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 5214e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC && 522ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 523c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 524c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 525c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 526c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 527c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 528c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 529c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 530c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 532c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 535e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 53877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, TInfo); 539e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 5409f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 5419f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 54228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 543894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 54428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 54528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 54623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 54728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 54823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 54923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 55023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 55128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 55228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 55328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 55428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 55628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 55728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 55828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 55928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 5630a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 564dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 5650a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 566ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 56728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 56828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 569ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_getter) 57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 57128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 572ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_setter) 57328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 57428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 57528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 57628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 57728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 578ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 58028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 581ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 582f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 583f85e193739c953358c865005855253af4f68a497John McCall 584ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) 585f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 586f85e193739c953358c865005855253af4f68a497John McCall 587ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 58828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 58928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 590ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 591f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 592f85e193739c953358c865005855253af4f68a497John McCall 59328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 59428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 59528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 596265941bc308d65cc270d5c4de5806f37ce405606John McCall // In the semantic attributes, one of nonatomic or atomic is always set. 597ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 59828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 599265941bc308d65cc270d5c4de5806f37ce405606John McCall else 60045937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 60128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 602f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 603ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 604f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 605f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 606f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 607f85e193739c953358c865005855253af4f68a497John McCall 60828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 60928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 61028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 61128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 61228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 613e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 61428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 61528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 616f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 617f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 618f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 619f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 620f85e193739c953358c865005855253af4f68a497John McCall 621f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 622f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 623f85e193739c953358c865005855253af4f68a497John McCall 624265941bc308d65cc270d5c4de5806f37ce405606John McCall // The lifetime implied by the property's attributes. 625265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime propertyLifetime = 626265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(property->getPropertyAttributes(), 627265941bc308d65cc270d5c4de5806f37ce405606John McCall property->getType()); 628f85e193739c953358c865005855253af4f68a497John McCall 629265941bc308d65cc270d5c4de5806f37ce405606John McCall // We're fine if they match. 630265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == ivarLifetime) return; 631f85e193739c953358c865005855253af4f68a497John McCall 632265941bc308d65cc270d5c4de5806f37ce405606John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 633265941bc308d65cc270d5c4de5806f37ce405606John McCall if (ivarLifetime == Qualifiers::OCL_None || 634265941bc308d65cc270d5c4de5806f37ce405606John McCall ivarLifetime == Qualifiers::OCL_Autoreleasing) 635265941bc308d65cc270d5c4de5806f37ce405606John McCall return; 636265941bc308d65cc270d5c4de5806f37ce405606John McCall 637d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // If the ivar is private, and it's implicitly __unsafe_unretained 638d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // becaues of its type, then pretend it was actually implicitly 639d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // __strong. This is only sound because we're processing the 640d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // property implementation before parsing any method bodies. 641d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (ivarLifetime == Qualifiers::OCL_ExplicitNone && 642d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall propertyLifetime == Qualifiers::OCL_Strong && 643d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->getAccessControl() == ObjCIvarDecl::Private) { 644d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall SplitQualType split = ivarType.split(); 645d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (split.Quals.hasObjCLifetime()) { 646d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall assert(ivarType->isObjCARCImplicitlyUnretainedType()); 647d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall split.Quals.setObjCLifetime(Qualifiers::OCL_Strong); 648d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivarType = S.Context.getQualifiedType(split); 649d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->setType(ivarType); 650d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return; 651d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 652d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 653d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall 654265941bc308d65cc270d5c4de5806f37ce405606John McCall switch (propertyLifetime) { 655265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Strong: 656135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::err_arc_strong_property_ownership) 657265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 658265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 659265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivarLifetime; 660265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 661265941bc308d65cc270d5c4de5806f37ce405606John McCall 662265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Weak: 663135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::error_weak_property) 664265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 665265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName(); 666265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 667265941bc308d65cc270d5c4de5806f37ce405606John McCall 668265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_ExplicitNone: 669135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::err_arc_assign_property_ownership) 670265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 671265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 672265941bc308d65cc270d5c4de5806f37ce405606John McCall << ((property->getPropertyAttributesAsWritten() 673265941bc308d65cc270d5c4de5806f37ce405606John McCall & ObjCPropertyDecl::OBJC_PR_assign) != 0); 674265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 675265941bc308d65cc270d5c4de5806f37ce405606John McCall 676265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Autoreleasing: 677265941bc308d65cc270d5c4de5806f37ce405606John McCall llvm_unreachable("properties cannot be autoreleasing"); 678265941bc308d65cc270d5c4de5806f37ce405606John McCall 679265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_None: 680265941bc308d65cc270d5c4de5806f37ce405606John McCall // Any other property should be ignored. 681f85e193739c953358c865005855253af4f68a497John McCall return; 682f85e193739c953358c865005855253af4f68a497John McCall } 683f85e193739c953358c865005855253af4f68a497John McCall 684f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 685135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis if (propertyImplLoc.isValid()) 686135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(propertyImplLoc, diag::note_property_synthesize); 687f85e193739c953358c865005855253af4f68a497John McCall} 688f85e193739c953358c865005855253af4f68a497John McCall 689015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// setImpliedPropertyAttributeForReadOnlyProperty - 690015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// This routine evaludates life-time attributes for a 'readonly' 691015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// property with no known lifetime of its own, using backing 692015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// 'ivar's attribute, if any. If no backing 'ivar', property's 693015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// life-time is assumed 'strong'. 694015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanianstatic void setImpliedPropertyAttributeForReadOnlyProperty( 695015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl *property, ObjCIvarDecl *ivar) { 696015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime propertyLifetime = 697015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian getImpliedARCOwnership(property->getPropertyAttributes(), 698015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->getType()); 699015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (propertyLifetime != Qualifiers::OCL_None) 700015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 701015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 702015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (!ivar) { 703015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // if no backing ivar, make property 'strong'. 704015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 705015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 706015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 707015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // property assumes owenership of backing ivar. 708015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian QualType ivarType = ivar->getType(); 709015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 710015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (ivarLifetime == Qualifiers::OCL_Strong) 711015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 712015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian else if (ivarLifetime == Qualifiers::OCL_Weak) 713015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 714015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 715015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian} 71628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 717cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// DiagnoseClassAndClassExtPropertyMismatch - diagnose inconsistant property 718cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// attribute declared in primary class and attributes overridden in any of its 719cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// class extensions. 720cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanianstatic void 721cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz JahanianDiagnoseClassAndClassExtPropertyMismatch(Sema &S, ObjCInterfaceDecl *ClassDecl, 722cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *property) { 723ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = property->getPropertyAttributesAsWritten(); 724ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool warn = (Attributes & ObjCDeclSpec::DQ_PR_readonly); 725d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCInterfaceDecl::known_extensions_iterator 726d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext = ClassDecl->known_extensions_begin(), 727d329724745b49f894b768d47275b7c2713106e89Douglas Gregor ExtEnd = ClassDecl->known_extensions_end(); 728d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext != ExtEnd; ++Ext) { 729cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *ClassExtProperty = 0; 7300dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor DeclContext::lookup_result R = Ext->lookup(property->getDeclName()); 7310dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor for (unsigned I = 0, N = R.size(); I != N; ++I) { 7320dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor ClassExtProperty = dyn_cast<ObjCPropertyDecl>(R[0]); 7330dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor if (ClassExtProperty) 734cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 735cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 7360dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor 737cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (ClassExtProperty) { 738c78ff27813288b30ee566477705353ae660fd577Fariborz Jahanian warn = false; 739cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned classExtPropertyAttr = 740cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ClassExtProperty->getPropertyAttributesAsWritten(); 741cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // We are issuing the warning that we postponed because class extensions 742cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // can override readonly->readwrite and 'setter' attributes originally 743cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // placed on class's property declaration now make sense in the overridden 744cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // property. 745ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) { 746cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (!classExtPropertyAttr || 747a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (classExtPropertyAttr & 748a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (ObjCDeclSpec::DQ_PR_readwrite| 749a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_assign | 750a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 751a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 752a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 753a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_strong))) 754cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian continue; 755cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian warn = true; 756cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 757cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 758cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 759cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 760cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (warn) { 761cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned setterAttrs = (ObjCDeclSpec::DQ_PR_assign | 762cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 763cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 764cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 765cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong); 766ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & setterAttrs) { 767cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian const char * which = 768ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 769cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "assign" : 770ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 771cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "unsafe_unretained" : 772ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 773cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "copy" : 774ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_retain) ? 775cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "retain" : "strong"; 776cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 777cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian S.Diag(property->getLocation(), 778cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian diag::warn_objc_property_attr_mutually_exclusive) 779cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << which; 780cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 781cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 782cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 783cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 784cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian} 785cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 78628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 78728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 788699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// as \@synthesize or \@dynamic. 78928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 790d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 791d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 792d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 793d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 794d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 795a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 796a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 797e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 79884e0ccff7a6e51d7b81fd58686b493a4880dd44dFariborz Jahanian dyn_cast<ObjCContainerDecl>(CurContext); 79928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 80028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 80128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 802d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 80328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 804f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis if (PropertyIvarLoc.isInvalid()) 805f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc = PropertyLoc; 806e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman SourceLocation PropertyDiagLoc = PropertyLoc; 807e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (PropertyDiagLoc.isInvalid()) 808e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PropertyDiagLoc = ClassImpDecl->getLocStart(); 80928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 81028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 81128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 81228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 81328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 81428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 81528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 81628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 81728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 81828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 81928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 82028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 82128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 82228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 82328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 82428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 82528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 826d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 82728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 828dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 82945937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 83045937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 831dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 832dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 833dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 834dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 835dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 836dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 837dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 83828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 83928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 84028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 84128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 84228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 843d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 84428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 84528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 8462b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian if (Synthesize&& 8472b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian (PIkind & ObjCPropertyDecl::OBJC_PR_readonly) && 8482b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian property->hasAttr<IBOutletAttr>() && 8492b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian !AtLoc.isValid()) { 850125643455953069b925b30d2e4ae5674063984edFariborz Jahanian bool ReadWriteProperty = false; 851125643455953069b925b30d2e4ae5674063984edFariborz Jahanian // Search into the class extensions and see if 'readonly property is 852125643455953069b925b30d2e4ae5674063984edFariborz Jahanian // redeclared 'readwrite', then no warning is to be issued. 853125643455953069b925b30d2e4ae5674063984edFariborz Jahanian for (ObjCInterfaceDecl::known_extensions_iterator 854125643455953069b925b30d2e4ae5674063984edFariborz Jahanian Ext = IDecl->known_extensions_begin(), 855125643455953069b925b30d2e4ae5674063984edFariborz Jahanian ExtEnd = IDecl->known_extensions_end(); Ext != ExtEnd; ++Ext) { 856125643455953069b925b30d2e4ae5674063984edFariborz Jahanian DeclContext::lookup_result R = Ext->lookup(property->getDeclName()); 857125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (!R.empty()) 858125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (ObjCPropertyDecl *ExtProp = dyn_cast<ObjCPropertyDecl>(R[0])) { 859125643455953069b925b30d2e4ae5674063984edFariborz Jahanian PIkind = ExtProp->getPropertyAttributesAsWritten(); 860125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) { 861125643455953069b925b30d2e4ae5674063984edFariborz Jahanian ReadWriteProperty = true; 862125643455953069b925b30d2e4ae5674063984edFariborz Jahanian break; 863125643455953069b925b30d2e4ae5674063984edFariborz Jahanian } 864125643455953069b925b30d2e4ae5674063984edFariborz Jahanian } 865125643455953069b925b30d2e4ae5674063984edFariborz Jahanian } 866125643455953069b925b30d2e4ae5674063984edFariborz Jahanian 867125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (!ReadWriteProperty) { 868a4475a6b8277f24ed15d7b67d9dab77444c77cb1Ted Kremenek Diag(property->getLocation(), diag::warn_auto_readonly_iboutlet_property) 869a4475a6b8277f24ed15d7b67d9dab77444c77cb1Ted Kremenek << property->getName(); 870125643455953069b925b30d2e4ae5674063984edFariborz Jahanian SourceLocation readonlyLoc; 871125643455953069b925b30d2e4ae5674063984edFariborz Jahanian if (LocPropertyAttribute(Context, "readonly", 872125643455953069b925b30d2e4ae5674063984edFariborz Jahanian property->getLParenLoc(), readonlyLoc)) { 873125643455953069b925b30d2e4ae5674063984edFariborz Jahanian SourceLocation endLoc = 874125643455953069b925b30d2e4ae5674063984edFariborz Jahanian readonlyLoc.getLocWithOffset(strlen("readonly")-1); 875125643455953069b925b30d2e4ae5674063984edFariborz Jahanian SourceRange ReadonlySourceRange(readonlyLoc, endLoc); 876125643455953069b925b30d2e4ae5674063984edFariborz Jahanian Diag(property->getLocation(), 877125643455953069b925b30d2e4ae5674063984edFariborz Jahanian diag::note_auto_readonly_iboutlet_fixup_suggest) << 878125643455953069b925b30d2e4ae5674063984edFariborz Jahanian FixItHint::CreateReplacement(ReadonlySourceRange, "readwrite"); 879125643455953069b925b30d2e4ae5674063984edFariborz Jahanian } 880edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 8812b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian } 882cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 883cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian DiagnoseClassAndClassExtPropertyMismatch(*this, IDecl, property); 8842b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 88528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 88628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 88728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 888d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 88928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 89028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 89128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 89228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 893d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 89428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 89528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 89628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 89728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 89828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 89928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 90028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 901d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 90228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 90328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 90428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 90528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 90628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 907d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 90828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 90928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 91028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 911d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 91228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 91328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 914e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman bool CompleteTypeErr = false; 915744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian bool compat = true; 91628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 91728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 91828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 91928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 92028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 921015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // Check that this is a previously declared 'ivar' in 'IDecl' interface 922015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared; 923015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 924265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropType = property->getType(); 925265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropertyIvarType = PropType.getNonReferenceType(); 926e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 927e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (RequireCompleteType(PropertyDiagLoc, PropertyIvarType, 928d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_incomplete_synthesized_property, 929d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor property->getDeclName())) { 930e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(property->getLocation(), diag::note_property_declare); 931e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman CompleteTypeErr = true; 932e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman } 933e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 9344e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 935015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian (property->getPropertyAttributesAsWritten() & 9363efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_readonly) && 9373efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian PropertyIvarType->isObjCRetainableType()) { 938015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian setImpliedPropertyAttributeForReadOnlyProperty(property, Ivar); 939015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 940015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 941015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl::PropertyAttributeKind kind 942015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian = property->getPropertyAttributes(); 943265941bc308d65cc270d5c4de5806f37ce405606John McCall 944265941bc308d65cc270d5c4de5806f37ce405606John McCall // Add GC __weak to the ivar type if the property is weak. 945265941bc308d65cc270d5c4de5806f37ce405606John McCall if ((kind & ObjCPropertyDecl::OBJC_PR_weak) && 9464e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 9474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie assert(!getLangOpts().ObjCAutoRefCount); 948265941bc308d65cc270d5c4de5806f37ce405606John McCall if (PropertyIvarType.isObjCGCStrong()) { 949e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_gc_weak_property_strong_type); 950265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(property->getLocation(), diag::note_property_declare); 951265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 952265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType = 953265941bc308d65cc270d5c4de5806f37ce405606John McCall Context.getObjCGCQualType(PropertyIvarType, Qualifiers::Weak); 954edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 955edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 956e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (AtLoc.isInvalid()) { 957e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // Check when default synthesizing a property that there is 958e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // an ivar matching property name and issue warning; since this 959e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // is the most common case of not using an ivar used for backing 960e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // property in non-default synthesis case. 961e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 962e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCIvarDecl *originalIvar = 963e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian IDecl->lookupInstanceVariable(property->getIdentifier(), 964e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ClassDeclared); 965e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (originalIvar) { 966e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(PropertyDiagLoc, 967e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian diag::warn_autosynthesis_property_ivar_match) 9682578532c7323efdd68ec42a31b7bdf72e5218867Fariborz Jahanian << PropertyId << (Ivar == 0) << PropertyIvar 96920e7d992140cc6bc94f2e65f3638346527150756Fariborz Jahanian << originalIvar->getIdentifier(); 970e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 971e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(originalIvar->getLocation(), diag::note_ivar_decl); 972dd3284b17829adfd542ecf4a7b4423dce1d7502bFariborz Jahanian } 973e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian } 974e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian 975e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (!Ivar) { 976265941bc308d65cc270d5c4de5806f37ce405606John McCall // In ARC, give the ivar a lifetime qualifier based on the 977f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 9784e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 979265941bc308d65cc270d5c4de5806f37ce405606John McCall !PropertyIvarType.getObjCLifetime() && 980265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType->isObjCRetainableType()) { 981f85e193739c953358c865005855253af4f68a497John McCall 982265941bc308d65cc270d5c4de5806f37ce405606John McCall // It's an error if we have to do this and the user didn't 983265941bc308d65cc270d5c4de5806f37ce405606John McCall // explicitly write an ownership attribute on the property. 984473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 985265941bc308d65cc270d5c4de5806f37ce405606John McCall !(kind & ObjCPropertyDecl::OBJC_PR_strong)) { 986e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, 987473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 988473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 989265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 990265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime lifetime = 991265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(kind, PropertyIvarType); 992265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(lifetime && "no lifetime for property?"); 9936dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (lifetime == Qualifiers::OCL_Weak) { 9946dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian bool err = false; 9956dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (const ObjCObjectPointerType *ObjT = 996a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith PropertyIvarType->getAs<ObjCObjectPointerType>()) { 997a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith const ObjCInterfaceDecl *ObjI = ObjT->getInterfaceDecl(); 998a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith if (ObjI && ObjI->isArcWeakrefUnavailable()) { 99980abce3d1597edaf427f65ce15d8433f3f13315dFariborz Jahanian Diag(property->getLocation(), 100080abce3d1597edaf427f65ce15d8433f3f13315dFariborz Jahanian diag::err_arc_weak_unavailable_property) << PropertyIvarType; 100180abce3d1597edaf427f65ce15d8433f3f13315dFariborz Jahanian Diag(ClassImpDecl->getLocation(), diag::note_implemented_by_class) 100280abce3d1597edaf427f65ce15d8433f3f13315dFariborz Jahanian << ClassImpDecl->getName(); 10036dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian err = true; 10046dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 1005a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith } 10060a7dd788dbef975f35f273c7ab913f480f7edd60John McCall if (!err && !getLangOpts().ObjCARCWeak) { 1007e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_arc_weak_no_runtime); 10086dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 10096dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 1010f85e193739c953358c865005855253af4f68a497John McCall } 10116dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian 1012f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 1013265941bc308d65cc270d5c4de5806f37ce405606John McCall qs.addObjCLifetime(lifetime); 1014f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 1015f85e193739c953358c865005855253af4f68a497John McCall } 1016f85e193739c953358c865005855253af4f68a497John McCall } 1017f85e193739c953358c865005855253af4f68a497John McCall 1018f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 10194e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().ObjCAutoRefCount && 10204e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() == LangOptions::NonGC) { 1021e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_synthesize_weak_non_arc_or_gc); 1022f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 1023f85e193739c953358c865005855253af4f68a497John McCall } 1024f85e193739c953358c865005855253af4f68a497John McCall 1025ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 1026f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc,PropertyIvarLoc, PropertyIvar, 102714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 10287504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 1029ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 1030e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (CompleteTypeErr) 1031e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->setInvalidDecl(); 103229fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 10331b7f9cbed1b96b58a6e5f7808ebc9345a76a0936Richard Smith IDecl->makeDeclVisibleInContext(Ivar); 103428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 1035260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (getLangOpts().ObjCRuntime.isFragile()) 1036e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_missing_property_ivar_decl) 1037e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman << PropertyId; 103828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 103928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 1040260611a32535c851237926bfcf78869b13c07d5bJohn McCall } else if (getLangOpts().ObjCRuntime.isNonFragile() && 104160ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor !declaresSameEntity(ClassDeclared, IDecl)) { 1042e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_ivar_in_superclass_use) 104328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 104428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 104528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 10464087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 104728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 104828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 10495bf5c2ec54ede5352293e5739e9b44bea2f6b01bAnna Zaks property->setPropertyIvarDecl(Ivar); 10505bf5c2ec54ede5352293e5739e9b44bea2f6b01bAnna Zaks 105128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 105228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 105328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 1054744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (!Context.hasSameType(PropertyIvarType, IvarType)) { 105514086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 1056f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 1057b3cd3c0c8a234803dcb9b9c0dfe10106674141cdRichard Smith compat = 105862ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 105914086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 106062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 1061b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 1062f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis compat = (CheckAssignmentConstraints(PropertyIvarLoc, PropertyIvarType, 1063f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis IvarType) 1064daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 1065b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 106662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 1067e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_ivar_type) 1068f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 1069f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 1070f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 107128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 107228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 107328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1074744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian else { 1075744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // FIXME! Rules for properties are somewhat different that those 1076744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // for assignments. Use a new routine to consolidate all cases; 1077744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // specifically for property redeclarations as well as for ivars. 1078744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 1079744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 1080744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (lhsType != rhsType && 1081744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian lhsType->isArithmeticType()) { 1082744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(PropertyDiagLoc, diag::error_property_ivar_type) 1083744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << property->getDeclName() << PropType 1084744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << Ivar->getDeclName() << IvarType; 1085744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 1086744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // Fall thru - see previous comment 1087744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian } 108828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 108928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 1090f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 10914e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC)) { 1092e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_weak_property) 109328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 1094edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 109528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 109628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1097f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 109828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 109928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 11004e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 1101e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_strong_property) 110228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 110328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 110428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 110528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 11064e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1107f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 110828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 110928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 1110e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_dynamic_property_ivar_decl); 1111f85e193739c953358c865005855253af4f68a497John McCall 111228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 111328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 111428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 111528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 111628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 111728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 111828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 1119a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 1120e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 1121744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (CompleteTypeErr || !compat) 1122e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PIDecl->setInvalidDecl(); 1123e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 112417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 112517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 1126e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 11270313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 112817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 112917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 113017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 11319a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman SynthesizedFunctionScope Scope(*this, getterMethod); 113217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 113317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1134f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 11359a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_RValue, PropertyDiagLoc); 11369a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(SelfExpr); 113717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 11389a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), PropertyDiagLoc, 11390c70181854a95fca0e0d56dfa1203eb2216052eaFariborz Jahanian Ivar->getLocation(), 114017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 114160d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 114217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 11439a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman PropertyDiagLoc, 11443c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 11453c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 11469a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman PropertyDiagLoc, 114717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 114817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 114917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 115017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 11514765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 115217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 115317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 115417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 1155831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 1156831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 1157831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 1158831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 1159831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 1160831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 1161b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian if (getLangOpts().ObjCAutoRefCount && Synthesize) 1162b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian switch (getterMethod->getMethodFamily()) { 1163b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian case OMF_retain: 1164b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian case OMF_retainCount: 1165b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian case OMF_release: 1166b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian case OMF_autorelease: 1167b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian Diag(getterMethod->getLocation(), diag::err_arc_illegal_method_def) 1168b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian << 1 << getterMethod->getSelector(); 1169b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian break; 1170b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian default: 1171b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian break; 1172b8ed071b88c1fd100eaa701f5fd7f5ebe8b9e362Fariborz Jahanian } 117317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 117417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 117517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 1176e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 1177e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->getType()->isRecordType()) { 117817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 11799a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman SynthesizedFunctionScope Scope(*this, setterMethod); 118017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 118117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1182f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 11839a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_RValue, PropertyDiagLoc); 11849a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(SelfExpr); 118517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 11869a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), PropertyDiagLoc, 11870c70181854a95fca0e0d56dfa1203eb2216052eaFariborz Jahanian Ivar->getLocation(), 118817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 118917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 119017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 11913c3b7f90a863af43fa63043d396553ecf205351cJohn McCall QualType T = Param->getType().getNonReferenceType(); 11929a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman DeclRefExpr *rhs = new (Context) DeclRefExpr(Param, false, T, 11939a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_LValue, PropertyDiagLoc); 11949a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(rhs); 11959a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman ExprResult Res = BuildBinOp(S, PropertyDiagLoc, 11962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 119757e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (property->getPropertyAttributes() & 119857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_atomic) { 119957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Expr *callExpr = Res.takeAs<Expr>(); 120057e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (const CXXOperatorCallExpr *CXXCE = 120113bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian dyn_cast_or_null<CXXOperatorCallExpr>(callExpr)) 120213bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian if (const FunctionDecl *FuncDecl = CXXCE->getDirectCallee()) 120357e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (!FuncDecl->isTrivial()) 120420abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian if (property->getType()->isReferenceType()) { 12059a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman Diag(PropertyDiagLoc, 120620abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::err_atomic_property_nontrivial_assign_op) 120757e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian << property->getType(); 120820abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian Diag(FuncDecl->getLocStart(), 120920abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::note_callee_decl) << FuncDecl; 121020abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian } 121157e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian } 121217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 121317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 121417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 121517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 121628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 121728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 121828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 121928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 122028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 122128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 122228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 122328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 122428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 122528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 122628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 122728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 122828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 122928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1230d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 123128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 123228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 12334e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCDefaultSynthProperties && 1234260611a32535c851237926bfcf78869b13c07d5bJohn McCall getLangOpts().ObjCRuntime.isNonFragile() && 123571207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek !IDecl->isObjCRequiresPropertyDefs()) { 1236ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 1237ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 1238cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 1239411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 1240ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 1241ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 1242ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1243ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 1244ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 1245ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1246ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1247cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 1248cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 124960ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor declaresSameEntity(IC->getClassInterface(), ClassDeclared)) { 1250ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 1251ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 1252ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 1253ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1254ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 125528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 125628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 125728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 125828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 1259e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_duplicate_ivar_use) 126028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 126128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 126228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 126328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 126428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 126528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 126628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 1267e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_implemented) << PropertyId; 126828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1269d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 127028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 127128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 127228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 127328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 1274d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 127528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 127628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 127728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 127828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 127928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 128028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 12819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 12829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 12839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 12849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 12859d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 12869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 12879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 12889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 12899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 12909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 12919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 12929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 12939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 12949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 12959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 12969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 12979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 12989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 12999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 13001b46d8d78be713c546fb9680eaeea8f793bee5bfFariborz Jahanian else if (!(SAttr & ObjCPropertyDecl::OBJC_PR_readonly)){ 1301f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 1302f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 1303f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1304f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 1305f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 1306f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1307f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 1308f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 1309f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 1310f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 1311f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 1312f85e193739c953358c865005855253af4f68a497John McCall } 13139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 1315b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 13169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 13179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 1318b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 1319b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian } 1320b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian if (Property->getSetterName() != SuperProperty->getSetterName()) { 13219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 13229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 1323b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 1324b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian } 1325b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian if (Property->getGetterName() != SuperProperty->getGetterName()) { 13269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 13279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 1328b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 1329b7b25659355d736a4f19099d96acc54d672340a5Fariborz Jahanian } 13309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 13329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 13339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 13349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 13359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1336c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 13378beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 13388beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 13398beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 13408beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 13418beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 13428beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 134313546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian IncompatibleObjC) { 13448beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 13458beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 134613546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 134713546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian } 13489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 13539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 13549abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!GetterMethod) 13559abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return false; 13569abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType GetterType = GetterMethod->getResultType().getNonReferenceType(); 13579abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType PropertyIvarType = property->getType().getNonReferenceType(); 13589abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian bool compat = Context.hasSameType(PropertyIvarType, GetterType); 13599abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 13609abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) && 13619abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian isa<ObjCObjectPointerType>(GetterType)) 13629abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = 13639abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Context.canAssignObjCInterfaces( 1364490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian GetterType->getAs<ObjCObjectPointerType>(), 1365490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>()); 1366490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian else if (CheckAssignmentConstraints(Loc, GetterType, PropertyIvarType) 13679abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian != Compatible) { 13689abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::error_property_accessor_type) 13699abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() << PropertyIvarType 13709abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector() << GetterType; 13719abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 13729abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 13739abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } else { 13749abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = true; 13759abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 13769abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType rhsType =Context.getCanonicalType(GetterType).getUnqualifiedType(); 13779abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (lhsType != rhsType && lhsType->isArithmeticType()) 13789abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = false; 13799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13819abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 13829abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 13839abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::warn_accessor_property_type_mismatch) 13849abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() 13859abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector(); 13869abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 13879abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 13889abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } 13899abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 13909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 13919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 13949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 13959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 13969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13970dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas GregorSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, ObjCProtocolDecl *PDecl) { 13980dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor if (!CDecl) 13990dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor return; 14000dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor 14010dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor // Category case. 14020dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor if (ObjCCategoryDecl *CatDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 14030dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor // FIXME: We should perform this check when the property in the category 14040dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor // is declared. 14059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 14069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 14079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 14089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 14090dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor ObjCPropertyDecl *ProtoProp = *P; 14100dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor DeclContext::lookup_result R 14110dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor = CatDecl->lookup(ProtoProp->getDeclName()); 14120dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor for (unsigned I = 0, N = R.size(); I != N; ++I) { 14130dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor if (ObjCPropertyDecl *CatProp = dyn_cast<ObjCPropertyDecl>(R[I])) { 14140dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor if (CatProp != ProtoProp) { 14150dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor // Property protocol already exist in class. Diagnose any mismatch. 14160dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor DiagnosePropertyMismatch(CatProp, ProtoProp, 14170dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor PDecl->getIdentifier()); 14180dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor } 14190dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor } 14200dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor } 14219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 14239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14240dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor 14250dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor // Class 14260dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor // FIXME: We should perform this check when the property in the class 14270dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor // is declared. 14280dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor ObjCInterfaceDecl *IDecl = cast<ObjCInterfaceDecl>(CDecl); 14299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 14300dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor E = PDecl->prop_end(); P != E; ++P) { 14310dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor ObjCPropertyDecl *ProtoProp = *P; 14320dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor DeclContext::lookup_result R 1433aabd094cf694039fe823987e133af7ac25cb9711Douglas Gregor = IDecl->lookup(ProtoProp->getDeclName()); 14340dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor for (unsigned I = 0, N = R.size(); I != N; ++I) { 14350dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor if (ObjCPropertyDecl *ClassProp = dyn_cast<ObjCPropertyDecl>(R[I])) { 14360dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor if (ClassProp != ProtoProp) { 14370dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor // Property protocol already exist in class. Diagnose any mismatch. 14380dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor DiagnosePropertyMismatch(ClassProp, ProtoProp, 14390dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor PDecl->getIdentifier()); 14400dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor } 14410dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor } 14429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14430dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor } 14449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 14479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 14489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 14499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 14509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 14519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 14529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 14539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 14559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 14569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 14579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 14609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 14619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 1462d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCInterfaceDecl::visible_categories_iterator 1463d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Cat = IDecl->visible_categories_begin(), 1464d329724745b49f894b768d47275b7c2713106e89Douglas Gregor CatEnd = IDecl->visible_categories_end(); 1465d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Cat != CatEnd; ++Cat) { 1466d329724745b49f894b768d47275b7c2713106e89Douglas Gregor if (Cat->getInstanceMethod(PDecl->getSetterName())) 14679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 1469d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Cat->FindPropertyDeclaration(PDecl->getIdentifier()); 14709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 14719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 14759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 14769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 14779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 14789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 14799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 14809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 14829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 14839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 14849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 14889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 14899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 14909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 14929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 14939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 14949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 14959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 14980dfe23c5d571222e74e3ed74c6fff3cee792118eDouglas Gregor/// the class and its conforming protocols; but not those in its super class. 14999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1500e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCContainerDecl::PropertyMap &PropMap, 1501e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCContainerDecl::PropertyMap &SuperPropMap) { 15029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 15039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 15049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 1505581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 15069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 15079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 150953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 151053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 151153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1512cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 15139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 15159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 15169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 15179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 1518581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 15199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 15209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 152253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 15239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1524cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 15259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 15279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 15289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1529581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1530cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1531cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1532cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1533a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian if (!PropertyFromSuper || 1534a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian PropertyFromSuper->getIdentifier() != Prop->getIdentifier()) { 1535cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1536cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1537cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1538cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 15399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 15419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 15429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1543cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 15449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 15469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1547509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1548509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1549509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1550509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1551e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCInterfaceDecl::PropertyMap &PropMap) { 1552509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1553cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian ObjCInterfaceDecl::PropertyDeclOrder PO; 1554509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1555cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian SDecl->collectPropertiesToImplement(PropMap, PO); 1556509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1557509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1558509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1559509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1560509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 156126202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian/// IvarBacksCurrentMethodAccessor - This routine returns 'true' if 'IV' is 156226202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian/// an ivar synthesized for 'Method' and 'Method' is a property accessor 156326202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian/// declared in class 'IFace'. 156426202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanianbool 156526202291b161f8598c0c342cba12c6552e44d44cFariborz JahanianSema::IvarBacksCurrentMethodAccessor(ObjCInterfaceDecl *IFace, 156626202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian ObjCMethodDecl *Method, ObjCIvarDecl *IV) { 156726202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian if (!IV->getSynthesize()) 156826202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian return false; 156926202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian ObjCMethodDecl *IMD = IFace->lookupMethod(Method->getSelector(), 157026202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian Method->isInstanceMethod()); 157126202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian if (!IMD || !IMD->isPropertyAccessor()) 157226202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian return false; 157326202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian 157426202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian // look up a property declaration whose one of its accessors is implemented 157526202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian // by this method. 157626202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IFace->prop_begin(), 157726202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian E = IFace->prop_end(); P != E; ++P) { 157826202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian ObjCPropertyDecl *property = *P; 157926202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian if ((property->getGetterName() == IMD->getSelector() || 158026202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian property->getSetterName() == IMD->getSelector()) && 158126202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian (property->getPropertyIvarDecl() == IV)) 158226202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian return true; 158326202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian } 158426202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian return false; 158526202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian} 158626202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian 158726202291b161f8598c0c342cba12c6552e44d44cFariborz Jahanian 1588699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// \brief Default synthesizes all properties which must be synthesized 1589699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// in class's \@implementation. 1590d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekvoid Sema::DefaultSynthesizeProperties(Scope *S, ObjCImplDecl* IMPDecl, 1591d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ObjCInterfaceDecl *IDecl) { 1592509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1593b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCInterfaceDecl::PropertyMap PropMap; 1594cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian ObjCInterfaceDecl::PropertyDeclOrder PropertyOrder; 1595cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian IDecl->collectPropertiesToImplement(PropMap, PropertyOrder); 1596509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1597509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1598b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCInterfaceDecl::PropertyMap SuperPropMap; 1599509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1600509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1601cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian for (unsigned i = 0, e = PropertyOrder.size(); i != e; i++) { 1602cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian ObjCPropertyDecl *Prop = PropertyOrder[i]; 1603509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 16046114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) { 16056114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian ObjCPropertyDecl *PropInSuperClass = SuperPropMap[Prop->getIdentifier()]; 16066114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian if ((Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readwrite) && 16076114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian (PropInSuperClass->getPropertyAttributes() & 16081d0d2fe76496ee2f8da9f56cb7f7eb24c4ffba05Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_readonly) && 16095bdaef55d486f20346fe16f3d41324694d3ff0d5Fariborz Jahanian !IMPDecl->getInstanceMethod(Prop->getSetterName()) && 16105bdaef55d486f20346fe16f3d41324694d3ff0d5Fariborz Jahanian !IDecl->HasUserDeclaredSetterMethod(Prop)) { 16116114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian Diag(Prop->getLocation(), diag::warn_no_autosynthesis_property) 16126114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian << Prop->getIdentifier()->getName(); 16136114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian Diag(PropInSuperClass->getLocation(), diag::note_property_declare); 16146114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian } 1615509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 16166114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian } 1617b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks // Is there a matching property synthesize/dynamic? 1618509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 16196114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional) 1620509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 16216114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian if (ObjCPropertyImplDecl *PID = 16226114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) { 16236114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian if (PID->getPropertyDecl() != Prop) { 16246114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian Diag(Prop->getLocation(), diag::warn_no_autosynthesis_shared_ivar_property) 16256114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian << Prop->getIdentifier()->getName(); 16266114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian if (!PID->getLocation().isInvalid()) 16276114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian Diag(PID->getLocation(), diag::note_property_synthesize); 16286114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian } 16296114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian continue; 16306114a3c9baf29b3db1e0853a829ae1278285aef4Fariborz Jahanian } 1631d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1632d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1633d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 163495f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 163595f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 163695f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 163795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 163895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 163995f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1640f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian if (isa<ObjCProtocolDecl>(Prop->getDeclContext())) { 1641f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian // We won't auto-synthesize properties declared in protocols. 1642f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(IMPDecl->getLocation(), 1643f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian diag::warn_auto_synthesizing_protocol_property); 1644f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(Prop->getLocation(), diag::note_property_declare); 1645f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian continue; 1646f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian } 16472a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 16482a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 16492a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 16502a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 16512a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 1652975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ObjCPropertyImplDecl *PIDecl = dyn_cast_or_null<ObjCPropertyImplDecl>( 1653975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1654975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian true, 1655975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian /* property = */ Prop->getIdentifier(), 1656ad0ce53c8219456938405b84c5d13341a47e3d94Anna Zaks /* ivar = */ Prop->getDefaultSynthIvarName(Context), 1657390fff8e8b480fa146ffc14cbc63a1c2f9e2d206Argyrios Kyrtzidis Prop->getLocation())); 1658975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian if (PIDecl) { 1659975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian Diag(Prop->getLocation(), diag::warn_missing_explicit_synthesis); 16605ea66619a3108e2985e952b9a60a84316d464b25Fariborz Jahanian Diag(IMPDecl->getLocation(), diag::note_while_in_implementation); 1661975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian } 16622a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1663509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 16649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16658697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 1666260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (!LangOpts.ObjCDefaultSynthProperties || LangOpts.ObjCRuntime.isFragile()) 16678697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 16688697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 16698697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 16708697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 16718697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 167271207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (!IDecl->isObjCRequiresPropertyDefs()) 1673eb4f2c56c298071d58b441ccf801b039be93788aFariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 16748697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 16758697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 167617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 1677c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian ObjCContainerDecl *CDecl) { 1678277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian ObjCContainerDecl::PropertyMap NoNeedToImplPropMap; 1679277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian ObjCInterfaceDecl *IDecl; 1680277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // Gather properties which need not be implemented in this class 1681277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // or category. 1682277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (!(IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl))) 1683277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) { 1684277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // For categories, no need to implement properties declared in 1685277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // its primary class (and its super classes) if property is 1686277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // declared in one of those containers. 1687cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian if ((IDecl = C->getClassInterface())) { 1688cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian ObjCInterfaceDecl::PropertyDeclOrder PO; 1689cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian IDecl->collectPropertiesToImplement(NoNeedToImplPropMap, PO); 1690cfaed8d399a34e79fbab9f70eb4ea1bbeb81a02bFariborz Jahanian } 1691277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian } 1692277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (IDecl) 1693277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, NoNeedToImplPropMap); 1694cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 1695b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCContainerDecl::PropertyMap PropMap; 1696277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, NoNeedToImplPropMap); 16979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 16989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 16999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 17019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 17029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 17039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 1704262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie PropImplMap.insert(I->getPropertyDecl()); 17059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1706c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian SelectorSet InsMap; 1707c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // Collect property accessors implemented in current implementation. 1708c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian for (ObjCImplementationDecl::instmeth_iterator 1709c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian I = IMPDecl->instmeth_begin(), E = IMPDecl->instmeth_end(); I!=E; ++I) 1710c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian InsMap.insert((*I)->getSelector()); 1711c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian 1712c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl); 1713c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian ObjCInterfaceDecl *PrimaryClass = 0; 1714c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if (C && !C->IsClassExtension()) 1715c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if ((PrimaryClass = C->getClassInterface())) 1716c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // Report unimplemented properties in the category as well. 1717c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if (ObjCImplDecl *IMP = PrimaryClass->getImplementation()) { 1718c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // When reporting on missing setter/getters, do not report when 1719c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // setter/getter is implemented in category's primary class 1720c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // implementation. 1721c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian for (ObjCImplementationDecl::instmeth_iterator 1722c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian I = IMP->instmeth_begin(), E = IMP->instmeth_end(); I!=E; ++I) 1723c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian InsMap.insert((*I)->getSelector()); 1724c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian } 1725c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian 1726b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks for (ObjCContainerDecl::PropertyMap::iterator 17279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 17289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 17299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 17309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 17319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 17327cdc45751cb5b200ad5fff0de28c5d1a64b6fce3Douglas Gregor PropImplMap.count(Prop) || 17337cdc45751cb5b200ad5fff0de28c5d1a64b6fce3Douglas Gregor Prop->getAvailability() == AR_Unavailable) 17349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 1735c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // When reporting on missing property getter implementation in 1736c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // categories, do not report when they are declared in primary class, 1737c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // class's protocol, or one of it super classes. This is because, 1738c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // the class is going to implement them. 1739c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if (!InsMap.count(Prop->getGetterName()) && 1740c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian (PrimaryClass == 0 || 1741f3f0f357f8d6b4511b6d605cc8a39ae3787fef6dFariborz Jahanian !PrimaryClass->lookupPropertyAccessor(Prop->getGetterName(), C))) { 1742b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 17439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 17449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 17459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 17469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1747b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1748b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1749260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1750da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 175171207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1752da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 1753da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian 17549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 1755c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // When reporting on missing property setter implementation in 1756c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // categories, do not report when they are declared in primary class, 1757c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // class's protocol, or one of it super classes. This is because, 1758c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian // the class is going to implement them. 1759c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName()) && 1760c775b1a0702621e297d00452a897381c8bf10f3fFariborz Jahanian (PrimaryClass == 0 || 1761f3f0f357f8d6b4511b6d605cc8a39ae3787fef6dFariborz Jahanian !PrimaryClass->lookupPropertyAccessor(Prop->getSetterName(), C))) { 1762b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 17639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 17649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 17659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 17669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1767b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1768b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1769260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1770da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 177171207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1772da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 17739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 17769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 17789d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 17799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 17809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 17814e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC) 17829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 17839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 17849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 17859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 1786581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Property = *I; 178794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 178894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 178994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 179094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1791ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = Property->getPropertyAttributes(); 1792265941bc308d65cc270d5c4de5806f37ce405606John McCall unsigned AttributesAsWritten = Property->getPropertyAttributesAsWritten(); 179394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1794265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic) && 1795265941bc308d65cc270d5c4de5806f37ce405606John McCall !(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 179694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 179794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 179894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 179994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 180094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 180194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1802293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 180394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 180494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 180594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 180694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 180794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1808293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 180994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 181094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 181194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 181294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 18139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 1814ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 1815ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 18169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 18179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 18189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 18199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 18209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 182194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 182294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 182394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 182494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 182594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 18269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 18279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 18289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 18299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 18309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 18317d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << Property->getIdentifier() << (GetterMethod != 0) 18327d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << (SetterMethod != 0); 183377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // fixit stuff. 183477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (!AttributesAsWritten) { 183577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (Property->getLParenLoc().isValid()) { 183677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 183777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), 183877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getLParenLoc()); 183977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 184077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic"); 184177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 184277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else { 184377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian //@property id etc. 184477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = 184577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getTypeSourceInfo()->getTypeLoc().getBeginLoc(); 184677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian endLoc = endLoc.getLocWithOffset(-1); 184777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 184877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 184977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic) "); 185077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 185177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 185277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic)) { 185377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 185477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = Property->getLParenLoc(); 185577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 185677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 185777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic, "); 185877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 185977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else 186077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(MethodLoc, diag::note_atomic_property_fixup_suggest); 18619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 18629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 18669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1867f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 18684e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::GCOnly) 1869f85e193739c953358c865005855253af4f68a497John McCall return; 1870f85e193739c953358c865005855253af4f68a497John McCall 1871f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1872f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1873581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyImplDecl *PID = *i; 1874f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1875f85e193739c953358c865005855253af4f68a497John McCall continue; 1876f85e193739c953358c865005855253af4f68a497John McCall 1877f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1878831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1879831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1880f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1881f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1882f85e193739c953358c865005855253af4f68a497John McCall continue; 1883f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1884f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1885f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 18864e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1887f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1888f85e193739c953358c865005855253af4f68a497John McCall else 1889920c9c1155c118ac40e5209d4b757b9f54186339Ted Kremenek Diag(PID->getLocation(), diag::warn_owning_getter_rule); 1890f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1891f85e193739c953358c865005855253af4f68a497John McCall } 1892f85e193739c953358c865005855253af4f68a497John McCall } 1893f85e193739c953358c865005855253af4f68a497John McCall } 1894f85e193739c953358c865005855253af4f68a497John McCall} 1895f85e193739c953358c865005855253af4f68a497John McCall 18965de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 18975de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 18985de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 18995de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 19005de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 19010a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 19020a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 19030a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 19040a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 19050a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 19060a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 19070a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 19080a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 19095de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 19105de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 19119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 19129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 19139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 19149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 19159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 19169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 19178254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 19188254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 19198254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 19208254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 19219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 19229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 19249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 19259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 19269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 19279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 19299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 19309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 19319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 19329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 19339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 19349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 19359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 19362aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian !Context.hasSameUnqualifiedType( 1937bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian (*SetterMethod->param_begin())->getType().getNonReferenceType(), 1938bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian property->getType().getNonReferenceType())) { 19399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 19409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 19419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 19429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 19439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 19449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 19459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 19469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 19489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 19499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 19509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 19519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 19529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 19539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 19549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 19559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 19569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1957a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1958a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1959a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1960a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1961a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1962a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 196375cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 19641e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose /*isVariadic=*/false, /*isPropertyAccessor=*/true, 196575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 19669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 19679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 19689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 19699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 19709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 19715de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 19725de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 19735de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 197423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 197523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1976a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 197723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1978831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1979831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1980831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 1981b846381fc3099b2340ba8c74d16178203a60d9a0John McCall 1982b846381fc3099b2340ba8c74d16178203a60d9a0John McCall if (getLangOpts().ObjCAutoRefCount) 1983b846381fc3099b2340ba8c74d16178203a60d9a0John McCall CheckARCMethodDecl(GetterMethod); 19849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 19859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 19869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 19871e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose GetterMethod->setPropertyAccessor(true); 19889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 19899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 19919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 19929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 19939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 19949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 19959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 19969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 19978254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 19988254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 19998254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 20008254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 20018254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 2002491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ObjCMethodDecl::Create(Context, Loc, Loc, 20038254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 200475cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 20051e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose /*isPropertyAccessor=*/true, 200675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 200775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 20089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 20099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 20108254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 20118254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 20128254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 20139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 20149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 2015ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 2016ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 20179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 2018f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 20199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 2020d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 20219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 20225543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko SetterMethod->setMethodParams(Context, Argument, None); 20235de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 20245de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 20255de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 20269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 202723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 202823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 20298254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 203023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 2031b846381fc3099b2340ba8c74d16178203a60d9a0John McCall 2032b846381fc3099b2340ba8c74d16178203a60d9a0John McCall // It's possible for the user to have set a very odd custom 2033b846381fc3099b2340ba8c74d16178203a60d9a0John McCall // setter selector that causes it to have a method family. 2034b846381fc3099b2340ba8c74d16178203a60d9a0John McCall if (getLangOpts().ObjCAutoRefCount) 2035b846381fc3099b2340ba8c74d16178203a60d9a0John McCall CheckARCMethodDecl(SetterMethod); 20369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 20379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 20389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 20391e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose SetterMethod->setPropertyAccessor(true); 20409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 20419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 20429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 20439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 20449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 20469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 20479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 20489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 20509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 20519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 20529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 20539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 20549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 20559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 20569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 20579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 2058e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis 2059e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(CD); 2060e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (!CurrentClass) { 2061e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(CD)) 2062e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Cat->getClassInterface(); 2063e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(CD)) 2064e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Impl->getClassInterface(); 2065e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis } 2066e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (GetterMethod) 2067e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(GetterMethod, CurrentClass, Sema::RTC_Unknown); 2068e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (SetterMethod) 2069e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(SetterMethod, CurrentClass, Sema::RTC_Unknown); 20709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 20719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2072d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 20739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 2074ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned &Attributes, 2075cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian bool propertyInPrimaryClass) { 20769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 2077f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 20785fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 20795fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 20805fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 2081842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 20829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 20834e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2084ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2085015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian PropertyTy->isObjCRetainableType()) { 2086015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // 'readonly' property with no obvious lifetime. 2087015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // its life time will be determined by its backing ivar. 2088015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian unsigned rel = (ObjCDeclSpec::DQ_PR_unsafe_unretained | 2089015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 2090015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 2091015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong | 2092015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_weak | 2093015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_assign); 2094ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & rel) == 0) 2095015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 2096015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 2097015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 2098cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (propertyInPrimaryClass) { 2099cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // we postpone most property diagnosis until class's implementation 2100cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // because, its readonly attribute may be overridden in its class 2101cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // extensions making other attributes, which make no sense, to make sense. 2102ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2103ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readwrite)) 2104cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2105cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << "readwrite"; 2106cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 21079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 2108ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2109ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 211028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 2111f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 211228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 2113f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 2114f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 2115ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 211628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 2117ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 211828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 2119ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 2120f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 2121ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 212228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 21239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2124ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 212528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 212628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 212728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 212828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 213028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 2131ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2132f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 2133f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 2134842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 213528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 2136ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 2137ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 2138ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2139f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 2140977ea7864a50eee39f6bef8a5a79154ac9ba4b3eJohn McCall PropertyDecl->setInvalidDecl(); 214128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 214328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 2144ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 2145ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 214628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 214728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 2148ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 214928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2150ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 215128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 215228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 2153ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 215428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2155ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2156f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2157f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 2158ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2159f85e193739c953358c865005855253af4f68a497John McCall } 21604e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2161ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2162f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2163f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 2164ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2165f85e193739c953358c865005855253af4f68a497John McCall } 2166ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 2167ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2168f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2169f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 2170ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 2171f85e193739c953358c865005855253af4f68a497John McCall } 2172ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 2173f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2174f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 2175ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2176f85e193739c953358c865005855253af4f68a497John McCall } 2177ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2178f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2179f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 2180ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2181f85e193739c953358c865005855253af4f68a497John McCall } 21824e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2183ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2184f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2185f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 2186ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2187f85e193739c953358c865005855253af4f68a497John McCall } 2188ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2189ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 219028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 219128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 2192ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 219328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2194ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2195f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2196f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 2197ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2198f85e193739c953358c865005855253af4f68a497John McCall } 2199ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 2200f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2201f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 2202ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2203f85e193739c953358c865005855253af4f68a497John McCall } 2204f85e193739c953358c865005855253af4f68a497John McCall } 2205ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2206ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2207f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2208f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 2209ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2210f85e193739c953358c865005855253af4f68a497John McCall } 2211ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 2212ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2213f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2214f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 2215ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 221628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 22179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2218ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_atomic) && 2219ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)) { 22209d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 22219d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian << "atomic" << "nonatomic"; 2222ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_atomic; 22239d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian } 22249d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian 222528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 222628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 2227ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 2228f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 2229f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 2230f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 223128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 22324e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 2233bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 2234f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian // not specified; including when property is 'readonly'. 2235bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 2236ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if (!(Attributes & ObjCDeclSpec::DQ_PR_readonly)) { 22379f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian bool isAnyClassTy = 22389f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian (PropertyTy->isObjCClassType() || 22399f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian PropertyTy->isObjCQualifiedClassType()); 22409f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // In non-gc, non-arc mode, 'Class' is treated as a 'void *' no need to 22419f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // issue any warning. 22424e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (isAnyClassTy && getLangOpts().getGC() == LangOptions::NonGC) 22439f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian ; 2244f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian else if (propertyInPrimaryClass) { 2245f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian // Don't issue warning on property with no life time in class 2246f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian // extension as it is inherited from property in primary class. 2247bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 22484e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::GCOnly) 2249bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 22500a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 2251bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 22524e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::NonGC) 2253bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 22549f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian } 2255bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 22569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 225728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 225828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 225928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 226028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 226128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 22629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2263ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 2264ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 22654e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie && getLangOpts().getGC() == LangOptions::GCOnly 226628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 226728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 2268ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2269ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2270ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 2271528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian PropertyTy->isBlockPointerType()) 2272528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Diag(Loc, diag::warn_objc_property_retain_of_block); 227348a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 2274ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2275ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_setter)) 227648a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian Diag(Loc, diag::warn_objc_readonly_property_has_setter); 227748a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 22789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 2279