SemaObjCProperty.cpp revision c80553efdc269dabd4ed0c3210555f45729ab5dd
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian#include "clang/AST/ExprCXX.h" 20c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis#include "clang/AST/ASTMutationListener.h" 2150df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 29265941bc308d65cc270d5c4de5806f37ce405606John McCall/// getImpliedARCOwnership - Given a set of property attributes and a 30265941bc308d65cc270d5c4de5806f37ce405606John McCall/// type, infer an expected lifetime. The type's ownership qualification 31265941bc308d65cc270d5c4de5806f37ce405606John McCall/// is not considered. 32265941bc308d65cc270d5c4de5806f37ce405606John McCall/// 33265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Returns OCL_None if the attributes as stated do not imply an ownership. 34265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Never returns OCL_Autoreleasing. 35265941bc308d65cc270d5c4de5806f37ce405606John McCallstatic Qualifiers::ObjCLifetime getImpliedARCOwnership( 36265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attrs, 37265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType type) { 38265941bc308d65cc270d5c4de5806f37ce405606John McCall // retain, strong, copy, weak, and unsafe_unretained are only legal 39265941bc308d65cc270d5c4de5806f37ce405606John McCall // on properties of retainable pointer type. 40265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & (ObjCPropertyDecl::OBJC_PR_retain | 41265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_strong | 42265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 435fa065b55bd622f20656e0de3b1f122951146784Fariborz Jahanian return type->getObjCARCImplicitLifetime(); 44265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_weak) { 45265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Weak; 46265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_unsafe_unretained) { 47265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 48265941bc308d65cc270d5c4de5806f37ce405606John McCall } 49265941bc308d65cc270d5c4de5806f37ce405606John McCall 50265941bc308d65cc270d5c4de5806f37ce405606John McCall // assign can appear on other types, so we have to check the 51265941bc308d65cc270d5c4de5806f37ce405606John McCall // property type. 52265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & ObjCPropertyDecl::OBJC_PR_assign && 53265941bc308d65cc270d5c4de5806f37ce405606John McCall type->isObjCRetainableType()) { 54265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 55265941bc308d65cc270d5c4de5806f37ce405606John McCall } 56265941bc308d65cc270d5c4de5806f37ce405606John McCall 57265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_None; 58265941bc308d65cc270d5c4de5806f37ce405606John McCall} 59265941bc308d65cc270d5c4de5806f37ce405606John McCall 60f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 61f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 62f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 63f85e193739c953358c865005855253af4f68a497John McCall 64f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 65f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 66f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 67f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 68f85e193739c953358c865005855253af4f68a497John McCall 69f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 70f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 71f85e193739c953358c865005855253af4f68a497John McCall 72265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime expectedLifetime 73265941bc308d65cc270d5c4de5806f37ce405606John McCall = getImpliedARCOwnership(propertyKind, property->getType()); 74265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!expectedLifetime) { 75f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 76265941bc308d65cc270d5c4de5806f37ce405606John McCall // attribute. That's okay, but restore reasonable invariants by 77265941bc308d65cc270d5c4de5806f37ce405606John McCall // setting the property attribute according to the lifetime 78265941bc308d65cc270d5c4de5806f37ce405606John McCall // qualifier. 79265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attr; 80265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == Qualifiers::OCL_Strong) { 81265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_strong; 82265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak) { 83265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_weak; 84265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 85265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(propertyLifetime == Qualifiers::OCL_ExplicitNone); 86265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 87265941bc308d65cc270d5c4de5806f37ce405606John McCall } 88265941bc308d65cc270d5c4de5806f37ce405606John McCall property->setPropertyAttributes(attr); 89f85e193739c953358c865005855253af4f68a497John McCall return; 90f85e193739c953358c865005855253af4f68a497John McCall } 91f85e193739c953358c865005855253af4f68a497John McCall 92f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 93f85e193739c953358c865005855253af4f68a497John McCall 94f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 95f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 96b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 97f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 98265941bc308d65cc270d5c4de5806f37ce405606John McCall << expectedLifetime 99f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 100f85e193739c953358c865005855253af4f68a497John McCall} 101f85e193739c953358c865005855253af4f68a497John McCall 102d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 103d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 104d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 105d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 106d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 107d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 1084a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 1094a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 11028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 111f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 112f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 113e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if ((getLangOptions().getGC() != LangOptions::NonGC && 114f85e193739c953358c865005855253af4f68a497John McCall T.isObjCGCWeak()) || 115f85e193739c953358c865005855253af4f68a497John McCall (getLangOptions().ObjCAutoRefCount && 116f85e193739c953358c865005855253af4f68a497John McCall T.getObjCLifetime() == Qualifiers::OCL_Weak)) 117f85e193739c953358c865005855253af4f68a497John McCall Attributes |= ObjCDeclSpec::DQ_PR_weak; 118f85e193739c953358c865005855253af4f68a497John McCall 11928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 12028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 12128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 12228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 12328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 12428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 12528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 12628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 127f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 128f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 129f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 130f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 13114086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 132e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 133a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 134e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 13528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 136ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 137a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian Decl *Res = HandlePropertyInClassExtension(S, AtLoc, 138ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 139ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 140ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 141dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 142ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 143ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 144f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 145ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 146f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 147f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 148f85e193739c953358c865005855253af4f68a497John McCall } 149ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 150ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 151ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 152f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 153f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 154f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 155dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis Attributes, 156dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 157dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis TSI, MethodImplKind); 1584a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1594a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1604a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 161842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 162842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 163f85e193739c953358c865005855253af4f68a497John McCall 164f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 165f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 166f85e193739c953358c865005855253af4f68a497John McCall 167842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 169e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 170b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidisstatic ObjCPropertyDecl::PropertyAttributeKind 171b98ffded10453d80369951f33f3892f35d747c95Argyrios KyrtzidismakePropertyAttributesAsWritten(unsigned Attributes) { 172b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 173b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 174b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 175b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 176b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 177b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_getter) 178b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 179b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_setter) 180b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 181b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_assign) 182b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 183b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_retain) 184b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 185b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_strong) 186b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 187b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_weak) 188b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 189b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_copy) 190b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 191b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 192b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 193b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 194b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 195b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 196b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 197b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 198b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis return (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten; 199b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis} 200b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 201d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 202a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 203e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 204e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 205e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 206e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 207e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 208dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 209e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 21083a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 211e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 21258a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 213e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 214a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 215e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 2162a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 2172a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 2182a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 2192a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 2202a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 2212a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 2222a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 2232a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 2242a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 2252a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 2262a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 2272a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 2282a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 2292a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2302a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2312a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 232e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 233e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 23488f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 235e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 236e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 237e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 238b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 239dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 24022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 24122f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 24222f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 24322f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 24488f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 24588f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 24688f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 24791ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 248e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 249e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 250e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 251e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 252e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 253e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 254e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 255d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 256e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 257e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 258e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 259e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 260e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 261e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 262e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 263e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 264e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 265e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 266e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 267e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 268dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis Attributes,AttributesAsWritten, T, MethodImplKind, DC); 269e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 270e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 271e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 272e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 273a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek ProcessPropertyDecl(PDecl, CCPrimary, /* redeclaredProperty = */ 0, 274a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 275c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 276c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PDecl, /*OrigProp=*/0, CDecl); 277d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PDecl; 278e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 279a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian if (PIDecl->getType().getCanonicalType() 280a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian != PDecl->getType().getCanonicalType()) { 281a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian Diag(AtLoc, 28268af536046461b514b59aedac016b52784ece3f7Fariborz Jahanian diag::warn_type_mismatch_continuation_class) << PDecl->getType(); 283a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian Diag(PIDecl->getLocation(), diag::note_property_declare); 284a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian } 285a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian 286e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 287e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 28880aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 289e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 290e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 291e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 292f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 293e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 294e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 295e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 296e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 297e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 298e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 299e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 3009944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 3019944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 3029944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 303e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 304e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 305e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 306e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 307e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 308e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 309e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 310e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 311a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 312a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 3137939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 3147939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 315d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 316e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 317e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 318e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 319a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 3204a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 3214a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 322d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 32328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 324e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 325e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 326e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 327f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 328f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 329e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 330e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 331e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 332e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 333788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 334788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 335788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 336788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 337788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 338788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 339788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 340788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 341788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 342788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 343e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 344e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 345e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 346e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 347e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 3488254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 349c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 350c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PDecl, PIDecl, CDecl); 351d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 352e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 353e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 354e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 355e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 356e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 357e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 358e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 359e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 360e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 361e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 362e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 363dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 36483a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 36523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 36623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 367e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 36883a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 37128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 372e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::NonGC && 37328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 374c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 375c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 376c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 377c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 378c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 379c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 380c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 381c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 38228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 383c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 38428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 38528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 386e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 38728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 38828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 38983a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 390e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 3919f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 3929f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 39328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 394894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 39528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 39628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 39723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 39828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 39923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 40023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 40123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 40228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 40328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 40428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 40528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 40628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 40728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 40928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 41028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 41128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 41328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 4140a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 415dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 4160a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 41728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 41828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 41928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 42028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 42128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 42228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 42328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 42428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 42528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 42628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 42728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 42828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 42928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 43028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 43128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 432f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 433f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 434f85e193739c953358c865005855253af4f68a497John McCall 435f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) 436f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 437f85e193739c953358c865005855253af4f68a497John McCall 43828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 43928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 44028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 441f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 442f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 443f85e193739c953358c865005855253af4f68a497John McCall 44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 44528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 44628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 447265941bc308d65cc270d5c4de5806f37ce405606John McCall // In the semantic attributes, one of nonatomic or atomic is always set. 44828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 44928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 450265941bc308d65cc270d5c4de5806f37ce405606John McCall else 45145937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 45228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 453f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 454f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 455f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 456f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 457f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 458f85e193739c953358c865005855253af4f68a497John McCall 45928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 46028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 46128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 46228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 46328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 464e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 46528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 46628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 467f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 468f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 469f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 470f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 471f85e193739c953358c865005855253af4f68a497John McCall 472f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 473f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 474f85e193739c953358c865005855253af4f68a497John McCall 475265941bc308d65cc270d5c4de5806f37ce405606John McCall // The lifetime implied by the property's attributes. 476265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime propertyLifetime = 477265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(property->getPropertyAttributes(), 478265941bc308d65cc270d5c4de5806f37ce405606John McCall property->getType()); 479f85e193739c953358c865005855253af4f68a497John McCall 480265941bc308d65cc270d5c4de5806f37ce405606John McCall // We're fine if they match. 481265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == ivarLifetime) return; 482f85e193739c953358c865005855253af4f68a497John McCall 483265941bc308d65cc270d5c4de5806f37ce405606John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 484265941bc308d65cc270d5c4de5806f37ce405606John McCall if (ivarLifetime == Qualifiers::OCL_None || 485265941bc308d65cc270d5c4de5806f37ce405606John McCall ivarLifetime == Qualifiers::OCL_Autoreleasing) 486265941bc308d65cc270d5c4de5806f37ce405606John McCall return; 487265941bc308d65cc270d5c4de5806f37ce405606John McCall 488265941bc308d65cc270d5c4de5806f37ce405606John McCall switch (propertyLifetime) { 489265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Strong: 490265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_strong_property_ownership) 491265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 492265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 493265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivarLifetime; 494265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 495265941bc308d65cc270d5c4de5806f37ce405606John McCall 496265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Weak: 497265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::error_weak_property) 498265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 499265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName(); 500265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 501265941bc308d65cc270d5c4de5806f37ce405606John McCall 502265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_ExplicitNone: 503265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_assign_property_ownership) 504265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 505265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 506265941bc308d65cc270d5c4de5806f37ce405606John McCall << ((property->getPropertyAttributesAsWritten() 507265941bc308d65cc270d5c4de5806f37ce405606John McCall & ObjCPropertyDecl::OBJC_PR_assign) != 0); 508265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 509265941bc308d65cc270d5c4de5806f37ce405606John McCall 510265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Autoreleasing: 511265941bc308d65cc270d5c4de5806f37ce405606John McCall llvm_unreachable("properties cannot be autoreleasing"); 512265941bc308d65cc270d5c4de5806f37ce405606John McCall 513265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_None: 514265941bc308d65cc270d5c4de5806f37ce405606John McCall // Any other property should be ignored. 515f85e193739c953358c865005855253af4f68a497John McCall return; 516f85e193739c953358c865005855253af4f68a497John McCall } 517f85e193739c953358c865005855253af4f68a497John McCall 518f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 519f85e193739c953358c865005855253af4f68a497John McCall} 520f85e193739c953358c865005855253af4f68a497John McCall 52128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 52228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 52328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 52428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 52528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 526d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 527d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 528d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 529d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 530d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 531a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 532a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 533e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 53484e0ccff7a6e51d7b81fd58686b493a4880dd44dFariborz Jahanian dyn_cast<ObjCContainerDecl>(CurContext); 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 538d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 54028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 54128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 54228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 54328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 54428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 54528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 54628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 54728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 54828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 54928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 55028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 55128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 55228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 55328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 55428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 55628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 557d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 55828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 559dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 56045937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 56145937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 562dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 563dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 564dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 565dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 566dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 567dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 568dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 56928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 57128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 57228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 57328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 574d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 57528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 57628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 57728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 57828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 580d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 58328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 58428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 585d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 58828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 58928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 59028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 59128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 59228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 593d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 59428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 59528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 59628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 59728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 59828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 599d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 60028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 60128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 60228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 603d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 60428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 60528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 60628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 60728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 60828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 60928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 61028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 611f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind kind 612f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 613265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropType = property->getType(); 614265941bc308d65cc270d5c4de5806f37ce405606John McCall 615265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropertyIvarType = PropType.getNonReferenceType(); 616265941bc308d65cc270d5c4de5806f37ce405606John McCall 617265941bc308d65cc270d5c4de5806f37ce405606John McCall // Add GC __weak to the ivar type if the property is weak. 618265941bc308d65cc270d5c4de5806f37ce405606John McCall if ((kind & ObjCPropertyDecl::OBJC_PR_weak) && 619e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC) { 620265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(!getLangOptions().ObjCAutoRefCount); 621265941bc308d65cc270d5c4de5806f37ce405606John McCall if (PropertyIvarType.isObjCGCStrong()) { 622265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(PropertyLoc, diag::err_gc_weak_property_strong_type); 623265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(property->getLocation(), diag::note_property_declare); 624265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 625265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType = 626265941bc308d65cc270d5c4de5806f37ce405606John McCall Context.getObjCGCQualType(PropertyIvarType, Qualifiers::Weak); 627edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 628edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 629265941bc308d65cc270d5c4de5806f37ce405606John McCall 63028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 63128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 63228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 63328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 634265941bc308d65cc270d5c4de5806f37ce405606John McCall // In ARC, give the ivar a lifetime qualifier based on the 635f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 636f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 637265941bc308d65cc270d5c4de5806f37ce405606John McCall !PropertyIvarType.getObjCLifetime() && 638265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType->isObjCRetainableType()) { 639f85e193739c953358c865005855253af4f68a497John McCall 640265941bc308d65cc270d5c4de5806f37ce405606John McCall // It's an error if we have to do this and the user didn't 641265941bc308d65cc270d5c4de5806f37ce405606John McCall // explicitly write an ownership attribute on the property. 642473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 643265941bc308d65cc270d5c4de5806f37ce405606John McCall !(kind & ObjCPropertyDecl::OBJC_PR_strong)) { 644473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(PropertyLoc, 645473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 646473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 647265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 648265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime lifetime = 649265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(kind, PropertyIvarType); 650265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(lifetime && "no lifetime for property?"); 651473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis 652265941bc308d65cc270d5c4de5806f37ce405606John McCall if (lifetime == Qualifiers::OCL_Weak && 653265941bc308d65cc270d5c4de5806f37ce405606John McCall !getLangOptions().ObjCRuntimeHasWeak) { 654f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::err_arc_weak_no_runtime); 655f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 656f85e193739c953358c865005855253af4f68a497John McCall } 657265941bc308d65cc270d5c4de5806f37ce405606John McCall 658f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 659265941bc308d65cc270d5c4de5806f37ce405606John McCall qs.addObjCLifetime(lifetime); 660f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 661f85e193739c953358c865005855253af4f68a497John McCall } 662f85e193739c953358c865005855253af4f68a497John McCall } 663f85e193739c953358c865005855253af4f68a497John McCall 664f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 665f85e193739c953358c865005855253af4f68a497John McCall !getLangOptions().ObjCAutoRefCount && 666e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() == LangOptions::NonGC) { 667f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::error_synthesize_weak_non_arc_or_gc); 668f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 669f85e193739c953358c865005855253af4f68a497John McCall } 670f85e193739c953358c865005855253af4f68a497John McCall 671ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 672ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara PropertyLoc, PropertyLoc, PropertyIvar, 67314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 6747504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 675ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 67629fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 67728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 67828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 67928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 68028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 68128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 68228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 68328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 68428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 68528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 68628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 68728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 68828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 68928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 6904087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 69128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 69228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 69328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 69428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 69528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 696265941bc308d65cc270d5c4de5806f37ce405606John McCall if (Context.getCanonicalType(PropertyIvarType) != IvarType) { 69762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 69814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 699f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 70062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 70162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 70214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 70362ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 704b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 705b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor SourceLocation Loc = PropertyIvarLoc; 706b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor if (Loc.isInvalid()) 707b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor Loc = PropertyLoc; 70814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian compat = (CheckAssignmentConstraints(Loc, PropertyIvarType, IvarType) 709daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 710b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 71162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 71228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 713f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 714f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 715f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 71628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 71728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 71828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 71928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 72028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 72128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 72228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 72314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 72428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 72528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 72628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 72728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 728f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 729f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 730f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 73128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 73228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 73328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 734f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 735e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC)) { 73628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 73728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 738edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 73928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 74028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 741f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 74228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 74328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 744e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC) { 74528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 74628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 74728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 74828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 74928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 750f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 751f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 75228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 75328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 75428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 755f85e193739c953358c865005855253af4f68a497John McCall 75628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 75728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 75828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 75928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 76028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 76128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 76228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 763a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 76417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 76517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 7660313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize && 7670313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 76817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 76917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 77017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 77117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 77217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 773f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 774f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 77517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 77617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 77717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 77860d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 77917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 7803c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 7813c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 7823c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 78317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 78417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 78517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 78617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 78717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 7884765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 78917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 79017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 79117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 792831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 793831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 794831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 795831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 796831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 797831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 79817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 79917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 80017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 8010313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize 8020313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian && Ivar->getType()->isRecordType()) { 80317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 80417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 80517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 806f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 807f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 80817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 80917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 81017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 81117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 81217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 8133c3b7f90a863af43fa63043d396553ecf205351cJohn McCall QualType T = Param->getType().getNonReferenceType(); 81414086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian Expr *rhs = new (Context) DeclRefExpr(Param, T, 815f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 816fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 8172de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 81857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (property->getPropertyAttributes() & 81957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_atomic) { 82057e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Expr *callExpr = Res.takeAs<Expr>(); 82157e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (const CXXOperatorCallExpr *CXXCE = 82213bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian dyn_cast_or_null<CXXOperatorCallExpr>(callExpr)) 82313bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian if (const FunctionDecl *FuncDecl = CXXCE->getDirectCallee()) 82457e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (!FuncDecl->isTrivial()) 82557e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Diag(PropertyLoc, 82657e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian diag::warn_atomic_property_nontrivial_assign_op) 82757e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian << property->getType(); 82857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian } 82917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 83017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 83117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 83217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 83328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 83428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 83528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 83628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 83728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 83828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 83928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 84028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 84128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 84228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 84328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 84428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 84528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 84628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 847d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 84828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 84928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 850e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian if (getLangOptions().ObjCDefaultSynthProperties && 851e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian getLangOptions().ObjCNonFragileABI2) { 852ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 853ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 854cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 855411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 856ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 857ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 858ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 859ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 860ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 861ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 862ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 863cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 864cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 865cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian IC->getClassInterface() == ClassDeclared) { 866ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 867ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 868ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 869ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 870ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 87128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 87228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 87328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 87428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 87528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 87628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 87728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 87828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 87928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 88028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 88128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 88228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 88328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 88428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 885d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 88628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 88728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 88828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 88928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 890d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 89128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 89228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 89328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 89428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 89528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 89628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 8979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 8989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 8999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 9019d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 9029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 9039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 9049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 9059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 9069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 9079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 9089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 9099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 9109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 9119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 9129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 9139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 9149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 9161b46d8d78be713c546fb9680eaeea8f793bee5bfFariborz Jahanian else if (!(SAttr & ObjCPropertyDecl::OBJC_PR_readonly)){ 917f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 918f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 919f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 920f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 921f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 922f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 923f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 924f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 925f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 926f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 927f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 928f85e193739c953358c865005855253af4f68a497John McCall } 9299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 9319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 9329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 9349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 9359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 9379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 9389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 9409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 9439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 946c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 9478beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 9488beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 9498beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 9508beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 9518beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 9528beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 95313546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian IncompatibleObjC) { 9548beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 9558beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 95613546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 95713546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian } 9589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 9649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 9653c3b7f90a863af43fa63043d396553ecf205351cJohn McCall !Context.hasSameType(GetterMethod->getResultType().getNonReferenceType(), 9663c3b7f90a863af43fa63043d396553ecf205351cJohn McCall property->getType().getNonReferenceType())) { 9679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 9681c23e91ef66688d20868b6bab3b5589a119eb603John McCall if (property->getType()->isObjCObjectPointerType()) 969b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor result = CheckAssignmentConstraints(Loc, GetterMethod->getResultType(), 9701c23e91ef66688d20868b6bab3b5589a119eb603John McCall property->getType()); 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 9769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 9779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 984fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 9889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 9899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 9919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 9929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 9939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 9949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 9999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 10009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 10019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 10069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 10099d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 10109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 10149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 10159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 10169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 10179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 10189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 10222d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 10329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 10349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 10469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 10479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 1049d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 1050d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 10559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 10569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 1067d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 107853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 107953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 108053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 10859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 108653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 108753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 108853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1089d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 10909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 11019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 11039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 11059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 11079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 11089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 11099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 11169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 11199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 11219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 11279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 11289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 11299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 11309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 11319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 11329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 11349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 11359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 11369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 11409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 11419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 11429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 11449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 11459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 11469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 11479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 11509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 11519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1152cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 1153cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 11549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 11559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 11569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 11579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 116153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 116253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 116353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1164cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 11679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 11689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 11699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 11709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 117453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 11759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1176cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 11799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 11809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 11819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 1182cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1183cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1184cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1185a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian if (!PropertyFromSuper || 1186a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian PropertyFromSuper->getIdentifier() != Prop->getIdentifier()) { 1187cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1188cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1189cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1190cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 11919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 11939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 11949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1195cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1199509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 1200509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 1201509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 1202509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 1203509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1204509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1205509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1206509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 1207509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1208509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1209509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 121053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 121153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 121253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1213509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1214509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1215509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1216509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1217509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 1218509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1219509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1220509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1221509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 1222509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1223509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 1224509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1225509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1226509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1227509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1228509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1229509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1230509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1231509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1232509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1233509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1234509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1235509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 1236509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1237509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1238509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1239509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1240509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 12419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 12429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 12439d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 12449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 12459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 12469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 12479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 12489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 12499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 125453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 125553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 125653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 12579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 12639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 12649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 12659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 12669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 12719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 12729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 12739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 12799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1281d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekstatic IdentifierInfo * getDefaultSynthIvarName(ObjCPropertyDecl *Prop, 1282d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ASTContext &Ctx) { 1283d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek llvm::SmallString<128> ivarName; 1284d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek { 1285d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek llvm::raw_svector_ostream os(ivarName); 1286d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek os << '_' << Prop->getIdentifier()->getName(); 1287d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek } 1288d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek return &Ctx.Idents.get(ivarName.str()); 1289d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek} 1290d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek 1291509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 1292509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 1293d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekvoid Sema::DefaultSynthesizeProperties(Scope *S, ObjCImplDecl* IMPDecl, 1294d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ObjCInterfaceDecl *IDecl) { 1295509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1296509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1297509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 1298509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1299509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1300509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1301509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1302509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1303509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1304509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1305509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1306509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1307509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1308509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1309509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1310509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1311509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1312509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1313509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1314d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1315d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1316d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 131795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 131895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 131995f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 132095f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 132195f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 132295f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1323d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian 13242a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 13252a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 13262a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 13272a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 13282a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 13292a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1330a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian true, 1331d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek /* property = */ Prop->getIdentifier(), 1332d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek /* ivar = */ getDefaultSynthIvarName(Prop, Context), 1333a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation()); 13342a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1335509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 13369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13378697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 13388697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!LangOpts.ObjCDefaultSynthProperties || !LangOpts.ObjCNonFragileABI2) 13398697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 13408697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 13418697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 13428697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 13438697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 13448697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 13458697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 13468697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 134717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 13489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 1350cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1351cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1352cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1353cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 13549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1355cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 13609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 13619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 13629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 13639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 13649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 13669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 13679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 13689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 13699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 13709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1371327126ee3d2faad9314b2633974eefc672f73b79Fariborz Jahanian PropImplMap.count(Prop) || Prop->hasAttr<UnavailableAttr>()) 13729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 13739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 1374b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 13759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1379b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1380b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 13819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1384b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 13859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1389b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1390b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 13919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13969d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 13979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 13989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 1399e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::NonGC) 14009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 14019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 14029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 14039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 14049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 140594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 140694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 140794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 140894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 14099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 1410265941bc308d65cc270d5c4de5806f37ce405606John McCall unsigned AttributesAsWritten = Property->getPropertyAttributesAsWritten(); 141194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1412265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic) && 1413265941bc308d65cc270d5c4de5806f37ce405606John McCall !(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 141494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 141594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 141694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 141794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 141894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 141994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1420293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 142194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 142294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 142394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 142494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 142594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1426293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 142794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 142894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 142994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 143094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 14319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 14329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 14339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 14349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 14359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 14369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 14379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 14389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 143994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 144094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 144194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 144294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 144394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 14449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 14459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 14469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 14479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 14489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 14497d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << Property->getIdentifier() << (GetterMethod != 0) 14507d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << (SetterMethod != 0); 14517d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian Diag(MethodLoc, diag::note_atomic_property_fixup_suggest); 14529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 14539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1458f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 1459e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() == LangOptions::GCOnly) 1460f85e193739c953358c865005855253af4f68a497John McCall return; 1461f85e193739c953358c865005855253af4f68a497John McCall 1462f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1463f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1464f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyImplDecl *PID = *i; 1465f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1466f85e193739c953358c865005855253af4f68a497John McCall continue; 1467f85e193739c953358c865005855253af4f68a497John McCall 1468f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1469831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1470831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1471f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1472f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1473f85e193739c953358c865005855253af4f68a497John McCall continue; 1474f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1475f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1476f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 1477f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 1478f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1479f85e193739c953358c865005855253af4f68a497John McCall else 1480920c9c1155c118ac40e5209d4b757b9f54186339Ted Kremenek Diag(PID->getLocation(), diag::warn_owning_getter_rule); 1481f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1482f85e193739c953358c865005855253af4f68a497John McCall } 1483f85e193739c953358c865005855253af4f68a497John McCall } 1484f85e193739c953358c865005855253af4f68a497John McCall } 1485f85e193739c953358c865005855253af4f68a497John McCall} 1486f85e193739c953358c865005855253af4f68a497John McCall 14875de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 14885de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 14895de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 14905de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 14915de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 14920a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 14930a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 14940a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 14950a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 14960a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 14970a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 14980a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 14990a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 15005de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 15015de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 15039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 15049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 15059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 15069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 15079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 15088254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 15098254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 15108254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 15118254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 15139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 15159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 15169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 15179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 15189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 15209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 15219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 15229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 15239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 15249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 15259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 15269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 15272aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian !Context.hasSameUnqualifiedType( 1528bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian (*SetterMethod->param_begin())->getType().getNonReferenceType(), 1529bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian property->getType().getNonReferenceType())) { 15309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 15319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 15329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 15339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 15349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 15359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 15399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 15409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 15419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 15429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 15439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 15449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 15459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 15469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 15479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1548a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1549a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1550a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1551a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1552a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1553a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 155475cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 155575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isVariadic=*/false, /*isSynthesized=*/true, 155675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 15579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 15609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 15619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 15625de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15635de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 15645de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 156523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 156623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1567a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 156823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1569831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1570831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1571831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 15729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 15739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 15749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 15759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 15769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 15779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 15799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 15809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 15819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 15829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 15839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 15849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 15858254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 15868254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 15878254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 15888254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15898254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 1590491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ObjCMethodDecl::Create(Context, Loc, Loc, 15918254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 159275cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 159375cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isSynthesized=*/true, 159475cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 159575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 15969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15988254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 15998254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 16008254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 16019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 16029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1603ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1604ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 16059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1606f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 16079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1608d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1609d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 16109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 1611491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis SetterMethod->setMethodParams(Context, Argument, 1612491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ArrayRef<SourceLocation>()); 16135de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 16145de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 16155de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 16169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 161723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 161823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 16198254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 162023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 16219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 16229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 16239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 16249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 16259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 16269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 16289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 16299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 16319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 16329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 16339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 16359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 16369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 16379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 16389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 16409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 16419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 16429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 16439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 16449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1645d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 16469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 16479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 16489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1649f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 16505fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 16515fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 16525fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1653842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 16549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 16569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 165728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 165828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 1659f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 166028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 1661f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 1662f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 166328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 166428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 166528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 166628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 1667f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 1668f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 166928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 167028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 16719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 167228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 167328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 167428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 167528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 167628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 167828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 1679f85e193739c953358c865005855253af4f68a497John McCall if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1680f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 1681f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 1682842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 168328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 1684f85e193739c953358c865005855253af4f68a497John McCall << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 1685f85e193739c953358c865005855253af4f68a497John McCall Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 1686f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1687f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 168828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 169028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 169128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 169228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 169328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 169428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 169528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 169628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 169728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 169828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 169928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 170028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 170128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1702f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1703f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1704f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 1705f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1706f85e193739c953358c865005855253af4f68a497John McCall } 1707f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1708f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1709f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1710f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 1711f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1712f85e193739c953358c865005855253af4f68a497John McCall } 1713f85e193739c953358c865005855253af4f68a497John McCall } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 1714f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1715f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1716f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 1717f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 1718f85e193739c953358c865005855253af4f68a497John McCall } 1719f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1720f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1721f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 1722f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1723f85e193739c953358c865005855253af4f68a497John McCall } 1724f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1725f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1726f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 1727f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1728f85e193739c953358c865005855253af4f68a497John McCall } 1729f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1730f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1731f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1732f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 1733f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1734f85e193739c953358c865005855253af4f68a497John McCall } 173528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 173628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 173728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 173828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 173928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 174028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1741f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1742f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1743f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 1744f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1745f85e193739c953358c865005855253af4f68a497John McCall } 1746f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 1747f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1748f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 1749f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1750f85e193739c953358c865005855253af4f68a497John McCall } 1751f85e193739c953358c865005855253af4f68a497John McCall } 1752f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 1753f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1754f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1755f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 1756528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1757f85e193739c953358c865005855253af4f68a497John McCall } 1758f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 1759f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1760f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1761f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 1762f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 176328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17659d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_atomic) && 17669d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)) { 17679d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 17689d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian << "atomic" << "nonatomic"; 17699d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_atomic; 17709d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian } 17719d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian 177228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 177328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 177428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 1775f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 1776f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 1777f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 177828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 1779bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().ObjCAutoRefCount) 1780bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 1781f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian // not specified; including when property is 'readonly'. 1782bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 1783f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian else if (!(Attributes & ObjCDeclSpec::DQ_PR_readonly)) { 1784bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 1785e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::GCOnly) 1786bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 17870a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 1788bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 1789e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() == LangOptions::NonGC) 1790bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 1791bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 17929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 179328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 179428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 179528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 179628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 179728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 179928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 18002b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 1801e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor && getLangOptions().getGC() == LangOptions::GCOnly 180228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 180328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 1804528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian else if (getLangOptions().ObjCAutoRefCount && 1805528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_retain) && 1806528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1807528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 1808528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian PropertyTy->isBlockPointerType()) 1809528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Diag(Loc, diag::warn_objc_property_retain_of_block); 181048a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 181148a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 181248a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_setter)) 181348a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian Diag(Loc, diag::warn_objc_readonly_property_has_setter); 181448a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 18159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1816