SemaObjCProperty.cpp revision cfa6a27f3cc5add888c6ac84dbcc45854cfd8666
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek#include "Sema.h" 1617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "SemaInit.h" 1717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted KremenekSema::DeclPtrTy Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FieldDeclarator &FD, 2728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec &ODS, 2828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Selector GetterSel, 2928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Selector SetterSel, 3028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DeclPtrTy ClassCategory, 3128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool *isOverridingProperty, 3228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 3328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 3428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 3528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 3628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 3728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 3828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 3928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 4028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 4128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 4228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_copy))); 43e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 44bf1a028246d884a540aeafa38e89be59a269b072John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 45bf1a028246d884a540aeafa38e89be59a269b072John McCall QualType T = TSI->getType(); 4628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isReferenceType()) { 4728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_reference_property); 4828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 4928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 50e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 51e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *ClassDecl = 52e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek cast<ObjCContainerDecl>(ClassCategory.getAs<Decl>()); 53e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 5428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 55e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (CDecl->IsClassExtension()) 56e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return HandlePropertyInClassExtension(S, CDecl, AtLoc, 57e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, 58e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek isAssign, isReadWrite, 59e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Attributes, 6083a230c83a54190366138c1a4f4310ef838b88fcJohn McCall isOverridingProperty, TSI, 61e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek MethodImplKind); 62e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 63842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian DeclPtrTy Res = DeclPtrTy::make(CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 64e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek GetterSel, SetterSel, 65e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek isAssign, isReadWrite, 6683a230c83a54190366138c1a4f4310ef838b88fcJohn McCall Attributes, TSI, MethodImplKind)); 67842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 68842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 69842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 70e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 71e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 72e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekSema::DeclPtrTy 73e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekSema::HandlePropertyInClassExtension(Scope *S, ObjCCategoryDecl *CDecl, 74e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 75e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 76e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 77e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 78e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 79e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 8083a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 81e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 82e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 83e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 84e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 85e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 86894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek 879f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 889f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 89e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::err_duplicate_property); 90894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 91e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return DeclPtrTy(); 92e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 93e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 94e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 95e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 96e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 97e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 98e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 9922f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 10022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 10122f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 10222f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 10322f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian 104e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 105e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 106e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 107e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 108e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 109e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 110e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 111e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 112e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return DeclPtrTy(); 113e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 114e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 115e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 116e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 117e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 118e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 119e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 120e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 121e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 122e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 123e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 124e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 12523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek Attributes, T, MethodImplKind, DC); 12680aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // Mark written attribute as having no attribute because 12780aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // this is not a user-written property declaration in primary 12880aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // class. 12980aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian PDecl->setPropertyAttributesAsWritten(ObjCPropertyDecl::OBJC_PR_noattr); 130e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 131e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 132e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 133e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 134e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProcessPropertyDecl(PDecl, CCPrimary); 135e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return DeclPtrTy::make(PDecl); 136e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 137e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 138e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 139e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 140e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 14180aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 143e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 144e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 145e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 146e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 147e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 148e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 149e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 150e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 151e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 1529944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 1539944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 1549944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 155e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 156e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 157e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 158e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 159e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 160e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 161e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 162e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 163e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 164e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclPtrTy ProtocolPtrTy = 165e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 166e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 167e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclPtrTy::make(CCPrimary), isOverridingProperty, 169e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek MethodImplKind); 170e9686572f17968048a5e097254f85c202ea44aecTed Kremenek PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy.getAs<Decl>()); 17128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 172e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 173e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 174e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 175e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 176e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 177e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 178e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 179e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::err_use_continuation_class) 180e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 183e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 184e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 185e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary); 186e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return DeclPtrTy(); 187e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 188e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 189e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 190e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 191e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 192e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 193e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 194e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 195e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 196e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 197e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 19883a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 19923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 20023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 201e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 20283a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 20328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 20428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 20528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 20628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC && 20728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 208c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 209c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 210c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 211c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 212c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 213c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 214c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 215c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 21628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 217c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 21828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 21928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 220e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 22128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 22228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 22383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 224e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 2259f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 2269f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 22728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 228894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 22928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 23028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 23123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 23228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 23323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 23423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 23523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 23628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 23728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 23828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 23928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 24028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 24128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 24328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 24528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 24628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 24728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 24828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 24928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 25028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 25128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 25328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 25428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 25628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 25728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 25828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 25928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 26028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 26228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 26328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 26528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 26628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 26728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 26828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 26928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 27128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 27228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27380aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian PDecl->setPropertyAttributesAsWritten(PDecl->getPropertyAttributes()); 27480aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian 27528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 27628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 27728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 27828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 27928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 280e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 28128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 28228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 28528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 28628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 28728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 28817cb326cb62a59f53d92236394af40eaae4eddbdFariborz JahanianSema::DeclPtrTy Sema::ActOnPropertyImplDecl(Scope *S, 28917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation AtLoc, 29028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek SourceLocation PropertyLoc, 29128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool Synthesize, 29228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DeclPtrTy ClassCatImpDecl, 29328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IdentifierInfo *PropertyId, 29428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IdentifierInfo *PropertyIvar) { 295e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 296e9686572f17968048a5e097254f85c202ea44aecTed Kremenek cast_or_null<ObjCContainerDecl>(ClassCatImpDecl.getAs<Decl>()); 29728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 29828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 29928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 30028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 30128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 30228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 30328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 30428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 30528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 30628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 30728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 30828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 30928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 31028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 31128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 31228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 31328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 31428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 31528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 31628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 31728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 31828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 31928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 32028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 32228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 32328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 32428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 32528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 32628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 32728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 33128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 33228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 33328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 33428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 33528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 33628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 33728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 33828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 33928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 34028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 34128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 34228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 34328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 34428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 34528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 34628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 34728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 34828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 34928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 35028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 35128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 35228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 35328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 35428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 35528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 35628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 35728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 35828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 35928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 36028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 36128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 36228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 36328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType PropType = Context.getCanonicalType(property->getType()); 36428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 36528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 36728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 36829fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, PropertyLoc, 36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar, PropType, /*Dinfo=*/0, 3702846b2b47029c877357438d16c73911c1510be6cFariborz Jahanian ObjCIvarDecl::Protected, 37128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Expr *)0); 37229fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 37328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 37428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 37528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 37628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 37728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 37828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 37928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 38028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 38128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 38228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 38328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 38428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 38528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 38628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Ivar << Ivar->getNameAsCString(); 38728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 38828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 38928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 39028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 39128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 39228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (PropType != IvarType) { 39362ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 39462ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (isa<ObjCObjectPointerType>(PropType) 39562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian && isa<ObjCObjectPointerType>(IvarType)) 39662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 39762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 39862ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian PropType->getAs<ObjCObjectPointerType>(), 39962ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 40062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian else 40162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = (CheckAssignmentConstraints(PropType, IvarType) == Compatible); 40262ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 40328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 404f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 405f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 406f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 40728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 40928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 41028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 41128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 41328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 41428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType lhsType =Context.getCanonicalType(PropType).getUnqualifiedType(); 41528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 41628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 41728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 41828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 419f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 420f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 421f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 42228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 42328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 42428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 42528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 42628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 42728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 42828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 42928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 43028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 43128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 43228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 43328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 43428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 43528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 43628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 43728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 43828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 43928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 44028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 44128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 44228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 44328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 44528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 44628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 44728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 44828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 44928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar); 45017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 45117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 45217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize) { 45317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 45417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 45517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 45617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 45717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 45817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) DeclRefExpr(SelfDecl,SelfDecl->getType(), 45917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation()); 46017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 46117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 46217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 46317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian OwningExprResult Res = 46417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 4653c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 4663c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 4673c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 46817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 46917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 47017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 47117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 47217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 47317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ResExpr = MaybeCreateCXXExprWithTemporaries(ResExpr); 47417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 47517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 47617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 47717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 47817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 47917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 48017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize) { 48117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 48217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 48317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 48417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) DeclRefExpr(SelfDecl,SelfDecl->getType(), 48517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation()); 48617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 48717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 48817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 48917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 49017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 49117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *rhs = new (Context) DeclRefExpr(Param,Param->getType(), 49217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation()); 49317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian OwningExprResult Res = BuildBinOp(S, SourceLocation(), 49417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian BinaryOperator::Assign, lhs, rhs); 49517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 49617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 49717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 49817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 49928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 50028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 50128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 50228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 50328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 50428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 50528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 50628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 50728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 50828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 50928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 51028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 51128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 51228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 51328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 51428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 51528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 51628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 51728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 51828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 52128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 52228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 52328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 52428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 52528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 52628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 52728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 52828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 52928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 53028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy(); 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek return DeclPtrTy::make(PIDecl); 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 53828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 54028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 54128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 5429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 5439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 5449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 5459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 5469d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 5479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 5489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 5499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 5509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 5519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 5529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 5539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 5549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 5559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 5569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 5579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 5589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 5599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 5619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain) 5629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_retain)) 5639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "retain" << inheritedName; 5659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 5679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 5689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 5709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 5719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 5739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 5749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 5759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 5769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 5789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 5799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 5809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 5819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Context.typesAreCompatible(LHSType, RHSType)) { 5839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Incorporate this test with typesAreCompatible. 5849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType()) 5859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Context.ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false)) 5869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 5879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 5889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getType() << SuperProperty->getType() << inheritedName; 5899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 5909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 5919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 5929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 5939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 5949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 5959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 5969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->getResultType() != property->getType()) { 5979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 5989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (property->getType()->isObjCObjectPointerType()) 5999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek result = CheckAssignmentConstraints(GetterMethod->getResultType(), 6009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType()); 6019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 6029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 6039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 6049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 6059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 6069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 6079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 6109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 6139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 6149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// diagnostics in a variety of inconsistant situations. 6159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 6169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 6179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 6189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 6199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 6209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 6219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 6229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 6239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 6249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 6259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 6269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 6279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 6289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 6299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 6309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 6319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 6369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 6379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 6389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 6399d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 6409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 6419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 6429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 6439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 6449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 6459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 6469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 6479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 6489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 6499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 6509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 6519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 6522d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 6539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 6549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 6559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 6569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 6579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 6589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 6609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 6629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 6639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 6649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 6659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 6669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 6679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 6689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 6699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 6709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 6719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 6729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 6739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 6749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 6769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 6779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 6789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 6799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CompareProperties(Decl *CDecl, 6809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DeclPtrTy ClassOrProtocol) { 6819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Decl *ClassDecl = ClassOrProtocol.getAs<Decl>(); 6829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 6839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 6859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 6869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 6879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 6889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 6899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 6909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 6919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 6929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 6939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 6949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 6959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 6969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 6979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 6989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CompareProperties(CatDecl, DeclPtrTy::make(*P)); 6999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 7009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 7019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 7029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 7039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 7049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 7069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 7099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator P = MDecl->protocol_begin(), 7109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 7119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 7129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 7139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 7159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 7169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator P = IDecl->protocol_begin(), 7179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); P != E; ++P) 7189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CompareProperties(IDecl, DeclPtrTy::make(*P)); 7199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 7209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 7219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 7229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 7239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 7249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 7289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 7299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 7309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 7319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 7329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 7339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 7349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 7369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 7379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 7389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 7419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 7429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 7439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 7449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 7459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 7469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 7479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 7489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 7509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 7519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 7529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 7569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 7579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 7589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 7599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 7609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 7619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 7639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 7649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 7659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 7699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 7709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 7719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 7729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 7739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 7749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 7759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 7769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 7779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 7789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 7799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 7809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 781cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 782cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 7839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 7849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 7859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 7869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 7879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 7889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 7909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 7919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); PI != E; ++PI) 792cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 7939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 7949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 7959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 7969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 7979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 7989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 7999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 8009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 8029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = CATDecl->protocol_begin(), 8039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 804cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 8059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 8079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 8089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 8099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 810cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 811cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 812cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 813cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropertyFromSuper || PropertyFromSuper != Prop) { 814cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 815cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 816cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 817cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 8189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 8209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 8219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 822cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 8239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 8259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 826509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 827509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 828509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 829509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 830509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 831509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 832509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 833509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 834509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 835509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 836509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 837509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 838509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->protocol_end(); PI != E; ++PI) 839509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 840509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 841509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 842509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 843509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 844509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 845509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 846509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 847509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 848509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 849509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 850509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 851509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 852509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 853509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 854509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 855509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 856509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 857509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 858509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 859509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 860509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 861509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 862509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 863509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 864509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 865509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 866509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 8679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 8689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 8699d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 8709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 8719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 8729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 8739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 8749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 8759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 8769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 8779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 8789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 8809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::protocol_iterator PI = IDecl->protocol_begin(), 8819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->protocol_end(); PI != E; ++PI) { 8829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 8839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 8849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 8859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 8889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 8899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 8909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 8919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 8929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 8939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 8949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 8969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 8979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 8989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 8999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 9019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 9049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 906509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 907509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 908509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties (Scope *S, ObjCImplDecl* IMPDecl, 909509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCInterfaceDecl *IDecl) { 910509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 911509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 912509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 913509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 914509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 915509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 916509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 917509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 918509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 919509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 920509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 921509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 922509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 923509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 924509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 925509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 926509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 927509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 928509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 929509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ActOnPropertyImplDecl(S, IMPDecl->getLocation(), IMPDecl->getLocation(), 930509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian true, DeclPtrTy::make(IMPDecl), 931509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getIdentifier(), Prop->getIdentifier()); 932509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 933509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 9349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 93517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 9369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 9379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 938cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 939cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 940cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 941cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 943cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 9489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 9499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 9509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 9519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 9529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 9549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 9559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 9569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 9579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 9589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.count(Prop)) 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 9619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 9649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 9659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 9669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 9679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 9699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 9769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 9779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 9849d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC) 9889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 9909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 9919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 9929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 9939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 9949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 9999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 10009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 10019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 10029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod = 10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IMPDecl->getInstanceMethod(Property->getGetterName()); 10049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *SetterMethod = 10059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IMPDecl->getInstanceMethod(Property->getSetterName()); 10069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 10099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 10109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getIdentifier(); 10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 10229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CD) { 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 10349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ((*SetterMethod->param_begin())->getType() != property->getType())) { 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 10459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 10469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 10509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 10559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 10569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), property->getGetterName(), 10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType(), 0, CD, true, false, true, 10629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 106723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 106823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 106923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (DeclContext *lexicalDC = property->getLexicalDeclContext()) 107023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 107123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek 10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 10759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 10799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 10809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 10849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 10859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 10869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), 10879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getSetterName(), 10889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy, 0, CD, true, false, true, 10899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 10909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 10919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 10949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 10959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 10969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation(), 10979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 10989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getType(), 10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek VarDecl::None, 110116573fa9705b546b7597c273b25b85d6321e2b33Douglas Gregor VarDecl::None, 11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 11034ecb25fa94897b2c03510292acace710e5262ba5Fariborz Jahanian SetterMethod->setMethodParams(Context, &Argument, 1, 1); 11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 110523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 110623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 110723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (DeclContext *lexicalDC = property->getLexicalDeclContext()) 110823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 11099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 11169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 11199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 11209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 11219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 11259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 11269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 11279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 11289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 11299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 11309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 11319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1133842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanianvoid Sema::CheckObjCPropertyAttributes(DeclPtrTy PropertyPtrTy, 11349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 11359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 11369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1137842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian Decl *PDecl = PropertyPtrTy.getAs<Decl>(); 11385fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek if (!PDecl) 11395fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 11405fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 11415fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1142842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 11439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 11459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 114628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 114728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 114828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 114928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_retain))) { 115028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 115128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 115228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 115328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 115428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 115528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 11569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 115728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 115828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 115928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 116028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 116128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 116328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 116428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) && 116528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !PropertyTy->isObjCObjectPointerType() && 116628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !PropertyTy->isBlockPointerType() && 1167842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !Context.isObjCNSObjectType(PropertyTy) && 1168842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 116928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 117028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << (Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain"); 117128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain); 117228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 11739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 117428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 117528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 117628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 117728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 117828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 117928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 118028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 118128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 118228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 118328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 118428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 118528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 118628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 118728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 118828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 118928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 119028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 119128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 119228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 11939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 119428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 119528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 119628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 119728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_retain)) && 119828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 119928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 120028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Skip this warning in gc-only mode. 120128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::GCOnly) 120228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 12039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 120428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If non-gc code warn that this is likely inappropriate. 120528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() == LangOptions::NonGC) 120628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_default_assign_on_object); 12079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 120828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 120928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 121028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 121128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 121228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 12139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 121428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 121528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && getLangOptions().getGCMode() == LangOptions::GCOnly 121628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 121728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 12189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1219