SemaObjCProperty.cpp revision d329724745b49f894b768d47275b7c2713106e89
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 1655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/ASTMutationListener.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian#include "clang/AST/ExprCXX.h" 1955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/ExprObjC.h" 20edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian#include "clang/Basic/SourceManager.h" 2155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Lex/Lexer.h" 2255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Lex/Preprocessor.h" 2355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h" 2450df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 258fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 3128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33265941bc308d65cc270d5c4de5806f37ce405606John McCall/// getImpliedARCOwnership - Given a set of property attributes and a 34265941bc308d65cc270d5c4de5806f37ce405606John McCall/// type, infer an expected lifetime. The type's ownership qualification 35265941bc308d65cc270d5c4de5806f37ce405606John McCall/// is not considered. 36265941bc308d65cc270d5c4de5806f37ce405606John McCall/// 37265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Returns OCL_None if the attributes as stated do not imply an ownership. 38265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Never returns OCL_Autoreleasing. 39265941bc308d65cc270d5c4de5806f37ce405606John McCallstatic Qualifiers::ObjCLifetime getImpliedARCOwnership( 40265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attrs, 41265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType type) { 42265941bc308d65cc270d5c4de5806f37ce405606John McCall // retain, strong, copy, weak, and unsafe_unretained are only legal 43265941bc308d65cc270d5c4de5806f37ce405606John McCall // on properties of retainable pointer type. 44265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & (ObjCPropertyDecl::OBJC_PR_retain | 45265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_strong | 46265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 47d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return Qualifiers::OCL_Strong; 48265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_weak) { 49265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Weak; 50265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_unsafe_unretained) { 51265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 52265941bc308d65cc270d5c4de5806f37ce405606John McCall } 53265941bc308d65cc270d5c4de5806f37ce405606John McCall 54265941bc308d65cc270d5c4de5806f37ce405606John McCall // assign can appear on other types, so we have to check the 55265941bc308d65cc270d5c4de5806f37ce405606John McCall // property type. 56265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & ObjCPropertyDecl::OBJC_PR_assign && 57265941bc308d65cc270d5c4de5806f37ce405606John McCall type->isObjCRetainableType()) { 58265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 59265941bc308d65cc270d5c4de5806f37ce405606John McCall } 60265941bc308d65cc270d5c4de5806f37ce405606John McCall 61265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_None; 62265941bc308d65cc270d5c4de5806f37ce405606John McCall} 63265941bc308d65cc270d5c4de5806f37ce405606John McCall 64f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 65f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 66f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 67f85e193739c953358c865005855253af4f68a497John McCall 68f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 69f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 70f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 71f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 72f85e193739c953358c865005855253af4f68a497John McCall 73f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 74f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 75f85e193739c953358c865005855253af4f68a497John McCall 76265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime expectedLifetime 77265941bc308d65cc270d5c4de5806f37ce405606John McCall = getImpliedARCOwnership(propertyKind, property->getType()); 78265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!expectedLifetime) { 79f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 80265941bc308d65cc270d5c4de5806f37ce405606John McCall // attribute. That's okay, but restore reasonable invariants by 81265941bc308d65cc270d5c4de5806f37ce405606John McCall // setting the property attribute according to the lifetime 82265941bc308d65cc270d5c4de5806f37ce405606John McCall // qualifier. 83265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attr; 84265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == Qualifiers::OCL_Strong) { 85265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_strong; 86265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak) { 87265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_weak; 88265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 89265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(propertyLifetime == Qualifiers::OCL_ExplicitNone); 90265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 91265941bc308d65cc270d5c4de5806f37ce405606John McCall } 92265941bc308d65cc270d5c4de5806f37ce405606John McCall property->setPropertyAttributes(attr); 93f85e193739c953358c865005855253af4f68a497John McCall return; 94f85e193739c953358c865005855253af4f68a497John McCall } 95f85e193739c953358c865005855253af4f68a497John McCall 96f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 97f85e193739c953358c865005855253af4f68a497John McCall 98f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 99f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 100b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 101f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 102265941bc308d65cc270d5c4de5806f37ce405606John McCall << expectedLifetime 103f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 104f85e193739c953358c865005855253af4f68a497John McCall} 105f85e193739c953358c865005855253af4f68a497John McCall 106dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanianstatic unsigned deduceWeakPropertyFromType(Sema &S, QualType T) { 107dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if ((S.getLangOpts().getGC() != LangOptions::NonGC && 108dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.isObjCGCWeak()) || 109dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (S.getLangOpts().ObjCAutoRefCount && 110dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.getObjCLifetime() == Qualifiers::OCL_Weak)) 111dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return ObjCDeclSpec::DQ_PR_weak; 112dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return 0; 113dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 114dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 115d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 11677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 117d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 118d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 119d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 120d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 121d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 1224a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 1234a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 124ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = ODS.getPropertyAttributes(); 125f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 126f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 127ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes |= deduceWeakPropertyFromType(*this, T); 128dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 129ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 13028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 131ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 13228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 13328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 134ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 13528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 136ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 137ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 138ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 139ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 140ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 14114086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 143a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 14428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 145ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 14677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Decl *Res = HandlePropertyInClassExtension(S, AtLoc, LParenLoc, 147ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 148ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 149ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes, 150dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 151ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 152ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 153f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 154ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling CheckObjCPropertyAttributes(Res, AtLoc, Attributes, false); 1554e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 156f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 157f85e193739c953358c865005855253af4f68a497John McCall } 158abd56c816e9164b17bb3e7154a511b0c9896ffdbDmitri Gribenko ActOnDocumentableDecl(Res); 159ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 160ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 161ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 16277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, LParenLoc, FD, 163f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 164f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 165ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes, 166dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 167dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis TSI, MethodImplKind); 1684a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1694a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1704a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 171842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 172ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling CheckObjCPropertyAttributes(Res, AtLoc, Attributes, 173cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (isa<ObjCInterfaceDecl>(ClassDecl) || 174cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian isa<ObjCProtocolDecl>(ClassDecl))); 175f85e193739c953358c865005855253af4f68a497John McCall 1764e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 177f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 178f85e193739c953358c865005855253af4f68a497John McCall 179abd56c816e9164b17bb3e7154a511b0c9896ffdbDmitri Gribenko ActOnDocumentableDecl(Res); 180842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 183b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidisstatic ObjCPropertyDecl::PropertyAttributeKind 184ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill WendlingmakePropertyAttributesAsWritten(unsigned Attributes) { 185b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 186ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 187b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 188ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 189b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 190ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_getter) 191b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 192ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_setter) 193b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 194ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_assign) 195b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 196ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 197b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 198ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 199b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 200ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) 201b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 202ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 203b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 204ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 205b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 206ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 207b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 208ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 209b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 210b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 211b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis return (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten; 212b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis} 213b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 2145bf0e3522fac400cf7bf49a775554f0fc942b336Fariborz Jahanianstatic bool LocPropertyAttribute( ASTContext &Context, const char *attrName, 215edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation LParenLoc, SourceLocation &Loc) { 216edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (LParenLoc.isMacroID()) 217edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 218edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 219edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceManager &SM = Context.getSourceManager(); 220edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian std::pair<FileID, unsigned> locInfo = SM.getDecomposedLoc(LParenLoc); 221edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Try to load the file buffer. 222edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian bool invalidTemp = false; 223edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef file = SM.getBufferData(locInfo.first, &invalidTemp); 224edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (invalidTemp) 225edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 226edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian const char *tokenBegin = file.data() + locInfo.second; 227edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 228edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Lex from the start of the given location. 229edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Lexer lexer(SM.getLocForStartOfFile(locInfo.first), 230edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Context.getLangOpts(), 231edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian file.begin(), tokenBegin, file.end()); 232edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Token Tok; 233edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian do { 234edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian lexer.LexFromRawLexer(Tok); 235edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (Tok.is(tok::raw_identifier) && 236edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef(Tok.getRawIdentifierData(), Tok.getLength()) == attrName) { 237edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Loc = Tok.getLocation(); 238edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return true; 239edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 240edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } while (Tok.isNot(tok::r_paren)); 241edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 242edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 2432b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian} 2442b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 245d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanianstatic unsigned getOwnershipRule(unsigned attr) { 246dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return attr & (ObjCPropertyDecl::OBJC_PR_assign | 247dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_retain | 248dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_copy | 249dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_weak | 250dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_strong | 251dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 252dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 253dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 254d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 255a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 25677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation AtLoc, 25777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 25877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FieldDeclarator &FD, 259e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 260e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 261e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 262ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const unsigned Attributes, 263dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 264e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 26583a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 266e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 26758a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 268e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 269a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 270e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 2712a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 2722a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 273d329724745b49f894b768d47275b7c2713106e89Douglas Gregor if (CCPrimary) { 2742a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 2752a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 276d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCInterfaceDecl::known_extensions_iterator 277d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext = CCPrimary->known_extensions_begin(), 278d329724745b49f894b768d47275b7c2713106e89Douglas Gregor ExtEnd = CCPrimary->known_extensions_end(); 279d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext != ExtEnd; ++Ext) { 280d329724745b49f894b768d47275b7c2713106e89Douglas Gregor if (ObjCPropertyDecl *prevDecl 281d329724745b49f894b768d47275b7c2713106e89Douglas Gregor = ObjCPropertyDecl::findPropertyDecl(*Ext, PropertyId)) { 2822a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 2832a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 2842a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 2852a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2862a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 287d329724745b49f894b768d47275b7c2713106e89Douglas Gregor } 288d329724745b49f894b768d47275b7c2713106e89Douglas Gregor 289e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 290e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 29188f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 292e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 293e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 29477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, T); 295b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 296dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 297ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 29822f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 299ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 30022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 30188f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 30288f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 30388f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 30491ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 305e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 306e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 307e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 308e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 309e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 310e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 311e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 312d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 313e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 314e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 315e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 316e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 317e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 318e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 319e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 320e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 321e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 322d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ObjCPropertyDecl *PrimaryPDecl = 32377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian CreatePropertyDecl(S, CCPrimary, AtLoc, LParenLoc, 324e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 325ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes,AttributesAsWritten, T, MethodImplKind, DC); 326e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 327e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 328e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 329e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 330d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ProcessPropertyDecl(PrimaryPDecl, CCPrimary, /* redeclaredProperty = */ 0, 331a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 332d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PrimaryPDecl->getGetterMethodDecl()); 333d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PrimaryPDecl->getSetterMethodDecl()); 334c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 335d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PrimaryPDecl, /*OrigProp=*/0, CDecl); 336d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis return PrimaryPDecl; 337e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 338e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!Context.hasSameType(PIDecl->getType(), PDecl->getType())) { 339e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian bool IncompatibleObjC = false; 340e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian QualType ConvertedType; 341ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Relax the strict type matching for property type in continuation class. 342ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Allow property object type of continuation class to be different as long 343ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // as it narrows the object type in its primary class property. Note that 344ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // this conversion is safe only because the wider type is for a 'readonly' 345ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // property in primary class and 'narrowed' type for a 'readwrite' property 346ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // in continuation class. 347e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!isa<ObjCObjectPointerType>(PIDecl->getType()) || 348e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian !isa<ObjCObjectPointerType>(PDecl->getType()) || 349e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian (!isObjCPointerConversion(PDecl->getType(), PIDecl->getType(), 350e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian ConvertedType, IncompatibleObjC)) 351e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian || IncompatibleObjC) { 352e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(AtLoc, 353e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian diag::err_type_mismatch_continuation_class) << PDecl->getType(); 354e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(PIDecl->getLocation(), diag::note_property_declare); 3556defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return 0; 356e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian } 357a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian } 358a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian 359e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 360e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 36180aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 362e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 363dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian PIkind |= deduceWeakPropertyFromType(*this, PIDecl->getType()); 364ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned ClassExtensionMemoryModel = getOwnershipRule(Attributes); 365d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanian unsigned PrimaryClassMemoryModel = getOwnershipRule(PIkind); 366dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if (PrimaryClassMemoryModel && ClassExtensionMemoryModel && 367dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (PrimaryClassMemoryModel != ClassExtensionMemoryModel)) { 368e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 369e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 370e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 3719944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 3729944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 3739944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 374e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 375e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 376e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 377e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 378e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 379e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 380e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 381e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 382a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 383a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 3847939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 3857939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 386d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 38777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian ActOnProperty(S, AtLoc, LParenLoc, FD, ProtocolPropertyODS, 388e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 389e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 390a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 3914a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 3924a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 393d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 39428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 395e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 396ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 397e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 398ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 399f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 400ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 401e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 402e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 403e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 404788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 405788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 406788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 407788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 408788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 409ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 410788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 411788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 412788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 413788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 414e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 415e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 4166defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return 0; 417e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 418e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 419e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 4208254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 421d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PIDecl->getGetterMethodDecl()); 422d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PIDecl->getSetterMethodDecl()); 423c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 424c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PDecl, PIDecl, CDecl); 4256defd9f31eec51278d056f1bff885018e2321373Fariborz Jahanian return PDecl; 426e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 427e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 428e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 429e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 430e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 43177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 432e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 433e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 434e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 435e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 436e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 437ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const unsigned Attributes, 438dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 43983a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 44023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 44123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 442e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 44383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 44528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 44628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 4474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC && 448ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 449c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 450c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 451c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 452c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 453c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 454c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 455c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 456c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 45728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 458c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 45928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 46028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 461e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 46228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 46328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 46477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, TInfo); 465e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 4669f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 4679f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 46828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 469894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 47028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 47128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 47223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 47328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 47423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 47523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 47623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 47728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 47828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 47928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 48028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 48128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 48228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 48328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 48428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 48528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 48628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 48728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 48828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 4890a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 490dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 4910a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 492ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 49328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 49428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 495ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_getter) 49628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 49728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 498ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_setter) 49928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 50028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 50128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 50228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 50328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 504ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) 50528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 50628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 507ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) 508f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 509f85e193739c953358c865005855253af4f68a497John McCall 510ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) 511f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 512f85e193739c953358c865005855253af4f68a497John McCall 513ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) 51428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 51528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 516ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 517f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 518f85e193739c953358c865005855253af4f68a497John McCall 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 52128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 522265941bc308d65cc270d5c4de5806f37ce405606John McCall // In the semantic attributes, one of nonatomic or atomic is always set. 523ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 52428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 525265941bc308d65cc270d5c4de5806f37ce405606John McCall else 52645937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 52728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 528f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 529ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 530f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 531f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 532f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 533f85e193739c953358c865005855253af4f68a497John McCall 53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 53828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 539e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 54028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 54128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 542f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 543f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 544f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 545f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 546f85e193739c953358c865005855253af4f68a497John McCall 547f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 548f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 549f85e193739c953358c865005855253af4f68a497John McCall 550265941bc308d65cc270d5c4de5806f37ce405606John McCall // The lifetime implied by the property's attributes. 551265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime propertyLifetime = 552265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(property->getPropertyAttributes(), 553265941bc308d65cc270d5c4de5806f37ce405606John McCall property->getType()); 554f85e193739c953358c865005855253af4f68a497John McCall 555265941bc308d65cc270d5c4de5806f37ce405606John McCall // We're fine if they match. 556265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == ivarLifetime) return; 557f85e193739c953358c865005855253af4f68a497John McCall 558265941bc308d65cc270d5c4de5806f37ce405606John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 559265941bc308d65cc270d5c4de5806f37ce405606John McCall if (ivarLifetime == Qualifiers::OCL_None || 560265941bc308d65cc270d5c4de5806f37ce405606John McCall ivarLifetime == Qualifiers::OCL_Autoreleasing) 561265941bc308d65cc270d5c4de5806f37ce405606John McCall return; 562265941bc308d65cc270d5c4de5806f37ce405606John McCall 563d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // If the ivar is private, and it's implicitly __unsafe_unretained 564d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // becaues of its type, then pretend it was actually implicitly 565d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // __strong. This is only sound because we're processing the 566d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // property implementation before parsing any method bodies. 567d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (ivarLifetime == Qualifiers::OCL_ExplicitNone && 568d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall propertyLifetime == Qualifiers::OCL_Strong && 569d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->getAccessControl() == ObjCIvarDecl::Private) { 570d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall SplitQualType split = ivarType.split(); 571d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (split.Quals.hasObjCLifetime()) { 572d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall assert(ivarType->isObjCARCImplicitlyUnretainedType()); 573d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall split.Quals.setObjCLifetime(Qualifiers::OCL_Strong); 574d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivarType = S.Context.getQualifiedType(split); 575d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->setType(ivarType); 576d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return; 577d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 578d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 579d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall 580265941bc308d65cc270d5c4de5806f37ce405606John McCall switch (propertyLifetime) { 581265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Strong: 582135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::err_arc_strong_property_ownership) 583265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 584265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 585265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivarLifetime; 586265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 587265941bc308d65cc270d5c4de5806f37ce405606John McCall 588265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Weak: 589135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::error_weak_property) 590265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 591265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName(); 592265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 593265941bc308d65cc270d5c4de5806f37ce405606John McCall 594265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_ExplicitNone: 595135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(ivar->getLocation(), diag::err_arc_assign_property_ownership) 596265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 597265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 598265941bc308d65cc270d5c4de5806f37ce405606John McCall << ((property->getPropertyAttributesAsWritten() 599265941bc308d65cc270d5c4de5806f37ce405606John McCall & ObjCPropertyDecl::OBJC_PR_assign) != 0); 600265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 601265941bc308d65cc270d5c4de5806f37ce405606John McCall 602265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Autoreleasing: 603265941bc308d65cc270d5c4de5806f37ce405606John McCall llvm_unreachable("properties cannot be autoreleasing"); 604265941bc308d65cc270d5c4de5806f37ce405606John McCall 605265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_None: 606265941bc308d65cc270d5c4de5806f37ce405606John McCall // Any other property should be ignored. 607f85e193739c953358c865005855253af4f68a497John McCall return; 608f85e193739c953358c865005855253af4f68a497John McCall } 609f85e193739c953358c865005855253af4f68a497John McCall 610f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 611135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis if (propertyImplLoc.isValid()) 612135aa60c613bdcc0e8e237b12bf93cab04284419Argyrios Kyrtzidis S.Diag(propertyImplLoc, diag::note_property_synthesize); 613f85e193739c953358c865005855253af4f68a497John McCall} 614f85e193739c953358c865005855253af4f68a497John McCall 615015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// setImpliedPropertyAttributeForReadOnlyProperty - 616015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// This routine evaludates life-time attributes for a 'readonly' 617015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// property with no known lifetime of its own, using backing 618015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// 'ivar's attribute, if any. If no backing 'ivar', property's 619015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// life-time is assumed 'strong'. 620015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanianstatic void setImpliedPropertyAttributeForReadOnlyProperty( 621015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl *property, ObjCIvarDecl *ivar) { 622015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime propertyLifetime = 623015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian getImpliedARCOwnership(property->getPropertyAttributes(), 624015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->getType()); 625015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (propertyLifetime != Qualifiers::OCL_None) 626015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 627015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 628015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (!ivar) { 629015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // if no backing ivar, make property 'strong'. 630015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 631015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 632015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 633015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // property assumes owenership of backing ivar. 634015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian QualType ivarType = ivar->getType(); 635015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 636015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (ivarLifetime == Qualifiers::OCL_Strong) 637015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 638015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian else if (ivarLifetime == Qualifiers::OCL_Weak) 639015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 640015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 641015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian} 64228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 643cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// DiagnoseClassAndClassExtPropertyMismatch - diagnose inconsistant property 644cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// attribute declared in primary class and attributes overridden in any of its 645cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// class extensions. 646cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanianstatic void 647cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz JahanianDiagnoseClassAndClassExtPropertyMismatch(Sema &S, ObjCInterfaceDecl *ClassDecl, 648cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *property) { 649ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = property->getPropertyAttributesAsWritten(); 650ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling bool warn = (Attributes & ObjCDeclSpec::DQ_PR_readonly); 651d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCInterfaceDecl::known_extensions_iterator 652d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext = ClassDecl->known_extensions_begin(), 653d329724745b49f894b768d47275b7c2713106e89Douglas Gregor ExtEnd = ClassDecl->known_extensions_end(); 654d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Ext != ExtEnd; ++Ext) { 655cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *ClassExtProperty = 0; 656d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCContainerDecl::prop_iterator P = Ext->prop_begin(), 657d329724745b49f894b768d47275b7c2713106e89Douglas Gregor E = Ext->prop_end(); 658d329724745b49f894b768d47275b7c2713106e89Douglas Gregor P != E; ++P) { 659cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if ((*P)->getIdentifier() == property->getIdentifier()) { 660cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ClassExtProperty = *P; 661cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 662cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 663cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 664cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (ClassExtProperty) { 665c78ff27813288b30ee566477705353ae660fd577Fariborz Jahanian warn = false; 666cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned classExtPropertyAttr = 667cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ClassExtProperty->getPropertyAttributesAsWritten(); 668cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // We are issuing the warning that we postponed because class extensions 669cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // can override readonly->readwrite and 'setter' attributes originally 670cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // placed on class's property declaration now make sense in the overridden 671cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // property. 672ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_readonly) { 673cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (!classExtPropertyAttr || 674a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (classExtPropertyAttr & 675a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (ObjCDeclSpec::DQ_PR_readwrite| 676a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_assign | 677a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 678a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 679a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 680a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_strong))) 681cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian continue; 682cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian warn = true; 683cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 684cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 685cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 686cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 687cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (warn) { 688cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned setterAttrs = (ObjCDeclSpec::DQ_PR_assign | 689cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 690cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 691cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 692cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong); 693ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & setterAttrs) { 694cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian const char * which = 695ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 696cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "assign" : 697ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 698cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "unsafe_unretained" : 699ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 700cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "copy" : 701ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_retain) ? 702cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "retain" : "strong"; 703cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 704cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian S.Diag(property->getLocation(), 705cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian diag::warn_objc_property_attr_mutually_exclusive) 706cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << which; 707cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 708cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 709cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 710cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 711cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian} 712cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 71328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 71428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 715699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// as \@synthesize or \@dynamic. 71628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 717d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 718d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 719d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 720d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 721d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 722a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 723a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 724e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 72584e0ccff7a6e51d7b81fd58686b493a4880dd44dFariborz Jahanian dyn_cast<ObjCContainerDecl>(CurContext); 72628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 72728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 72828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 729d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 73028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 731f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis if (PropertyIvarLoc.isInvalid()) 732f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc = PropertyLoc; 733e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman SourceLocation PropertyDiagLoc = PropertyLoc; 734e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (PropertyDiagLoc.isInvalid()) 735e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PropertyDiagLoc = ClassImpDecl->getLocStart(); 73628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 73728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 73828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 73928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 74028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 74128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 74228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 74328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 74428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 74528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 74628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 74728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 74828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 74928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 75028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 75128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 75228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 753d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 75428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 755dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 75645937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 75745937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 758dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 759dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 760dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 761dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 762dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 763dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 764dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 76528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 76628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 76728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 76828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 76928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 770d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 77128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 77228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 7732b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 7742b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian if (Synthesize&& 7752b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian (PIkind & ObjCPropertyDecl::OBJC_PR_readonly) && 7762b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian property->hasAttr<IBOutletAttr>() && 7772b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian !AtLoc.isValid()) { 7782b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_readonly_iboutlet_property); 7792b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 780edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation readonlyLoc; 7815bf0e3522fac400cf7bf49a775554f0fc942b336Fariborz Jahanian if (LocPropertyAttribute(Context, "readonly", 782edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian property->getLParenLoc(), readonlyLoc)) { 783edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation endLoc = 784edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian readonlyLoc.getLocWithOffset(strlen("readonly")-1); 785edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceRange ReadonlySourceRange(readonlyLoc, endLoc); 786edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Diag(property->getLocation(), 787edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian diag::note_auto_readonly_iboutlet_fixup_suggest) << 788edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian FixItHint::CreateReplacement(ReadonlySourceRange, "readwrite"); 789edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 7902b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian } 791cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 792cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian DiagnoseClassAndClassExtPropertyMismatch(*this, IDecl, property); 7932b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 79428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 79528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 79628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 797d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 79828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 79928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 80028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 80128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 802d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 80328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 80428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 80528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 80628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 80728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 80828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 80928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 810d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 81128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 81228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 81328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 81428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 81528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 816d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 81728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 81828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 81928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 820d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 82128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 82228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 823e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman bool CompleteTypeErr = false; 824744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian bool compat = true; 82528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 82628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 82728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 82828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 82928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 830015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // Check that this is a previously declared 'ivar' in 'IDecl' interface 831015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared; 832015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 833265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropType = property->getType(); 834265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropertyIvarType = PropType.getNonReferenceType(); 835e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 836e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (RequireCompleteType(PropertyDiagLoc, PropertyIvarType, 837d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_incomplete_synthesized_property, 838d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor property->getDeclName())) { 839e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(property->getLocation(), diag::note_property_declare); 840e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman CompleteTypeErr = true; 841e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman } 842e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 8434e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 844015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian (property->getPropertyAttributesAsWritten() & 8453efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_readonly) && 8463efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian PropertyIvarType->isObjCRetainableType()) { 847015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian setImpliedPropertyAttributeForReadOnlyProperty(property, Ivar); 848015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 849015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 850015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl::PropertyAttributeKind kind 851015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian = property->getPropertyAttributes(); 852265941bc308d65cc270d5c4de5806f37ce405606John McCall 853265941bc308d65cc270d5c4de5806f37ce405606John McCall // Add GC __weak to the ivar type if the property is weak. 854265941bc308d65cc270d5c4de5806f37ce405606John McCall if ((kind & ObjCPropertyDecl::OBJC_PR_weak) && 8554e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 8564e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie assert(!getLangOpts().ObjCAutoRefCount); 857265941bc308d65cc270d5c4de5806f37ce405606John McCall if (PropertyIvarType.isObjCGCStrong()) { 858e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_gc_weak_property_strong_type); 859265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(property->getLocation(), diag::note_property_declare); 860265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 861265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType = 862265941bc308d65cc270d5c4de5806f37ce405606John McCall Context.getObjCGCQualType(PropertyIvarType, Qualifiers::Weak); 863edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 864edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 865e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (AtLoc.isInvalid()) { 866e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // Check when default synthesizing a property that there is 867e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // an ivar matching property name and issue warning; since this 868e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // is the most common case of not using an ivar used for backing 869e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // property in non-default synthesis case. 870e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 871e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCIvarDecl *originalIvar = 872e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian IDecl->lookupInstanceVariable(property->getIdentifier(), 873e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ClassDeclared); 874e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (originalIvar) { 875e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(PropertyDiagLoc, 876e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian diag::warn_autosynthesis_property_ivar_match) 8772578532c7323efdd68ec42a31b7bdf72e5218867Fariborz Jahanian << PropertyId << (Ivar == 0) << PropertyIvar 87820e7d992140cc6bc94f2e65f3638346527150756Fariborz Jahanian << originalIvar->getIdentifier(); 879e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 880e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(originalIvar->getLocation(), diag::note_ivar_decl); 881dd3284b17829adfd542ecf4a7b4423dce1d7502bFariborz Jahanian } 882e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian } 883e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian 884e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (!Ivar) { 885265941bc308d65cc270d5c4de5806f37ce405606John McCall // In ARC, give the ivar a lifetime qualifier based on the 886f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 8874e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 888265941bc308d65cc270d5c4de5806f37ce405606John McCall !PropertyIvarType.getObjCLifetime() && 889265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType->isObjCRetainableType()) { 890f85e193739c953358c865005855253af4f68a497John McCall 891265941bc308d65cc270d5c4de5806f37ce405606John McCall // It's an error if we have to do this and the user didn't 892265941bc308d65cc270d5c4de5806f37ce405606John McCall // explicitly write an ownership attribute on the property. 893473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 894265941bc308d65cc270d5c4de5806f37ce405606John McCall !(kind & ObjCPropertyDecl::OBJC_PR_strong)) { 895e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, 896473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 897473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 898265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 899265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime lifetime = 900265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(kind, PropertyIvarType); 901265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(lifetime && "no lifetime for property?"); 9026dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (lifetime == Qualifiers::OCL_Weak) { 9036dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian bool err = false; 9046dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (const ObjCObjectPointerType *ObjT = 905a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith PropertyIvarType->getAs<ObjCObjectPointerType>()) { 906a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith const ObjCInterfaceDecl *ObjI = ObjT->getInterfaceDecl(); 907a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith if (ObjI && ObjI->isArcWeakrefUnavailable()) { 908e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_arc_weak_unavailable_property); 9096dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 9106dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian err = true; 9116dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 912a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith } 9130a7dd788dbef975f35f273c7ab913f480f7edd60John McCall if (!err && !getLangOpts().ObjCARCWeak) { 914e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_arc_weak_no_runtime); 9156dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 9166dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 917f85e193739c953358c865005855253af4f68a497John McCall } 9186dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian 919f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 920265941bc308d65cc270d5c4de5806f37ce405606John McCall qs.addObjCLifetime(lifetime); 921f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 922f85e193739c953358c865005855253af4f68a497John McCall } 923f85e193739c953358c865005855253af4f68a497John McCall } 924f85e193739c953358c865005855253af4f68a497John McCall 925f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 9264e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().ObjCAutoRefCount && 9274e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() == LangOptions::NonGC) { 928e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_synthesize_weak_non_arc_or_gc); 929f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 930f85e193739c953358c865005855253af4f68a497John McCall } 931f85e193739c953358c865005855253af4f68a497John McCall 932ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 933f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc,PropertyIvarLoc, PropertyIvar, 93414086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 9357504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 936ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 937e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (CompleteTypeErr) 938e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->setInvalidDecl(); 93929fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 9401b7f9cbed1b96b58a6e5f7808ebc9345a76a0936Richard Smith IDecl->makeDeclVisibleInContext(Ivar); 94128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 942260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (getLangOpts().ObjCRuntime.isFragile()) 943e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_missing_property_ivar_decl) 944e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman << PropertyId; 94528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 94628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 947260611a32535c851237926bfcf78869b13c07d5bJohn McCall } else if (getLangOpts().ObjCRuntime.isNonFragile() && 94860ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor !declaresSameEntity(ClassDeclared, IDecl)) { 949e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_ivar_in_superclass_use) 95028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 95128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 95228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 9534087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 95428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 95528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 9565bf5c2ec54ede5352293e5739e9b44bea2f6b01bAnna Zaks property->setPropertyIvarDecl(Ivar); 9575bf5c2ec54ede5352293e5739e9b44bea2f6b01bAnna Zaks 95828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 95928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 96028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 961744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (!Context.hasSameType(PropertyIvarType, IvarType)) { 96214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 963f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 964b3cd3c0c8a234803dcb9b9c0dfe10106674141cdRichard Smith compat = 96562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 96614086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 96762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 968b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 969f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis compat = (CheckAssignmentConstraints(PropertyIvarLoc, PropertyIvarType, 970f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis IvarType) 971daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 972b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 97362ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 974e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_ivar_type) 975f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 976f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 977f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 97828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 97928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 98028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 981744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian else { 982744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // FIXME! Rules for properties are somewhat different that those 983744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // for assignments. Use a new routine to consolidate all cases; 984744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // specifically for property redeclarations as well as for ivars. 985744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 986744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 987744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (lhsType != rhsType && 988744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian lhsType->isArithmeticType()) { 989744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(PropertyDiagLoc, diag::error_property_ivar_type) 990744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << property->getDeclName() << PropType 991744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << Ivar->getDeclName() << IvarType; 992744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 993744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // Fall thru - see previous comment 994744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian } 99528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 99628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 997f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 9984e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC)) { 999e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_weak_property) 100028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 1001edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 100228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 100328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1004f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 100528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 100628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 10074e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 1008e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_strong_property) 100928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 101028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 101128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 101228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 10134e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1014f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 101528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 101628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 1017e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_dynamic_property_ivar_decl); 1018f85e193739c953358c865005855253af4f68a497John McCall 101928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 102028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 102128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 102228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 102328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 102428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 102528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 1026a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 1027e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 1028744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (CompleteTypeErr || !compat) 1029e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PIDecl->setInvalidDecl(); 1030e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 103117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 103217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 1033e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 10340313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 103517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 103617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 103717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 10389a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman SynthesizedFunctionScope Scope(*this, getterMethod); 103917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 104017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1041f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 10429a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_RValue, PropertyDiagLoc); 10439a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(SelfExpr); 104417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 10459a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), PropertyDiagLoc, 104617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 104760d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 104817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 10499a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman PropertyDiagLoc, 10503c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 10513c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 10529a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman PropertyDiagLoc, 105317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 105417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 105517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 105617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 10574765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 105817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 105917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 106017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 1061831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 1062831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 1063831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 1064831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 1065831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 1066831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 106717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 106817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 106917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 1070e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 1071e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->getType()->isRecordType()) { 107217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 10739a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman SynthesizedFunctionScope Scope(*this, setterMethod); 107417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 107517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1076f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 10779a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_RValue, PropertyDiagLoc); 10789a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(SelfExpr); 107917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 10809a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), PropertyDiagLoc, 108117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 108217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 108317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 10843c3b7f90a863af43fa63043d396553ecf205351cJohn McCall QualType T = Param->getType().getNonReferenceType(); 10859a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman DeclRefExpr *rhs = new (Context) DeclRefExpr(Param, false, T, 10869a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman VK_LValue, PropertyDiagLoc); 10879a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman MarkDeclRefReferenced(rhs); 10889a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman ExprResult Res = BuildBinOp(S, PropertyDiagLoc, 10892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 109057e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (property->getPropertyAttributes() & 109157e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_atomic) { 109257e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Expr *callExpr = Res.takeAs<Expr>(); 109357e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (const CXXOperatorCallExpr *CXXCE = 109413bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian dyn_cast_or_null<CXXOperatorCallExpr>(callExpr)) 109513bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian if (const FunctionDecl *FuncDecl = CXXCE->getDirectCallee()) 109657e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (!FuncDecl->isTrivial()) 109720abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian if (property->getType()->isReferenceType()) { 10989a14db3fefa73ef8a702dea1928fd0ee0befe59bEli Friedman Diag(PropertyDiagLoc, 109920abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::err_atomic_property_nontrivial_assign_op) 110057e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian << property->getType(); 110120abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian Diag(FuncDecl->getLocStart(), 110220abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::note_callee_decl) << FuncDecl; 110320abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian } 110457e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian } 110517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 110617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 110717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 110817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 110928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 111028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 111128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 111228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 111328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 111428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 111528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 111628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 111728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 111828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 111928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 112028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 112128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 112228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1123d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 112428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 112528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 11264e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCDefaultSynthProperties && 1127260611a32535c851237926bfcf78869b13c07d5bJohn McCall getLangOpts().ObjCRuntime.isNonFragile() && 112871207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek !IDecl->isObjCRequiresPropertyDefs()) { 1129ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 1130ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 1131cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 1132411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 1133ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 1134ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 1135ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1136ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 1137ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 1138ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1139ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1140cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 1141cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 114260ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor declaresSameEntity(IC->getClassInterface(), ClassDeclared)) { 1143ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 1144ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 1145ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 1146ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1147ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 114828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 114928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 115028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 115128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 1152e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_duplicate_ivar_use) 115328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 115428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 115528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 115628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 115728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 115828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 115928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 1160e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_implemented) << PropertyId; 116128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1162d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 116328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 116428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 116528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 116628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 1167d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 116828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 116928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 117028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 117128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 117228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 117328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 11749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 11759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 11769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 11779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 11789d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 11799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 11809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 11819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 11829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 11839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 11849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 11859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 11869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 11879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 11889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 11899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 11909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 11919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 11929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 11931b46d8d78be713c546fb9680eaeea8f793bee5bfFariborz Jahanian else if (!(SAttr & ObjCPropertyDecl::OBJC_PR_readonly)){ 1194f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 1195f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 1196f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1197f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 1198f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 1199f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1200f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 1201f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 1202f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 1203f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 1204f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 1205f85e193739c953358c865005855253af4f68a497John McCall } 12069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 12089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 12099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 12109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 12119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 12129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 12139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 12149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 12159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 12169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 12179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 12199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 12209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 12219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 12229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1223c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 12248beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 12258beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 12268beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 12278beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 12288beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 12298beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 123013546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian IncompatibleObjC) { 12318beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 12328beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 123313546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 123413546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian } 12359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 12399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 12409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 12419abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!GetterMethod) 12429abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return false; 12439abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType GetterType = GetterMethod->getResultType().getNonReferenceType(); 12449abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType PropertyIvarType = property->getType().getNonReferenceType(); 12459abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian bool compat = Context.hasSameType(PropertyIvarType, GetterType); 12469abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 12479abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) && 12489abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian isa<ObjCObjectPointerType>(GetterType)) 12499abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = 12509abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Context.canAssignObjCInterfaces( 1251490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian GetterType->getAs<ObjCObjectPointerType>(), 1252490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>()); 1253490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian else if (CheckAssignmentConstraints(Loc, GetterType, PropertyIvarType) 12549abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian != Compatible) { 12559abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::error_property_accessor_type) 12569abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() << PropertyIvarType 12579abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector() << GetterType; 12589abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 12599abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 12609abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } else { 12619abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = true; 12629abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 12639abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType rhsType =Context.getCanonicalType(GetterType).getUnqualifiedType(); 12649abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (lhsType != rhsType && lhsType->isArithmeticType()) 12659abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = false; 12669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12689abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 12699abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 12709abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::warn_accessor_property_type_mismatch) 12719abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() 12729abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector(); 12739abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 12749abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 12759abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } 12769abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 12779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 12789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 12819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 1282fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 12839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 12849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 12859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 12869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 12879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 12889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 12899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 12909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 1291581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *SuperPDecl = *S; 12929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 12939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 12949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 1295581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *PDecl = *I; 12969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 12979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 12989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 12999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 13049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 13059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 13069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13079d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 13089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 13099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 13109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 13119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 13129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 13139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 13149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 13159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 13169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1317581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Pr = *P; 13189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 13199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 13202d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 1321262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie if (CP->getIdentifier() == Pr->getIdentifier()) 13229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 13239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 13249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 1325581deb3da481053c4993c7600f97acf7768caac5David Blaikie DiagnosePropertyMismatch(*CP, Pr, PDecl->getIdentifier()); 13269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 13309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1331581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Pr = *P; 13329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 13339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 13349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 1335262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie if (CP->getIdentifier() == Pr->getIdentifier()) 13369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 13379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 13389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 1339581deb3da481053c4993c7600f97acf7768caac5David Blaikie DiagnosePropertyMismatch(*CP, Pr, PDecl->getIdentifier()); 13409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 13449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 13459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 13469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 1347d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 1348d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 13509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 13539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 13549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 13609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 13629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 13639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 13649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 1365d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 13669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 13679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 13689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 13699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 13709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 13719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 137653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 137753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 137853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 13799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 13809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 13819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 13839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 138453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 138553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 138653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1387d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 13889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 13899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 13909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 13919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 13939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 13979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 13989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 13999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 14009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 14019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 14029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 14039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 14059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 14069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 14079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 14109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 14119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 1412d329724745b49f894b768d47275b7c2713106e89Douglas Gregor for (ObjCInterfaceDecl::visible_categories_iterator 1413d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Cat = IDecl->visible_categories_begin(), 1414d329724745b49f894b768d47275b7c2713106e89Douglas Gregor CatEnd = IDecl->visible_categories_end(); 1415d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Cat != CatEnd; ++Cat) { 1416d329724745b49f894b768d47275b7c2713106e89Douglas Gregor if (Cat->getInstanceMethod(PDecl->getSetterName())) 14179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 1419d329724745b49f894b768d47275b7c2713106e89Douglas Gregor Cat->FindPropertyDeclaration(PDecl->getIdentifier()); 14209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 14219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 14259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 14269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 14279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 14289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 14299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 14309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 14329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 14339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 14349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 14389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 14399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 14409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 14429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 14439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 14449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 14459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 14489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 14499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1450e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCContainerDecl::PropertyMap &PropMap, 1451e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCContainerDecl::PropertyMap &SuperPropMap) { 14529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 14539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 14549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 1455581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 14569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 14579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 145953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 146053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 146153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1462cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 14659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 14669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 14679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 1468581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 14699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 14709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 147253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 14739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1474cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 14779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 14789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1479581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1480cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1481cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1482cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1483a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian if (!PropertyFromSuper || 1484a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian PropertyFromSuper->getIdentifier() != Prop->getIdentifier()) { 1485cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1486cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1487cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1488cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 14899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 14919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 14929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1493cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1497509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1498509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1499509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1500509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1501e63aedd0cb064fc106636ad856cc0e645e6374ceAnna Zaks ObjCInterfaceDecl::PropertyMap &PropMap) { 1502509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1503509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1504b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks SDecl->collectPropertiesToImplement(PropMap); 1505509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1506509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1507509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1508509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1509509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1510699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// \brief Default synthesizes all properties which must be synthesized 1511699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// in class's \@implementation. 1512d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekvoid Sema::DefaultSynthesizeProperties(Scope *S, ObjCImplDecl* IMPDecl, 1513d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ObjCInterfaceDecl *IDecl) { 1514509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1515b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCInterfaceDecl::PropertyMap PropMap; 1516b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks IDecl->collectPropertiesToImplement(PropMap); 1517509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1518509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1519b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCInterfaceDecl::PropertyMap SuperPropMap; 1520509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1521509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1522b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks for (ObjCInterfaceDecl::PropertyMap::iterator 1523509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1524509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1525509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1526509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1527509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1528b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks // Is there a matching property synthesize/dynamic? 1529509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1530509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1531509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1532509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1533d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1534d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1535d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 153695f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 153795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 153895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 153995f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 154095f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 154195f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1542f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian if (isa<ObjCProtocolDecl>(Prop->getDeclContext())) { 1543f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian // We won't auto-synthesize properties declared in protocols. 1544f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(IMPDecl->getLocation(), 1545f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian diag::warn_auto_synthesizing_protocol_property); 1546f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(Prop->getLocation(), diag::note_property_declare); 1547f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian continue; 1548f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian } 15492a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 15502a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 15512a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 15522a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 15532a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 1554975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ObjCPropertyImplDecl *PIDecl = dyn_cast_or_null<ObjCPropertyImplDecl>( 1555975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1556975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian true, 1557975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian /* property = */ Prop->getIdentifier(), 1558ad0ce53c8219456938405b84c5d13341a47e3d94Anna Zaks /* ivar = */ Prop->getDefaultSynthIvarName(Context), 1559390fff8e8b480fa146ffc14cbc63a1c2f9e2d206Argyrios Kyrtzidis Prop->getLocation())); 1560975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian if (PIDecl) { 1561975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian Diag(Prop->getLocation(), diag::warn_missing_explicit_synthesis); 15625ea66619a3108e2985e952b9a60a84316d464b25Fariborz Jahanian Diag(IMPDecl->getLocation(), diag::note_while_in_implementation); 1563975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian } 15642a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1565509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 15669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15678697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 1568260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (!LangOpts.ObjCDefaultSynthProperties || LangOpts.ObjCRuntime.isFragile()) 15698697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 15708697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 15718697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 15728697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 15738697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 157471207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (!IDecl->isObjCRequiresPropertyDefs()) 1575eb4f2c56c298071d58b441ccf801b039be93788aFariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 15768697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 15778697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 157817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 15799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 1580811bfcd823d51db6a06b3fd5a5943ff910b79d68Benjamin Kramer const SelectorSet &InsMap) { 1581277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian ObjCContainerDecl::PropertyMap NoNeedToImplPropMap; 1582277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian ObjCInterfaceDecl *IDecl; 1583277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // Gather properties which need not be implemented in this class 1584277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // or category. 1585277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (!(IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl))) 1586277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) { 1587277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // For categories, no need to implement properties declared in 1588277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // its primary class (and its super classes) if property is 1589277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian // declared in one of those containers. 1590277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if ((IDecl = C->getClassInterface())) 1591277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian IDecl->collectPropertiesToImplement(NoNeedToImplPropMap); 1592277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian } 1593277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian if (IDecl) 1594277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, NoNeedToImplPropMap); 1595cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 1596b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks ObjCContainerDecl::PropertyMap PropMap; 1597277076a4cdf684e6ea102197a635d4a352998018Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, NoNeedToImplPropMap); 15989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 15999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 16009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 16029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 16039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 16049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 1605262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie PropImplMap.insert(I->getPropertyDecl()); 16069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1607b36ea375e20f71df19c101fa2399b7ea3a607e04Anna Zaks for (ObjCContainerDecl::PropertyMap::iterator 16089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 16099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 16109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 16119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 16129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 16137cdc45751cb5b200ad5fff0de28c5d1a64b6fce3Douglas Gregor PropImplMap.count(Prop) || 16147cdc45751cb5b200ad5fff0de28c5d1a64b6fce3Douglas Gregor Prop->getAvailability() == AR_Unavailable) 16159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 16169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 1617b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 16189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 16199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 16209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 16219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1622b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1623b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1624260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1625da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 162671207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1627da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 1628da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian 16299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1632b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 16339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 16349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 16359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 16369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1637b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1638b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1639260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1640da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 164171207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1642da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 16439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 16469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 16489d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 16499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 16509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 16514e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC) 16529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 16539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 16549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 16559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 1656581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Property = *I; 165794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 165894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 165994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 166094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1661ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = Property->getPropertyAttributes(); 1662265941bc308d65cc270d5c4de5806f37ce405606John McCall unsigned AttributesAsWritten = Property->getPropertyAttributesAsWritten(); 166394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1664265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic) && 1665265941bc308d65cc270d5c4de5806f37ce405606John McCall !(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 166694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 166794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 166894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 166994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 167094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 167194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1672293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 167394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 167494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 167594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 167694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 167794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1678293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 167994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 168094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 168194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 168294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 16839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 1684ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 1685ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 16869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 16879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 16889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 16899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 16909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 169194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 169294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 169394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 169494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 169594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 16969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 16979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 16989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 16999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 17009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 17017d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << Property->getIdentifier() << (GetterMethod != 0) 17027d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << (SetterMethod != 0); 170377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // fixit stuff. 170477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (!AttributesAsWritten) { 170577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (Property->getLParenLoc().isValid()) { 170677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 170777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), 170877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getLParenLoc()); 170977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 171077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic"); 171177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 171277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else { 171377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian //@property id etc. 171477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = 171577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getTypeSourceInfo()->getTypeLoc().getBeginLoc(); 171677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian endLoc = endLoc.getLocWithOffset(-1); 171777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 171877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 171977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic) "); 172077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 172177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 172277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic)) { 172377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 172477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = Property->getLParenLoc(); 172577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 172677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 172777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic, "); 172877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 172977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else 173077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(MethodLoc, diag::note_atomic_property_fixup_suggest); 17319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 17329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 17369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1737f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 17384e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::GCOnly) 1739f85e193739c953358c865005855253af4f68a497John McCall return; 1740f85e193739c953358c865005855253af4f68a497John McCall 1741f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1742f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1743581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyImplDecl *PID = *i; 1744f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1745f85e193739c953358c865005855253af4f68a497John McCall continue; 1746f85e193739c953358c865005855253af4f68a497John McCall 1747f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1748831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1749831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1750f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1751f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1752f85e193739c953358c865005855253af4f68a497John McCall continue; 1753f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1754f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1755f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 17564e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1757f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1758f85e193739c953358c865005855253af4f68a497John McCall else 1759920c9c1155c118ac40e5209d4b757b9f54186339Ted Kremenek Diag(PID->getLocation(), diag::warn_owning_getter_rule); 1760f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1761f85e193739c953358c865005855253af4f68a497John McCall } 1762f85e193739c953358c865005855253af4f68a497John McCall } 1763f85e193739c953358c865005855253af4f68a497John McCall } 1764f85e193739c953358c865005855253af4f68a497John McCall} 1765f85e193739c953358c865005855253af4f68a497John McCall 17665de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 17675de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 17685de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 17695de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 17705de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 17710a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 17720a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 17730a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 17740a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 17750a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 17760a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 17770a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 17780a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 17795de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 17805de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 17819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 17829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 17839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 17849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 17859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 17869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 17878254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 17888254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 17898254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 17908254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 17919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 17929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 17949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 17959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 17969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 17979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 17999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 18009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 18019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 18029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 18039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 18049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 18059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 18062aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian !Context.hasSameUnqualifiedType( 1807bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian (*SetterMethod->param_begin())->getType().getNonReferenceType(), 1808bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian property->getType().getNonReferenceType())) { 18099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 18109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 18119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 18129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 18139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 18149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 18179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 18189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 18199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 18209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 18219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 18229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 18239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 18249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 18259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 18269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1827a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1828a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1829a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1830a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1831a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1832a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 183375cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 18341e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose /*isVariadic=*/false, /*isPropertyAccessor=*/true, 183575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 18369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 18379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 18389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 18399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 18409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 18415de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 18425de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 18435de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 184423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 184523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1846a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 184723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1848831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1849831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1850831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 18519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 18529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 18539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 18541e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose GetterMethod->setPropertyAccessor(true); 18559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 18569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 18579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 18589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 18599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 18609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 18619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 18629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 18639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 18648254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 18658254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 18668254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 18678254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 18688254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 1869491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ObjCMethodDecl::Create(Context, Loc, Loc, 18708254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 187175cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 18721e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose /*isPropertyAccessor=*/true, 187375cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 187475cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 18759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 18769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 18778254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 18788254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 18798254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 18809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 18819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1882ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1883ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 18849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1885f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 18869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1887d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1888d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 18899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 1890491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis SetterMethod->setMethodParams(Context, Argument, 1891491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ArrayRef<SourceLocation>()); 18925de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 18935de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 18945de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 18959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 189623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 189723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 18988254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 189923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 19009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 19019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 19029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 19031e4691b9d8e1bdcc8ef62b323969d702c51b3c08Jordan Rose SetterMethod->setPropertyAccessor(true); 19049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 19059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 19069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 19079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 19089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 19099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 19109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 19119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 19129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 19139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 19149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 19159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 19169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 19179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 19189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 19199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 19209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 19219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 1922e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis 1923e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(CD); 1924e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (!CurrentClass) { 1925e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(CD)) 1926e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Cat->getClassInterface(); 1927e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(CD)) 1928e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Impl->getClassInterface(); 1929e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis } 1930e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (GetterMethod) 1931e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(GetterMethod, CurrentClass, Sema::RTC_Unknown); 1932e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (SetterMethod) 1933e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(SetterMethod, CurrentClass, Sema::RTC_Unknown); 19349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 19359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1936d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 19379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 1938ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned &Attributes, 1939cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian bool propertyInPrimaryClass) { 19409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1941f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 19425fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 19435fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 19445fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1945842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 19469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 1948ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1949015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian PropertyTy->isObjCRetainableType()) { 1950015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // 'readonly' property with no obvious lifetime. 1951015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // its life time will be determined by its backing ivar. 1952015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian unsigned rel = (ObjCDeclSpec::DQ_PR_unsafe_unretained | 1953015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 1954015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 1955015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong | 1956015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_weak | 1957015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_assign); 1958ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & rel) == 0) 1959015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 1960015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 1961015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 1962cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (propertyInPrimaryClass) { 1963cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // we postpone most property diagnosis until class's implementation 1964cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // because, its readonly attribute may be overridden in its class 1965cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // extensions making other attributes, which make no sense, to make sense. 1966ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1967ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_readwrite)) 1968cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1969cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << "readwrite"; 1970cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 19719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 1972ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1973ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 197428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 1975f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 197628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 1977f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 1978f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 1979ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 198028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 1981ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 198228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 1983ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 1984f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 1985ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 198628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 19879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1988ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 198928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 199028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 199128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 199228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 19939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 199428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 1995ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1996f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 1997f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 1998842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 199928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 2000ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 2001ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 2002ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2003f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 2004977ea7864a50eee39f6bef8a5a79154ac9ba4b3eJohn McCall PropertyDecl->setInvalidDecl(); 200528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 20069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 200728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 2008ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 2009ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 201028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 201128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 2012ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 201328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2014ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 201528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 201628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 2017ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 201828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2019ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2020f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2021f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 2022ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2023f85e193739c953358c865005855253af4f68a497John McCall } 20244e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2025ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2026f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2027f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 2028ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2029f85e193739c953358c865005855253af4f68a497John McCall } 2030ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 2031ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2032f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2033f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 2034ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 2035f85e193739c953358c865005855253af4f68a497John McCall } 2036ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 2037f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2038f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 2039ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2040f85e193739c953358c865005855253af4f68a497John McCall } 2041ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2042f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2043f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 2044ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2045f85e193739c953358c865005855253af4f68a497John McCall } 20464e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2047ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2048f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2049f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 2050ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2051f85e193739c953358c865005855253af4f68a497John McCall } 2052ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2053ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 205428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 205528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 2056ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 205728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2058ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2059f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2060f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 2061ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2062f85e193739c953358c865005855253af4f68a497John McCall } 2063ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 2064f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2065f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 2066ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2067f85e193739c953358c865005855253af4f68a497John McCall } 2068f85e193739c953358c865005855253af4f68a497John McCall } 2069ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2070ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2071f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2072f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 2073ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2074f85e193739c953358c865005855253af4f68a497John McCall } 2075ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 2076ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2077f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2078f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 2079ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 208028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 20819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2082ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_atomic) && 2083ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)) { 20849d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 20859d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian << "atomic" << "nonatomic"; 2086ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling Attributes &= ~ObjCDeclSpec::DQ_PR_atomic; 20879d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian } 20889d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian 208928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 209028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 2091ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 2092f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 2093f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 2094f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 209528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 20964e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 2097bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 2098f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian // not specified; including when property is 'readonly'. 2099bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 2100ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if (!(Attributes & ObjCDeclSpec::DQ_PR_readonly)) { 21019f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian bool isAnyClassTy = 21029f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian (PropertyTy->isObjCClassType() || 21039f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian PropertyTy->isObjCQualifiedClassType()); 21049f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // In non-gc, non-arc mode, 'Class' is treated as a 'void *' no need to 21059f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // issue any warning. 21064e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (isAnyClassTy && getLangOpts().getGC() == LangOptions::NonGC) 21079f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian ; 2108f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian else if (propertyInPrimaryClass) { 2109f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian // Don't issue warning on property with no life time in class 2110f224fb5de15e10cecd2d87fee73b0e39b503d924Fariborz Jahanian // extension as it is inherited from property in primary class. 2111bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 21124e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::GCOnly) 2113bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 21140a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 2115bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 21164e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::NonGC) 2117bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 21189f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian } 2119bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 21209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 212128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 212228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 212328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 212428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 212528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2127ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 2128ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 21294e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie && getLangOpts().getGC() == LangOptions::GCOnly 213028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 213128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 2132ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2133ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2134ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 2135528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian PropertyTy->isBlockPointerType()) 2136528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Diag(Loc, diag::warn_objc_property_retain_of_block); 213748a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 2138ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2139ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling (Attributes & ObjCDeclSpec::DQ_PR_setter)) 214048a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian Diag(Loc, diag::warn_objc_readonly_property_has_setter); 214148a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 21429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 2143