CallAndMessageChecker.cpp revision a2a860306e3697fcf7a12c5ba59551ca60578968
146d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)//===--- CallAndMessageChecker.cpp ------------------------------*- C++ -*--==//
246d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)//
346d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)//                     The LLVM Compiler Infrastructure
446d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)//
546d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)// This file is distributed under the University of Illinois Open Source
646d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)// License. See LICENSE.TXT for details.
746d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)//
846d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)//===----------------------------------------------------------------------===//
946d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)//
1046d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)// This defines CallAndMessageChecker, a builtin checker that checks for various
1146d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)// errors of call and objc message expressions.
12f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)//
13f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)//===----------------------------------------------------------------------===//
14f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)
15f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)#include "ClangSACheckers.h"
1646d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)#include "clang/StaticAnalyzer/Core/Checker.h"
17f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)#include "clang/StaticAnalyzer/Core/CheckerManager.h"
1846d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
1946d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)#include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h"
2046d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
21f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)#include "clang/AST/ParentMap.h"
2246d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)#include "clang/Basic/TargetInfo.h"
2346d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
24f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)using namespace clang;
25f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)using namespace ento;
2646d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
27f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)namespace {
2846d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)class CallAndMessageChecker
2946d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  : public Checker< check::PreStmt<CallExpr>, check::PreObjCMessage > {
3046d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  mutable llvm::OwningPtr<BugType> BT_call_null;
3146d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  mutable llvm::OwningPtr<BugType> BT_call_undef;
3246d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  mutable llvm::OwningPtr<BugType> BT_call_arg;
3346d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  mutable llvm::OwningPtr<BugType> BT_msg_undef;
3446d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  mutable llvm::OwningPtr<BugType> BT_msg_arg;
3546d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  mutable llvm::OwningPtr<BugType> BT_msg_ret;
3646d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)public:
3746d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
3846d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  void checkPreStmt(const CallExpr *CE, CheckerContext &C) const;
3946d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  void checkPreObjCMessage(ObjCMessage msg, CheckerContext &C) const;
4046d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
4146d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)private:
4246d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  static void PreVisitProcessArgs(CheckerContext &C,CallOrObjCMessage callOrMsg,
4346d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)                             const char *BT_desc, llvm::OwningPtr<BugType> &BT);
4446d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  static bool PreVisitProcessArg(CheckerContext &C, SVal V,SourceRange argRange,
4546d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)          const Expr *argEx, const char *BT_desc, llvm::OwningPtr<BugType> &BT);
4646d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
4746d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  static void EmitBadCall(BugType *BT, CheckerContext &C, const CallExpr *CE);
4846d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  void emitNilReceiverBug(CheckerContext &C, const ObjCMessage &msg,
4946d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)                          ExplodedNode *N) const;
5046d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
5146d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  void HandleNilReceiver(CheckerContext &C,
5246d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)                         const ProgramState *state,
5346d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)                         ObjCMessage msg) const;
5446d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
5546d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  static void LazyInit_BT(const char *desc, llvm::OwningPtr<BugType> &BT) {
5646d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)    if (!BT)
5746d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)      BT.reset(new BuiltinBug(desc));
586e8cce623b6e4fe0c9e4af605d675dd9d0338c38Torne (Richard Coles)  }
596e8cce623b6e4fe0c9e4af605d675dd9d0338c38Torne (Richard Coles)};
6046d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)} // end anonymous namespace
6146d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
6246d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)void CallAndMessageChecker::EmitBadCall(BugType *BT, CheckerContext &C,
6346d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)                                        const CallExpr *CE) {
6446d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  ExplodedNode *N = C.generateSink();
6546d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  if (!N)
6646d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)    return;
6746d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
68f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)  BugReport *R = new BugReport(*BT, BT->getName(), N);
69f8ee788a64d60abd8f2d742a5fdedde054ecd910Torne (Richard Coles)  R->addVisitor(bugreporter::getTrackNullOrUndefValueVisitor(N,
7046d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)                               bugreporter::GetCalleeExpr(N)));
7146d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)  C.EmitReport(R);
7246d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)}
7346d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)
7446d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)void CallAndMessageChecker::PreVisitProcessArgs(CheckerContext &C,
7546d4c2bc3267f3f028f39e7e311b0f89aba2e4fdTorne (Richard Coles)                                                CallOrObjCMessage callOrMsg,
76                                                const char *BT_desc,
77                                                llvm::OwningPtr<BugType> &BT) {
78  for (unsigned i = 0, e = callOrMsg.getNumArgs(); i != e; ++i)
79    if (PreVisitProcessArg(C, callOrMsg.getArgSVal(i),
80                           callOrMsg.getArgSourceRange(i), callOrMsg.getArg(i),
81                           BT_desc, BT))
82      return;
83}
84
85bool CallAndMessageChecker::PreVisitProcessArg(CheckerContext &C,
86                                               SVal V, SourceRange argRange,
87                                               const Expr *argEx,
88                                               const char *BT_desc,
89                                               llvm::OwningPtr<BugType> &BT) {
90
91  if (V.isUndef()) {
92    if (ExplodedNode *N = C.generateSink()) {
93      LazyInit_BT(BT_desc, BT);
94
95      // Generate a report for this bug.
96      BugReport *R = new BugReport(*BT, BT->getName(), N);
97      R->addRange(argRange);
98      if (argEx)
99        R->addVisitor(bugreporter::getTrackNullOrUndefValueVisitor(N, argEx));
100      C.EmitReport(R);
101    }
102    return true;
103  }
104
105  if (const nonloc::LazyCompoundVal *LV =
106        dyn_cast<nonloc::LazyCompoundVal>(&V)) {
107
108    class FindUninitializedField {
109    public:
110      SmallVector<const FieldDecl *, 10> FieldChain;
111    private:
112      ASTContext &C;
113      StoreManager &StoreMgr;
114      MemRegionManager &MrMgr;
115      Store store;
116    public:
117      FindUninitializedField(ASTContext &c, StoreManager &storeMgr,
118                             MemRegionManager &mrMgr, Store s)
119      : C(c), StoreMgr(storeMgr), MrMgr(mrMgr), store(s) {}
120
121      bool Find(const TypedValueRegion *R) {
122        QualType T = R->getValueType();
123        if (const RecordType *RT = T->getAsStructureType()) {
124          const RecordDecl *RD = RT->getDecl()->getDefinition();
125          assert(RD && "Referred record has no definition");
126          for (RecordDecl::field_iterator I =
127               RD->field_begin(), E = RD->field_end(); I!=E; ++I) {
128            const FieldRegion *FR = MrMgr.getFieldRegion(*I, R);
129            FieldChain.push_back(*I);
130            T = (*I)->getType();
131            if (T->getAsStructureType()) {
132              if (Find(FR))
133                return true;
134            }
135            else {
136              const SVal &V = StoreMgr.Retrieve(store, loc::MemRegionVal(FR));
137              if (V.isUndef())
138                return true;
139            }
140            FieldChain.pop_back();
141          }
142        }
143
144        return false;
145      }
146    };
147
148    const LazyCompoundValData *D = LV->getCVData();
149    FindUninitializedField F(C.getASTContext(),
150                             C.getState()->getStateManager().getStoreManager(),
151                             C.getSValBuilder().getRegionManager(),
152                             D->getStore());
153
154    if (F.Find(D->getRegion())) {
155      if (ExplodedNode *N = C.generateSink()) {
156        LazyInit_BT(BT_desc, BT);
157        llvm::SmallString<512> Str;
158        llvm::raw_svector_ostream os(Str);
159        os << "Passed-by-value struct argument contains uninitialized data";
160
161        if (F.FieldChain.size() == 1)
162          os << " (e.g., field: '" << *F.FieldChain[0] << "')";
163        else {
164          os << " (e.g., via the field chain: '";
165          bool first = true;
166          for (SmallVectorImpl<const FieldDecl *>::iterator
167               DI = F.FieldChain.begin(), DE = F.FieldChain.end(); DI!=DE;++DI){
168            if (first)
169              first = false;
170            else
171              os << '.';
172            os << **DI;
173          }
174          os << "')";
175        }
176
177        // Generate a report for this bug.
178        BugReport *R = new BugReport(*BT, os.str(), N);
179        R->addRange(argRange);
180
181        // FIXME: enhance track back for uninitialized value for arbitrary
182        // memregions
183        C.EmitReport(R);
184      }
185      return true;
186    }
187  }
188
189  return false;
190}
191
192void CallAndMessageChecker::checkPreStmt(const CallExpr *CE,
193                                         CheckerContext &C) const{
194
195  const Expr *Callee = CE->getCallee()->IgnoreParens();
196  SVal L = C.getState()->getSVal(Callee);
197
198  if (L.isUndef()) {
199    if (!BT_call_undef)
200      BT_call_undef.reset(new BuiltinBug("Called function pointer is an "
201                                         "uninitalized pointer value"));
202    EmitBadCall(BT_call_undef.get(), C, CE);
203    return;
204  }
205
206  if (isa<loc::ConcreteInt>(L)) {
207    if (!BT_call_null)
208      BT_call_null.reset(
209        new BuiltinBug("Called function pointer is null (null dereference)"));
210    EmitBadCall(BT_call_null.get(), C, CE);
211  }
212
213  PreVisitProcessArgs(C, CallOrObjCMessage(CE, C.getState()),
214                      "Function call argument is an uninitialized value",
215                      BT_call_arg);
216}
217
218void CallAndMessageChecker::checkPreObjCMessage(ObjCMessage msg,
219                                                CheckerContext &C) const {
220
221  const ProgramState *state = C.getState();
222
223  // FIXME: Handle 'super'?
224  if (const Expr *receiver = msg.getInstanceReceiver()) {
225    SVal recVal = state->getSVal(receiver);
226    if (recVal.isUndef()) {
227      if (ExplodedNode *N = C.generateSink()) {
228        if (!BT_msg_undef)
229          BT_msg_undef.reset(new BuiltinBug("Receiver in message expression is "
230                                            "an uninitialized value"));
231        BugReport *R =
232          new BugReport(*BT_msg_undef, BT_msg_undef->getName(), N);
233        R->addRange(receiver->getSourceRange());
234        R->addVisitor(bugreporter::getTrackNullOrUndefValueVisitor(N,
235                                                                   receiver));
236        C.EmitReport(R);
237      }
238      return;
239    } else {
240      // Bifurcate the state into nil and non-nil ones.
241      DefinedOrUnknownSVal receiverVal = cast<DefinedOrUnknownSVal>(recVal);
242
243      const ProgramState *notNilState, *nilState;
244      llvm::tie(notNilState, nilState) = state->assume(receiverVal);
245
246      // Handle receiver must be nil.
247      if (nilState && !notNilState) {
248        HandleNilReceiver(C, state, msg);
249        return;
250      }
251    }
252  }
253
254  const char *bugDesc = msg.isPropertySetter() ?
255                     "Argument for property setter is an uninitialized value"
256                   : "Argument in message expression is an uninitialized value";
257  // Check for any arguments that are uninitialized/undefined.
258  PreVisitProcessArgs(C, CallOrObjCMessage(msg, state), bugDesc, BT_msg_arg);
259}
260
261void CallAndMessageChecker::emitNilReceiverBug(CheckerContext &C,
262                                               const ObjCMessage &msg,
263                                               ExplodedNode *N) const {
264
265  if (!BT_msg_ret)
266    BT_msg_ret.reset(
267      new BuiltinBug("Receiver in message expression is "
268                     "'nil' and returns a garbage value"));
269
270  llvm::SmallString<200> buf;
271  llvm::raw_svector_ostream os(buf);
272  os << "The receiver of message '" << msg.getSelector().getAsString()
273     << "' is nil and returns a value of type '"
274     << msg.getType(C.getASTContext()).getAsString() << "' that will be garbage";
275
276  BugReport *report = new BugReport(*BT_msg_ret, os.str(), N);
277  if (const Expr *receiver = msg.getInstanceReceiver()) {
278    report->addRange(receiver->getSourceRange());
279    report->addVisitor(bugreporter::getTrackNullOrUndefValueVisitor(N,
280                                                                    receiver));
281  }
282  C.EmitReport(report);
283}
284
285static bool supportsNilWithFloatRet(const llvm::Triple &triple) {
286  return triple.getVendor() == llvm::Triple::Apple &&
287         (!triple.isMacOSXVersionLT(10,5) ||
288          triple.getArch() == llvm::Triple::arm ||
289          triple.getArch() == llvm::Triple::thumb);
290}
291
292void CallAndMessageChecker::HandleNilReceiver(CheckerContext &C,
293                                              const ProgramState *state,
294                                              ObjCMessage msg) const {
295  ASTContext &Ctx = C.getASTContext();
296
297  // Check the return type of the message expression.  A message to nil will
298  // return different values depending on the return type and the architecture.
299  QualType RetTy = msg.getType(Ctx);
300  CanQualType CanRetTy = Ctx.getCanonicalType(RetTy);
301
302  if (CanRetTy->isStructureOrClassType()) {
303    // Structure returns are safe since the compiler zeroes them out.
304    SVal V = C.getSValBuilder().makeZeroVal(msg.getType(Ctx));
305    C.addTransition(state->BindExpr(msg.getOriginExpr(), V));
306    return;
307  }
308
309  // Other cases: check if sizeof(return type) > sizeof(void*)
310  if (CanRetTy != Ctx.VoidTy && C.getLocationContext()->getParentMap()
311                                  .isConsumedExpr(msg.getOriginExpr())) {
312    // Compute: sizeof(void *) and sizeof(return type)
313    const uint64_t voidPtrSize = Ctx.getTypeSize(Ctx.VoidPtrTy);
314    const uint64_t returnTypeSize = Ctx.getTypeSize(CanRetTy);
315
316    if (voidPtrSize < returnTypeSize &&
317        !(supportsNilWithFloatRet(Ctx.getTargetInfo().getTriple()) &&
318          (Ctx.FloatTy == CanRetTy ||
319           Ctx.DoubleTy == CanRetTy ||
320           Ctx.LongDoubleTy == CanRetTy ||
321           Ctx.LongLongTy == CanRetTy ||
322           Ctx.UnsignedLongLongTy == CanRetTy))) {
323      if (ExplodedNode *N = C.generateSink(state))
324        emitNilReceiverBug(C, msg, N);
325      return;
326    }
327
328    // Handle the safe cases where the return value is 0 if the
329    // receiver is nil.
330    //
331    // FIXME: For now take the conservative approach that we only
332    // return null values if we *know* that the receiver is nil.
333    // This is because we can have surprises like:
334    //
335    //   ... = [[NSScreens screens] objectAtIndex:0];
336    //
337    // What can happen is that [... screens] could return nil, but
338    // it most likely isn't nil.  We should assume the semantics
339    // of this case unless we have *a lot* more knowledge.
340    //
341    SVal V = C.getSValBuilder().makeZeroVal(msg.getType(Ctx));
342    C.addTransition(state->BindExpr(msg.getOriginExpr(), V));
343    return;
344  }
345
346  C.addTransition(state);
347}
348
349void ento::registerCallAndMessageChecker(CheckerManager &mgr) {
350  mgr.registerChecker<CallAndMessageChecker>();
351}
352