1dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// MallocSizeofChecker.cpp - Check for dubious malloc arguments ---*- C++ -*-=// 2dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// 3dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// The LLVM Compiler Infrastructure 4dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// 5dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// This file is distributed under the University of Illinois Open Source 6dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// License. See LICENSE.TXT for details. 7dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// 8dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne//===----------------------------------------------------------------------===// 9dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// 10dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// Reports inconsistencies between the casted type of the return value of a 11dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// malloc/calloc/realloc call and the operand of any sizeof expressions 12dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// contained within its argument(s). 13dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne// 14dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne//===----------------------------------------------------------------------===// 15dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 16dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne#include "ClangSACheckers.h" 1755fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/StmtVisitor.h" 1855fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/TypeLoc.h" 19dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h" 20dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne#include "clang/StaticAnalyzer/Core/Checker.h" 21dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne#include "clang/StaticAnalyzer/Core/CheckerManager.h" 22dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne#include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h" 238fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 24a93d0f280693b8418bc88cf7a8c93325f7fcf4c6Benjamin Kramer#include "llvm/Support/raw_ostream.h" 25dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 26dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourneusing namespace clang; 27dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourneusing namespace ento; 28dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 29dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbournenamespace { 30dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 31dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbournetypedef std::pair<const TypeSourceInfo *, const CallExpr *> TypeCallPair; 32dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbournetypedef llvm::PointerUnion<const Stmt *, const VarDecl *> ExprParent; 33dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 34dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourneclass CastedAllocFinder 35dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne : public ConstStmtVisitor<CastedAllocFinder, TypeCallPair> { 36dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne IdentifierInfo *II_malloc, *II_calloc, *II_realloc; 37dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 38dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbournepublic: 39dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne struct CallRecord { 40dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne ExprParent CastedExprParent; 41dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne const Expr *CastedExpr; 42dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne const TypeSourceInfo *ExplicitCastType; 43dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne const CallExpr *AllocCall; 44dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 45dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne CallRecord(ExprParent CastedExprParent, const Expr *CastedExpr, 46dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne const TypeSourceInfo *ExplicitCastType, 47dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne const CallExpr *AllocCall) 48dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne : CastedExprParent(CastedExprParent), CastedExpr(CastedExpr), 49dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne ExplicitCastType(ExplicitCastType), AllocCall(AllocCall) {} 50dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne }; 51dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 52dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne typedef std::vector<CallRecord> CallVec; 53dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne CallVec Calls; 54dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 55dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne CastedAllocFinder(ASTContext *Ctx) : 56dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne II_malloc(&Ctx->Idents.get("malloc")), 57dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne II_calloc(&Ctx->Idents.get("calloc")), 58dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne II_realloc(&Ctx->Idents.get("realloc")) {} 59dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 60dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne void VisitChild(ExprParent Parent, const Stmt *S) { 61dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne TypeCallPair AllocCall = Visit(S); 62dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (AllocCall.second && AllocCall.second != S) 63dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne Calls.push_back(CallRecord(Parent, cast<Expr>(S), AllocCall.first, 64dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne AllocCall.second)); 65dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 66dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 67dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne void VisitChildren(const Stmt *S) { 68dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne for (Stmt::const_child_iterator I = S->child_begin(), E = S->child_end(); 69dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne I!=E; ++I) 70dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (const Stmt *child = *I) 71dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne VisitChild(S, child); 72dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 73dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 74dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne TypeCallPair VisitCastExpr(const CastExpr *E) { 75dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return Visit(E->getSubExpr()); 76dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 77dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 78dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne TypeCallPair VisitExplicitCastExpr(const ExplicitCastExpr *E) { 79dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return TypeCallPair(E->getTypeInfoAsWritten(), 80dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne Visit(E->getSubExpr()).second); 81dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 82dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 83dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne TypeCallPair VisitParenExpr(const ParenExpr *E) { 84dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return Visit(E->getSubExpr()); 85dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 86dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 87dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne TypeCallPair VisitStmt(const Stmt *S) { 88dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne VisitChildren(S); 89dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return TypeCallPair(); 90dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 91dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 92dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne TypeCallPair VisitCallExpr(const CallExpr *E) { 93dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne VisitChildren(E); 94dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne const FunctionDecl *FD = E->getDirectCallee(); 95dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (FD) { 96dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne IdentifierInfo *II = FD->getIdentifier(); 97dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (II == II_malloc || II == II_calloc || II == II_realloc) 986bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines return TypeCallPair((const TypeSourceInfo *)nullptr, E); 99dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 100dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return TypeCallPair(); 101dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 102dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 103dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne TypeCallPair VisitDeclStmt(const DeclStmt *S) { 104651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines for (const auto *I : S->decls()) 105651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (const VarDecl *VD = dyn_cast<VarDecl>(I)) 106dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (const Expr *Init = VD->getInit()) 107dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne VisitChild(VD, Init); 108dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return TypeCallPair(); 109dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 110dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne}; 111dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 112dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourneclass SizeofFinder : public ConstStmtVisitor<SizeofFinder> { 113dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbournepublic: 114dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne std::vector<const UnaryExprOrTypeTraitExpr *> Sizeofs; 115dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 116dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne void VisitBinMul(const BinaryOperator *E) { 117dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne Visit(E->getLHS()); 118dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne Visit(E->getRHS()); 119dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 120dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 121dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne void VisitImplicitCastExpr(const ImplicitCastExpr *E) { 122dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return Visit(E->getSubExpr()); 123dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 124dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 125dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne void VisitParenExpr(const ParenExpr *E) { 126dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return Visit(E->getSubExpr()); 127dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 128dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 129dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne void VisitUnaryExprOrTypeTraitExpr(const UnaryExprOrTypeTraitExpr *E) { 130dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (E->getKind() != UETT_SizeOf) 131dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne return; 132dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 133dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne Sizeofs.push_back(E); 134dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 135dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne}; 136dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 13788db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek// Determine if the pointee and sizeof types are compatible. Here 13888db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek// we ignore constness of pointer types. 13988db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenekstatic bool typesCompatible(ASTContext &C, QualType A, QualType B) { 14088db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek while (true) { 14188db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek A = A.getCanonicalType(); 14288db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek B = B.getCanonicalType(); 14388db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek 14488db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek if (A.getTypePtr() == B.getTypePtr()) 14588db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek return true; 14688db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek 14788db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek if (const PointerType *ptrA = A->getAs<PointerType>()) 14888db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek if (const PointerType *ptrB = B->getAs<PointerType>()) { 149d21c96409fee1d09331d9218bd673d0df7352874Ted Kremenek A = ptrA->getPointeeType(); 150d21c96409fee1d09331d9218bd673d0df7352874Ted Kremenek B = ptrB->getPointeeType(); 151d21c96409fee1d09331d9218bd673d0df7352874Ted Kremenek continue; 15288db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek } 15388db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek 15488db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek break; 15588db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek } 15688db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek 15788db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek return false; 15888db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek} 15988db6a2daa8bb55fe924773805f42616c8a4f314Ted Kremenek 1609f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaksstatic bool compatibleWithArrayType(ASTContext &C, QualType PT, QualType T) { 1619f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks // Ex: 'int a[10][2]' is compatible with 'int', 'int[2]', 'int[10][2]'. 1629f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks while (const ArrayType *AT = T->getAsArrayTypeUnsafe()) { 1639f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks QualType ElemType = AT->getElementType(); 1649f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks if (typesCompatible(C, PT, AT->getElementType())) 1659f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks return true; 1669f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks T = ElemType; 1679f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks } 1689f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks 1699f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks return false; 1709f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks} 1719f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks 172dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourneclass MallocSizeofChecker : public Checker<check::ASTCodeBody> { 173dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbournepublic: 174dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne void checkASTCodeBody(const Decl *D, AnalysisManager& mgr, 175dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne BugReporter &BR) const { 176dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne AnalysisDeclContext *ADC = mgr.getAnalysisDeclContext(D); 177dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne CastedAllocFinder Finder(&BR.getContext()); 178dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne Finder.Visit(D->getBody()); 179dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne for (CastedAllocFinder::CallVec::iterator i = Finder.Calls.begin(), 180dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne e = Finder.Calls.end(); i != e; ++i) { 181dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne QualType CastedType = i->CastedExpr->getType(); 182dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (!CastedType->isPointerType()) 183dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne continue; 184dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne QualType PointeeType = CastedType->getAs<PointerType>()->getPointeeType(); 185dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (PointeeType->isVoidType()) 186dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne continue; 187dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 188dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne for (CallExpr::const_arg_iterator ai = i->AllocCall->arg_begin(), 189dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne ae = i->AllocCall->arg_end(); ai != ae; ++ai) { 190a5796f87229b4aeebca71fa6ee1790ae7a5a0382Jordan Rose if (!(*ai)->getType()->isIntegralOrUnscopedEnumerationType()) 191dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne continue; 192dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 193dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne SizeofFinder SFinder; 194dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne SFinder.Visit(*ai); 195dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne if (SFinder.Sizeofs.size() != 1) 196dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne continue; 197dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 198dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne QualType SizeofType = SFinder.Sizeofs[0]->getTypeOfArgument(); 199258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks 200258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks if (typesCompatible(BR.getContext(), PointeeType, SizeofType)) 201258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks continue; 202258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks 203258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks // If the argument to sizeof is an array, the result could be a 2049f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks // pointer to any array element. 2059f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks if (compatibleWithArrayType(BR.getContext(), PointeeType, SizeofType)) 2069f6ec8253e3ec3e9722ca7e4599f977db2f786efAnna Zaks continue; 207258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks 2086bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines const TypeSourceInfo *TSI = nullptr; 209258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks if (i->CastedExprParent.is<const VarDecl *>()) { 210258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks TSI = 211dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne i->CastedExprParent.get<const VarDecl *>()->getTypeSourceInfo(); 212258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks } else { 213258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks TSI = i->ExplicitCastType; 214258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks } 215258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks 216258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks SmallString<64> buf; 217258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks llvm::raw_svector_ostream OS(buf); 218258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks 219258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks OS << "Result of "; 220258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks const FunctionDecl *Callee = i->AllocCall->getDirectCallee(); 221258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks if (Callee && Callee->getIdentifier()) 222258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks OS << '\'' << Callee->getIdentifier()->getName() << '\''; 223258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks else 224258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks OS << "call"; 225258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks OS << " is converted to a pointer of type '" 226258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks << PointeeType.getAsString() << "', which is incompatible with " 227258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks << "sizeof operand type '" << SizeofType.getAsString() << "'"; 228cfa88f893915ceb8ae4ce2f17c46c24a4d67502fDmitri Gribenko SmallVector<SourceRange, 4> Ranges; 229258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks Ranges.push_back(i->AllocCall->getCallee()->getSourceRange()); 230258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks Ranges.push_back(SFinder.Sizeofs[0]->getSourceRange()); 231258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks if (TSI) 232258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks Ranges.push_back(TSI->getTypeLoc().getSourceRange()); 233258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks 234258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks PathDiagnosticLocation L = 235dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne PathDiagnosticLocation::createBegin(i->AllocCall->getCallee(), 236258bd59eee5403fc2a98fb23df71fa0281a3ec29Anna Zaks BR.getSourceManager(), ADC); 237dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 238651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines BR.EmitBasicReport(D, this, "Allocator sizeof operand mismatch", 239651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines categories::UnixAPI, OS.str(), L, Ranges); 240dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 241dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 242dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne } 243dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne}; 244dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 245dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne} 246dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne 247dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbournevoid ento::registerMallocSizeofChecker(CheckerManager &mgr) { 248dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne mgr.registerChecker<MallocSizeofChecker>(); 249dc30967a4633186782e0e204c65dba2552301ec9Peter Collingbourne} 250