BugReporterVisitors.cpp revision a4bb4f6ca8dd31ad96cb9526a5abe1273f18ff40
1// BugReporterVisitors.cpp - Helpers for reporting bugs -----------*- C++ -*--//
2//
3//                     The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10//  This file defines a set of BugReporter "visitors" which can be used to
11//  enhance the diagnostics reported for a bug.
12//
13//===----------------------------------------------------------------------===//
14#include "clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h"
15#include "clang/AST/Expr.h"
16#include "clang/AST/ExprObjC.h"
17#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
18#include "clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
20#include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h"
21#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
22#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "llvm/ADT/SmallString.h"
24#include "llvm/ADT/StringExtras.h"
25#include "llvm/Support/raw_ostream.h"
26
27using namespace clang;
28using namespace ento;
29
30using llvm::FoldingSetNodeID;
31
32//===----------------------------------------------------------------------===//
33// Utility functions.
34//===----------------------------------------------------------------------===//
35
36bool bugreporter::isDeclRefExprToReference(const Expr *E) {
37  if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) {
38    return DRE->getDecl()->getType()->isReferenceType();
39  }
40  return false;
41}
42
43const Expr *bugreporter::getDerefExpr(const Stmt *S) {
44  // Pattern match for a few useful cases (do something smarter later):
45  //   a[0], p->f, *p
46  const Expr *E = dyn_cast<Expr>(S);
47  if (!E)
48    return 0;
49  E = E->IgnoreParenCasts();
50
51  while (true) {
52    if (const BinaryOperator *B = dyn_cast<BinaryOperator>(E)) {
53      assert(B->isAssignmentOp());
54      E = B->getLHS()->IgnoreParenCasts();
55      continue;
56    }
57    else if (const UnaryOperator *U = dyn_cast<UnaryOperator>(E)) {
58      if (U->getOpcode() == UO_Deref)
59        return U->getSubExpr()->IgnoreParenCasts();
60    }
61    else if (const MemberExpr *ME = dyn_cast<MemberExpr>(E)) {
62      if (ME->isArrow() || isDeclRefExprToReference(ME->getBase())) {
63        return ME->getBase()->IgnoreParenCasts();
64      }
65    }
66    else if (const ObjCIvarRefExpr *IvarRef = dyn_cast<ObjCIvarRefExpr>(E)) {
67      return IvarRef->getBase()->IgnoreParenCasts();
68    }
69    else if (const ArraySubscriptExpr *AE = dyn_cast<ArraySubscriptExpr>(E)) {
70      return AE->getBase();
71    }
72    break;
73  }
74
75  return NULL;
76}
77
78const Stmt *bugreporter::GetDenomExpr(const ExplodedNode *N) {
79  const Stmt *S = N->getLocationAs<PreStmt>()->getStmt();
80  if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(S))
81    return BE->getRHS();
82  return NULL;
83}
84
85const Stmt *bugreporter::GetRetValExpr(const ExplodedNode *N) {
86  const Stmt *S = N->getLocationAs<PostStmt>()->getStmt();
87  if (const ReturnStmt *RS = dyn_cast<ReturnStmt>(S))
88    return RS->getRetValue();
89  return NULL;
90}
91
92//===----------------------------------------------------------------------===//
93// Definitions for bug reporter visitors.
94//===----------------------------------------------------------------------===//
95
96PathDiagnosticPiece*
97BugReporterVisitor::getEndPath(BugReporterContext &BRC,
98                               const ExplodedNode *EndPathNode,
99                               BugReport &BR) {
100  return 0;
101}
102
103PathDiagnosticPiece*
104BugReporterVisitor::getDefaultEndPath(BugReporterContext &BRC,
105                                      const ExplodedNode *EndPathNode,
106                                      BugReport &BR) {
107  PathDiagnosticLocation L =
108    PathDiagnosticLocation::createEndOfPath(EndPathNode,BRC.getSourceManager());
109
110  BugReport::ranges_iterator Beg, End;
111  llvm::tie(Beg, End) = BR.getRanges();
112
113  // Only add the statement itself as a range if we didn't specify any
114  // special ranges for this report.
115  PathDiagnosticPiece *P = new PathDiagnosticEventPiece(L,
116      BR.getDescription(),
117      Beg == End);
118  for (; Beg != End; ++Beg)
119    P->addRange(*Beg);
120
121  return P;
122}
123
124
125namespace {
126/// Emits an extra note at the return statement of an interesting stack frame.
127///
128/// The returned value is marked as an interesting value, and if it's null,
129/// adds a visitor to track where it became null.
130///
131/// This visitor is intended to be used when another visitor discovers that an
132/// interesting value comes from an inlined function call.
133class ReturnVisitor : public BugReporterVisitorImpl<ReturnVisitor> {
134  const StackFrameContext *StackFrame;
135  enum {
136    Initial,
137    MaybeUnsuppress,
138    Satisfied
139  } Mode;
140  bool InitiallySuppressed;
141
142public:
143  ReturnVisitor(const StackFrameContext *Frame, bool Suppressed)
144    : StackFrame(Frame), Mode(Initial), InitiallySuppressed(Suppressed) {}
145
146  static void *getTag() {
147    static int Tag = 0;
148    return static_cast<void *>(&Tag);
149  }
150
151  virtual void Profile(llvm::FoldingSetNodeID &ID) const {
152    ID.AddPointer(ReturnVisitor::getTag());
153    ID.AddPointer(StackFrame);
154    ID.AddBoolean(InitiallySuppressed);
155  }
156
157  /// Adds a ReturnVisitor if the given statement represents a call that was
158  /// inlined.
159  ///
160  /// This will search back through the ExplodedGraph, starting from the given
161  /// node, looking for when the given statement was processed. If it turns out
162  /// the statement is a call that was inlined, we add the visitor to the
163  /// bug report, so it can print a note later.
164  static void addVisitorIfNecessary(const ExplodedNode *Node, const Stmt *S,
165                                    BugReport &BR) {
166    if (!CallEvent::isCallStmt(S))
167      return;
168
169    // First, find when we processed the statement.
170    do {
171      if (Optional<CallExitEnd> CEE = Node->getLocationAs<CallExitEnd>())
172        if (CEE->getCalleeContext()->getCallSite() == S)
173          break;
174      if (Optional<StmtPoint> SP = Node->getLocationAs<StmtPoint>())
175        if (SP->getStmt() == S)
176          break;
177
178      Node = Node->getFirstPred();
179    } while (Node);
180
181    // Next, step over any post-statement checks.
182    while (Node && Node->getLocation().getAs<PostStmt>())
183      Node = Node->getFirstPred();
184    if (!Node)
185      return;
186
187    // Finally, see if we inlined the call.
188    Optional<CallExitEnd> CEE = Node->getLocationAs<CallExitEnd>();
189    if (!CEE)
190      return;
191
192    const StackFrameContext *CalleeContext = CEE->getCalleeContext();
193    if (CalleeContext->getCallSite() != S)
194      return;
195
196    // Check the return value.
197    ProgramStateRef State = Node->getState();
198    SVal RetVal = State->getSVal(S, Node->getLocationContext());
199
200    // Handle cases where a reference is returned and then immediately used.
201    if (cast<Expr>(S)->isGLValue())
202      if (Optional<Loc> LValue = RetVal.getAs<Loc>())
203        RetVal = State->getSVal(*LValue);
204
205    // See if the return value is NULL. If so, suppress the report.
206    SubEngine *Eng = State->getStateManager().getOwningEngine();
207    assert(Eng && "Cannot file a bug report without an owning engine");
208    AnalyzerOptions &Options = Eng->getAnalysisManager().options;
209
210    bool InitiallySuppressed = false;
211    if (Options.shouldSuppressNullReturnPaths())
212      if (Optional<Loc> RetLoc = RetVal.getAs<Loc>())
213        InitiallySuppressed = !State->assume(*RetLoc, true);
214
215    BR.markInteresting(CalleeContext);
216    BR.addVisitor(new ReturnVisitor(CalleeContext, InitiallySuppressed));
217  }
218
219  /// Returns true if any counter-suppression heuristics are enabled for
220  /// ReturnVisitor.
221  static bool hasCounterSuppression(AnalyzerOptions &Options) {
222    return Options.shouldAvoidSuppressingNullArgumentPaths();
223  }
224
225  PathDiagnosticPiece *visitNodeInitial(const ExplodedNode *N,
226                                        const ExplodedNode *PrevN,
227                                        BugReporterContext &BRC,
228                                        BugReport &BR) {
229    // Only print a message at the interesting return statement.
230    if (N->getLocationContext() != StackFrame)
231      return 0;
232
233    Optional<StmtPoint> SP = N->getLocationAs<StmtPoint>();
234    if (!SP)
235      return 0;
236
237    const ReturnStmt *Ret = dyn_cast<ReturnStmt>(SP->getStmt());
238    if (!Ret)
239      return 0;
240
241    // Okay, we're at the right return statement, but do we have the return
242    // value available?
243    ProgramStateRef State = N->getState();
244    SVal V = State->getSVal(Ret, StackFrame);
245    if (V.isUnknownOrUndef())
246      return 0;
247
248    // Don't print any more notes after this one.
249    Mode = Satisfied;
250
251    const Expr *RetE = Ret->getRetValue();
252    assert(RetE && "Tracking a return value for a void function");
253
254    // Handle cases where a reference is returned and then immediately used.
255    Optional<Loc> LValue;
256    if (RetE->isGLValue()) {
257      if ((LValue = V.getAs<Loc>())) {
258        SVal RValue = State->getRawSVal(*LValue, RetE->getType());
259        if (RValue.getAs<DefinedSVal>())
260          V = RValue;
261      }
262    }
263
264    // Ignore aggregate rvalues.
265    if (V.getAs<nonloc::LazyCompoundVal>() ||
266        V.getAs<nonloc::CompoundVal>())
267      return 0;
268
269    RetE = RetE->IgnoreParenCasts();
270
271    // If we can't prove the return value is 0, just mark it interesting, and
272    // make sure to track it into any further inner functions.
273    if (State->assume(V.castAs<DefinedSVal>(), true)) {
274      BR.markInteresting(V);
275      ReturnVisitor::addVisitorIfNecessary(N, RetE, BR);
276      return 0;
277    }
278
279    // If we're returning 0, we should track where that 0 came from.
280    bugreporter::trackNullOrUndefValue(N, RetE, BR);
281
282    // Build an appropriate message based on the return value.
283    SmallString<64> Msg;
284    llvm::raw_svector_ostream Out(Msg);
285
286    if (V.getAs<Loc>()) {
287      // If we have counter-suppression enabled, make sure we keep visiting
288      // future nodes. We want to emit a path note as well, in case
289      // the report is resurrected as valid later on.
290      ExprEngine &Eng = BRC.getBugReporter().getEngine();
291      AnalyzerOptions &Options = Eng.getAnalysisManager().options;
292      if (InitiallySuppressed && hasCounterSuppression(Options))
293        Mode = MaybeUnsuppress;
294
295      if (RetE->getType()->isObjCObjectPointerType())
296        Out << "Returning nil";
297      else
298        Out << "Returning null pointer";
299    } else {
300      Out << "Returning zero";
301    }
302
303    if (LValue) {
304      if (const MemRegion *MR = LValue->getAsRegion()) {
305        if (MR->canPrintPretty()) {
306          Out << " (reference to '";
307          MR->printPretty(Out);
308          Out << "')";
309        }
310      }
311    } else {
312      // FIXME: We should have a more generalized location printing mechanism.
313      if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(RetE))
314        if (const DeclaratorDecl *DD = dyn_cast<DeclaratorDecl>(DR->getDecl()))
315          Out << " (loaded from '" << *DD << "')";
316    }
317
318    PathDiagnosticLocation L(Ret, BRC.getSourceManager(), StackFrame);
319    return new PathDiagnosticEventPiece(L, Out.str());
320  }
321
322  PathDiagnosticPiece *visitNodeMaybeUnsuppress(const ExplodedNode *N,
323                                                const ExplodedNode *PrevN,
324                                                BugReporterContext &BRC,
325                                                BugReport &BR) {
326#ifndef NDEBUG
327    ExprEngine &Eng = BRC.getBugReporter().getEngine();
328    AnalyzerOptions &Options = Eng.getAnalysisManager().options;
329    assert(hasCounterSuppression(Options));
330#endif
331
332    // Are we at the entry node for this call?
333    Optional<CallEnter> CE = N->getLocationAs<CallEnter>();
334    if (!CE)
335      return 0;
336
337    if (CE->getCalleeContext() != StackFrame)
338      return 0;
339
340    Mode = Satisfied;
341
342    // Don't automatically suppress a report if one of the arguments is
343    // known to be a null pointer. Instead, start tracking /that/ null
344    // value back to its origin.
345    ProgramStateManager &StateMgr = BRC.getStateManager();
346    CallEventManager &CallMgr = StateMgr.getCallEventManager();
347
348    ProgramStateRef State = N->getState();
349    CallEventRef<> Call = CallMgr.getCaller(StackFrame, State);
350    for (unsigned I = 0, E = Call->getNumArgs(); I != E; ++I) {
351      Optional<Loc> ArgV = Call->getArgSVal(I).getAs<Loc>();
352      if (!ArgV)
353        continue;
354
355      const Expr *ArgE = Call->getArgExpr(I);
356      if (!ArgE)
357        continue;
358
359      // Is it possible for this argument to be non-null?
360      if (State->assume(*ArgV, true))
361        continue;
362
363      if (bugreporter::trackNullOrUndefValue(N, ArgE, BR, /*IsArg=*/true))
364        BR.removeInvalidation(ReturnVisitor::getTag(), StackFrame);
365
366      // If we /can't/ track the null pointer, we should err on the side of
367      // false negatives, and continue towards marking this report invalid.
368      // (We will still look at the other arguments, though.)
369    }
370
371    return 0;
372  }
373
374  PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
375                                 const ExplodedNode *PrevN,
376                                 BugReporterContext &BRC,
377                                 BugReport &BR) {
378    switch (Mode) {
379    case Initial:
380      return visitNodeInitial(N, PrevN, BRC, BR);
381    case MaybeUnsuppress:
382      return visitNodeMaybeUnsuppress(N, PrevN, BRC, BR);
383    case Satisfied:
384      return 0;
385    }
386
387    llvm_unreachable("Invalid visit mode!");
388  }
389
390  PathDiagnosticPiece *getEndPath(BugReporterContext &BRC,
391                                  const ExplodedNode *N,
392                                  BugReport &BR) {
393    if (InitiallySuppressed)
394      BR.markInvalid(ReturnVisitor::getTag(), StackFrame);
395    return 0;
396  }
397};
398} // end anonymous namespace
399
400
401void FindLastStoreBRVisitor ::Profile(llvm::FoldingSetNodeID &ID) const {
402  static int tag = 0;
403  ID.AddPointer(&tag);
404  ID.AddPointer(R);
405  ID.Add(V);
406}
407
408PathDiagnosticPiece *FindLastStoreBRVisitor::VisitNode(const ExplodedNode *Succ,
409                                                       const ExplodedNode *Pred,
410                                                       BugReporterContext &BRC,
411                                                       BugReport &BR) {
412
413  if (Satisfied)
414    return NULL;
415
416  const ExplodedNode *StoreSite = 0;
417  const Expr *InitE = 0;
418  bool IsParam = false;
419
420  // First see if we reached the declaration of the region.
421  if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
422    if (Optional<PostStmt> P = Pred->getLocationAs<PostStmt>()) {
423      if (const DeclStmt *DS = P->getStmtAs<DeclStmt>()) {
424        if (DS->getSingleDecl() == VR->getDecl()) {
425          StoreSite = Pred;
426          InitE = VR->getDecl()->getInit();
427        }
428      }
429    }
430  }
431
432  // Otherwise, see if this is the store site:
433  // (1) Succ has this binding and Pred does not, i.e. this is
434  //     where the binding first occurred.
435  // (2) Succ has this binding and is a PostStore node for this region, i.e.
436  //     the same binding was re-assigned here.
437  if (!StoreSite) {
438    if (Succ->getState()->getSVal(R) != V)
439      return NULL;
440
441    if (Pred->getState()->getSVal(R) == V) {
442      Optional<PostStore> PS = Succ->getLocationAs<PostStore>();
443      if (!PS || PS->getLocationValue() != R)
444        return NULL;
445    }
446
447    StoreSite = Succ;
448
449    // If this is an assignment expression, we can track the value
450    // being assigned.
451    if (Optional<PostStmt> P = Succ->getLocationAs<PostStmt>())
452      if (const BinaryOperator *BO = P->getStmtAs<BinaryOperator>())
453        if (BO->isAssignmentOp())
454          InitE = BO->getRHS();
455
456    // If this is a call entry, the variable should be a parameter.
457    // FIXME: Handle CXXThisRegion as well. (This is not a priority because
458    // 'this' should never be NULL, but this visitor isn't just for NULL and
459    // UndefinedVal.)
460    if (Optional<CallEnter> CE = Succ->getLocationAs<CallEnter>()) {
461      if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
462        const ParmVarDecl *Param = cast<ParmVarDecl>(VR->getDecl());
463
464        ProgramStateManager &StateMgr = BRC.getStateManager();
465        CallEventManager &CallMgr = StateMgr.getCallEventManager();
466
467        CallEventRef<> Call = CallMgr.getCaller(CE->getCalleeContext(),
468                                                Succ->getState());
469        InitE = Call->getArgExpr(Param->getFunctionScopeIndex());
470        IsParam = true;
471      }
472    }
473
474    // If this is a CXXTempObjectRegion, the Expr responsible for its creation
475    // is wrapped inside of it.
476    if (const CXXTempObjectRegion *TmpR = dyn_cast<CXXTempObjectRegion>(R))
477      InitE = TmpR->getExpr();
478  }
479
480  if (!StoreSite)
481    return NULL;
482  Satisfied = true;
483
484  // If we have an expression that provided the value, try to track where it
485  // came from.
486  if (InitE) {
487    if (V.isUndef() || V.getAs<loc::ConcreteInt>()) {
488      if (!IsParam)
489        InitE = InitE->IgnoreParenCasts();
490      bugreporter::trackNullOrUndefValue(StoreSite, InitE, BR, IsParam);
491    } else {
492      ReturnVisitor::addVisitorIfNecessary(StoreSite, InitE->IgnoreParenCasts(),
493                                           BR);
494    }
495  }
496
497  if (!R->canPrintPretty())
498    return 0;
499
500  // Okay, we've found the binding. Emit an appropriate message.
501  SmallString<256> sbuf;
502  llvm::raw_svector_ostream os(sbuf);
503
504  if (Optional<PostStmt> PS = StoreSite->getLocationAs<PostStmt>()) {
505    const Stmt *S = PS->getStmt();
506    const char *action = 0;
507    const DeclStmt *DS = dyn_cast<DeclStmt>(S);
508    const VarRegion *VR = dyn_cast<VarRegion>(R);
509
510    if (DS) {
511      action = "initialized to ";
512    } else if (isa<BlockExpr>(S)) {
513      action = "captured by block as ";
514      if (VR) {
515        // See if we can get the BlockVarRegion.
516        ProgramStateRef State = StoreSite->getState();
517        SVal V = State->getSVal(S, PS->getLocationContext());
518        if (const BlockDataRegion *BDR =
519              dyn_cast_or_null<BlockDataRegion>(V.getAsRegion())) {
520          if (const VarRegion *OriginalR = BDR->getOriginalRegion(VR)) {
521            if (Optional<KnownSVal> KV =
522                State->getSVal(OriginalR).getAs<KnownSVal>())
523              BR.addVisitor(new FindLastStoreBRVisitor(*KV, OriginalR));
524          }
525        }
526      }
527    }
528
529    if (action) {
530      if (!R)
531        return 0;
532
533      os << '\'';
534      R->printPretty(os);
535      os << "' ";
536
537      if (V.getAs<loc::ConcreteInt>()) {
538        bool b = false;
539        if (R->isBoundable()) {
540          if (const TypedValueRegion *TR = dyn_cast<TypedValueRegion>(R)) {
541            if (TR->getValueType()->isObjCObjectPointerType()) {
542              os << action << "nil";
543              b = true;
544            }
545          }
546        }
547
548        if (!b)
549          os << action << "a null pointer value";
550      } else if (Optional<nonloc::ConcreteInt> CVal =
551                     V.getAs<nonloc::ConcreteInt>()) {
552        os << action << CVal->getValue();
553      }
554      else if (DS) {
555        if (V.isUndef()) {
556          if (isa<VarRegion>(R)) {
557            const VarDecl *VD = cast<VarDecl>(DS->getSingleDecl());
558            if (VD->getInit())
559              os << "initialized to a garbage value";
560            else
561              os << "declared without an initial value";
562          }
563        }
564        else {
565          os << "initialized here";
566        }
567      }
568    }
569  } else if (StoreSite->getLocation().getAs<CallEnter>()) {
570    if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
571      const ParmVarDecl *Param = cast<ParmVarDecl>(VR->getDecl());
572
573      os << "Passing ";
574
575      if (V.getAs<loc::ConcreteInt>()) {
576        if (Param->getType()->isObjCObjectPointerType())
577          os << "nil object reference";
578        else
579          os << "null pointer value";
580      } else if (V.isUndef()) {
581        os << "uninitialized value";
582      } else if (Optional<nonloc::ConcreteInt> CI =
583                     V.getAs<nonloc::ConcreteInt>()) {
584        os << "the value " << CI->getValue();
585      } else {
586        os << "value";
587      }
588
589      // Printed parameter indexes are 1-based, not 0-based.
590      unsigned Idx = Param->getFunctionScopeIndex() + 1;
591      os << " via " << Idx << llvm::getOrdinalSuffix(Idx) << " parameter '";
592
593      R->printPretty(os);
594      os << '\'';
595    }
596  }
597
598  if (os.str().empty()) {
599    if (V.getAs<loc::ConcreteInt>()) {
600      bool b = false;
601      if (R->isBoundable()) {
602        if (const TypedValueRegion *TR = dyn_cast<TypedValueRegion>(R)) {
603          if (TR->getValueType()->isObjCObjectPointerType()) {
604            os << "nil object reference stored to ";
605            b = true;
606          }
607        }
608      }
609
610      if (!b)
611        os << "Null pointer value stored to ";
612    }
613    else if (V.isUndef()) {
614      os << "Uninitialized value stored to ";
615    } else if (Optional<nonloc::ConcreteInt> CV =
616                   V.getAs<nonloc::ConcreteInt>()) {
617      os << "The value " << CV->getValue() << " is assigned to ";
618    }
619    else
620      os << "Value assigned to ";
621
622    os << '\'';
623    R->printPretty(os);
624    os << '\'';
625  }
626
627  // Construct a new PathDiagnosticPiece.
628  ProgramPoint P = StoreSite->getLocation();
629  PathDiagnosticLocation L;
630  if (P.getAs<CallEnter>() && InitE)
631    L = PathDiagnosticLocation(InitE, BRC.getSourceManager(),
632                               P.getLocationContext());
633  else
634    L = PathDiagnosticLocation::create(P, BRC.getSourceManager());
635  if (!L.isValid())
636    return NULL;
637  return new PathDiagnosticEventPiece(L, os.str());
638}
639
640void TrackConstraintBRVisitor::Profile(llvm::FoldingSetNodeID &ID) const {
641  static int tag = 0;
642  ID.AddPointer(&tag);
643  ID.AddBoolean(Assumption);
644  ID.Add(Constraint);
645}
646
647/// Return the tag associated with this visitor.  This tag will be used
648/// to make all PathDiagnosticPieces created by this visitor.
649const char *TrackConstraintBRVisitor::getTag() {
650  return "TrackConstraintBRVisitor";
651}
652
653PathDiagnosticPiece *
654TrackConstraintBRVisitor::VisitNode(const ExplodedNode *N,
655                                    const ExplodedNode *PrevN,
656                                    BugReporterContext &BRC,
657                                    BugReport &BR) {
658  if (isSatisfied)
659    return NULL;
660
661  // Check if in the previous state it was feasible for this constraint
662  // to *not* be true.
663  if (PrevN->getState()->assume(Constraint, !Assumption)) {
664
665    isSatisfied = true;
666
667    // As a sanity check, make sure that the negation of the constraint
668    // was infeasible in the current state.  If it is feasible, we somehow
669    // missed the transition point.
670    if (N->getState()->assume(Constraint, !Assumption))
671      return NULL;
672
673    // We found the transition point for the constraint.  We now need to
674    // pretty-print the constraint. (work-in-progress)
675    std::string sbuf;
676    llvm::raw_string_ostream os(sbuf);
677
678    if (Constraint.getAs<Loc>()) {
679      os << "Assuming pointer value is ";
680      os << (Assumption ? "non-null" : "null");
681    }
682
683    if (os.str().empty())
684      return NULL;
685
686    // Construct a new PathDiagnosticPiece.
687    ProgramPoint P = N->getLocation();
688    PathDiagnosticLocation L =
689      PathDiagnosticLocation::create(P, BRC.getSourceManager());
690    if (!L.isValid())
691      return NULL;
692
693    PathDiagnosticEventPiece *X = new PathDiagnosticEventPiece(L, os.str());
694    X->setTag(getTag());
695    return X;
696  }
697
698  return NULL;
699}
700
701SuppressInlineDefensiveChecksVisitor::
702SuppressInlineDefensiveChecksVisitor(DefinedSVal Value, const ExplodedNode *N)
703  : V(Value), IsSatisfied(false), IsTrackingTurnedOn(false) {
704    assert(N->getState()->isNull(V).isConstrainedTrue() &&
705           "The visitor only tracks the cases where V is constrained to 0");
706}
707
708void SuppressInlineDefensiveChecksVisitor::Profile(FoldingSetNodeID &ID) const {
709  static int id = 0;
710  ID.AddPointer(&id);
711  ID.Add(V);
712}
713
714const char *SuppressInlineDefensiveChecksVisitor::getTag() {
715  return "IDCVisitor";
716}
717
718PathDiagnosticPiece *
719SuppressInlineDefensiveChecksVisitor::VisitNode(const ExplodedNode *Succ,
720                                                const ExplodedNode *Pred,
721                                                BugReporterContext &BRC,
722                                                BugReport &BR) {
723  if (IsSatisfied)
724    return 0;
725  AnalyzerOptions &Options =
726  BRC.getBugReporter().getEngine().getAnalysisManager().options;
727  if (!Options.shouldSuppressInlinedDefensiveChecks())
728    return 0;
729
730  // Start tracking after we see the first state in which the value is null.
731  if (!IsTrackingTurnedOn)
732    if (Succ->getState()->isNull(V).isConstrainedTrue())
733      IsTrackingTurnedOn = true;
734  if (!IsTrackingTurnedOn)
735    return 0;
736
737
738  // Check if in the previous state it was feasible for this value
739  // to *not* be null.
740  if (Pred->getState()->assume(V, true)) {
741    IsSatisfied = true;
742
743    assert(!Succ->getState()->assume(V, true));
744
745    // Check if this is inlined defensive checks.
746    const LocationContext *CurLC =Succ->getLocationContext();
747    const LocationContext *ReportLC = BR.getErrorNode()->getLocationContext();
748    if (CurLC != ReportLC && !CurLC->isParentOf(ReportLC))
749      BR.markInvalid("Suppress IDC", CurLC);
750  }
751  return 0;
752}
753
754static const MemRegion *getLocationRegionIfReference(const Expr *E,
755                                                     const ExplodedNode *N) {
756  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(E)) {
757    if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
758      if (!VD->getType()->isReferenceType())
759        return 0;
760      ProgramStateManager &StateMgr = N->getState()->getStateManager();
761      MemRegionManager &MRMgr = StateMgr.getRegionManager();
762      return MRMgr.getVarRegion(VD, N->getLocationContext());
763    }
764  }
765
766  // FIXME: This does not handle other kinds of null references,
767  // for example, references from FieldRegions:
768  //   struct Wrapper { int &ref; };
769  //   Wrapper w = { *(int *)0 };
770  //   w.ref = 1;
771
772  return 0;
773}
774
775bool bugreporter::trackNullOrUndefValue(const ExplodedNode *ErrorNode,
776                                        const Stmt *S,
777                                        BugReport &report, bool IsArg) {
778  if (!S || !ErrorNode)
779    return false;
780
781  if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(S))
782    S = OVE->getSourceExpr();
783
784  const ExplodedNode *N = ErrorNode;
785
786  const Expr *Inner = 0;
787  if (const Expr *Ex = dyn_cast<Expr>(S)) {
788    Ex = Ex->IgnoreParenCasts();
789    if (ExplodedGraph::isInterestingLValueExpr(Ex) || CallEvent::isCallStmt(Ex))
790      Inner = Ex;
791  }
792
793  if (IsArg) {
794    assert(N->getLocation().getAs<CallEnter>() && "Tracking arg but not at call");
795  } else {
796    // Walk through nodes until we get one that matches the statement exactly.
797    // Alternately, if we hit a known lvalue for the statement, we know we've
798    // gone too far (though we can likely track the lvalue better anyway).
799    do {
800      const ProgramPoint &pp = N->getLocation();
801      if (Optional<PostStmt> ps = pp.getAs<PostStmt>()) {
802        if (ps->getStmt() == S || ps->getStmt() == Inner)
803          break;
804      } else if (Optional<CallExitEnd> CEE = pp.getAs<CallExitEnd>()) {
805        if (CEE->getCalleeContext()->getCallSite() == S ||
806            CEE->getCalleeContext()->getCallSite() == Inner)
807          break;
808      }
809      N = N->getFirstPred();
810    } while (N);
811
812    if (!N)
813      return false;
814  }
815
816  ProgramStateRef state = N->getState();
817
818  // See if the expression we're interested refers to a variable.
819  // If so, we can track both its contents and constraints on its value.
820  if (Inner && ExplodedGraph::isInterestingLValueExpr(Inner)) {
821    const MemRegion *R = 0;
822
823    // Find the ExplodedNode where the lvalue (the value of 'Ex')
824    // was computed.  We need this for getting the location value.
825    const ExplodedNode *LVNode = N;
826    while (LVNode) {
827      if (Optional<PostStmt> P = LVNode->getLocation().getAs<PostStmt>()) {
828        if (P->getStmt() == Inner)
829          break;
830      }
831      LVNode = LVNode->getFirstPred();
832    }
833    assert(LVNode && "Unable to find the lvalue node.");
834    ProgramStateRef LVState = LVNode->getState();
835    SVal LVal = LVState->getSVal(Inner, LVNode->getLocationContext());
836
837    if (LVState->isNull(LVal).isConstrainedTrue()) {
838      // In case of C++ references, we want to differentiate between a null
839      // reference and reference to null pointer.
840      // If the LVal is null, check if we are dealing with null reference.
841      // For those, we want to track the location of the reference.
842      if (const MemRegion *RR = getLocationRegionIfReference(Inner, N))
843        R = RR;
844    } else {
845      R = LVState->getSVal(Inner, LVNode->getLocationContext()).getAsRegion();
846
847      // If this is a C++ reference to a null pointer, we are tracking the
848      // pointer. In additon, we should find the store at which the reference
849      // got initialized.
850      if (const MemRegion *RR = getLocationRegionIfReference(Inner, N)) {
851        if (Optional<KnownSVal> KV = LVal.getAs<KnownSVal>())
852          report.addVisitor(new FindLastStoreBRVisitor(*KV, RR));
853      }
854    }
855
856    if (R) {
857      // Mark both the variable region and its contents as interesting.
858      SVal V = state->getRawSVal(loc::MemRegionVal(R));
859
860      // If the value matches the default for the variable region, that
861      // might mean that it's been cleared out of the state. Fall back to
862      // the full argument expression (with casts and such intact).
863      if (IsArg) {
864        bool UseArgValue = V.isUnknownOrUndef() || V.isZeroConstant();
865        if (!UseArgValue) {
866          const SymbolRegionValue *SRV =
867            dyn_cast_or_null<SymbolRegionValue>(V.getAsLocSymbol());
868          if (SRV)
869            UseArgValue = (SRV->getRegion() == R);
870        }
871        if (UseArgValue)
872          V = state->getSValAsScalarOrLoc(S, N->getLocationContext());
873      }
874
875      report.markInteresting(R);
876      report.markInteresting(V);
877      report.addVisitor(new UndefOrNullArgVisitor(R));
878
879      if (isa<SymbolicRegion>(R)) {
880        TrackConstraintBRVisitor *VI =
881          new TrackConstraintBRVisitor(loc::MemRegionVal(R), false);
882        report.addVisitor(VI);
883      }
884
885      // If the contents are symbolic, find out when they became null.
886      if (V.getAsLocSymbol()) {
887        BugReporterVisitor *ConstraintTracker =
888          new TrackConstraintBRVisitor(V.castAs<DefinedSVal>(), false);
889        report.addVisitor(ConstraintTracker);
890
891        // Add visitor, which will suppress inline defensive checks.
892        if (N->getState()->isNull(V).isConstrainedTrue()) {
893          BugReporterVisitor *IDCSuppressor =
894            new SuppressInlineDefensiveChecksVisitor(V.castAs<DefinedSVal>(),
895                                                     N);
896          report.addVisitor(IDCSuppressor);
897        }
898      }
899
900      if (Optional<KnownSVal> KV = V.getAs<KnownSVal>())
901        report.addVisitor(new FindLastStoreBRVisitor(*KV, R));
902      return true;
903    }
904  }
905
906  // If the expression is not an "lvalue expression", we can still
907  // track the constraints on its contents.
908  SVal V = state->getSValAsScalarOrLoc(S, N->getLocationContext());
909
910  // If the value came from an inlined function call, we should at least make
911  // sure that function isn't pruned in our output.
912  if (const Expr *E = dyn_cast<Expr>(S))
913    S = E->IgnoreParenCasts();
914  ReturnVisitor::addVisitorIfNecessary(N, S, report);
915
916  // Uncomment this to find cases where we aren't properly getting the
917  // base value that was dereferenced.
918  // assert(!V.isUnknownOrUndef());
919  // Is it a symbolic value?
920  if (Optional<loc::MemRegionVal> L = V.getAs<loc::MemRegionVal>()) {
921    // At this point we are dealing with the region's LValue.
922    // However, if the rvalue is a symbolic region, we should track it as well.
923    SVal RVal = state->getSVal(L->getRegion());
924    const MemRegion *RegionRVal = RVal.getAsRegion();
925    report.addVisitor(new UndefOrNullArgVisitor(L->getRegion()));
926
927    if (RegionRVal && isa<SymbolicRegion>(RegionRVal)) {
928      report.markInteresting(RegionRVal);
929      report.addVisitor(new TrackConstraintBRVisitor(
930        loc::MemRegionVal(RegionRVal), false));
931    }
932  }
933
934  return true;
935}
936
937BugReporterVisitor *
938FindLastStoreBRVisitor::createVisitorObject(const ExplodedNode *N,
939                                            const MemRegion *R) {
940  assert(R && "The memory region is null.");
941
942  ProgramStateRef state = N->getState();
943  if (Optional<KnownSVal> KV = state->getSVal(R).getAs<KnownSVal>())
944    return new FindLastStoreBRVisitor(*KV, R);
945  return 0;
946}
947
948PathDiagnosticPiece *NilReceiverBRVisitor::VisitNode(const ExplodedNode *N,
949                                                     const ExplodedNode *PrevN,
950                                                     BugReporterContext &BRC,
951                                                     BugReport &BR) {
952  Optional<PostStmt> P = N->getLocationAs<PostStmt>();
953  if (!P)
954    return 0;
955  const ObjCMessageExpr *ME = P->getStmtAs<ObjCMessageExpr>();
956  if (!ME)
957    return 0;
958  const Expr *Receiver = ME->getInstanceReceiver();
959  if (!Receiver)
960    return 0;
961  ProgramStateRef state = N->getState();
962  const SVal &V = state->getSVal(Receiver, N->getLocationContext());
963  Optional<DefinedOrUnknownSVal> DV = V.getAs<DefinedOrUnknownSVal>();
964  if (!DV)
965    return 0;
966  state = state->assume(*DV, true);
967  if (state)
968    return 0;
969
970  // The receiver was nil, and hence the method was skipped.
971  // Register a BugReporterVisitor to issue a message telling us how
972  // the receiver was null.
973  bugreporter::trackNullOrUndefValue(N, Receiver, BR);
974  // Issue a message saying that the method was skipped.
975  PathDiagnosticLocation L(Receiver, BRC.getSourceManager(),
976                                     N->getLocationContext());
977  return new PathDiagnosticEventPiece(L, "No method is called "
978      "because the receiver is nil");
979}
980
981// Registers every VarDecl inside a Stmt with a last store visitor.
982void FindLastStoreBRVisitor::registerStatementVarDecls(BugReport &BR,
983                                                       const Stmt *S) {
984  const ExplodedNode *N = BR.getErrorNode();
985  std::deque<const Stmt *> WorkList;
986  WorkList.push_back(S);
987
988  while (!WorkList.empty()) {
989    const Stmt *Head = WorkList.front();
990    WorkList.pop_front();
991
992    ProgramStateRef state = N->getState();
993    ProgramStateManager &StateMgr = state->getStateManager();
994
995    if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Head)) {
996      if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
997        const VarRegion *R =
998        StateMgr.getRegionManager().getVarRegion(VD, N->getLocationContext());
999
1000        // What did we load?
1001        SVal V = state->getSVal(S, N->getLocationContext());
1002
1003        if (V.getAs<loc::ConcreteInt>() || V.getAs<nonloc::ConcreteInt>()) {
1004          // Register a new visitor with the BugReport.
1005          BR.addVisitor(new FindLastStoreBRVisitor(V.castAs<KnownSVal>(), R));
1006        }
1007      }
1008    }
1009
1010    for (Stmt::const_child_iterator I = Head->child_begin();
1011        I != Head->child_end(); ++I)
1012      WorkList.push_back(*I);
1013  }
1014}
1015
1016//===----------------------------------------------------------------------===//
1017// Visitor that tries to report interesting diagnostics from conditions.
1018//===----------------------------------------------------------------------===//
1019
1020/// Return the tag associated with this visitor.  This tag will be used
1021/// to make all PathDiagnosticPieces created by this visitor.
1022const char *ConditionBRVisitor::getTag() {
1023  return "ConditionBRVisitor";
1024}
1025
1026PathDiagnosticPiece *ConditionBRVisitor::VisitNode(const ExplodedNode *N,
1027                                                   const ExplodedNode *Prev,
1028                                                   BugReporterContext &BRC,
1029                                                   BugReport &BR) {
1030  PathDiagnosticPiece *piece = VisitNodeImpl(N, Prev, BRC, BR);
1031  if (piece) {
1032    piece->setTag(getTag());
1033    if (PathDiagnosticEventPiece *ev=dyn_cast<PathDiagnosticEventPiece>(piece))
1034      ev->setPrunable(true, /* override */ false);
1035  }
1036  return piece;
1037}
1038
1039PathDiagnosticPiece *ConditionBRVisitor::VisitNodeImpl(const ExplodedNode *N,
1040                                                       const ExplodedNode *Prev,
1041                                                       BugReporterContext &BRC,
1042                                                       BugReport &BR) {
1043
1044  ProgramPoint progPoint = N->getLocation();
1045  ProgramStateRef CurrentState = N->getState();
1046  ProgramStateRef PrevState = Prev->getState();
1047
1048  // Compare the GDMs of the state, because that is where constraints
1049  // are managed.  Note that ensure that we only look at nodes that
1050  // were generated by the analyzer engine proper, not checkers.
1051  if (CurrentState->getGDM().getRoot() ==
1052      PrevState->getGDM().getRoot())
1053    return 0;
1054
1055  // If an assumption was made on a branch, it should be caught
1056  // here by looking at the state transition.
1057  if (Optional<BlockEdge> BE = progPoint.getAs<BlockEdge>()) {
1058    const CFGBlock *srcBlk = BE->getSrc();
1059    if (const Stmt *term = srcBlk->getTerminator())
1060      return VisitTerminator(term, N, srcBlk, BE->getDst(), BR, BRC);
1061    return 0;
1062  }
1063
1064  if (Optional<PostStmt> PS = progPoint.getAs<PostStmt>()) {
1065    // FIXME: Assuming that BugReporter is a GRBugReporter is a layering
1066    // violation.
1067    const std::pair<const ProgramPointTag *, const ProgramPointTag *> &tags =
1068      cast<GRBugReporter>(BRC.getBugReporter()).
1069        getEngine().geteagerlyAssumeBinOpBifurcationTags();
1070
1071    const ProgramPointTag *tag = PS->getTag();
1072    if (tag == tags.first)
1073      return VisitTrueTest(cast<Expr>(PS->getStmt()), true,
1074                           BRC, BR, N);
1075    if (tag == tags.second)
1076      return VisitTrueTest(cast<Expr>(PS->getStmt()), false,
1077                           BRC, BR, N);
1078
1079    return 0;
1080  }
1081
1082  return 0;
1083}
1084
1085PathDiagnosticPiece *
1086ConditionBRVisitor::VisitTerminator(const Stmt *Term,
1087                                    const ExplodedNode *N,
1088                                    const CFGBlock *srcBlk,
1089                                    const CFGBlock *dstBlk,
1090                                    BugReport &R,
1091                                    BugReporterContext &BRC) {
1092  const Expr *Cond = 0;
1093
1094  switch (Term->getStmtClass()) {
1095  default:
1096    return 0;
1097  case Stmt::IfStmtClass:
1098    Cond = cast<IfStmt>(Term)->getCond();
1099    break;
1100  case Stmt::ConditionalOperatorClass:
1101    Cond = cast<ConditionalOperator>(Term)->getCond();
1102    break;
1103  }
1104
1105  assert(Cond);
1106  assert(srcBlk->succ_size() == 2);
1107  const bool tookTrue = *(srcBlk->succ_begin()) == dstBlk;
1108  return VisitTrueTest(Cond, tookTrue, BRC, R, N);
1109}
1110
1111PathDiagnosticPiece *
1112ConditionBRVisitor::VisitTrueTest(const Expr *Cond,
1113                                  bool tookTrue,
1114                                  BugReporterContext &BRC,
1115                                  BugReport &R,
1116                                  const ExplodedNode *N) {
1117
1118  const Expr *Ex = Cond;
1119
1120  while (true) {
1121    Ex = Ex->IgnoreParenCasts();
1122    switch (Ex->getStmtClass()) {
1123      default:
1124        return 0;
1125      case Stmt::BinaryOperatorClass:
1126        return VisitTrueTest(Cond, cast<BinaryOperator>(Ex), tookTrue, BRC,
1127                             R, N);
1128      case Stmt::DeclRefExprClass:
1129        return VisitTrueTest(Cond, cast<DeclRefExpr>(Ex), tookTrue, BRC,
1130                             R, N);
1131      case Stmt::UnaryOperatorClass: {
1132        const UnaryOperator *UO = cast<UnaryOperator>(Ex);
1133        if (UO->getOpcode() == UO_LNot) {
1134          tookTrue = !tookTrue;
1135          Ex = UO->getSubExpr();
1136          continue;
1137        }
1138        return 0;
1139      }
1140    }
1141  }
1142}
1143
1144bool ConditionBRVisitor::patternMatch(const Expr *Ex, raw_ostream &Out,
1145                                      BugReporterContext &BRC,
1146                                      BugReport &report,
1147                                      const ExplodedNode *N,
1148                                      Optional<bool> &prunable) {
1149  const Expr *OriginalExpr = Ex;
1150  Ex = Ex->IgnoreParenCasts();
1151
1152  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Ex)) {
1153    const bool quotes = isa<VarDecl>(DR->getDecl());
1154    if (quotes) {
1155      Out << '\'';
1156      const LocationContext *LCtx = N->getLocationContext();
1157      const ProgramState *state = N->getState().getPtr();
1158      if (const MemRegion *R = state->getLValue(cast<VarDecl>(DR->getDecl()),
1159                                                LCtx).getAsRegion()) {
1160        if (report.isInteresting(R))
1161          prunable = false;
1162        else {
1163          const ProgramState *state = N->getState().getPtr();
1164          SVal V = state->getSVal(R);
1165          if (report.isInteresting(V))
1166            prunable = false;
1167        }
1168      }
1169    }
1170    Out << DR->getDecl()->getDeclName().getAsString();
1171    if (quotes)
1172      Out << '\'';
1173    return quotes;
1174  }
1175
1176  if (const IntegerLiteral *IL = dyn_cast<IntegerLiteral>(Ex)) {
1177    QualType OriginalTy = OriginalExpr->getType();
1178    if (OriginalTy->isPointerType()) {
1179      if (IL->getValue() == 0) {
1180        Out << "null";
1181        return false;
1182      }
1183    }
1184    else if (OriginalTy->isObjCObjectPointerType()) {
1185      if (IL->getValue() == 0) {
1186        Out << "nil";
1187        return false;
1188      }
1189    }
1190
1191    Out << IL->getValue();
1192    return false;
1193  }
1194
1195  return false;
1196}
1197
1198PathDiagnosticPiece *
1199ConditionBRVisitor::VisitTrueTest(const Expr *Cond,
1200                                  const BinaryOperator *BExpr,
1201                                  const bool tookTrue,
1202                                  BugReporterContext &BRC,
1203                                  BugReport &R,
1204                                  const ExplodedNode *N) {
1205
1206  bool shouldInvert = false;
1207  Optional<bool> shouldPrune;
1208
1209  SmallString<128> LhsString, RhsString;
1210  {
1211    llvm::raw_svector_ostream OutLHS(LhsString), OutRHS(RhsString);
1212    const bool isVarLHS = patternMatch(BExpr->getLHS(), OutLHS, BRC, R, N,
1213                                       shouldPrune);
1214    const bool isVarRHS = patternMatch(BExpr->getRHS(), OutRHS, BRC, R, N,
1215                                       shouldPrune);
1216
1217    shouldInvert = !isVarLHS && isVarRHS;
1218  }
1219
1220  BinaryOperator::Opcode Op = BExpr->getOpcode();
1221
1222  if (BinaryOperator::isAssignmentOp(Op)) {
1223    // For assignment operators, all that we care about is that the LHS
1224    // evaluates to "true" or "false".
1225    return VisitConditionVariable(LhsString, BExpr->getLHS(), tookTrue,
1226                                  BRC, R, N);
1227  }
1228
1229  // For non-assignment operations, we require that we can understand
1230  // both the LHS and RHS.
1231  if (LhsString.empty() || RhsString.empty())
1232    return 0;
1233
1234  // Should we invert the strings if the LHS is not a variable name?
1235  SmallString<256> buf;
1236  llvm::raw_svector_ostream Out(buf);
1237  Out << "Assuming " << (shouldInvert ? RhsString : LhsString) << " is ";
1238
1239  // Do we need to invert the opcode?
1240  if (shouldInvert)
1241    switch (Op) {
1242      default: break;
1243      case BO_LT: Op = BO_GT; break;
1244      case BO_GT: Op = BO_LT; break;
1245      case BO_LE: Op = BO_GE; break;
1246      case BO_GE: Op = BO_LE; break;
1247    }
1248
1249  if (!tookTrue)
1250    switch (Op) {
1251      case BO_EQ: Op = BO_NE; break;
1252      case BO_NE: Op = BO_EQ; break;
1253      case BO_LT: Op = BO_GE; break;
1254      case BO_GT: Op = BO_LE; break;
1255      case BO_LE: Op = BO_GT; break;
1256      case BO_GE: Op = BO_LT; break;
1257      default:
1258        return 0;
1259    }
1260
1261  switch (Op) {
1262    case BO_EQ:
1263      Out << "equal to ";
1264      break;
1265    case BO_NE:
1266      Out << "not equal to ";
1267      break;
1268    default:
1269      Out << BinaryOperator::getOpcodeStr(Op) << ' ';
1270      break;
1271  }
1272
1273  Out << (shouldInvert ? LhsString : RhsString);
1274  const LocationContext *LCtx = N->getLocationContext();
1275  PathDiagnosticLocation Loc(Cond, BRC.getSourceManager(), LCtx);
1276  PathDiagnosticEventPiece *event =
1277    new PathDiagnosticEventPiece(Loc, Out.str());
1278  if (shouldPrune.hasValue())
1279    event->setPrunable(shouldPrune.getValue());
1280  return event;
1281}
1282
1283PathDiagnosticPiece *
1284ConditionBRVisitor::VisitConditionVariable(StringRef LhsString,
1285                                           const Expr *CondVarExpr,
1286                                           const bool tookTrue,
1287                                           BugReporterContext &BRC,
1288                                           BugReport &report,
1289                                           const ExplodedNode *N) {
1290  // FIXME: If there's already a constraint tracker for this variable,
1291  // we shouldn't emit anything here (c.f. the double note in
1292  // test/Analysis/inlining/path-notes.c)
1293  SmallString<256> buf;
1294  llvm::raw_svector_ostream Out(buf);
1295  Out << "Assuming " << LhsString << " is ";
1296
1297  QualType Ty = CondVarExpr->getType();
1298
1299  if (Ty->isPointerType())
1300    Out << (tookTrue ? "not null" : "null");
1301  else if (Ty->isObjCObjectPointerType())
1302    Out << (tookTrue ? "not nil" : "nil");
1303  else if (Ty->isBooleanType())
1304    Out << (tookTrue ? "true" : "false");
1305  else if (Ty->isIntegerType())
1306    Out << (tookTrue ? "non-zero" : "zero");
1307  else
1308    return 0;
1309
1310  const LocationContext *LCtx = N->getLocationContext();
1311  PathDiagnosticLocation Loc(CondVarExpr, BRC.getSourceManager(), LCtx);
1312  PathDiagnosticEventPiece *event =
1313    new PathDiagnosticEventPiece(Loc, Out.str());
1314
1315  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(CondVarExpr)) {
1316    if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1317      const ProgramState *state = N->getState().getPtr();
1318      if (const MemRegion *R = state->getLValue(VD, LCtx).getAsRegion()) {
1319        if (report.isInteresting(R))
1320          event->setPrunable(false);
1321      }
1322    }
1323  }
1324
1325  return event;
1326}
1327
1328PathDiagnosticPiece *
1329ConditionBRVisitor::VisitTrueTest(const Expr *Cond,
1330                                  const DeclRefExpr *DR,
1331                                  const bool tookTrue,
1332                                  BugReporterContext &BRC,
1333                                  BugReport &report,
1334                                  const ExplodedNode *N) {
1335
1336  const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl());
1337  if (!VD)
1338    return 0;
1339
1340  SmallString<256> Buf;
1341  llvm::raw_svector_ostream Out(Buf);
1342
1343  Out << "Assuming '";
1344  VD->getDeclName().printName(Out);
1345  Out << "' is ";
1346
1347  QualType VDTy = VD->getType();
1348
1349  if (VDTy->isPointerType())
1350    Out << (tookTrue ? "non-null" : "null");
1351  else if (VDTy->isObjCObjectPointerType())
1352    Out << (tookTrue ? "non-nil" : "nil");
1353  else if (VDTy->isScalarType())
1354    Out << (tookTrue ? "not equal to 0" : "0");
1355  else
1356    return 0;
1357
1358  const LocationContext *LCtx = N->getLocationContext();
1359  PathDiagnosticLocation Loc(Cond, BRC.getSourceManager(), LCtx);
1360  PathDiagnosticEventPiece *event =
1361    new PathDiagnosticEventPiece(Loc, Out.str());
1362
1363  const ProgramState *state = N->getState().getPtr();
1364  if (const MemRegion *R = state->getLValue(VD, LCtx).getAsRegion()) {
1365    if (report.isInteresting(R))
1366      event->setPrunable(false);
1367    else {
1368      SVal V = state->getSVal(R);
1369      if (report.isInteresting(V))
1370        event->setPrunable(false);
1371    }
1372  }
1373  return event;
1374}
1375
1376PathDiagnosticPiece *
1377LikelyFalsePositiveSuppressionBRVisitor::getEndPath(BugReporterContext &BRC,
1378                                                    const ExplodedNode *N,
1379                                                    BugReport &BR) {
1380  const Stmt *S = BR.getStmt();
1381  if (!S)
1382    return 0;
1383
1384  // Here we suppress false positives coming from system macros. This list is
1385  // based on known issues.
1386
1387  // Skip reports within the sys/queue.h macros as we do not have the ability to
1388  // reason about data structure shapes.
1389  SourceManager &SM = BRC.getSourceManager();
1390  SourceLocation Loc = S->getLocStart();
1391  while (Loc.isMacroID()) {
1392    if (SM.isInSystemMacro(Loc) &&
1393       (SM.getFilename(SM.getSpellingLoc(Loc)).endswith("sys/queue.h"))) {
1394      BR.markInvalid(getTag(), 0);
1395      return 0;
1396    }
1397    Loc = SM.getSpellingLoc(Loc);
1398  }
1399
1400  return 0;
1401}
1402
1403PathDiagnosticPiece *
1404UndefOrNullArgVisitor::VisitNode(const ExplodedNode *N,
1405                                  const ExplodedNode *PrevN,
1406                                  BugReporterContext &BRC,
1407                                  BugReport &BR) {
1408
1409  ProgramStateRef State = N->getState();
1410  ProgramPoint ProgLoc = N->getLocation();
1411
1412  // We are only interested in visiting CallEnter nodes.
1413  Optional<CallEnter> CEnter = ProgLoc.getAs<CallEnter>();
1414  if (!CEnter)
1415    return 0;
1416
1417  // Check if one of the arguments is the region the visitor is tracking.
1418  CallEventManager &CEMgr = BRC.getStateManager().getCallEventManager();
1419  CallEventRef<> Call = CEMgr.getCaller(CEnter->getCalleeContext(), State);
1420  unsigned Idx = 0;
1421  for (CallEvent::param_iterator I = Call->param_begin(),
1422                                 E = Call->param_end(); I != E; ++I, ++Idx) {
1423    const MemRegion *ArgReg = Call->getArgSVal(Idx).getAsRegion();
1424
1425    // Are we tracking the argument or its subregion?
1426    if ( !ArgReg || (ArgReg != R && !R->isSubRegionOf(ArgReg->StripCasts())))
1427      continue;
1428
1429    // Check the function parameter type.
1430    const ParmVarDecl *ParamDecl = *I;
1431    assert(ParamDecl && "Formal parameter has no decl?");
1432    QualType T = ParamDecl->getType();
1433
1434    if (!(T->isAnyPointerType() || T->isReferenceType())) {
1435      // Function can only change the value passed in by address.
1436      continue;
1437    }
1438
1439    // If it is a const pointer value, the function does not intend to
1440    // change the value.
1441    if (T->getPointeeType().isConstQualified())
1442      continue;
1443
1444    // Mark the call site (LocationContext) as interesting if the value of the
1445    // argument is undefined or '0'/'NULL'.
1446    SVal BoundVal = State->getSVal(R);
1447    if (BoundVal.isUndef() || BoundVal.isZeroConstant()) {
1448      BR.markInteresting(CEnter->getCalleeContext());
1449      return 0;
1450    }
1451  }
1452  return 0;
1453}
1454