SkMatrixConvolutionImageFilter.cpp revision 528952b5afea0e82bf6db9ef22128533d50ef9e3
1/* 2 * Copyright 2012 The Android Open Source Project 3 * 4 * Use of this source code is governed by a BSD-style license that can be 5 * found in the LICENSE file. 6 */ 7 8#include "SkMatrixConvolutionImageFilter.h" 9#include "SkBitmap.h" 10#include "SkColorPriv.h" 11#include "SkFlattenableBuffers.h" 12#include "SkRect.h" 13#include "SkUnPreMultiply.h" 14 15#if SK_SUPPORT_GPU 16#include "gl/GrGLEffect.h" 17#include "gl/GrGLEffectMatrix.h" 18#include "effects/GrSingleTextureEffect.h" 19#include "GrTBackendEffectFactory.h" 20#include "GrTexture.h" 21#include "SkMatrix.h" 22 23#endif 24 25SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(const SkISize& kernelSize, const SkScalar* kernel, SkScalar gain, SkScalar bias, const SkIPoint& target, TileMode tileMode, bool convolveAlpha, SkImageFilter* input) 26 : INHERITED(input), 27 fKernelSize(kernelSize), 28 fGain(gain), 29 fBias(bias), 30 fTarget(target), 31 fTileMode(tileMode), 32 fConvolveAlpha(convolveAlpha) { 33 uint32_t size = fKernelSize.fWidth * fKernelSize.fHeight; 34 fKernel = SkNEW_ARRAY(SkScalar, size); 35 memcpy(fKernel, kernel, size * sizeof(SkScalar)); 36 SkASSERT(kernelSize.fWidth >= 1 && kernelSize.fHeight >= 1); 37 SkASSERT(target.fX >= 0 && target.fX < kernelSize.fWidth); 38 SkASSERT(target.fY >= 0 && target.fY < kernelSize.fHeight); 39} 40 41SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) { 42 fKernelSize.fWidth = buffer.readInt(); 43 fKernelSize.fHeight = buffer.readInt(); 44 uint32_t size = fKernelSize.fWidth * fKernelSize.fHeight; 45 fKernel = SkNEW_ARRAY(SkScalar, size); 46 uint32_t readSize = buffer.readScalarArray(fKernel); 47 SkASSERT(readSize == size); 48 fGain = buffer.readScalar(); 49 fBias = buffer.readScalar(); 50 fTarget.fX = buffer.readInt(); 51 fTarget.fY = buffer.readInt(); 52 fTileMode = (TileMode) buffer.readInt(); 53 fConvolveAlpha = buffer.readBool(); 54} 55 56void SkMatrixConvolutionImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const { 57 this->INHERITED::flatten(buffer); 58 buffer.writeInt(fKernelSize.fWidth); 59 buffer.writeInt(fKernelSize.fHeight); 60 buffer.writeScalarArray(fKernel, fKernelSize.fWidth * fKernelSize.fHeight); 61 buffer.writeScalar(fGain); 62 buffer.writeScalar(fBias); 63 buffer.writeInt(fTarget.fX); 64 buffer.writeInt(fTarget.fY); 65 buffer.writeInt((int) fTileMode); 66 buffer.writeBool(fConvolveAlpha); 67} 68 69SkMatrixConvolutionImageFilter::~SkMatrixConvolutionImageFilter() { 70 delete[] fKernel; 71} 72 73class UncheckedPixelFetcher { 74public: 75 static inline SkPMColor fetch(const SkBitmap& src, int x, int y) { 76 return *src.getAddr32(x, y); 77 } 78}; 79 80class ClampPixelFetcher { 81public: 82 static inline SkPMColor fetch(const SkBitmap& src, int x, int y) { 83 x = SkClampMax(x, src.width() - 1); 84 y = SkClampMax(y, src.height() - 1); 85 return *src.getAddr32(x, y); 86 } 87}; 88 89class RepeatPixelFetcher { 90public: 91 static inline SkPMColor fetch(const SkBitmap& src, int x, int y) { 92 x %= src.width(); 93 y %= src.height(); 94 if (x < 0) { 95 x += src.width(); 96 } 97 if (y < 0) { 98 y += src.height(); 99 } 100 return *src.getAddr32(x, y); 101 } 102}; 103 104class ClampToBlackPixelFetcher { 105public: 106 static inline SkPMColor fetch(const SkBitmap& src, int x, int y) { 107 if (x < 0 || x >= src.width() || y < 0 || y >= src.height()) { 108 return 0; 109 } else { 110 return *src.getAddr32(x, y); 111 } 112 } 113}; 114 115template<class PixelFetcher, bool convolveAlpha> 116void SkMatrixConvolutionImageFilter::filterPixels(const SkBitmap& src, SkBitmap* result, const SkIRect& rect) { 117 for (int y = rect.fTop; y < rect.fBottom; ++y) { 118 SkPMColor* dptr = result->getAddr32(rect.fLeft, y); 119 for (int x = rect.fLeft; x < rect.fRight; ++x) { 120 SkScalar sumA = 0, sumR = 0, sumG = 0, sumB = 0; 121 for (int cy = 0; cy < fKernelSize.fHeight; cy++) { 122 for (int cx = 0; cx < fKernelSize.fWidth; cx++) { 123 SkPMColor s = PixelFetcher::fetch(src, x + cx - fTarget.fX, y + cy - fTarget.fY); 124 SkScalar k = fKernel[cy * fKernelSize.fWidth + cx]; 125 if (convolveAlpha) { 126 sumA += SkScalarMul(SkIntToScalar(SkGetPackedA32(s)), k); 127 } 128 sumR += SkScalarMul(SkIntToScalar(SkGetPackedR32(s)), k); 129 sumG += SkScalarMul(SkIntToScalar(SkGetPackedG32(s)), k); 130 sumB += SkScalarMul(SkIntToScalar(SkGetPackedB32(s)), k); 131 } 132 } 133 int a = convolveAlpha 134 ? SkClampMax(SkScalarFloorToInt(SkScalarMul(sumA, fGain) + fBias), 255) 135 : 255; 136 int r = SkClampMax(SkScalarFloorToInt(SkScalarMul(sumR, fGain) + fBias), a); 137 int g = SkClampMax(SkScalarFloorToInt(SkScalarMul(sumG, fGain) + fBias), a); 138 int b = SkClampMax(SkScalarFloorToInt(SkScalarMul(sumB, fGain) + fBias), a); 139 if (!convolveAlpha) { 140 a = SkGetPackedA32(PixelFetcher::fetch(src, x, y)); 141 *dptr++ = SkPreMultiplyARGB(a, r, g, b); 142 } else { 143 *dptr++ = SkPackARGB32(a, r, g, b); 144 } 145 } 146 } 147} 148 149template<class PixelFetcher> 150void SkMatrixConvolutionImageFilter::filterPixels(const SkBitmap& src, SkBitmap* result, const SkIRect& rect) { 151 if (fConvolveAlpha) { 152 filterPixels<PixelFetcher, true>(src, result, rect); 153 } else { 154 filterPixels<PixelFetcher, false>(src, result, rect); 155 } 156} 157 158void SkMatrixConvolutionImageFilter::filterInteriorPixels(const SkBitmap& src, SkBitmap* result, const SkIRect& rect) { 159 filterPixels<UncheckedPixelFetcher>(src, result, rect); 160} 161 162void SkMatrixConvolutionImageFilter::filterBorderPixels(const SkBitmap& src, SkBitmap* result, const SkIRect& rect) { 163 switch (fTileMode) { 164 case kClamp_TileMode: 165 filterPixels<ClampPixelFetcher>(src, result, rect); 166 break; 167 case kRepeat_TileMode: 168 filterPixels<RepeatPixelFetcher>(src, result, rect); 169 break; 170 case kClampToBlack_TileMode: 171 filterPixels<ClampToBlackPixelFetcher>(src, result, rect); 172 break; 173 } 174} 175 176// FIXME: This should be refactored to SkSingleInputImageFilter for 177// use by other filters. For now, we assume the input is always 178// premultiplied and unpremultiply it 179static SkBitmap unpremultiplyBitmap(const SkBitmap& src) 180{ 181 SkAutoLockPixels alp(src); 182 if (!src.getPixels()) { 183 return SkBitmap(); 184 } 185 SkBitmap result; 186 result.setConfig(src.config(), src.width(), src.height()); 187 result.allocPixels(); 188 if (!result.getPixels()) { 189 return SkBitmap(); 190 } 191 for (int y = 0; y < src.height(); ++y) { 192 const uint32_t* srcRow = src.getAddr32(0, y); 193 uint32_t* dstRow = result.getAddr32(0, y); 194 for (int x = 0; x < src.width(); ++x) { 195 dstRow[x] = SkUnPreMultiply::PMColorToColor(srcRow[x]); 196 } 197 } 198 return result; 199} 200 201bool SkMatrixConvolutionImageFilter::onFilterImage(Proxy* proxy, 202 const SkBitmap& source, 203 const SkMatrix& matrix, 204 SkBitmap* result, 205 SkIPoint* loc) { 206 SkBitmap src = this->getInputResult(proxy, source, matrix, loc); 207 if (src.config() != SkBitmap::kARGB_8888_Config) { 208 return false; 209 } 210 211 if (!fConvolveAlpha && !src.isOpaque()) { 212 src = unpremultiplyBitmap(src); 213 } 214 215 SkAutoLockPixels alp(src); 216 if (!src.getPixels()) { 217 return false; 218 } 219 220 result->setConfig(src.config(), src.width(), src.height()); 221 result->allocPixels(); 222 223 SkIRect interior = SkIRect::MakeXYWH(fTarget.fX, fTarget.fY, 224 src.width() - fKernelSize.fWidth + 1, 225 src.height() - fKernelSize.fHeight + 1); 226 SkIRect top = SkIRect::MakeWH(src.width(), fTarget.fY); 227 SkIRect bottom = SkIRect::MakeLTRB(0, interior.bottom(), 228 src.width(), src.height()); 229 SkIRect left = SkIRect::MakeXYWH(0, interior.top(), 230 fTarget.fX, interior.height()); 231 SkIRect right = SkIRect::MakeLTRB(interior.right(), interior.top(), 232 src.width(), interior.bottom()); 233 filterBorderPixels(src, result, top); 234 filterBorderPixels(src, result, left); 235 filterInteriorPixels(src, result, interior); 236 filterBorderPixels(src, result, right); 237 filterBorderPixels(src, result, bottom); 238 return true; 239} 240 241#if SK_SUPPORT_GPU 242 243/////////////////////////////////////////////////////////////////////////////// 244 245class GrGLMatrixConvolutionEffect; 246 247class GrMatrixConvolutionEffect : public GrSingleTextureEffect { 248public: 249 typedef SkMatrixConvolutionImageFilter::TileMode TileMode; 250 GrMatrixConvolutionEffect(GrTexture*, 251 const SkISize& kernelSize, 252 const SkScalar* kernel, 253 SkScalar gain, 254 SkScalar bias, 255 const SkIPoint& target, 256 TileMode tileMode, 257 bool convolveAlpha); 258 virtual ~GrMatrixConvolutionEffect(); 259 260 static const char* Name() { return "MatrixConvolution"; } 261 const SkISize& kernelSize() const { return fKernelSize; } 262 const float* target() const { return fTarget; } 263 const float* kernel() const { return fKernel; } 264 float gain() const { return fGain; } 265 float bias() const { return fBias; } 266 TileMode tileMode() const { return fTileMode; } 267 bool convolveAlpha() const { return fConvolveAlpha; } 268 269 typedef GrGLMatrixConvolutionEffect GLEffect; 270 271 virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE; 272 virtual bool isEqual(const GrEffect&) const SK_OVERRIDE; 273 274private: 275 SkISize fKernelSize; 276 float *fKernel; 277 float fGain; 278 float fBias; 279 float fTarget[2]; 280 TileMode fTileMode; 281 bool fConvolveAlpha; 282 283 GR_DECLARE_EFFECT_TEST; 284 285 typedef GrSingleTextureEffect INHERITED; 286}; 287 288class GrGLMatrixConvolutionEffect : public GrGLEffect { 289public: 290 GrGLMatrixConvolutionEffect(const GrBackendEffectFactory& factory, 291 const GrEffect& effect); 292 virtual void emitCode(GrGLShaderBuilder*, 293 const GrEffectStage&, 294 EffectKey, 295 const char* vertexCoords, 296 const char* outputColor, 297 const char* inputColor, 298 const TextureSamplerArray&) SK_OVERRIDE; 299 300 static inline EffectKey GenKey(const GrEffectStage&, const GrGLCaps&); 301 302 virtual void setData(const GrGLUniformManager&, const GrEffectStage&) SK_OVERRIDE; 303 304private: 305 typedef GrGLUniformManager::UniformHandle UniformHandle; 306 typedef SkMatrixConvolutionImageFilter::TileMode TileMode; 307 SkISize fKernelSize; 308 TileMode fTileMode; 309 bool fConvolveAlpha; 310 311 UniformHandle fKernelUni; 312 UniformHandle fImageIncrementUni; 313 UniformHandle fTargetUni; 314 UniformHandle fGainUni; 315 UniformHandle fBiasUni; 316 317 GrGLEffectMatrix fEffectMatrix; 318 319 typedef GrGLEffect INHERITED; 320}; 321 322GrGLMatrixConvolutionEffect::GrGLMatrixConvolutionEffect(const GrBackendEffectFactory& factory, 323 const GrEffect& effect) 324 : INHERITED(factory) 325 , fKernelUni(GrGLUniformManager::kInvalidUniformHandle) 326 , fImageIncrementUni(GrGLUniformManager::kInvalidUniformHandle) 327 , fTargetUni(GrGLUniformManager::kInvalidUniformHandle) 328 , fGainUni(GrGLUniformManager::kInvalidUniformHandle) 329 , fBiasUni(GrGLUniformManager::kInvalidUniformHandle) { 330 const GrMatrixConvolutionEffect& m = static_cast<const GrMatrixConvolutionEffect&>(effect); 331 fKernelSize = m.kernelSize(); 332 fTileMode = m.tileMode(); 333 fConvolveAlpha = m.convolveAlpha(); 334} 335 336static void appendTextureLookup(GrGLShaderBuilder* builder, 337 const GrGLShaderBuilder::TextureSampler& sampler, 338 const char* coord, 339 SkMatrixConvolutionImageFilter::TileMode tileMode) { 340 SkString* code = &builder->fFSCode; 341 SkString clampedCoord; 342 switch (tileMode) { 343 case SkMatrixConvolutionImageFilter::kClamp_TileMode: 344 clampedCoord.printf("clamp(%s, 0.0, 1.0)", coord); 345 coord = clampedCoord.c_str(); 346 break; 347 case SkMatrixConvolutionImageFilter::kRepeat_TileMode: 348 clampedCoord.printf("fract(%s)", coord); 349 coord = clampedCoord.c_str(); 350 break; 351 case SkMatrixConvolutionImageFilter::kClampToBlack_TileMode: 352 code->appendf("clamp(%s, 0.0, 1.0) != %s ? vec4(0, 0, 0, 0) : ", coord, coord); 353 break; 354 } 355 builder->appendTextureLookup(code, sampler, coord); 356} 357 358void GrGLMatrixConvolutionEffect::emitCode(GrGLShaderBuilder* builder, 359 const GrEffectStage&, 360 EffectKey key, 361 const char* vertexCoords, 362 const char* outputColor, 363 const char* inputColor, 364 const TextureSamplerArray& samplers) { 365 const char* coords; 366 fEffectMatrix.emitCodeMakeFSCoords2D(builder, key, vertexCoords, &coords); 367 fImageIncrementUni = builder->addUniform(GrGLShaderBuilder::kFragment_ShaderType, 368 kVec2f_GrSLType, "ImageIncrement"); 369 fKernelUni = builder->addUniformArray(GrGLShaderBuilder::kFragment_ShaderType, 370 kFloat_GrSLType, "Kernel", fKernelSize.width() * fKernelSize.height()); 371 fTargetUni = builder->addUniform(GrGLShaderBuilder::kFragment_ShaderType, 372 kVec2f_GrSLType, "Target"); 373 fGainUni = builder->addUniform(GrGLShaderBuilder::kFragment_ShaderType, 374 kFloat_GrSLType, "Gain"); 375 fBiasUni = builder->addUniform(GrGLShaderBuilder::kFragment_ShaderType, 376 kFloat_GrSLType, "Bias"); 377 378 SkString* code = &builder->fFSCode; 379 380 const char* target = builder->getUniformCStr(fTargetUni); 381 const char* imgInc = builder->getUniformCStr(fImageIncrementUni); 382 const char* kernel = builder->getUniformCStr(fKernelUni); 383 const char* gain = builder->getUniformCStr(fGainUni); 384 const char* bias = builder->getUniformCStr(fBiasUni); 385 int kWidth = fKernelSize.width(); 386 int kHeight = fKernelSize.height(); 387 388 code->appendf("\t\tvec4 sum = vec4(0, 0, 0, 0);\n"); 389 code->appendf("\t\tvec2 coord = %s - %s * %s;\n", coords, target, imgInc); 390 code->appendf("\t\tfor (int y = 0; y < %d; y++) {\n", kHeight); 391 code->appendf("\t\t\tfor (int x = 0; x < %d; x++) {\n", kWidth); 392 code->appendf("\t\t\t\tfloat k = %s[y * %d + x];\n", kernel, kWidth); 393 code->appendf("\t\t\t\tvec2 coord2 = coord + vec2(x, y) * %s;\n", imgInc); 394 code->appendf("\t\t\t\tvec4 c = "); 395 appendTextureLookup(builder, samplers[0], "coord2", fTileMode); 396 code->appendf(";\n"); 397 if (!fConvolveAlpha) { 398 code->appendf("\t\t\t\tc.rgb /= c.a;\n"); 399 } 400 code->appendf("\t\t\t\tsum += c * k;\n"); 401 code->appendf("\t\t\t}\n"); 402 code->appendf("\t\t}\n"); 403 if (fConvolveAlpha) { 404 code->appendf("\t\t%s = sum * %s + %s;\n", outputColor, gain, bias); 405 code->appendf("\t\t%s.rgb = clamp(%s.rgb, 0.0, %s.a);\n", outputColor, outputColor, outputColor); 406 } else { 407 code->appendf("\t\tvec4 c = "); 408 appendTextureLookup(builder, samplers[0], coords, fTileMode); 409 code->appendf(";\n"); 410 code->appendf("\t\t%s.a = c.a;\n", outputColor); 411 code->appendf("\t\t%s.rgb = sum.rgb * %s + %s;\n", outputColor, gain, bias); 412 code->appendf("\t\t%s.rgb *= %s.a;\n", outputColor, outputColor); 413 } 414} 415 416namespace { 417 418int encodeXY(int x, int y) { 419 SkASSERT(x >= 1 && y >= 1 && x * y <= 32); 420 if (y < x) 421 return 0x40 | encodeXY(y, x); 422 else 423 return (0x40 >> x) | (y - x); 424} 425 426}; 427 428GrGLEffect::EffectKey GrGLMatrixConvolutionEffect::GenKey(const GrEffectStage& s, const GrGLCaps&) { 429 const GrMatrixConvolutionEffect& m = 430 static_cast<const GrMatrixConvolutionEffect&>(*s.getEffect()); 431 EffectKey key = encodeXY(m.kernelSize().width(), m.kernelSize().height()); 432 key |= m.tileMode() << 7; 433 key |= m.convolveAlpha() ? 1 << 9 : 0; 434 key <<= GrGLEffectMatrix::kKeyBits; 435 EffectKey matrixKey = GrGLEffectMatrix::GenKey(m.getMatrix(), 436 s.getCoordChangeMatrix(), 437 m.texture(0)); 438 return key | matrixKey; 439} 440 441void GrGLMatrixConvolutionEffect::setData(const GrGLUniformManager& uman, 442 const GrEffectStage& stage) { 443 const GrMatrixConvolutionEffect& effect = 444 static_cast<const GrMatrixConvolutionEffect&>(*stage.getEffect()); 445 GrTexture& texture = *effect.texture(0); 446 // the code we generated was for a specific kernel size 447 GrAssert(effect.kernelSize() == fKernelSize); 448 GrAssert(effect.tileMode() == fTileMode); 449 float imageIncrement[2]; 450 imageIncrement[0] = 1.0f / texture.width(); 451 imageIncrement[1] = 1.0f / texture.height(); 452 uman.set2fv(fImageIncrementUni, 0, 1, imageIncrement); 453 uman.set2fv(fTargetUni, 0, 1, effect.target()); 454 uman.set1fv(fKernelUni, 0, fKernelSize.width() * fKernelSize.height(), effect.kernel()); 455 uman.set1f(fGainUni, effect.gain()); 456 uman.set1f(fBiasUni, effect.bias()); 457 fEffectMatrix.setData(uman, 458 effect.getMatrix(), 459 stage.getCoordChangeMatrix(), 460 effect.texture(0)); 461} 462 463GrMatrixConvolutionEffect::GrMatrixConvolutionEffect(GrTexture* texture, 464 const SkISize& kernelSize, 465 const SkScalar* kernel, 466 SkScalar gain, 467 SkScalar bias, 468 const SkIPoint& target, 469 TileMode tileMode, 470 bool convolveAlpha) 471 : INHERITED(texture, MakeDivByTextureWHMatrix(texture)), 472 fKernelSize(kernelSize), 473 fGain(SkScalarToFloat(gain)), 474 fBias(SkScalarToFloat(bias) / 255.0f), 475 fTileMode(tileMode), 476 fConvolveAlpha(convolveAlpha) { 477 fKernel = new float[kernelSize.width() * kernelSize.height()]; 478 for (int i = 0; i < kernelSize.width() * kernelSize.height(); i++) { 479 fKernel[i] = SkScalarToFloat(kernel[i]); 480 } 481 fTarget[0] = static_cast<float>(target.x()); 482 fTarget[1] = static_cast<float>(target.y()); 483} 484 485GrMatrixConvolutionEffect::~GrMatrixConvolutionEffect() { 486 delete[] fKernel; 487} 488 489const GrBackendEffectFactory& GrMatrixConvolutionEffect::getFactory() const { 490 return GrTBackendEffectFactory<GrMatrixConvolutionEffect>::getInstance(); 491} 492 493bool GrMatrixConvolutionEffect::isEqual(const GrEffect& sBase) const { 494 const GrMatrixConvolutionEffect& s = 495 static_cast<const GrMatrixConvolutionEffect&>(sBase); 496 return INHERITED::isEqual(sBase) && 497 fKernelSize == s.kernelSize() && 498 !memcmp(fKernel, s.kernel(), fKernelSize.width() * fKernelSize.height() * sizeof(float)) && 499 fGain == s.gain() && 500 fBias == s.bias() && 501 fTarget == s.target() && 502 fTileMode == s.tileMode() && 503 fConvolveAlpha == s.convolveAlpha(); 504} 505 506GR_DEFINE_EFFECT_TEST(GrMatrixConvolutionEffect); 507 508// A little bit less than the minimum # uniforms required by DX9SM2 (32). 509// Allows for a 5x5 kernel (or 25x1, for that matter). 510#define MAX_KERNEL_SIZE 25 511 512GrEffect* GrMatrixConvolutionEffect::TestCreate(SkRandom* random, 513 GrContext* context, 514 GrTexture* textures[]) { 515 int texIdx = random->nextBool() ? GrEffectUnitTest::kSkiaPMTextureIdx : 516 GrEffectUnitTest::kAlphaTextureIdx; 517 int width = random->nextRangeU(1, MAX_KERNEL_SIZE); 518 int height = random->nextRangeU(1, MAX_KERNEL_SIZE / width); 519 SkISize kernelSize = SkISize::Make(width, height); 520 SkScalar* kernel = new SkScalar[width * height]; 521 for (int i = 0; i < width * height; i++) { 522 kernel[i] = random->nextSScalar1(); 523 } 524 SkScalar gain = random->nextSScalar1(); 525 SkScalar bias = random->nextSScalar1(); 526 SkIPoint target = SkIPoint::Make(random->nextRangeU(0, kernelSize.width()), 527 random->nextRangeU(0, kernelSize.height())); 528 TileMode tileMode = static_cast<TileMode>(random->nextRangeU(0, 2)); 529 bool convolveAlpha = random->nextBool(); 530 return SkNEW_ARGS(GrMatrixConvolutionEffect, (textures[texIdx], 531 kernelSize, 532 kernel, 533 gain, 534 bias, 535 target, 536 tileMode, 537 convolveAlpha)); 538 539} 540 541bool SkMatrixConvolutionImageFilter::asNewEffect(GrEffect** effect, 542 GrTexture* texture) const { 543 bool ok = fKernelSize.width() * fKernelSize.height() <= MAX_KERNEL_SIZE; 544 if (ok && effect) { 545 *effect = SkNEW_ARGS(GrMatrixConvolutionEffect, (texture, 546 fKernelSize, 547 fKernel, 548 fGain, 549 fBias, 550 fTarget, 551 fTileMode, 552 fConvolveAlpha)); 553 } 554 return ok; 555} 556 557/////////////////////////////////////////////////////////////////////////////// 558 559#endif 560