• Home
  • History
  • Annotate
  • only in /frameworks/av/media/libstagefright/codecs/aacenc/src/
History log of /frameworks/av/media/libstagefright/codecs/aacenc/src/
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
84333e0475bc911adc16417f4ca327c975cf6c36 08-Feb-2014 Andreas Huber <andih@google.com> warnings be gone.

Change-Id: Ie3bae3f037730e316d7fca12e7a3527973f752ef
acenc.c
dj_thr.c
itenc.c
yn_bits.c
sy_main.c
c_main.c
ns.c
9538ab83ed3917e643fc88f63ed83736d5a22d19 09-Sep-2012 Martin Storsjo <martin@martin.st> aacenc: Mark some global arrays const

This gets rid of initialized writeable data in the library.

Change-Id: I7c1cbeb3df10c302b645b7311591ead87a289ca1
ac_rom.c
lock_switch.c
b5325c8a8fff4d735c24d9a8138e4213ee0833d5 23-May-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Move system headers before local headers

This avoids issues with the encoder's own definition of __inline,
which conflicts with headers brought in by string.h in glibc.

Change-Id: I9e3fbf8d892529940ea67a46e67a9abe71d9c5fa
dj_thr.c
93eb01fd39e31b7532932f60828abf11a494fb8f 12-Jan-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Add parentheses in expression with mixed && and ||

This doesn't maintain the exact behaviour, but seems closer to
what the original author probably intended.

This avoids a warning.

Change-Id: I191292faa0a25f715f2b7d46ec770827e2ac0b7b
acenc.c
ca17672e75faf59492527a5b168cc01db8badabb 10-Mar-2012 Conley Owens <cco3@android.com> am 3557654c: am 66da3fdc: am 972efafb: am 6db6ea02: Merge changes I00c852e4,Ib31bf028

* commit '3557654c95bae7754dcd1951ec10742b895817e2':
stagefright aacenc: Avoid overflows when calculating normFactor
stagefright aacenc: Avoid a division by zero
1f7e2d9906d25b4e709c247d78537ee826d31051 09-Mar-2012 Conley Owens <cco3@android.com> Merge changes I00c852e4,Ib31bf028

* changes:
stagefright aacenc: Avoid overflows when calculating normFactor
stagefright aacenc: Avoid a division by zero
6c1f1cb5bd2b22f8b21b78ea020a0b6370f5b9ff 02-Mar-2012 Jean-Baptiste Queru <jbq@google.com> am 715c78b9: am 225eec8d: am f9d4ba77: am 69aae36e: Merge "stagefright aacenc: Safeguard against overwriting bits"

* commit '715c78b933f8dec04882ebb73acd61fdd42c6c64':
stagefright aacenc: Safeguard against overwriting bits
de99ee3d507bf1284fdb5d6b84a32f4227f16a6f 29-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Safeguard against overwriting bits"
acb364073e62acddced517f2edfe0326245b2af9 27-Feb-2012 Jean-Baptiste Queru <jbq@google.com> am 19bb6261: am bf826923: am faf38b24: am 9e3d9575: Merge "stagefright aacenc: Add prototypes for arm specific implementations of functions"

* commit '19bb62613f512b62d492fb4caf36de88fd1914dd':
stagefright aacenc: Add prototypes for arm specific implementations of functions
14f94704418852fe83eabd3e0e13288951fee574 27-Feb-2012 Jean-Baptiste Queru <jbq@google.com> am 2bf76b98: am 3e61e413: am 32901b39: am be9a7055: Merge "stagefright aacenc: Remove a stray semicolon"

* commit '2bf76b983da1d1730d685f9907d5d4fa6ea46fcd':
stagefright aacenc: Remove a stray semicolon
c0502b930651092683a5f47c55159b559fae7727 27-Feb-2012 Jean-Baptiste Queru <jbq@google.com> am 5b299d2f: am 18643e70: am 6bc542e0: am 5aff259c: Merge "stagefright aacenc: Don\'t address a Word32 with a Word16 pointer"

* commit '5b299d2f9038452aa09a97d4f2ce57ec20bbc06a':
stagefright aacenc: Don't address a Word32 with a Word16 pointer
61d07fbe79533517dbd4390d90206badd8df4641 27-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Add prototypes for arm specific implementations of functions"
7d8e0f1ae48058ac1613272fd66e4d8335adbb93 27-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Remove a stray semicolon"
5b9c33c7239c996135c0021ec9a0d9afedd81a78 27-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Don't address a Word32 with a Word16 pointer"
1e07b508b4f9d5031e17cde7701ad656824816f1 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> am ed7e1e83: am 47023027: am 26d9944e: am 6a300a54: Merge "stagefright aacenc: Make the bits to write in WriteBits unsigned"

* commit 'ed7e1e830165678421ee7d1b3dac044214a6e635':
stagefright aacenc: Make the bits to write in WriteBits unsigned
338b9c9020ca6be98f30670cf307ad8553f1b4c9 12-Jan-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Remove a stray semicolon

This avoids warnings about an empty body in an if statement.

mem_free does the same null check, so the accidental extra
semicolon was harmless, and the whole if statement actually
is needless. But if removing the if statements, all the
other ones should be removed too, for consistency.
(This could be done as a separate change).

Change-Id: I1b6064dedd15ffa949043bb5396148aaed9b43f6
c_main.c
8a3b3707a6e320ba75f4ecd47fdc001f16c15cb8 12-Jan-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Add prototypes for arm specific implementations of functions

The arm specific functions are implemented in .s files,
without any function declarations in headers.

This fixes compiler warnings about implicit declarations
of these functions.

Change-Id: I1512560b6740c1879f378886e05aaad2e3a6c869
ransform.c
b86b3c8f976b70635770d93217132d4023ecf33f 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Make the bits to write in WriteBits unsigned"
a118abebce9aa2bdd8fa4a7251875c5049082434 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> am 15278119: am 61022b06: am 5f83b957: am bf45bbf3: Merge "stagefright aacenc: Zero-initialize a struct"

* commit '1527811984557ee0b5d6e476e84ed147e073cb45':
stagefright aacenc: Zero-initialize a struct
d38faa28eb767a108a7a9467c1a481957531d2af 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> am 4de803c7: am 459df4ef: am e7650c32: am e5bdd24b: Merge "stagefright aacenc: Avoid warnings about incompatible pointer types"

* commit '4de803c76d4afd0f542c086b555b71729b3c5796':
stagefright aacenc: Avoid warnings about incompatible pointer types
80d4b8903ed09d2cf9ac35391f04eb8619f47a1e 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Zero-initialize a struct"
b20a352b7e4eb6690e86e0dcf9d58d73640dc874 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> am 307f47aa: am 7e8b65df: am 7ffa4546: am 47b56c5a: Merge "stagefright aacenc: Add const declarations to some pointers"

* commit '307f47aa5def85d0c0bb4af725ff557707c5be86':
stagefright aacenc: Add const declarations to some pointers
ccdf9e6e3dc929a9ffee7ed2aab57115ef810527 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Avoid warnings about incompatible pointer types"
aa1639aeb42e7c403315319bf55632de93d3c8d9 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Add const declarations to some pointers"
dcdfc1ad27cb64bcb51a864b020b846ba22ce2a7 19-Feb-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Avoid overflows when calculating normFactor

normFactor is calculated using the saturating L_add function,
but if the value added (*psfbPeFactors) is negative, the sum
can end up negative.

*psfbPeFactors can end up negative if redThrExp is less than
*psfbNActiveLines.

In cases where *psfbPeFactors ended up negative, normFactor
became INT_MIN, causing division by zero later.

Change-Id: I00c852e457b22f7eef4d6ed1887629828057206b
dj_thr.c
01e29ede19cd7d85bfef38896de8e71e569cd211 19-Feb-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Avoid a division by zero

In rare cases, the result of normFactor * (*psfbNActiveLines)
could be zero, leading to a division by zero in pow2_xy.

In these cases, normFactor was INT_MIN, and if *psfbNActiveLines
was 2, the product was zero.

normFactor being INT_MIN is a bug in itself though.

Change-Id: Ib31bf02889615a7be3bd1bc028da8a7651a8dbee
dj_thr.c
3989d5c21ce6d1f3492c9e5484d610d5d66abd9e 20-Apr-2011 Martin Storsjo <martin@martin.st> stagefright aacenc: Safeguard against overwriting bits

Previously, if bits above the lowest noBitsToWrite were
set, they would be ORed into the previous cache word,
setting unrelated bits erroneously.

This doesn't noticeably affect the performance of the
codec as a whole.

Change-Id: Ie9935533c4299b8f07cb14485f039a9be9c84016
itbuffer.c
cf8b805a0c0695097211ca18237c27f45b0df85c 22-Dec-2010 Martin Storsjo <martin@martin.st> stagefright aacenc: Avoid warnings about incompatible pointer types

Change-Id: Ida53cd1030ebb9feb0d6916e42e8ba67a90e86c7
acenc_core.c
2857b47a2731579772c76d46285660972c0ba23d 25-Jan-2012 Ben Cheng <bccheng@google.com> Preserve NEON callee-save registers d8-d15.

BUG:5918479
Change-Id: I574bd5845d9e7e007c637aabbf170d03217d10ad
sm/ARMV7/PrePostMDCT_v7.s
sm/ARMV7/R4R8First_v7.s
sm/ARMV7/Radix4FFT_v7.s
a078e9b727156c76ef864ac2d8b3f6a99df9e604 24-Jan-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Add missing newlines at the end of files"
9fc4dfb69df0b5a13b7a1904272eb1dcf8113d0c 22-Dec-2010 Martin Storsjo <martin@martin.st> stagefright aacenc: Add const declarations to some pointers

This avoids some compilation warnings.

Change-Id: Ia89ab94020a9f1ee4c1df48823fb89325cca7d36
yn_bits.c
nterface.c
sy_configuration.c
sy_main.c
uantize.c
60866592ed6953f2b0e12cefcd58f1ced26546d0 12-Jan-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Properly terminate a comment

This avoids a warning about /* within a comment.

Change-Id: I9079909734d35db5ab0fd54b46173d7a1848d0c9
dj_thr.c
132e42c04a58e623efa6cd6ca43641cd80db0f05 05-Apr-2011 Martin Storsjo <martin@martin.st> stagefright aacenc: Zero-initialize a struct

This avoids using uninitialized data in some cases, according
to valgrind.

Change-Id: I2eb5242b93c4d83a1cf6a15f022ec9579e0742a4
dj_thr.c
2f0fb8c1ec139d385feb6990111ed6dc93422eac 22-Dec-2010 Martin Storsjo <martin@martin.st> stagefright aacenc: Don't address a Word32 with a Word16 pointer

Currently, a pointer to a Word32 is used as a pointer to Word16, which
doesn't work as intended on big endian architectures.

This change needs to be analyzed and tested properly so that it doesn't
cause issues with overflows in these variables. Another solution would be
to change all the scf arrays to 32 bit instead.

Change-Id: I53d9eb83bdaf8d3b1530eb5064dd10b08bce737a
f_estim.c
5e9afe434d8207fb0af6e191cca671ab74cfe878 20-Apr-2011 Martin Storsjo <martin@martin.st> stagefright aacenc: Make the bits to write in WriteBits unsigned

They shouldn't, as far as I know, ever be a signed value.

Change-Id: I64429c7c0b2b52bec768a04d3c3eb0eb252955fa
itbuffer.c
891abc0ee089f2ba5b92dcc014e5efc2ef07f01e 31-Aug-2011 Martin Storsjo <martin@martin.st> stagefright aacenc: Add missing newlines at the end of files

This avoids compiler warnings about missing newlines.

Change-Id: Ieb2bb7152d794dca47c629588879032d3ba65677
ac_rom.c
acenc.c
sm/ARMV5E/PrePostMDCT_v5.s
sm/ARMV5E/R4R8First_v5.s
sm/ARMV5E/Radix4FFT_v5.s
sm/ARMV7/PrePostMDCT_v7.s
sm/ARMV7/R4R8First_v7.s
sm/ARMV7/Radix4FFT_v7.s
and_nrg.c
b676a05348e4c516fa8b57e33b10548e6142c3f8 05-Apr-2011 Mans Rullgard <mans@mansr.com> stagefright aacenc/amrwbenc: Remove trailing whitespace

This was applied in AOSP master earlier, in commit
b21611e5b0f1797e39e781d91ade023bac87637f, but when merged
into the Google internal tree in
88c2d4d26d79384f32a25bd775cf873cb678b12a, none of these
changes have been brought in. (The diff of this merge commit
and its first parent, d94b71d, is empty.)

Therefore, reapply the rest of these changes on the files
that still are present in the current version.

Change-Id: I645a9b9134769958a11808a06163123d28d83e46
ac_rom.c
acenc.c
acenc_core.c
dj_thr.c
sm/ARMV5E/AutoCorrelation_v5.s
sm/ARMV5E/CalcWindowEnergy_v5.s
sm/ARMV5E/PrePostMDCT_v5.s
sm/ARMV5E/R4R8First_v5.s
sm/ARMV5E/Radix4FFT_v5.s
sm/ARMV5E/band_nrg_v5.s
sm/ARMV7/PrePostMDCT_v7.s
sm/ARMV7/R4R8First_v7.s
sm/ARMV7/Radix4FFT_v7.s
and_nrg.c
it_cnt.c
itbuffer.c
itenc.c
lock_switch.c
hannel_map.c
yn_bits.c
rp_data.c
nterface.c
ine_pe.c
emalign.c
s_stereo.c
re_echo_control.c
sy_configuration.c
sy_main.c
c_main.c
uantize.c
f_estim.c
tat_bits.c
ns.c
ransform.c
8ebe5be6b0b3caa7d9d6277a1216ed786bd1e66a 19-Jul-2011 Conley Owens <cco3@android.com> am e5143d6c: am a4aef41a: am a74774fd: am 4d8f6a38: Merge "stagefright aacenc: Mark codeWord as UWord16"

* commit 'e5143d6c09f0e9a960661a2b0a5916c33fcafc4d':
stagefright aacenc: Mark codeWord as UWord16
d94bb8b524e09f978b6a16699b968628ff279208 19-Jul-2011 Conley Owens <cco3@android.com> Merge "stagefright aacenc: Mark codeWord as UWord16"
7b9bcbb0975049c05c3b4a4048802807433ace42 19-Jul-2011 Deckard Autoverifier <deckard@android.com> am d4dee1a5: am 29fd8cdb: am 80ef1745: am c06c3603: Merge "stagefright aacenc: Make the mem_malloc function 64-bit safe"

* commit 'd4dee1a57fdcd1bd1e7c621163e89039cf88d9f9':
stagefright aacenc: Make the mem_malloc function 64-bit safe
e625479f58d7d9234c8ae7cb0c0a604bf43a9115 19-Jul-2011 Deckard Autoverifier <deckard@android.com> Merge "stagefright aacenc: Make the mem_malloc function 64-bit safe"
267dbd822ff060843ce409c0f1b50f6d5468ea31 22-Dec-2010 Martin Storsjo <martin@martin.st> stagefright aacenc: Make the mem_malloc function 64-bit safe

Change-Id: I720109133bf5e13388b26a3bdbd66ff1f5320b70
emalign.c
e2e838afcf03e603a41a0455846eaf9614537c16 22-Apr-2011 Mans Rullgard <mans@mansr.com> Convert line breaks to Unix style

Change-Id: I6219725a9fbd72432bad71a176c14f26fabdbd5f
ac_rom.c
acenc.c
acenc_core.c
dj_thr.c
sm/ARMV5E/AutoCorrelation_v5.s
sm/ARMV5E/CalcWindowEnergy_v5.s
sm/ARMV5E/PrePostMDCT_v5.s
sm/ARMV5E/R4R8First_v5.s
sm/ARMV5E/Radix4FFT_v5.s
sm/ARMV5E/band_nrg_v5.s
sm/ARMV7/PrePostMDCT_v7.s
sm/ARMV7/R4R8First_v7.s
sm/ARMV7/Radix4FFT_v7.s
and_nrg.c
it_cnt.c
itbuffer.c
itenc.c
lock_switch.c
hannel_map.c
yn_bits.c
rp_data.c
nterface.c
ine_pe.c
s_stereo.c
re_echo_control.c
sy_configuration.c
sy_main.c
c_main.c
uantize.c
f_estim.c
preading.c
tat_bits.c
ns.c
ransform.c
99bc0510f9152fa88508a1ba1d2d158961fcefe0 20-Apr-2011 Martin Storsjo <martin@martin.st> stagefright aacenc: Mark codeWord as UWord16

Without this, the codeword 0xffff will be expanded to
0xffffffff when passed as a Word32 parameter. All code words
set into this variable are UWord16 initially.

When it was expanded to 0xffffffff, it could accidentally
overwrite earlier cached bits in the bitstream writer.

Change-Id: Id91a2b8a4e934876d9cb39eaeeee323202ec8e40
it_cnt.c
f3664ae9369a861ffbc2354e8e93e48983802062 05-Apr-2011 Mans Rullgard <mans@mansr.com> stagefright aacenc/amrwbenc: Remove trailing whitespace

Change-Id: I3c85d8ba4cfb164455d137cdbf3b5ecc941dc6b8
ac_rom.c
acenc.c
acenc_core.c
dj_thr.c
sm/ARMV5E/AutoCorrelation_v5.s
sm/ARMV5E/CalcWindowEnergy_v5.s
sm/ARMV5E/PrePostMDCT_v5.s
sm/ARMV5E/R4R8First_v5.s
sm/ARMV5E/Radix4FFT_v5.s
sm/ARMV5E/band_nrg_v5.s
sm/ARMV7/PrePostMDCT_v7.s
sm/ARMV7/R4R8First_v7.s
sm/ARMV7/Radix4FFT_v7.s
and_nrg.c
it_cnt.c
itbuffer.c
itenc.c
lock_switch.c
hannel_map.c
yn_bits.c
rp_data.c
nterface.c
ine_pe.c
emalign.c
s_stereo.c
re_echo_control.c
sy_configuration.c
sy_main.c
c_main.c
uantize.c
f_estim.c
tat_bits.c
ns.c
ransform.c
41050cdb033641ddf26831d9272c0930f7b40a2d 22-Apr-2011 Mans Rullgard <mans@mansr.com> stagefright aacenc/amrwbenc: Convert line breaks to Unix style

Change-Id: I6219725a9fbd72432bad71a176c14f26fabdbd5f
ac_rom.c
acenc.c
acenc_core.c
dj_thr.c
sm/ARMV5E/AutoCorrelation_v5.s
sm/ARMV5E/CalcWindowEnergy_v5.s
sm/ARMV5E/PrePostMDCT_v5.s
sm/ARMV5E/R4R8First_v5.s
sm/ARMV5E/Radix4FFT_v5.s
sm/ARMV5E/band_nrg_v5.s
sm/ARMV7/PrePostMDCT_v7.s
sm/ARMV7/R4R8First_v7.s
sm/ARMV7/Radix4FFT_v7.s
and_nrg.c
it_cnt.c
itbuffer.c
itenc.c
lock_switch.c
hannel_map.c
yn_bits.c
rp_data.c
nterface.c
ine_pe.c
s_stereo.c
re_echo_control.c
sy_configuration.c
sy_main.c
c_main.c
uantize.c
f_estim.c
preading.c
tat_bits.c
ns.c
ransform.c
956c553ab0ce72f8074ad0fda2ffd66a0305700c 15-May-2010 James Dong <jdong@google.com> Initial software encoder checkins

Change-Id: I27f387db23594e46384c4eb3a0093ce220bb6b60
ac_rom.c
acenc.c
acenc_core.c
dj_thr.c
sm/ARMV5E/AutoCorrelation_v5.s
sm/ARMV5E/CalcWindowEnergy_v5.s
sm/ARMV5E/PrePostMDCT_v5.s
sm/ARMV5E/R4R8First_v5.s
sm/ARMV5E/Radix4FFT_v5.s
sm/ARMV5E/band_nrg_v5.s
sm/ARMV7/PrePostMDCT_v7.s
sm/ARMV7/R4R8First_v7.s
sm/ARMV7/Radix4FFT_v7.s
and_nrg.c
it_cnt.c
itbuffer.c
itenc.c
lock_switch.c
hannel_map.c
yn_bits.c
rp_data.c
nterface.c
ine_pe.c
emalign.c
s_stereo.c
re_echo_control.c
sy_configuration.c
sy_main.c
c_main.c
uantize.c
f_estim.c
preading.c
tat_bits.c
ns.c
ransform.c