History log of /frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
b74155cf01f959fc9b7909de5a22806ad519f7c9 21-Jan-2015 Alan Viverette <alanv@google.com> Avoid ripple buffer creation for empty bounds

Bug: 19068439
Change-Id: I031d4303bbf101a25612dce6f02d81ce4cf58e2b
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
b942b6f15c51c2ff48c59d8f620ee6156d00f67e 08-Dec-2014 Alan Viverette <alanv@google.com> Fix hotspot coordinate propagation in ViewGroup and AbsListView

There was a weird disconnect between setPressed() and hotspot propagation
behavior. This makes hotspot propagation work like setPressed(). Also
fixes ripple animation during drag-to-open.

BUG: 18631557
BUG: 18593243
Change-Id: Id4adf5d815e4d426b4182aac4d0c780f04472ae4
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
6dfa60f33ca6018959ebff1efde82db7d2aed1e3 04-Dec-2014 Alan Viverette <alanv@google.com> Avoid extra saveLayer calls in RippleDrawable, fix docs

Also fixes opacity returned from InsetDrawable to accurately reflect
the transparent inset area and updates button to correctly use tint.

BUG: 18226391
Change-Id: Ia9a88d9d663990a6829d2f251c7f59ea2a79d816
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
ebc9f2e773c3ebb4d4af3025fc6770844cc8fdef 04-Dec-2014 Alan Viverette <alanv@google.com> Update locally cached drawables when constant state changes

Previously we were failing to update references to drawables that had
been pulled from constant state, so we were drawing the wrong ones.

Also fixes button Z translation on press, which was WAY too high.

BUG: 18542282
Change-Id: Ifde7d64e31d31737854cfcbe75777e5b07a06e3a
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
cc3c573334a9cd2124a8a0ccf2f37884e36f83fa 08-Nov-2014 Alan Viverette <alanv@google.com> Reduce number of saveLayer calls in RippleDrawable

Removes an extra saveLayer call by rendering ripples as overlapping. We
are now down to zero saveLayers when drawing unmasked ripples or ripples
masked against opaque content/masks, one saveLayer for ripples masked
against content and two saveLayers when masked against an explicit mask
layer.

BUG: 18226391
Change-Id: I0fc09d21fbc462fbcfe4c26fc7b18737f584043e
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
d21fd9d1ccd2b525f9c004a6cd9ba19a645701ab 29-Oct-2014 Alan Viverette <alanv@google.com> Add theme and config change support to more Drawable types

BUG: 16045735
Change-Id: Ic03173a1c1779c1bb545c4c389f77afed97011ee
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
b70cfb9103b02e90409ba1f1bc334210f139774f 15-Oct-2014 Alan Viverette <alanv@google.com> Merge "Avoid saveLayer in RippleDrawable if the background won't draw" into lmp-mr1-dev
9a00cbcc66b5b0002ff78507a1dc1efa12e84d63 15-Oct-2014 Alan Viverette <alanv@google.com> Merge "Update preload list, clean up drawable theming" into lmp-mr1-dev
17cd4dfe3a05c2eddbcbc76066ff3b13fc3f2c8b 14-Oct-2014 Alan Viverette <alanv@google.com> Update preload list, clean up drawable theming

Removes all implementations of three-arg ConstantState constructor, since
we handle mutation and applyTheme() in Resources now. Moves progress bar
tinting to android:tint attribute. Correctly implements applyTheme() and
canApplyTheme() in all drawable wrapper and container classes.

Change-Id: Ic9cb43d0d6228aa4914f3124bed234b837beaa41
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
a7b64e8eefec1a200701443622debf1032291bdd 14-Oct-2014 Alan Viverette <alanv@google.com> Avoid saveLayer in RippleDrawable if the background won't draw

BUG: 17952941
Change-Id: Ic2640f847e2ed43fc5117d43230513ee7696d9e7
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
2627206e1b1658ccade3669d1794dc0d90e36264 14-Oct-2014 Alan Viverette <alanv@google.com> Revert "Always project ripples"

Projecting ripples places them under shadows, which is not
ideal. Punting this workaround and waiting until we have
proper support for rounded corner clipping on windows.

This reverts commit f90b6bd54f60960a790b5bd507a0d75d961a981a.

Change-Id: I61946649bbb1bf74a969d74e5353608afc8e4463
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
f90b6bd54f60960a790b5bd507a0d75d961a981a 09-Oct-2014 Alan Viverette <alanv@google.com> Always project ripples

We already handle bounding rect in draw(), so this just ensures
that ripples are always clipped to window background outlines
until we can implement more general clipping.

BUG: 17498583
Change-Id: Iaff51fb177b017a11822bdf4f31c117fc9522c15
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
f92f26fef215897bd302c1c06adbe5d853881b3f 08-Oct-2014 Alan Viverette <alanv@google.com> Slow down ripple background fade in from press

BUG: 17433613
Change-Id: Ie9c4046532d61ad8ef8e044d14557db5d52e0d0b
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
5004032ebc2aee97c5884b7f91cc33d2f98ae8b5 26-Sep-2014 Alan Viverette <alanv@google.com> Fixed mutate() for RippleDrawable, ASLD, AVD, fix applyTheme in VD

BUG: 17646144
Change-Id: I58c111d86224dc8f7f557073c0bcbc22ad74aa1b
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
2ae56403542582bd39c0e522bf29844d59300f37 15-Sep-2014 Alan Viverette <alanv@google.com> Reduce overdraw after clearing ripples in RippleDrawable

We only need to force a transparent draw after canceling a render
thread accelerated animation, and then we can draw again without
the transparency to avoid overdraw in the display list.

BUG: 17451761
Change-Id: I640f9a29d0940a93802f14a15f27d2c2072755ce
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
8683a4f819c5b4c77593568048428a6a18a883ca 10-Sep-2014 Alan Viverette <alanv@google.com> Only force drawing in RippleDrawable when necessary

BUG: 17451761
Change-Id: Ibb9d1c64791ec54eb90608c957eeb5efb1712b4a
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
a3f0c2b21a73a82a919abe247c4046d114f3712c 05-Sep-2014 Alan Viverette <alanv@google.com> Simplify ripple background drawing, fix ripple alphas

Eliminates an extra saveLayer on the background in the common case of
a rectangle-bounded ripple.

Ripples and backgrounds are now drawn at 50% opacity of the ripple
color, which ensures that both the ripple and background are visible
and that the pressed state has a correct combined alpha.

Also fixes a bug where hardware (RT) animation was getting turned off
prematurely.

BUG: 17405007
BUG: 17398089
BUG: 17394445
BUG: 17389859
Change-Id: Idb5808368fe563581a51a8cb9778275ee8d22f4c
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
94b88e7103b0ce7a1bb1f79156b5fdc07f1c90b4 03-Sep-2014 Alan Viverette <alanv@google.com> Merge "Remove partial support for hotspot changes on focus movement" into lmp-dev
a8a8ff000b2902eb4e187e62be39fd9535c6c839 03-Sep-2014 Alan Viverette <alanv@google.com> Remove partial support for hotspot changes on focus movement

Also removes unused x/y position and tween values on RippleBackground. The
background is now always centered within the hotspot area.

BUG: 17300399
Change-Id: I1904c9f44e6bebb2b434d2b092205edd42204263
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
be0dd99bac781d1dd73cb67f33bcd931e3693af5 03-Sep-2014 Alan Viverette <alanv@google.com> Make sure ripple background bounds are used for invalidation

BUG: 17349157
Change-Id: Ie88fbabbc66349aea9b7d00e28ca12f93776a4a7
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
fdbb98e56d4668c7bfa8de59c3c438c0cb69a535 29-Aug-2014 Alan Viverette <alanv@google.com> Fix disappearing ripple background, treat active ripple separately

There is only a single background, and it did not correctly handle
enter() being called while exit() was busy animating. We now cancel
all animations when starting an enter or exit. Also separates the
active ripple from the list of animating (exiting) ripples.

BUG: 17042060
BUG: 17281011
Change-Id: I4d4e33560867c7c71c1bdb72b17d52d6fbd86f68
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
40e38d43675b9baa4383058e5afd5291291abc81 27-Aug-2014 Alan Viverette <alanv@google.com> Fix NPE in RippleDrawable

Invalidate was called while we were busy clearing the list of
animating ripples, which led to an inconsistency between the
ripple count and actual state of the ripple list.

BUG: 17136636
BUG: 17281011
Change-Id: Ifb7be7eb334ad9a44cc3a1e6f55ad1e35218989a
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
d78a44576c6bac5541e04c1f38599d43c9943653 21-Aug-2014 Alan Viverette <alanv@google.com> Jump drawable state (including ripples) on view detach

BUG: 15350931
Change-Id: I09928f59fb7b9f6d87b1f5219353a41ae6b5681d
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
34a14f967ab6c88829c9a36ce6e909c47b3ee398 16-Aug-2014 Alan Viverette <alanv@google.com> Better handling of unresolved theme attributes

Also adds a (very obviously wrong) default color to RippleDrawable

Change-Id: I6d29b371f4e59accbebf25eb059b1f372b9184b0
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
27cede8777c999f226e2e1035b5011e59b558444 13-Aug-2014 Alan Viverette <alanv@google.com> Prevent re-entry when clearing animating hotspots

BUG: 16651728
Change-Id: I2b1b1501a4adfded833d0ed95ec3537ae217a6d7
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
dbcbca447564245921697c6965b77d69cb1e795f 08-Aug-2014 Alan Viverette <alanv@google.com> Don't make ripples respond to selection state

Also exports view pressed state for hierarchyviewer.

BUG: 16622634
Change-Id: I754428dd1d59f3b7450b01976a73d5151d27152e
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
77b5cad3efedd20f2b7cc14d87ccce1b0261960a 31-Jul-2014 Chris Craik <ccraik@google.com> Add outline alpha

bug:16140822
bug:16566746

This allows background drawables to alter the opacity of a shadow
being cast with their own alpha values.

Change-Id: I49698cc7c1bf4b2b55ffe2f82899543ca62bc61c
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
b6417b8b9492d88ccfbb723decaece1bb9ff0f73 29-Jul-2014 Alan Viverette <alanv@google.com> Don't double-cancel the active ripple

BUG: 16651728
Change-Id: Ibe413eabf9644c2ac9a5c8c1418ff996dacf606a
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
6ce6d70f9c78f0197f1369246bf55a5f6b8d7ba4 25-Jul-2014 Alan Viverette <alanv@google.com> Separate background from ripple for better focus/press UX

Regresses the "jump" when focus changes, since the background position
is static and we don't have any reasonable UX spec for this yet.

BUG: 16323640
Change-Id: I7152546ed08375864174049b342653b3c4d3d9fb
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
96335e3543e88f7a26b465d547d68a60678232c8 24-Jul-2014 Alan Viverette <alanv@google.com> Merge "Remove the max ripple count exceeded warning" into lmp-dev
e5d6cf85e2d8a76015202eb2d00bdfe7417a6752 24-Jul-2014 Alan Viverette <alanv@google.com> Remove the max ripple count exceeded warning

BUG: 16543509
Change-Id: I84ec8e01136d1f0f34c6153d8ef7936de547746e
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
ade9ef236c5258d7369597f2f8a08ab277396513 23-Jul-2014 Alan Viverette <alanv@google.com> Ensure ripple mask gets updated in public constructor

Change-Id: I084ff0357c8e3cf08d3700d9c7dce42726b986f1
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
31ba192dd201df2cad96a8c503f730130ab0d80f 18-Jul-2014 Chris Craik <ccraik@google.com> Tweaks to outline API

b/15283203
b/16142564

Remove boolean return value chaining, as it's redundant with
the data in the Outline itself.

Change-Id: I3116e57cd1b35c98b74e95195117edd7e39fb2df
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
7068c39526459c18a020e29c1ebfa6aed54e2d0f 14-Jul-2014 Alan Viverette <alanv@google.com> Fix hotspot movement on focus change

BUG: 15726988
Change-Id: I97f88e5f7e404ecfcd5c254fddd18c8f6616064e
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
935b1fa24d05533a95ee47425ab9bedb31641012 11-Jul-2014 Alan Viverette <alanv@google.com> Remove old RippleDrawable constructor, fix new constructor

BUG: 16221737
Change-Id: I3807d8d7ccccf66568b9d5421cb9456fe818e2bf
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
8e5e11b99fac942122ee2d6cdd30af51564861ae 07-Jul-2014 Alan Viverette <alanv@google.com> Handle configuration changes in drawable attributes

Adds themeable attribute support to InsetDrawable, adds support
for attribute configuration changes to all themable drawables.

BUG: 16045735
Change-Id: I3dc62d28801760ac69d303be81b6c78bb9bb5aca
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
7c0517272ba2d97084739a14fea78641b265eb5d 08-Jul-2014 Alan Viverette <alanv@google.com> Fix getOutline() in ripple and layer drawables

BUG: 16134862
Change-Id: Ibcef20fc154ecc342344770f96fbd3d77d6fad26
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
6ae2d7cefafd7fbf5e7c8d7d3c1869e66056b7f8 30-Jun-2014 Alan Viverette <alanv@google.com> Don't call deprecated RippleDrawable constructor

BUG: 15972806
Change-Id: If0973eed2da4708312a1320be4dd0b314157bc9a
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
7275abde37f0ad2df50e78de2fee1c0cfeb9cd92 27-Jun-2014 Alan Viverette <alanv@google.com> Require color in RippleDrawable constructor, fix documentation

Marks old constructor for removal and emits LOG_E when used.

BUG: 15808263
Change-Id: Iae4f3237261541cb04f42343351b3fc0ac4929ac
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
e3c433aa457138425e514494e4d06590076a1d07 19-Jun-2014 Alan Viverette <alanv@google.com> Persist selector on ListView and GridView layout

BUG: 15472031
Change-Id: I0d10be3e0cf8a4d7580bd834e432c1c15fc481f5
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
a4eab42fe437bff3f8ee9dde264579067ea5cdbd 10-Jun-2014 Alan Viverette <alanv@google.com> Change ripple tint to color, remove tintMode

Also fixes double ripple on list preferences, missing ripple on up
button, and adds the Toolbar style to public. Further improves
ripple performance.

BUG: 15523923
BUG: 15473856
Change-Id: I5e8bf417368b60fcc33c80852e12f27b8c580774
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
1b6e856e6f9dab4464e3c556b2f68527439fc329 09-Jun-2014 Alan Viverette <alanv@google.com> Optimize use of layers in ripple, update dialog styling

BUG: 15474733
BUG: 15473856
Change-Id: I7c17865c7b2d4aad0fc3660ffac90e9f7ce8fda9
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
b996d809bf10a9ad1f6f6be790d0261fe1565f3b 04-Jun-2014 Alan Viverette <alanv@google.com> Update ripple spec, fix ripple mask, rotate progress drawable

Change-Id: I4fc155bf2f12d9f324c354dee81479f9cddafac4
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
55a54e17df5d77d83d5221345eaea65f1a6094b9 04-Jun-2014 Alan Viverette <alanv@google.com> Merge "Update theme colors, fix EditText state transition" into lmp-preview-dev
dcf7b59f845297c6e96950615e439d96ce3fb739 03-Jun-2014 Alan Viverette <alanv@google.com> Update theme colors, fix EditText state transition

BUG: 11218747
BUG: 15200201
Change-Id: I94368897ea9466ae971b25fc80d6ca43433aadd5
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
7a98f74438ac8da8bed5ebdb54c70ce24557a9d8 03-Jun-2014 Alan Viverette <alanv@google.com> Fix NPE when ripples are canceled due to visibility change

BUG: 15406248
Change-Id: I63ce42fef8e1614372ee4a82e45eb15e8bbe1fe3
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
dc6046fca37264b48e9c959f38d08cfb78f436ed 02-Jun-2014 Alan Viverette <alanv@google.com> Allow ripple bounds to change during enter animation

BUG: 15315168
Change-Id: I7588be96648318473998cfd5deba678224f1db51
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
4d2f2483f6d9e2eb25d843d676981f4ebc9c79e5 02-Jun-2014 Alan Viverette <alanv@google.com> Fixes hotspot list transitions, update to use a single hotspot

Also updates background and button colors to match spec, removes
dependency on bouncycastle Arrays. Vastly simplifies ripple drawing.
Adds APIs for maximum ripple radius. Makes selectableItemBackground
bounded by default and adds an unbounded version and theme attribute.

BUG: 15315168
BUG: 15314684
BUG: 15314830
BUG: 15316768
BUG: 15333033
BUG: 15344050
Change-Id: Ib0619587ce78e43056b66571bae185e0f1613185
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
e7772d313b88e9fd3366670a9c8d1b145edef344 22-May-2014 Alan Viverette <alanv@google.com> Move setTint into Drawable, unhide getDirtyBounds on Drawable

BUG: 15089957
Change-Id: Ib622ba24b3f4bcf430e1d524895ac5cb104a232e
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
53a3ed7c46c12c2e578d1b1df8b039c6db690eaa 22-May-2014 Alan Viverette <alanv@google.com> Clean up hotspot bounds API

Change-Id: I7daf7e2d360d761f673aa69a0f925b8076ab19c6
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
c80ad99a33ee49d0bac994c1749ff24d243c3862 20-May-2014 Alan Viverette <alanv@google.com> TouchFeedbackDrawable is now RippleDrawable

Change-Id: I59f5f04b73089215c6320560556ac21beb03db06
/frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java