indirect_reference_table.cc revision c56057e40938c587a74984651a510e320a8cb4fd
16c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes/*
26c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * Copyright (C) 2009 The Android Open Source Project
36c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes *
46c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * Licensed under the Apache License, Version 2.0 (the "License");
56c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * you may not use this file except in compliance with the License.
66c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * You may obtain a copy of the License at
76c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes *
86c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes *      http://www.apache.org/licenses/LICENSE-2.0
96c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes *
106c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * Unless required by applicable law or agreed to in writing, software
116c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * distributed under the License is distributed on an "AS IS" BASIS,
126c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
136c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * See the License for the specific language governing permissions and
146c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes * limitations under the License.
156c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes */
166c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
17c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier#include "indirect_reference_table-inl.h"
18c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier
19a2501990dd0f68baf38ce19251949d7bb3ecfe5aElliott Hughes#include "jni_internal.h"
206c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes#include "reference_table.h"
21a2501990dd0f68baf38ce19251949d7bb3ecfe5aElliott Hughes#include "runtime.h"
2200f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abacIan Rogers#include "scoped_thread_state_change.h"
235a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers#include "thread.h"
24cdd1d2d3fee0711b8b11db99f2dfb80113520100Ian Rogers#include "utils.h"
256dda898d47b3e8931e4404330e81b7110108e34fMathieu Chartier#include "verify_object-inl.h"
266c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
276c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes#include <cstdlib>
286c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
296c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughesnamespace art {
306c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
31719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogerstemplate<typename T>
32719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogersclass MutatorLockedDumpable {
33719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers public:
34719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers  explicit MutatorLockedDumpable(T& value)
35719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers      SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) : value_(value) {
36719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers  }
37719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers
38719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers  void Dump(std::ostream& os) const SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
39719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers    value_.Dump(os);
40719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers  }
41719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers
42719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers private:
43719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers  T& value_;
44719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers
45719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers  DISALLOW_COPY_AND_ASSIGN(MutatorLockedDumpable);
46719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers};
47719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers
48719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogerstemplate<typename T>
49719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogersstd::ostream& operator<<(std::ostream& os, const MutatorLockedDumpable<T>& rhs)
50719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers// TODO: should be SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) however annotalysis
51719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers//       currently fails for this.
52719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers    NO_THREAD_SAFETY_ANALYSIS {
53719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers  rhs.Dump(os);
54719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers  return os;
55719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers}
56719d1a33f6569864f529e5a3fff59e7bca97aad0Ian Rogers
57c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartiervoid IndirectReferenceTable::AbortIfNoCheckJNI() {
58a2501990dd0f68baf38ce19251949d7bb3ecfe5aElliott Hughes  // If -Xcheck:jni is on, it'll give a more detailed error before aborting.
59a2501990dd0f68baf38ce19251949d7bb3ecfe5aElliott Hughes  if (!Runtime::Current()->GetJavaVM()->check_jni) {
60a2501990dd0f68baf38ce19251949d7bb3ecfe5aElliott Hughes    // Otherwise, we want to abort rather than hand back a bad reference.
61a2501990dd0f68baf38ce19251949d7bb3ecfe5aElliott Hughes    LOG(FATAL) << "JNI ERROR (app bug): see above.";
62a2501990dd0f68baf38ce19251949d7bb3ecfe5aElliott Hughes  }
636c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes}
646c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
656c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott HughesIndirectReferenceTable::IndirectReferenceTable(size_t initialCount,
66ba8eee10607a524f43b55a6f33c13924fb16d435Elliott Hughes                                               size_t maxCount, IndirectRefKind desiredKind) {
676c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  CHECK_GT(initialCount, 0U);
686c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  CHECK_LE(initialCount, maxCount);
69408f79aeb676251ba35667a64e86c20638d7cb0bIan Rogers  CHECK_NE(desiredKind, kSirtOrInvalid);
706c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
71c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  std::string error_str;
72c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  const size_t initial_bytes = initialCount * sizeof(const mirror::Object*);
73c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  const size_t table_bytes = maxCount * sizeof(const mirror::Object*);
74c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  table_mem_map_.reset(MemMap::MapAnonymous("indirect ref table", nullptr, table_bytes,
75c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier                                            PROT_READ | PROT_WRITE, false, &error_str));
76c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  CHECK(table_mem_map_.get() != nullptr) << error_str;
77c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier
78c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  table_ = reinterpret_cast<mirror::Object**>(table_mem_map_->Begin());
79c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  CHECK(table_ != nullptr);
80c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  memset(table_, 0xd1, initial_bytes);
816c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
82c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  const size_t slot_bytes = maxCount * sizeof(IndirectRefSlot);
83c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  slot_mem_map_.reset(MemMap::MapAnonymous("indirect ref table slots", nullptr, slot_bytes,
84c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier                                           PROT_READ | PROT_WRITE, false, &error_str));
85c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  CHECK(slot_mem_map_.get() != nullptr) << error_str;
86c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  slot_data_ = reinterpret_cast<IndirectRefSlot*>(slot_mem_map_->Begin());
87c56057e40938c587a74984651a510e320a8cb4fdMathieu Chartier  CHECK(slot_data_ != nullptr);
886c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
89dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers  segment_state_.all = IRT_FIRST_SEGMENT;
906c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  alloc_entries_ = initialCount;
916c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  max_entries_ = maxCount;
926c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  kind_ = desiredKind;
936c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes}
946c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
956c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott HughesIndirectReferenceTable::~IndirectReferenceTable() {
966c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes}
976c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
98423d2a3dcbb260b020efb5da59f784c9f02accbfMathieu ChartierIndirectRef IndirectReferenceTable::Add(uint32_t cookie, mirror::Object* obj) {
996c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  IRTSegmentState prevState;
1006c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  prevState.all = cookie;
101dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers  size_t topIndex = segment_state_.parts.topIndex;
1026c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
103cd2cfff09c916c9e72a7cfeb0686b441847dc62eMathieu Chartier  CHECK(obj != NULL);
1046dda898d47b3e8931e4404330e81b7110108e34fMathieu Chartier  VerifyObject(obj);
1056c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  DCHECK(table_ != NULL);
1066c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  DCHECK_LE(alloc_entries_, max_entries_);
107dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers  DCHECK_GE(segment_state_.parts.numHoles, prevState.parts.numHoles);
1086c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
1096c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  if (topIndex == alloc_entries_) {
11073e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes    // reached end of allocated space; did we hit buffer max?
1116c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    if (topIndex == max_entries_) {
11273e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes      LOG(FATAL) << "JNI ERROR (app bug): " << kind_ << " table overflow "
11373e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes                 << "(max=" << max_entries_ << ")\n"
11400f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abacIan Rogers                 << MutatorLockedDumpable<IndirectReferenceTable>(*this);
1156c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    }
1166c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
1176c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    size_t newSize = alloc_entries_ * 2;
1186c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    if (newSize > max_entries_) {
1196c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes      newSize = max_entries_;
1206c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    }
1216c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    DCHECK_GT(newSize, alloc_entries_);
1226c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
1236c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    alloc_entries_ = newSize;
1246c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  }
1256c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
12673e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes  // We know there's enough room in the table.  Now we just need to find
12773e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes  // the right spot.  If there's a hole, find it and fill it; otherwise,
12873e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes  // add to the end of the list.
1296c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  IndirectRef result;
130dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers  int numHoles = segment_state_.parts.numHoles - prevState.parts.numHoles;
1316c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  if (numHoles > 0) {
1326c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    DCHECK_GT(topIndex, 1U);
13373e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes    // Find the first hole; likely to be near the end of the list.
134423d2a3dcbb260b020efb5da59f784c9f02accbfMathieu Chartier    mirror::Object** pScan = &table_[topIndex - 1];
1356c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    DCHECK(*pScan != NULL);
1366c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    while (*--pScan != NULL) {
1376c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes      DCHECK_GE(pScan, table_ + prevState.parts.topIndex);
1386c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    }
1396c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    UpdateSlotAdd(obj, pScan - table_);
1406c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    result = ToIndirectRef(obj, pScan - table_);
1416c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    *pScan = obj;
142dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers    segment_state_.parts.numHoles--;
1436c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  } else {
14473e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes    // Add to the end.
1456c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    UpdateSlotAdd(obj, topIndex);
1466c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    result = ToIndirectRef(obj, topIndex);
1476c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    table_[topIndex++] = obj;
148dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers    segment_state_.parts.topIndex = topIndex;
1496c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  }
1505a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers  if (false) {
1515a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers    LOG(INFO) << "+++ added at " << ExtractIndex(result) << " top=" << segment_state_.parts.topIndex
1525a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers              << " holes=" << segment_state_.parts.numHoles;
1535a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers  }
1546c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
1556c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  DCHECK(result != NULL);
1566c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  return result;
1576c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes}
1586c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
159726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughesvoid IndirectReferenceTable::AssertEmpty() {
16000f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abacIan Rogers  if (UNLIKELY(begin() != end())) {
16100f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abacIan Rogers    ScopedObjectAccess soa(Thread::Current());
16273e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes    LOG(FATAL) << "Internal Error: non-empty local reference table\n"
16300f7d0eaa6bd93d33bf0c1429bf4ba0b3f28abacIan Rogers               << MutatorLockedDumpable<IndirectReferenceTable>(*this);
164726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes  }
165726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes}
166726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes
16773e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes// Removes an object. We extract the table offset bits from "iref"
16873e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes// and zap the corresponding entry, leaving a hole if it's not at the top.
16973e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes// If the entry is not between the current top index and the bottom index
17073e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes// specified by the cookie, we don't remove anything. This is the behavior
17173e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes// required by JNI's DeleteLocalRef function.
17273e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes// This method is not called when a local frame is popped; this is only used
17373e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes// for explicit single removals.
17473e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes// Returns "false" if nothing was removed.
1756c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughesbool IndirectReferenceTable::Remove(uint32_t cookie, IndirectRef iref) {
1766c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  IRTSegmentState prevState;
1776c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  prevState.all = cookie;
178dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers  int topIndex = segment_state_.parts.topIndex;
1796c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  int bottomIndex = prevState.parts.topIndex;
1806c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
1816c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  DCHECK(table_ != NULL);
1826c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  DCHECK_LE(alloc_entries_, max_entries_);
183dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers  DCHECK_GE(segment_state_.parts.numHoles, prevState.parts.numHoles);
1846c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
1856c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  int idx = ExtractIndex(iref);
1866c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
1875a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers  if (GetIndirectRefKind(iref) == kSirtOrInvalid &&
1880399dde18753aa9bd2bd0d7cf60beef154d164a4Ian Rogers      Thread::Current()->SirtContains(reinterpret_cast<jobject>(iref))) {
1895a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers    LOG(WARNING) << "Attempt to remove local SIRT entry from IRT, ignoring";
1905a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers    return true;
1915a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers  }
1926c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
1936c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  if (idx < bottomIndex) {
194726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes    // Wrong segment.
195726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes    LOG(WARNING) << "Attempt to remove index outside index area (" << idx
196726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes                 << " vs " << bottomIndex << "-" << topIndex << ")";
1976c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    return false;
1986c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  }
1996c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  if (idx >= topIndex) {
200726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes    // Bad --- stale reference?
201726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes    LOG(WARNING) << "Attempt to remove invalid index " << idx
202726079d3e2e50854cd6ca4c393f4529a796dba58Elliott Hughes                 << " (bottom=" << bottomIndex << " top=" << topIndex << ")";
2036c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    return false;
2046c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  }
2056c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
2066c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  if (idx == topIndex-1) {
2076c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    // Top-most entry.  Scan up and consume holes.
2086c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
209987560fee798e48fb725c44b796d8ca7a5872ad6Ian Rogers    if (!CheckEntry("remove", iref, idx)) {
2106c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes      return false;
2116c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    }
2126c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
2136c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    table_[idx] = NULL;
214dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers    int numHoles = segment_state_.parts.numHoles - prevState.parts.numHoles;
2156c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    if (numHoles != 0) {
2166c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes      while (--topIndex > bottomIndex && numHoles != 0) {
2175a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers        if (false) {
2185a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers          LOG(INFO) << "+++ checking for hole at " << topIndex-1
2195a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers                    << " (cookie=" << cookie << ") val=" << table_[topIndex - 1];
2205a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers        }
2216c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes        if (table_[topIndex-1] != NULL) {
2226c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes          break;
2236c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes        }
2245a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers        if (false) {
2255a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers          LOG(INFO) << "+++ ate hole at " << (topIndex - 1);
2265a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers        }
2276c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes        numHoles--;
2286c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes      }
229dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers      segment_state_.parts.numHoles = numHoles + prevState.parts.numHoles;
230dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers      segment_state_.parts.topIndex = topIndex;
2316c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    } else {
232dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers      segment_state_.parts.topIndex = topIndex-1;
2335a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers      if (false) {
2345a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers        LOG(INFO) << "+++ ate last entry " << topIndex - 1;
2355a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers      }
2366c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    }
2376c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  } else {
23873e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes    // Not the top-most entry.  This creates a hole.  We NULL out the
23973e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes    // entry to prevent somebody from deleting it twice and screwing up
24073e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes    // the hole count.
2416c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    if (table_[idx] == NULL) {
2426c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes      LOG(INFO) << "--- WEIRD: removing null entry " << idx;
2436c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes      return false;
2446c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    }
245987560fee798e48fb725c44b796d8ca7a5872ad6Ian Rogers    if (!CheckEntry("remove", iref, idx)) {
2466c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes      return false;
2476c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    }
2486c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
2496c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes    table_[idx] = NULL;
250dc51b79e65abcdad094ccd5e5a2caf5153433d49Ian Rogers    segment_state_.parts.numHoles++;
2515a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers    if (false) {
2525a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers      LOG(INFO) << "+++ left hole at " << idx << ", holes=" << segment_state_.parts.numHoles;
2535a7a74a042e73a355f5cedffa0d2faf5340028faIan Rogers    }
2546c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  }
2556c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
2566c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes  return true;
2576c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes}
2586c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
25983c8ee000d525017ead8753fce6bc1020249b96aMathieu Chartiervoid IndirectReferenceTable::VisitRoots(RootCallback* callback, void* arg, uint32_t tid,
26083c8ee000d525017ead8753fce6bc1020249b96aMathieu Chartier                                        RootType root_type) {
26102e25119b15a6f619f17db99f5d05124a5807ff3Mathieu Chartier  for (auto ref : *this) {
262815873ecc312b1d231acce71e1a16f42cdaf09f2Mathieu Chartier    callback(ref, arg, tid, root_type);
263423d2a3dcbb260b020efb5da59f784c9f02accbfMathieu Chartier    DCHECK(*ref != nullptr);
264410c0c876f326e14c176a39ba21fc4dd3f7db8abElliott Hughes  }
265410c0c876f326e14c176a39ba21fc4dd3f7db8abElliott Hughes}
266410c0c876f326e14c176a39ba21fc4dd3f7db8abElliott Hughes
26773e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughesvoid IndirectReferenceTable::Dump(std::ostream& os) const {
26873e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes  os << kind_ << " table dump:\n";
269423d2a3dcbb260b020efb5da59f784c9f02accbfMathieu Chartier  ReferenceTable::Table entries(table_, table_ + Capacity());
27063818dc8b06af4a1e65c41b453f1a42166c22728Ian Rogers  // Remove NULLs.
27163818dc8b06af4a1e65c41b453f1a42166c22728Ian Rogers  for (int i = entries.size() - 1; i >= 0; --i) {
27263818dc8b06af4a1e65c41b453f1a42166c22728Ian Rogers    if (entries[i] == NULL) {
27363818dc8b06af4a1e65c41b453f1a42166c22728Ian Rogers      entries.erase(entries.begin() + i);
27463818dc8b06af4a1e65c41b453f1a42166c22728Ian Rogers    }
27563818dc8b06af4a1e65c41b453f1a42166c22728Ian Rogers  }
27673e66f73f5093b64f2b023ebbb85916a13d5c937Elliott Hughes  ReferenceTable::Dump(os, entries);
2776c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes}
2786c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes
2796c1a394b47c85c8d1723fc3b156a3b1b0b29a757Elliott Hughes}  // namespace art
280