a4b5c35036e68c7551dd77641ceec17b92c6368d |
|
19-Aug-2015 |
Chris Banes <chrisbanes@google.com> |
Fix AppCompatDialogFragment crashing We now model PhoneWindow in when it reads the theme window flags. Added a unit test too BUG: 23336734 Change-Id: I990bd91d29d1009e0e18f976c7b3c542782660e6
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
f2149b131fa96dc0a26fc86b3a36c4094c63a73a |
|
16-Jul-2015 |
Chris Banes <chrisbanes@google.com> |
Remove DayNight functionality DO NOT MERGE BUG: 22488087 Change-Id: I69298e07b8aae124a4982d30c070ea042c6e3568
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
4e0a0984e80ced79b8aa3cf71fc261044ecc08a6 |
|
23-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
am 5ba742a3: Merge "Fix leak for MenuInflater + setSupportActionBar" into lmp-mr1-ub-dev * commit '5ba742a37d06a0961f20e41c18cc6f8f4d5fd514': Fix leak for MenuInflater + setSupportActionBar
|
5ecdb2c5042da49d36d7cda3fa08f1d9151a1fbd |
|
22-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix leak for MenuInflater + setSupportActionBar Caused when there are multiple calls to setSupportActionBar(). getMenuInflater() will instantiate and keep an instance to the first Toolbar (and it's container, etc). BUG: 21638877 Change-Id: I4c79b4832534b06e7ab2819e78e303dde4a7d76a
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
2a5e18155a210d06ebb142059746becb31f67945 |
|
18-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Merge commit '62d9aaed' into manualmerge Change-Id: I22d22d6a496759a98b81c3f1bf1c226b48fa8e17
|
8d4765883ff24f0f79bf64fea23d4687d50cec85 |
|
18-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix memory leak in ToolbarActionBar Caused when there are multiple calls to setSupportActionBar() (i.e. fragments). ToolbarActionBar currently just wraps the Window's current Callback. Which means that for every setSupportActionBar() call, we're re-wrapping a ToolbarActionBar Window.Callback wrapper. This CL fixes it by making sure that we always wrap the correct 'root' Window.Callback. BUG: 21914909 Change-Id: I8f21b94d60eb488630b1fe7377ba62d3608accef
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
8122ad54f129c2214631fad86cabda82815cc0d8 |
|
08-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix window decor Action Bar init BUG: 21575069 Change-Id: I2e9919c36f221c968bc38c8d7ba4e476f41b45f7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
88c0ac5649d6b82c882e2de4bc4f043b107a4428 |
|
02-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Move our Window flags handling closer to PhoneWindow Fixes some issues around stack overflows for certain flag combinations. BUG: 21575069 Change-Id: I6f6c98863f7cfb4510cbeeb8a1be6e16c6de509f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
1282e55f13234e9275cd76d3e02559e1eabf12e3 |
|
08-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Fix window decor Action Bar init BUG: 21575069 Change-Id: I2e9919c36f221c968bc38c8d7ba4e476f41b45f7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
85d77caf73c0bfe957304951f94f88650a064efb |
|
08-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Merge "Move our Window flags handling closer to PhoneWindow DO NOT MERGE" into lmp-mr1-ub-dev
|
559fa14454cc053127b3b96c0e63c48c06937e38 |
|
03-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Revert the previous fix for stealing KEYCODE_MENU We now just steal those events if we can actually handle them. BUG: 20529185 Change-Id: I09119b9efcd24e15b39990a22a7da55257ebfd96 (cherry picked from commit a6624356b85f8a31c5d951c92ce39ef1070fd9db)
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
a6624356b85f8a31c5d951c92ce39ef1070fd9db |
|
03-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Revert the previous fix for stealing KEYCODE_MENU DO NOT MERGE We now just steal those events if we can actually handle them. BUG: 20529185 Change-Id: I09119b9efcd24e15b39990a22a7da55257ebfd96
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
0c4414fd7d27eef2a3545cb36db29070f8a3ea77 |
|
02-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
Move our Window flags handling closer to PhoneWindow DO NOT MERGE Fixes some issues around stack overflows for certain flag combinations. BUG: 21575069 Change-Id: I6f6c98863f7cfb4510cbeeb8a1be6e16c6de509f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
15ad53853d367f5d593bb019d88fb613878fd8fc |
|
14-May-2015 |
Chris Banes <chrisbanes@google.com> |
Theme.AppCompat.DayNight working back to API v14 This CL enables the use of -night and -notnight resource qualifiers, and thus allowing Theme.AppCompat.DayNight to work on those API levels. TwilightCalculator and TwilightManager are simplified versions of those internally in the framework. Since we don't want to force the use of location permissions, we have a fallback of hardcoded 'night' time. BUG: 21119724 Change-Id: I48ff5f0ea0c02ba60d3c2979aa9fa2997080de37
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
d25af35061a9f20d59b25329d613c62c20184dad |
|
04-May-2015 |
Chris Banes <chrisbanes@google.com> |
Window.Callback passthrough fixes We currently do not proxy onMenuOpened or onPanelClosed events to the Activity because we overload the FEATURE_ACTION_BAR ID internally. From v11+, those methods in Activity do special handling and try and init it's own Action Bar (which usually results in a crash). To fix this, we now use our own special feature IDs: FEATURE_SUPPORT_ACTION_BAR and FEATURE_SUPPORT_ACTION_BAR_OVERLAY. Meaning, we can now pass the calls through without the default impl blowing up. We still accept the normal window feature IDs for requestWindowFeature() but we log an info message. BUG: 20816353 Change-Id: Ieea6d451279469b9de7bd96a17e5338600fdf9d8
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
556a65bcf38cb6197f018ff4700f822538758261 |
|
30-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Merge "Fix our pre-JB onPreparePanel() workaround" into lmp-mr1-ub-dev
|
ba79f0593a0f53d254b4e555c8702ed1d0435120 |
|
29-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Fix getSupportActionBar() returning null for Toolbars Change-Id: I00d966f9de447c746355c5b820aecb3a49b6fde0
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
4e411251159c965caccb3bf3727c2921d74f06c1 |
|
29-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Fix our pre-JB onPreparePanel() workaround We now call Activity.onPreparePanel() as normal which fixes FragmentActivity dispatching the call to it's fragments. BUG: 20680612 Change-Id: If9325b78e54f61c472284334133e0d29b3778f63
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
5ec61b424dc658e52f65d40d05ee14b869c59374 |
|
28-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Merge "Let the Activity/Dialog handle KeyEvents first" into lmp-mr1-ub-dev
|
a9279663ecb98b85bf95a5ba1ebc145756fc13a2 |
|
27-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Don't allow an Action Bar to be created for floating windows BUG: 20624627 Change-Id: I9d3505b03d099ff8e09558094136094ad2e26213
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
e68562a419ae9fdcd2505bbc146214e3ec1883b1 |
|
26-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Let the Activity/Dialog handle KeyEvents first BUG: 20529185 Change-Id: I123aa7d206026c82984fb945f67f42bdf770ade9
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
547a80d347e0dc9751bbe3cf91f947477145bdba |
|
13-Apr-2015 |
Chris Banes <chrisbanes@google.com> |
Action Mode fixes - Added a switch to disable native CAB handling - They now use the correct theme - Using a better way to intercept framework CABs - We now only intercept on v14+. BUG: 20171499 BUG: 20022929 BUG: 20208108 Depends on Iacffdf908b98739770f13665732d7755b14b9a25 Change-Id: Ia64beb77ba0a08186e4cdea4544cd9880bf4a4d9
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
0f58401dc72db8ea2a201e3c0220f6529f2a7b33 |
|
04-Feb-2015 |
Chris Banes <chrisbanes@google.com> |
Add AppCompat specific windowNoTitle attribute More useful now that we support Dialogs. Also reworked the sub decor code to match more closely to the framework. BUG: 19194408 Change-Id: If48a338e583dddedfd620993aed92bca5e253781
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
16e8d4dd91083260223c007c797e46bc8f631055 |
|
23-Dec-2014 |
Chris Banes <chrisbanes@google.com> |
Material Dialog themes Lots of changes needed for this, building upon the refactoring CL. AppCompatDelegate can now handle Dialogs as well as Activitys (which was easy after the refactor). This was needed so that we can install a custom decor for Dialogs. Also added borderless button styles as they were needed for Dialogs. Change-Id: I88a7e4de5de85477982e401c832aeae732f81647
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|
f3ad1351d8b40ec5defe35e79d3430ad3c384b6d |
|
27-Nov-2014 |
Chris Banes <chrisbanes@google.com> |
Refactor AppCompat's Activity structure - The activity delegates now have a public abstract class called AppCompatDelegate. Any Activity can create one, but they must call through to the delegate at certain lifecycle methods. - Related, I've reduced the number of manual lifecycle calls needed by using Window.Callback where possible. - Activities can implement the the new AppCompatActivityCallback interface to receive certain callbacks. - AppCompatActivity does all of this automatically - ActionBarActivity is now a deprecated alias for AppCompatActivity - Removed support for the v4 Drawer Toggle - Remove our internal callback in favor of using Window.Callback directly BUG: 18547959 Change-Id: I8ece4372fa2abbc5b5246544643fafe0e22874be
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
|