History log of /frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
b290812e5d79643e587c1c76f9179077bdf3758d 28-Jul-2015 Chris Banes <chrisbanes@google.com> am fcefab49: Merge "Fix alpha keyboard shortcuts with ToolbarActionBar" into lmp-mr1-ub-dev

* commit 'fcefab49a0d08ceadf64d67a364e007006fc0bc0':
Fix alpha keyboard shortcuts with ToolbarActionBar
9d9c6a22548670bf017e69fd5d0f47134a18b53f 22-Jul-2015 Chris Banes <chrisbanes@google.com> Fix alpha keyboard shortcuts with ToolbarActionBar

BUG: 22651750

Change-Id: Ia012f19cb31840f8df85ba69de45cf284ab06441
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
f2b833b408c2169dee906a43268c41e55c8964b3 16-Jul-2015 Chris Banes <chrisbanes@google.com> am 9efaee2e: Always return true from ToolbarActionBar onKeyShortcut

* commit '9efaee2e7e3a147405847736eacdb5e1c66ae1c2':
Always return true from ToolbarActionBar onKeyShortcut
9efaee2e7e3a147405847736eacdb5e1c66ae1c2 16-Jul-2015 Chris Banes <chrisbanes@google.com> Always return true from ToolbarActionBar onKeyShortcut

BUG: 18021345
Change-Id: Idb8128d087364042e83f16ba1ac9c0580ced6ecf
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
2a5e18155a210d06ebb142059746becb31f67945 18-Jun-2015 Chris Banes <chrisbanes@google.com> Merge commit '62d9aaed' into manualmerge

Change-Id: I22d22d6a496759a98b81c3f1bf1c226b48fa8e17
8d4765883ff24f0f79bf64fea23d4687d50cec85 18-Jun-2015 Chris Banes <chrisbanes@google.com> Fix memory leak in ToolbarActionBar

Caused when there are multiple calls to
setSupportActionBar() (i.e. fragments). ToolbarActionBar
currently just wraps the Window's current Callback. Which
means that for every setSupportActionBar() call, we're
re-wrapping a ToolbarActionBar Window.Callback wrapper.

This CL fixes it by making sure that we always wrap the
correct 'root' Window.Callback.

BUG: 21914909

Change-Id: I8f21b94d60eb488630b1fe7377ba62d3608accef
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
00374d6956602a63c2d57b1962131b175e20d811 15-Jun-2015 Adam Powell <adamp@google.com> Fix crash in ToolbarActionBar when setting null custom view

AppCompat edition

Bug 21291849

Change-Id: I1cfdd8e7aa9d0845259380da11d7b14a06a7f46d
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
c27d0a499183aeb0be1fb9b6ede7132228a64cf3 06-Jun-2015 Chris Banes <chrisbanes@google.com> am ceacdb3a: Fix list menu theme when using Toolbar as AB

* commit 'ceacdb3af2ceaaded8d27e0393483a7eef59aa17':
Fix list menu theme when using Toolbar as AB
ceacdb3af2ceaaded8d27e0393483a7eef59aa17 05-Jun-2015 Chris Banes <chrisbanes@google.com> Fix list menu theme when using Toolbar as AB

The list menu presenter theme now matches what you
would get from a decor Action Bar.

BUG: 21586666
Change-Id: Ie1f7634d0ffab90fdf5b4a8d5152b767d9ff1abb
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
d25af35061a9f20d59b25329d613c62c20184dad 04-May-2015 Chris Banes <chrisbanes@google.com> Window.Callback passthrough fixes

We currently do not proxy onMenuOpened or onPanelClosed
events to the Activity because we overload the FEATURE_ACTION_BAR
ID internally. From v11+, those methods in Activity do special
handling and try and init it's own Action Bar (which usually results
in a crash).

To fix this, we now use our own special feature IDs:
FEATURE_SUPPORT_ACTION_BAR and FEATURE_SUPPORT_ACTION_BAR_OVERLAY.
Meaning, we can now pass the calls through without the default impl
blowing up.

We still accept the normal window feature IDs for requestWindowFeature()
but we log an info message.

BUG: 20816353

Change-Id: Ieea6d451279469b9de7bd96a17e5338600fdf9d8
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
436e191f80e197712dd1a7f1f7c61acfff8b1f04 22-Jan-2015 Chris Banes <chrisbanes@google.com> Ensure we dismiss the options menu on item click

BUG: 19104258
Change-Id: I72937d5882c5a476ea1688b1b8564e356271ef1f
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
f3ad1351d8b40ec5defe35e79d3430ad3c384b6d 27-Nov-2014 Chris Banes <chrisbanes@google.com> Refactor AppCompat's Activity structure

- The activity delegates now have a public abstract class
called AppCompatDelegate. Any Activity can create one,
but they must call through to the delegate at certain
lifecycle methods.
- Related, I've reduced the number of manual lifecycle
calls needed by using Window.Callback where possible.
- Activities can implement the the new AppCompatActivityCallback
interface to receive certain callbacks.
- AppCompatActivity does all of this automatically
- ActionBarActivity is now a deprecated alias for AppCompatActivity
- Removed support for the v4 Drawer Toggle
- Remove our internal callback in favor of using Window.Callback
directly

BUG: 18547959

Change-Id: I8ece4372fa2abbc5b5246544643fafe0e22874be
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
46dfe0c53492ef0cb59873123ca141906fbb7dcc 03-Nov-2014 Chris Banes <chrisbanes@google.com> Bring list menu fully into appcompat

We no longer delegate upto the Window to display
list menu items.

We now include more PhoneWindow. YAY.

BUG: 18004449
BUG: 17470603

Change-Id: Ieb072b6ac02db7a1438ab3ebfe2ba1cc29717a77
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
d15ee7df01f2f48b536a610c4739f33b226d3f81 29-Oct-2014 Chris Banes <chrisbanes@google.com> Let the Action Bar handle keyboard shortcuts

BUG: 18021345
Change-Id: If7f555b0ae2dc5ef8662f2d42c87f2b98cbeb603
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
6aadbd39814a5ae41e1fadfab06657cdf901e625 23-Oct-2014 Yigit Boyar <yboyar@google.com> Move all actionbar related methods to DecorToolbar

Bug: 17999561
Change-Id: Ibf7d84372eca7757bebee5c142c6a2237af815fa
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
0b7aedbbe43b9d4af60cc4ebd4994c74ebe6bc5f 29-Sep-2014 Chris Banes <chrisbanes@google.com> More list menu fixes

Fix Menu not having it's callback set. Caused by a timing issue
in ToolbarActionBar's new list menu. If Toolbar.getMenu() is
called before Toolbar.setMenuCallbacks() then the menu
callback is never used. Fixed by making sure we set
the callbacks before getMenu() is called.

Also fixes the scenario where Toolbar does not return a panel
view (no action-items to display), resulting in the standard
'window' panels being checked. This previously meant that the
Toolbar's panel view is never used. We now never check the
'window' panels if there is a Toolbar list menu presenter
available.

BUG: 17049242

Change-Id: I355db4c782b38cd09f7def29224af849b74da0b7
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
da0b9d63d6f940cbfd5b526c3f81858aeadcb7e8 24-Sep-2014 Chris Banes <chrisbanes@google.com> Fix List Menu for Toolbar Action Bars

The problem is that PhoneWindow keeps hold of
the first menu returned from onCreatePanelView(). The update
of that is controlled by PanelStateFeature.refreshDecorView flag
is rarely set, so the new view returned by onCreatePanelView()
is never actually used.

This CL works around it by keeping one ListMenuPresenter (and thus
one MenuView) and passing it to each ToolbarActionBar. It can
then update the view as needed.

BUG: 17049242

Change-Id: Iedaa93c1dfc0068e4ce588aee28548949f9c4d15
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
57c6de90985a63358129b99b9f0cd4d6afe887d6 19-Sep-2014 Chris Banes <chrisbanes@google.com> List menu fixes galore.

- ToolbarActionBar now handles it's own list menu.
- Also fixed theming of the list menu once and for all.
It's now tied to actionBarTheme and actionBarPopupTheme.

BUG: 17319897
BUG: 17049242

Change-Id: I0e523323f9f53060d1ebd678f344c56b9f9dda63
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
b3813e08451b31c599f47ebaf14c9467043cedbc 11-Sep-2014 Yigit Boyar <yboyar@google.com> Add support for default content description in Toolbar

Bug: 16888338

Change-Id: Iefd663455b5a8f5f4ec96041bfbd74881c2bf0df
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
c4b9e0cb716a4caff218b27d86f37ef8117d257b 05-Sep-2014 Chris Banes <chrisbanes@google.com> Menu Callbacks for appcompat Toolbar

BUG: 17326424
Change-Id: I1c06029a62626efe2cd2d88f198b7fbe76e057c2
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
ac00a989afc2f1c559fc33174f481a0a0ef5b3d8 01-Sep-2014 Chris Banes <chrisbanes@google.com> Backport Toolbar framework updates to appcompat

BUG: 17253638
BUG: 17305707
BUG: 17298370

Change-Id: Ic4f876565f7da93b166c52d4a206f86ae78d5ca7
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
ca58f2ce7cd9f0e0f2c4a46c3bcc98013209f6b3 27-Aug-2014 Chris Banes <chrisbanes@google.com> Update Toolbar/Action Bar title handling to match fw

BUG 17138048

Change-Id: Ib787757a991178787bbd1bf9dc405a9a507fe7c3
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
0b216f2263135782c361e122892a12156d5d2ce1 26-Aug-2014 Chris Banes <chrisbanes@google.com> Fix a bug propagating navigation events from ToolbarActionBar

Migrates fix from I2c3d7525489a21847f4af9b80f6ebf9b34b4dd58
to appcompat

BUG: 16980711
Change-Id: Ic265c73881935e5d2df59a3b693e5f9e75b56bea
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
a2c72b87007d10202c25e78e904938f770c6337d 13-Aug-2014 Chris Banes <chrisbanes@google.com> Update appcompat internal to lmp-dev framework

Not much of note.

Change-Id: I607624d63506bd72ae6f1a080c35afbeb361b0b7
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
4c2a95906254748cb9a843b061288265d6e185a9 01-Aug-2014 Chris Banes <chrisbanes@google.com> Fix ActionMode behavior in appcompat

This CL fixes a few issues. First is that the action mode
isn't visible when started.
Second, ToolbarActionBar wasn't hooked up to start an action
mode.
Third, we know wrap any implicit action modes (textIsSelectable, etc)
in a support action mode so that the styling is consistent.

BUG: 16721002
Change-Id: Iba7e7b7ab2589a4b1f759edb21f79caab16f2459
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
ebec8cacc3ebeea96b6c49890ee145d7e60cd7cd 31-Jul-2014 Andrew Sapperstein <asapperstein@google.com> Fix appcompat bugs.

b/16491458 - performs the equivalent fix for appcompat.
b/16688925 - return an ActionBar when setting it via Toolbar.

Change-Id: I4dc7f929fa05d51e61b05afe0ae42d604aca3903
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java
49c78900da0d43140fb602431fb93212bd7f6c70 15-Jul-2014 Chris Banes <chrisbanes@google.com> Update internal Action Bar implementation to L

This CL brings all of the internal widgets and helpers
for the Action Bar up to date with L. We now only use the
unbundled ActionBar/ToolBar implementation. This is to ease
integration and make styling simpler.

Change-Id: I267c9ee90b5707d997910c57242e26130f2dbcf8
/frameworks/support/v7/appcompat/src/android/support/v7/internal/app/ToolbarActionBar.java