History log of /frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
5d3c47dccb89d5616ec6f3625e586a5cc4fa61c9 30-Jun-2015 Chris Banes <chrisbanes@google.com> Fix memory leak in setActionProvider() - support edition

Caused by ActionMenuItem's SubUiVisibilityListener
not being nulled when it is replaced via setActionProvider().

BUG: 22189734

Change-Id: I1294fd44125db4271a081184fa59eb0935fd0986
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
6c72ea0134a3309ff8197f0862aad8d7bc712b55 15-Jun-2015 Yuichi Araki <yaraki@google.com> Fix SubMenu in NavigationView

This introduces new wrappers; NavigationMenu and NavigationSubMenu.
These are necessary to notify the top menu when its sub menu is changed.
https://code.google.com/p/android/issues/detail?id=176300

Change-Id: I1ea97880dfb0e0c1dee6426b3c528d6d60323063
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
937df84589168e159706463f25780f35ec63b750 28-Oct-2014 Chris Banes <chrisbanes@google.com> Workaround bug with EventLog.writeEvent + Spannables

Activity.onMenuItemSelected() calls EventLog.writeEvent()
with the menu item's condensed title. If the title is a
non-String CharSequence then writeEvent will throw an exception.

This was fixed in Activity for JB-MR2 so we need to workaround it
for devices before that.

BUG: 18072335
Change-Id: I6787170eabb2f840caa5e4e97663d835e06688b3
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
b37a31664b07243ca9e86c8dac58b9be6a417e8c 13-Sep-2014 Chris Banes <chrisbanes@google.com> Bundle tintable drawables for copy/cut/paste/select-all

BUG: 17262483
Change-Id: I6c82d39629ff2891c4be4593821ff90a4a6e428b
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
7fa6a00a4600aac591402398c23fea97721adf26 06-Aug-2014 Chris Banes <chrisbanes@google.com> Use ContextCompat.getDrawable(...) in appcompat

Fixes NPE in RippleDrawable. Also fixed appcompat's
ThemeOverlay styles on v21, as they led to cyclic
attrs which resulted in empty colors.

BUG: 16602748

Change-Id: I3dffbeff3f8280f816593af13bc3db666ed462fd
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
56261b25b9890dd44f04e0083c3ea9fde5455ebd 31-Jul-2014 Chris Banes <chrisbanes@google.com> Clarify exception messages in MenuItemImpl

Change-Id: I2c6a3f7c5cde23b3641b50b41c27ef3a90a3502e
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
49c78900da0d43140fb602431fb93212bd7f6c70 15-Jul-2014 Chris Banes <chrisbanes@google.com> Update internal Action Bar implementation to L

This CL brings all of the internal widgets and helpers
for the Action Bar up to date with L. We now only use the
unbundled ActionBar/ToolBar implementation. This is to ease
integration and make styling simpler.

Change-Id: I267c9ee90b5707d997910c57242e26130f2dbcf8
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
d713f4f0643a5f6409b431f643f1ad25dba6c22f 21-May-2013 Chris Banes <chrisbanes@google.com> Fix ActionProvider.isVisible() #8911267

- Hooked up Menu Item visibility with ActionProvider
visibility for v9 and below.
- Cleaned up wrapper code around ActionProvider:
- Move base ActionProviderWrapper code from HC to ICS
- Hooked up ActionProviderWrapperJB properly

Change-Id: Ib708f285784dbf0704989a1b258b96900c8b5e15
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
6e6abe6eb358db4c3932752249c8ac61dd3dab21 08-May-2013 Jeff Brown <jeffbrown@google.com> Fix several issues with menu wrappers.

The menu wrappers were being created for the wrong version due to
an upside-down if tree in the menu wrapper factory.

The action provider wrapper code was duplicated and failed to
propagate the visibility changed event correctly. The new JB
API bits were also mixed into the ICS bits.

Added @Override in a few places where it was absent.

Renamed MenuWrapper to MenuWrapperFactory to avoid confusion
in the subtype relation between it and the actual wrapper types.

Simplified the wrapper hierarchy by moving construction of
support wrapper types into this factory instead of having to
override individual createXXX methods on each wrapper type.
This means we can get rid of several types, a possible diamond
inheritance hierarchy involving MenuWrapperHC and SubMenuWrapperHC
and their subtypes and the maintenance hassle of having to update
four places whenever a new version specific subtype needs to
be added.

Added a SupportSubMenu interface type to complete the set
of defined interface types.

Fixed handling of null listeners in a few places.

Bug: 8175766
Change-Id: I8c164893a6025308751a8c05671945874fe047c4
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
34452b0d1034da026b8a1d6fe2fe4399844379d6 07-May-2013 Adam Powell <adamp@google.com> Support ActionProvider functionality from API 16

Add the API 16 ActionProvider methods regarding visibility changes to
appcompat.

Fix a previously introduced bug inflating ActionProviders.

Change-Id: Ieff63683af4515eaacd0a25fddd168a7e71006cd
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
30837f1095c803f332f4a1c3f0917c8afdd50156 24-Apr-2013 Adam Powell <adamp@google.com> API changes for support action bar menus

Refactor support action bar to use standard framework menu interfaces
instead of additional interfaces. This simplifies the API and results
in fewer disjoint callbacks which could make life difficult for
library authors.

SupportMenu/SupportMenuItem are now private implementation details of
the support lib rather than interfaces used directly by app
developers. Developers must use standard support shim *Compat classes
to access new methods, and these shims are now aware of
SupportMenu/SupportMenuItem and will do the right thing.

Fix up a few other general issues and bugs.

Change-Id: I833dce76485741b680bef84c1c0ed8d81ea57616
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java
da10fdd1400ecfd8d7f2e55651dd528d0614dfc5 19-Mar-2013 Jeff Brown <jeffbrown@google.com> Move appcompat library to v7 package.

Moved most of the options menu related functionality out of v4
support lib into appcompat where it belongs. These two libraries
have very different design philosophies and it is important that
they remain untangled.

The support action bar options menu is broken by this change but
will be fixed in later patches after some refactoring to more
fully express the facade-like nature of the appcompat library.

Collapsed the appcompat eclair, honeycomb and ics folders into
one src folder because the layering did not make any sense.
All of these folders were providing portions of the API.
The layering will be reconstructed and improved in later patches.

Moved implementation types into an internal package within appcompat
to prevent them from leaking into the API.

Changed the base package name to android.support.v7, similar
to the gridlayout support lib.

Bug: 8175766
Change-Id: I538cbe08310e63e96a2a9fed0b8636eeda530f2c
/frameworks/support/v7/appcompat/src/android/support/v7/internal/view/menu/MenuItemImpl.java