method_verifier.cc revision e5877a12c30afe10a5c6a1afaff7a47ef44a2a5f
1/* 2 * Copyright (C) 2011 The Android Open Source Project 3 * 4 * Licensed under the Apache License, Version 2.0 (the "License"); 5 * you may not use this file except in compliance with the License. 6 * You may obtain a copy of the License at 7 * 8 * http://www.apache.org/licenses/LICENSE-2.0 9 * 10 * Unless required by applicable law or agreed to in writing, software 11 * distributed under the License is distributed on an "AS IS" BASIS, 12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 13 * See the License for the specific language governing permissions and 14 * limitations under the License. 15 */ 16 17#include "method_verifier-inl.h" 18 19#include <iostream> 20 21#include "base/logging.h" 22#include "base/mutex-inl.h" 23#include "class_linker.h" 24#include "compiler_callbacks.h" 25#include "dex_file-inl.h" 26#include "dex_instruction-inl.h" 27#include "dex_instruction_visitor.h" 28#include "field_helper.h" 29#include "gc/accounting/card_table-inl.h" 30#include "indenter.h" 31#include "intern_table.h" 32#include "leb128.h" 33#include "method_helper-inl.h" 34#include "mirror/art_field-inl.h" 35#include "mirror/art_method-inl.h" 36#include "mirror/class.h" 37#include "mirror/class-inl.h" 38#include "mirror/dex_cache-inl.h" 39#include "mirror/object-inl.h" 40#include "mirror/object_array-inl.h" 41#include "register_line-inl.h" 42#include "runtime.h" 43#include "scoped_thread_state_change.h" 44#include "handle_scope-inl.h" 45#include "verifier/dex_gc_map.h" 46 47namespace art { 48namespace verifier { 49 50static constexpr bool gDebugVerify = false; 51// TODO: Add a constant to method_verifier to turn on verbose logging? 52 53void PcToRegisterLineTable::Init(RegisterTrackingMode mode, InstructionFlags* flags, 54 uint32_t insns_size, uint16_t registers_size, 55 MethodVerifier* verifier) { 56 DCHECK_GT(insns_size, 0U); 57 register_lines_.reset(new RegisterLine*[insns_size]()); 58 size_ = insns_size; 59 for (uint32_t i = 0; i < insns_size; i++) { 60 bool interesting = false; 61 switch (mode) { 62 case kTrackRegsAll: 63 interesting = flags[i].IsOpcode(); 64 break; 65 case kTrackCompilerInterestPoints: 66 interesting = flags[i].IsCompileTimeInfoPoint() || flags[i].IsBranchTarget(); 67 break; 68 case kTrackRegsBranches: 69 interesting = flags[i].IsBranchTarget(); 70 break; 71 default: 72 break; 73 } 74 if (interesting) { 75 register_lines_[i] = RegisterLine::Create(registers_size, verifier); 76 } 77 } 78} 79 80PcToRegisterLineTable::~PcToRegisterLineTable() { 81 for (size_t i = 0; i < size_; i++) { 82 delete register_lines_[i]; 83 if (kIsDebugBuild) { 84 register_lines_[i] = nullptr; 85 } 86 } 87} 88 89MethodVerifier::FailureKind MethodVerifier::VerifyClass(mirror::Class* klass, 90 bool allow_soft_failures, 91 std::string* error) { 92 if (klass->IsVerified()) { 93 return kNoFailure; 94 } 95 bool early_failure = false; 96 std::string failure_message; 97 const DexFile& dex_file = klass->GetDexFile(); 98 const DexFile::ClassDef* class_def = klass->GetClassDef(); 99 mirror::Class* super = klass->GetSuperClass(); 100 if (super == NULL && "Ljava/lang/Object;" != klass->GetDescriptor()) { 101 early_failure = true; 102 failure_message = " that has no super class"; 103 } else if (super != NULL && super->IsFinal()) { 104 early_failure = true; 105 failure_message = " that attempts to sub-class final class " + PrettyDescriptor(super); 106 } else if (class_def == NULL) { 107 early_failure = true; 108 failure_message = " that isn't present in dex file " + dex_file.GetLocation(); 109 } 110 if (early_failure) { 111 *error = "Verifier rejected class " + PrettyDescriptor(klass) + failure_message; 112 if (Runtime::Current()->IsCompiler()) { 113 ClassReference ref(&dex_file, klass->GetDexClassDefIndex()); 114 Runtime::Current()->GetCompilerCallbacks()->ClassRejected(ref); 115 } 116 return kHardFailure; 117 } 118 StackHandleScope<2> hs(Thread::Current()); 119 Handle<mirror::DexCache> dex_cache(hs.NewHandle(klass->GetDexCache())); 120 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(klass->GetClassLoader())); 121 return VerifyClass(&dex_file, dex_cache, class_loader, class_def, allow_soft_failures, error); 122} 123 124MethodVerifier::FailureKind MethodVerifier::VerifyClass(const DexFile* dex_file, 125 Handle<mirror::DexCache> dex_cache, 126 Handle<mirror::ClassLoader> class_loader, 127 const DexFile::ClassDef* class_def, 128 bool allow_soft_failures, 129 std::string* error) { 130 DCHECK(class_def != nullptr); 131 const byte* class_data = dex_file->GetClassData(*class_def); 132 if (class_data == NULL) { 133 // empty class, probably a marker interface 134 return kNoFailure; 135 } 136 ClassDataItemIterator it(*dex_file, class_data); 137 while (it.HasNextStaticField() || it.HasNextInstanceField()) { 138 it.Next(); 139 } 140 size_t error_count = 0; 141 bool hard_fail = false; 142 ClassLinker* linker = Runtime::Current()->GetClassLinker(); 143 int64_t previous_direct_method_idx = -1; 144 while (it.HasNextDirectMethod()) { 145 uint32_t method_idx = it.GetMemberIndex(); 146 if (method_idx == previous_direct_method_idx) { 147 // smali can create dex files with two encoded_methods sharing the same method_idx 148 // http://code.google.com/p/smali/issues/detail?id=119 149 it.Next(); 150 continue; 151 } 152 previous_direct_method_idx = method_idx; 153 InvokeType type = it.GetMethodInvokeType(*class_def); 154 mirror::ArtMethod* method = 155 linker->ResolveMethod(*dex_file, method_idx, dex_cache, class_loader, 156 NullHandle<mirror::ArtMethod>(), type); 157 if (method == NULL) { 158 DCHECK(Thread::Current()->IsExceptionPending()); 159 // We couldn't resolve the method, but continue regardless. 160 Thread::Current()->ClearException(); 161 } 162 MethodVerifier::FailureKind result = VerifyMethod(method_idx, 163 dex_file, 164 dex_cache, 165 class_loader, 166 class_def, 167 it.GetMethodCodeItem(), 168 method, 169 it.GetMemberAccessFlags(), 170 allow_soft_failures, 171 false); 172 if (result != kNoFailure) { 173 if (result == kHardFailure) { 174 hard_fail = true; 175 if (error_count > 0) { 176 *error += "\n"; 177 } 178 *error = "Verifier rejected class "; 179 *error += PrettyDescriptor(dex_file->GetClassDescriptor(*class_def)); 180 *error += " due to bad method "; 181 *error += PrettyMethod(method_idx, *dex_file); 182 } 183 ++error_count; 184 } 185 it.Next(); 186 } 187 int64_t previous_virtual_method_idx = -1; 188 while (it.HasNextVirtualMethod()) { 189 uint32_t method_idx = it.GetMemberIndex(); 190 if (method_idx == previous_virtual_method_idx) { 191 // smali can create dex files with two encoded_methods sharing the same method_idx 192 // http://code.google.com/p/smali/issues/detail?id=119 193 it.Next(); 194 continue; 195 } 196 previous_virtual_method_idx = method_idx; 197 InvokeType type = it.GetMethodInvokeType(*class_def); 198 mirror::ArtMethod* method = 199 linker->ResolveMethod(*dex_file, method_idx, dex_cache, class_loader, 200 NullHandle<mirror::ArtMethod>(), type); 201 if (method == NULL) { 202 DCHECK(Thread::Current()->IsExceptionPending()); 203 // We couldn't resolve the method, but continue regardless. 204 Thread::Current()->ClearException(); 205 } 206 MethodVerifier::FailureKind result = VerifyMethod(method_idx, 207 dex_file, 208 dex_cache, 209 class_loader, 210 class_def, 211 it.GetMethodCodeItem(), 212 method, 213 it.GetMemberAccessFlags(), 214 allow_soft_failures, 215 false); 216 if (result != kNoFailure) { 217 if (result == kHardFailure) { 218 hard_fail = true; 219 if (error_count > 0) { 220 *error += "\n"; 221 } 222 *error = "Verifier rejected class "; 223 *error += PrettyDescriptor(dex_file->GetClassDescriptor(*class_def)); 224 *error += " due to bad method "; 225 *error += PrettyMethod(method_idx, *dex_file); 226 } 227 ++error_count; 228 } 229 it.Next(); 230 } 231 if (error_count == 0) { 232 return kNoFailure; 233 } else { 234 return hard_fail ? kHardFailure : kSoftFailure; 235 } 236} 237 238MethodVerifier::FailureKind MethodVerifier::VerifyMethod(uint32_t method_idx, 239 const DexFile* dex_file, 240 Handle<mirror::DexCache> dex_cache, 241 Handle<mirror::ClassLoader> class_loader, 242 const DexFile::ClassDef* class_def, 243 const DexFile::CodeItem* code_item, 244 mirror::ArtMethod* method, 245 uint32_t method_access_flags, 246 bool allow_soft_failures, 247 bool need_precise_constants) { 248 MethodVerifier::FailureKind result = kNoFailure; 249 uint64_t start_ns = NanoTime(); 250 251 MethodVerifier verifier(dex_file, &dex_cache, &class_loader, class_def, code_item, 252 method_idx, method, method_access_flags, true, allow_soft_failures, 253 need_precise_constants); 254 if (verifier.Verify()) { 255 // Verification completed, however failures may be pending that didn't cause the verification 256 // to hard fail. 257 CHECK(!verifier.have_pending_hard_failure_); 258 if (verifier.failures_.size() != 0) { 259 if (VLOG_IS_ON(verifier)) { 260 verifier.DumpFailures(VLOG_STREAM(verifier) << "Soft verification failures in " 261 << PrettyMethod(method_idx, *dex_file) << "\n"); 262 } 263 result = kSoftFailure; 264 } 265 } else { 266 // Bad method data. 267 CHECK_NE(verifier.failures_.size(), 0U); 268 CHECK(verifier.have_pending_hard_failure_); 269 verifier.DumpFailures(LOG(INFO) << "Verification error in " 270 << PrettyMethod(method_idx, *dex_file) << "\n"); 271 if (gDebugVerify) { 272 std::cout << "\n" << verifier.info_messages_.str(); 273 verifier.Dump(std::cout); 274 } 275 result = kHardFailure; 276 } 277 uint64_t duration_ns = NanoTime() - start_ns; 278 if (duration_ns > MsToNs(100) && !kIsDebugBuild) { 279 LOG(WARNING) << "Verification of " << PrettyMethod(method_idx, *dex_file) 280 << " took " << PrettyDuration(duration_ns); 281 } 282 return result; 283} 284 285void MethodVerifier::VerifyMethodAndDump(std::ostream& os, uint32_t dex_method_idx, 286 const DexFile* dex_file, 287 Handle<mirror::DexCache> dex_cache, 288 Handle<mirror::ClassLoader> class_loader, 289 const DexFile::ClassDef* class_def, 290 const DexFile::CodeItem* code_item, 291 mirror::ArtMethod* method, 292 uint32_t method_access_flags) { 293 MethodVerifier verifier(dex_file, &dex_cache, &class_loader, class_def, code_item, 294 dex_method_idx, method, method_access_flags, true, true, true); 295 verifier.Verify(); 296 verifier.DumpFailures(os); 297 os << verifier.info_messages_.str(); 298 verifier.Dump(os); 299} 300 301MethodVerifier::MethodVerifier(const DexFile* dex_file, Handle<mirror::DexCache>* dex_cache, 302 Handle<mirror::ClassLoader>* class_loader, 303 const DexFile::ClassDef* class_def, 304 const DexFile::CodeItem* code_item, uint32_t dex_method_idx, 305 mirror::ArtMethod* method, uint32_t method_access_flags, 306 bool can_load_classes, bool allow_soft_failures, 307 bool need_precise_constants) 308 : reg_types_(can_load_classes), 309 work_insn_idx_(-1), 310 dex_method_idx_(dex_method_idx), 311 mirror_method_(method), 312 method_access_flags_(method_access_flags), 313 return_type_(nullptr), 314 dex_file_(dex_file), 315 dex_cache_(dex_cache), 316 class_loader_(class_loader), 317 class_def_(class_def), 318 code_item_(code_item), 319 declaring_class_(NULL), 320 interesting_dex_pc_(-1), 321 monitor_enter_dex_pcs_(nullptr), 322 have_pending_hard_failure_(false), 323 have_pending_runtime_throw_failure_(false), 324 new_instance_count_(0), 325 monitor_enter_count_(0), 326 can_load_classes_(can_load_classes), 327 allow_soft_failures_(allow_soft_failures), 328 need_precise_constants_(need_precise_constants), 329 has_check_casts_(false), 330 has_virtual_or_interface_invokes_(false) { 331 Runtime::Current()->AddMethodVerifier(this); 332 DCHECK(class_def != nullptr); 333} 334 335MethodVerifier::~MethodVerifier() { 336 Runtime::Current()->RemoveMethodVerifier(this); 337 STLDeleteElements(&failure_messages_); 338} 339 340void MethodVerifier::FindLocksAtDexPc(mirror::ArtMethod* m, uint32_t dex_pc, 341 std::vector<uint32_t>* monitor_enter_dex_pcs) { 342 StackHandleScope<2> hs(Thread::Current()); 343 Handle<mirror::DexCache> dex_cache(hs.NewHandle(m->GetDexCache())); 344 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(m->GetClassLoader())); 345 MethodVerifier verifier(m->GetDexFile(), &dex_cache, &class_loader, &m->GetClassDef(), 346 m->GetCodeItem(), m->GetDexMethodIndex(), m, m->GetAccessFlags(), false, 347 true, false); 348 verifier.interesting_dex_pc_ = dex_pc; 349 verifier.monitor_enter_dex_pcs_ = monitor_enter_dex_pcs; 350 verifier.FindLocksAtDexPc(); 351} 352 353void MethodVerifier::FindLocksAtDexPc() { 354 CHECK(monitor_enter_dex_pcs_ != NULL); 355 CHECK(code_item_ != NULL); // This only makes sense for methods with code. 356 357 // Strictly speaking, we ought to be able to get away with doing a subset of the full method 358 // verification. In practice, the phase we want relies on data structures set up by all the 359 // earlier passes, so we just run the full method verification and bail out early when we've 360 // got what we wanted. 361 Verify(); 362} 363 364mirror::ArtField* MethodVerifier::FindAccessedFieldAtDexPc(mirror::ArtMethod* m, 365 uint32_t dex_pc) { 366 StackHandleScope<2> hs(Thread::Current()); 367 Handle<mirror::DexCache> dex_cache(hs.NewHandle(m->GetDexCache())); 368 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(m->GetClassLoader())); 369 MethodVerifier verifier(m->GetDexFile(), &dex_cache, &class_loader, &m->GetClassDef(), 370 m->GetCodeItem(), m->GetDexMethodIndex(), m, m->GetAccessFlags(), true, 371 true, false); 372 return verifier.FindAccessedFieldAtDexPc(dex_pc); 373} 374 375mirror::ArtField* MethodVerifier::FindAccessedFieldAtDexPc(uint32_t dex_pc) { 376 CHECK(code_item_ != NULL); // This only makes sense for methods with code. 377 378 // Strictly speaking, we ought to be able to get away with doing a subset of the full method 379 // verification. In practice, the phase we want relies on data structures set up by all the 380 // earlier passes, so we just run the full method verification and bail out early when we've 381 // got what we wanted. 382 bool success = Verify(); 383 if (!success) { 384 return nullptr; 385 } 386 RegisterLine* register_line = reg_table_.GetLine(dex_pc); 387 if (register_line == NULL) { 388 return nullptr; 389 } 390 const Instruction* inst = Instruction::At(code_item_->insns_ + dex_pc); 391 return GetQuickFieldAccess(inst, register_line); 392} 393 394mirror::ArtMethod* MethodVerifier::FindInvokedMethodAtDexPc(mirror::ArtMethod* m, 395 uint32_t dex_pc) { 396 StackHandleScope<2> hs(Thread::Current()); 397 Handle<mirror::DexCache> dex_cache(hs.NewHandle(m->GetDexCache())); 398 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(m->GetClassLoader())); 399 MethodVerifier verifier(m->GetDexFile(), &dex_cache, &class_loader, &m->GetClassDef(), 400 m->GetCodeItem(), m->GetDexMethodIndex(), m, m->GetAccessFlags(), true, 401 true, false); 402 return verifier.FindInvokedMethodAtDexPc(dex_pc); 403} 404 405mirror::ArtMethod* MethodVerifier::FindInvokedMethodAtDexPc(uint32_t dex_pc) { 406 CHECK(code_item_ != NULL); // This only makes sense for methods with code. 407 408 // Strictly speaking, we ought to be able to get away with doing a subset of the full method 409 // verification. In practice, the phase we want relies on data structures set up by all the 410 // earlier passes, so we just run the full method verification and bail out early when we've 411 // got what we wanted. 412 bool success = Verify(); 413 if (!success) { 414 return NULL; 415 } 416 RegisterLine* register_line = reg_table_.GetLine(dex_pc); 417 if (register_line == NULL) { 418 return NULL; 419 } 420 const Instruction* inst = Instruction::At(code_item_->insns_ + dex_pc); 421 const bool is_range = (inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK); 422 return GetQuickInvokedMethod(inst, register_line, is_range); 423} 424 425bool MethodVerifier::Verify() { 426 // If there aren't any instructions, make sure that's expected, then exit successfully. 427 if (code_item_ == NULL) { 428 if ((method_access_flags_ & (kAccNative | kAccAbstract)) == 0) { 429 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "zero-length code in concrete non-native method"; 430 return false; 431 } else { 432 return true; 433 } 434 } 435 // Sanity-check the register counts. ins + locals = registers, so make sure that ins <= registers. 436 if (code_item_->ins_size_ > code_item_->registers_size_) { 437 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad register counts (ins=" << code_item_->ins_size_ 438 << " regs=" << code_item_->registers_size_; 439 return false; 440 } 441 // Allocate and initialize an array to hold instruction data. 442 insn_flags_.reset(new InstructionFlags[code_item_->insns_size_in_code_units_]()); 443 // Run through the instructions and see if the width checks out. 444 bool result = ComputeWidthsAndCountOps(); 445 // Flag instructions guarded by a "try" block and check exception handlers. 446 result = result && ScanTryCatchBlocks(); 447 // Perform static instruction verification. 448 result = result && VerifyInstructions(); 449 // Perform code-flow analysis and return. 450 result = result && VerifyCodeFlow(); 451 // Compute information for compiler. 452 if (result && Runtime::Current()->IsCompiler()) { 453 result = Runtime::Current()->GetCompilerCallbacks()->MethodVerified(this); 454 } 455 return result; 456} 457 458std::ostream& MethodVerifier::Fail(VerifyError error) { 459 switch (error) { 460 case VERIFY_ERROR_NO_CLASS: 461 case VERIFY_ERROR_NO_FIELD: 462 case VERIFY_ERROR_NO_METHOD: 463 case VERIFY_ERROR_ACCESS_CLASS: 464 case VERIFY_ERROR_ACCESS_FIELD: 465 case VERIFY_ERROR_ACCESS_METHOD: 466 case VERIFY_ERROR_INSTANTIATION: 467 case VERIFY_ERROR_CLASS_CHANGE: 468 if (Runtime::Current()->IsCompiler() || !can_load_classes_) { 469 // If we're optimistically running verification at compile time, turn NO_xxx, ACCESS_xxx, 470 // class change and instantiation errors into soft verification errors so that we re-verify 471 // at runtime. We may fail to find or to agree on access because of not yet available class 472 // loaders, or class loaders that will differ at runtime. In these cases, we don't want to 473 // affect the soundness of the code being compiled. Instead, the generated code runs "slow 474 // paths" that dynamically perform the verification and cause the behavior to be that akin 475 // to an interpreter. 476 error = VERIFY_ERROR_BAD_CLASS_SOFT; 477 } else { 478 // If we fail again at runtime, mark that this instruction would throw and force this 479 // method to be executed using the interpreter with checks. 480 have_pending_runtime_throw_failure_ = true; 481 } 482 break; 483 // Indication that verification should be retried at runtime. 484 case VERIFY_ERROR_BAD_CLASS_SOFT: 485 if (!allow_soft_failures_) { 486 have_pending_hard_failure_ = true; 487 } 488 break; 489 // Hard verification failures at compile time will still fail at runtime, so the class is 490 // marked as rejected to prevent it from being compiled. 491 case VERIFY_ERROR_BAD_CLASS_HARD: { 492 if (Runtime::Current()->IsCompiler()) { 493 ClassReference ref(dex_file_, dex_file_->GetIndexForClassDef(*class_def_)); 494 Runtime::Current()->GetCompilerCallbacks()->ClassRejected(ref); 495 } 496 have_pending_hard_failure_ = true; 497 break; 498 } 499 } 500 failures_.push_back(error); 501 std::string location(StringPrintf("%s: [0x%X]", PrettyMethod(dex_method_idx_, *dex_file_).c_str(), 502 work_insn_idx_)); 503 std::ostringstream* failure_message = new std::ostringstream(location); 504 failure_messages_.push_back(failure_message); 505 return *failure_message; 506} 507 508std::ostream& MethodVerifier::LogVerifyInfo() { 509 return info_messages_ << "VFY: " << PrettyMethod(dex_method_idx_, *dex_file_) 510 << '[' << reinterpret_cast<void*>(work_insn_idx_) << "] : "; 511} 512 513void MethodVerifier::PrependToLastFailMessage(std::string prepend) { 514 size_t failure_num = failure_messages_.size(); 515 DCHECK_NE(failure_num, 0U); 516 std::ostringstream* last_fail_message = failure_messages_[failure_num - 1]; 517 prepend += last_fail_message->str(); 518 failure_messages_[failure_num - 1] = new std::ostringstream(prepend); 519 delete last_fail_message; 520} 521 522void MethodVerifier::AppendToLastFailMessage(std::string append) { 523 size_t failure_num = failure_messages_.size(); 524 DCHECK_NE(failure_num, 0U); 525 std::ostringstream* last_fail_message = failure_messages_[failure_num - 1]; 526 (*last_fail_message) << append; 527} 528 529bool MethodVerifier::ComputeWidthsAndCountOps() { 530 const uint16_t* insns = code_item_->insns_; 531 size_t insns_size = code_item_->insns_size_in_code_units_; 532 const Instruction* inst = Instruction::At(insns); 533 size_t new_instance_count = 0; 534 size_t monitor_enter_count = 0; 535 size_t dex_pc = 0; 536 537 while (dex_pc < insns_size) { 538 Instruction::Code opcode = inst->Opcode(); 539 switch (opcode) { 540 case Instruction::APUT_OBJECT: 541 case Instruction::CHECK_CAST: 542 has_check_casts_ = true; 543 break; 544 case Instruction::INVOKE_VIRTUAL: 545 case Instruction::INVOKE_VIRTUAL_RANGE: 546 case Instruction::INVOKE_INTERFACE: 547 case Instruction::INVOKE_INTERFACE_RANGE: 548 has_virtual_or_interface_invokes_ = true; 549 break; 550 case Instruction::MONITOR_ENTER: 551 monitor_enter_count++; 552 break; 553 case Instruction::NEW_INSTANCE: 554 new_instance_count++; 555 break; 556 default: 557 break; 558 } 559 size_t inst_size = inst->SizeInCodeUnits(); 560 insn_flags_[dex_pc].SetLengthInCodeUnits(inst_size); 561 dex_pc += inst_size; 562 inst = inst->Next(); 563 } 564 565 if (dex_pc != insns_size) { 566 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "code did not end where expected (" 567 << dex_pc << " vs. " << insns_size << ")"; 568 return false; 569 } 570 571 new_instance_count_ = new_instance_count; 572 monitor_enter_count_ = monitor_enter_count; 573 return true; 574} 575 576bool MethodVerifier::ScanTryCatchBlocks() { 577 uint32_t tries_size = code_item_->tries_size_; 578 if (tries_size == 0) { 579 return true; 580 } 581 uint32_t insns_size = code_item_->insns_size_in_code_units_; 582 const DexFile::TryItem* tries = DexFile::GetTryItems(*code_item_, 0); 583 584 for (uint32_t idx = 0; idx < tries_size; idx++) { 585 const DexFile::TryItem* try_item = &tries[idx]; 586 uint32_t start = try_item->start_addr_; 587 uint32_t end = start + try_item->insn_count_; 588 if ((start >= end) || (start >= insns_size) || (end > insns_size)) { 589 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad exception entry: startAddr=" << start 590 << " endAddr=" << end << " (size=" << insns_size << ")"; 591 return false; 592 } 593 if (!insn_flags_[start].IsOpcode()) { 594 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 595 << "'try' block starts inside an instruction (" << start << ")"; 596 return false; 597 } 598 for (uint32_t dex_pc = start; dex_pc < end; 599 dex_pc += insn_flags_[dex_pc].GetLengthInCodeUnits()) { 600 insn_flags_[dex_pc].SetInTry(); 601 } 602 } 603 // Iterate over each of the handlers to verify target addresses. 604 const byte* handlers_ptr = DexFile::GetCatchHandlerData(*code_item_, 0); 605 uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr); 606 ClassLinker* linker = Runtime::Current()->GetClassLinker(); 607 for (uint32_t idx = 0; idx < handlers_size; idx++) { 608 CatchHandlerIterator iterator(handlers_ptr); 609 for (; iterator.HasNext(); iterator.Next()) { 610 uint32_t dex_pc= iterator.GetHandlerAddress(); 611 if (!insn_flags_[dex_pc].IsOpcode()) { 612 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 613 << "exception handler starts at bad address (" << dex_pc << ")"; 614 return false; 615 } 616 insn_flags_[dex_pc].SetBranchTarget(); 617 // Ensure exception types are resolved so that they don't need resolution to be delivered, 618 // unresolved exception types will be ignored by exception delivery 619 if (iterator.GetHandlerTypeIndex() != DexFile::kDexNoIndex16) { 620 mirror::Class* exception_type = linker->ResolveType(*dex_file_, 621 iterator.GetHandlerTypeIndex(), 622 *dex_cache_, *class_loader_); 623 if (exception_type == NULL) { 624 DCHECK(Thread::Current()->IsExceptionPending()); 625 Thread::Current()->ClearException(); 626 } 627 } 628 } 629 handlers_ptr = iterator.EndDataPointer(); 630 } 631 return true; 632} 633 634bool MethodVerifier::VerifyInstructions() { 635 const Instruction* inst = Instruction::At(code_item_->insns_); 636 637 /* Flag the start of the method as a branch target, and a GC point due to stack overflow errors */ 638 insn_flags_[0].SetBranchTarget(); 639 insn_flags_[0].SetCompileTimeInfoPoint(); 640 641 uint32_t insns_size = code_item_->insns_size_in_code_units_; 642 for (uint32_t dex_pc = 0; dex_pc < insns_size;) { 643 if (!VerifyInstruction(inst, dex_pc)) { 644 DCHECK_NE(failures_.size(), 0U); 645 return false; 646 } 647 /* Flag instructions that are garbage collection points */ 648 // All invoke points are marked as "Throw" points already. 649 // We are relying on this to also count all the invokes as interesting. 650 if (inst->IsBranch() || inst->IsSwitch() || inst->IsThrow()) { 651 insn_flags_[dex_pc].SetCompileTimeInfoPoint(); 652 } else if (inst->IsReturn()) { 653 insn_flags_[dex_pc].SetCompileTimeInfoPointAndReturn(); 654 } 655 dex_pc += inst->SizeInCodeUnits(); 656 inst = inst->Next(); 657 } 658 return true; 659} 660 661bool MethodVerifier::VerifyInstruction(const Instruction* inst, uint32_t code_offset) { 662 bool result = true; 663 switch (inst->GetVerifyTypeArgumentA()) { 664 case Instruction::kVerifyRegA: 665 result = result && CheckRegisterIndex(inst->VRegA()); 666 break; 667 case Instruction::kVerifyRegAWide: 668 result = result && CheckWideRegisterIndex(inst->VRegA()); 669 break; 670 } 671 switch (inst->GetVerifyTypeArgumentB()) { 672 case Instruction::kVerifyRegB: 673 result = result && CheckRegisterIndex(inst->VRegB()); 674 break; 675 case Instruction::kVerifyRegBField: 676 result = result && CheckFieldIndex(inst->VRegB()); 677 break; 678 case Instruction::kVerifyRegBMethod: 679 result = result && CheckMethodIndex(inst->VRegB()); 680 break; 681 case Instruction::kVerifyRegBNewInstance: 682 result = result && CheckNewInstance(inst->VRegB()); 683 break; 684 case Instruction::kVerifyRegBString: 685 result = result && CheckStringIndex(inst->VRegB()); 686 break; 687 case Instruction::kVerifyRegBType: 688 result = result && CheckTypeIndex(inst->VRegB()); 689 break; 690 case Instruction::kVerifyRegBWide: 691 result = result && CheckWideRegisterIndex(inst->VRegB()); 692 break; 693 } 694 switch (inst->GetVerifyTypeArgumentC()) { 695 case Instruction::kVerifyRegC: 696 result = result && CheckRegisterIndex(inst->VRegC()); 697 break; 698 case Instruction::kVerifyRegCField: 699 result = result && CheckFieldIndex(inst->VRegC()); 700 break; 701 case Instruction::kVerifyRegCNewArray: 702 result = result && CheckNewArray(inst->VRegC()); 703 break; 704 case Instruction::kVerifyRegCType: 705 result = result && CheckTypeIndex(inst->VRegC()); 706 break; 707 case Instruction::kVerifyRegCWide: 708 result = result && CheckWideRegisterIndex(inst->VRegC()); 709 break; 710 } 711 switch (inst->GetVerifyExtraFlags()) { 712 case Instruction::kVerifyArrayData: 713 result = result && CheckArrayData(code_offset); 714 break; 715 case Instruction::kVerifyBranchTarget: 716 result = result && CheckBranchTarget(code_offset); 717 break; 718 case Instruction::kVerifySwitchTargets: 719 result = result && CheckSwitchTargets(code_offset); 720 break; 721 case Instruction::kVerifyVarArgNonZero: 722 // Fall-through. 723 case Instruction::kVerifyVarArg: { 724 if (inst->GetVerifyExtraFlags() == Instruction::kVerifyVarArgNonZero && inst->VRegA() <= 0) { 725 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid arg count (" << inst->VRegA() << ") in " 726 "non-range invoke"; 727 return false; 728 } 729 uint32_t args[Instruction::kMaxVarArgRegs]; 730 inst->GetVarArgs(args); 731 result = result && CheckVarArgRegs(inst->VRegA(), args); 732 break; 733 } 734 case Instruction::kVerifyVarArgRangeNonZero: 735 // Fall-through. 736 case Instruction::kVerifyVarArgRange: 737 if (inst->GetVerifyExtraFlags() == Instruction::kVerifyVarArgRangeNonZero && 738 inst->VRegA() <= 0) { 739 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid arg count (" << inst->VRegA() << ") in " 740 "range invoke"; 741 return false; 742 } 743 result = result && CheckVarArgRangeRegs(inst->VRegA(), inst->VRegC()); 744 break; 745 case Instruction::kVerifyError: 746 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected opcode " << inst->Name(); 747 result = false; 748 break; 749 } 750 if (inst->GetVerifyIsRuntimeOnly() && Runtime::Current()->IsCompiler()) { 751 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "opcode only expected at runtime " << inst->Name(); 752 result = false; 753 } 754 return result; 755} 756 757bool MethodVerifier::CheckRegisterIndex(uint32_t idx) { 758 if (idx >= code_item_->registers_size_) { 759 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "register index out of range (" << idx << " >= " 760 << code_item_->registers_size_ << ")"; 761 return false; 762 } 763 return true; 764} 765 766bool MethodVerifier::CheckWideRegisterIndex(uint32_t idx) { 767 if (idx + 1 >= code_item_->registers_size_) { 768 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "wide register index out of range (" << idx 769 << "+1 >= " << code_item_->registers_size_ << ")"; 770 return false; 771 } 772 return true; 773} 774 775bool MethodVerifier::CheckFieldIndex(uint32_t idx) { 776 if (idx >= dex_file_->GetHeader().field_ids_size_) { 777 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad field index " << idx << " (max " 778 << dex_file_->GetHeader().field_ids_size_ << ")"; 779 return false; 780 } 781 return true; 782} 783 784bool MethodVerifier::CheckMethodIndex(uint32_t idx) { 785 if (idx >= dex_file_->GetHeader().method_ids_size_) { 786 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad method index " << idx << " (max " 787 << dex_file_->GetHeader().method_ids_size_ << ")"; 788 return false; 789 } 790 return true; 791} 792 793bool MethodVerifier::CheckNewInstance(uint32_t idx) { 794 if (idx >= dex_file_->GetHeader().type_ids_size_) { 795 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad type index " << idx << " (max " 796 << dex_file_->GetHeader().type_ids_size_ << ")"; 797 return false; 798 } 799 // We don't need the actual class, just a pointer to the class name. 800 const char* descriptor = dex_file_->StringByTypeIdx(idx); 801 if (descriptor[0] != 'L') { 802 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "can't call new-instance on type '" << descriptor << "'"; 803 return false; 804 } 805 return true; 806} 807 808bool MethodVerifier::CheckStringIndex(uint32_t idx) { 809 if (idx >= dex_file_->GetHeader().string_ids_size_) { 810 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad string index " << idx << " (max " 811 << dex_file_->GetHeader().string_ids_size_ << ")"; 812 return false; 813 } 814 return true; 815} 816 817bool MethodVerifier::CheckTypeIndex(uint32_t idx) { 818 if (idx >= dex_file_->GetHeader().type_ids_size_) { 819 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad type index " << idx << " (max " 820 << dex_file_->GetHeader().type_ids_size_ << ")"; 821 return false; 822 } 823 return true; 824} 825 826bool MethodVerifier::CheckNewArray(uint32_t idx) { 827 if (idx >= dex_file_->GetHeader().type_ids_size_) { 828 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad type index " << idx << " (max " 829 << dex_file_->GetHeader().type_ids_size_ << ")"; 830 return false; 831 } 832 int bracket_count = 0; 833 const char* descriptor = dex_file_->StringByTypeIdx(idx); 834 const char* cp = descriptor; 835 while (*cp++ == '[') { 836 bracket_count++; 837 } 838 if (bracket_count == 0) { 839 /* The given class must be an array type. */ 840 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 841 << "can't new-array class '" << descriptor << "' (not an array)"; 842 return false; 843 } else if (bracket_count > 255) { 844 /* It is illegal to create an array of more than 255 dimensions. */ 845 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 846 << "can't new-array class '" << descriptor << "' (exceeds limit)"; 847 return false; 848 } 849 return true; 850} 851 852bool MethodVerifier::CheckArrayData(uint32_t cur_offset) { 853 const uint32_t insn_count = code_item_->insns_size_in_code_units_; 854 const uint16_t* insns = code_item_->insns_ + cur_offset; 855 const uint16_t* array_data; 856 int32_t array_data_offset; 857 858 DCHECK_LT(cur_offset, insn_count); 859 /* make sure the start of the array data table is in range */ 860 array_data_offset = insns[1] | (((int32_t) insns[2]) << 16); 861 if ((int32_t) cur_offset + array_data_offset < 0 || 862 cur_offset + array_data_offset + 2 >= insn_count) { 863 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid array data start: at " << cur_offset 864 << ", data offset " << array_data_offset 865 << ", count " << insn_count; 866 return false; 867 } 868 /* offset to array data table is a relative branch-style offset */ 869 array_data = insns + array_data_offset; 870 /* make sure the table is 32-bit aligned */ 871 if ((reinterpret_cast<uintptr_t>(array_data) & 0x03) != 0) { 872 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unaligned array data table: at " << cur_offset 873 << ", data offset " << array_data_offset; 874 return false; 875 } 876 uint32_t value_width = array_data[1]; 877 uint32_t value_count = *reinterpret_cast<const uint32_t*>(&array_data[2]); 878 uint32_t table_size = 4 + (value_width * value_count + 1) / 2; 879 /* make sure the end of the switch is in range */ 880 if (cur_offset + array_data_offset + table_size > insn_count) { 881 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid array data end: at " << cur_offset 882 << ", data offset " << array_data_offset << ", end " 883 << cur_offset + array_data_offset + table_size 884 << ", count " << insn_count; 885 return false; 886 } 887 return true; 888} 889 890bool MethodVerifier::CheckBranchTarget(uint32_t cur_offset) { 891 int32_t offset; 892 bool isConditional, selfOkay; 893 if (!GetBranchOffset(cur_offset, &offset, &isConditional, &selfOkay)) { 894 return false; 895 } 896 if (!selfOkay && offset == 0) { 897 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "branch offset of zero not allowed at" 898 << reinterpret_cast<void*>(cur_offset); 899 return false; 900 } 901 // Check for 32-bit overflow. This isn't strictly necessary if we can depend on the runtime 902 // to have identical "wrap-around" behavior, but it's unwise to depend on that. 903 if (((int64_t) cur_offset + (int64_t) offset) != (int64_t) (cur_offset + offset)) { 904 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "branch target overflow " 905 << reinterpret_cast<void*>(cur_offset) << " +" << offset; 906 return false; 907 } 908 const uint32_t insn_count = code_item_->insns_size_in_code_units_; 909 int32_t abs_offset = cur_offset + offset; 910 if (abs_offset < 0 || 911 (uint32_t) abs_offset >= insn_count || 912 !insn_flags_[abs_offset].IsOpcode()) { 913 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid branch target " << offset << " (-> " 914 << reinterpret_cast<void*>(abs_offset) << ") at " 915 << reinterpret_cast<void*>(cur_offset); 916 return false; 917 } 918 insn_flags_[abs_offset].SetBranchTarget(); 919 return true; 920} 921 922bool MethodVerifier::GetBranchOffset(uint32_t cur_offset, int32_t* pOffset, bool* pConditional, 923 bool* selfOkay) { 924 const uint16_t* insns = code_item_->insns_ + cur_offset; 925 *pConditional = false; 926 *selfOkay = false; 927 switch (*insns & 0xff) { 928 case Instruction::GOTO: 929 *pOffset = ((int16_t) *insns) >> 8; 930 break; 931 case Instruction::GOTO_32: 932 *pOffset = insns[1] | (((uint32_t) insns[2]) << 16); 933 *selfOkay = true; 934 break; 935 case Instruction::GOTO_16: 936 *pOffset = (int16_t) insns[1]; 937 break; 938 case Instruction::IF_EQ: 939 case Instruction::IF_NE: 940 case Instruction::IF_LT: 941 case Instruction::IF_GE: 942 case Instruction::IF_GT: 943 case Instruction::IF_LE: 944 case Instruction::IF_EQZ: 945 case Instruction::IF_NEZ: 946 case Instruction::IF_LTZ: 947 case Instruction::IF_GEZ: 948 case Instruction::IF_GTZ: 949 case Instruction::IF_LEZ: 950 *pOffset = (int16_t) insns[1]; 951 *pConditional = true; 952 break; 953 default: 954 return false; 955 break; 956 } 957 return true; 958} 959 960bool MethodVerifier::CheckSwitchTargets(uint32_t cur_offset) { 961 const uint32_t insn_count = code_item_->insns_size_in_code_units_; 962 DCHECK_LT(cur_offset, insn_count); 963 const uint16_t* insns = code_item_->insns_ + cur_offset; 964 /* make sure the start of the switch is in range */ 965 int32_t switch_offset = insns[1] | ((int32_t) insns[2]) << 16; 966 if ((int32_t) cur_offset + switch_offset < 0 || cur_offset + switch_offset + 2 >= insn_count) { 967 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid switch start: at " << cur_offset 968 << ", switch offset " << switch_offset 969 << ", count " << insn_count; 970 return false; 971 } 972 /* offset to switch table is a relative branch-style offset */ 973 const uint16_t* switch_insns = insns + switch_offset; 974 /* make sure the table is 32-bit aligned */ 975 if ((reinterpret_cast<uintptr_t>(switch_insns) & 0x03) != 0) { 976 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unaligned switch table: at " << cur_offset 977 << ", switch offset " << switch_offset; 978 return false; 979 } 980 uint32_t switch_count = switch_insns[1]; 981 int32_t keys_offset, targets_offset; 982 uint16_t expected_signature; 983 if ((*insns & 0xff) == Instruction::PACKED_SWITCH) { 984 /* 0=sig, 1=count, 2/3=firstKey */ 985 targets_offset = 4; 986 keys_offset = -1; 987 expected_signature = Instruction::kPackedSwitchSignature; 988 } else { 989 /* 0=sig, 1=count, 2..count*2 = keys */ 990 keys_offset = 2; 991 targets_offset = 2 + 2 * switch_count; 992 expected_signature = Instruction::kSparseSwitchSignature; 993 } 994 uint32_t table_size = targets_offset + switch_count * 2; 995 if (switch_insns[0] != expected_signature) { 996 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 997 << StringPrintf("wrong signature for switch table (%x, wanted %x)", 998 switch_insns[0], expected_signature); 999 return false; 1000 } 1001 /* make sure the end of the switch is in range */ 1002 if (cur_offset + switch_offset + table_size > (uint32_t) insn_count) { 1003 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid switch end: at " << cur_offset 1004 << ", switch offset " << switch_offset 1005 << ", end " << (cur_offset + switch_offset + table_size) 1006 << ", count " << insn_count; 1007 return false; 1008 } 1009 /* for a sparse switch, verify the keys are in ascending order */ 1010 if (keys_offset > 0 && switch_count > 1) { 1011 int32_t last_key = switch_insns[keys_offset] | (switch_insns[keys_offset + 1] << 16); 1012 for (uint32_t targ = 1; targ < switch_count; targ++) { 1013 int32_t key = (int32_t) switch_insns[keys_offset + targ * 2] | 1014 (int32_t) (switch_insns[keys_offset + targ * 2 + 1] << 16); 1015 if (key <= last_key) { 1016 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid packed switch: last key=" << last_key 1017 << ", this=" << key; 1018 return false; 1019 } 1020 last_key = key; 1021 } 1022 } 1023 /* verify each switch target */ 1024 for (uint32_t targ = 0; targ < switch_count; targ++) { 1025 int32_t offset = (int32_t) switch_insns[targets_offset + targ * 2] | 1026 (int32_t) (switch_insns[targets_offset + targ * 2 + 1] << 16); 1027 int32_t abs_offset = cur_offset + offset; 1028 if (abs_offset < 0 || 1029 abs_offset >= (int32_t) insn_count || 1030 !insn_flags_[abs_offset].IsOpcode()) { 1031 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid switch target " << offset 1032 << " (-> " << reinterpret_cast<void*>(abs_offset) << ") at " 1033 << reinterpret_cast<void*>(cur_offset) 1034 << "[" << targ << "]"; 1035 return false; 1036 } 1037 insn_flags_[abs_offset].SetBranchTarget(); 1038 } 1039 return true; 1040} 1041 1042bool MethodVerifier::CheckVarArgRegs(uint32_t vA, uint32_t arg[]) { 1043 if (vA > Instruction::kMaxVarArgRegs) { 1044 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid arg count (" << vA << ") in non-range invoke)"; 1045 return false; 1046 } 1047 uint16_t registers_size = code_item_->registers_size_; 1048 for (uint32_t idx = 0; idx < vA; idx++) { 1049 if (arg[idx] >= registers_size) { 1050 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid reg index (" << arg[idx] 1051 << ") in non-range invoke (>= " << registers_size << ")"; 1052 return false; 1053 } 1054 } 1055 1056 return true; 1057} 1058 1059bool MethodVerifier::CheckVarArgRangeRegs(uint32_t vA, uint32_t vC) { 1060 uint16_t registers_size = code_item_->registers_size_; 1061 // vA/vC are unsigned 8-bit/16-bit quantities for /range instructions, so there's no risk of 1062 // integer overflow when adding them here. 1063 if (vA + vC > registers_size) { 1064 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid reg index " << vA << "+" << vC 1065 << " in range invoke (> " << registers_size << ")"; 1066 return false; 1067 } 1068 return true; 1069} 1070 1071bool MethodVerifier::VerifyCodeFlow() { 1072 uint16_t registers_size = code_item_->registers_size_; 1073 uint32_t insns_size = code_item_->insns_size_in_code_units_; 1074 1075 if (registers_size * insns_size > 4*1024*1024) { 1076 LOG(WARNING) << "warning: method is huge (regs=" << registers_size 1077 << " insns_size=" << insns_size << ")"; 1078 } 1079 /* Create and initialize table holding register status */ 1080 reg_table_.Init(kTrackCompilerInterestPoints, 1081 insn_flags_.get(), 1082 insns_size, 1083 registers_size, 1084 this); 1085 1086 1087 work_line_.reset(RegisterLine::Create(registers_size, this)); 1088 saved_line_.reset(RegisterLine::Create(registers_size, this)); 1089 1090 /* Initialize register types of method arguments. */ 1091 if (!SetTypesFromSignature()) { 1092 DCHECK_NE(failures_.size(), 0U); 1093 std::string prepend("Bad signature in "); 1094 prepend += PrettyMethod(dex_method_idx_, *dex_file_); 1095 PrependToLastFailMessage(prepend); 1096 return false; 1097 } 1098 /* Perform code flow verification. */ 1099 if (!CodeFlowVerifyMethod()) { 1100 DCHECK_NE(failures_.size(), 0U); 1101 return false; 1102 } 1103 return true; 1104} 1105 1106std::ostream& MethodVerifier::DumpFailures(std::ostream& os) { 1107 DCHECK_EQ(failures_.size(), failure_messages_.size()); 1108 for (size_t i = 0; i < failures_.size(); ++i) { 1109 os << failure_messages_[i]->str() << "\n"; 1110 } 1111 return os; 1112} 1113 1114extern "C" void MethodVerifierGdbDump(MethodVerifier* v) 1115 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { 1116 v->Dump(std::cerr); 1117} 1118 1119void MethodVerifier::Dump(std::ostream& os) { 1120 if (code_item_ == NULL) { 1121 os << "Native method\n"; 1122 return; 1123 } 1124 { 1125 os << "Register Types:\n"; 1126 Indenter indent_filter(os.rdbuf(), kIndentChar, kIndentBy1Count); 1127 std::ostream indent_os(&indent_filter); 1128 reg_types_.Dump(indent_os); 1129 } 1130 os << "Dumping instructions and register lines:\n"; 1131 Indenter indent_filter(os.rdbuf(), kIndentChar, kIndentBy1Count); 1132 std::ostream indent_os(&indent_filter); 1133 const Instruction* inst = Instruction::At(code_item_->insns_); 1134 for (size_t dex_pc = 0; dex_pc < code_item_->insns_size_in_code_units_; 1135 dex_pc += insn_flags_[dex_pc].GetLengthInCodeUnits()) { 1136 RegisterLine* reg_line = reg_table_.GetLine(dex_pc); 1137 if (reg_line != NULL) { 1138 indent_os << reg_line->Dump() << "\n"; 1139 } 1140 indent_os << StringPrintf("0x%04zx", dex_pc) << ": " << insn_flags_[dex_pc].ToString() << " "; 1141 const bool kDumpHexOfInstruction = false; 1142 if (kDumpHexOfInstruction) { 1143 indent_os << inst->DumpHex(5) << " "; 1144 } 1145 indent_os << inst->DumpString(dex_file_) << "\n"; 1146 inst = inst->Next(); 1147 } 1148} 1149 1150static bool IsPrimitiveDescriptor(char descriptor) { 1151 switch (descriptor) { 1152 case 'I': 1153 case 'C': 1154 case 'S': 1155 case 'B': 1156 case 'Z': 1157 case 'F': 1158 case 'D': 1159 case 'J': 1160 return true; 1161 default: 1162 return false; 1163 } 1164} 1165 1166bool MethodVerifier::SetTypesFromSignature() { 1167 RegisterLine* reg_line = reg_table_.GetLine(0); 1168 int arg_start = code_item_->registers_size_ - code_item_->ins_size_; 1169 size_t expected_args = code_item_->ins_size_; /* long/double count as two */ 1170 1171 DCHECK_GE(arg_start, 0); /* should have been verified earlier */ 1172 // Include the "this" pointer. 1173 size_t cur_arg = 0; 1174 if (!IsStatic()) { 1175 // If this is a constructor for a class other than java.lang.Object, mark the first ("this") 1176 // argument as uninitialized. This restricts field access until the superclass constructor is 1177 // called. 1178 const RegType& declaring_class = GetDeclaringClass(); 1179 if (IsConstructor() && !declaring_class.IsJavaLangObject()) { 1180 reg_line->SetRegisterType(arg_start + cur_arg, 1181 reg_types_.UninitializedThisArgument(declaring_class)); 1182 } else { 1183 reg_line->SetRegisterType(arg_start + cur_arg, declaring_class); 1184 } 1185 cur_arg++; 1186 } 1187 1188 const DexFile::ProtoId& proto_id = 1189 dex_file_->GetMethodPrototype(dex_file_->GetMethodId(dex_method_idx_)); 1190 DexFileParameterIterator iterator(*dex_file_, proto_id); 1191 1192 for (; iterator.HasNext(); iterator.Next()) { 1193 const char* descriptor = iterator.GetDescriptor(); 1194 if (descriptor == NULL) { 1195 LOG(FATAL) << "Null descriptor"; 1196 } 1197 if (cur_arg >= expected_args) { 1198 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected " << expected_args 1199 << " args, found more (" << descriptor << ")"; 1200 return false; 1201 } 1202 switch (descriptor[0]) { 1203 case 'L': 1204 case '[': 1205 // We assume that reference arguments are initialized. The only way it could be otherwise 1206 // (assuming the caller was verified) is if the current method is <init>, but in that case 1207 // it's effectively considered initialized the instant we reach here (in the sense that we 1208 // can return without doing anything or call virtual methods). 1209 { 1210 const RegType& reg_type = ResolveClassAndCheckAccess(iterator.GetTypeIdx()); 1211 if (!reg_type.IsNonZeroReferenceTypes()) { 1212 DCHECK(HasFailures()); 1213 return false; 1214 } 1215 reg_line->SetRegisterType(arg_start + cur_arg, reg_type); 1216 } 1217 break; 1218 case 'Z': 1219 reg_line->SetRegisterType(arg_start + cur_arg, reg_types_.Boolean()); 1220 break; 1221 case 'C': 1222 reg_line->SetRegisterType(arg_start + cur_arg, reg_types_.Char()); 1223 break; 1224 case 'B': 1225 reg_line->SetRegisterType(arg_start + cur_arg, reg_types_.Byte()); 1226 break; 1227 case 'I': 1228 reg_line->SetRegisterType(arg_start + cur_arg, reg_types_.Integer()); 1229 break; 1230 case 'S': 1231 reg_line->SetRegisterType(arg_start + cur_arg, reg_types_.Short()); 1232 break; 1233 case 'F': 1234 reg_line->SetRegisterType(arg_start + cur_arg, reg_types_.Float()); 1235 break; 1236 case 'J': 1237 case 'D': { 1238 if (cur_arg + 1 >= expected_args) { 1239 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected " << expected_args 1240 << " args, found more (" << descriptor << ")"; 1241 return false; 1242 } 1243 1244 const RegType& lo_half = descriptor[0] == 'J' ? reg_types_.LongLo() : reg_types_.DoubleLo(); 1245 const RegType& hi_half = descriptor[0] == 'J' ? reg_types_.LongHi() : reg_types_.DoubleHi(); 1246 reg_line->SetRegisterTypeWide(arg_start + cur_arg, lo_half, hi_half); 1247 cur_arg++; 1248 break; 1249 } 1250 default: 1251 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected signature type char '" 1252 << descriptor << "'"; 1253 return false; 1254 } 1255 cur_arg++; 1256 } 1257 if (cur_arg != expected_args) { 1258 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected " << expected_args 1259 << " arguments, found " << cur_arg; 1260 return false; 1261 } 1262 const char* descriptor = dex_file_->GetReturnTypeDescriptor(proto_id); 1263 // Validate return type. We don't do the type lookup; just want to make sure that it has the right 1264 // format. Only major difference from the method argument format is that 'V' is supported. 1265 bool result; 1266 if (IsPrimitiveDescriptor(descriptor[0]) || descriptor[0] == 'V') { 1267 result = descriptor[1] == '\0'; 1268 } else if (descriptor[0] == '[') { // single/multi-dimensional array of object/primitive 1269 size_t i = 0; 1270 do { 1271 i++; 1272 } while (descriptor[i] == '['); // process leading [ 1273 if (descriptor[i] == 'L') { // object array 1274 do { 1275 i++; // find closing ; 1276 } while (descriptor[i] != ';' && descriptor[i] != '\0'); 1277 result = descriptor[i] == ';'; 1278 } else { // primitive array 1279 result = IsPrimitiveDescriptor(descriptor[i]) && descriptor[i + 1] == '\0'; 1280 } 1281 } else if (descriptor[0] == 'L') { 1282 // could be more thorough here, but shouldn't be required 1283 size_t i = 0; 1284 do { 1285 i++; 1286 } while (descriptor[i] != ';' && descriptor[i] != '\0'); 1287 result = descriptor[i] == ';'; 1288 } else { 1289 result = false; 1290 } 1291 if (!result) { 1292 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected char in return type descriptor '" 1293 << descriptor << "'"; 1294 } 1295 return result; 1296} 1297 1298bool MethodVerifier::CodeFlowVerifyMethod() { 1299 const uint16_t* insns = code_item_->insns_; 1300 const uint32_t insns_size = code_item_->insns_size_in_code_units_; 1301 1302 /* Begin by marking the first instruction as "changed". */ 1303 insn_flags_[0].SetChanged(); 1304 uint32_t start_guess = 0; 1305 1306 /* Continue until no instructions are marked "changed". */ 1307 while (true) { 1308 // Find the first marked one. Use "start_guess" as a way to find one quickly. 1309 uint32_t insn_idx = start_guess; 1310 for (; insn_idx < insns_size; insn_idx++) { 1311 if (insn_flags_[insn_idx].IsChanged()) 1312 break; 1313 } 1314 if (insn_idx == insns_size) { 1315 if (start_guess != 0) { 1316 /* try again, starting from the top */ 1317 start_guess = 0; 1318 continue; 1319 } else { 1320 /* all flags are clear */ 1321 break; 1322 } 1323 } 1324 // We carry the working set of registers from instruction to instruction. If this address can 1325 // be the target of a branch (or throw) instruction, or if we're skipping around chasing 1326 // "changed" flags, we need to load the set of registers from the table. 1327 // Because we always prefer to continue on to the next instruction, we should never have a 1328 // situation where we have a stray "changed" flag set on an instruction that isn't a branch 1329 // target. 1330 work_insn_idx_ = insn_idx; 1331 if (insn_flags_[insn_idx].IsBranchTarget()) { 1332 work_line_->CopyFromLine(reg_table_.GetLine(insn_idx)); 1333 } else if (kIsDebugBuild) { 1334 /* 1335 * Sanity check: retrieve the stored register line (assuming 1336 * a full table) and make sure it actually matches. 1337 */ 1338 RegisterLine* register_line = reg_table_.GetLine(insn_idx); 1339 if (register_line != NULL) { 1340 if (work_line_->CompareLine(register_line) != 0) { 1341 Dump(std::cout); 1342 std::cout << info_messages_.str(); 1343 LOG(FATAL) << "work_line diverged in " << PrettyMethod(dex_method_idx_, *dex_file_) 1344 << "@" << reinterpret_cast<void*>(work_insn_idx_) << "\n" 1345 << " work_line=" << *work_line_ << "\n" 1346 << " expected=" << *register_line; 1347 } 1348 } 1349 } 1350 if (!CodeFlowVerifyInstruction(&start_guess)) { 1351 std::string prepend(PrettyMethod(dex_method_idx_, *dex_file_)); 1352 prepend += " failed to verify: "; 1353 PrependToLastFailMessage(prepend); 1354 return false; 1355 } 1356 /* Clear "changed" and mark as visited. */ 1357 insn_flags_[insn_idx].SetVisited(); 1358 insn_flags_[insn_idx].ClearChanged(); 1359 } 1360 1361 if (gDebugVerify) { 1362 /* 1363 * Scan for dead code. There's nothing "evil" about dead code 1364 * (besides the wasted space), but it indicates a flaw somewhere 1365 * down the line, possibly in the verifier. 1366 * 1367 * If we've substituted "always throw" instructions into the stream, 1368 * we are almost certainly going to have some dead code. 1369 */ 1370 int dead_start = -1; 1371 uint32_t insn_idx = 0; 1372 for (; insn_idx < insns_size; insn_idx += insn_flags_[insn_idx].GetLengthInCodeUnits()) { 1373 /* 1374 * Switch-statement data doesn't get "visited" by scanner. It 1375 * may or may not be preceded by a padding NOP (for alignment). 1376 */ 1377 if (insns[insn_idx] == Instruction::kPackedSwitchSignature || 1378 insns[insn_idx] == Instruction::kSparseSwitchSignature || 1379 insns[insn_idx] == Instruction::kArrayDataSignature || 1380 (insns[insn_idx] == Instruction::NOP && (insn_idx + 1 < insns_size) && 1381 (insns[insn_idx + 1] == Instruction::kPackedSwitchSignature || 1382 insns[insn_idx + 1] == Instruction::kSparseSwitchSignature || 1383 insns[insn_idx + 1] == Instruction::kArrayDataSignature))) { 1384 insn_flags_[insn_idx].SetVisited(); 1385 } 1386 1387 if (!insn_flags_[insn_idx].IsVisited()) { 1388 if (dead_start < 0) 1389 dead_start = insn_idx; 1390 } else if (dead_start >= 0) { 1391 LogVerifyInfo() << "dead code " << reinterpret_cast<void*>(dead_start) 1392 << "-" << reinterpret_cast<void*>(insn_idx - 1); 1393 dead_start = -1; 1394 } 1395 } 1396 if (dead_start >= 0) { 1397 LogVerifyInfo() << "dead code " << reinterpret_cast<void*>(dead_start) 1398 << "-" << reinterpret_cast<void*>(insn_idx - 1); 1399 } 1400 // To dump the state of the verify after a method, do something like: 1401 // if (PrettyMethod(dex_method_idx_, *dex_file_) == 1402 // "boolean java.lang.String.equals(java.lang.Object)") { 1403 // LOG(INFO) << info_messages_.str(); 1404 // } 1405 } 1406 return true; 1407} 1408 1409bool MethodVerifier::CodeFlowVerifyInstruction(uint32_t* start_guess) { 1410 // If we're doing FindLocksAtDexPc, check whether we're at the dex pc we care about. 1411 // We want the state _before_ the instruction, for the case where the dex pc we're 1412 // interested in is itself a monitor-enter instruction (which is a likely place 1413 // for a thread to be suspended). 1414 if (monitor_enter_dex_pcs_ != NULL && work_insn_idx_ == interesting_dex_pc_) { 1415 monitor_enter_dex_pcs_->clear(); // The new work line is more accurate than the previous one. 1416 for (size_t i = 0; i < work_line_->GetMonitorEnterCount(); ++i) { 1417 monitor_enter_dex_pcs_->push_back(work_line_->GetMonitorEnterDexPc(i)); 1418 } 1419 } 1420 1421 /* 1422 * Once we finish decoding the instruction, we need to figure out where 1423 * we can go from here. There are three possible ways to transfer 1424 * control to another statement: 1425 * 1426 * (1) Continue to the next instruction. Applies to all but 1427 * unconditional branches, method returns, and exception throws. 1428 * (2) Branch to one or more possible locations. Applies to branches 1429 * and switch statements. 1430 * (3) Exception handlers. Applies to any instruction that can 1431 * throw an exception that is handled by an encompassing "try" 1432 * block. 1433 * 1434 * We can also return, in which case there is no successor instruction 1435 * from this point. 1436 * 1437 * The behavior can be determined from the opcode flags. 1438 */ 1439 const uint16_t* insns = code_item_->insns_ + work_insn_idx_; 1440 const Instruction* inst = Instruction::At(insns); 1441 int opcode_flags = Instruction::FlagsOf(inst->Opcode()); 1442 1443 int32_t branch_target = 0; 1444 bool just_set_result = false; 1445 if (gDebugVerify) { 1446 // Generate processing back trace to debug verifier 1447 LogVerifyInfo() << "Processing " << inst->DumpString(dex_file_) << "\n" 1448 << *work_line_.get() << "\n"; 1449 } 1450 1451 /* 1452 * Make a copy of the previous register state. If the instruction 1453 * can throw an exception, we will copy/merge this into the "catch" 1454 * address rather than work_line, because we don't want the result 1455 * from the "successful" code path (e.g. a check-cast that "improves" 1456 * a type) to be visible to the exception handler. 1457 */ 1458 if ((opcode_flags & Instruction::kThrow) != 0 && CurrentInsnFlags()->IsInTry()) { 1459 saved_line_->CopyFromLine(work_line_.get()); 1460 } else { 1461#ifndef NDEBUG 1462 saved_line_->FillWithGarbage(); 1463#endif 1464 } 1465 1466 1467 // We need to ensure the work line is consistent while performing validation. When we spot a 1468 // peephole pattern we compute a new line for either the fallthrough instruction or the 1469 // branch target. 1470 std::unique_ptr<RegisterLine> branch_line; 1471 std::unique_ptr<RegisterLine> fallthrough_line; 1472 1473 switch (inst->Opcode()) { 1474 case Instruction::NOP: 1475 /* 1476 * A "pure" NOP has no effect on anything. Data tables start with 1477 * a signature that looks like a NOP; if we see one of these in 1478 * the course of executing code then we have a problem. 1479 */ 1480 if (inst->VRegA_10x() != 0) { 1481 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "encountered data table in instruction stream"; 1482 } 1483 break; 1484 1485 case Instruction::MOVE: 1486 work_line_->CopyRegister1(inst->VRegA_12x(), inst->VRegB_12x(), kTypeCategory1nr); 1487 break; 1488 case Instruction::MOVE_FROM16: 1489 work_line_->CopyRegister1(inst->VRegA_22x(), inst->VRegB_22x(), kTypeCategory1nr); 1490 break; 1491 case Instruction::MOVE_16: 1492 work_line_->CopyRegister1(inst->VRegA_32x(), inst->VRegB_32x(), kTypeCategory1nr); 1493 break; 1494 case Instruction::MOVE_WIDE: 1495 work_line_->CopyRegister2(inst->VRegA_12x(), inst->VRegB_12x()); 1496 break; 1497 case Instruction::MOVE_WIDE_FROM16: 1498 work_line_->CopyRegister2(inst->VRegA_22x(), inst->VRegB_22x()); 1499 break; 1500 case Instruction::MOVE_WIDE_16: 1501 work_line_->CopyRegister2(inst->VRegA_32x(), inst->VRegB_32x()); 1502 break; 1503 case Instruction::MOVE_OBJECT: 1504 work_line_->CopyRegister1(inst->VRegA_12x(), inst->VRegB_12x(), kTypeCategoryRef); 1505 break; 1506 case Instruction::MOVE_OBJECT_FROM16: 1507 work_line_->CopyRegister1(inst->VRegA_22x(), inst->VRegB_22x(), kTypeCategoryRef); 1508 break; 1509 case Instruction::MOVE_OBJECT_16: 1510 work_line_->CopyRegister1(inst->VRegA_32x(), inst->VRegB_32x(), kTypeCategoryRef); 1511 break; 1512 1513 /* 1514 * The move-result instructions copy data out of a "pseudo-register" 1515 * with the results from the last method invocation. In practice we 1516 * might want to hold the result in an actual CPU register, so the 1517 * Dalvik spec requires that these only appear immediately after an 1518 * invoke or filled-new-array. 1519 * 1520 * These calls invalidate the "result" register. (This is now 1521 * redundant with the reset done below, but it can make the debug info 1522 * easier to read in some cases.) 1523 */ 1524 case Instruction::MOVE_RESULT: 1525 work_line_->CopyResultRegister1(inst->VRegA_11x(), false); 1526 break; 1527 case Instruction::MOVE_RESULT_WIDE: 1528 work_line_->CopyResultRegister2(inst->VRegA_11x()); 1529 break; 1530 case Instruction::MOVE_RESULT_OBJECT: 1531 work_line_->CopyResultRegister1(inst->VRegA_11x(), true); 1532 break; 1533 1534 case Instruction::MOVE_EXCEPTION: { 1535 /* 1536 * This statement can only appear as the first instruction in an exception handler. We verify 1537 * that as part of extracting the exception type from the catch block list. 1538 */ 1539 const RegType& res_type = GetCaughtExceptionType(); 1540 work_line_->SetRegisterType(inst->VRegA_11x(), res_type); 1541 break; 1542 } 1543 case Instruction::RETURN_VOID: 1544 if (!IsConstructor() || work_line_->CheckConstructorReturn()) { 1545 if (!GetMethodReturnType().IsConflict()) { 1546 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "return-void not expected"; 1547 } 1548 } 1549 break; 1550 case Instruction::RETURN: 1551 if (!IsConstructor() || work_line_->CheckConstructorReturn()) { 1552 /* check the method signature */ 1553 const RegType& return_type = GetMethodReturnType(); 1554 if (!return_type.IsCategory1Types()) { 1555 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected non-category 1 return type " 1556 << return_type; 1557 } else { 1558 // Compilers may generate synthetic functions that write byte values into boolean fields. 1559 // Also, it may use integer values for boolean, byte, short, and character return types. 1560 const uint32_t vregA = inst->VRegA_11x(); 1561 const RegType& src_type = work_line_->GetRegisterType(vregA); 1562 bool use_src = ((return_type.IsBoolean() && src_type.IsByte()) || 1563 ((return_type.IsBoolean() || return_type.IsByte() || 1564 return_type.IsShort() || return_type.IsChar()) && 1565 src_type.IsInteger())); 1566 /* check the register contents */ 1567 bool success = 1568 work_line_->VerifyRegisterType(vregA, use_src ? src_type : return_type); 1569 if (!success) { 1570 AppendToLastFailMessage(StringPrintf(" return-1nr on invalid register v%d", vregA)); 1571 } 1572 } 1573 } 1574 break; 1575 case Instruction::RETURN_WIDE: 1576 if (!IsConstructor() || work_line_->CheckConstructorReturn()) { 1577 /* check the method signature */ 1578 const RegType& return_type = GetMethodReturnType(); 1579 if (!return_type.IsCategory2Types()) { 1580 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "return-wide not expected"; 1581 } else { 1582 /* check the register contents */ 1583 const uint32_t vregA = inst->VRegA_11x(); 1584 bool success = work_line_->VerifyRegisterType(vregA, return_type); 1585 if (!success) { 1586 AppendToLastFailMessage(StringPrintf(" return-wide on invalid register v%d", vregA)); 1587 } 1588 } 1589 } 1590 break; 1591 case Instruction::RETURN_OBJECT: 1592 if (!IsConstructor() || work_line_->CheckConstructorReturn()) { 1593 const RegType& return_type = GetMethodReturnType(); 1594 if (!return_type.IsReferenceTypes()) { 1595 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "return-object not expected"; 1596 } else { 1597 /* return_type is the *expected* return type, not register value */ 1598 DCHECK(!return_type.IsZero()); 1599 DCHECK(!return_type.IsUninitializedReference()); 1600 const uint32_t vregA = inst->VRegA_11x(); 1601 const RegType& reg_type = work_line_->GetRegisterType(vregA); 1602 // Disallow returning uninitialized values and verify that the reference in vAA is an 1603 // instance of the "return_type" 1604 if (reg_type.IsUninitializedTypes()) { 1605 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "returning uninitialized object '" 1606 << reg_type << "'"; 1607 } else if (!return_type.IsAssignableFrom(reg_type)) { 1608 if (reg_type.IsUnresolvedTypes() || return_type.IsUnresolvedTypes()) { 1609 Fail(VERIFY_ERROR_NO_CLASS) << " can't resolve returned type '" << return_type 1610 << "' or '" << reg_type << "'"; 1611 } else { 1612 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "returning '" << reg_type 1613 << "', but expected from declaration '" << return_type << "'"; 1614 } 1615 } 1616 } 1617 } 1618 break; 1619 1620 /* could be boolean, int, float, or a null reference */ 1621 case Instruction::CONST_4: { 1622 int32_t val = static_cast<int32_t>(inst->VRegB_11n() << 28) >> 28; 1623 work_line_->SetRegisterType(inst->VRegA_11n(), 1624 DetermineCat1Constant(val, need_precise_constants_)); 1625 break; 1626 } 1627 case Instruction::CONST_16: { 1628 int16_t val = static_cast<int16_t>(inst->VRegB_21s()); 1629 work_line_->SetRegisterType(inst->VRegA_21s(), 1630 DetermineCat1Constant(val, need_precise_constants_)); 1631 break; 1632 } 1633 case Instruction::CONST: { 1634 int32_t val = inst->VRegB_31i(); 1635 work_line_->SetRegisterType(inst->VRegA_31i(), 1636 DetermineCat1Constant(val, need_precise_constants_)); 1637 break; 1638 } 1639 case Instruction::CONST_HIGH16: { 1640 int32_t val = static_cast<int32_t>(inst->VRegB_21h() << 16); 1641 work_line_->SetRegisterType(inst->VRegA_21h(), 1642 DetermineCat1Constant(val, need_precise_constants_)); 1643 break; 1644 } 1645 /* could be long or double; resolved upon use */ 1646 case Instruction::CONST_WIDE_16: { 1647 int64_t val = static_cast<int16_t>(inst->VRegB_21s()); 1648 const RegType& lo = reg_types_.FromCat2ConstLo(static_cast<int32_t>(val), true); 1649 const RegType& hi = reg_types_.FromCat2ConstHi(static_cast<int32_t>(val >> 32), true); 1650 work_line_->SetRegisterTypeWide(inst->VRegA_21s(), lo, hi); 1651 break; 1652 } 1653 case Instruction::CONST_WIDE_32: { 1654 int64_t val = static_cast<int32_t>(inst->VRegB_31i()); 1655 const RegType& lo = reg_types_.FromCat2ConstLo(static_cast<int32_t>(val), true); 1656 const RegType& hi = reg_types_.FromCat2ConstHi(static_cast<int32_t>(val >> 32), true); 1657 work_line_->SetRegisterTypeWide(inst->VRegA_31i(), lo, hi); 1658 break; 1659 } 1660 case Instruction::CONST_WIDE: { 1661 int64_t val = inst->VRegB_51l(); 1662 const RegType& lo = reg_types_.FromCat2ConstLo(static_cast<int32_t>(val), true); 1663 const RegType& hi = reg_types_.FromCat2ConstHi(static_cast<int32_t>(val >> 32), true); 1664 work_line_->SetRegisterTypeWide(inst->VRegA_51l(), lo, hi); 1665 break; 1666 } 1667 case Instruction::CONST_WIDE_HIGH16: { 1668 int64_t val = static_cast<uint64_t>(inst->VRegB_21h()) << 48; 1669 const RegType& lo = reg_types_.FromCat2ConstLo(static_cast<int32_t>(val), true); 1670 const RegType& hi = reg_types_.FromCat2ConstHi(static_cast<int32_t>(val >> 32), true); 1671 work_line_->SetRegisterTypeWide(inst->VRegA_21h(), lo, hi); 1672 break; 1673 } 1674 case Instruction::CONST_STRING: 1675 work_line_->SetRegisterType(inst->VRegA_21c(), reg_types_.JavaLangString()); 1676 break; 1677 case Instruction::CONST_STRING_JUMBO: 1678 work_line_->SetRegisterType(inst->VRegA_31c(), reg_types_.JavaLangString()); 1679 break; 1680 case Instruction::CONST_CLASS: { 1681 // Get type from instruction if unresolved then we need an access check 1682 // TODO: check Compiler::CanAccessTypeWithoutChecks returns false when res_type is unresolved 1683 const RegType& res_type = ResolveClassAndCheckAccess(inst->VRegB_21c()); 1684 // Register holds class, ie its type is class, on error it will hold Conflict. 1685 work_line_->SetRegisterType(inst->VRegA_21c(), 1686 res_type.IsConflict() ? res_type 1687 : reg_types_.JavaLangClass(true)); 1688 break; 1689 } 1690 case Instruction::MONITOR_ENTER: 1691 work_line_->PushMonitor(inst->VRegA_11x(), work_insn_idx_); 1692 break; 1693 case Instruction::MONITOR_EXIT: 1694 /* 1695 * monitor-exit instructions are odd. They can throw exceptions, 1696 * but when they do they act as if they succeeded and the PC is 1697 * pointing to the following instruction. (This behavior goes back 1698 * to the need to handle asynchronous exceptions, a now-deprecated 1699 * feature that Dalvik doesn't support.) 1700 * 1701 * In practice we don't need to worry about this. The only 1702 * exceptions that can be thrown from monitor-exit are for a 1703 * null reference and -exit without a matching -enter. If the 1704 * structured locking checks are working, the former would have 1705 * failed on the -enter instruction, and the latter is impossible. 1706 * 1707 * This is fortunate, because issue 3221411 prevents us from 1708 * chasing the "can throw" path when monitor verification is 1709 * enabled. If we can fully verify the locking we can ignore 1710 * some catch blocks (which will show up as "dead" code when 1711 * we skip them here); if we can't, then the code path could be 1712 * "live" so we still need to check it. 1713 */ 1714 opcode_flags &= ~Instruction::kThrow; 1715 work_line_->PopMonitor(inst->VRegA_11x()); 1716 break; 1717 1718 case Instruction::CHECK_CAST: 1719 case Instruction::INSTANCE_OF: { 1720 /* 1721 * If this instruction succeeds, we will "downcast" register vA to the type in vB. (This 1722 * could be a "upcast" -- not expected, so we don't try to address it.) 1723 * 1724 * If it fails, an exception is thrown, which we deal with later by ignoring the update to 1725 * dec_insn.vA when branching to a handler. 1726 */ 1727 const bool is_checkcast = (inst->Opcode() == Instruction::CHECK_CAST); 1728 const uint32_t type_idx = (is_checkcast) ? inst->VRegB_21c() : inst->VRegC_22c(); 1729 const RegType& res_type = ResolveClassAndCheckAccess(type_idx); 1730 if (res_type.IsConflict()) { 1731 DCHECK_NE(failures_.size(), 0U); 1732 if (!is_checkcast) { 1733 work_line_->SetRegisterType(inst->VRegA_22c(), reg_types_.Boolean()); 1734 } 1735 break; // bad class 1736 } 1737 // TODO: check Compiler::CanAccessTypeWithoutChecks returns false when res_type is unresolved 1738 uint32_t orig_type_reg = (is_checkcast) ? inst->VRegA_21c() : inst->VRegB_22c(); 1739 const RegType& orig_type = work_line_->GetRegisterType(orig_type_reg); 1740 if (!res_type.IsNonZeroReferenceTypes()) { 1741 if (is_checkcast) { 1742 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "check-cast on unexpected class " << res_type; 1743 } else { 1744 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "instance-of on unexpected class " << res_type; 1745 } 1746 } else if (!orig_type.IsReferenceTypes()) { 1747 if (is_checkcast) { 1748 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "check-cast on non-reference in v" << orig_type_reg; 1749 } else { 1750 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "instance-of on non-reference in v" << orig_type_reg; 1751 } 1752 } else { 1753 if (is_checkcast) { 1754 work_line_->SetRegisterType(inst->VRegA_21c(), res_type); 1755 } else { 1756 work_line_->SetRegisterType(inst->VRegA_22c(), reg_types_.Boolean()); 1757 } 1758 } 1759 break; 1760 } 1761 case Instruction::ARRAY_LENGTH: { 1762 const RegType& res_type = work_line_->GetRegisterType(inst->VRegB_12x()); 1763 if (res_type.IsReferenceTypes()) { 1764 if (!res_type.IsArrayTypes() && !res_type.IsZero()) { // ie not an array or null 1765 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "array-length on non-array " << res_type; 1766 } else { 1767 work_line_->SetRegisterType(inst->VRegA_12x(), reg_types_.Integer()); 1768 } 1769 } 1770 break; 1771 } 1772 case Instruction::NEW_INSTANCE: { 1773 const RegType& res_type = ResolveClassAndCheckAccess(inst->VRegB_21c()); 1774 if (res_type.IsConflict()) { 1775 DCHECK_NE(failures_.size(), 0U); 1776 break; // bad class 1777 } 1778 // TODO: check Compiler::CanAccessTypeWithoutChecks returns false when res_type is unresolved 1779 // can't create an instance of an interface or abstract class */ 1780 if (!res_type.IsInstantiableTypes()) { 1781 Fail(VERIFY_ERROR_INSTANTIATION) 1782 << "new-instance on primitive, interface or abstract class" << res_type; 1783 // Soft failure so carry on to set register type. 1784 } 1785 const RegType& uninit_type = reg_types_.Uninitialized(res_type, work_insn_idx_); 1786 // Any registers holding previous allocations from this address that have not yet been 1787 // initialized must be marked invalid. 1788 work_line_->MarkUninitRefsAsInvalid(uninit_type); 1789 // add the new uninitialized reference to the register state 1790 work_line_->SetRegisterType(inst->VRegA_21c(), uninit_type); 1791 break; 1792 } 1793 case Instruction::NEW_ARRAY: 1794 VerifyNewArray(inst, false, false); 1795 break; 1796 case Instruction::FILLED_NEW_ARRAY: 1797 VerifyNewArray(inst, true, false); 1798 just_set_result = true; // Filled new array sets result register 1799 break; 1800 case Instruction::FILLED_NEW_ARRAY_RANGE: 1801 VerifyNewArray(inst, true, true); 1802 just_set_result = true; // Filled new array range sets result register 1803 break; 1804 case Instruction::CMPL_FLOAT: 1805 case Instruction::CMPG_FLOAT: 1806 if (!work_line_->VerifyRegisterType(inst->VRegB_23x(), reg_types_.Float())) { 1807 break; 1808 } 1809 if (!work_line_->VerifyRegisterType(inst->VRegC_23x(), reg_types_.Float())) { 1810 break; 1811 } 1812 work_line_->SetRegisterType(inst->VRegA_23x(), reg_types_.Integer()); 1813 break; 1814 case Instruction::CMPL_DOUBLE: 1815 case Instruction::CMPG_DOUBLE: 1816 if (!work_line_->VerifyRegisterTypeWide(inst->VRegB_23x(), reg_types_.DoubleLo(), 1817 reg_types_.DoubleHi())) { 1818 break; 1819 } 1820 if (!work_line_->VerifyRegisterTypeWide(inst->VRegC_23x(), reg_types_.DoubleLo(), 1821 reg_types_.DoubleHi())) { 1822 break; 1823 } 1824 work_line_->SetRegisterType(inst->VRegA_23x(), reg_types_.Integer()); 1825 break; 1826 case Instruction::CMP_LONG: 1827 if (!work_line_->VerifyRegisterTypeWide(inst->VRegB_23x(), reg_types_.LongLo(), 1828 reg_types_.LongHi())) { 1829 break; 1830 } 1831 if (!work_line_->VerifyRegisterTypeWide(inst->VRegC_23x(), reg_types_.LongLo(), 1832 reg_types_.LongHi())) { 1833 break; 1834 } 1835 work_line_->SetRegisterType(inst->VRegA_23x(), reg_types_.Integer()); 1836 break; 1837 case Instruction::THROW: { 1838 const RegType& res_type = work_line_->GetRegisterType(inst->VRegA_11x()); 1839 if (!reg_types_.JavaLangThrowable(false).IsAssignableFrom(res_type)) { 1840 Fail(res_type.IsUnresolvedTypes() ? VERIFY_ERROR_NO_CLASS : VERIFY_ERROR_BAD_CLASS_SOFT) 1841 << "thrown class " << res_type << " not instanceof Throwable"; 1842 } 1843 break; 1844 } 1845 case Instruction::GOTO: 1846 case Instruction::GOTO_16: 1847 case Instruction::GOTO_32: 1848 /* no effect on or use of registers */ 1849 break; 1850 1851 case Instruction::PACKED_SWITCH: 1852 case Instruction::SPARSE_SWITCH: 1853 /* verify that vAA is an integer, or can be converted to one */ 1854 work_line_->VerifyRegisterType(inst->VRegA_31t(), reg_types_.Integer()); 1855 break; 1856 1857 case Instruction::FILL_ARRAY_DATA: { 1858 /* Similar to the verification done for APUT */ 1859 const RegType& array_type = work_line_->GetRegisterType(inst->VRegA_31t()); 1860 /* array_type can be null if the reg type is Zero */ 1861 if (!array_type.IsZero()) { 1862 if (!array_type.IsArrayTypes()) { 1863 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid fill-array-data with array type " 1864 << array_type; 1865 } else { 1866 const RegType& component_type = reg_types_.GetComponentType(array_type, 1867 class_loader_->Get()); 1868 DCHECK(!component_type.IsConflict()); 1869 if (component_type.IsNonZeroReferenceTypes()) { 1870 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid fill-array-data with component type " 1871 << component_type; 1872 } else { 1873 // Now verify if the element width in the table matches the element width declared in 1874 // the array 1875 const uint16_t* array_data = insns + (insns[1] | (((int32_t) insns[2]) << 16)); 1876 if (array_data[0] != Instruction::kArrayDataSignature) { 1877 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid magic for array-data"; 1878 } else { 1879 size_t elem_width = Primitive::ComponentSize(component_type.GetPrimitiveType()); 1880 // Since we don't compress the data in Dex, expect to see equal width of data stored 1881 // in the table and expected from the array class. 1882 if (array_data[1] != elem_width) { 1883 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "array-data size mismatch (" << array_data[1] 1884 << " vs " << elem_width << ")"; 1885 } 1886 } 1887 } 1888 } 1889 } 1890 break; 1891 } 1892 case Instruction::IF_EQ: 1893 case Instruction::IF_NE: { 1894 const RegType& reg_type1 = work_line_->GetRegisterType(inst->VRegA_22t()); 1895 const RegType& reg_type2 = work_line_->GetRegisterType(inst->VRegB_22t()); 1896 bool mismatch = false; 1897 if (reg_type1.IsZero()) { // zero then integral or reference expected 1898 mismatch = !reg_type2.IsReferenceTypes() && !reg_type2.IsIntegralTypes(); 1899 } else if (reg_type1.IsReferenceTypes()) { // both references? 1900 mismatch = !reg_type2.IsReferenceTypes(); 1901 } else { // both integral? 1902 mismatch = !reg_type1.IsIntegralTypes() || !reg_type2.IsIntegralTypes(); 1903 } 1904 if (mismatch) { 1905 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "args to if-eq/if-ne (" << reg_type1 << "," 1906 << reg_type2 << ") must both be references or integral"; 1907 } 1908 break; 1909 } 1910 case Instruction::IF_LT: 1911 case Instruction::IF_GE: 1912 case Instruction::IF_GT: 1913 case Instruction::IF_LE: { 1914 const RegType& reg_type1 = work_line_->GetRegisterType(inst->VRegA_22t()); 1915 const RegType& reg_type2 = work_line_->GetRegisterType(inst->VRegB_22t()); 1916 if (!reg_type1.IsIntegralTypes() || !reg_type2.IsIntegralTypes()) { 1917 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "args to 'if' (" << reg_type1 << "," 1918 << reg_type2 << ") must be integral"; 1919 } 1920 break; 1921 } 1922 case Instruction::IF_EQZ: 1923 case Instruction::IF_NEZ: { 1924 const RegType& reg_type = work_line_->GetRegisterType(inst->VRegA_21t()); 1925 if (!reg_type.IsReferenceTypes() && !reg_type.IsIntegralTypes()) { 1926 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "type " << reg_type 1927 << " unexpected as arg to if-eqz/if-nez"; 1928 } 1929 1930 // Find previous instruction - its existence is a precondition to peephole optimization. 1931 uint32_t instance_of_idx = 0; 1932 if (0 != work_insn_idx_) { 1933 instance_of_idx = work_insn_idx_ - 1; 1934 while (0 != instance_of_idx && !insn_flags_[instance_of_idx].IsOpcode()) { 1935 instance_of_idx--; 1936 } 1937 CHECK(insn_flags_[instance_of_idx].IsOpcode()); 1938 } else { 1939 break; 1940 } 1941 1942 const Instruction* instance_of_inst = Instruction::At(code_item_->insns_ + instance_of_idx); 1943 1944 /* Check for peep-hole pattern of: 1945 * ...; 1946 * instance-of vX, vY, T; 1947 * ifXXX vX, label ; 1948 * ...; 1949 * label: 1950 * ...; 1951 * and sharpen the type of vY to be type T. 1952 * Note, this pattern can't be if: 1953 * - if there are other branches to this branch, 1954 * - when vX == vY. 1955 */ 1956 if (!CurrentInsnFlags()->IsBranchTarget() && 1957 (Instruction::INSTANCE_OF == instance_of_inst->Opcode()) && 1958 (inst->VRegA_21t() == instance_of_inst->VRegA_22c()) && 1959 (instance_of_inst->VRegA_22c() != instance_of_inst->VRegB_22c())) { 1960 // Check the type of the instance-of is different than that of registers type, as if they 1961 // are the same there is no work to be done here. Check that the conversion is not to or 1962 // from an unresolved type as type information is imprecise. If the instance-of is to an 1963 // interface then ignore the type information as interfaces can only be treated as Objects 1964 // and we don't want to disallow field and other operations on the object. If the value 1965 // being instance-of checked against is known null (zero) then allow the optimization as 1966 // we didn't have type information. If the merge of the instance-of type with the original 1967 // type is assignable to the original then allow optimization. This check is performed to 1968 // ensure that subsequent merges don't lose type information - such as becoming an 1969 // interface from a class that would lose information relevant to field checks. 1970 const RegType& orig_type = work_line_->GetRegisterType(instance_of_inst->VRegB_22c()); 1971 const RegType& cast_type = ResolveClassAndCheckAccess(instance_of_inst->VRegC_22c()); 1972 1973 if (!orig_type.Equals(cast_type) && 1974 !cast_type.IsUnresolvedTypes() && !orig_type.IsUnresolvedTypes() && 1975 !cast_type.GetClass()->IsInterface() && 1976 (orig_type.IsZero() || 1977 orig_type.IsStrictlyAssignableFrom(cast_type.Merge(orig_type, ®_types_)))) { 1978 RegisterLine* update_line = RegisterLine::Create(code_item_->registers_size_, this); 1979 if (inst->Opcode() == Instruction::IF_EQZ) { 1980 fallthrough_line.reset(update_line); 1981 } else { 1982 branch_line.reset(update_line); 1983 } 1984 update_line->CopyFromLine(work_line_.get()); 1985 update_line->SetRegisterType(instance_of_inst->VRegB_22c(), cast_type); 1986 if (!insn_flags_[instance_of_idx].IsBranchTarget() && 0 != instance_of_idx) { 1987 // See if instance-of was preceded by a move-object operation, common due to the small 1988 // register encoding space of instance-of, and propagate type information to the source 1989 // of the move-object. 1990 uint32_t move_idx = instance_of_idx - 1; 1991 while (0 != move_idx && !insn_flags_[move_idx].IsOpcode()) { 1992 move_idx--; 1993 } 1994 CHECK(insn_flags_[move_idx].IsOpcode()); 1995 const Instruction* move_inst = Instruction::At(code_item_->insns_ + move_idx); 1996 switch (move_inst->Opcode()) { 1997 case Instruction::MOVE_OBJECT: 1998 if (move_inst->VRegA_12x() == instance_of_inst->VRegB_22c()) { 1999 update_line->SetRegisterType(move_inst->VRegB_12x(), cast_type); 2000 } 2001 break; 2002 case Instruction::MOVE_OBJECT_FROM16: 2003 if (move_inst->VRegA_22x() == instance_of_inst->VRegB_22c()) { 2004 update_line->SetRegisterType(move_inst->VRegB_22x(), cast_type); 2005 } 2006 break; 2007 case Instruction::MOVE_OBJECT_16: 2008 if (move_inst->VRegA_32x() == instance_of_inst->VRegB_22c()) { 2009 update_line->SetRegisterType(move_inst->VRegB_32x(), cast_type); 2010 } 2011 break; 2012 default: 2013 break; 2014 } 2015 } 2016 } 2017 } 2018 2019 break; 2020 } 2021 case Instruction::IF_LTZ: 2022 case Instruction::IF_GEZ: 2023 case Instruction::IF_GTZ: 2024 case Instruction::IF_LEZ: { 2025 const RegType& reg_type = work_line_->GetRegisterType(inst->VRegA_21t()); 2026 if (!reg_type.IsIntegralTypes()) { 2027 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "type " << reg_type 2028 << " unexpected as arg to if-ltz/if-gez/if-gtz/if-lez"; 2029 } 2030 break; 2031 } 2032 case Instruction::AGET_BOOLEAN: 2033 VerifyAGet(inst, reg_types_.Boolean(), true); 2034 break; 2035 case Instruction::AGET_BYTE: 2036 VerifyAGet(inst, reg_types_.Byte(), true); 2037 break; 2038 case Instruction::AGET_CHAR: 2039 VerifyAGet(inst, reg_types_.Char(), true); 2040 break; 2041 case Instruction::AGET_SHORT: 2042 VerifyAGet(inst, reg_types_.Short(), true); 2043 break; 2044 case Instruction::AGET: 2045 VerifyAGet(inst, reg_types_.Integer(), true); 2046 break; 2047 case Instruction::AGET_WIDE: 2048 VerifyAGet(inst, reg_types_.LongLo(), true); 2049 break; 2050 case Instruction::AGET_OBJECT: 2051 VerifyAGet(inst, reg_types_.JavaLangObject(false), false); 2052 break; 2053 2054 case Instruction::APUT_BOOLEAN: 2055 VerifyAPut(inst, reg_types_.Boolean(), true); 2056 break; 2057 case Instruction::APUT_BYTE: 2058 VerifyAPut(inst, reg_types_.Byte(), true); 2059 break; 2060 case Instruction::APUT_CHAR: 2061 VerifyAPut(inst, reg_types_.Char(), true); 2062 break; 2063 case Instruction::APUT_SHORT: 2064 VerifyAPut(inst, reg_types_.Short(), true); 2065 break; 2066 case Instruction::APUT: 2067 VerifyAPut(inst, reg_types_.Integer(), true); 2068 break; 2069 case Instruction::APUT_WIDE: 2070 VerifyAPut(inst, reg_types_.LongLo(), true); 2071 break; 2072 case Instruction::APUT_OBJECT: 2073 VerifyAPut(inst, reg_types_.JavaLangObject(false), false); 2074 break; 2075 2076 case Instruction::IGET_BOOLEAN: 2077 VerifyISGet(inst, reg_types_.Boolean(), true, false); 2078 break; 2079 case Instruction::IGET_BYTE: 2080 VerifyISGet(inst, reg_types_.Byte(), true, false); 2081 break; 2082 case Instruction::IGET_CHAR: 2083 VerifyISGet(inst, reg_types_.Char(), true, false); 2084 break; 2085 case Instruction::IGET_SHORT: 2086 VerifyISGet(inst, reg_types_.Short(), true, false); 2087 break; 2088 case Instruction::IGET: 2089 VerifyISGet(inst, reg_types_.Integer(), true, false); 2090 break; 2091 case Instruction::IGET_WIDE: 2092 VerifyISGet(inst, reg_types_.LongLo(), true, false); 2093 break; 2094 case Instruction::IGET_OBJECT: 2095 VerifyISGet(inst, reg_types_.JavaLangObject(false), false, false); 2096 break; 2097 2098 case Instruction::IPUT_BOOLEAN: 2099 VerifyISPut(inst, reg_types_.Boolean(), true, false); 2100 break; 2101 case Instruction::IPUT_BYTE: 2102 VerifyISPut(inst, reg_types_.Byte(), true, false); 2103 break; 2104 case Instruction::IPUT_CHAR: 2105 VerifyISPut(inst, reg_types_.Char(), true, false); 2106 break; 2107 case Instruction::IPUT_SHORT: 2108 VerifyISPut(inst, reg_types_.Short(), true, false); 2109 break; 2110 case Instruction::IPUT: 2111 VerifyISPut(inst, reg_types_.Integer(), true, false); 2112 break; 2113 case Instruction::IPUT_WIDE: 2114 VerifyISPut(inst, reg_types_.LongLo(), true, false); 2115 break; 2116 case Instruction::IPUT_OBJECT: 2117 VerifyISPut(inst, reg_types_.JavaLangObject(false), false, false); 2118 break; 2119 2120 case Instruction::SGET_BOOLEAN: 2121 VerifyISGet(inst, reg_types_.Boolean(), true, true); 2122 break; 2123 case Instruction::SGET_BYTE: 2124 VerifyISGet(inst, reg_types_.Byte(), true, true); 2125 break; 2126 case Instruction::SGET_CHAR: 2127 VerifyISGet(inst, reg_types_.Char(), true, true); 2128 break; 2129 case Instruction::SGET_SHORT: 2130 VerifyISGet(inst, reg_types_.Short(), true, true); 2131 break; 2132 case Instruction::SGET: 2133 VerifyISGet(inst, reg_types_.Integer(), true, true); 2134 break; 2135 case Instruction::SGET_WIDE: 2136 VerifyISGet(inst, reg_types_.LongLo(), true, true); 2137 break; 2138 case Instruction::SGET_OBJECT: 2139 VerifyISGet(inst, reg_types_.JavaLangObject(false), false, true); 2140 break; 2141 2142 case Instruction::SPUT_BOOLEAN: 2143 VerifyISPut(inst, reg_types_.Boolean(), true, true); 2144 break; 2145 case Instruction::SPUT_BYTE: 2146 VerifyISPut(inst, reg_types_.Byte(), true, true); 2147 break; 2148 case Instruction::SPUT_CHAR: 2149 VerifyISPut(inst, reg_types_.Char(), true, true); 2150 break; 2151 case Instruction::SPUT_SHORT: 2152 VerifyISPut(inst, reg_types_.Short(), true, true); 2153 break; 2154 case Instruction::SPUT: 2155 VerifyISPut(inst, reg_types_.Integer(), true, true); 2156 break; 2157 case Instruction::SPUT_WIDE: 2158 VerifyISPut(inst, reg_types_.LongLo(), true, true); 2159 break; 2160 case Instruction::SPUT_OBJECT: 2161 VerifyISPut(inst, reg_types_.JavaLangObject(false), false, true); 2162 break; 2163 2164 case Instruction::INVOKE_VIRTUAL: 2165 case Instruction::INVOKE_VIRTUAL_RANGE: 2166 case Instruction::INVOKE_SUPER: 2167 case Instruction::INVOKE_SUPER_RANGE: { 2168 bool is_range = (inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE || 2169 inst->Opcode() == Instruction::INVOKE_SUPER_RANGE); 2170 bool is_super = (inst->Opcode() == Instruction::INVOKE_SUPER || 2171 inst->Opcode() == Instruction::INVOKE_SUPER_RANGE); 2172 mirror::ArtMethod* called_method = VerifyInvocationArgs(inst, METHOD_VIRTUAL, is_range, 2173 is_super); 2174 const RegType* return_type = nullptr; 2175 if (called_method != nullptr) { 2176 Thread* self = Thread::Current(); 2177 StackHandleScope<1> hs(self); 2178 Handle<mirror::ArtMethod> h_called_method(hs.NewHandle(called_method)); 2179 MethodHelper mh(h_called_method); 2180 mirror::Class* return_type_class = mh.GetReturnType(can_load_classes_); 2181 if (return_type_class != nullptr) { 2182 return_type = ®_types_.FromClass(h_called_method->GetReturnTypeDescriptor(), 2183 return_type_class, 2184 return_type_class->CannotBeAssignedFromOtherTypes()); 2185 } else { 2186 DCHECK(!can_load_classes_ || self->IsExceptionPending()); 2187 self->ClearException(); 2188 } 2189 } 2190 if (return_type == nullptr) { 2191 uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 2192 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); 2193 uint32_t return_type_idx = dex_file_->GetProtoId(method_id.proto_idx_).return_type_idx_; 2194 const char* descriptor = dex_file_->StringByTypeIdx(return_type_idx); 2195 return_type = ®_types_.FromDescriptor(class_loader_->Get(), descriptor, false); 2196 } 2197 if (!return_type->IsLowHalf()) { 2198 work_line_->SetResultRegisterType(*return_type); 2199 } else { 2200 work_line_->SetResultRegisterTypeWide(*return_type, return_type->HighHalf(®_types_)); 2201 } 2202 just_set_result = true; 2203 break; 2204 } 2205 case Instruction::INVOKE_DIRECT: 2206 case Instruction::INVOKE_DIRECT_RANGE: { 2207 bool is_range = (inst->Opcode() == Instruction::INVOKE_DIRECT_RANGE); 2208 mirror::ArtMethod* called_method = VerifyInvocationArgs(inst, METHOD_DIRECT, 2209 is_range, false); 2210 const char* return_type_descriptor; 2211 bool is_constructor; 2212 if (called_method == NULL) { 2213 uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 2214 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); 2215 is_constructor = strcmp("<init>", dex_file_->StringDataByIdx(method_id.name_idx_)) == 0; 2216 uint32_t return_type_idx = dex_file_->GetProtoId(method_id.proto_idx_).return_type_idx_; 2217 return_type_descriptor = dex_file_->StringByTypeIdx(return_type_idx); 2218 } else { 2219 is_constructor = called_method->IsConstructor(); 2220 return_type_descriptor = called_method->GetReturnTypeDescriptor(); 2221 } 2222 if (is_constructor) { 2223 /* 2224 * Some additional checks when calling a constructor. We know from the invocation arg check 2225 * that the "this" argument is an instance of called_method->klass. Now we further restrict 2226 * that to require that called_method->klass is the same as this->klass or this->super, 2227 * allowing the latter only if the "this" argument is the same as the "this" argument to 2228 * this method (which implies that we're in a constructor ourselves). 2229 */ 2230 const RegType& this_type = work_line_->GetInvocationThis(inst, is_range); 2231 if (this_type.IsConflict()) // failure. 2232 break; 2233 2234 /* no null refs allowed (?) */ 2235 if (this_type.IsZero()) { 2236 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unable to initialize null ref"; 2237 break; 2238 } 2239 2240 /* must be in same class or in superclass */ 2241 // const RegType& this_super_klass = this_type.GetSuperClass(®_types_); 2242 // TODO: re-enable constructor type verification 2243 // if (this_super_klass.IsConflict()) { 2244 // Unknown super class, fail so we re-check at runtime. 2245 // Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "super class unknown for '" << this_type << "'"; 2246 // break; 2247 // } 2248 2249 /* arg must be an uninitialized reference */ 2250 if (!this_type.IsUninitializedTypes()) { 2251 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Expected initialization on uninitialized reference " 2252 << this_type; 2253 break; 2254 } 2255 2256 /* 2257 * Replace the uninitialized reference with an initialized one. We need to do this for all 2258 * registers that have the same object instance in them, not just the "this" register. 2259 */ 2260 work_line_->MarkRefsAsInitialized(this_type); 2261 } 2262 const RegType& return_type = reg_types_.FromDescriptor(class_loader_->Get(), 2263 return_type_descriptor, false); 2264 if (!return_type.IsLowHalf()) { 2265 work_line_->SetResultRegisterType(return_type); 2266 } else { 2267 work_line_->SetResultRegisterTypeWide(return_type, return_type.HighHalf(®_types_)); 2268 } 2269 just_set_result = true; 2270 break; 2271 } 2272 case Instruction::INVOKE_STATIC: 2273 case Instruction::INVOKE_STATIC_RANGE: { 2274 bool is_range = (inst->Opcode() == Instruction::INVOKE_STATIC_RANGE); 2275 mirror::ArtMethod* called_method = VerifyInvocationArgs(inst, 2276 METHOD_STATIC, 2277 is_range, 2278 false); 2279 const char* descriptor; 2280 if (called_method == NULL) { 2281 uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 2282 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); 2283 uint32_t return_type_idx = dex_file_->GetProtoId(method_id.proto_idx_).return_type_idx_; 2284 descriptor = dex_file_->StringByTypeIdx(return_type_idx); 2285 } else { 2286 descriptor = called_method->GetReturnTypeDescriptor(); 2287 } 2288 const RegType& return_type = reg_types_.FromDescriptor(class_loader_->Get(), descriptor, 2289 false); 2290 if (!return_type.IsLowHalf()) { 2291 work_line_->SetResultRegisterType(return_type); 2292 } else { 2293 work_line_->SetResultRegisterTypeWide(return_type, return_type.HighHalf(®_types_)); 2294 } 2295 just_set_result = true; 2296 } 2297 break; 2298 case Instruction::INVOKE_INTERFACE: 2299 case Instruction::INVOKE_INTERFACE_RANGE: { 2300 bool is_range = (inst->Opcode() == Instruction::INVOKE_INTERFACE_RANGE); 2301 mirror::ArtMethod* abs_method = VerifyInvocationArgs(inst, 2302 METHOD_INTERFACE, 2303 is_range, 2304 false); 2305 if (abs_method != NULL) { 2306 mirror::Class* called_interface = abs_method->GetDeclaringClass(); 2307 if (!called_interface->IsInterface() && !called_interface->IsObjectClass()) { 2308 Fail(VERIFY_ERROR_CLASS_CHANGE) << "expected interface class in invoke-interface '" 2309 << PrettyMethod(abs_method) << "'"; 2310 break; 2311 } 2312 } 2313 /* Get the type of the "this" arg, which should either be a sub-interface of called 2314 * interface or Object (see comments in RegType::JoinClass). 2315 */ 2316 const RegType& this_type = work_line_->GetInvocationThis(inst, is_range); 2317 if (this_type.IsZero()) { 2318 /* null pointer always passes (and always fails at runtime) */ 2319 } else { 2320 if (this_type.IsUninitializedTypes()) { 2321 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "interface call on uninitialized object " 2322 << this_type; 2323 break; 2324 } 2325 // In the past we have tried to assert that "called_interface" is assignable 2326 // from "this_type.GetClass()", however, as we do an imprecise Join 2327 // (RegType::JoinClass) we don't have full information on what interfaces are 2328 // implemented by "this_type". For example, two classes may implement the same 2329 // interfaces and have a common parent that doesn't implement the interface. The 2330 // join will set "this_type" to the parent class and a test that this implements 2331 // the interface will incorrectly fail. 2332 } 2333 /* 2334 * We don't have an object instance, so we can't find the concrete method. However, all of 2335 * the type information is in the abstract method, so we're good. 2336 */ 2337 const char* descriptor; 2338 if (abs_method == NULL) { 2339 uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 2340 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx); 2341 uint32_t return_type_idx = dex_file_->GetProtoId(method_id.proto_idx_).return_type_idx_; 2342 descriptor = dex_file_->StringByTypeIdx(return_type_idx); 2343 } else { 2344 descriptor = abs_method->GetReturnTypeDescriptor(); 2345 } 2346 const RegType& return_type = reg_types_.FromDescriptor(class_loader_->Get(), descriptor, 2347 false); 2348 if (!return_type.IsLowHalf()) { 2349 work_line_->SetResultRegisterType(return_type); 2350 } else { 2351 work_line_->SetResultRegisterTypeWide(return_type, return_type.HighHalf(®_types_)); 2352 } 2353 just_set_result = true; 2354 break; 2355 } 2356 case Instruction::NEG_INT: 2357 case Instruction::NOT_INT: 2358 work_line_->CheckUnaryOp(inst, reg_types_.Integer(), reg_types_.Integer()); 2359 break; 2360 case Instruction::NEG_LONG: 2361 case Instruction::NOT_LONG: 2362 work_line_->CheckUnaryOpWide(inst, reg_types_.LongLo(), reg_types_.LongHi(), 2363 reg_types_.LongLo(), reg_types_.LongHi()); 2364 break; 2365 case Instruction::NEG_FLOAT: 2366 work_line_->CheckUnaryOp(inst, reg_types_.Float(), reg_types_.Float()); 2367 break; 2368 case Instruction::NEG_DOUBLE: 2369 work_line_->CheckUnaryOpWide(inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2370 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2371 break; 2372 case Instruction::INT_TO_LONG: 2373 work_line_->CheckUnaryOpToWide(inst, reg_types_.LongLo(), reg_types_.LongHi(), 2374 reg_types_.Integer()); 2375 break; 2376 case Instruction::INT_TO_FLOAT: 2377 work_line_->CheckUnaryOp(inst, reg_types_.Float(), reg_types_.Integer()); 2378 break; 2379 case Instruction::INT_TO_DOUBLE: 2380 work_line_->CheckUnaryOpToWide(inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2381 reg_types_.Integer()); 2382 break; 2383 case Instruction::LONG_TO_INT: 2384 work_line_->CheckUnaryOpFromWide(inst, reg_types_.Integer(), 2385 reg_types_.LongLo(), reg_types_.LongHi()); 2386 break; 2387 case Instruction::LONG_TO_FLOAT: 2388 work_line_->CheckUnaryOpFromWide(inst, reg_types_.Float(), 2389 reg_types_.LongLo(), reg_types_.LongHi()); 2390 break; 2391 case Instruction::LONG_TO_DOUBLE: 2392 work_line_->CheckUnaryOpWide(inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2393 reg_types_.LongLo(), reg_types_.LongHi()); 2394 break; 2395 case Instruction::FLOAT_TO_INT: 2396 work_line_->CheckUnaryOp(inst, reg_types_.Integer(), reg_types_.Float()); 2397 break; 2398 case Instruction::FLOAT_TO_LONG: 2399 work_line_->CheckUnaryOpToWide(inst, reg_types_.LongLo(), reg_types_.LongHi(), 2400 reg_types_.Float()); 2401 break; 2402 case Instruction::FLOAT_TO_DOUBLE: 2403 work_line_->CheckUnaryOpToWide(inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2404 reg_types_.Float()); 2405 break; 2406 case Instruction::DOUBLE_TO_INT: 2407 work_line_->CheckUnaryOpFromWide(inst, reg_types_.Integer(), 2408 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2409 break; 2410 case Instruction::DOUBLE_TO_LONG: 2411 work_line_->CheckUnaryOpWide(inst, reg_types_.LongLo(), reg_types_.LongHi(), 2412 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2413 break; 2414 case Instruction::DOUBLE_TO_FLOAT: 2415 work_line_->CheckUnaryOpFromWide(inst, reg_types_.Float(), 2416 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2417 break; 2418 case Instruction::INT_TO_BYTE: 2419 work_line_->CheckUnaryOp(inst, reg_types_.Byte(), reg_types_.Integer()); 2420 break; 2421 case Instruction::INT_TO_CHAR: 2422 work_line_->CheckUnaryOp(inst, reg_types_.Char(), reg_types_.Integer()); 2423 break; 2424 case Instruction::INT_TO_SHORT: 2425 work_line_->CheckUnaryOp(inst, reg_types_.Short(), reg_types_.Integer()); 2426 break; 2427 2428 case Instruction::ADD_INT: 2429 case Instruction::SUB_INT: 2430 case Instruction::MUL_INT: 2431 case Instruction::REM_INT: 2432 case Instruction::DIV_INT: 2433 case Instruction::SHL_INT: 2434 case Instruction::SHR_INT: 2435 case Instruction::USHR_INT: 2436 work_line_->CheckBinaryOp(inst, reg_types_.Integer(), reg_types_.Integer(), 2437 reg_types_.Integer(), false); 2438 break; 2439 case Instruction::AND_INT: 2440 case Instruction::OR_INT: 2441 case Instruction::XOR_INT: 2442 work_line_->CheckBinaryOp(inst, reg_types_.Integer(), reg_types_.Integer(), 2443 reg_types_.Integer(), true); 2444 break; 2445 case Instruction::ADD_LONG: 2446 case Instruction::SUB_LONG: 2447 case Instruction::MUL_LONG: 2448 case Instruction::DIV_LONG: 2449 case Instruction::REM_LONG: 2450 case Instruction::AND_LONG: 2451 case Instruction::OR_LONG: 2452 case Instruction::XOR_LONG: 2453 work_line_->CheckBinaryOpWide(inst, reg_types_.LongLo(), reg_types_.LongHi(), 2454 reg_types_.LongLo(), reg_types_.LongHi(), 2455 reg_types_.LongLo(), reg_types_.LongHi()); 2456 break; 2457 case Instruction::SHL_LONG: 2458 case Instruction::SHR_LONG: 2459 case Instruction::USHR_LONG: 2460 /* shift distance is Int, making these different from other binary operations */ 2461 work_line_->CheckBinaryOpWideShift(inst, reg_types_.LongLo(), reg_types_.LongHi(), 2462 reg_types_.Integer()); 2463 break; 2464 case Instruction::ADD_FLOAT: 2465 case Instruction::SUB_FLOAT: 2466 case Instruction::MUL_FLOAT: 2467 case Instruction::DIV_FLOAT: 2468 case Instruction::REM_FLOAT: 2469 work_line_->CheckBinaryOp(inst, 2470 reg_types_.Float(), 2471 reg_types_.Float(), 2472 reg_types_.Float(), 2473 false); 2474 break; 2475 case Instruction::ADD_DOUBLE: 2476 case Instruction::SUB_DOUBLE: 2477 case Instruction::MUL_DOUBLE: 2478 case Instruction::DIV_DOUBLE: 2479 case Instruction::REM_DOUBLE: 2480 work_line_->CheckBinaryOpWide(inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2481 reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2482 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2483 break; 2484 case Instruction::ADD_INT_2ADDR: 2485 case Instruction::SUB_INT_2ADDR: 2486 case Instruction::MUL_INT_2ADDR: 2487 case Instruction::REM_INT_2ADDR: 2488 case Instruction::SHL_INT_2ADDR: 2489 case Instruction::SHR_INT_2ADDR: 2490 case Instruction::USHR_INT_2ADDR: 2491 work_line_->CheckBinaryOp2addr(inst, 2492 reg_types_.Integer(), 2493 reg_types_.Integer(), 2494 reg_types_.Integer(), 2495 false); 2496 break; 2497 case Instruction::AND_INT_2ADDR: 2498 case Instruction::OR_INT_2ADDR: 2499 case Instruction::XOR_INT_2ADDR: 2500 work_line_->CheckBinaryOp2addr(inst, 2501 reg_types_.Integer(), 2502 reg_types_.Integer(), 2503 reg_types_.Integer(), 2504 true); 2505 break; 2506 case Instruction::DIV_INT_2ADDR: 2507 work_line_->CheckBinaryOp2addr(inst, 2508 reg_types_.Integer(), 2509 reg_types_.Integer(), 2510 reg_types_.Integer(), 2511 false); 2512 break; 2513 case Instruction::ADD_LONG_2ADDR: 2514 case Instruction::SUB_LONG_2ADDR: 2515 case Instruction::MUL_LONG_2ADDR: 2516 case Instruction::DIV_LONG_2ADDR: 2517 case Instruction::REM_LONG_2ADDR: 2518 case Instruction::AND_LONG_2ADDR: 2519 case Instruction::OR_LONG_2ADDR: 2520 case Instruction::XOR_LONG_2ADDR: 2521 work_line_->CheckBinaryOp2addrWide(inst, reg_types_.LongLo(), reg_types_.LongHi(), 2522 reg_types_.LongLo(), reg_types_.LongHi(), 2523 reg_types_.LongLo(), reg_types_.LongHi()); 2524 break; 2525 case Instruction::SHL_LONG_2ADDR: 2526 case Instruction::SHR_LONG_2ADDR: 2527 case Instruction::USHR_LONG_2ADDR: 2528 work_line_->CheckBinaryOp2addrWideShift(inst, reg_types_.LongLo(), reg_types_.LongHi(), 2529 reg_types_.Integer()); 2530 break; 2531 case Instruction::ADD_FLOAT_2ADDR: 2532 case Instruction::SUB_FLOAT_2ADDR: 2533 case Instruction::MUL_FLOAT_2ADDR: 2534 case Instruction::DIV_FLOAT_2ADDR: 2535 case Instruction::REM_FLOAT_2ADDR: 2536 work_line_->CheckBinaryOp2addr(inst, 2537 reg_types_.Float(), 2538 reg_types_.Float(), 2539 reg_types_.Float(), 2540 false); 2541 break; 2542 case Instruction::ADD_DOUBLE_2ADDR: 2543 case Instruction::SUB_DOUBLE_2ADDR: 2544 case Instruction::MUL_DOUBLE_2ADDR: 2545 case Instruction::DIV_DOUBLE_2ADDR: 2546 case Instruction::REM_DOUBLE_2ADDR: 2547 work_line_->CheckBinaryOp2addrWide(inst, reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2548 reg_types_.DoubleLo(), reg_types_.DoubleHi(), 2549 reg_types_.DoubleLo(), reg_types_.DoubleHi()); 2550 break; 2551 case Instruction::ADD_INT_LIT16: 2552 case Instruction::RSUB_INT: 2553 case Instruction::MUL_INT_LIT16: 2554 case Instruction::DIV_INT_LIT16: 2555 case Instruction::REM_INT_LIT16: 2556 work_line_->CheckLiteralOp(inst, reg_types_.Integer(), reg_types_.Integer(), false, true); 2557 break; 2558 case Instruction::AND_INT_LIT16: 2559 case Instruction::OR_INT_LIT16: 2560 case Instruction::XOR_INT_LIT16: 2561 work_line_->CheckLiteralOp(inst, reg_types_.Integer(), reg_types_.Integer(), true, true); 2562 break; 2563 case Instruction::ADD_INT_LIT8: 2564 case Instruction::RSUB_INT_LIT8: 2565 case Instruction::MUL_INT_LIT8: 2566 case Instruction::DIV_INT_LIT8: 2567 case Instruction::REM_INT_LIT8: 2568 case Instruction::SHL_INT_LIT8: 2569 case Instruction::SHR_INT_LIT8: 2570 case Instruction::USHR_INT_LIT8: 2571 work_line_->CheckLiteralOp(inst, reg_types_.Integer(), reg_types_.Integer(), false, false); 2572 break; 2573 case Instruction::AND_INT_LIT8: 2574 case Instruction::OR_INT_LIT8: 2575 case Instruction::XOR_INT_LIT8: 2576 work_line_->CheckLiteralOp(inst, reg_types_.Integer(), reg_types_.Integer(), true, false); 2577 break; 2578 2579 // Special instructions. 2580 case Instruction::RETURN_VOID_BARRIER: 2581 if (!IsConstructor() || IsStatic()) { 2582 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "return-void-barrier not expected"; 2583 } 2584 break; 2585 // Note: the following instructions encode offsets derived from class linking. 2586 // As such they use Class*/Field*/AbstractMethod* as these offsets only have 2587 // meaning if the class linking and resolution were successful. 2588 case Instruction::IGET_QUICK: 2589 VerifyIGetQuick(inst, reg_types_.Integer(), true); 2590 break; 2591 case Instruction::IGET_WIDE_QUICK: 2592 VerifyIGetQuick(inst, reg_types_.LongLo(), true); 2593 break; 2594 case Instruction::IGET_OBJECT_QUICK: 2595 VerifyIGetQuick(inst, reg_types_.JavaLangObject(false), false); 2596 break; 2597 case Instruction::IPUT_QUICK: 2598 VerifyIPutQuick(inst, reg_types_.Integer(), true); 2599 break; 2600 case Instruction::IPUT_WIDE_QUICK: 2601 VerifyIPutQuick(inst, reg_types_.LongLo(), true); 2602 break; 2603 case Instruction::IPUT_OBJECT_QUICK: 2604 VerifyIPutQuick(inst, reg_types_.JavaLangObject(false), false); 2605 break; 2606 case Instruction::INVOKE_VIRTUAL_QUICK: 2607 case Instruction::INVOKE_VIRTUAL_RANGE_QUICK: { 2608 bool is_range = (inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK); 2609 mirror::ArtMethod* called_method = VerifyInvokeVirtualQuickArgs(inst, is_range); 2610 if (called_method != NULL) { 2611 const char* descriptor = called_method->GetReturnTypeDescriptor(); 2612 const RegType& return_type = reg_types_.FromDescriptor(class_loader_->Get(), descriptor, 2613 false); 2614 if (!return_type.IsLowHalf()) { 2615 work_line_->SetResultRegisterType(return_type); 2616 } else { 2617 work_line_->SetResultRegisterTypeWide(return_type, return_type.HighHalf(®_types_)); 2618 } 2619 just_set_result = true; 2620 } 2621 break; 2622 } 2623 2624 /* These should never appear during verification. */ 2625 case Instruction::UNUSED_3E: 2626 case Instruction::UNUSED_3F: 2627 case Instruction::UNUSED_40: 2628 case Instruction::UNUSED_41: 2629 case Instruction::UNUSED_42: 2630 case Instruction::UNUSED_43: 2631 case Instruction::UNUSED_79: 2632 case Instruction::UNUSED_7A: 2633 case Instruction::UNUSED_EB: 2634 case Instruction::UNUSED_EC: 2635 case Instruction::UNUSED_ED: 2636 case Instruction::UNUSED_EE: 2637 case Instruction::UNUSED_EF: 2638 case Instruction::UNUSED_F0: 2639 case Instruction::UNUSED_F1: 2640 case Instruction::UNUSED_F2: 2641 case Instruction::UNUSED_F3: 2642 case Instruction::UNUSED_F4: 2643 case Instruction::UNUSED_F5: 2644 case Instruction::UNUSED_F6: 2645 case Instruction::UNUSED_F7: 2646 case Instruction::UNUSED_F8: 2647 case Instruction::UNUSED_F9: 2648 case Instruction::UNUSED_FA: 2649 case Instruction::UNUSED_FB: 2650 case Instruction::UNUSED_FC: 2651 case Instruction::UNUSED_FD: 2652 case Instruction::UNUSED_FE: 2653 case Instruction::UNUSED_FF: 2654 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Unexpected opcode " << inst->DumpString(dex_file_); 2655 break; 2656 2657 /* 2658 * DO NOT add a "default" clause here. Without it the compiler will 2659 * complain if an instruction is missing (which is desirable). 2660 */ 2661 } // end - switch (dec_insn.opcode) 2662 2663 if (have_pending_hard_failure_) { 2664 if (Runtime::Current()->IsCompiler()) { 2665 /* When compiling, check that the last failure is a hard failure */ 2666 CHECK_EQ(failures_[failures_.size() - 1], VERIFY_ERROR_BAD_CLASS_HARD); 2667 } 2668 /* immediate failure, reject class */ 2669 info_messages_ << "Rejecting opcode " << inst->DumpString(dex_file_); 2670 return false; 2671 } else if (have_pending_runtime_throw_failure_) { 2672 /* checking interpreter will throw, mark following code as unreachable */ 2673 opcode_flags = Instruction::kThrow; 2674 } 2675 /* 2676 * If we didn't just set the result register, clear it out. This ensures that you can only use 2677 * "move-result" immediately after the result is set. (We could check this statically, but it's 2678 * not expensive and it makes our debugging output cleaner.) 2679 */ 2680 if (!just_set_result) { 2681 work_line_->SetResultTypeToUnknown(); 2682 } 2683 2684 2685 2686 /* 2687 * Handle "branch". Tag the branch target. 2688 * 2689 * NOTE: instructions like Instruction::EQZ provide information about the 2690 * state of the register when the branch is taken or not taken. For example, 2691 * somebody could get a reference field, check it for zero, and if the 2692 * branch is taken immediately store that register in a boolean field 2693 * since the value is known to be zero. We do not currently account for 2694 * that, and will reject the code. 2695 * 2696 * TODO: avoid re-fetching the branch target 2697 */ 2698 if ((opcode_flags & Instruction::kBranch) != 0) { 2699 bool isConditional, selfOkay; 2700 if (!GetBranchOffset(work_insn_idx_, &branch_target, &isConditional, &selfOkay)) { 2701 /* should never happen after static verification */ 2702 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "bad branch"; 2703 return false; 2704 } 2705 DCHECK_EQ(isConditional, (opcode_flags & Instruction::kContinue) != 0); 2706 if (!CheckNotMoveException(code_item_->insns_, work_insn_idx_ + branch_target)) { 2707 return false; 2708 } 2709 /* update branch target, set "changed" if appropriate */ 2710 if (NULL != branch_line.get()) { 2711 if (!UpdateRegisters(work_insn_idx_ + branch_target, branch_line.get(), false)) { 2712 return false; 2713 } 2714 } else { 2715 if (!UpdateRegisters(work_insn_idx_ + branch_target, work_line_.get(), false)) { 2716 return false; 2717 } 2718 } 2719 } 2720 2721 /* 2722 * Handle "switch". Tag all possible branch targets. 2723 * 2724 * We've already verified that the table is structurally sound, so we 2725 * just need to walk through and tag the targets. 2726 */ 2727 if ((opcode_flags & Instruction::kSwitch) != 0) { 2728 int offset_to_switch = insns[1] | (((int32_t) insns[2]) << 16); 2729 const uint16_t* switch_insns = insns + offset_to_switch; 2730 int switch_count = switch_insns[1]; 2731 int offset_to_targets, targ; 2732 2733 if ((*insns & 0xff) == Instruction::PACKED_SWITCH) { 2734 /* 0 = sig, 1 = count, 2/3 = first key */ 2735 offset_to_targets = 4; 2736 } else { 2737 /* 0 = sig, 1 = count, 2..count * 2 = keys */ 2738 DCHECK((*insns & 0xff) == Instruction::SPARSE_SWITCH); 2739 offset_to_targets = 2 + 2 * switch_count; 2740 } 2741 2742 /* verify each switch target */ 2743 for (targ = 0; targ < switch_count; targ++) { 2744 int offset; 2745 uint32_t abs_offset; 2746 2747 /* offsets are 32-bit, and only partly endian-swapped */ 2748 offset = switch_insns[offset_to_targets + targ * 2] | 2749 (((int32_t) switch_insns[offset_to_targets + targ * 2 + 1]) << 16); 2750 abs_offset = work_insn_idx_ + offset; 2751 DCHECK_LT(abs_offset, code_item_->insns_size_in_code_units_); 2752 if (!CheckNotMoveException(code_item_->insns_, abs_offset)) { 2753 return false; 2754 } 2755 if (!UpdateRegisters(abs_offset, work_line_.get(), false)) { 2756 return false; 2757 } 2758 } 2759 } 2760 2761 /* 2762 * Handle instructions that can throw and that are sitting in a "try" block. (If they're not in a 2763 * "try" block when they throw, control transfers out of the method.) 2764 */ 2765 if ((opcode_flags & Instruction::kThrow) != 0 && insn_flags_[work_insn_idx_].IsInTry()) { 2766 bool within_catch_all = false; 2767 CatchHandlerIterator iterator(*code_item_, work_insn_idx_); 2768 2769 for (; iterator.HasNext(); iterator.Next()) { 2770 if (iterator.GetHandlerTypeIndex() == DexFile::kDexNoIndex16) { 2771 within_catch_all = true; 2772 } 2773 /* 2774 * Merge registers into the "catch" block. We want to use the "savedRegs" rather than 2775 * "work_regs", because at runtime the exception will be thrown before the instruction 2776 * modifies any registers. 2777 */ 2778 if (!UpdateRegisters(iterator.GetHandlerAddress(), saved_line_.get(), false)) { 2779 return false; 2780 } 2781 } 2782 2783 /* 2784 * If the monitor stack depth is nonzero, there must be a "catch all" handler for this 2785 * instruction. This does apply to monitor-exit because of async exception handling. 2786 */ 2787 if (work_line_->MonitorStackDepth() > 0 && !within_catch_all) { 2788 /* 2789 * The state in work_line reflects the post-execution state. If the current instruction is a 2790 * monitor-enter and the monitor stack was empty, we don't need a catch-all (if it throws, 2791 * it will do so before grabbing the lock). 2792 */ 2793 if (inst->Opcode() != Instruction::MONITOR_ENTER || work_line_->MonitorStackDepth() != 1) { 2794 Fail(VERIFY_ERROR_BAD_CLASS_HARD) 2795 << "expected to be within a catch-all for an instruction where a monitor is held"; 2796 return false; 2797 } 2798 } 2799 } 2800 2801 /* Handle "continue". Tag the next consecutive instruction. 2802 * Note: Keep the code handling "continue" case below the "branch" and "switch" cases, 2803 * because it changes work_line_ when performing peephole optimization 2804 * and this change should not be used in those cases. 2805 */ 2806 if ((opcode_flags & Instruction::kContinue) != 0) { 2807 uint32_t next_insn_idx = work_insn_idx_ + CurrentInsnFlags()->GetLengthInCodeUnits(); 2808 if (next_insn_idx >= code_item_->insns_size_in_code_units_) { 2809 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Execution can walk off end of code area"; 2810 return false; 2811 } 2812 // The only way to get to a move-exception instruction is to get thrown there. Make sure the 2813 // next instruction isn't one. 2814 if (!CheckNotMoveException(code_item_->insns_, next_insn_idx)) { 2815 return false; 2816 } 2817 if (NULL != fallthrough_line.get()) { 2818 // Make workline consistent with fallthrough computed from peephole optimization. 2819 work_line_->CopyFromLine(fallthrough_line.get()); 2820 } 2821 if (insn_flags_[next_insn_idx].IsReturn()) { 2822 // For returns we only care about the operand to the return, all other registers are dead. 2823 const Instruction* ret_inst = Instruction::At(code_item_->insns_ + next_insn_idx); 2824 Instruction::Code opcode = ret_inst->Opcode(); 2825 if ((opcode == Instruction::RETURN_VOID) || (opcode == Instruction::RETURN_VOID_BARRIER)) { 2826 work_line_->MarkAllRegistersAsConflicts(); 2827 } else { 2828 if (opcode == Instruction::RETURN_WIDE) { 2829 work_line_->MarkAllRegistersAsConflictsExceptWide(ret_inst->VRegA_11x()); 2830 } else { 2831 work_line_->MarkAllRegistersAsConflictsExcept(ret_inst->VRegA_11x()); 2832 } 2833 } 2834 } 2835 RegisterLine* next_line = reg_table_.GetLine(next_insn_idx); 2836 if (next_line != NULL) { 2837 // Merge registers into what we have for the next instruction, and set the "changed" flag if 2838 // needed. If the merge changes the state of the registers then the work line will be 2839 // updated. 2840 if (!UpdateRegisters(next_insn_idx, work_line_.get(), true)) { 2841 return false; 2842 } 2843 } else { 2844 /* 2845 * We're not recording register data for the next instruction, so we don't know what the 2846 * prior state was. We have to assume that something has changed and re-evaluate it. 2847 */ 2848 insn_flags_[next_insn_idx].SetChanged(); 2849 } 2850 } 2851 2852 /* If we're returning from the method, make sure monitor stack is empty. */ 2853 if ((opcode_flags & Instruction::kReturn) != 0) { 2854 if (!work_line_->VerifyMonitorStackEmpty()) { 2855 return false; 2856 } 2857 } 2858 2859 /* 2860 * Update start_guess. Advance to the next instruction of that's 2861 * possible, otherwise use the branch target if one was found. If 2862 * neither of those exists we're in a return or throw; leave start_guess 2863 * alone and let the caller sort it out. 2864 */ 2865 if ((opcode_flags & Instruction::kContinue) != 0) { 2866 *start_guess = work_insn_idx_ + insn_flags_[work_insn_idx_].GetLengthInCodeUnits(); 2867 } else if ((opcode_flags & Instruction::kBranch) != 0) { 2868 /* we're still okay if branch_target is zero */ 2869 *start_guess = work_insn_idx_ + branch_target; 2870 } 2871 2872 DCHECK_LT(*start_guess, code_item_->insns_size_in_code_units_); 2873 DCHECK(insn_flags_[*start_guess].IsOpcode()); 2874 2875 return true; 2876} // NOLINT(readability/fn_size) 2877 2878const RegType& MethodVerifier::ResolveClassAndCheckAccess(uint32_t class_idx) { 2879 const char* descriptor = dex_file_->StringByTypeIdx(class_idx); 2880 const RegType& referrer = GetDeclaringClass(); 2881 mirror::Class* klass = (*dex_cache_)->GetResolvedType(class_idx); 2882 const RegType& result = 2883 klass != NULL ? reg_types_.FromClass(descriptor, klass, 2884 klass->CannotBeAssignedFromOtherTypes()) 2885 : reg_types_.FromDescriptor(class_loader_->Get(), descriptor, false); 2886 if (result.IsConflict()) { 2887 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "accessing broken descriptor '" << descriptor 2888 << "' in " << referrer; 2889 return result; 2890 } 2891 if (klass == NULL && !result.IsUnresolvedTypes()) { 2892 (*dex_cache_)->SetResolvedType(class_idx, result.GetClass()); 2893 } 2894 // Check if access is allowed. Unresolved types use xxxWithAccessCheck to 2895 // check at runtime if access is allowed and so pass here. If result is 2896 // primitive, skip the access check. 2897 if (result.IsNonZeroReferenceTypes() && !result.IsUnresolvedTypes() && 2898 !referrer.IsUnresolvedTypes() && !referrer.CanAccess(result)) { 2899 Fail(VERIFY_ERROR_ACCESS_CLASS) << "illegal class access: '" 2900 << referrer << "' -> '" << result << "'"; 2901 } 2902 return result; 2903} 2904 2905const RegType& MethodVerifier::GetCaughtExceptionType() { 2906 const RegType* common_super = NULL; 2907 if (code_item_->tries_size_ != 0) { 2908 const byte* handlers_ptr = DexFile::GetCatchHandlerData(*code_item_, 0); 2909 uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr); 2910 for (uint32_t i = 0; i < handlers_size; i++) { 2911 CatchHandlerIterator iterator(handlers_ptr); 2912 for (; iterator.HasNext(); iterator.Next()) { 2913 if (iterator.GetHandlerAddress() == (uint32_t) work_insn_idx_) { 2914 if (iterator.GetHandlerTypeIndex() == DexFile::kDexNoIndex16) { 2915 common_super = ®_types_.JavaLangThrowable(false); 2916 } else { 2917 const RegType& exception = ResolveClassAndCheckAccess(iterator.GetHandlerTypeIndex()); 2918 if (!reg_types_.JavaLangThrowable(false).IsAssignableFrom(exception)) { 2919 if (exception.IsUnresolvedTypes()) { 2920 // We don't know enough about the type. Fail here and let runtime handle it. 2921 Fail(VERIFY_ERROR_NO_CLASS) << "unresolved exception class " << exception; 2922 return exception; 2923 } else { 2924 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "unexpected non-exception class " << exception; 2925 return reg_types_.Conflict(); 2926 } 2927 } else if (common_super == nullptr) { 2928 common_super = &exception; 2929 } else if (common_super->Equals(exception)) { 2930 // odd case, but nothing to do 2931 } else { 2932 common_super = &common_super->Merge(exception, ®_types_); 2933 CHECK(reg_types_.JavaLangThrowable(false).IsAssignableFrom(*common_super)); 2934 } 2935 } 2936 } 2937 } 2938 handlers_ptr = iterator.EndDataPointer(); 2939 } 2940 } 2941 if (common_super == NULL) { 2942 /* no catch blocks, or no catches with classes we can find */ 2943 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "unable to find exception handler"; 2944 return reg_types_.Conflict(); 2945 } 2946 return *common_super; 2947} 2948 2949mirror::ArtMethod* MethodVerifier::ResolveMethodAndCheckAccess(uint32_t dex_method_idx, 2950 MethodType method_type) { 2951 const DexFile::MethodId& method_id = dex_file_->GetMethodId(dex_method_idx); 2952 const RegType& klass_type = ResolveClassAndCheckAccess(method_id.class_idx_); 2953 if (klass_type.IsConflict()) { 2954 std::string append(" in attempt to access method "); 2955 append += dex_file_->GetMethodName(method_id); 2956 AppendToLastFailMessage(append); 2957 return NULL; 2958 } 2959 if (klass_type.IsUnresolvedTypes()) { 2960 return NULL; // Can't resolve Class so no more to do here 2961 } 2962 mirror::Class* klass = klass_type.GetClass(); 2963 const RegType& referrer = GetDeclaringClass(); 2964 mirror::ArtMethod* res_method = (*dex_cache_)->GetResolvedMethod(dex_method_idx); 2965 if (res_method == NULL) { 2966 const char* name = dex_file_->GetMethodName(method_id); 2967 const Signature signature = dex_file_->GetMethodSignature(method_id); 2968 2969 if (method_type == METHOD_DIRECT || method_type == METHOD_STATIC) { 2970 res_method = klass->FindDirectMethod(name, signature); 2971 } else if (method_type == METHOD_INTERFACE) { 2972 res_method = klass->FindInterfaceMethod(name, signature); 2973 } else { 2974 res_method = klass->FindVirtualMethod(name, signature); 2975 } 2976 if (res_method != NULL) { 2977 (*dex_cache_)->SetResolvedMethod(dex_method_idx, res_method); 2978 } else { 2979 // If a virtual or interface method wasn't found with the expected type, look in 2980 // the direct methods. This can happen when the wrong invoke type is used or when 2981 // a class has changed, and will be flagged as an error in later checks. 2982 if (method_type == METHOD_INTERFACE || method_type == METHOD_VIRTUAL) { 2983 res_method = klass->FindDirectMethod(name, signature); 2984 } 2985 if (res_method == NULL) { 2986 Fail(VERIFY_ERROR_NO_METHOD) << "couldn't find method " 2987 << PrettyDescriptor(klass) << "." << name 2988 << " " << signature; 2989 return NULL; 2990 } 2991 } 2992 } 2993 // Make sure calls to constructors are "direct". There are additional restrictions but we don't 2994 // enforce them here. 2995 if (res_method->IsConstructor() && method_type != METHOD_DIRECT) { 2996 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "rejecting non-direct call to constructor " 2997 << PrettyMethod(res_method); 2998 return NULL; 2999 } 3000 // Disallow any calls to class initializers. 3001 if (res_method->IsClassInitializer()) { 3002 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "rejecting call to class initializer " 3003 << PrettyMethod(res_method); 3004 return NULL; 3005 } 3006 // Check if access is allowed. 3007 if (!referrer.CanAccessMember(res_method->GetDeclaringClass(), res_method->GetAccessFlags())) { 3008 Fail(VERIFY_ERROR_ACCESS_METHOD) << "illegal method access (call " << PrettyMethod(res_method) 3009 << " from " << referrer << ")"; 3010 return res_method; 3011 } 3012 // Check that invoke-virtual and invoke-super are not used on private methods of the same class. 3013 if (res_method->IsPrivate() && method_type == METHOD_VIRTUAL) { 3014 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invoke-super/virtual can't be used on private method " 3015 << PrettyMethod(res_method); 3016 return NULL; 3017 } 3018 // Check that interface methods match interface classes. 3019 if (klass->IsInterface() && method_type != METHOD_INTERFACE) { 3020 Fail(VERIFY_ERROR_CLASS_CHANGE) << "non-interface method " << PrettyMethod(res_method) 3021 << " is in an interface class " << PrettyClass(klass); 3022 return NULL; 3023 } else if (!klass->IsInterface() && method_type == METHOD_INTERFACE) { 3024 Fail(VERIFY_ERROR_CLASS_CHANGE) << "interface method " << PrettyMethod(res_method) 3025 << " is in a non-interface class " << PrettyClass(klass); 3026 return NULL; 3027 } 3028 // See if the method type implied by the invoke instruction matches the access flags for the 3029 // target method. 3030 if ((method_type == METHOD_DIRECT && !res_method->IsDirect()) || 3031 (method_type == METHOD_STATIC && !res_method->IsStatic()) || 3032 ((method_type == METHOD_VIRTUAL || method_type == METHOD_INTERFACE) && res_method->IsDirect()) 3033 ) { 3034 Fail(VERIFY_ERROR_CLASS_CHANGE) << "invoke type (" << method_type << ") does not match method " 3035 " type of " << PrettyMethod(res_method); 3036 return NULL; 3037 } 3038 return res_method; 3039} 3040 3041template <class T> 3042mirror::ArtMethod* MethodVerifier::VerifyInvocationArgsFromIterator(T* it, const Instruction* inst, 3043 MethodType method_type, 3044 bool is_range, 3045 mirror::ArtMethod* res_method) { 3046 // We use vAA as our expected arg count, rather than res_method->insSize, because we need to 3047 // match the call to the signature. Also, we might be calling through an abstract method 3048 // definition (which doesn't have register count values). 3049 const size_t expected_args = (is_range) ? inst->VRegA_3rc() : inst->VRegA_35c(); 3050 /* caught by static verifier */ 3051 DCHECK(is_range || expected_args <= 5); 3052 if (expected_args > code_item_->outs_size_) { 3053 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid argument count (" << expected_args 3054 << ") exceeds outsSize (" << code_item_->outs_size_ << ")"; 3055 return nullptr; 3056 } 3057 3058 uint32_t arg[5]; 3059 if (!is_range) { 3060 inst->GetVarArgs(arg); 3061 } 3062 uint32_t sig_registers = 0; 3063 3064 /* 3065 * Check the "this" argument, which must be an instance of the class that declared the method. 3066 * For an interface class, we don't do the full interface merge (see JoinClass), so we can't do a 3067 * rigorous check here (which is okay since we have to do it at runtime). 3068 */ 3069 if (method_type != METHOD_STATIC) { 3070 const RegType& actual_arg_type = work_line_->GetInvocationThis(inst, is_range); 3071 if (actual_arg_type.IsConflict()) { // GetInvocationThis failed. 3072 CHECK(have_pending_hard_failure_); 3073 return nullptr; 3074 } 3075 if (actual_arg_type.IsUninitializedReference()) { 3076 if (res_method) { 3077 if (!res_method->IsConstructor()) { 3078 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "'this' arg must be initialized"; 3079 return nullptr; 3080 } 3081 } else { 3082 // Check whether the name of the called method is "<init>" 3083 const uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 3084 if (strcmp(dex_file_->GetMethodName(dex_file_->GetMethodId(method_idx)), "init") != 0) { 3085 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "'this' arg must be initialized"; 3086 return nullptr; 3087 } 3088 } 3089 } 3090 if (method_type != METHOD_INTERFACE && !actual_arg_type.IsZero()) { 3091 const RegType* res_method_class; 3092 if (res_method != nullptr) { 3093 mirror::Class* klass = res_method->GetDeclaringClass(); 3094 res_method_class = ®_types_.FromClass(klass->GetDescriptor().c_str(), klass, 3095 klass->CannotBeAssignedFromOtherTypes()); 3096 } else { 3097 const uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 3098 const uint16_t class_idx = dex_file_->GetMethodId(method_idx).class_idx_; 3099 res_method_class = ®_types_.FromDescriptor(class_loader_->Get(), 3100 dex_file_->StringByTypeIdx(class_idx), 3101 false); 3102 } 3103 if (!res_method_class->IsAssignableFrom(actual_arg_type)) { 3104 Fail(actual_arg_type.IsUnresolvedTypes() ? VERIFY_ERROR_NO_CLASS: 3105 VERIFY_ERROR_BAD_CLASS_SOFT) << "'this' argument '" << actual_arg_type 3106 << "' not instance of '" << *res_method_class << "'"; 3107 // Continue on soft failures. We need to find possible hard failures to avoid problems in 3108 // the compiler. 3109 if (have_pending_hard_failure_) { 3110 return nullptr; 3111 } 3112 } 3113 } 3114 sig_registers = 1; 3115 } 3116 3117 for ( ; it->HasNext(); it->Next()) { 3118 if (sig_registers >= expected_args) { 3119 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation, expected " << inst->VRegA() << 3120 " arguments, found " << sig_registers << " or more."; 3121 return nullptr; 3122 } 3123 3124 const char* param_descriptor = it->GetDescriptor(); 3125 3126 if (param_descriptor == nullptr) { 3127 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation because of missing signature " 3128 "component"; 3129 return nullptr; 3130 } 3131 3132 const RegType& reg_type = reg_types_.FromDescriptor(class_loader_->Get(), param_descriptor, 3133 false); 3134 uint32_t get_reg = is_range ? inst->VRegC_3rc() + static_cast<uint32_t>(sig_registers) : 3135 arg[sig_registers]; 3136 if (reg_type.IsIntegralTypes()) { 3137 const RegType& src_type = work_line_->GetRegisterType(get_reg); 3138 if (!src_type.IsIntegralTypes()) { 3139 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "register v" << get_reg << " has type " << src_type 3140 << " but expected " << reg_type; 3141 return res_method; 3142 } 3143 } else if (!work_line_->VerifyRegisterType(get_reg, reg_type)) { 3144 // Continue on soft failures. We need to find possible hard failures to avoid problems in the 3145 // compiler. 3146 if (have_pending_hard_failure_) { 3147 return res_method; 3148 } 3149 } 3150 sig_registers += reg_type.IsLongOrDoubleTypes() ? 2 : 1; 3151 } 3152 if (expected_args != sig_registers) { 3153 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation, expected " << expected_args << 3154 " arguments, found " << sig_registers; 3155 return nullptr; 3156 } 3157 return res_method; 3158} 3159 3160void MethodVerifier::VerifyInvocationArgsUnresolvedMethod(const Instruction* inst, 3161 MethodType method_type, 3162 bool is_range) { 3163 // As the method may not have been resolved, make this static check against what we expect. 3164 // The main reason for this code block is to fail hard when we find an illegal use, e.g., 3165 // wrong number of arguments or wrong primitive types, even if the method could not be resolved. 3166 const uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 3167 DexFileParameterIterator it(*dex_file_, 3168 dex_file_->GetProtoId(dex_file_->GetMethodId(method_idx).proto_idx_)); 3169 VerifyInvocationArgsFromIterator<DexFileParameterIterator>(&it, inst, method_type, is_range, 3170 nullptr); 3171} 3172 3173class MethodParamListDescriptorIterator { 3174 public: 3175 explicit MethodParamListDescriptorIterator(mirror::ArtMethod* res_method) : 3176 res_method_(res_method), pos_(0), params_(res_method->GetParameterTypeList()), 3177 params_size_(params_ == nullptr ? 0 : params_->Size()) { 3178 } 3179 3180 bool HasNext() { 3181 return pos_ < params_size_; 3182 } 3183 3184 void Next() { 3185 ++pos_; 3186 } 3187 3188 const char* GetDescriptor() SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { 3189 return res_method_->GetTypeDescriptorFromTypeIdx(params_->GetTypeItem(pos_).type_idx_); 3190 } 3191 3192 private: 3193 mirror::ArtMethod* res_method_; 3194 size_t pos_; 3195 const DexFile::TypeList* params_; 3196 const size_t params_size_; 3197}; 3198 3199mirror::ArtMethod* MethodVerifier::VerifyInvocationArgs(const Instruction* inst, 3200 MethodType method_type, 3201 bool is_range, 3202 bool is_super) { 3203 // Resolve the method. This could be an abstract or concrete method depending on what sort of call 3204 // we're making. 3205 const uint32_t method_idx = (is_range) ? inst->VRegB_3rc() : inst->VRegB_35c(); 3206 3207 mirror::ArtMethod* res_method = ResolveMethodAndCheckAccess(method_idx, method_type); 3208 if (res_method == NULL) { // error or class is unresolved 3209 // Check what we can statically. 3210 if (!have_pending_hard_failure_) { 3211 VerifyInvocationArgsUnresolvedMethod(inst, method_type, is_range); 3212 } 3213 return nullptr; 3214 } 3215 3216 // If we're using invoke-super(method), make sure that the executing method's class' superclass 3217 // has a vtable entry for the target method. 3218 if (is_super) { 3219 DCHECK(method_type == METHOD_VIRTUAL); 3220 const RegType& super = GetDeclaringClass().GetSuperClass(®_types_); 3221 if (super.IsUnresolvedTypes()) { 3222 Fail(VERIFY_ERROR_NO_METHOD) << "unknown super class in invoke-super from " 3223 << PrettyMethod(dex_method_idx_, *dex_file_) 3224 << " to super " << PrettyMethod(res_method); 3225 return nullptr; 3226 } 3227 mirror::Class* super_klass = super.GetClass(); 3228 if (res_method->GetMethodIndex() >= super_klass->GetVTable()->GetLength()) { 3229 Fail(VERIFY_ERROR_NO_METHOD) << "invalid invoke-super from " 3230 << PrettyMethod(dex_method_idx_, *dex_file_) 3231 << " to super " << super 3232 << "." << res_method->GetName() 3233 << res_method->GetSignature(); 3234 return nullptr; 3235 } 3236 } 3237 3238 // Process the target method's signature. This signature may or may not 3239 MethodParamListDescriptorIterator it(res_method); 3240 return VerifyInvocationArgsFromIterator<MethodParamListDescriptorIterator>(&it, inst, method_type, 3241 is_range, res_method); 3242} 3243 3244mirror::ArtMethod* MethodVerifier::GetQuickInvokedMethod(const Instruction* inst, 3245 RegisterLine* reg_line, bool is_range) { 3246 DCHECK(inst->Opcode() == Instruction::INVOKE_VIRTUAL_QUICK || 3247 inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK); 3248 const RegType& actual_arg_type = reg_line->GetInvocationThis(inst, is_range); 3249 if (!actual_arg_type.HasClass()) { 3250 VLOG(verifier) << "Failed to get mirror::Class* from '" << actual_arg_type << "'"; 3251 return nullptr; 3252 } 3253 mirror::ObjectArray<mirror::ArtMethod>* vtable = nullptr; 3254 mirror::Class* klass = actual_arg_type.GetClass(); 3255 if (klass->IsInterface()) { 3256 // Derive Object.class from Class.class.getSuperclass(). 3257 mirror::Class* object_klass = klass->GetClass()->GetSuperClass(); 3258 CHECK(object_klass->IsObjectClass()); 3259 vtable = object_klass->GetVTable(); 3260 } else { 3261 vtable = klass->GetVTable(); 3262 } 3263 CHECK(vtable != nullptr) << PrettyDescriptor(klass); 3264 uint16_t vtable_index = is_range ? inst->VRegB_3rc() : inst->VRegB_35c(); 3265 CHECK_LT(static_cast<int32_t>(vtable_index), vtable->GetLength()) << PrettyDescriptor(klass); 3266 mirror::ArtMethod* res_method = vtable->Get(vtable_index); 3267 CHECK(!Thread::Current()->IsExceptionPending()); 3268 return res_method; 3269} 3270 3271mirror::ArtMethod* MethodVerifier::VerifyInvokeVirtualQuickArgs(const Instruction* inst, 3272 bool is_range) { 3273 DCHECK(Runtime::Current()->IsStarted()); 3274 mirror::ArtMethod* res_method = GetQuickInvokedMethod(inst, work_line_.get(), 3275 is_range); 3276 if (res_method == NULL) { 3277 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Cannot infer method from " << inst->Name(); 3278 return NULL; 3279 } 3280 CHECK(!res_method->IsDirect() && !res_method->IsStatic()); 3281 3282 // We use vAA as our expected arg count, rather than res_method->insSize, because we need to 3283 // match the call to the signature. Also, we might be calling through an abstract method 3284 // definition (which doesn't have register count values). 3285 const RegType& actual_arg_type = work_line_->GetInvocationThis(inst, is_range); 3286 if (actual_arg_type.IsConflict()) { // GetInvocationThis failed. 3287 return NULL; 3288 } 3289 const size_t expected_args = (is_range) ? inst->VRegA_3rc() : inst->VRegA_35c(); 3290 /* caught by static verifier */ 3291 DCHECK(is_range || expected_args <= 5); 3292 if (expected_args > code_item_->outs_size_) { 3293 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid argument count (" << expected_args 3294 << ") exceeds outsSize (" << code_item_->outs_size_ << ")"; 3295 return NULL; 3296 } 3297 3298 /* 3299 * Check the "this" argument, which must be an instance of the class that declared the method. 3300 * For an interface class, we don't do the full interface merge (see JoinClass), so we can't do a 3301 * rigorous check here (which is okay since we have to do it at runtime). 3302 */ 3303 if (actual_arg_type.IsUninitializedReference() && !res_method->IsConstructor()) { 3304 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "'this' arg must be initialized"; 3305 return NULL; 3306 } 3307 if (!actual_arg_type.IsZero()) { 3308 mirror::Class* klass = res_method->GetDeclaringClass(); 3309 const RegType& res_method_class = 3310 reg_types_.FromClass(klass->GetDescriptor().c_str(), klass, 3311 klass->CannotBeAssignedFromOtherTypes()); 3312 if (!res_method_class.IsAssignableFrom(actual_arg_type)) { 3313 Fail(actual_arg_type.IsUnresolvedTypes() ? VERIFY_ERROR_NO_CLASS : 3314 VERIFY_ERROR_BAD_CLASS_SOFT) << "'this' argument '" << actual_arg_type 3315 << "' not instance of '" << res_method_class << "'"; 3316 return NULL; 3317 } 3318 } 3319 /* 3320 * Process the target method's signature. This signature may or may not 3321 * have been verified, so we can't assume it's properly formed. 3322 */ 3323 const DexFile::TypeList* params = res_method->GetParameterTypeList(); 3324 size_t params_size = params == NULL ? 0 : params->Size(); 3325 uint32_t arg[5]; 3326 if (!is_range) { 3327 inst->GetVarArgs(arg); 3328 } 3329 size_t actual_args = 1; 3330 for (size_t param_index = 0; param_index < params_size; param_index++) { 3331 if (actual_args >= expected_args) { 3332 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invalid call to '" << PrettyMethod(res_method) 3333 << "'. Expected " << expected_args 3334 << " arguments, processing argument " << actual_args 3335 << " (where longs/doubles count twice)."; 3336 return NULL; 3337 } 3338 const char* descriptor = 3339 res_method->GetTypeDescriptorFromTypeIdx(params->GetTypeItem(param_index).type_idx_); 3340 if (descriptor == NULL) { 3341 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation of " << PrettyMethod(res_method) 3342 << " missing signature component"; 3343 return NULL; 3344 } 3345 const RegType& reg_type = reg_types_.FromDescriptor(class_loader_->Get(), descriptor, false); 3346 uint32_t get_reg = is_range ? inst->VRegC_3rc() + actual_args : arg[actual_args]; 3347 if (!work_line_->VerifyRegisterType(get_reg, reg_type)) { 3348 return res_method; 3349 } 3350 actual_args = reg_type.IsLongOrDoubleTypes() ? actual_args + 2 : actual_args + 1; 3351 } 3352 if (actual_args != expected_args) { 3353 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Rejecting invocation of " << PrettyMethod(res_method) 3354 << " expected " << expected_args << " arguments, found " << actual_args; 3355 return NULL; 3356 } else { 3357 return res_method; 3358 } 3359} 3360 3361void MethodVerifier::VerifyNewArray(const Instruction* inst, bool is_filled, bool is_range) { 3362 uint32_t type_idx; 3363 if (!is_filled) { 3364 DCHECK_EQ(inst->Opcode(), Instruction::NEW_ARRAY); 3365 type_idx = inst->VRegC_22c(); 3366 } else if (!is_range) { 3367 DCHECK_EQ(inst->Opcode(), Instruction::FILLED_NEW_ARRAY); 3368 type_idx = inst->VRegB_35c(); 3369 } else { 3370 DCHECK_EQ(inst->Opcode(), Instruction::FILLED_NEW_ARRAY_RANGE); 3371 type_idx = inst->VRegB_3rc(); 3372 } 3373 const RegType& res_type = ResolveClassAndCheckAccess(type_idx); 3374 if (res_type.IsConflict()) { // bad class 3375 DCHECK_NE(failures_.size(), 0U); 3376 } else { 3377 // TODO: check Compiler::CanAccessTypeWithoutChecks returns false when res_type is unresolved 3378 if (!res_type.IsArrayTypes()) { 3379 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "new-array on non-array class " << res_type; 3380 } else if (!is_filled) { 3381 /* make sure "size" register is valid type */ 3382 work_line_->VerifyRegisterType(inst->VRegB_22c(), reg_types_.Integer()); 3383 /* set register type to array class */ 3384 const RegType& precise_type = reg_types_.FromUninitialized(res_type); 3385 work_line_->SetRegisterType(inst->VRegA_22c(), precise_type); 3386 } else { 3387 // Verify each register. If "arg_count" is bad, VerifyRegisterType() will run off the end of 3388 // the list and fail. It's legal, if silly, for arg_count to be zero. 3389 const RegType& expected_type = reg_types_.GetComponentType(res_type, class_loader_->Get()); 3390 uint32_t arg_count = (is_range) ? inst->VRegA_3rc() : inst->VRegA_35c(); 3391 uint32_t arg[5]; 3392 if (!is_range) { 3393 inst->GetVarArgs(arg); 3394 } 3395 for (size_t ui = 0; ui < arg_count; ui++) { 3396 uint32_t get_reg = is_range ? inst->VRegC_3rc() + ui : arg[ui]; 3397 if (!work_line_->VerifyRegisterType(get_reg, expected_type)) { 3398 work_line_->SetResultRegisterType(reg_types_.Conflict()); 3399 return; 3400 } 3401 } 3402 // filled-array result goes into "result" register 3403 const RegType& precise_type = reg_types_.FromUninitialized(res_type); 3404 work_line_->SetResultRegisterType(precise_type); 3405 } 3406 } 3407} 3408 3409void MethodVerifier::VerifyAGet(const Instruction* inst, 3410 const RegType& insn_type, bool is_primitive) { 3411 const RegType& index_type = work_line_->GetRegisterType(inst->VRegC_23x()); 3412 if (!index_type.IsArrayIndexTypes()) { 3413 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Invalid reg type for array index (" << index_type << ")"; 3414 } else { 3415 const RegType& array_type = work_line_->GetRegisterType(inst->VRegB_23x()); 3416 if (array_type.IsZero()) { 3417 // Null array class; this code path will fail at runtime. Infer a merge-able type from the 3418 // instruction type. TODO: have a proper notion of bottom here. 3419 if (!is_primitive || insn_type.IsCategory1Types()) { 3420 // Reference or category 1 3421 work_line_->SetRegisterType(inst->VRegA_23x(), reg_types_.Zero()); 3422 } else { 3423 // Category 2 3424 work_line_->SetRegisterTypeWide(inst->VRegA_23x(), reg_types_.FromCat2ConstLo(0, false), 3425 reg_types_.FromCat2ConstHi(0, false)); 3426 } 3427 } else if (!array_type.IsArrayTypes()) { 3428 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "not array type " << array_type << " with aget"; 3429 } else { 3430 /* verify the class */ 3431 const RegType& component_type = reg_types_.GetComponentType(array_type, class_loader_->Get()); 3432 if (!component_type.IsReferenceTypes() && !is_primitive) { 3433 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "primitive array type " << array_type 3434 << " source for aget-object"; 3435 } else if (component_type.IsNonZeroReferenceTypes() && is_primitive) { 3436 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "reference array type " << array_type 3437 << " source for category 1 aget"; 3438 } else if (is_primitive && !insn_type.Equals(component_type) && 3439 !((insn_type.IsInteger() && component_type.IsFloat()) || 3440 (insn_type.IsLong() && component_type.IsDouble()))) { 3441 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "array type " << array_type 3442 << " incompatible with aget of type " << insn_type; 3443 } else { 3444 // Use knowledge of the field type which is stronger than the type inferred from the 3445 // instruction, which can't differentiate object types and ints from floats, longs from 3446 // doubles. 3447 if (!component_type.IsLowHalf()) { 3448 work_line_->SetRegisterType(inst->VRegA_23x(), component_type); 3449 } else { 3450 work_line_->SetRegisterTypeWide(inst->VRegA_23x(), component_type, 3451 component_type.HighHalf(®_types_)); 3452 } 3453 } 3454 } 3455 } 3456} 3457 3458void MethodVerifier::VerifyPrimitivePut(const RegType& target_type, const RegType& insn_type, 3459 const uint32_t vregA) { 3460 // Primitive assignability rules are weaker than regular assignability rules. 3461 bool instruction_compatible; 3462 bool value_compatible; 3463 const RegType& value_type = work_line_->GetRegisterType(vregA); 3464 if (target_type.IsIntegralTypes()) { 3465 instruction_compatible = target_type.Equals(insn_type); 3466 value_compatible = value_type.IsIntegralTypes(); 3467 } else if (target_type.IsFloat()) { 3468 instruction_compatible = insn_type.IsInteger(); // no put-float, so expect put-int 3469 value_compatible = value_type.IsFloatTypes(); 3470 } else if (target_type.IsLong()) { 3471 instruction_compatible = insn_type.IsLong(); 3472 value_compatible = value_type.IsLongTypes(); 3473 } else if (target_type.IsDouble()) { 3474 instruction_compatible = insn_type.IsLong(); // no put-double, so expect put-long 3475 value_compatible = value_type.IsDoubleTypes(); 3476 } else { 3477 instruction_compatible = false; // reference with primitive store 3478 value_compatible = false; // unused 3479 } 3480 if (!instruction_compatible) { 3481 // This is a global failure rather than a class change failure as the instructions and 3482 // the descriptors for the type should have been consistent within the same file at 3483 // compile time. 3484 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "put insn has type '" << insn_type 3485 << "' but expected type '" << target_type << "'"; 3486 return; 3487 } 3488 if (!value_compatible) { 3489 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected value in v" << vregA 3490 << " of type " << value_type << " but expected " << target_type << " for put"; 3491 return; 3492 } 3493} 3494 3495void MethodVerifier::VerifyAPut(const Instruction* inst, 3496 const RegType& insn_type, bool is_primitive) { 3497 const RegType& index_type = work_line_->GetRegisterType(inst->VRegC_23x()); 3498 if (!index_type.IsArrayIndexTypes()) { 3499 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Invalid reg type for array index (" << index_type << ")"; 3500 } else { 3501 const RegType& array_type = work_line_->GetRegisterType(inst->VRegB_23x()); 3502 if (array_type.IsZero()) { 3503 // Null array type; this code path will fail at runtime. Infer a merge-able type from the 3504 // instruction type. 3505 } else if (!array_type.IsArrayTypes()) { 3506 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "not array type " << array_type << " with aput"; 3507 } else { 3508 const RegType& component_type = reg_types_.GetComponentType(array_type, class_loader_->Get()); 3509 const uint32_t vregA = inst->VRegA_23x(); 3510 if (is_primitive) { 3511 VerifyPrimitivePut(component_type, insn_type, vregA); 3512 } else { 3513 if (!component_type.IsReferenceTypes()) { 3514 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "primitive array type " << array_type 3515 << " source for aput-object"; 3516 } else { 3517 // The instruction agrees with the type of array, confirm the value to be stored does too 3518 // Note: we use the instruction type (rather than the component type) for aput-object as 3519 // incompatible classes will be caught at runtime as an array store exception 3520 work_line_->VerifyRegisterType(vregA, insn_type); 3521 } 3522 } 3523 } 3524 } 3525} 3526 3527mirror::ArtField* MethodVerifier::GetStaticField(int field_idx) { 3528 const DexFile::FieldId& field_id = dex_file_->GetFieldId(field_idx); 3529 // Check access to class 3530 const RegType& klass_type = ResolveClassAndCheckAccess(field_id.class_idx_); 3531 if (klass_type.IsConflict()) { // bad class 3532 AppendToLastFailMessage(StringPrintf(" in attempt to access static field %d (%s) in %s", 3533 field_idx, dex_file_->GetFieldName(field_id), 3534 dex_file_->GetFieldDeclaringClassDescriptor(field_id))); 3535 return NULL; 3536 } 3537 if (klass_type.IsUnresolvedTypes()) { 3538 return NULL; // Can't resolve Class so no more to do here, will do checking at runtime. 3539 } 3540 ClassLinker* class_linker = Runtime::Current()->GetClassLinker(); 3541 mirror::ArtField* field = class_linker->ResolveFieldJLS(*dex_file_, field_idx, *dex_cache_, 3542 *class_loader_); 3543 if (field == NULL) { 3544 VLOG(verifier) << "Unable to resolve static field " << field_idx << " (" 3545 << dex_file_->GetFieldName(field_id) << ") in " 3546 << dex_file_->GetFieldDeclaringClassDescriptor(field_id); 3547 DCHECK(Thread::Current()->IsExceptionPending()); 3548 Thread::Current()->ClearException(); 3549 return NULL; 3550 } else if (!GetDeclaringClass().CanAccessMember(field->GetDeclaringClass(), 3551 field->GetAccessFlags())) { 3552 Fail(VERIFY_ERROR_ACCESS_FIELD) << "cannot access static field " << PrettyField(field) 3553 << " from " << GetDeclaringClass(); 3554 return NULL; 3555 } else if (!field->IsStatic()) { 3556 Fail(VERIFY_ERROR_CLASS_CHANGE) << "expected field " << PrettyField(field) << " to be static"; 3557 return NULL; 3558 } 3559 return field; 3560} 3561 3562mirror::ArtField* MethodVerifier::GetInstanceField(const RegType& obj_type, int field_idx) { 3563 const DexFile::FieldId& field_id = dex_file_->GetFieldId(field_idx); 3564 // Check access to class 3565 const RegType& klass_type = ResolveClassAndCheckAccess(field_id.class_idx_); 3566 if (klass_type.IsConflict()) { 3567 AppendToLastFailMessage(StringPrintf(" in attempt to access instance field %d (%s) in %s", 3568 field_idx, dex_file_->GetFieldName(field_id), 3569 dex_file_->GetFieldDeclaringClassDescriptor(field_id))); 3570 return NULL; 3571 } 3572 if (klass_type.IsUnresolvedTypes()) { 3573 return NULL; // Can't resolve Class so no more to do here 3574 } 3575 ClassLinker* class_linker = Runtime::Current()->GetClassLinker(); 3576 mirror::ArtField* field = class_linker->ResolveFieldJLS(*dex_file_, field_idx, *dex_cache_, 3577 *class_loader_); 3578 if (field == NULL) { 3579 VLOG(verifier) << "Unable to resolve instance field " << field_idx << " (" 3580 << dex_file_->GetFieldName(field_id) << ") in " 3581 << dex_file_->GetFieldDeclaringClassDescriptor(field_id); 3582 DCHECK(Thread::Current()->IsExceptionPending()); 3583 Thread::Current()->ClearException(); 3584 return NULL; 3585 } else if (!GetDeclaringClass().CanAccessMember(field->GetDeclaringClass(), 3586 field->GetAccessFlags())) { 3587 Fail(VERIFY_ERROR_ACCESS_FIELD) << "cannot access instance field " << PrettyField(field) 3588 << " from " << GetDeclaringClass(); 3589 return NULL; 3590 } else if (field->IsStatic()) { 3591 Fail(VERIFY_ERROR_CLASS_CHANGE) << "expected field " << PrettyField(field) 3592 << " to not be static"; 3593 return NULL; 3594 } else if (obj_type.IsZero()) { 3595 // Cannot infer and check type, however, access will cause null pointer exception 3596 return field; 3597 } else { 3598 mirror::Class* klass = field->GetDeclaringClass(); 3599 const RegType& field_klass = 3600 reg_types_.FromClass(dex_file_->GetFieldDeclaringClassDescriptor(field_id), 3601 klass, klass->CannotBeAssignedFromOtherTypes()); 3602 if (obj_type.IsUninitializedTypes() && 3603 (!IsConstructor() || GetDeclaringClass().Equals(obj_type) || 3604 !field_klass.Equals(GetDeclaringClass()))) { 3605 // Field accesses through uninitialized references are only allowable for constructors where 3606 // the field is declared in this class 3607 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "cannot access instance field " << PrettyField(field) 3608 << " of a not fully initialized object within the context" 3609 << " of " << PrettyMethod(dex_method_idx_, *dex_file_); 3610 return NULL; 3611 } else if (!field_klass.IsAssignableFrom(obj_type)) { 3612 // Trying to access C1.field1 using reference of type C2, which is neither C1 or a sub-class 3613 // of C1. For resolution to occur the declared class of the field must be compatible with 3614 // obj_type, we've discovered this wasn't so, so report the field didn't exist. 3615 Fail(VERIFY_ERROR_NO_FIELD) << "cannot access instance field " << PrettyField(field) 3616 << " from object of type " << obj_type; 3617 return NULL; 3618 } else { 3619 return field; 3620 } 3621 } 3622} 3623 3624void MethodVerifier::VerifyISGet(const Instruction* inst, const RegType& insn_type, 3625 bool is_primitive, bool is_static) { 3626 uint32_t field_idx = is_static ? inst->VRegB_21c() : inst->VRegC_22c(); 3627 mirror::ArtField* field; 3628 if (is_static) { 3629 field = GetStaticField(field_idx); 3630 } else { 3631 const RegType& object_type = work_line_->GetRegisterType(inst->VRegB_22c()); 3632 field = GetInstanceField(object_type, field_idx); 3633 } 3634 const RegType* field_type = nullptr; 3635 if (field != NULL) { 3636 Thread* self = Thread::Current(); 3637 mirror::Class* field_type_class; 3638 { 3639 StackHandleScope<1> hs(self); 3640 HandleWrapper<mirror::ArtField> h_field(hs.NewHandleWrapper(&field)); 3641 field_type_class = FieldHelper(h_field).GetType(can_load_classes_); 3642 } 3643 if (field_type_class != nullptr) { 3644 field_type = ®_types_.FromClass(field->GetTypeDescriptor(), field_type_class, 3645 field_type_class->CannotBeAssignedFromOtherTypes()); 3646 } else { 3647 DCHECK(!can_load_classes_ || self->IsExceptionPending()); 3648 self->ClearException(); 3649 } 3650 } 3651 if (field_type == nullptr) { 3652 const DexFile::FieldId& field_id = dex_file_->GetFieldId(field_idx); 3653 const char* descriptor = dex_file_->GetFieldTypeDescriptor(field_id); 3654 field_type = ®_types_.FromDescriptor(class_loader_->Get(), descriptor, false); 3655 } 3656 DCHECK(field_type != nullptr); 3657 const uint32_t vregA = (is_static) ? inst->VRegA_21c() : inst->VRegA_22c(); 3658 if (is_primitive) { 3659 if (field_type->Equals(insn_type) || 3660 (field_type->IsFloat() && insn_type.IsInteger()) || 3661 (field_type->IsDouble() && insn_type.IsLong())) { 3662 // expected that read is of the correct primitive type or that int reads are reading 3663 // floats or long reads are reading doubles 3664 } else { 3665 // This is a global failure rather than a class change failure as the instructions and 3666 // the descriptors for the type should have been consistent within the same file at 3667 // compile time 3668 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected field " << PrettyField(field) 3669 << " to be of type '" << insn_type 3670 << "' but found type '" << *field_type << "' in get"; 3671 return; 3672 } 3673 } else { 3674 if (!insn_type.IsAssignableFrom(*field_type)) { 3675 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "expected field " << PrettyField(field) 3676 << " to be compatible with type '" << insn_type 3677 << "' but found type '" << *field_type 3678 << "' in Get-object"; 3679 work_line_->SetRegisterType(vregA, reg_types_.Conflict()); 3680 return; 3681 } 3682 } 3683 if (!field_type->IsLowHalf()) { 3684 work_line_->SetRegisterType(vregA, *field_type); 3685 } else { 3686 work_line_->SetRegisterTypeWide(vregA, *field_type, field_type->HighHalf(®_types_)); 3687 } 3688} 3689 3690void MethodVerifier::VerifyISPut(const Instruction* inst, const RegType& insn_type, 3691 bool is_primitive, bool is_static) { 3692 uint32_t field_idx = is_static ? inst->VRegB_21c() : inst->VRegC_22c(); 3693 mirror::ArtField* field; 3694 if (is_static) { 3695 field = GetStaticField(field_idx); 3696 } else { 3697 const RegType& object_type = work_line_->GetRegisterType(inst->VRegB_22c()); 3698 field = GetInstanceField(object_type, field_idx); 3699 } 3700 const RegType* field_type = nullptr; 3701 if (field != NULL) { 3702 if (field->IsFinal() && field->GetDeclaringClass() != GetDeclaringClass().GetClass()) { 3703 Fail(VERIFY_ERROR_ACCESS_FIELD) << "cannot modify final field " << PrettyField(field) 3704 << " from other class " << GetDeclaringClass(); 3705 return; 3706 } 3707 mirror::Class* field_type_class; 3708 { 3709 StackHandleScope<1> hs(Thread::Current()); 3710 HandleWrapper<mirror::ArtField> h_field(hs.NewHandleWrapper(&field)); 3711 FieldHelper fh(h_field); 3712 field_type_class = fh.GetType(can_load_classes_); 3713 } 3714 if (field_type_class != nullptr) { 3715 field_type = ®_types_.FromClass(field->GetTypeDescriptor(), field_type_class, 3716 field_type_class->CannotBeAssignedFromOtherTypes()); 3717 } else { 3718 Thread* self = Thread::Current(); 3719 DCHECK(!can_load_classes_ || self->IsExceptionPending()); 3720 self->ClearException(); 3721 } 3722 } 3723 if (field_type == nullptr) { 3724 const DexFile::FieldId& field_id = dex_file_->GetFieldId(field_idx); 3725 const char* descriptor = dex_file_->GetFieldTypeDescriptor(field_id); 3726 field_type = ®_types_.FromDescriptor(class_loader_->Get(), descriptor, false); 3727 } 3728 DCHECK(field_type != nullptr); 3729 const uint32_t vregA = (is_static) ? inst->VRegA_21c() : inst->VRegA_22c(); 3730 if (is_primitive) { 3731 VerifyPrimitivePut(*field_type, insn_type, vregA); 3732 } else { 3733 if (!insn_type.IsAssignableFrom(*field_type)) { 3734 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "expected field " << PrettyField(field) 3735 << " to be compatible with type '" << insn_type 3736 << "' but found type '" << *field_type 3737 << "' in put-object"; 3738 return; 3739 } 3740 work_line_->VerifyRegisterType(vregA, *field_type); 3741 } 3742} 3743 3744mirror::ArtField* MethodVerifier::GetQuickFieldAccess(const Instruction* inst, 3745 RegisterLine* reg_line) { 3746 DCHECK(inst->Opcode() == Instruction::IGET_QUICK || 3747 inst->Opcode() == Instruction::IGET_WIDE_QUICK || 3748 inst->Opcode() == Instruction::IGET_OBJECT_QUICK || 3749 inst->Opcode() == Instruction::IPUT_QUICK || 3750 inst->Opcode() == Instruction::IPUT_WIDE_QUICK || 3751 inst->Opcode() == Instruction::IPUT_OBJECT_QUICK); 3752 const RegType& object_type = reg_line->GetRegisterType(inst->VRegB_22c()); 3753 if (!object_type.HasClass()) { 3754 VLOG(verifier) << "Failed to get mirror::Class* from '" << object_type << "'"; 3755 return nullptr; 3756 } 3757 uint32_t field_offset = static_cast<uint32_t>(inst->VRegC_22c()); 3758 mirror::ArtField* f = mirror::ArtField::FindInstanceFieldWithOffset(object_type.GetClass(), 3759 field_offset); 3760 if (f == nullptr) { 3761 VLOG(verifier) << "Failed to find instance field at offset '" << field_offset 3762 << "' from '" << PrettyDescriptor(object_type.GetClass()) << "'"; 3763 } 3764 return f; 3765} 3766 3767void MethodVerifier::VerifyIGetQuick(const Instruction* inst, const RegType& insn_type, 3768 bool is_primitive) { 3769 DCHECK(Runtime::Current()->IsStarted()); 3770 mirror::ArtField* field = GetQuickFieldAccess(inst, work_line_.get()); 3771 if (field == NULL) { 3772 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Cannot infer field from " << inst->Name(); 3773 return; 3774 } 3775 mirror::Class* field_type_class; 3776 { 3777 StackHandleScope<1> hs(Thread::Current()); 3778 HandleWrapper<mirror::ArtField> h_field(hs.NewHandleWrapper(&field)); 3779 FieldHelper fh(h_field); 3780 field_type_class = fh.GetType(can_load_classes_); 3781 } 3782 const RegType* field_type; 3783 if (field_type_class != nullptr) { 3784 field_type = ®_types_.FromClass(field->GetTypeDescriptor(), field_type_class, 3785 field_type_class->CannotBeAssignedFromOtherTypes()); 3786 } else { 3787 Thread* self = Thread::Current(); 3788 DCHECK(!can_load_classes_ || self->IsExceptionPending()); 3789 self->ClearException(); 3790 field_type = ®_types_.FromDescriptor(field->GetDeclaringClass()->GetClassLoader(), 3791 field->GetTypeDescriptor(), false); 3792 } 3793 DCHECK(field_type != nullptr); 3794 const uint32_t vregA = inst->VRegA_22c(); 3795 if (is_primitive) { 3796 if (field_type->Equals(insn_type) || 3797 (field_type->IsFloat() && insn_type.IsIntegralTypes()) || 3798 (field_type->IsDouble() && insn_type.IsLongTypes())) { 3799 // expected that read is of the correct primitive type or that int reads are reading 3800 // floats or long reads are reading doubles 3801 } else { 3802 // This is a global failure rather than a class change failure as the instructions and 3803 // the descriptors for the type should have been consistent within the same file at 3804 // compile time 3805 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected field " << PrettyField(field) 3806 << " to be of type '" << insn_type 3807 << "' but found type '" << *field_type << "' in Get"; 3808 return; 3809 } 3810 } else { 3811 if (!insn_type.IsAssignableFrom(*field_type)) { 3812 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "expected field " << PrettyField(field) 3813 << " to be compatible with type '" << insn_type 3814 << "' but found type '" << *field_type 3815 << "' in get-object"; 3816 work_line_->SetRegisterType(vregA, reg_types_.Conflict()); 3817 return; 3818 } 3819 } 3820 if (!field_type->IsLowHalf()) { 3821 work_line_->SetRegisterType(vregA, *field_type); 3822 } else { 3823 work_line_->SetRegisterTypeWide(vregA, *field_type, field_type->HighHalf(®_types_)); 3824 } 3825} 3826 3827void MethodVerifier::VerifyIPutQuick(const Instruction* inst, const RegType& insn_type, 3828 bool is_primitive) { 3829 DCHECK(Runtime::Current()->IsStarted()); 3830 mirror::ArtField* field = GetQuickFieldAccess(inst, work_line_.get()); 3831 if (field == NULL) { 3832 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "Cannot infer field from " << inst->Name(); 3833 return; 3834 } 3835 const char* descriptor = field->GetTypeDescriptor(); 3836 mirror::ClassLoader* loader = field->GetDeclaringClass()->GetClassLoader(); 3837 const RegType& field_type = reg_types_.FromDescriptor(loader, descriptor, false); 3838 if (field != NULL) { 3839 if (field->IsFinal() && field->GetDeclaringClass() != GetDeclaringClass().GetClass()) { 3840 Fail(VERIFY_ERROR_ACCESS_FIELD) << "cannot modify final field " << PrettyField(field) 3841 << " from other class " << GetDeclaringClass(); 3842 return; 3843 } 3844 } 3845 const uint32_t vregA = inst->VRegA_22c(); 3846 if (is_primitive) { 3847 // Primitive field assignability rules are weaker than regular assignability rules 3848 bool instruction_compatible; 3849 bool value_compatible; 3850 const RegType& value_type = work_line_->GetRegisterType(vregA); 3851 if (field_type.IsIntegralTypes()) { 3852 instruction_compatible = insn_type.IsIntegralTypes(); 3853 value_compatible = value_type.IsIntegralTypes(); 3854 } else if (field_type.IsFloat()) { 3855 instruction_compatible = insn_type.IsInteger(); // no [is]put-float, so expect [is]put-int 3856 value_compatible = value_type.IsFloatTypes(); 3857 } else if (field_type.IsLong()) { 3858 instruction_compatible = insn_type.IsLong(); 3859 value_compatible = value_type.IsLongTypes(); 3860 } else if (field_type.IsDouble()) { 3861 instruction_compatible = insn_type.IsLong(); // no [is]put-double, so expect [is]put-long 3862 value_compatible = value_type.IsDoubleTypes(); 3863 } else { 3864 instruction_compatible = false; // reference field with primitive store 3865 value_compatible = false; // unused 3866 } 3867 if (!instruction_compatible) { 3868 // This is a global failure rather than a class change failure as the instructions and 3869 // the descriptors for the type should have been consistent within the same file at 3870 // compile time 3871 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "expected field " << PrettyField(field) 3872 << " to be of type '" << insn_type 3873 << "' but found type '" << field_type 3874 << "' in put"; 3875 return; 3876 } 3877 if (!value_compatible) { 3878 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "unexpected value in v" << vregA 3879 << " of type " << value_type 3880 << " but expected " << field_type 3881 << " for store to " << PrettyField(field) << " in put"; 3882 return; 3883 } 3884 } else { 3885 if (!insn_type.IsAssignableFrom(field_type)) { 3886 Fail(VERIFY_ERROR_BAD_CLASS_SOFT) << "expected field " << PrettyField(field) 3887 << " to be compatible with type '" << insn_type 3888 << "' but found type '" << field_type 3889 << "' in put-object"; 3890 return; 3891 } 3892 work_line_->VerifyRegisterType(vregA, field_type); 3893 } 3894} 3895 3896bool MethodVerifier::CheckNotMoveException(const uint16_t* insns, int insn_idx) { 3897 if ((insns[insn_idx] & 0xff) == Instruction::MOVE_EXCEPTION) { 3898 Fail(VERIFY_ERROR_BAD_CLASS_HARD) << "invalid use of move-exception"; 3899 return false; 3900 } 3901 return true; 3902} 3903 3904bool MethodVerifier::UpdateRegisters(uint32_t next_insn, RegisterLine* merge_line, 3905 bool update_merge_line) { 3906 bool changed = true; 3907 RegisterLine* target_line = reg_table_.GetLine(next_insn); 3908 if (!insn_flags_[next_insn].IsVisitedOrChanged()) { 3909 /* 3910 * We haven't processed this instruction before, and we haven't touched the registers here, so 3911 * there's nothing to "merge". Copy the registers over and mark it as changed. (This is the 3912 * only way a register can transition out of "unknown", so this is not just an optimization.) 3913 */ 3914 if (!insn_flags_[next_insn].IsReturn()) { 3915 target_line->CopyFromLine(merge_line); 3916 } else { 3917 // Verify that the monitor stack is empty on return. 3918 if (!merge_line->VerifyMonitorStackEmpty()) { 3919 return false; 3920 } 3921 // For returns we only care about the operand to the return, all other registers are dead. 3922 // Initialize them as conflicts so they don't add to GC and deoptimization information. 3923 const Instruction* ret_inst = Instruction::At(code_item_->insns_ + next_insn); 3924 Instruction::Code opcode = ret_inst->Opcode(); 3925 if ((opcode == Instruction::RETURN_VOID) || (opcode == Instruction::RETURN_VOID_BARRIER)) { 3926 target_line->MarkAllRegistersAsConflicts(); 3927 } else { 3928 target_line->CopyFromLine(merge_line); 3929 if (opcode == Instruction::RETURN_WIDE) { 3930 target_line->MarkAllRegistersAsConflictsExceptWide(ret_inst->VRegA_11x()); 3931 } else { 3932 target_line->MarkAllRegistersAsConflictsExcept(ret_inst->VRegA_11x()); 3933 } 3934 } 3935 } 3936 } else { 3937 std::unique_ptr<RegisterLine> copy(gDebugVerify ? 3938 RegisterLine::Create(target_line->NumRegs(), this) : 3939 NULL); 3940 if (gDebugVerify) { 3941 copy->CopyFromLine(target_line); 3942 } 3943 changed = target_line->MergeRegisters(merge_line); 3944 if (have_pending_hard_failure_) { 3945 return false; 3946 } 3947 if (gDebugVerify && changed) { 3948 LogVerifyInfo() << "Merging at [" << reinterpret_cast<void*>(work_insn_idx_) << "]" 3949 << " to [" << reinterpret_cast<void*>(next_insn) << "]: " << "\n" 3950 << *copy.get() << " MERGE\n" 3951 << *merge_line << " ==\n" 3952 << *target_line << "\n"; 3953 } 3954 if (update_merge_line && changed) { 3955 merge_line->CopyFromLine(target_line); 3956 } 3957 } 3958 if (changed) { 3959 insn_flags_[next_insn].SetChanged(); 3960 } 3961 return true; 3962} 3963 3964InstructionFlags* MethodVerifier::CurrentInsnFlags() { 3965 return &insn_flags_[work_insn_idx_]; 3966} 3967 3968const RegType& MethodVerifier::GetMethodReturnType() { 3969 if (return_type_ == nullptr) { 3970 if (mirror_method_ != NULL) { 3971 Thread* self = Thread::Current(); 3972 StackHandleScope<1> hs(self); 3973 mirror::Class* return_type_class; 3974 { 3975 HandleWrapper<mirror::ArtMethod> h_mirror_method(hs.NewHandleWrapper(&mirror_method_)); 3976 return_type_class = MethodHelper(h_mirror_method).GetReturnType(can_load_classes_); 3977 } 3978 if (return_type_class != nullptr) { 3979 return_type_ = ®_types_.FromClass(mirror_method_->GetReturnTypeDescriptor(), 3980 return_type_class, 3981 return_type_class->CannotBeAssignedFromOtherTypes()); 3982 } else { 3983 DCHECK(!can_load_classes_ || self->IsExceptionPending()); 3984 self->ClearException(); 3985 } 3986 } 3987 if (return_type_ == nullptr) { 3988 const DexFile::MethodId& method_id = dex_file_->GetMethodId(dex_method_idx_); 3989 const DexFile::ProtoId& proto_id = dex_file_->GetMethodPrototype(method_id); 3990 uint16_t return_type_idx = proto_id.return_type_idx_; 3991 const char* descriptor = dex_file_->GetTypeDescriptor(dex_file_->GetTypeId(return_type_idx)); 3992 return_type_ = ®_types_.FromDescriptor(class_loader_->Get(), descriptor, false); 3993 } 3994 } 3995 return *return_type_; 3996} 3997 3998const RegType& MethodVerifier::GetDeclaringClass() { 3999 if (declaring_class_ == NULL) { 4000 const DexFile::MethodId& method_id = dex_file_->GetMethodId(dex_method_idx_); 4001 const char* descriptor 4002 = dex_file_->GetTypeDescriptor(dex_file_->GetTypeId(method_id.class_idx_)); 4003 if (mirror_method_ != NULL) { 4004 mirror::Class* klass = mirror_method_->GetDeclaringClass(); 4005 declaring_class_ = ®_types_.FromClass(descriptor, klass, 4006 klass->CannotBeAssignedFromOtherTypes()); 4007 } else { 4008 declaring_class_ = ®_types_.FromDescriptor(class_loader_->Get(), descriptor, false); 4009 } 4010 } 4011 return *declaring_class_; 4012} 4013 4014std::vector<int32_t> MethodVerifier::DescribeVRegs(uint32_t dex_pc) { 4015 RegisterLine* line = reg_table_.GetLine(dex_pc); 4016 DCHECK(line != nullptr) << "No register line at DEX pc " << StringPrintf("0x%x", dex_pc); 4017 std::vector<int32_t> result; 4018 for (size_t i = 0; i < line->NumRegs(); ++i) { 4019 const RegType& type = line->GetRegisterType(i); 4020 if (type.IsConstant()) { 4021 result.push_back(type.IsPreciseConstant() ? kConstant : kImpreciseConstant); 4022 result.push_back(type.ConstantValue()); 4023 } else if (type.IsConstantLo()) { 4024 result.push_back(type.IsPreciseConstantLo() ? kConstant : kImpreciseConstant); 4025 result.push_back(type.ConstantValueLo()); 4026 } else if (type.IsConstantHi()) { 4027 result.push_back(type.IsPreciseConstantHi() ? kConstant : kImpreciseConstant); 4028 result.push_back(type.ConstantValueHi()); 4029 } else if (type.IsIntegralTypes()) { 4030 result.push_back(kIntVReg); 4031 result.push_back(0); 4032 } else if (type.IsFloat()) { 4033 result.push_back(kFloatVReg); 4034 result.push_back(0); 4035 } else if (type.IsLong()) { 4036 result.push_back(kLongLoVReg); 4037 result.push_back(0); 4038 result.push_back(kLongHiVReg); 4039 result.push_back(0); 4040 ++i; 4041 } else if (type.IsDouble()) { 4042 result.push_back(kDoubleLoVReg); 4043 result.push_back(0); 4044 result.push_back(kDoubleHiVReg); 4045 result.push_back(0); 4046 ++i; 4047 } else if (type.IsUndefined() || type.IsConflict() || type.IsHighHalf()) { 4048 result.push_back(kUndefined); 4049 result.push_back(0); 4050 } else { 4051 CHECK(type.IsNonZeroReferenceTypes()); 4052 result.push_back(kReferenceVReg); 4053 result.push_back(0); 4054 } 4055 } 4056 return result; 4057} 4058 4059const RegType& MethodVerifier::DetermineCat1Constant(int32_t value, bool precise) { 4060 if (precise) { 4061 // Precise constant type. 4062 return reg_types_.FromCat1Const(value, true); 4063 } else { 4064 // Imprecise constant type. 4065 if (value < -32768) { 4066 return reg_types_.IntConstant(); 4067 } else if (value < -128) { 4068 return reg_types_.ShortConstant(); 4069 } else if (value < 0) { 4070 return reg_types_.ByteConstant(); 4071 } else if (value == 0) { 4072 return reg_types_.Zero(); 4073 } else if (value == 1) { 4074 return reg_types_.One(); 4075 } else if (value < 128) { 4076 return reg_types_.PosByteConstant(); 4077 } else if (value < 32768) { 4078 return reg_types_.PosShortConstant(); 4079 } else if (value < 65536) { 4080 return reg_types_.CharConstant(); 4081 } else { 4082 return reg_types_.IntConstant(); 4083 } 4084 } 4085} 4086 4087void MethodVerifier::Init() { 4088 art::verifier::RegTypeCache::Init(); 4089} 4090 4091void MethodVerifier::Shutdown() { 4092 verifier::RegTypeCache::ShutDown(); 4093} 4094 4095void MethodVerifier::VisitRoots(RootCallback* callback, void* arg) { 4096 reg_types_.VisitRoots(callback, arg); 4097} 4098 4099} // namespace verifier 4100} // namespace art 4101