167bc6071d7abea2d4870bc4fd8f119ebd93c46f3Francois Pichet//===--- JumpDiagnostics.cpp - Protected scope jump analysis ------*- C++ -*-=// 25af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// 35af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// The LLVM Compiler Infrastructure 45af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// 55af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// This file is distributed under the University of Illinois Open Source 65af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// License. See LICENSE.TXT for details. 75af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// 85af280ce21af061f96b5b5b752746871e364ba99Chris Lattner//===----------------------------------------------------------------------===// 95af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// 105af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// This file implements the JumpScopeChecker class, which is used to diagnose 1167bc6071d7abea2d4870bc4fd8f119ebd93c46f3Francois Pichet// jumps that enter a protected scope in an invalid way. 125af280ce21af061f96b5b5b752746871e364ba99Chris Lattner// 135af280ce21af061f96b5b5b752746871e364ba99Chris Lattner//===----------------------------------------------------------------------===// 145af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 175af280ce21af061f96b5b5b752746871e364ba99Chris Lattner#include "clang/AST/Expr.h" 18e413516d0ed61ef9e2ff706bcc00480adca947c4Douglas Gregor#include "clang/AST/ExprCXX.h" 19972041f45bdf8df7ea447221292d7827466ba94bSebastian Redl#include "clang/AST/StmtCXX.h" 2055fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/StmtObjC.h" 21e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "llvm/ADT/BitVector.h" 225af280ce21af061f96b5b5b752746871e364ba99Chris Lattnerusing namespace clang; 235af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 245af280ce21af061f96b5b5b752746871e364ba99Chris Lattnernamespace { 255af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 265af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// JumpScopeChecker - This object is used by Sema to diagnose invalid jumps 275af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// into VLA and other protected scopes. For example, this rejects: 285af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// goto L; 295af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// int a[n]; 305af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// L: 315af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// 325af280ce21af061f96b5b5b752746871e364ba99Chris Lattnerclass JumpScopeChecker { 335af280ce21af061f96b5b5b752746871e364ba99Chris Lattner Sema &S; 341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 356bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines /// Permissive - True when recovering from errors, in which case precautions 366bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines /// are taken to handle incomplete scope information. 376bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines const bool Permissive; 386bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines 395af280ce21af061f96b5b5b752746871e364ba99Chris Lattner /// GotoScope - This is a record that we use to keep track of all of the 405af280ce21af061f96b5b5b752746871e364ba99Chris Lattner /// scopes that are introduced by VLAs and other things that scope jumps like 415af280ce21af061f96b5b5b752746871e364ba99Chris Lattner /// gotos. This scope tree has nothing to do with the source scope tree, 425af280ce21af061f96b5b5b752746871e364ba99Chris Lattner /// because you can have multiple VLA scopes per compound statement, and most 435af280ce21af061f96b5b5b752746871e364ba99Chris Lattner /// compound statements don't introduce any scopes. 445af280ce21af061f96b5b5b752746871e364ba99Chris Lattner struct GotoScope { 455af280ce21af061f96b5b5b752746871e364ba99Chris Lattner /// ParentScope - The index in ScopeMap of the parent scope. This is 0 for 465af280ce21af061f96b5b5b752746871e364ba99Chris Lattner /// the parent scope is the function body. 475af280ce21af061f96b5b5b752746871e364ba99Chris Lattner unsigned ParentScope; 481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 490e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith /// InDiag - The note to emit if there is a jump into this scope. 50ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall unsigned InDiag; 51ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 520e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith /// OutDiag - The note to emit if there is an indirect jump out 53ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall /// of this scope. Direct jumps always clean up their current scope 54ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall /// in an orderly way. 55ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall unsigned OutDiag; 561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 575af280ce21af061f96b5b5b752746871e364ba99Chris Lattner /// Loc - Location to emit the diagnostic. 585af280ce21af061f96b5b5b752746871e364ba99Chris Lattner SourceLocation Loc; 591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 60ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall GotoScope(unsigned parentScope, unsigned InDiag, unsigned OutDiag, 61ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall SourceLocation L) 62ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall : ParentScope(parentScope), InDiag(InDiag), OutDiag(OutDiag), Loc(L) {} 635af280ce21af061f96b5b5b752746871e364ba99Chris Lattner }; 641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 655f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<GotoScope, 48> Scopes; 665af280ce21af061f96b5b5b752746871e364ba99Chris Lattner llvm::DenseMap<Stmt*, unsigned> LabelAndGotoScopes; 675f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Stmt*, 16> Jumps; 68ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 695f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<IndirectGotoStmt*, 4> IndirectJumps; 705f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<LabelDecl*, 4> IndirectJumpTargets; 715af280ce21af061f96b5b5b752746871e364ba99Chris Lattnerpublic: 725af280ce21af061f96b5b5b752746871e364ba99Chris Lattner JumpScopeChecker(Stmt *Body, Sema &S); 735af280ce21af061f96b5b5b752746871e364ba99Chris Lattnerprivate: 7443dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor void BuildScopeInformation(Decl *D, unsigned &ParentScope); 754e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian void BuildScopeInformation(VarDecl *D, const BlockDecl *BDecl, 764e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian unsigned &ParentScope); 774e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian void BuildScopeInformation(Stmt *S, unsigned &origParentScope); 784e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian 795af280ce21af061f96b5b5b752746871e364ba99Chris Lattner void VerifyJumps(); 80ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall void VerifyIndirectJumps(); 814fe5be028b723fedc28bb33be96cde1ab2574ee6Bill Wendling void NoteJumpIntoScopes(ArrayRef<unsigned> ToScopes); 82ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall void DiagnoseIndirectJump(IndirectGotoStmt *IG, unsigned IGScope, 83ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner LabelDecl *Target, unsigned TargetScope); 84c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet void CheckJump(Stmt *From, Stmt *To, SourceLocation DiagLoc, 850e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith unsigned JumpDiag, unsigned JumpDiagWarning, 860e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith unsigned JumpDiagCXX98Compat); 87176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines void CheckGotoStmt(GotoStmt *GS); 885e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall 895e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall unsigned GetDeepestCommonScope(unsigned A, unsigned B); 905af280ce21af061f96b5b5b752746871e364ba99Chris Lattner}; 915af280ce21af061f96b5b5b752746871e364ba99Chris Lattner} // end anonymous namespace 925af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 936bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines#define CHECK_PERMISSIVE(x) (assert(Permissive || !(x)), (Permissive && (x))) 945af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 956bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen HinesJumpScopeChecker::JumpScopeChecker(Stmt *Body, Sema &s) 966bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines : S(s), Permissive(s.hasAnyUnrecoverableErrorsInThisFunction()) { 975af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Add a scope entry for function scope. 98ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall Scopes.push_back(GotoScope(~0U, ~0U, ~0U, SourceLocation())); 991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1005af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Build information for the top level compound statement, so that we have a 1015af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // defined scope record for every "goto" and label. 1024e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian unsigned BodyParentScope = 0; 1034e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian BuildScopeInformation(Body, BodyParentScope); 1041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1055af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Check that all jumps we saw are kosher. 1065af280ce21af061f96b5b5b752746871e364ba99Chris Lattner VerifyJumps(); 107ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall VerifyIndirectJumps(); 1085af280ce21af061f96b5b5b752746871e364ba99Chris Lattner} 1091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1105e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// GetDeepestCommonScope - Finds the innermost scope enclosing the 1115e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// two scopes. 1125e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCallunsigned JumpScopeChecker::GetDeepestCommonScope(unsigned A, unsigned B) { 1135e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall while (A != B) { 1145e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // Inner scopes are created after outer scopes and therefore have 1155e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // higher indices. 1165e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall if (A < B) { 1175e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall assert(Scopes[B].ParentScope < B); 1185e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall B = Scopes[B].ParentScope; 1195e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall } else { 1205e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall assert(Scopes[A].ParentScope < A); 1215e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall A = Scopes[A].ParentScope; 1225e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall } 1235e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall } 1245e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall return A; 1255e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall} 1265e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall 127f85e193739c953358c865005855253af4f68a497John McCalltypedef std::pair<unsigned,unsigned> ScopePair; 128f85e193739c953358c865005855253af4f68a497John McCall 1295af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// GetDiagForGotoScopeDecl - If this decl induces a new goto scope, return a 1305af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// diagnostic that should be emitted if control goes over it. If not, return 0. 131651f13cea278ec967336033dd032faef0e9fc2ecStephen Hinesstatic ScopePair GetDiagForGotoScopeDecl(Sema &S, const Decl *D) { 1325af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (const VarDecl *VD = dyn_cast<VarDecl>(D)) { 133644e90a17f1bc3dcc2b7b018eb02abb3a1c2022bRafael Espindola unsigned InDiag = 0; 134651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines unsigned OutDiag = 0; 135651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines 1365af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (VD->getType()->isVariablyModifiedType()) 137ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall InDiag = diag::note_protected_by_vla; 138ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 139f85e193739c953358c865005855253af4f68a497John McCall if (VD->hasAttr<BlocksAttr>()) 140f85e193739c953358c865005855253af4f68a497John McCall return ScopePair(diag::note_protected_by___block, 141f85e193739c953358c865005855253af4f68a497John McCall diag::note_exits___block); 142f85e193739c953358c865005855253af4f68a497John McCall 143f85e193739c953358c865005855253af4f68a497John McCall if (VD->hasAttr<CleanupAttr>()) 144f85e193739c953358c865005855253af4f68a497John McCall return ScopePair(diag::note_protected_by_cleanup, 145f85e193739c953358c865005855253af4f68a497John McCall diag::note_exits_cleanup); 146f85e193739c953358c865005855253af4f68a497John McCall 147651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (VD->hasLocalStorage()) { 148651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines switch (VD->getType().isDestructedType()) { 149651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines case QualType::DK_objc_strong_lifetime: 150651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines case QualType::DK_objc_weak_lifetime: 151b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis return ScopePair(diag::note_protected_by_objc_ownership, 152b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::note_exits_objc_ownership); 153651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines 154651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines case QualType::DK_cxx_destructor: 155651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines OutDiag = diag::note_exits_dtor; 156651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines break; 157651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines 158651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines case QualType::DK_none: 159651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines break; 160f85e193739c953358c865005855253af4f68a497John McCall } 161f85e193739c953358c865005855253af4f68a497John McCall } 162f85e193739c953358c865005855253af4f68a497John McCall 163651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines const Expr *Init = VD->getInit(); 164651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (S.Context.getLangOpts().CPlusPlus && VD->hasLocalStorage() && Init) { 1650e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith // C++11 [stmt.dcl]p3: 166f85e193739c953358c865005855253af4f68a497John McCall // A program that jumps from a point where a variable with automatic 167f85e193739c953358c865005855253af4f68a497John McCall // storage duration is not in scope to a point where it is in scope 168f85e193739c953358c865005855253af4f68a497John McCall // is ill-formed unless the variable has scalar type, class type with 169f85e193739c953358c865005855253af4f68a497John McCall // a trivial default constructor and a trivial destructor, a 170f85e193739c953358c865005855253af4f68a497John McCall // cv-qualified version of one of these types, or an array of one of 171f85e193739c953358c865005855253af4f68a497John McCall // the preceding types and is declared without an initializer. 172f85e193739c953358c865005855253af4f68a497John McCall 173f85e193739c953358c865005855253af4f68a497John McCall // C++03 [stmt.dcl.p3: 174f85e193739c953358c865005855253af4f68a497John McCall // A program that jumps from a point where a local variable 175f85e193739c953358c865005855253af4f68a497John McCall // with automatic storage duration is not in scope to a point 176f85e193739c953358c865005855253af4f68a497John McCall // where it is in scope is ill-formed unless the variable has 177f85e193739c953358c865005855253af4f68a497John McCall // POD type and is declared without an initializer. 178f85e193739c953358c865005855253af4f68a497John McCall 179651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines InDiag = diag::note_protected_by_variable_init; 180644e90a17f1bc3dcc2b7b018eb02abb3a1c2022bRafael Espindola 181651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines // For a variable of (array of) class type declared without an 182651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines // initializer, we will have call-style initialization and the initializer 183651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines // will be the CXXConstructExpr with no intervening nodes. 184651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (const CXXConstructExpr *CCE = dyn_cast<CXXConstructExpr>(Init)) { 185651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines const CXXConstructorDecl *Ctor = CCE->getConstructor(); 186651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (Ctor->isTrivial() && Ctor->isDefaultConstructor() && 187651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines VD->getInitStyle() == VarDecl::CallInit) { 188644e90a17f1bc3dcc2b7b018eb02abb3a1c2022bRafael Espindola if (OutDiag) 189644e90a17f1bc3dcc2b7b018eb02abb3a1c2022bRafael Espindola InDiag = diag::note_protected_by_variable_nontriv_destructor; 190651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines else if (!Ctor->getParent()->isPOD()) 191644e90a17f1bc3dcc2b7b018eb02abb3a1c2022bRafael Espindola InDiag = diag::note_protected_by_variable_non_pod; 192651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines else 193651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines InDiag = 0; 194e413516d0ed61ef9e2ff706bcc00480adca947c4Douglas Gregor } 195a92afb611c015196541edd53347aa23dba1949acRafael Espindola } 196a92afb611c015196541edd53347aa23dba1949acRafael Espindola } 197644e90a17f1bc3dcc2b7b018eb02abb3a1c2022bRafael Espindola 198651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines return ScopePair(InDiag, OutDiag); 199ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall } 200ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 201651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (const TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(D)) { 2025af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (TD->getUnderlyingType()->isVariablyModifiedType()) 203651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines return ScopePair(isa<TypedefDecl>(TD) 204651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines ? diag::note_protected_by_vla_typedef 205651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines : diag::note_protected_by_vla_type_alias, 206651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines 0); 207162e1c1b487352434552147967c3dd296ebee2f7Richard Smith } 208162e1c1b487352434552147967c3dd296ebee2f7Richard Smith 209f85e193739c953358c865005855253af4f68a497John McCall return ScopePair(0U, 0U); 2105af280ce21af061f96b5b5b752746871e364ba99Chris Lattner} 2115af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 21243dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor/// \brief Build scope information for a declaration that is part of a DeclStmt. 21343dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregorvoid JumpScopeChecker::BuildScopeInformation(Decl *D, unsigned &ParentScope) { 21443dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor // If this decl causes a new scope, push and switch to it. 215651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines std::pair<unsigned,unsigned> Diags = GetDiagForGotoScopeDecl(S, D); 21643dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor if (Diags.first || Diags.second) { 21743dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor Scopes.push_back(GotoScope(ParentScope, Diags.first, Diags.second, 21843dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor D->getLocation())); 21943dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor ParentScope = Scopes.size()-1; 22043dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor } 22143dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor 22243dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor // If the decl has an initializer, walk it with the potentially new 22343dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor // scope we just installed. 22443dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor if (VarDecl *VD = dyn_cast<VarDecl>(D)) 22543dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor if (Expr *Init = VD->getInit()) 22643dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor BuildScopeInformation(Init, ParentScope); 22743dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor} 2285af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 2294e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian/// \brief Build scope information for a captured block literal variables. 2304e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanianvoid JumpScopeChecker::BuildScopeInformation(VarDecl *D, 2314e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian const BlockDecl *BDecl, 2324e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian unsigned &ParentScope) { 2334e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian // exclude captured __block variables; there's no destructor 2344e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian // associated with the block literal for them. 2354e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian if (D->hasAttr<BlocksAttr>()) 2364e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian return; 2374e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian QualType T = D->getType(); 2384e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian QualType::DestructionKind destructKind = T.isDestructedType(); 2394e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian if (destructKind != QualType::DK_none) { 2404e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian std::pair<unsigned,unsigned> Diags; 2414e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian switch (destructKind) { 2424e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian case QualType::DK_cxx_destructor: 2434e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian Diags = ScopePair(diag::note_enters_block_captures_cxx_obj, 2444e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian diag::note_exits_block_captures_cxx_obj); 2454e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian break; 2464e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian case QualType::DK_objc_strong_lifetime: 2474e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian Diags = ScopePair(diag::note_enters_block_captures_strong, 2484e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian diag::note_exits_block_captures_strong); 2494e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian break; 2504e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian case QualType::DK_objc_weak_lifetime: 2514e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian Diags = ScopePair(diag::note_enters_block_captures_weak, 2524e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian diag::note_exits_block_captures_weak); 2534e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian break; 2544e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian case QualType::DK_none: 2550e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith llvm_unreachable("non-lifetime captured variable"); 2564e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian } 2574e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian SourceLocation Loc = D->getLocation(); 2584e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian if (Loc.isInvalid()) 2594e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian Loc = BDecl->getLocation(); 2604e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian Scopes.push_back(GotoScope(ParentScope, 2614e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian Diags.first, Diags.second, Loc)); 2624e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian ParentScope = Scopes.size()-1; 2634e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian } 2644e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian} 2654e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian 2665af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// BuildScopeInformation - The statements from CI to CE are known to form a 2675af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// coherent VLA scope with a specified parent node. Walk through the 2685af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// statements, adding any labels or gotos to LabelAndGotoScopes and recursively 2695af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// walking the AST as needed. 2704e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanianvoid JumpScopeChecker::BuildScopeInformation(Stmt *S, unsigned &origParentScope) { 2714e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian // If this is a statement, rather than an expression, scopes within it don't 2724e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian // propagate out into the enclosing scope. Otherwise we have to worry 2734e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian // about block literals, which have the lifetime of their enclosing statement. 2744e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian unsigned independentParentScope = origParentScope; 2754e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian unsigned &ParentScope = ((isa<Expr>(S) && !isa<StmtExpr>(S)) 2764e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian ? origParentScope : independentParentScope); 2774e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian 27843dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor bool SkipFirstSubStmt = false; 27943dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor 2805af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // If we found a label, remember that it is in ParentScope scope. 281ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall switch (S->getStmtClass()) { 282ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall case Stmt::AddrLabelExprClass: 283ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall IndirectJumpTargets.push_back(cast<AddrLabelExpr>(S)->getLabel()); 284ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall break; 285ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 286ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall case Stmt::IndirectGotoStmtClass: 28795c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall // "goto *&&lbl;" is a special case which we treat as equivalent 28895c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall // to a normal goto. In addition, we don't calculate scope in the 28995c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall // operand (to avoid recording the address-of-label use), which 29095c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall // works only because of the restricted set of expressions which 29195c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall // we detect as constant targets. 29295c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall if (cast<IndirectGotoStmt>(S)->getConstantTarget()) { 29395c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall LabelAndGotoScopes[S] = ParentScope; 29495c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall Jumps.push_back(S); 29595c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall return; 29695c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall } 29795c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall 2985af280ce21af061f96b5b5b752746871e364ba99Chris Lattner LabelAndGotoScopes[S] = ParentScope; 299ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall IndirectJumps.push_back(cast<IndirectGotoStmt>(S)); 300ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall break; 301ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 302ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall case Stmt::SwitchStmtClass: 30343dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor // Evaluate the condition variable before entering the scope of the switch 30443dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor // statement. 30543dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor if (VarDecl *Var = cast<SwitchStmt>(S)->getConditionVariable()) { 30643dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor BuildScopeInformation(Var, ParentScope); 30743dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor SkipFirstSubStmt = true; 30843dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor } 30943dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor // Fall through 31043dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor 31143dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor case Stmt::GotoStmtClass: 3125af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Remember both what scope a goto is in as well as the fact that we have 3135af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // it. This makes the second scan not have to walk the AST again. 3145af280ce21af061f96b5b5b752746871e364ba99Chris Lattner LabelAndGotoScopes[S] = ParentScope; 3155af280ce21af061f96b5b5b752746871e364ba99Chris Lattner Jumps.push_back(S); 316ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall break; 317ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 318889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman case Stmt::CXXTryStmtClass: { 319889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman CXXTryStmt *TS = cast<CXXTryStmt>(S); 320889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman unsigned newParentScope; 321889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman Scopes.push_back(GotoScope(ParentScope, 322889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman diag::note_protected_by_cxx_try, 323889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman diag::note_exits_cxx_try, 324889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman TS->getSourceRange().getBegin())); 325889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman if (Stmt *TryBlock = TS->getTryBlock()) 326889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman BuildScopeInformation(TryBlock, (newParentScope = Scopes.size()-1)); 327889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman 328889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman // Jump from the catch into the try is not allowed either. 329889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman for (unsigned I = 0, E = TS->getNumHandlers(); I != E; ++I) { 330889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman CXXCatchStmt *CS = TS->getHandler(I); 331889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman Scopes.push_back(GotoScope(ParentScope, 332889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman diag::note_protected_by_cxx_catch, 333889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman diag::note_exits_cxx_catch, 334889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman CS->getSourceRange().getBegin())); 335889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman BuildScopeInformation(CS->getHandlerBlock(), 336889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman (newParentScope = Scopes.size()-1)); 337889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman } 338889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman return; 339889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman } 340889b99e6d5b389c0ed99e7ad8470c28b146a42d3Eli Friedman 3410e2c34f92f00628d48968dfea096d36381f494cbStephen Hines case Stmt::SEHTryStmtClass: { 3420e2c34f92f00628d48968dfea096d36381f494cbStephen Hines SEHTryStmt *TS = cast<SEHTryStmt>(S); 3430e2c34f92f00628d48968dfea096d36381f494cbStephen Hines unsigned newParentScope; 3440e2c34f92f00628d48968dfea096d36381f494cbStephen Hines Scopes.push_back(GotoScope(ParentScope, 3450e2c34f92f00628d48968dfea096d36381f494cbStephen Hines diag::note_protected_by_seh_try, 3460e2c34f92f00628d48968dfea096d36381f494cbStephen Hines diag::note_exits_seh_try, 3470e2c34f92f00628d48968dfea096d36381f494cbStephen Hines TS->getSourceRange().getBegin())); 3480e2c34f92f00628d48968dfea096d36381f494cbStephen Hines if (Stmt *TryBlock = TS->getTryBlock()) 3490e2c34f92f00628d48968dfea096d36381f494cbStephen Hines BuildScopeInformation(TryBlock, (newParentScope = Scopes.size()-1)); 3500e2c34f92f00628d48968dfea096d36381f494cbStephen Hines 3510e2c34f92f00628d48968dfea096d36381f494cbStephen Hines // Jump from __except or __finally into the __try are not allowed either. 3520e2c34f92f00628d48968dfea096d36381f494cbStephen Hines if (SEHExceptStmt *Except = TS->getExceptHandler()) { 3530e2c34f92f00628d48968dfea096d36381f494cbStephen Hines Scopes.push_back(GotoScope(ParentScope, 3540e2c34f92f00628d48968dfea096d36381f494cbStephen Hines diag::note_protected_by_seh_except, 3550e2c34f92f00628d48968dfea096d36381f494cbStephen Hines diag::note_exits_seh_except, 3560e2c34f92f00628d48968dfea096d36381f494cbStephen Hines Except->getSourceRange().getBegin())); 3570e2c34f92f00628d48968dfea096d36381f494cbStephen Hines BuildScopeInformation(Except->getBlock(), 3580e2c34f92f00628d48968dfea096d36381f494cbStephen Hines (newParentScope = Scopes.size()-1)); 3590e2c34f92f00628d48968dfea096d36381f494cbStephen Hines } else if (SEHFinallyStmt *Finally = TS->getFinallyHandler()) { 3600e2c34f92f00628d48968dfea096d36381f494cbStephen Hines Scopes.push_back(GotoScope(ParentScope, 3610e2c34f92f00628d48968dfea096d36381f494cbStephen Hines diag::note_protected_by_seh_finally, 3620e2c34f92f00628d48968dfea096d36381f494cbStephen Hines diag::note_exits_seh_finally, 3630e2c34f92f00628d48968dfea096d36381f494cbStephen Hines Finally->getSourceRange().getBegin())); 3640e2c34f92f00628d48968dfea096d36381f494cbStephen Hines BuildScopeInformation(Finally->getBlock(), 3650e2c34f92f00628d48968dfea096d36381f494cbStephen Hines (newParentScope = Scopes.size()-1)); 3660e2c34f92f00628d48968dfea096d36381f494cbStephen Hines } 3670e2c34f92f00628d48968dfea096d36381f494cbStephen Hines 3680e2c34f92f00628d48968dfea096d36381f494cbStephen Hines return; 3690e2c34f92f00628d48968dfea096d36381f494cbStephen Hines } 3700e2c34f92f00628d48968dfea096d36381f494cbStephen Hines 371ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall default: 372ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall break; 3735af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 3741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3757502c1d3ce8bb97bcc4f7bebef507040bd93b26fJohn McCall for (Stmt::child_range CI = S->children(); CI; ++CI) { 37643dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor if (SkipFirstSubStmt) { 37743dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor SkipFirstSubStmt = false; 37843dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor continue; 37943dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor } 38043dec6bbde2d0a16c35978983761c8b7030c8e18Douglas Gregor 3815af280ce21af061f96b5b5b752746871e364ba99Chris Lattner Stmt *SubStmt = *CI; 3826bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines if (!SubStmt) continue; 3831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 38497ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall // Cases, labels, and defaults aren't "scope parents". It's also 38597ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall // important to handle these iteratively instead of recursively in 38697ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall // order to avoid blowing out the stack. 38797ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall while (true) { 38897ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall Stmt *Next; 389ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner if (CaseStmt *CS = dyn_cast<CaseStmt>(SubStmt)) 390ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner Next = CS->getSubStmt(); 391ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner else if (DefaultStmt *DS = dyn_cast<DefaultStmt>(SubStmt)) 392ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner Next = DS->getSubStmt(); 393ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner else if (LabelStmt *LS = dyn_cast<LabelStmt>(SubStmt)) 394ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner Next = LS->getSubStmt(); 39597ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall else 39697ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall break; 39797ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall 39897ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall LabelAndGotoScopes[SubStmt] = ParentScope; 39997ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall SubStmt = Next; 40097ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall } 40197ba481f3f45e5b63b4a354bfb471ce146b7de57John McCall 4025af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // If this is a declstmt with a VLA definition, it defines a scope from here 4035af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // to the end of the containing context. 4045af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (DeclStmt *DS = dyn_cast<DeclStmt>(SubStmt)) { 4056d97e5e4b7abdae710c2548b51f4ed0298e86d80Chris Lattner // The decl statement creates a scope if any of the decls in it are VLAs 4066d97e5e4b7abdae710c2548b51f4ed0298e86d80Chris Lattner // or have the cleanup attribute. 407651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines for (auto *I : DS->decls()) 408651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines BuildScopeInformation(I, ParentScope); 4095af280ce21af061f96b5b5b752746871e364ba99Chris Lattner continue; 4105af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 4115af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Disallow jumps into any part of an @try statement by pushing a scope and 4125af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // walking all sub-stmts in that scope. 4135af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (ObjCAtTryStmt *AT = dyn_cast<ObjCAtTryStmt>(SubStmt)) { 4144e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian unsigned newParentScope; 4155af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Recursively walk the AST for the @try part. 416ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall Scopes.push_back(GotoScope(ParentScope, 417ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall diag::note_protected_by_objc_try, 418ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall diag::note_exits_objc_try, 4195af280ce21af061f96b5b5b752746871e364ba99Chris Lattner AT->getAtTryLoc())); 4205af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (Stmt *TryPart = AT->getTryBody()) 4214e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian BuildScopeInformation(TryPart, (newParentScope = Scopes.size()-1)); 4225af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 4235af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Jump from the catch to the finally or try is not valid. 4248f5e3dd32e443768d9dbbad7191e123e6733750cDouglas Gregor for (unsigned I = 0, N = AT->getNumCatchStmts(); I != N; ++I) { 4258f5e3dd32e443768d9dbbad7191e123e6733750cDouglas Gregor ObjCAtCatchStmt *AC = AT->getCatchStmt(I); 4265af280ce21af061f96b5b5b752746871e364ba99Chris Lattner Scopes.push_back(GotoScope(ParentScope, 4275af280ce21af061f96b5b5b752746871e364ba99Chris Lattner diag::note_protected_by_objc_catch, 428ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall diag::note_exits_objc_catch, 4295af280ce21af061f96b5b5b752746871e364ba99Chris Lattner AC->getAtCatchLoc())); 4301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // @catches are nested and it isn't 4314e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian BuildScopeInformation(AC->getCatchBody(), 4324e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian (newParentScope = Scopes.size()-1)); 4335af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 4341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4355af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Jump from the finally to the try or catch is not valid. 4365af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (ObjCAtFinallyStmt *AF = AT->getFinallyStmt()) { 4375af280ce21af061f96b5b5b752746871e364ba99Chris Lattner Scopes.push_back(GotoScope(ParentScope, 4385af280ce21af061f96b5b5b752746871e364ba99Chris Lattner diag::note_protected_by_objc_finally, 439ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall diag::note_exits_objc_finally, 4405af280ce21af061f96b5b5b752746871e364ba99Chris Lattner AF->getAtFinallyLoc())); 4414e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian BuildScopeInformation(AF, (newParentScope = Scopes.size()-1)); 4425af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 4431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4445af280ce21af061f96b5b5b752746871e364ba99Chris Lattner continue; 4455af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 4464e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian 4474e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian unsigned newParentScope; 44846c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner // Disallow jumps into the protected statement of an @synchronized, but 44946c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner // allow jumps into the object expression it protects. 4500e2c34f92f00628d48968dfea096d36381f494cbStephen Hines if (ObjCAtSynchronizedStmt *AS = 4510e2c34f92f00628d48968dfea096d36381f494cbStephen Hines dyn_cast<ObjCAtSynchronizedStmt>(SubStmt)) { 45246c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner // Recursively walk the AST for the @synchronized object expr, it is 45346c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner // evaluated in the normal scope. 45446c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner BuildScopeInformation(AS->getSynchExpr(), ParentScope); 4551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 45646c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner // Recursively walk the AST for the @synchronized part, protected by a new 45746c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner // scope. 45846c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner Scopes.push_back(GotoScope(ParentScope, 45946c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner diag::note_protected_by_objc_synchronized, 460ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall diag::note_exits_objc_synchronized, 46146c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner AS->getAtSynchronizedLoc())); 4624e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian BuildScopeInformation(AS->getSynchBody(), 4634e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian (newParentScope = Scopes.size()-1)); 46446c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner continue; 46546c3c4ba78766ac0f1c5ec631b424773e21f5271Chris Lattner } 466972041f45bdf8df7ea447221292d7827466ba94bSebastian Redl 467f85e193739c953358c865005855253af4f68a497John McCall // Disallow jumps into the protected statement of an @autoreleasepool. 4680e2c34f92f00628d48968dfea096d36381f494cbStephen Hines if (ObjCAutoreleasePoolStmt *AS = 4690e2c34f92f00628d48968dfea096d36381f494cbStephen Hines dyn_cast<ObjCAutoreleasePoolStmt>(SubStmt)) { 4700e2c34f92f00628d48968dfea096d36381f494cbStephen Hines // Recursively walk the AST for the @autoreleasepool part, protected by a 4710e2c34f92f00628d48968dfea096d36381f494cbStephen Hines // new scope. 472f85e193739c953358c865005855253af4f68a497John McCall Scopes.push_back(GotoScope(ParentScope, 473f85e193739c953358c865005855253af4f68a497John McCall diag::note_protected_by_objc_autoreleasepool, 474f85e193739c953358c865005855253af4f68a497John McCall diag::note_exits_objc_autoreleasepool, 475f85e193739c953358c865005855253af4f68a497John McCall AS->getAtLoc())); 4760e2c34f92f00628d48968dfea096d36381f494cbStephen Hines BuildScopeInformation(AS->getSubStmt(), 4770e2c34f92f00628d48968dfea096d36381f494cbStephen Hines (newParentScope = Scopes.size() - 1)); 478f85e193739c953358c865005855253af4f68a497John McCall continue; 479f85e193739c953358c865005855253af4f68a497John McCall } 4809f357de8d5823f9b13cf33ad1f6af1dd69b7669fJohn McCall 4819f357de8d5823f9b13cf33ad1f6af1dd69b7669fJohn McCall // Disallow jumps past full-expressions that use blocks with 4829f357de8d5823f9b13cf33ad1f6af1dd69b7669fJohn McCall // non-trivial cleanups of their captures. This is theoretically 4839f357de8d5823f9b13cf33ad1f6af1dd69b7669fJohn McCall // implementable but a lot of work which we haven't felt up to doing. 4849f357de8d5823f9b13cf33ad1f6af1dd69b7669fJohn McCall if (ExprWithCleanups *EWC = dyn_cast<ExprWithCleanups>(SubStmt)) { 4859f357de8d5823f9b13cf33ad1f6af1dd69b7669fJohn McCall for (unsigned i = 0, e = EWC->getNumObjects(); i != e; ++i) { 4869f357de8d5823f9b13cf33ad1f6af1dd69b7669fJohn McCall const BlockDecl *BDecl = EWC->getObject(i); 487651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines for (const auto &CI : BDecl->captures()) { 488651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines VarDecl *variable = CI.getVariable(); 4894e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian BuildScopeInformation(variable, BDecl, ParentScope); 4904e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian } 4919f357de8d5823f9b13cf33ad1f6af1dd69b7669fJohn McCall } 4924e7c7f2b78ac3930e45f00626ef6acf08b3f80caFariborz Jahanian } 493651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines 494651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines // Disallow jumps out of scopes containing temporaries lifetime-extended to 495651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines // automatic storage duration. 496651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (MaterializeTemporaryExpr *MTE = 497651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines dyn_cast<MaterializeTemporaryExpr>(SubStmt)) { 498651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (MTE->getStorageDuration() == SD_Automatic) { 499651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines SmallVector<const Expr *, 4> CommaLHS; 500651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines SmallVector<SubobjectAdjustment, 4> Adjustments; 501651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines const Expr *ExtendedObject = 502651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines MTE->GetTemporaryExpr()->skipRValueSubobjectAdjustments( 503651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines CommaLHS, Adjustments); 504651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (ExtendedObject->getType().isDestructedType()) { 505651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines Scopes.push_back(GotoScope(ParentScope, 0, 506651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines diag::note_exits_temporary_dtor, 507651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines ExtendedObject->getExprLoc())); 508651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines ParentScope = Scopes.size()-1; 509651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines } 510651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines } 511651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines } 512651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines 5135af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Recursively walk the AST. 5145af280ce21af061f96b5b5b752746871e364ba99Chris Lattner BuildScopeInformation(SubStmt, ParentScope); 5155af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 5165af280ce21af061f96b5b5b752746871e364ba99Chris Lattner} 5175af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 5185af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// VerifyJumps - Verify each element of the Jumps array to see if they are 5195af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// valid, emitting diagnostics if not. 5205af280ce21af061f96b5b5b752746871e364ba99Chris Lattnervoid JumpScopeChecker::VerifyJumps() { 5215af280ce21af061f96b5b5b752746871e364ba99Chris Lattner while (!Jumps.empty()) { 5225af280ce21af061f96b5b5b752746871e364ba99Chris Lattner Stmt *Jump = Jumps.pop_back_val(); 5231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // With a goto, 5255af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (GotoStmt *GS = dyn_cast<GotoStmt>(Jump)) { 526176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines // The label may not have a statement if it's coming from inline MS ASM. 527176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines if (GS->getLabel()->getStmt()) { 528176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines CheckJump(GS, GS->getLabel()->getStmt(), GS->getGotoLoc(), 529176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines diag::err_goto_into_protected_scope, 530176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines diag::ext_goto_into_protected_scope, 531176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines diag::warn_cxx98_compat_goto_into_protected_scope); 532176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines } 533176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines CheckGotoStmt(GS); 5345af280ce21af061f96b5b5b752746871e364ba99Chris Lattner continue; 5355af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 5361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 53795c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall // We only get indirect gotos here when they have a constant target. 53895c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall if (IndirectGotoStmt *IGS = dyn_cast<IndirectGotoStmt>(Jump)) { 539ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner LabelDecl *Target = IGS->getConstantTarget(); 540ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner CheckJump(IGS, Target->getStmt(), IGS->getGotoLoc(), 5412e96511773c6a21291dfa5218eb8ba79f04b5318Francois Pichet diag::err_goto_into_protected_scope, 542176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines diag::ext_goto_into_protected_scope, 5430e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith diag::warn_cxx98_compat_goto_into_protected_scope); 54495c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall continue; 54595c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall } 54695c225de9fa3d79f70ef5008c0279580a7d9dcadJohn McCall 547ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall SwitchStmt *SS = cast<SwitchStmt>(Jump); 548ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall for (SwitchCase *SC = SS->getSwitchCaseList(); SC; 549ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall SC = SC->getNextSwitchCase()) { 5506bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(SC))) 5516bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines continue; 55265d78312ce026092cb6e7b1d4d06f05e18d02aa0Erik Verbruggen SourceLocation Loc; 55365d78312ce026092cb6e7b1d4d06f05e18d02aa0Erik Verbruggen if (CaseStmt *CS = dyn_cast<CaseStmt>(SC)) 55465d78312ce026092cb6e7b1d4d06f05e18d02aa0Erik Verbruggen Loc = CS->getLocStart(); 55565d78312ce026092cb6e7b1d4d06f05e18d02aa0Erik Verbruggen else if (DefaultStmt *DS = dyn_cast<DefaultStmt>(SC)) 55665d78312ce026092cb6e7b1d4d06f05e18d02aa0Erik Verbruggen Loc = DS->getLocStart(); 55765d78312ce026092cb6e7b1d4d06f05e18d02aa0Erik Verbruggen else 55865d78312ce026092cb6e7b1d4d06f05e18d02aa0Erik Verbruggen Loc = SC->getLocStart(); 55965d78312ce026092cb6e7b1d4d06f05e18d02aa0Erik Verbruggen CheckJump(SS, SC, Loc, diag::err_switch_into_protected_scope, 0, 5600e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith diag::warn_cxx98_compat_switch_into_protected_scope); 5615af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 562ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall } 563ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall} 564ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 5655e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// VerifyIndirectJumps - Verify whether any possible indirect jump 5665e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// might cross a protection boundary. Unlike direct jumps, indirect 5675e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// jumps count cleanups as protection boundaries: since there's no 5685e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// way to know where the jump is going, we can't implicitly run the 5695e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// right cleanups the way we can with direct jumps. 5705e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// 5715e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// Thus, an indirect jump is "trivial" if it bypasses no 5725e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// initializations and no teardowns. More formally, an indirect jump 5735e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// from A to B is trivial if the path out from A to DCA(A,B) is 5745e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// trivial and the path in from DCA(A,B) to B is trivial, where 5755e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// DCA(A,B) is the deepest common ancestor of A and B. 5765e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// Jump-triviality is transitive but asymmetric. 577ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall/// 578ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall/// A path in is trivial if none of the entered scopes have an InDiag. 579ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall/// A path out is trivial is none of the exited scopes have an OutDiag. 5805e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// 5815e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// Under these definitions, this function checks that the indirect 5825e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// jump between A and B is trivial for every indirect goto statement A 5835e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// and every label B whose address was taken in the function. 584ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCallvoid JumpScopeChecker::VerifyIndirectJumps() { 585ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (IndirectJumps.empty()) return; 586ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 587ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // If there aren't any address-of-label expressions in this function, 588ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // complain about the first indirect goto. 589ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (IndirectJumpTargets.empty()) { 590ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall S.Diag(IndirectJumps[0]->getGotoLoc(), 591ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall diag::err_indirect_goto_without_addrlabel); 592ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall return; 593ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall } 594ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 5955e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // Collect a single representative of every scope containing an 5965e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // indirect goto. For most code bases, this substantially cuts 5975e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // down on the number of jump sites we'll have to consider later. 598ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall typedef std::pair<unsigned, IndirectGotoStmt*> JumpScope; 5995f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<JumpScope, 32> JumpScopes; 600ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall { 601ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall llvm::DenseMap<unsigned, IndirectGotoStmt*> JumpScopesMap; 6025f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner for (SmallVectorImpl<IndirectGotoStmt*>::iterator 603ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall I = IndirectJumps.begin(), E = IndirectJumps.end(); I != E; ++I) { 604ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall IndirectGotoStmt *IG = *I; 6056bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(IG))) 6066bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines continue; 607ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall unsigned IGScope = LabelAndGotoScopes[IG]; 608ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall IndirectGotoStmt *&Entry = JumpScopesMap[IGScope]; 609ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (!Entry) Entry = IG; 610ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall } 611ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall JumpScopes.reserve(JumpScopesMap.size()); 612ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall for (llvm::DenseMap<unsigned, IndirectGotoStmt*>::iterator 613ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall I = JumpScopesMap.begin(), E = JumpScopesMap.end(); I != E; ++I) 614ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall JumpScopes.push_back(*I); 615ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall } 616ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 6175e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // Collect a single representative of every scope containing a 6185e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // label whose address was taken somewhere in the function. 6195e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // For most code bases, there will be only one such scope. 620ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner llvm::DenseMap<unsigned, LabelDecl*> TargetScopes; 6215f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner for (SmallVectorImpl<LabelDecl*>::iterator 622ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall I = IndirectJumpTargets.begin(), E = IndirectJumpTargets.end(); 623ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall I != E; ++I) { 624ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner LabelDecl *TheLabel = *I; 6256bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(TheLabel->getStmt()))) 6266bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines continue; 627ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner unsigned LabelScope = LabelAndGotoScopes[TheLabel->getStmt()]; 628ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner LabelDecl *&Target = TargetScopes[LabelScope]; 629ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (!Target) Target = TheLabel; 630ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall } 631ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 6325e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // For each target scope, make sure it's trivially reachable from 6335e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // every scope containing a jump site. 6345e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // 6355e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // A path between scopes always consists of exitting zero or more 6365e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // scopes, then entering zero or more scopes. We build a set of 6375e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // of scopes S from which the target scope can be trivially 6385e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // entered, then verify that every jump scope can be trivially 6395e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // exitted to reach a scope in S. 640ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall llvm::BitVector Reachable(Scopes.size(), false); 641ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner for (llvm::DenseMap<unsigned,LabelDecl*>::iterator 642ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall TI = TargetScopes.begin(), TE = TargetScopes.end(); TI != TE; ++TI) { 643ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall unsigned TargetScope = TI->first; 644ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner LabelDecl *TargetLabel = TI->second; 645ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 646ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall Reachable.reset(); 647ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 648ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // Mark all the enclosing scopes from which you can safely jump 6495e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // into the target scope. 'Min' will end up being the index of 6505e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // the shallowest such scope. 651ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall unsigned Min = TargetScope; 652ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall while (true) { 653ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall Reachable.set(Min); 654ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 655ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // Don't go beyond the outermost scope. 656ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (Min == 0) break; 657ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 6585e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // Stop if we can't trivially enter the current scope. 659ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (Scopes[Min].InDiag) break; 6605af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 661ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall Min = Scopes[Min].ParentScope; 6625af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 6635af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 664ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // Walk through all the jump sites, checking that they can trivially 665ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // reach this label scope. 6665f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner for (SmallVectorImpl<JumpScope>::iterator 667ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall I = JumpScopes.begin(), E = JumpScopes.end(); I != E; ++I) { 668ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall unsigned Scope = I->first; 669ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 670ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // Walk out the "scope chain" for this scope, looking for a scope 6715e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // we've marked reachable. For well-formed code this amortizes 6725e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // to O(JumpScopes.size() / Scopes.size()): we only iterate 6735e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // when we see something unmarked, and in well-formed code we 6745e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // mark everything we iterate past. 675ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall bool IsReachable = false; 676ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall while (true) { 677ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (Reachable.test(Scope)) { 678ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // If we find something reachable, mark all the scopes we just 679ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // walked through as reachable. 680ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall for (unsigned S = I->first; S != Scope; S = Scopes[S].ParentScope) 681ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall Reachable.set(S); 682ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall IsReachable = true; 683ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall break; 684ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall } 685ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 686ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // Don't walk out if we've reached the top-level scope or we've 687ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // gotten shallower than the shallowest reachable scope. 688ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (Scope == 0 || Scope < Min) break; 689ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 690ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // Don't walk out through an out-diagnostic. 691ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (Scopes[Scope].OutDiag) break; 692ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 693ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall Scope = Scopes[Scope].ParentScope; 694ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall } 695ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 696ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // Only diagnose if we didn't find something. 697ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall if (IsReachable) continue; 698ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 699ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall DiagnoseIndirectJump(I->second, I->first, TargetLabel, TargetScope); 7005af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 7015af280ce21af061f96b5b5b752746871e364ba99Chris Lattner } 7025af280ce21af061f96b5b5b752746871e364ba99Chris Lattner} 7035af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 7040e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith/// Return true if a particular error+note combination must be downgraded to a 7050e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith/// warning in Microsoft mode. 7060e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smithstatic bool IsMicrosoftJumpWarning(unsigned JumpDiag, unsigned InDiagNote) { 7070e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith return (JumpDiag == diag::err_goto_into_protected_scope && 7080e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith (InDiagNote == diag::note_protected_by_variable_init || 7090e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith InDiagNote == diag::note_protected_by_variable_nontriv_destructor)); 7100e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith} 7110e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith 7120e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith/// Return true if a particular note should be downgraded to a compatibility 7130e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith/// warning in C++11 mode. 7140e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smithstatic bool IsCXX98CompatWarning(Sema &S, unsigned InDiagNote) { 71580ad52f327b532bded5c5b0ee38779d841c6cd35Richard Smith return S.getLangOpts().CPlusPlus11 && 7160e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith InDiagNote == diag::note_protected_by_variable_non_pod; 7170e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith} 7180e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith 7190e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith/// Produce primary diagnostic for an indirect jump statement. 7200e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smithstatic void DiagnoseIndirectJumpStmt(Sema &S, IndirectGotoStmt *Jump, 7210e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith LabelDecl *Target, bool &Diagnosed) { 7220e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith if (Diagnosed) 7230e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith return; 7240e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith S.Diag(Jump->getGotoLoc(), diag::err_indirect_goto_in_protected_scope); 7250e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith S.Diag(Target->getStmt()->getIdentLoc(), diag::note_indirect_goto_target); 7260e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith Diagnosed = true; 7270e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith} 7280e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith 7290e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith/// Produce note diagnostics for a jump into a protected scope. 7304fe5be028b723fedc28bb33be96cde1ab2574ee6Bill Wendlingvoid JumpScopeChecker::NoteJumpIntoScopes(ArrayRef<unsigned> ToScopes) { 7316bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines if (CHECK_PERMISSIVE(ToScopes.empty())) 7326bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines return; 7330e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith for (unsigned I = 0, E = ToScopes.size(); I != E; ++I) 7340e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith if (Scopes[ToScopes[I]].InDiag) 7350e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith S.Diag(Scopes[ToScopes[I]].Loc, Scopes[ToScopes[I]].InDiag); 7360e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith} 7370e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith 7385e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall/// Diagnose an indirect jump which is known to cross scopes. 739ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCallvoid JumpScopeChecker::DiagnoseIndirectJump(IndirectGotoStmt *Jump, 740ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall unsigned JumpScope, 741ad8dcf4a9df0e24051dc31bf9e6f3cd138a34298Chris Lattner LabelDecl *Target, 742ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall unsigned TargetScope) { 7436bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines if (CHECK_PERMISSIVE(JumpScope == TargetScope)) 7446bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines return; 745ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 7465e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall unsigned Common = GetDeepestCommonScope(JumpScope, TargetScope); 7470e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith bool Diagnosed = false; 7485e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall 7495e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // Walk out the scope chain until we reach the common ancestor. 7505e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall for (unsigned I = JumpScope; I != Common; I = Scopes[I].ParentScope) 7510e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith if (Scopes[I].OutDiag) { 7520e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith DiagnoseIndirectJumpStmt(S, Jump, Target, Diagnosed); 7535e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall S.Diag(Scopes[I].Loc, Scopes[I].OutDiag); 7540e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith } 7550e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith 7560e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith SmallVector<unsigned, 10> ToScopesCXX98Compat; 757ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 758ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall // Now walk into the scopes containing the label whose address was taken. 7595e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall for (unsigned I = TargetScope; I != Common; I = Scopes[I].ParentScope) 7600e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith if (IsCXX98CompatWarning(S, Scopes[I].InDiag)) 7610e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith ToScopesCXX98Compat.push_back(I); 7620e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith else if (Scopes[I].InDiag) { 7630e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith DiagnoseIndirectJumpStmt(S, Jump, Target, Diagnosed); 7645e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall S.Diag(Scopes[I].Loc, Scopes[I].InDiag); 7650e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith } 766ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 7670e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith // Diagnose this jump if it would be ill-formed in C++98. 7680e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith if (!Diagnosed && !ToScopesCXX98Compat.empty()) { 7690e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith S.Diag(Jump->getGotoLoc(), 7700e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith diag::warn_cxx98_compat_indirect_goto_in_protected_scope); 7710e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith S.Diag(Target->getStmt()->getIdentLoc(), diag::note_indirect_goto_target); 7720e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith NoteJumpIntoScopes(ToScopesCXX98Compat); 7730e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith } 774c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet} 775c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet 7765af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// CheckJump - Validate that the specified jump statement is valid: that it is 7775af280ce21af061f96b5b5b752746871e364ba99Chris Lattner/// jumping within or out of its current scope, not into a deeper one. 778c985b88efc9188845952ab524fe6d4717705257bFrancois Pichetvoid JumpScopeChecker::CheckJump(Stmt *From, Stmt *To, SourceLocation DiagLoc, 7790e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith unsigned JumpDiagError, unsigned JumpDiagWarning, 7800e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith unsigned JumpDiagCXX98Compat) { 7816bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(From))) 7826bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines return; 7836bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(To))) 7846bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines return; 7855af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 7866bcf27bb9a4b5c3f79cb44c0e4654a6d7619ad89Stephen Hines unsigned FromScope = LabelAndGotoScopes[From]; 7875af280ce21af061f96b5b5b752746871e364ba99Chris Lattner unsigned ToScope = LabelAndGotoScopes[To]; 7881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7895af280ce21af061f96b5b5b752746871e364ba99Chris Lattner // Common case: exactly the same scope, which is fine. 7905af280ce21af061f96b5b5b752746871e364ba99Chris Lattner if (FromScope == ToScope) return; 7911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7923ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar // Warn on gotos out of __finally blocks. 7933ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar if (isa<GotoStmt>(From) || isa<IndirectGotoStmt>(From)) { 7943ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar // If FromScope > ToScope, FromScope is more nested and the jump goes to a 7953ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar // less nested scope. Check if it crosses a __finally along the way. 7963ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar for (unsigned I = FromScope; I > ToScope; I = Scopes[I].ParentScope) { 7973ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar if (Scopes[I].InDiag == diag::note_protected_by_seh_finally) { 7983ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar S.Diag(From->getLocStart(), diag::warn_jump_out_of_seh_finally); 7993ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar break; 8003ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar } 8013ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar } 8023ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar } 8033ea9e33ea25e0c2b12db56418ba3f994eb662c04Pirama Arumuga Nainar 8045e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall unsigned CommonScope = GetDeepestCommonScope(FromScope, ToScope); 8051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8065e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // It's okay to jump out from a nested scope. 8075e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall if (CommonScope == ToScope) return; 8081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8095e2a7acbdc9e4aee4da54e1e2f560a78bf6fb3c1John McCall // Pull out (and reverse) any scopes we might need to diagnose skipping. 8100e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith SmallVector<unsigned, 10> ToScopesCXX98Compat; 811c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet SmallVector<unsigned, 10> ToScopesError; 812c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet SmallVector<unsigned, 10> ToScopesWarning; 813c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet for (unsigned I = ToScope; I != CommonScope; I = Scopes[I].ParentScope) { 814651f13cea278ec967336033dd032faef0e9fc2ecStephen Hines if (S.getLangOpts().MSVCCompat && JumpDiagWarning != 0 && 815c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet IsMicrosoftJumpWarning(JumpDiagError, Scopes[I].InDiag)) 816c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet ToScopesWarning.push_back(I); 8170e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith else if (IsCXX98CompatWarning(S, Scopes[I].InDiag)) 8180e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith ToScopesCXX98Compat.push_back(I); 819c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet else if (Scopes[I].InDiag) 820c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet ToScopesError.push_back(I); 821c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet } 822ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 823c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet // Handle warnings. 824c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet if (!ToScopesWarning.empty()) { 825c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet S.Diag(DiagLoc, JumpDiagWarning); 8260e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith NoteJumpIntoScopes(ToScopesWarning); 827c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet } 828ddb0b4d5391d3e6bc9dcf93dc42310b20c96b6fcJohn McCall 829c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet // Handle errors. 830c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet if (!ToScopesError.empty()) { 831c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet S.Diag(DiagLoc, JumpDiagError); 8320e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith NoteJumpIntoScopes(ToScopesError); 8330e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith } 8340e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith 8350e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith // Handle -Wc++98-compat warnings if the jump is well-formed. 8360e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith if (ToScopesError.empty() && !ToScopesCXX98Compat.empty()) { 8370e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith S.Diag(DiagLoc, JumpDiagCXX98Compat); 8380e9e9814a7f8313c0c02b6afea71f0e4c411873eRichard Smith NoteJumpIntoScopes(ToScopesCXX98Compat); 839c985b88efc9188845952ab524fe6d4717705257bFrancois Pichet } 8405af280ce21af061f96b5b5b752746871e364ba99Chris Lattner} 8415af280ce21af061f96b5b5b752746871e364ba99Chris Lattner 842176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hinesvoid JumpScopeChecker::CheckGotoStmt(GotoStmt *GS) { 843176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines if (GS->getLabel()->isMSAsmLabel()) { 844176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines S.Diag(GS->getGotoLoc(), diag::err_goto_ms_asm_label) 845176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines << GS->getLabel()->getIdentifier(); 846176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines S.Diag(GS->getLabel()->getLocation(), diag::note_goto_ms_asm_label) 847176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines << GS->getLabel()->getIdentifier(); 848176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines } 849176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines} 850176edba5311f6eff0cad2631449885ddf4fbc9eaStephen Hines 8515af280ce21af061f96b5b5b752746871e364ba99Chris Lattnervoid Sema::DiagnoseInvalidJumps(Stmt *Body) { 8526490ae5003226cae28f980648948bea8b21a8638Douglas Gregor (void)JumpScopeChecker(Body, *this); 8535af280ce21af061f96b5b5b752746871e364ba99Chris Lattner} 854