History log of /external/skia/src/core/SkGeometry.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
507ef6d68115ae9e6d884bb36436a1463523d893 31-Jan-2016 mtklein <mtklein@chromium.org> SkNx Load/store: take any pointer.

This means we can remove a lot of explicit casts in code that uses SkNx.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1650653002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1650653002
/external/skia/src/core/SkGeometry.h
5ba2b9612ae4bc3a244bf45f1ec55c3a5a41e181 27-Jan-2016 caryclark <caryclark@google.com> move more geometry to simd

Remove duplicate quad and cubic code around
computing the polynomial coefficients, and
use common SIMD-based code instead.

R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633143002

Review URL: https://codereview.chromium.org/1633143002
/external/skia/src/core/SkGeometry.h
a273c0f6676b261ef82bc43b0dcc53282f2bdf8c 25-Jan-2016 caryclark <caryclark@google.com> remove legacy defines

The defines

SK_SUPPORT_LEGACY_ARCTO
SK_SUPPORT_LEGACY_CONIC_MEASURE
SK_SUPPORT_LEGACY_DASH_MEASURE
SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS
SK_SUPPORT_LEGACY_PATH_MEASURE_TVALUE

have been removed from Chrome. This removes the obsolete code
from Skia as well.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1627703002

Review URL: https://codereview.chromium.org/1627703002
/external/skia/src/core/SkGeometry.h
88651aeb551fb02003a7600679e8e7df8a589e7f 20-Jan-2016 caryclark <caryclark@google.com> replace arcto quads with a conic

also, remove code used only for
the quad generation

R=reed@google.com
BUG=578885
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612543003

Review URL: https://codereview.chromium.org/1612543003
/external/skia/src/core/SkGeometry.h
b6474dd1a530a543ae799c3822e8bc60180761c0 19-Jan-2016 caryclark <caryclark@google.com> fix circular dashing

Path measure cannot use the same code approach for quadratics
and cubics. Subdividing cubics repeatedly does not result in
subdivided t values, e.g. a quarter circle cubic divided in
half twice does not have a t value equivalent to 1/4.

Instead, always compute the cubic segment from a pair of
t values.

When finding the length of the cubic through recursive measures,
it is enough to carry the point at a given t to the next
subdivision.

(Chrome suppression has landed already.)

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1602153002

Review URL: https://codereview.chromium.org/1602153002
/external/skia/src/core/SkGeometry.h
96fcdcc219d2a0d3579719b84b28bede76efba64 27-Aug-2015 halcanary <halcanary@google.com> Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002

Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkGeometry.h
612f70d5fa2d4bf7a393c791966bbce933407017 19-May-2015 caryclark <caryclark@google.com> handle large conic strokes better

A stroked conic computes the outset quad's control point by
computing the intersection of the quad's endpoints. If the
the denominator used to compute the scale factor for the
control point is small, check to see if the numerator is also
small so that the division stays bounded.

Also clean up error returns and internal function calls to
simplify the code.

Additionally, remove comic max curvature (unimplemented) and call
extrema functions instead to handle cases where the conic is degenerate
or is a line.

R=reed@google.com, fmalita@chromium.org
BUG=skia:3843

Review URL: https://codereview.chromium.org/1144883003
/external/skia/src/core/SkGeometry.h
dc3088570f945ed0ede84f0af0016eedc267dda3 30-Apr-2015 reed <reed@google.com> use pathops utils to improve precision of cubic chopping in scan converter

BUG=skia:

Review URL: https://codereview.chromium.org/1113963002
/external/skia/src/core/SkGeometry.h
0b71278679f1ce2bdbabe117285bc1b3166d372a 16-Apr-2015 reed <reed@chromium.org> remove older version of cubic->coeff

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1084623004
/external/skia/src/core/SkGeometry.h
6983f66d8b3a489133b751e2cef03e72a03bfeae 16-Apr-2015 reed <reed@chromium.org> Speeup hairline curves (quads and cubics) (patchset #7 id:120001 of https://codereview.chromium.org/1078413003/)"

ah ha! Check for the define *after* we pull in SkUserConfig.h (indirectly)

This reverts commit 639a82855b94b93c4fa45560e67df8ec4a8bbb3a.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1084283003
/external/skia/src/core/SkGeometry.h
639a82855b94b93c4fa45560e67df8ec4a8bbb3a 15-Apr-2015 reed <reed@google.com> Revert of Speeup hairline curves (quads and cubics) (patchset #7 id:120001 of https://codereview.chromium.org/1078413003/)

Reason for revert:
Crazy failings in chrome tests
http://build.chromium.org/p/client.skia/builders/Linux%20Tests/builds/1862

Original issue's description:
> Speeup hairline curves (quads and cubics)
>
> /skia/trunk> cat ../old.txt
> maxrss loops min median mean max stddev samples config bench
> 9M 1 4.28ms 4.32ms 4.36ms 4.67ms 3% ▄▁▁▃▂▂▁▁▂█ 8888 path_hairline_small_AA_cubic
> 9M 1 743µs 767µs 770µs 825µs 4% ▃▃▇▃▁▁▅▁█▁ 8888 path_hairline_small_AA_conic
> 9M 1 533µs 606µs 598µs 680µs 9% ▁▂▂█▆▇▇▄▂▂ 8888 path_hairline_small_AA_quad
> 9M 1 451µs 452µs 456µs 495µs 3% ▁▁▁▁█▁▁▁▁▁ 8888 path_hairline_small_AA_line
>
> /skia/trunk> cat ../new.txt
> maxrss loops min median mean max stddev samples config bench
> 9M 1 827µs 827µs 831µs 869µs 2% ▁▁▁▁▁▁▁█▁▁ 8888 path_hairline_small_AA_cubic
> 9M 1 515µs 517µs 517µs 518µs 0% ▇█▆▅▃▃▁▁▁▅ 8888 path_hairline_small_AA_conic
> 9M 1 310µs 311µs 315µs 332µs 2% ▂▁█▆▁▁▁▁▁▁ 8888 path_hairline_small_AA_quad
> 9M 1 254µs 254µs 258µs 276µs 3% ▁▁▁▁▁▁▁█▇▂ 8888 path_hairline_small_AA_line
>
> Edited revert of https://codereview.chromium.org/1085013003
>
> TBR=
>
> Expectations:
> - no effect on chrome, as it is guarded
> - lots of tiny rebaselines for skia

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1092483003
/external/skia/src/core/SkGeometry.h
a0246165eab9018d07afc09ff826ea4c40898ebc 15-Apr-2015 reed <reed@google.com> Speeup hairline curves (quads and cubics)

/skia/trunk> cat ../old.txt
maxrss loops min median mean max stddev samples config bench
9M 1 4.28ms 4.32ms 4.36ms 4.67ms 3% ▄▁▁▃▂▂▁▁▂█ 8888 path_hairline_small_AA_cubic
9M 1 743µs 767µs 770µs 825µs 4% ▃▃▇▃▁▁▅▁█▁ 8888 path_hairline_small_AA_conic
9M 1 533µs 606µs 598µs 680µs 9% ▁▂▂█▆▇▇▄▂▂ 8888 path_hairline_small_AA_quad
9M 1 451µs 452µs 456µs 495µs 3% ▁▁▁▁█▁▁▁▁▁ 8888 path_hairline_small_AA_line

/skia/trunk> cat ../new.txt
maxrss loops min median mean max stddev samples config bench
9M 1 827µs 827µs 831µs 869µs 2% ▁▁▁▁▁▁▁█▁▁ 8888 path_hairline_small_AA_cubic
9M 1 515µs 517µs 517µs 518µs 0% ▇█▆▅▃▃▁▁▁▅ 8888 path_hairline_small_AA_conic
9M 1 310µs 311µs 315µs 332µs 2% ▂▁█▆▁▁▁▁▁▁ 8888 path_hairline_small_AA_quad
9M 1 254µs 254µs 258µs 276µs 3% ▁▁▁▁▁▁▁█▇▂ 8888 path_hairline_small_AA_line

Edited revert of https://codereview.chromium.org/1085013003

TBR=

Review URL: https://codereview.chromium.org/1078413003
/external/skia/src/core/SkGeometry.h
55011038816a3fc7f0c0a39d482fb85347cc2e78 26-Mar-2015 reed <reed@google.com> use new faster/vector impl for chopping conics

BUG=skia:

Review URL: https://codereview.chromium.org/1035943002
/external/skia/src/core/SkGeometry.h
c08330f1601aeca7f10aeb2194118decbfbf83e1 26-Mar-2015 reed <reed@google.com> remove slower scalar code in favor of vectors

BUG=skia:

Review URL: https://codereview.chromium.org/1001833006
/external/skia/src/core/SkGeometry.h
6b9ef90c029c7c783f156ffd6fb1ba047bec63e0 25-Mar-2015 reed <reed@chromium.org> SkChopCubicAt2 using Sk2s -- 2x faster

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1036753002
/external/skia/src/core/SkGeometry.h
b640203cd5733aaf110277e28e22007c5b541565 20-Mar-2015 reed <reed@google.com> use Sk2s for conics

BUG=skia:

Review URL: https://codereview.chromium.org/1025033002
/external/skia/src/core/SkGeometry.h
40b7dd57ef1f4e91af72512d8ca57459b99d71bd 20-Mar-2015 reed <reed@google.com> use Sk2s for EvalQuadTangent and ChopQuadAt

cloned from https://codereview.chromium.org/1026633002/

BUG=skia:

Review URL: https://codereview.chromium.org/1024873003
/external/skia/src/core/SkGeometry.h
65cb2cd2f7ad4146f055810b8bd77bff03a4e76e 19-Mar-2015 reed <reed@chromium.org> alt SkEvalQuadAt that returns its answer, using Sk2f

BUG=skia:

Review URL: https://codereview.chromium.org/1011493003
/external/skia/src/core/SkGeometry.h
562d0e1cd2286945cb73fca0233560071b052129 19-Mar-2015 reed <reed@chromium.org> remove unused SkXRay functions

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1016263002
/external/skia/src/core/SkGeometry.h
88f0a99fd48cfb30ca5596182f8932d76cd76f17 10-Feb-2015 reed <reed@google.com> Use conics for round joins and caps

patch from issue 909013004 at patchset 20001 (http://crrev.com/909013004#ps20001)

BUG=skia:
TBR=caryclark

Review URL: https://codereview.chromium.org/910213002
/external/skia/src/core/SkGeometry.h
d5d27d9b146731b871b1bcc6d6de36fba2d5ea44 09-Feb-2015 reed <reed@google.com> use conics for arcTo

guarded by SK_SUPPORT_LEGACY_ARCTO_QUADS

BUG=skia:

Review URL: https://codereview.chromium.org/892703002
/external/skia/src/core/SkGeometry.h
220f926d9d4b38a9018c922c095847bbd261f583 17-Dec-2014 reed <reed@google.com> use conics

BUG=skia:

Review URL: https://codereview.chromium.org/455043002
/external/skia/src/core/SkGeometry.h
8dd31cf69e24ff82865309781107dfab948b6a02 12-Dec-2014 caryclark <caryclark@google.com> Extract cubic classification from gpu into geometry

Move code from the GPU path utilities into geometry so that
path ops can share.

Review URL: https://codereview.chromium.org/787763007
/external/skia/src/core/SkGeometry.h
891372c3b5b8229cf5c20b085f2d9448525f98e4 12-Dec-2014 reed <reed@chromium.org> use SkScalar instead of float

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/796803005
/external/skia/src/core/SkGeometry.h
859b92448b27bb16852474f9a612748b3fd816d5 17-Jun-2014 reed <reed@google.com> move some headers out of public

patch from issue 338263003

BUG=skia:
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/339183002
/external/skia/src/core/SkGeometry.h
6efdc47afc8bb24603fc0d15146ada609b728f2f 19-Dec-2008 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> first cut at event-based test app



git-svn-id: http://skia.googlecode.com/svn/trunk@37 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkGeometry.h
8a1c16ff38322f0210116fa7293eb8817c7e477e 17-Dec-2008 reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> grab from latest android



git-svn-id: http://skia.googlecode.com/svn/trunk@27 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkGeometry.h