afc7cce5d68663934128d76963cd501f771d71de |
|
03-Feb-2016 |
senorblanco <senorblanco@chromium.org> |
Fix for rounded-rect clips with filters. Don't use the base canvas size to limit raster of complex clips, since the top canvas size may actually be larger (e.g., a blur filter which expands the clip bounds to accommodate filter margins). Use the top canvas bounds instead. BUG=skia:4879,471212 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657333002 Review URL: https://codereview.chromium.org/1657333002
/external/skia/src/core/SkRasterClip.h
|
125f19a2964c31a660256132acbce60e8a3e6752 |
|
23-Nov-2015 |
robertphillips <robertphillips@google.com> |
Avoid devolving to a path when conservative clipping with RRects Review URL: https://codereview.chromium.org/1461923004
/external/skia/src/core/SkRasterClip.h
|
d954498c01ccf0417feacf89e45d0c62a06a813b |
|
10-Sep-2014 |
reed <reed@chromium.org> |
Revert of Revert of allow canvas to force conservative clips (for speed) (patchset #1 id:1 of https://codereview.chromium.org/554033003/) Reason for revert: May just rebaseline, plus want to see the results of the chrome tests, so re-trying this CL. Original issue's description: > Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/) > > Reason for revert: > multipicturedraw failed on nvprmsaa -- don't know why yet > > Original issue's description: > > Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects: > > > > 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. > > > > 2. The conservative clips mean less work is done. > > > > 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. > > > > 4. API is private for now. > > > > Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241 > > TBR=robertphillips@google.com,bsalomon@google.com,mtklein@google.com,junov@google.com > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/6f09709519b79a1159f3826645f1c5fbc101ee11 R=robertphillips@google.com, bsalomon@google.com, mtklein@google.com, junov@google.com, reed@google.com TBR=bsalomon@google.com, junov@google.com, mtklein@google.com, reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/560713002
/external/skia/src/core/SkRasterClip.h
|
6f09709519b79a1159f3826645f1c5fbc101ee11 |
|
09-Sep-2014 |
reed <reed@google.com> |
Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/) Reason for revert: multipicturedraw failed on nvprmsaa -- don't know why yet Original issue's description: > Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects: > > 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. > > 2. The conservative clips mean less work is done. > > 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. > > 4. API is private for now. > > Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241 R=robertphillips@google.com, bsalomon@google.com, mtklein@google.com, junov@google.com TBR=bsalomon@google.com, junov@google.com, mtklein@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: reed@google.com Review URL: https://codereview.chromium.org/554033003
/external/skia/src/core/SkRasterClip.h
|
27a5e656c3d6ef22f9cb34de18e1b960da3aa241 |
|
09-Sep-2014 |
reed <reed@google.com> |
Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects: 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. 2. The conservative clips mean less work is done. 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. 4. API is private for now. R=robertphillips@google.com, bsalomon@google.com, mtklein@google.com, junov@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/541593005
/external/skia/src/core/SkRasterClip.h
|
49e3199e638595d7e8b8bf41081eb9cac5daaa2d |
|
09-Sep-2014 |
george <george@mozilla.com> |
SkRasterClip::quickReject doesn't need to check for emptiness as SkIRect::Intersect already does that for us R=reed@google.com, reed1 BUG=skia: Author: george@mozilla.com Review URL: https://codereview.chromium.org/554743007
/external/skia/src/core/SkRasterClip.h
|
d64c9487135094c83f658319f53ea2005ecc08b2 |
|
06-Sep-2014 |
reed <reed@google.com> |
move rasterclip_ helper into rasterclip R=robertphillips@google.com, reed@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/546113002
/external/skia/src/core/SkRasterClip.h
|
202ab2a5cabaf25a1e6ec47c0003da3213a79864 |
|
07-Aug-2014 |
reed <reed@google.com> |
add isRect() check to AAClip, to detect if a soft-clip is really just an irect taken from (https://codereview.chromium.org/445233006/) fix: don't assume that the first yoffset is 0, since we may have performed a translate and not re-alloced our data. This reverts commit 0aeea6d344f12e35e29a79f4bbc48af88f913204. TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/443353004
/external/skia/src/core/SkRasterClip.h
|
0aeea6d344f12e35e29a79f4bbc48af88f913204 |
|
07-Aug-2014 |
reed <reed@google.com> |
Revert of add isRect() check to AAClip, to detect if a soft-clip is really just an irect (https://codereview.chromium.org/445233006/) Reason for revert: new code asserts on some pictures Original issue's description: > add isRect() check to AAClip, to detect if a soft-clip is really just an irect > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/592cb8d552556b1e922887d506d00b64bc5d0547 R=bsalomon@google.com, humper@google.com TBR=bsalomon@google.com, humper@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/452533002
/external/skia/src/core/SkRasterClip.h
|
592cb8d552556b1e922887d506d00b64bc5d0547 |
|
07-Aug-2014 |
reed <reed@google.com> |
add isRect() check to AAClip, to detect if a soft-clip is really just an irect BUG=skia: R=bsalomon@google.com, humper@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/445233006
/external/skia/src/core/SkRasterClip.h
|
e61a86cfa00ea393ecc4a71fca94e1d476a37ecc |
|
18-Nov-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Guard against most unintentionally ephemeral SkAutoFoo instantiations. I think I applied the trick everywhere possible. Limitations: - can't be used with templated classes - all constructors and destructors must be defined inline A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I deleted them. This change caught the same bugs Cary found in SkPath, plus one more in SampleApp. BUG= R=reed@google.com, caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/72603005 git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
b446fc7f05d2e3f22d574187b433e02b0c781e1f |
|
10-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove SkRasterClip::setPath(const SkPath&, const SkRasterClip&, bool). The method is only used in SkCanvas::clipPathHelper() and only called when isRect() is true (which effectively disables the !isBW branch). Thus, we can promote the isBW branch to the caller and drop the rest of the method. R=reed@google.com Author: fmalita@chromium.org Review URL: https://chromiumcodereview.appspot.com/18552004 git-svn-id: http://skia.googlecode.com/svn/trunk@9974 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
48552314f6d101f3fd094d5f2fd6f70fe9aad841 |
|
26-Mar-2013 |
tfarina@chromium.org <tfarina@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix a few clang errors while trying to build tools target. Most of the errors were like: ../../src/gpu/gl/GrGLEffectMatrix.cpp:74:9: error: variable 'varyingType' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] ../../src/gpu/gl/debug/GrDebugGL.h:125:21: error: private field 'fMaxTextureUnits' is not used [-Werror,-Wunused-private-field] ../../src/core/SkBitmapSampler.cpp:312:25: error: private field 'fProcTable' is not used [-Werror,-Wunused-private-field] R=bsalomon@google.com,scroggo@google.com Review URL: https://codereview.chromium.org/12915007 git-svn-id: http://skia.googlecode.com/svn/trunk@8403 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
fbfcd5602128ec010c82cb733c9cdc0a3254f9f3 |
|
23-Aug-2012 |
rmistry@google.com <rmistry@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) This CL is part I of IV (I broke down the 1280 files into 4 CLs). Review URL: https://codereview.appspot.com/6485054 git-svn-id: http://skia.googlecode.com/svn/trunk@5262 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
a1c6ff4922251065c45e3323e17e985a62931fc7 |
|
11-May-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
inline isEmpty and isRect (faster) git-svn-id: http://skia.googlecode.com/svn/trunk@3907 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
045e62d715f5ee9b03deb5af3c750f8318096179 |
|
24-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
enable soft clipping (yikes) git-svn-id: http://skia.googlecode.com/svn/trunk@2515 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
34f7e47a3593911d03307a08e5af625b218ceec3 |
|
13-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
checkpoint -- more support changes for soft clipping git-svn-id: http://skia.googlecode.com/svn/trunk@2475 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
0017708a5bcb6d0fbff0fac565085bef65de7433 |
|
12-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
use SkRasterClip inside canvas (check-point for soft clipping) git-svn-id: http://skia.googlecode.com/svn/trunk@2462 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
ba16da97e82e7ec9b73caa752b00504206ff516d |
|
11-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add op(rgn, op) git-svn-id: http://skia.googlecode.com/svn/trunk@2454 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|
d1e3c5fde3f2ed309273cb08dbba2309b13e527f |
|
10-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add experimental wrapper for region+aaclip git-svn-id: http://skia.googlecode.com/svn/trunk@2451 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkRasterClip.h
|