| 02cd0f91059f04136bb3817b41305c2909f4f1d5 |
|
13-Jan-2016 |
Alan Viverette <alanv@google.com> |
Clean up lint warnings in popup menu presenter classes
Change-Id: I6b4cce1c4788b408615af0c93575e02e75b4c3ca
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 28a8468995c71ba3fbba12557d143e7599db38d8 |
|
04-Jan-2016 |
Alan Viverette <alanv@google.com> |
Avoid NPE when ActionMenuPresenter is intialized with null MenuBuilder
Also adds annotations to accurately reflect nullability.
Bug: 26318920
Change-Id: Ia3b170dd301edfc0088a11ee5764c24bab2f10aa
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 021627eb5875372dea57ba91fa782fffbfbbc559 |
|
25-Nov-2015 |
Alan Viverette <alanv@google.com> |
Ensure only one context menu is shown at a time
Refactors the menu helper classes. Both classes now implement a common
MenuHelper interface, which eliminates the need to keep separate helpers
on PhoneWindow and unifies the DecorView showContextMenuForChild()
implementations.
We now explicitly dismiss any previously shown context menu before showing
a new context menu. Previously we relied on the modal nature of the dialog
context menu to prevent multiple menus from being opened at once, but this
is no longer reliable with popup context menus.
Bug: 25656520
Change-Id: Idab3daa6d6888f803f2e33660fe1dd488e4c28d1
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 708aa9d96441fe359a4c2a2c89e2ab709b367f8a |
|
20-Nov-2015 |
Alan Viverette <alanv@google.com> |
Dispatch the actual PopupWindow dismiss callback to PopupMenu
Previously the dismiss callback was called immediately after the menu
received a close request; however, the dismiss callback implies that
the menu's window has finished animating and been removed from the
window manager.
Also cleans up handling of mPopup in MenuPopupHelper to prevent
unnecessary MenuPopup allocations and convert unnecessary fields into
method arguments.
Bug: 25323707
Change-Id: I8e3877ae6c40b4d0f1df23a4ff4fa48a7df34e0d
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 6c54e72892bdddd8453cfce40725ed3159d53b11 |
|
17-Nov-2015 |
Filip Gruszczynski <gruszczy@google.com> |
Swtich from max_action_buttons resource to a method.
We want to limit the number of size thresholds that an application will
report. Instead of using a dimen resource that will increase the number
of thresholds, we calculate the max number of action buttons dynamically
in code.
Bug: 25394588
Change-Id: I8ece331cd02fb116b49734003cec112708d27f85
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 00aa5103e2f71ad3f29f53168e37ef7da8ca03f2 |
|
03-Nov-2015 |
Alan Viverette <alanv@google.com> |
Reduce CascadingMenuPopup's reliance on internal ListView state
Bundles cascading menu information and stores it in a stack representing
the hierarchy of added menus.
Bug: 23970448
Change-Id: I1621d9eb30ff173767b6ebad2a1977127c42d0ad
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 8e12f8df076d38853e0fedde7ed79e2e8689d59e |
|
02-Sep-2015 |
Oren Blasberg <orenb@google.com> |
Add Cascading submenus implementation.
This change adds a new Cascading implementation of MenuPopup. When
enabled, submenus will show up in a cascading side by side fashion
when opened next to popup menus.
Bug: 20127825
Change-Id: Ie3c797fb5dbada7521cd93dc4171950af2be2ff7
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| f44d90b5c247f0629201d1fa322b83fa55b20608 |
|
31-Aug-2015 |
Oren Blasberg <orenb@google.com> |
Pull out widget helpers into their own classes.
This is in service of desktop-style submenus. Follow up CLs will make
use of the newly independent classes. MOST of the changes in this CL
are simply moving code from one place to another. Below are
descriptions of the new files added:
DropDownListView:
Decouple this from ListPopupWindow, so other "menu popup"
implementations [forthcoming] may make use of it.
This class is UNCHANGED except for the addition of the
setListSelectionHidden method.
ForwardingListener:
Decouple this from ListPopupWindow, so that other clients of this
listener can expect a more general ShowableListMenu rather than a
concrete ListPopupWindow. This will be useful later when we want to
use something other than ListPopupWindow to show a menu.
This class is UNCHANGED, except for (1) using the getListView() on
popup rather than accessing its mDropDownList member, and (2)
replacing ListPopupWindow return values with ShowableListMenu.
MenuAdapter:
Decouple from MenuPopupHelper so it may be used by forthcoming "menu
popup" implementations rather than just by MenuPopupHelper itself.
This class is UNCHANGED.
ShowableListMenu:
A new interface to encapsulate a menu that can be shown or hidden.
This will be implemented by both ListPopupWindow and a forthcoming
"menu popup" class.
Bug: 20127825
Change-Id: I565b444d25e966ff8b8c6ceac7be8de56a9116df
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| a41b78973db3dfde159f7d641f794f462ad323d3 |
|
09-Jun-2015 |
Chris Banes <chrisbanes@google.com> |
API council review feedback for ActionMenuView
Reverts "MenuItem, navigation and overflow icon tinting" CL,
and adds getter and setter for the overflow icon to ActionMenuView
and Toolbar.
BUG: 21571899
Change-Id: I591f43650356443fa3256e4d74e28b6ddd8c2b33
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| d96c87eb6464854822a2b26865785495a96105de |
|
07-May-2015 |
Chet Haase <chet@google.com> |
Disable ActionBar animations pending more involved fix
Recycling of ActionBar items can cause problems with the current
ActionBar animations, as the system animates views that represent both
pre- and post-layout changes, sometimes causing opposit animations to
run on the same view, resulting in unpredictable effect slike views
remaining invisible.
This 'fix' is a workaround to disable item animations pending a more
complete and robust fix that involves a more involved system of view
recycling that would avoid recycling views that are currently being used
in animations.
Issue #20538912 Menu missing in Downloads app
Change-Id: I7b1d3baf94378e4788f868801a452c6583353842
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 575217fc3da38357f1d5e322bf1c7a07b909ef2a |
|
09-Apr-2015 |
Chet Haase <chet@google.com> |
Make ActionBar animations work correctly
Previous ActionBar animations didn't handle configuration changes
or other situations in which the view would get detached. listeners
would stay on the view and would attempt to do something nonsensical
in the new window. This new approach removes listeners on window
detach to avoid this problem.
Issue #20125407 Settings Crashes when changing orientation of device
Change-Id: I0b3bbd0f6fc23cdb4cbd646b0d2772d72d3d795d
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 1ae7c284403ca514efa36130cf7291a60acd9dc1 |
|
09-Apr-2015 |
Chet Haase <chet@google.com> |
Fix breakage from ActionBar animations
Real fix will come later, but this disables the animations to work
around the current crash.
Issue #20125407 Settings Crashes when changing orientation of device
Change-Id: I748e8889f72483c82cff084c5815322057f16f03
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 74a94059c6b12c2dbbf2d475d6c09a665482a4e7 |
|
08-Apr-2015 |
Jorim Jaggi <jjaggi@google.com> |
Fix crash when removing draw listener
The same behavior can be achieved by using a predraw listener, which
can be removed while the callback is called, so it doesn't crash.
Change-Id: I3a7138ba49936159dc95b7758c9603366dcf808c
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 952cba2e07245609d4dd589edc856fef953050e5 |
|
20-Mar-2015 |
Chet Haase <chet@google.com> |
Animate ActionBar items
Chnages to the ActionBar are now tracked so that new items,
items that go away, and items that change location are now animated into
their new state.
Issue #10863316 action bar items don't fade in correctly
Change-Id: Ia956b2b76958f02108c756dab2d1c2617a5904dc
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 9cc36ca1b520c06f882e84b909f3a2b75d303a06 |
|
23-Feb-2015 |
Chris Banes <chrisbanes@google.com> |
MenuItem, navigation and overflow icon tinting
- iconTint and iconTintMode attrs for MenuItem, with
associated setters.
- navigationTint and navigationTintMode attrs for Toolbar
with associated setters.
- overlflowTint and overflowTintMode attrs for Toolbar
with associated setters.
BUG: 18126050
BUG: 19148351
BUG: 19305408
Change-Id: Ibd1fae7cdbc7a7c42809e52541fae5d8beb18e92
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| a54956a0bc611b1e9b3914edc7a604b59688f6b7 |
|
08-Jan-2015 |
Alan Viverette <alanv@google.com> |
Fix accessibility delegation
Ensures that delegate code is run last. Previously, calling the super
method from an accessibility delegate set on a widget would only run
code in the widget's parent. Next, the delegate code would run. Finally,
the widget's code would run. As a result, the widget code would override
any data supplied by the delegate.
By moving all overridden code to internal methods, we ensure that the
call chain for super includes the widget's parent code followed by the
widget's code. The delegate code will always run last.
BUG: 17641433
Change-Id: Ib9d403156c1fc4fb04f65f3c126d1277a44b3740
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 199ea8c0c759d5993b23467f22f2bff120c93d38 |
|
21-Nov-2014 |
Alan Viverette <alanv@google.com> |
Update overflow menu alignment to match spec
BUG: 18417348
Change-Id: I5e4b1ca366c554bca33eac8e5403be6de72370f9
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 9d9581f52edcbd086edcd4153e9daa29c0205256 |
|
12-Sep-2014 |
Alan Viverette <alanv@google.com> |
Fix toolbar height, list divider alpha, action item padding
BUG: 17487305
BUG: 17470290
BUG: 17486967
Change-Id: Ib0cb4308f9d57e730504bdeb125662b648cad0f7
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| f023c2530a4591889dda614aaa016d5a9f9617ed |
|
28-Aug-2014 |
Alan Viverette <alanv@google.com> |
Update action bar item widths, overflow menu, button, and spinner styles
Manually modifies the overflow button hotspot bounds so that the ripple
appears to be centered on the overflow icon. Adds styleable and parsing
for list popup window offsets. Updates spinner text appearance to be
consistent with drop down item text appearance. Also updates horizontal
inner padding in buttons.
BUG: 17305079
BUG: 17304391
BUG: 17302567
Change-Id: Iafddfef290078de968894a3b443ba9f60f84c6d4
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| d361a4f98bbc03cb61b9ac4504eda490ff704b60 |
|
01-Jul-2014 |
Alan Viverette <alanv@google.com> |
Use touch hotspot in drag-to-open, fix forwarding cancellation
BUG: 14230395
Change-Id: Ibea615bcd6a2e57fca8b49ffea23f0df951d497c
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| e021e6ed8931a0a8296af182fc9b0c76b64fb0c4 |
|
24-May-2014 |
Adam Powell <adamp@google.com> |
Toolbar factoring and ActionBar functionality integration
Toolbars now can act in the role of ActionBar with the exception of
navigation modes. Expandable action views are now supported as well as
populating menu items from a host window.
Change-Id: If477db9c7ad9f95723f28cf73cbf03a07ce9d6ad
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 560f17098f90b15c8894cce127f2fed85f7aeb6b |
|
05-May-2014 |
Alan Viverette <alanv@google.com> |
Add support for popups overlapping anchors
BUG: 14471731
Change-Id: I16e8d76caedfebd0c38b8c0b22cd9619d70877c8
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| e43340c80dc66c45edc793ecd0343774aa34d108 |
|
18-Mar-2014 |
Adam Powell <adamp@google.com> |
android.widget.Toolbar
Add the new Toolbar widget for use in app layouts.
ActionBar can now be used as a point of control for either a
traditional window decor action bar or for a Toolbar that appears
inline in an Activity's layout.
ToolbarActionBar is currently WIP.
Change-Id: I0da093e5645840f4fd032aa34efa0ae5f1825ff2
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| 56110725f2a0b3f09703f2cbe9705d97609ee1e5 |
|
10-Jan-2014 |
Alan Viverette <alanv@google.com> |
Move drag-to-open handling into ActionMenuItemView
This prevents the menu item's OnClickListener from being overwritten,
allows the client to override item invocation, and prevents showing
multiple popups when items are re-initialized.
BUG: 11969895
BUG: 12489213
Change-Id: I97ca737810073df348171cdba5442f24a5527f89
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|
| fe9c354ccdf02247eae8e5f4d1cceb10484ab904 |
|
10-Jan-2014 |
Adam Powell <adamp@google.com> |
am 9c9975ac: Merge "Fix a bug where OnTouchListeners in action views could be removed" into klp-modular-dev
* commit '9c9975ac3dc63423751c4783162d4ade11d156c1':
Fix a bug where OnTouchListeners in action views could be removed
|
| fa18d182a3f37505940e73ae6cd76c2e939f7f7c |
|
08-Jan-2014 |
Adam Powell <adamp@google.com> |
Move ActionMenuView into android.widget and make it public
Expose ActionMenuView as a way for applications to present
ActionBar-style menus in other embedded or repeating contexts.
Change-Id: I54b7ccd9b2116ca68bc72956da9262bca9d5085f
/frameworks/base/core/java/android/widget/ActionMenuPresenter.java
|