| 657d20afa621219c1eed72178d1325fd4409f458 |
|
17-Dec-2015 |
David Gross <dgross@google.com> |
Cleanup: RSExportType::getSize() has inconsistent semantics.
This is a virtual method with different semantics for different
classes in the type hierarchy:
RSExportPrimitiveType: Returns number of bytes occupied by type
RSExportPointerType: Returns 1
RSExportVectorType: Returns number of bytes occupied by one element
(i.e., of the component type)
RSExportMatrixType: Returns 1
RSExportConstantArrayType: Returns the number of array elements
RSExportRecordType: Returns 1
The fix is to replace this method with methods whose names
indicate their actual semantics.
Bug: 26235282
Change-Id: Ic7c5cfd1b73a0b6e7e6fd4ed0495de3877adf0e8
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 5abbe0e9ca2508260b627ffef2bf01e2554e8357 |
|
13-Aug-2014 |
Chris Wailes <chriswailes@google.com> |
Replace the NULL macro with nullptr literal.
Change-Id: I33609969cd0d7aa55eaa83fb2c65f5faa6d55fa0
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 796e7b1400d3f3f7c07496d88bb48129ea925bb9 |
|
27-May-2014 |
Jean-Luc Brouillet <jeanluc@google.com> |
Remove useless "return;" statements.
More cleanups to follow...
Change-Id: Ib8348255273771c1e9ff07e79bd7fbc8f2795a5b
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| d3f7527b105d21f1c69d3473eb88a762f2c3ab5a |
|
17-Jan-2014 |
Jean-Luc Brouillet <jeanluc@google.com> |
Add ReportErrror/Warning to RSContext.
Remove a lot of boilerplate code by adding error reporting methods to RSContext. There are still a few additional files that could be cleaned. That will be for another CL someday.
Change-Id: I6a261735720227ac87d94dbdea5ce4a7b8ef6cca
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| e37f7d349704bdd8c94afad7c6021561787ec5c9 |
|
03-Aug-2012 |
Shih-wei Liao <sliao@google.com> |
Fix build.
Change-Id: I05078283396a9f85b176c930a9f6333f1d02bfae
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 1f6c331d622ac645ab68a016aa4c577998547373 |
|
04-Jul-2012 |
Stephen Hines <srhines@google.com> |
Fix reflection of setters for unsigned primitive types.
BUG=6764163
We now generate set_*() functions for unsigned types by creating a single
element FieldPacker and stuffing it with the larger Dalvik type. Reusing
FieldPacker in this way allows us to validate that the input is non-negative
and within the appropriate range (i.e. not really using more bits than the
unsigned C type should).
This change also fixes a subtle race where the Dalvik and script side can
disagree about a variable's value. All set_*() methods need to be synchronized,
and we must do the Dalvik update after validating the input data.
Change-Id: I7b2371206848ebbf0b0752779cb6c98cec1ab5f6
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| e67239de8d94975e7e2216ee6860ae2e6cb8b15a |
|
25-Feb-2012 |
Stephen Hines <srhines@google.com> |
Style violation cleanup.
Change-Id: Idb127f2fd6e637039454f47299360aec5a4edfe8
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| d369cda199b11ae28a1935e06398c2162cf146f3 |
|
13-Feb-2012 |
Stephen Hines <srhines@google.com> |
Support initialization of constant array exports.
BUG=5901034
Change-Id: Ibdc74323080518223bbf79caef0c91030c501f17
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| f5eeaa6aac0c5ac612ec69f808609e95b97d6829 |
|
13-Feb-2012 |
Stephen Hines <srhines@google.com> |
Revert "Support initialization of constant array exports."
This reverts commit dc8853ace563c3a7e1976d570bf8fe96cfb11446.
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| dc8853ace563c3a7e1976d570bf8fe96cfb11446 |
|
07-Feb-2012 |
Stephen Hines <srhines@google.com> |
Support initialization of constant array exports.
BUG=5901034
Change-Id: I61fba1cdf54a5e3289da01730e8bc3d0d2e72050
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 4c622e0953afe3dca4da0aee364a811f3ccb61d9 |
|
11-Nov-2011 |
Stephen Hines <srhines@google.com> |
Adapt to upstream changes.
Change-Id: I9ab7bad890eb78621c5fc6dd516dbcacdad88471
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 6e6578a360497f78a181e63d7783422a9c9bfb15 |
|
08-Feb-2011 |
Stephen Hines <srhines@google.com> |
Add support for assertions in llvm-rs-cc.
Bug: 3430674
Change-Id: I3400238652449cde84275cc2a770f405332d9544
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| e639eb5caa2c386b4a60659a4929e8a6141a2cbe |
|
09-Nov-2010 |
Stephen Hines <srhines@google.com> |
Improve code style.
Change-Id: I26e043849bce2a4b41ae132fbe0c882f4a6f112f
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 9e5b503349719144f63ccb7c62ee9c291a7d83b8 |
|
03-Nov-2010 |
Stephen Hines <srhines@google.com> |
Use Clang object references instead of pointers.
Change-Id: Ief0e78859572761d880eaad9ae854f14e65da2c4
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 641558f02fe6ce0ee3ae5076eb366c25e2ad5903 |
|
12-Oct-2010 |
Zonr Chang <zonr@google.com> |
Implement one-definition-rule (ODR) feature.
When compiling multiple RS files, we say two RS files A and B break ODR
iff:
1. They have at least one common struct named [S] and [S] will be reflected
to ScriptField_[S].java, and
2. [S] defined in A is not *exactly the same* (number of fields, field
type and field name) as the one defined in B.
This CL detects such error.
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| c383a500aa59423264811be3874461bf8adbfea0 |
|
11-Oct-2010 |
Zonr Chang <zonr@google.com> |
Prepend legal announcement in all files.
Release libslang/llvm-rs-cc/llvm-rs-link under Apache 2.0 license.
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| a41ce1d98094da84643995d40d71c529905123fc |
|
05-Oct-2010 |
Zonr Chang <zonr@google.com> |
Fix memory leak of RSExport* object create in processExport(). Now, they will
properly be freed after their associated RSContext was destroyed.
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 6315f76e3cc6ff2d012d1183a0b030d4ff0dc808 |
|
05-Oct-2010 |
zonr <zonr@google.com> |
More coding style fixing to improve the readability. No actual semantics
changed. This also makes cpplint happy.
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 9ef2f785e0cc490af678dfd685995dec787321ff |
|
01-Oct-2010 |
Shih-wei Liao <sliao@google.com> |
The Mother-of-All code review:
1. Fix AllowRSPrefix bug
2. Remove member mRS*Pragma in class RSContext
3. No longer only support 2x2, 3x3, 4x4 arrays
4. Fix Export All code for victorhsieh
5. Improve readability and maintainability
6. size_t -> int in calculating padding
Change-Id: I772aebd1440af66a89e2d2e688b193e500f38d69
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| f52a620440fa62257dfdcf2583f0f9df5b855c76 |
|
11-Sep-2010 |
Shih-wei Liao <sliao@google.com> |
Apply changes on slang such that it can work with LLVM/Clang upstream r112364/r112367.
Change-Id: If38da28502a6111b855105c2fceb23fdb0caefa4
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 81c1b4865e9c8fd655ea4528814f6c53e225ba6d |
|
20-Jul-2010 |
Shih-wei Liao <sliao@google.com> |
Add QT.isConstQualified, to determine whether set_* needs to be reflected.
Change-Id: Ic59c6af9be8878c0b78a494c5f6bb6a2a594ce67
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 324c0479ec3edda573de60b2e6476507a99d06f7 |
|
21-Jun-2010 |
Shih-wei Liao <sliao@google.com> |
Reflect initializer of an exported variable if any.
(NOTE: record type is unsupported currently)
Change-Id: I26fa50dc38488217420a25bafb07f29f6ab28d28
/frameworks/compile/slang/slang_rs_export_var.cpp
|
| 462aefd62cc646d2ff753c1d003ef3cd7bbea262 |
|
05-Jun-2010 |
Shih-wei Liao <sliao@google.com> |
Initialize slang and Android.mk.
Change-Id: If74da8e54d45511c8c9bb236bcfeec508f4f2439
/frameworks/compile/slang/slang_rs_export_var.cpp
|