| e8abe8e5ad830bd130b258c6801d75f6542200b5 |
|
01-Apr-2016 |
Lifu Tang <lifu@google.com> |
Addressed API review comments and updated JavaDoc
Bug: 27274532
Bug: 27948390
Change-Id: I0255d2511deab788dcab9815def9c1287a50b7f9
/frameworks/base/services/core/java/com/android/server/location/GnssNavigationMessageProvider.java
|
| 76a620f0482ba54a4921c7c7e7eeb8ea87c12d3e |
|
27-Feb-2016 |
Lifu Tang <lifu@google.com> |
Addressed the review comments from API Council
Following are the review comments from API Council:
(Places below that reference "s/foo/bar/" below are suggesting that "foo" be
replaced with "bar".)
GnssClock
-- Class docs should not refer to "GPS" at the top level
-- s/InNs/Nanos/
-- s/Sec/Second/
GnssMeasurement
-- s/In// for "InUnitname"
-- s/Sec/Second/
-- s/Ms/Millis/
-- s/Deg/Degrees/
-- STATUS_GPS_LOCATION_DISABLED -> STATUS_GNSS_LOCATION_DISABLED
GnssMeasurementsEvent.Callback
-- "returns" -> "reports" in the method docs as the methods return void
LocationManager
-- register/unregisterGnssMeasurementEventCallback ->
register/unregisterGnssMeasurementsEventCallback (plural)
GnssNavigationMessage
-- MESSAGE_TYPE_ constants -> change to just TYPE_; the "MESSAGE" is redundant
with the class name
-- is a signed byte/short ok based on the standard here? If not consider using
int in the public api
GnssStatus
-- Make sure @IntDef exists for the constellation type
-- Please append unit types for values returned to match GnssMeasurement methods
GnssStatusCallback
-- Please document time base/units for the time parameter of onFirstFix
Bug: 27385557
Change-Id: Ifed6a2eca3fd7ba89b3ded6964a70376235af8f4
/frameworks/base/services/core/java/com/android/server/location/GnssNavigationMessageProvider.java
|
| 818aa2c2c46addae934fb6cd42f889affc9ef747 |
|
01-Feb-2016 |
Lifu Tang <lifu@google.com> |
Rename Gps to Gnss for measurement-related APIs
Bug: 26895757
Change-Id: I12d89dc251e356cf976a4bcd3589a8925a8ad745
/frameworks/base/services/core/java/com/android/server/location/GnssNavigationMessageProvider.java
|