Cross Reference: /system/connectivity/shill/mock

History log of /system/connectivity/shill/mock_manager.h
Revision	Date	Author	Comments (<<< Hide modified files) (Show modified files >>>)
e569b214bad42ec2be75ac1db2ca9b15563fdc61	15-Jan-2016	Samuel Tan <samueltan@google.com>	shill: wrap manager AP/Station mode methods in preprocessor conditionals Wrap the definitions and all callsites of Manager methods SetupApModeInterface(), SetupStationModeInterface(), and OnApModeSetterVanished() with preprocessor conditionals\ so that these methods will only be present and used in Brillo builds that do not disable WiFi. BUG: None Change-Id: I2a4bef5142bedd6fa70163ebb9ea6121e7cbff1e TEST: shill compiles and unit tests pass. /system/connectivity/shill/mock_manager.h
8a3f68edbcf7fe59380609588787baa54cbd9bdd	11-Jan-2016	Samuel Tan <samueltan@google.com>	shill: make remote service monitoring RPC-mechanism-specific Code that monitors remote RPC endpoints is RPC-mechanism-specific, so it should live in RPC-mechanism-specific source files. Move all code that creates D-Bus service watchers from Manager into ChromeosManagerDBusAdaptor, and remove expectations for service watcher creation/deletion from Manager unittests. Remove CreateRPCServiceWatcher from ControlInterface, since we leave the details of creating the RPC service watcher to the RPC adaptors. Also, create a ChromeosManagerDBusAdaptor unittest, along with the classess necessary to support these unittests (DBusServiceWatcherFactory, MockDBusServiceWatcherFactory, MockDBusServiceWatcher), to test for the creation/deletion of D-Bus service watchers that is now done in this adaptor. While there, remove an unnecssary comment from icmp_session_factory.cc. BUG: 26489902 TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=true TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=false Change-Id: I31be9ead90e0e538247401042c5b5012a924c0dd /system/connectivity/shill/mock_manager.h
91b7150819b785f36c2c094ae4aa102336bd6f71	09-Nov-2015	Peter Qiu <zqiu@google.com>	Do not claim/release blacklisted devices This prevents the device claimer from unintentionally removing blacklisted devices (specified through command line) from the blacklist. Any attempt to claim/release blacklisted devices will results in an error. Bug: 25448373 TEST=Verify p2p0 interface is not managed by shill after device setup on Brillo devices TEST=Run newly added unit tests Change-Id: I14323de2f125d92dc6207d2a4768b7dd4735b850 /system/connectivity/shill/mock_manager.h
bad1c10ffd2d4ac14f7bd9f4ef6a8982e711f566	19-Sep-2015	mukesh agrawal <quiche@google.com>	shill: remove references to GLib There are a number of references to GLib (the object), even though no one uses GLib in a substantive way. Remove these obsolete references. Bug: 23386647 TEST=unit tests Change-Id: I8d574980bc8e853c8b87ef64b581d64a71491201 /system/connectivity/shill/mock_manager.h
c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5	03-Sep-2015	Peter Qiu <zqiu@google.com>	License shill to Apache2 This patch automatically replaced the license on all text files from Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as a reference. The license header was added to .gyp and .gypi, the NOTICE was added with a copy of the Apache2 license and MODULE_LICENSE_* file was added. BUG=23587594 TEST=grep 'Chromium OS Authors' doesn't find anything. Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596 /system/connectivity/shill/mock_manager.h
9b6f8b8cdeb0c9e925fad635cc52a467c82741d0	26-Aug-2015	Peter Qiu <zqiu@google.com>	shill: emit "Devices" property change for non-primary connectivity devices This allows the remote client to get notified whenever a non-primary connectivity device (e.g. PPP device) gets added/deleted. BUG=chromium:523416 TEST=USE="asan clang dhcpv6 pppoe" FEATURES=test emerge-$BOARD shill Change-Id: Ife37ea536e7e73b81c3c7210fe12b8d109efb93d Reviewed-on: https://chromium-review.googlesource.com/295680 Commit-Ready: Zeping Qiu <zqiu@chromium.org> Tested-by: Zeping Qiu <zqiu@chromium.org> Reviewed-by: Zeping Qiu <zqiu@chromium.org> /system/connectivity/shill/mock_manager.h
1e006c610db980bca337121134d2ba54497b7a59	16-Jun-2015	Paul Stewart <pstew@chromium.org>	shill: Top-level mocks: Switch pointer/ref spacing Switch to Chrome style spacing. BUG=chromium:501026 TEST=Unit tests Change-Id: I730ed5115e62319c2745dd6cef642e228b0fb66e Reviewed-on: https://chromium-review.googlesource.com/278036 Reviewed-by: Rebecca Silberstein <silberst@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
1ce231c71932200e4d02c71567f8e93788120781	13-Jun-2015	Paul Stewart <pstew@chromium.org>	shill: Manager: Refactor command line setup In anticipation of a new and different implementation of shill::Daemon, this CL re-factors the interaction between the main() function and shill::Daemon by passing a new Daemon::Settings structure. This way the process of parsing command line parameters is separated from the task of delivering this configuration the Daemon object. While here, the "default_technology_order" field of was unified with the other parameters passed to the Manager from the Daemon. However this change is somewhat dwarfed by the technical debt that needed to be paid off in order to allow this new change to be tested. The new Daemon::ApplySettings method makes no new calls to the Manager object but none of these methods were previously mocked in the MockManager object. More troublingly the side-effects of these Manager methods were depended on in MockManager, so a few tests (notably DeviceTest) needed to be re-architected to deal with mock functionality instead of assuming the Mock object did what a real Manager would do. Lastly, both the Device::PrependDNSServers and Manager::FilterPrependDNSServersByFamily methods seemed a bit hard to understand and difficult to test. Minor changes to these APIs allowed the test changes above to work a lot smoother, and also to separate the unit tests to work on individually testing the functionality in each object. BUG=chromium:500991 TEST=Unit tests Change-Id: I04c33c841024c102ff9658e5857236ab2e5bf32f Reviewed-on: https://chromium-review.googlesource.com/278022 Reviewed-by: Garret Kelly <gdk@chromium.org> Reviewed-by: Rebecca Silberstein <silberst@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
d48fa0c5531e2102d4f537e81b9f92afc2d60955	10-Jun-2015	Peter Qiu <zqiu@chromium.org>	shill: command line support for DHCPv6 Add command line option "--dhcpv6-enabled-devices" to enable DHCPv6 for specific devices. The obtained DHCPv6 configuration is for informational purpose only, will not be used to setup connection nor update system configuration by shill. Note: since shill does not use DHCPv6 configuration to setup any connection, other IP configuration (DHCPv4 or IPv6 over RDNSS) is required in order for the device to setup a connection for a given network service. BUG=chromium:492764 TEST=USE="dhcpv6 asan clang" emerge-$BOARD shill TEST=USE="asan clang" emerge-$BOARD shill TEST=Verify with new DHCPv6 client auotest Manual Test: 1. Build/install IPv6 enabled dhcpcd and DHCPv6 enabled shill 2. Setup a virtual ethernet pair using: "ip link add name veth_master type veth peer name slave" 2. Setup a DHCPv6 server on veth_master interface "/usr/sbin/dhcpd -6 -cf /tmp/dhcp6.conf veth_master" 3. Start shill with DHCPv6 enabled for "slave" interface 4. Verify DHCPv6 configuration via "/usr/local/lib/flimflam/test/list-ipconfigs slave" Change-Id: Ic152400f61e5bb4cb02f237b97da971ed24da27f Reviewed-on: https://chromium-review.googlesource.com/276713 Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Zeping Qiu <zqiu@chromium.org> Commit-Queue: Zeping Qiu <zqiu@chromium.org> /system/connectivity/shill/mock_manager.h
208a97ed32c62bc11b0a20eaf01833482e8c0fbc	13-May-2015	Paul Stewart <pstew@chromium.org>	shill: Device: Perform validation of accepted hostname The hostname retrieved from the DHCP server may be too large. Try to be smart about truncating the hostname so that one can be successfully set. BUG=chromium:475699 TEST=New unit tests + network_DhcpRequestHostname Change-Id: Ic60c86919590f394de32a611296f9b9fbe454fb0 Reviewed-on: https://chromium-review.googlesource.com/270579 Reviewed-by: Zeping Qiu <zqiu@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
18213652e2ce4c6e4354951e5b665097b7a7aa6b	22-Apr-2015	Peter Qiu <zqiu@chromium.org>	shill: remove dependency for ProfileDBusPropertyExporter Currently, Profile.GetEntry uses ProfileDBusPropertyExporter to retrieve entry settings for a service entry that's not registered to the manager or loaded from a different profile. ProfileDBusPropertyExporter duplicates logics from Service and its subclasses for loading settings from the profile. Instead, create a temporary service for profile to load entry settings into for such service entry, and then retrieve the service settings (properties) directly. When creating a temporary service, the profile entry will be validated for fields required by the corresponding service type. Also added couple test scripts for testing purpose. BUG=chromium:208736 TEST=USE="asan clang wimax" FEATURES=test emerge-$BOARD shill Manual Test: 1. Bootup a DUT (wolf) without logging in, connect to a wifi network WiFi-A. 2. Logged in with an user account, connect to a different managed wifi network WiFi-B. 3. Invoke command "/usr/local/lib/flimflam/test/list-profiles", verify there is an entry in both default profile "/profile/default" and user profile "/profile/chronos/shill". 3. Use the get-profile-entry command to retrieve entry from both default and user profile, verify entries are retrieved successfully. "/usr/local/lib/flimflam/test/get-profile-entry default <entry_name>" "/usr/local/lib/flimflam/test/get-profile-entry shill <entry_name>" Change-Id: If6c22fbca0e4e47dd42761b047d57fff14c2e658 Reviewed-on: https://chromium-review.googlesource.com/266751 Tested-by: Zeping Qiu <zqiu@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Zeping Qiu <zqiu@chromium.org> /system/connectivity/shill/mock_manager.h
1a72f5444e077ed21b8e085b17d7f9f1bc44fa5e	15-Apr-2015	Peter Qiu <zqiu@chromium.org>	shill: compiler option support for wifi and wired 802.1x This allows shill to be compiled without wifi and wired 802.1x independently. The supplicant related code will not be compiled when both wifi and wired 802.1x compiler option are disabled. BUG=chromium:475665 TEST=USE="asan clang -wifi" FEATURES=test emerge-$BOARD shill USE="asan clang -wired_8021x" FEATURES=test emerge-$BOARD shill USE="asan clang -wifi -wired_8021x" FEATURES=test emerge-$BOARD shill USE="asan clang" FEATURES=test emerge-$BOARD shill Default shill (including both wifi and wired 802.1x): Passes wifi_matfunc test suite shill without wifi No wifi connectivity Have ethernet connectivity Passes network_8021xWiredAuthentication test shill without wired 802.1x Have wifi and ethernet connectivity Fail network_8021xWiredAuthentication test shill without both wifi and wired 802.1x No wifi connectivity Have ethernet connectivity Fail network_8021xWiredAuthentication test CQ-DEPEND=CL:265614 Change-Id: I6abaa150657f6ca0f6d5c37229fde9a2c0bb36aa Reviewed-on: https://chromium-review.googlesource.com/265774 Tested-by: Zeping Qiu <zqiu@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Zeping Qiu <zqiu@chromium.org> /system/connectivity/shill/mock_manager.h
782cdcea789d76a7ad7802cf9410b14a2399c0a9	01-Apr-2015	Garret Kelly <gdk@chromium.org>	shill: add minimum-mtu command-line parameter Add the --minimum-mtu option to shill to allow clients to override small MTU values set by DHCP servers. Any MTU value smaller than the provided one is dropped. BUG=chrome-os-partner:36886 TEST=FEATURES=test emerge-amd64-generic shill, ASAN profile Change-Id: I8e79a18f335705887568e04050712d565d53c4f0 Reviewed-on: https://chromium-review.googlesource.com/263522 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Garret Kelly <gdk@chromium.org> Tested-by: Garret Kelly <gdk@chromium.org> /system/connectivity/shill/mock_manager.h
a900f4a4b94d852e2a52a59f59ede4261d48ad80	19-Mar-2015	Peter Qiu <zqiu@chromium.org>	shill: configure preferred device for wifi services When a system has multiple wifi devices, it is desirable to allow users to be able to configure wifi services to use specific wifi device for connecting. A new wifi service configuration parameter "WiFi.PreferredDevice" is added for this purpose. With multiple wifi devices, a wifi endpoint will be created/added for each BSS detected on each wifi device. So when a wifi service tries to select an endpoint to "use", it will select the endpoint with the best signal that's associated with the preferred device if one exist, otherwise the endpoint with the best signal overall. This endpoint selection is mainly for determining the device to use to connect to that service (meaning the device on which "ConnectTo()" is performed if the service is connected), and the estimate of the signal strength when connected. wpa_supplicant is in charge for deciding which endpoint to actually connect to. There will be no side effect if the specified device is not an enabled WiFi device. BUG=chromium:467027 TEST=USE="asan clang" emerge-$BOARD shill Manual Test: 1. Grab a ath9k device (wolf), and setup one additional wifi interface with: "iw phy phy0 interface add wlan1 type managed" 2. Change the MAC address of wlan1 to be different from wlan0: "ifconfig wlan1 hw ether [MAC]" then bring up the interface using "ifconfig wlan1 up" 3. Verify shill is managing wlan1 with: "/usr/local/lib/flimflam/test/list-devices 4. Configure the service with WiFi.PreferredDevice set using: "/usr/local/lib/flimflam/test/configure-service [ssid] ..." 5. Connect to the service using: "/usr/local/lib/flimflam/test/connect-service [ssid]" 6. Verify the device is connected to the service on the specified wifi interface. CQ-DEPEND=CL:261049 Change-Id: I55838515b6f154d069ab5d02ded46e2f6148840c Reviewed-on: https://chromium-review.googlesource.com/261210 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Zeping Qiu <zqiu@chromium.org> Tested-by: Zeping Qiu <zqiu@chromium.org> /system/connectivity/shill/mock_manager.h
2d36a6e266deb96db1d3cf4b18dcc9d863795f28	19-Feb-2015	Samuel Tan <samueltan@chromium.org>	shill: check if in dark resume before launching periodic scan Check if we are in in a suspending/dark resume state (i.e. PowerManager::suspending()) before launching a periodic scan in WiFi::ScanTimerHandler. This ensures that we do not launch shill-initiated scheduled scans while in dark resume. Also add unit tests for WiFi::StartScanTimer. BUG=chromium:459821, chromium:439193 TEST=Compile shill and run unit tests. Change-Id: Ie727e068e1c48692e270b8c44662f10fb1299aaf Reviewed-on: https://chromium-review.googlesource.com/252571 Tested-by: Samuel Tan <samueltan@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Samuel Tan <samueltan@chromium.org> /system/connectivity/shill/mock_manager.h
22ce765226cfdcf267b7dc80c22892e6b29065ea	16-Oct-2014	Paul Stewart <pstew@chromium.org>	shill: Service: Move ManagerTest::SortServices to ServiceTest::Compare We have long considered the SortServices test to be misplaced. Finally move this to the Service unit tests, since after all, this is testing the Service::Compare static method. While here, mock EnableAndRetainAutoConnect() in MockService since the move of SortServices was blocking this change. BUG=chromium:206367 TEST=Unit tests Change-Id: I4ec7d5a098edfb938d1ffd0ae78116f8004646c9 Reviewed-on: https://chromium-review.googlesource.com/223615 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
8e6b8ef22e185310480c13aa3a6e89184cce62d1	15-Jul-2014	Ben Chan <benchan@chromium.org>	shill: Add 'NoAutoConnectTechnologies' manager DBus property. This CL adds a 'NoAutoConnectTechnologies' property to the manager DBus interface, which is a comma-separated list of technologies for which auto-connect is disabled. This property will be used by cellular tests to temporarily disable auto-connect for a cellular device under test. BUG=chromium:403164 CQ-DEPEND=CL:217813 TEST=Tested the following: 1. `FEATURES=test emerge-$BOARD platform2` 2. Manually test the following on a DUT: - Plug in a cellular modem over USB. - Verify that shill auto-connects the cellular service. - Unplug the modem. - Disable auto-connect on cellular via: dbus-send --system --dest=org.chromium.flimflam \ /org/chromium/flimflam \ org.chromium.flimflam.Manager.SetProperty \ string:'NoAutoConnectTechnologies' string:'cellular' - Plug in the modem again. - Verify that shill no longer auto-connects the cellular service. Change-Id: Ib09e7593695b0436c72717bc9463ce0c714185ee Reviewed-on: https://chromium-review.googlesource.com/217825 Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> /system/connectivity/shill/mock_manager.h
cc67c52a2c00f90e877971d552208dd99825d84e	03-Sep-2014	Ben Chan <benchan@chromium.org>	shill: Include base/macros.h instead of base/basictypes.h shill no longer uses the integer types from base/basictypes.h. It should simply include base/macros.h for the DISALLOW_COPY_AND_ASSIGN macro instead. BUG=None TEST=`USE='cellular wimax' FEATURES=test emerge-$BOARD platform2` Change-Id: I9b350c1bd9eff88e2c87de2ef8d607e90049e102 Reviewed-on: https://chromium-review.googlesource.com/216055 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> /system/connectivity/shill/mock_manager.h
5ea763b83299b5fad76a87183fb39a74c2d3c61d	13-Aug-2014	Ben Chan <benchan@chromium.org>	shill: Add C++11 override specifier to destructors of derived classes. BUG=None TEST=`USE=wimax FEATURES=test emerge-$BOARD platform2` Change-Id: I88d4e29165869b26924cccb94ac940dc8961c312 Reviewed-on: https://chromium-review.googlesource.com/212267 Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> /system/connectivity/shill/mock_manager.h
700de6400c18f8cba77821f8cd2a1935b96999a6	15-Jul-2014	Peter Qiu <zqiu@chromium.org>	shill: Reporting of device's connection status Report device's connection status to UMA stats periodically. Possible status are offline (not connected to an AP), connected (connected to an AP), and online (connected to an AP with internet connectivity). When the device is in online state, it will report both connected and online to UMA stats. This data will allow us to determine the percentage of time when the device have internet connectivity, also the percentage of time when the device is connected to an AP but without internet connectivity. While at it, update the old IsOnline function in manager.cc to IsConnected to be more semantically correct, since that function return true if there is a service that's in connected or above state. And Add a new IsOnline function which will return true only if there is a service that's in online state. BUG=chromium:392990 TEST=unit tests, manual Manual Test: 1. Boot up a chrome device without any network connectivity. 2. Wait for 3 minutes, and browse to "chrome://histograms", veriyf there is a histogram for "Network.Shill.DeviceConnectionStatus" with a hit for bucket 0 (offline). 3. Connect the chrome device to an AP without internet connectivity. 4. Wait for 3 minutes, and browse to "chrome://histograms", verify there is a hit for bucket 1 (connected) for histogram "Network.Shill.DeviceConnectionStatus". 5. Connect the chrome device to an AP with internet connectivity. 6. Wait for 3 minutes, and browse to "chrome://histograms", verify there sia hit for bucket 1 (connected) and 2 (online) for histogram "Network.Shill.DeviceConnectionStatus". Change-Id: I1a949b17398214d745ca1d5a37e35202e087181a Reviewed-on: https://chromium-review.googlesource.com/207960 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Tested-by: Peter Qiu <zqiu@chromium.org> /system/connectivity/shill/mock_manager.h
8a5322984f2d81bcbfd8d44c59747a11bd9b904b	17-Jun-2014	Alex Vakulenko <avakulenko@chromium.org>	shill: Fix most of warnings from cpplint Fix most cpplinter's warnings. On a few occasisions, the warnings produced were false-positives, so added explicit // NOLINT comment overrides. There were a few instances of disallowed non-const reference usage (reported as runtime/reference error by cpplint) for "DBus::Error &error" which should potentially be changed to pointers to comply with C++ coding style but I will let Shill owners do that since there is quite a few of those and the change isn't brain-dead simple... BUG=None TEST=platform2 still compiles and all unit tests pass. Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e Reviewed-on: https://chromium-review.googlesource.com/204164 Tested-by: Alex Vakulenko <avakulenko@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org> /system/connectivity/shill/mock_manager.h
d4f26486b237fae831d4b682481de785fc99c66e	26-Apr-2014	Paul Stewart <pstew@chromium.org>	shill: Device: Report IPv6 address Have the Device query DeviceInfo for the primary IPv6 address every time DeviceInfo notifies it of a change. Use the output of this to add another IPConfig object to the list reported if this address exists. While here, emit a property change event from the "IPConfigs" property if either the IPv4 or IPv6 ipconfigs change. BUG=chromium:365883 TEST=Unit tests, upcoming change to network_Ipv6SimpleNegotiation (CL:197394). Manual: list-ipconfigs while connected to a network that supplies IPv6 global prefixes. Change-Id: I28771acd3e990a9bea7f5988cc382a5cd9e91f1f Reviewed-on: https://chromium-review.googlesource.com/197304 Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
7de7e02e14074989757a4f9f220de2310cc05236	28-Aug-2013	Paul Stewart <pstew@chromium.org>	shill: Manager: Cache Geolocation Info Instead of polling devices for their current scan information when Manager::GetNetworksForGeolocation() is called, instead have devices notify the Manager when they have new (and complete) geolocation information to share. At this point in time the Manager caches this information in a per-technology map which it will return to callers asking for geolocation information. As a result, callers receive the most complete information from the last scan. The task of ensuring that this geolocation information is maintained at a desired "freshness" is left as a separate exercise. BUG=chromium:236418,chromium:217247 TEST=Unit tests; connect to AP and allow scan cache to expire ("list-services" only shows connected AP), call manager.GetNetworksForGeolocation() and ensure the data from the most recent scan is still available. Change-Id: I67316656168173ad3ed6c19a3368c9f75b7322f3 Reviewed-on: https://chromium-review.googlesource.com/167310 Reviewed-by: Wade Guthrie <wdg@chromium.org> Reviewed-by: Gaurav Shah <gauravsh@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
ad0e598399c224cfed6fc90464d3022fa8c067ef	02-Jul-2013	Paul Stewart <pstew@chromium.org>	shill: Service: Implement "SetProperties" DBus call Configure multiple Service properties at once in a single call. This method differs from Manager::ConfigureService in two important ways: Firstly, since this is a service method, the service is found via its RPC identifier as opposed to its GUID or other properties. Secondly, only the service properties are set -- it is not assigned a profile like ConfigureService -- in fact the "Profile" property is silently ignored if provided to this call. BUG=None TEST=Unit tests Change-Id: Ied4b75184bc4c27d88652dc14d14ef3f49b1574e Reviewed-on: https://gerrit.chromium.org/gerrit/60775 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
35eff134fd95fdf1918803c4966f8b790914b3d4	12-Apr-2013	Paul Stewart <pstew@chromium.org>	shill: Ethernet: Create shared credentials provider Share a single service instance for all Ethernet devices to use for EAP credentials. This service instance is only used for EAP authentication, so other parameters such as Static IP paramters are still retrieved from the per-device Ethernet service. Provide a method for all Ethernet devices connected to an EAP authenticator to be notified when the EAP credentials for this shared service have been changed. Use both facilities in the Ethernet device. CQ-DEPEND=CL:48162 BUG=chromium:227433 TEST=New unit tests; revised version of network_8021xWiredAuthentication (see co-dependent CL) Change-Id: I5b19723dddfa2d793090128adb6429f31174b276 Reviewed-on: https://gerrit.chromium.org/gerrit/48138 Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
60a3706bee5686ae2322a774b9e7d5e8e63fcaf7	02-Apr-2013	Wade Guthrie <wdg@chromium.org>	shill: Keeps track of successful wifi connection frequencies. Saves the connection frequencies (and counts therefor) in the default profile. Sends number of frequencies on which successful connections have been made to an UMA stat. BUG=chromium:222081 TEST=unittests and manual (look for UMA stat 'Network.Shill.Wifi.FrequenciesConnectedEver', disconnect from wifi, reconnect, verify that the UMA stat went up by 1). Change-Id: I1e3c75b82ac387dd01066c4da4ebfce2c4b2ddc0 Reviewed-on: https://gerrit.chromium.org/gerrit/47154 Commit-Queue: Wade Guthrie <wdg@chromium.org> Reviewed-by: Wade Guthrie <wdg@chromium.org> Tested-by: Wade Guthrie <wdg@chromium.org> /system/connectivity/shill/mock_manager.h
68d4109ff0176f7e5a9b67b916478d638aac577a	02-Apr-2013	Wade Guthrie <wdg@chromium.org>	shill: Adds UMA metric for scan time for certain scans. Future code will perform a different type of scan (called "progressive scan") for resume from disconnect, resume from suspend, and boot up. This CL differentiates between those cases and the traditional, full, scan in the code and adds a time-to-scan UMA metric for progressive scan. BUG=chromium:222096 TEST=unittest and manual (cycle power on the chromebook and notice on chrome://histograms that Network.Shill.Wifi.TimeToScan got a new entry). Change-Id: I450602c4b0a418c2b9322edeceec970c79de1330 Reviewed-on: https://gerrit.chromium.org/gerrit/47562 Commit-Queue: Wade Guthrie <wdg@chromium.org> Reviewed-by: Wade Guthrie <wdg@chromium.org> Tested-by: Wade Guthrie <wdg@chromium.org> /system/connectivity/shill/mock_manager.h
c3505a569e3f98ce56e4017300a3ce46bc714e4c	18-Mar-2013	Darin Petkov <petkov@chromium.org>	shill: vpn: Conditionally build VPN support into shill. VPN is disabled if SHILL_VPN=0 is passed to the Makefile. BUG=chromium-os:39329 TEST=Together with I9e4d5741cbdcd99c9c109259167d87dbff04ee7a: - FEATURES=test emerge-lumpy shill; - After unmerging dependencies, FEATURES=test USE=-vpn emerge-lumpy shill - Connected to OpenVPN successfully with default USE flags. - Tested connectivity with shill with no VPN support. Change-Id: I480a5911a4310ff9f80ca312db2a1bc3fe67bbd1 Reviewed-on: https://gerrit.chromium.org/gerrit/45740 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Darin Petkov <petkov@chromium.org> Tested-by: Darin Petkov <petkov@chromium.org> /system/connectivity/shill/mock_manager.h
0e1cdeae24dd678a5fe27c840802582c0ca45ec0	28-Feb-2013	Albert Chaulk <achaulk@chromium.org>	shill: Implement Service.Remove & delete DHCP leases Implement the Service.Remove dbus API and modify the unload sequence to remove the DHCP lease file. Add unit tests to DHCPProvider & WiFiService to check lease file deletion. Currently only WiFi does the DHCP lease delete from DBus - WiMax/Cell/VPN do their own things for IP configuration and Ethernet can't be removed as per the API spec. Also make sure FilePath is qualified as base::FilePath throughout the project. BUG=chromium-os:32756 TEST=added unittests to test the call path on Unload() to delete the lease file Change-Id: Ic6eee17b9d81cd0be8d09c683d85d6a4d19278c9 Reviewed-on: https://gerrit.chromium.org/gerrit/44339 Tested-by: Albert Chaulk <achaulk@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> /system/connectivity/shill/mock_manager.h
3c5040174273386868cc8dea8044d22c465885d8	18-Jan-2013	Paul Stewart <pstew@chromium.org>	shill: WiFiProvider: Move Service vector to WiFiProvider Remove the services_ vector from the WiFi Device and move it to the WiFiProvider. Also remove the WiFi device initializer from the WiFiService, so it doesn't have an early or permanent binding to a particular device. This allows WiFi services to be loaded immediately as a profile loads, so that operations that operate on services (like Manager::ConfigureService and Manager::FindMatchingService) do not need to use a separate API to find and modify services that are not visible but have stored configuration associated with them. This also allows Chrome a somewhat more stabilized service path to remembered services as they appear and disappear from view. Another advantage is that this completely regularizes the relationship between the presence of the service in the provider's services_ list and its registration with the manager. In order to perform late-binding to a WiFi device, we provide two methods for WiFi services to find a device to call WiFi::ConnectTo on when the time comes: Firstly, visible WiFi services (ones with endpoints) can select the device associated with the most "promising" endpoint. In the case where we try to connect to a hidden WiFi service before endpoints appear for it, there is a new method for selecting a WiFi device from the Manager. In both of these cases only one WiFi device is selected for the connect request, so this method is no worse than before in the unlikely case where there are two WiFi devices, except for the fact that now there won't be duplicate WiFi services registered in the Manager. CQ-DEPEND=Ic8af4999b25503c3b002504edd12405dc91cc824 BUG=chromium-os:38017 TEST=Unit tests; manual operation; manager unit tests, WiFiManager autotests (profile tests failing due to crosbug.com/35374) Change-Id: I904df8a983ba6e7e76e20159622c652675eb6a7d Reviewed-on: https://gerrit.chromium.org/gerrit/41664 Commit-Queue: Paul Stewart <pstew@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
6c1e3bbca64d642cb30ed9952203626942bc1451	07-Feb-2013	Thieu Le <thieule@chromium.org>	shill: cellular: Add Network.Shill.Cellular.DropsPerHour. BUG=chromium-os:38557 TEST=Unit tests, manually lose LTE signal and check chrome://histograms Change-Id: I82aa1edabd21c5dfde4834cd36a34a12b629ba8f Reviewed-on: https://gerrit.chromium.org/gerrit/42813 Reviewed-by: Arman Uguray <armansito@chromium.org> Commit-Queue: Thieu Le <thieule@chromium.org> Tested-by: Thieu Le <thieule@chromium.org> /system/connectivity/shill/mock_manager.h
4cbff5b5897593f7a2e6de48a98abe72356075af	29-Jan-2013	Darin Petkov <petkov@chromium.org>	shill: vpn: Auto-connect at most one service at a time, only when online. This patch suppresses auto-connect for non-primary technologies (such as VPN) while the system is offline. Also, don't auto-connect a VPN service if there's already an active (connecting or connected) VPN service. Cleanup Manager's online/offline API a bit. BUG=chromium-os:38229 TEST=unit tests Change-Id: Iedd3879cf45c8b509a956415c7de5e5ba1af4652 Reviewed-on: https://gerrit.chromium.org/gerrit/42226 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Darin Petkov <petkov@chromium.org> /system/connectivity/shill/mock_manager.h
85aea151c69ff40967becfa8751d821feebf3bb9	22-Jan-2013	Paul Stewart <pstew@chromium.org>	shill: WiFiService: Fix-up old-style WiFi Service entries Add a utility to upgrade WiFi service entries that don't contain the "Type", "Mode" or "Security" properties, and only contain this information in the fields of the storage identifier. Use this utility whenever the WiFi device loads a new profile. Follow-on CLs will clean up all remaining direct callers of WiFiServce::ParseStorageIdentifier(). BUG=chromium-os:38048 TEST=Unit Tests, inspect chrome://histograms for new histogram entries when profiles are updated. Change-Id: I0f1d4e75abc1edfe6da1bbfe68183cab1b1c0021 Reviewed-on: https://gerrit.chromium.org/gerrit/41802 Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
87a4ae88915e3dc22dbb1327002e1daf769ef23e	27-Oct-2012	Paul Stewart <pstew@chromium.org>	shill: WiFi: Reload hidden services after restart Hidden services in WiFi are loaded in two situations: (1) When the WiFi Device is registered, WiFi::Load() is called each profile. (2) When a profile is pushed, WiFi::Load() is called with the new profile. When WiFi::Stop() is called, all services are removed, so some mechanism needs to be used to reload these hidden services when WiFi::Start() is called. BUG=chromium-os:35703 TEST=Unit tests + manual: Disable / Re-Enable WiFi and make sure remembered hidden networks are still visible. Change-Id: Ie6b9351db940860cb20c39e0575c3d5dd8c921d0 Reviewed-on: https://gerrit.chromium.org/gerrit/36736 Reviewed-by: Christopher Wiley <wiley@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Ready: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
036dba0c6641acdbe02d52260c6fa6dca84b1af2	07-Aug-2012	Paul Stewart <pstew@chromium.org>	shill: Device: Add LinkMonitor Start link monitoring for technologies for which it is enabled. Add facilities in the manager and default profile to determine and persist a list of technologies for which link monitoring is enabled. Provide a means for the Device to report the current rolling average LinkMonitor response time. BUG=chromium-os:32600 TEST=Unit tests Change-Id: I39dcc8ce2332d7be3c95d9953b4ae7d7172d7df1 Reviewed-on: https://gerrit.chromium.org/gerrit/29731 Commit-Ready: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
a5e07ef0402aad0635a5e7a0932740b9dfbf46d1	09-Jul-2012	Darin Petkov <petkov@chromium.org>	shill: openvpn: Hold connect/reconnect until a new service is online. Use OpenVPN's management hold API to prevent the client from connecting/reconnecting until an underlying connection becomes available. The hold is released only when a new default service is connected. This ensures, for example, that the openvpn client will not use stale network configuration on reconnect. Also, add API to Manager to register and deregister callbacks to monitor for default service changes. BUG=chromium-os:31572 TEST=unit tests, tested on device with inactivity restart/reconnect Change-Id: I6d6d63a03ee92aaa18b7a2cca9462a8ea1e5a931 Reviewed-on: https://gerrit.chromium.org/gerrit/26920 Commit-Ready: Darin Petkov <petkov@chromium.org> Reviewed-by: Darin Petkov <petkov@chromium.org> Tested-by: Darin Petkov <petkov@chromium.org> /system/connectivity/shill/mock_manager.h
e7c6ad35cafed32a0fd1390487c74e66eae1961d	29-Jun-2012	Darin Petkov <petkov@chromium.org>	shill: Add Profile and Manager UpdateDevice support. UpdateDevice persists Devices into profiles. It's similar to UpdateService, however, only the topmost DefaultProfile handles UpdateDevice. Use UpdateDevice to persist Device's Enabled and Cellular's AllowRoaming properties. Remove now unused Manager::SaveActiveProfile method to avoid confusion. BUG=chrome-os-partner:10178,chromium-os:32230 TEST=unit tests Change-Id: I1d293fa84e0bce3156943e8e9d313fc98facbde1 Reviewed-on: https://gerrit.chromium.org/gerrit/26405 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Ready: Ben Chan <benchan@chromium.org> /system/connectivity/shill/mock_manager.h
e4b270274cba2a1976c7be6c733bd899e009c1d1	16-May-2012	Darin Petkov <petkov@chromium.org>	shill: Complete interaction between DeviceInfo and WiMaxProvider. WiMaxProvider now creates/registers and destroys/deregisters devices based on DeviceInfo and RPC callbacks. Also, add missing DeviceInfo WiMax unit tests, and implement WiMaxService's GetDeviceRpcIdentifier and GetStorageIdentifier. BUG=chrome-os-partner:9735 TEST=unit tests Change-Id: I9dbf8f785ef824ca5628b96a2e22ec0ef6336b97 Reviewed-on: https://gerrit.chromium.org/gerrit/22807 Commit-Ready: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Darin Petkov <petkov@chromium.org> /system/connectivity/shill/mock_manager.h
8c116a90d3a3536430b808b15e73275060918434	03-May-2012	Paul Stewart <pstew@chromium.org>	shill: device_info: Revamp address/route flushing The route flushing for devices ended up floating around in the device code with a number of changes and lodged itself in a place where it might not even be called in some situations. The address flush code was only being called on connection close, and only applied to addresses that were active before the system started up. Implemented the following fixes: - Move FlushRoutes out of Device to the initialization code in DeviceInfo. - Add Address flushing code in the same place. - Capture the list of IP addresses per-interface earlier at startup so they can be flushed at device discovery. This involved re-ordering the RTNL "Dump" path to dump addresses before links, and adding code in DeviceInfo to capture these addresses in its Info structures before the actual link was discovered. This way, when the link is discovered, it's possible to flush the old addresses. - Use the NLM_ECHO flag when creating and deleting IP addresses in RTNL, so RTNL events are generated even for operations that originate from shill, and the tables are better kept up to date, so when Connections flush IP addresses on disconnect, this properly includes those that were created locally. - Break apart DeviceInfo::AddLinkMsgHandler so it can be tested. BUG=chromium-os:30358 TEST=New unit tests + plug/unplug between different networks / kill/restart shill. Change-Id: Ie1a38e0e86ba3a52aaaaf9c3f0e0dfcb3c8fc276 Reviewed-on: https://gerrit.chromium.org/gerrit/21719 Commit-Ready: Paul Stewart <pstew@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h
10ccbb3c6bc4f4246105743c8508fc9ce8759c17	27-Apr-2012	Paul Stewart <pstew@chromium.org>	shill: wifi: Scan for non-ephemeral hidden networks Before, shill used the "favorite()" property to tell whether it should scan for a hidden SSID. Instead, use a more direct approach of asking whether the service is part of a non-ephemeral profile. This allows services configured via Manager::ConfigureService() for which the "favorite" flag has not been set to be scanned for and listed for the user to select. BUG=chromium-os:26676 TEST=New unit tests, manual -- configure a hidden network via configure-hidden-wifi, then propose a scan via "test-flimflam scan", while running "iw event" to confirm whether the new SSID appears in the scan list Change-Id: I75364c83c94482c0c3d654e2076a4bed06a7fca2 Reviewed-on: https://gerrit.chromium.org/gerrit/21288 Commit-Ready: Paul Stewart <pstew@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/mock_manager.h