dex_file_verifier.cc revision acc2bb693d83102f93007d7c4881a94bbcc3b9bb
12faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes/* 22faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * Copyright (C) 2011 The Android Open Source Project 32faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * 42faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * Licensed under the Apache License, Version 2.0 (the "License"); 52faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * you may not use this file except in compliance with the License. 62faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * You may obtain a copy of the License at 72faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * 82faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * http://www.apache.org/licenses/LICENSE-2.0 92faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * 102faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * Unless required by applicable law or agreed to in writing, software 112faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * distributed under the License is distributed on an "AS IS" BASIS, 122faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 132faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * See the License for the specific language governing permissions and 142faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes * limitations under the License. 152faa5f1271587cda765f26bcf2951065300a01ffElliott Hughes */ 1610037c866b04550fc5461058c398c2e3e509381ajeffhao 1710037c866b04550fc5461058c398c2e3e509381ajeffhao#include "dex_file_verifier.h" 1810037c866b04550fc5461058c398c2e3e509381ajeffhao 1992572be7f754c213e615a62955cc5f65ca8c0c0eNarayan Kamath#include <zlib.h> 20700a402244a1a423da4f3ba8032459f4b65fa18fIan Rogers#include <memory> 2192572be7f754c213e615a62955cc5f65ca8c0c0eNarayan Kamath 22e222ee0b794f941af4fb1b32fb8224e32942ea7bElliott Hughes#include "base/stringprintf.h" 234f6ad8ab428038129b2d0d6c40b7fd625cca15e1Ian Rogers#include "dex_file-inl.h" 2410037c866b04550fc5461058c398c2e3e509381ajeffhao#include "leb128.h" 25a0e180632411f7fe0edf454e571c42209ee7b540Elliott Hughes#include "safe_map.h" 26a67249065e4c9b3cf4a7c081d95a78df28291ee9Ian Rogers#include "utf-inl.h" 272dd0e2cea360bc9206eb88ecc40d259e796c239dIan Rogers#include "utils.h" 2810037c866b04550fc5461058c398c2e3e509381ajeffhao 2910037c866b04550fc5461058c398c2e3e509381ajeffhaonamespace art { 3010037c866b04550fc5461058c398c2e3e509381ajeffhao 3110037c866b04550fc5461058c398c2e3e509381ajeffhaostatic uint32_t MapTypeToBitMask(uint32_t map_type) { 3210037c866b04550fc5461058c398c2e3e509381ajeffhao switch (map_type) { 3310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeHeaderItem: return 1 << 0; 3410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringIdItem: return 1 << 1; 3510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeIdItem: return 1 << 2; 3610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeProtoIdItem: return 1 << 3; 3710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeFieldIdItem: return 1 << 4; 3810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMethodIdItem: return 1 << 5; 3910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDefItem: return 1 << 6; 4010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMapList: return 1 << 7; 4110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeList: return 1 << 8; 4210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetRefList: return 1 << 9; 4310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetItem: return 1 << 10; 4410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDataItem: return 1 << 11; 4510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeCodeItem: return 1 << 12; 4610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringDataItem: return 1 << 13; 4710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeDebugInfoItem: return 1 << 14; 4810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationItem: return 1 << 15; 4910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeEncodedArrayItem: return 1 << 16; 5010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationsDirectoryItem: return 1 << 17; 5110037c866b04550fc5461058c398c2e3e509381ajeffhao } 5210037c866b04550fc5461058c398c2e3e509381ajeffhao return 0; 5310037c866b04550fc5461058c398c2e3e509381ajeffhao} 5410037c866b04550fc5461058c398c2e3e509381ajeffhao 5510037c866b04550fc5461058c398c2e3e509381ajeffhaostatic bool IsDataSectionType(uint32_t map_type) { 5610037c866b04550fc5461058c398c2e3e509381ajeffhao switch (map_type) { 5710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeHeaderItem: 5810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringIdItem: 5910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeIdItem: 6010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeProtoIdItem: 6110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeFieldIdItem: 6210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMethodIdItem: 6310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDefItem: 6410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 6510037c866b04550fc5461058c398c2e3e509381ajeffhao } 6610037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 6710037c866b04550fc5461058c398c2e3e509381ajeffhao} 6810037c866b04550fc5461058c398c2e3e509381ajeffhao 69e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampeconst char* DexFileVerifier::CheckLoadStringByIdx(uint32_t idx, const char* error_string) { 70df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(!CheckIndex(idx, dex_file_->NumStringIds(), error_string))) { 71e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return nullptr; 72e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 73e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return dex_file_->StringDataByIdx(idx); 74e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe} 75e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 76e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampeconst char* DexFileVerifier::CheckLoadStringByTypeIdx(uint32_t type_idx, const char* error_string) { 77df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(!CheckIndex(type_idx, dex_file_->NumTypeIds(), error_string))) { 78e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return nullptr; 79e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 80e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe const DexFile::TypeId& type_id = dex_file_->GetTypeId(type_idx); 81e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe uint32_t idx = type_id.descriptor_idx_; 82e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return CheckLoadStringByIdx(idx, error_string); 83e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe} 84e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 85e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampeconst DexFile::FieldId* DexFileVerifier::CheckLoadFieldId(uint32_t idx, const char* error_string) { 86df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(!CheckIndex(idx, dex_file_->NumFieldIds(), error_string))) { 87e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return nullptr; 88e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 89e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return &dex_file_->GetFieldId(idx); 90e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe} 91e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 92e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampeconst DexFile::MethodId* DexFileVerifier::CheckLoadMethodId(uint32_t idx, const char* err_string) { 93df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(!CheckIndex(idx, dex_file_->NumMethodIds(), err_string))) { 94e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return nullptr; 95e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 96e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return &dex_file_->GetMethodId(idx); 97e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe} 98e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 99e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe// Helper macro to load string and return false on error. 100e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe#define LOAD_STRING(var, idx, error) \ 101e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe const char* var = CheckLoadStringByIdx(idx, error); \ 102df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(var == nullptr)) { \ 103e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return false; \ 104e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 105e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 106e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe// Helper macro to load string by type idx and return false on error. 107e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe#define LOAD_STRING_BY_TYPE(var, type_idx, error) \ 108e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe const char* var = CheckLoadStringByTypeIdx(type_idx, error); \ 109df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(var == nullptr)) { \ 110e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return false; \ 111e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 112e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 113e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe// Helper macro to load method id. Return last parameter on error. 1145e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe#define LOAD_METHOD(var, idx, error_string, error_stmt) \ 115e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe const DexFile::MethodId* var = CheckLoadMethodId(idx, error_string); \ 116df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(var == nullptr)) { \ 1175e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe error_stmt; \ 118e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 119e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 120e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe// Helper macro to load method id. Return last parameter on error. 1215e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe#define LOAD_FIELD(var, idx, fmt, error_stmt) \ 122e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe const DexFile::FieldId* var = CheckLoadFieldId(idx, fmt); \ 123df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(var == nullptr)) { \ 1245e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe error_stmt; \ 125e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 126e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 1278d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogersbool DexFileVerifier::Verify(const DexFile* dex_file, const byte* begin, size_t size, 1288d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers const char* location, std::string* error_msg) { 129700a402244a1a423da4f3ba8032459f4b65fa18fIan Rogers std::unique_ptr<DexFileVerifier> verifier(new DexFileVerifier(dex_file, begin, size, location)); 1308d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (!verifier->Verify()) { 1318d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers *error_msg = verifier->FailureReason(); 1328d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers return false; 1338d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers } 1348d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers return true; 1358d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers} 1368d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers 1378d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogersbool DexFileVerifier::CheckShortyDescriptorMatch(char shorty_char, const char* descriptor, 1388d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers bool is_return_type) { 13910037c866b04550fc5461058c398c2e3e509381ajeffhao switch (shorty_char) { 14010037c866b04550fc5461058c398c2e3e509381ajeffhao case 'V': 1418d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(!is_return_type)) { 1428d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid use of void"); 14310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 14410037c866b04550fc5461058c398c2e3e509381ajeffhao } 14510037c866b04550fc5461058c398c2e3e509381ajeffhao // Intentional fallthrough. 14610037c866b04550fc5461058c398c2e3e509381ajeffhao case 'B': 14710037c866b04550fc5461058c398c2e3e509381ajeffhao case 'C': 14810037c866b04550fc5461058c398c2e3e509381ajeffhao case 'D': 14910037c866b04550fc5461058c398c2e3e509381ajeffhao case 'F': 15010037c866b04550fc5461058c398c2e3e509381ajeffhao case 'I': 15110037c866b04550fc5461058c398c2e3e509381ajeffhao case 'J': 15210037c866b04550fc5461058c398c2e3e509381ajeffhao case 'S': 15310037c866b04550fc5461058c398c2e3e509381ajeffhao case 'Z': 1548d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((descriptor[0] != shorty_char) || (descriptor[1] != '\0'))) { 1558d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Shorty vs. primitive type mismatch: '%c', '%s'", 1568d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers shorty_char, descriptor); 15710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 15810037c866b04550fc5461058c398c2e3e509381ajeffhao } 15910037c866b04550fc5461058c398c2e3e509381ajeffhao break; 16010037c866b04550fc5461058c398c2e3e509381ajeffhao case 'L': 1618d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((descriptor[0] != 'L') && (descriptor[0] != '['))) { 1628d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Shorty vs. type mismatch: '%c', '%s'", shorty_char, descriptor); 16310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 16410037c866b04550fc5461058c398c2e3e509381ajeffhao } 16510037c866b04550fc5461058c398c2e3e509381ajeffhao break; 16610037c866b04550fc5461058c398c2e3e509381ajeffhao default: 1678d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad shorty character: '%c'", shorty_char); 16810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 16910037c866b04550fc5461058c398c2e3e509381ajeffhao } 17010037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 17110037c866b04550fc5461058c398c2e3e509381ajeffhao} 17210037c866b04550fc5461058c398c2e3e509381ajeffhao 1738d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogersbool DexFileVerifier::CheckPointerRange(const void* start, const void* end, const char* label) { 1748a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers const byte* range_start = reinterpret_cast<const byte*>(start); 1758a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers const byte* range_end = reinterpret_cast<const byte*>(end); 1768a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers const byte* file_start = reinterpret_cast<const byte*>(begin_); 1778a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers const byte* file_end = file_start + size_; 1788d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((range_start < file_start) || (range_start > file_end) || 1798d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers (range_end < file_start) || (range_end > file_end))) { 1808a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers ErrorStringPrintf("Bad range for %s: %zx to %zx", label, 181e3d5581266301e6a672af6233220037abf52fea1Ian Rogers static_cast<size_t>(range_start - file_start), 182e3d5581266301e6a672af6233220037abf52fea1Ian Rogers static_cast<size_t>(range_end - file_start)); 18310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 18410037c866b04550fc5461058c398c2e3e509381ajeffhao } 18510037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 18610037c866b04550fc5461058c398c2e3e509381ajeffhao} 18710037c866b04550fc5461058c398c2e3e509381ajeffhao 18810037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckListSize(const void* start, uint32_t count, 1898d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers uint32_t element_size, const char* label) { 19010037c866b04550fc5461058c398c2e3e509381ajeffhao const byte* list_start = reinterpret_cast<const byte*>(start); 19110037c866b04550fc5461058c398c2e3e509381ajeffhao return CheckPointerRange(list_start, list_start + (count * element_size), label); 19210037c866b04550fc5461058c398c2e3e509381ajeffhao} 19310037c866b04550fc5461058c398c2e3e509381ajeffhao 1948d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogersbool DexFileVerifier::CheckIndex(uint32_t field, uint32_t limit, const char* label) { 1958d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(field >= limit)) { 1968d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad index for %s: %x >= %x", label, field, limit); 19710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 19810037c866b04550fc5461058c398c2e3e509381ajeffhao } 19910037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 20010037c866b04550fc5461058c398c2e3e509381ajeffhao} 20110037c866b04550fc5461058c398c2e3e509381ajeffhao 2028d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogersbool DexFileVerifier::CheckHeader() { 203f6174e8a1566bb357e82506f7ec97dc359c90eb2jeffhao // Check file size from the header. 204f6174e8a1566bb357e82506f7ec97dc359c90eb2jeffhao uint32_t expected_size = header_->file_size_; 205f6174e8a1566bb357e82506f7ec97dc359c90eb2jeffhao if (size_ != expected_size) { 2068d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad file size (%zd, expected %ud)", size_, expected_size); 20710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 20810037c866b04550fc5461058c398c2e3e509381ajeffhao } 20910037c866b04550fc5461058c398c2e3e509381ajeffhao 21010037c866b04550fc5461058c398c2e3e509381ajeffhao // Compute and verify the checksum in the header. 21110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t adler_checksum = adler32(0L, Z_NULL, 0); 21210037c866b04550fc5461058c398c2e3e509381ajeffhao const uint32_t non_sum = sizeof(header_->magic_) + sizeof(header_->checksum_); 21310037c866b04550fc5461058c398c2e3e509381ajeffhao const byte* non_sum_ptr = reinterpret_cast<const byte*>(header_) + non_sum; 214f6174e8a1566bb357e82506f7ec97dc359c90eb2jeffhao adler_checksum = adler32(adler_checksum, non_sum_ptr, expected_size - non_sum); 21510037c866b04550fc5461058c398c2e3e509381ajeffhao if (adler_checksum != header_->checksum_) { 2168d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad checksum (%08x, expected %08x)", adler_checksum, header_->checksum_); 21710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 21810037c866b04550fc5461058c398c2e3e509381ajeffhao } 21910037c866b04550fc5461058c398c2e3e509381ajeffhao 22010037c866b04550fc5461058c398c2e3e509381ajeffhao // Check the contents of the header. 22110037c866b04550fc5461058c398c2e3e509381ajeffhao if (header_->endian_tag_ != DexFile::kDexEndianConstant) { 2228d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Unexpected endian_tag: %x", header_->endian_tag_); 22310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 22410037c866b04550fc5461058c398c2e3e509381ajeffhao } 22510037c866b04550fc5461058c398c2e3e509381ajeffhao 22610037c866b04550fc5461058c398c2e3e509381ajeffhao if (header_->header_size_ != sizeof(DexFile::Header)) { 2278d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad header size: %ud", header_->header_size_); 22810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 22910037c866b04550fc5461058c398c2e3e509381ajeffhao } 23010037c866b04550fc5461058c398c2e3e509381ajeffhao 23110037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 23210037c866b04550fc5461058c398c2e3e509381ajeffhao} 23310037c866b04550fc5461058c398c2e3e509381ajeffhao 2348d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogersbool DexFileVerifier::CheckMap() { 23530fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers const DexFile::MapList* map = reinterpret_cast<const DexFile::MapList*>(begin_ + header_->map_off_); 23610037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::MapItem* item = map->list_; 23710037c866b04550fc5461058c398c2e3e509381ajeffhao 23810037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t count = map->size_; 23910037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t last_offset = 0; 24010037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t data_item_count = 0; 24110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t data_items_left = header_->data_size_; 24210037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t used_bits = 0; 24310037c866b04550fc5461058c398c2e3e509381ajeffhao 24410037c866b04550fc5461058c398c2e3e509381ajeffhao // Sanity check the size of the map list. 24510037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckListSize(item, count, sizeof(DexFile::MapItem), "map size")) { 24610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 24710037c866b04550fc5461058c398c2e3e509381ajeffhao } 24810037c866b04550fc5461058c398c2e3e509381ajeffhao 24910037c866b04550fc5461058c398c2e3e509381ajeffhao // Check the items listed in the map. 25010037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < count; i++) { 2518d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(last_offset >= item->offset_ && i != 0)) { 2528d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out of order map item: %x then %x", last_offset, item->offset_); 25310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 25410037c866b04550fc5461058c398c2e3e509381ajeffhao } 2558d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(item->offset_ >= header_->file_size_)) { 2568d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map item after end of file: %x, size %x", 2578d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers item->offset_, header_->file_size_); 25810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 25910037c866b04550fc5461058c398c2e3e509381ajeffhao } 26010037c866b04550fc5461058c398c2e3e509381ajeffhao 26110037c866b04550fc5461058c398c2e3e509381ajeffhao if (IsDataSectionType(item->type_)) { 26210037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t icount = item->size_; 2638d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(icount > data_items_left)) { 2648d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Too many items in data section: %ud", data_item_count + icount); 26510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 26610037c866b04550fc5461058c398c2e3e509381ajeffhao } 26710037c866b04550fc5461058c398c2e3e509381ajeffhao data_items_left -= icount; 26810037c866b04550fc5461058c398c2e3e509381ajeffhao data_item_count += icount; 26910037c866b04550fc5461058c398c2e3e509381ajeffhao } 27010037c866b04550fc5461058c398c2e3e509381ajeffhao 27110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t bit = MapTypeToBitMask(item->type_); 27210037c866b04550fc5461058c398c2e3e509381ajeffhao 2738d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(bit == 0)) { 2748d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Unknown map section type %x", item->type_); 27510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 27610037c866b04550fc5461058c398c2e3e509381ajeffhao } 27710037c866b04550fc5461058c398c2e3e509381ajeffhao 2788d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & bit) != 0)) { 2798d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Duplicate map section of type %x", item->type_); 28010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 28110037c866b04550fc5461058c398c2e3e509381ajeffhao } 28210037c866b04550fc5461058c398c2e3e509381ajeffhao 28310037c866b04550fc5461058c398c2e3e509381ajeffhao used_bits |= bit; 28410037c866b04550fc5461058c398c2e3e509381ajeffhao last_offset = item->offset_; 28510037c866b04550fc5461058c398c2e3e509381ajeffhao item++; 28610037c866b04550fc5461058c398c2e3e509381ajeffhao } 28710037c866b04550fc5461058c398c2e3e509381ajeffhao 28810037c866b04550fc5461058c398c2e3e509381ajeffhao // Check for missing sections in the map. 2898d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & MapTypeToBitMask(DexFile::kDexTypeHeaderItem)) == 0)) { 2908d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map is missing header entry"); 29110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 29210037c866b04550fc5461058c398c2e3e509381ajeffhao } 2938d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & MapTypeToBitMask(DexFile::kDexTypeMapList)) == 0)) { 2948d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map is missing map_list entry"); 29510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 29610037c866b04550fc5461058c398c2e3e509381ajeffhao } 2978d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & MapTypeToBitMask(DexFile::kDexTypeStringIdItem)) == 0 && 2988d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ((header_->string_ids_off_ != 0) || (header_->string_ids_size_ != 0)))) { 2998d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map is missing string_ids entry"); 30010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 30110037c866b04550fc5461058c398c2e3e509381ajeffhao } 3028d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & MapTypeToBitMask(DexFile::kDexTypeTypeIdItem)) == 0 && 3038d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ((header_->type_ids_off_ != 0) || (header_->type_ids_size_ != 0)))) { 3048d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map is missing type_ids entry"); 30510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 30610037c866b04550fc5461058c398c2e3e509381ajeffhao } 3078d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & MapTypeToBitMask(DexFile::kDexTypeProtoIdItem)) == 0 && 3088d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ((header_->proto_ids_off_ != 0) || (header_->proto_ids_size_ != 0)))) { 3098d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map is missing proto_ids entry"); 31010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 31110037c866b04550fc5461058c398c2e3e509381ajeffhao } 3128d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & MapTypeToBitMask(DexFile::kDexTypeFieldIdItem)) == 0 && 3138d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ((header_->field_ids_off_ != 0) || (header_->field_ids_size_ != 0)))) { 3148d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map is missing field_ids entry"); 31510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 31610037c866b04550fc5461058c398c2e3e509381ajeffhao } 3178d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & MapTypeToBitMask(DexFile::kDexTypeMethodIdItem)) == 0 && 3188d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ((header_->method_ids_off_ != 0) || (header_->method_ids_size_ != 0)))) { 3198d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map is missing method_ids entry"); 32010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 32110037c866b04550fc5461058c398c2e3e509381ajeffhao } 3228d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((used_bits & MapTypeToBitMask(DexFile::kDexTypeClassDefItem)) == 0 && 3238d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ((header_->class_defs_off_ != 0) || (header_->class_defs_size_ != 0)))) { 3248d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map is missing class_defs entry"); 32510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 32610037c866b04550fc5461058c398c2e3e509381ajeffhao } 32710037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 32810037c866b04550fc5461058c398c2e3e509381ajeffhao} 32910037c866b04550fc5461058c398c2e3e509381ajeffhao 33010037c866b04550fc5461058c398c2e3e509381ajeffhaouint32_t DexFileVerifier::ReadUnsignedLittleEndian(uint32_t size) { 33110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t result = 0; 3328d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (LIKELY(CheckPointerRange(ptr_, ptr_ + size, "encoded_value"))) { 3338d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers for (uint32_t i = 0; i < size; i++) { 3348d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers result |= ((uint32_t) *(ptr_++)) << (i * 8); 3358d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers } 33610037c866b04550fc5461058c398c2e3e509381ajeffhao } 33710037c866b04550fc5461058c398c2e3e509381ajeffhao return result; 33810037c866b04550fc5461058c398c2e3e509381ajeffhao} 33910037c866b04550fc5461058c398c2e3e509381ajeffhao 34010037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckAndGetHandlerOffsets(const DexFile::CodeItem* code_item, 3418d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers uint32_t* handler_offsets, uint32_t handlers_size) { 34210037c866b04550fc5461058c398c2e3e509381ajeffhao const byte* handlers_base = DexFile::GetCatchHandlerData(*code_item, 0); 34310037c866b04550fc5461058c398c2e3e509381ajeffhao 34410037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < handlers_size; i++) { 34510037c866b04550fc5461058c398c2e3e509381ajeffhao bool catch_all; 3468a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers size_t offset = ptr_ - handlers_base; 34710037c866b04550fc5461058c398c2e3e509381ajeffhao int32_t size = DecodeSignedLeb128(&ptr_); 34810037c866b04550fc5461058c398c2e3e509381ajeffhao 3498d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((size < -65536) || (size > 65536))) { 3508d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid exception handler size: %d", size); 35110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 35210037c866b04550fc5461058c398c2e3e509381ajeffhao } 35310037c866b04550fc5461058c398c2e3e509381ajeffhao 35410037c866b04550fc5461058c398c2e3e509381ajeffhao if (size <= 0) { 35510037c866b04550fc5461058c398c2e3e509381ajeffhao catch_all = true; 35610037c866b04550fc5461058c398c2e3e509381ajeffhao size = -size; 35710037c866b04550fc5461058c398c2e3e509381ajeffhao } else { 35810037c866b04550fc5461058c398c2e3e509381ajeffhao catch_all = false; 35910037c866b04550fc5461058c398c2e3e509381ajeffhao } 36010037c866b04550fc5461058c398c2e3e509381ajeffhao 3618a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers handler_offsets[i] = static_cast<uint32_t>(offset); 36210037c866b04550fc5461058c398c2e3e509381ajeffhao 36310037c866b04550fc5461058c398c2e3e509381ajeffhao while (size-- > 0) { 36410037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t type_idx = DecodeUnsignedLeb128(&ptr_); 36510037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(type_idx, header_->type_ids_size_, "handler type_idx")) { 36610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 36710037c866b04550fc5461058c398c2e3e509381ajeffhao } 36810037c866b04550fc5461058c398c2e3e509381ajeffhao 36910037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t addr = DecodeUnsignedLeb128(&ptr_); 3708d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(addr >= code_item->insns_size_in_code_units_)) { 3718d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid handler addr: %x", addr); 37210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 37310037c866b04550fc5461058c398c2e3e509381ajeffhao } 37410037c866b04550fc5461058c398c2e3e509381ajeffhao } 37510037c866b04550fc5461058c398c2e3e509381ajeffhao 37610037c866b04550fc5461058c398c2e3e509381ajeffhao if (catch_all) { 37710037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t addr = DecodeUnsignedLeb128(&ptr_); 3788d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(addr >= code_item->insns_size_in_code_units_)) { 3798d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid handler catch_all_addr: %x", addr); 38010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 38110037c866b04550fc5461058c398c2e3e509381ajeffhao } 38210037c866b04550fc5461058c398c2e3e509381ajeffhao } 38310037c866b04550fc5461058c398c2e3e509381ajeffhao } 38410037c866b04550fc5461058c398c2e3e509381ajeffhao 38510037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 38610037c866b04550fc5461058c398c2e3e509381ajeffhao} 38710037c866b04550fc5461058c398c2e3e509381ajeffhao 38810037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckClassDataItemField(uint32_t idx, uint32_t access_flags, 3898d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers bool expect_static) { 39010037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(idx, header_->field_ids_size_, "class_data_item field_idx")) { 39110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 39210037c866b04550fc5461058c398c2e3e509381ajeffhao } 39310037c866b04550fc5461058c398c2e3e509381ajeffhao 39410037c866b04550fc5461058c398c2e3e509381ajeffhao bool is_static = (access_flags & kAccStatic) != 0; 3958d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(is_static != expect_static)) { 3968d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Static/instance field not in expected list"); 39710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 39810037c866b04550fc5461058c398c2e3e509381ajeffhao } 39910037c866b04550fc5461058c398c2e3e509381ajeffhao 40010037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t access_field_mask = kAccPublic | kAccPrivate | kAccProtected | kAccStatic | 40110037c866b04550fc5461058c398c2e3e509381ajeffhao kAccFinal | kAccVolatile | kAccTransient | kAccSynthetic | kAccEnum; 4028d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((access_flags & ~access_field_mask) != 0)) { 4038d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad class_data_item field access_flags %x", access_flags); 40410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 40510037c866b04550fc5461058c398c2e3e509381ajeffhao } 40610037c866b04550fc5461058c398c2e3e509381ajeffhao 40710037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 40810037c866b04550fc5461058c398c2e3e509381ajeffhao} 40910037c866b04550fc5461058c398c2e3e509381ajeffhao 41010037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckClassDataItemMethod(uint32_t idx, uint32_t access_flags, 4118d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers uint32_t code_offset, bool expect_direct) { 41210037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(idx, header_->method_ids_size_, "class_data_item method_idx")) { 41310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 41410037c866b04550fc5461058c398c2e3e509381ajeffhao } 41510037c866b04550fc5461058c398c2e3e509381ajeffhao 41610037c866b04550fc5461058c398c2e3e509381ajeffhao bool is_direct = (access_flags & (kAccStatic | kAccPrivate | kAccConstructor)) != 0; 41710037c866b04550fc5461058c398c2e3e509381ajeffhao bool expect_code = (access_flags & (kAccNative | kAccAbstract)) == 0; 41810037c866b04550fc5461058c398c2e3e509381ajeffhao bool is_synchronized = (access_flags & kAccSynchronized) != 0; 41910037c866b04550fc5461058c398c2e3e509381ajeffhao bool allow_synchronized = (access_flags & kAccNative) != 0; 42010037c866b04550fc5461058c398c2e3e509381ajeffhao 4218d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(is_direct != expect_direct)) { 4228d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Direct/virtual method not in expected list"); 42310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 42410037c866b04550fc5461058c398c2e3e509381ajeffhao } 42510037c866b04550fc5461058c398c2e3e509381ajeffhao 42610037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t access_method_mask = kAccPublic | kAccPrivate | kAccProtected | kAccStatic | 42710037c866b04550fc5461058c398c2e3e509381ajeffhao kAccFinal | kAccSynchronized | kAccBridge | kAccVarargs | kAccNative | kAccAbstract | 42810037c866b04550fc5461058c398c2e3e509381ajeffhao kAccStrict | kAccSynthetic | kAccConstructor | kAccDeclaredSynchronized; 4298d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(((access_flags & ~access_method_mask) != 0) || 4308d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers (is_synchronized && !allow_synchronized))) { 4318d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad class_data_item method access_flags %x", access_flags); 43210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 43310037c866b04550fc5461058c398c2e3e509381ajeffhao } 43410037c866b04550fc5461058c398c2e3e509381ajeffhao 4358d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(expect_code && (code_offset == 0))) { 4368d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Unexpected zero value for class_data_item method code_off with access " 4378d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers "flags %x", access_flags); 43810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 4398d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers } else if (UNLIKELY(!expect_code && (code_offset != 0))) { 4408d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Unexpected non-zero value %x for class_data_item method code_off" 4418d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers " with access flags %x", code_offset, access_flags); 44210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 44310037c866b04550fc5461058c398c2e3e509381ajeffhao } 44410037c866b04550fc5461058c398c2e3e509381ajeffhao 44510037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 44610037c866b04550fc5461058c398c2e3e509381ajeffhao} 44710037c866b04550fc5461058c398c2e3e509381ajeffhao 4488a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogersbool DexFileVerifier::CheckPadding(size_t offset, uint32_t aligned_offset) { 44910037c866b04550fc5461058c398c2e3e509381ajeffhao if (offset < aligned_offset) { 45030fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers if (!CheckPointerRange(begin_ + offset, begin_ + aligned_offset, "section")) { 45110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 45210037c866b04550fc5461058c398c2e3e509381ajeffhao } 45310037c866b04550fc5461058c398c2e3e509381ajeffhao while (offset < aligned_offset) { 4548d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(*ptr_ != '\0')) { 4558a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers ErrorStringPrintf("Non-zero padding %x before section start at %zx", *ptr_, offset); 45610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 45710037c866b04550fc5461058c398c2e3e509381ajeffhao } 45810037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_++; 45910037c866b04550fc5461058c398c2e3e509381ajeffhao offset++; 46010037c866b04550fc5461058c398c2e3e509381ajeffhao } 46110037c866b04550fc5461058c398c2e3e509381ajeffhao } 46210037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 46310037c866b04550fc5461058c398c2e3e509381ajeffhao} 46410037c866b04550fc5461058c398c2e3e509381ajeffhao 46510037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckEncodedValue() { 46610037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(ptr_, ptr_ + 1, "encoded_value header")) { 46710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 46810037c866b04550fc5461058c398c2e3e509381ajeffhao } 46910037c866b04550fc5461058c398c2e3e509381ajeffhao 47010037c866b04550fc5461058c398c2e3e509381ajeffhao uint8_t header_byte = *(ptr_++); 47110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t value_type = header_byte & DexFile::kDexAnnotationValueTypeMask; 47210037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t value_arg = header_byte >> DexFile::kDexAnnotationValueArgShift; 47310037c866b04550fc5461058c398c2e3e509381ajeffhao 47410037c866b04550fc5461058c398c2e3e509381ajeffhao switch (value_type) { 47510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationByte: 4768d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg != 0)) { 4778d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value byte size %x", value_arg); 47810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 47910037c866b04550fc5461058c398c2e3e509381ajeffhao } 48010037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_++; 48110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 48210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationShort: 48310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationChar: 4848d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg > 1)) { 4858d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value char/short size %x", value_arg); 48610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 48710037c866b04550fc5461058c398c2e3e509381ajeffhao } 48810037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += value_arg + 1; 48910037c866b04550fc5461058c398c2e3e509381ajeffhao break; 49010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationInt: 49110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationFloat: 4928d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg > 3)) { 4938d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value int/float size %x", value_arg); 49410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 49510037c866b04550fc5461058c398c2e3e509381ajeffhao } 49610037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += value_arg + 1; 49710037c866b04550fc5461058c398c2e3e509381ajeffhao break; 49810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationLong: 49910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationDouble: 50010037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += value_arg + 1; 50110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 50210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationString: { 5038d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg > 3)) { 5048d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value string size %x", value_arg); 50510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 50610037c866b04550fc5461058c398c2e3e509381ajeffhao } 50710037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t idx = ReadUnsignedLittleEndian(value_arg + 1); 50810037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(idx, header_->string_ids_size_, "encoded_value string")) { 50910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 51010037c866b04550fc5461058c398c2e3e509381ajeffhao } 51110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 51210037c866b04550fc5461058c398c2e3e509381ajeffhao } 51310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationType: { 5148d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg > 3)) { 5158d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value type size %x", value_arg); 51610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 51710037c866b04550fc5461058c398c2e3e509381ajeffhao } 51810037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t idx = ReadUnsignedLittleEndian(value_arg + 1); 51910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(idx, header_->type_ids_size_, "encoded_value type")) { 52010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 52110037c866b04550fc5461058c398c2e3e509381ajeffhao } 52210037c866b04550fc5461058c398c2e3e509381ajeffhao break; 52310037c866b04550fc5461058c398c2e3e509381ajeffhao } 52410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationField: 52510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationEnum: { 5268d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg > 3)) { 5278d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value field/enum size %x", value_arg); 52810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 52910037c866b04550fc5461058c398c2e3e509381ajeffhao } 53010037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t idx = ReadUnsignedLittleEndian(value_arg + 1); 53110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(idx, header_->field_ids_size_, "encoded_value field")) { 53210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 53310037c866b04550fc5461058c398c2e3e509381ajeffhao } 53410037c866b04550fc5461058c398c2e3e509381ajeffhao break; 53510037c866b04550fc5461058c398c2e3e509381ajeffhao } 53610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationMethod: { 5378d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg > 3)) { 5388d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value method size %x", value_arg); 53910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 54010037c866b04550fc5461058c398c2e3e509381ajeffhao } 54110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t idx = ReadUnsignedLittleEndian(value_arg + 1); 54210037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(idx, header_->method_ids_size_, "encoded_value method")) { 54310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 54410037c866b04550fc5461058c398c2e3e509381ajeffhao } 54510037c866b04550fc5461058c398c2e3e509381ajeffhao break; 54610037c866b04550fc5461058c398c2e3e509381ajeffhao } 54710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationArray: 5488d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg != 0)) { 5498d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value array value_arg %x", value_arg); 55010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 55110037c866b04550fc5461058c398c2e3e509381ajeffhao } 55210037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckEncodedArray()) { 55310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 55410037c866b04550fc5461058c398c2e3e509381ajeffhao } 55510037c866b04550fc5461058c398c2e3e509381ajeffhao break; 55610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationAnnotation: 5578d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg != 0)) { 5588d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value annotation value_arg %x", value_arg); 55910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 56010037c866b04550fc5461058c398c2e3e509381ajeffhao } 56110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckEncodedAnnotation()) { 56210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 56310037c866b04550fc5461058c398c2e3e509381ajeffhao } 56410037c866b04550fc5461058c398c2e3e509381ajeffhao break; 56510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationNull: 5668d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg != 0)) { 5678d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value null value_arg %x", value_arg); 56810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 56910037c866b04550fc5461058c398c2e3e509381ajeffhao } 57010037c866b04550fc5461058c398c2e3e509381ajeffhao break; 57110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexAnnotationBoolean: 5728d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value_arg > 1)) { 5738d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad encoded_value boolean size %x", value_arg); 57410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 57510037c866b04550fc5461058c398c2e3e509381ajeffhao } 57610037c866b04550fc5461058c398c2e3e509381ajeffhao break; 57710037c866b04550fc5461058c398c2e3e509381ajeffhao default: 5788d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bogus encoded_value value_type %x", value_type); 57910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 58010037c866b04550fc5461058c398c2e3e509381ajeffhao } 58110037c866b04550fc5461058c398c2e3e509381ajeffhao 58210037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 58310037c866b04550fc5461058c398c2e3e509381ajeffhao} 58410037c866b04550fc5461058c398c2e3e509381ajeffhao 58510037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckEncodedArray() { 58610037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t size = DecodeUnsignedLeb128(&ptr_); 58710037c866b04550fc5461058c398c2e3e509381ajeffhao 58810037c866b04550fc5461058c398c2e3e509381ajeffhao while (size--) { 58910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckEncodedValue()) { 5908d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers failure_reason_ = StringPrintf("Bad encoded_array value: %s", failure_reason_.c_str()); 59110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 59210037c866b04550fc5461058c398c2e3e509381ajeffhao } 59310037c866b04550fc5461058c398c2e3e509381ajeffhao } 59410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 59510037c866b04550fc5461058c398c2e3e509381ajeffhao} 59610037c866b04550fc5461058c398c2e3e509381ajeffhao 59710037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckEncodedAnnotation() { 59810037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t idx = DecodeUnsignedLeb128(&ptr_); 59910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(idx, header_->type_ids_size_, "encoded_annotation type_idx")) { 60010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 60110037c866b04550fc5461058c398c2e3e509381ajeffhao } 60210037c866b04550fc5461058c398c2e3e509381ajeffhao 60310037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t size = DecodeUnsignedLeb128(&ptr_); 60410037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t last_idx = 0; 60510037c866b04550fc5461058c398c2e3e509381ajeffhao 60610037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < size; i++) { 60710037c866b04550fc5461058c398c2e3e509381ajeffhao idx = DecodeUnsignedLeb128(&ptr_); 60810037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(idx, header_->string_ids_size_, "annotation_element name_idx")) { 60910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 61010037c866b04550fc5461058c398c2e3e509381ajeffhao } 61110037c866b04550fc5461058c398c2e3e509381ajeffhao 6128d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(last_idx >= idx && i != 0)) { 6138d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order annotation_element name_idx: %x then %x", 6148d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers last_idx, idx); 61510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 61610037c866b04550fc5461058c398c2e3e509381ajeffhao } 61710037c866b04550fc5461058c398c2e3e509381ajeffhao 61810037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckEncodedValue()) { 61910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 62010037c866b04550fc5461058c398c2e3e509381ajeffhao } 62110037c866b04550fc5461058c398c2e3e509381ajeffhao 62210037c866b04550fc5461058c398c2e3e509381ajeffhao last_idx = idx; 62310037c866b04550fc5461058c398c2e3e509381ajeffhao } 62410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 62510037c866b04550fc5461058c398c2e3e509381ajeffhao} 62610037c866b04550fc5461058c398c2e3e509381ajeffhao 62710037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckIntraClassDataItem() { 62810037c866b04550fc5461058c398c2e3e509381ajeffhao ClassDataItemIterator it(*dex_file_, ptr_); 62910037c866b04550fc5461058c398c2e3e509381ajeffhao 63010037c866b04550fc5461058c398c2e3e509381ajeffhao for (; it.HasNextStaticField(); it.Next()) { 63110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckClassDataItemField(it.GetMemberIndex(), it.GetMemberAccessFlags(), true)) { 63210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 63310037c866b04550fc5461058c398c2e3e509381ajeffhao } 63410037c866b04550fc5461058c398c2e3e509381ajeffhao } 63510037c866b04550fc5461058c398c2e3e509381ajeffhao for (; it.HasNextInstanceField(); it.Next()) { 63610037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckClassDataItemField(it.GetMemberIndex(), it.GetMemberAccessFlags(), false)) { 63710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 63810037c866b04550fc5461058c398c2e3e509381ajeffhao } 63910037c866b04550fc5461058c398c2e3e509381ajeffhao } 64010037c866b04550fc5461058c398c2e3e509381ajeffhao for (; it.HasNextDirectMethod(); it.Next()) { 64110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckClassDataItemMethod(it.GetMemberIndex(), it.GetMemberAccessFlags(), 64210037c866b04550fc5461058c398c2e3e509381ajeffhao it.GetMethodCodeItemOffset(), true)) { 64310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 64410037c866b04550fc5461058c398c2e3e509381ajeffhao } 64510037c866b04550fc5461058c398c2e3e509381ajeffhao } 64610037c866b04550fc5461058c398c2e3e509381ajeffhao for (; it.HasNextVirtualMethod(); it.Next()) { 64710037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckClassDataItemMethod(it.GetMemberIndex(), it.GetMemberAccessFlags(), 64810037c866b04550fc5461058c398c2e3e509381ajeffhao it.GetMethodCodeItemOffset(), false)) { 64910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 65010037c866b04550fc5461058c398c2e3e509381ajeffhao } 65110037c866b04550fc5461058c398c2e3e509381ajeffhao } 65210037c866b04550fc5461058c398c2e3e509381ajeffhao 65310037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = it.EndDataPointer(); 65410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 65510037c866b04550fc5461058c398c2e3e509381ajeffhao} 65610037c866b04550fc5461058c398c2e3e509381ajeffhao 65710037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckIntraCodeItem() { 65810037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::CodeItem* code_item = reinterpret_cast<const DexFile::CodeItem*>(ptr_); 65910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(code_item, code_item + 1, "code")) { 66010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 66110037c866b04550fc5461058c398c2e3e509381ajeffhao } 66210037c866b04550fc5461058c398c2e3e509381ajeffhao 6638d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(code_item->ins_size_ > code_item->registers_size_)) { 6648d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("ins_size (%ud) > registers_size (%ud)", 6658d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers code_item->ins_size_, code_item->registers_size_); 66610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 66710037c866b04550fc5461058c398c2e3e509381ajeffhao } 66810037c866b04550fc5461058c398c2e3e509381ajeffhao 6698d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((code_item->outs_size_ > 5) && 6708d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers (code_item->outs_size_ > code_item->registers_size_))) { 67110037c866b04550fc5461058c398c2e3e509381ajeffhao /* 67210037c866b04550fc5461058c398c2e3e509381ajeffhao * outs_size can be up to 5, even if registers_size is smaller, since the 67310037c866b04550fc5461058c398c2e3e509381ajeffhao * short forms of method invocation allow repetitions of a register multiple 67410037c866b04550fc5461058c398c2e3e509381ajeffhao * times within a single parameter list. However, longer parameter lists 67510037c866b04550fc5461058c398c2e3e509381ajeffhao * need to be represented in-order in the register file. 67610037c866b04550fc5461058c398c2e3e509381ajeffhao */ 6778d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("outs_size (%ud) > registers_size (%ud)", 6788d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers code_item->outs_size_, code_item->registers_size_); 67910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 68010037c866b04550fc5461058c398c2e3e509381ajeffhao } 68110037c866b04550fc5461058c398c2e3e509381ajeffhao 68210037c866b04550fc5461058c398c2e3e509381ajeffhao const uint16_t* insns = code_item->insns_; 68310037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t insns_size = code_item->insns_size_in_code_units_; 68410037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckListSize(insns, insns_size, sizeof(uint16_t), "insns size")) { 68510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 68610037c866b04550fc5461058c398c2e3e509381ajeffhao } 68710037c866b04550fc5461058c398c2e3e509381ajeffhao 68810037c866b04550fc5461058c398c2e3e509381ajeffhao // Grab the end of the insns if there are no try_items. 68910037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t try_items_size = code_item->tries_size_; 69010037c866b04550fc5461058c398c2e3e509381ajeffhao if (try_items_size == 0) { 69110037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = reinterpret_cast<const byte*>(&insns[insns_size]); 69210037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 69310037c866b04550fc5461058c398c2e3e509381ajeffhao } 69410037c866b04550fc5461058c398c2e3e509381ajeffhao 69510037c866b04550fc5461058c398c2e3e509381ajeffhao // try_items are 4-byte aligned. Verify the spacer is 0. 6968a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers if (((reinterpret_cast<uintptr_t>(&insns[insns_size]) & 3) != 0) && (insns[insns_size] != 0)) { 6978d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Non-zero padding: %x", insns[insns_size]); 69810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 69910037c866b04550fc5461058c398c2e3e509381ajeffhao } 70010037c866b04550fc5461058c398c2e3e509381ajeffhao 70110037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::TryItem* try_items = DexFile::GetTryItems(*code_item, 0); 70210037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = DexFile::GetCatchHandlerData(*code_item, 0); 70310037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t handlers_size = DecodeUnsignedLeb128(&ptr_); 70410037c866b04550fc5461058c398c2e3e509381ajeffhao 70510037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckListSize(try_items, try_items_size, sizeof(DexFile::TryItem), "try_items size")) { 70610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 70710037c866b04550fc5461058c398c2e3e509381ajeffhao } 70810037c866b04550fc5461058c398c2e3e509381ajeffhao 7098d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((handlers_size == 0) || (handlers_size >= 65536))) { 7108d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid handlers_size: %ud", handlers_size); 71110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 71210037c866b04550fc5461058c398c2e3e509381ajeffhao } 71310037c866b04550fc5461058c398c2e3e509381ajeffhao 714700a402244a1a423da4f3ba8032459f4b65fa18fIan Rogers std::unique_ptr<uint32_t[]> handler_offsets(new uint32_t[handlers_size]); 715ee0fa76b2e5d39ad36d1ff144b2d0270df81e606Elliott Hughes if (!CheckAndGetHandlerOffsets(code_item, &handler_offsets[0], handlers_size)) { 71610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 71710037c866b04550fc5461058c398c2e3e509381ajeffhao } 71810037c866b04550fc5461058c398c2e3e509381ajeffhao 71910037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t last_addr = 0; 72010037c866b04550fc5461058c398c2e3e509381ajeffhao while (try_items_size--) { 7218d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(try_items->start_addr_ < last_addr)) { 7228d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of_order try_item with start_addr: %x", try_items->start_addr_); 72310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 72410037c866b04550fc5461058c398c2e3e509381ajeffhao } 72510037c866b04550fc5461058c398c2e3e509381ajeffhao 7268d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(try_items->start_addr_ >= insns_size)) { 7278d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid try_item start_addr: %x", try_items->start_addr_); 72810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 72910037c866b04550fc5461058c398c2e3e509381ajeffhao } 73010037c866b04550fc5461058c398c2e3e509381ajeffhao 73110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t i; 73210037c866b04550fc5461058c398c2e3e509381ajeffhao for (i = 0; i < handlers_size; i++) { 73310037c866b04550fc5461058c398c2e3e509381ajeffhao if (try_items->handler_off_ == handler_offsets[i]) { 73410037c866b04550fc5461058c398c2e3e509381ajeffhao break; 73510037c866b04550fc5461058c398c2e3e509381ajeffhao } 73610037c866b04550fc5461058c398c2e3e509381ajeffhao } 73710037c866b04550fc5461058c398c2e3e509381ajeffhao 7388d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(i == handlers_size)) { 7398d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bogus handler offset: %x", try_items->handler_off_); 74010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 74110037c866b04550fc5461058c398c2e3e509381ajeffhao } 74210037c866b04550fc5461058c398c2e3e509381ajeffhao 74310037c866b04550fc5461058c398c2e3e509381ajeffhao last_addr = try_items->start_addr_ + try_items->insn_count_; 7448d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(last_addr > insns_size)) { 7458d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid try_item insn_count: %x", try_items->insn_count_); 74610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 74710037c866b04550fc5461058c398c2e3e509381ajeffhao } 74810037c866b04550fc5461058c398c2e3e509381ajeffhao 74910037c866b04550fc5461058c398c2e3e509381ajeffhao try_items++; 75010037c866b04550fc5461058c398c2e3e509381ajeffhao } 75110037c866b04550fc5461058c398c2e3e509381ajeffhao 75210037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 75310037c866b04550fc5461058c398c2e3e509381ajeffhao} 75410037c866b04550fc5461058c398c2e3e509381ajeffhao 75510037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckIntraStringDataItem() { 75610037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t size = DecodeUnsignedLeb128(&ptr_); 757f6174e8a1566bb357e82506f7ec97dc359c90eb2jeffhao const byte* file_end = begin_ + size_; 75810037c866b04550fc5461058c398c2e3e509381ajeffhao 75910037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < size; i++) { 760c647564845429bd709ed3338c13f15063c2f9fd9Brian Carlstrom CHECK_LT(i, size); // b/15014252 Prevents hitting the impossible case below 7618d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(ptr_ >= file_end)) { 7628d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("String data would go beyond end-of-file"); 76310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 76410037c866b04550fc5461058c398c2e3e509381ajeffhao } 76510037c866b04550fc5461058c398c2e3e509381ajeffhao 76610037c866b04550fc5461058c398c2e3e509381ajeffhao uint8_t byte = *(ptr_++); 76710037c866b04550fc5461058c398c2e3e509381ajeffhao 76810037c866b04550fc5461058c398c2e3e509381ajeffhao // Switch on the high 4 bits. 76910037c866b04550fc5461058c398c2e3e509381ajeffhao switch (byte >> 4) { 77010037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x00: 77110037c866b04550fc5461058c398c2e3e509381ajeffhao // Special case of bit pattern 0xxx. 7728d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(byte == 0)) { 773c647564845429bd709ed3338c13f15063c2f9fd9Brian Carlstrom CHECK_LT(i, size); // b/15014252 Actually hit this impossible case with clang 7748d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("String data shorter than indicated utf16_size %x", size); 77510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 77610037c866b04550fc5461058c398c2e3e509381ajeffhao } 77710037c866b04550fc5461058c398c2e3e509381ajeffhao break; 77810037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x01: 77910037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x02: 78010037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x03: 78110037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x04: 78210037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x05: 78310037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x06: 78410037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x07: 78510037c866b04550fc5461058c398c2e3e509381ajeffhao // No extra checks necessary for bit pattern 0xxx. 78610037c866b04550fc5461058c398c2e3e509381ajeffhao break; 78710037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x08: 78810037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x09: 78910037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x0a: 79010037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x0b: 79110037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x0f: 79210037c866b04550fc5461058c398c2e3e509381ajeffhao // Illegal bit patterns 10xx or 1111. 79310037c866b04550fc5461058c398c2e3e509381ajeffhao // Note: 1111 is valid for normal UTF-8, but not here. 7948d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Illegal start byte %x in string data", byte); 79510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 79610037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x0c: 79710037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x0d: { 79810037c866b04550fc5461058c398c2e3e509381ajeffhao // Bit pattern 110x has an additional byte. 79910037c866b04550fc5461058c398c2e3e509381ajeffhao uint8_t byte2 = *(ptr_++); 8008d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((byte2 & 0xc0) != 0x80)) { 8018d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Illegal continuation byte %x in string data", byte2); 80210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 80310037c866b04550fc5461058c398c2e3e509381ajeffhao } 80410037c866b04550fc5461058c398c2e3e509381ajeffhao uint16_t value = ((byte & 0x1f) << 6) | (byte2 & 0x3f); 8058d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((value != 0) && (value < 0x80))) { 8068d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Illegal representation for value %x in string data", value); 80710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 80810037c866b04550fc5461058c398c2e3e509381ajeffhao } 80910037c866b04550fc5461058c398c2e3e509381ajeffhao break; 81010037c866b04550fc5461058c398c2e3e509381ajeffhao } 81110037c866b04550fc5461058c398c2e3e509381ajeffhao case 0x0e: { 81210037c866b04550fc5461058c398c2e3e509381ajeffhao // Bit pattern 1110 has 2 additional bytes. 81310037c866b04550fc5461058c398c2e3e509381ajeffhao uint8_t byte2 = *(ptr_++); 8148d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((byte2 & 0xc0) != 0x80)) { 8158d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Illegal continuation byte %x in string data", byte2); 81610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 81710037c866b04550fc5461058c398c2e3e509381ajeffhao } 81810037c866b04550fc5461058c398c2e3e509381ajeffhao uint8_t byte3 = *(ptr_++); 8198d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((byte3 & 0xc0) != 0x80)) { 8208d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Illegal continuation byte %x in string data", byte3); 82110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 82210037c866b04550fc5461058c398c2e3e509381ajeffhao } 82310037c866b04550fc5461058c398c2e3e509381ajeffhao uint16_t value = ((byte & 0x0f) << 12) | ((byte2 & 0x3f) << 6) | (byte3 & 0x3f); 8248d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(value < 0x800)) { 8258d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Illegal representation for value %x in string data", value); 82610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 82710037c866b04550fc5461058c398c2e3e509381ajeffhao } 82810037c866b04550fc5461058c398c2e3e509381ajeffhao break; 82910037c866b04550fc5461058c398c2e3e509381ajeffhao } 83010037c866b04550fc5461058c398c2e3e509381ajeffhao } 83110037c866b04550fc5461058c398c2e3e509381ajeffhao } 83210037c866b04550fc5461058c398c2e3e509381ajeffhao 8338d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(*(ptr_++) != '\0')) { 8348d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("String longer than indicated size %x", size); 83510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 83610037c866b04550fc5461058c398c2e3e509381ajeffhao } 83710037c866b04550fc5461058c398c2e3e509381ajeffhao 83810037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 83910037c866b04550fc5461058c398c2e3e509381ajeffhao} 84010037c866b04550fc5461058c398c2e3e509381ajeffhao 84110037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckIntraDebugInfoItem() { 84210037c866b04550fc5461058c398c2e3e509381ajeffhao DecodeUnsignedLeb128(&ptr_); 84310037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t parameters_size = DecodeUnsignedLeb128(&ptr_); 8448d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(parameters_size > 65536)) { 8458d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid parameters_size: %x", parameters_size); 84610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 84710037c866b04550fc5461058c398c2e3e509381ajeffhao } 84810037c866b04550fc5461058c398c2e3e509381ajeffhao 84910037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t j = 0; j < parameters_size; j++) { 85010037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t parameter_name = DecodeUnsignedLeb128(&ptr_); 85110037c866b04550fc5461058c398c2e3e509381ajeffhao if (parameter_name != 0) { 85210037c866b04550fc5461058c398c2e3e509381ajeffhao parameter_name--; 85310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(parameter_name, header_->string_ids_size_, "debug_info_item parameter_name")) { 85410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 85510037c866b04550fc5461058c398c2e3e509381ajeffhao } 85610037c866b04550fc5461058c398c2e3e509381ajeffhao } 85710037c866b04550fc5461058c398c2e3e509381ajeffhao } 85810037c866b04550fc5461058c398c2e3e509381ajeffhao 85910037c866b04550fc5461058c398c2e3e509381ajeffhao while (true) { 86010037c866b04550fc5461058c398c2e3e509381ajeffhao uint8_t opcode = *(ptr_++); 86110037c866b04550fc5461058c398c2e3e509381ajeffhao switch (opcode) { 86210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::DBG_END_SEQUENCE: { 86310037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 86410037c866b04550fc5461058c398c2e3e509381ajeffhao } 86510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::DBG_ADVANCE_PC: { 86610037c866b04550fc5461058c398c2e3e509381ajeffhao DecodeUnsignedLeb128(&ptr_); 86710037c866b04550fc5461058c398c2e3e509381ajeffhao break; 86810037c866b04550fc5461058c398c2e3e509381ajeffhao } 86910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::DBG_ADVANCE_LINE: { 87010037c866b04550fc5461058c398c2e3e509381ajeffhao DecodeSignedLeb128(&ptr_); 87110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 87210037c866b04550fc5461058c398c2e3e509381ajeffhao } 87310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::DBG_START_LOCAL: { 87410037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t reg_num = DecodeUnsignedLeb128(&ptr_); 8758d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(reg_num >= 65536)) { 8768d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad reg_num for opcode %x", opcode); 87710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 87810037c866b04550fc5461058c398c2e3e509381ajeffhao } 87910037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t name_idx = DecodeUnsignedLeb128(&ptr_); 88010037c866b04550fc5461058c398c2e3e509381ajeffhao if (name_idx != 0) { 88110037c866b04550fc5461058c398c2e3e509381ajeffhao name_idx--; 88210037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(name_idx, header_->string_ids_size_, "DBG_START_LOCAL name_idx")) { 88310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 88410037c866b04550fc5461058c398c2e3e509381ajeffhao } 88510037c866b04550fc5461058c398c2e3e509381ajeffhao } 88610037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t type_idx = DecodeUnsignedLeb128(&ptr_); 88710037c866b04550fc5461058c398c2e3e509381ajeffhao if (type_idx != 0) { 88810037c866b04550fc5461058c398c2e3e509381ajeffhao type_idx--; 88910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(type_idx, header_->string_ids_size_, "DBG_START_LOCAL type_idx")) { 89010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 89110037c866b04550fc5461058c398c2e3e509381ajeffhao } 89210037c866b04550fc5461058c398c2e3e509381ajeffhao } 89310037c866b04550fc5461058c398c2e3e509381ajeffhao break; 89410037c866b04550fc5461058c398c2e3e509381ajeffhao } 89510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::DBG_END_LOCAL: 89610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::DBG_RESTART_LOCAL: { 89710037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t reg_num = DecodeUnsignedLeb128(&ptr_); 8988d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(reg_num >= 65536)) { 8998d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad reg_num for opcode %x", opcode); 90010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 90110037c866b04550fc5461058c398c2e3e509381ajeffhao } 90210037c866b04550fc5461058c398c2e3e509381ajeffhao break; 90310037c866b04550fc5461058c398c2e3e509381ajeffhao } 90410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::DBG_START_LOCAL_EXTENDED: { 90510037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t reg_num = DecodeUnsignedLeb128(&ptr_); 9068d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(reg_num >= 65536)) { 9078d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad reg_num for opcode %x", opcode); 90810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 90910037c866b04550fc5461058c398c2e3e509381ajeffhao } 91010037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t name_idx = DecodeUnsignedLeb128(&ptr_); 91110037c866b04550fc5461058c398c2e3e509381ajeffhao if (name_idx != 0) { 91210037c866b04550fc5461058c398c2e3e509381ajeffhao name_idx--; 91310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(name_idx, header_->string_ids_size_, "DBG_START_LOCAL_EXTENDED name_idx")) { 91410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 91510037c866b04550fc5461058c398c2e3e509381ajeffhao } 91610037c866b04550fc5461058c398c2e3e509381ajeffhao } 91710037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t type_idx = DecodeUnsignedLeb128(&ptr_); 91810037c866b04550fc5461058c398c2e3e509381ajeffhao if (type_idx != 0) { 91910037c866b04550fc5461058c398c2e3e509381ajeffhao type_idx--; 92010037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(type_idx, header_->string_ids_size_, "DBG_START_LOCAL_EXTENDED type_idx")) { 92110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 92210037c866b04550fc5461058c398c2e3e509381ajeffhao } 92310037c866b04550fc5461058c398c2e3e509381ajeffhao } 92410037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t sig_idx = DecodeUnsignedLeb128(&ptr_); 92510037c866b04550fc5461058c398c2e3e509381ajeffhao if (sig_idx != 0) { 92610037c866b04550fc5461058c398c2e3e509381ajeffhao sig_idx--; 92710037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(sig_idx, header_->string_ids_size_, "DBG_START_LOCAL_EXTENDED sig_idx")) { 92810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 92910037c866b04550fc5461058c398c2e3e509381ajeffhao } 93010037c866b04550fc5461058c398c2e3e509381ajeffhao } 93110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 93210037c866b04550fc5461058c398c2e3e509381ajeffhao } 93310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::DBG_SET_FILE: { 93410037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t name_idx = DecodeUnsignedLeb128(&ptr_); 93510037c866b04550fc5461058c398c2e3e509381ajeffhao if (name_idx != 0) { 93610037c866b04550fc5461058c398c2e3e509381ajeffhao name_idx--; 93710037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIndex(name_idx, header_->string_ids_size_, "DBG_SET_FILE name_idx")) { 93810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 93910037c866b04550fc5461058c398c2e3e509381ajeffhao } 94010037c866b04550fc5461058c398c2e3e509381ajeffhao } 94110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 94210037c866b04550fc5461058c398c2e3e509381ajeffhao } 94310037c866b04550fc5461058c398c2e3e509381ajeffhao } 94410037c866b04550fc5461058c398c2e3e509381ajeffhao } 94510037c866b04550fc5461058c398c2e3e509381ajeffhao} 94610037c866b04550fc5461058c398c2e3e509381ajeffhao 94710037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckIntraAnnotationItem() { 94810037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(ptr_, ptr_ + 1, "annotation visibility")) { 94910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 95010037c866b04550fc5461058c398c2e3e509381ajeffhao } 95110037c866b04550fc5461058c398c2e3e509381ajeffhao 95210037c866b04550fc5461058c398c2e3e509381ajeffhao // Check visibility 95310037c866b04550fc5461058c398c2e3e509381ajeffhao switch (*(ptr_++)) { 95410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexVisibilityBuild: 95510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexVisibilityRuntime: 95610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexVisibilitySystem: 95710037c866b04550fc5461058c398c2e3e509381ajeffhao break; 95810037c866b04550fc5461058c398c2e3e509381ajeffhao default: 9598d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad annotation visibility: %x", *ptr_); 96010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 96110037c866b04550fc5461058c398c2e3e509381ajeffhao } 96210037c866b04550fc5461058c398c2e3e509381ajeffhao 96310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckEncodedAnnotation()) { 96410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 96510037c866b04550fc5461058c398c2e3e509381ajeffhao } 96610037c866b04550fc5461058c398c2e3e509381ajeffhao 96710037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 96810037c866b04550fc5461058c398c2e3e509381ajeffhao} 96910037c866b04550fc5461058c398c2e3e509381ajeffhao 97010037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckIntraAnnotationsDirectoryItem() { 97110037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationsDirectoryItem* item = 97210037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::AnnotationsDirectoryItem*>(ptr_); 97310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(item, item + 1, "annotations_directory")) { 97410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 97510037c866b04550fc5461058c398c2e3e509381ajeffhao } 97610037c866b04550fc5461058c398c2e3e509381ajeffhao 97710037c866b04550fc5461058c398c2e3e509381ajeffhao // Field annotations follow immediately after the annotations directory. 97810037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::FieldAnnotationsItem* field_item = 97910037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::FieldAnnotationsItem*>(item + 1); 98010037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t field_count = item->fields_size_; 98110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckListSize(field_item, field_count, sizeof(DexFile::FieldAnnotationsItem), "field_annotations list")) { 98210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 98310037c866b04550fc5461058c398c2e3e509381ajeffhao } 98410037c866b04550fc5461058c398c2e3e509381ajeffhao 98510037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t last_idx = 0; 98610037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < field_count; i++) { 9878d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(last_idx >= field_item->field_idx_ && i != 0)) { 9888d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order field_idx for annotation: %x then %x", last_idx, field_item->field_idx_); 98910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 99010037c866b04550fc5461058c398c2e3e509381ajeffhao } 99110037c866b04550fc5461058c398c2e3e509381ajeffhao last_idx = field_item->field_idx_; 99210037c866b04550fc5461058c398c2e3e509381ajeffhao field_item++; 99310037c866b04550fc5461058c398c2e3e509381ajeffhao } 99410037c866b04550fc5461058c398c2e3e509381ajeffhao 99510037c866b04550fc5461058c398c2e3e509381ajeffhao // Method annotations follow immediately after field annotations. 99610037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::MethodAnnotationsItem* method_item = 99710037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::MethodAnnotationsItem*>(field_item); 99810037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t method_count = item->methods_size_; 99910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckListSize(method_item, method_count, sizeof(DexFile::MethodAnnotationsItem), "method_annotations list")) { 100010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 100110037c866b04550fc5461058c398c2e3e509381ajeffhao } 100210037c866b04550fc5461058c398c2e3e509381ajeffhao 100310037c866b04550fc5461058c398c2e3e509381ajeffhao last_idx = 0; 100410037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < method_count; i++) { 10058d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(last_idx >= method_item->method_idx_ && i != 0)) { 10068d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order method_idx for annotation: %x then %x", 10078d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers last_idx, method_item->method_idx_); 100810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 100910037c866b04550fc5461058c398c2e3e509381ajeffhao } 101010037c866b04550fc5461058c398c2e3e509381ajeffhao last_idx = method_item->method_idx_; 101110037c866b04550fc5461058c398c2e3e509381ajeffhao method_item++; 101210037c866b04550fc5461058c398c2e3e509381ajeffhao } 101310037c866b04550fc5461058c398c2e3e509381ajeffhao 101410037c866b04550fc5461058c398c2e3e509381ajeffhao // Parameter annotations follow immediately after method annotations. 101510037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::ParameterAnnotationsItem* parameter_item = 101610037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::ParameterAnnotationsItem*>(method_item); 101710037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t parameter_count = item->parameters_size_; 10182b87ddf36abff711fa2233c49bffc7ceb03b15d7Dragos Sbirlea if (!CheckListSize(parameter_item, parameter_count, sizeof(DexFile::ParameterAnnotationsItem), 10198d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers "parameter_annotations list")) { 102010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 102110037c866b04550fc5461058c398c2e3e509381ajeffhao } 102210037c866b04550fc5461058c398c2e3e509381ajeffhao 102310037c866b04550fc5461058c398c2e3e509381ajeffhao last_idx = 0; 102410037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < parameter_count; i++) { 10258d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(last_idx >= parameter_item->method_idx_ && i != 0)) { 10268d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order method_idx for annotation: %x then %x", 10278d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers last_idx, parameter_item->method_idx_); 102810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 102910037c866b04550fc5461058c398c2e3e509381ajeffhao } 103010037c866b04550fc5461058c398c2e3e509381ajeffhao last_idx = parameter_item->method_idx_; 103110037c866b04550fc5461058c398c2e3e509381ajeffhao parameter_item++; 103210037c866b04550fc5461058c398c2e3e509381ajeffhao } 103310037c866b04550fc5461058c398c2e3e509381ajeffhao 103410037c866b04550fc5461058c398c2e3e509381ajeffhao // Return a pointer to the end of the annotations. 103510037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = reinterpret_cast<const byte*>(parameter_item); 103610037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 103710037c866b04550fc5461058c398c2e3e509381ajeffhao} 103810037c866b04550fc5461058c398c2e3e509381ajeffhao 10398a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogersbool DexFileVerifier::CheckIntraSectionIterate(size_t offset, uint32_t count, uint16_t type) { 104010037c866b04550fc5461058c398c2e3e509381ajeffhao // Get the right alignment mask for the type of section. 10418a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers size_t alignment_mask; 104210037c866b04550fc5461058c398c2e3e509381ajeffhao switch (type) { 104310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDataItem: 104410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringDataItem: 104510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeDebugInfoItem: 104610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationItem: 104710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeEncodedArrayItem: 104810037c866b04550fc5461058c398c2e3e509381ajeffhao alignment_mask = sizeof(uint8_t) - 1; 104910037c866b04550fc5461058c398c2e3e509381ajeffhao break; 105010037c866b04550fc5461058c398c2e3e509381ajeffhao default: 105110037c866b04550fc5461058c398c2e3e509381ajeffhao alignment_mask = sizeof(uint32_t) - 1; 105210037c866b04550fc5461058c398c2e3e509381ajeffhao break; 105310037c866b04550fc5461058c398c2e3e509381ajeffhao } 105410037c866b04550fc5461058c398c2e3e509381ajeffhao 105510037c866b04550fc5461058c398c2e3e509381ajeffhao // Iterate through the items in the section. 105610037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < count; i++) { 10578a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers size_t aligned_offset = (offset + alignment_mask) & ~alignment_mask; 105810037c866b04550fc5461058c398c2e3e509381ajeffhao 105910037c866b04550fc5461058c398c2e3e509381ajeffhao // Check the padding between items. 106010037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPadding(offset, aligned_offset)) { 106110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 106210037c866b04550fc5461058c398c2e3e509381ajeffhao } 106310037c866b04550fc5461058c398c2e3e509381ajeffhao 106410037c866b04550fc5461058c398c2e3e509381ajeffhao // Check depending on the section type. 106510037c866b04550fc5461058c398c2e3e509381ajeffhao switch (type) { 106610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringIdItem: { 106710037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(ptr_, ptr_ + sizeof(DexFile::StringId), "string_ids")) { 106810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 106910037c866b04550fc5461058c398c2e3e509381ajeffhao } 107010037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::StringId); 107110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 107210037c866b04550fc5461058c398c2e3e509381ajeffhao } 107310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeIdItem: { 107410037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(ptr_, ptr_ + sizeof(DexFile::TypeId), "type_ids")) { 107510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 107610037c866b04550fc5461058c398c2e3e509381ajeffhao } 107710037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::TypeId); 107810037c866b04550fc5461058c398c2e3e509381ajeffhao break; 107910037c866b04550fc5461058c398c2e3e509381ajeffhao } 108010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeProtoIdItem: { 108110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(ptr_, ptr_ + sizeof(DexFile::ProtoId), "proto_ids")) { 108210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 108310037c866b04550fc5461058c398c2e3e509381ajeffhao } 108410037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::ProtoId); 108510037c866b04550fc5461058c398c2e3e509381ajeffhao break; 108610037c866b04550fc5461058c398c2e3e509381ajeffhao } 108710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeFieldIdItem: { 108810037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(ptr_, ptr_ + sizeof(DexFile::FieldId), "field_ids")) { 108910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 109010037c866b04550fc5461058c398c2e3e509381ajeffhao } 109110037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::FieldId); 109210037c866b04550fc5461058c398c2e3e509381ajeffhao break; 109310037c866b04550fc5461058c398c2e3e509381ajeffhao } 109410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMethodIdItem: { 109510037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(ptr_, ptr_ + sizeof(DexFile::MethodId), "method_ids")) { 109610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 109710037c866b04550fc5461058c398c2e3e509381ajeffhao } 109810037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::MethodId); 109910037c866b04550fc5461058c398c2e3e509381ajeffhao break; 110010037c866b04550fc5461058c398c2e3e509381ajeffhao } 110110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDefItem: { 110210037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(ptr_, ptr_ + sizeof(DexFile::ClassDef), "class_defs")) { 110310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 110410037c866b04550fc5461058c398c2e3e509381ajeffhao } 110510037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::ClassDef); 110610037c866b04550fc5461058c398c2e3e509381ajeffhao break; 110710037c866b04550fc5461058c398c2e3e509381ajeffhao } 110810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeList: { 110910037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::TypeList* list = reinterpret_cast<const DexFile::TypeList*>(ptr_); 111010037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::TypeItem* item = &list->GetTypeItem(0); 111110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t count = list->Size(); 111210037c866b04550fc5461058c398c2e3e509381ajeffhao 111310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(list, list + 1, "type_list") || 111410037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckListSize(item, count, sizeof(DexFile::TypeItem), "type_list size")) { 111510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 111610037c866b04550fc5461058c398c2e3e509381ajeffhao } 111710037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = reinterpret_cast<const byte*>(item + count); 111810037c866b04550fc5461058c398c2e3e509381ajeffhao break; 111910037c866b04550fc5461058c398c2e3e509381ajeffhao } 112010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetRefList: { 112110037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationSetRefList* list = 112210037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::AnnotationSetRefList*>(ptr_); 112310037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationSetRefItem* item = list->list_; 112410037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t count = list->size_; 112510037c866b04550fc5461058c398c2e3e509381ajeffhao 112610037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(list, list + 1, "annotation_set_ref_list") || 11272b87ddf36abff711fa2233c49bffc7ceb03b15d7Dragos Sbirlea !CheckListSize(item, count, sizeof(DexFile::AnnotationSetRefItem), 11288d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers "annotation_set_ref_list size")) { 112910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 113010037c866b04550fc5461058c398c2e3e509381ajeffhao } 113110037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = reinterpret_cast<const byte*>(item + count); 113210037c866b04550fc5461058c398c2e3e509381ajeffhao break; 113310037c866b04550fc5461058c398c2e3e509381ajeffhao } 113410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetItem: { 113510037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationSetItem* set = 113610037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::AnnotationSetItem*>(ptr_); 113710037c866b04550fc5461058c398c2e3e509381ajeffhao const uint32_t* item = set->entries_; 113810037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t count = set->size_; 113910037c866b04550fc5461058c398c2e3e509381ajeffhao 114010037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPointerRange(set, set + 1, "annotation_set_item") || 114110037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckListSize(item, count, sizeof(uint32_t), "annotation_set_item size")) { 114210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 114310037c866b04550fc5461058c398c2e3e509381ajeffhao } 114410037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = reinterpret_cast<const byte*>(item + count); 114510037c866b04550fc5461058c398c2e3e509381ajeffhao break; 114610037c866b04550fc5461058c398c2e3e509381ajeffhao } 114710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDataItem: { 114810037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraClassDataItem()) { 114910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 115010037c866b04550fc5461058c398c2e3e509381ajeffhao } 115110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 115210037c866b04550fc5461058c398c2e3e509381ajeffhao } 115310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeCodeItem: { 115410037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraCodeItem()) { 115510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 115610037c866b04550fc5461058c398c2e3e509381ajeffhao } 115710037c866b04550fc5461058c398c2e3e509381ajeffhao break; 115810037c866b04550fc5461058c398c2e3e509381ajeffhao } 115910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringDataItem: { 116010037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraStringDataItem()) { 116110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 116210037c866b04550fc5461058c398c2e3e509381ajeffhao } 116310037c866b04550fc5461058c398c2e3e509381ajeffhao break; 116410037c866b04550fc5461058c398c2e3e509381ajeffhao } 116510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeDebugInfoItem: { 116610037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraDebugInfoItem()) { 116710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 116810037c866b04550fc5461058c398c2e3e509381ajeffhao } 116910037c866b04550fc5461058c398c2e3e509381ajeffhao break; 117010037c866b04550fc5461058c398c2e3e509381ajeffhao } 117110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationItem: { 117210037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraAnnotationItem()) { 117310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 117410037c866b04550fc5461058c398c2e3e509381ajeffhao } 117510037c866b04550fc5461058c398c2e3e509381ajeffhao break; 117610037c866b04550fc5461058c398c2e3e509381ajeffhao } 117710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeEncodedArrayItem: { 117810037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckEncodedArray()) { 117910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 118010037c866b04550fc5461058c398c2e3e509381ajeffhao } 118110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 118210037c866b04550fc5461058c398c2e3e509381ajeffhao } 118310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationsDirectoryItem: { 118410037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraAnnotationsDirectoryItem()) { 118510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 118610037c866b04550fc5461058c398c2e3e509381ajeffhao } 118710037c866b04550fc5461058c398c2e3e509381ajeffhao break; 118810037c866b04550fc5461058c398c2e3e509381ajeffhao } 118910037c866b04550fc5461058c398c2e3e509381ajeffhao default: 11908d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Unknown map item type %x", type); 119110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 119210037c866b04550fc5461058c398c2e3e509381ajeffhao } 119310037c866b04550fc5461058c398c2e3e509381ajeffhao 119410037c866b04550fc5461058c398c2e3e509381ajeffhao if (IsDataSectionType(type)) { 1195a0e180632411f7fe0edf454e571c42209ee7b540Elliott Hughes offset_to_type_map_.Put(aligned_offset, type); 119610037c866b04550fc5461058c398c2e3e509381ajeffhao } 119710037c866b04550fc5461058c398c2e3e509381ajeffhao 11988a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers aligned_offset = ptr_ - begin_; 11998d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(aligned_offset > size_)) { 12008d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Item %d at ends out of bounds", i); 120110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 120210037c866b04550fc5461058c398c2e3e509381ajeffhao } 120310037c866b04550fc5461058c398c2e3e509381ajeffhao 120410037c866b04550fc5461058c398c2e3e509381ajeffhao offset = aligned_offset; 120510037c866b04550fc5461058c398c2e3e509381ajeffhao } 120610037c866b04550fc5461058c398c2e3e509381ajeffhao 120710037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 120810037c866b04550fc5461058c398c2e3e509381ajeffhao} 120910037c866b04550fc5461058c398c2e3e509381ajeffhao 12108a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogersbool DexFileVerifier::CheckIntraIdSection(size_t offset, uint32_t count, uint16_t type) { 121110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t expected_offset; 121210037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t expected_size; 121310037c866b04550fc5461058c398c2e3e509381ajeffhao 121410037c866b04550fc5461058c398c2e3e509381ajeffhao // Get the expected offset and size from the header. 121510037c866b04550fc5461058c398c2e3e509381ajeffhao switch (type) { 121610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringIdItem: 121710037c866b04550fc5461058c398c2e3e509381ajeffhao expected_offset = header_->string_ids_off_; 121810037c866b04550fc5461058c398c2e3e509381ajeffhao expected_size = header_->string_ids_size_; 121910037c866b04550fc5461058c398c2e3e509381ajeffhao break; 122010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeIdItem: 122110037c866b04550fc5461058c398c2e3e509381ajeffhao expected_offset = header_->type_ids_off_; 122210037c866b04550fc5461058c398c2e3e509381ajeffhao expected_size = header_->type_ids_size_; 122310037c866b04550fc5461058c398c2e3e509381ajeffhao break; 122410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeProtoIdItem: 122510037c866b04550fc5461058c398c2e3e509381ajeffhao expected_offset = header_->proto_ids_off_; 122610037c866b04550fc5461058c398c2e3e509381ajeffhao expected_size = header_->proto_ids_size_; 122710037c866b04550fc5461058c398c2e3e509381ajeffhao break; 122810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeFieldIdItem: 122910037c866b04550fc5461058c398c2e3e509381ajeffhao expected_offset = header_->field_ids_off_; 123010037c866b04550fc5461058c398c2e3e509381ajeffhao expected_size = header_->field_ids_size_; 123110037c866b04550fc5461058c398c2e3e509381ajeffhao break; 123210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMethodIdItem: 123310037c866b04550fc5461058c398c2e3e509381ajeffhao expected_offset = header_->method_ids_off_; 123410037c866b04550fc5461058c398c2e3e509381ajeffhao expected_size = header_->method_ids_size_; 123510037c866b04550fc5461058c398c2e3e509381ajeffhao break; 123610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDefItem: 123710037c866b04550fc5461058c398c2e3e509381ajeffhao expected_offset = header_->class_defs_off_; 123810037c866b04550fc5461058c398c2e3e509381ajeffhao expected_size = header_->class_defs_size_; 123910037c866b04550fc5461058c398c2e3e509381ajeffhao break; 124010037c866b04550fc5461058c398c2e3e509381ajeffhao default: 12418d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad type for id section: %x", type); 124210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 124310037c866b04550fc5461058c398c2e3e509381ajeffhao } 124410037c866b04550fc5461058c398c2e3e509381ajeffhao 124510037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that the offset and size are what were expected from the header. 12468d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(offset != expected_offset)) { 12478a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers ErrorStringPrintf("Bad offset for section: got %zx, expected %x", offset, expected_offset); 124810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 124910037c866b04550fc5461058c398c2e3e509381ajeffhao } 12508d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(count != expected_size)) { 12518d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Bad size for section: got %x, expected %x", count, expected_size); 125210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 125310037c866b04550fc5461058c398c2e3e509381ajeffhao } 125410037c866b04550fc5461058c398c2e3e509381ajeffhao 125510037c866b04550fc5461058c398c2e3e509381ajeffhao return CheckIntraSectionIterate(offset, count, type); 125610037c866b04550fc5461058c398c2e3e509381ajeffhao} 125710037c866b04550fc5461058c398c2e3e509381ajeffhao 12588a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogersbool DexFileVerifier::CheckIntraDataSection(size_t offset, uint32_t count, uint16_t type) { 12598a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers size_t data_start = header_->data_off_; 12608a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers size_t data_end = data_start + header_->data_size_; 126110037c866b04550fc5461058c398c2e3e509381ajeffhao 126210037c866b04550fc5461058c398c2e3e509381ajeffhao // Sanity check the offset of the section. 12638d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((offset < data_start) || (offset > data_end))) { 12648a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers ErrorStringPrintf("Bad offset for data subsection: %zx", offset); 126510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 126610037c866b04550fc5461058c398c2e3e509381ajeffhao } 126710037c866b04550fc5461058c398c2e3e509381ajeffhao 126810037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraSectionIterate(offset, count, type)) { 126910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 127010037c866b04550fc5461058c398c2e3e509381ajeffhao } 127110037c866b04550fc5461058c398c2e3e509381ajeffhao 12728a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers size_t next_offset = ptr_ - begin_; 127310037c866b04550fc5461058c398c2e3e509381ajeffhao if (next_offset > data_end) { 12748a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers ErrorStringPrintf("Out-of-bounds end of data subsection: %zx", next_offset); 127510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 127610037c866b04550fc5461058c398c2e3e509381ajeffhao } 127710037c866b04550fc5461058c398c2e3e509381ajeffhao 127810037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 127910037c866b04550fc5461058c398c2e3e509381ajeffhao} 128010037c866b04550fc5461058c398c2e3e509381ajeffhao 128110037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckIntraSection() { 128230fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers const DexFile::MapList* map = reinterpret_cast<const DexFile::MapList*>(begin_ + header_->map_off_); 128310037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::MapItem* item = map->list_; 128410037c866b04550fc5461058c398c2e3e509381ajeffhao 128510037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t count = map->size_; 12868a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers size_t offset = 0; 128730fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers ptr_ = begin_; 128810037c866b04550fc5461058c398c2e3e509381ajeffhao 128910037c866b04550fc5461058c398c2e3e509381ajeffhao // Check the items listed in the map. 129010037c866b04550fc5461058c398c2e3e509381ajeffhao while (count--) { 129110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t section_offset = item->offset_; 129210037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t section_count = item->size_; 129310037c866b04550fc5461058c398c2e3e509381ajeffhao uint16_t type = item->type_; 129410037c866b04550fc5461058c398c2e3e509381ajeffhao 129510037c866b04550fc5461058c398c2e3e509381ajeffhao // Check for padding and overlap between items. 129610037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckPadding(offset, section_offset)) { 129710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 12988d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers } else if (UNLIKELY(offset > section_offset)) { 12998a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers ErrorStringPrintf("Section overlap or out-of-order map: %zx, %x", offset, section_offset); 130010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 130110037c866b04550fc5461058c398c2e3e509381ajeffhao } 130210037c866b04550fc5461058c398c2e3e509381ajeffhao 130310037c866b04550fc5461058c398c2e3e509381ajeffhao // Check each item based on its type. 130410037c866b04550fc5461058c398c2e3e509381ajeffhao switch (type) { 130510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeHeaderItem: 13068d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(section_count != 1)) { 13078d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Multiple header items"); 130810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 130910037c866b04550fc5461058c398c2e3e509381ajeffhao } 13108d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(section_offset != 0)) { 13118d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Header at %x, not at start of file", section_offset); 131210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 131310037c866b04550fc5461058c398c2e3e509381ajeffhao } 131430fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers ptr_ = begin_ + header_->header_size_; 131510037c866b04550fc5461058c398c2e3e509381ajeffhao offset = header_->header_size_; 131610037c866b04550fc5461058c398c2e3e509381ajeffhao break; 131710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringIdItem: 131810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeIdItem: 131910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeProtoIdItem: 132010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeFieldIdItem: 132110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMethodIdItem: 132210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDefItem: 132310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraIdSection(section_offset, section_count, type)) { 132410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 132510037c866b04550fc5461058c398c2e3e509381ajeffhao } 13268a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers offset = ptr_ - begin_; 132710037c866b04550fc5461058c398c2e3e509381ajeffhao break; 132810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMapList: 13298d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(section_count != 1)) { 13308d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Multiple map list items"); 133110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 133210037c866b04550fc5461058c398c2e3e509381ajeffhao } 13338d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(section_offset != header_->map_off_)) { 13348d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Map not at header-defined offset: %x, expected %x", 13358d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers section_offset, header_->map_off_); 133610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 133710037c866b04550fc5461058c398c2e3e509381ajeffhao } 133810037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(uint32_t) + (map->size_ * sizeof(DexFile::MapItem)); 133910037c866b04550fc5461058c398c2e3e509381ajeffhao offset = section_offset + sizeof(uint32_t) + (map->size_ * sizeof(DexFile::MapItem)); 134010037c866b04550fc5461058c398c2e3e509381ajeffhao break; 134110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeList: 134210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetRefList: 134310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetItem: 134410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDataItem: 134510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeCodeItem: 134610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringDataItem: 134710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeDebugInfoItem: 134810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationItem: 134910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeEncodedArrayItem: 135010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationsDirectoryItem: 135110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraDataSection(section_offset, section_count, type)) { 135210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 135310037c866b04550fc5461058c398c2e3e509381ajeffhao } 13548a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers offset = ptr_ - begin_; 135510037c866b04550fc5461058c398c2e3e509381ajeffhao break; 135610037c866b04550fc5461058c398c2e3e509381ajeffhao default: 13578d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Unknown map item type %x", type); 135810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 135910037c866b04550fc5461058c398c2e3e509381ajeffhao } 136010037c866b04550fc5461058c398c2e3e509381ajeffhao 136110037c866b04550fc5461058c398c2e3e509381ajeffhao item++; 136210037c866b04550fc5461058c398c2e3e509381ajeffhao } 136310037c866b04550fc5461058c398c2e3e509381ajeffhao 136410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 136510037c866b04550fc5461058c398c2e3e509381ajeffhao} 136610037c866b04550fc5461058c398c2e3e509381ajeffhao 13678a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogersbool DexFileVerifier::CheckOffsetToTypeMap(size_t offset, uint16_t type) { 136802e25119b15a6f619f17db99f5d05124a5807ff3Mathieu Chartier auto it = offset_to_type_map_.find(offset); 13698d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(it == offset_to_type_map_.end())) { 13708a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers ErrorStringPrintf("No data map entry found @ %zx; expected %x", offset, type); 137110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 137210037c866b04550fc5461058c398c2e3e509381ajeffhao } 13738d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(it->second != type)) { 13748a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers ErrorStringPrintf("Unexpected data map entry @ %zx; expected %x, found %x", 13758d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers offset, type, it->second); 137610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 137710037c866b04550fc5461058c398c2e3e509381ajeffhao } 137810037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 137910037c866b04550fc5461058c398c2e3e509381ajeffhao} 138010037c866b04550fc5461058c398c2e3e509381ajeffhao 13815e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampeuint16_t DexFileVerifier::FindFirstClassDataDefiner(const byte* ptr, bool* success) { 138210037c866b04550fc5461058c398c2e3e509381ajeffhao ClassDataItemIterator it(*dex_file_, ptr); 13835e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe *success = true; 138410037c866b04550fc5461058c398c2e3e509381ajeffhao 138510037c866b04550fc5461058c398c2e3e509381ajeffhao if (it.HasNextStaticField() || it.HasNextInstanceField()) { 13865e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe LOAD_FIELD(field, it.GetMemberIndex(), "first_class_data_definer field_id", 13875e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe *success = false; return DexFile::kDexNoIndex16) 1388e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return field->class_idx_; 138910037c866b04550fc5461058c398c2e3e509381ajeffhao } 139010037c866b04550fc5461058c398c2e3e509381ajeffhao 139110037c866b04550fc5461058c398c2e3e509381ajeffhao if (it.HasNextDirectMethod() || it.HasNextVirtualMethod()) { 13925e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe LOAD_METHOD(method, it.GetMemberIndex(), "first_class_data_definer method_id", 13935e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe *success = false; return DexFile::kDexNoIndex16) 1394e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return method->class_idx_; 139510037c866b04550fc5461058c398c2e3e509381ajeffhao } 139610037c866b04550fc5461058c398c2e3e509381ajeffhao 139710037c866b04550fc5461058c398c2e3e509381ajeffhao return DexFile::kDexNoIndex16; 139810037c866b04550fc5461058c398c2e3e509381ajeffhao} 139910037c866b04550fc5461058c398c2e3e509381ajeffhao 14005e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampeuint16_t DexFileVerifier::FindFirstAnnotationsDirectoryDefiner(const byte* ptr, bool* success) { 140110037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationsDirectoryItem* item = 140210037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::AnnotationsDirectoryItem*>(ptr); 14035e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe *success = true; 14045e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe 140510037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->fields_size_ != 0) { 140610037c866b04550fc5461058c398c2e3e509381ajeffhao DexFile::FieldAnnotationsItem* field_items = (DexFile::FieldAnnotationsItem*) (item + 1); 14075e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe LOAD_FIELD(field, field_items[0].field_idx_, "first_annotations_dir_definer field_id", 14085e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe *success = false; return DexFile::kDexNoIndex16) 1409e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return field->class_idx_; 141010037c866b04550fc5461058c398c2e3e509381ajeffhao } 141110037c866b04550fc5461058c398c2e3e509381ajeffhao 141210037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->methods_size_ != 0) { 141310037c866b04550fc5461058c398c2e3e509381ajeffhao DexFile::MethodAnnotationsItem* method_items = (DexFile::MethodAnnotationsItem*) (item + 1); 1414e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_METHOD(method, method_items[0].method_idx_, "first_annotations_dir_definer method id", 14155e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe *success = false; return DexFile::kDexNoIndex16) 1416e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return method->class_idx_; 141710037c866b04550fc5461058c398c2e3e509381ajeffhao } 141810037c866b04550fc5461058c398c2e3e509381ajeffhao 141910037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->parameters_size_ != 0) { 142010037c866b04550fc5461058c398c2e3e509381ajeffhao DexFile::ParameterAnnotationsItem* parameter_items = (DexFile::ParameterAnnotationsItem*) (item + 1); 1421e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_METHOD(method, parameter_items[0].method_idx_, "first_annotations_dir_definer method id", 14225e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe *success = false; return DexFile::kDexNoIndex16) 1423e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return method->class_idx_; 142410037c866b04550fc5461058c398c2e3e509381ajeffhao } 142510037c866b04550fc5461058c398c2e3e509381ajeffhao 142610037c866b04550fc5461058c398c2e3e509381ajeffhao return DexFile::kDexNoIndex16; 142710037c866b04550fc5461058c398c2e3e509381ajeffhao} 142810037c866b04550fc5461058c398c2e3e509381ajeffhao 142910037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterStringIdItem() { 143010037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::StringId* item = reinterpret_cast<const DexFile::StringId*>(ptr_); 143110037c866b04550fc5461058c398c2e3e509381ajeffhao 143210037c866b04550fc5461058c398c2e3e509381ajeffhao // Check the map to make sure it has the right offset->type. 143310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckOffsetToTypeMap(item->string_data_off_, DexFile::kDexTypeStringDataItem)) { 143410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 143510037c866b04550fc5461058c398c2e3e509381ajeffhao } 143610037c866b04550fc5461058c398c2e3e509381ajeffhao 143710037c866b04550fc5461058c398c2e3e509381ajeffhao // Check ordering between items. 143810037c866b04550fc5461058c398c2e3e509381ajeffhao if (previous_item_ != NULL) { 143910037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::StringId* prev_item = reinterpret_cast<const DexFile::StringId*>(previous_item_); 144010037c866b04550fc5461058c398c2e3e509381ajeffhao const char* prev_str = dex_file_->GetStringData(*prev_item); 144110037c866b04550fc5461058c398c2e3e509381ajeffhao const char* str = dex_file_->GetStringData(*item); 14428d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(CompareModifiedUtf8ToModifiedUtf8AsUtf16CodePointValues(prev_str, str) >= 0)) { 14438d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order string_ids: '%s' then '%s'", prev_str, str); 144410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 144510037c866b04550fc5461058c398c2e3e509381ajeffhao } 144610037c866b04550fc5461058c398c2e3e509381ajeffhao } 144710037c866b04550fc5461058c398c2e3e509381ajeffhao 144810037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::StringId); 144910037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 145010037c866b04550fc5461058c398c2e3e509381ajeffhao} 145110037c866b04550fc5461058c398c2e3e509381ajeffhao 145210037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterTypeIdItem() { 145310037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::TypeId* item = reinterpret_cast<const DexFile::TypeId*>(ptr_); 1454e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 1455e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING(descriptor, item->descriptor_idx_, "inter_type_id_item descriptor_idx") 145610037c866b04550fc5461058c398c2e3e509381ajeffhao 145710037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that the descriptor is a valid type. 14588d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(!IsValidDescriptor(descriptor))) { 14598d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid type descriptor: '%s'", descriptor); 146010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 146110037c866b04550fc5461058c398c2e3e509381ajeffhao } 146210037c866b04550fc5461058c398c2e3e509381ajeffhao 146310037c866b04550fc5461058c398c2e3e509381ajeffhao // Check ordering between items. 146410037c866b04550fc5461058c398c2e3e509381ajeffhao if (previous_item_ != NULL) { 146510037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::TypeId* prev_item = reinterpret_cast<const DexFile::TypeId*>(previous_item_); 14668d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(prev_item->descriptor_idx_ >= item->descriptor_idx_)) { 14678d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order type_ids: %x then %x", 14688d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers prev_item->descriptor_idx_, item->descriptor_idx_); 146910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 147010037c866b04550fc5461058c398c2e3e509381ajeffhao } 147110037c866b04550fc5461058c398c2e3e509381ajeffhao } 147210037c866b04550fc5461058c398c2e3e509381ajeffhao 147310037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::TypeId); 147410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 147510037c866b04550fc5461058c398c2e3e509381ajeffhao} 147610037c866b04550fc5461058c398c2e3e509381ajeffhao 147710037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterProtoIdItem() { 147810037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::ProtoId* item = reinterpret_cast<const DexFile::ProtoId*>(ptr_); 1479e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 1480e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING(shorty, item->shorty_idx_, "inter_proto_id_item shorty_idx") 1481e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe 148210037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->parameters_off_ != 0 && 148310037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckOffsetToTypeMap(item->parameters_off_, DexFile::kDexTypeTypeList)) { 148410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 148510037c866b04550fc5461058c398c2e3e509381ajeffhao } 148610037c866b04550fc5461058c398c2e3e509381ajeffhao 148710037c866b04550fc5461058c398c2e3e509381ajeffhao // Check the return type and advance the shorty. 1488e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING_BY_TYPE(return_type, item->return_type_idx_, "inter_proto_id_item return_type_idx") 1489e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (!CheckShortyDescriptorMatch(*shorty, return_type, true)) { 149010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 149110037c866b04550fc5461058c398c2e3e509381ajeffhao } 149210037c866b04550fc5461058c398c2e3e509381ajeffhao shorty++; 149310037c866b04550fc5461058c398c2e3e509381ajeffhao 149410037c866b04550fc5461058c398c2e3e509381ajeffhao DexFileParameterIterator it(*dex_file_, *item); 149510037c866b04550fc5461058c398c2e3e509381ajeffhao while (it.HasNext() && *shorty != '\0') { 1496bb836e14541d5424328182f3e20ce08c691d041eAndreas Gampe if (!CheckIndex(it.GetTypeIdx(), dex_file_->NumTypeIds(), 1497bb836e14541d5424328182f3e20ce08c691d041eAndreas Gampe "inter_proto_id_item shorty type_idx")) { 1498bb836e14541d5424328182f3e20ce08c691d041eAndreas Gampe return false; 1499bb836e14541d5424328182f3e20ce08c691d041eAndreas Gampe } 150010037c866b04550fc5461058c398c2e3e509381ajeffhao const char* descriptor = it.GetDescriptor(); 150110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckShortyDescriptorMatch(*shorty, descriptor, false)) { 150210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 150310037c866b04550fc5461058c398c2e3e509381ajeffhao } 150410037c866b04550fc5461058c398c2e3e509381ajeffhao it.Next(); 150510037c866b04550fc5461058c398c2e3e509381ajeffhao shorty++; 150610037c866b04550fc5461058c398c2e3e509381ajeffhao } 15078d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(it.HasNext() || *shorty != '\0')) { 15088d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Mismatched length for parameters and shorty"); 150910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 151010037c866b04550fc5461058c398c2e3e509381ajeffhao } 151110037c866b04550fc5461058c398c2e3e509381ajeffhao 151210037c866b04550fc5461058c398c2e3e509381ajeffhao // Check ordering between items. This relies on type_ids being in order. 151310037c866b04550fc5461058c398c2e3e509381ajeffhao if (previous_item_ != NULL) { 151410037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::ProtoId* prev = reinterpret_cast<const DexFile::ProtoId*>(previous_item_); 15158d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(prev->return_type_idx_ > item->return_type_idx_)) { 15168d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order proto_id return types"); 151710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 151810037c866b04550fc5461058c398c2e3e509381ajeffhao } else if (prev->return_type_idx_ == item->return_type_idx_) { 151910037c866b04550fc5461058c398c2e3e509381ajeffhao DexFileParameterIterator curr_it(*dex_file_, *item); 152010037c866b04550fc5461058c398c2e3e509381ajeffhao DexFileParameterIterator prev_it(*dex_file_, *prev); 152110037c866b04550fc5461058c398c2e3e509381ajeffhao 152210037c866b04550fc5461058c398c2e3e509381ajeffhao while (curr_it.HasNext() && prev_it.HasNext()) { 152310037c866b04550fc5461058c398c2e3e509381ajeffhao uint16_t prev_idx = prev_it.GetTypeIdx(); 152410037c866b04550fc5461058c398c2e3e509381ajeffhao uint16_t curr_idx = curr_it.GetTypeIdx(); 152510037c866b04550fc5461058c398c2e3e509381ajeffhao if (prev_idx == DexFile::kDexNoIndex16) { 152610037c866b04550fc5461058c398c2e3e509381ajeffhao break; 152710037c866b04550fc5461058c398c2e3e509381ajeffhao } 15288d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(curr_idx == DexFile::kDexNoIndex16)) { 15298d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order proto_id arguments"); 153010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 153110037c866b04550fc5461058c398c2e3e509381ajeffhao } 153210037c866b04550fc5461058c398c2e3e509381ajeffhao 153310037c866b04550fc5461058c398c2e3e509381ajeffhao if (prev_idx < curr_idx) { 153410037c866b04550fc5461058c398c2e3e509381ajeffhao break; 15358d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers } else if (UNLIKELY(prev_idx > curr_idx)) { 15368d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order proto_id arguments"); 153710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 153810037c866b04550fc5461058c398c2e3e509381ajeffhao } 153910037c866b04550fc5461058c398c2e3e509381ajeffhao 154010037c866b04550fc5461058c398c2e3e509381ajeffhao prev_it.Next(); 154110037c866b04550fc5461058c398c2e3e509381ajeffhao curr_it.Next(); 154210037c866b04550fc5461058c398c2e3e509381ajeffhao } 154310037c866b04550fc5461058c398c2e3e509381ajeffhao } 154410037c866b04550fc5461058c398c2e3e509381ajeffhao } 154510037c866b04550fc5461058c398c2e3e509381ajeffhao 154610037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::ProtoId); 154710037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 154810037c866b04550fc5461058c398c2e3e509381ajeffhao} 154910037c866b04550fc5461058c398c2e3e509381ajeffhao 155010037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterFieldIdItem() { 155110037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::FieldId* item = reinterpret_cast<const DexFile::FieldId*>(ptr_); 155210037c866b04550fc5461058c398c2e3e509381ajeffhao 155310037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that the class descriptor is valid. 1554e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING_BY_TYPE(class_descriptor, item->class_idx_, "inter_field_id_item class_idx") 1555e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(!IsValidDescriptor(class_descriptor) || class_descriptor[0] != 'L')) { 1556e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe ErrorStringPrintf("Invalid descriptor for class_idx: '%s'", class_descriptor); 155710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 155810037c866b04550fc5461058c398c2e3e509381ajeffhao } 155910037c866b04550fc5461058c398c2e3e509381ajeffhao 156010037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that the type descriptor is a valid field name. 1561e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING_BY_TYPE(type_descriptor, item->type_idx_, "inter_field_id_item type_idx") 1562e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(!IsValidDescriptor(type_descriptor) || type_descriptor[0] == 'V')) { 1563e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe ErrorStringPrintf("Invalid descriptor for type_idx: '%s'", type_descriptor); 156410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 156510037c866b04550fc5461058c398c2e3e509381ajeffhao } 156610037c866b04550fc5461058c398c2e3e509381ajeffhao 156710037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that the name is valid. 1568e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING(descriptor, item->name_idx_, "inter_field_id_item name_idx") 15698d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(!IsValidMemberName(descriptor))) { 15708d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid field name: '%s'", descriptor); 157110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 157210037c866b04550fc5461058c398c2e3e509381ajeffhao } 157310037c866b04550fc5461058c398c2e3e509381ajeffhao 157410037c866b04550fc5461058c398c2e3e509381ajeffhao // Check ordering between items. This relies on the other sections being in order. 157510037c866b04550fc5461058c398c2e3e509381ajeffhao if (previous_item_ != NULL) { 157610037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::FieldId* prev_item = reinterpret_cast<const DexFile::FieldId*>(previous_item_); 15778d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(prev_item->class_idx_ > item->class_idx_)) { 15788d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order field_ids"); 157910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 158010037c866b04550fc5461058c398c2e3e509381ajeffhao } else if (prev_item->class_idx_ == item->class_idx_) { 15818d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(prev_item->name_idx_ > item->name_idx_)) { 15828d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order field_ids"); 158310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 158410037c866b04550fc5461058c398c2e3e509381ajeffhao } else if (prev_item->name_idx_ == item->name_idx_) { 15858d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(prev_item->type_idx_ >= item->type_idx_)) { 15868d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order field_ids"); 158710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 158810037c866b04550fc5461058c398c2e3e509381ajeffhao } 158910037c866b04550fc5461058c398c2e3e509381ajeffhao } 159010037c866b04550fc5461058c398c2e3e509381ajeffhao } 159110037c866b04550fc5461058c398c2e3e509381ajeffhao } 159210037c866b04550fc5461058c398c2e3e509381ajeffhao 159310037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::FieldId); 159410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 159510037c866b04550fc5461058c398c2e3e509381ajeffhao} 159610037c866b04550fc5461058c398c2e3e509381ajeffhao 159710037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterMethodIdItem() { 159810037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::MethodId* item = reinterpret_cast<const DexFile::MethodId*>(ptr_); 159910037c866b04550fc5461058c398c2e3e509381ajeffhao 160010037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that the class descriptor is a valid reference name. 1601e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING_BY_TYPE(class_descriptor, item->class_idx_, "inter_method_id_item class_idx") 1602e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(!IsValidDescriptor(class_descriptor) || (class_descriptor[0] != 'L' && 1603e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe class_descriptor[0] != '['))) { 1604e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe ErrorStringPrintf("Invalid descriptor for class_idx: '%s'", class_descriptor); 160510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 160610037c866b04550fc5461058c398c2e3e509381ajeffhao } 160710037c866b04550fc5461058c398c2e3e509381ajeffhao 160810037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that the name is valid. 1609df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe LOAD_STRING(descriptor, item->name_idx_, "inter_method_id_item name_idx") 16108d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(!IsValidMemberName(descriptor))) { 16118d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid method name: '%s'", descriptor); 161210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 161310037c866b04550fc5461058c398c2e3e509381ajeffhao } 161410037c866b04550fc5461058c398c2e3e509381ajeffhao 1615df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe // Check that the proto id is valid. 1616df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe if (UNLIKELY(!CheckIndex(item->proto_idx_, dex_file_->NumProtoIds(), 1617df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe "inter_method_id_item proto_idx"))) { 1618df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe return false; 1619df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe } 1620df10b32c4d0adfa86201169692eaa7ef038b642cAndreas Gampe 162110037c866b04550fc5461058c398c2e3e509381ajeffhao // Check ordering between items. This relies on the other sections being in order. 162210037c866b04550fc5461058c398c2e3e509381ajeffhao if (previous_item_ != NULL) { 162310037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::MethodId* prev_item = reinterpret_cast<const DexFile::MethodId*>(previous_item_); 16248d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(prev_item->class_idx_ > item->class_idx_)) { 16258d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order method_ids"); 162610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 162710037c866b04550fc5461058c398c2e3e509381ajeffhao } else if (prev_item->class_idx_ == item->class_idx_) { 16288d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(prev_item->name_idx_ > item->name_idx_)) { 16298d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order method_ids"); 163010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 163110037c866b04550fc5461058c398c2e3e509381ajeffhao } else if (prev_item->name_idx_ == item->name_idx_) { 16328d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(prev_item->proto_idx_ >= item->proto_idx_)) { 16338d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order method_ids"); 163410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 163510037c866b04550fc5461058c398c2e3e509381ajeffhao } 163610037c866b04550fc5461058c398c2e3e509381ajeffhao } 163710037c866b04550fc5461058c398c2e3e509381ajeffhao } 163810037c866b04550fc5461058c398c2e3e509381ajeffhao } 163910037c866b04550fc5461058c398c2e3e509381ajeffhao 164010037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::MethodId); 164110037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 164210037c866b04550fc5461058c398c2e3e509381ajeffhao} 164310037c866b04550fc5461058c398c2e3e509381ajeffhao 164410037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterClassDefItem() { 164510037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::ClassDef* item = reinterpret_cast<const DexFile::ClassDef*>(ptr_); 164610037c866b04550fc5461058c398c2e3e509381ajeffhao 1647e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING_BY_TYPE(class_descriptor, item->class_idx_, "inter_class_def_item class_idx") 1648e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(!IsValidDescriptor(class_descriptor) || class_descriptor[0] != 'L')) { 1649e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe ErrorStringPrintf("Invalid class descriptor: '%s'", class_descriptor); 165010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 165110037c866b04550fc5461058c398c2e3e509381ajeffhao } 165210037c866b04550fc5461058c398c2e3e509381ajeffhao 1653acc2bb693d83102f93007d7c4881a94bbcc3b9bbAndreas Gampe // Only allow non-runtime modifiers. 1654acc2bb693d83102f93007d7c4881a94bbcc3b9bbAndreas Gampe if ((item->access_flags_ & ~kAccJavaFlagsMask) != 0) { 1655acc2bb693d83102f93007d7c4881a94bbcc3b9bbAndreas Gampe ErrorStringPrintf("Invalid class flags: '%d'", item->access_flags_); 1656acc2bb693d83102f93007d7c4881a94bbcc3b9bbAndreas Gampe return false; 1657acc2bb693d83102f93007d7c4881a94bbcc3b9bbAndreas Gampe } 1658acc2bb693d83102f93007d7c4881a94bbcc3b9bbAndreas Gampe 165910037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->interfaces_off_ != 0 && 166010037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckOffsetToTypeMap(item->interfaces_off_, DexFile::kDexTypeTypeList)) { 166110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 166210037c866b04550fc5461058c398c2e3e509381ajeffhao } 166310037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->annotations_off_ != 0 && 166410037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckOffsetToTypeMap(item->annotations_off_, DexFile::kDexTypeAnnotationsDirectoryItem)) { 166510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 166610037c866b04550fc5461058c398c2e3e509381ajeffhao } 166710037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->class_data_off_ != 0 && 166810037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckOffsetToTypeMap(item->class_data_off_, DexFile::kDexTypeClassDataItem)) { 166910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 167010037c866b04550fc5461058c398c2e3e509381ajeffhao } 167110037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->static_values_off_ != 0 && 167210037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckOffsetToTypeMap(item->static_values_off_, DexFile::kDexTypeEncodedArrayItem)) { 167310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 167410037c866b04550fc5461058c398c2e3e509381ajeffhao } 167510037c866b04550fc5461058c398c2e3e509381ajeffhao 167610037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->superclass_idx_ != DexFile::kDexNoIndex16) { 1677e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING_BY_TYPE(superclass_descriptor, item->superclass_idx_, 1678e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe "inter_class_def_item superclass_idx") 1679e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(!IsValidDescriptor(superclass_descriptor) || superclass_descriptor[0] != 'L')) { 1680e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe ErrorStringPrintf("Invalid superclass: '%s'", superclass_descriptor); 168110037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 168210037c866b04550fc5461058c398c2e3e509381ajeffhao } 168310037c866b04550fc5461058c398c2e3e509381ajeffhao } 168410037c866b04550fc5461058c398c2e3e509381ajeffhao 168510037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::TypeList* interfaces = dex_file_->GetInterfacesList(*item); 168610037c866b04550fc5461058c398c2e3e509381ajeffhao if (interfaces != NULL) { 168710037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t size = interfaces->Size(); 168810037c866b04550fc5461058c398c2e3e509381ajeffhao 168910037c866b04550fc5461058c398c2e3e509381ajeffhao // Ensure that all interfaces refer to classes (not arrays or primitives). 169010037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < size; i++) { 1691e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_STRING_BY_TYPE(inf_descriptor, interfaces->GetTypeItem(i).type_idx_, 1692e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe "inter_class_def_item interface type_idx") 1693e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(!IsValidDescriptor(inf_descriptor) || inf_descriptor[0] != 'L')) { 1694e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe ErrorStringPrintf("Invalid interface: '%s'", inf_descriptor); 169510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 169610037c866b04550fc5461058c398c2e3e509381ajeffhao } 169710037c866b04550fc5461058c398c2e3e509381ajeffhao } 169810037c866b04550fc5461058c398c2e3e509381ajeffhao 169910037c866b04550fc5461058c398c2e3e509381ajeffhao /* 170010037c866b04550fc5461058c398c2e3e509381ajeffhao * Ensure that there are no duplicates. This is an O(N^2) test, but in 170110037c866b04550fc5461058c398c2e3e509381ajeffhao * practice the number of interfaces implemented by any given class is low. 170210037c866b04550fc5461058c398c2e3e509381ajeffhao */ 170310037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 1; i < size; i++) { 170410037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t idx1 = interfaces->GetTypeItem(i).type_idx_; 170510037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t j =0; j < i; j++) { 170610037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t idx2 = interfaces->GetTypeItem(j).type_idx_; 17078d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(idx1 == idx2)) { 17088d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Duplicate interface: '%s'", dex_file_->StringByTypeIdx(idx1)); 170910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 171010037c866b04550fc5461058c398c2e3e509381ajeffhao } 171110037c866b04550fc5461058c398c2e3e509381ajeffhao } 171210037c866b04550fc5461058c398c2e3e509381ajeffhao } 171310037c866b04550fc5461058c398c2e3e509381ajeffhao } 171410037c866b04550fc5461058c398c2e3e509381ajeffhao 171510037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that references in class_data_item are to the right class. 171610037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->class_data_off_ != 0) { 171730fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers const byte* data = begin_ + item->class_data_off_; 17185e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe bool success; 17195e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe uint16_t data_definer = FindFirstClassDataDefiner(data, &success); 17205e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe if (!success) { 1721e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return false; 1722e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 17238d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((data_definer != item->class_idx_) && (data_definer != DexFile::kDexNoIndex16))) { 17248d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid class_data_item"); 172510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 172610037c866b04550fc5461058c398c2e3e509381ajeffhao } 172710037c866b04550fc5461058c398c2e3e509381ajeffhao } 172810037c866b04550fc5461058c398c2e3e509381ajeffhao 172910037c866b04550fc5461058c398c2e3e509381ajeffhao // Check that references in annotations_directory_item are to right class. 173010037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->annotations_off_ != 0) { 173130fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers const byte* data = begin_ + item->annotations_off_; 17325e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe bool success; 17335e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe uint16_t annotations_definer = FindFirstAnnotationsDirectoryDefiner(data, &success); 17345e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe if (!success) { 1735e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return false; 1736e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 17378d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY((annotations_definer != item->class_idx_) && 17388d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers (annotations_definer != DexFile::kDexNoIndex16))) { 17398d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Invalid annotations_directory_item"); 174010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 174110037c866b04550fc5461058c398c2e3e509381ajeffhao } 174210037c866b04550fc5461058c398c2e3e509381ajeffhao } 174310037c866b04550fc5461058c398c2e3e509381ajeffhao 174410037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ += sizeof(DexFile::ClassDef); 174510037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 174610037c866b04550fc5461058c398c2e3e509381ajeffhao} 174710037c866b04550fc5461058c398c2e3e509381ajeffhao 174810037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterAnnotationSetRefList() { 174910037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationSetRefList* list = 175010037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::AnnotationSetRefList*>(ptr_); 175110037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationSetRefItem* item = list->list_; 175210037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t count = list->size_; 175310037c866b04550fc5461058c398c2e3e509381ajeffhao 175410037c866b04550fc5461058c398c2e3e509381ajeffhao while (count--) { 175510037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->annotations_off_ != 0 && 175610037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckOffsetToTypeMap(item->annotations_off_, DexFile::kDexTypeAnnotationSetItem)) { 175710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 175810037c866b04550fc5461058c398c2e3e509381ajeffhao } 175910037c866b04550fc5461058c398c2e3e509381ajeffhao item++; 176010037c866b04550fc5461058c398c2e3e509381ajeffhao } 176110037c866b04550fc5461058c398c2e3e509381ajeffhao 176210037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = reinterpret_cast<const byte*>(item); 176310037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 176410037c866b04550fc5461058c398c2e3e509381ajeffhao} 176510037c866b04550fc5461058c398c2e3e509381ajeffhao 176610037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterAnnotationSetItem() { 176710037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationSetItem* set = reinterpret_cast<const DexFile::AnnotationSetItem*>(ptr_); 176810037c866b04550fc5461058c398c2e3e509381ajeffhao const uint32_t* offsets = set->entries_; 176910037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t count = set->size_; 177010037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t last_idx = 0; 177110037c866b04550fc5461058c398c2e3e509381ajeffhao 177210037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < count; i++) { 177310037c866b04550fc5461058c398c2e3e509381ajeffhao if (*offsets != 0 && !CheckOffsetToTypeMap(*offsets, DexFile::kDexTypeAnnotationItem)) { 177410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 177510037c866b04550fc5461058c398c2e3e509381ajeffhao } 177610037c866b04550fc5461058c398c2e3e509381ajeffhao 177710037c866b04550fc5461058c398c2e3e509381ajeffhao // Get the annotation from the offset and the type index for the annotation. 177810037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationItem* annotation = 177930fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers reinterpret_cast<const DexFile::AnnotationItem*>(begin_ + *offsets); 178010037c866b04550fc5461058c398c2e3e509381ajeffhao const uint8_t* data = annotation->annotation_; 178110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t idx = DecodeUnsignedLeb128(&data); 178210037c866b04550fc5461058c398c2e3e509381ajeffhao 17838d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers if (UNLIKELY(last_idx >= idx && i != 0)) { 17848d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Out-of-order entry types: %x then %x", last_idx, idx); 178510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 178610037c866b04550fc5461058c398c2e3e509381ajeffhao } 178710037c866b04550fc5461058c398c2e3e509381ajeffhao 178810037c866b04550fc5461058c398c2e3e509381ajeffhao last_idx = idx; 178910037c866b04550fc5461058c398c2e3e509381ajeffhao offsets++; 179010037c866b04550fc5461058c398c2e3e509381ajeffhao } 179110037c866b04550fc5461058c398c2e3e509381ajeffhao 179210037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = reinterpret_cast<const byte*>(offsets); 179310037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 179410037c866b04550fc5461058c398c2e3e509381ajeffhao} 179510037c866b04550fc5461058c398c2e3e509381ajeffhao 179610037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterClassDataItem() { 179710037c866b04550fc5461058c398c2e3e509381ajeffhao ClassDataItemIterator it(*dex_file_, ptr_); 17985e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe bool success; 17995e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe uint16_t defining_class = FindFirstClassDataDefiner(ptr_, &success); 18005e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe if (!success) { 1801e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return false; 1802e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 180310037c866b04550fc5461058c398c2e3e509381ajeffhao 180410037c866b04550fc5461058c398c2e3e509381ajeffhao for (; it.HasNextStaticField() || it.HasNextInstanceField(); it.Next()) { 18055e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe LOAD_FIELD(field, it.GetMemberIndex(), "inter_class_data_item field_id", return false) 1806e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(field->class_idx_ != defining_class)) { 18078d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Mismatched defining class for class_data_item field"); 180810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 180910037c866b04550fc5461058c398c2e3e509381ajeffhao } 181010037c866b04550fc5461058c398c2e3e509381ajeffhao } 181110037c866b04550fc5461058c398c2e3e509381ajeffhao for (; it.HasNextDirectMethod() || it.HasNextVirtualMethod(); it.Next()) { 181210037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t code_off = it.GetMethodCodeItemOffset(); 181310037c866b04550fc5461058c398c2e3e509381ajeffhao if (code_off != 0 && !CheckOffsetToTypeMap(code_off, DexFile::kDexTypeCodeItem)) { 181410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 181510037c866b04550fc5461058c398c2e3e509381ajeffhao } 18165e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe LOAD_METHOD(method, it.GetMemberIndex(), "inter_class_data_item method_id", return false) 1817e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(method->class_idx_ != defining_class)) { 18188d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Mismatched defining class for class_data_item method"); 181910037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 182010037c866b04550fc5461058c398c2e3e509381ajeffhao } 182110037c866b04550fc5461058c398c2e3e509381ajeffhao } 182210037c866b04550fc5461058c398c2e3e509381ajeffhao 182310037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = it.EndDataPointer(); 182410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 182510037c866b04550fc5461058c398c2e3e509381ajeffhao} 182610037c866b04550fc5461058c398c2e3e509381ajeffhao 182710037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterAnnotationsDirectoryItem() { 182810037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::AnnotationsDirectoryItem* item = 182910037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::AnnotationsDirectoryItem*>(ptr_); 18305e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe bool success; 18315e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe uint16_t defining_class = FindFirstAnnotationsDirectoryDefiner(ptr_, &success); 18325e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe if (!success) { 1833e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe return false; 1834e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe } 183510037c866b04550fc5461058c398c2e3e509381ajeffhao 183610037c866b04550fc5461058c398c2e3e509381ajeffhao if (item->class_annotations_off_ != 0 && 183710037c866b04550fc5461058c398c2e3e509381ajeffhao !CheckOffsetToTypeMap(item->class_annotations_off_, DexFile::kDexTypeAnnotationSetItem)) { 183810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 183910037c866b04550fc5461058c398c2e3e509381ajeffhao } 184010037c866b04550fc5461058c398c2e3e509381ajeffhao 184110037c866b04550fc5461058c398c2e3e509381ajeffhao // Field annotations follow immediately after the annotations directory. 184210037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::FieldAnnotationsItem* field_item = 184310037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::FieldAnnotationsItem*>(item + 1); 184410037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t field_count = item->fields_size_; 184510037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < field_count; i++) { 18465e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe LOAD_FIELD(field, field_item->field_idx_, "inter_annotations_directory_item field_id", 18475e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe return false) 1848e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(field->class_idx_ != defining_class)) { 18498d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Mismatched defining class for field_annotation"); 185010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 185110037c866b04550fc5461058c398c2e3e509381ajeffhao } 185210037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckOffsetToTypeMap(field_item->annotations_off_, DexFile::kDexTypeAnnotationSetItem)) { 185310037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 185410037c866b04550fc5461058c398c2e3e509381ajeffhao } 185510037c866b04550fc5461058c398c2e3e509381ajeffhao field_item++; 185610037c866b04550fc5461058c398c2e3e509381ajeffhao } 185710037c866b04550fc5461058c398c2e3e509381ajeffhao 185810037c866b04550fc5461058c398c2e3e509381ajeffhao // Method annotations follow immediately after field annotations. 185910037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::MethodAnnotationsItem* method_item = 186010037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::MethodAnnotationsItem*>(field_item); 186110037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t method_count = item->methods_size_; 186210037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < method_count; i++) { 1863e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_METHOD(method, method_item->method_idx_, "inter_annotations_directory_item method_id", 18645e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe return false) 1865e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(method->class_idx_ != defining_class)) { 18668d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Mismatched defining class for method_annotation"); 186710037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 186810037c866b04550fc5461058c398c2e3e509381ajeffhao } 186910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckOffsetToTypeMap(method_item->annotations_off_, DexFile::kDexTypeAnnotationSetItem)) { 187010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 187110037c866b04550fc5461058c398c2e3e509381ajeffhao } 187210037c866b04550fc5461058c398c2e3e509381ajeffhao method_item++; 187310037c866b04550fc5461058c398c2e3e509381ajeffhao } 187410037c866b04550fc5461058c398c2e3e509381ajeffhao 187510037c866b04550fc5461058c398c2e3e509381ajeffhao // Parameter annotations follow immediately after method annotations. 187610037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::ParameterAnnotationsItem* parameter_item = 187710037c866b04550fc5461058c398c2e3e509381ajeffhao reinterpret_cast<const DexFile::ParameterAnnotationsItem*>(method_item); 187810037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t parameter_count = item->parameters_size_; 187910037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < parameter_count; i++) { 1880e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe LOAD_METHOD(parameter_method, parameter_item->method_idx_, 18815e31ddadd29325649260aa186e9ffa8ccdb370a2Andreas Gampe "inter_annotations_directory_item parameter method_id", return false) 1882e09269ca05e3014e86198e9a2cf6092026fafefdAndreas Gampe if (UNLIKELY(parameter_method->class_idx_ != defining_class)) { 18838d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Mismatched defining class for parameter_annotation"); 188410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 188510037c866b04550fc5461058c398c2e3e509381ajeffhao } 18862b87ddf36abff711fa2233c49bffc7ceb03b15d7Dragos Sbirlea if (!CheckOffsetToTypeMap(parameter_item->annotations_off_, 18872b87ddf36abff711fa2233c49bffc7ceb03b15d7Dragos Sbirlea DexFile::kDexTypeAnnotationSetRefList)) { 188810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 188910037c866b04550fc5461058c398c2e3e509381ajeffhao } 189010037c866b04550fc5461058c398c2e3e509381ajeffhao parameter_item++; 189110037c866b04550fc5461058c398c2e3e509381ajeffhao } 189210037c866b04550fc5461058c398c2e3e509381ajeffhao 189310037c866b04550fc5461058c398c2e3e509381ajeffhao ptr_ = reinterpret_cast<const byte*>(parameter_item); 189410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 189510037c866b04550fc5461058c398c2e3e509381ajeffhao} 189610037c866b04550fc5461058c398c2e3e509381ajeffhao 18978a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogersbool DexFileVerifier::CheckInterSectionIterate(size_t offset, uint32_t count, uint16_t type) { 189810037c866b04550fc5461058c398c2e3e509381ajeffhao // Get the right alignment mask for the type of section. 18998a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers size_t alignment_mask; 190010037c866b04550fc5461058c398c2e3e509381ajeffhao switch (type) { 190110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDataItem: 190210037c866b04550fc5461058c398c2e3e509381ajeffhao alignment_mask = sizeof(uint8_t) - 1; 190310037c866b04550fc5461058c398c2e3e509381ajeffhao break; 190410037c866b04550fc5461058c398c2e3e509381ajeffhao default: 190510037c866b04550fc5461058c398c2e3e509381ajeffhao alignment_mask = sizeof(uint32_t) - 1; 190610037c866b04550fc5461058c398c2e3e509381ajeffhao break; 190710037c866b04550fc5461058c398c2e3e509381ajeffhao } 190810037c866b04550fc5461058c398c2e3e509381ajeffhao 190910037c866b04550fc5461058c398c2e3e509381ajeffhao // Iterate through the items in the section. 191010037c866b04550fc5461058c398c2e3e509381ajeffhao previous_item_ = NULL; 191110037c866b04550fc5461058c398c2e3e509381ajeffhao for (uint32_t i = 0; i < count; i++) { 191210037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t new_offset = (offset + alignment_mask) & ~alignment_mask; 191330fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers ptr_ = begin_ + new_offset; 191410037c866b04550fc5461058c398c2e3e509381ajeffhao const byte* prev_ptr = ptr_; 191510037c866b04550fc5461058c398c2e3e509381ajeffhao 191610037c866b04550fc5461058c398c2e3e509381ajeffhao // Check depending on the section type. 191710037c866b04550fc5461058c398c2e3e509381ajeffhao switch (type) { 191810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringIdItem: { 191910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterStringIdItem()) { 192010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 192110037c866b04550fc5461058c398c2e3e509381ajeffhao } 192210037c866b04550fc5461058c398c2e3e509381ajeffhao break; 192310037c866b04550fc5461058c398c2e3e509381ajeffhao } 192410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeIdItem: { 192510037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterTypeIdItem()) { 192610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 192710037c866b04550fc5461058c398c2e3e509381ajeffhao } 192810037c866b04550fc5461058c398c2e3e509381ajeffhao break; 192910037c866b04550fc5461058c398c2e3e509381ajeffhao } 193010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeProtoIdItem: { 193110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterProtoIdItem()) { 193210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 193310037c866b04550fc5461058c398c2e3e509381ajeffhao } 193410037c866b04550fc5461058c398c2e3e509381ajeffhao break; 193510037c866b04550fc5461058c398c2e3e509381ajeffhao } 193610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeFieldIdItem: { 193710037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterFieldIdItem()) { 193810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 193910037c866b04550fc5461058c398c2e3e509381ajeffhao } 194010037c866b04550fc5461058c398c2e3e509381ajeffhao break; 194110037c866b04550fc5461058c398c2e3e509381ajeffhao } 194210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMethodIdItem: { 194310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterMethodIdItem()) { 194410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 194510037c866b04550fc5461058c398c2e3e509381ajeffhao } 194610037c866b04550fc5461058c398c2e3e509381ajeffhao break; 194710037c866b04550fc5461058c398c2e3e509381ajeffhao } 194810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDefItem: { 194910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterClassDefItem()) { 195010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 195110037c866b04550fc5461058c398c2e3e509381ajeffhao } 195210037c866b04550fc5461058c398c2e3e509381ajeffhao break; 195310037c866b04550fc5461058c398c2e3e509381ajeffhao } 195410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetRefList: { 195510037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterAnnotationSetRefList()) { 195610037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 195710037c866b04550fc5461058c398c2e3e509381ajeffhao } 195810037c866b04550fc5461058c398c2e3e509381ajeffhao break; 195910037c866b04550fc5461058c398c2e3e509381ajeffhao } 196010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetItem: { 196110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterAnnotationSetItem()) { 196210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 196310037c866b04550fc5461058c398c2e3e509381ajeffhao } 196410037c866b04550fc5461058c398c2e3e509381ajeffhao break; 196510037c866b04550fc5461058c398c2e3e509381ajeffhao } 196610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDataItem: { 196710037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterClassDataItem()) { 196810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 196910037c866b04550fc5461058c398c2e3e509381ajeffhao } 197010037c866b04550fc5461058c398c2e3e509381ajeffhao break; 197110037c866b04550fc5461058c398c2e3e509381ajeffhao } 197210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationsDirectoryItem: { 197310037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterAnnotationsDirectoryItem()) { 197410037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 197510037c866b04550fc5461058c398c2e3e509381ajeffhao } 197610037c866b04550fc5461058c398c2e3e509381ajeffhao break; 197710037c866b04550fc5461058c398c2e3e509381ajeffhao } 197810037c866b04550fc5461058c398c2e3e509381ajeffhao default: 19798d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Unknown map item type %x", type); 198010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 198110037c866b04550fc5461058c398c2e3e509381ajeffhao } 198210037c866b04550fc5461058c398c2e3e509381ajeffhao 198310037c866b04550fc5461058c398c2e3e509381ajeffhao previous_item_ = prev_ptr; 19848a6bbfc66e3cf01d4aa07ee08b515beee481d553Ian Rogers offset = ptr_ - begin_; 198510037c866b04550fc5461058c398c2e3e509381ajeffhao } 198610037c866b04550fc5461058c398c2e3e509381ajeffhao 198710037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 198810037c866b04550fc5461058c398c2e3e509381ajeffhao} 198910037c866b04550fc5461058c398c2e3e509381ajeffhao 199010037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::CheckInterSection() { 199130fab40ee5a07af6b8c3b6b0e9438071695a57f4Ian Rogers const DexFile::MapList* map = reinterpret_cast<const DexFile::MapList*>(begin_ + header_->map_off_); 199210037c866b04550fc5461058c398c2e3e509381ajeffhao const DexFile::MapItem* item = map->list_; 199310037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t count = map->size_; 199410037c866b04550fc5461058c398c2e3e509381ajeffhao 199510037c866b04550fc5461058c398c2e3e509381ajeffhao // Cross check the items listed in the map. 199610037c866b04550fc5461058c398c2e3e509381ajeffhao while (count--) { 199710037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t section_offset = item->offset_; 199810037c866b04550fc5461058c398c2e3e509381ajeffhao uint32_t section_count = item->size_; 199910037c866b04550fc5461058c398c2e3e509381ajeffhao uint16_t type = item->type_; 200010037c866b04550fc5461058c398c2e3e509381ajeffhao 200110037c866b04550fc5461058c398c2e3e509381ajeffhao switch (type) { 200210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeHeaderItem: 200310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMapList: 200410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeList: 200510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeCodeItem: 200610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringDataItem: 200710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeDebugInfoItem: 200810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationItem: 200910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeEncodedArrayItem: 201010037c866b04550fc5461058c398c2e3e509381ajeffhao break; 201110037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeStringIdItem: 201210037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeTypeIdItem: 201310037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeProtoIdItem: 201410037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeFieldIdItem: 201510037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeMethodIdItem: 201610037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDefItem: 201710037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetRefList: 201810037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationSetItem: 201910037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeClassDataItem: 202010037c866b04550fc5461058c398c2e3e509381ajeffhao case DexFile::kDexTypeAnnotationsDirectoryItem: { 202110037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterSectionIterate(section_offset, section_count, type)) { 202210037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 202310037c866b04550fc5461058c398c2e3e509381ajeffhao } 202410037c866b04550fc5461058c398c2e3e509381ajeffhao break; 202510037c866b04550fc5461058c398c2e3e509381ajeffhao } 202610037c866b04550fc5461058c398c2e3e509381ajeffhao default: 20278d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers ErrorStringPrintf("Unknown map item type %x", type); 202810037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 202910037c866b04550fc5461058c398c2e3e509381ajeffhao } 203010037c866b04550fc5461058c398c2e3e509381ajeffhao 203110037c866b04550fc5461058c398c2e3e509381ajeffhao item++; 203210037c866b04550fc5461058c398c2e3e509381ajeffhao } 203310037c866b04550fc5461058c398c2e3e509381ajeffhao 203410037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 203510037c866b04550fc5461058c398c2e3e509381ajeffhao} 203610037c866b04550fc5461058c398c2e3e509381ajeffhao 203710037c866b04550fc5461058c398c2e3e509381ajeffhaobool DexFileVerifier::Verify() { 203810037c866b04550fc5461058c398c2e3e509381ajeffhao // Check the header. 203910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckHeader()) { 204010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 204110037c866b04550fc5461058c398c2e3e509381ajeffhao } 204210037c866b04550fc5461058c398c2e3e509381ajeffhao 204310037c866b04550fc5461058c398c2e3e509381ajeffhao // Check the map section. 204410037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckMap()) { 204510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 204610037c866b04550fc5461058c398c2e3e509381ajeffhao } 204710037c866b04550fc5461058c398c2e3e509381ajeffhao 204810037c866b04550fc5461058c398c2e3e509381ajeffhao // Check structure within remaining sections. 204910037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckIntraSection()) { 205010037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 205110037c866b04550fc5461058c398c2e3e509381ajeffhao } 205210037c866b04550fc5461058c398c2e3e509381ajeffhao 205310037c866b04550fc5461058c398c2e3e509381ajeffhao // Check references from one section to another. 205410037c866b04550fc5461058c398c2e3e509381ajeffhao if (!CheckInterSection()) { 205510037c866b04550fc5461058c398c2e3e509381ajeffhao return false; 205610037c866b04550fc5461058c398c2e3e509381ajeffhao } 205710037c866b04550fc5461058c398c2e3e509381ajeffhao 205810037c866b04550fc5461058c398c2e3e509381ajeffhao return true; 205910037c866b04550fc5461058c398c2e3e509381ajeffhao} 206010037c866b04550fc5461058c398c2e3e509381ajeffhao 20618d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogersvoid DexFileVerifier::ErrorStringPrintf(const char* fmt, ...) { 20628d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers va_list ap; 20638d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers va_start(ap, fmt); 20648d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers DCHECK(failure_reason_.empty()) << failure_reason_; 20658d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers failure_reason_ = StringPrintf("Failure to verify dex file '%s': ", location_); 20668d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers StringAppendV(&failure_reason_, fmt, ap); 20678d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers va_end(ap); 20688d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers} 20698d31bbd3d6536de12bc20e3d29cfe03fe848f9daIan Rogers 207010037c866b04550fc5461058c398c2e3e509381ajeffhao} // namespace art 2071