| 3a62e235646ec19bee71e8dbee5208282dcd13b5 |
|
20-Jan-2016 |
Alex Vakulenko <avakulenko@google.com> |
shill: Update libchrome APIs to r369476
The new libchrome has been ported from Chromium and some APIs have
changed. Make necessary changes at call sites.
Change-Id: Ib4c4b5438a2e249777c9c1b6509f085ad5d00049
/system/connectivity/shill/crypto_util_proxy.cc
|
| 03e6719bae1e0903d94853b896673a033196bcf5 |
|
13-Oct-2015 |
Alex Vakulenko <avakulenko@google.com> |
shill: Rename "chromeos" -> "brillo" in include paths and namespaces
libchromeos is transitioning to libbrillo and chromeos namespaces
and include directory is changing to brillo.
Bug: 24872993
TEST=built for aosp and brillo, all unit tests pass on dragonboard
Change-Id: I804311e49ee780ca96e05f6a581e8c95709d4e1d
/system/connectivity/shill/crypto_util_proxy.cc
|
| 304afb43643faa19fa3a599a59fbb1574c0a06ef |
|
19-Sep-2015 |
mukesh agrawal <quiche@google.com> |
shill: migrate CryptoUtilProxy to ProcessManager
We want to remove ProcessKiller, since ProcessKiller
depends on glib. So migrate CryptoUtilProxy away
from ProcessKiller.
Bug: None
BUG=chromium:528079
TEST=unit tests
Change-Id: I45d196c9a2e53f8f9258c3dc03515f6e68e14708
/system/connectivity/shill/crypto_util_proxy.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/crypto_util_proxy.cc
|
| 13d581fa047118d065f41eb1d0da203cf0a49b07 |
|
15-Aug-2015 |
mukesh agrawal <quiche@chromium.org> |
shill: migrate CryptoUtilProxy to libchromeos' base64
On some platforms, we don't have glib available. Update
CryptoUtilProxy to use libchromeos' base64, so that this
code can compile on those platforms.
BUG=b:23003526
TEST=unit tests
Change-Id: I4728b9cba0df79c15856928ca1b621ac3cdf4030
Reviewed-on: https://chromium-review.googlesource.com/293881
Trybot-Ready: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| a794cd60a7339d576ea2eed263a4f0a20fb255af |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level files a-e: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: Idb7252202e142098999fe0672712aded7d369259
Reviewed-on: https://chromium-review.googlesource.com/278038
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| ccab3f9f460312262f6153db8246b100d1362ba8 |
|
15-Jun-2015 |
Alex Vakulenko <avakulenko@chromium.org> |
platform2: Fix issues with new version of libchrome
libchrome r334380 has the following breaking changes that need to be fixed:
- base::JSONWriter::Write() and base::JSONWriter::WriteWithOptions() take
"const base::Value&" instead of "const base::Value*"
- base::JSONReader::Read() and base::JSONReader::ReadAndReturnError()
return a scoped_ptr<base::Value> instead of base::Value*
- base/safe_strerror_posix.h is moved to base/posix/safe_strerror.h
- safe_strerror() is now in "base" namespace
- StartsWithASCII(), EndsWith(), StringToUpperASCII(), LowerCaseEqualsASCII()
are now in "base" namespace
- ObserverList<T> is now in "base" namespace
- base::PrintTo(base::FilePath) used in gtest is now moved to libchrome-test
library and as such, unit test runners need to link to this library now.
- crypto::RSAPrivateKey::CreateSensitive() is now removed from //crypto, so
some of tests in chromeos-login that used that function had to be changed
to use crypto::GenerateRSAKeyPairNSS() directly.
- UnixDomanSocket class is now in "base" namespace
- Pickle class is now in "base" namespace
BUG=chromium:496469
TEST=`./build_packages`
CQ-DEPEND=CL:277662
Change-Id: I36e5fbf2e36a92068873ffbd44020c862a3ed9e3
Reviewed-on: https://chromium-review.googlesource.com/277671
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
Trybot-Ready: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| 34f424e672439bdf237a755f85245ebd7b66e8e2 |
|
17-Jan-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Error: Attribute source from PopulateAndLog
Have callers pass the source file/line of PopulateAndLog calls so
the log message can disambiguate the ultimate source of the error.
BUG=chromium:449528
TEST=Unit tests + manual: restart shill and "grep error.cc /var/log/net.log"
Change-Id: I7bb54e966b047025a3ec7ef18acce5b8bed3d031
Reviewed-on: https://chromium-review.googlesource.com/241522
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| 3161caa04e98af2fec2106d80c5d2e2b2f809366 |
|
29-Oct-2014 |
Peter Qiu <zqiu@chromium.org> |
shill: Remove shill::Error dependency from libshill-net shared library.
Update the ErrorCallback in the IOHandler to pass back a std::string
(error message) instead of shill::Error objet to remove the dependency
of shill:: Error from the libshill-net library, which also allow it to
remove the dependency for dbus-c++.
BUG=chromium:427982
TEST=unittests
Change-Id: I2e756d5e0744f449fcdcb157f5356112c45fd855
Reviewed-on: https://chromium-review.googlesource.com/226291
Reviewed-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Peter Qiu <zqiu@chromium.org>
Commit-Queue: Peter Qiu <zqiu@chromium.org>
Tested-by: Peter Qiu <zqiu@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| cc225ef3b77b5e098cc12c661a947e1737480777 |
|
30-Sep-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace NULL with nullptr.
BUG=None
TEST=`USE=wimax FEATURES=test emerge-$BOARD shill`
Change-Id: I30ab47ff32dcadad09ae7a2baf4d4123a6ef0d8e
Reviewed-on: https://chromium-review.googlesource.com/220657
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| e4c6aff3afa8eec213691e6ab1941d6dd6463ce0 |
|
30-Jul-2014 |
Utkarsh Sanghi <usanghi@chromium.org> |
shill, libchromeos, lorgnette: move minijail to libchromeos
Move the c++ wrapper of minijail out of lorgnette
and into libchromeos
BUG=None
TEST=emerge-lumpy libchromeos && USE="shill lorgnette" emerge-lumpy
platform2 --test
Change-Id: Idc796ffb042b1ed6b5a4d322d501eab5bff7fc55
Reviewed-on: https://chromium-review.googlesource.com/210553
Reviewed-by: Utkarsh Sanghi <usanghi@chromium.org>
Commit-Queue: Utkarsh Sanghi <usanghi@chromium.org>
Tested-by: Utkarsh Sanghi <usanghi@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| 83bd64b869bef72ec734b96eb9cf291b9a9ac2c4 |
|
30-Jul-2014 |
Utkarsh Sanghi <usanghi@chromium.org> |
shill, libchromeos: Move the minijail c++ bindings
This CL moves the c++ binding for minijail from shill
into libchromeos
BUG=None
TEST=emerge-lumpy libchromeos && FEATURES=test emerge-lumpy platform2
CQ-DEPEND=CL:210408
Change-Id: Ia087ffbf4f54e08fff450f0e2b7984e9eb3448e3
Reviewed-on: https://chromium-review.googlesource.com/210379
Tested-by: Utkarsh Sanghi <usanghi@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Bertrand Simonnet <bsimonnet@chromium.org>
Commit-Queue: Utkarsh Sanghi <usanghi@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| a0ddf46e466bd4ba3d20952f0a6988c680c1af14 |
|
06-Feb-2014 |
Ben Chan <benchan@chromium.org> |
shill: Update to build against libchrome-242728.
BUG=chromium:341521
CQ-DEPEND=CL:193660
TEST=Tested the following:
1. `FEATURES=test USE='cellular wimax' emerge-$BOARD platform2`
2. Run the following tests:
- network_3GSmokeTest
- network_VPNConnect.*
- network_WiMaxSmoke
- wifi_matfunc
Change-Id: Ic1553c182ab7a833a68c45f012f646b8930cb095
Reviewed-on: https://chromium-review.googlesource.com/193606
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| 67e425e5af9b28ffff2c17f879e70f9f6a4e10e9 |
|
03-May-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Fix race on crypto-util shim death
Fix a race between the death of the shim and crypto_util_proxy callers.
CryptUtilProxy was incorrectly calling its result handler before the
shim was completely dead, leading linked calls to fail *sometimes*.
BUG=chromium:236083
TEST=Manual. VerifyAndEncryptData no longer fails with valid input.
Change-Id: I50c72b3609b51a2a8f3b624bc8eac7d7372283f3
Reviewed-on: https://gerrit.chromium.org/gerrit/50000
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| b3e70d2ca1cfb02effd82c6f95f2869d22201860 |
|
27-Apr-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Only call shim result callback from clean shim state
Fix a bug where VerifyAndEncryptData fails when the Verify callback
cannot start an Encrypt operation because the shim is supposedly still
working. The shim has actually returned a complete result in this case,
but we're calling into the crypto_util_proxy before giving it a chance
to clean up the shim state.
While we're here, check the correct error in the Manager when we fail to
link Verify and Encrypt shim operations.
TEST=Unit tests.
BUG=chromium:236083
Change-Id: I00366d55afa1c3dd228d40662e2baacac7d79eb0
Reviewed-on: https://gerrit.chromium.org/gerrit/49490
Commit-Queue: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| c2c22ca6a6e1610bc3056951af51dad1aece35a1 |
|
19-Apr-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Format destination MAC address correctly for verification
Correctly upper case the MAC address for a destiantion when verifying
identity. This allows signed blob comparisons to succeed.
TEST=Called into shill via DBus while connected to a destination with
credentials supplied by the destination (obtained via curl offline).
Noted that this change causes verification to succeed.
BUG=chromium:231673
Change-Id: I5db7a1116f3cd1c4d6891c9ec168cbafdf0bb631
Reviewed-on: https://gerrit.chromium.org/gerrit/48694
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| 956400a700b5ad9236c30774ca7d47d63ebe530a |
|
05-Apr-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Append NULL to end of crypto-util arguments
Fix a crash in minijail after we fork off the shim by properly
formatting its argument strings.
TEST=By hand: call Manager.VerifyDestination with any data, observe that
the shim starts and at least looks at the data before exitting,
rather than crashing mysteriously.
BUG=chromium:227074
Change-Id: I547151bdb07c7656249220caff388dc36c53b8c7
Reviewed-on: https://gerrit.chromium.org/gerrit/47447
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| 0d05c11a21752aa82c598977bdd409a41d51cb55 |
|
20-Mar-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Add crypto_util shim
Add a shim to delegate cryptographic verification of destinations.
TEST=Unit tests pass. Co-commit with an autotest that verifies OpenSSL
operations.
BUG=chromium:221169
CQ-DEPEND:CL:46308
Change-Id: I564732224cd3f30411f7330198bd3c5fc99c289e
Reviewed-on: https://gerrit.chromium.org/gerrit/46051
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| 5447d2e616b657a36ef878ae35c77f7d2f4d2c8e |
|
20-Mar-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Base64 encode/decode crypto_util arguments
Initially, I thought this would be easier to do in the shim, where
things might play nicely with OpenSSL. However, it turns out that the
OpenSSL API for base64 encoding/decoding is far more painful that it's
worth. Add a convenient wrapper around the raw GLib calls so that
people have less opportunity to shoot themselves in the foot.
BUG=chromium-os:221168
TEST=Unit tests pass.
Change-Id: I69732af03fdf729519783a3440213ef6adf8a630
Reviewed-on: https://gerrit.chromium.org/gerrit/46049
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| eb7d736a9be40a807b4ebd1d7888b4e950d1b3ef |
|
12-Mar-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Pass down the BSSID of the destination to crypto_util
This will allow the crypto_util shim to verify that the device listed in
the certificate matches the device shill believes to be the current WiFi
service. There was some debate around what would eventually end up in
the certificate and this was the final result.
TEST=None
BUG=chromium-os:39056
Change-Id: I83e1a8a12918f6eef6e531959bc485c22ac62cba
Reviewed-on: https://gerrit.chromium.org/gerrit/45245
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|
| 5a3f23a122566b53e230b1132c0241411016386a |
|
21-Feb-2013 |
Christopher Wiley <wiley@chromium.org> |
shill: Delegate credential verification operations to a shim
Define a protocol buffer interface to a shim, and suppport
asynchronously piping the arguments for credential verification and data
signing into the shim. Read results back from the shim asynchronously
as well.
BUG=chromium-os:39055
TEST=Unit tests. Added some more.
Change-Id: I5e0e25b9639bf5e6237c4c35d0be14b129951809
Reviewed-on: https://gerrit.chromium.org/gerrit/44239
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/crypto_util_proxy.cc
|