codegen_test.cc revision 946e143941d456a4ec666f7f54719c65c5aa3f5d 
1/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 *      http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include <functional>
18
19#include "base/macros.h"
20#include "builder.h"
21#include "code_generator_arm.h"
22#include "code_generator_arm64.h"
23#include "code_generator_x86.h"
24#include "code_generator_x86_64.h"
25#include "common_compiler_test.h"
26#include "dex_file.h"
27#include "dex_instruction.h"
28#include "instruction_set.h"
29#include "nodes.h"
30#include "optimizing_unit_test.h"
31#include "prepare_for_register_allocation.h"
32#include "register_allocator.h"
33#include "ssa_liveness_analysis.h"
34#include "utils.h"
35
36#include "gtest/gtest.h"
37
38namespace art {
39
40class InternalCodeAllocator : public CodeAllocator {
41 public:
42  InternalCodeAllocator() { }
43
44  virtual uint8_t* Allocate(size_t size) {
45    size_ = size;
46    memory_.reset(new uint8_t[size]);
47    return memory_.get();
48  }
49
50  size_t GetSize() const { return size_; }
51  uint8_t* GetMemory() const { return memory_.get(); }
52
53 private:
54  size_t size_;
55  std::unique_ptr<uint8_t[]> memory_;
56
57  DISALLOW_COPY_AND_ASSIGN(InternalCodeAllocator);
58};
59
60template <typename Expected>
61static void Run(const InternalCodeAllocator& allocator,
62                const CodeGenerator& codegen,
63                bool has_result,
64                Expected expected) {
65  typedef Expected (*fptr)();
66  CommonCompilerTest::MakeExecutable(allocator.GetMemory(), allocator.GetSize());
67  fptr f = reinterpret_cast<fptr>(allocator.GetMemory());
68  if (codegen.GetInstructionSet() == kThumb2) {
69    // For thumb we need the bottom bit set.
70    f = reinterpret_cast<fptr>(reinterpret_cast<uintptr_t>(f) + 1);
71  }
72  Expected result = f();
73  if (has_result) {
74    ASSERT_EQ(result, expected);
75  }
76}
77
78template <typename Expected>
79static void RunCodeBaseline(HGraph* graph, bool has_result, Expected expected) {
80  InternalCodeAllocator allocator;
81
82  x86::CodeGeneratorX86 codegenX86(graph);
83  // We avoid doing a stack overflow check that requires the runtime being setup,
84  // by making sure the compiler knows the methods we are running are leaf methods.
85  codegenX86.CompileBaseline(&allocator, true);
86  if (kRuntimeISA == kX86) {
87    Run(allocator, codegenX86, has_result, expected);
88  }
89
90  arm::CodeGeneratorARM codegenARM(graph);
91  codegenARM.CompileBaseline(&allocator, true);
92  if (kRuntimeISA == kArm || kRuntimeISA == kThumb2) {
93    Run(allocator, codegenARM, has_result, expected);
94  }
95
96  x86_64::CodeGeneratorX86_64 codegenX86_64(graph);
97  codegenX86_64.CompileBaseline(&allocator, true);
98  if (kRuntimeISA == kX86_64) {
99    Run(allocator, codegenX86_64, has_result, expected);
100  }
101
102  arm64::CodeGeneratorARM64 codegenARM64(graph);
103  codegenARM64.CompileBaseline(&allocator, true);
104  if (kRuntimeISA == kArm64) {
105    Run(allocator, codegenARM64, has_result, expected);
106  }
107}
108
109template <typename Expected>
110static void RunCodeOptimized(CodeGenerator* codegen,
111                             HGraph* graph,
112                             std::function<void(HGraph*)> hook_before_codegen,
113                             bool has_result,
114                             Expected expected) {
115  SsaLivenessAnalysis liveness(*graph, codegen);
116  liveness.Analyze();
117
118  RegisterAllocator register_allocator(graph->GetArena(), codegen, liveness);
119  register_allocator.AllocateRegisters();
120  hook_before_codegen(graph);
121
122  InternalCodeAllocator allocator;
123  codegen->CompileOptimized(&allocator);
124  Run(allocator, *codegen, has_result, expected);
125}
126
127template <typename Expected>
128static void RunCodeOptimized(HGraph* graph,
129                             std::function<void(HGraph*)> hook_before_codegen,
130                             bool has_result,
131                             Expected expected) {
132  if (kRuntimeISA == kX86) {
133    x86::CodeGeneratorX86 codegenX86(graph);
134    RunCodeOptimized(&codegenX86, graph, hook_before_codegen, has_result, expected);
135  } else if (kRuntimeISA == kArm || kRuntimeISA == kThumb2) {
136    arm::CodeGeneratorARM codegenARM(graph);
137    RunCodeOptimized(&codegenARM, graph, hook_before_codegen, has_result, expected);
138  } else if (kRuntimeISA == kX86_64) {
139    x86_64::CodeGeneratorX86_64 codegenX86_64(graph);
140    RunCodeOptimized(&codegenX86_64, graph, hook_before_codegen, has_result, expected);
141  }
142}
143
144static void TestCode(const uint16_t* data, bool has_result = false, int32_t expected = 0) {
145  ArenaPool pool;
146  ArenaAllocator arena(&pool);
147  HGraphBuilder builder(&arena);
148  const DexFile::CodeItem* item = reinterpret_cast<const DexFile::CodeItem*>(data);
149  HGraph* graph = builder.BuildGraph(*item);
150  ASSERT_NE(graph, nullptr);
151  // Remove suspend checks, they cannot be executed in this context.
152  RemoveSuspendChecks(graph);
153  RunCodeBaseline(graph, has_result, expected);
154}
155
156static void TestCodeLong(const uint16_t* data, bool has_result, int64_t expected) {
157  ArenaPool pool;
158  ArenaAllocator arena(&pool);
159  HGraphBuilder builder(&arena, Primitive::kPrimLong);
160  const DexFile::CodeItem* item = reinterpret_cast<const DexFile::CodeItem*>(data);
161  HGraph* graph = builder.BuildGraph(*item);
162  ASSERT_NE(graph, nullptr);
163  // Remove suspend checks, they cannot be executed in this context.
164  RemoveSuspendChecks(graph);
165  RunCodeBaseline(graph, has_result, expected);
166}
167
168TEST(CodegenTest, ReturnVoid) {
169  const uint16_t data[] = ZERO_REGISTER_CODE_ITEM(Instruction::RETURN_VOID);
170  TestCode(data);
171}
172
173TEST(CodegenTest, CFG1) {
174  const uint16_t data[] = ZERO_REGISTER_CODE_ITEM(
175    Instruction::GOTO | 0x100,
176    Instruction::RETURN_VOID);
177
178  TestCode(data);
179}
180
181TEST(CodegenTest, CFG2) {
182  const uint16_t data[] = ZERO_REGISTER_CODE_ITEM(
183    Instruction::GOTO | 0x100,
184    Instruction::GOTO | 0x100,
185    Instruction::RETURN_VOID);
186
187  TestCode(data);
188}
189
190TEST(CodegenTest, CFG3) {
191  const uint16_t data1[] = ZERO_REGISTER_CODE_ITEM(
192    Instruction::GOTO | 0x200,
193    Instruction::RETURN_VOID,
194    Instruction::GOTO | 0xFF00);
195
196  TestCode(data1);
197
198  const uint16_t data2[] = ZERO_REGISTER_CODE_ITEM(
199    Instruction::GOTO_16, 3,
200    Instruction::RETURN_VOID,
201    Instruction::GOTO_16, 0xFFFF);
202
203  TestCode(data2);
204
205  const uint16_t data3[] = ZERO_REGISTER_CODE_ITEM(
206    Instruction::GOTO_32, 4, 0,
207    Instruction::RETURN_VOID,
208    Instruction::GOTO_32, 0xFFFF, 0xFFFF);
209
210  TestCode(data3);
211}
212
213TEST(CodegenTest, CFG4) {
214  const uint16_t data[] = ZERO_REGISTER_CODE_ITEM(
215    Instruction::RETURN_VOID,
216    Instruction::GOTO | 0x100,
217    Instruction::GOTO | 0xFE00);
218
219  TestCode(data);
220}
221
222TEST(CodegenTest, CFG5) {
223  const uint16_t data[] = ONE_REGISTER_CODE_ITEM(
224    Instruction::CONST_4 | 0 | 0,
225    Instruction::IF_EQ, 3,
226    Instruction::GOTO | 0x100,
227    Instruction::RETURN_VOID);
228
229  TestCode(data);
230}
231
232TEST(CodegenTest, IntConstant) {
233  const uint16_t data[] = ONE_REGISTER_CODE_ITEM(
234    Instruction::CONST_4 | 0 | 0,
235    Instruction::RETURN_VOID);
236
237  TestCode(data);
238}
239
240TEST(CodegenTest, Return1) {
241  const uint16_t data[] = ONE_REGISTER_CODE_ITEM(
242    Instruction::CONST_4 | 0 | 0,
243    Instruction::RETURN | 0);
244
245  TestCode(data, true, 0);
246}
247
248TEST(CodegenTest, Return2) {
249  const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(
250    Instruction::CONST_4 | 0 | 0,
251    Instruction::CONST_4 | 0 | 1 << 8,
252    Instruction::RETURN | 1 << 8);
253
254  TestCode(data, true, 0);
255}
256
257TEST(CodegenTest, Return3) {
258  const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(
259    Instruction::CONST_4 | 0 | 0,
260    Instruction::CONST_4 | 1 << 8 | 1 << 12,
261    Instruction::RETURN | 1 << 8);
262
263  TestCode(data, true, 1);
264}
265
266TEST(CodegenTest, ReturnIf1) {
267  const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(
268    Instruction::CONST_4 | 0 | 0,
269    Instruction::CONST_4 | 1 << 8 | 1 << 12,
270    Instruction::IF_EQ, 3,
271    Instruction::RETURN | 0 << 8,
272    Instruction::RETURN | 1 << 8);
273
274  TestCode(data, true, 1);
275}
276
277TEST(CodegenTest, ReturnIf2) {
278  const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(
279    Instruction::CONST_4 | 0 | 0,
280    Instruction::CONST_4 | 1 << 8 | 1 << 12,
281    Instruction::IF_EQ | 0 << 4 | 1 << 8, 3,
282    Instruction::RETURN | 0 << 8,
283    Instruction::RETURN | 1 << 8);
284
285  TestCode(data, true, 0);
286}
287
288// Exercise bit-wise (one's complement) not-int instruction.
289#define NOT_INT_TEST(TEST_NAME, INPUT, EXPECTED_OUTPUT) \
290TEST(CodegenTest, TEST_NAME) {                          \
291  const int32_t input = INPUT;                          \
292  const uint16_t input_lo = Low16Bits(input);           \
293  const uint16_t input_hi = High16Bits(input);          \
294  const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(      \
295      Instruction::CONST | 0 << 8, input_lo, input_hi,  \
296      Instruction::NOT_INT | 1 << 8 | 0 << 12 ,         \
297      Instruction::RETURN | 1 << 8);                    \
298                                                        \
299  TestCode(data, true, EXPECTED_OUTPUT);                \
300}
301
302NOT_INT_TEST(ReturnNotIntMinus2, -2, 1)
303NOT_INT_TEST(ReturnNotIntMinus1, -1, 0)
304NOT_INT_TEST(ReturnNotInt0, 0, -1)
305NOT_INT_TEST(ReturnNotInt1, 1, -2)
306NOT_INT_TEST(ReturnNotIntINT32_MIN, -2147483648, 2147483647)  // (2^31) - 1
307NOT_INT_TEST(ReturnNotIntINT32_MINPlus1, -2147483647, 2147483646)  // (2^31) - 2
308NOT_INT_TEST(ReturnNotIntINT32_MAXMinus1, 2147483646, -2147483647)  // -(2^31) - 1
309NOT_INT_TEST(ReturnNotIntINT32_MAX, 2147483647, -2147483648)  // -(2^31)
310
311#undef NOT_INT_TEST
312
313// Exercise bit-wise (one's complement) not-long instruction.
314#define NOT_LONG_TEST(TEST_NAME, INPUT, EXPECTED_OUTPUT)                 \
315TEST(CodegenTest, TEST_NAME) {                                           \
316  const int64_t input = INPUT;                                           \
317  const uint16_t word0 = Low16Bits(Low32Bits(input));   /* LSW. */       \
318  const uint16_t word1 = High16Bits(Low32Bits(input));                   \
319  const uint16_t word2 = Low16Bits(High32Bits(input));                   \
320  const uint16_t word3 = High16Bits(High32Bits(input)); /* MSW. */       \
321  const uint16_t data[] = FOUR_REGISTERS_CODE_ITEM(                      \
322      Instruction::CONST_WIDE | 0 << 8, word0, word1, word2, word3,      \
323      Instruction::NOT_LONG | 2 << 8 | 0 << 12,                          \
324      Instruction::RETURN_WIDE | 2 << 8);                                \
325                                                                         \
326  TestCodeLong(data, true, EXPECTED_OUTPUT);                             \
327}
328
329NOT_LONG_TEST(ReturnNotLongMinus2, INT64_C(-2), INT64_C(1))
330NOT_LONG_TEST(ReturnNotLongMinus1, INT64_C(-1), INT64_C(0))
331NOT_LONG_TEST(ReturnNotLong0, INT64_C(0), INT64_C(-1))
332NOT_LONG_TEST(ReturnNotLong1, INT64_C(1), INT64_C(-2))
333
334NOT_LONG_TEST(ReturnNotLongINT32_MIN,
335              INT64_C(-2147483648),
336              INT64_C(2147483647))  // (2^31) - 1
337NOT_LONG_TEST(ReturnNotLongINT32_MINPlus1,
338              INT64_C(-2147483647),
339              INT64_C(2147483646))  // (2^31) - 2
340NOT_LONG_TEST(ReturnNotLongINT32_MAXMinus1,
341              INT64_C(2147483646),
342              INT64_C(-2147483647))  // -(2^31) - 1
343NOT_LONG_TEST(ReturnNotLongINT32_MAX,
344              INT64_C(2147483647),
345              INT64_C(-2147483648))  // -(2^31)
346
347// Note that the C++ compiler won't accept
348// INT64_C(-9223372036854775808) (that is, INT64_MIN) as a valid
349// int64_t literal, so we use INT64_C(-9223372036854775807)-1 instead.
350NOT_LONG_TEST(ReturnNotINT64_MIN,
351              INT64_C(-9223372036854775807)-1,
352              INT64_C(9223372036854775807));  // (2^63) - 1
353NOT_LONG_TEST(ReturnNotINT64_MINPlus1,
354              INT64_C(-9223372036854775807),
355              INT64_C(9223372036854775806));  // (2^63) - 2
356NOT_LONG_TEST(ReturnNotLongINT64_MAXMinus1,
357              INT64_C(9223372036854775806),
358              INT64_C(-9223372036854775807));  // -(2^63) - 1
359NOT_LONG_TEST(ReturnNotLongINT64_MAX,
360              INT64_C(9223372036854775807),
361              INT64_C(-9223372036854775807)-1);  // -(2^63)
362
363#undef NOT_LONG_TEST
364
365#if defined(__aarch64__)
366TEST(CodegenTest, DISABLED_IntToLongOfLongToInt) {
367#else
368TEST(CodegenTest, IntToLongOfLongToInt) {
369#endif
370  const int64_t input = INT64_C(4294967296);             // 2^32
371  const uint16_t word0 = Low16Bits(Low32Bits(input));    // LSW.
372  const uint16_t word1 = High16Bits(Low32Bits(input));
373  const uint16_t word2 = Low16Bits(High32Bits(input));
374  const uint16_t word3 = High16Bits(High32Bits(input));  // MSW.
375  const uint16_t data[] = FIVE_REGISTERS_CODE_ITEM(
376      Instruction::CONST_WIDE | 0 << 8, word0, word1, word2, word3,
377      Instruction::CONST_WIDE | 2 << 8, 1, 0, 0, 0,
378      Instruction::ADD_LONG | 0, 0 << 8 | 2,             // v0 <- 2^32 + 1
379      Instruction::LONG_TO_INT | 4 << 8 | 0 << 12,
380      Instruction::INT_TO_LONG | 2 << 8 | 4 << 12,
381      Instruction::RETURN_WIDE | 2 << 8);
382
383  TestCodeLong(data, true, 1);
384}
385
386TEST(CodegenTest, ReturnAdd1) {
387  const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(
388    Instruction::CONST_4 | 3 << 12 | 0,
389    Instruction::CONST_4 | 4 << 12 | 1 << 8,
390    Instruction::ADD_INT, 1 << 8 | 0,
391    Instruction::RETURN);
392
393  TestCode(data, true, 7);
394}
395
396TEST(CodegenTest, ReturnAdd2) {
397  const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(
398    Instruction::CONST_4 | 3 << 12 | 0,
399    Instruction::CONST_4 | 4 << 12 | 1 << 8,
400    Instruction::ADD_INT_2ADDR | 1 << 12,
401    Instruction::RETURN);
402
403  TestCode(data, true, 7);
404}
405
406TEST(CodegenTest, ReturnAdd3) {
407  const uint16_t data[] = ONE_REGISTER_CODE_ITEM(
408    Instruction::CONST_4 | 4 << 12 | 0 << 8,
409    Instruction::ADD_INT_LIT8, 3 << 8 | 0,
410    Instruction::RETURN);
411
412  TestCode(data, true, 7);
413}
414
415TEST(CodegenTest, ReturnAdd4) {
416  const uint16_t data[] = ONE_REGISTER_CODE_ITEM(
417    Instruction::CONST_4 | 4 << 12 | 0 << 8,
418    Instruction::ADD_INT_LIT16, 3,
419    Instruction::RETURN);
420
421  TestCode(data, true, 7);
422}
423
424TEST(CodegenTest, NonMaterializedCondition) {
425  ArenaPool pool;
426  ArenaAllocator allocator(&pool);
427
428  HGraph* graph = new (&allocator) HGraph(&allocator);
429  HBasicBlock* entry = new (&allocator) HBasicBlock(graph);
430  graph->AddBlock(entry);
431  graph->SetEntryBlock(entry);
432  entry->AddInstruction(new (&allocator) HGoto());
433
434  HBasicBlock* first_block = new (&allocator) HBasicBlock(graph);
435  graph->AddBlock(first_block);
436  entry->AddSuccessor(first_block);
437  HIntConstant* constant0 = new (&allocator) HIntConstant(0);
438  entry->AddInstruction(constant0);
439  HIntConstant* constant1 = new (&allocator) HIntConstant(1);
440  entry->AddInstruction(constant1);
441  HEqual* equal = new (&allocator) HEqual(constant0, constant0);
442  first_block->AddInstruction(equal);
443  first_block->AddInstruction(new (&allocator) HIf(equal));
444
445  HBasicBlock* then = new (&allocator) HBasicBlock(graph);
446  HBasicBlock* else_ = new (&allocator) HBasicBlock(graph);
447  HBasicBlock* exit = new (&allocator) HBasicBlock(graph);
448
449  graph->AddBlock(then);
450  graph->AddBlock(else_);
451  graph->AddBlock(exit);
452  first_block->AddSuccessor(then);
453  first_block->AddSuccessor(else_);
454  then->AddSuccessor(exit);
455  else_->AddSuccessor(exit);
456
457  exit->AddInstruction(new (&allocator) HExit());
458  then->AddInstruction(new (&allocator) HReturn(constant0));
459  else_->AddInstruction(new (&allocator) HReturn(constant1));
460
461  ASSERT_TRUE(equal->NeedsMaterialization());
462  graph->BuildDominatorTree();
463  PrepareForRegisterAllocation(graph).Run();
464  ASSERT_FALSE(equal->NeedsMaterialization());
465
466  auto hook_before_codegen = [](HGraph* graph_in) {
467    HBasicBlock* block = graph_in->GetEntryBlock()->GetSuccessors().Get(0);
468    HParallelMove* move = new (graph_in->GetArena()) HParallelMove(graph_in->GetArena());
469    block->InsertInstructionBefore(move, block->GetLastInstruction());
470  };
471
472  RunCodeOptimized(graph, hook_before_codegen, true, 0);
473}
474
475#define MUL_TEST(TYPE, TEST_NAME)                     \
476  TEST(CodegenTest, Return ## TEST_NAME) {            \
477    const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(  \
478      Instruction::CONST_4 | 3 << 12 | 0,             \
479      Instruction::CONST_4 | 4 << 12 | 1 << 8,        \
480      Instruction::MUL_ ## TYPE, 1 << 8 | 0,          \
481      Instruction::RETURN);                           \
482                                                      \
483    TestCode(data, true, 12);                         \
484  }                                                   \
485                                                      \
486  TEST(CodegenTest, Return ## TEST_NAME ## 2addr) {   \
487    const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(  \
488      Instruction::CONST_4 | 3 << 12 | 0,             \
489      Instruction::CONST_4 | 4 << 12 | 1 << 8,        \
490      Instruction::MUL_ ## TYPE ## _2ADDR | 1 << 12,  \
491      Instruction::RETURN);                           \
492                                                      \
493    TestCode(data, true, 12);                         \
494  }
495
496#if !defined(__aarch64__)
497MUL_TEST(INT, MulInt);
498MUL_TEST(LONG, MulLong);
499#endif
500
501TEST(CodegenTest, ReturnMulIntLit8) {
502  const uint16_t data[] = ONE_REGISTER_CODE_ITEM(
503    Instruction::CONST_4 | 4 << 12 | 0 << 8,
504    Instruction::MUL_INT_LIT8, 3 << 8 | 0,
505    Instruction::RETURN);
506
507  TestCode(data, true, 12);
508}
509
510TEST(CodegenTest, ReturnMulIntLit16) {
511  const uint16_t data[] = ONE_REGISTER_CODE_ITEM(
512    Instruction::CONST_4 | 4 << 12 | 0 << 8,
513    Instruction::MUL_INT_LIT16, 3,
514    Instruction::RETURN);
515
516  TestCode(data, true, 12);
517}
518
519TEST(CodegenTest, MaterializedCondition1) {
520  // Check that condition are materialized correctly. A materialized condition
521  // should yield `1` if it evaluated to true, and `0` otherwise.
522  // We force the materialization of comparisons for different combinations of
523  // inputs and check the results.
524
525  int lhs[] = {1, 2, -1, 2, 0xabc};
526  int rhs[] = {2, 1, 2, -1, 0xabc};
527
528  for (size_t i = 0; i < arraysize(lhs); i++) {
529    ArenaPool pool;
530    ArenaAllocator allocator(&pool);
531    HGraph* graph = new (&allocator) HGraph(&allocator);
532
533    HBasicBlock* entry_block = new (&allocator) HBasicBlock(graph);
534    graph->AddBlock(entry_block);
535    graph->SetEntryBlock(entry_block);
536    entry_block->AddInstruction(new (&allocator) HGoto());
537    HBasicBlock* code_block = new (&allocator) HBasicBlock(graph);
538    graph->AddBlock(code_block);
539    HBasicBlock* exit_block = new (&allocator) HBasicBlock(graph);
540    graph->AddBlock(exit_block);
541    exit_block->AddInstruction(new (&allocator) HExit());
542
543    entry_block->AddSuccessor(code_block);
544    code_block->AddSuccessor(exit_block);
545    graph->SetExitBlock(exit_block);
546
547    HIntConstant cst_lhs(lhs[i]);
548    code_block->AddInstruction(&cst_lhs);
549    HIntConstant cst_rhs(rhs[i]);
550    code_block->AddInstruction(&cst_rhs);
551    HLessThan cmp_lt(&cst_lhs, &cst_rhs);
552    code_block->AddInstruction(&cmp_lt);
553    HReturn ret(&cmp_lt);
554    code_block->AddInstruction(&ret);
555
556    auto hook_before_codegen = [](HGraph* graph_in) {
557      HBasicBlock* block = graph_in->GetEntryBlock()->GetSuccessors().Get(0);
558      HParallelMove* move = new (graph_in->GetArena()) HParallelMove(graph_in->GetArena());
559      block->InsertInstructionBefore(move, block->GetLastInstruction());
560    };
561
562    RunCodeOptimized(graph, hook_before_codegen, true, lhs[i] < rhs[i]);
563  }
564}
565
566TEST(CodegenTest, MaterializedCondition2) {
567  // Check that HIf correctly interprets a materialized condition.
568  // We force the materialization of comparisons for different combinations of
569  // inputs. An HIf takes the materialized combination as input and returns a
570  // value that we verify.
571
572  int lhs[] = {1, 2, -1, 2, 0xabc};
573  int rhs[] = {2, 1, 2, -1, 0xabc};
574
575
576  for (size_t i = 0; i < arraysize(lhs); i++) {
577    ArenaPool pool;
578    ArenaAllocator allocator(&pool);
579    HGraph* graph = new (&allocator) HGraph(&allocator);
580
581    HBasicBlock* entry_block = new (&allocator) HBasicBlock(graph);
582    graph->AddBlock(entry_block);
583    graph->SetEntryBlock(entry_block);
584    entry_block->AddInstruction(new (&allocator) HGoto());
585
586    HBasicBlock* if_block = new (&allocator) HBasicBlock(graph);
587    graph->AddBlock(if_block);
588    HBasicBlock* if_true_block = new (&allocator) HBasicBlock(graph);
589    graph->AddBlock(if_true_block);
590    HBasicBlock* if_false_block = new (&allocator) HBasicBlock(graph);
591    graph->AddBlock(if_false_block);
592    HBasicBlock* exit_block = new (&allocator) HBasicBlock(graph);
593    graph->AddBlock(exit_block);
594    exit_block->AddInstruction(new (&allocator) HExit());
595
596    graph->SetEntryBlock(entry_block);
597    entry_block->AddSuccessor(if_block);
598    if_block->AddSuccessor(if_true_block);
599    if_block->AddSuccessor(if_false_block);
600    if_true_block->AddSuccessor(exit_block);
601    if_false_block->AddSuccessor(exit_block);
602    graph->SetExitBlock(exit_block);
603
604    HIntConstant cst_lhs(lhs[i]);
605    if_block->AddInstruction(&cst_lhs);
606    HIntConstant cst_rhs(rhs[i]);
607    if_block->AddInstruction(&cst_rhs);
608    HLessThan cmp_lt(&cst_lhs, &cst_rhs);
609    if_block->AddInstruction(&cmp_lt);
610    // We insert a temporary to separate the HIf from the HLessThan and force
611    // the materialization of the condition.
612    HTemporary force_materialization(0);
613    if_block->AddInstruction(&force_materialization);
614    HIf if_lt(&cmp_lt);
615    if_block->AddInstruction(&if_lt);
616
617    HIntConstant cst_lt(1);
618    if_true_block->AddInstruction(&cst_lt);
619    HReturn ret_lt(&cst_lt);
620    if_true_block->AddInstruction(&ret_lt);
621    HIntConstant cst_ge(0);
622    if_false_block->AddInstruction(&cst_ge);
623    HReturn ret_ge(&cst_ge);
624    if_false_block->AddInstruction(&ret_ge);
625
626    auto hook_before_codegen = [](HGraph* graph_in) {
627      HBasicBlock* block = graph_in->GetEntryBlock()->GetSuccessors().Get(0);
628      HParallelMove* move = new (graph_in->GetArena()) HParallelMove(graph_in->GetArena());
629      block->InsertInstructionBefore(move, block->GetLastInstruction());
630    };
631
632    RunCodeOptimized(graph, hook_before_codegen, true, lhs[i] < rhs[i]);
633  }
634}
635
636#if defined(__aarch64__)
637TEST(CodegenTest, DISABLED_ReturnDivIntLit8) {
638#else
639TEST(CodegenTest, ReturnDivIntLit8) {
640#endif
641  const uint16_t data[] = ONE_REGISTER_CODE_ITEM(
642    Instruction::CONST_4 | 4 << 12 | 0 << 8,
643    Instruction::DIV_INT_LIT8, 3 << 8 | 0,
644    Instruction::RETURN);
645
646  TestCode(data, true, 1);
647}
648
649#if defined(__aarch64__)
650TEST(CodegenTest, DISABLED_ReturnDivInt2Addr) {
651#else
652TEST(CodegenTest, ReturnDivInt2Addr) {
653#endif
654  const uint16_t data[] = TWO_REGISTERS_CODE_ITEM(
655    Instruction::CONST_4 | 4 << 12 | 0,
656    Instruction::CONST_4 | 2 << 12 | 1 << 8,
657    Instruction::DIV_INT_2ADDR | 1 << 12,
658    Instruction::RETURN);
659
660  TestCode(data, true, 2);
661}
662
663}  // namespace art
664