AnalysisBasedWarnings.cpp revision fcdd2cb2fdf35f806dd800b369fe0772a1c8c26c 
1//=- AnalysisBasedWarnings.cpp - Sema warnings based on libAnalysis -*- C++ -*-=//
2//
3//                     The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines analysis_warnings::[Policy,Executor].
11// Together they are used by Sema to issue warnings based on inexpensive
12// static analysis algorithms in libAnalysis.
13//
14//===----------------------------------------------------------------------===//
15
16#include "clang/Sema/AnalysisBasedWarnings.h"
17#include "clang/Sema/SemaInternal.h"
18#include "clang/Sema/ScopeInfo.h"
19#include "clang/Basic/SourceManager.h"
20#include "clang/Basic/SourceLocation.h"
21#include "clang/Lex/Preprocessor.h"
22#include "clang/AST/DeclObjC.h"
23#include "clang/AST/DeclCXX.h"
24#include "clang/AST/ExprObjC.h"
25#include "clang/AST/ExprCXX.h"
26#include "clang/AST/StmtObjC.h"
27#include "clang/AST/StmtCXX.h"
28#include "clang/AST/EvaluatedExprVisitor.h"
29#include "clang/AST/StmtVisitor.h"
30#include "clang/Analysis/AnalysisContext.h"
31#include "clang/Analysis/CFG.h"
32#include "clang/Analysis/Analyses/ReachableCode.h"
33#include "clang/Analysis/Analyses/CFGReachabilityAnalysis.h"
34#include "clang/Analysis/Analyses/ThreadSafety.h"
35#include "clang/Analysis/CFGStmtMap.h"
36#include "clang/Analysis/Analyses/UninitializedValues.h"
37#include "llvm/ADT/BitVector.h"
38#include "llvm/ADT/FoldingSet.h"
39#include "llvm/ADT/ImmutableMap.h"
40#include "llvm/ADT/PostOrderIterator.h"
41#include "llvm/ADT/SmallVector.h"
42#include "llvm/ADT/StringRef.h"
43#include "llvm/Support/Casting.h"
44#include <algorithm>
45#include <vector>
46
47using namespace clang;
48
49//===----------------------------------------------------------------------===//
50// Unreachable code analysis.
51//===----------------------------------------------------------------------===//
52
53namespace {
54  class UnreachableCodeHandler : public reachable_code::Callback {
55    Sema &S;
56  public:
57    UnreachableCodeHandler(Sema &s) : S(s) {}
58
59    void HandleUnreachable(SourceLocation L, SourceRange R1, SourceRange R2) {
60      S.Diag(L, diag::warn_unreachable) << R1 << R2;
61    }
62  };
63}
64
65/// CheckUnreachable - Check for unreachable code.
66static void CheckUnreachable(Sema &S, AnalysisContext &AC) {
67  UnreachableCodeHandler UC(S);
68  reachable_code::FindUnreachableCode(AC, UC);
69}
70
71//===----------------------------------------------------------------------===//
72// Check for missing return value.
73//===----------------------------------------------------------------------===//
74
75enum ControlFlowKind {
76  UnknownFallThrough,
77  NeverFallThrough,
78  MaybeFallThrough,
79  AlwaysFallThrough,
80  NeverFallThroughOrReturn
81};
82
83/// CheckFallThrough - Check that we don't fall off the end of a
84/// Statement that should return a value.
85///
86/// \returns AlwaysFallThrough iff we always fall off the end of the statement,
87/// MaybeFallThrough iff we might or might not fall off the end,
88/// NeverFallThroughOrReturn iff we never fall off the end of the statement or
89/// return.  We assume NeverFallThrough iff we never fall off the end of the
90/// statement but we may return.  We assume that functions not marked noreturn
91/// will return.
92static ControlFlowKind CheckFallThrough(AnalysisContext &AC) {
93  CFG *cfg = AC.getCFG();
94  if (cfg == 0) return UnknownFallThrough;
95
96  // The CFG leaves in dead things, and we don't want the dead code paths to
97  // confuse us, so we mark all live things first.
98  llvm::BitVector live(cfg->getNumBlockIDs());
99  unsigned count = reachable_code::ScanReachableFromBlock(&cfg->getEntry(),
100                                                          live);
101
102  bool AddEHEdges = AC.getAddEHEdges();
103  if (!AddEHEdges && count != cfg->getNumBlockIDs())
104    // When there are things remaining dead, and we didn't add EH edges
105    // from CallExprs to the catch clauses, we have to go back and
106    // mark them as live.
107    for (CFG::iterator I = cfg->begin(), E = cfg->end(); I != E; ++I) {
108      CFGBlock &b = **I;
109      if (!live[b.getBlockID()]) {
110        if (b.pred_begin() == b.pred_end()) {
111          if (b.getTerminator() && isa<CXXTryStmt>(b.getTerminator()))
112            // When not adding EH edges from calls, catch clauses
113            // can otherwise seem dead.  Avoid noting them as dead.
114            count += reachable_code::ScanReachableFromBlock(&b, live);
115          continue;
116        }
117      }
118    }
119
120  // Now we know what is live, we check the live precessors of the exit block
121  // and look for fall through paths, being careful to ignore normal returns,
122  // and exceptional paths.
123  bool HasLiveReturn = false;
124  bool HasFakeEdge = false;
125  bool HasPlainEdge = false;
126  bool HasAbnormalEdge = false;
127
128  // Ignore default cases that aren't likely to be reachable because all
129  // enums in a switch(X) have explicit case statements.
130  CFGBlock::FilterOptions FO;
131  FO.IgnoreDefaultsWithCoveredEnums = 1;
132
133  for (CFGBlock::filtered_pred_iterator
134	 I = cfg->getExit().filtered_pred_start_end(FO); I.hasMore(); ++I) {
135    const CFGBlock& B = **I;
136    if (!live[B.getBlockID()])
137      continue;
138
139    // Skip blocks which contain an element marked as no-return. They don't
140    // represent actually viable edges into the exit block, so mark them as
141    // abnormal.
142    if (B.hasNoReturnElement()) {
143      HasAbnormalEdge = true;
144      continue;
145    }
146
147    // Destructors can appear after the 'return' in the CFG.  This is
148    // normal.  We need to look pass the destructors for the return
149    // statement (if it exists).
150    CFGBlock::const_reverse_iterator ri = B.rbegin(), re = B.rend();
151
152    for ( ; ri != re ; ++ri)
153      if (isa<CFGStmt>(*ri))
154        break;
155
156    // No more CFGElements in the block?
157    if (ri == re) {
158      if (B.getTerminator() && isa<CXXTryStmt>(B.getTerminator())) {
159        HasAbnormalEdge = true;
160        continue;
161      }
162      // A labeled empty statement, or the entry block...
163      HasPlainEdge = true;
164      continue;
165    }
166
167    CFGStmt CS = cast<CFGStmt>(*ri);
168    const Stmt *S = CS.getStmt();
169    if (isa<ReturnStmt>(S)) {
170      HasLiveReturn = true;
171      continue;
172    }
173    if (isa<ObjCAtThrowStmt>(S)) {
174      HasFakeEdge = true;
175      continue;
176    }
177    if (isa<CXXThrowExpr>(S)) {
178      HasFakeEdge = true;
179      continue;
180    }
181    if (const AsmStmt *AS = dyn_cast<AsmStmt>(S)) {
182      if (AS->isMSAsm()) {
183        HasFakeEdge = true;
184        HasLiveReturn = true;
185        continue;
186      }
187    }
188    if (isa<CXXTryStmt>(S)) {
189      HasAbnormalEdge = true;
190      continue;
191    }
192    if (std::find(B.succ_begin(), B.succ_end(), &cfg->getExit())
193        == B.succ_end()) {
194      HasAbnormalEdge = true;
195      continue;
196    }
197
198    HasPlainEdge = true;
199  }
200  if (!HasPlainEdge) {
201    if (HasLiveReturn)
202      return NeverFallThrough;
203    return NeverFallThroughOrReturn;
204  }
205  if (HasAbnormalEdge || HasFakeEdge || HasLiveReturn)
206    return MaybeFallThrough;
207  // This says AlwaysFallThrough for calls to functions that are not marked
208  // noreturn, that don't return.  If people would like this warning to be more
209  // accurate, such functions should be marked as noreturn.
210  return AlwaysFallThrough;
211}
212
213namespace {
214
215struct CheckFallThroughDiagnostics {
216  unsigned diag_MaybeFallThrough_HasNoReturn;
217  unsigned diag_MaybeFallThrough_ReturnsNonVoid;
218  unsigned diag_AlwaysFallThrough_HasNoReturn;
219  unsigned diag_AlwaysFallThrough_ReturnsNonVoid;
220  unsigned diag_NeverFallThroughOrReturn;
221  bool funMode;
222  SourceLocation FuncLoc;
223
224  static CheckFallThroughDiagnostics MakeForFunction(const Decl *Func) {
225    CheckFallThroughDiagnostics D;
226    D.FuncLoc = Func->getLocation();
227    D.diag_MaybeFallThrough_HasNoReturn =
228      diag::warn_falloff_noreturn_function;
229    D.diag_MaybeFallThrough_ReturnsNonVoid =
230      diag::warn_maybe_falloff_nonvoid_function;
231    D.diag_AlwaysFallThrough_HasNoReturn =
232      diag::warn_falloff_noreturn_function;
233    D.diag_AlwaysFallThrough_ReturnsNonVoid =
234      diag::warn_falloff_nonvoid_function;
235
236    // Don't suggest that virtual functions be marked "noreturn", since they
237    // might be overridden by non-noreturn functions.
238    bool isVirtualMethod = false;
239    if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(Func))
240      isVirtualMethod = Method->isVirtual();
241
242    // Don't suggest that template instantiations be marked "noreturn"
243    bool isTemplateInstantiation = false;
244    if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(Func)) {
245      switch (Function->getTemplateSpecializationKind()) {
246      case TSK_Undeclared:
247      case TSK_ExplicitSpecialization:
248        break;
249
250      case TSK_ImplicitInstantiation:
251      case TSK_ExplicitInstantiationDeclaration:
252      case TSK_ExplicitInstantiationDefinition:
253        isTemplateInstantiation = true;
254        break;
255      }
256    }
257
258    if (!isVirtualMethod && !isTemplateInstantiation)
259      D.diag_NeverFallThroughOrReturn =
260        diag::warn_suggest_noreturn_function;
261    else
262      D.diag_NeverFallThroughOrReturn = 0;
263
264    D.funMode = true;
265    return D;
266  }
267
268  static CheckFallThroughDiagnostics MakeForBlock() {
269    CheckFallThroughDiagnostics D;
270    D.diag_MaybeFallThrough_HasNoReturn =
271      diag::err_noreturn_block_has_return_expr;
272    D.diag_MaybeFallThrough_ReturnsNonVoid =
273      diag::err_maybe_falloff_nonvoid_block;
274    D.diag_AlwaysFallThrough_HasNoReturn =
275      diag::err_noreturn_block_has_return_expr;
276    D.diag_AlwaysFallThrough_ReturnsNonVoid =
277      diag::err_falloff_nonvoid_block;
278    D.diag_NeverFallThroughOrReturn =
279      diag::warn_suggest_noreturn_block;
280    D.funMode = false;
281    return D;
282  }
283
284  bool checkDiagnostics(DiagnosticsEngine &D, bool ReturnsVoid,
285                        bool HasNoReturn) const {
286    if (funMode) {
287      return (ReturnsVoid ||
288              D.getDiagnosticLevel(diag::warn_maybe_falloff_nonvoid_function,
289                                   FuncLoc) == DiagnosticsEngine::Ignored)
290        && (!HasNoReturn ||
291            D.getDiagnosticLevel(diag::warn_noreturn_function_has_return_expr,
292                                 FuncLoc) == DiagnosticsEngine::Ignored)
293        && (!ReturnsVoid ||
294            D.getDiagnosticLevel(diag::warn_suggest_noreturn_block, FuncLoc)
295              == DiagnosticsEngine::Ignored);
296    }
297
298    // For blocks.
299    return  ReturnsVoid && !HasNoReturn
300            && (!ReturnsVoid ||
301                D.getDiagnosticLevel(diag::warn_suggest_noreturn_block, FuncLoc)
302                  == DiagnosticsEngine::Ignored);
303  }
304};
305
306}
307
308/// CheckFallThroughForFunctionDef - Check that we don't fall off the end of a
309/// function that should return a value.  Check that we don't fall off the end
310/// of a noreturn function.  We assume that functions and blocks not marked
311/// noreturn will return.
312static void CheckFallThroughForBody(Sema &S, const Decl *D, const Stmt *Body,
313                                    const BlockExpr *blkExpr,
314                                    const CheckFallThroughDiagnostics& CD,
315                                    AnalysisContext &AC) {
316
317  bool ReturnsVoid = false;
318  bool HasNoReturn = false;
319
320  if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
321    ReturnsVoid = FD->getResultType()->isVoidType();
322    HasNoReturn = FD->hasAttr<NoReturnAttr>() ||
323       FD->getType()->getAs<FunctionType>()->getNoReturnAttr();
324  }
325  else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
326    ReturnsVoid = MD->getResultType()->isVoidType();
327    HasNoReturn = MD->hasAttr<NoReturnAttr>();
328  }
329  else if (isa<BlockDecl>(D)) {
330    QualType BlockTy = blkExpr->getType();
331    if (const FunctionType *FT =
332          BlockTy->getPointeeType()->getAs<FunctionType>()) {
333      if (FT->getResultType()->isVoidType())
334        ReturnsVoid = true;
335      if (FT->getNoReturnAttr())
336        HasNoReturn = true;
337    }
338  }
339
340  DiagnosticsEngine &Diags = S.getDiagnostics();
341
342  // Short circuit for compilation speed.
343  if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
344      return;
345
346  // FIXME: Function try block
347  if (const CompoundStmt *Compound = dyn_cast<CompoundStmt>(Body)) {
348    switch (CheckFallThrough(AC)) {
349      case UnknownFallThrough:
350        break;
351
352      case MaybeFallThrough:
353        if (HasNoReturn)
354          S.Diag(Compound->getRBracLoc(),
355                 CD.diag_MaybeFallThrough_HasNoReturn);
356        else if (!ReturnsVoid)
357          S.Diag(Compound->getRBracLoc(),
358                 CD.diag_MaybeFallThrough_ReturnsNonVoid);
359        break;
360      case AlwaysFallThrough:
361        if (HasNoReturn)
362          S.Diag(Compound->getRBracLoc(),
363                 CD.diag_AlwaysFallThrough_HasNoReturn);
364        else if (!ReturnsVoid)
365          S.Diag(Compound->getRBracLoc(),
366                 CD.diag_AlwaysFallThrough_ReturnsNonVoid);
367        break;
368      case NeverFallThroughOrReturn:
369        if (ReturnsVoid && !HasNoReturn && CD.diag_NeverFallThroughOrReturn) {
370          if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
371            S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn)
372              << 0 << FD;
373          } else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
374            S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn)
375              << 1 << MD;
376          } else {
377            S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn);
378          }
379        }
380        break;
381      case NeverFallThrough:
382        break;
383    }
384  }
385}
386
387//===----------------------------------------------------------------------===//
388// -Wuninitialized
389//===----------------------------------------------------------------------===//
390
391namespace {
392/// ContainsReference - A visitor class to search for references to
393/// a particular declaration (the needle) within any evaluated component of an
394/// expression (recursively).
395class ContainsReference : public EvaluatedExprVisitor<ContainsReference> {
396  bool FoundReference;
397  const DeclRefExpr *Needle;
398
399public:
400  ContainsReference(ASTContext &Context, const DeclRefExpr *Needle)
401    : EvaluatedExprVisitor<ContainsReference>(Context),
402      FoundReference(false), Needle(Needle) {}
403
404  void VisitExpr(Expr *E) {
405    // Stop evaluating if we already have a reference.
406    if (FoundReference)
407      return;
408
409    EvaluatedExprVisitor<ContainsReference>::VisitExpr(E);
410  }
411
412  void VisitDeclRefExpr(DeclRefExpr *E) {
413    if (E == Needle)
414      FoundReference = true;
415    else
416      EvaluatedExprVisitor<ContainsReference>::VisitDeclRefExpr(E);
417  }
418
419  bool doesContainReference() const { return FoundReference; }
420};
421}
422
423static bool SuggestInitializationFixit(Sema &S, const VarDecl *VD) {
424  // Don't issue a fixit if there is already an initializer.
425  if (VD->getInit())
426    return false;
427
428  // Suggest possible initialization (if any).
429  const char *initialization = 0;
430  QualType VariableTy = VD->getType().getCanonicalType();
431
432  if (VariableTy->isObjCObjectPointerType() ||
433      VariableTy->isBlockPointerType()) {
434    // Check if 'nil' is defined.
435    if (S.PP.getMacroInfo(&S.getASTContext().Idents.get("nil")))
436      initialization = " = nil";
437    else
438      initialization = " = 0";
439  }
440  else if (VariableTy->isRealFloatingType())
441    initialization = " = 0.0";
442  else if (VariableTy->isBooleanType() && S.Context.getLangOptions().CPlusPlus)
443    initialization = " = false";
444  else if (VariableTy->isEnumeralType())
445    return false;
446  else if (VariableTy->isPointerType() || VariableTy->isMemberPointerType()) {
447    if (S.Context.getLangOptions().CPlusPlus0x)
448      initialization = " = nullptr";
449    // Check if 'NULL' is defined.
450    else if (S.PP.getMacroInfo(&S.getASTContext().Idents.get("NULL")))
451      initialization = " = NULL";
452    else
453      initialization = " = 0";
454  }
455  else if (VariableTy->isScalarType())
456    initialization = " = 0";
457
458  if (initialization) {
459    SourceLocation loc = S.PP.getLocForEndOfToken(VD->getLocEnd());
460    S.Diag(loc, diag::note_var_fixit_add_initialization) << VD->getDeclName()
461      << FixItHint::CreateInsertion(loc, initialization);
462    return true;
463  }
464  return false;
465}
466
467/// DiagnoseUninitializedUse -- Helper function for diagnosing uses of an
468/// uninitialized variable. This manages the different forms of diagnostic
469/// emitted for particular types of uses. Returns true if the use was diagnosed
470/// as a warning. If a pariticular use is one we omit warnings for, returns
471/// false.
472static bool DiagnoseUninitializedUse(Sema &S, const VarDecl *VD,
473                                     const Expr *E, bool isAlwaysUninit) {
474  bool isSelfInit = false;
475
476  if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) {
477    if (isAlwaysUninit) {
478      // Inspect the initializer of the variable declaration which is
479      // being referenced prior to its initialization. We emit
480      // specialized diagnostics for self-initialization, and we
481      // specifically avoid warning about self references which take the
482      // form of:
483      //
484      //   int x = x;
485      //
486      // This is used to indicate to GCC that 'x' is intentionally left
487      // uninitialized. Proven code paths which access 'x' in
488      // an uninitialized state after this will still warn.
489      //
490      // TODO: Should we suppress maybe-uninitialized warnings for
491      // variables initialized in this way?
492      if (const Expr *Initializer = VD->getInit()) {
493        if (DRE == Initializer->IgnoreParenImpCasts())
494          return false;
495
496        ContainsReference CR(S.Context, DRE);
497        CR.Visit(const_cast<Expr*>(Initializer));
498        isSelfInit = CR.doesContainReference();
499      }
500      if (isSelfInit) {
501        S.Diag(DRE->getLocStart(),
502               diag::warn_uninit_self_reference_in_init)
503        << VD->getDeclName() << VD->getLocation() << DRE->getSourceRange();
504      } else {
505        S.Diag(DRE->getLocStart(), diag::warn_uninit_var)
506          << VD->getDeclName() << DRE->getSourceRange();
507      }
508    } else {
509      S.Diag(DRE->getLocStart(), diag::warn_maybe_uninit_var)
510        << VD->getDeclName() << DRE->getSourceRange();
511    }
512  } else {
513    const BlockExpr *BE = cast<BlockExpr>(E);
514    S.Diag(BE->getLocStart(),
515           isAlwaysUninit ? diag::warn_uninit_var_captured_by_block
516                          : diag::warn_maybe_uninit_var_captured_by_block)
517      << VD->getDeclName();
518  }
519
520  // Report where the variable was declared when the use wasn't within
521  // the initializer of that declaration & we didn't already suggest
522  // an initialization fixit.
523  if (!isSelfInit && !SuggestInitializationFixit(S, VD))
524    S.Diag(VD->getLocStart(), diag::note_uninit_var_def)
525      << VD->getDeclName();
526
527  return true;
528}
529
530typedef std::pair<const Expr*, bool> UninitUse;
531
532namespace {
533struct SLocSort {
534  bool operator()(const UninitUse &a, const UninitUse &b) {
535    SourceLocation aLoc = a.first->getLocStart();
536    SourceLocation bLoc = b.first->getLocStart();
537    return aLoc.getRawEncoding() < bLoc.getRawEncoding();
538  }
539};
540
541class UninitValsDiagReporter : public UninitVariablesHandler {
542  Sema &S;
543  typedef SmallVector<UninitUse, 2> UsesVec;
544  typedef llvm::DenseMap<const VarDecl *, UsesVec*> UsesMap;
545  UsesMap *uses;
546
547public:
548  UninitValsDiagReporter(Sema &S) : S(S), uses(0) {}
549  ~UninitValsDiagReporter() {
550    flushDiagnostics();
551  }
552
553  void handleUseOfUninitVariable(const Expr *ex, const VarDecl *vd,
554                                 bool isAlwaysUninit) {
555    if (!uses)
556      uses = new UsesMap();
557
558    UsesVec *&vec = (*uses)[vd];
559    if (!vec)
560      vec = new UsesVec();
561
562    vec->push_back(std::make_pair(ex, isAlwaysUninit));
563  }
564
565  void flushDiagnostics() {
566    if (!uses)
567      return;
568
569    for (UsesMap::iterator i = uses->begin(), e = uses->end(); i != e; ++i) {
570      const VarDecl *vd = i->first;
571      UsesVec *vec = i->second;
572
573      // Sort the uses by their SourceLocations.  While not strictly
574      // guaranteed to produce them in line/column order, this will provide
575      // a stable ordering.
576      std::sort(vec->begin(), vec->end(), SLocSort());
577
578      for (UsesVec::iterator vi = vec->begin(), ve = vec->end(); vi != ve;
579           ++vi) {
580        if (DiagnoseUninitializedUse(S, vd, vi->first,
581                                      /*isAlwaysUninit=*/vi->second))
582          // Skip further diagnostics for this variable. We try to warn only on
583          // the first point at which a variable is used uninitialized.
584          break;
585      }
586
587      delete vec;
588    }
589    delete uses;
590  }
591};
592}
593
594
595//===----------------------------------------------------------------------===//
596// -Wthread-safety
597//===----------------------------------------------------------------------===//
598namespace clang {
599namespace thread_safety {
600typedef std::pair<SourceLocation, PartialDiagnostic> DelayedDiag;
601typedef llvm::SmallVector<DelayedDiag, 4> DiagList;
602
603struct SortDiagBySourceLocation {
604  Sema &S;
605  SortDiagBySourceLocation(Sema &S) : S(S) {}
606
607  bool operator()(const DelayedDiag &left, const DelayedDiag &right) {
608    // Although this call will be slow, this is only called when outputting
609    // multiple warnings.
610    return S.getSourceManager().isBeforeInTranslationUnit(left.first,
611                                                          right.first);
612  }
613};
614
615class ThreadSafetyReporter : public clang::thread_safety::ThreadSafetyHandler {
616  Sema &S;
617  DiagList Warnings;
618
619  // Helper functions
620  void warnLockMismatch(unsigned DiagID, Name LockName, SourceLocation Loc) {
621    PartialDiagnostic Warning = S.PDiag(DiagID) << LockName;
622    Warnings.push_back(DelayedDiag(Loc, Warning));
623  }
624
625 public:
626  ThreadSafetyReporter(Sema &S) : S(S) {}
627
628  /// \brief Emit all buffered diagnostics in order of sourcelocation.
629  /// We need to output diagnostics produced while iterating through
630  /// the lockset in deterministic order, so this function orders diagnostics
631  /// and outputs them.
632  void emitDiagnostics() {
633    SortDiagBySourceLocation SortDiagBySL(S);
634    sort(Warnings.begin(), Warnings.end(), SortDiagBySL);
635    for (DiagList::iterator I = Warnings.begin(), E = Warnings.end();
636         I != E; ++I)
637      S.Diag(I->first, I->second);
638  }
639
640  void handleInvalidLockExp(SourceLocation Loc) {
641    PartialDiagnostic Warning = S.PDiag(diag::warn_cannot_resolve_lock) << Loc;
642    Warnings.push_back(DelayedDiag(Loc, Warning));
643  }
644  void handleUnmatchedUnlock(Name LockName, SourceLocation Loc) {
645    warnLockMismatch(diag::warn_unlock_but_no_lock, LockName, Loc);
646  }
647
648  void handleDoubleLock(Name LockName, SourceLocation Loc) {
649    warnLockMismatch(diag::warn_double_lock, LockName, Loc);
650  }
651
652  void handleMutexHeldEndOfScope(Name LockName, SourceLocation Loc,
653                                 LockErrorKind LEK){
654    unsigned DiagID = 0;
655    switch (LEK) {
656      case LEK_LockedSomePredecessors:
657        DiagID = diag::warn_lock_at_end_of_scope;
658        break;
659      case LEK_LockedSomeLoopIterations:
660        DiagID = diag::warn_expecting_lock_held_on_loop;
661        break;
662      case LEK_LockedAtEndOfFunction:
663        DiagID = diag::warn_no_unlock;
664        break;
665    }
666    warnLockMismatch(DiagID, LockName, Loc);
667  }
668
669
670  void handleExclusiveAndShared(Name LockName, SourceLocation Loc1,
671                                SourceLocation Loc2) {
672    PartialDiagnostic Warning =
673      S.PDiag(diag::warn_lock_exclusive_and_shared) << LockName;
674    PartialDiagnostic Note =
675      S.PDiag(diag::note_lock_exclusive_and_shared) << LockName;
676    Warnings.push_back(DelayedDiag(Loc1, Warning));
677    Warnings.push_back(DelayedDiag(Loc2, Note));
678  }
679
680  void handleNoMutexHeld(const NamedDecl *D, ProtectedOperationKind POK,
681                         AccessKind AK, SourceLocation Loc) {
682    assert((POK == POK_VarAccess || POK == POK_VarDereference)
683             && "Only works for variables");
684    unsigned DiagID = POK == POK_VarAccess?
685                        diag::warn_variable_requires_any_lock:
686                        diag::warn_var_deref_requires_any_lock;
687    PartialDiagnostic Warning = S.PDiag(DiagID)
688      << D->getName() << getLockKindFromAccessKind(AK);
689    Warnings.push_back(DelayedDiag(Loc, Warning));
690  }
691
692  void handleMutexNotHeld(const NamedDecl *D, ProtectedOperationKind POK,
693                          Name LockName, LockKind LK, SourceLocation Loc) {
694    unsigned DiagID = 0;
695    switch (POK) {
696      case POK_VarAccess:
697        DiagID = diag::warn_variable_requires_lock;
698        break;
699      case POK_VarDereference:
700        DiagID = diag::warn_var_deref_requires_lock;
701        break;
702      case POK_FunctionCall:
703        DiagID = diag::warn_fun_requires_lock;
704        break;
705    }
706    PartialDiagnostic Warning = S.PDiag(DiagID)
707      << D->getName() << LockName << LK;
708    Warnings.push_back(DelayedDiag(Loc, Warning));
709  }
710
711  void handleFunExcludesLock(Name FunName, Name LockName, SourceLocation Loc) {
712    PartialDiagnostic Warning =
713      S.PDiag(diag::warn_fun_excludes_mutex) << FunName << LockName;
714    Warnings.push_back(DelayedDiag(Loc, Warning));
715  }
716};
717}
718}
719
720//===----------------------------------------------------------------------===//
721// AnalysisBasedWarnings - Worker object used by Sema to execute analysis-based
722//  warnings on a function, method, or block.
723//===----------------------------------------------------------------------===//
724
725clang::sema::AnalysisBasedWarnings::Policy::Policy() {
726  enableCheckFallThrough = 1;
727  enableCheckUnreachable = 0;
728  enableThreadSafetyAnalysis = 0;
729}
730
731clang::sema::AnalysisBasedWarnings::AnalysisBasedWarnings(Sema &s)
732  : S(s),
733    NumFunctionsAnalyzed(0),
734    NumFunctionsWithBadCFGs(0),
735    NumCFGBlocks(0),
736    MaxCFGBlocksPerFunction(0),
737    NumUninitAnalysisFunctions(0),
738    NumUninitAnalysisVariables(0),
739    MaxUninitAnalysisVariablesPerFunction(0),
740    NumUninitAnalysisBlockVisits(0),
741    MaxUninitAnalysisBlockVisitsPerFunction(0) {
742  DiagnosticsEngine &D = S.getDiagnostics();
743  DefaultPolicy.enableCheckUnreachable = (unsigned)
744    (D.getDiagnosticLevel(diag::warn_unreachable, SourceLocation()) !=
745        DiagnosticsEngine::Ignored);
746  DefaultPolicy.enableThreadSafetyAnalysis = (unsigned)
747    (D.getDiagnosticLevel(diag::warn_double_lock, SourceLocation()) !=
748     DiagnosticsEngine::Ignored);
749
750}
751
752static void flushDiagnostics(Sema &S, sema::FunctionScopeInfo *fscope) {
753  for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
754       i = fscope->PossiblyUnreachableDiags.begin(),
755       e = fscope->PossiblyUnreachableDiags.end();
756       i != e; ++i) {
757    const sema::PossiblyUnreachableDiag &D = *i;
758    S.Diag(D.Loc, D.PD);
759  }
760}
761
762void clang::sema::
763AnalysisBasedWarnings::IssueWarnings(sema::AnalysisBasedWarnings::Policy P,
764                                     sema::FunctionScopeInfo *fscope,
765                                     const Decl *D, const BlockExpr *blkExpr) {
766
767  // We avoid doing analysis-based warnings when there are errors for
768  // two reasons:
769  // (1) The CFGs often can't be constructed (if the body is invalid), so
770  //     don't bother trying.
771  // (2) The code already has problems; running the analysis just takes more
772  //     time.
773  DiagnosticsEngine &Diags = S.getDiagnostics();
774
775  // Do not do any analysis for declarations in system headers if we are
776  // going to just ignore them.
777  if (Diags.getSuppressSystemWarnings() &&
778      S.SourceMgr.isInSystemHeader(D->getLocation()))
779    return;
780
781  // For code in dependent contexts, we'll do this at instantiation time.
782  if (cast<DeclContext>(D)->isDependentContext())
783    return;
784
785  if (Diags.hasErrorOccurred() || Diags.hasFatalErrorOccurred()) {
786    // Flush out any possibly unreachable diagnostics.
787    flushDiagnostics(S, fscope);
788    return;
789  }
790
791  const Stmt *Body = D->getBody();
792  assert(Body);
793
794  AnalysisContext AC(D, 0);
795
796  // Don't generate EH edges for CallExprs as we'd like to avoid the n^2
797  // explosion for destrutors that can result and the compile time hit.
798  AC.getCFGBuildOptions().PruneTriviallyFalseEdges = true;
799  AC.getCFGBuildOptions().AddEHEdges = false;
800  AC.getCFGBuildOptions().AddInitializers = true;
801  AC.getCFGBuildOptions().AddImplicitDtors = true;
802
803  // Force that certain expressions appear as CFGElements in the CFG.  This
804  // is used to speed up various analyses.
805  // FIXME: This isn't the right factoring.  This is here for initial
806  // prototyping, but we need a way for analyses to say what expressions they
807  // expect to always be CFGElements and then fill in the BuildOptions
808  // appropriately.  This is essentially a layering violation.
809  if (P.enableCheckUnreachable) {
810    // Unreachable code analysis requires a linearized CFG.
811    AC.getCFGBuildOptions().setAllAlwaysAdd();
812  }
813  else {
814    AC.getCFGBuildOptions()
815      .setAlwaysAdd(Stmt::BinaryOperatorClass)
816      .setAlwaysAdd(Stmt::BlockExprClass)
817      .setAlwaysAdd(Stmt::CStyleCastExprClass)
818      .setAlwaysAdd(Stmt::DeclRefExprClass)
819      .setAlwaysAdd(Stmt::ImplicitCastExprClass)
820      .setAlwaysAdd(Stmt::UnaryOperatorClass);
821  }
822
823  // Construct the analysis context with the specified CFG build options.
824
825  // Emit delayed diagnostics.
826  if (!fscope->PossiblyUnreachableDiags.empty()) {
827    bool analyzed = false;
828
829    // Register the expressions with the CFGBuilder.
830    for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
831         i = fscope->PossiblyUnreachableDiags.begin(),
832         e = fscope->PossiblyUnreachableDiags.end();
833         i != e; ++i) {
834      if (const Stmt *stmt = i->stmt)
835        AC.registerForcedBlockExpression(stmt);
836    }
837
838    if (AC.getCFG()) {
839      analyzed = true;
840      for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
841            i = fscope->PossiblyUnreachableDiags.begin(),
842            e = fscope->PossiblyUnreachableDiags.end();
843            i != e; ++i)
844      {
845        const sema::PossiblyUnreachableDiag &D = *i;
846        bool processed = false;
847        if (const Stmt *stmt = i->stmt) {
848          const CFGBlock *block = AC.getBlockForRegisteredExpression(stmt);
849          assert(block);
850          if (CFGReverseBlockReachabilityAnalysis *cra = AC.getCFGReachablityAnalysis()) {
851            // Can this block be reached from the entrance?
852            if (cra->isReachable(&AC.getCFG()->getEntry(), block))
853              S.Diag(D.Loc, D.PD);
854            processed = true;
855          }
856        }
857        if (!processed) {
858          // Emit the warning anyway if we cannot map to a basic block.
859          S.Diag(D.Loc, D.PD);
860        }
861      }
862    }
863
864    if (!analyzed)
865      flushDiagnostics(S, fscope);
866  }
867
868
869  // Warning: check missing 'return'
870  if (P.enableCheckFallThrough) {
871    const CheckFallThroughDiagnostics &CD =
872      (isa<BlockDecl>(D) ? CheckFallThroughDiagnostics::MakeForBlock()
873                         : CheckFallThroughDiagnostics::MakeForFunction(D));
874    CheckFallThroughForBody(S, D, Body, blkExpr, CD, AC);
875  }
876
877  // Warning: check for unreachable code
878  if (P.enableCheckUnreachable)
879    CheckUnreachable(S, AC);
880
881  // Check for thread safety violations
882  if (P.enableThreadSafetyAnalysis) {
883    thread_safety::ThreadSafetyReporter Reporter(S);
884    thread_safety::runThreadSafetyAnalysis(AC, Reporter);
885    Reporter.emitDiagnostics();
886  }
887
888  if (Diags.getDiagnosticLevel(diag::warn_uninit_var, D->getLocStart())
889      != DiagnosticsEngine::Ignored ||
890      Diags.getDiagnosticLevel(diag::warn_maybe_uninit_var, D->getLocStart())
891      != DiagnosticsEngine::Ignored) {
892    if (CFG *cfg = AC.getCFG()) {
893      UninitValsDiagReporter reporter(S);
894      UninitVariablesAnalysisStats stats;
895      std::memset(&stats, 0, sizeof(UninitVariablesAnalysisStats));
896      runUninitializedVariablesAnalysis(*cast<DeclContext>(D), *cfg, AC,
897                                        reporter, stats);
898
899      if (S.CollectStats && stats.NumVariablesAnalyzed > 0) {
900        ++NumUninitAnalysisFunctions;
901        NumUninitAnalysisVariables += stats.NumVariablesAnalyzed;
902        NumUninitAnalysisBlockVisits += stats.NumBlockVisits;
903        MaxUninitAnalysisVariablesPerFunction =
904            std::max(MaxUninitAnalysisVariablesPerFunction,
905                     stats.NumVariablesAnalyzed);
906        MaxUninitAnalysisBlockVisitsPerFunction =
907            std::max(MaxUninitAnalysisBlockVisitsPerFunction,
908                     stats.NumBlockVisits);
909      }
910    }
911  }
912
913  // Collect statistics about the CFG if it was built.
914  if (S.CollectStats && AC.isCFGBuilt()) {
915    ++NumFunctionsAnalyzed;
916    if (CFG *cfg = AC.getCFG()) {
917      // If we successfully built a CFG for this context, record some more
918      // detail information about it.
919      NumCFGBlocks += cfg->getNumBlockIDs();
920      MaxCFGBlocksPerFunction = std::max(MaxCFGBlocksPerFunction,
921                                         cfg->getNumBlockIDs());
922    } else {
923      ++NumFunctionsWithBadCFGs;
924    }
925  }
926}
927
928void clang::sema::AnalysisBasedWarnings::PrintStats() const {
929  llvm::errs() << "\n*** Analysis Based Warnings Stats:\n";
930
931  unsigned NumCFGsBuilt = NumFunctionsAnalyzed - NumFunctionsWithBadCFGs;
932  unsigned AvgCFGBlocksPerFunction =
933      !NumCFGsBuilt ? 0 : NumCFGBlocks/NumCFGsBuilt;
934  llvm::errs() << NumFunctionsAnalyzed << " functions analyzed ("
935               << NumFunctionsWithBadCFGs << " w/o CFGs).\n"
936               << "  " << NumCFGBlocks << " CFG blocks built.\n"
937               << "  " << AvgCFGBlocksPerFunction
938               << " average CFG blocks per function.\n"
939               << "  " << MaxCFGBlocksPerFunction
940               << " max CFG blocks per function.\n";
941
942  unsigned AvgUninitVariablesPerFunction = !NumUninitAnalysisFunctions ? 0
943      : NumUninitAnalysisVariables/NumUninitAnalysisFunctions;
944  unsigned AvgUninitBlockVisitsPerFunction = !NumUninitAnalysisFunctions ? 0
945      : NumUninitAnalysisBlockVisits/NumUninitAnalysisFunctions;
946  llvm::errs() << NumUninitAnalysisFunctions
947               << " functions analyzed for uninitialiazed variables\n"
948               << "  " << NumUninitAnalysisVariables << " variables analyzed.\n"
949               << "  " << AvgUninitVariablesPerFunction
950               << " average variables per function.\n"
951               << "  " << MaxUninitAnalysisVariablesPerFunction
952               << " max variables per function.\n"
953               << "  " << NumUninitAnalysisBlockVisits << " block visits.\n"
954               << "  " << AvgUninitBlockVisitsPerFunction
955               << " average block visits per function.\n"
956               << "  " << MaxUninitAnalysisBlockVisitsPerFunction
957               << " max block visits per function.\n";
958}
959