| 28b1252bab2915a028a3c9da3e8a64c89e3b8d9d |
|
08-Mar-2017 |
Brian Osman <brianosman@google.com> |
Added MSAA selection to viewer GUI
On Windows, we need to reconstruct the window to allow setting a new
pixel format with a different sample count.
Added some code that maintains window size/position across these changes.
Previously, just cycling through backends would cause the window to move,
as the "default" position would cycle across the screen. Now it's pinned.
BUG=skia:
Change-Id: Iecbe7a490577382043ffe5a88c910b4c0be2ed5c
Reviewed-on: https://skia-review.googlesource.com/9085
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 4749b8c1b899f9f4e440f60c88c880a8765e6dee |
|
08-Mar-2017 |
Brian Osman <brianosman@google.com> |
Maintain window position and size when re-created
Eliminates a UI oddity on Windows when cycling through backends.
BUG=skia:
Change-Id: I83f0325054def80bb9b6e5a9886461f8aad215ae
Reviewed-on: https://skia-review.googlesource.com/9453
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 578f064a60b63ddfb00831e9e59a47060bfcefe0 |
|
25-Feb-2017 |
csmartdalton <csmartdalton@google.com> |
Add msaa flag and UI to viewer
BUG=skia:
Change-Id: I0a24d5e6a4271f84ea5c82eb6d9ede9a1e63f86a
Reviewed-on: https://skia-review.googlesource.com/8787
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 443ec1b794ec5ec8a155a9cdc641e95a95914533 |
|
24-Feb-2017 |
Christopher Dalton <csmartdalton@google.com> |
Add onBackendCreated callback to Viewer
Also removes fWidth and fHeight from Window and instead
calls into WindowContent to get these values.
BUG=skia:
Change-Id: I72ee506004b7da73db9abb607a3bc82edfcf7d43
Reviewed-on: https://skia-review.googlesource.com/8795
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 79086b94eda7c46c37e1cf4395eb75ef54807e3c |
|
10-Feb-2017 |
Brian Osman <brianosman@google.com> |
Integrate the ImGui library with viewer
Code and docs are at: https://github.com/ocornut/imgui
ImGui is an open source immediate mode GUI library that's
lightweight and fairly simply to integrate. Widget functions
return their state, and the library emits vertex and index
data to render everything. It's got a huge set of built-in
widgets and really robust layout control.
For the initial integration, I had to fix up event handling
in the viewer's app framework (to get mouse wheel and more
keys, etc...).
The new viewer 'Debug' window is toggled with the space bar.
For this change, I've added one feature to that window: the
slide picker. It's got a list of all slides, with filtering
support, and the ability to click to switch slides.
I also included the ImGui 'Demo' window (toggled with 'g').
This is nicely laid out, and includes examples of pretty
much everything the library can do. It also serves as good
documentation - find something that looks like what you want,
and then go look at the corresponding code (all of it is in
imgui_demo.cpp).
I have other CLs with other features (like directly editing
the primaries of the working color space), but I wanted to
land this chunk first, then start adding more features.
Other than adding new debugging features, there are few
more outstanding work items:
1) Raster doesn't render the GUI correctly, due to non-
invertible pos -> UV matrices. Florin is working on that.
2) Touch inputs aren't being routed yet, so the GUI isn't
usable on Android yet. Might also be tough to work with,
given the size.
3) ImGui has clipboard integration (that's why it wants
the C, X, and V keys), but we need to wire it up to the
OS' clipboard functions.
4) Draw commands can carry a void* payload to support
drawing images (using whatever mechanism the engine has).
I'd like to set that up (probably using SkImage*), which
makes it really easy to add visualization of off-screen
images in GMs, etc...
BUG=skia:
Change-Id: Iac2a63e37228d33141cb55b7e4d60bf11b7e9ae1
Reviewed-on: https://skia-review.googlesource.com/7702
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| b8794ccea2163c780760b6e0f7ebd022f2c85d33 |
|
27-Jul-2016 |
jvanverth <jvanverth@google.com> |
Enable backend switching for Windows Viewer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184163003
Review-Url: https://codereview.chromium.org/2184163003
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| ccde4ab8e6f5d9f0634d7f156dc1617fd0e48581 |
|
27-Jul-2016 |
bsalomon <bsalomon@google.com> |
SW backend for viewer on Windows
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182273002
Review-Url: https://codereview.chromium.org/2182273002
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| d1bdd1fcbd308afb9903f39d231742f5c951cf07 |
|
26-Jul-2016 |
bsalomon <bsalomon@google.com> |
Use Windowing system-specific WindowContext factories.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169543002
Review-Url: https://codereview.chromium.org/2169543002
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 063ece71848fadc963cbac5c978cd48262138131 |
|
17-Jun-2016 |
jvanverth <jvanverth@google.com> |
Enable viewer in non-Vulkan builds
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
Committed: https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b
Review-Url: https://codereview.chromium.org/2067023002
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 963632f686cd642344429f64e6a53262fe592828 |
|
15-Jun-2016 |
egdaniel <egdaniel@google.com> |
Revert of Enable viewer in non-Vulkan builds (patchset #2 id:20001 of https://codereview.chromium.org/2067023002/ )
Reason for revert:
breaking compile bots
Original issue's description:
> Enable viewer in non-Vulkan builds
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
>
> Committed: https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b
TBR=djsollen@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2072563002
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 746b792a9aad1230ab69158a51c49b2e5437d95b |
|
15-Jun-2016 |
jvanverth <jvanverth@google.com> |
Enable viewer in non-Vulkan builds
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
Review-Url: https://codereview.chromium.org/2067023002
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 566c8e4a36c51cb24d8bb97cc71b3eb26737c012 |
|
23-May-2016 |
liyuqian <liyuqian@google.com> |
Move inval dedup to Window for wider usages.
It turns out that the inval dedup is not just useful for Android. Hence
we move it up to the Window level so more OSes such as Linux, Windows
can also use it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2001153002
Review-Url: https://codereview.chromium.org/2001153002
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| af236b5aa9e7d71d59bee6533d16deb76e9d098b |
|
20-May-2016 |
jvanverth <jvanverth@google.com> |
Add OpenGL context to Viewer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003
Committed: https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
Review-Url: https://codereview.chromium.org/1978573003
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 2884e9c0bd2cc9634a4b932d4142840c67227a78 |
|
18-May-2016 |
jvanverth <jvanverth@google.com> |
Revert of Add OpenGL context to Viewer. (patchset #7 id:120001 of https://codereview.chromium.org/1978573003/ )
Reason for revert:
sk_app/WindowContext.cpp is missing. Need to add file and resubmit.
Original issue's description:
> Add OpenGL context to Viewer.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003
>
> Committed: https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
TBR=brianosman@google.com,bsalomon@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/1990893002
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 56a11e4d6f3d436a3c2497c9c9e71a117d78a93f |
|
17-May-2016 |
jvanverth <jvanverth@google.com> |
Add OpenGL context to Viewer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003
Review-Url: https://codereview.chromium.org/1978573003
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 622c8d5de12f264e496e8d4664a2eea9333922d0 |
|
10-May-2016 |
brianosman <brianosman@google.com> |
Add flexible keybinding/command system to sk_app.
Viewer demonstrates use: Just create an instance of CommandSet,
register with the window, and add commands. Hopefully, we can keep
all commands in one place, and get some nice side-benefits. With
this framework, if you want to add a new command, you are only
required to add code in ONE place. And you get added to the help
screen, for free.
CommandSet automatically binds 'h' to cycle through the help modes.
(Functional grouping is most useful for general use, but the other
mode is nice to know what a key does, or to find an unused key for
a new feature).
Grouped by function: https://screenshot.googleplex.com/G5h3f52wFKu.png
Alphabetical by key: https://screenshot.googleplex.com/nZiopabLKJ6.png
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955293002
Review-Url: https://codereview.chromium.org/1955293002
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| 05de216ffb864cb1f3a4fa37a2c3a772be38a0c9 |
|
06-May-2016 |
brianosman <brianosman@google.com> |
Add sRGB mode toggle to Viewer.
Unlike SampleApp, this just switches out the format of the window
surface (and then adjusts the gamma-correct flag on the SkSurfaces).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950983007
Review-Url: https://codereview.chromium.org/1950983007
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|
| a8d0d6c8bad00e713bc33e5f0d47ca4fec104433 |
|
05-May-2016 |
jvanverth <jvanverth@google.com> |
More refactoring for Viewer
* Move support files into sk_app and main files up to top directory
* Rename VulkanTestContext and create WindowContext parent class
* Place VulkanWindowContext et al. in sk_app namespace.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1944413005
Review-Url: https://codereview.chromium.org/1944413005
/external/skia/tools/viewer/sk_app/win/Window_win.cpp
|