| e2976c87f7ba627fa1e1246f0ccfb34b4b9f3a73 |
|
04-Jan-2016 |
Peter Boström <pbos@webrtc.org> |
Remove DISABLED_ON_ macros.
Macro incorrectly displays DISABLED_ON_ANDROID in test names for
parameterized tests under --gtest_list_tests, causing tests to be
disabled on all platforms since they contain the DISABLED_ prefix rather
than their expanded variants.
This expands the macro variants to inline if they're disabled or not,
and removes building some tests under configurations where they should
fail, instead of building them but disabling them by default.
The change also removes gtest_disable.h as an unused include from many
other files.
BUG=webrtc:5387, webrtc:5400
R=kjellander@webrtc.org, phoglund@webrtc.org
TBR=henrik.lundin@webrtc.org
Review URL: https://codereview.webrtc.org/1547343002 .
Cr-Commit-Position: refs/heads/master@{#11150}
/external/webrtc/webrtc/base/thread_unittest.cc
|
| 8c38e8b9b96d72317d6ce94c1442113b4e385dcb |
|
26-Nov-2015 |
Peter Boström <pbos@webrtc.org> |
Clean up PlatformThread.
* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.
BUG=
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1476453002 .
Cr-Commit-Position: refs/heads/master@{#10812}
/external/webrtc/webrtc/base/thread_unittest.cc
|
| d9b75bef5d0749ea94b31cedab0105c241938954 |
|
16-Nov-2015 |
nisse <nisse@webrtc.org> |
Fix a data race in the thread unit tests.
The flag used in thread_unittest.cc:FunctorB is subject to a (mostly
harmless) data race. In a tsan build, reproduce using
out/Release/rtc_unittests --gtest_filter=AsyncInvokeTest.FireAndForget
There are additional tsan warnings, not all deterministic, when
running all the rtc_unittets: Some data races related to destructors,
and a locking-order-inversion warning. Hence applying this patch does
not make the unit tests tsan-clean.
I should also add that this is my very first cl, so I'm not at all
familiar with the process.
Review URL: https://codereview.webrtc.org/1439613004
Cr-Commit-Position: refs/heads/master@{#10645}
/external/webrtc/webrtc/base/thread_unittest.cc
|
| 0c4e06b4c6107a1b94f764e279e4fb4161e905b0 |
|
07-Oct-2015 |
Peter Boström <pbos@webrtc.org> |
Use suffixed {uint,int}{8,16,32,64}_t types.
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
/external/webrtc/webrtc/base/thread_unittest.cc
|
| a1f590f3b6d317047d28b6568d1229973bb93f29 |
|
20-Aug-2015 |
Magnus Jedvert <magjed@webrtc.org> |
Add helper class GuardedAsyncInvoker to protect against thread dying
BUG=webrtc:4909
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1303443003 .
Cr-Commit-Position: refs/heads/master@{#9745}
/external/webrtc/webrtc/base/thread_unittest.cc
|
| e93cbd13d51c59763476528bb2232903504f7457 |
|
15-Oct-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Fix data races in ThreadTest.ThreeThreadsInvoke.
R=henrike@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/26819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7457 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| c732a3e5113bd64c85eeefa7a2ed3a5076e3db87 |
|
10-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Re-enable allmost all base tests.
BUG=3836
R=marpan@google.com
Review URL: https://webrtc-codereview.appspot.com/22989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7416 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| e30dab77dfaf4a156b50c899246c3734152d11b2 |
|
09-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
base/thread_unittest: wrap test was setting current thread to NULL.
This broke unittests following ThreadTest.Wrap
BUG=3836
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28689004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7413 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| 3987b6de506a7e72a5bdfdf8c8ad9964705c5a28 |
|
24-Sep-2014 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Fix a problem in Thread::Send.
Previously if thread A->Send is called on thread B, B->ReceiveSends will be called, which enables an arbitrary thread to invoke calls on B while B is wait for A->Send to return. This caused mutliple problems like issue 3559, 3579.
The fix is to limit B->ReceiveSends to only process requests from A.
Also disallow the worker thread invoking other threads.
BUG=3559
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7290 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| 95705602bd47a619aea0388ebe969103a1c0cdc3 |
|
19-Sep-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Additional disabled tests in rtc_unittests.
It appears https://review.webrtc.org/27559004/
not enough to get rtc_unittests up and running.
It's currently failing on Linux 32, Linux ASan
and Win SyzyASan bots.
BUG=3836
TBR=henrike@webrtc.org
TEST=Locally passing rtc_unittests on Linux Release
build with asan=1 and lsan=1 in GYP_DEFINES.
Review URL: https://webrtc-codereview.appspot.com/24659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7242 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| fded02c164ea4cc3d28d7f30ac9ce9d94d76ef7a |
|
19-Sep-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
base: disabled several base tests on Mac so that rtc_unittests can be turned back on
BUG=N/A
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7240 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| ba737cba1aa6607911b1ca10460423b4c3e51fb9 |
|
18-Sep-2014 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Do not require synchronization access on the thread if called from rtc::Thread::WrapCurrent.
The synchronization access is unnecessary for rtc::Thread::WrapCurrent (called from JingleThreadWrapper) since JingleThreadWrapper never calls rtc::Thread::Stop or rtc::Thread::Join. Failing to get the access caused crashes in Chrome since rtc::Thread::Current will be NULL when rtc::Thread::WrapCurrent fails.
rtc::ThreadManager::WrapCurrentThread still requires the synchronization access, since I am not sure if the callers (e.g. the plugin) depends on it.
BUG=crbug/413853
R=juberti@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7224 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| e5063b173303e9ee6c2246d2aa42a1480902b867 |
|
23-May-2014 |
fischman@webrtc.org <fischman@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Thread: delete racy API (Release()) and fix racy code (started()).
- Thread::Release() wrote a local variable on the calling thread but read it on
another thread, with no synchronization. Happily it has no non-test callers
so deleting it instead of trying to fix it (see bug for details).
- Thread::started_ similarly was racily being written to; replaced with a
running_ Event, and hid the accessor except for tests & legacy callers,
with a note about why it's a bad idea.
webrtc/base patched with:
git diff origin --relative=talk/base | patch -p1 -dwebrtc/base
followed by manual merge of 3 thunks that ran afoul of naming differences
between talk/base and webrtc/base.
BUG=3388
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14589005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6236 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| f048872e915a3ee229044ec4bc541f6cbf9e4de1 |
|
13-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in
migrating talk/base to webrtc/base.
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| e9a604accd54ab14dbf98f99ccdcf3ae1c54d27c |
|
13-May-2014 |
perkj@webrtc.org <perkj@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.
http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457
> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|
| 2c7d1b39b9374d2bc9bda4755fd4813db66a135c |
|
12-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/thread_unittest.cc
|